Re: [PATCH] vnc: add qmp to support change authz

2021-01-11 Thread Gerd Hoffmann
> >> +{ 'command': 'change-vnc-authz', > >> + 'data': { 'type' : 'str', > >> +'index': 'str'}, > >> + 'if': 'defined(CONFIG_VNC_SASL)' } > > > > type should be an enum I think. > It is a good idea to set type to enum, I will fix it in the next version. > > > Also index should be an

Re: [PATCH] vhost-user-fs: add the "bootindex" property

2021-01-11 Thread Laszlo Ersek
Ping On 01/04/21 14:24, Laszlo Ersek wrote: > virtio-fs qualifies as a bootable device minimally under OVMF, but > currently the necessary "bootindex" property is missing (fw_cfg kernel > boot notwithstanding). > > Add the property. For completeness, add it to the CCW device as well; > other virt

Re: [PATCH v8 5/7] fuzz: set bits in operand of write/out to zero

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/11/21 7:11 AM, Qiuhao Li wrote: > Simplifying the crash cases by opportunistically setting bits in operands of > out/write to zero may help to debug, since usually bit one means turn on or > trigger a function while zero is the default turn-off setting. > > Tested Bug 1908062. Please use the

Re: [PATCH] hw/block/nvme: add smart_critical_warning property

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/11/21 8:50 AM, zhenwei pi wrote: > There is a very low probability that hitting physical NVMe disk > hardware critical warning case, it's hard to write & test a monitor > agent service. > > For debugging purposes, add a new 'smart_critical_warning' property > to emulate this situation. > > T

Re: [PATCH v2 0/4] s390x/tcg: fix booting Linux kernels compiled with clang-11 and clang-12

2021-01-11 Thread David Hildenbrand
On 08.01.21 20:21, Guenter Roeck wrote: > On 1/8/21 5:20 AM, David Hildenbrand wrote: >> This series fixes booting current upstream Linux kernel compiled by >> clang-11 and clang-12 under TCG. >> >> Decided to pull in already separatly sent patches. The last patch is >> not required to fix the boot

Re: [PATCH] target/i386: Use X86Seg enum for segment registers

2021-01-11 Thread Paolo Bonzini
On 10/01/21 00:34, Philippe Mathieu-Daudé wrote: Use the dedicated X86Seg enum type for segment registers. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu.h| 4 ++-- target/i386/gdbstub.c| 2 +- target/i386/tcg/seg_helper.c | 8 target/i386/tcg/transl

Re: [PATCH] hw/block/nvme: add smart_critical_warning property

2021-01-11 Thread Klaus Jensen
On Jan 11 10:14, Philippe Mathieu-Daudé wrote: > On 1/11/21 8:50 AM, zhenwei pi wrote: > > There is a very low probability that hitting physical NVMe disk > > hardware critical warning case, it's hard to write & test a monitor > > agent service. > > > > For debugging purposes, add a new 'smart_cri

Re: [PATCH v8 5/7] fuzz: set bits in operand of write/out to zero

2021-01-11 Thread Qiuhao Li
On Mon, 2021-01-11 at 10:01 +0100, Philippe Mathieu-Daudé wrote: > On 1/11/21 7:11 AM, Qiuhao Li wrote: > > Simplifying the crash cases by opportunistically setting bits in > > operands of > > out/write to zero may help to debug, since usually bit one means > > turn on or > > trigger a function whi

Re: [PATCH] vhost-user-fs: add the "bootindex" property

2021-01-11 Thread Christian Borntraeger
On 04.01.21 14:24, Laszlo Ersek wrote: > virtio-fs qualifies as a bootable device minimally under OVMF, but > currently the necessary "bootindex" property is missing (fw_cfg kernel > boot notwithstanding). > > Add the property. For completeness, add it to the CCW device as well; > other virtio-

Re: [External] Re: [PATCH] hw/block/nvme: add smart_critical_warning property

2021-01-11 Thread zhenwei pi
On 1/11/21 5:21 PM, Klaus Jensen wrote: On Jan 11 10:14, Philippe Mathieu-Daudé wrote: On 1/11/21 8:50 AM, zhenwei pi wrote: There is a very low probability that hitting physical NVMe disk hardware critical warning case, it's hard to write & test a monitor agent service. For debugging purposes

[PATCH] 9pfs/proxy: Check return value of proxy_marshal()

2021-01-11 Thread Greg Kurz
This should always successfully write exactly two 32-bit integers. Make it clear with an assert(), like v9fs_receive_status() and v9fs_receive_response() already do when unmarshalling the same header. Fixes: Coverity CID 1438968 Signed-off-by: Greg Kurz --- hw/9pfs/9p-proxy.c |3 ++- 1 file

Re: [RFC] Using gitlab for upstream qemu repo?

2021-01-11 Thread Stefan Hajnoczi
On Tue, Jan 05, 2021 at 02:12:59PM +, Peter Maydell wrote: > On Thu, 22 Oct 2020 at 17:48, Paolo Bonzini wrote: > > now that Gitlab is the primary CI infrastructure for QEMU, and that all > > QEMU git repositories (including mirrors) are available on Gitlab, I > > would like to propose that co

Re: [PATCH 4/5] hw/ppc/ppc4xx_pci: Replace pointless warning by assert()

2021-01-11 Thread Philippe Mathieu-Daudé
+Peter On 1/11/21 2:11 AM, Nathan Chancellor wrote: > On Tue, Sep 01, 2020 at 12:40:42PM +0200, Philippe Mathieu-Daudé wrote: >> We call pci_register_root_bus() to register 4 IRQs with the >> ppc4xx_pci_set_irq() handler. As it can only be called with >> values in the [0-4[ range, replace the p

Re: [PATCH] vhost-user-fs: add the "bootindex" property

2021-01-11 Thread Laszlo Ersek
On 01/11/21 10:46, Christian Borntraeger wrote: > > > On 04.01.21 14:24, Laszlo Ersek wrote: >> virtio-fs qualifies as a bootable device minimally under OVMF, but >> currently the necessary "bootindex" property is missing (fw_cfg kernel >> boot notwithstanding). >> >> Add the property. For comple

Re: [PATCH] vhost-user-fs: add the "bootindex" property

2021-01-11 Thread Christian Borntraeger
On 11.01.21 11:05, Laszlo Ersek wrote: > On 01/11/21 10:46, Christian Borntraeger wrote: >> >> >> On 04.01.21 14:24, Laszlo Ersek wrote: >>> virtio-fs qualifies as a bootable device minimally under OVMF, but >>> currently the necessary "bootindex" property is missing (fw_cfg kernel >>> boot notw

Re: [PULL 23/35] hw/intc: Rework Loongson LIOINTC

2021-01-11 Thread BALATON Zoltan
On Mon, 11 Jan 2021, Jiaxun Yang wrote: On Mon, Jan 11, 2021, at 8:36 AM, Huacai Chen wrote: I think R_END should be 0x60, Jiaxun, what do you think? U r right. The manual is misleading. The R_END constant is also used in loongson_liointc_init() for the length of the memory region so you mi

Re: [PATCH v8 5/7] fuzz: set bits in operand of write/out to zero

2021-01-11 Thread Thomas Huth
On 11/01/2021 10.39, Qiuhao Li wrote: On Mon, 2021-01-11 at 10:01 +0100, Philippe Mathieu-Daudé wrote: On 1/11/21 7:11 AM, Qiuhao Li wrote: Simplifying the crash cases by opportunistically setting bits in operands of out/write to zero may help to debug, since usually bit one means turn on or tr

Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge

2021-01-11 Thread BALATON Zoltan
On Mon, 11 Jan 2021, Jiaxun Yang wrote: On Mon, Jan 11, 2021, at 3:25 AM, BALATON Zoltan wrote: On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: +PCI experts On 1/10/21 1:43 AM, BALATON Zoltan wrote: On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: [...] I'm not a PCI expert but my un

Re: [PATCH v3 4/6] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2021-01-11 Thread Laurent Desnogues
On Fri, Jan 8, 2021 at 7:51 PM Leif Lindholm wrote: > > Signed-off-by: Leif Lindholm Reviewed-by: Laurent Desnogues Thanks, Laurent > --- > target/arm/cpu.h | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/target/arm/cpu.h b/target/arm/cpu.h > index

Re: [PATCH v3 3/6] target/arm: make ARMCPU.ctr 64-bit

2021-01-11 Thread Laurent Desnogues
On Fri, Jan 8, 2021 at 7:51 PM Leif Lindholm wrote: > > When FEAT_MTE is implemented, the AArch64 view of CTR_EL0 adds the > TminLine field in bits [37:32]. > Extend the ctr field to be able to hold this context. > > Signed-off-by: Leif Lindholm Reviewed-by: Laurent Desnogues Thanks, Laurent

[PATCH] cirrus.yml: Replace the hard-coded python-sphinx version with the generic one

2021-01-11 Thread Thomas Huth
The mingw-w64-x86_64-python-sphinx-2.3.1 package has been removed from the server, so the windows_msys2_task is currently failing. Replace the old version with the current generic one to fix the issue (the current version seems to work fine now, too). Signed-off-by: Thomas Huth --- Successful ru

Re: [PULL 23/35] hw/intc: Rework Loongson LIOINTC

2021-01-11 Thread Peter Maydell
On Mon, 11 Jan 2021 at 10:20, BALATON Zoltan wrote: > > On Mon, 11 Jan 2021, Jiaxun Yang wrote: > > On Mon, Jan 11, 2021, at 8:36 AM, Huacai Chen wrote: > >> I think R_END should be 0x60, Jiaxun, what do you think? > > > > U r right. > > The manual is misleading. > > The R_END constant is also use

Re: [PULL 23/35] hw/intc: Rework Loongson LIOINTC

2021-01-11 Thread BALATON Zoltan
On Mon, 11 Jan 2021, Peter Maydell wrote: On Mon, 11 Jan 2021 at 10:20, BALATON Zoltan wrote: On Mon, 11 Jan 2021, Jiaxun Yang wrote: On Mon, Jan 11, 2021, at 8:36 AM, Huacai Chen wrote: I think R_END should be 0x60, Jiaxun, what do you think? U r right. The manual is misleading. The R_E

Re: [RFC] Using gitlab for upstream qemu repo?

2021-01-11 Thread Paolo Bonzini
On 11/01/21 10:57, Stefan Hajnoczi wrote: I will send a patch to point .gitmodules at GitLab. In the process of doing this I noticed sgabios.git is not yet mirrored on GitLab. After I create that repo (and any other missing repos) I will send a qemu.git patch series that references the GitLab rep

Re: [PATCH v2 0/4] hw/ppc: Convert UIC device to QOM

2021-01-11 Thread David Gibson
On Fri, Jan 08, 2021 at 05:12:08PM +, Peter Maydell wrote: > This patchseries converts the PPC UIC "Universal Interrupt > Controller" to a QOM device. My main reason for doing it is that > this fixes a couple of long-standing trivial Coverity issues -- the > current ppcuic_init() function allo

Re: [PATCH v8 5/7] fuzz: set bits in operand of write/out to zero

2021-01-11 Thread Qiuhao Li
On Mon, 2021-01-11 at 11:26 +0100, Thomas Huth wrote: > On 11/01/2021 10.39, Qiuhao Li wrote: > > On Mon, 2021-01-11 at 10:01 +0100, Philippe Mathieu-Daudé wrote: > > > On 1/11/21 7:11 AM, Qiuhao Li wrote: > > > > Simplifying the crash cases by opportunistically setting bits > > > > in > > > > oper

Re: [External] Re: [PATCH] hw/block/nvme: add smart_critical_warning property

2021-01-11 Thread Klaus Jensen
On Jan 11 17:49, zhenwei pi wrote: > On 1/11/21 5:21 PM, Klaus Jensen wrote: > > On Jan 11 10:14, Philippe Mathieu-Daudé wrote: > > > On 1/11/21 8:50 AM, zhenwei pi wrote: > > > > There is a very low probability that hitting physical NVMe disk > > > > hardware critical warning case, it's hard to wr

[RHEL7 qemu-kvm PATCH 0/3] Fixing several GCC 11 warnings

2021-01-11 Thread mrezanin
From: Miroslav Rezanina Compiling qemu using GCC 11 we got several new warnings. To allow build with --enable-werror, we need to solve issues generating these warnings. Signed-of-by: Miroslav Rezanina Miroslav Rezanina (3): Fix net.c warning on GCC 11 s390x: Fix vm name copy length Fix t

[RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread mrezanin
From: Miroslav Rezanina There are two cases when vm name is copied but closing \0 can be lost in case name is too long (>=256 characters). Updating length to copy so there is space for closing \0. Signed-off-by: Miroslav Rezanina --- target/s390x/kvm.c | 2 +- target/s390x/misc_helper

[RHEL7 qemu-kvm PATCH 3/3] Fix tcg_out_op argument mismatch warning

2021-01-11 Thread mrezanin
From: Miroslav Rezanina There's prototype mismatch between tcg/tcg.c and tcg/aarch/tcg-target.c.inc: tcg.c: static void tcg_out_op(TCGContext *s, TCGOpcode opc, const TCGArg *args, const int *const_args); tcg-target.c.inc: static void tcg_out_op(TCGContext *

[RHEL7 qemu-kvm PATCH 1/3] Fix net.c warning on GCC 11

2021-01-11 Thread mrezanin
From: Miroslav Rezanina When building qemu with GCC 11, compiling eth.c file produce following warning: warning: array subscript 'struct ip6_ext_hdr_routing[0]' is partly outside array bounds of 'struct ip6_ext_hdr[1]' [-Warray-bounds] This caused by retyping from ip6_ext_hdr to ip6_ext_hdr

Re: [RHEL7 qemu-kvm PATCH 0/3] Fixing several GCC 11 warnings

2021-01-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1610364304.git.mreza...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1610364304.git.mreza...@redhat.com Subject: [RHEL7 qemu-kvm PATCH 0/3] Fixing several

Call for Google Summer of Code 2021 project ideas

2021-01-11 Thread Stefan Hajnoczi
Dear QEMU, KVM, and rust-vmm community, QEMU will apply for Google Summer of Code (https://summerofcode.withgoogle.com/) again this year. This internship program offers paid, 10-week, remote work internships for contributing to open source. QEMU can act as an umbrella organization for KVM kernel

[PATCH 0/6] Update git repo URLs to GitLab

2021-01-11 Thread Stefan Hajnoczi
Several places in qemu.git reference qemu.org git repo URLs. Let's switch to GitLab repo URLs in order to enable GitLab as a gating CI and in order to reduce qemu.org bandwidth consumption. Paolo has already set up GitLab mirror repos. sgabios was missing and I added that today. It is now possible

[PATCH 1/6] .github: point Repo Lockdown bot to GitLab repo

2021-01-11 Thread Stefan Hajnoczi
Use the GitLab repo URL as the main repo location in order to reduce load on qemu.org. Signed-off-by: Stefan Hajnoczi --- .github/lockdown.yml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/lockdown.yml b/.github/lockdown.yml index 9acc393f1c..07fc2f31ee 1006

[PATCH 2/6] gitmodules: use GitLab repos instead of qemu.org

2021-01-11 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi --- .gitmodules | 44 ++-- 1 file changed, 22 insertions(

[PATCH 5/6] pc-bios: update mirror URLs to GitLab

2021-01-11 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi --- pc-bios/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pc-bio

[PATCH 3/6] gitlab-ci: remove redundant GitLab repo URL command

2021-01-11 Thread Stefan Hajnoczi
It is no longer necessary to point .gitmodules at GitLab repos when running in GitLab CI since they are now used all the time. Signed-off-by: Stefan Hajnoczi --- .gitlab-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 01c9e46410..4c2a71b934 100644

[PATCH 4/6] docs: update README to use GitLab repo URLs

2021-01-11 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi --- README.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.rst

[PATCH 6/6] get_maintainer: update repo URL to GitLab

2021-01-11 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi --- scripts/get_maintainer.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH 1/6] .github: point Repo Lockdown bot to GitLab repo

2021-01-11 Thread Daniel P . Berrangé
On Mon, Jan 11, 2021 at 11:50:12AM +, Stefan Hajnoczi wrote: > Use the GitLab repo URL as the main repo location in order to reduce > load on qemu.org. > > Signed-off-by: Stefan Hajnoczi > --- > .github/lockdown.yml | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --

Re: Fwd: VirtioSound device emulation implementation

2021-01-11 Thread Alex Bennée
Shreyansh Chouhan writes: > -- Forwarded message - > From: Shreyansh Chouhan > Date: Mon, 11 Jan 2021 at 11:59 > Subject: Re: VirtioSound device emulation implementation > To: Gerd Hoffmann > > > > > On Sun, 10 Jan 2021 at 13:55, Shreyansh Chouhan < > chouhan.shreyansh2...@gma

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Philippe Mathieu-Daudé
Hi Miroslav, On 1/11/21 12:30 PM, mreza...@redhat.com wrote: > From: Miroslav Rezanina > > There are two cases when vm name is copied but closing \0 can be lost > in case name is too long (>=256 characters). > > Updating length to copy so there is space for closing \0. > > Signed-off-by: Miros

Re: [RHEL7 qemu-kvm PATCH 3/3] Fix tcg_out_op argument mismatch warning

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/11/21 12:30 PM, mreza...@redhat.com wrote: > From: Miroslav Rezanina > > There's prototype mismatch between tcg/tcg.c and tcg/aarch/tcg-target.c.inc: > > tcg.c: > > static void tcg_out_op(TCGContext *s, TCGOpcode opc, const TCGArg *args, >const int *const_ar

Re: [PATCH 2/6] gitmodules: use GitLab repos instead of qemu.org

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/11/21 12:50 PM, Stefan Hajnoczi wrote: > qemu.org is running out of bandwidth and the QEMU project is moving > towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org > (they will become mirrors). > > Signed-off-by: Stefan Hajnoczi > --- > .gitmodules | 44 ++

Re: [PATCH 3/6] gitlab-ci: remove redundant GitLab repo URL command

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/11/21 12:50 PM, Stefan Hajnoczi wrote: > It is no longer necessary to point .gitmodules at GitLab repos when > running in GitLab CI since they are now used all the time. > > Signed-off-by: Stefan Hajnoczi > --- > .gitlab-ci.yml | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Philippe M

Re: [PATCH 6/6] get_maintainer: update repo URL to GitLab

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/11/21 12:50 PM, Stefan Hajnoczi wrote: > qemu.org is running out of bandwidth and the QEMU project is moving > towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org > (they will become mirrors). > > Signed-off-by: Stefan Hajnoczi > --- > scripts/get_maintainer.pl | 2 +- >

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Thomas Huth
On 11/01/2021 13.10, Philippe Mathieu-Daudé wrote: Hi Miroslav, On 1/11/21 12:30 PM, mreza...@redhat.com wrote: From: Miroslav Rezanina There are two cases when vm name is copied but closing \0 can be lost in case name is too long (>=256 characters). Updating length to copy so there is space

[PATCH 2/6] hw/block/nvme: merge implicitly/explicitly opened processing masks

2021-01-11 Thread Klaus Jensen
From: Klaus Jensen Implicitly and explicitly opended zones are always bulk processed together, so merge the two processing masks. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/hw/block/nvme.c b/

[PATCH 0/6] hw/block/nvme: zoned misc fixes

2021-01-11 Thread Klaus Jensen
From: Klaus Jensen These are some follow-up patches to the just merged zoned series. The biggest addition here is asynchronous zeroing of zones on reset. Klaus Jensen (6): hw/block/nvme: fix shutdown/reset logic hw/block/nvme: merge implicitly/explicitly opened processing masks hw/block/n

[PATCH 6/6] hw/block/nvme: remove unnecessary check for append

2021-01-11 Thread Klaus Jensen
From: Klaus Jensen nvme_io_cmd already checks if the namespace supports the Zone Append command, so the removed check is dead code. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index b3658595fe1b..1f175

[PATCH 3/6] hw/block/nvme: enum style fix

2021-01-11 Thread Klaus Jensen
From: Klaus Jensen Align with existing style and use a typedef for header-file enums. Signed-off-by: Klaus Jensen --- hw/block/nvme-ns.h | 4 ++-- include/block/nvme.h | 4 ++-- hw/block/nvme.c | 19 +-- 3 files changed, 13 insertions(+), 14 deletions(-) diff --git a/

[PATCH 1/6] hw/block/nvme: fix shutdown/reset logic

2021-01-11 Thread Klaus Jensen
From: Klaus Jensen A shutdown is only about flushing stuff. It is the host that should delete any queues, so do not perform a reset here. Also, on shutdown, make sure that the PMR is flushed if in use. Fixes: 368f4e752cf9 ("hw/block/nvme: Process controller reset and shutdown differently") Sig

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Miroslav Rezanina
- Original Message - > From: "Thomas Huth" > To: "Philippe Mathieu-Daudé" , mreza...@redhat.com, > qemu-devel@nongnu.org, "qemu-s390x" > > Sent: Monday, January 11, 2021 1:24:57 PM > Subject: Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length > > On 11/01/2021 13.10, Phili

[PATCH 5/6] hw/block/nvme: add missing string representations for commands

2021-01-11 Thread Klaus Jensen
From: Klaus Jensen Add missing string representations for a couple of new commands. Signed-off-by: Klaus Jensen --- hw/block/nvme.h | 4 1 file changed, 4 insertions(+) diff --git a/hw/block/nvme.h b/hw/block/nvme.h index b7fbcca39d9f..65540b650e1d 100644 --- a/hw/block/nvme.h +++ b/hw/b

[PATCH 4/6] hw/block/nvme: zero out zones on reset

2021-01-11 Thread Klaus Jensen
From: Klaus Jensen The zoned command set specification states that "All logical blocks in a zone *shall* be marked as deallocated when [the zone is reset]". Since the device guarantees 0x00 to be read from deallocated blocks we have to issue a pwrite_zeroes since we cannot be sure that a discard

Re: [RHEL7 qemu-kvm PATCH 3/3] Fix tcg_out_op argument mismatch warning

2021-01-11 Thread Miroslav Rezanina
- Original Message - > From: "Philippe Mathieu-Daudé" > To: mreza...@redhat.com, qemu-devel@nongnu.org > Cc: "Richard Henderson" , "Eric Blake" > > Sent: Monday, January 11, 2021 1:15:04 PM > Subject: Re: [RHEL7 qemu-kvm PATCH 3/3] Fix tcg_out_op argument mismatch > warning > > On 1/11

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Thomas Huth
On 11/01/2021 13.42, Miroslav Rezanina wrote: - Original Message - From: "Thomas Huth" To: "Philippe Mathieu-Daudé" , mreza...@redhat.com, qemu-devel@nongnu.org, "qemu-s390x" Sent: Monday, January 11, 2021 1:24:57 PM Subject: Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy le

Re: [PATCH v3 2/3] Update linux headers to 5.11-rc2

2021-01-11 Thread Cornelia Huck
On Mon, 4 Jan 2021 21:20:56 +0100 Eric Farman wrote: > Signed-off-by: Eric Farman > --- > .../infiniband/hw/vmw_pvrdma/pvrdma_ring.h| 14 +- > .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 2 +- > include/standard-headers/drm/drm_fourcc.h | 175 +- > include/standa

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Miroslav Rezanina
- Original Message - > From: "Philippe Mathieu-Daudé" > To: mreza...@redhat.com, qemu-devel@nongnu.org > Sent: Monday, January 11, 2021 1:10:07 PM > Subject: Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length > > Hi Miroslav, > > On 1/11/21 12:30 PM, mreza...@redhat.com wro

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Miroslav Rezanina
- Original Message - > From: "Thomas Huth" > To: "Miroslav Rezanina" > Cc: "qemu-s390x" , "Philippe Mathieu-Daudé" > , qemu-devel@nongnu.org > Sent: Monday, January 11, 2021 1:54:06 PM > Subject: Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length > > On 11/01/2021 13.42, M

Re: qemu bsd-user plans

2021-01-11 Thread Thomas Huth
On 08/01/2021 20.56, Peter Maydell wrote: Adding the people to the CC list who were on the previous discussion thread... -- PMM On Fri, 8 Jan 2021 at 19:43, Warner Losh wrote: [...] So, my new plan is to rebase what changes I can to the tip of master and submit those for review. I'll work

Re: [PATCH v3 2/3] Update linux headers to 5.11-rc2

2021-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2021 at 01:54:04PM +0100, Cornelia Huck wrote: > On Mon, 4 Jan 2021 21:20:56 +0100 > Eric Farman wrote: > > > Signed-off-by: Eric Farman > > --- > > .../infiniband/hw/vmw_pvrdma/pvrdma_ring.h| 14 +- > > .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 2 +- > > include/s

Re: [PATCH 18/20] keyval: Use GString to accumulate value strings

2021-01-11 Thread Markus Armbruster
Paolo Bonzini writes: > On 11/12/20 18:11, Markus Armbruster wrote: >> QString supports modifying its string, but it's quite limited: you can >> only append. The remaining callers use it for building an initial >> string, never for modifying it later. >> Change keyval_parse_one() to do build the

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Christian Borntraeger
On 11.01.21 14:02, Christian Borntraeger wrote: > > > On 11.01.21 13:54, Thomas Huth wrote: >> On 11/01/2021 13.42, Miroslav Rezanina wrote: >>> >>> >>> - Original Message - From: "Thomas Huth" To: "Philippe Mathieu-Daudé" , mreza...@redhat.com, qemu-devel@nongnu.org,

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Christian Borntraeger
On 11.01.21 13:54, Thomas Huth wrote: > On 11/01/2021 13.42, Miroslav Rezanina wrote: >> >> >> - Original Message - >>> From: "Thomas Huth" >>> To: "Philippe Mathieu-Daudé" , mreza...@redhat.com, >>> qemu-devel@nongnu.org, "qemu-s390x" >>> >>> Sent: Monday, January 11, 2021 1:24:57 PM

Re: [PATCH] 9pfs/proxy: Check return value of proxy_marshal()

2021-01-11 Thread Christian Schoenebeck via
On Montag, 11. Januar 2021 10:49:56 CET Greg Kurz wrote: > This should always successfully write exactly two 32-bit integers. > Make it clear with an assert(), like v9fs_receive_status() and > v9fs_receive_response() already do when unmarshalling the same > header. > > Fixes: Coverity CID 1438968

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Miroslav Rezanina
- Original Message - > From: "Christian Borntraeger" > To: "Thomas Huth" , "Miroslav Rezanina" > > Cc: "qemu-s390x" , "Philippe Mathieu-Daudé" > , qemu-devel@nongnu.org > Sent: Monday, January 11, 2021 2:02:32 PM > Subject: Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy lengt

[PATCH] vnc: fix unfinalized tlscreds for VncDisplay

2021-01-11 Thread Zihao Chang
In vnc_display_open(), if tls-creds is enabled, do object_ref(object ref 1->2) for tls-creds. While in vnc_display_close(), object_unparent sets object ref to 1(2->1) and unparent the object for root. Problem: 1. the object can not be found from the objects_root, while the object is not finalized.

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Christian Borntraeger
On 11.01.21 14:17, Miroslav Rezanina wrote: > > > - Original Message - >> From: "Christian Borntraeger" >> To: "Thomas Huth" , "Miroslav Rezanina" >> >> Cc: "qemu-s390x" , "Philippe Mathieu-Daudé" >> , qemu-devel@nongnu.org >> Sent: Monday, January 11, 2021 2:02:32 PM >> Subject: R

Re: [PATCH v1 10/20] target/arm: use official org.gnu.gdb.aarch64.sve layout for registers

2021-01-11 Thread Luis Machado
For the record, the layout looks OK to me. Just a reminder that GDB will soon support bfloat16 types. A patch may be pushed this month. On 1/8/21 7:42 PM, Alex Bennée wrote: While GDB can work with any XML description given to it there is special handling for SVE registers on the GDB side whi

Re: qemu bsd-user plans

2021-01-11 Thread Daniel P . Berrangé
On Fri, Jan 08, 2021 at 12:41:30PM -0700, Warner Losh wrote: > The FreeBSD project has rewritten bsd-user. We've been working on this for > quite some time (the earliest commits date from 2013). Maybe a dozen people > have worked on this over time, and there's 3 or 4 active developers focused > on

Re: [PATCH v14 1/7] Introduce yank feature

2021-01-11 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Dec 28, 2020 at 7:08 PM Lukas Straub wrote: > >> The yank feature allows to recover from hanging qemu by "yanking" >> at various parts. Other qemu systems can register themselves and >> multiple yank functions. Then all yank functions for selected >> in

Re: [PATCH v3 2/3] Update linux headers to 5.11-rc2

2021-01-11 Thread Cornelia Huck
On Mon, 11 Jan 2021 08:00:45 -0500 "Michael S. Tsirkin" wrote: > On Mon, Jan 11, 2021 at 01:54:04PM +0100, Cornelia Huck wrote: > > On Mon, 4 Jan 2021 21:20:56 +0100 > > Eric Farman wrote: > > > > > Signed-off-by: Eric Farman > > > --- > > > .../infiniband/hw/vmw_pvrdma/pvrdma_ring.h|

[PULL 01/15] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD

2021-01-11 Thread Thomas Huth
From: "Cho, Yu-Chen via" Add build-system-opensuse jobs and opensuse-leap.docker dockerfile. Use openSUSE Leap 15.2 container image in the gitlab-CI. Signed-off-by: Cho, Yu-Chen Tested-by: Wainer dos Santos Moschetta Reviewed-by: Wainer dos Santos Moschetta Message-Id: <20201229085046.8536-1-

[PULL 05/15] fuzz: double the IOs to remove for every loop

2021-01-11 Thread Thomas Huth
From: Qiuhao Li Instead of removing IO instructions one by one, we can try deleting multiple instructions at once. According to the locality of reference, we double the number of instructions to remove for the next round and recover it to one once we fail. This patch is usually significant for l

[PULL 06/15] fuzz: split write operand using binary approach

2021-01-11 Thread Thomas Huth
From: Qiuhao Li Currently, we split the write commands' data from the middle. If it does not work, try to move the pivot left by one byte and retry until there is no space. But, this method has two flaws: 1. It may fail to trim all unnecessary bytes on the right side. For example, there is an

[PULL 00/15] Testing, CI and bsd-user patches

2021-01-11 Thread Thomas Huth
Hi, the following changes since commit 7b09f127738ae3d0e71716cea086fc8f847a5686: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210108' into staging (2021-01-08 15:37:04 +) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pull-reques

[PULL 03/15] util/oslib-win32: Fix _aligned_malloc() arguments order

2021-01-11 Thread Thomas Huth
From: Philippe Mathieu-Daudé Commit dfbd0b873a8 inadvertently swapped the arguments of _aligned_malloc(), correct it to fix [*]: G_TEST_SRCDIR=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/tests G_TEST_BUILDDIR=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-

[PULL 10/15] fuzz: heuristic split write based on past IOs

2021-01-11 Thread Thomas Huth
From: Qiuhao Li If previous write commands write the same length of data with the same step, we view it as a hint. Signed-off-by: Qiuhao Li Reviewed-by: Alexander Bulekov Tested-by: Alexander Bulekov Message-Id: Signed-off-by: Thomas Huth --- scripts/oss-fuzz/minimize_qtest_trace.py | 56

[PULL 11/15] bsd-user: regenerate FreeBSD's system call numbers

2021-01-11 Thread Thomas Huth
From: Warner Losh Recreate the FreeBSD system call numbers from current sys/syscall.h. Since this isn't guaranteed to be on all systems, continue the practice of generating it with some variation on: sed -e s/SYS_/TARGET_NR_/ < $FREEBSD_SRC/sys/syscall.h > syscall_nr.h until a more compre

[PULL 02/15] qtest/libqtest: fix heap-buffer-overflow in qtest_cb_for_every_machine()

2021-01-11 Thread Thomas Huth
From: Gan Qixin When the length of mname is less than 5, memcpy("xenfv", mname, 5) will cause heap buffer overflow. Therefore, use strncmp to avoid this problem. The asan showed stack: ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020f2f4 at pc 0x7f65d8cc2225 bp 0x7ffe93cc5a60

[PULL 04/15] fuzz: accelerate non-crash detection

2021-01-11 Thread Thomas Huth
From: Qiuhao Li We spend much time waiting for the timeout program during the minimization process until it passes a time limit. This patch hacks the CLOSED (indicates the redirection file closed) notification in QTest's output if it doesn't crash. Test with quadrupled trace input at: https://

[PULL 14/15] tests/acceptance: Fix race conditions in s390x tests & skip fedora on gitlab-CI

2021-01-11 Thread Thomas Huth
There was a race condition in the first test where there was already the "crw" output in the dmesg, but the "0.0.4711" entry has not been created in the /sys fs yet. Fix it by waiting until it is there. The second test has even more problems on gitlab-CI. Even after adding some more synchronizatio

[PULL 12/15] bsd-user: move strace OS/arch dependent code to host/arch dirs

2021-01-11 Thread Thomas Huth
From: Stacey Son This change moves host OS and arch dependent code for the sysarch system call related to the -strace functionality into the appropriate host OS and target arch directories. Signed-off-by: Stacey Son Signed-off-by: Sean Bruno [ imp integrated minor build fixes from sbruno ] Sig

[PULL 15/15] fuzz: map all BARs and enable PCI devices

2021-01-11 Thread Thomas Huth
From: Alexander Bulekov Prior to this patch, the fuzzer found inputs to map PCI device BARs and enable the device. While it is nice that the fuzzer can do this, it added significant overhead, since the fuzzer needs to map all the BARs (regenerating the memory topology), at the start of each input

[PULL 08/15] fuzz: set bits in operand of write/out to zero

2021-01-11 Thread Thomas Huth
From: Qiuhao Li Simplifying the crash cases by opportunistically setting bits in operands of out/write to zero may help to debug, since usually bit one means turn on or trigger a function while zero is the default turn-off setting. Tested bug https://bugs.launchpad.net/qemu/+bug/1908062 Signed-

[PULL 07/15] fuzz: remove IO commands iteratively

2021-01-11 Thread Thomas Huth
From: Qiuhao Li Now we use a one-time scan and remove strategy in the minimizer, which is not suitable for timing dependent instructions. For example, instruction A will indicate an address where the config chunk locates, and instruction B will make the configuration active. If we have the follo

Re: [PATCH 18/20] keyval: Use GString to accumulate value strings

2021-01-11 Thread Paolo Bonzini
On 11/01/21 14:05, Markus Armbruster wrote: I had to choose between creating a conflict and holding back my series while we figure out what to do with your patch. The dilemma is my own doing; your patch is waiting just for me. I picked the conflict. I can look into rebasing your patch on top o

[PULL 09/15] fuzz: add minimization options

2021-01-11 Thread Thomas Huth
From: Qiuhao Li -M1: remove IO commands iteratively -M2: try setting bits in operand of write/out to zero Signed-off-by: Qiuhao Li Reviewed-by: Alexander Bulekov Tested-by: Alexander Bulekov Message-Id: Signed-off-by: Thomas Huth --- scripts/oss-fuzz/minimize_qtest_trace.py | 30 +

[PULL 13/15] bsd-user: Update strace.list for FreeBSD's latest syscalls

2021-01-11 Thread Thomas Huth
From: Warner Losh Update strace.list to include all of FreeBSD's syscalls up through svn r331280. Signed-off-by: Stacey Son Signed-off-by: Sean Bruno Signed-off-by: Alexander Kabaev Signed-off-by: Jung-uk Kim Author: Michal Meloun Signed-off-by: Mikaël Urankar [imp moved this change to ear

Re: [PULL 00/15] Testing, CI and bsd-user patches

2021-01-11 Thread Thomas Huth
On 11/01/2021 14.46, Peter Maydell wrote: On Mon, 11 Jan 2021 at 13:43, Thomas Huth wrote: Hi, the following changes since commit 7b09f127738ae3d0e71716cea086fc8f847a5686: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210108' into staging (2021-01-08 15:37:04 +

Re: [PULL 00/15] Testing, CI and bsd-user patches

2021-01-11 Thread Peter Maydell
On Mon, 11 Jan 2021 at 13:43, Thomas Huth wrote: > > Hi, > > the following changes since commit 7b09f127738ae3d0e71716cea086fc8f847a5686: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210108' into staging (2021-01-08 > 15:37:04 +) > > are available in the Git

Re: check-tcg HOWTO?

2021-01-11 Thread Alex Bennée
Claudio Fontana writes: > Hi Alex, > > happy new year, > > I am trying to get check-tcg to run reliably, > as I am doing some substantial refactoring of tcg cpu operations, so I need > to verify that TCG is fine. > > This is an overall getting started question, is there a how-to on how > to us

[PULL 01/15] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD

2021-01-11 Thread Thomas Huth
From: "Cho, Yu-Chen" Add build-system-opensuse jobs and opensuse-leap.docker dockerfile. Use openSUSE Leap 15.2 container image in the gitlab-CI. Signed-off-by: Cho, Yu-Chen Tested-by: Wainer dos Santos Moschetta Reviewed-by: Wainer dos Santos Moschetta Message-Id: <20201229085046.8536-1-a...

[PULL v2 00/15] Testing, CI and bsd-user patches

2021-01-11 Thread Thomas Huth
The following changes since commit 7b09f127738ae3d0e71716cea086fc8f847a5686: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210108' into staging (2021-01-08 15:37:04 +) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pull-request-2021

Re: [PATCH v14 1/7] Introduce yank feature

2021-01-11 Thread Marc-André Lureau
On Mon, Jan 11, 2021 at 5:34 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Mon, Dec 28, 2020 at 7:08 PM Lukas Straub > wrote: > > > >> The yank feature allows to recover from hanging qemu by "yanking" > >> at various parts. Other qemu systems can register themselve

Re: [PATCH v1 10/20] target/arm: use official org.gnu.gdb.aarch64.sve layout for registers

2021-01-11 Thread Alex Bennée
Luis Machado writes: > For the record, the layout looks OK to me. So a Reviewed-by? > Just a reminder that GDB will soon support bfloat16 types. A patch may > be pushed this month. Will we be able to probe for the support - or will an older GDB silently accept and drop any bfloat16 fields?

Re: [PULL v2 00/15] Testing, CI and bsd-user patches

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/11/21 3:06 PM, Thomas Huth wrote: > The following changes since commit 7b09f127738ae3d0e71716cea086fc8f847a5686: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210108' into staging (2021-01-08 > 15:37:04 +) > > are available in the Git repository at: > >

Re: check-tcg HOWTO?

2021-01-11 Thread Claudio Fontana
Ciao Alex, thanks for your answer, On 1/11/21 2:35 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> Hi Alex, >> >> happy new year, >> >> I am trying to get check-tcg to run reliably, >> as I am doing some substantial refactoring of tcg cpu operations, so I need >> to verify that TCG is

  1   2   3   4   >