Public bug reported:
Dear all,
I am afraid I found a problem, it seems like qemu-arm crashes when executing
assembly push instruction.
I use qemu version 5.2.0, but it checked an older version (4.2.1) and the
problem was also present. I start qemu using "qemu-arm -cpu cortex-m4
-singlestep -g 1
On Sat, Dec 26, 2020 at 06:33:39PM +0800, g00517791 wrote:
> From: Jinhao Gao
>
> For some device state having some fields of VMS_ALLOC flag, they don't
> free memory allocated for the fields in vmstate_save_state and vmstate
> _load_state. We add funcs or sentences of free memory before allocati
On 12/25/20 12:23 AM, BALATON Zoltan wrote:
> We'll need a flag for implementing some device specific behaviour in
> via-ide but we already have a currently CMD646 specific field that can
> be repurposed for this and leave room for furhter flags if needed in
> the future. This patch changes the "se
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
> This groups identifiers related to the ISA bridge part and superio
> part also in their naming.
>
> Signed-off-by: BALATON Zoltan
> ---
> hw/isa/vt82c686.c | 48 ++-
> hw/mips/fuloong2e.c | 2 +-
>
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
> There's no reason to suffix everything with _DEVICE when the names are
> already unique without it and shorter names are more readable.
>
> Signed-off-by: BALATON Zoltan
> ---
> hw/isa/vt82c686.c | 48 +++---
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
> There's no reason to suffix everything with _DEVICE when the names are
> already unique without it and shorter names are more readable.
>
> Signed-off-by: BALATON Zoltan
> ---
> hw/isa/vt82c686.c | 48 +++---
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
> Also rename VT82C686B type to lower case to match other device names.
If possible do not split the commit description in 2 (one part in
subject and the other part here) as this is annoying to read.
>
> Signed-off-by: BALATON Zoltan
> ---
> hw/is
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
> Also rename VT82C686B_PM to match other device names.
s/Also/Remove vt82c686b_pm_init() function and/
Preferably copying the subject in the description to
ease reading:
Reviewed-by: Philippe Mathieu-Daudé
>
> Signed-off-by: BALATON Zoltan
> ---
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
> These are not used or not needed.
>
> Signed-off-by: BALATON Zoltan
> ---
> hw/isa/vt82c686.c | 8
> 1 file changed, 8 deletions(-)
>
> diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
> index 789459bcae..6dff2bc67d 100644
> --- a/hw/i
Hi Zoltan,
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
> Remove some unneded, empty code and set user_creatable to false
> (besides being not implemented yet, so does nothing anyway) it's also
> normally part of VIA south bridge chips so no need to confuse users
> showing them these devices.
A
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
> These supposed to implement audio part used in VIA south bridges so
> they are better placed under hw/audio.
"The via-[am]c97 code is supposed to implement the audio part of
VIA south bridge chipset so is better placed under hw/audio/.
Split it off
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
> These parts are common between VT82C686B and VT8231 so can be shared
> in the future. Rename them to VIA prefix accordingly.
>
> Signed-off-by: BALATON Zoltan
> ---
> hw/isa/vt82c686.c | 28 ++--
> 1 file changed, 14 insert
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
> Signed-off-by: BALATON Zoltan
> ---
> hw/isa/trace-events | 6 ++
> hw/isa/vt82c686.c | 51 +
> 2 files changed, 21 insertions(+), 36 deletions(-)
...
> switch (superio_conf->index) {
>
On 12/25/20 12:23 AM, BALATON Zoltan wrote:
> From: Guenter Roeck
>
> Fuloong2e needs to use legacy mode for IDE support to work with Linux.
> Add property to via-ide driver to make the mode configurable, and set
> legacy mode for Fuloong2e.
>
Fixes: 4ea98d317eb ("ide/via: Implement and use nat
On 12/25/20 9:19 PM, Richard Henderson wrote:
> This emphasizes that we don't support s390, only 64-bit s390x hosts.
>
> Signed-off-by: Richard Henderson
> ---
> meson.build | 2 --
> tcg/{s390 => s390x}/tcg-target-conset.h | 0
> tcg/{s390 => s390x}/tcg-target-constr
On 12/25/20 9:19 PM, Richard Henderson wrote:
> They are rightly values in the same enumeration.
>
> Reviewed-by: David Hildenbrand
> Signed-off-by: Richard Henderson
> ---
> tcg/s390x/tcg-target.h | 28 +++-
> 1 file changed, 7 insertions(+), 21 deletions(-)
Reviewed-b
On 12/25/20 9:19 PM, Richard Henderson wrote:
> We will shortly need to be able to check facilities beyond the
> first 64. Instead of explicitly masking against s390_facilities,
> create a HAVE_FACILITY macro that indexes an array.
>
> Reviewed-by: David Hildenbrand
> Signed-off-by: Richard Hend
On 12/26/20 12:07 AM, BALATON Zoltan via wrote:
> Remove dependencies from KConfig that are not actually needed.
>
> Signed-off-by: BALATON Zoltan
> ---
> hw/ppc/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
> index 8548f42b0d..5893f80909 1006
On Sun, 27 Dec 2020, Philippe Mathieu-Daudé wrote:
On 12/25/20 12:23 AM, BALATON Zoltan wrote:
From: Guenter Roeck
Fuloong2e needs to use legacy mode for IDE support to work with Linux.
Add property to via-ide driver to make the mode configurable, and set
legacy mode for Fuloong2e.
Fixes: 4
On Sun, 27 Dec 2020, Philippe Mathieu-Daudé wrote:
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
Signed-off-by: BALATON Zoltan
---
hw/isa/trace-events | 6 ++
hw/isa/vt82c686.c | 51 +
2 files changed, 21 insertions(+), 36 deletions(-)
...
since we implement byte interfaces and librbd supports aio on byte granularity
we can lift
the 512 byte alignment.
Signed-off-by: Peter Lieven
---
block/rbd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 27b4404adf..8673e8f553 100644
--- a/block/rbd.c
+++
this series migrates the qemu rbd driver from the old aio emulation
to native coroutines and adds write zeroes support which is important
for block operations.
To archive this we first bump the librbd requirement to the already
outdated luminous release of ceph to get rid of some wrappers and
ifde
Signed-off-by: Peter Lieven
---
block/rbd.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index bc8cf8af9b..a2da70e37f 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -956,15 +956,7 @@ static int qemu_rbd_getinfo(BlockDriverState *bs,
Block
Signed-off-by: Peter Lieven
---
block/rbd.c | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/block/rbd.c b/block/rbd.c
index 2d77d0007f..27b4404adf 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -63,7 +63,8 @@ typedef enum {
RBD_AIO_READ,
Signed-off-by: Peter Lieven
---
block/rbd.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 650e27c351..bc8cf8af9b 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -90,6 +90,7 @@ typedef struct BDRVRBDState {
char *snap;
Signed-off-by: Peter Lieven
---
block/rbd.c | 247 ++--
1 file changed, 84 insertions(+), 163 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 27b232f4d8..2d77d0007f 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -66,22 +66,6 @@ typedef enu
On Sun, 27 Dec 2020, Philippe Mathieu-Daudé wrote:
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
There's no reason to suffix everything with _DEVICE when the names are
already unique without it and shorter names are more readable.
Signed-off-by: BALATON Zoltan
---
hw/isa/vt82c686.c | 48
On Sun, 27 Dec 2020, Philippe Mathieu-Daudé wrote:
Hi Zoltan,
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
Remove some unneded, empty code and set user_creatable to false
(besides being not implemented yet, so does nothing anyway) it's also
normally part of VIA south bridge chips so no need t
On Sun, 27 Dec 2020, Philippe Mathieu-Daudé wrote:
On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
Also rename VT82C686B type to lower case to match other device names.
If possible do not split the commit description in 2 (one part in
subject and the other part here) as this is annoying to read
Signed-off-by: Peter Lieven
---
block/rbd.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index a2da70e37f..27b232f4d8 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -91,6 +91,7 @@ typedef struct BDRVRBDState {
char *names
even luminous (version 12.2) is unmaintained for over 3 years now.
Bump the requirement to get rid of the ifdef'ry in the code.
Signed-off-by: Peter Lieven
---
block/rbd.c | 120
configure | 7 +--
2 files changed, 12 insertions(+), 115 de
On 12/27/20 5:40 PM, BALATON Zoltan via wrote:
> On Sun, 27 Dec 2020, Philippe Mathieu-Daudé wrote:
>> On 12/25/20 12:23 AM, BALATON Zoltan wrote:
>>> From: Guenter Roeck
>>>
>>> Fuloong2e needs to use legacy mode for IDE support to work with Linux.
>>> Add property to via-ide driver to make the m
On 12/27/20 9:24 AM, Philippe Mathieu-Daudé wrote:
> On 12/27/20 5:40 PM, BALATON Zoltan via wrote:
>> On Sun, 27 Dec 2020, Philippe Mathieu-Daudé wrote:
>>> On 12/25/20 12:23 AM, BALATON Zoltan wrote:
From: Guenter Roeck
Fuloong2e needs to use legacy mode for IDE support to work wi
On 12/25/20 3:07 PM, BALATON Zoltan wrote:
> Avoid mapping multiple interrupts to the same irq. Instead map them to
> the 4 PCI interrupts and use an or-gate in the board to connect them
> to the interrupt controller. This does not fix any known problem but
> does not seem to cause a new problem ei
This implements the legacy-mode emulation option for via-ide which is
needed for Linux on fuloong2e. I've tested that the Debian kernel now
finds CD ROM and MorphOS on pegasos2 is not affected by this.
v2 adds review tags and fixes
BALATON Zoltan (1):
ide: Make room for flags in PCIIDEState and
We'll need a flag for implementing some device specific behaviour in
via-ide but we already have a currently CMD646 specific field that can
be repurposed for this and leave room for further flags if needed in
the future. This patch changes the "secondary" field to "flags" and
change CMD646 and its
From: Guenter Roeck
The IDE legacy mode emulation has been removed in commit 4ea98d317eb
("ide/via: Implement and use native PCI IDE mode") but some Linux
kernels (probably including def_config) require legacy mode on the
Fuloong2e so only emulating native mode did not turn out feasible.
Add prop
On Sun, 27 Dec 2020, Philippe Mathieu-Daudé wrote:
On 12/27/20 5:40 PM, BALATON Zoltan via wrote:
On Sun, 27 Dec 2020, Philippe Mathieu-Daudé wrote:
On 12/25/20 12:23 AM, BALATON Zoltan wrote:
From: Guenter Roeck
Fuloong2e needs to use legacy mode for IDE support to work with Linux.
Add prop
Paolo Bonzini writes:
> On 22/12/20 16:39, Marian Posteuca wrote:
Qemu's ACPI table generation sets the fields OEM ID and OEM table ID
to "BOCHS " and "BXPC" where "" is replaced by the ACPI
table name.
Some games like Red Dead Redemption 2 seem to check the ACPI
Hi, BALATON
On Sun, Dec 27, 2020 at 9:21 AM BALATON Zoltan wrote:
>
> Compiling vt82c686.c fails without APM and ACPI_PM functions. Add
> dependency on these in Kconfig to fix this.
>
> Signed-off-by: BALATON Zoltan
> ---
> hw/isa/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
> -Original Message-
> From: Jason Wang
> Sent: Friday, December 25, 2020 2:20 PM
> To: Zhang, Chen ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan
> Gilbert ; Markus Armbruster
> Cc: Zhang Chen
> Subject: Re: [PATCH 1/3] qapi/net: Add new QMP command for COLO
> passthrough
> -Original Message-
> From: Jason Wang
> Sent: Friday, December 25, 2020 2:23 PM
> To: Zhang, Chen ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan
> Gilbert ; Markus Armbruster
> Cc: Zhang Chen
> Subject: Re: [PATCH 0/3] Bypass specific network traffic in COLO
>
>
> On 20
Hello,
On Mon, 28 Dec 2020, Huacai Chen wrote:
Hi, BALATON
On Sun, Dec 27, 2020 at 9:21 AM BALATON Zoltan wrote:
Compiling vt82c686.c fails without APM and ACPI_PM functions. Add
dependency on these in Kconfig to fix this.
Signed-off-by: BALATON Zoltan
---
hw/isa/Kconfig | 2 ++
1 file ch
OK, just do it as Philippe suggested.
Huacai
On Mon, Dec 28, 2020 at 9:42 AM BALATON Zoltan via
wrote:
>
> Hello,
>
> On Mon, 28 Dec 2020, Huacai Chen wrote:
> > Hi, BALATON
> >
> > On Sun, Dec 27, 2020 at 9:21 AM BALATON Zoltan wrote:
> >>
> >> Compiling vt82c686.c fails without APM and ACPI_P
I'm sending this v2 with tags added and small edits after Philippe's
review for now, maybe these are already good to go. I've taken out a
few patches that may need some more work but I've run out of free time
for now so will have to come back to them later. I still could not
cleanly add the VT8231
This is really the ISA bridge part so name the type accordingly.
Signed-off-by: BALATON Zoltan
---
hw/isa/vt82c686.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index 1be1169f83..d40599c7da 100644
--- a/hw/isa/v
These parts are common between VT82C686B and VT8231 so can be shared
in the future. Rename them to VIA prefix accordingly.
Signed-off-by: BALATON Zoltan
Reviewed-by: Philippe Mathieu-Daudé
---
hw/isa/vt82c686.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
These are legacy init functions that are just equivalent to directly
calling pci_create_simple so do that instead. Also rename objects to
lower case via-ac97 and via-mc97 matching naming of other devices.
Signed-off-by: BALATON Zoltan
---
hw/isa/vt82c686.c | 27 --
The via-[am]c97 code is supposed to implement the audio part of VIA
south bridge chips so it is better placed under hw/audio/. Split it
off into a separate file.
Signed-off-by: BALATON Zoltan
Reviewed-by: Philippe Mathieu-Daudé
---
v2: Reworded commit message
hw/audio/meson.build | 1 +
hw/a
There's no reason to suffix everything with _DEVICE when the names are
already unique without it and shorter names are more readable.
Signed-off-by: BALATON Zoltan
Reviewed-by: Philippe Mathieu-Daudé
---
hw/isa/vt82c686.c | 48 +++
1 file changed, 23
These are not used or not needed.
Signed-off-by: BALATON Zoltan
---
v2: Added back a few that we get indirectly but keep it explicit
hw/isa/vt82c686.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index d7ce15bf9f..02d6759c00 100644
--- a/hw/isa/v
Signed-off-by: BALATON Zoltan
Reviewed-by: Philippe Mathieu-Daudé
---
v2: Reworded commit message
hw/isa/vt82c686.c | 9 -
hw/mips/fuloong2e.c | 4 +++-
include/hw/isa/vt82c686.h | 3 +--
3 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/hw/isa/vt82c686.c b/h
Remove legacy vt82c686b_pm_init() function and also rename
VT82C686B_PM type name to match other device names.
Signed-off-by: BALATON Zoltan
Reviewed-by: Philippe Mathieu-Daudé
---
v2: Reworded commit message, delete i2c include here
hw/isa/vt82c686.c | 18 --
hw/mips/f
Remove some unneded, empty code and set user_creatable to false
(besides being not implemented yet, so does nothing anyway) it's also
normally part of VIA south bridge chips so no need to confuse users
showing them these devices.
Signed-off-by: BALATON Zoltan
---
hw/audio/via-ac97.c | 51 +++
Drop DPRINTF and use trace functions instead. Two debug messages about
unimplemented registers could be converted to qemu_log_mask() but in
reality all registers are currently unimplemented (we just store and
return values of writable regs but do nothing with them). As we
already trace register acc
Extend and refine the crash case minimization process.
Test input:
Bug 1909261 full_reproducer
6500 QTest instructions (write mostly)
Refined (-M1 minimization level) vs. Original version:
real 38m31.942s <-- real 532m57.192s
user 28m18.188s <-- user 89m0.536s
sys 12m42.239s <-
We spend much time waiting for the timeout program during the minimization
process until it passes a time limit. This patch hacks the CLOSED (indicates
the redirection file closed) notification in QTest's output if it doesn't
crash.
Test with quadrupled trace input at:
https://bugs.launchpad.net
Currently, we split the write commands' data from the middle. If it does not
work, try to move the pivot left by one byte and retry until there is no
space.
But, this method has two flaws:
1. It may fail to trim all unnecessary bytes on the right side.
For example, there is an IO write command:
Now we use a one-time scan and remove strategy in the remval minimizer,
which is not suitable for timing dependent instructions.
For example, instruction A will indicate an address where the config
chunk locates, and instruction B will make the configuration active. If
we have the following instru
Instead of removing IO instructions one by one, we can try deleting multiple
instructions at once. According to the locality of reference, we double the
number of instructions to remove for the next round and recover it to one
once we fail.
This patch is usually significant for large input.
Test
-M1: loop around the remove minimizer
-M2: try setting bits in operand of write/out to zero
Signed-off-by: Qiuhao Li
---
scripts/oss-fuzz/minimize_qtest_trace.py | 30
1 file changed, 25 insertions(+), 5 deletions(-)
diff --git a/scripts/oss-fuzz/minimize_qtest_trace.py
Simplifying the crash cases by opportunistically setting bits in operands of
out/write to zero may help to debug, since usually bit one means turn on or
trigger a function while zero is the default turn-off setting.
Tested Bug 1908062.
Signed-off-by: Qiuhao Li
---
scripts/oss-fuzz/minimize_qtes
If previous write commands write the same length of data with the same step,
we view it as a hint.
Signed-off-by: Qiuhao Li
---
scripts/oss-fuzz/minimize_qtest_trace.py | 55
1 file changed, 55 insertions(+)
diff --git a/scripts/oss-fuzz/minimize_qtest_trace.py
b/scrip
Patchew URL:
https://patchew.org/QEMU/me3p282mb17458b2705c43e860a26171dfc...@me3p282mb1745.ausp282.prod.outlook.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id:
me3p282mb17458b2705c43e860a26171dfc...@me3p282mb1745.
On Sat, Dec 26, 2020 at 06:33:42PM +0800, g00517791 wrote:
> From: Jinhao Gao
>
> When VM migrate VMState of spapr_event_log_entry, the field(extended_log)
> of spapr_event_log_entry having a flag of VMS_ALLOC needs to allocate
> memory. If the dst doesn't free memory which has been allocated for
On Sat, Dec 26, 2020 at 06:33:43PM +0800, g00517791 wrote:
> From: Jinhao Gao
>
> When VM migrate VMState of spapr_pci, the field(msi_devs) of spapr_pci
> having a flag of VMS_ALLOC need to allocate memory. If the src doesn't free
> memory of msi_devs in SaveStateEntry of spapr_pci after QEMUFile
On Sat, Dec 19, 2020 at 10:42:23AM +, Mark Cave-Ayland wrote:
> This condition will have already been caught when wiring the heathrow PIC
> irqs to the CPU.
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: David Gibson
> ---
> hw/ppc/mac_oldworld.c | 6 --
> 1 file changed, 6 deletion
On 2020/12/28 上午8:38, Zhang, Chen wrote:
-Original Message-
From: Jason Wang
Sent: Friday, December 25, 2020 2:20 PM
To: Zhang, Chen ; qemu-dev ; Eric Blake ; Dr. David Alan
Gilbert ; Markus Armbruster
Cc: Zhang Chen
Subject: Re: [PATCH 1/3] qapi/net: Add new QMP command for COLO
p
Transfer tabs to spaces.
Signed-off-by: Zhang Han
---
qobject/qdict.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qobject/qdict.c b/qobject/qdict.c
index 1079bd3f6f..2c07b3c87f 100644
--- a/qobject/qdict.c
+++ b/qobject/qdict.c
@@ -38,8 +38,8 @@ QDict *qdict_new(void)
Some style problems in qobject directory are found by checkpatch.pl. Fix these
style problems.
Zhang Han (4):
qobject: open brace '{' following struct go on the same line
qobject: code indent should never use tabs
qobject: spaces required around that operators
qobject: braces {} are necess
Put open brace '{' on the same line of struct.
Signed-off-by: Zhang Han
---
qobject/json-parser.c | 3 +--
qobject/qjson.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/qobject/json-parser.c b/qobject/json-parser.c
index c0f521b56b..18b87a42f3 100644
--- a/qobject
On Sat, Dec 19, 2020 at 10:42:24AM +, Mark Cave-Ayland wrote:
> Signed-off-by: Mark Cave-Ayland
Looks correct, but it could really do with a rationale in the commit message.
> ---
> hw/ppc/mac_oldworld.c | 30 +++---
> 1 file changed, 15 insertions(+), 15 deletions(-
Add spaces around operators.
Signed-off-by: Zhang Han
---
qobject/qdict.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qobject/qdict.c b/qobject/qdict.c
index 2c07b3c87f..05ec950e05 100644
--- a/qobject/qdict.c
+++ b/qobject/qdict.c
@@ -42,8 +42,8 @@ static unsigned in
On Sat, Dec 19, 2020 at 10:42:25AM +, Mark Cave-Ayland wrote:
Really needs a commit message.
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/misc/macio/macio.c | 20 +--
> hw/ppc/mac_oldworld.c | 66 +--
> include/hw/misc/macio/macio.h |
Add braces {} for arms of if/for statement
Signed-off-by: Zhang Han
---
qobject/qdict.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qobject/qdict.c b/qobject/qdict.c
index 05ec950e05..0a49b787ab 100644
--- a/qobject/qdict.c
+++ b/qobject/qdict.c
@@ -42,8 +42,9 @@ st
On Fri, Dec 18, 2020 at 11:33:56AM +0100, Greg Kurz wrote:
> Documentation of object_property_iter_init() clearly stipulates that
> "it is forbidden to modify the property list while iterating". But this
> is exactly what we do when resetting transient DR connectors during CAS.
> The call to spapr_
On Fri, Dec 18, 2020 at 11:33:55AM +0100, Greg Kurz wrote:
> Non-transient DRCs are either in the empty or the ready state,
> which means spapr_drc_reset() doesn't change their state. It
> is thus not needed to do any checking. Call spapr_drc_reset()
> unconditionally and squash spapr_drc_transient
On Fri, Dec 18, 2020 at 11:33:58AM +0100, Greg Kurz wrote:
> Documentation of object_child_foreach_recursive() clearly stipulates
> that "it is forbidden to add or remove children from @obj from the @fn
> callback". But this is exactly what we do during machine reset. The call
> to spapr_drc_reset(
On Fri, Dec 18, 2020 at 02:53:24PM +0100, Greg Kurz wrote:
> Running a guest with 128 NUMA nodes crashes QEMU:
>
> ../../util/error.c:59: error_setv: Assertion `*errp == NULL' failed.
>
> The crash happens when setting the FWNMI migration blocker:
>
> 2861 if (spapr_get_cap(spapr, SPAPR_CAP
On Fri, Dec 18, 2020 at 11:33:57AM +0100, Greg Kurz wrote:
> No need to expose the way DRCs are traversed outside of spapr_drc.c.
>
> Signed-off-by: Greg Kurz
Applied, thanks.
> ---
> include/hw/ppc/spapr_drc.h | 6 ++
> hw/ppc/spapr_drc.c | 31 +
> hw/
On Fri, Dec 18, 2020 at 11:33:59AM +0100, Greg Kurz wrote:
> Use a less generic name for an easier experience with tools such as
> cscope or grep.
>
> Signed-off-by: Greg Kurz
Applied to ppc-for-6.0, thanks.
> ---
> hw/ppc/spapr_drc.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 del
Patchew URL:
https://patchew.org/QEMU/20201228071129.24563-1-zhangha...@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201228071129.24563-1-zhangha...@huawei.com
Subject: [PATCH 0/4] Fix some style proble
82 matches
Mail list logo
