Re: [PATCH v12 1/7] Introduce yank feature

2020-12-22 Thread Marc-André Lureau
On Sun, Dec 13, 2020 at 3:48 PM Lukas Straub wrote: > The yank feature allows to recover from hanging qemu by "yanking" > at various parts. Other qemu systems can register themselves and > multiple yank functions. Then all yank functions for selected > instances can be called by the 'yank' out-of

[RFC PATCH 0/3 updated] add support for free hugepage reporting

2020-12-22 Thread Liang Li
A typical usage of hugetlbfs it's to reserve amount of memory during kernel booting, and the reserved pages are unlikely to return to the buddy system. When application need hugepages, kernel will allocate them from the reserved pool. when application terminates, huge pages will return to the res

[RFC PATCH 0/3 updated] add support for free hugepage reporting

2020-12-22 Thread Liang Li
A typical usage of hugetlbfs it's to reserve amount of memory during kernel booting, and the reserved pages are unlikely to return to the buddy system. When application need hugepages, kernel will allocate them from the reserved pool. when application terminates, huge pages will return to the res

Re: [RFC PATCH 2/3] virtio-balloon: add support for providing free huge page reports to host

2020-12-22 Thread David Hildenbrand
On 22.12.20 08:48, Liang Li wrote: > Free page reporting only supports buddy pages, it can't report the > free pages reserved for hugetlbfs case. On the other hand, hugetlbfs The virtio-balloon free page reporting interface accepts a generic sg, so it isn't glue to buddy pages. There is no need fo

Re: [RFC PATCH 3/3] mm: support free hugepage pre zero out

2020-12-22 Thread David Hildenbrand
On 22.12.20 08:49, Liang Li wrote: > This patch add support of pre zero out free hugepage, we can use > this feature to speed up page population and page fault handing. > > Cc: Alexander Duyck > Cc: Mel Gorman > Cc: Andrea Arcangeli > Cc: Dan Williams > Cc: Dave Hansen > Cc: David Hildenbrand

Re: [RFC PATCH 3/3] mm: support free hugepage pre zero out

2020-12-22 Thread David Hildenbrand
On 22.12.20 09:31, David Hildenbrand wrote: > On 22.12.20 08:49, Liang Li wrote: >> This patch add support of pre zero out free hugepage, we can use >> this feature to speed up page population and page fault handing. >> >> Cc: Alexander Duyck >> Cc: Mel Gorman >> Cc: Andrea Arcangeli >> Cc: Dan

Re: [PATCH 3/5] net/tap: tap_set_sndbuf(): return status

2020-12-22 Thread Vladimir Sementsov-Ogievskiy
21.12.2020 23:12, Philippe Mathieu-Daudé wrote: On 12/21/20 8:06 PM, Vladimir Sementsov-Ogievskiy wrote: It's recommended to return a value indicating success / failure for functions with errp parameter (see include/qapi/error.h). Let's update tap_set_sndbuf(). For simple "success/failure" a b

Re: [PATCH 18/20] keyval: Use GString to accumulate value strings

2020-12-22 Thread Paolo Bonzini
On 11/12/20 18:11, Markus Armbruster wrote: QString supports modifying its string, but it's quite limited: you can only append. The remaining callers use it for building an initial string, never for modifying it later. Change keyval_parse_one() to do build the initial string with GString. This

Re: [PATCH 00/20] Immutable QString, and also one JSON writer less

2020-12-22 Thread Paolo Bonzini
On 11/12/20 18:11, Markus Armbruster wrote: Based-on: <20201210161452.2813491-1-arm...@redhat.com> Cc: Daniel P. Berrangé Cc: Dr. David Alan Gilbert Cc: Eduardo Habkost Cc: Juan Quintela Cc: Kevin Wolf Cc: Marcel Apfelbaum Cc: Max Reitz Cc: Paolo Bonzini Cc: Yuval Shaia Cc: qemu-bl...@n

Re: [PATCH 0/6] spapr: Fix visibility and traversal of DR connectors

2020-12-22 Thread Daniel Henrique Barboza
On 12/18/20 7:33 AM, Greg Kurz wrote: Setting a high maxmem value seriously degrades the guest's boot time, from 3 seconds for 1T up to more than 3 minutes for 8T. All this time is spent during initial machine setup and CAS, preventing use of the QEMU monitor in the meantime. Profiling reveal

Re: [PATCH v14 RESEND 05/21] multi-process: Add config option for multi-process QEMU

2020-12-22 Thread Stefan Hajnoczi
On Thu, Dec 17, 2020 at 09:40:35PM -0800, elena.ufimts...@oracle.com wrote: > From: Jagannathan Raman > > Add configuration options to enable or disable multiprocess QEMU code > > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > Signed-off-by: Elena Ufimtseva > --- > config

Re: [PATCH v14 RESEND 08/21] multi-process: add qio channel write function

2020-12-22 Thread Stefan Hajnoczi
On Thu, Dec 17, 2020 at 09:40:38PM -0800, elena.ufimts...@oracle.com wrote: > From: Elena Ufimtseva > > Adds qio_channel_writev_full_all() to transmit both data and FDs. > Refactors existing code to use this function. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-

Re: [PATCH v4] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

2020-12-22 Thread Cornelia Huck
On Mon, 21 Dec 2020 15:34:23 +0100 Thomas Huth wrote: > This initrd contains a virtio-net and a virtio-gpu kernel module, > so we can check that we can set a MAC address for the network device > and whether we can hot-plug and -unplug a virtio-crypto device. > But the most interesting part is may

Re: [PATCH v14 RESEND 09/21] multi-process: add qio channel read function

2020-12-22 Thread Stefan Hajnoczi
On Thu, Dec 17, 2020 at 09:40:39PM -0800, elena.ufimts...@oracle.com wrote: > +int qio_channel_readv_full_all(QIOChannel *ioc, > +const struct iovec *iov, > +size_t niov, > +int **fds, size_t *nfds, > +

Re: [PATCH v14 00/21] Initial support for multi-process Qemu

2020-12-22 Thread Stefan Hajnoczi
On Thu, Dec 17, 2020 at 07:57:47PM -0800, elena.ufimts...@oracle.com wrote: > From: Elena Ufimtseva > > Hi > > This is the v14 of the patchset. Thank you very much for reviewing v13 and > sharing your feedback. Please see Marc-André's comment and my comment about a possible fd/memory leak. Ste

[PULL 00/14] s390x update

2020-12-22 Thread Cornelia Huck
tags/s390x-20201222 for you to fetch changes up to 24bfaae13958b823a4f33b70fca52f086851641f: tests/acceptance: Add a test with the Fedora 31 kernel and initrd (2020-12-22 09:23:09 +0100) Further s390x updates: - enhance the s3

[PULL 02/14] MAINTAINERS: move my git tree to gitlab

2020-12-22 Thread Cornelia Huck
I push to gitlab anyway to get some CI coverage, so let's make it my primary tree to avoid workflow duplication. Signed-off-by: Cornelia Huck Acked-by: Thomas Huth Message-Id: <20201214132628.56019-1-coh...@redhat.com> --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletion

[PULL 03/14] qga/commands-posix: Send CCW address on s390x with the fsinfo data

2020-12-22 Thread Cornelia Huck
From: Thomas Huth We need the CCW address on the libvirt side to correctly identify the disk, so add this information to the GuestDiskAddress on s390x. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Reviewed-by: Michael Roth Message-Id: <20201127082353.448251-1-th...@redhat.com> Signed

[PULL 04/14] target/s390x: Improve cc computation for ADD LOGICAL

2020-12-22 Thread Cornelia Huck
From: Richard Henderson The resulting cc is only dependent on the result and the carry-out. So save those things rather than the inputs. Carry-out for 64-bit inputs is had via tcg_gen_add2_i64 directly into cc_src. Carry-out for 32-bit inputs is had via extraction from a normal 64-bit add (wit

[PULL 06/14] target/s390x: Improve cc computation for SUBTRACT LOGICAL

2020-12-22 Thread Cornelia Huck
From: Richard Henderson The resulting cc is only dependent on the result and the carry-out. Carry-out and borrow-out are inverses, so are trivially converted. With tcg ops, it is easier to compute borrow-out than carry-out, so save result and borrow-out rather than the inputs. Borrow-out for 64-

[PULL 01/14] s390x: pv: Fence additional unavailable SCLP facilities for PV guests

2020-12-22 Thread Cornelia Huck
From: Janosch Frank There's no VSIE support for a protected guest, so let's better not advertise it and its support facilities. Fixes: c3347ed0d2ee ("s390x: protvirt: Support unpack facility") Signed-off-by: Janosch Frank Reviewed-by: Christian Borntraeger Reviewed-by: David Hildenbrand Messa

[PULL 07/14] target/s390x: Improve SUB LOGICAL WITH BORROW

2020-12-22 Thread Cornelia Huck
From: Richard Henderson Now that SUB LOGICAL outputs borrow, we can use that as input directly. It also means we can re-use CC_OP_SUBU and produce an output borrow directly from SUB LOGICAL WITH BORROW. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson Message-Id: <20201214221356

[PULL 11/14] tests/acceptance: Test the virtio-balloon device on s390x

2020-12-22 Thread Cornelia Huck
From: Thomas Huth Inflate the balloon and check whether the size of the memory changes. Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Tested-by: Willian Rampazzo Signed-off-by: Thomas Huth Message-Id: <20201215183623.110128-4-th...@redhat.com> Signed-off-by: Cornelia

[PULL 08/14] tests/acceptance: test hot(un)plug of ccw devices

2020-12-22 Thread Cornelia Huck
Hotplug a virtio-net-ccw device, and then hotunplug it again. Signed-off-by: Cornelia Huck Reviewed-by: Thomas Huth Tested-by: Willian Rampazzo Reviewed-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta Message-Id: <20201208122843.147186-1-coh...@redhat.com> --- tests/acceptance/

[PULL 10/14] tests/acceptance: Test virtio-rng on s390 via /dev/hwrng

2020-12-22 Thread Cornelia Huck
From: Thomas Huth /dev/hwrng is only functional if virtio-rng is working right, so let's add a sanity check for this device node. Reviewed-by: Willian Rampazzo Tested-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Thomas Huth Message-Id: <20201215183623.110128-3

[PULL 05/14] target/s390x: Improve ADD LOGICAL WITH CARRY

2020-12-22 Thread Cornelia Huck
From: Richard Henderson Now that ADD LOGICAL outputs carry, we can use that as input directly. It also means we can re-use CC_OP_ADDU and produce an output carry directly from ADD LOGICAL WITH CARRY. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson Message-Id: <20201214221356.68

[PULL 09/14] tests/acceptance: Extract the code to clear dmesg and wait for CRW reports

2020-12-22 Thread Cornelia Huck
From: Thomas Huth We will use this in more spots soon, so it's easier to put this into a separate function. Reviewed-by: Willian Rampazzo Tested-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Thomas Huth Message-Id: <20201215183623.110128-2-th...@redhat.com> Sig

[PULL 12/14] s390x/pci: fix pcistb length

2020-12-22 Thread Cornelia Huck
From: Matthew Rosato In pcistb_service_call, we are grabbing 8 bits from a guest register to indicate the length of the store operation -- but per the architecture the length is actually defined by 13 bits of the guest register. Fixes: 863f6f52b7 ("s390: implement pci instructions") Signed-off-b

[PULL 13/14] s390x/pci: Fix memory_region_access_valid call

2020-12-22 Thread Cornelia Huck
From: Matthew Rosato In pcistb_service_handler, a call is made to validate that the memory region can be accessed. However, the call is made using the entire length of the pcistb operation, which can be larger than the allowed memory access size (8). Since we already know that the provided buff

[PULL 14/14] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

2020-12-22 Thread Cornelia Huck
From: Thomas Huth This initrd contains a virtio-net and a virtio-gpu kernel module, so we can check that we can set a MAC address for the network device and whether we can hot-plug and -unplug a virtio-crypto device. But the most interesting part is maybe that we can also successfully write some

Re: [PATCH 2/4] fuzz: split QTest writes from the rightmost byte

2020-12-22 Thread Qiuhao Li
On Mon, 2020-12-21 at 15:01 -0500, Alexander Bulekov wrote: > Qiuhao Li writes: > > > Currently, we split the write commands' data from the middle. If it > > does not > > work, try to move the pivot "left" and retry until there is no > > space left. > > But, this is complete for ram writes but no

Re: [PATCH 3/4] fuzz: setting bits in operand of out/write to zero

2020-12-22 Thread Qiuhao Li
On Mon, 2020-12-21 at 15:35 -0500, Alexander Bulekov wrote: > On 201220 0256, Qiuhao Li wrote: > > Simplifying the crash cases by opportunistically setting bits in > > operands of > > out/write to zero may help to debug, since usually bit one means > > turn on > > or > > trigger a function while ze

Re: [PATCH 4/4] fuzz: delay IO until they can't trigger the crash

2020-12-22 Thread Qiuhao Li
On Mon, 2020-12-21 at 16:17 -0500, Alexander Bulekov wrote: > On 201220 0256, Qiuhao Li wrote: > > Since programmers usually trigger an IO just before they need it. > > Try to > > delay some IO instructions may help us better understanding the > > timing > > context when debug. > > > > Tested with

Re: [PATCH 1/4] fuzz: refine crash detection mechanism

2020-12-22 Thread Qiuhao Li
This email looks empty. Is this intentional? On Mon, 2020-12-21 at 13:46 -0500, Alexander Bulekov wrote: >

[PATCH v2] acpi: Permit OEM ID and OEM table ID fields to be changed

2020-12-22 Thread Marian Posteuca
Qemu's ACPI table generation sets the fields OEM ID and OEM table ID to "BOCHS " and "BXPC" where "" is replaced by the ACPI table name. Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID and OEM table ID for the strings "BOCHS" and "BXPC" and if they are found, the game c

Re: [PATCH v2 4/8] hw/pci-host/bonito: Fixup pci.lomem mapping

2020-12-22 Thread Philippe Mathieu-Daudé
On 12/22/20 1:36 AM, Jiaxun Yang wrote: > 在 2020/12/22 上午4:45, Philippe Mathieu-Daudé 写道: >> On 12/19/20 8:18 AM, Jiaxun Yang wrote: >>> The original mapping had wrong base address. >>> Fix by correct the base adress and merge three alias into >>> a single. >> Why merge? Beside, typo "address". >

Re: [PATCH v2] acpi: Permit OEM ID and OEM table ID fields to be changed

2020-12-22 Thread Michael Tokarev
22.12.2020 14:33, Marian Posteuca wrote: Qemu's ACPI table generation sets the fields OEM ID and OEM table ID to "BOCHS " and "BXPC" where "" is replaced by the ACPI table name. Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID and OEM table ID for the strings "BOCHS" a

Re: [RFC PATCH 2/3] virtio-balloon: add support for providing free huge page reports to host

2020-12-22 Thread Liang Li
On Tue, Dec 22, 2020 at 4:28 PM David Hildenbrand wrote: > > On 22.12.20 08:48, Liang Li wrote: > > Free page reporting only supports buddy pages, it can't report the > > free pages reserved for hugetlbfs case. On the other hand, hugetlbfs > > The virtio-balloon free page reporting interface accep

[PATCH 1/9] net: Add spaces around operator/delete redundant spaces

2020-12-22 Thread Zhang Han
Fix problems about spaces: -operator needs spaces around it, add them. -somespaces are redundant, remove them. Signed-off-by: Zhang Han --- net/checksum.c| 4 +-- net/eth.c | 2 +- net/net.c | 2 +- net/queue.c | 2 +- net/socket.c | 12 +++ net/tap-solari

[PATCH 9/9] net: Fix the indent problems

2020-12-22 Thread Zhang Han
Fix Suspect code indent for statements Signed-off-by: Zhang Han --- net/tap-solaris.c | 18 +- net/tap-win32.c | 28 ++-- net/vde.c | 2 +- 3 files changed, 24 insertions(+), 24 deletions(-) diff --git a/net/tap-solaris.c b/net/tap-solaris.c in

[PATCH 5/9] net: Fix lines over 90 characters

2020-12-22 Thread Zhang Han
Fix the line width of code. Signed-off-by: Zhang Han --- net/socket.c| 11 +++ net/tap-win32.c | 39 ++- 2 files changed, 33 insertions(+), 17 deletions(-) diff --git a/net/socket.c b/net/socket.c index 61671e41e3..0093ed2794 100644 --- a/net/sock

[PATCH 6/9] net: Transfer tabs to spcaes

2020-12-22 Thread Zhang Han
Code indent use spaces instead of tabs. Signed-off-by: Zhang Han --- net/tap-linux.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/tap-linux.h b/net/tap-linux.h index 2f36d100fc..db72960c19 100644 --- a/net/tap-linux.h +++ b/net/tap-linux.h @@ -44,10 +44,10 @

[PATCH 0/9] Fix some style problems in net

2020-12-22 Thread Zhang Han
Some style problems in net directory are found by checkpatch.pl. Fix these style problems. Zhang Han (9): net: Add spaces around operator/delete redundant spaces net: Add braces for statements/fix braces' position net: transfer // comments to /**/ net: transfer "foo* bar" to "foo *" net:

[PATCH 4/9] net: Transfer "foo* " to "foo *"

2020-12-22 Thread Zhang Han
Fix style problems about "foo*" -"foo* bar" should be "foo *bar". -"foo* const bar" should be "foo * const bar". -"(foo*)" should be "(foo *)" Signed-off-by: Zhang Han --- net/slirp.c | 2 +- net/tap-win32.c | 34 +- 2 files changed, 18 insertions(+), 18 dele

Re: [RFC PATCH 3/3] mm: support free hugepage pre zero out

2020-12-22 Thread Liang Li
> > Free page reporting in virtio-balloon doesn't give you any guarantees > > regarding zeroing of pages. Take a look at the QEMU implementation - > > e.g., with vfio all reports are simply ignored. > > > > Also, I am not sure if mangling such details ("zeroing of pages") into > > the page reportin

[PATCH 8/9] net: Remove initialization of static ints

2020-12-22 Thread Zhang Han
Do not initialise statics to 0 or NULL Signed-off-by: Zhang Han --- net/tap-solaris.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/tap-solaris.c b/net/tap-solaris.c index d5af4efd60..0b4f709abc 100644 --- a/net/tap-solaris.c +++ b/net/tap-solaris.c @@ -63,10 +63,10

[PATCH 3/9] net: Transfer // comments to /**/

2020-12-22 Thread Zhang Han
Do not use C99 // comments, thransfer // to /**/ Signed-off-by: Zhang Han --- net/checksum.c| 6 ++--- net/tap-solaris.c | 2 +- net/tap-win32.c | 60 +++ 3 files changed, 38 insertions(+), 30 deletions(-) diff --git a/net/checksum.c b/net/che

[PATCH 2/9] net: Add braces for statements/fix braces' position

2020-12-22 Thread Zhang Han
Fix problems about braces: -braces are necessary for all arms of if/for/while statements -open brace { should follow if/for/while statements on the same line -else should follow close brace '}' Signed-off-by: Zhang Han --- net/checksum.c| 3 ++- net/net.c | 24 --

[PATCH 7/9] net: Remove assignment in if condition

2020-12-22 Thread Zhang Han
Put the assignment before the if condition Signed-off-by: Zhang Han --- net/tap-bsd.c | 3 ++- net/tap-solaris.c | 9 ++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/net/tap-bsd.c b/net/tap-bsd.c index dc8f9c8658..d1dca793f9 100644 --- a/net/tap-bsd.c +++ b/net/tap-b

Re: [PATCH v2 1/2] block: report errno when flock fcntl fails

2020-12-22 Thread Philippe Mathieu-Daudé
On 12/21/20 2:49 PM, David Edmondson wrote: > When a call to fcntl(2) for the purpose of manipulating file locks > fails, report the error returned by fcntl. > > Signed-off-by: David Edmondson > --- > block/file-posix.c | 20 +- > tests/qemu-iotests/153.out | 76 +

Re: [PATCH v4 1/2] hw/block: m25p80: Don't write to flash if write is disabled

2020-12-22 Thread Philippe Mathieu-Daudé
On 12/22/20 7:45 AM, Bin Meng wrote: > From: Bin Meng > > When write is disabled, the write to flash should be avoided > in flash_write8(). > > Fixes: 82a2499011a7 ("m25p80: Initial implementation of SPI flash device") > Signed-off-by: Bin Meng > > --- > > (no changes since v2) > > Changes i

Re: [PATCH v2 5/8] hw/mips/fuloong2e: Remove unused env entry

2020-12-22 Thread Philippe Mathieu-Daudé
On 12/19/20 8:21 AM, Jiaxun Yang wrote: > modetty and busclock is not handled by kernel and the parameter > here seems unreasonable. 'busclock' is used by old kernels: https://elixir.bootlin.com/linux/v3.1/source/arch/mips/loongson/common/env.c#L51 'modetty' is likely here because this code was s

Re: [PATCH] iotests: fix _check_o_direct

2020-12-22 Thread Max Reitz
On 18.12.20 19:20, Vladimir Sementsov-Ogievskiy wrote: Unfortunately commit "iotests: handle tmpfs" break running iotests with -nbd -nocache, as _check_o_direct tries to create $TEST_IMG.test_o_direct, but in case of nbd TEST_IMG is smothing like nbd+unix:///... , and test fails with message

Re: [PATCH v15 04/13] qapi: add filter-node-name to block-stream

2020-12-22 Thread Max Reitz
On 16.12.20 07:16, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy [vseme

Re: [PATCH 2/3] hw/misc/pvpanic: add PCI interface support

2020-12-22 Thread Gerd Hoffmann
> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > index 259f9c9..e9512ab 100644 > --- a/include/hw/pci/pci.h > +++ b/include/hw/pci/pci.h > @@ -108,6 +108,7 @@ extern bool pci_available; > #define PCI_DEVICE_ID_REDHAT_MDPY0x000f > #define PCI_DEVICE_ID_REDHAT_NVME0x0010

Re: [PATCH] iotests: fix _check_o_direct

2020-12-22 Thread Vladimir Sementsov-Ogievskiy
22.12.2020 18:15, Max Reitz wrote: On 18.12.20 19:20, Vladimir Sementsov-Ogievskiy wrote: Unfortunately commit "iotests: handle tmpfs" break running iotests with -nbd -nocache, as _check_o_direct tries to create $TEST_IMG.test_o_direct, but in case of nbd TEST_IMG is smothing like s/smothing/s

Re: [PATCH v2] acpi: Permit OEM ID and OEM table ID fields to be changed

2020-12-22 Thread Marian Posteuca
Michael Tokarev writes: > 22.12.2020 14:33, Marian Posteuca wrote: >> Qemu's ACPI table generation sets the fields OEM ID and OEM table ID >> to "BOCHS " and "BXPC" where "" is replaced by the ACPI >> table name. >> >> Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID >

Re: [PATCH v4 2/2] hw/block: m25p80: Implement AAI-WP command support for SST flashes

2020-12-22 Thread Francisco Iglesias
Hi Bin, A couple of minor comments only! On [2020 Dec 22] Tue 14:45:20, Bin Meng wrote: > From: Xuzhou Cheng > > Auto Address Increment (AAI) Word-Program is a special command of > SST flashes. AAI-WP allows multiple bytes of data to be programmed > without re-issuing the next sequential addres

Re: [PATCH v4 2/2] hw/block: m25p80: Implement AAI-WP command support for SST flashes

2020-12-22 Thread Bin Meng
Hi Francisco, On Tue, Dec 22, 2020 at 11:43 PM Francisco Iglesias wrote: > > Hi Bin, > > A couple of minor comments only! > > On [2020 Dec 22] Tue 14:45:20, Bin Meng wrote: > > From: Xuzhou Cheng > > > > Auto Address Increment (AAI) Word-Program is a special command of > > SST flashes. AAI-WP al

Re: [PATCH v4 1/2] hw/block: m25p80: Don't write to flash if write is disabled

2020-12-22 Thread Francisco Iglesias
On [2020 Dec 22] Tue 14:45:19, Bin Meng wrote: > From: Bin Meng > > When write is disabled, the write to flash should be avoided > in flash_write8(). > > Fixes: 82a2499011a7 ("m25p80: Initial implementation of SPI flash device") > Signed-off-by: Bin Meng Reviewed-by: Francisco Iglesias > >

Re: [PATCH v15 09/13] stream: rework backing-file changing

2020-12-22 Thread Max Reitz
On 16.12.20 07:16, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich Stream in stream_prepare calls bdrv_change_backing_file() to change backing-file in the metadata of bs. It may use either backing-file parameter given by user or just take filename of base on job start. Backing fil

Re: [PATCH 2/3] hw/misc/pvpanic: add PCI interface support

2020-12-22 Thread Mihai Carabas
> On 22 Dec 2020, at 17:30, Gerd Hoffmann wrote: > >  >> >> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h >> index 259f9c9..e9512ab 100644 >> --- a/include/hw/pci/pci.h >> +++ b/include/hw/pci/pci.h >> @@ -108,6 +108,7 @@ extern bool pci_available; >> #define PCI_DEVICE_ID_REDHAT_

Re: [PATCH v15 10/13] qapi: block-stream: add "bottom" argument

2020-12-22 Thread Max Reitz
On 16.12.20 07:17, Vladimir Sementsov-Ogievskiy wrote: The code already don't freeze base node and we try to make it prepared for the situation when base node is changed during the operation. In other words, block-stream doesn't own base node. Let's introduce a new interface which should replace

Problems with irq mapping in qemu v5.2

2020-12-22 Thread Guenter Roeck
Hi, commit 459ca8bfa41 ("pci: Assert irqnum is between 0 and bus->nirqs in pci_bus_change_irq_level") added sanity checks to the interrupt number passed to pci_bus_change_irq_level(). That makes sense, given that bus->irq_count is indexed and sized by the number of interrupts. However, as it turn

Re: [PATCH v15 13/13] block: apply COR-filter to block-stream jobs

2020-12-22 Thread Max Reitz
On 16.12.20 07:17, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich This patch completes the series with the COR-filter applied to block-stream operations. Adding the filter makes it possible in future implement discarding copied regions in backing files during the block-stream job,

Re: [PATCH] iotests: fix _check_o_direct

2020-12-22 Thread Max Reitz
On 22.12.20 16:35, Vladimir Sementsov-Ogievskiy wrote: 22.12.2020 18:15, Max Reitz wrote: On 18.12.20 19:20, Vladimir Sementsov-Ogievskiy wrote: Unfortunately commit "iotests: handle tmpfs" break running iotests with -nbd -nocache, as _check_o_direct tries to create $TEST_IMG.test_o_direct, but

Re: [PATCH 1/4] fuzz: refine crash detection mechanism

2020-12-22 Thread Alexander Bulekov
Oops let me try to resend this.. Qiuhao Li writes: > The original crash detection method is to fork a process to test our new > trace input. If the child process exits in time and the second-to-last line > is the same as the first crash, we think it is a crash triggered by the same > bug. Howe

Re: [PATCH 0/9] Fix some style problems in net

2020-12-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201222082340.67405-1-zhangha...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201222082340.67405-1-zhangha...@huawei.com Subject: [PATCH 0/9] Fix some style proble

Re: [PATCH v15 09/13] stream: rework backing-file changing

2020-12-22 Thread Vladimir Sementsov-Ogievskiy
22.12.2020 18:59, Max Reitz wrote: On 16.12.20 07:16, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich Stream in stream_prepare calls bdrv_change_backing_file() to change backing-file in the metadata of bs. It may use either backing-file parameter given by user or just take filenam

Re: Problems with irq mapping in qemu v5.2

2020-12-22 Thread BALATON Zoltan via
Hello, On Tue, 22 Dec 2020, Guenter Roeck wrote: Hi, commit 459ca8bfa41 ("pci: Assert irqnum is between 0 and bus->nirqs in pci_bus_change_irq_level") added sanity checks to the interrupt number passed to pci_bus_change_irq_level(). That makes sense, given that bus->irq_count is indexed and siz

Re: [PATCH v15 10/13] qapi: block-stream: add "bottom" argument

2020-12-22 Thread Vladimir Sementsov-Ogievskiy
22.12.2020 19:07, Max Reitz wrote: On 16.12.20 07:17, Vladimir Sementsov-Ogievskiy wrote: The code already don't freeze base node and we try to make it prepared for the situation when base node is changed during the operation. In other words, block-stream doesn't own base node. Let's introduce

Re: [PATCH v15 13/13] block: apply COR-filter to block-stream jobs

2020-12-22 Thread Vladimir Sementsov-Ogievskiy
22.12.2020 19:20, Max Reitz wrote: On 16.12.20 07:17, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich This patch completes the series with the COR-filter applied to block-stream operations. Adding the filter makes it possible in future implement discarding copied regions in backin

Re: [PATCH v15 10/13] qapi: block-stream: add "bottom" argument

2020-12-22 Thread Vladimir Sementsov-Ogievskiy
22.12.2020 21:00, Vladimir Sementsov-Ogievskiy wrote: We shouldn't have use-cases when backing-fmt is set to something another than final base node. I mean, we shouldn't have use-cases when backing-file is [...] -- Best regards, Vladimir

Re: Problems with irq mapping in qemu v5.2

2020-12-22 Thread Mark Cave-Ayland
On 22/12/2020 16:16, Guenter Roeck wrote: Hi, commit 459ca8bfa41 ("pci: Assert irqnum is between 0 and bus->nirqs in pci_bus_change_irq_level") added sanity checks to the interrupt number passed to pci_bus_change_irq_level(). That makes sense, given that bus->irq_count is indexed and sized by t

Re: [PATCH 4/4] fuzz: delay IO until they can't trigger the crash

2020-12-22 Thread Alexander Bulekov
On 201222 1922, Qiuhao Li wrote: > On Mon, 2020-12-21 at 16:17 -0500, Alexander Bulekov wrote: > > On 201220 0256, Qiuhao Li wrote: > > > Since programmers usually trigger an IO just before they need it. > > > Try to > > > delay some IO instructions may help us better understanding the > > > timing

Re: [PATCH 1/9] tests/docker: Add dockerfile for Alpine Linux

2020-12-22 Thread Wainer dos Santos Moschetta
Hi, On 12/20/20 9:53 PM, Jiaxun Yang wrote: Alpine Linux[1] is a security-oriented, lightweight Linux distribution based on musl libc and busybox. It it popular among Docker guests and embedded applications. Adding it to test against different libc. [1]: https://alpinelinux.org/ Signed-off-b

Re: [PATCH 0/9] Alpine Linux build fix and CI pipeline

2020-12-22 Thread Wainer dos Santos Moschetta
Hi, On 12/21/20 5:25 AM, Jiaxun Yang wrote: On Mon, Dec 21, 2020, at 9:06 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20201221005318.11866-1-jiaxun.y...@flygoat.com/ Hi, This series seems to have some coding style problems. See output below for more information:

Re: [PATCH] RISC-V: Place DTB at 3GB boundary instead of 4GB

2020-12-22 Thread Atish Patra
On Tue, 2020-12-22 at 13:35 +0800, Bin Meng wrote: > Hi Atish, > > On Sat, Dec 19, 2020 at 3:46 AM Atish Patra > wrote: > > > > On Fri, 2020-12-18 at 16:42 +0800, Bin Meng wrote: > > > Hi Atish, > > > > > > On Fri, Dec 18, 2020 at 4:00 PM Atish Patra > > > wrote: > > > > > > > > On Fri, 2020-

Re: [RFC PATCH 1/3] mm: support hugetlb free page reporting

2020-12-22 Thread Alexander Duyck
On Mon, Dec 21, 2020 at 11:47 PM Liang Li wrote: > > Free page reporting only supports buddy pages, it can't report the > free pages reserved for hugetlbfs case. On the other hand, hugetlbfs > is a good choice for a system with a huge amount of RAM, because it > can help to reduce the memory manag

Re: Problems with irq mapping in qemu v5.2

2020-12-22 Thread Guenter Roeck
On 12/22/20 10:23 AM, Mark Cave-Ayland wrote: > On 22/12/2020 16:16, Guenter Roeck wrote: > >> Hi, >> >> commit 459ca8bfa41 ("pci: Assert irqnum is between 0 and bus->nirqs in >> pci_bus_change_irq_level") added sanity checks to the interrupt number passed >> to pci_bus_change_irq_level(). That ma

Re: Problems with irq mapping in qemu v5.2

2020-12-22 Thread BALATON Zoltan via
On Tue, 22 Dec 2020, BALATON Zoltan via wrote: Hello, On Tue, 22 Dec 2020, Guenter Roeck wrote: Hi, commit 459ca8bfa41 ("pci: Assert irqnum is between 0 and bus->nirqs in pci_bus_change_irq_level") added sanity checks to the interrupt number passed to pci_bus_change_irq_level(). That makes s

Re: [RFC PATCH 1/3] mm: support hugetlb free page reporting

2020-12-22 Thread Mike Kravetz
On 12/21/20 11:46 PM, Liang Li wrote: > Free page reporting only supports buddy pages, it can't report the > free pages reserved for hugetlbfs case. On the other hand, hugetlbfs > is a good choice for a system with a huge amount of RAM, because it > can help to reduce the memory management overhead

Re: [PATCH v2] acpi: Permit OEM ID and OEM table ID fields to be changed

2020-12-22 Thread Paolo Bonzini
On 22/12/20 16:39, Marian Posteuca wrote: Qemu's ACPI table generation sets the fields OEM ID and OEM table ID to "BOCHS " and "BXPC" where "" is replaced by the ACPI table name. Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID and OEM table ID for the strings "BOCHS"

Re: [RFC PATCH 1/3] mm: support hugetlb free page reporting

2020-12-22 Thread Mike Kravetz
On 12/22/20 11:59 AM, Alexander Duyck wrote: > On Mon, Dec 21, 2020 at 11:47 PM Liang Li > wrote: >> + >> + if (huge_page_order(h) > MAX_ORDER) >> + budget = HUGEPAGE_REPORTING_CAPACITY; >> + else >> + budget = HUGEPAGE_REPORTING_CAPACITY * 32; > > Wouldn'

Re: Problems with irq mapping in qemu v5.2

2020-12-22 Thread BALATON Zoltan via
On Tue, 22 Dec 2020, Guenter Roeck wrote: On 12/22/20 10:23 AM, Mark Cave-Ayland wrote: On 22/12/2020 16:16, Guenter Roeck wrote: Hi, commit 459ca8bfa41 ("pci: Assert irqnum is between 0 and bus->nirqs in pci_bus_change_irq_level") added sanity checks to the interrupt number passed to pci_bus

Re: Problems with irq mapping in qemu v5.2

2020-12-22 Thread Guenter Roeck
On 12/22/20 2:23 PM, BALATON Zoltan wrote: > On Tue, 22 Dec 2020, BALATON Zoltan via wrote: >> Hello, >> >> On Tue, 22 Dec 2020, Guenter Roeck wrote: >>> Hi, >>> >>> commit 459ca8bfa41 ("pci: Assert irqnum is between 0 and bus->nirqs in >>> pci_bus_change_irq_level") added sanity checks to the inte

[RFC 3/5] pci: introduce apci-index property for PCI device

2020-12-22 Thread Igor Mammedov
In x86/ACPI world, since systemd v197, linux distros are using predictable network interface naming since systemd v197. Which on QEMU based VMs results into path based naming scheme, that names network interfaces based on PCI topology. With this one has to plug NIC in exacly the same bus/slot, whi

[RFC 5/5] tests: acpi: update expected data files

2020-12-22 Thread Igor Mammedov
Expected change is addition of AIDX and PDSM methods at PCI0 scope and _DSM methods (+ _SUN field where it was missing) to each PCI device slot @@ -277,6 +277,54 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x0001) Release (BLCK) Return (Zero)

[RFC 2/5] tests: acpi: temporary whitelist DSDT changes

2020-12-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 21 + 1 file changed, 21 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..5c695cdf37 100644 --- a/tests/qtest/

[RFC 1/5] acpi: add aml_to_decimalstring() and aml_call6() helpers

2020-12-22 Thread Igor Mammedov
it will be used by follow up patches Signed-off-by: Igor Mammedov --- include/hw/acpi/aml-build.h | 3 +++ hw/acpi/aml-build.c | 28 2 files changed, 31 insertions(+) diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h index e727bea1bc..6

[RFC 0/5] pc: support user provided NIC naming/indexing

2020-12-22 Thread Igor Mammedov
Series implements support for 'onboard' naming scheme for network interfaces (1), which is based on PCI firmware spec and lets user to explicitly specify index that will be used by guest to name network interface, ex: -device e1000,acpi-index=33 should make guest rename NIC name to 'eno33' wh

[RFC 4/5] pci: acpi: add _DSM method to PCI devices

2020-12-22 Thread Igor Mammedov
Implement _DSM according to: PCI Firmware Specification 3.1 4.6.7. DSM for Naming a PCI or PCI Express Device Under Operating Systems and wire it up to cold and hot-plugged PCI devices. Feature depends on ACPI hotplug being enabled (as that provides PCI devices descriptions in

Re: [PATCH 0/9] Alpine Linux build fix and CI pipeline

2020-12-22 Thread Jiaxun Yang
On Wed, Dec 23, 2020, at 2:41 AM, Wainer dos Santos Moschetta wrote: > Hi, > > On 12/21/20 5:25 AM, Jiaxun Yang wrote: > > > > On Mon, Dec 21, 2020, at 9:06 AM, no-re...@patchew.org wrote: > >> Patchew URL: > >> https://patchew.org/QEMU/20201221005318.11866-1-jiaxun.y...@flygoat.com/ > >> > >>

Re: Problems with irq mapping in qemu v5.2

2020-12-22 Thread Guenter Roeck
On 12/22/20 2:57 PM, BALATON Zoltan wrote: [ ... ] > I've already forgot about the details but we have analysed it quite throughly > back when the via ide changes were made. Here are some random pointers to > threads that could have some info: > This was the final solution that was merged as th

Re: [PATCH] RISC-V: Place DTB at 3GB boundary instead of 4GB

2020-12-22 Thread Bin Meng
Hi Atish, On Wed, Dec 23, 2020 at 3:59 AM Atish Patra wrote: > > On Tue, 2020-12-22 at 13:35 +0800, Bin Meng wrote: > > Hi Atish, > > > > On Sat, Dec 19, 2020 at 3:46 AM Atish Patra > > wrote: > > > > > > On Fri, 2020-12-18 at 16:42 +0800, Bin Meng wrote: > > > > Hi Atish, > > > > > > > > On Fri

[PATCH] target/riscv/pmp: Raise exception if no PMP entry is configured

2020-12-22 Thread Atish Patra
As per the privilege specification, any access from S/U mode should fail if no pmp region is configured. Signed-off-by: Atish Patra --- target/riscv/op_helper.c | 5 + target/riscv/pmp.c | 4 ++-- target/riscv/pmp.h | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --

[PATCH] vhost-user: Check vhost features for CONFIGURE_MEM_SLOTS

2020-12-22 Thread Dylan Reid
The `CONFIGURE_MEM_SLOTS` feature is specified by vhost, not by virtio. Check the vhost flags for it being set. I noticed this while testing a new vhost implementation that doesn't yet support configuring memory slots and retested with dpdk's block example as well. Signed-off-by: Dylan Reid ---

[PATCH v5 1/2] hw/block: m25p80: Don't write to flash if write is disabled

2020-12-22 Thread Bin Meng
From: Bin Meng When write is disabled, the write to flash should be avoided in flash_write8(). Fixes: 82a2499011a7 ("m25p80: Initial implementation of SPI flash device") Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias --- (no changes since v2) Ch

[PATCH v5 2/2] hw/block: m25p80: Implement AAI-WP command support for SST flashes

2020-12-22 Thread Bin Meng
From: Xuzhou Cheng Auto Address Increment (AAI) Word-Program is a special command of SST flashes. AAI-WP allows multiple bytes of data to be programmed without re-issuing the next sequential address location. Signed-off-by: Xuzhou Cheng Signed-off-by: Bin Meng --- Changes in v5: - remove the

Re: [PATCH] target/riscv/pmp: Raise exception if no PMP entry is configured

2020-12-22 Thread Richard Henderson
On 12/22/20 5:21 PM, Atish Patra wrote: > +++ b/target/riscv/pmp.c > @@ -74,7 +74,7 @@ static inline int pmp_is_locked(CPURISCVState *env, > uint32_t pmp_index) > /* > * Count the number of active rules. > */ > -static inline uint32_t pmp_get_num_rules(CPURISCVState *env) > +inline uint32_t p

  1   2   >