Re: [PATCH] RISC-V: Place DTB at 3GB boundary instead of 4GB

On Fri, 2020-12-18 at 15:33 +0800, Bin Meng wrote: > Hi Atish, > > On Fri, Dec 18, 2020 at 3:27 PM Atish Patra > wrote: > > > > On Fri, 2020-12-18 at 15:21 +0800, Bin Meng wrote: > > > Hi Atish, > > > > > > On Fri, Dec 18, 2020 at 5:48 AM Atish Patra > > > wrote: > > > > > > > > Currently, we

Re: [PATCH v2 0/8] fcntl, sockopt, and ioctl options

Hi Shu-Chun, I'm sorry for the delay. Your series doesn't apply anymore. Could you rebase it and send a new version. I'll merge the 4 first patches. Thanks, Laurent Le 11/08/2020 à 09:09, Shu-Chun Weng a écrit : > Hi Laurent, > > This is a series of 8 patches in 4 groups, putting into a singl

[PULL v2 00/14] Compile QEMU with -Wimplicit-fallthrough

Hi! The following changes since commit 75ee62ac606bfc9eb59310b9446df3434bf6e8c2: Merge remote-tracking branch 'remotes/ehabkost-gl/tags/x86-next-pull-request' into staging (2020-12-17 18:53:36 +) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pull-reque

[PULL 12/14] bsd-user: Silence warnings about missing fallthrough statement

When compiling with -Werror=implicit-fallthrough, the compiler complains about a missing fallthrough annotation in this file. Looking at the code, the fallthrough is indeed wanted here, so let's add a proper comment. Message-Id: <20201217154138.1547274-1-th...@redhat.com> Reviewed-by: Richard Hend

[PULL 13/14] hw/rtc/twl92230: Add missing 'break'

From: Philippe Mathieu-Daudé Add missing 'break' to fix: hw/rtc/twl92230.c: In function ‘menelaus_write’: hw/rtc/twl92230.c:713:5: error: label at end of compound statement 713 | default: | ^~~ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed

[PULL 14/14] configure: Compile with -Wimplicit-fallthrough=2

Coverity always complains about switch-case statements that fall through the next one when there is no comment in between - which could indicate a forgotten "break" statement. Instead of handling these issues after they have been committed, it would be better to avoid them in the build process alre

Re: [PATCH] RISC-V: Place DTB at 3GB boundary instead of 4GB

Hi Atish, On Fri, Dec 18, 2020 at 4:00 PM Atish Patra wrote: > > On Fri, 2020-12-18 at 15:33 +0800, Bin Meng wrote: > > Hi Atish, > > > > On Fri, Dec 18, 2020 at 3:27 PM Atish Patra > > wrote: > > > > > > On Fri, 2020-12-18 at 15:21 +0800, Bin Meng wrote: > > > > Hi Atish, > > > > > > > > On Fri

Ping: [PATCH v2] bugfix: hostmem: Free host_nodes list right after visited

Hi Peter, Friendly ping :-) Are you going to queue this? Thanks, Keqian On 2020/12/10 15:52, Keqian Zhu wrote: > In host_memory_backend_get_host_nodes, we build host_nodes > list and output it to v (a StringOutputVisitor) but forget > to free the list. This fixes the memory leak. > > The memory

[PATCH] whpx: fix compilation

From: Marc-André Lureau When compiling WHPX (on msys2) FAILED: libqemu-x86_64-softmmu.fa.p/target_i386_whpx_whpx-all.c.obj ../target/i386/whpx/whpx-all.c:29:10: fatal error: whp-dispatch.h: No such file or directory 29 | #include "whp-dispatch.h" | ^~~~ Signed-off

Re: [PULL 07/17] i386: move hyperv_vendor_id initialization to x86_cpu_realizefn()

On 12/18/20 2:05 AM, Eduardo Habkost wrote: > On Fri, Dec 18, 2020 at 01:07:33AM +0100, Claudio Fontana wrote: >> On 12/18/20 12:47 AM, Eduardo Habkost wrote: >>> On Fri, Dec 18, 2020 at 12:34:46AM +0100, Claudio Fontana wrote: On 12/17/20 11:53 PM, Eduardo Habkost wrote: > On Thu, Dec 17,

[Bug 1908626] Re: Atomic test-and-set instruction does not work on qemu-user

Interestingly, the spinlock test works after I change tas() implementation FROM __sync_lock_test_and_set(lock, 1); TO __sync_val_compare_and_swap(lock, 0, 1); ## gcc (GCC) 8.3.1 20190311 (Red Hat 8.3.1-3) __sync_lock_test_and_set(lock, 1) disassembly: ``` objdump -S a.out 00400

Re: [PATCH v3 05/10] vfio: Support for RamDiscardMgr in the !vIOMMU case

On 17.12.20 20:59, Alex Williamson wrote: > On Thu, 17 Dec 2020 19:55:55 +0100 > David Hildenbrand wrote: > >> On 17.12.20 19:36, Alex Williamson wrote: >>> On Wed, 16 Dec 2020 15:11:55 +0100 >>> David Hildenbrand wrote: >>> Implement support for RamDiscardMgr, to prepare for virtio-mem

Re: [PATCH v2 1/2] s390x/pci: fix pcistb length

On 17.12.20 23:16, Matthew Rosato wrote: > In pcistb_service_call, we are grabbing 8 bits from a guest register to > indicate the length of the store operation -- but per the architecture > the length is actually defined by 13 bits of the guest register. > > Fixes: 863f6f52b7 ("s390: implement

[PATCH 1/3] hw/block/nvme: cmb enhancements

From: Padmakar Kalghatgi Implement v1.4 logic for configuring the Controller Memory Buffer. The x-legacy-cmb nvme device parameter can be set to revert to v1.3 behavior. Signed-off-by: Padmakar Kalghatgi Signed-off-by: Klaus Jensen --- hw/block/nvme.h | 1 + include/block/nvme.h | 106

[PATCH 2/3] hw/block/nvme: bump to v1.4

From: Klaus Jensen With the new CMB logic in place, bump the implemented specification version to v1.4. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index f3c111ee0a5c..16bf05638bf6 100644

[PATCH 3/3] hw/block/nvme: lift cmb restrictions

From: Klaus Jensen The controller now implements v1.4 and we can lift the restrictions on CMB Data Pointer and Command Independent Locations Support (CDPCILS) and CMB Data Pointer Mixed Locations Support (CDPMLS) since the device really does not care about mixed host/cmb pointers in those cases.

Re: [PATCH v2 2/2] s390x/pci: Fix memory_region_access_valid call

On 12/17/20 11:16 PM, Matthew Rosato wrote: In pcistb_service_handler, a call is made to validate that the memory region can be accessed. However, the call is made using the entire length of the pcistb operation, which can be larger than the allowed memory access size (8). Since we already k

[PATCH 0/3] hw/block/nvme: cmb enhancements and bump to v1.4

From: Klaus Jensen This adds CMB logic from v1.4. To my knowledge, this is the last piece missing for v1.4 compliance, so bump the controller spec version. Please retort if I am jumping the gun. Since the slow-moving (sorry, super poor attempt of humor) Linux kernel nvme driver does not support

Re: [PATCH RFC 0/3] hw/block/nvme: dif-based end-to-end data protection support

On Dec 17 13:14, Keith Busch wrote: > On Thu, Dec 17, 2020 at 10:02:19PM +0100, Klaus Jensen wrote: > > From: Klaus Jensen > > > > This series adds support for extended LBAs and end-to-end data > > protection. Marked RFC, since there are a bunch of issues that could use > > some discussion. > >

Re: [External] Re: [RFC PATCH 0/9] Support for Virtio-fs daemon crash reconnection

On Wed, Dec 16, 2020 at 11:36 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Tue, Dec 15, 2020 at 8:22 PM Jiachen Zhang < > zhangjiachen.jay...@bytedance.com> wrote: > >> Hi, all >> >> We implement virtio-fs crash reconnection in this patchset. The crash >> reconnection of v

Re: [PATCH] whpx: fix compilation

On 18/12/20 09:46, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau When compiling WHPX (on msys2) FAILED: libqemu-x86_64-softmmu.fa.p/target_i386_whpx_whpx-all.c.obj ../target/i386/whpx/whpx-all.c:29:10: fatal error: whp-dispatch.h: No such file or directory 29 | #include "whp-

Re: [PATCH] configure: Fail when specified cross compiler cannot be found

On 17/12/20 18:56, Alex Bennée wrote: To be honest at the moment the information is a little hidden at the top of the output. It would be nice if we could teach meson to echo it in it's nice coloured output. Paolo, Any ideas for the cleanest way to do that? The code in configure is pretty sma

Re: [PATCH] whpx: fix compilation

Hi On Fri, Dec 18, 2020 at 1:51 PM Paolo Bonzini wrote: > On 18/12/20 09:46, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > When compiling WHPX (on msys2) > > > > FAILED: libqemu-x86_64-softmmu.fa.p/target_i386_whpx_whpx-all.c.obj > > ../target/i386/whpx/whpx-all.c:29:10

Re: [PATCH] tests/docker: Use lower case for centos8 powertools

Jiaxun Yang writes: > Our gitlab amd64-centos8-container pipeline constantly fail at: > > 15.36 Error: No matching repo to modify: PowerTools. > > Fix it by convert it to lower case. > > Signed-off-by: Jiaxun Yang Thanks for you patch, we already have a similar fix in flight this PR: Subje

Re: [PATCH 1/9] block/vpc: Make vpc_open() read the full dynamic header

On 17.12.20 17:19, Markus Armbruster wrote: The dynamic header's size is 1024 bytes. vpc_open() reads only the 512 bytes of the dynamic header into buf[]. Works, because it doesn't actually access the second half. However, a colleague told me that GCC 11 warns: ../block/vpc.c:358:51: erro

Re: [PATCH] block/nvme: Do not allow image creation with NVMe block driver

Am 17.12.2020 um 17:17 hat Stefan Hajnoczi geschrieben: > On Mon, Dec 07, 2020 at 06:16:04PM +0100, Philippe Mathieu-Daudé wrote: > > On 12/4/20 11:28 PM, Philippe Mathieu-Daudé wrote: > > > On 12/4/20 5:57 PM, Philippe Mathieu-Daudé wrote: > > >> The NVMe driver does not support image creation. >

[PULL 00/14] Linux user for 6.0 patches

The following changes since commit af3f37319cb1e1ca0c42842ecdbd1bcfc64a4b6f: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' int= o staging (2020-12-15 21:24:31 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-6.0-pul

[PULL 01/14] linux-user/mmap.c: check range of mremap result in target address space

From: Tobias Koch If mremap succeeds, an additional check is performed to ensure that the new address range fits into the target address space. This check was previously perfomed in host address space, with the upper bound fixed to abi_ulong. This patch replaces the static check with a call to `

[PULL 10/14] linux-user: Add most IFTUN ioctls

From: Shu-Chun Weng The three options handling `struct sock_fprog` (TUNATTACHFILTER, TUNDETACHFILTER, and TUNGETFILTER) are not implemented. Linux kernel keeps a user space pointer in them which we cannot correctly handle. Signed-off-by: Josh Kunz Signed-off-by: Shu-Chun Weng Reviewed-by: Laur

[PULL 03/14] linux-user/elfload: Rename MIPS GET_FEATURE() as GET_FEATURE_INSN()

From: Philippe Mathieu-Daudé We want to add macros similar to GET_FEATURE(). As this one use the 'insn_flags' field, rename it GET_FEATURE_INSN(). Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201214003215.344522-3-f4...@amsat.org> Signed-off-by: Laurent V

[PULL 09/14] linux-user: Implement copy_file_range

From: Andreas Schwab Signed-off-by: Andreas Schwab Reviewed-by: Laurent Vivier Message-Id: [lv: copy back offset only if there is no error] Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/l

[PULL 13/14] linux-user/sparc: Don't restore %g7 in sparc64_set_context()

From: Peter Maydell The kernel does not restore the g7 register in sparc64_set_context(); neither should we. (We still save it in sparc64_get_context().) Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-Id: <20201106152738.26026-4-peter.mayd...@linaro.org> Signed-off-by: Lau

[PULL 04/14] linux-user/elfload: Introduce MIPS GET_FEATURE_REG_SET() macro

From: Philippe Mathieu-Daudé ISA features are usually denoted in read-only bits from CPU registers. Add the GET_FEATURE_REG_SET() macro which checks if a CPU register has bits set. Use the macro to check for MSA (which sets the MSAP bit of the Config3 register when the ASE implementation is pres

[PULL 11/14] linux-user/sparc: Correct sparc64_get/set_context() FPU handling

From: Peter Maydell The handling of the FPU state in sparc64_get_context() and sparc64_set_context() is not the same as what the kernel actually does: we unconditionally read and write the FP registers and the FSR, GSR and FPRS, but the kernel logic is more complicated: * in get_context the kern

[PULL 12/14] linux-user/sparc: Remove unneeded checks of 'err' from sparc64_get_context()

From: Peter Maydell Unlike the kernel macros, our __get_user() and __put_user() do not return a failure code. Kernel code typically has a style of err |= __get_user(...); err |= __get_user(...); and then checking err at the end. In sparc64_get_context() our version of the code dropped the acc

[PULL 05/14] linux-user/elfload: Introduce MIPS GET_FEATURE_REG_EQU() macro

From: Philippe Mathieu-Daudé ISA features are usually denoted in read-only bits from CPU registers. Add the GET_FEATURE_REG_EQU() macro which checks if a CPU register has bits set to a specific value. Use the macro to check the 'Architecture Revision' level of the Config0 register, which is '2'

[PULL 06/14] linux-user/elfload: Update HWCAP bits from linux 5.7

From: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201214003215.344522-6-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/elfload.c | 13 + 1 file changed, 13 insertions(+) diff --git a/linux-user/elfload.

Re: [PATCH] whpx: fix compilation

On 18/12/20 11:08, Marc-André Lureau wrote: >   #ifdef CONFIG_WHPX > > -#include "whp-dispatch.h" > +#include > +#include > +#include > >   struct whpx_state { >       uint64_t mem_quota; > This is wrong, just "git mv target/i386/whpx/whp-

[PULL 02/14] linux-user/elfload: Move GET_FEATURE macro out of get_elf_hwcap() body

From: Philippe Mathieu-Daudé As we are going to add more macros, keep the function body clear. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201214003215.344522-2-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/elfload.c | 10 +- 1

[PULL 14/14] linux-user/sparc: Handle tstate in sparc64_get/set_context()

From: Peter Maydell Correctly implement save/restore of the tstate field in sparc64_get_context() and sparc64_set_context(): * Don't use the CWP value from the guest in set_context * Construct and save a tstate value rather than leaving it as zero in get_context To do this we factor out the

[PULL 07/14] linux-user: Add support for MIPS Loongson 2F/3A

From: Philippe Mathieu-Daudé Userland ELF binaries using Loongson SIMD instructions have the HWCAP_LOONGSON_MMI bit set [1]. Binaries compiled for Loongson 3A [2] have the HWCAP_LOONGSON_EXT bit set for the LQ / SQ instructions. [1] commit 8e2d5831e4b ("target/mips: Legalize Loongson insn flags"

[PULL 08/14] docs/user: Display linux-user binaries nicely

From: Philippe Mathieu-Daudé linux-user binaries are displayed altogether. Use the '*' character to force displaying them as bullet list (one list per architecture). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id: <20201119160838.1981709-1-f4...@amsat.org> Signed-

Re: [PATCH 2/9] block/vpc: Don't abuse the footer buffer as BAT sector buffer

On 17.12.20 17:19, Markus Armbruster wrote: create_dynamic_disk() takes a buffer holding the footer as first argument. It writes out the footer (512 bytes), then reuses the buffer to initialize and write out the dynamic header (1024 bytes), then reuses it again to initialize and write out BAT se

[PATCH 6/6] spapr: Model DR connectors as simple objects

Modeling DR connectors as individual devices raises some concerns, as already discussed a year ago in this thread: https://patchew.org/QEMU/20191017205953.13122-1-chel...@linux.vnet.ibm.com/ First, high maxmem settings creates too many DRC devices. This causes scalability issues. It severely incr

Re: [PATCH v2 0/2] Fix _send_qemu_cmd with bash 5.1

Am 17.12.2020 um 16:38 hat Max Reitz geschrieben: > Hi, > > See patch 2 for what’s changed in bash 5.1 that makes this series > necessary, and what we need to do. (tl;dr: Bash presumably fixed a bug > for array slices, and that now breaks nearly all iotests that use > _send_qemu_cmd – but we don’

[PATCH 2/6] spapr: Fix reset of transient DR connectors

Documentation of object_property_iter_init() clearly stipulates that "it is forbidden to modify the property list while iterating". But this is exactly what we do when resetting transient DR connectors during CAS. The call to spapr_drc_reset() can finalize the hot-unplug sequence of a PHB or a PCI

[PATCH 3/6] spapr: Introduce spapr_drc_reset_all()

No need to expose the way DRCs are traversed outside of spapr_drc.c. Signed-off-by: Greg Kurz --- include/hw/ppc/spapr_drc.h | 6 ++ hw/ppc/spapr_drc.c | 31 + hw/ppc/spapr_hcall.c | 40 ++ 3 files changed, 43 ins

[PATCH 1/6] spapr: Call spapr_drc_reset() for all DRCs at CAS

Non-transient DRCs are either in the empty or the ready state, which means spapr_drc_reset() doesn't change their state. It is thus not needed to do any checking. Call spapr_drc_reset() unconditionally and squash spapr_drc_transient() into its only user, spapr_drc_needed(). Signed-off-by: Greg Kur

[PATCH 5/6] spapr: Add drc_ prefix to the DRC realize and unrealize functions

Use a less generic name for an easier experience with tools such as cscope or grep. Signed-off-by: Greg Kurz --- hw/ppc/spapr_drc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index a4d2608017c5..8571d5bafe4e 100644 ---

[PATCH 0/6] spapr: Fix visibility and traversal of DR connectors

Setting a high maxmem value seriously degrades the guest's boot time, from 3 seconds for 1T up to more than 3 minutes for 8T. All this time is spent during initial machine setup and CAS, preventing use of the QEMU monitor in the meantime. Profiling reveals: % cumulative self se

[PATCH 4/6] spapr: Use spapr_drc_reset_all() at machine reset

Documentation of object_child_foreach_recursive() clearly stipulates that "it is forbidden to add or remove children from @obj from the @fn callback". But this is exactly what we do during machine reset. The call to spapr_drc_reset() can finalize the hot-unplug sequence of a PHB or a PCI bridge, bo

[PULL 02/15] monitor:braces {} are necessary for all arms of this statement

From: Yutao Ai Fix the errors by add {} Signed-off-by: Yutao Ai Message-Id: <20201125014514.55562-3-aiyu...@huawei.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Dr. David Alan Gilbert --- monitor/misc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --gi

[PULL 07/15] virtiofsd: Set up posix_lock hash table for root inode

From: Vivek Goyal We setup per inode hash table ->posix_lock to support remote posix locks. But we forgot to initialize this table for root inode. Laszlo managed to trigger an issue where he sent a FUSE_FLUSH request for root inode and lo_flush() found inode with inode->posix_lock NULL and acces

[PULL 00/15] migration queue

From: "Dr. David Alan Gilbert" The following changes since commit 75ee62ac606bfc9eb59310b9446df3434bf6e8c2: Merge remote-tracking branch 'remotes/ehabkost-gl/tags/x86-next-pull-request' into staging (2020-12-17 18:53:36 +) are available in the Git repository at: git://github.com/dagrh

[PULL 01/15] monitor:open brace '{' following struct go on the same line

From: Yutao Ai Move the open brace '{' following struct go on the same line Signed-off-by: Yutao Ai Message-Id: <20201125014514.55562-2-aiyu...@huawei.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Dr. David Alan Gilbert --- monitor/hmp-cmds.c | 3 +-- 1 file changed, 1 insertion(+)

Re: [PATCH v2 for-6.0 0/8] nbd reconnect on open

ping :) 30.11.2020 16:40, Vladimir Sementsov-Ogievskiy wrote: Hi all! There is a new feature: reconnect on open. It is useful when start of vm and start of nbd server are not simple to sync. v2: rebase on master. Also, I've discovered that I've sent downstream version of test which doesn't work

[PULL 03/15] monitor:Don't use '#' flag of printf format ('%#') in format strings

From: Yutao Ai Delete '#' and use '0x' prefix instead Signed-off-by: Yutao Ai Message-Id: <20201125014514.55562-4-aiyu...@huawei.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Dr. David Alan Gilbert --- monitor/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PULL 05/15] virtiofsd: Use --thread-pool-size=0 to mean no thread pool

From: Vivek Goyal Right now we create a thread pool and main thread hands over the request to thread in thread pool to process. Number of threads in thread pool can be managed by option --thread-pool-size. In tests we have noted that many of the workloads are getting better performance if we don

[PULL 06/15] virtiofsd: make the debug log timestamp on stderr more human-readable

From: Laszlo Ersek The current timestamp format doesn't help me visually notice small jumps in time ("small" as defined on human scale, such as a few seconds or a few ten seconds). Replace it with a local time format where such differences stand out. Before: > [13316826770337] [ID: 0004] un

[PULL 09/15] virtiofsd: Check file type in lo_flush()

From: Vivek Goyal Currently lo_flush() is written in such a way that it expects to receive a FLUSH requests on a regular file (and not directories). For example, we call lo_fi_fd() which searches lo->fd_map. If we open directories using opendir(), we keep don't keep track of these in lo->fd_map i

[PULL 04/15] hmp-commands.hx: List abbreviation after command for cont, quit, print

From: Peter Maydell We have four HMP commands which have a single-character abbreviated version: cont ('c'), quit ('q'), print ('p') and help ('h'). For cont, quit and print, we list the abbreviation first in the help documentation and the command name. This has the odd effect that in the full

[PULL 11/15] virtiofsd: Remove useless code about send_notify_iov

From: Alex Chen The 'ch' will be NULL in the following stack: send_notify_iov()->fuse_send_msg()->virtio_send_msg(), and this may lead to NULL pointer dereferenced in virtio_send_msg(). But send_notify_iov() was never called, so remove the useless code about send_notify_iov() to fix this problem.

[PULL 10/15] virtiofsd: update FUSE_FORGET comment on "lo_inode.nlookup"

From: Laszlo Ersek Miklos confirms it's *only* the FUSE_FORGET request that the client can use for decrementing "lo_inode.nlookup". Cc: "Dr. David Alan Gilbert" Cc: Miklos Szeredi Cc: Stefan Hajnoczi Fixes: 1222f015558fc34cea02aa3a5a92de608c82cec8 Signed-off-by: Laszlo Ersek Message-Id: <202

[PULL 08/15] virtiofsd: Disable posix_lock hash table if remote locks are not enabled

From: Vivek Goyal If remote posix locks are not enabled (lo->posix_lock == false), then disable code paths taken to initialize inode->posix_lock hash table and corresponding destruction and search etc. lo_getlk() and lo_setlk() have been modified to return ENOSYS if daemon does not support posix

Re: [PATCH 00/11] mirror: cancel nbd reconnect

ping 18.11.2020 21:04, Vladimir Sementsov-Ogievskiy wrote: Hi all! The problem Assume we have mirror job with nbd target node with enabled reconnect. Connection failed. So, all current requests to nbd node are waiting for nbd driver to reconnect. And they will wait for reconnect-delay time spe

[PULL 13/15] savevm: Remove dead code in save_snapshot()

From: Tuguoyi The snapshot in each bs is deleted at the beginning, so there is no need to find the snapshot again. Signed-off-by: Tuguoyi Message-Id: <1607410416-13563-2-git-send-email-tu.gu...@h3c.com> Reviewed-by: Denis V. Lunev Signed-off-by: Dr. David Alan Gilbert --- migration/savevm.c

[PULL 12/15] docs/devel/migration: Improve debugging section a bit

From: Markus Armbruster Fix typos, and make the example work out of the box. Signed-off-by: Markus Armbruster Message-Id: <20201217071450.701909-1-arm...@redhat.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- docs/devel/migration.rst | 11 ++- 1 fil

Re: [PATCH 0/9] block/vpc: Clean up some buffer abuse

Am 17.12.2020 um 17:19 hat Markus Armbruster geschrieben: > Markus Armbruster (9): > block/vpc: Make vpc_open() read the full dynamic header > block/vpc: Don't abuse the footer buffer as BAT sector buffer > block/vpc: Don't abuse the footer buffer for dynamic header > block/vpc: Make vpc_ch

Re: [PATCH] whpx: fix compilation

Hi On Fri, Dec 18, 2020 at 2:28 PM Paolo Bonzini wrote: > On 18/12/20 11:08, Marc-André Lureau wrote: > > > #ifdef CONFIG_WHPX > > > > > > -#include "whp-dispatch.h" > > > +#include > > > +#include > > > +#include > > > > > > struct whpx_state { > >

[PULL 15/15] migration: Don't allow migration if vm is in POSTMIGRATE

From: Tuguoyi The following steps will cause qemu assertion failure: - pause vm by executing 'virsh suspend' - create external snapshot of memory and disk using 'virsh snapshot-create-as' - doing the above operation again will cause qemu crash The backtrace looks like: at /build/qemu-5.0/mig

[PULL 14/15] savevm: Delete snapshots just created in case of error

From: Tuguoyi bdrv_all_create_snapshot() can fails with some snapshots created, so it's better to delete those snapshots before returns to the caller Signed-off-by: Tuguoyi Message-Id: <1607410416-13563-3-git-send-email-tu.gu...@h3c.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. D

Re: [PATCH 7/9] block/vpc: Pad VHDFooter, replace uint8_t[] buffers

On 17.12.20 17:20, Markus Armbruster wrote: Pad VHDFooter as specified in the "Virtual Hard Disk Image Format Specification" version 1.0[*]. Change footer buffers from uint8_t[HEADER_SIZE] to VHDFooter. Their size remains the same. The VHDFooter * variables pointing to a VHDFooter variable rig

Re: [PATCH v2] fuzz: map all BARs and enable PCI devices

On 15/12/2020 20.08, Alexander Bulekov wrote: > Prior to this patch, the fuzzer found inputs to map PCI device BARs and > enable the device. While it is nice that the fuzzer can do this, it > added significant overhead, since the fuzzer needs to map all the > BARs (regenerating the memory topology)

Re: [PATCH v2] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD

On 11/12/2020 14.09, Thomas Huth wrote: > On 10/12/2020 10.32, AL Yu-Chen Cho wrote: >> Hi Thomas, >> >> I try to reproduce this failed in my repo, but it seems works fine. >> Would you please give it a try again? I think you maybe just hit a bad >> point in time... > > I just re-tried, but it sti

Re: [PATCH 5/9] block/vpc: Pad VHDDynDiskHeader, replace uint8_t[] buffers

On 17.12.20 17:19, Markus Armbruster wrote: Pad VHDDynDiskHeader as specified in the "Virtual Hard Disk Image Format Specification" version 1.0[*]. Change dynamic disk header buffers from uint8_t[1024] to VHDDynDiskHeader. Their size remains the same. The VHDDynDiskHeader * variables pointing

Re: [PATCH 3/9] block/vpc: Don't abuse the footer buffer for dynamic header

On 17.12.20 17:19, Markus Armbruster wrote: create_dynamic_disk() takes a buffer holding the footer as first argument. It writes out the footer (512 bytes), then reuses the buffer to initialize and write out the dynamic header (1024 bytes). Works, because the caller passes a buffer that is larg

Re: [PATCH v2 2/2] s390x/pci: Fix memory_region_access_valid call

On Fri, 18 Dec 2020 10:37:38 +0100 Pierre Morel wrote: > On 12/17/20 11:16 PM, Matthew Rosato wrote: > > In pcistb_service_handler, a call is made to validate that the memory > > region can be accessed. However, the call is made using the entire length > > of the pcistb operation, which can be l

Re: [PATCH 4/9] block/vpc: Make vpc_checksum() take void *

On 17.12.20 17:19, Markus Armbruster wrote: Some of the next commits will checksum structs. Change vpc_checksum() to take void * instead of uint8_t, to save us pointless casts to uint8_t *. Signed-off-by: Markus Armbruster --- block/vpc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH 6/9] block/vpc: Use sizeof() instead of 1024 for dynamic header size

On 17.12.20 17:20, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- block/vpc.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Max Reitz

Re: [PATCH 8/9] block/vpc: Pass footer buffers as VHDFooter * instead of uint8_t *

On 17.12.20 17:20, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- block/vpc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Max Reitz (Some mumbling about const pointers in the distance)

Re: [PATCH 9/9] block/vpc: Use sizeof() instead of HEADER_SIZE for footer size

On 17.12.20 17:20, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- block/vpc.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) Reviewed-by: Max Reitz

Re: [PULL v2 00/11] testing and configure updates

On Thu, 17 Dec 2020 at 23:43, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Thu, 17 Dec 2020 at 09:43, Alex Bennée wrote: > >> > >> The following changes since commit > >> af3f37319cb1e1ca0c42842ecdbd1bcfc64a4b6f: > >> > >> Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/f

Re: [PATCH] whpx: fix compilation

On 12/18/20 9:46 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > When compiling WHPX (on msys2) > > FAILED: libqemu-x86_64-softmmu.fa.p/target_i386_whpx_whpx-all.c.obj > ../target/i386/whpx/whpx-all.c:29:10: fatal error: whp-dispatch.h: No such > file or directory >29 |

[PATCH v2 1/9] test/guest-debug: echo QEMU command as well

This helps with debugging. Signed-off-by: Alex Bennée Message-Id: <20201214153012.12723-2-alex.ben...@linaro.org> Signed-off-by: Alex Bennée --- tests/guest-debug/run-test.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/guest-debug/run-test.py b/tests/guest-debug/run-test.py index

[PATCH v2 0/9] gdbstub/next (cleanups, softmmu, SVE)

Hi, This is the next iteration of gdbstub/next. Apart from adding review tags there are a few new patches: - now the 8.3.1 gating is there we can revert the disable of gdbstub-sha1 - addition of some softmmu tests (which exercise watchpoints) - moving the SVE target representation to org.gnu.g

[PATCH v2 2/9] configure: gate our use of GDB to 8.3.1 or above

The support of socket based debugging which we need for linux-user testing is only really stable as of 8.3.1 so lets gate our use of GDB on having a relatively modern version. For direct testing you can just point to a locally compiled version of gdb via configure, e.g.: ../../configure --gdb=$

[PATCH v2 3/9] Revert "tests/tcg/multiarch/Makefile.target: Disable run-gdbstub-sha1 test"

We won't attempt to run the test now it's gated on a newer version of gdb. This reverts commit a930cadd83b4681a98ce72abf530a791ee2e42a6. Signed-off-by: Alex Bennée --- tests/tcg/multiarch/Makefile.target | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/tcg/multiarch/M

[PATCH v2 7/9] gdbstub: drop gdbserver_cleanup in favour of gdb_exit

Despite it's name it didn't actually clean-up so let us document gdb_exit() better and use that. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20201214153012.12723-6-alex.ben...@linaro.org> Signed-off-by: Alex Bennée --- include/exec/gdbstub.h | 14 +++--- gdbs

Re: Question about migration of a VM between hosts having slight difference in TSC Frequency

Veselina Radeva writes: > Hi, > > I'm trying to migrate a VM from one host to another where there is a 1KHz > difference in the TSC frequency between hosts. This results in errors > caused by this warning >

[PATCH v2 6/9] gdbstub: drop CPUEnv from gdb_exit()

gdb_exit() has never needed anything from env and I doubt we are going to start now. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20201214153012.12723-5-alex.ben...@linaro.org> Signed-off-by: Alex Bennée --- include/exec/gdbstub.h| 2 +- bsd-user/syscall.c

[PATCH v2 9/9] target/arm: use official org.gnu.gdb.aarch64.sve layout for registers

While GDB can work with any XML description given to it there is special handling for SVE registers on the GDB side which makes the users life a little better. The changes aren't that major and all the registers save the $vg reported the same. All that changes is: - report org.gnu.gdb.aarch64.sv

[PATCH v2 4/9] gdbstub: implement a softmmu based test

This adds a new tests that allows us to test softmmu only features including watchpoints. To do achieve this we need to: - add _exit: labels to the boot codes - write a memory.py test case - plumb the test case into the build system - tweak the run_test script to: - re-direct output wh

Re: [PATCH v2 02/12] libqtest: add qtest_socket_server()

On 07/12/2020 18.20, Stefan Hajnoczi wrote: > Add an API that returns a new UNIX domain socket in the listen state. > The code for this was already there but only used internally in > init_socket(). > > This new API will be used by vhost-user-blk-test. > > Signed-off-by: Stefan Hajnoczi > --- >

[PATCH v2 8/9] gdbstub: ensure we clean-up when terminated

If you kill the inferior from GDB we end up leaving our socket lying around. Fix this by calling gdb_exit() first. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20201214153012.12723-7-alex.ben...@linaro.org> Signed-off-by: Alex Bennée --- gdbstub.c | 2 ++ 1 file chang

[PATCH v2 5/9] gdbstub: add support to Xfer:auxv:read: packet

From: Lirong Yuan This allows gdb to access the target’s auxiliary vector, which can be helpful for telling system libraries important details about the hardware, operating system, and process. [AJB: minor tweaks to test case, update MAINTAINERS] Signed-off-by: Lirong Yuan Signed-off-by: Alex

Re: [PATCH v14 04/21] socket: export socket_get_fd() function

Hi On Fri, Dec 18, 2020 at 7:59 AM wrote: > From: Jagannathan Raman > > Export socket_get_fd() helper function. The function protorype is > changed to be more generic. Use monitor_fd_param() instead of > monitor_fd_get() in order to support named fds as well. > > Signed-off-by: Jagannathan Rama

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

On Thu, 17 Dec 2020 15:15:30 +0100 Greg Kurz wrote: > On Thu, 17 Dec 2020 12:38:42 +0100 > Cornelia Huck wrote: > > > On Thu, 17 Dec 2020 16:47:36 +1100 > > David Gibson wrote: > > > > > On Mon, Dec 14, 2020 at 06:22:40PM +0100, Cornelia Huck wrote: > > > > On Fri, 4 Dec 2020 16:44:13 +1

Re: [PULL v2 00/11] testing and configure updates

Peter Maydell writes: > On Thu, 17 Dec 2020 at 23:43, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> >> > On Thu, 17 Dec 2020 at 09:43, Alex Bennée wrote: >> >> >> >> The following changes since commit >> >> af3f37319cb1e1ca0c42842ecdbd1bcfc64a4b6f: >> >> >> >> Merge remote-tracking

Re: [PATCH v1 1/1] chardev: enable guest socket status/crontrol via DTR and DCD

Hi On Thu, Dec 17, 2020 at 9:54 PM Darrin M. Gorski wrote: > > > That sounds like a good idea to me, but others may have different > opinions. > > My original idea was simply to allow DCD to track socket state, because > this is what I need. The DTR idea came from the referenced bug. The > fea

Re: [PATCH] configure: Fail when specified cross compiler cannot be found

Paolo Bonzini writes: > On 17/12/20 18:56, Alex Bennée wrote: >> To be honest at the moment the information is a little hidden at the top >> of the output. It would be nice if we could teach meson to echo it in >> it's nice coloured output. >> >> Paolo, >> >> Any ideas for the cleanest way to

  1   2   3   >