Re: [PATCH 08/12] qapi/schema: make QAPISourceInfo mandatory

2020-12-17 Thread Markus Armbruster
John Snow writes: > On 12/16/20 5:18 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> -- >>> >>> events.py had an info to route, was it by choice that it wasn't before? >> >> See below. >> >> I figure this is intentionally below the -- line, but ... >> >>> Signed-off-by: John Snow >

Re: [PATCH v6 0/4] migration: UFFD write-tracking migration/snapshots

2020-12-17 Thread Andrey Gruzdev
On 17.12.2020 00:02, Peter Xu wrote: On Tue, Dec 15, 2020 at 10:53:13PM +0300, Andrey Gruzdev wrote: First are series of runs without scan-rate-limiting.patch. Windows 10: msecs : count distribution 0 -> 1 : 131913 |**

Re: [PULL 00/11] testing and configure updates

2020-12-17 Thread Alex Bennée
Peter Maydell writes: > On Wed, 16 Dec 2020 at 18:24, Alex Bennée wrote: >> >> >> Alex Bennée writes: >> >> > The following changes since commit >> > af3f37319cb1e1ca0c42842ecdbd1bcfc64a4b6f: >> > >> > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' >> > into stagi

[PATCH 4/4] configure: remove CONFIG_FILEVERSION and CONFIG_PRODUCTVERSION

2020-12-17 Thread Paolo Bonzini
version.rc can just use existing preprocessor symbols. Signed-off-by: Paolo Bonzini --- configure | 9 - version.rc | 4 ++-- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/configure b/configure index 568818e72d..74eebfd692 100755 --- a/configure +++ b/configure @@ -592

[PATCH 2/4] configure: remove variable bogus_os

2020-12-17 Thread Paolo Bonzini
The condition can be tested also from $targetos, clean up. Signed-off-by: Paolo Bonzini --- configure | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/configure b/configure index 085a5ad7ff..18af8207d9 100755 --- a/configure +++ b/configure @@ -467,7 +467,6 @@ gettext="auto

[PATCH 1/4] configure: remove useless code to check for Xen PCI passthrough

2020-12-17 Thread Paolo Bonzini
meson.build is already doing the same check, so remove it from configure. Signed-off-by: Paolo Bonzini --- configure | 12 1 file changed, 12 deletions(-) diff --git a/configure b/configure index 708cf365f0..085a5ad7ff 100755 --- a/configure +++ b/configure @@ -2879,18 +2879,6 @@ E

[PATCH 3/4] configure: accept --enable-slirp

2020-12-17 Thread Paolo Bonzini
Meson understands -Dslirp=enabled, so there is no reason not to accept the configure option as well. Signed-off-by: Paolo Bonzini --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index 18af8207d9..568818e72d 100755 --- a/configure +++ b/configure @@ -1083

[PATCH 0/4] First batch of configure cleanups

2020-12-17 Thread Paolo Bonzini
After the Meson cleanups from yesterday, here are some small improvements to configure, mostly removing obsolete code. Paolo Paolo Bonzini (4): configure: remove useless code to check for Xen PCI passthrough configure: remove variable bogus_os configure: accept --enable-slirp configure:

[PATCH v2] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

2020-12-17 Thread Thomas Huth
This initrd contains a virtio-net and a virtio-gpu kernel module, so we can check that we can set a MAC address for the network device and whether we can hot-plug and -unplug a virtio-crypto device. But the most interesting part is maybe that we can also successfully write some stuff into the emula

Re: [PATCH 2/4] configure: remove variable bogus_os

2020-12-17 Thread Thomas Huth
On 17/12/2020 09.50, Paolo Bonzini wrote: > The condition can be tested also from $targetos, clean up. > > Signed-off-by: Paolo Bonzini > --- > configure | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/configure b/configure > index 085a5ad7ff..18af8207d9 100755 > ---

Re: [PATCH 3/4] configure: accept --enable-slirp

2020-12-17 Thread Thomas Huth
On 17/12/2020 09.50, Paolo Bonzini wrote: > Meson understands -Dslirp=enabled, so there is no reason not to > accept the configure option as well. > > Signed-off-by: Paolo Bonzini > --- > configure | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configure b/configure > index 18af8207

[PATCH] vl: initialize displays _after_ exiting preconfiguration

2020-12-17 Thread Paolo Bonzini
Due to the renumbering of text consoles when graphical consoles are created, init_displaystate must be called after all QemuConsoles are created, i.e. after devices are created. vl.c calls it from qemu_init_displays, while qmp_x_exit_preconfig is where devices are created. If qemu_init_displays i

[Bug 1908489] Re: qemu 4.2 bootloops with -cpu host and nested hypervisor

2020-12-17 Thread Luqman
** Attachment added: "vmxcap" https://bugs.launchpad.net/qemu/+bug/1908489/+attachment/555/+files/vmxcap.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908489 Title: qemu 4.2 bootloops

[Bug 1908489] Re: qemu 4.2 bootloops with -cpu host and nested hypervisor

2020-12-17 Thread Luqman
** Attachment added: "cpuinfo.txt" https://bugs.launchpad.net/qemu/+bug/1908489/+attachment/556/+files/cpuinfo.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908489 Title: qemu 4.2 boot

[PATCH v1 0/3] Fix some style problems in block

2020-12-17 Thread chaihaoyu
This patch fixed some code style problems while using checkpatch.pl tool, please review. Date: Wen, 16 Dec 2020 17:19:37 +0800 Subject: [PATCH] Fix some style problems in block signed-off-by: Haoyu Chai --- Haoyu Chai (3): block: some space-style errors while coding block: braces {} are nece

[PATCH v1 1/3] some space-style errors while coding

2020-12-17 Thread chaihaoyu
This patch fixes error style problems found by checkpatch.pl, please review: some space-style errors while coding Signed-off-by: Haoyu Chai --- block/bochs.c| 10 block/cloop.c| 2 +- block/curl.c | 7 +++ block/dmg.c | 4 +- block/file-posix.c

[PATCH v1 3/3] block: "(foo*)" should be "(foo *)"

2020-12-17 Thread chaihaoyu
This patch fixes error style problems found by checkpatch.pl, please review: "(foo*)" should be "(foo *)" Signed-off-by: Haoyu Chai --- block/curl.c | 2 +- block/file-win32.c | 2 +- block/qcow2.c| 10 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/blo

[PATCH v1 2/3]block: braces {} are necessary for all arms of this statement

2020-12-17 Thread chaihaoyu
This patch fixes error style problems found by checkpatch.pl, please review: braces {} are necessary for all arms of this statement Signed-off-by: Haoyu Chai --- block/bochs.c| 6 ++- block/commit.c | 3 +- block/curl.c | 15 +++-- block/file-posix.c | 27 ++--- blo

Re: [PATCH v5 0/6] linux-user: Rework get_elf_hwcap() and support MIPS Loongson 2F/3A

2020-12-17 Thread Laurent Vivier
Le 14/12/2020 à 01:32, Philippe Mathieu-Daudé a écrit : > Series now fully reviewed. > > Since v5: > - Dropped MAINTAINERS patch =) > > Since v4: > - Fixed yet another typo... > > Since v3: > - Add CP0C0_AR_LENGTH definition (Richard) > - Fixed 3E -> 3A, Longsoon -> Loongson typos (Huacai) > >

Re: [PATCH v2 2/4] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

2020-12-17 Thread Sergio Lopez
On Wed, Dec 16, 2020 at 07:31:02PM +0100, Kevin Wolf wrote: > Am 16.12.2020 um 15:55 hat Sergio Lopez geschrieben: > > On Wed, Dec 16, 2020 at 01:35:14PM +0100, Kevin Wolf wrote: > > > Am 15.12.2020 um 18:23 hat Sergio Lopez geschrieben: > > > > On Tue, Dec 15, 2020 at 04:01:19PM +0100, Kevin Wolf

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2020-12-17 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Thu, Nov 19, 2020 at 11:32:21AM +0100, Vitaly Kuznetsov wrote: >> Enabling Hyper-V emulation for a Windows VM is a tiring experience as it >> requires listing all currently supported enlightenments ("hv_*" CPU >> features) explicitly. We do have a 'hv_passthrough' mod

Re: [PATCH 16/20] migration: Replace migration's JSON writer by the general one

2020-12-17 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Commit 8118f0950f "migration: Append JSON description of migration > >> stream" needs a JSON writer. The existing qobject_to_json() wasn't a > >> good fit,

[PATCH 00/22] meson: move detection of various libraries to meson.build

2020-12-17 Thread Paolo Bonzini
Not particularly interesting except for the diffstat and for the removal of curl compatibility code. I am sending this in preparation for another RFC around automatically parsing configure command line options. This uses Meson build option introspection data in order to parse --enable and --disab

[PATCH 01/18] brlapi: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- chardev/meson.build | 2 +- configure | 32 meson.build | 20 +--- meson_options.txt | 2 ++ 4 files changed, 24 insertions(+), 32 deletions(-) diff --git a/chardev/meson.build b/chardev/meson

[PATCH 03/18] curl: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 31 --- contrib/elf2dmp/meson.build | 2 +- meson.build | 11 +++ meson_options.txt | 2 ++ 4 files changed, 14 insertions(+), 32 deletions(-) diff --git a/configure b/c

[PATCH 12/18] lzfse: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 31 --- meson.build | 19 +++ meson_options.txt | 2 ++ 3 files changed, 21 insertions(+), 31 deletions(-) diff --git a/configure b/configure index aee27d9cdd..ea5650acca 100755 --- a/configur

[PATCH 11/18] snappy: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 32 meson.build | 19 +++ meson_options.txt | 2 ++ 3 files changed, 21 insertions(+), 32 deletions(-) diff --git a/configure b/configure index f52f04d0e3..aee27d9cdd 100755 --- a/configu

[PATCH 02/18] curl: remove compatibility code, require 7.29.0

2020-12-17 Thread Paolo Bonzini
cURL 7.16.0 was released in October 2006. Just remove code that is in all likelihood not being used anywhere, and require the oldest version found in currently supported distros, which is 7.29.0 from CentOS 7. pkg-config is enough for QEMU, since it does not need extra information such as the pat

[PATCH 10/18] lzo: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 32 meson.build | 20 meson_options.txt | 2 ++ 3 files changed, 22 insertions(+), 32 deletions(-) diff --git a/configure b/configure index e34885d505..f52f04d0e3 100755 --- a/config

[PATCH 09/18] rbd: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 35 --- meson.build | 22 +++--- meson_options.txt | 2 ++ 3 files changed, 25 insertions(+), 34 deletions(-) diff --git a/configure b/configure index f3271381f1..e34885d505 100755 --- a/c

Re: [PULL 00/11] testing and configure updates

2020-12-17 Thread Alex Bennée
Peter Maydell writes: > On Wed, 16 Dec 2020 at 18:24, Alex Bennée wrote: >> >> >> Alex Bennée writes: >> >> > The following changes since commit >> > af3f37319cb1e1ca0c42842ecdbd1bcfc64a4b6f: >> > >> > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' >> > into stagi

[PATCH 05/18] bzip2: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 31 --- meson.build | 18 +++--- meson_options.txt | 2 ++ 3 files changed, 21 insertions(+), 30 deletions(-) diff --git a/configure b/configure index 5529ac4b32..082ac3bf35 100755 --- a/configure

[PATCH 13/18] zstd: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 30 -- meson.build | 10 ++ meson_options.txt | 2 ++ migration/meson.build | 2 +- 4 files changed, 13 insertions(+), 31 deletions(-) diff --git a/configure b/configure index ea5650acca.

[PATCH 18/18] meson.build: convert --with-default-devices to meson

2020-12-17 Thread Paolo Bonzini
Pass the boolean option directly instead of writing CONFIG_MINIKCONF_MODE to config-host.mak. Signed-off-by: Paolo Bonzini --- configure | 13 - meson.build | 5 +++-- meson_options.txt | 2 ++ 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/configure

[PATCH 07/18] libnfs: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 27 --- meson.build | 9 ++--- meson_options.txt | 2 ++ 3 files changed, 12 insertions(+), 26 deletions(-) diff --git a/configure b/configure index e22c56e8f6..c404252b17 100755 --- a/configure +++ b/config

[PATCH 15/18] virtfs: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 29 - meson.build | 24 ++-- meson_options.txt | 11 +++ 3 files changed, 33 insertions(+), 31 deletions(-) diff --git a/configure b/configure index 00c2d61a96..11d6f40f92 100755 --

[PATCH 17/18] libattr: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 45 - meson.build | 38 +++--- meson_options.txt | 2 ++ 3 files changed, 41 insertions(+), 44 deletions(-) diff --git a/configure b/configure index faee71612f.

[PATCH 16/18] cap_ng: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 34 -- meson.build | 24 meson_options.txt | 2 ++ tools/meson.build | 4 ++-- 4 files changed, 28 insertions(+), 36 deletions(-) diff --git a/configure b/configure index 11d6f40

[PULL v2 00/11] testing and configure updates

2020-12-17 Thread Alex Bennée
The following changes since commit af3f37319cb1e1ca0c42842ecdbd1bcfc64a4b6f: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2020-12-15 21:24:31 +) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-171220-

[PATCH 06/18] libiscsi: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/meson.build | 2 +- configure | 29 - contrib/vhost-user-scsi/meson.build | 2 +- meson.build | 10 ++ meson_options.txt | 2 ++ 5 fi

[PATCH 14/18] seccomp: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 32 meson.build| 10 ++ meson_options.txt | 2 ++ softmmu/meson.build| 2 +- softmmu/qemu-seccomp.c | 2 -- tools/meson.build | 4 ++-- 6 files changed, 15 insertions(+

Re: [PATCH] linux-user/elfload: Fix handling of pure BSS segments

2020-12-17 Thread Laurent Vivier
Le 18/11/2020 à 17:52, Stephen Long a écrit : > qemu-user fails to load ELFs with only BSS and no data section > > Signed-off-by: Ben Hutchings > Signed-off-by: Stephen Long > --- > > Submitting this on behalf of Ben Hutchings. Feel free to edit the commit > msg. > > linux-user/elfload.c | 2

[PATCH 04/18] glusterfs: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 102 ++ meson.build | 46 +++-- meson_options.txt | 2 + 3 files changed, 48 insertions(+), 102 deletions(-) diff --git a/configure b/configure index 71196b1fe7..5529ac4b32 1

Re: Bug: qemu-system-ppc -M mac99 boots into compat-monitor, not openbios.

2020-12-17 Thread Paolo Bonzini
On 16/12/20 22:16, Howard Spoelstra wrote: Hi all, It seems a qemu-system-ppc from current master no longer boots into openbios, but into to the compat monitor. Command line to reproduce: /home/hsp/src/qemu-master/build/qemu-system-ppc \ -L pc-bios \ -M mac99,via=pmu -m 1024 -boot c \ -drive f

Re: [PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-17 Thread Laurent Desnogues
Hi Leif, On Tue, Dec 15, 2020 at 5:49 PM Leif Lindholm wrote: > > On Tue, Dec 15, 2020 at 13:23:58 +0100, Laurent Desnogues wrote: > > Hello, > > > > On Tue, Dec 15, 2020 at 12:51 PM Leif Lindholm wrote: > > > > > > Signed-off-by: Leif Lindholm > > > --- > > > target/arm/cpu.h | 24 +++

[PATCH 08/18] libssh: convert to meson

2020-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 45 - meson.build | 18 ++ meson_options.txt | 2 ++ 3 files changed, 20 insertions(+), 45 deletions(-) diff --git a/configure b/configure index c404252b17..f3271381f1 100755 -

Re: [PATCH-for-5.2] docs/user: Display linux-user binaries nicely

2020-12-17 Thread Laurent Vivier
Le 19/11/2020 à 17:08, Philippe Mathieu-Daudé a écrit : > linux-user binaries are displayed altogether. Use the '*' > character to force displaying them as bullet list (one list > per architecture). > > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/user/main.rst | 99 +++

Re: [PATCH-for-5.2] docs/user: Display linux-user binaries nicely

2020-12-17 Thread Laurent Vivier
Le 19/11/2020 à 17:08, Philippe Mathieu-Daudé a écrit : > linux-user binaries are displayed altogether. Use the '*' > character to force displaying them as bullet list (one list > per architecture). > > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/user/main.rst | 99 +++

Re: [PATCH 0/7] scsi: scsi-disk corrupts data

2020-12-17 Thread Paolo Bonzini
On 16/11/20 19:40, Hannes Reinecke wrote: Hi all, a customer of ours reported repeated data corruption in the guest following a command abort. After lengthy debugging we found that scsi-disk (and scsi-generic, for that matter) ignores the host_status field from SG_IO once a command is aborted.

Re: [PATCH 03/18] curl: convert to meson

2020-12-17 Thread Daniel P . Berrangé
On Thu, Dec 17, 2020 at 10:40:29AM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > configure | 31 --- > contrib/elf2dmp/meson.build | 2 +- > meson.build | 11 +++ > meson_options.txt | 2 ++ > 4

Re: [PATCH 02/18] curl: remove compatibility code, require 7.29.0

2020-12-17 Thread Daniel P . Berrangé
On Thu, Dec 17, 2020 at 10:40:28AM +0100, Paolo Bonzini wrote: > cURL 7.16.0 was released in October 2006. Just remove code that is > in all likelihood not being used anywhere, and require the oldest version > found in currently supported distros, which is 7.29.0 from CentOS 7. > > pkg-config is

[PATCH] linux-user: Fix loading of BSS segments

2020-12-17 Thread Giuseppe Musacchio
Some ELF binaries encode the .bss section as an extension of the data ones by setting the segment p_memsz > p_filesz. Some other binaries take a different route and encode it as a stand-alone PT_LOAD segment with p_filesz = 0 and p_memsz > 0. Both the encodings are actually correct per ELF specifi

Re: [PATCH 1/4] linux-user/mips64: Restore setup_frame() for o32 ABI

2020-12-17 Thread Laurent Vivier
Le 19/11/2020 à 17:17, Philippe Mathieu-Daudé a écrit : > 64-bit MIPS targets lost setup_frame() during the refactor in commit > 8949bef18b9. Restore it declaring TARGET_ARCH_HAS_SETUP_FRAME, to be > able to build the o32 ABI target. > > Fixes: 8949bef18b9 ("linux-user: move mips/mips64 signal.c p

Re: [PATCH 1/4] configure: remove useless code to check for Xen PCI passthrough

2020-12-17 Thread Marc-André Lureau
On Thu, Dec 17, 2020 at 12:51 PM Paolo Bonzini wrote: > meson.build is already doing the same check, so remove it from > configure. > > Signed-off-by: Paolo Bonzini > Reviewed-by: Marc-André Lureau --- > configure | 12 > 1 file changed, 12 deletions(-) > > diff --git a/configur

Re: [PATCH 2/4] configure: remove variable bogus_os

2020-12-17 Thread Marc-André Lureau
On Thu, Dec 17, 2020 at 12:50 PM Paolo Bonzini wrote: > The condition can be tested also from $targetos, clean up. > > Signed-off-by: Paolo Bonzini > Reviewed-by: Marc-André Lureau --- > configure | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/configure b/configu

Re: [PATCH 3/4] configure: accept --enable-slirp

2020-12-17 Thread Marc-André Lureau
On Thu, Dec 17, 2020 at 12:52 PM Paolo Bonzini wrote: > Meson understands -Dslirp=enabled, so there is no reason not to > accept the configure option as well. > > Signed-off-by: Paolo Bonzini > Reviewed-by: Marc-André Lureau --- > configure | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [PATCH 4/4] configure: remove CONFIG_FILEVERSION and CONFIG_PRODUCTVERSION

2020-12-17 Thread Marc-André Lureau
On Thu, Dec 17, 2020 at 12:50 PM Paolo Bonzini wrote: > version.rc can just use existing preprocessor symbols. > > Signed-off-by: Paolo Bonzini > Reviewed-by: Marc-André Lureau --- > configure | 9 - > version.rc | 4 ++-- > 2 files changed, 2 insertions(+), 11 deletions(-) > > diff

Re: [PATCH 16/20] migration: Replace migration's JSON writer by the general one

2020-12-17 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Commit 8118f0950f "migration: Append JSON description of migration > >> stream" needs a JSON writer. The existing qobject_to_json() wasn't a > >> good fit,

Re: [PATCH 2/4] linux-user/mips64: Support o32 ABI syscalls

2020-12-17 Thread Laurent Vivier
Le 19/11/2020 à 17:17, Philippe Mathieu-Daudé a écrit : > o32 ABI syscalls start at offset 4000. > > Signed-off-by: Philippe Mathieu-Daudé > --- > linux-user/mips64/syscall_nr.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/linux-user/mips64/syscall_nr.h b/linux-u

[PATCH] build-sys: fix win32 compilation with --target-list=''

2020-12-17 Thread marcandre . lureau
From: Marc-André Lureau Fixes linking: x86_64-w64-mingw32-gcc -o tests/test-qapi-util.exe version.rc_version.o tests/test-qapi-util.exe.p/test-qapi-util.c.obj -Wl,--allow-shlib-undefined -Wl,--nxcompat -Wl,--no-seh -Wl,--dynamicbase -Wl,--warn-common -m64 -fstack-protector-strong -Wl,--start-

Re: [PATCH] linux-user: Fix loading of BSS segments

2020-12-17 Thread Laurent Vivier
Le 17/12/2020 à 11:17, Giuseppe Musacchio a écrit : > Some ELF binaries encode the .bss section as an extension of the data > ones by setting the segment p_memsz > p_filesz. Some other binaries take > a different route and encode it as a stand-alone PT_LOAD segment with > p_filesz = 0 and p_memsz >

Re: [PATCH v2 2/4] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

2020-12-17 Thread Kevin Wolf
Am 17.12.2020 um 10:37 hat Sergio Lopez geschrieben: > On Wed, Dec 16, 2020 at 07:31:02PM +0100, Kevin Wolf wrote: > > Am 16.12.2020 um 15:55 hat Sergio Lopez geschrieben: > > > On Wed, Dec 16, 2020 at 01:35:14PM +0100, Kevin Wolf wrote: > > > > Am 15.12.2020 um 18:23 hat Sergio Lopez geschrieben:

Re: [PATCH] linux-user: Fix loading of BSS segments

2020-12-17 Thread Giuseppe Musacchio
On 17/12/20 11:48, Laurent Vivier wrote: > Le 17/12/2020 à 11:17, Giuseppe Musacchio a écrit : >> Some ELF binaries encode the .bss section as an extension of the data >> ones by setting the segment p_memsz > p_filesz. Some other binaries take >> a different route and encode it as a stand-alone PT_

[Bug 1908515] [NEW] assertion failure in lsi53c810 emulator

2020-12-17 Thread Cheol-Woo,Myung
Public bug reported: Hello, Using hypervisor fuzzer, hyfuzz, I found an assertion failure through lsi53c810 emulator. A malicious guest user/process could use this flaw to abort the QEMU process on the host, resulting in a denial of service. This was found in version 5.2.0 (master) qemu-syste

[Bug 1908513] [NEW] assertion failure in mptsas1068 emulator

2020-12-17 Thread Cheol-Woo,Myung
Public bug reported: Using hypervisor fuzzer, hyfuzz, I found an assertion failure through mptsas1068 emulator. A malicious guest user/process could use this flaw to abort the QEMU process on the host, resulting in a denial of service. This was found in version 5.2.0 (master) qemu-system-i386:

Re: [PATCH] linux-user: Implement copy_file_range

2020-12-17 Thread Laurent Vivier
Le 12/11/2020 à 12:45, Andreas Schwab a écrit : > Signed-off-by: Andreas Schwab > --- > linux-user/syscall.c | 40 > 1 file changed, 40 insertions(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 3160a9ba06..c3373af4c7 100644 > ---

Re: [PATCH 11/12] qapi/schema: Name the builtin module "" instead of None

2020-12-17 Thread Markus Armbruster
John Snow writes: > On 12/16/20 5:42 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Instead of using None as the built-in module filename, use an empty >>> string instead. >> >> PATCH 05's changes the module name of the special system module for >> built-in stuff from None to './buil

Re: [PATCH] target/i386: Check privilege level for protected mode 'int N' task gate

2020-12-17 Thread Paolo Bonzini
On 21/11/20 23:44, Peter Maydell wrote: When the 'int N' instruction is executed in protected mode, the pseudocode in the architecture manual specifies that we need to check: * vector number within IDT limits * selected IDT descriptor is a valid type (interrupt, trap or task gate) * if thi

[Bug 1901532] Re: Assertion failure `mr != NULL' failed through usb-ehci

2020-12-17 Thread Cheol-Woo,Myung
** Changed in: qemu Status: New => Confirmed ** CVE added: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2020-25723 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1901532 Title: Assertion f

Re: [PATCH] linux-user: Implement copy_file_range

2020-12-17 Thread Laurent Vivier
Le 12/11/2020 à 12:45, Andreas Schwab a écrit : > Signed-off-by: Andreas Schwab > --- > linux-user/syscall.c | 40 > 1 file changed, 40 insertions(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 3160a9ba06..c3373af4c7 100644 > ---

Re: [PATCH v4] linux-user: Add most IFTUN ioctls

2020-12-17 Thread Laurent Vivier
Le 29/09/2020 à 03:48, Shu-Chun Weng via a écrit : > The three options handling `struct sock_fprog` (TUNATTACHFILTER, > TUNDETACHFILTER, and TUNGETFILTER) are not implemented. Linux kernel > keeps a user space pointer in them which we cannot correctly handle. > > Signed-off-by: Josh Kunz > Signed

Re: [for-6.0 v5 08/13] securable guest memory: Introduce sgm "ready" flag

2020-12-17 Thread Cornelia Huck
On Thu, 17 Dec 2020 16:38:20 +1100 David Gibson wrote: > On Mon, Dec 14, 2020 at 06:00:36PM +0100, Cornelia Huck wrote: > > On Fri, 4 Dec 2020 16:44:10 +1100 > > David Gibson wrote: > > > > > The platform specific details of mechanisms for implementing securable > > > guest memory may requir

Re: [PATCH v2 1/4] linux-user/sparc: Correct sparc64_get/set_context() FPU handling

2020-12-17 Thread Laurent Vivier
Le 06/11/2020 à 18:09, Richard Henderson a écrit : > On 11/6/20 7:27 AM, Peter Maydell wrote: >> +if (fprs & FPRS_DU) { >> +for (i = 16; i < 31; i++) { > > 32. > > Otherwise, > Reviewed-by: Richard Henderson > > r~ > Applied to my linux-user-for-6.0 branch with this change

[PATCH v2 2/7] digic-timer: Use ptimer_free() in the finalize function to avoid memleaks

2020-12-17 Thread Gan Qixin
When running device-introspect-test, a memory leak occurred in the digic_timer_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 288 byte(s) in 3 object(s) allocated from: #0 0xab97e1f0 in __interceptor_calloc (/lib64/

Re: [PATCH v2 2/4] linux-user/sparc: Remove unneeded checks of 'err' from sparc64_get_context()

2020-12-17 Thread Laurent Vivier
Le 06/11/2020 à 16:27, Peter Maydell a écrit : > Unlike the kernel macros, our __get_user() and __put_user() do not > return a failure code. Kernel code typically has a style of > err |= __get_user(...); err |= __get_user(...); > and then checking err at the end. In sparc64_get_context() our >

Re: [PATCH] build-sys: fix win32 compilation with --target-list=''

2020-12-17 Thread Claudio Fontana
On 12/17/20 11:44 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Fixes linking: > x86_64-w64-mingw32-gcc -o tests/test-qapi-util.exe version.rc_version.o > tests/test-qapi-util.exe.p/test-qapi-util.c.obj -Wl,--allow-shlib-undefined > -Wl,--nxcompat -Wl,--no-seh -Wl,--dyna

[PATCH v2 0/7] Fix some memleaks caused by ptimer_init

2020-12-17 Thread Gan Qixin
v1->v2: Changes suggested by Peter Maydell: Delete the modification of unrelated whitespace. Gan Qixin (7): allwinner-a10-pit: Use ptimer_free() in the finalize function to avoid memleaks digic-timer: Use ptimer_free() in the finalize function to avoid memleaks exynos4210_mct: Us

Re: [PATCH v2 3/4] linux-user/sparc: Don't restore %g7 in sparc64_set_context()

2020-12-17 Thread Laurent Vivier
Le 06/11/2020 à 16:27, Peter Maydell a écrit : > The kernel does not restore the g7 register in sparc64_set_context(); > neither should we. (We still save it in sparc64_get_context().) > > Signed-off-by: Peter Maydell > --- > linux-user/sparc/signal.c | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH v2 1/7] allwinner-a10-pit: Use ptimer_free() in the finalize function to avoid memleaks

2020-12-17 Thread Gan Qixin
When running device-introspect-test, a memory leak occurred in the a10_pit_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 288 byte(s) in 6 object(s) allocated from: #0 0xab97e1f0 in __interceptor_calloc (/lib64/liba

[PATCH v2 5/7] exynos4210_rtc: Use ptimer_free() in the finalize function to avoid memleaks

2020-12-17 Thread Gan Qixin
When running device-introspect-test, a memory leak occurred in the exynos4210_rtc_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 96 byte(s) in 1 object(s) allocated from: #0 0xab97e1f0 in __interceptor_calloc (/lib6

[PATCH v2 4/7] exynos4210_pwm: Use ptimer_free() in the finalize function to avoid memleaks

2020-12-17 Thread Gan Qixin
When running device-introspect-test, a memory leak occurred in the exynos4210_pwm_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 240 byte(s) in 5 object(s) allocated from: #0 0xab97e1f0 in __interceptor_calloc (/lib

[PATCH v2 6/7] mss-timer: Use ptimer_free() in the finalize function to avoid memleaks

2020-12-17 Thread Gan Qixin
When running device-introspect-test, a memory leak occurred in the mss_timer_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 192 byte(s) in 2 object(s) allocated from: #0 0xab97e1f0 in __interceptor_calloc (/lib64/li

[PATCH v2 7/7] musicpal: Use ptimer_free() in the finalize function to avoid memleaks

2020-12-17 Thread Gan Qixin
When running device-introspect-test, a memory leak occurred in the mv88w8618_pit_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 192 byte(s) in 4 object(s) allocated from: #0 0xab97e1f0 in __interceptor_calloc (/lib6

Re: [PATCH v2 4/4] linux-user/sparc: Handle tstate in sparc64_get/set_context()

2020-12-17 Thread Laurent Vivier
Le 06/11/2020 à 16:27, Peter Maydell a écrit : > Correctly implement save/restore of the tstate field in > sparc64_get_context() and sparc64_set_context(): > * Don't use the CWP value from the guest in set_context > * Construct and save a tstate value rather than leaving >it as zero in get_co

[PATCH v2 3/7] exynos4210_mct: Use ptimer_free() in the finalize function to avoid memleaks

2020-12-17 Thread Gan Qixin
When running device-introspect-test, a memory leak occurred in the exynos4210_mct_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 96 byte(s) in 1 object(s) allocated from: #0 0xab97e1f0 in __interceptor_calloc (/lib6

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2020-12-17 Thread Cornelia Huck
On Thu, 17 Dec 2020 16:47:36 +1100 David Gibson wrote: > On Mon, Dec 14, 2020 at 06:22:40PM +0100, Cornelia Huck wrote: > > On Fri, 4 Dec 2020 16:44:13 +1100 > > David Gibson wrote: > > > > > We haven't yet implemented the fairly involved handshaking that will be > > > needed to migrate PEF

Re: [PATCH 01/18] brlapi: convert to meson

2020-12-17 Thread Marc-André Lureau
On Thu, Dec 17, 2020 at 1:40 PM Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > Reviewed-by: Marc-André Lureau --- > chardev/meson.build | 2 +- > configure | 32 > meson.build | 20 +--- > meson_options.txt | 2 ++

Re: [PATCH] build-sys: fix win32 compilation with --target-list=''

2020-12-17 Thread Marc-André Lureau
Hi On Thu, Dec 17, 2020 at 3:33 PM Claudio Fontana wrote: > On 12/17/20 11:44 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Fixes linking: > > x86_64-w64-mingw32-gcc -o tests/test-qapi-util.exe version.rc_version.o > tests/test-qapi-util.exe.p/test-qapi-util.c.obj

Re: [PATCH] build-sys: fix win32 compilation with --target-list=''

2020-12-17 Thread Paolo Bonzini
On 17/12/20 12:32, Claudio Fontana wrote: Is the root cause elsewhere though? I don't like stubs very much, because often they are introduced as the easy way out of a problem instead of doing the necessary refactoring, and they end up confusing the hell out of someone trying to understand what

Re: [PATCH 02/18] curl: remove compatibility code, require 7.29.0

2020-12-17 Thread Marc-André Lureau
On Thu, Dec 17, 2020 at 1:40 PM Paolo Bonzini wrote: > cURL 7.16.0 was released in October 2006. Just remove code that is > in all likelihood not being used anywhere, and require the oldest version > found in currently supported distros, which is 7.29.0 from CentOS 7. > > pkg-config is enough fo

Re: [for-6.0 v5 00/13] Generalize memory encryption models

2020-12-17 Thread Cornelia Huck
On Thu, 17 Dec 2020 17:21:16 +1100 David Gibson wrote: > On Tue, Dec 08, 2020 at 01:43:08PM +0100, Cornelia Huck wrote: > > On Tue, 8 Dec 2020 13:57:28 +1100 > > David Gibson wrote: > > > > > On Fri, Dec 04, 2020 at 02:12:29PM +0100, Cornelia Huck wrote: > > > > On Fri, 4 Dec 2020 13:07:27

Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel

2020-12-17 Thread Markus Armbruster
John Snow writes: > On 12/16/20 4:22 AM, Markus Armbruster wrote: >> 2. On error with "no source info", don't crash. >> I have my doubts on this one. >> Such an error means the QAPI code generator screwed up, at least >> in >> theory. Crashing is only proper. It gets the screwup fix

Re: [PATCH] docs/devel/migration: Improve debugging section a bit

2020-12-17 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Fix typos, and make the example work out of the box. > > Signed-off-by: Markus Armbruster Thanks, Reviewed-by: Dr. David Alan Gilbert and queued. > --- > docs/devel/migration.rst | 11 ++- > 1 file changed, 6 insertions(+), 5 deletion

Re: [PATCH 03/18] curl: convert to meson

2020-12-17 Thread Marc-André Lureau
Hi On Thu, Dec 17, 2020 at 1:40 PM Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > configure | 31 --- > contrib/elf2dmp/meson.build | 2 +- > meson.build | 11 +++ > meson_options.txt | 2 ++ > 4 fil

Re: [PATCH 03/18] curl: convert to meson

2020-12-17 Thread Marc-André Lureau
On Thu, Dec 17, 2020 at 3:59 PM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > Hi > > On Thu, Dec 17, 2020 at 1:40 PM Paolo Bonzini wrote: > >> Signed-off-by: Paolo Bonzini >> > --- >> configure | 31 --- >> contrib/elf2dmp/meson.build |

Re: [PATCH 03/18] curl: convert to meson

2020-12-17 Thread Paolo Bonzini
On 17/12/20 13:00, Marc-André Lureau wrote: -curl="$default_feature" +curl="auto" What about default_feature=no ? Oh got it:         $(if test "$default_features" = no; then echo "-Dauto_features=disabled"; fi) \ Yeah, Meson has that feature natively. The plan is to:

Re: [PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-17 Thread Leif Lindholm
Hi Laurent, On Thu, Dec 17, 2020 at 11:02:23 +0100, Laurent Desnogues wrote: > Hi Leif, > > On Tue, Dec 15, 2020 at 5:49 PM Leif Lindholm wrote: > > > > On Tue, Dec 15, 2020 at 13:23:58 +0100, Laurent Desnogues wrote: > > > Hello, > > > > > > On Tue, Dec 15, 2020 at 12:51 PM Leif Lindholm wrote

Re: [PATCH 04/18] glusterfs: convert to meson

2020-12-17 Thread Marc-André Lureau
Hi On Thu, Dec 17, 2020 at 1:40 PM Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > configure | 102 ++ > meson.build | 46 +++-- > meson_options.txt | 2 + > 3 files changed, 48 insertions(+), 102 deletion

Re: [PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-17 Thread Laurent Desnogues
On Thu, Dec 17, 2020 at 1:10 PM Leif Lindholm wrote: [...] > > > > > +FIELD(CCSIDR_EL1, LINESIZE, 0, 3) > > > > > +FIELD(CCSIDR_EL1, ASSOCIATIVITY, 3, 21) > > > > > +FIELD(CCSIDR_EL1, NUMSETS, 32, 24) > > > > > > > > The positions and sizes of the ASSOCIATIVITY and NUMSETS CCSIDR fields > > > > de

Re: [PATCH v2 2/2] accel: kvm: Add aligment assert for kvm_log_clear_one_slot

2020-12-17 Thread Andrew Jones
On Thu, Dec 17, 2020 at 09:49:41AM +0800, Keqian Zhu wrote: > The parameters start and size are transfered from QEMU memory > emulation layer. It can promise that they are TARGET_PAGE_SIZE > aligned. However, KVM needs they are qemu_real_page_size aligned. > > Though no caller breaks this aligned

  1   2   3   4   5   >