Re: [PATCH v13 07/19] multi-process: add qio channel function to transmit data and fds

2020-12-15 Thread Elena Ufimtseva
On Tue, Dec 15, 2020 at 02:49:22PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Dec 14, 2020 at 9:15 AM Jagannathan Raman > wrote: > > > From: Elena Ufimtseva > > > > Adds QIO channel functions that transmit and receive iovs along with fds. > > > > Signed-off-by: Elena Ufimtseva > > Signed

tests/test-char hangs in CI (Centos7 with check-crypto-old-nettle)

2020-12-15 Thread Alex Bennée
Hi, Over the last few weeks we've seen a steadily more common failure in test-char on CI. It seems to only manifest itself on the check-crypto-old-nettle build set and fails with a message like: Running test test-char Unexpected error in object_property_try_add() at ../qom/object.c:1219: at

[Bug 1907817] Re: qemu-aarch64 tcg assertion v5.2.0

2020-12-15 Thread Richard Henderson
Proposed patch: https://lists.gnu.org/archive/html/qemu-devel/2020-12/msg04150.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1907817 Title: qemu-aarch64 tcg assertion v5.2.0 Status in QEMU:

Re: [PULL 20/20] hw/block/m25p80: Fix Numonyx fast read dummy cycle count

2020-12-15 Thread Peter Maydell
On Tue, 15 Dec 2020 at 15:42, Francisco Iglesias wrote: > > Hello Peter, > > On [2020 Dec 15] Tue 15:11:00, Peter Maydell wrote: > > On Tue, 15 Dec 2020 at 15:06, Bin Meng wrote: > > > I believe you tested this with Xilinx SPIPS but not some other > > > controllers. > > > Francisco and I had a d

Re: [PULL 00/20] target-arm queue

2020-12-15 Thread Peter Maydell
4: > > Merge remote-tracking branch > 'remotes/vivier2/tags/trivial-branch-for-6.0-pull-request' into staging > (2020-12-14 20:32:38 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/p

Re: [PATCH v13 07/19] multi-process: add qio channel function to transmit data and fds

2020-12-15 Thread Elena Ufimtseva
On Tue, Dec 15, 2020 at 02:49:22PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Dec 14, 2020 at 9:15 AM Jagannathan Raman > wrote: > > > From: Elena Ufimtseva > > > > Adds QIO channel functions that transmit and receive iovs along with fds. > > > > Signed-off-by: Elena Ufimtseva > > Signed

Re: [PULL 1/2] test-char: abort on serial test error

2020-12-15 Thread Eduardo Habkost
On Tue, Dec 15, 2020 at 02:29:22PM -0500, Eduardo Habkost wrote: > On Sun, Dec 13, 2020 at 11:51:05PM +0100, Philippe Mathieu-Daudé wrote: > > On 7/28/20 4:31 PM, Marc-André Lureau wrote: > > > We are having issues debugging and bisecting this issue that happen > > > mostly on patchew. Let's make i

Re: [PATCH v3 01/15] hw/riscv: Expand the is 32-bit check to support more CPUs

2020-12-15 Thread Richard Henderson
On 12/15/20 10:44 AM, Alistair Francis wrote: > On Tue, Dec 15, 2020 at 1:26 AM Bin Meng wrote: >> >> On Tue, Dec 15, 2020 at 4:34 AM Alistair Francis >> wrote: >>> >>> Currently the riscv_is_32_bit() function only supports the generic rv32 >>> CPUs. Extend the function to support the SiFive and

Re: [PATCH 3/3] target/arm: set ID_AA64ISAR0.TLB to 2 for max AARCH64 CPU type

2020-12-15 Thread Richard Henderson
On 12/14/20 2:23 PM, Rebecca Cran wrote: > +++ b/target/arm/cpu64.c > @@ -620,6 +620,7 @@ static void aarch64_max_initfn(Object *obj) > t = FIELD_DP64(t, ID_AA64ISAR0, DP, 1); > t = FIELD_DP64(t, ID_AA64ISAR0, FHM, 1); > t = FIELD_DP64(t, ID_AA64ISAR0, TS, 2); /* v8.5-Con

[Bug 1907952] Re: qemu-system-aarch64: with "-display gtk" arrow keys are received as just ^[ on ttyAMA0

2020-12-15 Thread Ryutaroh Matsumoto
An easier way to reproduce the symptom was provided by Alper Nebi Yasak at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=976808#88 qemu-system-aarch64 \ -display gtk -enable-kvm -machine virt -cpu host -m 1G -smp 2 \ -kernel /boot/vmlinuz -initrd /boot/initrd.img \ -append "break c

Re: [PATCH v12 07/23] i386: move TCG cpu class initialization to tcg/

2020-12-15 Thread Richard Henderson
On 12/12/20 9:55 AM, Claudio Fontana wrote: > to do this, we need to take code out of cpu.c and helper.c, > and also move some prototypes from cpu.h, for code that is > needed in tcg/xxx_helper.c, and which in turn is part of the > callbacks registered by the class initialization. > > Therefore, d

Re: [PATCH v12 08/23] i386: tcg: remove inline from cpu_load_eflags

2020-12-15 Thread Richard Henderson
On 12/12/20 9:55 AM, Claudio Fontana wrote: > make it a regular function. > > Suggested-by: Richard Henderson > Signed-off-by: Claudio Fontana > --- > target/i386/tcg/helper-tcg.h | 15 ++- > target/i386/tcg/misc_helper.c | 13 + > 2 files changed, 15 insertions(+), 13

[Bug 1906193] Re: riscv32 user mode emulation: fork return values broken

2020-12-15 Thread Andreas K . Hüttel
I can confirm that the same binary works fine with qemu system emulation: (riscv-ilp32 qemu) (none) /tmp # ./wait-test-short (riscv-ilp32 qemu) (none) /tmp # -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net

[PATCH 1/2] test-char: Destroy chardev correctly at char_file_test_internal()

2020-12-15 Thread Eduardo Habkost
commit 1e419ee68fa5 ("chardev: generate an internal id when none given") changed the reference ownership semantics of qemu_chardev_new(NULL, ...): now all chardevs created using qemu_chardev_new() are added to the /chardevs QOM container, and the caller does not own a reference to the newly created

[PATCH 2/2] qom: Assert that objects being destroyed have no parent

2020-12-15 Thread Eduardo Habkost
QOM reference counting bugs are often hard to detect, but there's one kind of bug that's easier: if we are freeing an object but is still attached to a parent, it means the reference count is wrong (because the parent always hold a reference to their children). Add an assertion to make sure we det

[PATCH 0/2] Fix test-char reference counting bug

2020-12-15 Thread Eduardo Habkost
This series addresses a bug that seems to be the cause of the following crash, that is reported by Patchew and other CI systems once in a while: Running test test-char Unexpected error in object_property_try_add() at ../qom/object.c:1220: attempt to add duplicate property 'serial-id' to objec

Re: [PATCH v4 07/43] tcg: Add in_code_gen_buffer

2020-12-15 Thread Richard Henderson
On 12/14/20 4:09 PM, Philippe Mathieu-Daudé wrote: > On 12/14/20 3:02 PM, Richard Henderson wrote: >> Create a function to determine if a pointer is within the buffer. >> >> Signed-off-by: Richard Henderson >> --- >> include/tcg/tcg.h | 6 ++ >> accel/tcg/translate-all.c | 26 +++

Re: [PATCH v4 17/43] tcg: Add --accel tcg,split-wx property

2020-12-15 Thread Richard Henderson
On 12/14/20 8:05 PM, Joelle van Dyne wrote: > Should qemu-options.hx be updated? Yep, good catch. r~

Re: [RFC PATCH 0/9] Support for Virtio-fs daemon crash reconnection

2020-12-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201215162119.27360-1-zhangjiachen.jay...@bytedance.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201215162119.27360-1-zhangjiachen.jay...@bytedance.com Subject: [RFC PATC

[PATCH v2 00/24] target/mips: Convert MSA ASE to decodetree

2020-12-15 Thread Philippe Mathieu-Daudé
Missing review: 1-3 14 17 19-24 Since v1: - rebased - addressed Richard review comments - reworded some commit descriptions - avoid 64-bit ifdef'ry Finally, we use decodetree with the MIPS target. Starting easy with the MSA ASE. 2700+ lines extracted from helper.h and translate.c, now built as a

[PATCH v2 06/24] target/mips: Use CP0_Config3 to set MIPS_HFLAG_MSA

2020-12-15 Thread Philippe Mathieu-Daudé
MSA presence is expressed by the MSAP bit of CP0_Config3. We don't need to check anything else. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mi

[PATCH v2 03/24] target/mips/cpu: Introduce isa_rel6_available() helper

2020-12-15 Thread Philippe Mathieu-Daudé
Introduce the isa_rel6_available() helper to check if the CPU supports the Release 6 ISA. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.h | 1 + target/mips/cpu.c | 8 2 files changed, 9 insertions(+) diff --git a/target/mips/cpu.h b/target/mips/cpu.h index 3ac21d0e9c0..c6a

[PATCH v2 02/24] target/mips/translate: Expose check_mips_64() to 32-bit mode

2020-12-15 Thread Philippe Mathieu-Daudé
To allow compiling 64-bit specific translation code more generically (and removing #ifdef'ry), allow compiling check_mips_64() on 32-bit targets. If ever called on 32-bit, we obviously emit a reserved instruction exception. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.h | 2 --

[PATCH v2 01/24] target/mips/translate: Extract decode_opc_legacy() from decode_opc()

2020-12-15 Thread Philippe Mathieu-Daudé
As we will slowly move to decodetree generated decoders, extract the legacy decoding from decode_opc(), so new decoders are added in decode_opc() while old code is removed from decode_opc_legacy(). Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 45 ---

[PATCH v2 04/24] target/mips: Introduce ase_msa_available() helper

2020-12-15 Thread Philippe Mathieu-Daudé
Instead of accessing CP0_Config3 directly and checking the 'MSA Present' bit, introduce an explicit helper, making the code easier to read. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.h | 6 ++ target/mips/cpu.c

[PATCH v2 07/24] target/mips: Simplify MSA TCG logic

2020-12-15 Thread Philippe Mathieu-Daudé
Only decode MSA opcodes if MSA is present (implemented). Now than check_msa_access() will only be called if MSA is present, the only way to have MIPS_HFLAG_MSA unset is if MSA is disabled (bit CP0C5_MSAEn cleared, see previous commit). Therefore we can remove the 'reserved instruction' exception.

[PATCH v2 16/24] target/mips: Extract MSA helper definitions

2020-12-15 Thread Philippe Mathieu-Daudé
Keep all MSA-related code altogether. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201120210844.2625602-4-f4...@amsat.org> --- target/mips/helper.h | 436 +- target/mips/mod-msa_helper.h.inc | 443 +++

[PATCH v2 08/24] target/mips: Remove now unused ASE_MSA definition

2020-12-15 Thread Philippe Mathieu-Daudé
We don't use ASE_MSA anymore (replaced by ase_msa_available() checking MSAP bit from CP0_Config3). Remove it. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mips-defs.h| 1 - target/mips/cpu-defs.c.inc | 8 2 files cha

[PATCH v2 05/24] target/mips: Simplify msa_reset()

2020-12-15 Thread Philippe Mathieu-Daudé
Call msa_reset() unconditionally, but only reset the MSA registers if MSA is implemented. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.c | 5 + target/mips/cpu-defs.c.inc | 4 2 files changed, 5 insertions(+

[PATCH v2 09/24] target/mips: Alias MSA vector registers on FPU scalar registers

2020-12-15 Thread Philippe Mathieu-Daudé
Commits 863f264d10f ("add msa_reset(), global msa register") and cb269f273fd ("fix multiple TCG registers covering same data") removed the FPU scalar registers and replaced them by aliases to the MSA vector registers. It is not very clear to have FPU registers displayed with MSA register names, ev

[PATCH v2 14/24] target/mips: Move msa_reset() to mod-msa_helper.c

2020-12-15 Thread Philippe Mathieu-Daudé
translate_init.c.inc mostly contains CPU definitions. msa_reset() doesn't belong here, move it with the MSA helpers. One comment style is updated to avoid checkpatch.pl warning. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 2 ++ target/mips/cpu.c| 1 +

[PATCH v2 19/24] target/mips: Introduce decode tree bindings for MSA opcodes

2020-12-15 Thread Philippe Mathieu-Daudé
Introduce the 'mod-msa32' decodetree config for the 32-bit MSA ASE. We decode the branch instructions, and all instructions based on the MSA opcode. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.h | 3 +++ target/mips/mod-msa32.decode| 24 + ta

[PATCH v2 11/24] target/mips: Remove CPUMIPSState* argument from gen_msa*() methods

2020-12-15 Thread Philippe Mathieu-Daudé
The gen_msa*() methods don't use the "CPUMIPSState *env" argument. Remove it to simplify. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 57 - 1 file changed, 28 insertions(+),

[PATCH v2 10/24] target/mips: Extract msa_translate_init() from mips_tcg_init()

2020-12-15 Thread Philippe Mathieu-Daudé
The msa_wr_d[] registers are only initialized/used by MSA. They are declared static. We want to move them to the new 'mod-msa_translate.c' unit in few commits, without having to declare them global (with extern). Extract first the logic initialization of the MSA registers from the generic initial

[PATCH v2 21/24] target/mips: Extract LSA/DLSA translation generators

2020-12-15 Thread Philippe Mathieu-Daudé
Extract gen_lsa() from translate.c and explode it as gen_LSA() and gen_DLSA(). Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.h| 6 target/mips/translate.c| 35 +++- target/mips/translate_addr_const.c | 52 +++

[PATCH v2 15/24] target/mips: Extract MSA helpers from op_helper.c

2020-12-15 Thread Philippe Mathieu-Daudé
We have ~400 lines of MSA helpers in the generic op_helper.c, move them with the other helpers in 'mod-msa_helper.c'. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201123204448.3260804-5-f4...@amsat.org> --- target/mips/mod-msa_helper.c | 393 ++

[PATCH v2 12/24] target/mips: Explode gen_msa_branch() as gen_msa_BxZ_V/BxZ()

2020-12-15 Thread Philippe Mathieu-Daudé
In preparation of using the decodetree script, explode gen_msa_branch() as following: - OPC_BZ_V -> BxZ_V(EQ) - OPC_BNZ_V -> BxZ_V(NE) - OPC_BZ_[BHWD] -> BxZ(false) - OPC_BNZ_[BHWD]-> BxZ(true) Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Sign

[PATCH v2 17/24] target/mips: Declare gen_msa/_branch() in 'translate.h'

2020-12-15 Thread Philippe Mathieu-Daudé
Make gen_msa() and gen_msa_branch() public declarations so we can keep calling them once extracted from the big translate.c in the next commit. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.h | 2 ++ target/mips/translate.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletion

[PATCH v2 22/24] target/mips: Introduce decodetree helpers for MSA LSA/DLSA opcodes

2020-12-15 Thread Philippe Mathieu-Daudé
Add the LSA opcode to the MSA32 decodetree config, add DLSA to a new config for the MSA64 ASE, and call decode_msa64() in the main decode_opc() loop. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mod-msa32.decode| 4 target/mips/mod-msa64.decode| 17 + targe

[PATCH v2 13/24] target/mips: Rename msa_helper.c as mod-msa_helper.c

2020-12-15 Thread Philippe Mathieu-Daudé
MSA means 'MIPS SIMD Architecture' and is defined as a Module by MIPS. To keep the directory sorted, we use the 'mod' prefix for MIPS modules. Rename msa_helper.c as mod-msa_helper.c. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201123204448.3260804-4-f4...

[PATCH v2 20/24] target/mips: Use decode_ase_msa() generated from decodetree

2020-12-15 Thread Philippe Mathieu-Daudé
Now that we can decode the MSA ASE opcodes with decode_msa32(), use it and remove the unreachable code. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.h | 12 target/mips/mod-msa_translate.c | 29 + target/mips/translate.c

[PATCH v2 23/24] target/mips: Introduce decodetree helpers for Release6 LSA/DLSA opcodes

2020-12-15 Thread Philippe Mathieu-Daudé
LSA and LDSA opcodes are also available with MIPS release 6. Introduce the decodetree config files and call the decode() helpers in the main decode_opc() loop. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.h | 1 + target/mips/isa-mips32r6.decode | 17 +

[RFC PATCH v2 24/24] target/mips/mod-msa: Pass TCGCond argument to gen_check_zero_element()

2020-12-15 Thread Philippe Mathieu-Daudé
Simplify gen_check_zero_element() by passing the TCGCond argument along. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Maybe this can be named 'msa_translate.c' after all... --- target/mips/mod-msa_translate.c | 10 -- 1 file changed, 4 insertions(+), 6 delet

Re: [PATCH v2 21/24] target/mips: Extract LSA/DLSA translation generators

2020-12-15 Thread Richard Henderson
On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote: > Extract gen_lsa() from translate.c and explode it as > gen_LSA() and gen_DLSA(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.h| 6 > target/mips/translate.c| 35 +++- >

Re: [PATCH v2 19/24] target/mips: Introduce decode tree bindings for MSA opcodes

2020-12-15 Thread Richard Henderson
On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote: > Introduce the 'mod-msa32' decodetree config for the 32-bit MSA ASE. > > We decode the branch instructions, and all instructions based > on the MSA opcode. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.h | 3

Re: [PATCH v4 07/43] tcg: Add in_code_gen_buffer

2020-12-15 Thread Philippe Mathieu-Daudé
On 12/15/20 11:43 PM, Richard Henderson wrote: > On 12/14/20 4:09 PM, Philippe Mathieu-Daudé wrote: >> On 12/14/20 3:02 PM, Richard Henderson wrote: >>> Create a function to determine if a pointer is within the buffer. >>> >>> Signed-off-by: Richard Henderson >>> --- >>> include/tcg/tcg.h

Re: [PATCH v2 0/4] clock: Get rid of clock_get_ns()

2020-12-15 Thread Philippe Mathieu-Daudé
On 12/15/20 4:29 PM, Philippe Mathieu-Daudé wrote: > On 12/15/20 4:09 PM, Peter Maydell wrote: >> This patchseries makes some changes to the clock API: >> * Remove clock_get_ns() >> * Add clock_ticks_to_ns() to return number of nanoseconds >>it will take the clock to tick N times >> * clock_

Re: [PATCH v2 20/24] target/mips: Use decode_ase_msa() generated from decodetree

2020-12-15 Thread Richard Henderson
On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote: > Now that we can decode the MSA ASE opcodes with decode_msa32(), > use it and remove the unreachable code. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.h | 12 > target/mips/mod-msa_translate.c |

Re: [RFC PATCH v2 24/24] target/mips/mod-msa: Pass TCGCond argument to gen_check_zero_element()

2020-12-15 Thread Richard Henderson
On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote: > Simplify gen_check_zero_element() by passing the TCGCond > argument along. > > Suggested-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé > --- > Maybe this can be named 'msa_translate.c' after all... > --- > target/mips/mod-msa_

Re: [PATCH v2 23/24] target/mips: Introduce decodetree helpers for Release6 LSA/DLSA opcodes

2020-12-15 Thread Richard Henderson
On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote: > LSA and LDSA opcodes are also available with MIPS release 6. > Introduce the decodetree config files and call the decode() > helpers in the main decode_opc() loop. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.h

Re: [PATCH v2 14/24] target/mips: Move msa_reset() to mod-msa_helper.c

2020-12-15 Thread Richard Henderson
On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote: > translate_init.c.inc mostly contains CPU definitions. > msa_reset() doesn't belong here, move it with the MSA > helpers. > > One comment style is updated to avoid checkpatch.pl warning. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target

Re: [PATCH v2 01/24] target/mips/translate: Extract decode_opc_legacy() from decode_opc()

2020-12-15 Thread Richard Henderson
On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote: > As we will slowly move to decodetree generated decoders, > extract the legacy decoding from decode_opc(), so new > decoders are added in decode_opc() while old code is > removed from decode_opc_legacy(). > > Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH v2 17/24] target/mips: Declare gen_msa/_branch() in 'translate.h'

2020-12-15 Thread Richard Henderson
On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote: > Make gen_msa() and gen_msa_branch() public declarations > so we can keep calling them once extracted from the big > translate.c in the next commit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.h | 2 ++ > target/mips

Re: [PATCH v2 03/24] target/mips/cpu: Introduce isa_rel6_available() helper

2020-12-15 Thread Richard Henderson
On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote: > +bool isa_rel6_available(const CPUMIPSState *env) > +{ > +if (TARGET_LONG_BITS == 64) { > +return cpu_supports_isa(env, ISA_MIPS64R6); > +} > +return cpu_supports_isa(env, ISA_MIPS32R6); > +} So... does qemu-system-mips64 sup

Re: [PATCH v2 22/24] target/mips: Introduce decodetree helpers for MSA LSA/DLSA opcodes

2020-12-15 Thread Richard Henderson
On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote: > Add the LSA opcode to the MSA32 decodetree config, add DLSA > to a new config for the MSA64 ASE, and call decode_msa64() > in the main decode_opc() loop. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/mod-msa32.decode| 4 ++

Re: [PATCH] tcg: Use memset for large vector byte replication

2020-12-15 Thread Philippe Mathieu-Daudé
On 12/15/20 6:48 PM, Richard Henderson wrote: > In f47db80cc07, we handled odd-sized tail clearing for > the case of hosts that have vector operations, but did > not handle the case of hosts that do not have vector ops. > > This was ok until e2e7168a214b, which changed the encoding > of simd_desc

Re: [PATCH v2 03/24] target/mips/cpu: Introduce isa_rel6_available() helper

2020-12-15 Thread Philippe Mathieu-Daudé
On 12/16/20 12:27 AM, Richard Henderson wrote: > On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote: >> +bool isa_rel6_available(const CPUMIPSState *env) >> +{ >> +if (TARGET_LONG_BITS == 64) { >> +return cpu_supports_isa(env, ISA_MIPS64R6); >> +} >> +return cpu_supports_isa(env,

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-12-15 Thread Keith Busch
Hi Dmitry, Looks good to me, thanks for sticking with it. Reviewed-by: Keith Busch

Re: [PATCH] spapr: DRC lookup cannot fail

2020-12-15 Thread David Gibson
On Tue, Dec 15, 2020 at 06:36:51PM +0100, Greg Kurz wrote: > All memory DRC objects are created during machine init. It is thus safe > to assume spapr_drc_by_id() cannot return NULL when hot-plug/unplugging > memory. > > Make this clear with an assertion, like the code already does a few lines > a

Re: [PATCH] spapr/xive: Make spapr_xive_pic_print_info() static

2020-12-15 Thread David Gibson
On Tue, Dec 15, 2020 at 06:40:25PM +0100, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater Applied to ppc-for-6.0, thanks. > --- > include/hw/ppc/spapr_xive.h | 2 -- > hw/intc/spapr_xive.c| 2 +- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/hw/pp

[PATCH] configure: Fail when specified cross compiler cannot be found

2020-12-15 Thread Gustavo Romero
Currently if the cross compiler passed to 'configure' (--cross-cc-) does not exist no error happens and only later when the TCG tests are run they fail because the cross compiler is not set correctly. This commit changes that behavior and make 'configure' fail if the specified cross compiler canno

[RFC v2 00/15] support subsets of bitmanip extension

2020-12-15 Thread frank . chang
From: Frank Chang This patchset implements RISC-V B-extension draft version Zbb, Zbs and Zba subset instructions. Some Zbp instructions are also implemented as they have similar behavior with their Zbb-, Zbs- and Zba-family instructions or for Zbb pseudo instructions (e.g. rev8, orc.b). Specific

[RFC v2 02/15] target/riscv: rvb: count leading/trailing zeros

2020-12-15 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32-64.decode | 4 +++ target/riscv/insn32.decode | 7 +++- target/riscv/insn_trans/trans_rvb.c.inc | 47 + target/riscv/translate.c| 42 ++

[RFC v2 04/15] target/riscv: rvb: logic-with-negate

2020-12-15 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32.decode | 4 target/riscv/insn_trans/trans_rvb.c.inc | 18 ++ target/riscv/translate.c| 21 + 3 files changed, 43 insertions(+) d

[RFC v2 05/15] target/riscv: rvb: pack two words into one register

2020-12-15 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32-64.decode | 3 ++ target/riscv/insn32.decode | 3 ++ target/riscv/insn_trans/trans_rvb.c.inc | 30 ++ target/riscv/translate.c| 41

[RFC v2 01/15] target/riscv: reformat @sh format encoding for B-extension

2020-12-15 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32.decode | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index 84080dd18ca..3823b3ea800 100644 --- a/target/riscv/i

[RFC v2 03/15] target/riscv: rvb: count bits set

2020-12-15 Thread frank . chang
From: Frank Chang Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32-64.decode | 1 + target/riscv/insn32.decode | 1 + target/riscv/insn_trans/trans_rvb.c.inc | 12 target/riscv/translate.c| 6 ++ 4 files cha

[RFC v2 13/15] target/riscv: rvb: address calculation

2020-12-15 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32-64.decode | 3 +++ target/riscv/insn32.decode | 3 +++ target/riscv/insn_trans/trans_rvb.c.inc | 23 ++ target/riscv/translate.c| 32 ++

[RFC v2 09/15] target/riscv: rvb: shift ones

2020-12-15 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32-64.decode | 4 ++ target/riscv/insn32.decode | 4 ++ target/riscv/insn_trans/trans_rvb.c.inc | 58 + target/riscv/translate.c| 13 +

[RFC v2 06/15] target/riscv: rvb: min/max instructions

2020-12-15 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32.decode | 4 target/riscv/insn_trans/trans_rvb.c.inc | 24 2 files changed, 28 insertions(+) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.d

[RFC v2 07/15] target/riscv: rvb: sign-extend instructions

2020-12-15 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32.decode | 2 ++ target/riscv/insn_trans/trans_rvb.c.inc | 13 + 2 files changed, 15 insertions(+) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index 0

[RFC v2 15/15] target/riscv: rvb: support and turn on B-extension from command line

2020-12-15 Thread frank . chang
From: Kito Cheng B-extension is default off, use cpu rv32 or rv64 with x-b=true to enable B-extension. Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/cpu.c | 4 target/riscv/cpu.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/target/riscv/cpu.c b/target/ri

[RFC v2 08/15] target/riscv: rvb: single-bit instructions

2020-12-15 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32-64.decode | 8 ++ target/riscv/insn32.decode | 9 +++ target/riscv/insn_trans/trans_rvb.c.inc | 90 + target/riscv/translate.c| 102

[RFC v2 12/15] target/riscv: rvb: generalized or-combine

2020-12-15 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang --- target/riscv/bitmanip_helper.c | 31 ++ target/riscv/helper.h | 2 ++ target/riscv/insn32-64.decode | 2 ++ target/riscv/insn32.decode | 2 ++ target/riscv/insn_trans/trans_

[RFC v2 10/15] target/riscv: rvb: rotate (left/right)

2020-12-15 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32-64.decode | 3 ++ target/riscv/insn32.decode | 3 ++ target/riscv/insn_trans/trans_rvb.c.inc | 61 + target/riscv/translate.c| 36 +

[RFC v2 14/15] target/riscv: rvb: add/sub with postfix zero-extend

2020-12-15 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32-64.decode | 3 +++ target/riscv/insn_trans/trans_rvb.c.inc | 22 ++ target/riscv/translate.c| 6 ++ 3 files changed, 31 insertions(+) diff --git a/

[RFC v2 11/15] target/riscv: rvb: generalized reverse

2020-12-15 Thread frank . chang
From: Frank Chang Signed-off-by: Frank Chang --- target/riscv/bitmanip_helper.c | 72 + target/riscv/helper.h | 7 +++ target/riscv/insn32-64.decode | 2 + target/riscv/insn32.decode | 2 + target/riscv/insn_trans/tran

[PATCH 0/7] hw/mips/fuloong2e fixes

2020-12-15 Thread Jiaxun Yang
It can now boot Debian installer[1]. I'm going to add acceptance test for it later. Thanks. Jiaxun Yang (7): hw/mips/fuloong2e: Remove define DEBUG_FULOONG2E_INIT hw/mips/fuloong2e: Relpace fault links hw/pci-host/bonito: Fixup IRQ mapping hw/pci-host/bonito: Fixup pci.lomem mapping hw/

[PATCH 1/7] hw/mips/fuloong2e: Remove define DEBUG_FULOONG2E_INIT

2020-12-15 Thread Jiaxun Yang
Seems useless Signed-off-by: Jiaxun Yang --- hw/mips/fuloong2e.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c index 9b0eb8a314..055b99e378 100644 --- a/hw/mips/fuloong2e.c +++ b/hw/mips/fuloong2e.c @@ -48,8 +48,6 @@ #include "sysemu/reset.h"

[PATCH 3/7] hw/pci-host/bonito: Fixup IRQ mapping

2020-12-15 Thread Jiaxun Yang
Accroading to arch/mips/pci/fixup-fuloong2e.c in kernel, despites south bridge IRQs needs special care, all other IRQ pins are mapped by 'LOONGSON_IRQ_BASE + 25 + pin'. As south bridge IRQs are all handled by ISA bus, we can simply remove BONITO_IRQ_BASE and direct map IRQs here. Signed-off-by: J

[PATCH 2/7] hw/mips/fuloong2e: Relpace fault links

2020-12-15 Thread Jiaxun Yang
Websites are downing, but GitHub may last forever. Loongson even doesn't recogonize 2E as their products nowadays.. Signed-off-by: Jiaxun Yang --- hw/mips/fuloong2e.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c inde

[PATCH 4/7] hw/pci-host/bonito: Fixup pci.lomem mapping

2020-12-15 Thread Jiaxun Yang
The original mapping had wrong base address. Fix by correct the base adress and merge three alias into a single. Signed-off-by: Jiaxun Yang --- hw/pci-host/bonito.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c

[PATCH 5/7] hw/mips/fuloong2e: Remove unused env entry

2020-12-15 Thread Jiaxun Yang
modetty and busclock is not handled by kernel and the parameter here seems unreasonable. Signed-off-by: Jiaxun Yang --- hw/mips/fuloong2e.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c index a5b75b230a..256c7867e4 100644 --- a/hw/mips/fuloong2e.c

[PATCH 7/7] hw/mips/fuloong2e: Add highmem support

2020-12-15 Thread Jiaxun Yang
highmem started from 0x2000. Now we can have up to 2G RAM. Signed-off-by: Jiaxun Yang --- hw/mips/fuloong2e.c | 49 - 1 file changed, 39 insertions(+), 10 deletions(-) diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c index af2d259dc4..dec6ac

[PATCH 6/7] hw/mips/fuloong2e: Correct cpuclock env

2020-12-15 Thread Jiaxun Yang
It should be 53308. See clock_set_hz. Signed-off-by: Jiaxun Yang --- hw/mips/fuloong2e.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c index 256c7867e4..af2d259dc4 100644 --- a/hw/mips/fuloong2e.c +++ b/hw/mips/fuloong2e.c @@ -1

Re: [PATCH v2 03/24] target/mips/cpu: Introduce isa_rel6_available() helper

2020-12-15 Thread Jiaxun Yang
在 2020/12/16 上午7:48, Philippe Mathieu-Daudé 写道: On 12/16/20 12:27 AM, Richard Henderson wrote: On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote: +bool isa_rel6_available(const CPUMIPSState *env) +{ +if (TARGET_LONG_BITS == 64) { +return cpu_supports_isa(env, ISA_MIPS64R6); +

Re: [PATCH v2 03/24] target/mips/cpu: Introduce isa_rel6_available() helper

2020-12-15 Thread Jiaxun Yang
在 2020/12/16 上午10:50, Jiaxun Yang 写道: TBH I do think it doesn't sounds like a good idea to make 32-bit and 64-bit different. In fact ISA_MIPS32R6 is always set for targets with ISA_MIPS64R6. We're treating MIPS64R6 as a superset of MIPS32R6, and ISA_MIPS3 is used to tell if a CPU supports 6

CXL support in QEMU

2020-12-15 Thread Prashant V Agarwal
Hi, Is there a way to know the support plans for CXL protocol in QEMU? I see that there is side branch development going on: https://gitlab.com/bwidawsk/qemu/-/tree/cxl-2.0v2 But when does it get merged and gets released in QEMU formally? Is there a way to know a rough timeline? Regards, Prashan

Re: [PATCH v2 04/12] i386: Register feature bit properties as class properties

2020-12-15 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Dec 15, 2020 at 03:11:06PM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > Class properties make QOM introspection simpler and easier, as >> > they don't require an object to be instantiated. >> > >> > Signed-off-by: Eduardo Habkost >> >> T

Re: [PATCH v5 3/4] hmp: Use QMP query-netdev in hmp_info_network

2020-12-15 Thread Jason Wang
- Original Message - > Jason Wang writes: > > [...] > > One more stupid question, instead of generating the string via hard > > codes, is there any method (dict?) to iterate all the key/values > > automatically? > > QAPI visitors. > > The lazy way: use the QObject output visitor to c

[PATCH v15 04/13] qapi: add filter-node-name to block-stream

2020-12-15 Thread Vladimir Sementsov-Ogievskiy
From: Andrey Shinkevich Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy [vsementsov: comment indentation, s/Since: 5.2/Since: 6.0/] Revi

[PATCH v15 00/13] Apply COR-filter to the block-stream permanently

2020-12-15 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is a new version of cor-filter in block-stream series. Main change is freezing the chain in cor-filter itself. v15: 02: s/ = / = / add Max's r-b 03: add Max's r-b 04: since: 6.0 indent comment add Max's r-b 05: changed commit msg wording document the default

[PATCH v15 02/13] block: add API function to insert a node

2020-12-15 Thread Vladimir Sementsov-Ogievskiy
From: Andrey Shinkevich Provide API for insertion a node to backing chain. Suggested-by: Max Reitz Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- include/block/block.h | 2 ++ block.c | 25 + 2 fil

[PATCH v15 10/13] qapi: block-stream: add "bottom" argument

2020-12-15 Thread Vladimir Sementsov-Ogievskiy
The code already don't freeze base node and we try to make it prepared for the situation when base node is changed during the operation. In other words, block-stream doesn't own base node. Let's introduce a new interface which should replace the current one, which will in better relations with the

[PATCH v15 05/13] qapi: copy-on-read filter: add 'bottom' option

2020-12-15 Thread Vladimir Sementsov-Ogievskiy
From: Andrey Shinkevich Add an option to limit copy-on-read operations to specified sub-chain of backing-chain, to make copy-on-read filter useful for block-stream job. Suggested-by: Max Reitz Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich Signed-off-by: Vladimir

[PATCH v15 09/13] stream: rework backing-file changing

2020-12-15 Thread Vladimir Sementsov-Ogievskiy
From: Andrey Shinkevich Stream in stream_prepare calls bdrv_change_backing_file() to change backing-file in the metadata of bs. It may use either backing-file parameter given by user or just take filename of base on job start. Backing file format is determined by base on job finish. There are

[PATCH v15 01/13] copy-on-read: support preadv/pwritev_part functions

2020-12-15 Thread Vladimir Sementsov-Ogievskiy
From: Andrey Shinkevich Add support for the recently introduced functions bdrv_co_preadv_part() and bdrv_co_pwritev_part() to the COR-filter driver. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/copy-on-read.c | 28 1 file ch

[PATCH v15 06/13] iotests: add #310 to test bottom node in COR driver

2020-12-15 Thread Vladimir Sementsov-Ogievskiy
From: Andrey Shinkevich The test case #310 is similar to #216 by Max Reitz. The difference is that the test #310 involves a bottom node to the COR filter driver. Signed-off-by: Andrey Shinkevich Signed-off-by: Vladimir Sementsov-Ogievskiy [vsementsov: detach backing to test reads from top, l

[PATCH v15 11/13] iotests: 30: prepare to COR filter insertion by stream job

2020-12-15 Thread Vladimir Sementsov-Ogievskiy
test_stream_parallel run parallel stream jobs, intersecting so that top of one is base of another. It's OK now, but it would be a problem if insert the filter, as one job will want to use another job's filter as above_base node. Correct thing to do is move to new interface: "bottom" argument inste

[PATCH v15 03/13] copy-on-read: add filter drop function

2020-12-15 Thread Vladimir Sementsov-Ogievskiy
From: Andrey Shinkevich Provide API for the COR-filter removal. Also, drop the filter child permissions for an inactive state when the filter node is being removed. To insert the filter, the block generic layer function bdrv_insert_node() can be used. The new function bdrv_cor_filter_drop() may b

<    1   2   3   4   5   >