[PATCH 6/8] hw/ppc: Delete unused ppc405cr_init() code

2020-12-11 Thread Peter Maydell
The function ppc405cr_init() has apparently been unused since it was added in commit 8ecc7913525ecb in 2007. Remove this dead code, so we don't have to convert it away from using ppcuic_init(). Signed-off-by: Peter Maydell --- hw/ppc/ppc405.h| 6 - hw/ppc/ppc405_uc.c | 345 ---

[PATCH 8/8] hw/ppc: Remove unused ppcuic_init()

2020-12-11 Thread Peter Maydell
Now we've converted all the callsites to directly create the QOM UIC device themselves, the ppcuic_init() function is unused and can be removed. The enum defining PPCUIC symbolic constants can be moved to the ppc-uic.h header where it more naturally belongs. Signed-off-by: Peter Maydell --- incl

[PATCH 7/8] hw/ppc/ppc405_uc: Drop use of ppcuic_init()

2020-12-11 Thread Peter Maydell
Switch the ppc405_uc boards to directly creating and configuring the UIC, rather than doing it via the old ppcuic_init() helper function. We retain the API feature of ppc405ep_init() where it passes back something allowing the callers to wire up devices to the UIC if they need to, even though neit

Re: [PATCH 0/7] Additional NPCM7xx devices and IPMI BMC emulation support

2020-12-11 Thread Havard Skinnemoen via
On Fri, Dec 11, 2020 at 4:16 PM Corey Minyard wrote: > On Fri, Dec 11, 2020 at 12:56:07PM -0800, Hao Wu wrote: > > Tl,dr: We'll remove the IPMI changes from the current patch set and > > refactor > > them in a separate patch set. > > > > Thank you for your review! On high level, we are

Re: [PATCH 0/7] Additional NPCM7xx devices and IPMI BMC emulation support

2020-12-11 Thread Corey Minyard
On Fri, Dec 11, 2020 at 12:56:07PM -0800, Hao Wu wrote: > Tl,dr: We'll remove the IPMI changes from the current patch set and > refactor > them in a separate patch set. > > Thank you for your review! On high level, we are trying to emulate the BMC > side of the IPMI protocol. So we canno

Re: [PATCH 0/7] Additional NPCM7xx devices and IPMI BMC emulation support

2020-12-11 Thread Hao Wu via
Thanks for the comments! I've removed IPMI part from the patch sets. I'll send a separate patch sets once the refactor is done. I'll also include Havard's documentation in it. I haven't thought of a better name. We can update the name accordingly. On Fri, Dec 11, 2020 at 4:26 PM Havard Skinnemoe

Re: [PULL 0/6] s390x update

2020-12-11 Thread Peter Maydell
ilable in the Git repository at: > > https://github.com/cohuck/qemu tags/s390x-20201211 > > for you to fetch changes up to c7454f05171405b8013a9d6b57045cd614ccc386: > > s390x/cpu: Use timer_free() in the finalize functio

Re: [PATCH 0/7] Additional NPCM7xx devices and IPMI BMC emulation support

2020-12-11 Thread Corey Minyard
On Fri, Dec 11, 2020 at 04:26:03PM -0800, Havard Skinnemoen wrote: > On Fri, Dec 11, 2020 at 4:16 PM Corey Minyard wrote: > > > On Fri, Dec 11, 2020 at 12:56:07PM -0800, Hao Wu wrote: > > > Tl,dr: We'll remove the IPMI changes from the current patch set and > > > refactor > > > them in

Re: [PATCH] ide:atapi: check io_buffer_index in ide_atapi_cmd_reply_end

2020-12-11 Thread leonwxqian

Re: [PATCH] icount: improve exec nocache usage

2020-12-11 Thread Pavel Dovgalyuk
On 12.12.2020 00:41, Richard Henderson wrote: On 12/8/20 3:10 AM, Pavel Dovgalyuk wrote: cpu-exec tries to execute TB without caching when current icount budget is over. But sometimes refilled budget is big enough to try executing cached blocks. This patch checks that instruction budget is big e

Re: ceph + freeipa ubuntu/fedora common small bug

2020-12-11 Thread Harry Coin
It's the latest ubuntu and fedora distros. On December 11, 2020 5:05:22 AM CST, "Dr. David Alan Gilbert" wrote: >* Harry G. Coin (hgc...@gmail.com) wrote: >> FYI.  Same thing we saw on Fedora installing freeipa, this on ubuntu >> with ceph.  Identical bitmask report. >> >> ... >> >> Fixing

Re: [PATCH 2/3] tests/acceptance/machine_s390_ccw_virtio: Test virtio-rng via /dev/hwrng

2020-12-11 Thread Thomas Huth
On 11/12/2020 21.30, Wainer dos Santos Moschetta wrote: > Hi, > > On 12/11/20 2:31 PM, Thomas Huth wrote: >> /dev/hwrng is only functional if virtio-rng is working right, so let's >> add a sanity check for this device node. > > Good idea. > >> >> Signed-off-by: Thomas Huth >> --- >>   tests/acc

Re: [PATCH 0/3] tests/acceptance: Test virtio-rng and -balloon on s390x

2020-12-11 Thread Thomas Huth
On 11/12/2020 21.10, Willian Rampazzo wrote: > On 12/11/20 2:31 PM, Thomas Huth wrote: >> Add two more simple tests to check that virtio-rng and virtio-balloon >> are at least (very) basically working on s390x. >> >> Based-on: 20201204121450.120730-1-coh...@redhat.com >> >> Thomas Huth (3): >>    t

RE: [PATCH 11/12] tests/fp: Do not emit implicit-fallthrough warnings in the softfloat tests

2020-12-11 Thread Chenqun (kuhn)
> -Original Message- > From: Thomas Huth [mailto:th...@redhat.com] > Sent: Friday, December 11, 2020 11:24 PM > To: Peter Maydell ; qemu-devel@nongnu.org > Cc: Chenqun (kuhn) ; Richard Henderson > ; Paolo Bonzini > Subject: [PATCH 11/12] tests/fp: Do not emit implicit-fallthrough warnings

<    1   2   3   4   5