From: Gan Qixin
Replace manual lock()/unlock() calls with lock guard macros
(QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/accounting.
Signed-off-by: Gan Qixin
Reviewed-by: Paolo Bonzini
Message-Id: <20201203075055.127773-2-ganqi...@huawei.com>
Signed-off-by: Kevin Wolf
---
block/accounting
From: Gan Qixin
Replace manual lock()/unlock() calls with lock guard macros
(QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/throttle-groups.
Signed-off-by: Gan Qixin
Message-Id: <20201203075055.127773-4-ganqi...@huawei.com>
Signed-off-by: Kevin Wolf
---
block/throttle-groups.c | 48 ++
From: Max Reitz
Signed-off-by: Max Reitz
Message-Id: <20201027190600.192171-2-mre...@redhat.com>
Signed-off-by: Kevin Wolf
---
meson_options.txt | 2 ++
configure | 7 +++
meson.build | 6 ++
3 files changed, 15 insertions(+)
diff --git a/meson_options.txt b/meson_option
Hi,
On 12/7/20 10:14 AM, Philippe Mathieu-Daudé wrote:
Document what this job cover (build X86 targets with
KVM being the single accelerator available).
Reviewed-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.yml | 5 +
1 file changed, 5 insertions(+)
Reviewed-b
From: Max Reitz
Signed-off-by: Max Reitz
Message-Id: <20201027190600.192171-18-mre...@redhat.com>
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/check | 11 +++
tests/qemu-iotests/common.rc | 17 +
2 files changed, 28 insertions(+)
diff --git a/tests/qemu-iotests
From: Max Reitz
This makes the export actually useful instead of only producing errors
whenever it is accessed.
Signed-off-by: Max Reitz
Message-Id: <20201027190600.192171-4-mre...@redhat.com>
Signed-off-by: Kevin Wolf
---
block/export/fuse.c | 242
From: Max Reitz
Executing _make_test_img as part of a pipe will undo all variable
changes it has done. As such, this could not work with FUSE (because
we want to remember all of our exports and their qemu instances).
Replace the pipe by a temporary file in 071 and 174 (the two tests that
can ru
From: Max Reitz
Many tests (that do not support generic protocols) can run just fine
with FUSE-exported images, so allow them to. Note that this is no
attempt at being definitely complete. There are some tests that might
be modified to run on FUSE, but this patch still skips them. This patch
o
From: Max Reitz
These will behave more like normal files in that writes beyond the EOF
will automatically grow the export size.
As an optimization, keep the RESIZE permission for growable exports so
we do not have to take it for every post-EOF write. (This permission is
not released when the ex
From: Gan Qixin
Replace manual lock()/unlock() calls with lock guard macros
(QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/iscsi.
Signed-off-by: Gan Qixin
Message-Id: <20201203075055.127773-5-ganqi...@huawei.com>
Signed-off-by: Kevin Wolf
---
block/iscsi.c | 50 --
The drain functions assume that we hold the AioContext lock of the
drained block node. Make sure to actually take the lock.
Cc: qemu-sta...@nongnu.org
Fixes: eb94b81a94bce112e6b206df846c1551aaf6cab6
Signed-off-by: Kevin Wolf
Message-Id: <20201203172311.68232-3-kw...@redhat.com>
Reviewed-by: Vladi
From: Max Reitz
Otherwise, exports and block devices are not properly shut down and
closed, unless the users explicitly issues blockdev-del and
block-export-del commands for each of them.
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
Message-Id: <20201027190600.192171-17-mre...@redhat.com>
From: Max Reitz
This is a relatively new feature in libfuse (available since 3.8.0,
which was released in November 2019), so we have to add a dedicated
check whether it is available before making use of it.
Signed-off-by: Max Reitz
Message-Id: <20201027190600.192171-7-mre...@redhat.com>
Signed-
From: Max Reitz
287 creates an image in a subshell (thanks to the pipe) to see whether
that is possible with compression_type=zstd. If _make_test_img were to
modify any global state, this global state would then be lost before we
could cleanup the image.
When using FUSE as the test protocol, th
From: Max Reitz
block-export-add type=fuse allows mounting block graph nodes via FUSE on
some existing regular file. That file should then appears like a raw
disk image, and accesses to it result in accesses to the exported BDS.
Right now, we only implement the necessary block export functions
If bdrv_co_yield_to_drain() is called for draining a block node that
runs in a different AioContext, it keeps that AioContext locked while it
yields and schedules a BH in the AioContext to do the actual drain.
As long as executing the BH is the very next thing that the event loop
of the node's Aio
From: Max Reitz
qemu-img convert (without -n) can often be replaced by a combination of
_make_test_img + qemu-img convert -n. Doing so allows converting to
protocols that do not allow direct file creation, such as FUSE exports.
The only problem is that for formats other than qcow2 and qed (qcow1
From: Max Reitz
This pretends FUSE exports are a kind of protocol. As such, they are
always tested under the format node. This is probably the best way to
test them, actually, because this will generate more I/O load and more
varied patterns.
Signed-off-by: Max Reitz
Message-Id: <202010271906
From: Max Reitz
This allows allocating areas after the (old) EOF as part of a growing
resize, writing zeroes, and discarding.
Signed-off-by: Max Reitz
Message-Id: <20201027190600.192171-6-mre...@redhat.com>
Signed-off-by: Kevin Wolf
---
block/export/fuse.c | 84 +++
From: Max Reitz
This generally does not work on non-file protocols. It is better to
create the image with the final name from the start, and most tests do
this already. Let 046 follow suit.
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
Message-Id: <20201027190600.192171-11-mre...@redhat.c
From: Li Feng
The scenario is that when accessing a volume on an NFS filesystem
without supporting the file lock, Qemu will complain "Failed to lock
byte 100", even when setting the file.locking = off.
We should do file lock related operations only when the file.locking is
enabled, otherwise, t
On 12/11/20 6:10 PM, Claudio Fontana wrote:
> On 12/11/20 6:05 PM, Richard Henderson wrote:
>> On 12/11/20 2:31 AM, Claudio Fontana wrote:
>>> From: Eduardo Habkost
>>>
>>> Signed-off-by: Eduardo Habkost
>>> [claudio: wrapped in CONFIG_TCG]
>>> Signed-off-by: Claudio Fontana
>>> Reviewed-by: Phi
From: Max Reitz
In most cases, _make_test_img does not need a _filter_imgfmt on top. It
does that by itself.
(The exception is when IMGFMT has been overwritten but TEST_IMG has not.
In such cases, we do need a _filter_imgfmt on top to filter the test's
original IMGFMT from TEST_IMG.)
Signed-of
From: Max Reitz
If the test environment has some other child processes running (like a
storage daemon that provides a FUSE export), then "wait" will never
finish. Use wait=yes _cleanup_qemu instead.
(We need to discard the output so there is no change to the reference
output.)
Signed-off-by: M
qobject_to_json() and qobject_to_json_pretty() build a GString, then
covert it to QString. Just one of the callers actually needs a
QString: qemu_rbd_parse_filename(). A few others need a string they
can modify: qmp_send_response(), qga's send_response(), to_json_str(),
and qmp_fd_vsend_fds(). T
From: Max Reitz
Avoid creating images with custom filenames in $TEST_DIR, because
non-file protocols may want to keep $TEST_IMG (and all other test
images) in some other directory.
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
Message-Id: <20201027190600.192171-12-mre...@redhat.com>
Signed-
From: Max Reitz
See the new comment for why this should be done.
I do not have a reproducer on master, but when using FUSE block exports,
this test breaks depending on the underlying filesystem (for me, it
works on tmpfs, but fails on xfs, because the block allocated by
file-posix has 16 kB ther
Commit aafb21a0b9 "qobject: let object_property_get_str() use new API"
isn't much of a simplification. Not worth having
object_property_get_str() differ from the other
object_property_get_FOO(). Revert.
This reverts commit aafb21a0b9cea5fa0fe52e68111bb6bd13837a02.
Cc: Paolo Bonzini
Cc: Daniel
From: Max Reitz
Most Python tests are restricted to the file protocol (without
explicitly saying so), but these are the ones that would break
./check -fuse -qcow2.
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
Message-Id: <20201027190600.192171-14-mre...@redhat.com>
Signed-off-by: Kevin Wol
From: Max Reitz
When most iotests want to create a test image that is named differently
from the default $TEST_IMG, they do something like this:
TEST_IMG="$TEST_IMG.base" _make_test_img $options
This works fine with the "file" protocol, but not so much for anything
else: _make_test_img trie
Providing the 'if' property, but not 'canbus' segfaults like this:
#0 0x55b0f14d in can_bus_insert_client (bus=0x0,
client=0x56aa9af0) at ../net/can/can_core.c:88
#1 0x559c3803 in can_host_connect (ch=0x56aa9ac0,
errp=0x7fffd568) at ../net/can/can_host.c:62
#2 0
As I am interested in using the runner based on the fedora-i386-cross
docker image, add a smoke test job to be sure this image is usable,
and set the JOB_MAINTAINER_NAME/JOB_MAINTAINER_EMAIL variables so
other developers can contact me in case there is a problem with the
public runner based on this
From: Max Reitz
We have good coverage of the normal I/O paths now, but what remains is a
test that tests some more special cases: Exporting an image on itself
(thus turning a formatted image into a raw one), some error cases, and
non-writable and non-growable exports.
Signed-off-by: Max Reitz
R
From: Vladimir Sementsov-Ogievskiy
Move bdrv_is_inserted() calls into callers.
We are going to make bdrv_check_byte_request() a clean thing.
bdrv_is_inserted() is not about checking the request, it's about
checking the bs. So, it should be separate.
With this patch we probably change error path
From: Vladimir Sementsov-Ogievskiy
We are going to modify block layer to work with 64bit requests. And
first step is moving to int64_t type for both offset and bytes
arguments in all block request related functions.
It's mostly safe (when widening signed or unsigned int to int64_t), but
switchin
On 12/11/20 5:13 PM, Richard Henderson wrote:
> On 12/11/20 2:31 AM, Claudio Fontana wrote:
>> Signed-off-by: Claudio Fontana
>> Reviewed-by: Alex Bennée
>> ---
>> target/i386/cpu.h | 1 +
>> target/i386/cpu-dump.c | 537
>> target/i386/helper.c
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/qbool.h | 2 --
include/qapi/qmp/qdict.h | 2 --
include/qapi/qmp/qlist.h | 2 --
include/qapi/qmp/qnull.h | 2 --
include/qapi/qmp/qnum.h| 3 ---
include/qapi/qmp/qobject.h | 9 +
include/qapi/qmp/qstring.h | 2 --
From: Vladimir Sementsov-Ogievskiy
We should not set overlap_bytes:
1. Don't worry: it is calculated by bdrv_mark_request_serialising() and
will be equal to or greater than bytes anyway.
2. If the request was already aligned up to some greater alignment,
than we may break things: we reduc
On 11.12.20 17:50, Vladimir Sementsov-Ogievskiy wrote:
11.12.2020 19:05, Max Reitz wrote:
On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote:
The code already don't freeze base node and we try to make it prepared
for the situation when base node is changed during the operation. In
other word
On 12/11/20 6:05 PM, Richard Henderson wrote:
> On 12/11/20 2:31 AM, Claudio Fontana wrote:
>> From: Eduardo Habkost
>>
>> Signed-off-by: Eduardo Habkost
>> [claudio: wrapped in CONFIG_TCG]
>> Signed-off-by: Claudio Fontana
>> Reviewed-by: Philippe Mathieu-Daudé
>> Reviewed-by: Alex Bennée
>>
This reverts commit 164c374b75f87c6765a705c4418ab7005a2d356f.
A free function for a reference-counted object is in bad taste.
Fortunately, this one is now also unused. Drop it.
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/qstring.h | 1 -
qobject/qstring.c | 27 +
From: Vladimir Sementsov-Ogievskiy
This simplifies following commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20201203222713.13507-3-vsement...@virtuozzo.com>
Reviewed-by: Alberto Garcia
Signed-off-by: Kevin Wolf
---
block/io.c | 7 +++
1 file changed, 3 insertions(+), 4
On 12/11/20 11:10 AM, Claudio Fontana wrote:
> On 12/11/20 6:05 PM, Richard Henderson wrote:
>> On 12/11/20 2:31 AM, Claudio Fontana wrote:
>>> From: Eduardo Habkost
>>>
>>> Signed-off-by: Eduardo Habkost
>>> [claudio: wrapped in CONFIG_TCG]
>>> Signed-off-by: Claudio Fontana
>>> Reviewed-by: Ph
Signed-off-by: Markus Armbruster
---
qobject/qjson.c | 110
1 file changed, 54 insertions(+), 56 deletions(-)
diff --git a/qobject/qjson.c b/qobject/qjson.c
index 2f690c1816..962214f5a7 100644
--- a/qobject/qjson.c
+++ b/qobject/qjson.c
@@ -156,6
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/qstring.h | 1 -
qobject/qstring.c | 11 ---
2 files changed, 12 deletions(-)
diff --git a/include/qapi/qmp/qstring.h b/include/qapi/qmp/qstring.h
index e4ac761a22..56034dae54 100644
--- a/include/qapi/qmp/qstring.h
+++ b/in
The only thing that happens after the 'out:' label is blk_unref(blk).
However, blk = NULL in all of the error cases, so instead of jumping to
'out:', we can just return directly.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Kevin Wolf
Message-Id: <20201203172311.68232-2-kw...@redhat.com>
Reviewed-by
11.12.2020 20:24, Max Reitz wrote:
On 11.12.20 17:50, Vladimir Sementsov-Ogievskiy wrote:
11.12.2020 19:05, Max Reitz wrote:
On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote:
The code already don't freeze base node and we try to make it prepared
for the situation when base node is changed
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/qjson.h | 2 +-
monitor/qmp.c| 2 +-
qemu-img.c | 8
qobject/qjson.c | 28 +++-
qom/qom-hmp-cmds.c | 2 +-
tests/qtest/libqtest.c | 2 +-
6 files changed, 19 inse
I'm about to remove qobject_get_try_str(). Use qstring_get_str()
instead. Safe because the argument is known to be a QString here.
Cc: Kevin Wolf
Cc: Max Reitz
Cc: qemu-bl...@nongnu.org
Signed-off-by: Markus Armbruster
---
block.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
GString has a richer set of string operations than QString. It should
be preferred to QString except where we need a QObject or reference
counting. We don't here. Switch to GString, and put its richer
interface to use.
Cc: Dr. David Alan Gilbert
Signed-off-by: Markus Armbruster
---
monitor/m
On 12/11/20 2:31 AM, Claudio Fontana wrote:
> cc->do_interrupt is in theory a TCG callback used in accel/tcg only,
> to prepare the emulated architecture to take an interrupt as defined
> in the hardware specifications,
>
> but in reality the _do_interrupt style of functions in targets are
> also
QString supports modifying its string, but it's quite limited: you can
only append. The remaining callers use it for building an initial
string, never for modifying it later.
Change parse_string() to do build the initial string with GString.
This is another step towards making QString immutable.
QString supports modifying its string, but it's quite limited: you can
only append. Just one caller remains:
bdrv_parse_filename_strip_prefix() uses it just for building an
initial string.
Change it to do build the initial string with GString. This is
another step towards making QString immutabl
QString supports modifying its string, but it's quite limited: you can
only append. The remaining callers use it for building an initial
string, never for modifying it later.
Use of GString for building the initial string is actually more
convenient here. Change qobject_to_json() & friends to do
QString supports modifying its string, but it's quite limited: you can
only append. The remaining callers use it for building an initial
string, never for modifying it later.
Change keyval_parse_one() to do build the initial string with GString.
This is another step towards making QString immutab
RdmaProtectedQList provides a thread-safe queue of int64_t on top of a
QList.
rdma_protected_qlist_destroy() calls qlist_destroy_obj() directly.
qlist_destroy_obj() is actually for use by qobject_destroy() only.
The next commit will make that obvious.
The minimal fix would be calling qobject_unre
Commit 48c043d0d1 "hmp: human-monitor-command: stop using the Memory
chardev driver" left us "if string is non-empty, duplicate it, else
duplicate the empty string". Meh. Duplicate it unconditionally.
Cc: Dr. David Alan Gilbert
Signed-off-by: Markus Armbruster
---
monitor/misc.c | 6 +-
1
The functions to modify a QString's string are all unused now. Drop
them, and make the string immutable. Saves 16 bytes per QString on my
system.
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/qstring.h | 8 +
qobject/qstring.c | 65 ++
We have two JSON writers written in C: qobject/qjson.c provides
qobject_to_json(), and migration/qjson.c provides a more low level
imperative interface. They don't share code. The latter tacitly
limits numbers to int64_t, and strings contents to characters that
don't need escaping.
Factor out qo
Based-on: <20201210161452.2813491-1-arm...@redhat.com>
Cc: Daniel P. Berrangé
Cc: Dr. David Alan Gilbert
Cc: Eduardo Habkost
Cc: Juan Quintela
Cc: Kevin Wolf
Cc: Marcel Apfelbaum
Cc: Max Reitz
Cc: Paolo Bonzini
Cc: Yuval Shaia
Cc: qemu-bl...@nongnu.org
Markus Armbruster (20):
hmp: Simp
No users left outside tests/, and the ones in tests/ can just as well
use qstring_get_str(). Do that, and drop the function.
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/qstring.h | 1 -
qobject/qstring.c | 10 --
tests/check-qjson.c| 11 +--
3 files c
Tracepoints monitor_qmp_cmd_in_band and
monitor_qmp_cmd_out_of_band (commit cf869d5317 "qmp: support
out-of-band (oob) execution") treat non-string "id" like absent "id".
Fix that.
Signed-off-by: Markus Armbruster
---
monitor/qmp.c | 30 ++
1 file changed, 18 insertio
Commit 8118f0950f "migration: Append JSON description of migration
stream" needs a JSON writer. The existing qobject_to_json() wasn't a
good fit, because it requires building a QObject to convert. Instead,
migration got its very own JSON writer, in commit 190c882ce2 "QJSON:
Add JSON writer". It
On 12/11/20 5:56 PM, Richard Henderson wrote:
> On 12/11/20 2:31 AM, Claudio Fontana wrote:
>> for now only TCG is allowed as an accelerator for riscv,
>> so remove the CONFIG_TCG use.
>>
>> Signed-off-by: Claudio Fontana
>> Reviewed-by: Alistair Francis
>> ---
>> target/riscv/cpu.c | 3 +--
>>
On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote:
From: Andrey Shinkevich
This patch completes the series with the COR-filter applied to
block-stream operations.
Adding the filter makes it possible in future implement discarding
copied regions in backing files during the block-stream job,
/dev/hwrng is only functional if virtio-rng is working right, so let's
add a sanity check for this device node.
Signed-off-by: Thomas Huth
---
tests/acceptance/machine_s390_ccw_virtio.py | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/tests/acceptance/machi
On 12/11/20 5:44 PM, Richard Henderson wrote:
> On 12/11/20 2:31 AM, Claudio Fontana wrote:
>> Signed-off-by: Claudio Fontana
>> ---
>> target/i386/cpu.h | 97 ++---
>> target/i386/tcg/helper-tcg.h | 112 ++
>> target/i386/tcg/
Yet another attempt to make GitLab-CI inclusive to the
all users from the QEMU community.
We allow manual pipeline for some users, letting default
to all jobs started.
Also I step in to maintain in my work time the public
runner based on Fedora that we use for the X86 32-bit
builds, because I don
Inflate the balloon and check whether the size of the memory changes.
Signed-off-by: Thomas Huth
---
tests/acceptance/machine_s390_ccw_virtio.py | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/tests/acceptance/machine_s390_ccw_virtio.py
b/tests/acceptance/machin
We will use this in more spots soon, so it's easier to put this into
a separate function.
Signed-off-by: Thomas Huth
---
tests/acceptance/machine_s390_ccw_virtio.py | 30 -
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/tests/acceptance/machine_s390_ccw_virti
It might be overkill (and frustrating) to rerun all the jobs when
iterating over a single code unit. As some users are interested
in only rerunning a specific set of jobs, allow them to use a
"manual" profile, when jobs are created in the pipeline but not
started. It is up to the user to manually s
On 12/11/20 6:47 PM, Claudio Fontana wrote:
> On 12/11/20 6:28 PM, Richard Henderson wrote:
>> On 12/11/20 11:10 AM, Claudio Fontana wrote:
>>> On 12/11/20 6:05 PM, Richard Henderson wrote:
On 12/11/20 2:31 AM, Claudio Fontana wrote:
> From: Eduardo Habkost
>
> Signed-off-by: Edua
On 12/11/20 2:31 AM, Claudio Fontana wrote:
> From: Eduardo Habkost
>
> Signed-off-by: Eduardo Habkost
> [claudio: wrapped in CONFIG_TCG]
> Signed-off-by: Claudio Fontana
> Reviewed-by: Philippe Mathieu-Daudé
> Reviewed-by: Alex Bennée
> ---
> include/hw/core/cpu.h | 6 --
> i
11.12.2020 20:21, Max Reitz wrote:
On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote:
From: Andrey Shinkevich
This patch completes the series with the COR-filter applied to
block-stream operations.
Adding the filter makes it possible in future implement discarding
copied regions in backin
On 12/11/20 2:31 AM, Claudio Fontana wrote:
> From: Eduardo Habkost
>
> Signed-off-by: Eduardo Habkost
> [claudio: wrapped in CONFIG_TCG]
> Signed-off-by: Claudio Fontana
> Reviewed-by: Philippe Mathieu-Daudé
> Reviewed-by: Alex Bennée
> ---
> include/hw/core/cpu.h | 9 -
>
Sai Pavan Boddu would like to recall the message, "[PATCH v15 0/4] Add Versal
usb model".
Add two more simple tests to check that virtio-rng and virtio-balloon
are at least (very) basically working on s390x.
Based-on: 20201204121450.120730-1-coh...@redhat.com
Thomas Huth (3):
tests/acceptance: Extract the code to clear dmesg and wait for CRW
reports
tests/acceptance/machine_s3
Sai Pavan Boddu would like to recall the message, "[PATCH v15 0/4] Add Versal
usb model".
On 12/11/20 2:31 AM, Claudio Fontana wrote:
> @@ -848,7 +842,7 @@ static inline void cpu_unaligned_access(CPUState *cpu,
> vaddr addr,
>
> cc->do_unaligned_access(cpu, addr, access_type, mmu_idx, retaddr);
> }
> -
> +#ifdef CONFIG_TCG
> static inline void cpu_transaction_failed(CPUState *
On 12/11/20 2:31 AM, Claudio Fontana wrote:
> From: Eduardo Habkost
>
> Signed-off-by: Eduardo Habkost
> Signed-off-by: Claudio Fontana
> Reviewed-by: Alex Bennée
> ---
> include/hw/core/cpu.h | 2 --
> include/hw/core/tcg-cpu-ops.h | 2 ++
> accel/tcg/cpu-exec.c | 4 ++--
>
On 12/11/20 2:31 AM, Claudio Fontana wrote:
> +++ b/include/hw/core/tcg-cpu-ops.h
> @@ -66,6 +66,13 @@ typedef struct TcgCpuOperations {
>unsigned size, MMUAccessType access_type,
>int mmu_idx, MemTxAttrs attrs,
>
On 12/11/20 6:28 PM, Richard Henderson wrote:
> On 12/11/20 11:10 AM, Claudio Fontana wrote:
>> On 12/11/20 6:05 PM, Richard Henderson wrote:
>>> On 12/11/20 2:31 AM, Claudio Fontana wrote:
From: Eduardo Habkost
Signed-off-by: Eduardo Habkost
[claudio: wrapped in CONFIG_TCG]
>
On 12/11/20 11:47 AM, Claudio Fontana wrote:
>> What is it that you thought you needed from core/cpu.h anyway?
...
Are you sure that splitting out hw/core/tcg-cpu-ops.h from hw/core/cpu.h in
patch 15 is even useful?
>>>
>>> it avoids a huge #ifdef CONFIG_TCG
>>
>> So? The question should
On 11.12.20 18:42, Vladimir Sementsov-Ogievskiy wrote:
11.12.2020 20:24, Max Reitz wrote:
On 11.12.20 17:50, Vladimir Sementsov-Ogievskiy wrote:
11.12.2020 19:05, Max Reitz wrote:
On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote:
The code already don't freeze base node and we try to make
On 12/11/20 2:31 AM, Claudio Fontana wrote:
> Signed-off-by: Claudio Fontana
> Reviewed-by: Alex Bennée
> ---
> include/hw/core/cpu.h | 2 --
> include/hw/core/tcg-cpu-ops.h | 3 +++
> accel/tcg/cpu-exec.c| 4 ++--
> target/alpha/cpu.c | 2 +-
> target/ar
On 12/11/20 12:15 PM, Claudio Fontana wrote:
> Should I return this file to the original state (without the extra #includes
> that pretend it to be a standalone header file,
> and call it
>
> tcg-cpu-ops.h.inc
>
> ?
If this header can work with qemu/typedefs.h, then no, because the circularity
* Vivek Goyal (vgo...@redhat.com) wrote:
> On Thu, Dec 10, 2020 at 08:29:21PM +0100, Miklos Szeredi wrote:
> > On Thu, Dec 10, 2020 at 5:11 PM Vivek Goyal wrote:
> >
> > > Conclusion
> > > ---
> > > - virtiofs DAX seems to help a lot in many workloads.
> > >
> > > Note, DAX performance
Hi all!
We want 64bit write-zeroes, and for this, convert all io functions to
64bit.
We chose signed type, to be consistent with off_t (which is signed) and
with possibility for signed return type (where negative value means
error).
Please refer to initial cover-letter
https://lists.gnu.org/ar
To use Avocado's testlogs plug-in on CI it is required to use
its 83.0 or greater version.
Signed-off-by: Wainer dos Santos Moschetta
---
tests/requirements.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/requirements.txt b/tests/requirements.txt
index a1c631fa59..6
Replace the code (python) on after_script of the acceptance jobs that
is currently used to show the logs of failed tests. Instead it is used
the Avocado's testlogs plug-in which works likewise.
Signed-off-by: Wainer dos Santos Moschetta
---
.gitlab-ci.yml | 3 ++-
1 file changed, 2 insertions(+)
It's better to pass &error_abort than just assert that result is 0: on
crash, we'll immediately see the reason in the backtrace.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block_int.h| 2 +-
block/file-posix.c | 2 +-
block/io.c | 29 +
On 12/11/20 7:22 PM, Richard Henderson wrote:
> On 12/11/20 12:15 PM, Claudio Fontana wrote:
>> Should I return this file to the original state (without the extra #includes
>> that pretend it to be a standalone header file,
>> and call it
>>
>> tcg-cpu-ops.h.inc
>>
>> ?
>
> If this header can wor
Actually, we can't extend the io vector in all cases. Handle possible
MAX_IOV and size_t overflows.
For now add assertion to callers (actually they rely on success anyway)
and fix them in the following patch.
Add also some additional good assertions to qemu_iovec_init_slice()
while being here.
S
Keep the logs of acceptance tests for two days on GitLab. If you want
to make it available for more time, click on the 'Keep' button on
the Job page at web UI.
By default GitLab will archive artifacts only if the job succeed.
Instead let's keep it on both success and failure, so it gives the
oppor
11.12.2020 20:11, Markus Armbruster wrote:
I'm about to remove qobject_get_try_str(). Use qstring_get_str()
instead. Safe because the argument is known to be a QString here.
Cc: Kevin Wolf
Cc: Max Reitz
Cc:qemu-bl...@nongnu.org
Signed-off-by: Markus Armbruster
Reviewed-by: Vladimir Sementsov
Calculation of sum may theoretically overflow, so use 64bit type and
add some good assertions.
Use int64_t constantly.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/io.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/block/io.c b/block/io.c
index 21e8a50725.
Make bdrv_pad_request() honest: return error if
qemu_iovec_init_extended() failed.
Update also bdrv_padding_destroy() to clean the structure for safety.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/io.c | 45 +++--
1 file changed, 31 insertions(+
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibili
Hi,
Finally, usb series got accepted. I thank Vikram and Edgar for the great
support.
Regards,
Sai Pavan
-Original Message-
From: Peter Maydell
Sent: Friday, December 11, 2020 9:40 PM
To: Sai Pavan Boddu
Cc: Markus Armbruster ; Marc-André Lureau
; Paolo Bonzini ; Gerd
Hoffmann ; Ed
Prepare to the following patch when bdrv_pad_request() will be able to
fail. Update the comments.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/io.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/block/io.c b/block/io.c
index d9bc67f1b0..dc
201 - 300 of 414 matches
Mail list logo
