[Bug 1907776] [NEW] Mounting VFat drive yields error messages.

Public bug reported: Mounting a virtual Fat drive results in error messages (see attached image). * https://www.qemu.org/docs/master/system/images.html#virtual-fat-disk- images The "drive" is however mounted, and as a test, saving a text file to the drive is successfully stored in the directory

Re: [PATCH v3 0/7] silence the compiler warnings

On 11/12/2020 03.22, Chenqun (kuhn) wrote: > Kindly ping! > > Hi all, > Patch 1 to Patch 5 are not in the queue. Could someone pick them up？ Hi, yes, I'm currently preparing another patch series that includes your patches, which will finally turn on -Wimplicit-fallthrough for everybody. I'll

[PATCH v11 01/25] accel/tcg: split CpusAccel into three TCG variants

split up the CpusAccel tcg_cpus into three TCG variants: tcg_cpus_rr (single threaded, round robin cpus) tcg_cpus_icount (same as rr, but with instruction counting enabled) tcg_cpus_mttcg (multi-threaded cpus) Suggested-by: Richard Henderson Signed-off-by: Claudio Fontana Reviewed-by: Richard H

[PATCH v11 00/25] i386 cleanup PART 1

Hello, this is version 11 of the cleanup. The series has been split into two separate parts, and this is PART 1. v10 -> v11: small tweaks for !CONFIG_USER_ONLY * make transaction_failed and do_unaligned_access consistently !CONFIG_USER_ONLY. * hw/mips/jazz: wrap mips_jazz_do_transaction_faile

[PATCH v11 04/25] i386: move kvm accel files into kvm/

Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- meson.build | 1 + target/i386/cpu.h| 2 +- target/i386/{ => kvm}/hyperv-proto.h | 0 target/i386/{ => kvm}/hyperv.h | 0 target/i386/{ => kvm}/kvm_i386.h | 0 target/i386/kvm/trace

[PATCH v11 08/25] i386: move TCG accel files into tcg/

Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- target/i386/{ => tcg}/bpt_helper.c | 0 target/i386/{ => tcg}/cc_helper.c | 0 target/i386/{ => tcg}/excp_helper.c | 0 target/i386/{ => tcg}/fpu_helper.c | 0 target/i386/{ => tcg}/int_helper.c | 0 target/i386/{ => tcg}/mem_

[PATCH v11 02/25] accel/tcg: split tcg_start_vcpu_thread

after the initial split into 3 tcg variants, we proceed to also split tcg_start_vcpu_thread. We actually split it in 2 this time, since the icount variant just uses the round robin function. Suggested-by: Richard Henderson Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson --- acce

[PATCH v11 13/25] tcg: Make CPUClass.debug_excp_handler optional

From: Eduardo Habkost Signed-off-by: Eduardo Habkost Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- accel/tcg/cpu-exec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 890b88861a..64cba89356 100644 --- a/ac

[PATCH v11 11/25] tcg: cpu_exec_{enter,exit} helpers

From: Eduardo Habkost Move invocation of CPUClass.cpu_exec_*() to separate helpers, to make it easier to refactor that code later. Signed-off-by: Eduardo Habkost Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- accel/tcg/cpu-exec.c | 23 ++- 1 file changed, 18

[PATCH v11 03/25] accel/tcg: rename tcg-cpus functions to match module name

Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- accel/tcg/tcg-cpus-icount.h | 6 +-- accel/tcg/tcg-cpus-rr.h | 2 +- accel/tcg/tcg-cpus.h| 6 +-- accel/tcg/tcg-cpus-icount.c | 24 ++-- accel/tcg/tcg-cpus-mttcg.c | 10

[PATCH v11 07/25] i386: hvf: remove stale MAINTAINERS entry for old hvf stubs

Signed-off-by: Claudio Fontana Reviewed-by: Roman Bolshakov Reviewed-by: Alex Bennée --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 448593c904..f53f2678d8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -444,7 +444,6 @@ M: Cameron Esfahani M:

[PATCH v11 10/25] i386: move TCG cpu class initialization out of helper.c

Signed-off-by: Claudio Fontana --- target/i386/cpu.h | 97 ++--- target/i386/tcg/helper-tcg.h | 112 ++ target/i386/tcg/tcg-cpu.h | 15 + target/i386/cpu.c | 33 -- target/i386/helper.c |

[PATCH v11 05/25] i386: move whpx accel files into whpx/

Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- target/i386/{ => whpx}/whp-dispatch.h | 0 target/i386/{ => whpx}/whpx-cpus.h| 0 target/i386/{ => whpx}/whpx-all.c | 0 target/i386/{ => whpx}/whpx-cpus.c| 0 MAINTAINERS | 5 + target/i386/mes

[PATCH v11 17/25] accel/tcg: split TCG-only code from cpu_exec_realizefn

move away TCG-only code, make it compile only on TCG. Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- include/hw/core/cpu.h | 8 + accel/tcg/cpu-exec.c | 28 + cpu.c | 70 --- hw/core/cpu.c | 6 ++

[PATCH v11 06/25] i386: move hax accel files into hax/

Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- target/i386/{ => hax}/hax-cpus.h | 0 target/i386/{ => hax}/hax-i386.h | 6 +++--- target/i386/{ => hax}/hax-interface.h | 0 target/i386/{ => hax}/hax-posix.h | 0 target/i386/{ => hax}/hax-windows.h | 0 target/i386/{

[PATCH v11 12/25] tcg: make CPUClass.cpu_exec_* optional

From: Eduardo Habkost This will let us simplify the code that initializes CPU class methods, when we move cpu_exec_*() to a separate struct. Signed-off-by: Eduardo Habkost Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- accel/tcg/cpu-exec.c | 11 --- 1 file changed, 8 ins

[PATCH v11 20/25] cpu: Move tlb_fill to tcg_ops

From: Eduardo Habkost Signed-off-by: Eduardo Habkost [claudio: wrapped in CONFIG_TCG] Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- include/hw/core/cpu.h | 9 - include/hw/core/tcg-cpu-ops.h | 12 accel/tcg/c

[PATCH v11 21/25] cpu: Move debug_excp_handler to tcg_ops

From: Eduardo Habkost Signed-off-by: Eduardo Habkost Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- include/hw/core/cpu.h | 2 -- include/hw/core/tcg-cpu-ops.h | 2 ++ accel/tcg/cpu-exec.c | 4 ++-- target/arm/cpu.c | 2 +- target/i386/tcg/tcg-cpu.c

[PATCH v11 09/25] i386: move cpu dump out of helper.c into cpu-dump.c

Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- target/i386/cpu.h | 1 + target/i386/cpu-dump.c | 537 target/i386/helper.c| 514 -- target/i386/meson.build | 1 + 4 files changed, 539 inserti

[PATCH v11 15/25] cpu: Introduce TCGCpuOperations struct

From: Eduardo Habkost The TCG-specific CPU methods will be moved to a separate struct, to make it easier to move accel-specific code outside generic CPU code in the future. Start by moving tcg_initialize(). The new CPUClass.tcg_opts field may eventually become a pointer, but keep it an embedded

[PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

From: Eduardo Habkost Signed-off-by: Eduardo Habkost [claudio: wrapped in CONFIG_TCG] Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- include/hw/core/cpu.h | 8 include/hw/core/tcg-cpu-ops.h | 12 accel/tcg/cpu-ex

[PATCH v11 19/25] cpu: Move cpu_exec_* to tcg_ops

From: Eduardo Habkost Signed-off-by: Eduardo Habkost [claudio: wrapped in CONFIG_TCG] Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- include/hw/core/cpu.h | 6 -- include/hw/core/tcg-cpu-ops.h | 6 ++ accel/tcg/cpu-exec.c

[PATCH v11 14/25] cpu: Remove unnecessary noop methods

From: Eduardo Habkost Signed-off-by: Eduardo Habkost Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- hw/core/cpu.c | 13 - 1 file changed, 13 deletions(-) diff --git a/hw/core/cpu.c b/hw/core/cpu.c index 576fa1d7ba..994a12cb35 100644 --- a/hw/core/cpu.c +++ b/hw/core/

[PATCH v11 16/25] target/riscv: remove CONFIG_TCG, as it is always TCG

for now only TCG is allowed as an accelerator for riscv, so remove the CONFIG_TCG use. Signed-off-by: Claudio Fontana Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index a52e0ce4

[PATCH v11 24/25] cpu: move cc->transaction_failed to tcg_ops

Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- include/hw/core/cpu.h | 18 +++--- include/hw/core/tcg-cpu-ops.h | 14 ++ hw/mips/jazz.c| 9 +++-- target/alpha/cpu.c| 2 +- target/arm/cpu.c | 4 ++-- targ

[PATCH v11 25/25] cpu: move do_unaligned_access to tcg_ops

make it consistently SOFTMMU-only. Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- include/hw/core/cpu.h | 17 +++-- include/hw/core/tcg-cpu-ops.h | 7 +++ target/alpha/cpu.c | 2 +- target/arm/cpu.c| 2 +- target/hppa/cpu.

[PATCH v11 23/25] cpu: move cc->do_interrupt to tcg_ops

Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- include/hw/core/cpu.h | 2 -- include/hw/core/tcg-cpu-ops.h | 3 +++ accel/tcg/cpu-exec.c| 4 ++-- target/alpha/cpu.c | 2 +- target/arm/cpu.c| 4 ++-- target/arm/cpu_tcg.c

[PATCH v11 22/25] target/arm: do not use cc->do_interrupt for KVM directly

cc->do_interrupt is in theory a TCG callback used in accel/tcg only, to prepare the emulated architecture to take an interrupt as defined in the hardware specifications, but in reality the _do_interrupt style of functions in targets are also occasionally reused by KVM to prepare the architecture s

Re: [PATCH v14 05/13] qapi: create BlockdevOptionsCor structure for COR driver

On 10.12.20 19:30, Vladimir Sementsov-Ogievskiy wrote: 10.12.2020 20:43, Max Reitz wrote: I don’t like this patch’s subject very much, because I find the implementation of the @bottom option to be more noteworthy than the addition of the QAPI structure. On 04.12.20 23:07, Vladimir Sementsov-

Re: [PATCH v11 00/25] i386 cleanup PART 1

Patchew URL: https://patchew.org/QEMU/20201211083143.14350-1-cfont...@suse.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201211083143.14350-1-cfont...@suse.de Subject: [PATCH v11 00/25] i386 cleanup PART 1 === T

[PULL 0/8] Ui 20201211 patches

The following changes since commit 2ecfc0657afa5d29a373271b342f704a1a3c6737: Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2020-12-10' into staging (2020-12-10 17:01:05 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-20201211-pull-re

[PULL 8/8] sdl2: Add extra mouse buttons

From: Darrell Walisser Allows guest to receive mouse buttons 4 and 5, aka "SIDE" button and "EXTRA" button Signed-off-by: Darrell Walisser Message-id: GNUALCfDBqhCUvLwBNJaKqxcPewMtlqCnixk8xTrgI@ubuntu Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 2 ++ 1 file changed, 2 insertions(+) diff --g

[PULL 6/8] vnc: add alpha cursor support

There is a new vnc extension for cursors with an alpha channel. Use it if supported by the vnc client, prefer it over the "rich cursor" extension which supports only a bitmask for transparency. This is a visible improvement especially on modern desktops which actually use the alpha channel when d

[PULL 2/8] console: allow con==NULL in dpy_{get, set}_ui_info and dpy_ui_info_supported

Use active_console in that case like we do in many other places. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Message-id: 20201208115737.18581-3-kra...@redhat.com --- ui/console.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/ui/console.c b/ui

[PULL 3/8] vnc: use enum for features

Use an enum for the vnc feature bits. That way they are enumerated automatically and we don't have to do that manually when adding or removing features. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20201208115737.18581-4-kra...@redhat.com --- ui/vnc.h | 26 ++

[PULL 7/8] ui/vnc: Add missing lock for send_color_map

From: Peng Liang vnc_write() should be locked after the RFB protocol is initialized. Fixes: 0c426e4534b4 ("vnc: Add support for color map") Cc: qemu-sta...@nongnu.org Reported-by: Euler Robot Signed-off-by: Peng Liang Message-id: 20201116141338.148911-1-liangpen...@huawei.com Signed-off-by: Ge

[PULL 4/8] vnc: drop unused copyrect feature

vnc stopped using the copyrect pseudo encoding in 2017, in commit 50628d3479e4 ("cirrus/vnc: zap bitblit support from console code.") So we can drop the now unused copyrect feature bit. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-id: 20201

[PULL 5/8] vnc: add pseudo encodings

Add #defines for two new pseudo encodings: * cursor with alpha channel. * extended desktop resize. https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#pseudo-encodings Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-id: 2020120811

[PULL 1/8] console: drop qemu_console_get_ui_info

Unused and duplicate (there is dpy_get_ui_info). Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-id: 20201208115737.18581-2-kra...@redhat.com --- include/ui/console.h | 1 - ui/console.c | 6 -- 2 files changed, 7 deletions(-) di

[PATCH v2 1/3] net: checksum: Skip fragmented IP packets

From: Markus Carlstedt To calculate the TCP/UDP checksum we need the whole datagram. Unless the hardware has some logic to collect all fragments before sending the whole datagram first, it can only be done by the network stack, which is normally the case for the NICs we have seen so far. Skip th

[PATCH v2 2/3] net: checksum: Add IP header checksum calculation

From: Guishan Qin At present net_checksum_calculate() only calculates TCP/UDP checksum in an IP packet, but assumes the IP header checksum to be provided by the software, e.g.: Linux kernel always calculates the IP header checksum. However this might not always be the case, e.g.: for an IP checks

[PATCH v2 3/3] net: checksum: Introduce fine control over checksum type

From: Bin Meng At present net_checksum_calculate() blindly calculates all types of checksums (IP, TCP, UDP). Some NICs may have a per type setting in their BDs to control what checksum should be offloaded. To support such hardware behavior, introduce a 'csum_flag' parameter to the net_checksum_ca

Re: RFC: don't store backing filename in qcow2 image

On Thu, Dec 10, 2020 at 17:26:52 +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! Hi, > > I have an idea, that not storing backing filename in qcow2 image at all may > be a good thing. I'll give some reasons and want to know what do you think > about it. > > 1. Libvirt has to manage and k

Re: [PATCH v2 4/8] configure: add --without-default-features

Thomas Huth writes: > On 10/12/2020 20.04, Alex Bennée wrote: >> By default QEMU enables a lot of features if it can probe and find the >> support libraries. It also enables a bunch of features by default. >> This patch adds the ability to build --without-default-features which >> can be paired

[PATCH v11 0/7] i386 cleanup PART 2

Hello, this is version 11 of the cleanup, PART 2. The series has been split into two separate parts; to find PART 1, see the series "i386 cleanup PART 1" v10 -> v11: split off PART 2, no further changes to PART 2 other than the split. v9 -> v10: minor tweaks and fixes * in "i386: split cpu acc

[PATCH v11 2/7] accel: replace struct CpusAccel with AccelOpsClass

also centralize the registration of the cpus.c module accelerator operations in accel/accel-softmmu.c Consequently, rename all tcg-cpus.c, kvm-cpus.c etc to tcg-accel-ops.c, kvm-accel-ops.c etc, also matching the object type names. Signed-off-by: Claudio Fontana --- accel/accel-softmmu.h

[PATCH v11 1/7] accel: extend AccelState and AccelClass to user-mode

Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée --- include/hw/boards.h| 2 +- include/{sysemu => qemu}/accel.h | 14 + include/sysemu/hvf.h | 2 +- include/sysemu/kvm.h | 2 +- include/sysemu/kvm_int.h | 2 +- target/i3

[PATCH v11 3/7] accel: introduce AccelCPUClass extending CPUClass

add a new optional interface to CPUClass, which allows accelerators to extend the CPUClass with additional accelerator-specific initializations. Signed-off-by: Claudio Fontana --- include/hw/core/accel-cpu.h | 25 + include/hw/core/cpu.h | 13 +++ accel/accel-co

[PATCH v11 5/7] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn

move the call to the accel_cpu_interface method to the general cpu_exec_realizefn from target/i386, so it does not need to be called for every target explicitly as we enable more targets. Signed-off-by: Claudio Fontana --- cpu.c | 5 + target/i386/cpu.c | 15 --- 2 f

[PATCH v11 4/7] i386: split cpu accelerators from cpu.c, using AccelCPUClass

i386 is the first user of AccelCPUClass, allowing to split cpu.c into: cpu.ccpuid and common x86 cpu functionality host-cpu.c host x86 cpu functions and "host" cpu type kvm/kvm-cpu.cKVM x86 AccelCPUClass hvf/hvf-cpu.cHVF x86 AccelCPUClass tcg/tcg-cpu.cTCG x86 AccelCPU

[PATCH v11 6/7] hw/core/cpu: call qemu_init_vcpu in cpu_common_realizefn

move the call to qemu_init_vcpu inside cpu_common_realizefn, so it does not need to be done explicitly in each target cpu. This makes it a little bit better, but still the way realize is done continues to be bad; ideally the cpu_list_add would be done in common_cpu, and in this case we could avoid

[PATCH v11 7/7] cpu: introduce cpu_accel_instance_init

centralize the calls to cpu->accel_cpu_interface Signed-off-by: Claudio Fontana --- include/hw/core/cpu.h | 6 ++ hw/core/cpu.c | 9 + target/i386/cpu.c | 9 ++--- 3 files changed, 17 insertions(+), 7 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/

Re: [PATCH] virtiofsd: Fix potential NULL pointer dereference in virtio_send_msg()

Hi Dave, On 2020/12/11 2:00, Dr. David Alan Gilbert wrote: > * Alex Chen (alex.c...@huawei.com) wrote: >> The 'ch' will be NULL in the following stack: >> send_notify_iov()->fuse_send_msg()->virtio_send_msg(), >> so we should check 'ch' is valid before dereferencing it >> >> Reported-by: Euler Rob

Re: [PATCH] configure: replace --enable/disable-git-update with --with-git-submodules

On Wed, Dec 09, 2020 at 09:38:51AM -0500, Dan Streetman wrote: > Hi, just a ping to try to keep this alive, does the patch look ok? I > can rebase it on the latest git if so (and if needed) Yes, I meant to ask for a rebase. The impl broadly looks fine to me. > > On Fri, Oct 16, 2020 at 4:39 PM D

[PATCH v2] s390x: pv: Fence additional unavailable SCLP facilities for PV guests

There's no VSIE support for a protected guest, so let's better not advertise it and its support facilities. Signed-off-by: Janosch Frank --- v2: added hpma2 --- target/s390x/cpu_features.c | 39 - target/s390x/cpu_models.c | 25 ++-- 2 fi

Re: [PATCH v5 6/7] tcg: implement JIT for iOS and Apple Silicon

On 25.11.20 03:08, Joelle van Dyne wrote: A lot of users of UTM are on iOS 13 (a large number of devices only have jailbreak for iOS 13 and below), but if the QEMU community thinks it's better that way, we are willing to compromise. I think it would make merging much more straight forward if

Re: [PATCH v11 24/25] cpu: move cc->transaction_failed to tcg_ops

On 12/11/20 9:31 AM, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > Reviewed-by: Alex Bennée > --- > include/hw/core/cpu.h | 18 +++--- > include/hw/core/tcg-cpu-ops.h | 14 ++ > hw/mips/jazz.c| 9 +++-- > target/alpha/cpu.c

Re: [PATCH v11 25/25] cpu: move do_unaligned_access to tcg_ops

On 12/11/20 9:31 AM, Claudio Fontana wrote: > make it consistently SOFTMMU-only. > > Signed-off-by: Claudio Fontana > Reviewed-by: Alex Bennée > --- > include/hw/core/cpu.h | 17 +++-- > include/hw/core/tcg-cpu-ops.h | 7 +++ > target/alpha/cpu.c | 2 +

Re: [PATCH v11 14/25] cpu: Remove unnecessary noop methods

On 12/11/20 9:31 AM, Claudio Fontana wrote: > From: Eduardo Habkost > Either add: "In the previous commits we made cpu_exec_* and debug_excp_handler handlers optional, we can now remove these no-op handlers." Or squash in each commit... Anyhow: Reviewed-by: Philippe Mathieu-Daudé > Signed

Re: ceph + freeipa ubuntu/fedora common small bug

* Harry G. Coin (hgc...@gmail.com) wrote: > FYI.  Same thing we saw on Fedora installing freeipa, this on ubuntu > with ceph.  Identical bitmask report. > > ... > > Fixing /var/run/ceph ownershipdone > > Cannot set file attribute for '/var/log/journal', value=0x0080, > mask=0x0080,

Re: [PATCH v11 00/25] i386 cleanup PART 1

On 12/11/20 9:31 AM, Claudio Fontana wrote: > Hello, this is version 11 of the cleanup. > > The series has been split into two separate parts, > and this is PART 1. One single patch misses review: #10 "i386: move TCG cpu class initialization out of helper.c" > > v10 -> v11: small tweaks for !C

Re: [PATCH v2] s390x: pv: Fence additional unavailable SCLP facilities for PV guests

On 11.12.20 11:51, Janosch Frank wrote: > There's no VSIE support for a protected guest, so let's better not > advertise it and its support facilities. > > Signed-off-by: Janosch Frank Reviewed-by: Christian Borntraeger shall we add Fixes: 0f73c5b30b8b ("s390x: protvirt: SCLP interpretatio

Re: [PATCH V17 4/6] hw/mips: Add Loongson-3 boot parameter helpers

On 12/11/20 3:46 AM, Huacai Chen wrote: > Hi, Rechard and Peter, > > On Wed, Dec 2, 2020 at 5:32 PM Philippe Mathieu-Daudé wrote: >> >> On 12/2/20 2:14 AM, Huacai Chen wrote: >>> Hi, Phillippe, >>> >>> On Tue, Nov 24, 2020 at 6:25 AM Philippe Mathieu-Daudé >>> wrote: On 11/6/20 5:21 A

Re: [PATCH] ide:atapi: check io_buffer_index in ide_atapi_cmd_reply_end

On 11/12/20 09:23, Wenxiang Qian wrote: Hello, I may not have made the detail clear in my previous email. The details of the AHCI device, after running the reproducer I attached in my report are as follows. If there is any information I can provide, please let me know. Thank you. ###root ca

Re: [PATCH] ide:atapi: check io_buffer_index in ide_atapi_cmd_reply_end

On 11/12/20 09:32, Wenxiang Qian wrote: + The lba is set to -1 to avoid some code paths, to make PoC simpler. void ide_atapi_cmd_reply_end(IDEState *s) {     int byte_count_limit, size, ret;     while (s->packet_transfer_size > 0) { .         if (s->lba != -1 && s->io_buffer_index >= s->c

Re: [PATCH v2] s390x: pv: Fence additional unavailable SCLP facilities for PV guests

On 12/11/20 12:28 PM, Christian Borntraeger wrote: > > > On 11.12.20 11:51, Janosch Frank wrote: >> There's no VSIE support for a protected guest, so let's better not >> advertise it and its support facilities. >> >> Signed-off-by: Janosch Frank > > Reviewed-by: Christian Borntraeger > > shal

Re: [PATCH v2 3/3] net: checksum: Introduce fine control over checksum type

On 12/11/20 10:35 AM, Bin Meng wrote: > From: Bin Meng > > At present net_checksum_calculate() blindly calculates all types of > checksums (IP, TCP, UDP). Some NICs may have a per type setting in > their BDs to control what checksum should be offloaded. To support > such hardware behavior, introd

[PULL 0/6] s390x update

The following changes since commit 2ecfc0657afa5d29a373271b342f704a1a3c6737: Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2020-12-10' into staging (2020-12-10 17:01:05 +) are available in the Git repository at: https://github.com/cohuck/qemu tags/s390x-2020121

[PULL 1/6] hw/watchdog/wdt_diag288: Remove unnecessary includes

From: Thomas Huth Neither sysbus.h nor module.h are required to compile this file. diag288 is not a sysbus device, and module.h (for type_init) is included eventually through qom/object.h. Signed-off-by: Thomas Huth Reviewed-by: Christian Borntraeger Message-Id: <20201118090344.243117-1-th...@

[PULL 4/6] tests/acceptance: verify s390x device detection

The kernel/initrd combination does not provide the virtio-net driver; therefore, simply check whether the presented device type is indeed virtio-net for the two virtio-net-{ccw,pci} devices. Signed-off-by: Cornelia Huck [re-formatted overlong lines] Reviewed-by: Thomas Huth Reviewed-by: Wainer d

[PULL 2/6] tests/acceptance: add a test for devices on s390x

This adds a very basic test for checking that we present devices in a way that Linux can consume: boot with both virtio-net-ccw and virtio-net-pci attached and then verify that Linux is able to see and detect these devices. Signed-off-by: Cornelia Huck Reviewed-by: Thomas Huth Reviewed-by: Waine

[PULL 3/6] tests/acceptance: test virtio-ccw revision handling

The max_revision prop of virtio-ccw devices can be used to force an older revision for compatibility handling. The easiest way to check this is to force a device to revision 0, which turns off virtio-1. Signed-off-by: Cornelia Huck [re-formatted overlong lines] Reviewed-by: Thomas Huth Reviewed-

[PULL 001/113] target/i386: fix operand order for PDEP and PEXT

For PDEP and PEXT, the mask is provided in the memory (mod+r/m) operand, and therefore is loaded in s->T0 by gen_ldst_modrm. The source is provided in the second source operand (VEX.) and therefore is loaded in s->T1. Fix the order in which they are passed to the helpers. Reported-by: Lenard

[PULL v2 000/113] First batch of misc (i386, kernel-doc, memory, vl.c) changes for QEMU 6.0

The following changes since commit 379e9eaed497a2e09b5985e1e15967d7bfea8296: Merge remote-tracking branch 'remotes/legoater/tags/pull-aspeed-20201210' into staging (2020-12-10 14:26:35 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for

[PULL 5/6] tests/acceptance: test s390x zpci fid propagation

Verify that a fid specified on the command line shows up correctly as the function_id in the guest. Signed-off-by: Cornelia Huck [re-formatted overlong lines] Reviewed-by: Thomas Huth Reviewed-by: Wainer dos Santos Moschetta Message-Id: <20201130180216.15366-4-coh...@redhat.com> --- tests/acce

[PULL 6/6] s390x/cpu: Use timer_free() in the finalize function to avoid memleaks

From: Gan Qixin When running device-introspect-test, a memory leak occurred in the s390_cpu_initfn function, this patch use timer_free() in the finalize function to fix it. ASAN shows memory leak stack: Direct leak of 3552 byte(s) in 74 object(s) allocated from: #0 0xfffeb3d4e1f0 in __inte

Re: [PULL 00/30] ppc-for-6.0 queue 20201211

ble in the Git repository at: > > https://gitlab.com/dgibson/qemu.git tags/ppc-for-6.0-20201211 > > for you to fetch changes up to 7728c7ef126468a3e982b03b427196b1cccfa2c8: > > spapr.c: set a 'kvm-type' default value

Re: [PATCH v5 6/7] tcg: implement JIT for iOS and Apple Silicon

On Fri, Dec 11, 2020 at 10:54 AM Alexander Graf wrote: > On 25.11.20 03:08, Joelle van Dyne wrote: > > A lot of users of UTM are on iOS 13 (a large number of devices only > > have jailbreak for iOS 13 and below), but if the QEMU community thinks > > it's better that way, we are willing to compromi

Re: [PATCH v14 05/13] qapi: create BlockdevOptionsCor structure for COR driver

11.12.2020 11:54, Max Reitz wrote: On 10.12.20 19:30, Vladimir Sementsov-Ogievskiy wrote: 10.12.2020 20:43, Max Reitz wrote: I don’t like this patch’s subject very much, because I find the implementation of the @bottom option to be more noteworthy than the addition of the QAPI structure. On

Re: RFC: don't store backing filename in qcow2 image

11.12.2020 12:44, Peter Krempa wrote: On Thu, Dec 10, 2020 at 17:26:52 +0300, Vladimir Sementsov-Ogievskiy wrote: Hi all! Hi, I have an idea, that not storing backing filename in qcow2 image at all may be a good thing. I'll give some reasons and want to know what do you think about it. 1

Re: [PULL 00/30] ppc-for-6.0 queue 20201211

On Fri, 11 Dec 2020 at 12:35, Philippe Mathieu-Daudé wrote: > > On 12/11/20 5:14 AM, David Gibson wrote: > > LemonBoy (5): > > ppc/translate: Fix unordered f64/f128 comparisons > > ppc/translate: Turn the helper macros into functions > > ppc/translate: Delay NaN checking after co

Re: [PATCH v14 06/13] iotests: add #310 to test bottom node in COR driver

On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich The test case #310 is similar to #216 by Max Reitz. The difference is that the test #310 involves a bottom node to the COR filter driver. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy

Re: [PATCH v2] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD

On 10/12/2020 10.32, AL Yu-Chen Cho wrote: > Hi Thomas, > > I try to reproduce this failed in my repo, but it seems works fine. > Would you please give it a try again? I think you maybe just hit a bad > point in time... I just re-tried, but it still fails for me: https://gitlab.com/huth/qemu/-/

Re: [PATCH v14 06/13] iotests: add #310 to test bottom node in COR driver

11.12.2020 15:49, Max Reitz wrote: On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich The test case #310 is similar to #216 by Max Reitz. The difference is that the test #310 involves a bottom node to the COR filter driver. Signed-off-by: Andrey Shinkevich Reviewe

[RFC PATCH v4] compiler.h: remove GCC < 3 __builtin_expect fallback

Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >= 4.8. (clang >= 3.4 advertizes itself as GCC >= 4.2 compatible and supports __builtin_expect too) Signed-off-by: Marc-André Lureau [PMD: #error if likely/unlikely already defined] S

Re: [PATCH v14 07/13] block: include supported_read_flags into BDS structure

On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich Add the new member supported_read_flags to the BlockDriverState structure. It will control the flags set for copy-on-read operations. Make the block generic layer evaluate supported read flags before they go to a blo

Re: [PATCH v14 06/13] iotests: add #310 to test bottom node in COR driver

On 11.12.20 14:10, Vladimir Sementsov-Ogievskiy wrote: 11.12.2020 15:49, Max Reitz wrote: On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich The test case #310 is similar to #216 by Max Reitz. The difference is that the test #310 involves a bottom node to the COR f

Re: [PATCH v6 0/4] migration: UFFD write-tracking migration/snapshots

On 09.12.2020 13:08, Andrey Gruzdev wrote: This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas he's implemented in his series '[PATCH v0 0/4] migration: add background snapshot'. Currently the only way to make (external) live VM snapshot is using existing dirty page logging mi

Re: [RFC PATCH v4] compiler.h: remove GCC < 3 __builtin_expect fallback

On 12/11/20 2:13 PM, Philippe Mathieu-Daudé wrote: > Since commit efc6c07 ("configure: Add a test for the minimum compiler > version"), QEMU explicitely depends on GCC >= 4.8. > > (clang >= 3.4 advertizes itself as GCC >= 4.2 compatible and supports > __builtin_expect too) > > Signed-off-by: Marc

Re: [PATCH v14 07/13] block: include supported_read_flags into BDS structure

11.12.2020 16:20, Max Reitz wrote: On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich Add the new member supported_read_flags to the BlockDriverState structure. It will control the flags set for copy-on-read operations. Make the block generic layer evaluate supporte

Re: [RFC PATCH v4] compiler.h: remove GCC < 3 __builtin_expect fallback

On Fri, 11 Dec 2020 at 13:13, Philippe Mathieu-Daudé wrote: > > Since commit efc6c07 ("configure: Add a test for the minimum compiler > version"), QEMU explicitely depends on GCC >= 4.8. > > (clang >= 3.4 advertizes itself as GCC >= 4.2 compatible and supports > __builtin_expect too) > > Signed-of

Re: [RFC PATCH v4] compiler.h: remove GCC < 3 __builtin_expect fallback

On 12/11/20 2:28 PM, Claudio Fontana wrote: > On 12/11/20 2:13 PM, Philippe Mathieu-Daudé wrote: >> Since commit efc6c07 ("configure: Add a test for the minimum compiler >> version"), QEMU explicitely depends on GCC >= 4.8. >> >> (clang >= 3.4 advertizes itself as GCC >= 4.2 compatible and supports

Re: [PATCH] target/i386/sev: add the support to query the attestation report

On 12/10/20 10:13 AM, James Bottomley wrote: > On Fri, 2020-12-04 at 15:31 -0600, Brijesh Singh wrote: >> The SEV FW >= 0.23 added a new command that can be used to query the >> attestation report containing the SHA-256 digest of the guest memory >> and VMSA encrypted with the LAUNCH_UPDATE and s

Re: [RFC PATCH v4] compiler.h: remove GCC < 3 __builtin_expect fallback

On 12/11/20 2:33 PM, Peter Maydell wrote: > On Fri, 11 Dec 2020 at 13:13, Philippe Mathieu-Daudé > wrote: >> >> Since commit efc6c07 ("configure: Add a test for the minimum compiler >> version"), QEMU explicitely depends on GCC >= 4.8. >> >> (clang >= 3.4 advertizes itself as GCC >= 4.2 compatibl

Re: [PULL 0/3] Machine and x86 queue, 2020-12-10

On Thu, 10 Dec 2020 at 22:42, Eduardo Habkost wrote: > > The following changes since commit 2ecfc0657afa5d29a373271b342f704a1a3c6737: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2020-12-10' > into staging (2020-12-10 17:01:05 +) > > are available in the Git repository at

Re: [PATCH 0/4] clock: Get rid of clock_get_ns()

On 12/8/20 7:15 PM, Peter Maydell wrote: > This patchseries makes some changes to the clock API: > * Remove clock_get_ns() > * Add clock_ticks_to_ns() to return number of nanoseconds >it will take the clock to tick N times > * clock_display_freq() to return prettily-formatted string >for

Re: [PATCH] ide:atapi: check io_buffer_index in ide_atapi_cmd_reply_end

+ The lba is set to -1 to avoid some code paths, to make PoC simpler. void ide_atapi_cmd_reply_end(IDEState *s) { int byte_count_limit, size, ret; while (s->packet_transfer_size > 0) { . if (s->lba != -1 && s->io_buffer_index >= s->cd_sector_size) { <- set lba to -1 to avoi

Re: [PATCH] ide:atapi: check io_buffer_index in ide_atapi_cmd_reply_end

Hello, I may not have made the detail clear in my previous email. The details of the AHCI device, after running the reproducer I attached in my report are as follows. If there is any information I can provide, please let me know. Thank you. ###root cause### (1) The s->packet_transfer_size is bigg

Re: [PATCH 0/3] target/openrisc: Move pic_cpu code into CPU object

On Fri, 27 Nov 2020 at 22:51, Peter Maydell wrote: > > The openrisc code uses an old style of interrupt handling, where a > separate standalone set of qemu_irqs invoke a function > openrisc_pic_cpu_handler() which signals the interrupt to the CPU > proper by directly calling cpu_interrupt() and cp

[Bug 1907817] [NEW] qemu-aarch64 tcg assertion v5.2.0

Public bug reported: After updating to 5.2 I am getting following assertion error: qemu-aarch64: ../tcg/tcg-op-gvec.c:54: check_size_align: Assertion `(maxsz & max_align) == 0' failed. I think it was introduced by commit: e2e7168a214b0ed98dc357bba96816486a289762 Becasue before this change, in f

  1   2   3   4   5   >