Re: [PULL v2 48/65] libvhost-user: make it a meson subproject

2020-12-10 Thread Peter Maydell
On Thu, 10 Dec 2020 at 16:17, Paolo Bonzini wrote: > > On Thu, Dec 10, 2020 at 5:11 PM Peter Maydell > wrote: > > Looking at the commit, it's not clear to me why the > > vhost-user changes have resulted in all binaries getting > > a change to their link line. Paolo ? > > Because libvhost-user/me

Re: [PATCH] target/i386/sev: add the support to query the attestation report

2020-12-10 Thread James Bottomley
On Fri, 2020-12-04 at 15:31 -0600, Brijesh Singh wrote: > The SEV FW >= 0.23 added a new command that can be used to query the > attestation report containing the SHA-256 digest of the guest memory > and VMSA encrypted with the LAUNCH_UPDATE and sign it with the PEK. > > Note, we already have a co

[PULL 02/13] qerror: Drop unused QERR_ macros

2020-12-10 Thread Markus Armbruster
QERR_INVALID_BLOCK_FORMAT is dead since commit e6641719fe "block: Always pass NULL as drv for bdrv_open()", 2015-09-14. QERR_INVALID_PASSWORD is dead since commit c01c214b69 "block: remove all encryption handling APIs", 2017-07-11. Bury them. Signed-off-by: Markus Armbruster Message-Id: <202011

[PULL 08/13] qga: Replace an unreachable error by abort()

2020-12-10 Thread Markus Armbruster
check_suspend_mode()'s error message Parameter 'mode' expects GuestSuspendMode makes no sense to users: GuestSuspendMode is a C enum. Fortunately, it is unreachable. Replace it by abort(). Cc: Michael Roth Signed-off-by: Markus Armbruster Message-Id: <20201113082626.2725812-8-arm...@redh

[PULL 06/13] ui: Improve a client_migrate_info error message

2020-12-10 Thread Markus Armbruster
client_migrate_info reports spice_server_migrate_connect() failure as "An undefined error has occurred". Improve to "Could not set up display for migration". QERR_UNDEFINED_ERROR is now unused. Drop. Cc: Gerd Hoffmann Signed-off-by: Markus Armbruster Message-Id: <20201113082626.2725812-6-arm.

[PULL 00/13] Miscellaneous patches for 2020-12-10

2020-12-10 Thread Markus Armbruster
The following changes since commit 00ef48ff0de9c3e5834e7e3f6691bbc80d08c114: Merge remote-tracking branch 'remotes/kraxel/tags/microvm-20201210-pull-request' into staging (2020-12-10 12:53:01 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags

[PULL 07/13] ui: Tweak a client_migrate_info error message

2020-12-10 Thread Markus Armbruster
Change Parameter 'protocol' expects spice to Parameter 'protocol' expects 'spice' for consistency with similar error messages elsewhere. Cc: Gerd Hoffmann Signed-off-by: Markus Armbruster Message-Id: <20201113082626.2725812-7-arm...@redhat.com> --- monitor/misc.c | 2 +- 1 file chan

[PULL 12/13] qapi: Normalize version references x.y.0 to just x.y

2020-12-10 Thread Markus Armbruster
We use x.y most of the time, and x.y.0 sometimes. Normalize for consistency. Reported-by: Eduardo Habkost Signed-off-by: Markus Armbruster Message-Id: <20201118064158.3359056-1-arm...@redhat.com> Reviewed-by: Eric Blake --- qapi/block-core.json | 28 qapi/block-ex

[PULL 03/13] qerror: Eliminate QERR_ macros used in just one place

2020-12-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20201113082626.2725812-3-arm...@redhat.com> --- include/qapi/qmp/qerror.h | 9 - monitor/misc.c| 8 net/net.c | 2 +- 3 files changed, 5 insertions(+), 14 deletions(-) diff --git a/include/qapi/qmp/qerror.

[PULL 13/13] docs/devel/writing-qmp-commands.txt: Fix docs

2020-12-10 Thread Markus Armbruster
From: Zihao Chang Fix the example of add qmp hello-world example. Without ":", make will report error: ../qapi/misc.json:573:2: line should end with ':' Signed-off-by: Zihao Chang Message-Id: <20201201143308.1626-1-changzih...@huawei.com> Reviewed-by: Eric Blake Signed-off-by: Markus Armbruste

[PULL 05/13] ui: Improve some set_passwd, expire_password error messages

2020-12-10 Thread Markus Armbruster
set_passwd and expire_password reject invalid "protocol" with "Invalid parameter 'protocol'". Misleading; the parameter is valid, its value isn't. Improve to "Parameter 'protocol' expects 'vnc' or 'spice'". expire_password fails with "Could not set password". Misleading; improve to "Could not s

[PULL 10/13] qom: Improve {qom, device}-list-properties error messages

2020-12-10 Thread Markus Armbruster
device-list-properties reports Parameter 'typename' expects device when @typename exists, but isn't a TYPE_DEVICE. Improve this to Parameter 'typename' expects a non-abstract device type qom-list-properties reports Parameter 'typename' expects object when @typename exists, but is

[PULL 09/13] qga: Tweak a guest-shutdown error message

2020-12-10 Thread Markus Armbruster
Change Parameter 'mode' expects halt|powerdown|reboot to Parameter 'mode' expects 'halt', 'powerdown', or 'reboot' for consistency with similar error messages elsewhere. Cc: Michael Roth Signed-off-by: Markus Armbruster Message-Id: <20201113082626.2725812-9-arm...@redhat.com> --- qg

[PULL 11/13] Tweak a few "Parameter 'NAME' expects THING" error message

2020-12-10 Thread Markus Armbruster
Change to "expects a THING" where that's an obvious improvement Signed-off-by: Markus Armbruster Message-Id: <20201113082626.2725812-11-arm...@redhat.com> --- block/quorum.c | 2 +- blockdev.c | 2 +- chardev/char.c | 2 +- hw/core/qdev-p

[PATCH v3] file-posix: detect the lock using the real file

2020-12-10 Thread Li Feng
This patch addresses this issue: When accessing a volume on an NFS filesystem without supporting the file lock, tools, like qemu-img, will complain "Failed to lock byte 100". Add a new function 'qemu_has_file_lock' to detect if the filesystem supports locks or not. And when the drive is auto mode

Re: [PATCH v3 0/1] spapr.c: set a 'kvm-type' default value instead of relying on NULL

2020-12-10 Thread Paolo Bonzini
On 10/12/20 15:55, Daniel Henrique Barboza wrote: changes from v2, all proposed by Greg: * Handle 'NULL' value as default mode fallback in spapr_kvm_type() * Do not allow for 'AUTO' to be a valid mode in spapr_kvm_type() * Initialize 'spapr->kvm_type' in spapr_instance_init() like Paolo propos

Re: [RFC PATCH] hw/misc/zynq_slcr: Avoid #DIV/0! error

2020-12-10 Thread Alistair Francis
On Thu, Dec 10, 2020 at 6:27 AM Philippe Mathieu-Daudé wrote: > > Malicious user can set the feedback divisor for the PLLs > to zero, triggering a floating-point exception (SIGFPE). > > As the datasheet [*] is not clear how hardware behaves > when these bits are zeroes, use the maximum divisor > p

Re: [PATCH v3] file-posix: detect the lock using the real file

2020-12-10 Thread Daniel P . Berrangé
On Fri, Dec 11, 2020 at 12:38:19AM +0800, Li Feng wrote: > This patch addresses this issue: > When accessing a volume on an NFS filesystem without supporting the file lock, > tools, like qemu-img, will complain "Failed to lock byte 100". > > Add a new function 'qemu_has_file_lock' to detect if the

Re: [PATCH v2 0/3] nvdimm: read-only file support

2020-12-10 Thread Liam Merwick
On 16/09/2020 10:51, Stefan Hajnoczi wrote: v2: * s/the the/the/ in documentation [Philippe] * Assign nvdimm->unarmed earlier [Philippe] There is currently no way to back an NVDIMM with a read-only file so it can be safely shared between untrusted guests. Introduce an -object memory-backend

Re: [PATCH 0/4] Remove deprecated CLI parameters

2020-12-10 Thread Paolo Bonzini
On 10/12/20 16:58, Thomas Huth wrote: Remove some simple CLI parameters that have been deprecated since at least two releass already. Philippe Mathieu-Daudé (1): accel/tcg: Remove deprecated '-tb-size' option Thomas Huth (3): docs/system: Move the list of removed features to a separate fi

Re: [PATCH v12 16/19] multi-process: Synchronize remote memory

2020-12-10 Thread Jag Raman
> On Dec 9, 2020, at 4:28 PM, Marc-André Lureau > wrote: > > > > On Wed, Dec 9, 2020 at 8:20 PM Jag Raman wrote: > > > > On Dec 8, 2020, at 8:57 AM, Marc-André Lureau > > wrote: > > > > Hi > > > > On Wed, Dec 2, 2020 at 12:23 AM Jagannathan Raman > > wrote: > > Add memory-listener

Re: [PULL v2 000/113] First batch of misc (i386, kernel-doc, memory, vl.c) changes for QEMU 6.0

2020-12-10 Thread Peter Maydell
On Thu, 10 Dec 2020 at 13:37, Paolo Bonzini wrote: > > The following changes since commit 5e7b204dbfae9a562fc73684986f936b97f63877: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2020-12-09 20:08:54 +) > > are available in the Git repository at: > > https

[PATCH] hw/virtio-pci: Replace error_report() by qemu_log_mask(GUEST_ERROR)

2020-12-10 Thread Philippe Mathieu-Daudé
Replace I/O write error reported with error_report() by qemu_log_mask(GUEST_ERROR) which allow filtering. Signed-off-by: Philippe Mathieu-Daudé --- hw/virtio/virtio-pci.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c ind

[PATCH v2] accel/tcg: Remove deprecated '-tb-size' option

2020-12-10 Thread Philippe Mathieu-Daudé
The '-tb-size' option (replaced by '-accel tcg,tb-size') is deprecated since 5.0 (commit fe174132478). Remove it. Reviewed-by: Thomas Huth Reviewed-by: Ján Tomko Signed-off-by: Philippe Mathieu-Daudé --- v2: fixed "Title underline too short." (Thomas) --- docs/system/deprecated.rst | 12 +-

Re: [RFC PATCH] hw/misc/zynq_slcr: Avoid #DIV/0! error

2020-12-10 Thread Mauro Matteo Cascella
On Thu, Dec 10, 2020 at 3:16 PM Philippe Mathieu-Daudé wrote: > > Malicious user can set the feedback divisor for the PLLs > to zero, triggering a floating-point exception (SIGFPE). > > As the datasheet [*] is not clear how hardware behaves > when these bits are zeroes, use the maximum divisor > p

Re: [PATCH v14 02/13] block: add API function to insert a node

2020-12-10 Thread Max Reitz
On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich Provide API for insertion a node to backing chain. Suggested-by: Max Reitz Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 2 ++ block.c |

Re: [PATCH v14 03/13] copy-on-read: add filter drop function

2020-12-10 Thread Max Reitz
On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich Provide API for the COR-filter removal. Also, drop the filter child permissions for an inactive state when the filter node is being removed. To insert the filter, the block generic layer function bdrv_insert_node() c

Re: [PATCH v14 05/13] qapi: create BlockdevOptionsCor structure for COR driver

2020-12-10 Thread Max Reitz
I don’t like this patch’s subject very much, because I find the implementation of the @bottom option to be more noteworthy than the addition of the QAPI structure. On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich Create the BlockdevOptionsCor structure for COR

Re: [PATCH v14 04/13] qapi: add filter-node-name to block-stream

2020-12-10 Thread Max Reitz
On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- qap

Re: [PATCH 1/6] migration: Fix and clean up around @tls-authz

2020-12-10 Thread Dr. David Alan Gilbert
Dan: Can you please see if this makes sense to you, it did to me at the time. Dave * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > Commit d2f1d29b95 "migration: add support for a "tls-authz" migration > > parameter" added MigrationParamet

Re: [PATCH v2 1/1] security-process: update process information

2020-12-10 Thread Michael Roth
Quoting P J P (2020-12-03 08:29:02) > From: Prasad J Pandit > > We are about to introduce a qemu-security mailing list to report > and triage QEMU security issues. > > Update the security process web page with new mailing list address > and triage details. > > Signed-off-by: Prasad J Pandit >

[RFC PATCH] virtio: Only display errors if GUEST_ERROR is enabled

2020-12-10 Thread Philippe Mathieu-Daudé
Do not display virtio guest errors until the user request it. Signed-off-by: Philippe Mathieu-Daudé --- hw/virtio/virtio.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index eff35fab7ce..bde0d31c5d9 100644 --- a/hw/virtio/vir

Re: [PATCH] virtiofsd: Fix potential NULL pointer dereference in virtio_send_msg()

2020-12-10 Thread Dr. David Alan Gilbert
* Alex Chen (alex.c...@huawei.com) wrote: > The 'ch' will be NULL in the following stack: > send_notify_iov()->fuse_send_msg()->virtio_send_msg(), > so we should check 'ch' is valid before dereferencing it > > Reported-by: Euler Robot > Signed-off-by: Alex Chen Please check, but I don't think w

Re: [PATCH v2 3/4] qmp: Allow setting -action parameters on the fly

2020-12-10 Thread Paolo Bonzini
On 10/12/20 04:21, Alejandro Jimenez wrote: I misunderstood your request in v1. Oh ypu're right, in v1 you had multiple commands. My fault then. { 'command': 'set-action', 'data' : {     '*reboot': 'RebootAction',     '*shutdown': 'ShutdownAction',     '*panic': 'PanicAction',     '*wat

Re: [RFC PATCH] virtio: Only display errors if GUEST_ERROR is enabled

2020-12-10 Thread Philippe Mathieu-Daudé
On 12/10/20 6:59 PM, Philippe Mathieu-Daudé wrote: > Do not display virtio guest errors until the user request it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/virtio/virtio.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/hw/virtio/virtio.c b/hw/virtio

Re: [PATCH 1/6] migration: Fix and clean up around @tls-authz

2020-12-10 Thread Daniel P . Berrangé
On Fri, Nov 13, 2020 at 07:52:31AM +0100, Markus Armbruster wrote: > Commit d2f1d29b95 "migration: add support for a "tls-authz" migration > parameter" added MigrationParameters member @tls-authz. Whereas the > other members aren't really optional (see commit 1bda8b3c695), this > one is genuinely

Re: [PATCH v14 05/13] qapi: create BlockdevOptionsCor structure for COR driver

2020-12-10 Thread Vladimir Sementsov-Ogievskiy
10.12.2020 20:43, Max Reitz wrote: I don’t like this patch’s subject very much, because I find the implementation of the @bottom option to be more noteworthy than the addition of the QAPI structure. On 04.12.20 23:07, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich Create the B

Re: [RFC PATCH v2 2/3] vfio: Set the priority of the VFIO VM state change handler explicitly

2020-12-10 Thread Cornelia Huck
On Thu, 10 Dec 2020 11:11:17 +0800 Shenming Lu wrote: > On 2020/12/9 20:45, Cornelia Huck wrote: > > On Wed, 9 Dec 2020 16:09:18 +0800 > > Shenming Lu wrote: > > > >> In the VFIO VM state change handler, VFIO devices are transitioned > >> in the _SAVING state, which should keep them from send

[PATCH v2 0/8] testing/next (without-features, gitlab, python)

2020-12-10 Thread Alex Bennée
Hi, A quick turnaround from the version I posted yesterday. I've cleaned up the --without-default-devices stuff thanks to Paolo's feedback and it's a big win on binary size cutting my qemu-system-aarch64 to around a 1/3rd of it's normal size. I've also enable -Werror for tests/tcg. All still need

[PATCH v2 4/8] configure: add --without-default-features

2020-12-10 Thread Alex Bennée
By default QEMU enables a lot of features if it can probe and find the support libraries. It also enables a bunch of features by default. This patch adds the ability to build --without-default-features which can be paired with a --without-default-devices for a barely functional build. The main use

[PATCH v2 5/8] python: add __repr__ to ConsoleSocket to aid debugging

2020-12-10 Thread Alex Bennée
While attempting to debug some console weirdness I thought it would be worth making it easier to see what it had inside. Signed-off-by: Alex Bennée Reviewed-by: John Snow Reviewed-by: Willian Rampazzo --- v2 - make more pythonic --- python/qemu/console_socket.py | 7 +++ 1 file changed,

[PATCH v2 3/8] configure: move gettext detection to meson.build

2020-12-10 Thread Alex Bennée
This will allow meson to honour -Dauto_features=disabled later. Suggested-by: Paolo Bonzini Signed-off-by: Alex Bennée --- configure | 19 +++ meson_options.txt | 2 +- po/meson.build| 2 +- 3 files changed, 5 insertions(+), 18 deletions(-) diff --git a/configure

[PATCH v2 1/8] configure: include moxie-softmmu in deprecated_targets_list

2020-12-10 Thread Alex Bennée
We still build it but there is no point including it in the normal builds as it is ushered out of the door. Fixes: 4258c8e221 ("docs/system/deprecated: Mark the 'moxie' CPU as deprecated") Signed-off-by: Alex Bennée --- configure | 2 +- .gitlab-ci.yml | 2 +- 2 files changed, 2 insertions(

[PATCH v2 6/8] gitlab: move --without-default-devices build from Travis

2020-12-10 Thread Alex Bennée
Signed-off-by: Alex Bennée --- v2 - move to centos8 --- .gitlab-ci.yml | 7 +++ .travis.yml| 8 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index b3bcaacf7b..2134453717 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -514,

[PATCH v2 2/8] gitlab: include aarch64-softmmu and ppc64-softmmu cross-system-build

2020-12-10 Thread Alex Bennée
Otherwise we miss coverage of KVM support in the cross build. To balance it out add arm-softmmu (no kvm, subset of aarch64), cris-softmmu and ppc-softmmu to the exclude list which do get coverage elsewhere. Signed-off-by: Alex Bennée --- .gitlab-ci.d/crossbuilds.yml | 6 +++--- 1 file changed, 3

[PATCH v2 8/8] tests/tcg: build tests with -Werror

2020-12-10 Thread Alex Bennée
Hopefully this will guard against sloppy code getting into our tests. Suggested-by: Paolo Bonzini Signed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index 2ae86776cd..

[PATCH v2 7/8] gitlab: add --without-default-features build

2020-12-10 Thread Alex Bennée
Signed-off-by: Alex Bennée --- v2 - swap with centos8, don't include --without-default-devuces --- .gitlab-ci.yml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 2134453717..229545bc03 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -521,6 +

RE: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-12-10 Thread Dmitry Fomichev
> -Original Message- > From: Klaus Jensen > Sent: Wednesday, December 9, 2020 4:58 AM > To: Dmitry Fomichev > Cc: Keith Busch ; Klaus Jensen > ; Kevin Wolf ; Philippe > Mathieu-Daudé ; Max Reitz ; > Maxim Levitsky ; Fam Zheng ; > Niklas Cassel ; Damien Le Moal > ; qemu-bl...@nongnu.org; q

Re: Some performance numbers for virtiofs, DAX and virtio-9p

2020-12-10 Thread Miklos Szeredi
On Thu, Dec 10, 2020 at 5:11 PM Vivek Goyal wrote: > Conclusion > --- > - virtiofs DAX seems to help a lot in many workloads. > > Note, DAX performance well only if data fits in cache window. My total > data is 16G and cache window size is 16G as well. If data is larger > than DAX c

Re: [PULL 00/13] Miscellaneous patches for 2020-12-10

2020-12-10 Thread Peter Maydell
On Thu, 10 Dec 2020 at 16:32, Markus Armbruster wrote: > > The following changes since commit 00ef48ff0de9c3e5834e7e3f6691bbc80d08c114: > > Merge remote-tracking branch > 'remotes/kraxel/tags/microvm-20201210-pull-request' into staging (2020-12-10 > 12:53:01 +00

Re: [PATCH 1/3] virtiofsd: Set up posix_lock hash table for root inode

2020-12-10 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > We setup per inode hash table ->posix_lock to support remote posix locks. > But we forgot to initialize this table for root inode. > > Laszlo managed to trigger an issue where he sent a FUSE_FLUSH request for > root inode and lo_flush() found inode with i

Re: [PATCH 2/3] virtiofsd: Disable posix_lock hash table if remote locks are not enabled

2020-12-10 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > If remote posix locks are not enabled (lo->posix_lock == false), then disable > code paths taken to initialize inode->posix_lock hash table and corresponding > destruction and search etc. > > lo_getlk() and lo_setlk() have been modified to return ENOSYS i

Re: [PATCH 3/3] virtiofsd: Check file type in lo_flush()

2020-12-10 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > Currently lo_flush() is written in such a way that it expects to receive > a FLUSH requests on a regular file (and not directories). For example, > we call lo_fi_fd() which searches lo->fd_map. If we open directories > using opendir(), we keep don't keep t

Re: [PATCH 3/3] virtiofsd: Check file type in lo_flush()

2020-12-10 Thread Vivek Goyal
On Thu, Dec 10, 2020 at 08:03:03PM +, Dr. David Alan Gilbert wrote: > * Vivek Goyal (vgo...@redhat.com) wrote: > > Currently lo_flush() is written in such a way that it expects to receive > > a FLUSH requests on a regular file (and not directories). For example, > > we call lo_fi_fd() which sea

Re: [RFC PATCH] hw/misc/zynq_slcr: Avoid #DIV/0! error

2020-12-10 Thread Edgar E. Iglesias
On Thu, Dec 10, 2020 at 08:39:32AM -0800, Alistair Francis wrote: > On Thu, Dec 10, 2020 at 6:27 AM Philippe Mathieu-Daudé > wrote: > > > > Malicious user can set the feedback divisor for the PLLs > > to zero, triggering a floating-point exception (SIGFPE). > > > > As the datasheet [*] is not cle

[PATCH v3 3/4] target/arm: Implement FPCXT_NS fp system register

2020-12-10 Thread Peter Maydell
Implement the v8.1M FPCXT_NS floating-point system register. This is a little more complicated than FPCXT_S, because it has specific handling for "current FP state is inactive", and it only wants to do PreserveFPState(), not the full set of actions done by ExecuteFPCheck() which vfp_access_check()

[PATCH v3 1/4] hw/intc/armv7m_nvic: Correct handling of CCR.BFHFNMIGN

2020-12-10 Thread Peter Maydell
The CCR is a register most of whose bits are banked between security states but where BFHFNMIGN is not, and we keep it in the non-secure entry of the v7m.ccr[] array. The logic which tries to handle this bit fails to implement the "RAZ/WI from Nonsecure if AIRCR.BFHFNMINS is zero" requirement; cor

[PATCH v3 4/4] target/arm: Implement Cortex-M55 model

2020-12-10 Thread Peter Maydell
Now that we have implemented all the features needed by the v8.1M architecture, we can add the model of the Cortex-M55. This is the configuration without MVE support; we'll add MVE later. Signed-off-by: Peter Maydell --- target/arm/cpu_tcg.c | 42 ++ 1 fi

[PATCH v3 2/4] target/arm: Correct store of FPSCR value via FPCXT_S

2020-12-10 Thread Peter Maydell
In commit 64f863baeedc8659 we implemented the v8.1M FPCXT_S register, but we got the write behaviour wrong. On read, this register reads bits [27:0] of FPSCR plus the CONTROL.SFPA bit. On write, it doesn't just write back those bits -- it writes a value to the whole FPSCR, whose upper 4 bits are ze

[PATCH v3 0/4] target/arm: Implement v8.1M and Cortex-M55

2020-12-10 Thread Peter Maydell
This is a lot smaller than v2 because most of that work made it through review and is now in master. This series has the last few patches that needed rework to address review comments, one new patch (patch 2) which fixes a bug that I missed until this evening, and the final "provide a Cortex-M55 m

Re: [PATCH 3/3] virtiofsd: Check file type in lo_flush()

2020-12-10 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > On Thu, Dec 10, 2020 at 08:03:03PM +, Dr. David Alan Gilbert wrote: > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > Currently lo_flush() is written in such a way that it expects to receive > > > a FLUSH requests on a regular file (and not directorie

[PATCH] docs: Build and install all the docs in a single manual

2020-12-10 Thread Peter Maydell
When we first converted our documentation to Sphinx, we split it into multiple manuals (system, interop, tools, etc), which are all built separately. The primary driver for this was wanting to be able to avoid shipping the 'devel' manual to end-users. However, this is working against the grain of

Re: [PATCH 00/10] Fix floating-point -> text conversion precision

2020-12-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201210161452.2813491-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201210161452.2813491-1-arm...@redhat.com Subject: [PATCH 00/10] Fix floating-point -> t

Re: [PATCH 1/4] clock: Introduce clock_ticks_to_ns()

2020-12-10 Thread Peter Maydell
On Tue, 8 Dec 2020 at 23:39, Richard Henderson wrote: > > On 12/8/20 12:15 PM, Peter Maydell wrote: > > +static inline uint64_t clock_ticks_to_ns(const Clock *clk, uint64_t ticks) > > +{ > > +uint64_t ns_low, ns_high; > > + > > +/* > > + * clk->period is the period in units of 2^-32 ns

Re: [PATCH v10 00/32] i386 cleanup

2020-12-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201210121226.19822-1-cfont...@suse.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201210121226.19822-1-cfont...@suse.de Subject: [PATCH v10 00/32] i386 cleanup === TEST SCR

Re: [PATCH v2 1/1] security-process: update process information

2020-12-10 Thread Stefano Stabellini
On Thu, 3 Dec 2020, P J P wrote: > From: Prasad J Pandit > > We are about to introduce a qemu-security mailing list to report > and triage QEMU security issues. > > Update the security process web page with new mailing list address > and triage details. > > Signed-off-by: Prasad J Pandit Acke

Re: [PATCH v2 1/1] security-process: update process information

2020-12-10 Thread Konrad Rzeszutek Wilk
On Thu, Dec 03, 2020 at 06:29:02AM -0800, P J P wrote: > From: Prasad J Pandit > > We are about to introduce a qemu-security mailing list to report > and triage QEMU security issues. > > Update the security process web page with new mailing list address > and triage details. > > Signed-off-by:

ceph + freeipa ubuntu/fedora common small bug

2020-12-10 Thread Harry G. Coin
FYI.  Same thing we saw on Fedora installing freeipa, this on ubuntu with ceph.  Identical bitmask report. ... Fixing /var/run/ceph ownershipdone Cannot set file attribute for '/var/log/journal', value=0x0080, mask=0x0080, ignoring: Function not implemented Cannot set file attribute

Re: [PATCH v2 8/8] tests/tcg: build tests with -Werror

2020-12-10 Thread Philippe Mathieu-Daudé
On 12/10/20 8:04 PM, Alex Bennée wrote: > Hopefully this will guard against sloppy code getting into our tests. > > Suggested-by: Paolo Bonzini > Signed-off-by: Alex Bennée > --- > tests/tcg/Makefile.target | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-D

[PATCH] audio: Simplify audio_bug() removing old code

2020-12-10 Thread Philippe Mathieu-Daudé
This code (introduced in commit 1d14ffa97ea, Oct 2005) is likely unused since years. Time to remove it. If the condition is true, simply call abort(). Suggested-by: Gerd Hoffmann Signed-off-by: Philippe Mathieu-Daudé --- audio/audio.c | 19 +-- 1 file changed, 1 insertion(+), 1

[PULL 1/3] qom: code hardening - have bound checking while looping with integer value

2020-12-10 Thread Eduardo Habkost
From: Ani Sinha Object property insertion code iterates over an integer to get an unused index that can be used as an unique name for an object property. This loop increments the integer value indefinitely. Although very unlikely, this can still cause an integer overflow. In this change, we fix t

[PULL 2/3] sev: add sev-inject-launch-secret

2020-12-10 Thread Eduardo Habkost
From: Tobin Feldman-Fitzthum AMD SEV allows a guest owner to inject a secret blob into the memory of a virtual machine. The secret is encrypted with the SEV Transport Encryption Key and integrity is guaranteed with the Transport Integrity Key. Although QEMU facilitates the injection of the launch

[PULL 3/3] i386/cpu: Make the Intel PT LIP feature configurable

2020-12-10 Thread Eduardo Habkost
From: Luwei Kang The current implementation will disable the guest Intel PT feature if the Intel PT LIP feature is supported on the host, but the LIP feature is comming soon(e.g. SnowRidge and later). This patch will make the guest LIP feature configurable and Intel PT feature can be enabled in

[PULL 0/3] Machine and x86 queue, 2020-12-10

2020-12-10 Thread Eduardo Habkost
The following changes since commit 2ecfc0657afa5d29a373271b342f704a1a3c6737: Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2020-12-10' into staging (2020-12-10 17:01:05 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/machine-next-pull-req

Re: [PATCH v3 0/1] spapr.c: set a 'kvm-type' default value instead of relying on NULL

2020-12-10 Thread David Gibson
On Thu, Dec 10, 2020 at 05:51:41PM +0100, Paolo Bonzini wrote: > On 10/12/20 15:55, Daniel Henrique Barboza wrote: > > changes from v2, all proposed by Greg: > > * Handle 'NULL' value as default mode fallback in spapr_kvm_type() > > * Do not allow for 'AUTO' to be a valid mode in spapr_kvm_type() >

[PULL 2/3] accel/tcg: split tcg_start_vcpu_thread

2020-12-10 Thread Richard Henderson
From: Claudio Fontana after the initial split into 3 tcg variants, we proceed to also split tcg_start_vcpu_thread. We actually split it in 2 this time, since the icount variant just uses the round robin function. Suggested-by: Richard Henderson Signed-off-by: Claudio Fontana Message-Id: <2020

[PULL 0/3] tcg patch queue

2020-12-10 Thread Richard Henderson
The following changes since commit 2ecfc0657afa5d29a373271b342f704a1a3c6737: Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2020-12-10' into staging (2020-12-10 17:01:05 +) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-tc

Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap

2020-12-10 Thread zhukeqian
On 2020/12/10 22:50, Peter Xu wrote: > On Thu, Dec 10, 2020 at 10:53:23AM +0800, zhukeqian wrote: >> >> >> On 2020/12/10 10:08, Peter Xu wrote: >>> Keqian, >>> >>> On Thu, Dec 10, 2020 at 09:46:06AM +0800, zhukeqian wrote: Hi, I see that if start or size is not PAGE aligned, it als

[PULL 3/3] accel/tcg: rename tcg-cpus functions to match module name

2020-12-10 Thread Richard Henderson
From: Claudio Fontana Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201015143217.29337-4-cfont...@suse.de> Signed-off-by: Richard Henderson --- accel/tcg/tcg-cpus-icount.h | 6 +-- accel/tcg/tcg-cpus-rr.h | 2 +- accel/tcg/tcg-cpus.h| 6 +--

[PULL 1/3] accel/tcg: split CpusAccel into three TCG variants

2020-12-10 Thread Richard Henderson
From: Claudio Fontana split up the CpusAccel tcg_cpus into three TCG variants: tcg_cpus_rr (single threaded, round robin cpus) tcg_cpus_icount (same as rr, but with instruction counting enabled) tcg_cpus_mttcg (multi-threaded cpus) Suggested-by: Richard Henderson Signed-off-by: Claudio Fontana

[PATCH 1/2] tcg/i386: Adjust TCG_TARGET_HAS_MEMORY_BSWAP

2020-12-10 Thread Richard Henderson
Always true when movbe is available, otherwise leave this to generic code. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 3 +- tcg/i386/tcg-target.c.inc | 119 ++ 2 files changed, 47 insertions(+), 75 deletions(-) diff --git a/tcg/i386/tc

[PATCH 0/2] tcg: Eliminate scratch regs from i386 backend

2020-12-10 Thread Richard Henderson
Eliminating these cleans up the backend a bit, allows the code generator more freedom to properly place the inputs. r~ Richard Henderson (2): tcg/i386: Adjust TCG_TARGET_HAS_MEMORY_BSWAP tcg: Introduce INDEX_op_qemu_st8_i32 include/tcg/tcg-opc.h | 5 ++ tcg/aarch64/tcg-target.h |

[PATCH 2/2] tcg: Introduce INDEX_op_qemu_st8_i32

2020-12-10 Thread Richard Henderson
Enable this on i386 to restrict the set of input registers for an 8-bit store, as required by the architecture. This removes the last use of scratch registers for user-only mode. Signed-off-by: Richard Henderson --- include/tcg/tcg-opc.h | 5 + tcg/aarch64/tcg-target.h | 1 + tcg/arm

Re: [Bug 1907427] [NEW] Build on sparc64 fails with "undefined reference to `fdt_check_full'"

2020-12-10 Thread David Gibson
On Thu, Dec 10, 2020 at 09:00:41AM +0100, Thomas Huth wrote: > On 09/12/2020 10.13, John Paul Adrian Glaubitz wrote: > > Public bug reported: > > > > Trying to build QEMU on sparc64 fails with: > [...] > > /usr/bin/ld: libqemu-ppc64-softmmu.fa.p/hw_ppc_spapr_hcall.c.o: in function > > `h_update_d

Re: [PATCH 1/4] clock: Introduce clock_ticks_to_ns()

2020-12-10 Thread Richard Henderson
On 12/10/20 2:47 PM, Peter Maydell wrote: >> With the shift, you're discarding the high 32 bits of the result. You'll >> lose >> those same bits if you shift one of the inputs left by 32, and use only the >> high part of the result, e.g. >> >> mulu(&discard, &ret, clk->period, ticks << 32); >

[PATCH 0/7] Additional NPCM7xx devices and IPMI BMC emulation support

2020-12-10 Thread Hao Wu via
This patch series include a few more NPCM7XX devices including - Analog Digital Converter (ADC) - Pulse Width Modulation (PWM) - Keyboard Style Controller (KSC) To utilize these modules we also add two extra functionalities: 1. We modified the CLK module to generate clock values using qdev_clock

[PATCH 4/7] hw/misc: Add a PWM module for NPCM7XX

2020-12-10 Thread Hao Wu via
The PWM module is part of NPCM7XX module. Each NPCM7XX module has two identical PWM modules. Each module contains 4 PWM entries. Each PWM has two outputs: frequency and duty_cycle. Both are computed using inputs from software side. This module does not model detail pulse signals since it is expens

[PATCH 1/7] hw/misc: Add clock converter in NPCM7XX CLK module

2020-12-10 Thread Hao Wu via
This patch allows NPCM7XX CLK module to compute clocks that are used by other NPCM7XX modules. Add a new struct NPCM7xxClockConverterState which represents a single converter. Each clock converter in CLK module represents one converter in NPCM7XX CLK Module(PLL, SEL or Divider). Each converter ta

[PATCH 2/7] hw/timer: Refactor NPCM7XX Timer to use CLK clock

2020-12-10 Thread Hao Wu via
This patch makes NPCM7XX Timer to use a the timer clock generated by the CLK module instead of the magic nubmer TIMER_REF_HZ. Reviewed-by: Havard Skinnemoen Reviewed-by: Tyrone Ting Signed-off-by: Hao Wu --- hw/arm/npcm7xx.c | 5 + hw/timer/npcm7xx_timer.c | 25 +++

[PATCH 3/7] hw/adc: Add an ADC module for NPCM7XX

2020-12-10 Thread Hao Wu via
The ADC is part of NPCM7XX Module. Its behavior is controled by the ADC_CON register. It converts one of the eight analog inputs into a digital input and stores it in the ADC_DATA register when enabled. Reviewed-by: Havard Skinnemoen Reviewed-by: Tyrone Ting Signed-off-by: Hao Wu --- docs/syst

[PATCH 5/7] hw/ipmi: Add an IPMI host interface

2020-12-10 Thread Hao Wu via
The IPMI host interface is used to emulate IPMI related devices on a System-on-Chip (SoC) used for Baseband Management Controller (BMC). This interface consists of two components: IPMI host and IPMI responder. An IPMI responder is a device to intercept reads and writes to the system interface regis

[PATCH 6/7] hw/ipmi: Add a KCS Module for NPCM7XX

2020-12-10 Thread Hao Wu via
Add a KCS module for NPCM7xx SoC. This module implements the IPMI responder interface and is responsible to communicate with an external host via the KCS channels in an NPCM7xx SoC. Reviewed-by: Tyrone Ting Signed-off-by: Hao Wu --- docs/system/arm/nuvoton.rst | 2 +- hw/arm/npcm7xx.c

[PATCH 7/7] hw/ipmi: Add an IPMI external host device

2020-12-10 Thread Hao Wu via
The IPMI external host device works for Baseband Management Controller (BMC) emulations. It works as a representation of a host class that connects to a given BMC. It can connect to a real host hardware or a emulated or simulated host device. In particular it can connect to a host QEMU instance wi

Re: [PULL 13/13] docs/devel/writing-qmp-commands.txt: Fix docs

2020-12-10 Thread Zihao Chang
On 2020/12/11 0:31, Markus Armbruster wrote: > From: Zihao Chang > > Fix the example of add qmp hello-world example. > Without ":", make will report error: > ../qapi/misc.json:573:2: line should end with ':' > > Signed-off-by: Zihao Chang > Message-Id: <20201201143308.1626-1-changzih...@huaw

RE: [PATCH v3 0/7] silence the compiler warnings

2020-12-10 Thread Chenqun (kuhn)
Kindly ping! Hi all, Patch 1 to Patch 5 are not in the queue. Could someone pick them up? Patch1~Patch5: target/i386: silence the compiler warnings in gen_shiftd_rm_T1 hw/intc/arm_gicv3_kvm: silence the compiler warnings accel/tcg/user-exec: silence the compiler warnings target/sparc/t

RE: [PATCH v2 0/5] fix uninitialized variable warning

2020-12-10 Thread Chenqun (kuhn)
Kindly ping! Hi folks, Patch 1 to Patch 4 are not in the queue. Could someone help pick them up? Patch1~Patch4: hw/rdma/rdma_backend: fix uninitialized variable warning in rdma_poll_cq() util/qemu-timer: fix uninitialized variable warning in timer_mod_anticipate_ns() util/qemu-tim

Re: [PATCH V17 4/6] hw/mips: Add Loongson-3 boot parameter helpers

2020-12-10 Thread Huacai Chen
Hi, Rechard and Peter, On Wed, Dec 2, 2020 at 5:32 PM Philippe Mathieu-Daudé wrote: > > On 12/2/20 2:14 AM, Huacai Chen wrote: > > Hi, Phillippe, > > > > On Tue, Nov 24, 2020 at 6:25 AM Philippe Mathieu-Daudé > > wrote: > >> > >> On 11/6/20 5:21 AM, Huacai Chen wrote: > >>> Preparing to add Loo

Re: [PATCH 0/7] Additional NPCM7xx devices and IPMI BMC emulation support

2020-12-10 Thread Corey Minyard
On Thu, Dec 10, 2020 at 05:51:49PM -0800, Hao Wu wrote: > This patch series include a few more NPCM7XX devices including > > - Analog Digital Converter (ADC) > - Pulse Width Modulation (PWM) > - Keyboard Style Controller (KSC) > > To utilize these modules we also add two extra functionalities: >

[PULL 01/30] spapr/xive: Turn some sanity checks into assertions

2020-12-10 Thread David Gibson
From: Greg Kurz The sPAPR XIVE device is created by the machine in spapr_irq_init(). The latter overrides any value provided by the user with -global for the "nr-irqs" and "nr-ends" properties with strictly positive values. It seems reasonable to assume these properties should never be 0, which

[PULL 03/30] spapr: Do PCI device hotplug sanity checks at pre-plug only

2020-12-10 Thread David Gibson
From: Greg Kurz The PHB acts as the hotplug handler for PCI devices. It does some sanity checks on DR enablement, PCI bridge chassis numbers and multifunction. These checks are currently performed at plug time, but they would best sit in a pre-plug handler in order to error out as early as possib

<    1   2   3   4   5   >