On Wed 09 Dec 2020 05:44:41 PM CET, Maxim Levitsky wrote:
> @@ -3847,12 +3847,13 @@ static int coroutine_fn
> qcow2_co_create_opts(BlockDriver *drv,
>
> /* Create the qcow2 image (format layer) */
> ret = qcow2_co_create(create_options, errp);
> +
> +finish:
> if (ret < 0) {
> -
Add a QMP command to allow for the behaviors specified by the
-action event=action command line option to be set at runtime.
The new command is named set-action, and takes a single argument
of type RunStateAction, which contains an event|action pair.
Example:
-> { "execute": "set-action",
"a
Convert tracing.txt to rST and add it to the generated developer documentation.
Peter Maydell suggested making the "log" backend the recommended backend in the
quickstart documentation. It's easier to use than the "simple" backend. The
final patch updates the documentation to do this.
Stefan Hajn
The simpletrace documentation section was accidentally split when the
ftrace section was introduced. Move the simpletrace-specific
documentation back into the simpletrace section.
Fixes: e64dd5efb2c6d522a3bc9d096cd49a4e53f0ae10 ("trace: document ftrace
backend")
Signed-off-by: Stefan Hajnoczi
--
On Tue, Dec 8, 2020 at 8:21 AM Stefan Hajnoczi wrote:
>
> On Fri, Nov 20, 2020 at 07:50:46PM +0100, Eugenio Pérez wrote:
> > @@ -1571,6 +1577,13 @@ void vhost_dev_disable_notifiers(struct vhost_dev
> > *hdev, VirtIODevice *vdev)
> > BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(vdev)));
>
On Wed, 2020-12-09 at 09:23 -0800, James Bottomley wrote:
> This patch series includes one from Tobin that has already been
> posted
> and reviewed:
>
> https://lore.kernel.org/qemu-devel/20201027170303.47550-1-to...@linux.ibm.com/
>
> I'm adding it here because it's a required precursor, but it
The "simple" backend is actually more complicated to use than the "log"
backend. Update the quickstart documentation to feature the "log"
backend instead of the "simple" backend.
Suggested-by: Peter Maydell
Signed-off-by: Stefan Hajnoczi
---
docs/devel/tracing.rst | 19 ---
1 fi
Test the scenario where the -action panic=none parameter is used to
signal that the VM must continue executing after a guest panic
occurs.
Suggested-by: Paolo Bonzini
Signed-off-by: Alejandro Jimenez
---
tests/qtest/pvpanic-test.c | 26 +-
1 file changed, 25 insertions(+
On 12/9/20 6:42 PM, Greg Kurz wrote:
> On Wed, 9 Dec 2020 18:34:31 +0100
> Philippe Mathieu-Daudé wrote:
>
>> On 12/9/20 6:00 PM, Greg Kurz wrote:
>>> The sPAPR CPU core device can only work with pseries machine types.
>>> This is currently checked in the realize function with a dynamic
>>> cast
The current default action of pausing a guest after a panic event
is received leaves the responsibility to resume guest execution to the
management layer. The reasons for this behavior are discussed here:
https://lore.kernel.org/qemu-devel/52148f88.5000...@redhat.com/
However, in instances like th
On Wed, Dec 09, 2020 at 04:20:59PM +, Peter Maydell wrote:
> On Wed, 9 Dec 2020 at 14:37, Peter Maydell wrote:
> >
> > On Tue, 8 Dec 2020 at 19:33, Michael S. Tsirkin wrote:
> > >
> > > The following changes since commit
> > > 553032db17440f8de011390e5a1cfddd13751b0b:
> > >
> > > Update ve
Several command line options currently in use are meant to modify
the behavior of QEMU in response to certain guest events like:
-no-reboot, -no-shutdown, -watchdog-action.
These can be grouped into a single option of the form:
-action event=action
Which can be used to specify the existing optio
v2:
- Replaced the individual qmp commands in patch 3/4 for a generic set-action
command that takes a RunStateAction parameter, specifying an event|action pair.
- Removed qmp_ prefix from X_set_action() functions in runstate-action.c
***
This is a follow up to the proposal to add a "-no-panicstop
The following changes since commit 553032db17440f8de011390e5a1cfddd13751b0b:
Update version for v5.2.0 release (2020-12-08 15:55:19 +)
are available in the Git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
for you to fetch changes up to fdfa3b1d6f9e
On Tue, Sep 08, 2020 at 05:54:37PM +0100, Daniel P. Berrangé wrote:
> This refactoring prepares for exposing the SMBIOS entry point type as a
> machine property on x86.
>
> Signed-off-by: Daniel P. Berrangé
> ---
[...]
> +##
> +# @SmbiosEntryPointType:
> +#
> +# @2_1: SMBIOS version 2.1
> +#
> +#
From: John Levon
If we find a queue with an inconsistent guest index value, explicitly mark the
device as needing a reset - and broken - via virtio_error().
There's at least one driver implementation - the virtio-win NetKVM driver - that
is able to handle a VIRTIO_CONFIG_S_NEEDS_RESET notificati
ping
Adding CC qemu-trivial.
This already got one R-b:
https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg00525.html
-Dov
On 03/11/2020 12:07, Dov Murik wrote:
Three trace events had a literal "0x" prefix but the 'len' values were
formatted in decimal base. Keep the prefix and format
From: Eugenio Pérez
This way we can tell between regular IOMMUTLBEntry (entry of IOMMU
hardware) and notifications.
In the notifications, we set explicitly if it is a MAPs or an UNMAP,
instead of trusting in entry permissions to differentiate them.
Signed-off-by: Eugenio Pérez
Reviewed-by: Pet
From: Eugenio Pérez
This allows us to differentiate between regular IOMMU map/unmap events
and DEVIOTLB unmap. Doing so, notifiers that only need device IOTLB
invalidations will not receive regular IOMMU unmappings.
Adapt intel and vhost to use it.
Signed-off-by: Eugenio Pérez
Reviewed-by: Pet
From: Yubo Miao
Extract two APIs acpi_dsdt_add_pci_route_table and
acpi_dsdt_add_pci_osc from acpi_dsdt_add_pci. The first
API is used to specify the pci route table and the second
API is used to declare the operation system capabilities.
These two APIs would be used to specify the pxb-pcie in DS
From: Eugenio Pérez
Although they didn't reach the notifier because of the filtering in
memory_region_notify_iommu_one, the vt-d was still splitting huge
memory invalidations in chunks. Skipping it.
This improves performance in case of netperf with vhost-net:
* TCP_STREAM: From 1923.6Mbit/s to 2
From: Alex Chen
The 'elem' is allocated memory in vu_queue_pop(), and its memory should be
freed in all error branches after vu_queue_pop().
In addition, in order to free the 'elem' memory outside of while(1) loop, move
the definition of 'elem' to the beginning of vus_proc_req().
Reported-by: Eu
From: Juan Quintela
Just remove the struct member.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-5-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/virtio/virtio-net.h | 1 -
hw/net/virtio-net.c| 8
2 f
From: Yubo Miao
Extract crs build form acpi_build.c, the function could also be used
to build the crs for pxbs for arm. The resources are composed by two parts:
1. The bar space of pci-bridge/pcie-root-ports
2. The resources needed by devices behind PXBs.
The base and limit of memory/io are obtai
From: Jiahui Cen
Add bus property to virt machine for primary PCI root bus and use it to add
extra pci roots behind it.
Signed-off-by: Jiahui Cen
Signed-off-by: Yubo Miao
Message-Id: <20201119014841.7298-4-cenjia...@huawei.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
From: Eugenio Pérez
Previous name didn't reflect the iommu operation.
Signed-off-by: Eugenio Pérez
Reviewed-by: Peter Xu
Reviewed-by: David Gibson
Reviewed-by: Juan Quintela
Reviewed-by: Eric Auger
Acked-by: Jason Wang
Message-Id: <20201116165506.31315-2-epere...@redhat.com>
Reviewed-by: M
On Wed, Dec 02, 2020 at 02:27:53PM +, Stefan Hajnoczi wrote:
> On Wed, Nov 25, 2020 at 02:06:38PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Do not compile potentially panicking code, instead check memfd API is
> > present during configure time.
> >
> > Si
From: Yubo Miao
Add testcase for pxb to make sure the ACPI table is correct for guest.
Signed-off-by: Yubo Miao
Signed-off-by: Jiahui Cen
Message-Id: <20201119014841.7298-9-cenjia...@huawei.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
tests/qtest/bios-tables-te
From: Yubo Miao
Add the binary file DSDT.pxb and clear bios-tables-test-allowed-diff.h
Signed-off-by: Yubo Miao
Signed-off-by: Jiahui Cen
Message-Id: <20201119014841.7298-10-cenjia...@huawei.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
tests/qtest/bios-tables-t
From: Eugenio Pérez
Device IOTLB invalidations can unmap arbitrary ranges, eiter outside of
the memory region or even [0, ~0ULL] for all the space. The assertion
could be hit by a guest, and rhel7 guest effectively hit it.
Signed-off-by: Eugenio Pérez
Reviewed-by: Peter Xu
Reviewed-by: Juan Qu
From: Juan Quintela
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-6-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/hw/net/virtio-net.c b/
From: Juan Quintela
We can calculate it, and we only use it once anyways.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-12-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/virtio/virtio-net.h | 1 -
hw/net/virtio-net.c
From: Juan Quintela
It was only set "once", and with the wrong value. As far as I can see,
libvirt still don't use it.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-7-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.
From: Jiahui Cen
Extract extra pci roots addition from pc machine, which could be used by
other machines.
In order to make uefi get the extra roots, it is necessary to write extra
roots into fw_cfg. And only if the uefi knows there are extra roots,
the config spaces of devices behind the root co
From: Juan Quintela
This commit:
* Rename them to failover_find_primary_devices() so
- it starts with failover_
- it don't connect anything, just find the primary device
* Create documentation for the function
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-19-quint...@redhat.
From: Juan Quintela
It was really only used once, in failover_add_primary(). Just search
for it on global opts when it is needed.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-11-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
inclu
From: Juan Quintela
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-10-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/virtio-net.c b/hw/net/
From: Yubo Miao
The resources of pxbs are obtained by crs_build and the resources
used by pxbs would be moved from the resources defined for host-bridge.
The resources for pxb are composed of following two parts:
1. The bar space of the pci-bridge/pcie-root-port behined it
2. The config space of
From: Juan Quintela
So we can calculate the device id when we need it.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-24-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.c | 63 +---
From: Juan Quintela
Two things, at this point:
* n->primary_device_id has to be set, otherwise
virtio_net_find_primary don't work. So we have a leak here.
* it has to be exactly the same that prim_dev->id because what
qdev_find_recursive() does is just compare this two values.
So remove t
From: Juan Quintela
It was only used once. And we have there opts->id, so no need for it.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-13-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/virtio/virtio-net.h | 1 -
hw/net
From: Yubo Miao
If table size is changed between virt_acpi_build and
virt_acpi_build_update, the table size would not be updated to
UEFI, therefore, just align the size to 128kb, which is enough
and same with x86. It would warn if 64k is not enough and the
align size should be updated.
Signed-of
From: Juan Quintela
Pass it as an argument.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-26-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.c | 27 ++-
1 file changed, 14 insertions(+), 13 d
From: Juan Quintela
Just put allthe logic inside the same if.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-20-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
softmmu/qdev-monitor.c | 11 ++-
1 file changed, 6 insertions(+),
From: Juan Quintela
We didn't use at all the -1 value, and we don't really care. It was
only used for the cases when this is not the device that we are
searching for. And in that case we should not hide the device.
Once there, simplify virtio-Snet_primary_should_be_hidden.
Signed-off-by: Juan
From: Yubo Miao
The unit-test is seperated into three patches:
1. The files changed and list in bios-tables-test-allowed-diff.h
2. The unit-test
3. The binary file and clear bios-tables-test-allowed-diff.h
The ASL diff would also be listed.
Sice there are 1000+lines diff, some changes would be o
From: Juan Quintela
Only three uses remained, and we can remove them on that case.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-28-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/virtio/virtio-net.h | 1 -
hw/net/virtio-
From: Juan Quintela
You should not use pasive.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-17-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/qdev-core.h | 28 +++-
hw/core/qdev.c | 4 ++-
From: Juan Quintela
Once there, remove not needed cast.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-3-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.c| 33 +++--
softmmu/qdev-monit
From: Juan Quintela
We can calculate device just once.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-27-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.c | 25 ++---
1 file changed, 10 insertions
From: Juan Quintela
We check that it exist at device creation time, so we don't have to
check anywhere else.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-22-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.c| 3
From: Cornelia Huck
Add 6.0 machine types for arm/i440fx/q35/s390x/spapr.
Signed-off-by: Cornelia Huck
Message-Id: <20201109173928.1001764-1-coh...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
From: Juan Quintela
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-4-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/virtio-net.c b/hw/net/v
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Message-Id: <20201125100640.366523-4-marcandre.lur...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
contrib/libvhost-user/libvhost-user.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
dif
From: Marc-André Lureau
Undo the damage from commit 5f9ff1eff3 ("libvhost-user: Support tracking
inflight I/O in shared memory") which introduced glib dependency through
osdep.h inclusion.
libvhost-user.c tries to stay free from glib usage.
Use glibc memfd_create directly when available (assume
Hi Paolo, Fam,
On 12/8/20 1:28 PM, Cornelia Huck wrote:
> Hotplug a virtio-net-ccw device, and then hotunplug it again.
>
> Signed-off-by: Cornelia Huck
> ---
> v2->v3:
> - do the dmesg cleanout and waiting for messages properly [Thomas]
>
> Wainer: I dropped your r-b, as there had been too man
From: Juan Quintela
Never both.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-8-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/ne
From: Marc-André Lureau
By making libvhost-user a subproject, check it builds
standalone (without the global QEMU cflags etc).
Note that the library still relies on QEMU include/qemu/atomic.h and
linux_headers/.
Signed-off-by: Marc-André Lureau
Message-Id: <20201125100640.366523-6-marcandre.lu
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Message-Id: <20201125100640.366523-9-marcandre.lur...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
.gitlab-ci.yml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/.gitlab-ci.yml b/.gi
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Stefan Hajnoczi
Message-Id: <20201125100640.366523-2-marcandre.lur...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
contrib/libvhost-user/libvhost-us
From: Juan Quintela
You should not use passive naming variables.
And once there, be able to search for them.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-9-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/virtio/virtio-net
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Message-Id: <20201125100640.366523-8-marcandre.lur...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
subprojects/libvhost-user/link-test.c | 45 +++
subprojects/libvhost-user/me
From: Stefan Hajnoczi
Do not validate input with g_return_val_if(). This API is intended for
checking programming errors and is compiled out with -DG_DISABLE_CHECKS.
Use an explicit if statement for input validation so it cannot
accidentally be compiled out.
Suggested-by: Markus Armbruster
Sig
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Message-Id: <20201125100640.366523-5-marcandre.lur...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
contrib/libvhost-user/libvhost-user-glib.c | 10 --
1 file changed, 8 insertions(+), 2 delet
From: Juan Quintela
a - is_my_primary() never sets one error
b - If we return 1, primary_device_id is always set
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-15-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.c | 1
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Message-Id: <20201207140739.3829993-4-imamm...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-bu
From: Erich-McMillan
At Hewlett Packard Inc. we have a need for increased fw size to enable testing
of our custom fw.
Rebase v6 patch to d73c46e4
Signed-off-by: Erich McMillan
Message-Id: <20201208155338.14-1-erich.mcmil...@hp.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Ts
From: Stefan Hajnoczi
Do not validate input with g_return_val_if(). This API is intended for
checking programming errors and is compiled out with -DG_DISABLE_CHECKS.
Use an explicit if statement for input validation so it cannot
accidentally be compiled out.
Suggested-by: Markus Armbruster
Sig
From: Juan Quintela
It just calls virtio_net_find_primary(), so just update the callers.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-18-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.c | 17 ++---
1 f
From: Igor Mammedov
Adds bit #4 to status/control field of CPU hotplug MMIO interface.
New bit will be used OSPM to mark CPUs as pending for removal by firmware,
when it calls _EJ0 method on CPU device node. Later on, when firmware
sees this bit set, it will perform CPU eject which will clear bit
From: Igor Mammedov
if firmware and QEMU negotiated CPU hotunplug support, generate
_EJ0 method so that it will mark CPU for removal by firmware and
pass control to it by triggering SMI.
Signed-off-by: Igor Mammedov
Message-Id: <20201207140739.3829993-6-imamm...@redhat.com>
Reviewed-by: Michael
From: Stefan Hajnoczi
Do not validate input with g_return_val_if(). This API is intended for
checking programming errors and is compiled out with -DG_DISABLE_CHECKS.
Use an explicit if statement for input validation so it cannot
accidentally be compiled out.
Suggested-by: Markus Armbruster
Sig
From: Juan Quintela
We don't need to walk the opts by hand. qmp_opt_get() already does
that. And then we can remove the functions that did that walk.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-21-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S
From: Igor Mammedov
update expected files with following change:
@@ -557,6 +557,7 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT",
0x0001)
CINS, 1,
CRMV, 1,
CEJ0, 1,
+CEJF, 1,
Offset (0x05),
On 12/9/20 6:53 PM, Philippe Mathieu-Daudé wrote:
> On 12/9/20 6:42 PM, Greg Kurz wrote:
>> On Wed, 9 Dec 2020 18:34:31 +0100
>> Philippe Mathieu-Daudé wrote:
>>
>>> On 12/9/20 6:00 PM, Greg Kurz wrote:
The sPAPR CPU core device can only work with pseries machine types.
This is currently
From: Igor Mammedov
Change that will be introduced by following patch:
@@ -557,6 +557,7 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT",
0x0001)
CINS, 1,
CRMV, 1,
CEJ0, 1,
+CEJF, 1,
Offset (0
From: Juan Quintela
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-25-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/virtio/virtio-net.h | 1 -
hw/net/virtio-net.c| 20 ++--
2 files changed, 10
From: Zenghui Yu
There is an interesting typo in the help message of pcie_aer_inject_error
command. Use 'tlp' instead of 'tlb' to match the PCIe AER term.
Signed-off-by: Zenghui Yu
Message-Id: <20201204030953.837-1-yuzeng...@huawei.com>
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Michael
From: Andrew Melnychenko
Removed hardcoded offset for ats. Added cap offset counter
for future capabilities like AER.
Signed-off-by: Andrew Melnychenko
Message-Id: <20201203110713.204938-2-and...@daynix.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/virtio/virt
From: Igor Mammedov
it will be reused by next patch to check validity of unplug
feature.
Signed-off-by: Igor Mammedov
Message-Id: <20201207140739.3829993-8-imamm...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/isa/lpc_ich9.c | 8 ++--
1 file change
From: Andrew Melnychenko
Added AER capability for virtio-pci devices.
Also added property for devices, by default AER is disabled.
Signed-off-by: Andrew Melnychenko
Message-Id: <20201203110713.204938-3-and...@daynix.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
h
From: Juan Quintela
It can never give one error.
Signed-off-by: Juan Quintela
Message-Id: <20201118083748.1328-23-quint...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
dif
From: Stefan Hajnoczi
Do not validate input with g_return_val_if(). This API is intended for
checking programming errors and is compiled out with -DG_DISABLE_CHECKS.
Use an explicit if statement for input validation so it cannot
accidentally be compiled out.
Suggested-by: Markus Armbruster
Sig
On Tue, Dec 8, 2020 at 9:18 AM Stefan Hajnoczi wrote:
>
> On Fri, Nov 20, 2020 at 07:50:48PM +0100, Eugenio Pérez wrote:
> > Signed-off-by: Eugenio Pérez
> > ---
> > hw/virtio/vhost-sw-lm-ring.c | 7 ++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/virtio/vhost-
On 12/9/20 11:08 AM, Thomas Huth wrote:
> On 09/12/2020 18.00, Alex Bennée wrote:
>> Otherwise we miss coverage of KVM support in the cross build. To
>> balance it out add cris-softmmu and ppc-softmmu to the exclude list
>> which do get coverage elsewhere.
>
> Could you maybe add arm-softmmu to th
From: Igor Mammedov
Keep CPU hotunplug with SMI disabled on 5.2 and older and enable
it by default on newer machine types.
Signed-off-by: Igor Mammedov
Message-Id: <20201207140739.3829993-9-imamm...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/pc.
On Wed, Dec 09, 2020 at 09:42:25AM +, Daniel P. Berrangé wrote:
> On Tue, Dec 08, 2020 at 04:20:23PM -0500, Eduardo Habkost wrote:
> > Add command-line option that lets the SMBIOS entry point type to
> > be configured.
> >
> > SMBIOS 3.0 support is necessary to allow us to support more
> > tha
On Wed, 9 Dec 2020 19:09:25 +0100
Philippe Mathieu-Daudé wrote:
> Hi Paolo, Fam,
>
> On 12/8/20 1:28 PM, Cornelia Huck wrote:
> > Hotplug a virtio-net-ccw device, and then hotunplug it again.
> >
> > Signed-off-by: Cornelia Huck
> > ---
> > v2->v3:
> > - do the dmesg cleanout and waiting for m
> We have some special RAM memory regions (managed by virtio-mem), whereby
> the guest agreed to only use selected memory ranges. "unused" parts are
> discarded so they won't consume memory - to logically unplug these memory
> ranges. Before the VM is allowed to use such logically unplugged memory
On 12/9/20 9:27 AM, Catalin Marinas wrote:
> On Wed, Dec 09, 2020 at 01:25:18PM +, Marc Zyngier wrote:
>> Would this syscall operate on the guest address space? Or on the VMM's
>> own mapping?
...
> Whatever is easier for the VMM, I don't think it matters as long as the
> host kernel can get th
On Wed, Dec 09, 2020 at 07:11:40PM +0100, Philippe Mathieu-Daudé wrote:
[...]
> @@ -200,7 +199,7 @@ static void spapr_cpu_core_reset(DeviceState *dev)
> int i;
>
> for (i = 0; i < cc->nr_threads; i++) {
> -spapr_reset_vcpu(sc->threads[i]);
> +
Thomas Huth writes:
> On 09/12/2020 18.00, Alex Bennée wrote:
>> Signed-off-by: Alex Bennée
>> ---
>> .gitlab-ci.yml | 7 +++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index 878d114d40..f87584ca8f 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.git
On Tue, Dec 8, 2020 at 9:42 AM Stefan Hajnoczi wrote:
>
> On Fri, Nov 20, 2020 at 07:50:56PM +0100, Eugenio Pérez wrote:
> > @@ -83,6 +89,18 @@ void
> > vhost_vring_set_notification_rcu(VhostShadowVirtqueue *vq, bool enable)
> > smp_mb();
> > }
> >
> > +bool vhost_vring_poll_rcu(VhostShadow
On 12/9/20 7:22 PM, Cornelia Huck wrote:
> On Wed, 9 Dec 2020 19:09:25 +0100
> Philippe Mathieu-Daudé wrote:
>
>> Hi Paolo, Fam,
>>
>> On 12/8/20 1:28 PM, Cornelia Huck wrote:
>>> Hotplug a virtio-net-ccw device, and then hotunplug it again.
>>>
>>> Signed-off-by: Cornelia Huck
>>> ---
>>> v2->v
On Wed, 9 Dec 2020 13:29:47 +0100
Cornelia Huck wrote:
> On Wed, 9 Dec 2020 16:09:17 +0800
> Shenming Lu wrote:
>
> > On ARM64 the VFIO SET_IRQS ioctl is dependent on the VM interrupt
> > setup, if the restoring of the VFIO PCI device config space is
> > before the VGIC, an error might occur in
> Let's factor out the core logic, to be reused soon.
>
> Cc: Paolo Bonzini
> Cc: "Michael S. Tsirkin"
> Cc: Alex Williamson
> Cc: Dr. David Alan Gilbert
> Cc: Igor Mammedov
> Cc: Pankaj Gupta
> Cc: Peter Xu
> Cc: Auger Eric
> Cc: Wei Yang
> Cc: teawater
> Cc: Marek Kedzierski
> Signed-o
> We implement the RamDiscardMgr interface and only require coordinated
> discarding of RAM to work.
>
> Reviewed-by: Dr. David Alan Gilbert
> Cc: Paolo Bonzini
> Cc: "Michael S. Tsirkin"
> Cc: Alex Williamson
> Cc: Dr. David Alan Gilbert
> Cc: Igor Mammedov
> Cc: Pankaj Gupta
> Cc: Peter Xu
On Wed, Dec 09, 2020 at 12:27:59PM -0600, Richard Henderson wrote:
> On 12/9/20 9:27 AM, Catalin Marinas wrote:
> > On Wed, Dec 09, 2020 at 01:25:18PM +, Marc Zyngier wrote:
> >> Would this syscall operate on the guest address space? Or on the VMM's
> >> own mapping?
> ...
> > Whatever is easie
Claudio Fontana writes:
> On 12/9/20 1:54 PM, Alex Bennée wrote:
>>
>> Claudio Fontana writes:
>>
>>> centralize the registration of the cpus.c module
>>> accelerator operations in accel/accel-softmmu.c
>>>
>>> Signed-off-by: Claudio Fontana
>>
>>> diff --git a/accel/tcg/tcg-cpus.c b/accel
On Tue, Dec 8, 2020 at 9:16 AM Stefan Hajnoczi wrote:
>
> On Fri, Nov 20, 2020 at 07:50:51PM +0100, Eugenio Pérez wrote:
> > -static inline bool vhost_vring_should_kick(VhostShadowVirtqueue *vq)
> > +static bool vhost_vring_should_kick_rcu(VhostShadowVirtqueue *vq)
>
> "vhost_vring_" is a confusin
201 - 300 of 369 matches
Mail list logo
