Use the machine properties instead.
Cc: Laurent Vivier
Reviewed-by: Thomas Huth
Signed-off-by: Paolo Bonzini
---
hw/m68k/mcf5206.c | 4 +++-
hw/m68k/mcf5208.c | 3 ++-
target/m68k/m68k-semi.c | 5 +++--
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/m68k/mcf5206.
Use the equivalent argument to the function instead.
Signed-off-by: Paolo Bonzini
---
hw/microblaze/boot.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/microblaze/boot.c b/hw/microblaze/boot.c
index 8ad3c27f2c..e1f56f83f9 100644
--- a/hw/microblaze/boot.c
+++ b/
The check has the same effect here, it only matters that it is performed
once all devices, both builtin and user-specified, have been created.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/softmmu/v
Use the equivalent argument to the function instead.
Signed-off-by: Paolo Bonzini
---
hw/nios2/boot.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/nios2/boot.c b/hw/nios2/boot.c
index 1df3b66c29..3cb864914b 100644
--- a/hw/nios2/boot.c
+++ b/hw/nios2/boot.c
@@ -
Cc: Mark Cave-Ayland
Signed-off-by: Paolo Bonzini
Reviewed-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20201026143028.3034018-15-pbonz...@redhat.com>
Signed-off-by: Paolo Bonzini
---
hw/sparc/leon3.c | 4 +---
hw/sparc/sun4m.c | 2 +-
hw/sparc64/sun4u.c | 2 +-
3 file
"Early" backends are created before the machine and can be used as
machine options.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 123 +++
1 file changed, 65 insertions(+), 58 deletions(-)
diff --git a/softmmu/vl.c b/
Use the machine properties instead.
Cc: Cornelia Huck
Signed-off-by: Paolo Bonzini
---
hw/s390x/ipl.c | 10 ++
hw/s390x/s390-skeys.c | 6 --
hw/s390x/s390-virtio-ccw.c | 4 +++-
target/s390x/excp_helper.c | 3 ++-
target/s390x/mem_helper.c | 10 +++---
targe
There is no reason to prevent -preconfig -daemonize. Of course if
no monitor is defined there will be no way to start the VM,
but that is a user error.
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 69d54b
Some very simple initialization routines can be nested in existing
subsystem-level functions, do that to simplify qemu_init.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
hw/core/machine.c | 3 +++
include/hw/qdev-core.h | 8
migration/migration.c | 4
softmmu/
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
hw/core/machine.c | 24
include/sysemu/sysemu.h | 1 +
softmmu/vl.c| 24
3 files changed, 25 insertions(+), 24 deletions(-)
diff --git a/hw/core/machine.c b/hw/core/m
Once smp_parse is done, the validation operates on the MachineState.
There is no reason for that code to be in vl.c.
Reviewed-by: Igor Mammedov
Tested-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
hw/core/machine.c | 23 +++
include/hw/boards.h | 1 +
softmmu/vl.c
Use the machine properties or loader parameters instead.
Cc: Philippe Mathieu-Daudé
Signed-off-by: Paolo Bonzini
---
hw/mips/fuloong2e.c | 4 ++--
hw/mips/malta.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c
index 25b679011
Move more of them into MachineState, in preparation for moving initialization
of the machine out of vl.c.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
include/hw/boards.h | 1 +
softmmu/vl.c| 12 ++--
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a
Use the loader parameters instead.
Signed-off-by: Paolo Bonzini
---
hw/i386/fw_cfg.c | 2 +-
hw/i386/vmport.c | 3 ++-
hw/i386/xen/xen-hvm.c | 2 +-
hw/intc/apic_common.c | 3 ++-
hw/smbios/smbios.c| 8
5 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/hw/i38
Use the machine properties for the leftovers too.
Signed-off-by: Paolo Bonzini
---
hw/core/generic-loader.c | 3 ++-
hw/core/numa.c | 10 +-
hw/virtio/virtio-balloon.c | 3 ++-
include/exec/cpu-common.h | 2 --
monitor/qmp-cmds.c | 3 ++-
softmmu/vl.c
Just like -incoming. Later we will add support for "-incoming defer
-preconfig", because there are cases (Xen, block layer) that want
to look at RUNSTATE_INMIGRATE. -loadvm will remain mutually exclusive
with preconfig; the plan is to just do loadvm in the monitor, since
the user is already going
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
hw/core/machine.c | 1 +
softmmu/vl.c | 78 +++
2 files changed, 40 insertions(+), 39 deletions(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 5260155962..7ef3de5ce5 100644
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
include/sysemu/sysemu.h | 2 +
softmmu/meson.build | 1 +
softmmu/rtc.c | 190
softmmu/vl.c| 156 -
4 files changed, 193 insertions(+
Use the machine properties instead.
Cc: Alistair Francis
Signed-off-by: Paolo Bonzini
---
hw/riscv/boot.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
index 9b3fe3fb1e..70a9bf8f5d 100644
--- a/hw/riscv/boot.c
+++ b/hw/riscv/boot.c
@@
Various options affect the global state of QEMU including the rest of
qemu_init, and they need to be called very early. Group them together
in a function that is called at the beginning.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 200
Use the machine properties instead.
Cc: qemu-...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/ppc/prep.c | 2 +-
hw/ppc/spapr_vio.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index c6b9d1ddcb..7e72f6e4a9 100644
--- a/hw/ppc/prep.
Complement the previous patch by starting the VM with a QMP command.
The plan is that the user will be able to do the same, invoking two
commands "finish-machine-init" and "cont" instead of
"x-exit-preconfig".
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 3 ++-
1 f
They are going to be deprecated, avoid warnings on stdout while the
tests run.
Signed-off-by: Paolo Bonzini
---
docs/specs/tpm.rst | 2 +-
python/qemu/machine.py | 2 +-
qemu-options.hx | 32 ++--
tests/qtest/bios-tab
qemu_opts_set is used to create default network backends and to
parse sugar options -kernel, -initrd, -append, -bios and -dtb.
These are very different uses:
I would *expect* a function named qemu_opts_set to set an option in a
merge-lists QemuOptsList, such as -kernel, and possibly to set an opti
Keep the machine initialization sequence free of miscellaneous command
line parsing actions.
The only difference is that preallocation will always be done with one
thread if -smp is not provided; previously it was using mc->default_cpus,
which is almost always 1 anyway.
Reviewed-by: Igor Mammedov
From: Philippe Mathieu-Daudé
Since commit 5ec3a23e6c8 ("serial: convert PIO to new memory
api read/write") we don't need to worry about accesses bigger
than 8-bit. Use the extract()/deposit() functions to access
the correct part of the 16-bit 'divider' register.
Reported-by: Jonathan D. Belanger
From: André Almeida
Subroutine dump_struct uses type attributes to check if the struct
syntax is valid. Then, it removes all attributes before using it for
output. `cacheline_aligned_in_smp` is an attribute that is
not included in both steps. Add it, since it is used by kernel structs.
Signe
"Late" backends are created after the machine.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 64 ++--
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index aafcbec356..d9fe9f
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 216 +++
1 file changed, 114 insertions(+), 102 deletions(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index cb4b870f09..1a80a9a68d 100644
--- a/softmmu/vl.c
+++ b/softmmu/v
From: "Alexander A. Klimov"
Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.
Deterministic algorithm:
For each file:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`
Displays should be available before the monitor starts, so that
it is possible to use the graphical console to interact with
the monitor itself.
This patch is quite ugly, but all this is temporary. The double
call to qemu_init_displays will go away as soon we can unify machine
initialization betw
There is no need to load plugins in the middle of default device processing,
move -plugin handling just before preconfig is entered.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 12 ++--
1 file changed, 6 insertions(+),
This reverts commit 92bb29f9b2c3d4a98eef5f0db935d4be291eec72.
We will replace the commit with the fix from Linux.
Signed-off-by: Paolo Bonzini
Message-Id: <20201117165312.118257-15-pbonz...@redhat.com>
Signed-off-by: Paolo Bonzini
---
scripts/kernel-doc | 18 +-
1 file changed,
The final part of qemu_init, starting with the completion of
board init, is already relatively clean. Split it out of
qemu_init so that qemu_init keeps only the messy parts.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 249 +++--
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 113 +++
1 file changed, 60 insertions(+), 53 deletions(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index d9fe9f63c0..5af52454ee 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.
Move CHECKPOINT_INIT right before the machine initialization is
completed. Everything before is essentially an extension of
command line parsing.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
hw/core/machine.c | 5 +
softmmu/vl.c | 5
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 81 +---
1 file changed, 45 insertions(+), 36 deletions(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 5af52454ee..acf09b2040 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -2704,6 +2704,49 @@ sta
Preserve bisectability while we update scripts/kernel-doc from Linux.
Without this patch, building with Sphinx 3 would break while we
revert our own Sphinx 3 support and replace it with Linux's.
Suggested-by: Peter Maydell
Signed-off-by: Paolo Bonzini
---
docs/sphinx/kerneldoc.py | 3 +++
1 fil
This reverts commit 152d1967f650f67b7ece3a5dda77d48069d72647.
We will replace the commit with the fix from Linux.
Signed-off-by: Paolo Bonzini
Message-Id: <20201117165312.118257-16-pbonz...@redhat.com>
Signed-off-by: Paolo Bonzini
---
docs/sphinx/kerneldoc.py | 1 -
scripts/kernel-doc |
Make qemu_start_incoming_migration local to migration/migration.c.
By using the runstate instead of a separate flag, vl need not do
anything to setup deferred incoming migration.
qmp_migrate_incoming also does not need the deferred_incoming flag
anymore, because "-incoming PROTOCOL" will clear the
From: Mauro Carvalho Chehab
Some typedef expressions are output as normal functions.
As we need to be clearer about the type with Sphinx 3.x,
detect such cases.
While here, fix a wrongly-indented block.
Signed-off-by: Mauro Carvalho Chehab
Signed-off-by: Paolo Bonzini
Message-Id: <2020111716
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
hw/alpha/dp264.c| 1 +
hw/arm/boot.c | 1 +
hw/arm/digic_boards.c | 1 +
hw/arm/highbank.c | 1 +
hw/arm/npcm7xx_boards.c | 1 +
hw/arm/sbsa-ref.c | 1 +
hw/arm/vexpress.c | 1 +
hw/ar
serial_hd(i) is NULL if and only if i >= serial_max_hds(). Test
serial_hd(i) instead of bounding the loop at serial_max_hds(),
thus removing one more function that vl.c is expected to export.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
hw/ppc/spapr.c | 6 ++
includ
From: Mauro Carvalho Chehab
The __ETHTOOL_DECLARE_LINK_MODE_MASK macro is a variant of
DECLARE_BITMAP(), used by phylink.h. As we have already a
parser for DECLARE_BITMAP(), let's add one for this macro,
in order to avoid such warnings:
./include/linux/phylink.h:54: warning: Function par
From: Mauro Carvalho Chehab
When kernel-doc is called via kerneldoc.py, there's no need to
auto-detect the Sphinx version, as the Sphinx module already
knows it. So, add an optional parameter to allow changing the
Sphinx dialect.
As kernel-doc can also be manually called, keep the auto-detection
Combine the RUN_STATE_PRECONFIG and cmd_can_preconfig checks
into a single function, to avoid repeating the same expression
(or its negation after applying DeMorgan's rule) over and
over again.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
monitor/hmp.c | 18 ++
1
From: Pierre-Louis Bossart
The kbuild bot recently added the W=1 option, which triggered
documentation cleanups to squelch hundreds of kernel-doc warnings.
To make sure new kernel contributions don't add regressions to
kernel-doc descriptors, this patch suggests an option to treat
warnings as er
From: Mauro Carvalho Chehab
The pattern @foo->bar() is valid, as it can be used by a
function pointer inside a struct passed as a parameter.
Right now, it causes a warning:
./drivers/firewire/core-transaction.c:606: WARNING: Inline strong
start-string without end-string.
In this speci
From: André Almeida
The current regular expression for strip attributes of structs (and
for nested ones as well) also removes all whitespaces that may
surround the attribute. After that, the code will split structs and
iterate for each symbol separated by comma at the end of struct
definition (e.
From: Mauro Carvalho Chehab
Address several issues related to pointing to the wrong line
number:
1) ensure that line numbers will always be initialized
When section is the default (Description), the line number
is not initializing, producing this:
$ ./scripts/kernel-doc --enable-
From: Mauro Carvalho Chehab
The PHY kernel-doc markup has gained support for documenting
a typedef enum.
However, right now the parser was not prepared for it.
So, add support for parsing it.
Fixes: 4069a572d423 ("net: phy: Document core PHY structures")
Signed-off-by: Mauro Carvalho Chehab
S
We want to make it independent of QemuOpts.
Signed-off-by: Paolo Bonzini
Signed-off-by: Paolo Bonzini
---
include/qemu/config-file.h | 1 -
softmmu/vl.c | 33 +
util/qemu-config.c | 33 -
3 files changed, 33
A comment in kernel-doc mentions QEMU's qatomic_set macro, but since
this code originated in Linux we should just revert it and stay as close
to the kernel's copy of the script as possible.
The change was introduced (more or less unintentionally) in QEMU commit
commit d73415a31547, which did a glo
From: Mauro Carvalho Chehab
This should solve bad error reports like this one:
./include/linux/iio/iio.h:0: WARNING: Unknown target name: "devm".
Signed-off-by: Mauro Carvalho Chehab
Link:
https://lore.kernel.org/r/56eed0ba50cd726236acd12b11b55ce54854c5ea.1599660067.git.mchehab+hua...
From: Mauro Carvalho Chehab
Sphinx is very pedantic with respect to blank lines. Sometimes,
in order to make it to properly handle something, we need to
add a blank line. However, currently, any blank line inside a
kernel-doc comment like:
/*
* @foo: bar
*
*
From: Jonathan Neuschäfer
Currently, when kernel-doc encounters a macro with a named variable
argument[1], such as this:
#define hlist_for_each_entry_rcu(pos, head, member, cond...)
... it expects the variable argument to be documented as `cond...`,
rather than `cond`. This is semantically w
Move post-preconfig initialization to the x-exit-preconfig. If preconfig
is not requested, just exit preconfig mode immediately with the QMP
command.
As a result, the preconfig loop will run with accel_setup_post
and os_setup_post restrictions (xen_restrict, chroot, etc.)
already done.
Signed-of
From: Jonathan Cameron
Subroutine dump_struct uses type attributes to check if the struct
syntax is valid. Then, it removes all attributes before using it for
output. `cacheline_aligned` is an attribute that is
not included in both steps. Add it, since it is used by kernel structs.
Based on
From: Mauro Carvalho Chehab
On a few places, it sometimes need to indicate a negation of a
parameter, like:
!@fshared
This pattern happens, for example, at:
kernel/futex.c
and it is perfectly valid. However, kernel-doc currently
transforms it into:
!**fshared**
This
From: Mauro Carvalho Chehab
Unfortunately, Sphinx 3.x parser for c functions is too pedantic:
https://github.com/sphinx-doc/sphinx/issues/8241
While it could be relaxed with some configurations, there are
several corner cases that it would make it hard to maintain,
and will require teac
From: Mauro Carvalho Chehab
Right now, the build system doesn't use -nofunction, as
it is pretty much useless, because it doesn't consider
the other output modes (extern, internal), working only
with all.
Also, it is limited to exclude functions.
Re-implement it in order to allow excluding any
Machine options can be retrieved as properties of the machine object.
Encourage that by removing the "easy" accessor to machine options.
Signed-off-by: Paolo Bonzini
---
accel/kvm/kvm-all.c | 11 ---
hw/arm/boot.c | 2 +-
hw/microblaze/boot.c| 9 -
hw/nios2/bo
From: Mauro Carvalho Chehab
There are a few namespace clashes by using c:macro everywhere:
basically, when using it, we can't have something like:
.. c:struct:: pwm_capture
.. c:macro:: pwm_capture
So, we need to use, instead:
.. c:function:: int pwm_capture (struct p
From: Mauro Carvalho Chehab
There are some function pointer prototypes inside the net
includes, like this one:
int (*pcs_config)(struct phylink_config *config, unsigned int mode,
phy_interface_t interface, const unsigned long
*advertising);
There's nothing wro
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
hw/core/machine.c | 2 ++
include/exec/cpu-common.h | 3 ++
include/exec/exec-all.h | 3 --
softmmu/globals.c | 74 +++
softmmu/meson.build | 1 +
softmmu/vl.c
From: Mauro Carvalho Chehab
The include/linux/genalloc.h file defined this typedef:
typedef unsigned long (*genpool_algo_t)(unsigned long *map,unsigned
long size,unsigned long start,unsigned int nr,void *data, struct gen_pool
*pool, unsigned long start_addr);
Because it has a type com
From: Mauro Carvalho Chehab
There's currently a bug with the way kernel-doc script
counts line numbers that can be seen with:
$ ./scripts/kernel-doc -rst -enable-lineno include/linux/math64.h >all
&& ./scripts/kernel-doc -rst -internal -enable-lineno include/linux/math64.h
>int && dif
From: Mauro Carvalho Chehab
With Sphinx 3.x, the ".. c:type:" tag was changed to accept either:
.. c:type:: typedef-like declaration
.. c:type:: name
Using it for other types (including functions) don't work anymore.
So, there are newer tags for macro, enum, struct, union, and
This reverts commit 19ab6044be0c55d529e875e3ee16fdd5c3b54d33.
We will replace the commit with the fix from Linux.
Signed-off-by: Paolo Bonzini
Message-Id: <20201117165312.118257-27-pbonz...@redhat.com>
Signed-off-by: Paolo Bonzini
---
scripts/kernel-doc | 4 ++--
1 file changed, 2 insertions(+)
From: Mauro Carvalho Chehab
Sphinx C domain code after 3.2.1 will start complaning if :c:struct
would be used for an union type:
.../Documentation/gpu/drm-kms-helpers:352: ../drivers/video/hdmi.c:851:
WARNING: C 'identifier' cross-reference uses wrong tag: reference name is
'union hdmi
This reverts commit fd68a72875cf318f4310726f842139119c5f45d5. We're
done with the update of kernel-doc and we can restore kernel-doc's
functionality.
Signed-off-by: Paolo Bonzini
Signed-off-by: Paolo Bonzini
---
docs/sphinx/kerneldoc.py | 3 ---
1 file changed, 3 deletions(-)
diff --git a/do
This reverts commit 3cd3c5193cde5242e243c25759f85802e267994f.
We will replace the commit with the fix from Linux.
Signed-off-by: Paolo Bonzini
Message-Id: <20201117165312.118257-26-pbonz...@redhat.com>
Signed-off-by: Paolo Bonzini
---
scripts/kernel-doc | 2 +-
1 file changed, 1 insertion(+), 1
The default RAM size is 0, so no RAM will be created anyway.
Signed-off-by: Paolo Bonzini
---
hw/core/null-machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/null-machine.c b/hw/core/null-machine.c
index 7e693523d7..c40badf5bc 100644
--- a/hw/core/null-machine.
From: Mauro Carvalho Chehab
While kernel-doc needs to parse parameters in order to
identify its name, it shouldn't be touching the type,
as parsing it is very difficult, and errors happen.
One current error is when parsing this parameter:
const u32 (*tab)[256]
Found at ./lib/crc32.c, o
From: Mauro Carvalho Chehab
The typedef regex for function prototypes are very complex.
Split them into 3 separate regex and then join them using
qr.
Signed-off-by: Mauro Carvalho Chehab
Link:
https://lore.kernel.org/r/3a4af999a0d62d4ab9dfae1cdefdfcad93383356.1603792384.git.mchehab+hua...@kern
Compute the DIRTY_MEMORY_CODE bit in memory_region_get_dirty_log_mask
instead of memory_region_init_*. This makes it possible to allocate
memory backend objects at any time.
Signed-off-by: Paolo Bonzini
---
softmmu/memory.c | 12 ++--
softmmu/vl.c | 6 +-
2 files changed, 7 ins
> -Original Message-
> From: Eduardo Habkost
> Sent: Wednesday, December 2, 2020 5:12 AM
> To: Kang, Luwei
> Cc: pbonz...@redhat.com; r...@twiddle.net; qemu-devel@nongnu.org
> Subject: Re: [PATCH 1/2] i386/cpu: Add the Intel PT capabilities checking
> before
> extend the CPUID level
>
>
These are the patches that needed another review, had some conflicts,
or were not quite ready for the previous posting.
Highlights include:
- fixing the HMP prompt for -preconfig
- enabling the qtest server with -object instead of -qtest
- decoupling target machine code from QemuOpts
Based-on:
The preconfig state is only used if -incoming is not specified, which
makes the RunState state machine more tricky than it need be. However
there is already an equivalent condition which works even with -incoming,
namely qdev_hotplug. Use it instead of a separate runstate.
Signed-off-by: Paolo B
Signed-off-by: Paolo Bonzini
---
hmp-commands.hx | 1 +
qapi/control.json | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index ff2d7aa8f3..d192afa652 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -45,6 +45,7 @@ ERST
.par
Now that there is no RUN_STATE_PRECONFIG anymore that can conflict with
RUN_STATE_INMIGRATE, we can allow -incoming defer with -preconfig.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/softmmu/vl
This series switches -object, -M and -accel from QemuOpts to keyval.
Monitor commands device_add and netdev_add are also switched to keyval,
though -device and -netdev for now are not.
Along the way, the syntax of keyval and QemuOpts becomes more consistent
and support for keyval-based options is
machine_init_done is not the right flag to check when preconfig
is taken into account; for example "./qemu-system-x86_64 -serial
mon:stdio -preconfig" does not print the QEMU monitor header until after
exit_preconfig. Add back a custom bool for mux character devices. This
partially undoes commit
qdev_machine_creation_done is only setting a flag now. Extend it to
move more code out of vl.c. Leave only consistency checks and gdbserver
processing in qemu_machine_creation_done.
gdbserver_start can be moved after qdev_machine_creation_done because
it only does listen on the socket and create
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
include/sysemu/sysemu.h | 3 +
softmmu/meson.build | 1 +
softmmu/runstate.c | 800
softmmu/vl.c| 752 +
4 files changed, 805 insertio
On 12/1/20 11:35 AM, Paolo Bonzini wrote:
> A comment in kernel-doc mentions QEMU's qatomic_set macro, but since
> this code originated in Linux we should just revert it and stay as close
> to the kernel's copy of the script as possible.
>
> The change was introduced (more or less unintentionally)
Looking at all merge-lists QemuOptsList, here is how they access their
QemuOpts:
reopen_opts in qemu-io-cmds.c ("qemu-img reopen -o")
qemu_opts_find(&reopen_opts, NULL)
empty_opts in qemu-io.c ("qemu-io open -o")
qemu_opts_find(&empty_opts, NULL)
qemu_rtc_opts ("-rtc")
qe
This is needed for SPAPR which has different defaults than everyone else.
Right now it looks at the -machine QemuOpts, but those will go away.
Signed-off-by: Paolo Bonzini
---
hw/core/machine.c | 1 +
include/hw/mem/nvdimm.h | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --g
Right now, help options are parsed normally and then checked
specially in opt_validate, but only if coming from
qemu_opts_parse_noisily. has_help_option does the check on its own.
opt_validate() has two callers: qemu_opt_set(), which passes null and is
therefore unaffected, and opts_do_parse(), w
A QemuOptsList can be of one of two kinds: either it is pre-validated, or
it accepts any key and validation happens somewhere else (typically in
a Visitor or against a list of QOM properties). opts_accepts_any
returns true if a QemuOpts instance was created from a QemuOptsList of
the latter kind,
qemu_finish_machine_init currently can only exit QEMU if it fails.
Prepare for giving it proper error propagation, and possibly for
adding a plugin_add monitor command that calls an accelerator
method.
While at it, make all errors from plugin_load look the same.
Signed-off-by: Paolo Bonzini
---
Generalize the qdev_hotplug variable to the different phases of
machine initialization. We would like to allow different
monitor commands depending on the phase.
Signed-off-by: Paolo Bonzini
---
hw/core/machine-qmp-cmds.c | 6 +++---
hw/core/machine.c | 8 +++-
hw/core/qdev.c
The qtest server right now can only be created using the -qtest
and -qtest-log options. Allow an alternative way to create it
using "-object qtest,chardev=...,log=...".
Signed-off-by: Paolo Bonzini
---
softmmu/qtest.c | 144
softmmu/vl.c| 5
Switch from QemuOpts to keyval. This enables compound options
for accelerators.
Signed-off-by: Paolo Bonzini
---
accel/accel.c | 6 ++
include/sysemu/accel.h | 1 +
softmmu/vl.c | 134 ++---
3 files changed, 67 insertions(+), 74 deletio
This is used with the weirdly-named device "SUNFD,fdtwo":
$ qemu-system-sparc -device SUNW,,fdtwo,help
SUNW,fdtwo options:
drive=- Node name or ID of a block device to use as a
backend
fallback= - FDC drive type, 144/288/120/none/auto (default:
"144")
...
Therefore,
Like -set and -readconfig, it would not really be too hard to
extend -writeconfig to parsing mechanisms other than QemuOpts.
However, the uses of -writeconfig are substantially more
limited, as it is generally easier to write the configuration
by hand in the first place. In addition, -writeconfig
> -Original Message-
> From: Qemu-devel
> [mailto:qemu-devel-bounces+kuhn.chenqun=huawei@nongnu.org] On
> Behalf Of Luká? Doktor
> Sent: Thursday, November 26, 2020 4:10 PM
> To: QEMU Developers
> Cc: Charles Shih ; Aleksandar Markovic
> ; Stefan Hajnoczi
>
> Subject: Proposal for a r
Now that the key is NULL terminated, we can remove some of the contortions
that were done to operate on possibly '='-terminated strings in
keyval_parse_one.
Signed-off-by: Paolo Bonzini
---
util/keyval.c | 27 ++-
1 file changed, 10 insertions(+), 17 deletions(-)
diff --
Enable creation of object with non-scalar properties.
Signed-off-by: Paolo Bonzini
---
qemu-io.c | 42 +-
1 file changed, 13 insertions(+), 29 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index ac88d8bd40..306086f767 100644
--- a/qemu-io.c
+++ b/qemu-i
> On Tue, Dec 01, 2020 at 01:06:35PM +0100, Lukáš Doktor wrote:
> > Dne 01. 12. 20 v 11:22 Stefan Hajnoczi napsal(a):
> > > On Tue, Dec 01, 2020 at 09:05:49AM +0100, Lukáš Doktor wrote:
> > > > Dne 30. 11. 20 v 14:25 Stefan Hajnoczi napsal(a):
> > > > > On Thu, Nov 26, 2020 at 09:10:14AM +0100, Luk
101 - 200 of 406 matches
Mail list logo
