Re: [PATCH v2 1/1] Fix to show vfio migration stat in migration status

2020-12-02 Thread Alex Williamson
On Wed, 2 Dec 2020 00:43:14 +0530 Kirti Wankhede wrote: > Header file where CONFIG_VFIO is defined is not included in migration.c > file. > > Moved populate_vfio_info() to hw/vfio/common.c file. Added its stub in > stubs/vfio.c file. Updated header files and meson file accordingly. > > Fixes: 3

Re: [PATCH v3 00/10] hvf: Implement Apple Silicon Support

2020-12-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201202190408.2041-1-ag...@csgraf.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201202190408.2041-1-ag...@csgraf.de Subject: [PATCH v3 00/10] hvf: Implement Apple Silicon Su

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Eduardo Habkost
On Wed, Dec 02, 2020 at 06:35:06PM +0100, Kevin Wolf wrote: > Am 02.12.2020 um 17:05 hat Eduardo Habkost geschrieben: > > > > Looks nice as end goal. Then, these are a few questions I would > > > > have about the transition plan: > > > > > > > > Would it require changing both device implementatio

Re: [PATCH] hw/block: m25p80: Fix fast read for SST flashes

2020-12-02 Thread Alistair Francis
On Sun, Nov 29, 2020 at 6:55 PM Bin Meng wrote: > > From: Bin Meng > > SST flashes require a dummy byte after the address bits. > > Signed-off-by: Bin Meng I couldn't find a datasheet that says this... But the actual code change looks fine, so: Acked-by: Alistair Francis Alistair > --- > >

Re: [PATCH] docs: set CONFDIR when running sphinx

2020-12-02 Thread Eduardo Habkost
On Wed, Dec 02, 2020 at 10:05:50AM +0100, Paolo Bonzini wrote: > On 01/12/20 19:37, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > The default configuration path /etc/qemu can be overriden with configure > > options, and the generated documentation used to reflect it. > >

Re: [DISCUSSION] How to set properties of non-pluggable devices?

2020-12-02 Thread BALATON Zoltan via
Hello, On Wed, 2 Dec 2020, Doug Evans wrote: Hi. Suppose I want to set a property of a non-pluggable device that cannot be set after the device has been realized (e.g., I can't use qmp to set the property after QEMU has started). Being non-pluggable means I can't use "-device foo,bar=baz" on th

Re: [PATCH v3 3/3] arm/hvf: Add a WFI handler

2020-12-02 Thread Peter Collingbourne
On Wed, Dec 2, 2020 at 10:49 AM Alexander Graf wrote: > > > On 02.12.20 05:44, Peter Collingbourne wrote: > > Sleep on WFI until the VTIMER is due but allow ourselves to be woken > > up on IPI. > > > > Signed-off-by: Peter Collingbourne > > --- > > v3: > > - move the simplified locking to a separ

[PATCH-for-5.2? 1/1] Acceptance tests: bump Fedora to 32

2020-12-02 Thread Cleber Rosa
Currently in use Fedora 31 has been moved out of the standard download locations that are supported by the functionality provided by avocado.utils.vmimage. So right now, the boot_linux.py tests will get canceled by not being able to find those specific images. Ideally, this would be bumped to ver

[PATCH-for-5.2? 0/1] Acceptance tests: bump Fedora to 32

2020-12-02 Thread Cleber Rosa
I believe this may be a candidate for "right now" because the code changes here simply sync with external infrastructure changes, that is, the retirement of Fedora 31 from the official repository locations). The following jobs contain a validation of this bump: - https://gitlab.com/cleber.gnu/qe

[PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Frank Yang
>From downstream: https://android-review.googlesource.com/c/platform/external/qemu/+/1515002 Based on v3 of Alexander Graf's patches https://patchew.org/QEMU/20201202190408.2041-1-ag...@csgraf.de We need to adjust CNTVOFF_EL2 so that time doesnt warp. Even though we can set separate CNTVOFF_EL2

Re: [PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Frank Yang
We've gotten the Android Emulator snapshots working again on M1 and noticed a time warp issue where the stopwatch app would, on a snapshot load, resume including the time the emulator wasn't running. This seems to fix it. Now we have snapshots mostly working (though file backed ram is a bit busted,

Re: [PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Alexander Graf
On 02.12.20 23:19, Frank Yang wrote: From downstream: https://android-review.googlesource.com/c/platform/external/qemu/+/1515002 Based on v3 of Alexander Graf's patches https://patchew.org/QEMU/20201202190408.2041

Re: [PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Frank Yang
On Wed, Dec 2, 2020 at 2:28 PM Alexander Graf wrote: > > On 02.12.20 23:19, Frank Yang wrote: > > > From downstream: > https://android-review.googlesource.com/c/platform/external/qemu/+/1515002 > > Based on v3 of Alexander Graf's patches > > https://patchew.org/QEMU/20201202190408.2041-1-ag...@cs

Re: [PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Alexander Graf
On 02.12.20 23:46, Frank Yang wrote: On Wed, Dec 2, 2020 at 2:28 PM Alexander Graf > wrote: On 02.12.20 23:19, Frank Yang wrote: From downstream: https://android-review.googlesource.com/c/platform/external/qemu/+/1515002

Re: [PATCH] hw/block: m25p80: Fix fast read for SST flashes

2020-12-02 Thread Bin Meng
Hi Alistair, On Thu, Dec 3, 2020 at 3:52 AM Alistair Francis wrote: > > On Sun, Nov 29, 2020 at 6:55 PM Bin Meng wrote: > > > > From: Bin Meng > > > > SST flashes require a dummy byte after the address bits. > > > > Signed-off-by: Bin Meng > > I couldn't find a datasheet that says this... But

Re: [PATCH] hw/block: m25p80: Fix fast read for SST flashes

2020-12-02 Thread Alistair Francis
On Wed, Dec 2, 2020 at 3:09 PM Bin Meng wrote: > > Hi Alistair, > > On Thu, Dec 3, 2020 at 3:52 AM Alistair Francis wrote: > > > > On Sun, Nov 29, 2020 at 6:55 PM Bin Meng wrote: > > > > > > From: Bin Meng > > > > > > SST flashes require a dummy byte after the address bits. > > > > > > Signed-o

Re: [PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Frank Yang
On Wed, Dec 2, 2020 at 2:57 PM Alexander Graf wrote: > > On 02.12.20 23:46, Frank Yang wrote: > > > > On Wed, Dec 2, 2020 at 2:28 PM Alexander Graf wrote: > >> >> On 02.12.20 23:19, Frank Yang wrote: >> >> >> From downstream: >> https://android-review.googlesource.com/c/platform/external/qemu/+/

Re: [PATCH v1 1/9] memory: Introduce RamDiscardMgr for RAM memory regions

2020-12-02 Thread Alex Williamson
On Thu, 19 Nov 2020 16:39:10 +0100 David Hildenbrand wrote: > We have some special RAM memory regions (managed by virtio-mem), whereby > the guest agreed to only use selected memory ranges. "unused" parts are > discarded so they won't consume memory - to logically unplug these memory > ranges. Be

Re: [PATCH v1 4/9] vfio: Support for RamDiscardMgr in the !vIOMMU case

2020-12-02 Thread Alex Williamson
On Thu, 19 Nov 2020 16:39:13 +0100 David Hildenbrand wrote: > Implement support for RamDiscardMgr, to prepare for virtio-mem > support. Instead of mapping the whole memory section, we only map > "populated" parts and update the mapping when notified about > discarding/population of memory via the

Re: [PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Peter Collingbourne
On Wed, Dec 2, 2020 at 2:57 PM Alexander Graf wrote: > > > On 02.12.20 23:46, Frank Yang wrote: > > > > On Wed, Dec 2, 2020 at 2:28 PM Alexander Graf wrote: >> >> >> On 02.12.20 23:19, Frank Yang wrote: >> >> >> From downstream: >> https://android-review.googlesource.com/c/platform/external/qemu

Re: [PATCH v3 01/10] hvf: Add hypervisor entitlement to output binaries

2020-12-02 Thread Roman Bolshakov
On Wed, Dec 02, 2020 at 08:03:59PM +0100, Alexander Graf wrote: > In macOS 11, QEMU only gets access to Hypervisor.framework if it has the > respective entitlement. Add an entitlement template and automatically self > sign and apply the entitlement in the build. > > Signed-off-by: Alexander Graf

Re: [PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Peter Collingbourne
On Wed, Dec 2, 2020 at 3:26 PM Frank Yang wrote: > > > > On Wed, Dec 2, 2020 at 2:57 PM Alexander Graf wrote: >> >> >> On 02.12.20 23:46, Frank Yang wrote: >> >> >> >> On Wed, Dec 2, 2020 at 2:28 PM Alexander Graf wrote: >>> >>> >>> On 02.12.20 23:19, Frank Yang wrote: >>> >>> >>> From downstrea

Re: [PATCH for-6.0 v2 1/3] spapr: Improve naming of some vCPU id related items

2020-12-02 Thread David Gibson
On Mon, Nov 30, 2020 at 05:52:56PM +0100, Greg Kurz wrote: > The machine tells the IC backend the number of vCPU ids it will be > exposed to, in order to: > - fill the "ibm,interrupt-server-ranges" property in the DT (XICS) > - size the VP block used by the in-kernel chip (XICS-on-XIVE, XIVE) > >

Re: [PATCH v3 02/10] hvf: Move common code out

2020-12-02 Thread Roman Bolshakov
On Wed, Dec 02, 2020 at 08:04:00PM +0100, Alexander Graf wrote: > Until now, Hypervisor.framework has only been available on x86_64 systems. > With Apple Silicon shipping now, it extends its reach to aarch64. To > prepare for support for multiple architectures, let's move common code out > into its

Re: [PATCH v3 03/10] hvf: Introduce hvf vcpu struct

2020-12-02 Thread Roman Bolshakov
On Wed, Dec 02, 2020 at 08:04:01PM +0100, Alexander Graf wrote: > We will need more than a single field for hvf going forward. To keep > the global vcpu struct uncluttered, let's allocate a special hvf vcpu > struct, similar to how hax does it. > Reviewed-by: Roman Bolshakov Tested-by: Roman Bol

Re: [PATCH v3 04/10] arm: Set PSCI to 0.2 for HVF

2020-12-02 Thread Roman Bolshakov
On Wed, Dec 02, 2020 at 08:04:02PM +0100, Alexander Graf wrote: > In Hypervisor.framework, we just pass PSCI calls straight on to the QEMU > emulation > of it. That means, if TCG is compatible with PSCI 0.2, so are we. Let's > transpose > that fact in code too. > > Signed-off-by: Alexander Graf

Re: [PATCH v3 05/10] hvf: arm: Mark CPU as dirty on reset

2020-12-02 Thread Roman Bolshakov
On Wed, Dec 02, 2020 at 08:04:03PM +0100, Alexander Graf wrote: > When clearing internal state of a CPU, we should also make sure that HVF > knows about it and can push the new values down to vcpu state. > I'm sorry if I'm asking something dumb. But isn't cpu_synchronize_all_post_reset() is suppo

Re: [PATCH] xive: Add more trace events

2020-12-02 Thread David Gibson
On Fri, Nov 27, 2020 at 02:36:54PM +0100, Cédric Le Goater wrote: > These are useful to understand IRQ requests from the OS. > > Signed-off-by: Cédric Le Goater > --- > > David, Feel free to merge with the previous. Done, thanks. > > hw/intc/spapr_xive.c | 6 ++ > hw/intc/spapr_xive_

Re: [PATCH for-6.0] hw/ppc: Do not re-read the clock on pre_save if doing savevm

2020-12-02 Thread David Gibson
On Wed, Dec 02, 2020 at 06:28:26PM +0100, Greg Kurz wrote: > A guest with enough RAM, eg. 128G, is likely to detect savevm downtime > and to complain about stalled CPUs. This happens because we re-read > the timebase just before migrating it and we thus don't account for > all the time between VM s

Re: [PATCH v10 0/9] pci_expander_brdige:acpi: Support pxb-pcie for ARM

2020-12-02 Thread Jiahui Cen
Hi Michael, On 2020/12/2 17:53, Michael S. Tsirkin wrote: > On Thu, Nov 19, 2020 at 09:48:32AM +0800, Jiahui Cen wrote: >> Changes with v9 >> v9->v10: >> Refactor patch2 to drop useless macros and variables. >> Split patch2 into two patches. > > I tagged this for after the release. To help make s

[Bug 1906156] Re: Host OS Reboot Required, for Guest kext to Load (Fully)

2020-12-02 Thread Russell Morris
Sorry for the delay on updating this - but pulling my hair out (and I'm short enough of that already ... LOL). I can't get Ubuntu to let me run the custom qemu executable. Really is looking like apparmor. Fighting with that, but struggling to have it let me run it :-(. Thanks. -- You received th

Re: [PATCH] scsi: allow user to set werror as report

2020-12-02 Thread Zihao Chang
Ping? This is a fix patch which has been reviewed, whose tree should it go via? Thanks Zihao On 2020/11/3 22:03, Zihao Chang wrote: > > > On 2020/11/3 18:52, Fam Zheng wrote: >> On Tue, 2020-11-03 at 14:12 +0800, Zihao Chang wrote: >>> 'enospc' is the default for -drive, but qemu allows user to

Re: [PATCH v3 6/6] linux-user: Add support for MIPS Loongson 2F/3E

2020-12-02 Thread chen huacai
Hi, Philippe, On Wed, Dec 2, 2020 at 5:16 PM Philippe Mathieu-Daudé wrote: > > On 12/2/20 2:01 AM, chen huacai wrote: > > Hi, Philippe, > > > > On Wed, Dec 2, 2020 at 3:31 AM Philippe Mathieu-Daudé > > wrote: > >> > >> Userland ELF binaries using Longsoon SIMD instructions have the > >> HWCAP_L

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread Stefano Stabellini
On Wed, 2 Dec 2020, Daniel P. Berrangé wrote: > On Mon, Nov 30, 2020 at 07:19:07PM +0530, P J P wrote: > > From: Prasad J Pandit > > > > We are about to introduce a qemu-security mailing list to report > > and triage QEMU security issues. > > > > Update the QEMU security process web page with ne

Re: [PATCH 0/9] target/mips: Simplify MSA TCG logic

2020-12-02 Thread Jiaxun Yang
在 2020/12/3 上午2:44, Philippe Mathieu-Daudé 写道: I converted MSA opcodes to decodetree. To keep the series small I split it in 2, this is the non-decodetree specific patches (so non-decodetree experts can review it ;) ). First we stop using env->insn_flags to check for MSAi presence, then we re

Re: [PATCH v2] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD

2020-12-02 Thread AL Yu-Chen Cho
On Mon, 2020-11-30 at 10:14 +0100, Philippe Mathieu-Daudé wrote: > On 11/30/20 5:26 AM, Cho, Yu-Chen wrote: > > v2: > > Drop some package from dockerfile to make docker image more light. > > > > v1: > > Add build-system-opensuse jobs and opensuse-leap.docker dockerfile. > > Use openSUSE Leap 15.2

Re: [PATCH 0/9] target/mips: Simplify MSA TCG logic

2020-12-02 Thread Jiaxun Yang
在 2020/12/3 上午2:44, Philippe Mathieu-Daudé 写道: I converted MSA opcodes to decodetree. To keep the series small I split it in 2, this is the non-decodetree specific patches (so non-decodetree experts can review it ;) ). First we stop using env->insn_flags to check for MSAi presence, then we re

[Bug 1906516] Re: [RISCV] sfence.vma need to end the translation block

2020-12-02 Thread jinyan
** Description changed: QEMU emulator version 5.0.0 sfence.vma will flush the tlb, so after this instruction, the translation block should be end. The following code will only work in single step mode: ``` relocate: - li a0, OFFSET +  li a0, OFFSET - la t0, 1f - ad

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread P J P
+-- On Wed, 2 Dec 2020, Philippe Mathieu-Daudé wrote --+ | Maybe: | | 0) **Acknowledge reception** |- A non-automated response email is sent to acknowledge the | reception of the request. | This is the starting date for the maximum **60 days** required | to

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread P J P
Hello Dan, +-- On Wed, 2 Dec 2020, Daniel P. Berrangé wrote --+ | > +- If issue is found to be less severe, an upstream public bug (or an | > + issue) will be created immediately. | | No need to repeat "or an issue". I think it would read more clearly as | |- If the severity of t

Re: [PATCH v3 06/10] hvf: Add Apple Silicon support

2020-12-02 Thread Roman Bolshakov
On Wed, Dec 02, 2020 at 08:04:04PM +0100, Alexander Graf wrote: > With Apple Silicon available to the masses, it's a good time to add support > for driving its virtualization extensions from QEMU. > > This patch adds all necessary architecture specific code to get basic VMs > working. It's still p

Re: [PATCH v3 07/10] arm: Add Hypervisor.framework build target

2020-12-02 Thread Roman Bolshakov
On Wed, Dec 02, 2020 at 08:04:05PM +0100, Alexander Graf wrote: > Now that we have all logic in place that we need to handle > Hypervisor.framework > on Apple Silicon systems, let's add CONFIG_HVF for aarch64 as well so that we > can build it. > > Signed-off-by: Alexander Graf > > --- > > v1 -

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread P J P
Hello Dan, Stefano, +-- On Wed, 2 Dec 2020, Stefano Stabellini wrote --+ | On Wed, 2 Dec 2020, Daniel P. Berrangé wrote: | > > + any third parties, including Xen Security Project, without your prior | > > + permission. | > | > Why this explicit note about the Xen project ? What if we decide

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread P J P
+-- On Wed, 2 Dec 2020, Daniel P. Berrangé wrote --+ | > +- If issue is found to be less severe, an upstream public bug (or an | > + issue) will be created immediately. | | No need to repeat "or an issue". I think it would read more clearly as | |- If the severity of the issue is suf

Re: [PATCH] tests/acceptance: fix timeout for vm.wait

2020-12-02 Thread Pavel Dovgalyuk
On 02.12.2020 18:22, John Snow wrote: On 12/2/20 1:31 AM, Pavel Dovgalyuk wrote: This patch adds timeout parameter to vm.wait() calls, because the default value is just 30 seconds, and tests may last for more time. This doesn't sound right -- the timeout isn't meant to be for the entire d

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Gerd Hoffmann
Hi, > It would be much nicer to do the wrapper the other way round, i.e. > setting properties before the device is realized would update a > configuration struct and realize would then call .create() with that > struct. To me, this sounds much harder, though also a more useful state. Well, in s

RE: [PATCH v2 01/12] pc-dimm: put it into the 'storage' category

2020-12-02 Thread ganqixin
> -Original Message- > From: Pankaj Gupta [mailto:pankaj.gupta.li...@gmail.com] > Sent: Monday, November 30, 2020 6:19 PM > To: ganqixin > Cc: Qemu Developers ; qemu-triv...@nongnu.org; > Chenqun (kuhn) ; th...@redhat.com; > Zhanghailiang ; Michael S . Tsirkin > > Subject: Re: [PATCH v2 0

RE: [PATCH 4/4] block/iscsi.c: Use lock guard macros

2020-12-02 Thread ganqixin
> -Original Message- > From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: Wednesday, December 2, 2020 7:12 PM > To: ganqixin > Cc: qemu-devel@nongnu.org; qemu-triv...@nongnu.org; > pbonz...@redhat.com; mre...@redhat.com; stefa...@redhat.com; > dnbrd...@gmail.com; Zhanghailiang ; > Chenqun

[Bug 1906608] [NEW] [Feature request]For some ehci controller, qemu should implement using portsc[26-27] to detect the speed of device.

2020-12-02 Thread ruimeiyan
Public bug reported: for some ehci controller ,for example ehci controller on fsl_imx6,it using portsc[26-27] to decide a full speed device or high speed device was connected, hub-ehci.c should set the portsc[26-27] to return the right speed. line:1001 in hub-ehci.c if (dev && dev->attach

[PATCH v2 2/4] block/curl: Use lock guard macros

2020-12-02 Thread Gan Qixin
Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/curl. Signed-off-by: Gan Qixin Reviewed-by: Paolo Bonzini --- Cc: Kevin Wolf Cc: Markus Armbruster --- block/curl.c | 28 ++-- 1 file changed, 14 insertions(+),

[PATCH v2 0/4] Use lock guard macros in block

2020-12-02 Thread Gan Qixin
v1->v2: -Patch1: Add Paolo Bonzini reviewed tag and delete the .c suffix in the commit message. -Patch2: Add Paolo Bonzini reviewed tag and delete the .c suffix in the commit message. -Patch3: Delete the .c suffix in the commit. Changes suggested by Kevin Wolf: Fix wrong indentat

[PATCH v2 3/4] block/throttle-groups: Use lock guard macros

2020-12-02 Thread Gan Qixin
Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/throttle-groups. Signed-off-by: Gan Qixin --- Cc: Kevin Wolf Cc: Paolo Bonzini Cc: Markus Armbruster --- block/throttle-groups.c | 48 - 1 file c

[PATCH v2 1/4] block/accounting: Use lock guard macros

2020-12-02 Thread Gan Qixin
Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/accounting. Signed-off-by: Gan Qixin Reviewed-by: Paolo Bonzini --- Cc: Kevin Wolf Cc: Markus Armbruster --- block/accounting.c | 32 +++- 1 file changed, 15

[PATCH v2 4/4] block/iscsi: Use lock guard macros

2020-12-02 Thread Gan Qixin
Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/iscsi. Signed-off-by: Gan Qixin --- Cc: Kevin Wolf Cc: Paolo Bonzini Cc: Markus Armbruster --- block/iscsi.c | 50 -- 1 file changed, 24

[Bug 1906463] Re: "-device help" does not report all devices

2020-12-02 Thread Thomas Huth
This works as intended, see Markus' reply here: https://lists.gnu.org/archive/html/qemu-devel/2020-12/msg00337.html ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launc

[Bug 1896298] Re: memory leak

2020-12-02 Thread Thomas Huth
Confirmed, this is still reproducible with the current v5.2-rc4... ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896298 Title: memory leak Sta

Re: [RFC PATCH v2 4/5] virtio-net: Added eBPF RSS to virtio-net.

2020-12-02 Thread Jason Wang
On 2020/12/2 下午3:16, Yuri Benditovich wrote: On Wed, Dec 2, 2020 at 6:06 AM Jason Wang > wrote: On 2020/12/1 下午3:40, Yuri Benditovich wrote: > > > On Tue, Nov 24, 2020 at 10:49 AM Jason Wang mailto:jasow...@redhat.com> >

[PULL 002/113] target/i386: Support up to 32768 CPUs without IRQ remapping

2020-12-02 Thread Paolo Bonzini
From: David Woodhouse The IOAPIC has an 'Extended Destination ID' field in its RTE, which maps to bits 11-4 of the MSI address. Since those address bits fall within a given 4KiB page they were historically non-trivial to use on real hardware. The Intel IOMMU uses the lowest bit to indicate a rem

[PULL 003/113] target/i386: seg_helper: Correct segement selector nullification in the RET/IRET helper

2020-12-02 Thread Paolo Bonzini
From: Bin Meng Per the SDM, when returning to outer privilege level, for segment registers (ES, FS, GS, and DS) if the check fails, the segment selector becomes null, but QEMU clears the base/limit/flags as well as nullifying the segment selector, which should be a spec violation. Real hardware

[PULL 008/113] dma: Let dma_memory_set() propagate MemTxResult

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé address_space_write() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201023151923.3243652-5-phi...@re

[PULL 009/113] dma: Let dma_memory_rw() propagate MemTxResult

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé address_space_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201023151923.3243652-6-phi...@redha

[PULL 011/113] dma: Let dma_memory_write() propagate MemTxResult

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé dma_memory_rw_relaxed() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201023151923.3243652-8-phi...@

[PULL 007/113] dma: Document address_space_map/address_space_unmap() prototypes

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Add documentation based on address_space_map / address_space_unmap. Reviewed-by: Richard Henderson Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201023151923.3243652-4-phi...@redhat.com> Signed-off-by: Paolo Bonzini --- incl

[PULL 005/113] docs/devel/loads-stores: Add regexp for DMA functions

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201023151923.3243652-3-phi...@redhat.com> Signed-off-by: Paolo Bonzini --- docs/devel/loads-stores.rst | 2 ++ 1 file changed, 2 insertions(+) diff

[PULL 001/113] target/i386: fix operand order for PDEP and PEXT

2020-12-02 Thread Paolo Bonzini
For PDEP and PEXT, the mask is provided in the memory (mod+r/m) operand, and therefore is loaded in s->T0 by gen_ldst_modrm. The source is provided in the second source operand (VEX.) and therefore is loaded in s->T1. Fix the order in which they are passed to the helpers. Reported-by: Lenard

[PULL 024/113] i386: remove bios_name

2020-12-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Message-Id: <20201026143028.3034018-6-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/i386/microvm.c | 7 +++ hw/i386/pc_sysfw.c| 4 ++-- hw/i386/x86.c | 10 -- include/hw/i386/x86.h | 3 ++- 4 files c

[PULL 004/113] WHPX: support for the kernel-irqchip on/off

2020-12-02 Thread Paolo Bonzini
From: Sunil Muthuswamy This patch adds support the kernel-irqchip option for WHPX with on or off value. 'split' value is not supported for the option. The option only works for the latest version of Windows (ones that are coming out on Insiders). The change maintains backward compatibility on old

[PULL 013/113] pci: Let pci_dma_read() propagate MemTxResult

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé pci_dma_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201023151923.3243652-10-phi...@redhat.com> Signed-off-by: Paolo Bonzini

[PULL 000/113] First batch of misc (i386, kernel-doc, memory, vl.c) changes for QEMU 6.0

2020-12-02 Thread Paolo Bonzini
The following changes since commit 944fdc5e27a5b5adbb765891e8e70e88ba9a00ec: Merge remote-tracking branch 'remotes/elmarco/tags/libslirp-pull-request' into staging (2020-11-27 17:09:55 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for

[PULL 023/113] hppa: remove bios_name

2020-12-02 Thread Paolo Bonzini
Cc: Richard Henderson Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201026143028.3034018-5-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/hppa/machine.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/h

[PULL 012/113] pci: Let pci_dma_rw() propagate MemTxResult

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé dma_memory_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201023151923.3243652-9-phi...@redhat.com> Signed-off-by: Paolo Bonzini

[PULL 006/113] qom: eliminate identical functions

2020-12-02 Thread Paolo Bonzini
Most property release functions in qom/object.c only free the opaque value. Combine all of them into a single function. Signed-off-by: Paolo Bonzini --- qom/object.c | 36 +++- 1 file changed, 7 insertions(+), 29 deletions(-) diff --git a/qom/object.c b/qom/obje

[PULL 014/113] pci: Let pci_dma_write() propagate MemTxResult

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé pci_dma_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201023151923.3243652-11-phi...@redhat.com> Signed-off-by: Paolo Bonzini

[PULL 017/113] hw/ssi: Rename SSI 'slave' as 'peripheral'

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé In order to use inclusive terminology, rename SSI 'slave' as 'peripheral', following the specification resolution: https://www.oshwa.org/a-resolution-to-redefine-spi-signal-names/ Patch created mechanically using: $ sed -i s/SSISlave/SSIPeripheral/ $(git grep -l S

[PULL 015/113] hw/ssi/aspeed_smc: Rename 'max_slaves' variable as 'max_peripherals'

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé In order to use inclusive terminology, rename max_slaves as max_peripherals. Patch generated using: $ sed -i s/slave/peripheral/ \ hw/ssi/aspeed_smc.c include/hw/ssi/aspeed_smc.h One line in aspeed_smc_read() has been manually tweaked to pass checkpatch.

[PULL 010/113] dma: Let dma_memory_read() propagate MemTxResult

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé dma_memory_rw_relaxed() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201023151923.3243652-7-phi...@

[PULL 019/113] hw/dma/xilinx_axidma: Rename StreamSlave as StreamSink

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé In order to use inclusive terminology, rename 'slave stream' as 'sink stream'. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Reviewed-by: Edgar E. Iglesias Message-Id: <20200910070131.435543-4-phi...@redhat.com> Signed-off-by: Paolo Bonzini --- h

[PULL 018/113] hw/core/stream: Rename StreamSlave as StreamSink

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé In order to use inclusive terminology, rename 'slave stream' as 'sink stream'. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Reviewed-by: Edgar E. Iglesias Message-Id: <20200910070131.435543-3-phi...@redhat.com> Signed-off-by: Paolo Bonzini --- h

[PULL 038/113] hppa: do not use ram_size global

2020-12-02 Thread Paolo Bonzini
Use the machine properties instead. Cc: Richard Henderson Signed-off-by: Paolo Bonzini --- hw/hppa/machine.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index 5e745d5ea9..7e41cb2462 100644 --- a/hw/hppa/machine.c +++ b/hw/

[PULL 021/113] alpha: remove bios_name

2020-12-02 Thread Paolo Bonzini
Cc: Richard Henderson Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201026143028.3034018-2-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/alpha/dp264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/a

[PULL 016/113] hw/ssi: Update coding style to make checkpatch.pl happy

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé To make the next commit easier to review, clean this code first. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201012124955.3409127-3-f4...@amsat.org> Signed-off-by: Paolo Bonzini --- include/hw/ssi/ssi.h | 16 +--- 1 file changed, 9 insertions(

[PULL 020/113] hw/net/xilinx_axienet: Rename StreamSlave as StreamSink

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé In order to use inclusive terminology, rename 'slave stream' as 'sink stream'. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Reviewed-by: Edgar E. Iglesias Message-Id: <20200910070131.435543-5-phi...@redhat.com> Signed-off-by: Paolo Bonzini --- h

[PULL 043/113] moxie: do not use ram_size global

2020-12-02 Thread Paolo Bonzini
Use the loader parameters instead. Cc: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- hw/moxie/moxiesim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/moxie/moxiesim.c b/hw/moxie/moxiesim.c index d07d504c0d..f7b57fcae1 100644 --- a/hw/moxie/moxiesim.c +++ b/hw

[PULL 022/113] arm: remove bios_name

2020-12-02 Thread Paolo Bonzini
Get the firmware name from the MachineState object. Cc: Peter Maydell Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Message-Id: <20201026143028.3034018-4-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/arm/cubieboard.c | 2 +- hw/arm/highbank.c | 8 hw/arm/

[PULL 028/113] moxie: remove bios_name

2020-12-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Message-Id: <20201026143028.3034018-10-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/moxie/moxiesim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/moxie/moxiesim.c b/hw/moxie/moxiesim.c index a765e9

[PULL 048/113] sparc64: do not use ram_size global

2020-12-02 Thread Paolo Bonzini
Use the machine properties instead. Cc: Mark Cave-Ayland Signed-off-by: Paolo Bonzini --- hw/sparc64/sparc64.c | 3 ++- hw/sparc64/sun4u.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/sparc64/sparc64.c b/hw/sparc64/sparc64.c index 100b2fab17..e3f9219a10 100644 -

[PULL 025/113] lm32: remove bios_name

2020-12-02 Thread Paolo Bonzini
Cc: Michael Walle Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Message-Id: <20201026143028.3034018-7-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/lm32/milkymist.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist

[PULL 030/113] rx: move BIOS load from MCU to board

2020-12-02 Thread Paolo Bonzini
The ROM loader state is global and not part of the MCU, and the BIOS is in machine->firmware. So just like the kernel case, load it in the board. Due to the ordering between CPU reset and ROM reset, the ROM has to be registered before the CPU is realized, otherwise the reset vector is loaded befo

[PULL 026/113] m68k: remove bios_name

2020-12-02 Thread Paolo Bonzini
Cc: Laurent Vivier Signed-off-by: Paolo Bonzini Acked-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20201026143028.3034018-8-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/m68k/mcf5208.c | 10 +- hw/

[PULL 032/113] sh4: remove bios_name

2020-12-02 Thread Paolo Bonzini
Cc: Yoshinori Sato Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201026143028.3034018-14-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/sh4/shix.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/sh4/

[PULL 056/113] vl: extract qemu_init_subsystems

2020-12-02 Thread Paolo Bonzini
Group a bunch of subsystem initializations that can be done right after command line parsing. Remove initializations that can be done simply as global variable initializers. Reviewed-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 94 --

[PULL 027/113] mips: remove bios_name

2020-12-02 Thread Paolo Bonzini
Cc: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Message-Id: <20201026143028.3034018-9-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/mips/fuloong2e.c | 6 +++--- hw/mips/jazz.c | 6 +++--- hw/mips/malta.c | 6 +++--- hw/mips/mipssim.c | 6 +

[PULL 029/113] ppc: remove bios_name

2020-12-02 Thread Paolo Bonzini
Cc: David Gibson Signed-off-by: Paolo Bonzini Acked-by: David Gibson Reviewed-by: Alex Bennée Message-Id: <20201026143028.3034018-11-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/ppc/e500.c | 4 ++-- hw/ppc/mac_newworld.c | 4 +--- hw/ppc/mac_oldworld.c | 4 +--- hw/ppc/

[PULL 062/113] vl: create "-net nic -net user" default earlier

2020-12-02 Thread Paolo Bonzini
Create it together with other default backends, even though the processing is done later. Reviewed-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 5571f9ff75..a

[PULL 031/113] s390: remove bios_name

2020-12-02 Thread Paolo Bonzini
Cc: Thomas Huth Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20201026143028.3034018-13-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/s390x/ipl.c | 8 ++-- hw/s390x/s390-virtio-ccw.c | 3 ++- 2 files changed, 4 insertion

[PULL 035/113] vl: remove bios_name

2020-12-02 Thread Paolo Bonzini
bios_name was a legacy variable used by machine code, but it is no more. Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Message-Id: <20201026143028.3034018-16-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- include/sysemu/sysemu.h | 1 - softmmu/vl.c| 2 -- 2 files cha

[PULL 034/113] digic: remove bios_name

2020-12-02 Thread Paolo Bonzini
Pull defaults to digic4_board_init so that a MachineState is available. Cc: Peter Maydell Signed-off-by: Paolo Bonzini --- hw/arm/digic_boards.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c index d5524d3e7

[PULL 070/113] vl: separate qemu_resolve_machine_memdev

2020-12-02 Thread Paolo Bonzini
This is a bit nasty: the machine is storing a string and later resolving it. We probably want to remove the memdev property and instead make this a memory-set command. "-M memdev" can be handled a legacy option that is special cased by machine_set_property. Reviewed-by: Igor Mammedov Signed-off

[PULL 037/113] cris: do not use ram_size global

2020-12-02 Thread Paolo Bonzini
Use the machine properties instead. Signed-off-by: Paolo Bonzini --- hw/cris/axis_dev88.c | 1 + hw/cris/boot.c | 2 +- hw/cris/boot.h | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/cris/axis_dev88.c b/hw/cris/axis_dev88.c index dab7423c73..b0cb6d84af 100644

[PULL 036/113] arm: do not use ram_size global

2020-12-02 Thread Paolo Bonzini
Use the machine properties instead. Cc: qemu-...@nongnu.org Signed-off-by: Paolo Bonzini --- hw/arm/aspeed.c | 8 hw/display/pxa2xx_lcd.c | 5 +++-- target/arm/arm-semi.c | 3 ++- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c

  1   2   3   4   5   >