[PULL 0/5] Final (?) batch of misc patches for QEMU 5.2

2020-11-26 Thread Paolo Bonzini
The following changes since commit 8cc30eb1400fc01f2b139cdd3dc524f8b84dbe07: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-20201122' into staging (2020-11-22 15:02:52 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for y

[PULL 3/5] tests/docker, tests/vm: remove setuptools from images

2020-11-26 Thread Paolo Bonzini
Setuptools is not needed anymore by the bundled copy of meson, remove it. Suggested-by: Thomas Huth Signed-off-by: Paolo Bonzini --- .cirrus.yml| 1 - tests/docker/dockerfiles/debian10.docker | 1 - tests/docker/dockerfiles/fedora-win32-cross.do

[Bug 1821054] Re: qemu segfault error when using pcie to dual pci adapter

2020-11-26 Thread Thomas Huth
Ok, thanks for getting back. So I'm closing this now due to insufficient data. ** Changed in: qemu Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1821054 Title:

[PULL 5/5] nsis: Fix build for 64 bit installer

2020-11-26 Thread Paolo Bonzini
From: Stefan Weil Pass cpu instead of cpu_family to the NSIS installer script. That script checks for "x86_64" which is the cpu value, while cpu_family is "x86". Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20201125191833.964753-1...@weilnetz.de> Signed-off-by: Paolo

[PULL 1/5] meson: use dependency() to find libjpeg

2020-11-26 Thread Paolo Bonzini
Prefer pkg-config to find_library because some installations of libjpeg may place it outside the default search path. Reported-by: Stefan Weil Signed-off-by: Paolo Bonzini --- meson.build | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 50

[PULL 4/5] target/i386: fix operand order for PDEP and PEXT

2020-11-26 Thread Paolo Bonzini
For PDEP and PEXT, the mask is provided in the memory (mod+r/m) operand, and therefore is loaded in s->T0 by gen_ldst_modrm. The source is provided in the second source operand (VEX.) and therefore is loaded in s->T1. Fix the order in which they are passed to the helpers. Reported-by: Lenard

Proposal for a regular upstream performance testing

2020-11-26 Thread Lukáš Doktor
Hello guys, I had been around qemu on the Avocado-vt side for quite some time and a while ago I shifted my focus on performance testing. Currently I am not aware of any upstream CI that would continuously monitor the upstream qemu performance and I'd like to change that. There is a lot to cove

Re: [PULL 0/5] Final (?) batch of misc patches for QEMU 5.2

2020-11-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201126075921.3116321-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201126075921.3116321-1-pbonz...@redhat.com Subject: [PULL 0/5] Final (?) batch of mis

Re: Proposal for a regular upstream performance testing

2020-11-26 Thread Jason Wang
On 2020/11/26 下午4:10, Lukáš Doktor wrote: Hello guys, I had been around qemu on the Avocado-vt side for quite some time and a while ago I shifted my focus on performance testing. Currently I am not aware of any upstream CI that would continuously monitor the upstream qemu performance and I'

Re: [PATCH for-6.0 4/9] spapr: Set compat mode in spapr_reset_vcpu()

2020-11-26 Thread Greg Kurz
On Thu, 26 Nov 2020 15:57:37 +1100 David Gibson wrote: > On Wed, Nov 25, 2020 at 10:51:05AM +0100, Greg Kurz wrote: > > On Wed, 25 Nov 2020 13:39:47 +1100 > > David Gibson wrote: > > > > > On Mon, Nov 23, 2020 at 12:51:08PM +0100, Greg Kurz wrote: > > > > On Mon, 23 Nov 2020 16:11:30 +1100 > >

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-26 Thread Claudio Fontana
Hi Eduardo, On 11/25/20 9:56 PM, Eduardo Habkost wrote: > This function will be used to replace the xen_available() and > kvm_available() functions from arch_init.c. > > Signed-off-by: Eduardo Habkost > --- > Cc: Richard Henderson > Cc: Paolo Bonzini > Cc: Claudio Fontana > Cc: Roman Bolshako

Re: [PATCH for-5.2] nsis: Fix build for 64 bit installer

2020-11-26 Thread Daniel P . Berrangé
On Wed, Nov 25, 2020 at 09:59:48PM +0100, Stefan Weil wrote: > Am 25.11.20 um 20:28 schrieb Peter Maydell: > > > On Wed, 25 Nov 2020 at 19:23, Stefan Weil wrote: > > > Pass cpu instead of cpu_family to the NSIS installer script. > > > > > > That script checks for "x86_64" which is the cpu value,

Re: Proposal for a regular upstream performance testing

2020-11-26 Thread Daniel P . Berrangé
On Thu, Nov 26, 2020 at 09:10:14AM +0100, Lukáš Doktor wrote: > How > === > > This is a tough question. Ideally this should be a standalone service that > would only notify the author of the patch that caused the change with a > bunch of useful data so they can either address the issue or just be

Re: [DISCUSSION] Running one qtest test: how?

2020-11-26 Thread Peter Maydell
On Wed, 25 Nov 2020 at 23:41, Doug Evans wrote: > I can run a subset of qtest tests with "make check-qtest-TARGET", but that's > the limit of the granularity that I can find. Why would one want more > granularity? When adding a test one wants the edit/test cycle as short as > possible and needl

Re: [PULL 0/5] Final (?) batch of misc patches for QEMU 5.2

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 08:02, Paolo Bonzini wrote: > > The following changes since commit 8cc30eb1400fc01f2b139cdd3dc524f8b84dbe07: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-20201122' > into staging (2020-11-22 15:02:52 +) > > are available in the Git repository at:

Re: [PATCH] Add an announcement about the 2020 QEMU advent calendar and a call for images to include.

2020-11-26 Thread Thomas Huth
On 26/11/2020 04.37, Eldon Stegall wrote: > Signed-off-by: Eldon Stegall > --- > _posts/2020-11-26-qemu-advent-announce.md | 39 +++ > 1 file changed, 39 insertions(+) > create mode 100644 _posts/2020-11-26-qemu-advent-announce.md Thanks a lot for tackling this! I've pushed

Re: Proposal for a regular upstream performance testing

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 08:13, Lukáš Doktor wrote: > The goal of this initiative is to detect system-wide performance > regressions as well as improvements early, ideally pin-point the > individual commits and notify people that they should fix things. > All in upstream and ideally with least human

[PATCH] virtfs-proxy-helper: Fix a resource leak in main()

2020-11-26 Thread Alex Chen
Only one of the options -s and -f can be used. When -f is used, the fd is created externally and does not need to be closed. When -s is used, a new socket fd is created, and this socket fd needs to be closed at the end of main(). Reported-by: Euler Robot Signed-off-by: Alex Chen --- fsdev/virtf

Re: [PATCH] vnc: Fix a memleak in vnc_display_connect()

2020-11-26 Thread Li Qiang
Alex Chen 于2020年11月26日周四 下午3:10写道: > > Free the 'sioc' when the qio_channel_socket_connect_sync() fails. > > Reported-by: Euler Robot > Signed-off-by: Alex Chen Reviewed-by: Li Qiang > --- > ui/vnc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ui/vnc.c b/ui/vnc.c > index 4923505

Re: [PATCH] test-qga: fix a resource leak in test_qga_guest_get_osinfo()

2020-11-26 Thread Li Qiang
Alex Chen 于2020年11月25日周三 下午6:37写道: > > The fixture->fd is created in fixture_setup() and, likewise, needs to be > closed > in fixture_tear_down(). > > Reported-by: Euler Robot > Signed-off-by: Alex Chen Reviewed-by: Li Qiang > --- > tests/test-qga.c | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH v3] virtio-rng: return available data with O_NONBLOCK

2020-11-26 Thread Laurent Vivier
On 25/11/2020 10:39, Michael S. Tsirkin wrote: > On Tue, Sep 08, 2020 at 05:33:40PM +0200, Martin Wilck wrote: >> On Tue, 2020-09-08 at 10:14 -0400, Michael S. Tsirkin wrote: >>> On Mon, Aug 31, 2020 at 02:37:26PM +0200, Laurent Vivier wrote: On 28/08/2020 23:34, Martin Wilck wrote: > On W

Re: [PATCH] virtfs-proxy-helper: Fix a resource leak in main()

2020-11-26 Thread Li Qiang
Alex Chen 于2020年11月26日周四 下午6:29写道: > > Only one of the options -s and -f can be used. When -f is used, > the fd is created externally and does not need to be closed. > When -s is used, a new socket fd is created, and this socket fd > needs to be closed at the end of main(). > > Reported-by: Euler

Re: [PULL 0/5] Final (?) batch of misc patches for QEMU 5.2

2020-11-26 Thread Paolo Bonzini
On 26/11/20 11:10, Peter Maydell wrote: On Thu, 26 Nov 2020 at 08:02, Paolo Bonzini wrote: The following changes since commit 8cc30eb1400fc01f2b139cdd3dc524f8b84dbe07: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-20201122' into staging (2020-11-22 15:02:52 +) are av

Re: [RFC v5 11/12] i386: centralize initialization of cpu accel interfaces

2020-11-26 Thread Claudio Fontana
On 11/24/20 10:31 PM, Eduardo Habkost wrote: > On Tue, Nov 24, 2020 at 09:13:13PM +0100, Paolo Bonzini wrote: >> On 24/11/20 17:22, Claudio Fontana wrote: >>> +static void x86_cpu_accel_init(void) >>> { >>> -X86CPUAccelClass *acc; >>> +const char *ac_name; >>> +ObjectClass *ac; >>> +

Re: [DISCUSSION] Allow ACPI default OEM ID and OEM table ID fields to be set.

2020-11-26 Thread Michael S. Tsirkin
On Wed, Nov 25, 2020 at 09:13:22PM +0100, Antoine Damhet wrote: > On Wed, Nov 25, 2020 at 11:04:55AM -0500, Michael S. Tsirkin wrote: > > On Wed, Nov 25, 2020 at 01:32:51PM +, Richard W.M. Jones wrote: > > > On Wed, Nov 25, 2020 at 02:27:11PM +0100, Antoine Damhet wrote: > > > > Hello, > > > >

Re: Proposal for a regular upstream performance testing

2020-11-26 Thread Lukáš Doktor
Dne 26. 11. 20 v 11:17 Peter Maydell napsal(a): On Thu, 26 Nov 2020 at 08:13, Lukáš Doktor wrote: The goal of this initiative is to detect system-wide performance regressions as well as improvements early, ideally pin-point the individual commits and notify people that they should fix things. A

Re: [RFC] ich9:cpuhp: add support for cpu hot-unplug with SMI broadcast enabled

2020-11-26 Thread Laszlo Ersek
On 11/24/20 13:25, Igor Mammedov wrote: > If firmware negotiates ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT feature, > OSPM on CPU eject will set bit #4 in CPU hotplug block for to be > ejected CPU to mark it for removal by firmware and trigger SMI > upcall to let firmware do actual eject. > > Signed-off-by

[PATCH 0/5] hw/misc: Fix some bad printf format specifiers

2020-11-26 Thread Alex Chen
Find a lot of bad printf format specifiers in hw/misc, fix them. Alex Chen (5): i.MX25: Fix bad printf format specifiers i.MX31: Fix bad printf format specifiers i.MX6: Fix bad printf format specifiers i.MX6ul: Fix bad printf format specifiers misc/omap_sdrc: Fix bad printf format specif

[PATCH 1/5] i.MX25: Fix bad printf format specifiers

2020-11-26 Thread Alex Chen
We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen --- hw/misc/imx25_ccm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/misc/imx25_ccm.c b/hw/misc/imx25_ccm.c in

[PATCH 5/5] misc/omap_sdrc: Fix bad printf format specifiers

2020-11-26 Thread Alex Chen
We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen --- hw/misc/omap_sdrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/omap_sdrc.c b/hw/misc/omap_sdrc.c index f2f72f681

[PATCH 4/5] i.MX6ul: Fix bad printf format specifiers

2020-11-26 Thread Alex Chen
We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen --- hw/misc/imx6ul_ccm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/imx6ul_ccm.c b/hw/misc/imx6ul_ccm.c index 5e

[PATCH 2/5] i.MX31: Fix bad printf format specifiers

2020-11-26 Thread Alex Chen
We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen --- hw/misc/imx31_ccm.c | 14 +++--- hw/misc/imx_ccm.c | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/misc/im

[PATCH 3/5] i.MX6: Fix bad printf format specifiers

2020-11-26 Thread Alex Chen
We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen --- hw/misc/imx6_ccm.c | 20 ++-- hw/misc/imx6_src.c | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/mis

Re: Proposal for a regular upstream performance testing

2020-11-26 Thread Lukáš Doktor
Dne 26. 11. 20 v 10:43 Daniel P. Berrangé napsal(a): On Thu, Nov 26, 2020 at 09:10:14AM +0100, Lukáš Doktor wrote: How === This is a tough question. Ideally this should be a standalone service that would only notify the author of the patch that caused the change with a bunch of useful data so t

[PATCH v2 02/13] qemu/atomic: Drop special case for unsupported compiler

2020-11-26 Thread marcandre . lureau
From: Philippe Mathieu-Daudé Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8, which has the GCC BZ#36793 bug fixed. We can safely remove the special case introduced in commit a281ebc11a6 ("virtio: add missin

[PATCH v2 01/13] compiler.h: replace QEMU_GNUC_PREREQ macro

2020-11-26 Thread marcandre . lureau
From: Marc-André Lureau Replace it with glib G_GNUC_CHECK_VERSION. Available since 2.42, the macro received a small correction in 2.55.1 (glib d44afbadda8a "macros: make G_GNUC_CHECK_VERSION() portable" which was apparently harmless). Signed-off-by: Marc-André Lureau --- include/qemu/atomic.h

Re: [RFC v5 09/12] module: introduce MODULE_INIT_ACCEL_CPU

2020-11-26 Thread Philippe Mathieu-Daudé
On 11/24/20 5:22 PM, Claudio Fontana wrote: > apply this to the registration of the cpus accel interfaces, > > but this will be also in preparation for later use of this > new module init step to also register per-accel x86 cpu type > interfaces. > > Signed-off-by: Claudio Fontana > --- > accel

[PATCH v2 08/13] compiler.h: explicit case for Clang printf attribute

2020-11-26 Thread marcandre . lureau
From: Marc-André Lureau Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >= 4.8, we could thus drop earlier version checks. Except clang advertizes itself as GCC 4.2.1. Since clang doesn't support gnu_printf, make that case explicit

[PATCH v2 03/13] accel/tcg: Remove special case for GCC < 4.6

2020-11-26 Thread marcandre . lureau
From: Philippe Mathieu-Daudé Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8. We can safely remove the special case for GCC 4.6 introduced in commit 0448f5f8b81 ("cpu-exec: Fix compiler warning (-Werror=clob

[PATCH v2 07/13] virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON

2020-11-26 Thread marcandre . lureau
From: Marc-André Lureau This allows to get rid of a check for older GCC version (which was a bit bogus too since it was falling back on c++ version..) Signed-off-by: Marc-André Lureau --- tools/virtiofsd/fuse_common.h | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --gi

[PATCH v2 00/13] Remove GCC < 4.8 checks

2020-11-26 Thread marcandre . lureau
From: Marc-André Lureau Hi, Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >= 4.8. v2: - include reviewed Philippe earlier series - drop problematic patch to replace GCC_FMT_ATTR, but tweak the check to be clang - replace QEM

[PATCH v2 12/13] compiler: remove GNUC check

2020-11-26 Thread marcandre . lureau
From: Marc-André Lureau QEMU requires Clang or GCC, that define and support __GNUC__ extensions. Signed-off-by: Marc-André Lureau --- include/qemu/compiler.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index 108bf

[PATCH v2 09/13] audio: remove GNUC & MSVC check

2020-11-26 Thread marcandre . lureau
From: Marc-André Lureau QEMU requires either GCC or Clang, which both advertize __GNUC__. Drop MSVC fallback path. Signed-off-by: Marc-André Lureau --- audio/audio.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 46578e4a58..d7a00

[PATCH v2 04/13] compiler.h: remove GCC < 3 __builtin_expect fallback

2020-11-26 Thread marcandre . lureau
From: Marc-André Lureau Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >= 4.8. (clang >= 3.8 advertizes itself as GCC >= 4.2 compatible) Signed-off-by: Marc-André Lureau --- include/qemu/compiler.h | 4 1 file changed, 4 d

[PATCH v2 05/13] qemu-plugin.h: remove GCC < 4

2020-11-26 Thread marcandre . lureau
From: Marc-André Lureau Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >= 4.8. (clang >= 3.8 advertizes itself as GCC >= 4.2 compatible) Signed-off-by: Marc-André Lureau --- include/qemu/qemu-plugin.h | 9 ++--- 1 file chan

Re: [PATCH RFC] tests/acceptance: add a test for devices on s390x

2020-11-26 Thread Cornelia Huck
On Wed, 25 Nov 2020 17:04:05 +0100 Philippe Mathieu-Daudé wrote: > Hi Cornelia, > > On 11/25/20 4:03 PM, Thomas Huth wrote: > > On 25/11/2020 14.58, Cornelia Huck wrote: > >> This adds a very basic test for checking that we present devices > >> in a way that Linux can consume: boot with both v

[PATCH v2 06/13] tests: remove GCC < 4 fallbacks

2020-11-26 Thread marcandre . lureau
From: Marc-André Lureau Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >= 4.8. (clang >= 3.8 advertizes itself as GCC >= 4.2 compatible) Signed-off-by: Marc-André Lureau --- tests/tcg/arm/fcvt.c | 8 +++- 1 file changed, 3

Re: [PATCH] iotests: Add test for the regression fixed in c8bf9a9169

2020-11-26 Thread Maxim Levitsky
On Wed, 2020-11-25 at 19:55 +0100, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > Suggested-by: Maxim Levitsky > --- > tests/qemu-iotests/313 | 103 + > tests/qemu-iotests/313.out | 29 +++ > tests/qemu-iotests/group | 1 + > 3 files

[PATCH v2 10/13] poison: remove GNUC check

2020-11-26 Thread marcandre . lureau
From: Marc-André Lureau QEMU requires Clang or GCC, that define and support __GNUC__ extensions Signed-off-by: Marc-André Lureau --- include/exec/poison.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/exec/poison.h b/include/exec/poison.h index 7b9ac361dc..d7ae1f23e7 100644 ---

Re: [PATCH] virtfs-proxy-helper: Fix a resource leak in main()

2020-11-26 Thread Alex Chen
On 2020/11/26 18:50, Li Qiang wrote: > Alex Chen >> >> Only one of the options -s and -f can be used. When -f is used, >> the fd is created externally and does not need to be closed. >> When -s is used, a new socket fd is created, and this socket fd >> needs to be closed at the end of main(). >> >

Re: [PATCH v2 01/13] compiler.h: replace QEMU_GNUC_PREREQ macro

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 11:29, wrote: > > From: Marc-André Lureau > > Replace it with glib G_GNUC_CHECK_VERSION. > > Available since 2.42, the macro received a small correction in > 2.55.1 (glib d44afbadda8a "macros: make G_GNUC_CHECK_VERSION() > portable" which was apparently harmless). > > Signe

[PATCH v2 11/13] xen: remove GNUC check

2020-11-26 Thread marcandre . lureau
From: Marc-André Lureau QEMU requires Clang or GCC, that define and support __GNUC__ extensions Signed-off-by: Marc-André Lureau --- include/hw/xen/interface/io/ring.h | 9 - 1 file changed, 9 deletions(-) diff --git a/include/hw/xen/interface/io/ring.h b/include/hw/xen/interface/io/

[PATCH v2 13/13] linux-user: remove GNUC check

2020-11-26 Thread marcandre . lureau
From: Marc-André Lureau QEMU requires Clang or GCC, that define and support __GNUC__ extensions. Signed-off-by: Marc-André Lureau --- linux-user/strace.c | 4 1 file changed, 4 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 11fea14fba..e00275fcb5 100644 --- a/l

Re: [PATCH v2 02/13] qemu/atomic: Drop special case for unsupported compiler

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 11:29, wrote: > > From: Philippe Mathieu-Daudé > > Since commit efc6c070aca ("configure: Add a test for the > minimum compiler version") the minimum compiler version > required for GCC is 4.8, which has the GCC BZ#36793 bug fixed. > > We can safely remove the special case i

Re: [PATCH v2 04/13] compiler.h: remove GCC < 3 __builtin_expect fallback

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 11:29, wrote: > > From: Marc-André Lureau > > Since commit efc6c07 ("configure: Add a test for the minimum compiler > version"), QEMU explicitely depends on GCC >= 4.8. > > (clang >= 3.8 advertizes itself as GCC >= 4.2 compatible) All clangs always have advertised themselv

Re: [PATCH v2 01/13] compiler.h: replace QEMU_GNUC_PREREQ macro

2020-11-26 Thread Marc-André Lureau
Hi On Thu, Nov 26, 2020 at 3:48 PM Peter Maydell wrote: > > On Thu, 26 Nov 2020 at 11:29, wrote: > > > > From: Marc-André Lureau > > > > Replace it with glib G_GNUC_CHECK_VERSION. > > > > Available since 2.42, the macro received a small correction in > > 2.55.1 (glib d44afbadda8a "macros: make

Re: [PATCH v2 06/13] tests: remove GCC < 4 fallbacks

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 11:30, wrote: > > From: Marc-André Lureau > > Since commit efc6c07 ("configure: Add a test for the minimum compiler > version"), QEMU explicitely depends on GCC >= 4.8. > > (clang >= 3.8 advertizes itself as GCC >= 4.2 compatible) > > Signed-off-by: Marc-André Lureau > ---

Re: [PATCH v2 00/13] Remove GCC < 4.8 checks

2020-11-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201126112915.525285-1-marcandre.lur...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201126112915.525285-1-marcandre.lur...@redhat.com Subject: [PATCH v2 00/13] Re

Re: [PATCH v2 05/13] qemu-plugin.h: remove GCC < 4

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 11:30, wrote: > > From: Marc-André Lureau > > Since commit efc6c07 ("configure: Add a test for the minimum compiler > version"), QEMU explicitely depends on GCC >= 4.8. > > (clang >= 3.8 advertizes itself as GCC >= 4.2 compatible) > > Signed-off-by: Marc-André Lureau > ---

Re: [PATCH v2 08/13] compiler.h: explicit case for Clang printf attribute

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 11:30, wrote: > > From: Marc-André Lureau > > Since commit efc6c07 ("configure: Add a test for the minimum compiler > version"), QEMU explicitely depends on GCC >= 4.8, we could thus drop > earlier version checks. Except clang advertizes itself as GCC 4.2.1. > > Since clang

Re: [RFC v5 09/12] module: introduce MODULE_INIT_ACCEL_CPU

2020-11-26 Thread Claudio Fontana
On 11/26/20 12:25 PM, Philippe Mathieu-Daudé wrote: > On 11/24/20 5:22 PM, Claudio Fontana wrote: >> apply this to the registration of the cpus accel interfaces, >> >> but this will be also in preparation for later use of this >> new module init step to also register per-accel x86 cpu type >> inter

Re: [PATCH RFC] tests/acceptance: add a test for devices on s390x

2020-11-26 Thread Cornelia Huck
On Wed, 25 Nov 2020 16:30:34 +0100 Cornelia Huck wrote: > On Wed, 25 Nov 2020 16:03:13 +0100 > Thomas Huth wrote: > > > On 25/11/2020 14.58, Cornelia Huck wrote: > > > +def test(self): > > > + > > > +""" > > > +:avocado: tags=arch:s390x > > > +:avocado: tags=machi

Re: [PATCH v2 02/13] qemu/atomic: Drop special case for unsupported compiler

2020-11-26 Thread Daniel P . Berrangé
On Thu, Nov 26, 2020 at 11:49:28AM +, Peter Maydell wrote: > On Thu, 26 Nov 2020 at 11:29, wrote: > > > > From: Philippe Mathieu-Daudé > > > > Since commit efc6c070aca ("configure: Add a test for the > > minimum compiler version") the minimum compiler version > > required for GCC is 4.8, whic

Re: [PATCH v2 09/13] audio: remove GNUC & MSVC check

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 11:30, wrote: > > From: Marc-André Lureau > > QEMU requires either GCC or Clang, which both advertize __GNUC__. > Drop MSVC fallback path. > > Signed-off-by: Marc-André Lureau > --- > audio/audio.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --

Re: [PATCH] virtfs-proxy-helper: Fix a resource leak in main()

2020-11-26 Thread Greg Kurz
On Thu, 26 Nov 2020 10:16:24 + Alex Chen wrote: > Only one of the options -s and -f can be used. When -f is used, > the fd is created externally and does not need to be closed. The process running virtfs-proxy-helper has its own copy of the fd inherited from its parent. And this fd will be c

Re: [PATCH v2 10/13] poison: remove GNUC check

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 11:30, wrote: > > From: Marc-André Lureau > > QEMU requires Clang or GCC, that define and support __GNUC__ extensions > > Signed-off-by: Marc-André Lureau > --- > include/exec/poison.h | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 09/13] audio: remove GNUC & MSVC check

2020-11-26 Thread Marc-André Lureau
Hi On Thu, Nov 26, 2020 at 4:08 PM Peter Maydell wrote: > On Thu, 26 Nov 2020 at 11:30, wrote: > > > > From: Marc-André Lureau > > > > QEMU requires either GCC or Clang, which both advertize __GNUC__. > > Drop MSVC fallback path. > > > > Signed-off-by: Marc-André Lureau > > --- > > audio/aud

Re: [PATCH v2 12/13] compiler: remove GNUC check

2020-11-26 Thread Marc-André Lureau
On Thu, Nov 26, 2020 at 4:10 PM Peter Maydell wrote: > > On Thu, 26 Nov 2020 at 11:30, wrote: > > > > From: Marc-André Lureau > > > > QEMU requires Clang or GCC, that define and support __GNUC__ extensions. > > > > Signed-off-by: Marc-André Lureau > > --- > > include/qemu/compiler.h | 8 +-

Re: [PATCH v2 12/13] compiler: remove GNUC check

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 11:30, wrote: > > From: Marc-André Lureau > > QEMU requires Clang or GCC, that define and support __GNUC__ extensions. > > Signed-off-by: Marc-André Lureau > --- > include/qemu/compiler.h | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/incl

Re: [PATCH v2 11/13] xen: remove GNUC check

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 11:30, wrote: > > From: Marc-André Lureau > > QEMU requires Clang or GCC, that define and support __GNUC__ extensions > > Signed-off-by: Marc-André Lureau > --- > include/hw/xen/interface/io/ring.h | 9 - > 1 file changed, 9 deletions(-) >From QEMU's POV this cha

Re: [PATCH v2 05/13] qemu-plugin.h: remove GCC < 4

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 12:12, Daniel P. Berrangé wrote: > On Thu, Nov 26, 2020 at 11:57:14AM +, Peter Maydell wrote: > > This is an interesting case, because it's a header intended > > for external use (people compiling plugins), not part of > > QEMU proper. I don't know whether we want to imp

Re: [PATCH v2 02/13] qemu/atomic: Drop special case for unsupported compiler

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 12:06, Daniel P. Berrangé wrote: > > On Thu, Nov 26, 2020 at 11:49:28AM +, Peter Maydell wrote: > > On Thu, 26 Nov 2020 at 11:29, wrote: > > > > > > From: Philippe Mathieu-Daudé > > > > > > Since commit efc6c070aca ("configure: Add a test for the > > > minimum compiler

Re: [PATCH v2 13/13] linux-user: remove GNUC check

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 11:31, wrote: > > From: Marc-André Lureau > > QEMU requires Clang or GCC, that define and support __GNUC__ extensions. > > Signed-off-by: Marc-André Lureau > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 05/13] qemu-plugin.h: remove GCC < 4

2020-11-26 Thread Daniel P . Berrangé
On Thu, Nov 26, 2020 at 11:57:14AM +, Peter Maydell wrote: > On Thu, 26 Nov 2020 at 11:30, wrote: > > > > From: Marc-André Lureau > > > > Since commit efc6c07 ("configure: Add a test for the minimum compiler > > version"), QEMU explicitely depends on GCC >= 4.8. > > > > (clang >= 3.8 advertiz

Re: [PATCH RFC] tests/acceptance: add a test for devices on s390x

2020-11-26 Thread Thomas Huth
On 26/11/2020 13.05, Cornelia Huck wrote: > On Wed, 25 Nov 2020 16:30:34 +0100 > Cornelia Huck wrote: > >> On Wed, 25 Nov 2020 16:03:13 +0100 >> Thomas Huth wrote: >> >>> On 25/11/2020 14.58, Cornelia Huck wrote: > +def test(self): + +""" +:avocado: tag

Re: [PATCH v2 1/6] arch_init: Move QEMU_ARCH definitions to cpu.h

2020-11-26 Thread Thomas Huth
On 25/11/2020 21.56, Eduardo Habkost wrote: > Instead of a collection of #ifdefs on arch_init.c, define > QEMU_ARCH inside each cpu.h file. > > Signed-off-by: Eduardo Habkost > --- Sounds like a good idea to get rid of the #ifdeffery! Acked-by: Thomas Huth

Re: [PATCH RFC] tests/acceptance: add a test for devices on s390x

2020-11-26 Thread Cornelia Huck
On Thu, 26 Nov 2020 13:18:38 +0100 Thomas Huth wrote: > On 26/11/2020 13.05, Cornelia Huck wrote: > > On Wed, 25 Nov 2020 16:30:34 +0100 > > Cornelia Huck wrote: > > > >> On Wed, 25 Nov 2020 16:03:13 +0100 > >> Thomas Huth wrote: > >> > >>> On 25/11/2020 14.58, Cornelia Huck wrote: > >

Re: [RFC v5 09/12] module: introduce MODULE_INIT_ACCEL_CPU

2020-11-26 Thread Claudio Fontana
On 11/25/20 10:30 AM, Paolo Bonzini wrote: > On 25/11/20 10:21, Claudio Fontana wrote: >> Hi Paolo, >> >> in RFC v5 , module init for ACCEL_CPU is not conditional anymore, right? >> But the fact that its behavior depends on current_accel() still disqualifies >> it? >> It is called right after the

Re: [RFC] ich9:cpuhp: add support for cpu hot-unplug with SMI broadcast enabled

2020-11-26 Thread Laszlo Ersek
On 11/26/20 11:24, Ankur Arora wrote: > On 2020-11-24 4:25 a.m., Igor Mammedov wrote: >> If firmware negotiates ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT feature, >> OSPM on CPU eject will set bit #4 in CPU hotplug block for to be >> ejected CPU to mark it for removal by firmware and trigger SMI >> upcall

Re: [DISCUSSION] Allow ACPI default OEM ID and OEM table ID fields to be set.

2020-11-26 Thread Antoine Damhet
On Thu, Nov 26, 2020 at 06:09:11AM -0500, Michael S. Tsirkin wrote: > On Wed, Nov 25, 2020 at 09:13:22PM +0100, Antoine Damhet wrote: > > On Wed, Nov 25, 2020 at 11:04:55AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Nov 25, 2020 at 01:32:51PM +, Richard W.M. Jones wrote: > > > > On Wed, Nov

Re: [RFC PATCH v2 0/5] eBPF RSS support for virtio-net

2020-11-26 Thread Yuri Benditovich
On Mon, Nov 23, 2020 at 8:08 AM Jason Wang wrote: > > On 2020/11/19 下午7:13, Andrew Melnychenko wrote: > > This set of patches introduces the usage of eBPF for packet steering > > and RSS hash calculation: > > * RSS(Receive Side Scaling) is used to distribute network packets to > > guest virtqueue

Re: [DISCUSSION] Allow ACPI default OEM ID and OEM table ID fields to be set.

2020-11-26 Thread Laszlo Ersek
On 11/26/20 12:09, Michael S. Tsirkin wrote: > On Wed, Nov 25, 2020 at 09:13:22PM +0100, Antoine Damhet wrote: >> On Wed, Nov 25, 2020 at 11:04:55AM -0500, Michael S. Tsirkin wrote: >>> On Wed, Nov 25, 2020 at 01:32:51PM +, Richard W.M. Jones wrote: On Wed, Nov 25, 2020 at 02:27:11PM +0100

Re: [RFC PATCH v2 5/5] docs: Added eBPF documentation.

2020-11-26 Thread Yuri Benditovich
On Tue, Nov 24, 2020 at 10:55 AM Jason Wang wrote: > > On 2020/11/19 下午7:13, Andrew Melnychenko wrote: > > From: Andrew > > > > Also, added maintainers information. > > > > Signed-off-by: Yuri Benditovich > > Signed-off-by: Andrew Melnychenko > > --- > > MAINTAINERS | 7 +++ > > doc

[PATCH v2] tests/acceptance: add a test for devices on s390x

2020-11-26 Thread Cornelia Huck
This adds a very basic test for checking that we present devices in a way that Linux can consume: boot with both virtio-net-ccw and virtio-net-pci attached and then verify that Linux is able to see and detect these devices. Signed-off-by: Cornelia Huck --- RFC->v2: - use a newer kernel that uses

Re: [PATCH v2 05/13] qemu-plugin.h: remove GCC < 4

2020-11-26 Thread Alex Bennée
Peter Maydell writes: > On Thu, 26 Nov 2020 at 12:12, Daniel P. Berrangé wrote: >> On Thu, Nov 26, 2020 at 11:57:14AM +, Peter Maydell wrote: >> > This is an interesting case, because it's a header intended >> > for external use (people compiling plugins), not part of >> > QEMU proper. I d

Re: [PATCH v2] tests/acceptance: add a test for devices on s390x

2020-11-26 Thread Thomas Huth
On 26/11/2020 14.01, Cornelia Huck wrote: > This adds a very basic test for checking that we present devices > in a way that Linux can consume: boot with both virtio-net-ccw and > virtio-net-pci attached and then verify that Linux is able to see > and detect these devices. > > Signed-off-by: Corne

Re: [PATCH] virtfs-proxy-helper: Fix a resource leak in main()

2020-11-26 Thread Alex Chen
Hi Greg, Thanks for your review. On 2020/11/26 20:07, Greg Kurz wrote: > On Thu, 26 Nov 2020 10:16:24 + > Alex Chen wrote: > >> Only one of the options -s and -f can be used. When -f is used, >> the fd is created externally and does not need to be closed. > > The process running virtfs-pro

Re: [DISCUSSION] Allow ACPI default OEM ID and OEM table ID fields to be set.

2020-11-26 Thread Michael S. Tsirkin
On Thu, Nov 26, 2020 at 01:51:43PM +0100, Laszlo Ersek wrote: > On 11/26/20 12:09, Michael S. Tsirkin wrote: > > On Wed, Nov 25, 2020 at 09:13:22PM +0100, Antoine Damhet wrote: > >> On Wed, Nov 25, 2020 at 11:04:55AM -0500, Michael S. Tsirkin wrote: > >>> On Wed, Nov 25, 2020 at 01:32:51PM +, R

Re: [DISCUSSION] Allow ACPI default OEM ID and OEM table ID fields to be set.

2020-11-26 Thread Michael S. Tsirkin
On Thu, Nov 26, 2020 at 01:50:12PM +0100, Antoine Damhet wrote: > On Thu, Nov 26, 2020 at 06:09:11AM -0500, Michael S. Tsirkin wrote: > > On Wed, Nov 25, 2020 at 09:13:22PM +0100, Antoine Damhet wrote: > > > On Wed, Nov 25, 2020 at 11:04:55AM -0500, Michael S. Tsirkin wrote: > > > > On Wed, Nov 25,

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-26 Thread Eduardo Habkost
On Thu, Nov 26, 2020 at 10:14:31AM +0100, Claudio Fontana wrote: > Hi Eduardo, > > On 11/25/20 9:56 PM, Eduardo Habkost wrote: > > This function will be used to replace the xen_available() and > > kvm_available() functions from arch_init.c. > > > > Signed-off-by: Eduardo Habkost > > --- > > Cc:

Re: [RFC v5 11/12] i386: centralize initialization of cpu accel interfaces

2020-11-26 Thread Eduardo Habkost
On Thu, Nov 26, 2020 at 11:57:28AM +0100, Claudio Fontana wrote: > On 11/24/20 10:31 PM, Eduardo Habkost wrote: > > On Tue, Nov 24, 2020 at 09:13:13PM +0100, Paolo Bonzini wrote: > >> On 24/11/20 17:22, Claudio Fontana wrote: > >>> +static void x86_cpu_accel_init(void) > >>> { > >>> -X86CPUAcc

Re: [PULL 0/5] Final (?) batch of misc patches for QEMU 5.2

2020-11-26 Thread Peter Maydell
On Thu, 26 Nov 2020 at 08:02, Paolo Bonzini wrote: > > The following changes since commit 8cc30eb1400fc01f2b139cdd3dc524f8b84dbe07: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-20201122' > into staging (2020-11-22 15:02:52 +) > > are available in the Git repository at:

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-26 Thread Claudio Fontana
On 11/26/20 2:36 PM, Eduardo Habkost wrote: > On Thu, Nov 26, 2020 at 10:14:31AM +0100, Claudio Fontana wrote: >> Hi Eduardo, >> >> On 11/25/20 9:56 PM, Eduardo Habkost wrote: >>> This function will be used to replace the xen_available() and >>> kvm_available() functions from arch_init.c. >>> >>> S

[PULL 2/4] configure: remove python pkg_resources check

2020-11-26 Thread Paolo Bonzini
From: Olaf Hering Since meson.git#0240d760c7699a059cc89e584363c6431cdd2b61 setuptools is not required anymore. Signed-off-by: Olaf Hering Reviewed-by: Thomas Huth Message-Id: <20201124211925.4194-1-o...@aepfle.de> Signed-off-by: Paolo Bonzini --- configure | 3 --- 1 file changed, 3 deletio

[PULL 3/4] tests/docker, tests/vm: remove setuptools from images

2020-11-26 Thread Paolo Bonzini
Setuptools is not needed anymore by the bundled copy of meson, remove it. Suggested-by: Thomas Huth Signed-off-by: Paolo Bonzini --- .cirrus.yml| 1 - tests/docker/dockerfiles/debian10.docker | 1 - tests/docker/dockerfiles/fedora-win32-cross.do

[PULL v2 0/4] Final (?) batch of misc patches for QEMU 5.2

2020-11-26 Thread Paolo Bonzini
The following changes since commit 8cc30eb1400fc01f2b139cdd3dc524f8b84dbe07: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-20201122' into staging (2020-11-22 15:02:52 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for y

[PULL 4/4] nsis: Fix build for 64 bit installer

2020-11-26 Thread Paolo Bonzini
From: Stefan Weil Pass cpu instead of cpu_family to the NSIS installer script. That script checks for "x86_64" which is the cpu value, while cpu_family is "x86". Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20201125191833.964753-1...@weilnetz.de> Signed-off-by: Paolo

[PULL 1/4] meson: use dependency() to find libjpeg

2020-11-26 Thread Paolo Bonzini
Prefer pkg-config to find_library because some installations of libjpeg may place it outside the default search path. Reported-by: Stefan Weil Signed-off-by: Paolo Bonzini --- meson.build | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 50

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-26 Thread Paolo Bonzini
On 26/11/20 15:13, Claudio Fontana wrote: One option I see is simply to document the behavior where accel_available() is declared in accel.h (ie do not use in fast path), as well as in accel_find() actually, so that both accel_find() and accel_available() are avoided in fast path and avoid being

Re: [PATCH] tests/docker, tests/vm: remove setuptools from images

2020-11-26 Thread Paolo Bonzini
On 25/11/20 19:20, Thomas Huth wrote: On 25/11/2020 18.50, Paolo Bonzini wrote: Setuptools is not needed anymore by the bundled copy of meson, remove it. Suggested-by: Thomas Huth Signed-off-by: Paolo Bonzini --- .cirrus.yml| 1 - tests/docker/docker

  1   2   3   >