Re: [PATCH v2 2/2] pc-bios: s390x: Clear out leftover S390EP string

2020-11-23 Thread Thomas Huth
On 23/11/2020 08.39, Christian Borntraeger wrote: > On 20.11.20 17:01, Eric Farman wrote: >> A Linux binary will have the string "S390EP" at address 0x10008, >> which is important in getting the guest up off the ground. In the >> case of a reboot (specifically chreipl going to a new device), >> we

Re: [PATCH v2 2/2] pc-bios: s390x: Clear out leftover S390EP string

2020-11-23 Thread Christian Borntraeger
On 23.11.20 09:05, Thomas Huth wrote: > On 23/11/2020 08.39, Christian Borntraeger wrote: >> On 20.11.20 17:01, Eric Farman wrote: >>> A Linux binary will have the string "S390EP" at address 0x10008, >>> which is important in getting the guest up off the ground. In the >>> case of a reboot (spec

Re: [PATCH for-6.0 0/8] spapr: Address the confusion between IPI numbers and vCPU ids

2020-11-23 Thread Cédric Le Goater
On 11/20/20 6:46 PM, Greg Kurz wrote: > A regression was recently fixed in the sPAPR XIVE code for QEMU 5.2 > RC3 [1]. It boiled down to a confusion between IPI numbers and vCPU > ids, which happen to be numerically equal in general, but are really > different entities that can diverge in some setu

Re: [PATCH for-6.0 1/8] spapr/xive: Turn some sanity checks into assertions

2020-11-23 Thread Cédric Le Goater
On 11/20/20 6:46 PM, Greg Kurz wrote: > The sPAPR XIVE device is created by the machine in spapr_irq_init(). > The latter overrides any value provided by the user with -global for > the "nr-irqs" and "nr-ends" properties with strictly positive values. > > It seems reasonable to assume these proper

Re: [PATCH for-5.2] hw/display/tcx: add missing 64-bit access for framebuffer blitter

2020-11-23 Thread Mark Cave-Ayland
On 20/11/2020 08:17, Mark Cave-Ayland wrote: Commit ae5643ecc6 "hw/display/tcx: Allow 64-bit accesses to framebuffer stippler and blitter" enabled 64-bit access for the TCX framebuffer stippler and blitter but missed applying the change to one of the blitter MemoryRegions. Whilst the original c

Re: [PATCH] net: Use correct default-path macro for downscript

2020-11-23 Thread Jason Wang
On 2020/11/23 下午2:29, Keqian Zhu wrote: Fixes: 63c4db4c2e6d (net: relocate paths to helpers and scripts) Signed-off-by: Keqian Zhu --- net/tap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/tap.c b/net/tap.c index c46ff66184..b8e5cca51c 100644 --- a/net/tap.c ++

Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function

2020-11-23 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Nov 20, 2020 at 07:52:31AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Thu, Nov 19, 2020 at 11:27:40AM +0100, Markus Armbruster wrote: >> > [...] >> >> > +bool qnum_is_equal(const QObject *x, const QObject *y) >> >> > +{ >> >> > +c

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-23 Thread Thomas Huth
On 18/11/2020 15.30, Peter Maydell wrote: > On Wed, 18 Nov 2020 at 14:24, Markus Armbruster wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> On 11/18/20 10:03 AM, Thomas Huth wrote: Both headers, sysbus.h and module.h, are not required to compile this file. >> >> module.h is: it defines ty

Re: [PATCH v2 2/2] pc-bios: s390x: Clear out leftover S390EP string

2020-11-23 Thread Thomas Huth
On 23/11/2020 09.07, Christian Borntraeger wrote: > > > On 23.11.20 09:05, Thomas Huth wrote: >> On 23/11/2020 08.39, Christian Borntraeger wrote: >>> On 20.11.20 17:01, Eric Farman wrote: A Linux binary will have the string "S390EP" at address 0x10008, which is important in getting the

[Bug 1892540] Re: qemu can no longer boot NetBSD/sparc

2020-11-23 Thread Mark Cave-Ayland
This should now be fixed in master as of 48e5c7f34c "hw/display/tcx: add missing 64-bit access for framebuffer blitter". ATB, Mark. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [PATCH 28/29] vl: remove separate preconfig main_loop

2020-11-23 Thread Paolo Bonzini
On 20/11/20 17:26, Igor Mammedov wrote: +if (!preconfig_requested) { +qmp_x_exit_preconfig(&error_fatal); +} +qemu_init_displays(); given that qemu_init_displays() were called in both cases, shouldn't it be called unconditionally at [1]? Yes, correct. Paolo

[Bug 1800156] Re: windows 8.1 loose grab/leave window on windowed

2020-11-23 Thread Thomas Huth
Does the mouse grabbing still does not work with the latest version of QEMU? Which binaries did you use? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/

[Bug 1801933] Re: default memory parameter too small on x86_64 today

2020-11-23 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1801933 Title: default memory parameter too small on x86_64 today Status in QEMU: New Bug

[Bug 1796520] Re: autogen crashes on qemu-sh4-user after 61dedf2af7

2020-11-23 Thread Thomas Huth
Did you ever ask the glibc or SuperH experts? Is this bug still pending in the latest version of QEMU? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.

Re: [RFC v4 9/9] i386: split cpu accelerators from cpu.c

2020-11-23 Thread Claudio Fontana
Hi Eduardo, On 11/20/20 8:00 PM, Eduardo Habkost wrote: > On Fri, Nov 20, 2020 at 07:47:11PM +0100, Claudio Fontana wrote: >> On 11/20/20 6:44 PM, Eduardo Habkost wrote: >>> On Fri, Nov 20, 2020 at 03:49:09PM +0100, Claudio Fontana wrote: split cpu.c into: cpu.ccpuid a

Re: [PATCH for-6.0 3/8] spapr/xive: Add "nr-servers" property

2020-11-23 Thread Greg Kurz
On Mon, 23 Nov 2020 14:52:14 +1100 David Gibson wrote: > On Fri, Nov 20, 2020 at 06:46:41PM +0100, Greg Kurz wrote: > > The sPAPR XIVE object has an "nr-ends" property that is used > > to size the END table. This property is set by the machine > > code to a value derived from spapr_max_server_num

[Bug 1745895] Re: Unable to migrate vhost-net to virtio-1.0-capable kernel

2020-11-23 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

Re: [PATCH v1 3/6] tests/avocado: clean-up socket directory after run

2020-11-23 Thread Alex Bennée
Wainer dos Santos Moschetta writes: > On 11/17/20 2:36 PM, Alex Bennée wrote: >> Previously we were leaving temporary directories behind. While the >> QEMUMachine does make efforts to clean up after itself the directory >> belongs to the calling function. We use TemporaryDirectory to wrap >> th

Re: [PATCH] hmp: Changed hmp_netdev_add() using qmp_marshal_netdev_add()

2020-11-23 Thread Markus Armbruster
Andrew Melnichenko writes: > --f73b2205b4aef0c5 > Content-Type: text/plain; charset="UTF-8" > > Hi, the bug can be reproduced like that: > >> QEMU 5.1.50 monitor - type 'help' for more information >> (qemu) netdev_add >> type=tap,id=net0,script=/home/and/SRCS/qemu/ifup.sh,downscript=n

Re: [RFC v3 8/9] module: introduce MODULE_INIT_ACCEL_CPU

2020-11-23 Thread Claudio Fontana
On 11/20/20 7:09 PM, Eduardo Habkost wrote: > On Fri, Nov 20, 2020 at 06:41:35PM +0100, Claudio Fontana wrote: >> On 11/20/20 6:19 PM, Eduardo Habkost wrote: >>> On Fri, Nov 20, 2020 at 01:13:33PM +0100, Claudio Fontana wrote: On 11/18/20 11:07 PM, Eduardo Habkost wrote: > On Wed, Nov 18,

[raw] Guest stuck during live live-migration

2020-11-23 Thread Quentin Grolleau
Hello, In our company, we are hosting a large number of Vm, hosted behind Openstack (so libvirt/qemu). A large majority of our Vms are runnign with local data only, stored on NVME, and most of them are RAW disks. With Qemu 4.0 (can be even with older version) we see strange live-migration com

Re: [PATCH for-6.0 6/8] spapr/xics: Add "nr-servers" property

2020-11-23 Thread Greg Kurz
On Mon, 23 Nov 2020 15:18:09 +1100 David Gibson wrote: > On Fri, Nov 20, 2020 at 06:46:44PM +0100, Greg Kurz wrote: > > The sPAPR ICS device exposes the range of vCPU ids it can handle in > > the "ibm,interrupt-server-ranges" FDT property. The highest vCPU > > id, ie. spapr_max_server_number(), i

Re: [PATCH for-6.0 2/8] spapr/xive: Introduce spapr_xive_nr_ends()

2020-11-23 Thread Cédric Le Goater
On 11/20/20 6:46 PM, Greg Kurz wrote: > We're going to kill the "nr_ends" field in a subsequent patch. why ? it is one of the tables of the controller and its part of the main XIVE concepts. Conceptually, we could let the machine dimension it with an arbitrary value as OPAL does. The controller

Re: [Virtio-fs] [PATCH] virtiofsd: Use --thread-pool-size=0 to mean no thread pool

2020-11-23 Thread Miklos Szeredi
On Wed, Nov 18, 2020 at 8:52 PM Vivek Goyal wrote: > > On Thu, Nov 12, 2020 at 10:06:37AM +0100, Miklos Szeredi wrote: > > On Fri, Nov 6, 2020 at 11:35 PM Vivek Goyal wrote: > > > > > > On Fri, Nov 06, 2020 at 08:33:50PM +, Venegas Munoz, Jose Carlos > > > wrote: > > > > Hi Vivek, > > > > >

Re: [PATCH for-6.0 7/8] spapr: Drop "nr_servers" argument of the sPAPR IC activate() operation

2020-11-23 Thread Greg Kurz
On Mon, 23 Nov 2020 15:38:32 +1100 David Gibson wrote: > On Fri, Nov 20, 2020 at 06:46:45PM +0100, Greg Kurz wrote: > > This argument isn't used by the backends anymore. > > > > Signed-off-by: Greg Kurz > > --- > > include/hw/ppc/spapr_irq.h | 3 +-- > > hw/intc/spapr_xive.c | 3 +-- > >

Re: [RFC v3 8/9] module: introduce MODULE_INIT_ACCEL_CPU

2020-11-23 Thread Claudio Fontana
On 11/23/20 10:29 AM, Claudio Fontana wrote: > On 11/20/20 7:09 PM, Eduardo Habkost wrote: >> On Fri, Nov 20, 2020 at 06:41:35PM +0100, Claudio Fontana wrote: >>> On 11/20/20 6:19 PM, Eduardo Habkost wrote: On Fri, Nov 20, 2020 at 01:13:33PM +0100, Claudio Fontana wrote: > On 11/18/20 11:0

Re: [PATCH for-6.0 3/8] spapr/xive: Add "nr-servers" property

2020-11-23 Thread Cédric Le Goater
On 11/20/20 6:46 PM, Greg Kurz wrote: > The sPAPR XIVE object has an "nr-ends" property that is used > to size the END table. This property is set by the machine > code to a value derived from spapr_max_server_number(). Yes. This is done at the machine level. > spapr_max_server_number() is also u

Re: [PATCH for-6.0 0/8] spapr: Address the confusion between IPI numbers and vCPU ids

2020-11-23 Thread Greg Kurz
On Mon, 23 Nov 2020 09:04:42 +0100 Cédric Le Goater wrote: > On 11/20/20 6:46 PM, Greg Kurz wrote: > > A regression was recently fixed in the sPAPR XIVE code for QEMU 5.2 > > RC3 [1]. It boiled down to a confusion between IPI numbers and vCPU > > ids, which happen to be numerically equal in gener

[Bug 1748612] Re: qemu-user option -strace -D doesn't work

2020-11-23 Thread Thomas Huth
I think this has been fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=4b25a50674de41e72f6b3003 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.

Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30

2020-11-23 Thread Kevin Wolf
Am 20.11.2020 um 19:19 hat Vladimir Sementsov-Ogievskiy geschrieben: > 20.11.2020 20:22, Kevin Wolf wrote: > > Am 20.11.2020 um 17:43 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 20.11.2020 19:36, Kevin Wolf wrote: > > > > Am 20.11.2020 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben:

Re: [PATCH for-6.0 4/8] spapr/xive: Add "nr-ipis" property

2020-11-23 Thread Cédric Le Goater
On 11/20/20 6:46 PM, Greg Kurz wrote: > The sPAPR XIVE device exposes a range of LISNs that the guest uses > for IPIs. This range is currently sized according to the highest > vCPU id, ie. spapr_max_server_number(), as obtained from the machine > through the "nr_servers" argument of the generic spa

Re: [PATCH for-6.0 5/8] spapr/xics: Drop unused argument to xics_kvm_has_broken_disconnect()

2020-11-23 Thread Cédric Le Goater
On 11/20/20 6:46 PM, Greg Kurz wrote: > Never used from the start. > > Signed-off-by: Greg Kurz Reviewed-by: Cédric Le Goater > --- > include/hw/ppc/xics_spapr.h | 2 +- > hw/intc/xics_kvm.c | 2 +- > hw/ppc/spapr_irq.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletio

Re: [PATCH for-6.0 6/8] spapr/xics: Add "nr-servers" property

2020-11-23 Thread Cédric Le Goater
On 11/20/20 6:46 PM, Greg Kurz wrote: > The sPAPR ICS device exposes the range of vCPU ids it can handle in > the "ibm,interrupt-server-ranges" FDT property. The highest vCPU > id, ie. spapr_max_server_number(), is obtained from the machine > through the "nr_servers" argument of the generic spapr_i

Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30

2020-11-23 Thread Vladimir Sementsov-Ogievskiy
23.11.2020 13:10, Kevin Wolf wrote: Am 20.11.2020 um 19:19 hat Vladimir Sementsov-Ogievskiy geschrieben: 20.11.2020 20:22, Kevin Wolf wrote: Am 20.11.2020 um 17:43 hat Vladimir Sementsov-Ogievskiy geschrieben: 20.11.2020 19:36, Kevin Wolf wrote: Am 20.11.2020 um 17:16 hat Vladimir Sementsov-O

Re: [PATCH] gdbstub: Correct misparsing of vCont C/S requests

2020-11-23 Thread Philippe Mathieu-Daudé
On 11/21/20 10:03 PM, Peter Maydell wrote: > In the vCont packet, two of the command actions (C and S) take an > argument specifying the signal to be sent to the process/thread, which is > sent as an ASCII string of two hex digits which immediately follow the > 'C' or 'S' character. > > Our code f

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-23 Thread Markus Armbruster
Thomas Huth writes: > On 18/11/2020 15.30, Peter Maydell wrote: >> On Wed, 18 Nov 2020 at 14:24, Markus Armbruster wrote: >>> >>> Philippe Mathieu-Daudé writes: >>> On 11/18/20 10:03 AM, Thomas Huth wrote: > Both headers, sysbus.h and module.h, are not required to compile this > f

Re: [PATCH-for-5.2 0/6] MAINTAINERS: Fix docs/system/arm/ entries

2020-11-23 Thread Peter Maydell
On Fri, 20 Nov 2020 at 15:46, Philippe Mathieu-Daudé wrote: > > Correctly docs/system/arm/ rst files in MAINTAINERS. > > Philippe Mathieu-Daudé (6): > MAINTAINERS: Cover system/arm/cpu-features.rst with ARM TCG CPUs > MAINTAINERS: Cover system/arm/aspeed.rst with ASPEED BMC machines > MAINTA

Re: [PATCH-for-5.2 v2 0/4] docs/system/arm: Document raspi/tosa boards

2020-11-23 Thread Peter Maydell
On Fri, 20 Nov 2020 at 17:39, Philippe Mathieu-Daudé wrote: > > - Deprecate raspi2/raspi3 machine aliases > - Document the Raspberry Pi boards > - Document LED on OpenPOWER Witherspoon > - Document Sharp Zaurus SL-6000 Tosa > > Since v1: > - cover docs/system/arm/raspi.rst in MAINTAINERS > - Addre

Re: [PATCH RFC 0/5] Fix accidental crash in iotest 30

2020-11-23 Thread Kevin Wolf
Am 23.11.2020 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > 23.11.2020 13:10, Kevin Wolf wrote: > > Am 20.11.2020 um 19:19 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 20.11.2020 20:22, Kevin Wolf wrote: > > > > Am 20.11.2020 um 17:43 hat Vladimir Sementsov-Ogievskiy geschrieben:

[Bug 1886793] Re: "go install" command fails while running inside s390x docker container on x86_64 host using qemu

2020-11-23 Thread Nirman Narang
Any update on this? I tried the latest version of qemu-user-static, it still fails with the same error. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1886793 Title: "go install" command fails whil

Re: [PATCH v2 0/6] spapr/xive: Activate StoreEOI in P10 compat guests

2020-11-23 Thread Cédric Le Goater
On 11/23/20 7:44 AM, David Gibson wrote: > On Mon, Nov 02, 2020 at 02:22:35PM +0100, Cédric Le Goater wrote: >> Sorry for the late answer I was out for a couple of weeks. >> >> On 10/9/20 2:23 AM, David Gibson wrote: >>> On Mon, Oct 05, 2020 at 06:51:41PM +0200, Cédric Le Goater wrote: Hello,

Re: [PATCH for-6.0 2/8] spapr/xive: Introduce spapr_xive_nr_ends()

2020-11-23 Thread Greg Kurz
On Mon, 23 Nov 2020 10:46:38 +0100 Cédric Le Goater wrote: > On 11/20/20 6:46 PM, Greg Kurz wrote: > > We're going to kill the "nr_ends" field in a subsequent patch. > > why ? it is one of the tables of the controller and its part of > the main XIVE concepts. Conceptually, we could let the mach

Re: [PATCH 0/4] vhost-user: avoid g_return_val_if() in get/set_config()

2020-11-23 Thread Stefano Garzarella
On Wed, Nov 18, 2020 at 09:16:40AM +, Stefan Hajnoczi wrote: Markus Armbruster pointed out that g_return_val_if() is meant for programming errors. It must not be used for input validation since it can be compiled out. Use explicit if statements instead. This patch series converts vhost-user

Re: [PATCH for-6.0 3/8] spapr/xive: Add "nr-servers" property

2020-11-23 Thread Greg Kurz
On Mon, 23 Nov 2020 10:56:13 +0100 Cédric Le Goater wrote: > On 11/20/20 6:46 PM, Greg Kurz wrote: > > The sPAPR XIVE object has an "nr-ends" property that is used > > to size the END table. This property is set by the machine > > code to a value derived from spapr_max_server_number(). > > Yes.

[PULL 1/7] scripts/ci: clean up default args logic a little

2020-11-23 Thread Alex Bennée
This allows us to do: ./scripts/ci/gitlab-pipeline-status -w -b HEAD -p 2961854 to check out own pipeline status of a recently pushed branch. Signed-off-by: Alex Bennée Reviewed-by: Wainer dos Santos Moschetta Message-Id: <20201117173635.29101-2-alex.ben...@linaro.org> diff --git a/scripts/

[PULL 5/7] tests/docker: Install liblttng-ust-dev package in Ubuntu 20.04 image

2020-11-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé Install the liblttng-ust-dev package to be able to build QEMU using the User-Space Tracer trace backend (configure --enable-trace-backends=ust). Suggested-by: Wainer dos Santos Moschetta Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id:

[PULL 2/7] tests: add prefixes to the bare mkdtemp calls

2020-11-23 Thread Alex Bennée
The first step to debug a thing is to know what created the thing in the first place. Add some prefixes so random tmpdir's have something grep in the code. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Message-I

[PULL for 5.2-rc3 0/7] various CI cleanups (scripts, avocado, gitlab)

2020-11-23 Thread Alex Bennée
The following changes since commit 8cc30eb1400fc01f2b139cdd3dc524f8b84dbe07: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-20201122' into staging (2020-11-22 15:02:52 +) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-for-5.2-rc3-23

[PULL 7/7] .cirrus.yml: bump timeout period for MacOS builds

2020-11-23 Thread Alex Bennée
These seem to trigger timeouts with some regularity. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20201118140739.18377-1-alex.ben...@linaro.org> Signed-off-by: Alex Bennée diff --git a/.cirrus.yml b/.cirrus.yml index f0209b7a3e..08db7c419f 100644 --- a/.cirrus.yml +++ b/.ci

[PULL 3/7] tests/avocado: clean-up socket directory after run

2020-11-23 Thread Alex Bennée
Previously we were leaving temporary directories behind. While the QEMUMachine does make efforts to clean up after itself the directory belongs to the calling function. We use TemporaryDirectory to wrap this although we explicitly clear the reference in tearDown() as it doesn't get cleaned up other

[PULL 4/7] gitlab: move remaining x86 check-tcg targets to gitlab

2020-11-23 Thread Alex Bennée
The GCC check-tcg (user) test in particular was very prone to timing out on Travis. We only actually need to move the some-softmmu builds across as we already have coverage for linux-user. As --enable-debug-tcg does increase the run time somewhat as more debug is put in let's restrict that to just

Re: [PATCH v1 0/9] virtio-mem: vfio support

2020-11-23 Thread David Hildenbrand
On 19.11.20 16:39, David Hildenbrand wrote: > This is the follow-up of: > https://lkml.kernel.org/r/20200924160423.106747-1-da...@redhat.com > to make vfio and virtio-mem play together. The basic idea was the result of > Alex brainstorming with me on how to tackle this. > > A virtio-mem device m

[PULL 6/7] gitlab-ci: Move trace backend tests across to gitlab

2020-11-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé Similarly to commit 8cdb2cef3f1, move the trace backend tests to GitLab. Note the User-Space Tracer backend is still tested on Ubuntu by the s390x jobs on Travis-CI. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Acked-by: Thomas Huth Message-Id

Re: [PATCH 4/4] [broken] meson: try link tracepoints to module

2020-11-23 Thread Gerd Hoffmann
> You could build a separate dictionary in trace/meson.build. Instead of > using the 'hw_display_qxl' group, you use the module name i.e. > 'hw-display-qxl'. trace/meson.build does: > > module_trace = {} > > and in trace/meson.build > > module_trace_src = [] > foreach c : ... > ... >

physmem: Is 0644 OK for new created file?

2020-11-23 Thread Peng Liang
Hi, Recently, I tried to use ivshmem-plain devices to share some information between guests. I found that if the file of the shmem doesn't exist, then QEMU will create one and the mode of it is 0644. Maybe it is risky because everyone can read the content of the file? Do we need to change it to

[PULL 03/24] hw/intc: fix heap-buffer-overflow in rxicu_realize()

2020-11-23 Thread Peter Maydell
From: Chen Qun When 'j = icu->nr_sense – 1', the 'j < icu->nr_sense' condition is true, then 'j = icu->nr_sense', the'icu->init_sense[j]' has out-of-bounds access. The asan showed stack: ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60404d7d at pc 0x55852cd26a76 bp 0x7ffe39f262

[PULL 01/24] target/arm: fix stage 2 page-walks in 32-bit emulation

2020-11-23 Thread Peter Maydell
From: Rémi Denis-Courmont Using a target unsigned long would limit the Input Address to a LPAE page-walk to 32 bits on AArch32 and 64 bits on AArch64. This is okay for stage 1 or on AArch64, but it is insufficient for stage 2 on AArch32. In that later case, the Input Address can have up to 40 bit

[PULL 04/24] MAINTAINERS: Cover system/arm/cpu-features.rst with ARM TCG CPUs

2020-11-23 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20201120154545.2504625-2-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2e018a0c1da..a9c7

[PULL 00/24] target-arm queue

2020-11-23 Thread Peter Maydell
yland/tags/qemu-sparc-20201122' into staging (2020-11-22 15:02:52 +) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20201123 for you to fetch changes up to c6ff78563ad2971f289168c7cae6ecb0b4359516: docs/system/pr-m

[PULL 08/24] MAINTAINERS: Cover system/arm/sbsa.rst with SBSA-REF machine

2020-11-23 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20201120154545.2504625-6-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e653ff70d9d..33e4

[PULL 13/24] docs/system/arm: Document the Sharp Zaurus SL-6000

2020-11-23 Thread Peter Maydell
From: Philippe Mathieu-Daudé List the 'tosa' machine with the XScale-based PDAs models. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20201120173953.2539469-5-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- docs/system/arm/xscale.rst | 20 +---

[PULL 09/24] MAINTAINERS: Cover system/arm/sx1.rst with OMAP machines

2020-11-23 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20201120154545.2504625-7-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 33e44b023ae..6f46

[PULL 02/24] hw/arm: Fix bad print format specifiers

2020-11-23 Thread Peter Maydell
From: AlexChen We should use printf format specifier "%u" instead of "%i" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen Message-id: 5f9fd78b.8000...@huawei.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/arm/pxa2xx.c | 2 +- hw/arm

[PULL 20/24] docs: Split out 'pc' machine model docs into their own file

2020-11-23 Thread Peter Maydell
Currently target-i386.rst includes the documentation of the 'pc' machine model inline. Split it out into its own file, in a similar way to target-i386.rst; this gives us a place to put documentation of other i386 machine models, such as 'microvm'. Signed-off-by: Peter Maydell Reviewed-by: Alex Be

[PULL 10/24] docs/system: Deprecate raspi2/raspi3 machine aliases

2020-11-23 Thread Peter Maydell
From: Philippe Mathieu-Daudé Since commit aa35ec2213b ("hw/arm/raspi: Use more specific machine names") the raspi2/raspi3 machines have been renamed as raspi2b/raspi3b. Note, rather than the raspi3b, the raspi3ap introduced in commit 5be94252d34 ("hw/arm/raspi: Add the Raspberry Pi 3 model A+")

[PULL 11/24] docs/system/arm: Document the various raspi boards

2020-11-23 Thread Peter Maydell
From: Philippe Mathieu-Daudé Document the following Raspberry Pi models: - raspi0 Raspberry Pi Zero (revision 1.2) - raspi1ap Raspberry Pi A+ (revision 1.1) - raspi2b Raspberry Pi 2B (revision 1.1) - raspi3ap Raspberry Pi 3A+ (revision 1.0)

[PULL 05/24] MAINTAINERS: Cover system/arm/aspeed.rst with ASPEED BMC machines

2020-11-23 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Message-id: 20201120154545.2504625-3-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAIN

[PULL 15/24] linux-user/arm: Deliver SIGTRAP for UDF patterns used as breakpoints

2020-11-23 Thread Peter Maydell
The Linux kernel doesn't use the official bkpt insn for breakpoints; instead it uses three instructions in the guaranteed-to-UNDEF space, and generates SIGTRAP for these rather than the SIGILL that most UNDEF insns generate: https://elixir.bootlin.com/linux/v5.9.8/source/arch/arm/kernel/ptrace.c#L

[PULL 14/24] target/arm: Make SYS_HEAPINFO work with RAM that doesn't start at 0

2020-11-23 Thread Peter Maydell
The semihosting SYS_HEAPINFO call is supposed to return an array of four guest addresses: * base of heap memory * limit of heap memory * base of stack memory * limit of stack memory Some semihosting programs (including those compiled to use the 'newlib' embedded C library) use this call to wor

[PULL 06/24] MAINTAINERS: Cover system/arm/nuvoton.rst with Nuvoton NPCM7xx

2020-11-23 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20201120154545.2504625-4-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 02f8b6f696c..5e47

[PULL 18/24] docs: Move virtio-pmem.rst into the system manual

2020-11-23 Thread Peter Maydell
Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée --- docs/system/index.rst | 1 + docs/{ => system}/virtio-pmem.rst | 0 2 files changed, 1 insertion(+) rename docs/{ => system}/virtio-pmem.rst (100%) diff --git a/docs/system/index.rst b/docs/system/index.rst index 0f0f6d2e99d

[PULL 21/24] docs: Move microvm.rst into the system manual

2020-11-23 Thread Peter Maydell
Now that target-i386.rst has a place to list documentation of machines other than the 'pc' machine, we have a place we can move the microvm documentation to. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée --- docs/{ => system/i386}/microvm.rst | 5 ++--- docs/system/target-i386.rst

[PULL 0/3] s390-ccw bios reboot fixes

2020-11-23 Thread Thomas Huth
Hi Peter, the following changes since commit 8cc30eb1400fc01f2b139cdd3dc524f8b84dbe07: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-20201122' into staging (2020-11-22 15:02:52 +) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pull-reque

[PULL 07/24] MAINTAINERS: Fix system/arm/orangepi.rst path

2020-11-23 Thread Peter Maydell
From: Philippe Mathieu-Daudé Fixes: 0553ef42571 ("docs: add Orange Pi PC document") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Niek Linnenbank Message-id: 20201120154545.2504625-5-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- MAINTAINERS | 2 +- 1 file c

[PULL 22/24] docs: Move pr-manager.rst into the system manual

2020-11-23 Thread Peter Maydell
Move the pr-manager documentation into the system manual. Some of it (the documentation of the pr-manager-helper tool) should be in tools, but we will split it up after moving it. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée --- docs/system/index.rst| 1 + docs/{ => system}

[PULL 12/24] docs/system/arm: Document OpenPOWER Witherspoon BMC model Front LEDs

2020-11-23 Thread Peter Maydell
From: Philippe Mathieu-Daudé Document the 3 front LEDs modeled on the OpenPOWER Witherspoon BMC (see commit 7cfbde5ea1c "hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1"). Reviewed-by: Cédric Le Goater Signed-off-by: Philippe Mathieu-Daudé Message-id: 20201120173953.2539469-4-f4..

[PULL 1/3] pc-bios: s390x: Ensure Read IPL memory is clean

2020-11-23 Thread Thomas Huth
From: Eric Farman If, for example, we boot off a virtio device and chreipl to a vfio-ccw device, the space at lowcore will be non-zero. We build a Read IPL CCW at address zero, but it will have leftover PSW data that will conflict with the Format-0 CCW being generated: 0x0: 0008 8001

[PULL 23/24] docs: Split qemu-pr-helper documentation into tools manual

2020-11-23 Thread Peter Maydell
Split the documentation of the qemu-pr-helper binary into the tools manual, and give it a manpage like our other standalone executables. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée --- docs/meson.build | 1 + docs/system/pr-manager.rst| 38 ++- docs/tools

[PULL 2/3] pc-bios: s390x: Clear out leftover S390EP string

2020-11-23 Thread Thomas Huth
From: Eric Farman A Linux binary will have the string "S390EP" at address 0x10008, which is important in getting the guest up off the ground. In the case of a reboot (specifically chreipl going to a new device), we should defer to the PSW at address zero for the new config, which will re-write "S

[PULL 24/24] docs/system/pr-manager.rst: Fix minor docs nits

2020-11-23 Thread Peter Maydell
Fix a couple of nits in pr-manager.rst: * the title marker for the top level heading is overlength * stray capital 'R' in the middle of a sentence Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée --- docs/system/pr-manager.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PULL 16/24] docs: Move virtio-net-failover.rst into the system manual

2020-11-23 Thread Peter Maydell
The virtio-net-failover documentation is currently orphan and not included in any manual; move it into the system manual, immediately following the general network emulation section. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée --- docs/system/index.rst | 1 + docs/

[PULL 17/24] docs: Move cpu-hotplug.rst into the system manual

2020-11-23 Thread Peter Maydell
The cpu-hotplug.rst documentation is currently orphan and not included in any manual; move it into the system manual. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée --- docs/{ => system}/cpu-hotplug.rst | 0 docs/system/index.rst | 1 + 2 files changed, 1 insertion(+) rename

Re: [Bug 1892540] Re: qemu can no longer boot NetBSD/sparc

2020-11-23 Thread mst
Seems to at least do the innital part of the boot ok. I got to shell at least: not sure how far I'm supposed to get or which options to choose. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1892540 T

[PULL 19/24] docs/system/virtio-pmem.rst: Fix minor style issues

2020-11-23 Thread Peter Maydell
The virtio-pmem documentation has some minor style issues we hadn't noticed since we weren't rendering it in our docs: * Sphinx doesn't complain about overlong title-underlining the way it complains about too-short underlining, but it looks odd; make the underlines of section headers the ri

Re: [PATCH for-6.0 4/9] spapr: Set compat mode in spapr_reset_vcpu()

2020-11-23 Thread Greg Kurz
On Mon, 23 Nov 2020 16:11:30 +1100 David Gibson wrote: > On Sat, Nov 21, 2020 at 12:42:03AM +0100, Greg Kurz wrote: > > When it comes to resetting the compat mode of the vCPUS, there are > > two situations to consider: > > (1) machine reset should set the compat mode back to the machine default,

Re: [Bug 1886793] Re: "go install" command fails while running inside s390x docker container on x86_64 host using qemu

2020-11-23 Thread Laurent Vivier
Le 23/11/2020 à 12:03, Nirman Narang a écrit : > Any update on this? > I tried the latest version of qemu-user-static, it still fails with the same > error. > It works fine for me. Perhaps your chroot has been corrupted by your previous attempts -- You received this bug notification because yo

[PULL 3/3] pc-bios/s390: Update the s390-ccw bios binaries

2020-11-23 Thread Thomas Huth
Update the binaries with the two reboot fixes from Eric Farman. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw.img | Bin 46704 -> 42608 bytes pc-bios/s390-netboot.img | Bin 71328 -> 67232 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bios/s

Re: [PATCH v5 0/2] MTE support for KVM guest

2020-11-23 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Thu, 19 Nov 2020 at 15:39, Steven Price wrote: > > This series adds support for Arm's Memory Tagging Extension (MTE) to > > KVM, allowing KVM guests to make use of it. This builds on the existing > > user space support already in v5.10-rc1, se

[Bug 1886793] Re: "go install" command fails while running inside s390x docker container on x86_64 host using qemu

2020-11-23 Thread Nirman Narang
Let me try again using the following commands on a fresh x86 host. #apt install debootstrap #debootstrap_dir=debootstrap #debootstrap --arch=s390x --foreign sid "$debootstrap_dir" #sudo mkdir -p "${debootstrap_dir}/usr/bin" #sudo cp "$(which qemu-s390x-static)" "${debootstrap_dir}/usr/bin" #sudo c

Re: [PATCH v4 1/2] hw/misc: add an EMC141{3,4} device model

2020-11-23 Thread Cédric Le Goater
On 11/22/20 11:51 AM, John Wang wrote: > Largely inspired by the TMP421 temperature sensor, here is a model for > the EMC1413/EMC1414 temperature sensors. > > Specs can be found here : > http://ww1.microchip.com/downloads/en/DeviceDoc/20005274A.pdf > > Signed-off-by: John Wang Reviewed-by: Cé

Re: [raw] Guest stuck during live live-migration

2020-11-23 Thread Kevin Wolf
[ Cc: qemu-block ] Am 23.11.2020 um 10:36 hat Quentin Grolleau geschrieben: > Hello, > > In our company, we are hosting a large number of Vm, hosted behind Openstack > (so libvirt/qemu). > A large majority of our Vms are runnign with local data only, stored on NVME, > and most of them are RAW d

Re: [PATCH-for-6.0 0/2] exec: Ensure variable page size is only used with TARGET_PAGE_BITS_VARY

2020-11-23 Thread Philippe Mathieu-Daudé
ping? On 11/4/20 10:35 AM, Philippe Mathieu-Daudé wrote: > Simple patch while trying to figure out Fuloong-2E 16KB page size. > Better safe than sorry =) > > Philippe Mathieu-Daudé (2): > MAINTAINERS: Cover exec-vary.c (variable page size) > exec: Ensure variable page size is only used with >

Re: [PATCH-for-6.0 0/2] hw/scsi/scsi-disk: QOM style change

2020-11-23 Thread Philippe Mathieu-Daudé
ping? On 11/6/20 6:04 PM, Philippe Mathieu-Daudé wrote: > Some QOM style changes in TYPE_SCSI_DISK to follow > the rest of the codebase style. No logical change. > > Philippe Mathieu-Daudé (2): > hw/scsi/scsi-disk: Rename type as TYPE_SCSI_DISK > hw/scsi/scsi-disk: Use SCSI_DISK_GET_CLASS() m

[Bug 1775011] Re: -display gtk,gl=on crashes on Wayland

2020-11-23 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

Re: [PATCH-for-5.2] docs/user: Display linux-user binaries nicely

2020-11-23 Thread Philippe Mathieu-Daudé
ping? On 11/19/20 5:21 PM, Philippe Mathieu-Daudé wrote: > On 11/19/20 5:08 PM, Philippe Mathieu-Daudé wrote: >> linux-user binaries are displayed altogether. Use the '*' >> character to force displaying them as bullet list (one list >> per architecture). >> >> Signed-off-by: Philippe Mathieu-Daud

Re: [PULL 00/33] Block patches

2020-11-23 Thread Philippe Mathieu-Daudé
On 11/4/20 9:59 PM, Peter Maydell wrote: > On Wed, 4 Nov 2020 at 15:18, Stefan Hajnoczi wrote: >> >> The following changes since commit 8507c9d5c9a62de2a0e281b640f995e26eac46af: >> >> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into >> staging (2020-11-03 15:59:44 +) >> >

Re: [PULL for 5.2-rc3 0/7] various CI cleanups (scripts, avocado, gitlab)

2020-11-23 Thread Peter Maydell
On Mon, 23 Nov 2020 at 11:25, Alex Bennée wrote: > > The following changes since commit 8cc30eb1400fc01f2b139cdd3dc524f8b84dbe07: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-20201122' > into staging (2020-11-22 15:02:52 +) > > are available in the Git repository at: >

[PATCH] target/i386: fix operand order for PDEP and PEXT

2020-11-23 Thread Paolo Bonzini
For PDEP and PEXT, the mask is provided in the memory (mod+r/m) operand, and therefore is loaded in s->T0 by gen_ldst_modrm. The source is provided in the second source operand (VEX.) and therefore is loaded in s->T1. Fix the order in which they are passed to the helpers. Reported-by: Lenard

[Bug 1613817] Re: x86: ret, lret and iret with noncanonical IP saves wrong IP on the exception stack

2020-11-23 Thread Vda-linux
Still happens with qemu 5.1.92 ** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1613817 Title: x86: ret, lret and iret with noncanonical IP saves

Re: [PATCH 4/4] [broken] meson: try link tracepoints to module

2020-11-23 Thread Paolo Bonzini
On 23/11/20 12:38, Gerd Hoffmann wrote: So basically keep track of the objects separately. Got that working for the modular builds. Progress!!! Non-modular builds fail due to missing qxl tracepoints. Tried to fix that with a simple 'softmmu_ss.add(module_trace_src)'. Mentioned in https://wi

  1   2   3   4   >