Re: [PATCH-for-5.2? 1/2] tests/qtest: variable defined by g_autofree need to be initialized

2020-11-19 Thread Peter Maydell
On Wed, 18 Nov 2020 at 11:57, Chen Qun wrote: > > According to the glib function requirements, we need initialise > the variable. Otherwise there will be compilation warnings: > > glib-autocleanups.h:28:3: warning: ‘full_name’ may be > used uninitialized in this function [-Wmaybe-uninitialized] >

RE: [PATCH-for-5.2? 1/2] tests/qtest: variable defined by g_autofree need to be initialized

2020-11-19 Thread Chenqun (kuhn)
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Thursday, November 19, 2020 4:26 PM > To: Chenqun (kuhn) > Cc: QEMU Developers ; QEMU Trivial > ; Hao Wu ; Havard > Skinnemoen ; Zhanghailiang > ; Thomas Huth ; > Laurent Vivier ; Euler Robot > Subject: R

Re: [PATCH-for-5.2? 1/2] tests/qtest: variable defined by g_autofree need to be initialized

2020-11-19 Thread Peter Maydell
On Thu, 19 Nov 2020 at 08:35, Chenqun (kuhn) wrote: > > > -Original Message- > > > static void tim_add_test(const char *name, const TestData *td, > > > GTestDataFunc fn) { > > > -g_autofree char *full_name; > > > - > > > -full_name = g_strdup_printf("npcm7xx_timer/tim[%d]/timer[%

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-19 Thread Kirti Wankhede
On 11/14/2020 2:47 PM, Shenming Lu wrote: When running VFIO migration, I found that the restoring of VFIO PCI device’s config space is before VGIC on ARM64 target. But generally, interrupt controllers need to be restored before PCI devices. Is there any other way by which VGIC can be resto

[PATCH 4/4] [broken] meson: try link tracepoints to module

2020-11-19 Thread Gerd Hoffmann
Add source set to trace_events_config, use it in trace/meson.build so the trace objects are linked to the module not core qemu. Not working as intended. /me looks puzzled. Signed-off-by: Gerd Hoffmann --- hw/display/meson.build | 1 + trace/meson.build | 9 + 2 files changed, 6 ins

[PATCH 0/4] [RfC] try fix tracing for modules

2020-11-19 Thread Gerd Hoffmann
Problem only partly solved so far. Building separate object files for modules works. Actually linking those to the module not yet. See last patch of the series for my not working approach. More context: https://bugzilla.redhat.com/show_bug.cgi?id=1898700 https://bugzilla.redhat.com/show_bug.cg

[PATCH 3/4] meson: move qxl trace events to separate file

2020-11-19 Thread Gerd Hoffmann
Move qxl trace events to separate trace-events-qxl file. Signed-off-by: Gerd Hoffmann --- hw/display/qxl-render.c | 1 + hw/display/qxl.c| 1 + hw/display/meson.build | 4 +++ hw/display/trace-events | 67 - hw/display/trace-events-

[PATCH 1/4] meson: add trace_events_config[]

2020-11-19 Thread Gerd Hoffmann
It's an array of dicts, where each dict holds the configuration for one trace-events file. For now just fill it from trace_events_subdirs. Signed-off-by: Gerd Hoffmann --- meson.build | 1 + trace/meson.build | 21 - 2 files changed, 17 insertions(+), 5 deletions(-)

[PATCH] qga: Correct loop count in qmp_guest_get_vcpus()

2020-11-19 Thread Lin Ma
The guest-get-vcpus returns incorrect vcpu info in case we hotunplug vcpus(not the last one). e.g.: A VM has 4 VCPUs: cpu0 + 3 hotunpluggable online vcpus(cpu1, cpu2 and cpu3). Hotunplug cpu2, Now only cpu0, cpu1 and cpu3 are present & online. ./qmp-shell /tmp/qmp-monitor.sock (QEMU) query-hotplu

[PATCH 2/4] meson: move up hw subdir (specifically before trace subdir)

2020-11-19 Thread Gerd Hoffmann
Needed so trace/meson.build can see stuff done in hw/*/meson.build. Signed-off-by: Gerd Hoffmann --- meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 04bd9b57e401..41009b9685de 100644 --- a/meson.build +++ b/meson.build @@ -1456,6

Re: [PATCH v2 7/7] qapi: More complex uses of QAPI_LIST_APPEND

2020-11-19 Thread Markus Armbruster
Eric Blake writes: > These cases require a bit more thought to review; in each case, the > code was appending to a list, but not with a FOOList **tail variable. > > Signed-off-by: Eric Blake > --- > block/gluster.c| 13 +--- > block/qapi.c | 14 + > dump/dump.c

Re: [RFC v3 9/9] i386: split cpu accelerators from cpu.c

2020-11-19 Thread Claudio Fontana
Hi, On 11/18/20 7:28 PM, Eduardo Habkost wrote: > On Wed, Nov 18, 2020 at 11:29:36AM +0100, Claudio Fontana wrote: >> split cpu.c into: >> >> cpu.ccpuid and common x86 cpu functionality >> host-cpu.c host x86 cpu functions and "host" cpu type >> kvm/cpu.cKVM x86 cpu type

Re: [PATCH RFC v3 23/23] i386: provide simple 'hyperv=on' option to x86 machine types

2020-11-19 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Fri, Oct 09, 2020 at 02:18:42PM +0200, Vitaly Kuznetsov wrote: >> Enabling Hyper-V emulation for a Windows VM is a tiring experience as it >> requires listing all currently supported enlightenments ("hv_*" CPU >> features) explicitly. We do have a 'hv_passthrough' mod

Re: [PATCH v2 0/7] UFFD write-tracking migration/snapshots

2020-11-19 Thread Andrey Gruzdev
On 18.11.2020 16:20, Andrey Gruzdev wrote: Currently the only way to make (external) live VM snapshot is using existing dirty page logging migration mechanism. The main problem is that it tends to produce a lot of page duplicates while running VM goes on updating already saved pages. That leads t

[PATCH] virtio-blk: seg_max do not subtract 2 if host has VIRTIO_RING_F_INDIRECT_DESC feature

2020-11-19 Thread zhaoxin\RockCuioc
This patch modify virtio-blk seg_max when host has VIRTIO_RING_F_INDIRECT_DESC feature, when read/write virtio-blk disk in direct mode, this patch can make the bio reach 512k but not 504k if the user buffer physical segments are all discontinuous,when use ceph the size of 504k will affect perfo

Re: [PATCH] virtio-blk: seg_max do not subtract 2 if host has VIRTIO_RING_F_INDIRECT_DESC feature

2020-11-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201119085437.5333-1-rockcui...@zhaoxin.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201119085437.5333-1-rockcui...@zhaoxin.com Subject: [PATCH] virtio-blk: seg_max do no

Re: [PATCH] display/vmware_vga: Fix bad printf format specifiers

2020-11-19 Thread Alex Chen
Hi Philippe, On 2020/11/19 14:16, Philippe Mathieu-Daudé wrote: > Hi Alex, > > On 11/19/20 4:01 AM, Alex Chen wrote: >> We should use printf format specifier "%u" instead of "%d" for >> argument of type "unsigned int". >> >> Reported-by: Euler Robot >> Signed-off-by: Alex Chen >> --- >> hw/dis

[PATCH for-5.2] target/arm: Make SYS_HEAPINFO work with RAM that doesn't start at 0

2020-11-19 Thread Peter Maydell
The semihosting SYS_HEAPINFO call is supposed to return an array of four guest addresses: * base of heap memory * limit of heap memory * base of stack memory * limit of stack memory Some semihosting programs (including those compiled to use the 'newlib' embedded C library) use this call to wor

Re: [PATCH v2 0/7] Common macros for QAPI list growth

2020-11-19 Thread Markus Armbruster
Eric Blake writes: > v1, as such, was here: > https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg08003.html > (v6 11/11 qapi: Use QAPI_LIST_ADD() where possible) > > since then, I've rebased that patch (upstream went with PREPEND > instead of ADD), split things out for easier review, added

Re: [PATCH] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD

2020-11-19 Thread Daniel P . Berrangé
On Thu, Nov 19, 2020 at 03:37:50PM +0800, AL Yu-Chen Cho wrote: > On Tue, 2020-11-17 at 12:51 +0100, Thomas Huth wrote: > > On 17/11/2020 07.57, Cho, Yu-Chen wrote: > > > Add build-system-opensuse jobs and add opensuse-leap.docker > > > dockerfile. > > > Use openSUSE Leap 15.2 container image in th

Re: [PATCH 3/4] meson: move qxl trace events to separate file

2020-11-19 Thread Daniel P . Berrangé
On Thu, Nov 19, 2020 at 09:44:47AM +0100, Gerd Hoffmann wrote: > Move qxl trace events to separate trace-events-qxl file. > > Signed-off-by: Gerd Hoffmann > --- > hw/display/qxl-render.c | 1 + > hw/display/qxl.c| 1 + > hw/display/meson.build | 4 +++ > hw/display/trace-

[Bug 393569] Re: qemu cannot load multiple initramfs archives

2020-11-19 Thread Thomas Huth
Looking through old bug tickets... If I've got that right, there is multiboot support in QEMU nowadays, and we also have the possibility to load multiple files with the "loader" device ... is that enough, or is still something to be done here? ** Changed in: qemu Status: Confirmed => Incomp

Re: [PATCH v2 1/8] qobject: Include API docs in docs/devel/qobject.html

2020-11-19 Thread Markus Armbruster
Eduardo Habkost writes: > Render existing doc comments at docs/devel/qobject.html. > > Signed-off-by: Eduardo Habkost > --- > docs/devel/index.rst | 1 + > docs/devel/qobject.rst | 11 + > include/qapi/qmp/qnum.h| 4 +++- > include/qapi/qmp/qobject.h | 48 +++

Re: [PATCH] trace: use STAP_SDT_V2 to work around symbol visibility

2020-11-19 Thread Stefan Hajnoczi
On Wed, Nov 18, 2020 at 05:51:28PM +, Daniel P. Berrangé wrote: > On Wed, Nov 18, 2020 at 05:48:09PM +, Stefan Hajnoczi wrote: > > QEMU binaries no longer launch successfully with recent SystemTap > > releases. This is because modular QEMU builds link the sdt semaphores > > into the main bi

Re: [PATCH 1/4] meson: add trace_events_config[]

2020-11-19 Thread Stefan Hajnoczi
On Thu, Nov 19, 2020 at 09:44:45AM +0100, Gerd Hoffmann wrote: > It's an array of dicts, where each dict holds the configuration for one > trace-events file. For now just fill it from trace_events_subdirs. > > Signed-off-by: Gerd Hoffmann > --- > meson.build | 1 + > trace/meson.build |

[Bug 498523] Re: Add on-line write compression support to qcow2

2020-11-19 Thread Thomas Huth
As far as I know, QEMU v5.1 now has support for compression filters, e.g. by creating a qcow2 image with: qemu-img create -f qcow2 -o compression_type=zlib image.qcow2 1G ... so I think we can finally mark this ticket here as done. ** Changed in: qemu Status: Confirmed => Fix Released -

Re: [PATCH 2/4] meson: move up hw subdir (specifically before trace subdir)

2020-11-19 Thread Stefan Hajnoczi
On Thu, Nov 19, 2020 at 09:44:46AM +0100, Gerd Hoffmann wrote: > Needed so trace/meson.build can see > stuff done in hw/*/meson.build. > > Signed-off-by: Gerd Hoffmann > --- > meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > inde

Re: [PATCH 3/4] meson: move qxl trace events to separate file

2020-11-19 Thread Stefan Hajnoczi
On Thu, Nov 19, 2020 at 09:44:47AM +0100, Gerd Hoffmann wrote: > Move qxl trace events to separate trace-events-qxl file. > > Signed-off-by: Gerd Hoffmann Can we put modules into their own subdirs so that the existing meson and tracing infrastructure (e.g. scripts/cleanup-trace-events.pl) can ha

[PULL for-5.2 1/3] s390/kvm: fix diag318 propagation and reset functionality

2020-11-19 Thread Cornelia Huck
From: Collin Walling The Control Program Name Code (CPNC) portion of the diag318 info must be set within the SIE block of each VCPU in the configuration. The handler will iterate through each VCPU and dirty the diag318_info reg to be synced with KVM on a subsequent sync_regs call. Additionally,

[PULL for-5.2 2/3] s390x/pci: Unregister listeners before destroying IOMMU address space

2020-11-19 Thread Cornelia Huck
From: Matthew Rosato Hot-unplugging a vfio-pci device on s390x causes a QEMU crash: qemu-system-s390x: ../softmmu/memory.c:2772: do_address_space_destroy: Assertion `QTAILQ_EMPTY(&as->listeners)' failed. In s390, the IOMMU address space is freed during device unplug but the associated vfio-pci

[PULL for-5.2 0/3] s390x fixes

2020-11-19 Thread Cornelia Huck
tags/s390x-20201119 for you to fetch changes up to a4e2fff1b104f2b235ea2673968d0b0383f541dc: s390x/pci: fix endianness issues (2020-11-18 16:59:29 +0100) s390x fixes: - fix propagation and reset for the new diag318 call - fix hot-unplu

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-19 Thread Markus Armbruster
Marc-André Lureau writes: > On Tue, Nov 17, 2020 at 6:42 PM Eduardo Habkost wrote: > >> On Tue, Nov 17, 2020 at 12:37:56PM +0400, Marc-André Lureau wrote: >> > On Tue, Nov 17, 2020 at 2:43 AM Eduardo Habkost >> wrote: >> > >> > > Provide a separate QNumValue type that can be used for QNum value

[PULL for-5.2 3/3] s390x/pci: fix endianness issues

2020-11-19 Thread Cornelia Huck
The zPCI group and function structures are big endian. However, we do not consistently store them as big endian locally, and are missing some conversions. Let's just store the structures as host endian instead and convert to big endian when actually handling the instructions retrieving the data.

Re: [PATCH 3/4] meson: move qxl trace events to separate file

2020-11-19 Thread Gerd Hoffmann
On Thu, Nov 19, 2020 at 10:06:40AM +, Stefan Hajnoczi wrote: > On Thu, Nov 19, 2020 at 09:44:47AM +0100, Gerd Hoffmann wrote: > > Move qxl trace events to separate trace-events-qxl file. > > > > Signed-off-by: Gerd Hoffmann > > Can we put modules into their own subdirs so that the existing m

Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function

2020-11-19 Thread Markus Armbruster
Eduardo Habkost writes: > Extract the QNum value comparison logic to a function that takes > QNumValue* as argument. > > Signed-off-by: Eduardo Habkost > --- > include/qapi/qmp/qnum.h | 1 + > qobject/qnum.c | 29 +++-- > 2 files changed, 20 insertions(+), 10 d

[PATCH 1/5] i386: move hyperv_vendor_id initialization to x86_cpu_realizefn()

2020-11-19 Thread Vitaly Kuznetsov
As a preparation to expanding Hyper-V CPU features early, move hyperv_vendor_id initialization to x86_cpu_realizefn(). Introduce x86_cpu_hyperv_realize() to not not pollute x86_cpu_realizefn() itself. Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 23 ++- target/i386

[PATCH 2/5] i386: move hyperv_interface_id initialization to x86_cpu_realizefn()

2020-11-19 Thread Vitaly Kuznetsov
As a preparation to expanding Hyper-V CPU features early, move hyperv_interface_id initialization to x86_cpu_realizefn(). Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 6 ++ target/i386/cpu.h | 1 + target/i386/kvm.c | 18 -- 3 files changed, 19 insertions(+), 6 d

[PATCH 3/5] i386: move hyperv_version_id initialization to x86_cpu_realizefn()

2020-11-19 Thread Vitaly Kuznetsov
As a preparation to expanding Hyper-V CPU features early, move hyperv_version_id initialization to x86_cpu_realizefn(). Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 4 target/i386/cpu.h | 1 + target/i386/kvm.c | 14 -- 3 files changed, 17 insertions(+), 2 deletions

[PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2020-11-19 Thread Vitaly Kuznetsov
Enabling Hyper-V emulation for a Windows VM is a tiring experience as it requires listing all currently supported enlightenments ("hv_*" CPU features) explicitly. We do have a 'hv_passthrough' mode enabling everything but it can't be used in production as it prevents migration. Introduce a simple

[PATCH 0/5] i386: simplify Hyper-V enlightenments enablement

2020-11-19 Thread Vitaly Kuznetsov
This series is a part of the previously sent "[PATCH RFC v3 00/23] i386: KVM: expand Hyper-V features early": https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg02443.html We're not ready to merge the full patch set yet because the required KVM capability is only queued for 5.11. We can, how

[PATCH 4/5] i386: move hyperv_limits initialization to x86_cpu_realizefn()

2020-11-19 Thread Vitaly Kuznetsov
As a preparation to expanding Hyper-V CPU features early, move hyperv_limits initialization to x86_cpu_realizefn(). Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 5 + target/i386/cpu.h | 1 + target/i386/kvm.c | 13 - 3 files changed, 18 insertions(+), 1 deletion(-)

Re: [PATCH] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD

2020-11-19 Thread Alex Bennée
AL Yu-Chen Cho writes: > On Tue, 2020-11-17 at 12:51 +0100, Thomas Huth wrote: >> On 17/11/2020 07.57, Cho, Yu-Chen wrote: >> > Add build-system-opensuse jobs and add opensuse-leap.docker >> > dockerfile. >> > Use openSUSE Leap 15.2 container image in the gitlab-CI. >> > >> > Signed-off-by: Ch

Re: [PATCH v2 5/8] qlit: Support all types of QNums

2020-11-19 Thread Markus Armbruster
Marc-André Lureau writes: > On Tue, Nov 17, 2020 at 2:48 AM Eduardo Habkost wrote: > >> Use QNumValue to represent QNums, so we can also support uint64_t >> and double QNum values. Add new QLIT_QNUM_(INT|UINT|DOUBLE) >> macros for each case. >> >> The QLIT_QNUM() macro is being kept for compati

[RFC PATCH v2 1/5] net: Added SetSteeringEBPF method for NetClientState.

2020-11-19 Thread Andrew Melnychenko
From: Andrew For now, that method supported only by Linux TAP. Linux TAP uses TUNSETSTEERINGEBPF ioctl. Signed-off-by: Andrew Melnychenko --- include/net/net.h | 2 ++ net/tap-bsd.c | 5 + net/tap-linux.c | 13 + net/tap-linux.h | 1 + net/tap-solaris.c | 5 + n

[RFC PATCH v2 0/5] eBPF RSS support for virtio-net

2020-11-19 Thread Andrew Melnychenko
This set of patches introduces the usage of eBPF for packet steering and RSS hash calculation: * RSS(Receive Side Scaling) is used to distribute network packets to guest virtqueues by calculating packet hash * Additionally adding support for the usage of RSS with vhost The eBPF works on kernels 5.

[RFC PATCH v2 4/5] virtio-net: Added eBPF RSS to virtio-net.

2020-11-19 Thread Andrew Melnychenko
From: Andrew When RSS is enabled the device tries to load the eBPF program to select RX virtqueue in the TUN. If eBPF can be loaded the RSS will function also with vhost (works with kernel 5.8 and later). Software RSS is used as a fallback with vhost=off when eBPF can't be loaded or when hash pop

[RFC PATCH v2 3/5] ebpf: Added eBPF RSS loader.

2020-11-19 Thread Andrew Melnychenko
From: Andrew Added function that loads RSS eBPF program. Added stub functions for RSS eBPF loader. Added meson and configuration options. By default, eBPF feature enabled if libbpf is present in the build system. libbpf checked in configuration shell script and meson script. Signed-off-by: Yuri

Re: [PATCH v2 6/8] qlit: qlit_type() function

2020-11-19 Thread Markus Armbruster
Eduardo Habkost writes: > Useful function where we need to check for the qlit type before > converting it to an actual QObject. > > Signed-off-by: Eduardo Habkost > --- > include/qapi/qmp/qlit.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/include/qapi/qmp/qlit.h b/include/qapi

[RFC PATCH v2 5/5] docs: Added eBPF documentation.

2020-11-19 Thread Andrew Melnychenko
From: Andrew Also, added maintainers information. Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko --- MAINTAINERS | 7 +++ docs/ebpf_rss.rst | 133 ++ 2 files changed, 140 insertions(+) create mode 100644 docs/ebpf_rss.rst

Re: [PATCH 1/2] file-posix: Use OFD lock only if the filesystem supports the lock

2020-11-19 Thread Kevin Wolf
Am 18.11.2020 um 20:48 hat Masayoshi Mizuma geschrieben: > On Wed, Nov 18, 2020 at 02:10:36PM -0500, Masayoshi Mizuma wrote: > > On Wed, Nov 18, 2020 at 04:42:47PM +0100, Kevin Wolf wrote: > > > Am 06.11.2020 um 05:01 hat Masayoshi Mizuma geschrieben: > > > > From: Masayoshi Mizuma > > > > > > >

Re: [PATCH 4/4] [broken] meson: try link tracepoints to module

2020-11-19 Thread Stefan Hajnoczi
On Thu, Nov 19, 2020 at 09:44:48AM +0100, Gerd Hoffmann wrote: > Add source set to trace_events_config, use it in trace/meson.build > so the trace objects are linked to the module not core qemu. > > Not working as intended. > /me looks puzzled. > > Signed-off-by: Gerd Hoffmann > --- > hw/displa

RFC: Pull request testing expectations for subsystem maintainers

2020-11-19 Thread Daniel P . Berrangé
This is a longish mail, so [tldr] I propose that we require subsystem maintainers to run GitLab CI pipeline /before/ sending pull requests to qemu-devel. This will * reduce the burden on the person merging pull requests by making it less likely merge tests will fail, thus avoiding v2/

RE: [PATCH-for-5.2? 1/2] tests/qtest: variable defined by g_autofree need to be initialized

2020-11-19 Thread Chenqun (kuhn)
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Thursday, November 19, 2020 4:39 PM > To: Chenqun (kuhn) > Cc: QEMU Developers ; QEMU Trivial > ; Hao Wu ; Havard > Skinnemoen ; Zhanghailiang > ; Thomas Huth ; > Laurent Vivier ; Euler Robot > Subject: R

Re: [PATCH 4/4] [broken] meson: try link tracepoints to module

2020-11-19 Thread Gerd Hoffmann
Hi, > > diff --git a/trace/meson.build b/trace/meson.build > > index 66395d3e2ba7..3f0fe7b7b74c 100644 > > --- a/trace/meson.build > > +++ b/trace/meson.build > > @@ -18,6 +18,7 @@ foreach c : trace_events_config > >trace_events_files += [ trace_events_file ] > >group = '--group=' + c.ge

Re: [PATCH for-5.2] target/arm: Make SYS_HEAPINFO work with RAM that doesn't start at 0

2020-11-19 Thread Alex Bennée
Peter Maydell writes: > The semihosting SYS_HEAPINFO call is supposed to return an array > of four guest addresses: > * base of heap memory > * limit of heap memory > * base of stack memory > * limit of stack memory > > Some semihosting programs (including those compiled to use the > 'newli

[PATCH v2] trace: use STAP_SDT_V2 to work around symbol visibility

2020-11-19 Thread Stefan Hajnoczi
QEMU binaries no longer launch successfully with recent SystemTap releases. This is because modular QEMU builds link the sdt semaphores into the main binary instead of into the shared objects where they are used. The symbol visibility of semaphores is 'hidden' and the dynamic linker prints an error

Re: [PATCH for-5.2] target/arm: Make SYS_HEAPINFO work with RAM that doesn't start at 0

2020-11-19 Thread Peter Maydell
On Thu, 19 Nov 2020 at 11:26, Alex Bennée wrote: > Peter Maydell writes: > > QEMU's implementation when in system emulation mode is very > > simplistic: we say that the heap starts halfway into RAM and > > continues to the end of RAM, and the stack starts at the top of RAM > > and works down to t

Re: [PATCH v2] trace: use STAP_SDT_V2 to work around symbol visibility

2020-11-19 Thread Daniel P . Berrangé
On Thu, Nov 19, 2020 at 11:27:04AM +, Stefan Hajnoczi wrote: > QEMU binaries no longer launch successfully with recent SystemTap > releases. This is because modular QEMU builds link the sdt semaphores > into the main binary instead of into the shared objects where they are > used. The symbol vi

Re: [RFC PATCH 3/5] hw/arm: Convert assertions about flash image size to error_report

2020-11-19 Thread Alex Bennée
David Edmondson writes: > Rather than throwing an assertion, provide a more detailed report if a > flash image is inappropriately sized or aligned. > > Signed-off-by: David Edmondson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH-for-5.2 v2] trace: use STAP_SDT_V2 to work around symbol visibility

2020-11-19 Thread Philippe Mathieu-Daudé
On 11/19/20 12:27 PM, Stefan Hajnoczi wrote: > QEMU binaries no longer launch successfully with recent SystemTap > releases. This is because modular QEMU builds link the sdt semaphores > into the main binary instead of into the shared objects where they are > used. The symbol visibility of semaphor

Re: [RFC PATCH 0/5] ARM: reduce the memory consumed when mapping UEFI flash images

2020-11-19 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 11/16/20 2:48 PM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Hi David, >>> >>> On 11/16/20 11:42 AM, David Edmondson wrote: Currently ARM UEFI images are typically built as 2MB/768kB flash images for code and variables respe

Re: [PULL for-5.2 0/3] s390x fixes

2020-11-19 Thread Peter Maydell
> > are available in the Git repository at: > > https://github.com/cohuck/qemu tags/s390x-20201119 > > for you to fetch changes up to a4e2fff1b104f2b235ea2673968d0b0383f541dc: > > s390x/pci: fix endianness issues (2020-11-18 16:59:29 +0100) > >

Re: [PATCH 4/4] [broken] meson: try link tracepoints to module

2020-11-19 Thread Stefan Hajnoczi
On Thu, Nov 19, 2020 at 12:23:23PM +0100, Gerd Hoffmann wrote: > Hi, > > > > diff --git a/trace/meson.build b/trace/meson.build > > > index 66395d3e2ba7..3f0fe7b7b74c 100644 > > > --- a/trace/meson.build > > > +++ b/trace/meson.build > > > @@ -18,6 +18,7 @@ foreach c : trace_events_config > > >

Re: [RFC PATCH 1/5] hw/block: blk_check_size_and_read_all should report backend name

2020-11-19 Thread Alex Bennée
David Edmondson writes: > If there are problems examining or reading data from the block > backend, the error messages should include an appropriate identifier > to assist in diagnoses. > > Signed-off-by: David Edmondson With Phillipe's suggested ''s: Reviewed-by: Alex Bennée -- Alex Ben

Re: [RFC PATCH 0/5] ARM: reduce the memory consumed when mapping UEFI flash images

2020-11-19 Thread Philippe Mathieu-Daudé
+Ard & Leif for EDK2. On 11/19/20 12:45 PM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: >> On 11/16/20 2:48 PM, Markus Armbruster wrote: >>> Philippe Mathieu-Daudé writes: >>> Hi David, On 11/16/20 11:42 AM, David Edmondson wrote: > Currently ARM UEFI images are typica

Re: [PATCH-for-5.2 v2] trace: use STAP_SDT_V2 to work around symbol visibility

2020-11-19 Thread Stefan Hajnoczi
On Thu, Nov 19, 2020 at 11:45 AM Philippe Mathieu-Daudé wrote: > On 11/19/20 12:27 PM, Stefan Hajnoczi wrote: > > diff --git a/configure b/configure > > index 714e75b5d8..5d91d49c7b 100755 > > --- a/configure > > +++ b/configure > > @@ -4832,6 +4832,7 @@ if have_backend "dtrace"; then > >trace

Re: [RFC PATCH 2/2] vfio-ccw: Connect the device request notifier

2020-11-19 Thread Cornelia Huck
On Tue, 17 Nov 2020 04:26:05 +0100 Eric Farman wrote: > Now that the vfio-ccw code has a notifier interface to request that > a device be unplugged, let's wire that together. > > Signed-off-by: Eric Farman > --- > hw/vfio/ccw.c | 40 > 1 file changed, 3

Re: [PATCH v2] drivers/virt: vmgenid: add vm generation id driver

2020-11-19 Thread Christian Borntraeger
On 16.11.20 16:34, Catangiu, Adrian Costin wrote: > - Background > > The VM Generation ID is a feature defined by Microsoft (paper: > http://go.microsoft.com/fwlink/?LinkId=260709) and supported by > multiple hypervisor vendors. > > The feature is required in virtualized environments by apps th

Re: [PATCH v2 0/8] qom: Use qlit to represent property defaults

2020-11-19 Thread Markus Armbruster
Eduardo Habkost writes: > Based-on: 20201104160021.2342108-1-ehabk...@redhat.com > Git branch: https://gitlab.com/ehabkost/qemu/-/commits/work/qdev-qlit-defaults > > This extend qlit.h to support all QNum types (signed int, > unsigned int, and double), and use QLitObject to represent field > prop

RE: [PATCH-for-5.2? 1/2] tests/qtest: variable defined by g_autofree need to be initialized

2020-11-19 Thread Chenqun (kuhn)
> > On Thu, 19 Nov 2020 at 08:35, Chenqun (kuhn) > > > wrote: > > > > > > > -Original Message- > > > > > static void tim_add_test(const char *name, const TestData *td, > > > > > GTestDataFunc fn) { > > > > > -g_autofree char *full_name; > > > > > - > > > > > -full_name = > > g_st

Re: [PATCH v2] trace: use STAP_SDT_V2 to work around symbol visibility

2020-11-19 Thread Miroslav Rezanina
- Original Message - > From: "Stefan Hajnoczi" > To: qemu-devel@nongnu.org > Cc: "Peter Maydell" , "Stefan Hajnoczi" > , "Daniel P . Berrangé" > , wco...@redhat.com, f...@redhat.com, kra...@redhat.com, > rjo...@redhat.com, > mreza...@redhat.com, ddepa...@redhat.com > Sent: Thursday, N

Re: [PATCH v4 2/2] arm64: kvm: Introduce MTE VCPU feature

2020-11-19 Thread Steven Price
On 18/11/2020 17:05, Andrew Jones wrote: On Wed, Nov 18, 2020 at 04:50:01PM +, Catalin Marinas wrote: On Wed, Nov 18, 2020 at 04:01:20PM +, Steven Price wrote: On 17/11/2020 16:07, Catalin Marinas wrote: On Mon, Oct 26, 2020 at 03:57:27PM +, Steven Price wrote: diff --git a/arch/a

Re: [PATCH v4 1/2] arm64: kvm: Save/restore MTE registers

2020-11-19 Thread Steven Price
On 18/11/2020 17:02, Catalin Marinas wrote: On Wed, Nov 18, 2020 at 04:01:18PM +, Steven Price wrote: On 17/11/2020 19:20, Marc Zyngier wrote: On 2020-10-26 15:57, Steven Price wrote: diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h index d52c1b3ce589..7727df0

Re: [PATCH v2] drivers/virt: vmgenid: add vm generation id driver

2020-11-19 Thread Alexander Graf
On 19.11.20 13:02, Christian Borntraeger wrote: On 16.11.20 16:34, Catangiu, Adrian Costin wrote: - Background The VM Generation ID is a feature defined by Microsoft (paper: http://go.microsoft.com/fwlink/?LinkId=260709) and supported by multiple hypervisor vendors. The feature is required

[PATCH v3 0/7] UFFD write-tracking migration/snapshots

2020-11-19 Thread Andrey Gruzdev via
Changes with v3: * coding style fixes to pass checkpatch test * qapi/migration.json: change 'track-writes-ram' capability * supported version to 6.0 * fixes to commit message format This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas he's implemented in his

[PATCH v3 1/7] introduce 'track-writes-ram' migration capability

2020-11-19 Thread Andrey Gruzdev via
Signed-off-by: Andrey Gruzdev --- migration/migration.c | 96 +++ migration/migration.h | 1 + qapi/migration.json | 7 +++- 3 files changed, 103 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 87a9b59f83..

[PATCH v3 3/7] support UFFD write fault processing in ram_save_iterate()

2020-11-19 Thread Andrey Gruzdev via
In this particular implementation the same single migration thread is responsible for both normal linear dirty page migration and procesing UFFD page fault events. Processing write faults includes reading UFFD file descriptor, finding respective RAM block and saving faulting page to the migration

[PATCH v3 4/7] implementation of write-tracking migration thread

2020-11-19 Thread Andrey Gruzdev via
Signed-off-by: Andrey Gruzdev --- migration/migration.c | 168 +- migration/migration.h | 3 + migration/savevm.c| 1 - migration/savevm.h| 2 + 4 files changed, 171 insertions(+), 3 deletions(-) diff --git a/migration/migration.c b/migration

[PATCH v3 7/7] introduce simple linear scan rate limiting mechanism

2020-11-19 Thread Andrey Gruzdev via
Since reading UFFD events and saving paged data are performed from the same thread, write fault latencies are sensitive to migration stream stalls. Limiting total page saving rate is a method to reduce amount of noticiable fault resolution latencies. Migration bandwidth limiting is achieved via no

[PATCH v3 6/7] the rest of write tracking migration code

2020-11-19 Thread Andrey Gruzdev via
Signed-off-by: Andrey Gruzdev --- migration/migration.c | 72 +-- 1 file changed, 70 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index dba388f8bd..ccb451b238 100644 --- a/migration/migration.c +++ b/migration/mi

[PATCH v3 2/7] introduce UFFD-WP low-level interface helpers

2020-11-19 Thread Andrey Gruzdev via
Implemented support for the whole RAM block memory protection/un-protection. Introduced higher level ram_write_tracking_start() and ram_write_tracking_stop() to start/stop tracking guest memory writes. Signed-off-by: Andrey Gruzdev --- include/exec/memory.h | 7 ++ migration/ram.c | 267

[PATCH v3 5/7] implementation of vm_start() BH

2020-11-19 Thread Andrey Gruzdev via
To avoid saving updated versions of memory pages we need to start tracking RAM writes before we resume operation of vCPUs. This sequence is especially critical for virtio device backends whos VQs are mapped to main memory and accessed directly not using MMIO callbacks. One problem is that vm_start

Re: [PATCH v2] drivers/virt: vmgenid: add vm generation id driver

2020-11-19 Thread Christian Borntraeger
On 19.11.20 13:51, Alexander Graf wrote: > > > On 19.11.20 13:02, Christian Borntraeger wrote: >> >> On 16.11.20 16:34, Catangiu, Adrian Costin wrote: >>> - Background >>> >>> The VM Generation ID is a feature defined by Microsoft (paper: >>> http://go.microsoft.com/fwlink/?LinkId=260709) and

[PATCH 0/4] Add function to dump block layer for debugging

2020-11-19 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is a new function dbg_dump_block_layer() to help with block layer code debugging. Usage: 1. Add dbg_dump_block_layer("/path/to/dump.json") call in some place were you are trying to understand the relations in block graph and run your test. Or just call dbg_dump_block_layer("/path/to

[PATCH 1/4] block: bdrv_get_xdbg_block_graph() drop unused errp argument

2020-11-19 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 2 +- block.c | 2 +- blockdev.c| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/block/block.h b/include/block/block.h index c9d7c58765..d17151abd7 100644 --- a/include/

[PATCH 2/4] blockjob: add block_jobs_info_list()

2020-11-19 Thread Vladimir Sementsov-Ogievskiy
Move qmp_query_block_jobs() functionality to blockjob.c. We'll need it in block.c which is not always compiled together with blockdev.c Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/blockjob.h | 7 +++ blockdev.c | 26 +- blockjob.c

[PATCH] target/mips/helper: Also display exception names in user-mode

2020-11-19 Thread Philippe Mathieu-Daudé
Currently MIPS exceptions are displayed as string in system-mode emulation, but as number in user-mode. Unify by extracting the current system-mode code as excp_name() and use that in user-mode. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/helper.c | 23 +-- 1 file c

[PATCH 3/4] block: add dbg_dump_block_layer()

2020-11-19 Thread Vladimir Sementsov-Ogievskiy
Add function for debugging: we already have x-debug-query-block-graph qmp command and scripts/render_block_graph.py which can dump block-layer graph for running vm using qmp command. But when debug block layer code, its often needed to dump some intermediate state during some operation, so separate

[PATCH 4/4] scripts/render_block_graph.py: add ability to parse json files

2020-11-19 Thread Vladimir Sementsov-Ogievskiy
Add an option to use json file (generated by dbg_dump_block_layer()) as input. Also, add myself as maintainer of the script. Signed-off-by: Vladimir Sementsov-Ogievskiy --- MAINTAINERS | 5 scripts/render_block_graph.py | 53 ++- 2 files c

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-19 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Nov 18, 2020 at 09:56:28AM -0600, Eric Blake wrote: >> On 11/18/20 9:45 AM, Eduardo Habkost wrote: >> > On Wed, Nov 18, 2020 at 02:53:26PM +0100, Markus Armbruster wrote: >> > [...] >> >> Another way to skin this cat: >> >> >> >> {"available": {"kvm": { ext

Re: [PATCH 00/10] vhost/qemu: thread per IO SCSI vq

2020-11-19 Thread Stefan Hajnoczi
On Wed, Nov 18, 2020 at 04:54:07AM -0500, Michael S. Tsirkin wrote: > On Tue, Nov 17, 2020 at 01:13:14PM -0600, Mike Christie wrote: > > On 11/17/20 10:40 AM, Stefan Hajnoczi wrote: > > > On Thu, Nov 12, 2020 at 05:18:59PM -0600, Mike Christie wrote: > > >> The following kernel patches were made ov

Re: [PATCH 02/13] virtio-pmem: put it into the 'storage' category

2020-11-19 Thread Pankaj Gupta
> The category of the virtio-pmem device is not set, put it into the 'storage' > category. > > Signed-off-by: Gan Qixin > --- > Cc: Michael S. Tsirkin > --- > hw/virtio/virtio-pmem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/virtio/virtio-pmem.c b/hw/virtio/virtio-pmem.c > inde

[PATCH v3] trace: use STAP_SDT_V2 to work around symbol visibility

2020-11-19 Thread Stefan Hajnoczi
QEMU binaries no longer launch successfully with recent SystemTap releases. This is because modular QEMU builds link the sdt semaphores into the main binary instead of into the shared objects where they are used. The symbol visibility of semaphores is 'hidden' and the dynamic linker prints an error

Re: [for-5.2 4/9] docs/system/virtio-pmem.rst: Fix minor style issues

2020-11-19 Thread Pankaj Gupta
> The virtio-pmem documentation has some minor style issues we hadn't > noticed since we weren't rendering it in our docs: > > * Sphinx doesn't complain about overlong title-underlining the >way it complains about too-short underlining, but it looks odd; >make the underlines of the top lev

Re: [PATCH 0/5] i386: simplify Hyper-V enlightenments enablement

2020-11-19 Thread Claudio Fontana
Hi Vitaly, I just wanted to raise awareness of https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg04597.html because if that series work is completed, you would have already the right hook to put your code in, when it comes to your hyperv-specific code for the realizefn. Ciao ciao, Clau

Re: [Bug 498523] Re: Add on-line write compression support to qcow2

2020-11-19 Thread Eric Blake
On 11/19/20 3:39 AM, Thomas Huth wrote: > As far as I know, QEMU v5.1 now has support for compression filters, > e.g. by creating a qcow2 image with: > > qemu-img create -f qcow2 -o compression_type=zlib image.qcow2 1G > > ... so I think we can finally mark this ticket here as done. That says w

[Bug 1900241] Re: [regression][powerpc] some vcpus are found offline inside guest with different vsmt setting from qemu-cmdline and breaks subsequent vcpu hotplug operation (xive)

2020-11-19 Thread Greg Kurz
Fixed by reverting the series that caused the regression. https://git.qemu.org/?p=qemu.git;a=commit;h=6d24795ee7e3199d199d3c415312c93382ad1807 The optimization needs to be reworked later. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you

Re: [PATCH-for-5.2 v2] trace: use STAP_SDT_V2 to work around symbol visibility

2020-11-19 Thread Frank Ch. Eigler
Hi - > > Maybe add a comment? (no need to repost if you agree): > > > ># Workaround to avoid dtrace(1) produces file with 'hidden' > ># symbol visibility, define STAP_SDT_V2 to produce 'default' > ># symbol visibility instead. > > > > > +QEMU_CFLAGS="$QEMU_CFLAGS -DSTAP

Re: [PATCH for 5.2-rc3 v1 0/6] testing fixes (avocado, gitlab)

2020-11-19 Thread Alex Bennée
Alex Bennée writes: > Hi, > Gentle ping: > The following need review: > > - tests/avocado: clean-up socket directory after run > - scripts/ci: clean up default args logic a little -- Alex Bennée

Re: [PATCH for-6.0 0/6] Add HMP/QMP commands to query accelerator

2020-11-19 Thread Claudio Fontana
Ciao Roman, On 11/16/20 2:10 PM, Roman Bolshakov wrote: > Hi, > > Management applications have no way to determine if certain accelerator > is available. That complicates discovery of non-KVM accelerators. are we thinking about how to make this future-proof when it comes to modularization effor

  1   2   3   4   >