[Bug 1793608] Re: qemu doesn't seem to support lxvwsx for POWER9 target

2020-11-12 Thread Thomas Huth
A patch has been posted here: https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg02218.html ("ppc/translate: Implement lxvwsx opcode") ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [PATCH v2 00/44] Make qdev static property API usable by any QOM type

2020-11-12 Thread Paolo Bonzini
On 11/11/20 19:39, Eduardo Habkost wrote: I will submit v3 of this series with both object_class_property_add_field() and object_class_add_field_properties() as internal QOM APIs. object_class_add_field_properties() will be used to implement device_class_set_props(). I have no problem making bo

Re: [PATCH 1/2] char: Skip CLI aliases in query-chardev-backends

2020-11-12 Thread Markus Armbruster
Kevin Wolf writes: > The aliases "tty" and "parport" are only valid on the command line, QMP > commands like chardev-add don't know them. query-chardev-backends should > describe QMP and therefore not include them in the list of available > backends. > > Signed-off-by: Kevin Wolf I'd call that

Re: [PATCH v2] ACPI: Avoid infinite recursion when dump-vmstate

2020-11-12 Thread Michael S. Tsirkin
On Thu, Nov 12, 2020 at 10:06:38AM +0800, Peng Liang wrote: > There is a field with vmstate_ghes_state as vmsd in vmstate_ghes_state, > which will lead to infinite recursion in dump_vmstate_vmsd. > > Fixes: a08a64627b ("ACPI: Record the Generic Error Status Block address") > Reported-by: Euler Rob

Re: [PATCH-for-5.2 v2] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off

2020-11-12 Thread Michael S. Tsirkin
On Thu, Nov 12, 2020 at 09:21:47AM +0530, Ani Sinha wrote: > > > On Sun, Nov 8, 2020 at 22:40 Philippe Mathieu-Daudé > wrote: > > On 11/8/20 4:58 AM, Ani Sinha wrote: > > On Sun, Nov 8, 2020 at 1:10 AM Philippe Mathieu-Daudé > > wrote: > >> > >> GCC 9.3.0 thinks that 'm

Re: [Virtio-fs] [PATCH] virtiofsd: Use --thread-pool-size=0 to mean no thread pool

2020-11-12 Thread Miklos Szeredi
On Fri, Nov 6, 2020 at 11:35 PM Vivek Goyal wrote: > > On Fri, Nov 06, 2020 at 08:33:50PM +, Venegas Munoz, Jose Carlos wrote: > > Hi Vivek, > > > > I have tested with Kata 1.12-apha0, the results seems that are better for > > the use fio config I am tracking. > > > > The fio config does ran

Re: [PATCH] ast2600: SRAM is 89KB

2020-11-12 Thread Cédric Le Goater
On 11/12/20 2:21 AM, Joel Stanley wrote: > On the AST2600A1, the SRAM size was increased to 89KB. > > Fixes: 7582591ae745 ("aspeed: Support AST2600A1 silicon revision") > Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater > --- > hw/arm/aspeed_ast2600.c | 2 +- > 1 file changed, 1 inse

[Bug 786208] Re: Missing checks for non-existent device in ide_exec_cmd

2020-11-12 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 670769] Re: CDROM size not updated when changing image files

2020-11-12 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete ** Changed in: qemu Assignee: John Snow (jnsnow) => (unassigned) -- You received this bug noti

[Bug 761469] Re: multicast VPN breaks IPv6 Duplicate Address Detection

2020-11-12 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

Re: [PATCH v2-for-5.2] macio: set user_creatable to false in macio_class_init()

2020-11-12 Thread Mark Cave-Ayland
On 10/11/2020 10:31, Mark Cave-Ayland wrote: Commit 348b8d1a76 "macio: don't reference serial_hd() directly within the device" removed the setting of user_creatable to false on the basis that the restriction was due to the use of serial_hd() in macio_instance_init(). Unfortunately this isn't t

[PATCH] virtio-net: purge queued rx packets on queue deletion

2020-11-12 Thread Yuri Benditovich
https://bugzilla.redhat.com/show_bug.cgi?id=1829272 When deleting queue pair, purge pending RX packets if any. Example of problematic flow: 1. Bring up q35 VM with tap (vhost off) and virtio-net or e1000e 2. Run ping flood to the VM NIC ( 1 ms interval) 3. Hot unplug the NIC device (device_del)

[PATCH] scsi-disk: convert more errno values back to SCSI statuses

2020-11-12 Thread Paolo Bonzini
Linux has some OS-specific (and sometimes weird) mappings for various SCSI statuses and sense codes. The most important is probably RESERVATION CONFLICT. Add them so that they can be reported back to the guest kernel. Cc: Hannes Reinecke Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c |

Re: [PATCH v5 1/1] tricore: added triboard with tc27x_soc

2020-11-12 Thread Bastian Koppelmann
On Mon, Nov 09, 2020 at 05:50:55PM +0100, David Brenken wrote: > From: Andreas Konopik > > Signed-off-by: Andreas Konopik > Signed-off-by: David Brenken > Signed-off-by: Georg Hofstetter > Signed-off-by: Robert Rasche > Signed-off-by: Lars Biermanski > --- > default-configs/devices/tricore-

[PULL 1/1] macio: set user_creatable to false in macio_class_init()

2020-11-12 Thread Mark Cave-Ayland
Commit 348b8d1a76 "macio: don't reference serial_hd() directly within the device" removed the setting of user_creatable to false on the basis that the restriction was due to the use of serial_hd() in macio_instance_init(). Unfortunately this isn't the full story since the PIC object property link

[PULL 0/1] qemu-macppc queue 20201112

2020-11-12 Thread Mark Cave-Ayland
tags/qemu-macppc-20201112 for you to fetch changes up to 6bfa035ec31f4f5a14499f17e08f62e8f14760cc: macio: set user_creatable to false in macio_class_init() (2020-11-12 09:26:20 +) qemu-macppc f

Re: [Virtio-fs] [PATCH] virtiofsd: Use --thread-pool-size=0 to mean no thread pool

2020-11-12 Thread Miklos Szeredi
On Thu, Nov 12, 2020 at 10:06 AM Miklos Szeredi wrote: > > On Fri, Nov 6, 2020 at 11:35 PM Vivek Goyal wrote: > > > > On Fri, Nov 06, 2020 at 08:33:50PM +, Venegas Munoz, Jose Carlos wrote: > > > Hi Vivek, > > > > > > I have tested with Kata 1.12-apha0, the results seems that are better for

Re: [PATCH PROTOTYPE 3/6] vfio: Implement support for sparse RAM memory regions

2020-11-12 Thread David Hildenbrand
On 20.10.20 22:44, Peter Xu wrote: > On Tue, Oct 20, 2020 at 10:01:12PM +0200, David Hildenbrand wrote: >> Thanks ... but I have an AMD system. Will try to find out how to get >> that running with AMD :) I just did some more testing with the oldish GPU I have for that purpose. Seems to work, at le

Re: [PATCH] net/e1000e_core: make sure RDH never exceeds RDT in e1000e_ring_advance()

2020-11-12 Thread Mauro Matteo Cascella
On Wed, Nov 11, 2020 at 1:48 PM Jason Wang wrote: > > > On 2020/11/11 下午4:54, Jason Wang wrote: > > > > On 2020/11/10 下午5:06, Mauro Matteo Cascella wrote: > >> On Mon, Nov 9, 2020 at 3:38 AM Jason Wang wrote: > >>> > >>> On 2020/11/5 下午6:56, Mauro Matteo Cascella wrote: > The e1000e_write_pa

[PATCH] xhci: fix nec-usb-xhci properties

2020-11-12 Thread Gerd Hoffmann
Storing properties directly in XHCIPciState.xhci doesn't work, the object_initialize_child() call in xhci_instance_init() will overwrite them. This changes the defaults for some properties, which in turn breaks live migration and possibly other things as well. So add XHCINecState, store propertie

Re: [PATCH] migration: handle CANCELLING state in migration_completion()

2020-11-12 Thread Dr. David Alan Gilbert
* Longpeng(Mike) (longpe...@huawei.com) wrote: > The following sequence may cause the VM abort during migration: > > 1. RUN_STATE_RUNNING,MIGRATION_STATUS_ACTIVE > > 2. before call migration_completion(), we send migrate_cancel >QMP command, the state machine is changed to: > RUN_STATE_R

Re: [PATCH 1/2] char: Skip CLI aliases in query-chardev-backends

2020-11-12 Thread Kevin Wolf
Am 12.11.2020 um 09:22 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > The aliases "tty" and "parport" are only valid on the command line, QMP > > commands like chardev-add don't know them. query-chardev-backends should > > describe QMP and therefore not include them in the list of

Re: [PATCH 1/3] meson: move vhost_user_blk_server to meson.build

2020-11-12 Thread Stefan Hajnoczi
On Wed, Nov 11, 2020 at 12:54:38PM +0100, Philippe Mathieu-Daudé wrote: > On 11/11/20 12:44 PM, Philippe Mathieu-Daudé wrote: > > On 11/11/20 10:41 AM, Philippe Mathieu-Daudé wrote: > >> On 11/10/20 6:11 PM, Stefan Hajnoczi wrote: > >>> The --enable/disable-vhost-user-blk-server options were implem

Re: [Virtio-fs] [PATCH] virtiofsd: Use --thread-pool-size=0 to mean no thread pool

2020-11-12 Thread Christian Schoenebeck
On Donnerstag, 12. November 2020 10:06:37 CET Miklos Szeredi wrote: > On Fri, Nov 6, 2020 at 11:35 PM Vivek Goyal wrote: > > On Fri, Nov 06, 2020 at 08:33:50PM +, Venegas Munoz, Jose Carlos wrote: > > > Hi Vivek, > > > > > > I have tested with Kata 1.12-apha0, the results seems that are bett

Re: [PATCH v2 2/4] ads7846: put it into the 'display' category

2020-11-12 Thread Peter Maydell
On Thu, 12 Nov 2020 at 07:25, Gan Qixin wrote: > > The category of the ads7846 device is not set, put it into the 'display' > category. > > Signed-off-by: Gan Qixin > --- > hw/display/ads7846.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/display/ads7846.c b/hw/display/ads7846.c

Re: [PATCH 0/2] RFC: Issue with discards on raw block device without O_DIRECT

2020-11-12 Thread Jan Kara
[added some relevant people and lists to CC] On Wed 11-11-20 17:44:05, Maxim Levitsky wrote: > On Wed, 2020-11-11 at 17:39 +0200, Maxim Levitsky wrote: > > clone of "starship_production" > > The git-publish destroyed the cover letter: > > For the reference this is for bz #1872633 > > The issue

Re: [PATCH] vl, qemu-config: remove -set

2020-11-12 Thread Gerd Hoffmann
Hi, > IOW, it looks like it is valid to use -set, even if you're not using > -readconfig. Yes, that is quite useful for setting device properties which are not (yet) supported by libvirt, like this: Grepping through my libvirt domain config files I see 90% is indeed "-set devi

Re: [PULL 0/2] Linux user for 5.2 patches

2020-11-12 Thread Peter Maydell
On Wed, 11 Nov 2020 at 21:42, Laurent Vivier wrote: > > The following changes since commit c6f28ed5075df79fef39c500362a3f4089256c9c: > > Update version for v5.2.0-rc1 release (2020-11-10 22:29:57 +) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux

[PATCH] linux-user: Implement copy_file_range

2020-11-12 Thread Andreas Schwab
Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 40 1 file changed, 40 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 3160a9ba06..c3373af4c7 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -813,6 +813

Re: [PATCH] target/i386: seg_helper: Correct segement selector nullification in the RET/IRET helper

2020-11-12 Thread Paolo Bonzini
On 22/10/20 12:16, Bin Meng wrote: From: Bin Meng Per the SDM, when returning to outer privilege level, for segment registers (ES, FS, GS, and DS) if the check fails, the segment selector becomes null, but QEMU clears the base/limit/flags as well as nullifying the segment selector, which should

RE: [PATCH v2 2/4] ads7846: put it into the 'display' category

2020-11-12 Thread ganqixin
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Thursday, November 12, 2020 7:20 PM > To: ganqixin > Cc: QEMU Developers ; QEMU Trivial > ; Thomas Huth ; > Zhanghailiang ; Michael S. Tsirkin > ; Laurent Vivier ; Markus Armbruster > ; Chenqun (kuhn) ; >

Re: [PATCH 0/2] RFC: Issue with discards on raw block device without O_DIRECT

2020-11-12 Thread Jan Kara
On Thu 12-11-20 12:19:51, Jan Kara wrote: > [added some relevant people and lists to CC] > > On Wed 11-11-20 17:44:05, Maxim Levitsky wrote: > > On Wed, 2020-11-11 at 17:39 +0200, Maxim Levitsky wrote: > > > clone of "starship_production" > > > > The git-publish destroyed the cover letter: > > >

Re: [PATCH 2/2] qemu-img: align next status sector on destination alignment.

2020-11-12 Thread Peter Lieven
Am 11.11.20 um 16:39 schrieb Maxim Levitsky: > This helps avoid unneeded writes and discards. > > Signed-off-by: Maxim Levitsky > --- > qemu-img.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index c2c56fc797..7e9b0f659f 100644 >

Re: [Virtio-fs] [PATCH] virtiofsd: Use --thread-pool-size=0 to mean no thread pool

2020-11-12 Thread Miklos Szeredi
On Thu, Nov 12, 2020 at 12:34 PM Christian Schoenebeck wrote: > > On Donnerstag, 12. November 2020 10:06:37 CET Miklos Szeredi wrote: > > > > 9p:cache=none <-> virtiofs:cache=none > > 9p:cache=loose <-> virtiofs:cache=always > > > > "9p:cache=mmap" and "virtiofs:cache=auto" have no match. > > Wha

[Bug 1628971] Re: -netdev user: guestfwd doesn't work

2020-11-12 Thread Thomas Huth
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1628971 Title: -netdev user: guestfwd doesn't work Status in QEMU: Invalid Bug description: Hel

[Bug 1626207] Re: -device usb-host failing with usbip_vudc-vhdi_hcd gadget

2020-11-12 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1626596] Re: Lockup with vhost network

2020-11-12 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1668273] Re: DoS possible on - a QEMU process using userspace SLIRP?

2020-11-12 Thread Thomas Huth
Slirp has been moved to an external project now. If this is still an issue, please report the problem there instead: https://gitlab.freedesktop.org/slirp/libslirp ** Changed in: qemu Status: New => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml

Re: [PULL 0/1] qemu-macppc queue 20201112

2020-11-12 Thread Peter Maydell
> > are available in the Git repository at: > > git://github.com/mcayland/qemu.git tags/qemu-macppc-20201112 > > for you to fetch changes up to 6bfa035ec31f4f5a14499f17e08f62e8f14760cc: > > macio: set user_creatable to false

Re: [PATCH 1/1] virtio-blk-ccw: tweak the default for num_queues

2020-11-12 Thread Halil Pasic
On Wed, 11 Nov 2020 13:49:08 +0100 Michael Mueller wrote: > Halil, > > still I would like to know what the exact memory consumption per queue > is that you are talking about. Have you made a calculation? Thanks. Hi! The default size for virtio-blk seems to be 256 ring entries, which translate

Re: [PATCH 2/2] qemu-img: align next status sector on destination alignment.

2020-11-12 Thread Eric Blake
On 11/12/20 6:40 AM, Peter Lieven wrote: >> /* >> - * Avoid that s->sector_next_status becomes unaligned to the source >> - * request alignment and/or cluster size to avoid unnecessary read >> - * cycles. >> + * Avoid that s->sector_next_status becomes unal

Re: [PATCH] vl, qemu-config: remove -set

2020-11-12 Thread Paolo Bonzini
On 12/11/20 12:26, Gerd Hoffmann wrote: Yes, that is quite useful for setting device properties which are not (yet) supported by libvirt, like this: Grepping through my libvirt domain config files I see 90% is indeed "-set device". But I've also found netdev (set tftp+bootf

Re: [PATCH-for-5.2 4/4] migration/ram: Fix hexadecimal format string specifier

2020-11-12 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > > Hi David, Juan. > > > > On 11/3/20 1:46 PM, Dr. David Alan Gilbert wrote: > > > * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > > >> The '%u' conversion specifier is for

Re: Command line QAPIfication and -readconfig

2020-11-12 Thread Andrea Bolognani
On Wed, 2020-11-11 at 11:35 +0100, Kevin Wolf wrote: > Am 11.11.2020 um 11:14 hat Daniel P. Berrangé geschrieben: > > Normally we would not mark something as deprecated unless its replacement > > is ready, because telling people "stop using this but the replacement > > doesn't exist yet" is not

Re: [PATCH v2] ACPI: Avoid infinite recursion when dump-vmstate

2020-11-12 Thread Dr. David Alan Gilbert
* Peng Liang (liangpen...@huawei.com) wrote: > There is a field with vmstate_ghes_state as vmsd in vmstate_ghes_state, > which will lead to infinite recursion in dump_vmstate_vmsd. > > Fixes: a08a64627b ("ACPI: Record the Generic Error Status Block address") > Reported-by: Euler Robot > Signed-of

[Bug 1778966] Re: Windows 1803 and later crashes on KVM

2020-11-12 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1779120] Re: disk missing in the guest contingently when hotplug several virtio scsi disks consecutively

2020-11-12 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

Re: [PATCH for-5.2 04/10] vhost-user-blk-test: rename destroy_drive() to destroy_file()

2020-11-12 Thread Max Reitz
On 11.11.20 13:43, Stefan Hajnoczi wrote: The function is used not just for image files but also for UNIX domain sockets (QMP monitor and vhost-user-blk). Reflect that in the name. Signed-off-by: Stefan Hajnoczi --- tests/qtest/vhost-user-blk-test.c | 9 + 1 file changed, 5 insertion

Re: [PATCH] migration/multifd: fix hangup with TLS-Multifd due to blocking handshake

2020-11-12 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > The qemu main loop could hang up forever when we enable TLS+Multifd. > The Src multifd_send_0 invokes tls handshake, it sends hello to sever > and wait response. > However, the Dst main qemu loop has been waiting recvmsg() for multifd_recv_1. > Both of

[for-5.2 0/9] docs: Move orphan top-level .rst files into manuals

2020-11-12 Thread Peter Maydell
Currently we have a handful of rST documents that are sat in the top level docs/ directory and do not get built into the manuals. These are a legacy from the period after we'd decided we wanted rST format documentation but before we'd set up the manual structure. This patchset moves them all into

[for-5.2 3/9] docs: Move virtio-pmem.rst into the system manual

2020-11-12 Thread Peter Maydell
Signed-off-by: Peter Maydell --- docs/system/index.rst | 1 + docs/{ => system}/virtio-pmem.rst | 0 2 files changed, 1 insertion(+) rename docs/{ => system}/virtio-pmem.rst (100%) diff --git a/docs/system/index.rst b/docs/system/index.rst index 0f0f6d2e99d..2a5155c67dc 100644 --- a

[for-5.2 4/9] docs/system/virtio-pmem.rst: Fix minor style issues

2020-11-12 Thread Peter Maydell
The virtio-pmem documentation has some minor style issues we hadn't noticed since we weren't rendering it in our docs: * Sphinx doesn't complain about overlong title-underlining the way it complains about too-short underlining, but it looks odd; make the underlines of the top level title th

[for-5.2 5/9] docs: Split out 'pc' machine model docs into their own file

2020-11-12 Thread Peter Maydell
Currently target-i386.rst includes the documentation of the 'pc' machine model inline. Split it out into its own file, in a similar way to target-i386.rst; this gives us a place to put documentation of other i386 machine models, such as 'microvm'. Signed-off-by: Peter Maydell --- docs/system/i38

[for-5.2 1/9] docs: Move virtio-net-failover.rst into the system manual

2020-11-12 Thread Peter Maydell
The virtio-net-failover documentation is currently orphan and not included in any manual; move it into the system manual, immediately following the general network emulation section. Signed-off-by: Peter Maydell --- docs/system/index.rst | 1 + docs/{ => system}/virtio-net-fa

[for-5.2 6/9] docs: Move microvm.rst into the system manual

2020-11-12 Thread Peter Maydell
Now that target-i386.rst has a place to list documentation of machines other than the 'pc' machine, we have a place we can move the microvm documentation to. Signed-off-by: Peter Maydell --- docs/{ => system/i386}/microvm.rst | 5 ++--- docs/system/target-i386.rst| 1 + 2 files changed,

[for-5.2 2/9] docs: Move cpu-hotplug.rst into the system manual

2020-11-12 Thread Peter Maydell
The cpu-hotplug.rst documentation is currently orphan and not included in any manual; move it into the system manual. Signed-off-by: Peter Maydell --- docs/{ => system}/cpu-hotplug.rst | 0 docs/system/index.rst | 1 + 2 files changed, 1 insertion(+) rename docs/{ => system}/cpu-hot

[for-5.2 9/9] docs/system/pr-manager.rst: Fix minor docs nits

2020-11-12 Thread Peter Maydell
Fix a couple of nits in pr-manager.rst: * the title marker for the top level heading is overlength * stray capital 'R' in the middle of a sentence Signed-off-by: Peter Maydell --- docs/system/pr-manager.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/system/p

[for-5.2 7/9] docs: Move pr-manager.rst into the system manual

2020-11-12 Thread Peter Maydell
Move the pr-manager documentation into the system manual. Some of it (the documentation of the pr-manager-helper tool) should be in tools, but we will split it up after moving it. Signed-off-by: Peter Maydell --- docs/system/index.rst| 1 + docs/{ => system}/pr-manager.rst | 0 2 fil

[for-5.2 8/9] docs: Split qemu-pr-helper documentation into tools manual

2020-11-12 Thread Peter Maydell
Split the documentation of the qemu-pr-helper binary into the tools manual, and give it a manpage like our other standalone executables. Signed-off-by: Peter Maydell --- docs/meson.build | 1 + docs/system/pr-manager.rst| 38 ++- docs/tools/conf.py| 2 +

Re: [PATCH v2 5/5] migration: fix uninitialized variable warning in migrate_send_rp_req_pages()

2020-11-12 Thread Dr. David Alan Gilbert
* Chen Qun (kuhn.chen...@huawei.com) wrote: > After the WITH_QEMU_LOCK_GUARD macro is added, the compiler cannot identify > that the statements in the macro must be executed. As a result, some > variables > assignment statements in the macro may be considered as unexecuted by the > compiler. >

Re: [PATCH v2 00/44] Make qdev static property API usable by any QOM type

2020-11-12 Thread Eduardo Habkost
On Thu, Nov 12, 2020 at 09:11:48AM +0100, Paolo Bonzini wrote: > On 11/11/20 19:39, Eduardo Habkost wrote: > > I will submit v3 of this series with both > > object_class_property_add_field() and > > object_class_add_field_properties() as internal QOM APIs. > > object_class_add_field_properties() wi

Re: [PATCH] migration/dirtyrate: simplify inlcudes in dirtyrate.c

2020-11-12 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > Remove redundant blank line which is left by Commit 662770af7c6e8c, > also take this opportunity to remove redundant includes in dirtyrate.c. > > Signed-off-by: Chuan Zheng and queued Reviewed-by: Dr. David Alan Gilbert > --- > migration/dirtyra

Re: [PATCH 2/2] qemu-img: align next status sector on destination alignment.

2020-11-12 Thread Maxim Levitsky
On Thu, 2020-11-12 at 07:45 -0600, Eric Blake wrote: > On 11/12/20 6:40 AM, Peter Lieven wrote: > > > > /* > > > - * Avoid that s->sector_next_status becomes unaligned to the > > > source > > > - * request alignment and/or cluster size to avoid unnecessary > > > read > >

Re: [PATCH for-5.2 08/10] block/export: port virtio-blk discard/write zeroes input validation

2020-11-12 Thread Max Reitz
On 11.11.20 13:43, Stefan Hajnoczi wrote: Validate discard/write zeroes the same way we do for virtio-blk. Some of these checks are mandated by the VIRTIO specification, others are internal to QEMU. Signed-off-by: Stefan Hajnoczi --- block/export/vhost-user-blk-server.c | 115

Re: [RFC v3] VFIO Migration

2020-11-12 Thread Cornelia Huck
On Wed, 11 Nov 2020 15:48:50 + Daniel P. Berrangé wrote: > In terms of validation I can't help but feel the whole proposal is > really very complicated. > > In validating QEMU migration compatibility we merely compare the > versioned machine type. > > IIUC, in this proposal, it would be mor

Re: [PATCH] scsi-disk: convert more errno values back to SCSI statuses

2020-11-12 Thread Hannes Reinecke
On 11/12/20 10:52 AM, Paolo Bonzini wrote: Linux has some OS-specific (and sometimes weird) mappings for various SCSI statuses and sense codes. The most important is probably RESERVATION CONFLICT. Add them so that they can be reported back to the guest kernel. Cc: Hannes Reinecke Signed-off-b

Re: [PATCH] migration: handle CANCELLING state in migration_completion()

2020-11-12 Thread Dr. David Alan Gilbert
* Longpeng(Mike) (longpe...@huawei.com) wrote: > The following sequence may cause the VM abort during migration: > > 1. RUN_STATE_RUNNING,MIGRATION_STATUS_ACTIVE > > 2. before call migration_completion(), we send migrate_cancel >QMP command, the state machine is changed to: > RUN_STATE_R

Re: [PATCH] hw/arm/virt: ARM_VIRT must select ARM_GIC

2020-11-12 Thread Peter Maydell
On Wed, 11 Nov 2020 at 14:34, Andrew Jones wrote: > > The removal of the selection of A15MPCORE from ARM_VIRT also > removed what A15MPCORE selects, ARM_GIC. We still need ARM_GIC. > > Fixes: bec3c97e0cf9 ("hw/arm/virt: Remove dependency on Cortex-A15 MPCore > peripherals") > Reported-by: Mirosla

Re: [PATCH] exynos: Fix bad printf format specifiers

2020-11-12 Thread Peter Maydell
On Wed, 11 Nov 2020 at 07:48, Alex Chen wrote: > > We should use printf format specifier "%u" instead of "%d" for > argument of type "unsigned int". > > Reported-by: Euler Robot > Signed-off-by: Alex Chen > --- > hw/timer/exynos4210_mct.c | 4 ++-- > hw/timer/exynos4210_pwm.c | 8 > 2

Re: [PATCH] hw/input/ps2.c: Remove remnants of printf debug

2020-11-12 Thread Peter Maydell
On Sun, 1 Nov 2020 at 13:33, Peter Maydell wrote: > > In commit 5edab03d4040 we added tracepoints to the ps2 keyboard > and mouse emulation. However we didn't remove all the debug-by-printf > support. In fact there is only one printf() remaining, and it is > redundant with the trace_ps2_write_mous

Re: [PATCH] target/openrisc: Remove dead code attempting to check "is timer disabled"

2020-11-12 Thread Peter Maydell
On Wed, 4 Nov 2020 at 11:44, Stafford Horne wrote: > As for the patch. > > Acked-by: Stafford Horne Thanks; I'll take this via target-arm.next since I'm putting together a pullreq at the moment. -- PMM

Re: [PATCH 0/2] RFC: Issue with discards on raw block device without O_DIRECT

2020-11-12 Thread Maxim Levitsky
On Thu, 2020-11-12 at 12:19 +0100, Jan Kara wrote: > [added some relevant people and lists to CC] > > On Wed 11-11-20 17:44:05, Maxim Levitsky wrote: > > On Wed, 2020-11-11 at 17:39 +0200, Maxim Levitsky wrote: > > > clone of "starship_production" > > > > The git-publish destroyed the cover lette

Re: [PATCH for-5.2 09/10] vhost-user-blk-test: test discard/write zeroes invalid inputs

2020-11-12 Thread Max Reitz
On 11.11.20 13:43, Stefan Hajnoczi wrote: Exercise input validation code paths in block/export/vhost-user-blk-server.c. Signed-off-by: Stefan Hajnoczi --- block/export/vhost-user-blk-server.c | 4 +- tests/qtest/vhost-user-blk-test.c| 124 +++ 2 files changed,

[Bug 1779649] Re: Suspending a domain works with a 3.16 gues kernel but not with a 4.16 one

2020-11-12 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

Re: [PATCH for-5.2] virtiofsd: Announce submounts even without statx()

2020-11-12 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > Contrary to what the check (and warning) in lo_init() claims, we can > announce submounts just fine even without statx() -- the check is based > on comparing both the mount ID and st_dev of parent and child. Without > statx(), we will not have the mount ID;

[Bug 1781515] Re: Resolution switch leads to the screen/image being corrupted

2020-11-12 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1782300] Re: COLO unable to failover to secondary VM

2020-11-12 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1782107] Re: Random errors when emulating armv7 and using dh

2020-11-12 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1780815] Re: SDL Doesn't Rescale Image on Resolution Change

2020-11-12 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

Re: [PATCH V2] vhost-user-blk/scsi: Fix broken error handling for socket call

2020-11-12 Thread Peter Maydell
Ping? This is a coverity issue fix which has been reviewed, whose tree should it go via? Adding mst to cc list as the listed maintainer. thanks -- PMM On Thu, 29 Oct 2020 at 06:05, AlexChen wrote: > > When socket() fails, it returns -1, 0 is the normal return value and should > not return erro

Re: [PATCH v2 1/1] register: Remove unnecessary NULL check

2020-11-12 Thread Peter Maydell
On Fri, 2 Oct 2020 at 17:04, Alistair Francis wrote: > > This patch fixes CID 1432800 by removing an unnecessary check. > > Signed-off-by: Alistair Francis > --- > hw/core/register.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/hw/core/register.c b/hw/core/register.c > index 31038

Re: [PATCH] target/i386: avoid theoretical leak on MCE injection

2020-11-12 Thread Peter Maydell
On Tue, 6 Oct 2020 at 08:54, Paolo Bonzini wrote: > > g_strdup_printf is used twice to write to the same variable, which > can theoretically cause a leak. In practice, it is extremely > unlikely that a guest is seeing a recursive MCE and has disabled > CR4.MCE between the first and the second err

Re: [PATCH for-5.2 10/10] block/export: port virtio-blk read/write range check

2020-11-12 Thread Max Reitz
On 11.11.20 13:43, Stefan Hajnoczi wrote: Check that the sector number and byte count are valid. Signed-off-by: Stefan Hajnoczi --- block/export/vhost-user-blk-server.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/block/export/vhost-user-blk-server.c b/block/export/vh

Re: [PATCH-for-5.2 v3] util/cutils: Fix Coverity array overrun in freq_to_str()

2020-11-12 Thread Peter Maydell
On Sun, 1 Nov 2020 at 21:57, Philippe Mathieu-Daudé wrote: > > Fix Coverity CID 1435957: Memory - illegal accesses (OVERRUN): > > >>> Overrunning array "suffixes" of 7 8-byte elements at element > index 7 (byte offset 63) using index "idx" (which evaluates to 7). > > Note, the biggest input v

Re: [PATCH v2 1/1] Fix use after free in vfio_migration_probe

2020-11-12 Thread Peter Maydell
On Fri, 6 Nov 2020 at 18:35, Kirti Wankhede wrote: > > Fixes Coverity issue: > CID 1436126: Memory - illegal accesses (USE_AFTER_FREE) > > Fixes: a9e271ec9b36 ("vfio: Add migration region initialization and finalize > function") > > Signed-off-by: Kirti Wankhede > Reviewed-by: David Edmondson

Re: [PATCH v3 0/3] virtiofsd: fix some accessing NULL pointer problem

2020-11-12 Thread Dr. David Alan Gilbert
* Haotian Li (lihaoti...@huawei.com) wrote: > Hi, > We find some potential NULL pointer bugs on tools/virtiofsd. > Three patches are made to fix them Queued > Haotian Li (3): > tools/virtiofsd/buffer.c: check whether buf is NULL in > fuse_bufvec_advance func > virtiofsd: check whether l

Re: [PATCH v5 0/7] iOS and Apple Silicon host support

2020-11-12 Thread Stefan Hajnoczi
On Sun, Nov 08, 2020 at 03:24:17PM -0800, Joelle van Dyne wrote: > Based-on: 20201106032921.600200-1-richard.hender...@linaro.org > ([PATCH v3 00/41] Mirror map JIT memory for TCG) > > These set of changes brings QEMU TCG to iOS devices and future Apple Silicon > devices. They were originally deve

[PATCH for-5.2?] configure: Make "does libgio work" test pull in some actual functions

2020-11-12 Thread Peter Maydell
In commit 76346b6264a9b01979 we tried to add a configure check that the libgio pkg-config data was correct, which builds an executable linked against it. Unfortunately this doesn't catch the problem (missing static library dependency info), because a "do nothing" test source file doesn't have any

Re: [PATCH v2 1/1] Fix use after free in vfio_migration_probe

2020-11-12 Thread Alex Williamson
On Thu, 12 Nov 2020 15:57:46 + Peter Maydell wrote: > On Fri, 6 Nov 2020 at 18:35, Kirti Wankhede wrote: > > > > Fixes Coverity issue: > > CID 1436126: Memory - illegal accesses (USE_AFTER_FREE) > > > > Fixes: a9e271ec9b36 ("vfio: Add migration region initialization and finalize > > functi

Re: [PATCH for-5.2 04/10] vhost-user-blk-test: rename destroy_drive() to destroy_file()

2020-11-12 Thread Stefan Hajnoczi
On Thu, Nov 12, 2020 at 03:32:58PM +0100, Max Reitz wrote: > On 11.11.20 13:43, Stefan Hajnoczi wrote: > > The function is used not just for image files but also for UNIX domain > > sockets (QMP monitor and vhost-user-blk). Reflect that in the name. > > > > Signed-off-by: Stefan Hajnoczi > > ---

Re: [PATCH-for-5.2? v5 0/2] ci: Move trace backend tests across to gitlab

2020-11-12 Thread Stefan Hajnoczi
On Wed, Nov 11, 2020 at 01:12:32PM +0100, Philippe Mathieu-Daudé wrote: > Extracted from "ci: Move various jobs from Travis to GitLab CI": > https://www.mail-archive.com/qemu-devel@nongnu.org/msg758314.html > > v5: > - addressed Wainer's review comment > > Philippe Mathieu-Daudé (2): > tests/do

[PATCH 2/6] qapi: Remember alias definitions in qobject-input-visitor

2020-11-12 Thread Kevin Wolf
This makes qobject-input-visitor remember the currently valid aliases in each StackObject. It doesn't actually allow using the aliases yet. Signed-off-by: Kevin Wolf --- qapi/qobject-input-visitor.c | 115 +++ 1 file changed, 115 insertions(+) diff --git a/qapi/q

[PATCH 0/6] qapi: Add support for aliases

2020-11-12 Thread Kevin Wolf
This series introduces alias definitions for QAPI object types (structs and unions). This allows using the same QAPI type and visitor even when the syntax has some variations between different external interfaces such as QMP and the command line. It also provides a new tool for evolving the schem

[PATCH 4/6] qapi: Apply aliases in qobject-input-visitor

2020-11-12 Thread Kevin Wolf
When looking for an object in a struct in the external representation, check not only the currently visited struct, but also whether an alias in the current StackObject matches and try to fetch the value from the alias then. Providing two values for the same object through different aliases is an e

[PATCH 1/6] qapi: Add interfaces for alias support to Visitor

2020-11-12 Thread Kevin Wolf
This adds functions to the Visitor interface that can be used to define aliases and alias scopes. Signed-off-by: Kevin Wolf --- include/qapi/visitor-impl.h | 12 include/qapi/visitor.h | 37 + qapi/qapi-visit-core.c | 21

[PATCH 3/6] qapi: Simplify full_name_nth() in qobject-input-visitor

2020-11-12 Thread Kevin Wolf
Instead of counting how many elements from the top of the stack we need to ignore until we find the thing we're interested in, we can just directly pass the StackObject pointer because all callers already know it. We only need a different way now to tell if we want to know the name of something co

[PATCH 5/6] qapi: Add support for aliases

2020-11-12 Thread Kevin Wolf
Introduce alias definitions for object types (structs and unions). This allows using the same QAPI type and visitor for many syntax variations that exist in the external representation, like between QMP and the command line. It also provides a new tool for evolving the schema while maintaining back

[PATCH 6/6] tests/qapi-schema: Test cases for aliases

2020-11-12 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qapi-schema/alias-bad-type.err | 2 ++ tests/qapi-schema/alias-bad-type.json | 3 ++ tests/qapi-schema/alias-bad-type.out | 0 tests/qapi-schema/alias-missing-source.err| 2 ++ tests/qapi-schema/alias-missing-source.json | 3

[Bug 1809291] Re: SD Card not working in Ubuntu 18.10 (CMD 2, 3 timeout). The device worked fine in Ubuntu 18.04 and earlier versions but not in Ubuntu 18.10

2020-11-12 Thread The Lemon Man
The new code in Qemu is correct, the real problem is that the code [1] is trying to negotiate an invalid working voltage with CMD41. The SD specification marks the first 15 bits as reserved (except for the 7th, that's the dual-voltage flag) meaning that compliant cards will timeout as well. If y

Re: [RFC PATCH 12/25] acpi/pci: Consolidate host bridge setup

2020-11-12 Thread Ben Widawsky
On 20-11-10 21:47:11, Ben Widawsky wrote: > This cleanup will make it easier to add support for CXL to the mix. This patch needs bios table updates for qtest... I am fixing it... > > Signed-off-by: Ben Widawsky > --- > hw/i386/acpi-build.c | 31 +-- > 1 file changed

  1   2   3   >