Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

On Tue, Nov 10, 2020 at 4:23 AM Jason Wang wrote: > > On 2020/11/9 下午9:33, Yuri Benditovich wrote: > > > > > > On Mon, Nov 9, 2020 at 4:14 AM Jason Wang > > wrote: > > > > > > On 2020/11/5 下午11:13, Yuri Benditovich wrote: > > > First of all, thank you for all

Re: [PATCH] qtest: Fix bad printf format specifiers

On 09/11/2020 13.50, Markus Armbruster wrote: > Alex Chen writes: > >> On 2020/11/9 15:57, Markus Armbruster wrote: >>> Thomas Huth writes: >>> On 06/11/2020 15.18, Philippe Mathieu-Daudé wrote: > On 11/6/20 7:33 AM, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> On

Re: [PATCH v2 4/6] qemu-option: clean up id vs. list->merge_lists

Paolo Bonzini writes: > On 09/11/20 19:38, Markus Armbruster wrote: >>> They are never qemu_opts_find'd with non-NULL id, so I'd say they are. >> >> We also need to check qemu_opts_foreach(). > > Using qemu_opts_foreach means that e.g. -name id=... was not ignored > unlike -M id= However,

[PULL 3/3] linux-user/sparc: Don't zero high half of PC, NPC, PSR in sigreturn

From: Peter Maydell The function do_sigreturn() tries to store the PC, NPC and PSR in uint32_t local variables, which implicitly drops the high half of these fields for 64-bit guests. The usual effect was that a guest which used signals would crash on return from a signal unless it was lucky eno

[PULL 1/3] linux-user/sparc: Fix errors in target_ucontext structures

From: Peter Maydell The various structs that make up the SPARC target_ucontext had some errors: * target structures must not include fields which are host pointers, which might be the wrong size. These should be abi_ulong instead * because we don't have the 'long double' part of the mcfpu_f

[PULL 0/3] Linux user for 5.2 patches

The following changes since commit 43afbbd9fea1b255cc81f5f4bfd0b6a88826c735: Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2020-11-09-tag' = into staging (2020-11-09 20:29:04 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-5.2-

[PULL 2/3] linux-user/sparc: Correct set/get_context handling of fp and i7

From: Peter Maydell Because QEMU's user-mode emulation just directly accesses guest CPU state, for SPARC the guest register window state is not the same in the sparc64_get_context() and sparc64_set_context() functions as it is for the real kernel's versions of those functions. Specifically, for

Re: [PATCH v2 6/6] qemu-option: warn for short-form boolean options

Paolo Bonzini writes: > Il lun 9 nov 2020, 22:19 Markus Armbruster ha scritto: > >> This function now warns, except for "help" and "?". The exception >> applies even when we treat "help" and "?" as sugar for "help=on" and >> "?=on" because opts_accepts_any(). >> > > Right, because again help_wa

Re: [PATCH v2 4/6] qemu-option: clean up id vs. list->merge_lists

On 10/11/20 09:29, Markus Armbruster wrote: As we will see below, there are exceptions where we reject options that used to work. Do we want that? I think that, as long as we gain in consistency, we do. The special casing of "id" is a wart of the current parser and the less it shows that "i

Re: [PATCH 1/1] virtio-blk-ccw: tweak the default for num_queues

On 09.11.20 19:53, Halil Pasic wrote: > On Mon, 9 Nov 2020 17:06:16 +0100 > Cornelia Huck wrote: > >>> @@ -20,6 +21,11 @@ static void virtio_ccw_blk_realize(VirtioCcwDevice >>> *ccw_dev, Error **errp) >>> { >>> VirtIOBlkCcw *dev = VIRTIO_BLK_CCW(ccw_dev); >>> DeviceState *vdev = DE

Re: [PATCH] tests/vm: update openbsd to release 6.8

On 11/9/2020 3:13 AM, Thomas Huth wrote: On 07/11/2020 07.07, Brad Smith wrote: ping. It's not directly my turf, but I can add it to my next testing-related pull request if nobody else picks this patch up before. Please, if you could. Thank you. Thomas On 10/27/2020 6:22 AM, Brad Smith wr

Re: [PATCH for-5.2 1/3] linux-user/sparc: Fix errors in target_ucontext structures

Hello Laurent, you probably want to also apply my patch for stack_t definitions [1] that was mentioned in Peter Maydell's cover letter for the patch series. [1] https://patchew.org/QEMU/e9d47692-ee92-009f-6007-0abc3f502...@gmail.com/ On 10/11/20 07:53, Laurent Vivier wrote: > Le 05/11/2020 à 22:2

Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

On 09/11/2020 10:02, Thomas Huth wrote: Just out of interest how did you find this? My new workflow involves a local "make check" with all ppc targets and a pass through Travis-CI and it didn't show up there for me (or indeed Peter's pre-merge tests). I've found it with the scripts/device-cras

Re: [PATCH] ppc/translate: Fix unordered f64/f128 comparisons

On 10/11/20 04:24, Richard Henderson wrote: > On 11/9/20 2:21 AM, LemonBoy wrote: >> According to the PowerISA v3.1 reference, Table 68 "Actions for xscmpudp >> - Part 1: Compare Unordered", whenever one of the two operands is a NaN >> the SO bit is set while the other three bits are cleared. >> >>

Re: [PATCH] net/e1000e_core: make sure RDH never exceeds RDT in e1000e_ring_advance()

On Mon, Nov 9, 2020 at 3:38 AM Jason Wang wrote: > > > On 2020/11/5 下午6:56, Mauro Matteo Cascella wrote: > > The e1000e_write_packet_to_guest() function iterates over a set of > > receive descriptors by advancing rx descriptor head register (RDH) from > > its initial value to rx descriptor tail re

Re: [RFC PATCH for-QEMU-5.2] vfio: Make migration support experimental

* Alex Williamson (alex.william...@redhat.com) wrote: > On Mon, 9 Nov 2020 19:44:17 + > "Dr. David Alan Gilbert" wrote: > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > Per the proposed documentation for vfio device migration: > > > > > > Dirty pages are tracked when devic

Re: [PATCH 1/2] ppc/translate: Implement lxvwsx opcode

Is there any chance for this patch series to be merged for 5.2? On 09/11/20 18:39, Richard Henderson wrote: > On 11/9/20 1:17 AM, LemonBoy wrote: >> Implement the "Load VSX Vector Word & Splat Indexed" opcode, introduced >> in Power ISA v3.0. >> >> Buglink: https://bugs.launchpad.net/qemu/+bug/179

Re: QMP and the 'id' parameter

On Tue, Nov 10, 2020 at 07:22:26AM +0100, Markus Armbruster wrote: > John Snow writes: > > > The QMP specification states: > > > >> NOTE: Some errors can occur before the Server is able to read the "id" > >> member, in these cases the "id" member will not be part of the error > >> response, even

Re: [PATCH for-5.2] vhost-user: fix VHOST_USER_ADD/REM_MEM_REG truncation

On Mon, Nov 09, 2020 at 06:59:00PM +0100, Cornelia Huck wrote: > On Mon, 9 Nov 2020 17:43:55 + > Stefan Hajnoczi wrote: > > Fixes: f1aeb14b0809e313c74244d838645ed25e85ea63 ("Transmit vhost-user > > memory regions individually") > > I think the canonical format is > > Fixes: f1aeb14b0809 ("

RE: [PATCH v13 0/4] Add Versal usb model

Hi Philippe > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Tuesday, November 10, 2020 1:27 PM > To: Sai Pavan Boddu ; Peter Maydell > ; Markus Armbruster ; > Marc-André Lureau ; Paolo Bonzini > ; Gerd Hoffmann ; Edgar Iglesias > ; Francisco Eduardo Iglesias ; > Alistair > Fr

Re: [RFC v2] VFIO Migration

On Thu, Nov 05, 2020 at 04:52:20PM +0100, Cornelia Huck wrote: > On Thu, 5 Nov 2020 15:09:02 + > Stefan Hajnoczi wrote: > > (...) > > something> > > > VFIO/mdev Devices > > - > > TODO this is a first draft, more thought needed around enumerating supported > > parameters, re

Re: [RFC v1 09/10] i386: split cpu.c and defer x86 models registration

On 11/9/20 7:03 PM, Daniel P. Berrangé wrote: > On Mon, Nov 09, 2020 at 06:27:54PM +0100, Claudio Fontana wrote: >> split cpu.c into: >> >> cpu.ccpuid and common x86 cpu functionality >> host-cpu.c host x86 cpu functions and "host" cpu type >> kvm-cpu-type.c KVM x86 cpu type >>

Re: [PATCH for-5.2 1/3] linux-user/sparc: Fix errors in target_ucontext structures

Le 10/11/2020 à 10:02, LemonBoy a écrit : > Hello Laurent, > you probably want to also apply my patch for stack_t definitions [1] that > was mentioned in Peter Maydell's cover letter for the patch series. > > [1] https://patchew.org/QEMU/e9d47692-ee92-009f-6007-0abc3f502...@gmail.com/ Yes, you're

Re: [RFC v1 09/10] i386: split cpu.c and defer x86 models registration

Hello Eduardo, thank you for your answer, On 11/9/20 8:04 PM, Eduardo Habkost wrote: > On Mon, Nov 09, 2020 at 06:27:54PM +0100, Claudio Fontana wrote: >> split cpu.c into: >> >> cpu.ccpuid and common x86 cpu functionality >> host-cpu.c host x86 cpu functions and "host" cpu type

Re: [RFC v2] VFIO Migration

On Thu, Nov 05, 2020 at 12:37:08PM -0700, Alex Williamson wrote: > On Thu, 5 Nov 2020 15:09:02 + > Stefan Hajnoczi wrote: > > The disk image file may indirectly affect the hardware interface, for > > example > > by constraining the device's block size. In this case a block-size=N > > migrati

Re: [PATCH v2 4/6] qemu-option: clean up id vs. list->merge_lists

Paolo Bonzini writes: > On 10/11/20 09:29, Markus Armbruster wrote: >> As we will see below, there are exceptions where we reject >> options that used to work. Do we want that? > > I think that, as long as we gain in consistency, we do. The special > casing of "id" is a wart of the current pars

[RFC v3] VFIO Migration

v3: * Introduce migration info JSON to describe migration parameters * Rework mdev sysfs interface * Propose standard interface for vfio-user device emulation programs VFIO Migration == This document describes how to ensure migration compatibility for VFIO devices, including mdev an

Re: [RFC v1 09/10] i386: split cpu.c and defer x86 models registration

On Tue, Nov 10, 2020 at 10:40:04AM +0100, Claudio Fontana wrote: > On 11/9/20 7:03 PM, Daniel P. Berrangé wrote: > > On Mon, Nov 09, 2020 at 06:27:54PM +0100, Claudio Fontana wrote: > >> split cpu.c into: > >> > >> cpu.ccpuid and common x86 cpu functionality > >> host-cpu.c host x

Re: [RFC v1 07/10] i386: move TCG cpu class initialization out of helper.c

On 11/9/20 6:39 PM, Paolo Bonzini wrote: > On 09/11/20 18:27, Claudio Fontana wrote: >> Signed-off-by: Claudio Fontana >> --- >> target/i386/accel/tcg/bpt_helper.c | 1 + >> target/i386/accel/tcg/cc_helper.c | 1 + >> target/i386/accel/tcg/excp_helper.c | 1 + >> target/i386/accel/tc

Re: Qemu first time contribution

Hi Stefan, This looks interesting, let me take a look at it. Thank you! Best, Harsha On Mon, Nov 9, 2020 at 10:17 AM Stefan Hajnoczi wrote: > > On Sun, Nov 08, 2020 at 12:21:33PM +, Harshavardhan Unnibhavi wrote: > > Thank you for the reply! Yes, I understand that gsoc is over for 2020, > >

Re: [PATCH v2] migration/multifd: close TLS channel before socket finalize

On Fri, Nov 06, 2020 at 06:54:54PM +0800, Chuan Zheng wrote: > Since we now support tls multifd, when we cancel migration, the TLS > sockets will be left as CLOSE-WAIT On Src which results in socket > leak. > Fix it by closing TLS channel before socket finalize. > > Signed-off-by: Chuan Zheng > -

Re: [RFC v1 09/10] i386: split cpu.c and defer x86 models registration

On 11/10/20 11:04 AM, Daniel P. Berrangé wrote: > On Tue, Nov 10, 2020 at 10:40:04AM +0100, Claudio Fontana wrote: >> On 11/9/20 7:03 PM, Daniel P. Berrangé wrote: >>> On Mon, Nov 09, 2020 at 06:27:54PM +0100, Claudio Fontana wrote: split cpu.c into: cpu.ccpuid and common

Re: [PATCH 1/1] virtio-blk-ccw: tweak the default for num_queues

On Tue, 10 Nov 2020 09:47:51 +0100 Christian Borntraeger wrote: > On 09.11.20 19:53, Halil Pasic wrote: > > On Mon, 9 Nov 2020 17:06:16 +0100 > > Cornelia Huck wrote: > > > >>> @@ -20,6 +21,11 @@ static void virtio_ccw_blk_realize(VirtioCcwDevice > >>> *ccw_dev, Error **errp) > >>> { > >>>

Re: [PATCH v3 07/11] gitlab-ci: Extract common job definition as 'cross_common_job'

On 11/9/20 10:52 AM, Thomas Huth wrote: > On 08/11/2020 23.19, Philippe Mathieu-Daudé wrote: >> Extract the common definitions shared by '.cross_system_build_job' >> and '.cross_user_build_job' to '.cross_common_job'. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> .gitlab-ci.d/crossbuilds.

Re: QMP and the 'id' parameter

Daniel P. Berrangé writes: > On Tue, Nov 10, 2020 at 07:22:26AM +0100, Markus Armbruster wrote: [...] >> Command responses get sent strictly in order (even parse errors), except >> for commands executed out-of-band. > > With out of band commands, how much runs in the background ? Is the > JSON pa

[PATCH v2-for-5.2] macio: set user_creatable to false in macio_class_init()

Commit 348b8d1a76 "macio: don't reference serial_hd() directly within the device" removed the setting of user_creatable to false on the basis that the restriction was due to the use of serial_hd() in macio_instance_init(). Unfortunately this isn't the full story since the PIC object property link

Re: [PATCH v2 00/44] Make qdev static property API usable by any QOM type

Am 09.11.2020 um 21:28 hat Eduardo Habkost geschrieben: > On Mon, Nov 09, 2020 at 08:27:21PM +0100, Paolo Bonzini wrote: > > On 09/11/20 19:55, Eduardo Habkost wrote: > > > On Mon, Nov 09, 2020 at 06:33:04PM +0100, Paolo Bonzini wrote: > > > > On 09/11/20 18:16, Eduardo Habkost wrote: > > > > > I m

Re: [PATCH 1/1] virtio-blk-ccw: tweak the default for num_queues

On Tue, 10 Nov 2020 09:47:51 +0100 Christian Borntraeger wrote: > > > On 09.11.20 19:53, Halil Pasic wrote: > > On Mon, 9 Nov 2020 17:06:16 +0100 > > Cornelia Huck wrote: > > > >>> @@ -20,6 +21,11 @@ static void virtio_ccw_blk_realize(VirtioCcwDevice > >>> *ccw_dev, Error **errp) > >>> { >

Re: [RFC v1 09/10] i386: split cpu.c and defer x86 models registration

On 10/11/20 11:04, Daniel P. Berrangé wrote: ie, we should have one class hierarchy for CPU model definitions, and one class hierarchy for accelerator CPU implementations. So at runtime we then get two object instances - a CPU implementation and a CPU definition. The CPU implementation object

Re: [RFC v1 07/10] i386: move TCG cpu class initialization out of helper.c

On 10/11/20 11:05, Claudio Fontana wrote: Up to this patch I think it's a no brainer, modulo the bikeshedding on paths. Paolo Ok, the paths: I kinda liked the symmetry between: $(top_srcdir)/accel/kvm $(top_srcdir)/target/i386/accel/kvm but yeah, minor think that can be dropped if necessary

Re: [PATCH v2] migration/multifd: close TLS channel before socket finalize

On 2020/11/10 18:12, Daniel P. Berrangé wrote: > On Fri, Nov 06, 2020 at 06:54:54PM +0800, Chuan Zheng wrote: >> Since we now support tls multifd, when we cancel migration, the TLS >> sockets will be left as CLOSE-WAIT On Src which results in socket >> leak. >> Fix it by closing TLS channel befo

Re: [PATCH 0/3] tests/qtest: npcm7xx test fixes

On Tue, 3 Nov 2020 at 01:52, Philippe Mathieu-Daudé wrote: > > Cc'ing Daniel (patches 1-3) & Marc-André (2). > > On 11/3/20 2:14 AM, Havard Skinnemoen via wrote: > > This series contains a fix for the randomness calculation in > > npcm7xx_rng-test. > > It also makes test failures fatal. The last

Re: [PULL 0/6] riscv-to-apply queue

On Tue, 10 Nov 2020 at 04:09, Alistair Francis wrote: > > The following changes since commit 3c8c36c9087da957f580a9bb5ebf7814a753d1c6: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20201104-pull-request' > into staging (2020-11-04 16:52:17 +) > > are available in the Git reposito

[PATCH v2 0/4] ppc/translate: Fix unordered f64/f128 comparisons

Fix a couple of problems found in the emulation of f64/f128 comparisons plus some minimal self-contained commits to clean-up some code. Is it too late to ask for inclusion in the upcoming release? Giuseppe Musacchio (4): ppc/translate: Fix unordered f64/f128 comparisons ppc/translate: Turn th

[PATCH v2 3/4] ppc/translate: Delay NaN checking after comparison

Since we always perform a comparison between the two operands avoid checking for NaN unless the result states they're unordered. Suggested-by: Richard Henderson Signed-off-by: Giuseppe Musacchio --- target/ppc/fpu_helper.c | 82 + 1 file changed, 42 inser

[PATCH v2 1/4] ppc/translate: Fix unordered f64/f128 comparisons

According to the PowerISA v3.1 reference, Table 68 "Actions for xscmpudp - Part 1: Compare Unordered", whenever one of the two operands is a NaN the SO bit is set while the other three bits are cleared. Apply the same change to xscmpuqp. The respective ordered counterparts are unaffected. Signed

[PATCH v2 2/4] ppc/translate: Turn the helper macros into functions

Suggested-by: Richard Henderson Signed-off-by: Giuseppe Musacchio --- target/ppc/fpu_helper.c | 220 +--- 1 file changed, 118 insertions(+), 102 deletions(-) diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c index b07ff66375..c74c080c17 100644 --

[PATCH v2 4/4] ppc/translate: Raise exceptions after setting the cc

The PowerISA reference states that the comparison operators update the FPCC, CR and FPSCR and, if VE=1, jump to the exception handler. Moving the exception-triggering code after the CC update sequence solves the problem. Signed-off-by: Giuseppe Musacchio --- target/ppc/fpu_helper.c | 28 +++

Re: [PATCH v2 00/44] Make qdev static property API usable by any QOM type

On 09/11/20 21:28, Eduardo Habkost wrote: I don't know yet what's the best solution for the x86 feature case. Maybe duplicating the list of feature names would be a small price to pay to get a static list of properties defined at compilation time? Maybe we can replace FeatureWordInfo.feat_names

Re: [PULL 5/7] gitlab-ci: Move edk2 and opensbi YAML files to .gitlab-ci.d folder

On 10/13/20 4:18 PM, Philippe Mathieu-Daudé wrote: > On 10/12/20 4:01 PM, Daniel P. Berrangé wrote: >> On Mon, Oct 12, 2020 at 03:44:00PM +0200, Philippe Mathieu-Daudé wrote: >>> Hi Thomas, Alex, >>> >>> +Daniel >>> >>> On 5/28/20 12:10 PM, Thomas Huth wrote: We have a dedicated folder for the

Re: [PATCH v2] migration/multifd: close TLS channel before socket finalize

On Tue, Nov 10, 2020 at 06:45:45PM +0800, Zheng Chuan wrote: > > > On 2020/11/10 18:12, Daniel P. Berrangé wrote: > > On Fri, Nov 06, 2020 at 06:54:54PM +0800, Chuan Zheng wrote: > >> Since we now support tls multifd, when we cancel migration, the TLS > >> sockets will be left as CLOSE-WAIT On Sr

[PULL 00/19] qtests, gitlab, s390x and misc patches

Hi Peter, the following changes since commit a2547c1ba911a0c53a10fe02d94a0f539dc064cc: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-11-09' into staging (2020-11-09 13:55:15 +) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pull-reques

[PULL 01/19] meson: always include contrib/libvhost-user

From: Stefan Hajnoczi libvhost-user is needed when CONFIG_LINUX is set. The CONFIG_VHOST_USER check in meson.build is incorrect. In fact, no explicit check is needed since this dependency is not built by default. If something declares a dependency on libvhost-user then it will be built, otherwis

[PULL 06/19] gitlab-ci: Drop generic cache rule

From: Philippe Mathieu-Daudé This cache rule is meant for Avocado artifacts, but affects all jobs. Moreover the 'acceptance_template' template already include a more detailled rule to cache artifacts. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201108221925.2344515-2-phi...@redhat.com>

[PULL 03/19] device-crash-test: Check if path is actually an executable file

From: Eduardo Habkost After the transition to Meson, the build directory now have subdirectories named "qemu-system-*.p", and device-crash-test will try to execute them as if they were binaries. This results in errors like: PermissionError: [Errno 13] Permission denied: './qemu-system-or1k.p'

[PULL 09/19] docs/fuzz: update fuzzing documentation post-meson

From: Alexander Bulekov Signed-off-by: Alexander Bulekov Message-Id: <20201106180600.360110-3-alx...@bu.edu> Signed-off-by: Thomas Huth --- docs/devel/fuzzing.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/devel/fuzzing.rst b/docs/devel/fuzzing.rst index f19

[PULL 11/19] fuzz: Make fork_fuzz.ld compatible with LLVM's LLD

From: Daniele Buono LLVM's linker, LLD, supports the keyword "INSERT AFTER", starting with version 11. However, when multiple sections are defined in the same "INSERT AFTER", they are added in a reversed order, compared to BFD's LD. This patch makes fork_fuzz.ld generic enough to work with both

[PULL 04/19] qtest: Fix bad printf format specifiers

From: AlexChen We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen Message-Id: <5fa28117.3020...@huawei.com> Signed-off-by: Thomas Huth --- tests/qtest/arm-cpu-features.c | 8 1 file change

[PULL 02/19] tests/vm: update openbsd to release 6.8

From: Brad Smith A double dash at the end of a package name removes ambiguity when the intent is to install a non-FLAVORed package. Signed-off-by: Brad Smith Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201027053048.gb64...@humpty.hom

[PULL 10/19] scripts/oss-fuzz: give all fuzzers -target names

From: Alexander Bulekov We switched to hardlinks in a942f64cc4 ("scripts/oss-fuzz: use hardlinks instead of copying") The motivation was to conserve space (50 fuzzers built with ASAN, can weigh close to 9 GB). Unfortunately, OSS-Fuzz (partially) treated the underlying copy of the fuzzer as a st

[PULL 13/19] gitlab: publish the docs built during CI

From: Daniel P. Berrangé Most of the build jobs will create the sphinx documentation. If we expose this as an artifact of a "pages" job in a "public" directory, it will get published using GitLab Pages. This means a user can push a branch with docs changes to GitLab and view the results at htt

[PULL 05/19] tests/qtest/tpm: Remove redundant check in the tpm_test_swtpm_test()

From: AlexChen The 'addr' would not be NULL after checking 'succ' is valid, and it has been dereferenced in the previous code(args = g_strdup_printf()). So the check on 'addr' in the tpm_test_swtpm_test() is redundant. Remove it. Reported-by: Euler Robot Signed-off-by: Alex Chen Message-Id: <5

[PULL 07/19] MAINTAINERS: Add gitlab-pipeline-status script to GitLab CI section

From: Philippe Mathieu-Daudé Do not let the gitlab-pipeline-status script unmaintained, add it to the 'GitLab Continuous Integration' section. Fixes: c02b2eac55e ("GitLab Gating CI: introduce pipeline-status contrib script") Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201108204535.231

QOM address space handling

Hi all, This email follows on from my investigation of intermittent Travis-CI failures in make check's device-introspect test when trying to add the patch at https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg06093.html to my last qemu-sparc pull request. The patch itself seems fairly

[PULL 01/16] hw/arm/Kconfig: ARM_V7M depends on PTIMER

From: Andrew Jones commit 32bd322a0134 ("hw/timer/armv7m_systick: Rewrite to use ptimers") changed armv7m_systick to build on ptimers. Make sure we have ptimers in the build when building armv7m_systick. Signed-off-by: Andrew Jones Reviewed-by: Philippe Mathieu-Daudé Message-id: 20201104103343

[PULL 12/19] configure: surface deprecated targets in the help output

From: Alex Bennée Show the targets but keep them separate from the main list. Signed-off-by: Alex Bennée Message-Id: <20201029201449.6926-1-alex.ben...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth ---

[PULL 08/19] docs/fuzz: rST-ify the fuzzing documentation

From: Alexander Bulekov Signed-off-by: Alexander Bulekov Message-Id: <20201106180600.360110-2-alx...@bu.edu> Signed-off-by: Thomas Huth --- MAINTAINERS| 2 +- docs/devel/fuzzing.rst | 236 + docs/devel/fuzzing.txt | 214

[PULL 08/16] target/arm: Fix neon VTBL/VTBX for len > 1

From: Richard Henderson The helper function did not get updated when we reorganized the vector register file for SVE. Since then, the neon dregs are non-sequential and cannot be simply indexed. At the same time, make the helper function operate on 64-bit quantities so that we do not have to cal

[PULL 15/19] docs: add "page source" link to sphinx documentation

From: Daniel P. Berrangé Add a link to the top of the sidebar in every docs page that takes the user back to the source code in gitlab. Signed-off-by: Daniel P. Berrangé Message-Id: <20201102130926.161183-5-berra...@redhat.com> Signed-off-by: Thomas Huth --- docs/_templates/editpage.html

[PULL 00/16] target-arm queue

) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20201110 for you to fetch changes up to b6c56c8a9a4064ea783f352f43c5df6231a110fa: target/arm/translate-neon.c: Handle VTBL UNDEF case before VFP access check (2020-11-10 11:0

[PULL 14/19] gitlab: force enable docs build in Fedora, Ubuntu, Debian

From: Daniel P. Berrangé Meson runs a test to see if Sphinx works, and automatically disables it on error. This can lead to the CI jobs skipping docs build without maintainers noticing the problem. Use --enable-docs to force a fatal error if Sphinx doesn't work on the jobs where we expect it to b

[PULL 11/16] hw/arm/nseries: Remove invalid/unnecessary n8x0_uart_setup()

From: Philippe Mathieu-Daudé omap2420_mpu_init() introduced in commit 827df9f3c5f ("Add basic OMAP2 chip support") takes care of creating the 3 UARTs. Then commit 58a26b477e9 ("Emulate a serial bluetooth HCI with H4+ extensions and attach to n8x0's UART") added n8x0_uart_setup() which create the

[PULL 04/16] target/arm: Don't use '#' flag of printf format

From: Xinhao Zhang Fix code style. Don't use '#' flag of printf format ('%#') in format strings, use '0x' prefix instead Signed-off-by: Xinhao Zhang Signed-off-by: Kai Deng Message-id: 20201103114529.638233-2-zhangxinh...@huawei.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell ---

[PULL 16/19] fuzz: add virtio-blk fuzz target

From: Dima Stepanov The virtio-blk fuzz target sets up and fuzzes the available virtio-blk queues. The implementation is based on two files: - tests/qtest/fuzz/virtio_scsi_fuzz.c - tests/qtest/virtio_blk_test.c Signed-off-by: Dima Stepanov Reviewed-by: Alexander Bulekov Message-Id: Signe

Re: [RFC v3] VFIO Migration

On 10/11/20 10:53, Stefan Hajnoczi wrote: "allowed_values" The list all values that the device implementation accepts for this migration parameter. Integer ranges can be described using "-" strings. Examples: ['a', 'b', 'c'], [1, 5, 7], ['0-255', 512, '1024-2048'], [true] This membe

[PULL 15/16] tests/qtest/npcm7xx_rng-test: count runs properly

From: Havard Skinnemoen The number of runs is equal to the number of 0-1 and 1-0 transitions, plus one. Currently, it's counting the number of times these transitions do _not_ happen, plus one. Source: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-22r1a.pdf section 2.3.4

[PULL 17/19] qtest: Update references to parse_escape() in comments

From: Peter Maydell In commit 61030280ca2d67bd in 2018 we renamed the parse_escape() function to parse_interpolation(), but we didn't catch the references to this function in doc comments in libqtest.h. Update them. Signed-off-by: Peter Maydell Message-Id: <20201109162621.18885-1-peter.mayd...@

[PULL 03/16] target/arm: add spaces around operator

From: Xinhao Zhang Fix code style. Operator needs spaces both sides. Signed-off-by: Xinhao Zhang Signed-off-by: Kai Deng Message-id: 20201103114529.638233-1-zhangxinh...@huawei.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/arch_dump.c | 8 target/arm/ar

[PULL 06/16] docs: add some notes on the sbsa-ref machine

From: Alex Bennée We should at least document what this machine is about. Reviewed-by: Graeme Gregory Signed-off-by: Alex Bennée Message-id: 20201104165254.24822-1-alex.ben...@linaro.org Cc: Leif Lindholm Cc: Shashi Mallela Signed-off-by: Alex Bennée [PMM: fixed filename mismatch] Signed-of

[PULL 16/16] target/arm/translate-neon.c: Handle VTBL UNDEF case before VFP access check

Checks for UNDEF cases should go before the "is VFP enabled?" access check, except in special cases. Move a stray UNDEF check in the VTBL trans function up above the access check. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20201109145324.2859-1-peter.mayd...@linaro.o

[PULL 18/19] s390x: fix clang 11 warnings in cpu_models.c

From: Daniele Buono There are void * pointers that get casted to enums, in cpu_models.c Such casts can result in a small integer type and are caught as warnings with clang, starting with version 11: Clang 11 finds a bunch of spots in the code that trigger this new warnings: ../qemu-base/target/

[PULL 02/16] ssi: Fix bad printf format specifiers

From: AlexChen We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen Reviewed-by: Alistair Francis Message-id: 5fa280f5.8060...@huawei.com Signed-off-by: Peter Maydell --- hw/ssi/imx_spi.c| 2 +-

[PULL 1/6] meson: Clarify the confusing vhost-user vs. vhost-kernel output

From: Thomas Huth The configuration summary prints a line with "vhost-user: YES/NO", but the value is currently the vhost-kernel setting instead which looks wrong. Print the kernel setting in a separate line and switch the "vhost-user:" line to CONFIG_VHOST_USER instead. Signed-off-by: Thomas Hu

[PULL 05/16] target/arm: add space before the open parenthesis '('

From: Xinhao Zhang Fix code style. Space required before the open parenthesis '('. Signed-off-by: Xinhao Zhang Signed-off-by: Kai Deng Message-id: 20201103114529.638233-3-zhangxinh...@huawei.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/translate.c | 2 +- 1 fil

[PULL 19/19] s390x: Avoid variable size warning in ipl.h

From: Daniele Buono S390IPLState contains two IplParameterBlock, which may in turn have either a IPLBlockPV or a IplBlockFcp, both ending with a variable sized field (an array). This causes a warning with clang 11 or greater, which checks that variable sized type are only allocated at the end of

[PULL 0/6] Misc fixes for QEMU 5.2-rc2

The following changes since commit 3493c36f0371777c62d1d72b205b0eb6117e2156: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201106' into staging (2020-11-06 13:43:28 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to f

[PULL 07/16] hw/arm/virt: Remove dependency on Cortex-A15 MPCore peripherals

From: Philippe Mathieu-Daudé When using a Cortex-A15, the Virt machine does not use any MPCore peripherals. Remove the dependency. Fixes: 7951c7b7c05 ("hw/arm: Express dependencies of the virt machine with Kconfig") Reported-by: Miroslav Rezanina Signed-off-by: Philippe Mathieu-Daudé Message-

[PULL 09/16] hw/arm/armsse: Correct expansion MPC interrupt lines

From: Philippe Mathieu-Daudé We can use one MPC per SRAM bank, but we currently only wire the IRQ from the first expansion MPC to the IRQ splitter. Fix that. Fixes: bb75e16d5e6 ("hw/arm/iotkit: Wire up MPC interrupt lines") Signed-off-by: Philippe Mathieu-Daudé Message-id: 20201107193403.436146

[PULL 6/6] pvpanic: Advertise the PVPANIC_CRASHLOADED event support

Advertise both types of events as supported when the guest OS queries the pvpanic device. Currently only PVPANIC_PANICKED is exposed; PVPANIC_CRASHLOADED must also be advertised, but only on new machine types. Fixes: 7dc58deea79a ("pvpanic: implement crashloaded event handling") Reported-by: Alej

[PULL 10/16] hw/misc/stm32f2xx_syscfg: Remove extraneous IRQ

From: Philippe Mathieu-Daudé The system configuration controller (SYSCFG) doesn't have any output IRQ (and the INTC input #71 belongs to the UART6). Remove the invalid code. Fixes: db635521a02 ("stm32f205: Add the stm32f205 SoC") Signed-off-by: Philippe Mathieu-Daudé Message-id: 20201107193403.

[PULL 13/16] hw/arm/musicpal: Only use qdev_get_gpio_in() when necessary

From: Philippe Mathieu-Daudé We don't need to fill the full pic[] array if we only use few of the interrupt lines. Directly call qdev_get_gpio_in() when necessary. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20201107193403.436146-6-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by

[PULL 2/6] fix make clean/distclean

A misplaced $(quiet-@) meant that "make clean" and "make distclean" did not work properly. Reported-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefi

[PULL 14/16] hw/arm/nseries: Check return value from load_image_targphys()

The nseries machines have a codepath that allows them to load a secondary bootloader. This code wasn't checking that the load_image_targphys() succeeded. Check the return value and report the error to the user. While we're in the vicinity, fix the comment style of the comment documenting what th

[PULL 12/16] hw/arm/musicpal: Don't connect two qemu_irqs directly to the same input

From: Philippe Mathieu-Daudé The MusicPal board code connects both of the IRQ outputs of the UART to the same INTC qemu_irq. Connecting two qemu_irqs outputs directly to the same input is not valid as it produces subtly wrong behaviour (for instance if both the IRQ lines are high, and then one go

[PULL 4/6] Makefile: No echoing for 'make help V=1'

From: Greg Kurz It doesn't bring much to have echoing with "make help". Suppress it unconditionally. Signed-off-by: Greg Kurz Message-Id: <160459122012.462591.8467906402712875729.st...@bahia.lan> Signed-off-by: Paolo Bonzini --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PULL 5/6] physmem: improve ram size error messages

From: Pankaj Gupta Ram size mismatch condition logs below message. "Length mismatch: pc.ram: 0x8000 in != 0x18000: Invalid argument" This patch improves the readability of error messages. Removed the superflous "in" and changed "Length" to "Size". Signed-off-by: Pankaj Gupta Rep

[PULL 3/6] replay: remove some dead code

From: Pavel Dovgalyuk This patch removes dead code in replay_continue_stop() function. Signed-off-by: Pavel Dovgalyuk Reported-by: Philippe Mathieu-Daudé Message-Id: <160455661411.3455.4177953912304752892.stgit@pasha-ThinkPad-X280> Signed-off-by: Paolo Bonzini --- replay/replay-debugging.c |

Re: [PATCH V2] virtiofsd: Use --thread-pool-size=0 to mean no thread pool

On Mon, Nov 09, 2020 at 09:35:48AM -0500, Vivek Goyal wrote: > Right now we create a thread pool and main thread hands over the request > to thread in thread pool to process. Number of threads in thread pool > can be managed by option --thread-pool-size. > > In tests we have noted that many of the

Re: [PATCH v3 0/2] plugins: Fix some resource leaks

Alex Chen writes: > There are 3 resource leaks in contrib/plugins/lockstep.c, fix it. Queued to for-5.2/various-fixes, thanks. > > v2->v3: > - change the "From" line to "Alex Chen" > > v1->v2: > - add the cover letter > - modify the subject of the patch[2/2] > > Alex Chen (2): > plugins: Fi

Re: [PULL 0/6] Misc fixes for QEMU 5.2-rc2

Patchew URL: https://patchew.org/QEMU/20201110112909.1103518-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20201110112909.1103518-1-pbonz...@redhat.com Subject: [PULL 0/6] Misc fixes for QEMU 5.2-rc2 Type: s

  1   2   3   4   >