Paolo Bonzini writes:
> On 06/11/20 17:49, Markus Armbruster wrote:
>>> Deprecate all this, except for -chardev and -spice where it is in
>>> wide use.
>> I consider this a misuse of deprecation, to be frank. If something is
>> known to be unused, we just remove it. Deprecation is precisely for
Public bug reported:
As a rookie, I don’t know if I should ask this question here. If it’s
not right, I hope people who see it can help submit it to the right
place. Qemu-kvm can add wireless network card bridging, after all, now
you see that vbox and vmware can directly choose wireless network ca
On 08/11/2020 12.58, Peter Maydell wrote:
> On Sun, 8 Nov 2020 at 09:01, Thomas Huth wrote:
>> I agree with Daniel. Please let's not clog the new bug tracker right from
>> the start with hundreds of bugs - that only makes it harder to focus on the
>> tickets that are really important. Let's use th
This test is regularly failing on CI :( Do not run it automatically.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/boot_linux_console.py | 1 +
tests/acceptance/replay_kernel.py | 1 +
2 files changed, 2 insertions(+)
diff --git a/tests/acceptance/boot_linux_console.py
b/test
This test is regularly failing on CI:
(05/34)
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_microblaze_s3adsp1800:
Linux version 4.11.3 (th...@thuth.remote.csb) (gcc version 6.4.0 (Buildroot
2018.05.2) ) #5 Tue Dec 11 11:56:23 CET 2018
...
Freeing unused kernel memory: 14
On 11/9/20 9:12 AM, Philippe Mathieu-Daudé wrote:
> This test is regularly failing on CI:
>
>(05/34)
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_microblaze_s3adsp1800:
> Linux version 4.11.3 (th...@thuth.remote.csb) (gcc version 6.4.0 (Buildroot
> 2018.05.2) ) #5 Tue Dec
On 07/11/2020 07.07, Brad Smith wrote:
> ping.
It's not directly my turf, but I can add it to my next testing-related pull
request if nobody else picks this patch up before.
Thomas
> On 10/27/2020 6:22 AM, Brad Smith wrote:
>> On Tue, Oct 27, 2020 at 11:05:20AM +0100, Philippe Mathieu-Daud?? wr
Max Reitz writes:
> Hi,
>
> Markus has revived a rather old patch to remove an unused QAPI
> structure:
>
> https://lists.nongnu.org/archive/html/qemu-block/2020-10/msg01902.html
>
> He quoted a response of mine to the original patch, where I noted that
> removing this structure is OK because it
On 2020/11/6 21:17, Eric Blake wrote:
> On 11/5/20 7:59 PM, AlexChen wrote:
>> Close the fd when the connect() fails.
>>
>> Reported-by: Euler Robot
>> Signed-off-by: Alex Chen
>
> Your From: line ("AlexChen") is spelled differently than your S-o-b:
> line ("Alex Chen"). While this is not fatal
On 08/11/2020 21.45, Philippe Mathieu-Daudé wrote:
> Check vhost-user is available to build vhost-user-blk-server to fix:
>
> $ ../configure \
> --disable-vhost-user --enable-vhost-user-blk-server && \
>make qemu-nbd
> ...
> [505/505] Linking target qemu-nbd
> FAILED: qemu-nbd
> cc
There are 3 resource leaks in contrib/plugins/lockstep.c, fix it.
v2->v3:
- change the "From" line to "Alex Chen"
v1->v2:
- add the cover letter
- modify the subject of the patch[2/2]
Alex Chen (2):
plugins: Fix resource leak in connect_socket()
plugins: Fix two resource leaks in setup_socke
Close the fd when the connect() fails.
Reported-by: Euler Robot
Signed-off-by: Alex Chen
---
contrib/plugins/lockstep.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index a696673dff..319bd44b83 100644
--- a/contrib/plugins/lockstep.
Either accept() fails or exits normally, we need to close the fd.
Reported-by: Euler Robot
Signed-off-by: Alex Chen
---
contrib/plugins/lockstep.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index 319bd44b83..5aad50869d 100644
--
I get this on Fedora 32:
[12/8327] Generating trace-dtrace-hw_virtio.h with a custom command
Warning: /usr/bin/dtrace:trace/trace-dtrace-hw_virtio.dtrace:76: syntax error
near:
probe vhost_vdpa_dev_start
Warning: Proceeding as if --no-pyparsing was given.
06.11.2020 15:42, Andrey Shinkevich wrote:
The subject was discussed here:
https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg00206.html
This series is a solution for the issue with QMP monitor buffered input.
A little parser is introduced to throttle JSON commands read from the
buffer so
The configuration summary prints a line with "vhost-user: YES/NO",
but the value is currently the vhost-kernel setting instead which
looks wrong. Print the kernel setting in a separate line and switch
the "vhost-user:" line to CONFIG_VHOST_USER instead.
Signed-off-by: Thomas Huth
---
meson.build
Peter Maydell writes:
> On Fri, 6 Nov 2020 at 16:08, Markus Armbruster wrote:
>> Peter Maydell writes:
>> > Personally I just don't think checkpatch should be nudging people
>> > into folding 85-character lines, especially when there are
>> > multiple very similar lines in a row and only one wo
On 08/11/2020 16.54, Philippe Mathieu-Daudé wrote:
> On 11/6/20 10:03 PM, Stefan Hajnoczi wrote:
>> libvhost-user is needed when CONFIG_LINUX is set. The CONFIG_VHOST_USER
>> check in meson.build is incorrect.
>>
>> In fact, no explicit check is needed since this dependency is not built
>> by defau
The following changes since commit 3493c36f0371777c62d1d72b205b0eb6117e2156:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201106' into
staging (2020-11-06 13:43:28 +)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2020-11-09
for you
Based-on: <20201108234234.2389789-1-f4...@amsat.org>
Philippe Mathieu-Daudé (2):
target/mips: Replace magic values by CP0PM_MASK or
TARGET_PAGE_BITS_MIN
target/mips: Do not include CP0 helpers in user-mode emulation
target/mips/cp0_helper.c | 9 +++--
target/mips/helper.c | 4 ++-
From: Max Reitz
MapEntry and BlockDeviceMapEntry are kind of the same thing, and the
latter is not used, so we want to remove it. However, the documentation
it provides for some fields is better than that of MapEntry, so steal
some of it for the latter.
(And adjust them a bit in the process, be
Audio stuff is under "Miscellanea", and authorization stuff is under
"Input". Add suitable header doc comments to correct that.
Cc: Gerd Hoffmann
Cc: Daniel P. Berrange
Signed-off-by: Markus Armbruster
Message-Id: <20201102081550.171061-3-arm...@redhat.com>
Acked-by: Daniel P. Berrangé
---
q
BlockDeviceMapEntry has never been used. It was added in commit
facd6e2 "so that it is published through the introspection mechanism."
What exactly introspecting types that aren't used for anything could
accomplish isn't clear. What "introspection mechanism" to use is also
nebulous. To the best
Signed-off-by: Markus Armbruster
Message-Id: <20201027121026.3025930-1-arm...@redhat.com>
Reviewed-by: Marc-André Lureau
---
docs/devel/qapi-code-gen.txt | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
index c6
Replace magic values related to page size:
12 -> TARGET_PAGE_BITS_MIN
13 -> CP0PM_MASK
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/cp0_helper.c | 5 +++--
target/mips/helper.c | 4 ++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/target/mips/cp0_helper.c b/t
This patch enables zstd option in multi-thread compression.
Signed-off-by: Zeyu Jin
Signed-off-by: Ying Fang
---
hw/core/qdev-properties-system.c | 2 +-
migration/ram.c | 128 ++-
qapi/migration.json | 2 +-
3 files changed, 129 ins
Add the relevant QAPI schema modules to section Audio, QMP, Tracing,
Cryptography.
Cc: Gerd Hoffmann
Cc: Stefan Hajnoczi
Cc: Daniel P. Berrange
Signed-off-by: Markus Armbruster
Message-Id: <20201102081550.171061-2-arm...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Hajn
On 09/11/2020 09.07, Philippe Mathieu-Daudé wrote:
> This test is regularly failing on CI :( Do not run it automatically.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/acceptance/boot_linux_console.py | 1 +
> tests/acceptance/replay_kernel.py | 1 +
> 2 files changed, 2 insertion
CP0 helpers are restricted to system-mode emulation.
Do not intent do build cp0_helper.c in user-mode (this
allows to simplify some #ifdef'ry).
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/cp0_helper.c | 4
target/mips/meson.build | 2 +-
2 files changed, 1 insertion(+), 5 deletio
Code refactor for the compression procedure which includes:
1. Move qemu_compress_data and qemu_put_compression_data from qemu-file.c to
ram.c, for the reason that most part of the code logical has nothing to do
with qemu-file. Besides, the decompression code is located at ram.c only.
2. Simplify
Currently we have both multi-thread compression and multifd to optimize
live migration in Qemu. Mulit-thread compression deals with the situation
where network bandwith is limited but cpu resource adequate. Multifd instead
aims to take full advantage of network bandwith. Moreover it supports both
z
Add the MigrationCompressOps and MigrationDecompressOps structures to make
the compression method configurable for multi-thread compression migration.
Signed-off-by: Zeyu Jin
Signed-off-by: Ying Fang parameters.decompress_threads;
}
+CompressMethod migrate_compress_method(void)
+{
+Migrati
A multi-thread compress method parameter is added to hold the method we
are going to use. By default the 'zlib' method is used to maintain the
compatibility as before.
Signed-off-by: Zeyu Jin
Signed-off-by: Ying Fang
---
hw/core/qdev-properties-system.c | 11 +++
include/hw/qdev-propert
On 09/11/20 09:59, Thomas Huth wrote:
The configuration summary prints a line with "vhost-user: YES/NO",
but the value is currently the vhost-kernel setting instead which
looks wrong. Print the kernel setting in a separate line and switch
the "vhost-user:" line to CONFIG_VHOST_USER instead.
Sign
Zlib compression has level from 1 to 9. However Zstd compression has level
from 1 to 22 (level >= 20 not recommanded). Let's do sanity check here
to make sure a vaild compress_level is given by user.
Signed-off-by: Zeyu Jin
Signed-off-by: Ying Fang
---
migration/migration.c | 32 +++
On 11/9/20 10:04 AM, Thomas Huth wrote:
> On 09/11/2020 09.07, Philippe Mathieu-Daudé wrote:
>> This test is regularly failing on CI :( Do not run it automatically.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> tests/acceptance/boot_linux_console.py | 1 +
>> tests/acceptance/replay_kerne
This test is regularly failing on CI:
(05/34)
tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_microblaze_s3adsp1800:
Linux version 4.11.3 (th...@thuth.remote.csb) (gcc version 6.4.0 (Buildroot
2018.05.2) ) #5 Tue Dec 11 11:56:23 CET 2018
...
Freeing unused kernel memory: 14
Modify the doc to fit the previous changes.
Signed-off-by: Zeyu Jin
Signed-off-by: Ying Fang
---
docs/multi-thread-compression.txt | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/docs/multi-thread-compression.txt
b/docs/multi-thread-compres
> > > * *Error* in a reply message indicates the command being
> acknowledged
> > had
> > > an error. In this case, the *Error* field will be valid.
> > >
> > > * *Error* in a reply message is a UNIX errno value. It is reserved in a
> > command message.
> >
> > I'm not quite following why we
On 11/9/20 10:16 AM, Thomas Huth wrote:
> On 09/11/2020 10.09, Philippe Mathieu-Daudé wrote:
>> On 11/9/20 10:04 AM, Thomas Huth wrote:
>>> On 09/11/2020 09.07, Philippe Mathieu-Daudé wrote:
This test is regularly failing on CI :( Do not run it automatically.
Signed-off-by: Philippe
On 09/11/2020 10.09, Philippe Mathieu-Daudé wrote:
> On 11/9/20 10:04 AM, Thomas Huth wrote:
>> On 09/11/2020 09.07, Philippe Mathieu-Daudé wrote:
>>> This test is regularly failing on CI :( Do not run it automatically.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé
>>> ---
>>> tests/acceptance/bo
Implement the "Load VSX Vector Word & Splat Indexed" opcode, introduced
in Power ISA v3.0.
Buglink: https://bugs.launchpad.net/qemu/+bug/1793608
Signed-off-by: Giuseppe Musacchio
---
target/ppc/translate/vsx-impl.c.inc | 30 +
target/ppc/translate/vsx-ops.c.inc | 1
Make the implementation match the lxvwsx one.
The code is now shorter smaller and potentially faster as the
translation will use the host SIMD capabilities if available.
No functional change.
Signed-off-by: Giuseppe Musacchio
---
target/ppc/translate/vsx-impl.c.inc | 46 ++--
On 11/9/20 9:48 AM, Markus Armbruster wrote:
> I get this on Fedora 32:
>
> [12/8327] Generating trace-dtrace-hw_virtio.h with a custom command
> Warning: /usr/bin/dtrace:trace/trace-dtrace-hw_virtio.dtrace:76: syntax error
> near:
> probe vhost_vdpa_dev_start
A warning at 12/8327 is unlikely to
** Description changed:
As a rookie, I don’t know if I should ask this question here. If it’s
not right, I hope people who see it can help submit it to the right
- place. Qemu-kvm can add wireless network card bridging, after all, now
+ place.Can Qemu or kvm add wireless network card bridging?
On Sun, Nov 08, 2020 at 09:45:31PM +0100, Philippe Mathieu-Daudé wrote:
> Install the lttng-ust-devel package to be able to
> build QEMU using the User-Space Tracer trace backend
> (configure --enable-trace-backends=ust).
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Cc: Stefan Hajnoczi
> Cc
On Sun, Nov 08, 2020 at 09:45:30PM +0100, Philippe Mathieu-Daudé wrote:
> Similarly to commit 8cdb2cef3f1, move the coroutine tests to GitLab.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Cc: Stefan Hajnoczi
> Cc: Kevin Wolf
> ---
> .gitlab-ci.yml | 16
> .travis.yml|
Hello,
I'm running x86 Ubuntu VM with GlusterFS-backed /, e.g.
qemu-system-x86_64 -enable-kvm -smp 8 -m 4096 -drive \
file=gluster://192.168.1.xxx/test/bionic.qcow2,if=virtio
and the following Fio (https://github.com/axboe/fio) benchmark inside a VM:
[global]
name=fio-rand-write-libaio
filenam
It is pointless to build/link these stubs into user-mode binaries.
Philippe Mathieu-Daudé (3):
accel: Only include TCG stubs in user-mode only builds
accel/stubs: Restrict system-mode emulation stubs
accel/stubs: Simplify kvm-stub.c
accel/stubs/kvm-stub.c | 5 -
accel/meson.build
We only require TCG stubs in user-mode emulation.
Do not build stubs restricted to system-mode emulation
in a user-mode only build.
Signed-off-by: Philippe Mathieu-Daudé
---
accel/meson.build | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/accel/meson.build b/accel
This system-mode emulation stubs are not require
in user-mode binaries. Restrict them to system-mode
binaries.
Signed-off-by: Philippe Mathieu-Daudé
---
accel/stubs/meson.build | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/accel/stubs/meson.build b/accel/stubs/
Now than kvm-stub.c is only built on system-mode emulation,
we can simplify its #ifdef'ry.
Signed-off-by: Philippe Mathieu-Daudé
---
accel/stubs/kvm-stub.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/accel/stubs/kvm-stub.c b/accel/stubs/kvm-stub.c
index 680e0994637..68fdfce50ed 10064
On 08/11/2020 23.19, Philippe Mathieu-Daudé wrote:
> This cache rule is meant for Avocado artifacts, but affects
> all jobs. Moreover the 'acceptance_template' template already
> include a more detailled rule to cache artifacts.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .gitlab-ci.yml |
On 08/11/2020 23.19, Philippe Mathieu-Daudé wrote:
> Extract the common definitions shared by '.cross_system_build_job'
> and '.cross_user_build_job' to '.cross_common_job'.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .gitlab-ci.d/crossbuilds.yml | 9 +
> 1 file changed, 5 insertio
On Sun, Nov 08, 2020 at 09:45:32PM +0100, Philippe Mathieu-Daudé wrote:
> Similarly to commit 8cdb2cef3f1, move the trace backend
> tests to GitLab.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Cc: Stefan Hajnoczi
> ---
> .gitlab-ci.yml | 18 ++
> .travis.yml| 19 --
On 30.10.20 04:35, shiliyang wrote:
There have some code style problems be found when read the block driver code.
So I fixes some problems of this error, ERROR: "foo* bar" should be "foo *bar".
Signed-off-by: Liyang Shi
Reported-by: Euler Robot
---
block/blkdebug.c | 2 +-
block/dmg.c
On Sat, Nov 07, 2020 at 12:13:03PM +0100, Philippe Mathieu-Daudé wrote:
> The TYPE_XHCI model is abstract and can not be used as it.
> It is meant to be overloaded by children classes. Restore
> it as abstract type.
Breaks "make check".
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 +
On 11/9/20 10:45 AM, Philippe Mathieu-Daudé wrote:
> We only require TCG stubs in user-mode emulation.
> Do not build stubs restricted to system-mode emulation
> in a user-mode only build.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> accel/meson.build | 10 ++
> 1 file changed, 6 in
06.11.2020 15:42, Andrey Shinkevich wrote:
QMP and HMP monitors read one byte at a time from the socket or stdin,
which is very inefficient. With 100+ VMs on the host, this results in
multiple extra system calls and CPU overuse.
This patch increases the amount of read data up to 4096 bytes that f
On 11/9/20 10:45 AM, Philippe Mathieu-Daudé wrote:
> This system-mode emulation stubs are not require
nit: s,require,required,
> in user-mode binaries. Restrict them to system-mode
> binaries.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> accel/stubs/meson.build | 12
> 1 file
On 08/11/2020 23.19, Philippe Mathieu-Daudé wrote:
> Add rules to select some crossbuild jobs.
>
> The following tags are available to restrict the CI jobs:
> - all(select all jobs, this is default)
> - cross (select all cross-jobs)
> - system (select all cross-system jobs)
> - user (select
On 2020/11/9 15:57, Markus Armbruster wrote:
> Thomas Huth writes:
>
>> On 06/11/2020 15.18, Philippe Mathieu-Daudé wrote:
>>> On 11/6/20 7:33 AM, Markus Armbruster wrote:
Thomas Huth writes:
> On 05/11/2020 06.14, AlexChen wrote:
>> On 2020/11/4 18:44, Thomas Huth wrote:
>
On 08/11/2020 23.19, Philippe Mathieu-Daudé wrote:
> Build jobs include the 'native_build_job' template. Move
> the 'artifacts expiry' rule there. Now all build jobs benefit
> from it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .gitlab-ci.yml | 24
> 1 file change
* Vivek Goyal (vgo...@redhat.com) wrote:
> On Fri, Nov 06, 2020 at 08:33:50PM +, Venegas Munoz, Jose Carlos wrote:
> > Hi Vivek,
> >
> > I have tested with Kata 1.12-apha0, the results seems that are better for
> > the use fio config I am tracking.
> >
> > The fio config does randrw:
> >
On 06/11/2020 08.35, Mark Cave-Ayland wrote:
> On 05/11/2020 05:31, Thomas Huth wrote:
>
>>> (goes and looks)
>>>
>>> Ah okay it appears to be because the object property link to the PIC is
>>> missing, which is to be expected as it is only present on the Mac machines.
>>>
>>> With the latest roun
09.11.2020 11:50, Vladimir Sementsov-Ogievskiy wrote:
06.11.2020 15:42, Andrey Shinkevich wrote:
The subject was discussed here:
https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg00206.html
This series is a solution for the issue with QMP monitor buffered input.
A little parser is introd
On 08/11/2020 21.45, Philippe Mathieu-Daudé wrote:
> Do not let the gitlab-pipeline-status script unmaintained,
> add it to the 'GitLab Continuous Integration' section.
>
> Fixes: c02b2eac55e ("GitLab Gating CI: introduce pipeline-status contrib
> script")
> Signed-off-by: Philippe Mathieu-Daudé
On Sun, Nov 08, 2020 at 11:58:28AM +, Peter Maydell wrote:
> On Sun, 8 Nov 2020 at 09:01, Thomas Huth wrote:
> > I agree with Daniel. Please let's not clog the new bug tracker right from
> > the start with hundreds of bugs - that only makes it harder to focus on the
> > tickets that are really
* Vivek Goyal (vgo...@redhat.com) wrote:
> Right now we create a thread pool and main thread hands over the request
> to thread in thread pool to process. Number of threads in thread pool
> can be managed by option --thread-pool-size.
>
> There is a chance that in case of some workloads, we might
On Mon, 9 Nov 2020 at 10:11, Daniel P. Berrangé wrote:
>
> On Sun, Nov 08, 2020 at 11:58:28AM +, Peter Maydell wrote:
> > On Sun, 8 Nov 2020 at 09:01, Thomas Huth wrote:
> > > I agree with Daniel. Please let's not clog the new bug tracker right from
> > > the start with hundreds of bugs - tha
On 08/11/2020 21.45, Philippe Mathieu-Daudé wrote:
> Add these missing options to the 'build-disabled' job:
> --disable-auth-pam (commit 8953caf3cd38)
> --disable-gcrypt (commit 91bfcdb01d48)
> --disable-keyring (commit 54e7aac05624)
> --disable-libude
On Sun, Nov 08, 2020 at 12:21:33PM +, Harshavardhan Unnibhavi wrote:
> Thank you for the reply! Yes, I understand that gsoc is over for 2020,
> and projects for 2021 will come up next year. I was thinking of
> contributing outside of gsoc(for which I won't be eligible anyways for
> next year).
On Fri, Nov 06, 2020 at 08:04:09PM +0100, Philippe Mathieu-Daudé wrote:
> Check vhost-user is available to build vhost-user-blk-server to fix:
I sent a different patch to address this. The vhost-user-blk server does
not depend on CONFIG_VHOST_USER, just CONFIG_LINUX.
Stefan
signature.asc
Descri
On 08/11/2020 21.45, Philippe Mathieu-Daudé wrote:
> Similarly to commit 8cdb2cef3f1, move the job testing the
> '--without-default-devices' configure option to GitLab.
>
> Since building all softmmu targets takes too long, split
> the job in 2.
>
> As smoke test, run the qtests on the AVR and m6
According to the PowerISA v3.1 reference, Table 68 "Actions for xscmpudp
- Part 1: Compare Unordered", whenever one of the two operands is a NaN
the SO bit is set while the other three bits are cleared.
Apply the same change to xscmpuqp.
The respective ordered counterparts are unaffected.
Signed
On Mon, Nov 09, 2020 at 09:48:54AM +0100, Markus Armbruster wrote:
> I get this on Fedora 32:
>
> [12/8327] Generating trace-dtrace-hw_virtio.h with a custom command
> Warning: /usr/bin/dtrace:trace/trace-dtrace-hw_virtio.dtrace:76: syntax error
> near:
> probe vhost_vdpa_dev_start
>
> Warning:
On Wed, 4 Nov 2020 12:25:09 -0500
Eduardo Habkost wrote:
> All field property getters and setters must interpret the fourth
> argument as Property*. Change the function signature of field
> property getters and setters to indicate that.
>
> Signed-off-by: Eduardo Habkost
> ---
> Cc: Stefan Be
Hi Fangying,
A trivial thing. This patch looks bit of a noise in this patch-set. Better
to send it as a separate patch-set and get it accepted.
Thanks
> From: fangying
> Sent: Monday, November 9, 2020 3:05 AM
> To: peter.mayd...@linaro.org
> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; drjo...
On Wed, 4 Nov 2020 12:25:11 -0500
Eduardo Habkost wrote:
> Introduce a FIELD_PTR macro that will ensure the size of the area
> we are accessing has the correct size, and will return a pointer
> of the correct type.
>
> Signed-off-by: Eduardo Habkost
> ---
> Cc: Stefan Berger
> Cc: Stefano Sta
On 09/11/20 10:55, Claudio Fontana wrote:
Ciao Philippe,
I thought that the pattern used by Paolo was, recurse always, and put
the check inside the recursed dir meson.build . Paolo did you indeed
intend meson use this way?
Generally yeah, I preferred to recurse always. In this specific case,
On 09/11/20 10:45, Philippe Mathieu-Daudé wrote:
It is pointless to build/link these stubs into user-mode binaries.
Philippe Mathieu-Daudé (3):
accel: Only include TCG stubs in user-mode only builds
accel/stubs: Restrict system-mode emulation stubs
accel/stubs: Simplify kvm-stub.c
ac
On 04/11/2020 17.46, Fotis Xenakis wrote:
> This post briefly goes over the main points of virtio-fs and OSv, a
> unikernel running under QEMU/KVM and taking advantage of its virtio-fs
> implementation.
>
> Changes since v1:
> - Fixed wording and links, as suggested by Thomas Huth.
> - Added a sho
Hi Fangying,
Same here. Why not club [01/13] and [02/13] together and send it separately?
Thanks
> From: fangying
> Sent: Monday, November 9, 2020 3:05 AM
> To: peter.mayd...@linaro.org
> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; drjo...@redhat.com;
> imamm...@redhat.com; shannon.zha...@gma
Fix:
commit 7bd04a041addcdef6a03e6498aafaea55ca6e88b
Author: Stefan Hajnoczi
Date: Thu Sep 17 10:44:54 2020 +0100
virtio-blk: undo destructive iov_discard_*() operations
** Changed in: qemu
Status: In Progress => Fix Committed
--
You received this bug notification because you are
Three points stand out:
1. The alignment code is buggy, as mentioned in comment 15.
2. The iov_discard_undo() API has been added to "qemu/iov.h" to undo the
effect of iov_discard_front/back_undoable() calls before unmapping. You
can use this API to restore the originally mapped iovecs.
3. The de
Cc'ing Thomas who wrote the test.
On 11/9/20 10:51 AM, Gerd Hoffmann wrote:
> On Sat, Nov 07, 2020 at 12:13:03PM +0100, Philippe Mathieu-Daudé wrote:
>> The TYPE_XHCI model is abstract and can not be used as it.
>> It is meant to be overloaded by children classes. Restore
>> it as abstract type.
> From: fangying
> Sent: Monday, November 9, 2020 3:05 AM
> To: peter.mayd...@linaro.org
> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; drjo...@redhat.com;
> imamm...@redhat.com; shannon.zha...@gmail.com; alistair.fran...@wdc.com;
> Zhanghailiang ; Salil Mehta
>
> Subject: [RFC PATCH v3 03/13]
On 11/9/20 11:20 AM, Thomas Huth wrote:
> On 08/11/2020 21.45, Philippe Mathieu-Daudé wrote:
>> Similarly to commit 8cdb2cef3f1, move the job testing the
>> '--without-default-devices' configure option to GitLab.
>>
>> Since building all softmmu targets takes too long, split
>> the job in 2.
>>
>>
On 11/9/20 11:25 AM, Daniel P. Berrangé wrote:
> On Mon, Nov 09, 2020 at 09:48:54AM +0100, Markus Armbruster wrote:
>> I get this on Fedora 32:
>>
>> [12/8327] Generating trace-dtrace-hw_virtio.h with a custom command
>> Warning: /usr/bin/dtrace:trace/trace-dtrace-hw_virtio.dtrace:76: syntax
>> er
On Fri, 6 Nov 2020 at 18:12, Pavel Pisa wrote:
>
> Hello Peter,
>
> this one is a little problematic. I understand that you want
> to have clean code and no warnings reports from coverity.
>
> On Friday 06 of November 2020 18:11:51 Peter Maydell wrote:
> > @@ -271,10 +266,7 @@ static void ctucan_
On Sat, Nov 07, 2020 at 12:13:04PM +0100, Philippe Mathieu-Daudé wrote:
> Since commit 755fba11fbc and 8ddab8dd3d8 we can not build
> USB_XHCI_NEC without USB_XHCI_PCI. Correct the Kconfig
> dependency.
Fails make check too:
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST
04.11.2020 20:19, Max Reitz wrote:
On 22.10.20 22:35, Vladimir Sementsov-Ogievskiy wrote:
22.07.2020 15:22, Max Reitz wrote:
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
Add new parameters to configure future backup features. The patch
doesn't introduce aio backup requests (so we act
On Thu, 5 Nov 2020 17:18:58 -0500
Daniele Buono wrote:
> There are void * pointers that get casted to enums, in cpu_models.c
> Such casts can result in a small integer type and are caught as
> warnings with clang, starting with version 11:
>
> Clang 11 finds a bunch of spots in the code that tr
On Thu, 5 Nov 2020 17:19:00 -0500
Daniele Buono wrote:
> S390IPLState contains two IplParameterBlock, which may in turn have
> either a IPLBlockPV or a IplBlockFcp, both ending with a variable
> sized field (an array).
>
> This causes a warning with clang 11 or greater, which checks that
> vari
On 09/11/2020 12.04, Philippe Mathieu-Daudé wrote:
> On 11/9/20 11:20 AM, Thomas Huth wrote:
>> On 08/11/2020 21.45, Philippe Mathieu-Daudé wrote:
>>> Similarly to commit 8cdb2cef3f1, move the job testing the
>>> '--without-default-devices' configure option to GitLab.
>>>
>>> Since building all sof
available in the Git repository at:
>
> https://gitlab.com/philmd/qemu.git tags/mips-fixes-20201109
>
> for you to fetch changes up to bf4ee88ab63fcf2dcb75f0d68cc6c8d2edb68212:
>
> hw/mips/boston: Fix memory leak in boston_fdt_filter() e
v1 -> v2:
- Update meson build with the CONFIG_VIRTIO_BLK case
- Add "Reviewed-by: Alexander Bulekov" for both patches
Based on the current virtio-scsi-fuzz target implement new virtio-blk
fuzz target. Use a virtio_blk_test.c file as a reference for the block
device initialization.
Also make
After meson and some other build changes the qemu fuzz target should be
build as:
make qemu-fuzz-i386
And also update the run path command line.
Signed-off-by: Dima Stepanov
Reviewed-by: Alexander Bulekov
---
docs/devel/fuzzing.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
The virtio-blk fuzz target sets up and fuzzes the available virtio-blk
queues. The implementation is based on two files:
- tests/qtest/fuzz/virtio_scsi_fuzz.c
- tests/qtest/virtio_blk_test.c
Signed-off-by: Dima Stepanov
Reviewed-by: Alexander Bulekov
---
tests/qtest/fuzz/meson.build |
On 05/11/2020 16.03, AlexChen wrote:
> The 'addr' would not be NULL after checking 'succ' is valid,
> and it has been dereferenced in the previous code(args = g_strdup_printf()).
> So the check on 'addr' in the tpm_test_swtpm_test() is redundant. Remove it.
>
> Reported-by: Euler Robot
> Signed-o
1 - 100 of 398 matches
Mail list logo