Re: Qemu first time contribution

2020-11-08 Thread Thomas Huth
On 07/11/2020 20.18, Harshavardhan Unnibhavi wrote: > Hi, > > I am looking to contribute code to QEMU, a software I have enjoyed > using for my own projects. I want to contribute to developing a > specific component in the project. I was looking for possible project > ideas and came across this pa

Re: [PATCH] macio: set user_creatable to false in macio_class_init()

2020-11-08 Thread Thomas Huth
On 07/11/2020 12.28, Mark Cave-Ayland wrote: > Commit 348b8d1a76 "macio: don't reference serial_hd() directly within the > device" > removed the setting of user_creatable to false on the basis that the > restriction > was due to the use of serial_hd() in macio_instance_init(). > > Unfortunately

Re: Migrating to the gitlab issue tracker

2020-11-08 Thread Thomas Huth
On 30/10/2020 13.53, John Snow wrote: > On 10/30/20 6:26 AM, Alex Bennée wrote: >> Can we extract data as a CSV from Launchpad? > > Not sure, I don't have maintainer access there. Thomas? I've never seen such an option. But (as you've already discovered) there is an API for Launchpad which can be

Re: Migrating to the gitlab issue tracker

2020-11-08 Thread Thomas Huth
On 05/11/2020 16.50, Daniel P. Berrangé wrote: > On Thu, Nov 05, 2020 at 10:44:42AM -0500, John Snow wrote: >> On 11/5/20 1:14 AM, Thomas Huth wrote: >>> On 05/11/2020 01.06, John Snow wrote: On 10/30/20 6:57 AM, Peter Maydell wrote: > On Fri, 30 Oct 2020 at 10:10, Daniel P. Berrangé >>>

[Bug 1649236] Re: Commit snapshot fails with Permission denied when daemonized

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1652459] Re: kvm rbd driver (and maybe others, i.e. qcow2, qed and so on) does not report DISCARD-ZERO flag

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1649233] Re: scrolling does not work once mouse is grabbed

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1652373] Re: User-mode QEMU is not deterministic

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1648726] Re: [usb-host] Passthrough of UAS devices fails with Windows (10) guests

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1661758] Re: qemu-nbd causes data corruption in VDI-format disk images

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1668041] Re: x86 Floating point exceptions - incorrect support?

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1670175] Re: qemu-system-sparc64 with tribblix-sparc-0m16.iso ends with "panic - kernel: no nucleus hblk8 to allocate"

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1653419] Re: SVM emulation fails due to EIP and FLAG register update optimization

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1658141] Re: QEMU's default msrs handling causes Windows 10 64 bit to crash

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1663287] Re: Illegal delay slot code causes abort on mips64

2020-11-08 Thread Thomas Huth
** Changed in: qemu Assignee: (unassigned) => Philippe Mathieu-Daudé (philmd) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1663287 Title: Illegal delay slot code causes abort on mips64 Statu

[Bug 1656711] Re: GTK3 interface doesn't zoom-to-fit by default

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1671173] Re: OS started to crash with a message: "Trying to execute code outside RAM or ROM"

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1662600] Re: error while building from source on Ubuntu 16.04

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1671677] Re: vfio-pci passthrough issue after resume from suspend

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1654826] Re: Holding key down using input-linux freezes guest

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1665789] Re: More resolutions for vga displays

2020-11-08 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1665789 Title: More resolutions for vga displays Status in QEMU: New Bug description: Wo

[Bug 1673722] Re: Reading register at offset. It is not fully implemented warning make VM impossible to use

2020-11-08 Thread Thomas Huth
I think this has been fixed by: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=b4053c64833 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/16737

[Bug 1673957] Re: virtfs: mapped-xattr on mount point

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1630723] Re: UART writes to netduino2/stm32f205-soc disappear

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1634069] Re: Exclude keys from grab

2020-11-08 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1634069 Title: Exclude keys from grab Status in QEMU: New Bug description: Feature reque

[Bug 1640073] Re: Guest pause because VMPTRLD failed in KVM

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1639791] Re: early virtio console output is lost

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1639983] Re: e1000 EEPROM have bad checksum

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1636770] Re: mouse wheel works only with -usbdevice tablet

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1642011] Re: Mouse wheel events not forwarded to guest using GTK display

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1642421] Re: qemu-system-x86_64: ipv6 and dns is broken with netdev user

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1644754] Re: gluster partial reads refusal conflicts with qcow2

2020-11-08 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting all older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1647683] Re: Bad interaction between tb flushing & gdb stub

2020-11-08 Thread Thomas Huth
Fix had been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=a9353fe897ca2687e5b338 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs

[Bug 1895080] Re: pgb_reserved_va: Assertion `addr == test' failed

2020-11-08 Thread Thomas Huth
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=fb730c8683807d549c4a ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895080 Title: pgb_reserv

[Bug 1816819] Re: Chardev websocket stops listening after first connection disconnects

2020-11-08 Thread Thomas Huth
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=dd154c4d9f48a44ad24e1 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1816819 Title: Chardev we

[Bug 1896263] Re: The bios-tables-test test causes QEMU to crash (Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed) on AMD processors

2020-11-08 Thread Thomas Huth
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=d1e2d46467b95b03279 ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896263 Title: The bios-ta

Re: [PATCH v10 1/1] audio/jack: fix use after free segfault

2020-11-08 Thread Christian Schoenebeck
On Sonntag, 8. November 2020 07:33:50 CET Geoffrey McRae wrote: > This change registers a bottom handler to close the JACK client > connection when a server shutdown signal is received. Without this > libjack2 attempts to "clean up" old clients and causes a use after free > segfault. > > Signed-of

[Bug 1673957] Re: virtfs: mapped-xattr on mount point

2020-11-08 Thread Christian Schoenebeck
Independent of the planned tracker transition: this issue would require more information by original reporter anyway. >From the information provided so far, I cannot reproduce this problem, and the error messages don't look like common misconfigurations on host side like wrong permissions, AppArmo

Re: Migrating to the gitlab issue tracker

2020-11-08 Thread Peter Maydell
On Sun, 8 Nov 2020 at 09:01, Thomas Huth wrote: > I agree with Daniel. Please let's not clog the new bug tracker right from > the start with hundreds of bugs - that only makes it harder to focus on the > tickets that are really important. Let's use the migration instead to start > as clean as poss

Re: Qemu first time contribution

2020-11-08 Thread Harshavardhan Unnibhavi
Hi, Thank you for the reply! Yes, I understand that gsoc is over for 2020, and projects for 2021 will come up next year. I was thinking of contributing outside of gsoc(for which I won't be eligible anyways for next year). Anyway, I will work on some of the bite sized tasks, and get back to you for

RE: [PATCH-for-5.2 2/5] hw/usb/Kconfig: Fix USB_XHCI_NEC (depends on USB_XHCI_PCI)

2020-11-08 Thread Sai Pavan Boddu
Thanks, good fix. Reviewed-by: Sai Pavan Boddu Regards, Sai Pavan > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Saturday, November 7, 2020 4:43 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann ; Sai Pavan Boddu > ; Philippe Mathieu-Daudé > Subject: [PATCH-for-5.2 2/5] h

RE: [PATCH-for-5.2 1/5] hw/usb/hcd-xhci: Make xhci base model abstract

2020-11-08 Thread Sai Pavan Boddu
Looks good. Reviewed-by: Sai Pavan Boddu Thanks, Sai Pavan > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Saturday, November 7, 2020 4:43 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann ; Sai Pavan Boddu > ; Philippe Mathieu-Daudé ; > Miroslav Rezanina > Subject: [PATCH

Re: [PATCH v2 00/44] Make qdev static property API usable by any QOM type

2020-11-08 Thread Paolo Bonzini
On 06/11/20 22:10, Eduardo Habkost wrote: This was implemented at: https://gitlab.com/ehabkost/qemu/-/commits/work/qdev-make-generic This is the interface I'd like to submit as v3: static Property machine_props[] = { DEFINE_PROP_STRING("kernel", MachineState, kernel_filename,

[Bug 1630723] Re: UART writes to netduino2/stm32f205-soc disappear

2020-11-08 Thread Philippe Mathieu-Daudé
Example program tested successfully on commit 3493c36f037. Eventually fixed by fc38a1120c2 ("Remove checks on MAX_SERIAL_PORTS that are just bounds checks"). ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- de

Re: [PATCH v4 4/7] coroutine: add libucontext as external library

2020-11-08 Thread Philippe Mathieu-Daudé
Hi Joelle, On 11/8/20 6:26 AM, Joelle van Dyne wrote: > iOS does not support ucontext natively for aarch64 and the sigaltstack is > also unsupported (even worse, it fails silently, see: > https://openradar.appspot.com/13002712 ) > > As a workaround we include a library implementation of ucontext

mmap2 is probably still broken in linux-user & other things

2020-11-08 Thread Catherine A. Frederick
Hi, I submitted a patch a while ago and then dropped off the face of the planet like most people do. In my journey to fix DRM/radeonsi in user-mode emulation I discovered a few bugs. I don't really have the time to write the infrastructure to make wrapping DRM IOCTLs remotely not-ugly, but I do

Re: [PATCH] meson: always include contrib/libvhost-user

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/6/20 10:03 PM, Stefan Hajnoczi wrote: > libvhost-user is needed when CONFIG_LINUX is set. The CONFIG_VHOST_USER > check in meson.build is incorrect. > > In fact, no explicit check is needed since this dependency is not built > by default. If something declares a dependency on libvhost-user t

[PATCH for-5.2] qga: fix missing closedir() in qmp_guest_get_disks()

2020-11-08 Thread Michael Roth
We opendir("/sys/block") at the beginning of the function, but we never close it prior to returning. Fixes: Coverity CID 1436130 Fixes: fed3956429d5 ("qga: add implementation of guest-get-disks for Linux") Reported-by: Peter Maydell Cc: Marc-André Lureau Cc: Tomáš Golembiovský Signed-off-by: Mi

[PATCH] ui/gtk: Fix guest absolute pointer position under Wayland

2020-11-08 Thread Andrei Borzenkov
Ubuntu 20.04, GNOME Wayland desktop, QEMU 5.1.0 compiled from sources. Absolute tablet/vmmouse location in guest window does not match cursor - coordinates reported to guest are smaller than visible mouse cursor location. Adding debug print to ui/gtk.c:gd_motion_event() to print surface and windo

Re: [PULL v3 05/12] qga: add command guest-get-disks

2020-11-08 Thread Michael Roth
Quoting Eric Blake (2020-11-04 15:56:17) > [Adding Markus in CC] > > On 11/2/20 8:43 PM, Michael Roth wrote: > > From: Tomá\u0161 Golembiovský > > > > Add API and stubs for new guest-get-disks command. > > > > The command guest-get-fsinfo can be used to list information about disks > > and part

Re: mmap2 is probably still broken in linux-user & other things

2020-11-08 Thread Philippe Mathieu-Daudé
Cc'ing user-mode team. On 11/8/20 4:53 PM, Catherine A. Frederick wrote: > Hi, I submitted a patch a while ago and then dropped off the face of the > planet like most people do. In my journey to fix DRM/radeonsi in > user-mode emulation I discovered a few bugs. I don't really have the > time to wr

Re: [PATCH for-5.2] qga: fix missing closedir() in qmp_guest_get_disks()

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/8/20 5:11 PM, Michael Roth wrote: > We opendir("/sys/block") at the beginning of the function, but we never > close it prior to returning. > > Fixes: Coverity CID 1436130 > Fixes: fed3956429d5 ("qga: add implementation of guest-get-disks for Linux") > Reported-by: Peter Maydell > Cc: Marc-A

Re: [PATCH-for-5.2 v2] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/8/20 4:58 AM, Ani Sinha wrote: > On Sun, Nov 8, 2020 at 1:10 AM Philippe Mathieu-Daudé > wrote: >> >> GCC 9.3.0 thinks that 'method' can be left uninitialized. This code >> is already in the "if (bsel || pcihp_bridge_en)" block statement, >> but it isn't smart enough to figure it out. >> >>

[PATCH] scripts/oss-fuzz: give all fuzzers -target names

2020-11-08 Thread Alexander Bulekov
We switched to hardlinks in a942f64cc4 ("scripts/oss-fuzz: use hardlinks instead of copying") The motivation was to conserve space (50 fuzzers built with ASAN, can weigh close to 9 GB). Unfortunately, OSS-Fuzz (partially) treated the underlying copy of the fuzzer as a standalone fuzzer. To attemp

Re: --enable-xen on gitlab CI? (was Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg)

2020-11-08 Thread Philippe Mathieu-Daudé
On 10/31/20 11:25 AM, Thomas Huth wrote: > On 30/10/2020 18.13, Paolo Bonzini wrote: >> On 30/10/20 12:35, Eduardo Habkost wrote: >>> >>> What is necessary to make sure we have a CONFIG_XEN=y job in >>> gitlab CI? Maybe just including xen-devel in some of the >>> container images is enough? >> >>

[Bug 1652459] Re: kvm rbd driver (and maybe others, i.e. qcow2, qed and so on) does not report DISCARD-ZERO flag

2020-11-08 Thread Коренберг Марк
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1652459 Title: kvm rbd driver (and maybe others, i.e. qcow2, qed and so on) does not report DIS

[PATCH-for-5.2 v4 01/17] configure: Check vhost-user is available to build vhost-user-blk-server

2020-11-08 Thread Philippe Mathieu-Daudé
Check vhost-user is available to build vhost-user-blk-server to fix: $ ../configure \ --disable-vhost-user --enable-vhost-user-blk-server && \ make qemu-nbd ... [505/505] Linking target qemu-nbd FAILED: qemu-nbd cc -o qemu-nbd qemu-nbd.p/qemu-nbd.c.o -Wl,--as-needed -Wl,--no-undefin

[PATCH-for-6.0 v4 04/17] MAINTAINERS: Add gitlab-pipeline-status script to GitLab CI section

2020-11-08 Thread Philippe Mathieu-Daudé
Do not let the gitlab-pipeline-status script unmaintained, add it to the 'GitLab Continuous Integration' section. Fixes: c02b2eac55e ("GitLab Gating CI: introduce pipeline-status contrib script") Signed-off-by: Philippe Mathieu-Daudé --- Cc: Cleber Rosa --- MAINTAINERS | 1 + 1 file changed, 1

[PATCH-for-6.0 v4 05/17] gitlab-ci: Split CONFIGURE_ARGS one argument per line for build-disabled

2020-11-08 Thread Philippe Mathieu-Daudé
We will keep adding/removing options to our 'configure' script, so for easier maintainability it makes sense to have CONFIGURE_ARGS declared as one option per line. This way we can review diff easily (or rebase/cherry-pick). No logical change. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Daniel

[PATCH-for-5.2 v4 00/17] ci: Move various jobs from Travis to GitLab CI

2020-11-08 Thread Philippe Mathieu-Daudé
We have various job covered on Travis-CI, but recommend the community to use GitLab, so build failures are missed. We need help to move the jobs to GitLab (we will keep the s390x and ppc64 containerized jobs on Travis as there is no similar offer on GitLab). Start moving jobs. Resulting pipelines

[PATCH-for-6.0 v4 06/17] gitlab-ci: Update 'build-disabled' to cover all configurable options

2020-11-08 Thread Philippe Mathieu-Daudé
Add these missing options to the 'build-disabled' job: --disable-auth-pam (commit 8953caf3cd38) --disable-gcrypt (commit 91bfcdb01d48) --disable-keyring (commit 54e7aac05624) --disable-libudev (commit 5c53015a480b) --disable-opengl

[PATCH-for-5.2 v4 02/17] meson: always include contrib/libvhost-user

2020-11-08 Thread Philippe Mathieu-Daudé
From: Stefan Hajnoczi libvhost-user is needed when CONFIG_LINUX is set. The CONFIG_VHOST_USER check in meson.build is incorrect. In fact, no explicit check is needed since this dependency is not built by default. If something declares a dependency on libvhost-user then it will be built, otherwis

[PATCH-for-6.0 v4 12/17] gitlab-ci: Move coroutine tests across to gitlab

2020-11-08 Thread Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the coroutine tests to GitLab. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Stefan Hajnoczi Cc: Kevin Wolf --- .gitlab-ci.yml | 16 .travis.yml| 14 -- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/.gitl

[PATCH-for-6.0 v4 07/17] gitlab-ci: Move job testing --without-default-devices across to gitlab

2020-11-08 Thread Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the job testing the '--without-default-devices' configure option to GitLab. Since building all softmmu targets takes too long, split the job in 2. As smoke test, run the qtests on the AVR and m68k targets. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Paolo

[PATCH-for-5.2 v4 03/17] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off

2020-11-08 Thread Philippe Mathieu-Daudé
GCC 9.3.0 thinks that 'method' can be left uninitialized. This code is already in the "if (bsel || pcihp_bridge_en)" block statement, but it isn't smart enough to figure it out. Restrict the code to be used only in the "if (bsel || pcihp_bridge_en)" block statement to fix (on Ubuntu): ../hw/i38

[PATCH-for-6.0 v4 08/17] gitlab-ci: Move linux-user debug-tcg test across to gitlab

2020-11-08 Thread Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the linux-user (debug-tcg) test to GitLab. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Laurent Vivier --- .gitlab-ci.yml | 7 +++ .travis.yml| 9 - 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.

[PATCH-for-6.0 v4 15/17] gitlab-ci: Add test for Xen (on CentOS 7)

2020-11-08 Thread Philippe Mathieu-Daudé
Xen packages are available in CentOS 7, but have been removed from CentOS 8. Use the CentOS 7 container. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Eduardo Habkost Cc: Stefano Stabellini Cc: Anthony Perard Cc: Paul Durrant Cc: xen-de...@lists.xenproject.org --- .gitlab-ci.yml | 21 +++

[PATCH-for-6.0 v4 10/17] gitlab-ci: Move user-static test across to gitlab

2020-11-08 Thread Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the user-static test to GitLab. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Laurent Vivier --- .gitlab-ci.yml | 7 +++ .travis.yml| 5 - 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d1583

[PATCH-for-6.0 v4 11/17] gitlab-ci: Move tools-only and softfloat tests across to gitlab

2020-11-08 Thread Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the tools-only and softfloat test to GitLab (splitting it in 2 different jobs). Signed-off-by: Philippe Mathieu-Daudé --- Cc: Alex Bennée Cc: Emilio G. Cota --- .gitlab-ci.yml | 14 ++ .travis.yml| 9 - 2 files changed, 14 insertio

[PATCH-for-6.0 v4 09/17] gitlab-ci: Move gprof/gcov test across to gitlab

2020-11-08 Thread Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the gprof/gcov test to GitLab. The coverage-summary.sh script is not Travis-CI specific, make it generic. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 12 .travis.yml| 14

[PATCH-for-6.0 v4 16/17] gitlab-ci: Make some ARM 32-bit jobs optional

2020-11-08 Thread Philippe Mathieu-Daudé
The armel/armhf targets have a lot in common. Instead of testing both user/system emulation on each target, test each one once. Mark the other combination optional, so user can still run the tests manually. We now test system-mode emulation on armel target, and user-mode emulation to armhf target:

[PATCH-for-6.0 v4 13/17] tests/docker: Install lttng-ust-devel package in Fedora image

2020-11-08 Thread Philippe Mathieu-Daudé
Install the lttng-ust-devel package to be able to build QEMU using the User-Space Tracer trace backend (configure --enable-trace-backends=ust). Signed-off-by: Philippe Mathieu-Daudé --- Cc: Stefan Hajnoczi Cc: Daniel P . Berrange --- tests/docker/dockerfiles/fedora.docker | 1 + 1 file changed

[PATCH-for-6.0 v4 14/17] gitlab-ci: Move trace backend tests across to gitlab

2020-11-08 Thread Philippe Mathieu-Daudé
Similarly to commit 8cdb2cef3f1, move the trace backend tests to GitLab. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Stefan Hajnoczi --- .gitlab-ci.yml | 18 ++ .travis.yml| 19 --- 2 files changed, 18 insertions(+), 19 deletions(-) diff --git a/.gitlab-ci

[PATCH-for-6.0 v4 17/17] gitlab-ci: Make MIPS user-mode 32-bit little-endian job optional

2020-11-08 Thread Philippe Mathieu-Daudé
Keep the mips user-mode emulation by default on 32-bit big endian and 64-bit little endian targets, but make it optional on 32-bit little endian. User can still run the job manually. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Laurent Vivier --- .gitlab-ci.d/crossbuilds.yml | 3 +++ 1 file ch

Re: [PATCH-for-6.0 v4 16/17] gitlab-ci: Make some ARM 32-bit jobs optional

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/8/20 9:45 PM, Philippe Mathieu-Daudé wrote: > The armel/armhf targets have a lot in common. Instead of > testing both user/system emulation on each target, test > each one once. Mark the other combination optional, so > user can still run the tests manually. > > We now test system-mode emula

[PATCH v3 01/11] gitlab-ci: Drop generic cache rule

2020-11-08 Thread Philippe Mathieu-Daudé
This cache rule is meant for Avocado artifacts, but affects all jobs. Moreover the 'acceptance_template' template already include a more detailled rule to cache artifacts. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 6 -- 1 file changed, 6 deletions(-) diff --git a/.gitlab-ci

[PATCH v3 00/11] gitlab-ci: Allow forks to select & restrict build jobs

2020-11-08 Thread Philippe Mathieu-Daudé
Hi, 2 months ago GitLab added time limit to their free CI offer [1]. This series provide developers with the possibility to not run all jobs. By default all jobs are started, but we can restrict by selecting a subset of them. Since v2: - no more RFC - project-wide environment variable works - do

[PATCH v3 07/11] gitlab-ci: Extract common job definition as 'cross_common_job'

2020-11-08 Thread Philippe Mathieu-Daudé
Extract the common definitions shared by '.cross_system_build_job' and '.cross_user_build_job' to '.cross_common_job'. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/crossbuilds.yml | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.gitlab-ci.d/crossbuilds.yml

[PATCH v3 02/11] gitlab-ci: Replace YAML anchors by extends (cross_system_build_job)

2020-11-08 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/crossbuilds.yml | 40 ++-- 1 file changed, 20 insertions(+), 20 de

[PATCH v3 05/11] gitlab-ci: Replace YAML anchors by extends (acceptance_test_job)

2020-11-08 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/.gitlab-ci.y

[PATCH v3 03/11] gitlab-ci: Replace YAML anchors by extends (native_build_job)

2020-11-08 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff -

[PATCH v3 04/11] gitlab-ci: Replace YAML anchors by extends (native_test_job)

2020-11-08 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a

[PATCH v3 06/11] gitlab-ci: Rename acceptance_test_job -> integration_test_job

2020-11-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 0ef814764a0..d4526323169 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -42,7 +42,7 @@ include: - find .

[PATCH v3 08/11] gitlab-ci: Extract common job definition as 'native_common_job'

2020-11-08 Thread Philippe Mathieu-Daudé
Extract the common definitions shared by '.native_build_job' and '.native_test_job' to '.native_common_job'. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d4526323169..f7

[PATCH v3 10/11] gitlab-ci: Add rules to select building/testing native jobs

2020-11-08 Thread Philippe Mathieu-Daudé
Add rules to select various build/test jobs. The following tags are available to restrict CI jobs: - user(user-mode jobs) - system (system-mode jobs) - centos (jobs based on CentOS distribution image) - debian (... Debian) - fedora (... Fedora) - ubu

[PATCH v3 09/11] gitlab-ci: Add rules to select cross-jobs to build

2020-11-08 Thread Philippe Mathieu-Daudé
Add rules to select some crossbuild jobs. The following tags are available to restrict the CI jobs: - all(select all jobs, this is default) - cross (select all cross-jobs) - system (select all cross-system jobs) - user (select all cross-user jobs) - $ARCH (select an architecture: arm/mips/

[PATCH v3 11/11] gitlab-ci: Move artifacts expiry rule to common 'native_build_job'

2020-11-08 Thread Philippe Mathieu-Daudé
Build jobs include the 'native_build_job' template. Move the 'artifacts expiry' rule there. Now all build jobs benefit from it. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/.gitlab-ci.yml b/

Re: [PATCH v4 4/7] coroutine: add libucontext as external library

2020-11-08 Thread Joelle van Dyne
Thanks, it built on my 18.04 machine but it seems that newer versions of GCC had different behavior on the underscore assembly functions. I will fix it and test on 20.04. -j On Sun, Nov 8, 2020 at 7:46 AM Philippe Mathieu-Daudé wrote: > > Hi Joelle, > > On 11/8/20 6:26 AM, Joelle van Dyne wrote:

Re: [PATCH for-5.2] hw/mips/boston.c: Fix memory leak in boston_fdt_filter() error-handling paths

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/6/20 6:58 PM, Peter Maydell wrote: > Coverity points out that the error-handling paths in the > boston_fdt_filter() function don't free the fdt that was allocated. > Fix the leak by using g_autofree. > > Fixes: Coverity CID 1432275 > > Signed-off-by: Peter Maydell > --- > hw/mips/boston.c

Re: [PATCH V17 1/6] target/mips: Fix PageMask with variable page size

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/6/20 5:21 AM, Huacai Chen wrote: > From: Jiaxun Yang > > Our current code assumed the target page size is always 4k > when handling PageMask and VPN2, however, variable page size > was just added to mips target and that's no longer true. > > Fixes: ee3863b9d414 ("target/mips: Support varia

Re: [PATCH-for-5.2] target/mips: Deprecate nanoMIPS ISA

2020-11-08 Thread Philippe Mathieu-Daudé
On 11/2/20 9:27 PM, Philippe Mathieu-Daudé wrote: > The nanoMIPS ISA has been announced in 2018 for various projects: > > GCC: https://gcc.gnu.org/legacy-ml/gcc/2018-05/msg00012.html > Linux: https://lwn.net/Articles/753605/ > QEMU: https://www.mail-archive.com/qemu-devel@nongnu.org/msg530721.h

[PATCH v5 4/7] coroutine: add libucontext as external library

2020-11-08 Thread Joelle van Dyne
iOS does not support ucontext natively for aarch64 and the sigaltstack is also unsupported (even worse, it fails silently, see: https://openradar.appspot.com/13002712 ) As a workaround we include a library implementation of ucontext and add it as a build option. Signed-off-by: Joelle van Dyne --

[PATCH v5 1/7] configure: option to disable host block devices

2020-11-08 Thread Joelle van Dyne
Some hosts (iOS) have a sandboxed filesystem and do not provide low-level APIs for interfacing with host block devices. Signed-off-by: Joelle van Dyne --- configure| 4 meson.build | 1 + qapi/block-core.json | 10 +++--- block/file-posix.c | 10 +- 4 fi

[PATCH v5 0/7] iOS and Apple Silicon host support

2020-11-08 Thread Joelle van Dyne
Based-on: 20201106032921.600200-1-richard.hender...@linaro.org ([PATCH v3 00/41] Mirror map JIT memory for TCG) These set of changes brings QEMU TCG to iOS devices and future Apple Silicon devices. They were originally developed last year and have been working in the UTM app. Recently, we ported t

[PATCH v5 7/7] block: check availablity for preadv/pwritev on mac

2020-11-08 Thread Joelle van Dyne
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 12 1 f

[PATCH v5 2/7] configure: cross-compiling with empty cross_prefix

2020-11-08 Thread Joelle van Dyne
The iOS toolchain does not use the host prefix naming convention. So we need to enable cross-compile options while allowing the PREFIX to be blank. Signed-off-by: Joelle van Dyne --- configure | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 9

[PATCH v5 6/7] tcg: implement JIT for iOS and Apple Silicon

2020-11-08 Thread Joelle van Dyne
When entitlements are available (macOS or jailbroken iOS), a hardware feature called APRR exists on newer Apple Silicon that can cheaply mark JIT pages as either RX or RW. Reverse engineered functions from libsystem_pthread.dylib are implemented to handle this. The following rules apply for JIT wr

[Bug 1663287] Re: Illegal delay slot code causes abort on mips64

2020-11-08 Thread Philippe Mathieu-Daudé
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1663287 Title: Illegal delay slot code causes abort on mips64 Status in QEMU: Confirmed Bug des

[PATCH v5 3/7] qemu: add support for iOS host

2020-11-08 Thread Joelle van Dyne
This introduces support for building for iOS hosts. When the correct Xcode toolchain is used, iOS host will be detected automatically. * block: disable features not supported by iOS sandbox * slirp: disable SMB features for iOS * osdep: disable system() calls for iOS Signed-off-by: Joelle van Dyn

[PATCH v5 5/7] slirp: update build flags for iOS resolv fix

2020-11-08 Thread Joelle van Dyne
A future libslirp update will use libresolv on Darwin systems, so we add the flags in QEMU build now. Reviewed-by: Stefan Hajnoczi Signed-off-by: Joelle van Dyne --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index b087721f63..40dd3b30fc 100644 -

  1   2   >