[PATCH] quorum: Implement bdrv_co_block_status()

2020-11-04 Thread Alberto Garcia
The quorum driver does not implement bdrv_co_block_status() and because of that it always reports to contain data even if all its children are known to be empty. One consequence of this is that if we for example create a quorum with a size of 10GB and we mirror it to a new image the operation will

Re: [PATCH 0/5] SCSI: fix transfer limits for SCSI passthrough

2020-11-04 Thread Maxim Levitsky
On Wed, 2020-11-04 at 09:48 -0800, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20201104173217.417538-1-mlevi...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 2

Re: [PATCH RFC] memory: pause all vCPUs for the duration of memory transactions

2020-11-04 Thread Laszlo Ersek
On 11/03/20 17:37, Peter Xu wrote: > On Tue, Nov 03, 2020 at 02:07:09PM +0100, Vitaly Kuznetsov wrote: >> In case it is a normal access from the guest, yes, but AFAIR here >> guest's CR3 is pointing to non existent memory and when KVM detects that >> it injects #PF by itself without a loop through

Re: [PATCH] tcg: Revert "tcg/optimize: Flush data at labels not TCG_OPF_BB_END"

2020-11-04 Thread Peter Maydell
On Tue, 3 Nov 2020 at 21:38, Richard Henderson wrote: > > This reverts commit cd0372c515c4732d8bd3777cdd995c139c7ed7ea. > > The patch is incorrect in that it retains copies between globals and > non-local temps, and non-local temps still die at the end of the BB. Reviewed-by: Peter Maydell I as

RE: executing user code to test qemu driver

2020-11-04 Thread Shaked Matzner
Hey again, I also see that when I try open the device after insmod and mknnodev by: int device_fd = open("/dev/lkmc_pci",O_RDWR); fails due to permission issue, I tried to chmod it from the device but it does not work as well. What is the proper way to add access permission for the device from t

Re: [PATCH] tcg: Revert "tcg/optimize: Flush data at labels not TCG_OPF_BB_END"

2020-11-04 Thread Richard Henderson
On 11/4/20 10:12 AM, Peter Maydell wrote: > On Tue, 3 Nov 2020 at 21:38, Richard Henderson > wrote: >> >> This reverts commit cd0372c515c4732d8bd3777cdd995c139c7ed7ea. >> >> The patch is incorrect in that it retains copies between globals and >> non-local temps, and non-local temps still die at th

Re: [PATCH v11 19/19] multi-process: add configure and usage information

2020-11-04 Thread Philippe Mathieu-Daudé
Hi Jagannathan, On 10/15/20 8:05 PM, Jagannathan Raman wrote: > From: Elena Ufimtseva Documentation is scarce ;) > > Signed-off-by: Elena Ufimtseva > Signed-off-by: Jagannathan Raman > Signed-off-by: John G Johnson > Reviewed-by: Stefan Hajnoczi > --- > MAINTAINERS| 2 ++

[PULL v3 02/31] virtio-mem: Make sure "addr" is always multiples of the block size

2020-11-04 Thread Michael S. Tsirkin
From: David Hildenbrand The spec states: "The device MUST set addr, region_size, usable_region_size, plugged_size, requested_size to multiples of block_size." In some cases, we currently don't guarantee that for "addr": For example, when starting a VM with 4 GiB boot memory and a virtio-mem

[PULL v3 00/31] pc,pci,vhost,virtio: fixes

2020-11-04 Thread Michael S. Tsirkin
changes from v2: drop patches causing issues on BE The following changes since commit c7a7a877b716cf14848f1fd5c754d293e2f8d852: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20201102' into staging (2020-11-03 10:38:05 +) are available in the Git repository at:

[PULL v3 04/31] virtio-mem: Probe THP size to determine default block size

2020-11-04 Thread Michael S. Tsirkin
From: David Hildenbrand Let's allow a minimum block size of 1 MiB in all configurations. Select the default block size based on - The page size of the memory backend. - The THP size if the memory backend size corresponds to the real host page size. - The global minimum of 1 MiB. and warn if som

[PULL v3 01/31] pc: comment style fixup

2020-11-04 Thread Michael S. Tsirkin
Fix up checkpatch comment style warnings. Signed-off-by: Michael S. Tsirkin Reviewed-by: Chen Qun --- hw/i386/pc.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 5e6c0023e0..17b514d1da 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @

[PULL v3 03/31] virtio-mem: Make sure "usable_region_size" is always multiples of the block size

2020-11-04 Thread Michael S. Tsirkin
From: David Hildenbrand The spec states: "The device MUST set addr, region_size, usable_region_size, plugged_size, requested_size to multiples of block_size." With block sizes > 256MB, we currently wouldn't guarantee that for the usable_region_size. Note that we cannot exceed the region_si

[PULL v3 07/31] virito-mem: Implement get_min_alignment()

2020-11-04 Thread Michael S. Tsirkin
From: David Hildenbrand The block size determines the alignment requirements. Implement get_min_alignment() of the TYPE_MEMORY_DEVICE interface. This allows auto-assignment of a properly aligned address in guest physical address space. For example, when specifying a 2GB block size for a virtio-m

[PULL v3 08/31] hw/acpi : Don't use '#' flag of printf format

2020-11-04 Thread Michael S. Tsirkin
From: Xinhao Zhang Fix code style. Don't use '#' flag of printf format ('%#') in format strings, use '0x' prefix instead Signed-off-by: Xinhao Zhang Signed-off-by: Kai Deng Message-Id: <20201103102634.273021-1-zhangxinh...@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[PULL v3 15/31] virtio-iommu: Add memory notifiers for map/unmap

2020-11-04 Thread Michael S. Tsirkin
From: Bharat Bhushan Extend VIRTIO_IOMMU_T_MAP/UNMAP request to notify memory listeners. It will call VFIO notifier to map/unmap regions in the physical IOMMU. Signed-off-by: Bharat Bhushan Signed-off-by: Eric Auger Signed-off-by: Jean-Philippe Brucker Message-Id: <20201030180510.747225-4-jea

[PULL v3 13/31] virtio-iommu: Fix virtio_iommu_mr()

2020-11-04 Thread Michael S. Tsirkin
From: Jean-Philippe Brucker Due to an invalid mask, virtio_iommu_mr() may return the wrong memory region. It hasn't been too problematic so far because the function was only used to test existence of an endpoint, but that is about to change. Fixes: cfb42188b24d ("virtio-iommu: Implement attach/d

[PULL v3 05/31] memory-device: Support big alignment requirements

2020-11-04 Thread Michael S. Tsirkin
From: David Hildenbrand Let's warn instead of bailing out - the worst thing that can happen is that we'll fail hot/coldplug later. The user got warned, and this should be rare. This will be necessary for memory devices with rather big (user-defined) alignment requirements - say a virtio-mem devi

[PULL v3 09/31] hw/acpi : add space before the open parenthesis '('

2020-11-04 Thread Michael S. Tsirkin
From: Xinhao Zhang Fix code style. Space required before the open parenthesis '('. Signed-off-by: Xinhao Zhang Signed-off-by: Kai Deng Message-Id: <20201103102634.273021-2-zhangxinh...@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/core.c | 2 +- 1

[PULL v3 19/31] memory: Add interface to set iommu page size mask

2020-11-04 Thread Michael S. Tsirkin
From: Bharat Bhushan Allow to set the page size mask supported by an iommu memory region. This enables a vIOMMU to communicate the page size granule supported by an assigned device, on hosts that use page sizes greater than 4kB. Acked-by: Peter Xu Reviewed-by: Eric Auger Signed-off-by: Bharat

[PULL v3 06/31] memory-device: Add get_min_alignment() callback

2020-11-04 Thread Michael S. Tsirkin
From: David Hildenbrand Add a callback that can be used to express additional alignment requirements (exceeding the ones from the memory region). Will be used by virtio-mem to express special alignment requirements due to manually configured, big block sizes (e.g., 1GB with an ordinary memory-ba

[PULL v3 14/31] virtio-iommu: Store memory region in endpoint struct

2020-11-04 Thread Michael S. Tsirkin
From: Jean-Philippe Brucker Store the memory region associated to each endpoint into the endpoint structure, to allow efficient memory notification on map/unmap. Acked-by: Eric Auger Signed-off-by: Jean-Philippe Brucker Message-Id: <20201030180510.747225-3-jean-phili...@linaro.org> Reviewed-by

[PULL v3 16/31] virtio-iommu: Call memory notifiers in attach/detach

2020-11-04 Thread Michael S. Tsirkin
From: Bharat Bhushan Call the memory notifiers when attaching an endpoint to a domain, to replay existing mappings, and when detaching the endpoint, to remove all mappings. Signed-off-by: Bharat Bhushan Signed-off-by: Jean-Philippe Brucker Message-Id: <20201030180510.747225-5-jean-phili...@lin

[PULL v3 24/31] net: Add vhost-vdpa in show_netdevs()

2020-11-04 Thread Michael S. Tsirkin
From: Cindy Lu Fix the bug that while Check qemu supported netdev, there is no vhost-vdpa Signed-off-by: Cindy Lu Message-Id: <20201016030909.9522-2-l...@redhat.com> Acked-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- net/net.c | 3 +++ 1 file changed,

[PULL v3 20/31] vfio: Set IOMMU page size as per host supported page size

2020-11-04 Thread Michael S. Tsirkin
From: Bharat Bhushan Set IOMMU supported page size mask same as host Linux supported page size mask. Acked-by: Alex Williamson Reviewed-by: Eric Auger Signed-off-by: Bharat Bhushan Signed-off-by: Jean-Philippe Brucker Message-Id: <20201030180510.747225-9-jean-phili...@linaro.org> Reviewed-by

[PULL v3 17/31] virtio-iommu: Add replay() memory region callback

2020-11-04 Thread Michael S. Tsirkin
From: Bharat Bhushan Implement the replay callback to setup all mappings for a new memory region. Signed-off-by: Bharat Bhushan Signed-off-by: Jean-Philippe Brucker Message-Id: <20201030180510.747225-6-jean-phili...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[PULL v3 11/31] hw/virtio/vhost-backend: Fix Coverity CID 1432871

2020-11-04 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé Fix uninitialized value issues reported by Coverity: Field 'msg.reserved' is uninitialized when calling write(). While the 'struct vhost_msg' does not have a 'reserved' field, we still initialize it to have the two parts of the function consistent. Reported-by: C

[PULL v3 30/31] block/export: fix vhost-user-blk get_config() information leak

2020-11-04 Thread Michael S. Tsirkin
From: Stefan Hajnoczi Refuse get_config() requests in excess of sizeof(struct virtio_blk_config). Signed-off-by: Stefan Hajnoczi Message-Id: <20201027173528.213464-5-stefa...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- block/export/vhost-user-blk-server.

[PULL v3 12/31] hw/smbios: Fix leaked fd in save_opt_one() error path

2020-11-04 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé Fix the following Coverity issue (RESOURCE_LEAK): CID 1432879: Resource leak Handle variable fd going out of scope leaks the handle. Replace a close() call by qemu_close() since the handle is opened with qemu_open(). Fixes: bb99f4772f5 ("hw/smbios: support l

[PULL v3 21/31] virtio-iommu: Set supported page size mask

2020-11-04 Thread Michael S. Tsirkin
From: Bharat Bhushan The virtio-iommu device can deal with arbitrary page sizes for virtual endpoints, but for endpoints assigned with VFIO it must follow the page granule used by the host IOMMU driver. Implement the interface to set the vIOMMU page size mask, called by VFIO for each endpoint. W

[PULL v3 28/31] configure: introduce --enable-vhost-user-blk-server

2020-11-04 Thread Michael S. Tsirkin
From: Stefan Hajnoczi Make it possible to compile out the vhost-user-blk server. It is enabled by default on Linux. Note that vhost-user-server.c depends on libvhost-user, which requires CONFIG_LINUX. The CONFIG_VHOST_USER dependency was erroneous since that option controls vhost-user frontends

[PULL v3 22/31] vfio: Don't issue full 2^64 unmap

2020-11-04 Thread Michael S. Tsirkin
From: Jean-Philippe Brucker IOMMUs may declare memory regions spanning from 0 to UINT64_MAX. When attempting to deal with such region, vfio_listener_region_del() passes a size of 2^64 to int128_get64() which throws an assertion failure. Even ignoring this, the VFIO_IOMMU_DMA_MAP ioctl cannot han

[PATCH v3 1/2] iotests: add filter_qmp_virtio_scsi function

2020-11-04 Thread Maxim Levitsky
filter_qmp_virtio_scsi can be used to filter virtio-scsi-pci/ccw differences. Note that this patch was only tested on x86. Suggested-by: Paolo Bonzini Signed-off-by: Maxim Levitsky Tested-by: Christian Borntraeger Reviewed-by: Paolo Bonzini --- tests/qemu-iotests/iotests.py | 10 ++ 1

[PATCH v3 0/2] Assorted fixes to tests that were broken by recent scsi changes

2020-11-04 Thread Maxim Levitsky
While most of the patches in V1 of this series are already merged upstream, the patch that fixes iotest 240 was broken on s390 and was not accepted. This is an updated version of this patch, based on Paulo's suggestion, that hopefully makes this iotest work on both x86 and s390. V3: addressed rev

[PULL v3 26/31] vhost-blk: set features before setting inflight feature

2020-11-04 Thread Michael S. Tsirkin
From: Jin Yu Virtqueue has split and packed, so before setting inflight, you need to inform the back-end virtqueue format. Signed-off-by: Jin Yu Acked-by: Raphael Norwitz Message-Id: <20201103123617.28256-1-jin...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin -

[PULL v3 23/31] vhost-vdpa: Add qemu_close in vhost_vdpa_cleanup

2020-11-04 Thread Michael S. Tsirkin
From: Cindy Lu fix the bug that fd will still open after the cleanup Signed-off-by: Cindy Lu Message-Id: <20201016030909.9522-1-l...@redhat.com> Acked-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- net/vhost-vdpa.c | 4 1 file changed, 4 insertions

[PULL v3 25/31] Revert "vhost-blk: set features before setting inflight feature"

2020-11-04 Thread Michael S. Tsirkin
From: Stefan Hajnoczi This reverts commit adb29c027341ba095a3ef4beef6aaef86d3a520e. The commit broke -device vhost-user-blk-pci because the vhost_dev_prepare_inflight() function it introduced segfaults in vhost_dev_set_features() when attempting to access struct vhost_dev's vdev pointer before i

Re: [PATCH v2 2/2] iotests: rewrite iotest 240 in python

2020-11-04 Thread Maxim Levitsky
On Tue, 2020-11-03 at 13:53 +0100, Max Reitz wrote: > On 01.11.20 17:15, Maxim Levitsky wrote: > > The recent changes that brought RCU delayed device deletion, > > broke few tests and this test breakage went unnoticed. > > > > Fix this test by rewriting it in python > > (which allows to wait for D

[PULL v3 29/31] block/export: make vhost-user-blk config space little-endian

2020-11-04 Thread Michael S. Tsirkin
From: Stefan Hajnoczi VIRTIO 1.0 devices have little-endian configuration space. The vhost-user-blk-server.c code already uses little-endian for virtqueue processing but not for the configuration space fields. Fix this so the vhost-user-blk export works on big-endian hosts. Signed-off-by: Stefan

[PULL v3 27/31] libvhost-user: follow QEMU comment style

2020-11-04 Thread Michael S. Tsirkin
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Message-Id: <20201027173528.213464-2-stefa...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- contrib/libvhost-user/libvhost-user.h | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) di

[PULL v3 18/31] virtio-iommu: Add notify_flag_changed() memory region callback

2020-11-04 Thread Michael S. Tsirkin
From: Bharat Bhushan Add notify_flag_changed() to notice when memory listeners are added and removed. Acked-by: Eric Auger Signed-off-by: Bharat Bhushan Signed-off-by: Jean-Philippe Brucker Message-Id: <20201030180510.747225-7-jean-phili...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-

[PULL v3 31/31] contrib/vhost-user-blk: fix get_config() information leak

2020-11-04 Thread Michael S. Tsirkin
From: Stefan Hajnoczi Refuse get_config() in excess of sizeof(struct virtio_blk_config). Signed-off-by: Stefan Hajnoczi Message-Id: <20201027173528.213464-6-stefa...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- contrib/vhost-user-blk/vhost-user-blk.c | 2

[PATCH v3 2/2] iotests: rewrite iotest 240 in python

2020-11-04 Thread Maxim Levitsky
The recent changes that brought RCU delayed device deletion, broke few tests and this test breakage went unnoticed. Fix this test by rewriting it in python (which allows to wait for DEVICE_DELETED events before continuing). Signed-off-by: Maxim Levitsky Tested-by: Christian Borntraeger Reviewed

[PULL v3 10/31] hw/acpi : add spaces around operator

2020-11-04 Thread Michael S. Tsirkin
From: Xinhao Zhang Fix code style. Operator needs spaces both sides. Signed-off-by: Xinhao Zhang Signed-off-by: Kai Deng Message-Id: <20201103102634.273021-3-zhangxinh...@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/pcihp.c | 2 +- 1 file changed

Re: [PATCH RFC] memory: pause all vCPUs for the duration of memory transactions

2020-11-04 Thread Peter Xu
On Wed, Nov 04, 2020 at 07:09:02PM +0100, Laszlo Ersek wrote: > On 11/03/20 17:37, Peter Xu wrote: > > On Tue, Nov 03, 2020 at 02:07:09PM +0100, Vitaly Kuznetsov wrote: > >> In case it is a normal access from the guest, yes, but AFAIR here > >> guest's CR3 is pointing to non existent memory and whe

Re: [PATCH V2] vl: pause option

2020-11-04 Thread Eric Blake
On 11/2/20 9:50 AM, Steve Sistare wrote: > Provide the -pause command-line parameter and the QEMU_PAUSE environment > variable to pause QEMU during process startup using SIGSTOP and allow a > developer to attach a debugger, or observe the process using tools such as > strace. Useful when the QEMU

Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

2020-11-04 Thread Mark Cave-Ayland
On 04/11/2020 12:47, Thomas Huth wrote: On 26/09/2020 16.02, Mark Cave-Ayland wrote: Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the Mac Old World and New World machine level. Also remove the now obsolete comment referring to the use of serial_hd() and the setting

[PATCH] README: Add Documentation blurb

2020-11-04 Thread John Snow
Add it in a prominent place: Right after figuring out what QEMU is, users may wish to know how to use it more than they want to know how to build their own version of it. Signed-off-by: John Snow --- README.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/README.rst b/README.

[Bug 1338563] Re: README refers to a non-extant file

2020-11-04 Thread John Snow
In 2020, the qemu documentation is now hosted online and doesn't require a build: https://www.qemu.org/documentation/ We are also very deep into a tree-wide overhaul to move our documentation onto Sphinx and begin providing versioned manuals. I'm closing this as fixed. ** Changed in: qemu

[Bug 1377163] Re: Does not add usb-host devices as they are hotplugged

2020-11-04 Thread John Snow
** Changed in: qemu Status: Opinion => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1377163 Title: Does not add usb-host devices as they are hotplugged Status in QEMU: New Bug descr

Re: [PATCH v9 2/8] fw_cfg: Write the extra roots into the fw_cfg

2020-11-04 Thread Laszlo Ersek
+Marcel On 11/03/20 13:01, Jiahui Cen wrote: > From: Yubo Miao > > Write the extra roots into the fw_cfg, therefore the uefi could > get the extra roots. Only if the uefi knows there are extra roots, > the config space of devices behind the root could be obtained. > > Signed-off-by: Yubo Miao

[Bug 1569491] Re: qemu system i386 poor performance on e5500 core

2020-11-04 Thread John Snow
I'm triaging old bugs: Can you provide command lines, versions, and steps to test and measure the relative performance? At the very least, please try to confirm on the latest version of QEMU (5.2.0-rc0, if possible) to update this report. ** Changed in: qemu Status: Opinion => Incomplete

[Bug 1781463] Re: qemu don't start *.abs firmware files

2020-11-04 Thread John Snow
** Changed in: qemu Status: Opinion => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1781463 Title: qemu don't start *.abs firmware files Status in QEMU: New Bug description: Hello

Re: [PATCH v9 2/8] fw_cfg: Write the extra roots into the fw_cfg

2020-11-04 Thread Laszlo Ersek
+Phil, +Gerd On 11/04/20 20:54, Laszlo Ersek wrote: > +Marcel > > On 11/03/20 13:01, Jiahui Cen wrote: >> From: Yubo Miao >> >> Write the extra roots into the fw_cfg, therefore the uefi could >> get the extra roots. Only if the uefi knows there are extra roots, >> the config space of devices beh

[Bug 1879672] Re: QEMU installer with WHPX support

2020-11-04 Thread John Snow
Removing 'Opinion' and moving back to 'New'; as 'Opinion' is essentially the same as "WONTFIX" but allows discussion to continue. I believe you want a Feature Request tag instead. If there is still work for us to do, let's move this to Confirmed/Triaged and add the feature request tag. Thanks! *

[Bug 1878253] Re: null-ptr dereference in address_space_to_flatview through ide

2020-11-04 Thread John Snow
Merged upstream: 55adb3c45620c31f29978f209e2a44a08d34e2da 4ac4e7281a2dd1ca5158812198c4d2cbacf2ae25 b45bcd81e05dea2781f2164ca1c9dd86069502ea 1a9925e3390b6adf1125e3abaa17c80ca012bede ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you

[Bug 1884693] Re: Assertion failure in address_space_unmap through ahci_map_clb_address

2020-11-04 Thread John Snow
Merged: 1d1c4bdb736688b20d864831b90c07dc59c7b10c ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1884693 Title: Assertion failure in a

[Bug 1887303] Re: Assertion failure in *bmdma_active_if `bmdma->bus->retry_unit != (uint8_t)-1' failed.

2020-11-04 Thread John Snow
Merged upstream: 55adb3c45620c31f29978f209e2a44a08d34e2da 4ac4e7281a2dd1ca5158812198c4d2cbacf2ae25 b45bcd81e05dea2781f2164ca1c9dd86069502ea 1a9925e3390b6adf1125e3abaa17c80ca012bede ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you

[Bug 1887309] Re: Floating-point exception in ide_set_sector

2020-11-04 Thread John Snow
Merged upstream: 55adb3c45620c31f29978f209e2a44a08d34e2da 4ac4e7281a2dd1ca5158812198c4d2cbacf2ae25 b45bcd81e05dea2781f2164ca1c9dd86069502ea 1a9925e3390b6adf1125e3abaa17c80ca012bede ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you

Re: [PATCH V2] vl: pause option

2020-11-04 Thread Steven Sistare
On 11/4/2020 2:26 PM, Eric Blake wrote: > On 11/2/20 9:50 AM, Steve Sistare wrote: >> Provide the -pause command-line parameter and the QEMU_PAUSE environment >> variable to pause QEMU during process startup using SIGSTOP and allow a >> developer to attach a debugger, or observe the process using t

Re: [PATCH v2 41/44] qdev: Move base property types to qom/property-types.c

2020-11-04 Thread Eduardo Habkost
On Wed, Nov 04, 2020 at 05:36:20PM +0100, Paolo Bonzini wrote: > On 04/11/20 17:00, Eduardo Habkost wrote: > > Move all property types from qdev-properties.c to > > qom/property-types.c. > > > > Signed-off-by: Eduardo Habkost > > --- > > Changes v1 -> v2: > > * Rebased after changes in previous p

Re: [PULL 00/33] Block patches

2020-11-04 Thread Peter Maydell
On Wed, 4 Nov 2020 at 15:18, Stefan Hajnoczi wrote: > > The following changes since commit 8507c9d5c9a62de2a0e281b640f995e26eac46af: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2020-11-03 15:59:44 +) > > are available in the Git repository at: > > ht

Re: [PATCH v9 2/8] fw_cfg: Write the extra roots into the fw_cfg

2020-11-04 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 11/4/20 9:05 PM, Laszlo Ersek wrote: > +Phil, +Gerd > > On 11/04/20 20:54, Laszlo Ersek wrote: >> +Marcel >> >> On 11/03/20 13:01, Jiahui Cen wrote: >>> From: Yubo Miao >>> >>> Write the extra roots into the fw_cfg, therefore the uefi could >>> get the extra roots. Only if the uefi

Re: [PATCH v2 4/8] linux-user/mips/cpu_loop: silence the compiler warnings

2020-11-04 Thread Laurent Vivier
Le 30/10/2020 à 01:40, Chen Qun a écrit : > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: > linux-user/mips/cpu_loop.c: In function ‘cpu_loop’: > linux-user/mips/cpu_loop.c:104:24: warning: this statement may fall through > [-Wimplicit-fallthrough=] > 104 |

Re: [PATCH] linux-user: Check copy_from_user() return value in vma_dump_size()

2020-11-04 Thread Laurent Vivier
Le 03/11/2020 à 15:15, Peter Maydell a écrit : > Coverity points out that we don't check the return value from > copy_from_user() in vma_dump_size(). This is to some extent > a "can't happen" error since we've already checked the page > with an access_ok() call earlier, but it's simple enough to >

Re: [PATCH] linux-user: Use "!= 0" when checking if MAP_FIXED_NOREPLACE is non-zero

2020-11-04 Thread Laurent Vivier
Le 03/11/2020 à 15:26, Peter Maydell a écrit : > In pgd_find_hole_fallback(), Coverity doesn't like the use > of "if (MAP_FIXED_NOREPLACE || ...)" because it's using a > logical operator on a constant other than 0 or 1 and its > heuristic thinks we might have intended a bitwise operator > instead.

Re: [PATCH v1 1/1] linux-user/syscall: Fix missing target_to_host_timespec64() check

2020-11-04 Thread Laurent Vivier
Le 03/11/2020 à 20:48, Alistair Francis a écrit : > Coverity pointed out (CID 1432339) that target_to_host_timespec64() can > fail with -TARGET_EFAULT but we never check the return value. This patch > checks the return value and handles the error. > > Signed-off-by: Alistair Francis > --- > linu

Re: [PATCH] linux-user: Check copy_from_user() return value in vma_dump_size()

2020-11-04 Thread Laurent Vivier
Le 03/11/2020 à 15:15, Peter Maydell a écrit : > Coverity points out that we don't check the return value from > copy_from_user() in vma_dump_size(). This is to some extent > a "can't happen" error since we've already checked the page > with an access_ok() call earlier, but it's simple enough to >

Re: [PATCH V2] vl: pause option

2020-11-04 Thread Alex Bennée
Eric Blake writes: > On 11/2/20 9:50 AM, Steve Sistare wrote: >> Provide the -pause command-line parameter and the QEMU_PAUSE environment >> variable to pause QEMU during process startup using SIGSTOP and allow a >> developer to attach a debugger, or observe the process using tools such as >> s

Re: [PATCH] ssi: Fix bad printf format specifiers

2020-11-04 Thread Chubb, Peter (Data61, Kensington NSW)
> "AlexChen" == AlexChen writes: AlexChen> We should use printf format specifier "%u" instead of "%d" AlexChen> for argument of type "unsigned int". AlexChen> Reported-by: Euler Robot AlexChen>Signed-off-by: Alex Chen --- LGTM, add Reviewed-By: Peter Chubb -- Peter ChubbTe

Re: Question on UEFI ACPI tables setup and probing on arm64

2020-11-04 Thread Laszlo Ersek
+Ard, +Drew On 11/03/20 13:39, Igor Mammedov wrote: > On Fri, 30 Oct 2020 10:50:01 +0800 > Ying Fang wrote: > >> Hi, >> >> I have a question on UEFI/ACPI tables setup and probing on arm64 platform. > > CCing Laszlo, > who might know how it's implemented. > >> Currently on arm64 platform guest

Re: [PULL v3 05/12] qga: add command guest-get-disks

2020-11-04 Thread Eric Blake
[Adding Markus in CC] On 11/2/20 8:43 PM, Michael Roth wrote: > From: Tomáš Golembiovský > > Add API and stubs for new guest-get-disks command. > > The command guest-get-fsinfo can be used to list information about disks > and partitions but it is limited only to mounted disks with filesystem.

Re: Question on UEFI ACPI tables setup and probing on arm64

2020-11-04 Thread Ard Biesheuvel
On 11/4/20 10:46 PM, Laszlo Ersek wrote: ... (9) (Ard, please correct the below if necessary; thanks.) The UEFI stub of the guest kernel (which is a UEFI application) uses a device tree as its main communication channel to the (later-started) kernel entry point, AIUI. The UEFI stub basically i

[Bug 1900779] Re: xp /16i on arm mixes DWords

2020-11-04 Thread John Snow
Staged: 437588d81d99ac91cb1e4ff060610458e67852d5 ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1900779 Title: xp /16i on arm mixes D

[Bug 1900779] Re: xp /16i on arm mixes DWords

2020-11-04 Thread John Snow
https://gitlab.com/qemu- project/qemu/-/commit/437588d81d99ac91cb1e4ff060610458e67852d5 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1900779 Title: xp /16i on arm mixes DWords Status in QEMU: F

[Bug 1893667] Re: Btrfs commands don't work when using user-space emulation of other architectures

2020-11-04 Thread John Snow
Laurent, I am assuming that the commits here: https://gitlab.com/qemu-project/qemu/-/commits/master?utf8=%E2%9C%93&search=Filip+Bozuta are sufficient to mark this issue as Fix Committed. It looks like the Downstream bug tracker for Fedora has marked the related bug as CLOSED ERRATA already. If I'

[RFC PATCH 0/9] gitlab-ci: Allow forks to skip some build jobs

2020-11-04 Thread Philippe Mathieu-Daudé
Hi, 2 months ago GitLab added time limit to their free CI offer [1]. This series provide developers with the possibility to not run all jobs. By default all jobs are started, but we can disable a subset of them. I think this should be the other way around (enable features one wants to test, with

[RFC PATCH 2/9] gitlab-ci: Replace YAML anchors by extends (native_build_job)

2020-11-04 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff -

[RFC PATCH 4/9] gitlab-ci: Replace YAML anchors by extends (acceptance_test_job)

2020-11-04 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/.gitlab-ci.y

[RFC PATCH 3/9] gitlab-ci: Replace YAML anchors by extends (native_test_job)

2020-11-04 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a

[RFC PATCH 5/9] gitlab-ci: Rename acceptance_test_job -> integration_test_job

2020-11-04 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 5c64e477c9d..0b77a90dd73 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -48,7 +48,7 @@ include: - find .

[RFC PATCH 6/9] gitlab-ci: Extract common job definition as 'cross_common_job'

2020-11-04 Thread Philippe Mathieu-Daudé
Extract the common definitions shared by '.cross_system_build_job' and '.cross_user_build_job' to '.cross_common_job'. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/crossbuilds.yml | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.gitlab-ci.d/crossbuilds.yml

[RFC PATCH 1/9] gitlab-ci: Replace YAML anchors by extends (cross_system_build_job)

2020-11-04 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/crossbuilds.yml | 40 ++-- 1 file changed, 20 insertions(+), 20 de

[RFC PATCH 8/9] gitlab-ci: Add rules to skip building cross-jobs

2020-11-04 Thread Philippe Mathieu-Daudé
Add rules to skip some crossbuild jobs. The following tags are available to skip CI jobs: - cross (skip all cross-jobs) - system (skip all cross-system jobs) - user (skip all cross-user jobs) Developers can combine tags in the SKIP_BUILD variable when pushing a branch (or tag) to repositories.

[RFC PATCH 9/9] gitlab-ci: Add rules to skip building/testing native jobs

2020-11-04 Thread Philippe Mathieu-Daudé
Add rules to skip various build/test jobs. The following tags are available to skip CI jobs: - user(user-mode jobs) - system (system-mode jobs) - centos (jobs based on CentOS distribution image) - debian (... Debian) - fedora (... Fedora) - ubuntu

[RFC PATCH 7/9] gitlab-ci: Extract common job definition as 'native_common_job'

2020-11-04 Thread Philippe Mathieu-Daudé
Extract the common definitions shared by '.native_build_job' and '.native_test_job' to '.native_common_job'. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 0b77a90dd73..96

[Bug 1294227] Re: migration wrong handling of KVM_GET_DIRTY_LOG ioctl

2020-11-04 Thread John Snow
Moving this bug back to Confirmed to move it out of "In progress" state. We still check for only -1 upstream. ** Changed in: qemu Status: In Progress => Confirmed ** Changed in: qemu Assignee: Christoffer Dall (cdall) => (unassigned) -- You received this bug notification because you

[Bug 1888918] Re: qemu-system-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

2020-11-04 Thread John Snow
Assuming that this commit: https://gitlab.com/qemu-project/qemu/-/commit/8dcdb535d7cc4ba6270bb756e12e1d323254ed4e is sufficient to mark this bug as Fix Committed. Please re-open if I am mistaken. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notificati

[Bug 1611394] Re: qemu-ppc: Scalar Single-Precision Floating-Point instructions should not test MSR[SPV]

2020-11-04 Thread John Snow
Assuming that this commit: https://gitlab.com/qemu-project/qemu/-/commit/8dcdb535d7cc4ba6270bb756e12e1d323254ed4e is sufficient to mark this bug as Fix Committed. Please re-open if I am mistaken. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notificati

Re: [Bug 1879672] Re: QEMU installer with WHPX support

2020-11-04 Thread Philippe Mathieu-Daudé
Hi John, On 11/4/20 9:01 PM, John Snow wrote: > Removing 'Opinion' and moving back to 'New'; as 'Opinion' is essentially > the same as "WONTFIX" but allows discussion to continue. I believe you > want a Feature Request tag instead. > > If there is still work for us to do, let's move this to > Con

[Bug 1826200] Re: RFE: populate "OEM Strings" (type 11) SMBIOS table strings from regular files

2020-11-04 Thread John Snow
Merged: https://patchew.org/QEMU/20200923133804.2089190-1-berra...@redhat.com/ Commits: https://gitlab.com/qemu-project/qemu/-/commit/bb99f4772f54017490e3356ecbb3df25c5d4537f https://gitlab.com/qemu-project/qemu/-/commit/10c358f53c5ec8fd9ec27cdf5c393ff814a0 https://gitlab.com/qemu-project/qem

[Bug 1817239] Re: add '--targets' option to qemu-binfmt-conf.sh

2020-11-04 Thread John Snow
This series appears to have stalled as of v7: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04241.html -- moving back to 'New' status. ** Changed in: qemu Status: In Progress => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subs

Re: locking option doesn't work as expected

2020-11-04 Thread Masayoshi Mizuma
On Wed, Nov 04, 2020 at 04:48:53PM +, Daniel P. Berrangé wrote: > On Wed, Nov 04, 2020 at 11:35:56AM -0500, Masayoshi Mizuma wrote: > > Hello, > > > > It seems that locking option doesn't work as expected. > > When I run qemu as following options, then I got an error and failed to > > boot the

[Bug 1835865] Re: piix crashes on mips when accessing acpi-pci-hotplug

2020-11-04 Thread John Snow
** Changed in: qemu Status: In Progress => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1835865 Title: piix crashes on mips when accessing acpi-pci-hotplug Status in QEMU: Conf

[Bug 1878043] Re: memcpy param-overlap in Slirp ip_stripoptions through e1000e

2020-11-04 Thread John Snow
** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878043 Title: memcpy param-overlap in Slirp ip_stripoptions through e1000e Status in

[Bug 1872237] Re: SysTick reload behavior emulated incorrectly

2020-11-04 Thread John Snow
Merged: https://patchew.org/QEMU/20201015151829.14656-1-peter.mayd...@linaro.org/ Commits: https://gitlab.com/qemu-project/qemu/-/commit/68d59c6d8d85ae176d3cb2cd20a48d6a090ba288 https://gitlab.com/qemu-project/qemu/-/commit/32bd322a0134ed89db00f2b9b3894982db3dedcb ** Changed in: qemu Stat

Re: [QEMU] Question regarding user mode support for ARM syscalls

2020-11-04 Thread Laurent Vivier
Le 04/11/2020 à 11:57, Lukasz Majewski a écrit : > Hi Alistair, > >> On Tue, Nov 3, 2020 at 8:55 AM Lukasz Majewski wrote: >>> >>> Hi Alistair, >>> On Tue, Nov 3, 2020 at 3:03 AM Lukasz Majewski wrote: > > Dear Qemu Community, Hey Lukasz, + QEMU Dev Ma

[Bug 1681439] Re: qemu-system-x86_64: hw/ide/core.c:685: ide_cancel_dma_sync: Assertion `s->bus->dma->aiocb == NULL' failed.

2020-11-04 Thread John Snow
TLDR: I am not actively working on this, because the problem extends well below IDE and I don't have the bandwidth to take point on this at the moment. Here's a writeup I sent to qemu-devel on 2020-07-30: First, the (partially bogus, fuzzer-generated) IDE command wants to: 1. dma write 259 sect

Re: Migrating to the gitlab issue tracker

2020-11-04 Thread John Snow
On 10/30/20 6:57 AM, Peter Maydell wrote: On Fri, 30 Oct 2020 at 10:10, Daniel P. Berrangé wrote: This makes it more appealing to leave existing bugs in the LP tracker until they are resolved, auto-closed, or there is a compelling reason to move to gitlab. The compelling reason is that there

[PULL for-5.2 0/2] tcg patch queue

2020-11-04 Thread Richard Henderson
The following changes since commit 3c8c36c9087da957f580a9bb5ebf7814a753d1c6: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20201104-pull-request' into staging (2020-11-04 16:52:17 +) are available in the Git repository at: https://github.com/rth7680/qemu.git tag

[PULL for-5.2 1/2] tcg: Remove assert from set_jmp_reset_offset

2020-11-04 Thread Richard Henderson
Since 6e6c4efed99, there has been a more appropriate range check done later at the end of tcg_gen_code. There, a failing range check results in a returned error code, which causes the TB to be restarted at half the size. Reported-by: Sai Pavan Boddu Tested-by: Sai Pavan Boddu Reviewed-by: Phili

<    1   2   3   4   5   >