On Mittwoch, 4. November 2020 12:57:04 CET Philippe Mathieu-Daudé wrote:
> Commit b2c00bce54c ("meson: convert hw/9pfs, cleanup") introduced
> CONFIG_9PFS (probably a wrong conflict resolution). This config is
> not used anywhere. Backends depend on CONFIG_FSDEV_9P which itself
> depends on CONFIG_
On Fri, 30 Oct 2020 13:28:23 +0100
Christian Borntraeger wrote:
> From: "Jason J. Herne"
>
> The architecture states that the iplb location is only written to low
> core for list directed ipl and not for traditional ccw ipl. If we don't
> skip this then operating systems that load by reading in
On Wed, 4 Nov 2020 13:25:40 +0530
Kirti Wankhede wrote:
> On 11/4/2020 1:57 AM, Alex Williamson wrote:
> > On Wed, 4 Nov 2020 01:18:12 +0530
> > Kirti Wankhede wrote:
> >
> >> On 10/30/2020 12:35 AM, Alex Williamson wrote:
> >>> On Thu, 29 Oct 2020 23:11:16 +0530
> >>> Kirti Wankhede wrote
On 26/09/2020 16.02, Mark Cave-Ayland wrote:
> Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the
> Mac Old World and New World machine level.
>
> Also remove the now obsolete comment referring to the use of serial_hd() and
> the setting of user_creatable to false accordi
On 04/11/20 13:21, Markus Armbruster wrote:
Paolo Bonzini writes:
Right now, help options are parsed normally and then checked
specially in opt_validate---but only if coming from
qemu_opts_parse or qemu_opts_parse_noisily, not if coming
from qemu_opt_set.
Instead, move the check from opt_vali
On 11/4/20 9:57 AM, Philippe Mathieu-Daudé wrote:
We test './configure --without-default-devices' since commit
20885b5b169 (".travis.yml: test that no-default-device builds
do not regress") in Travis-CI.
Since having a single CI to look at is easier, and GitLab-CI
is the preferred one, add the
On 11/4/20 9:57 AM, Philippe Mathieu-Daudé wrote:
We replicated the --without-default-devices job on GitLab-CI
in the previous commit. We can now remove it from Travis-CI.
Reviewed-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
.travis.yml | 8
1 file changed, 8 deleti
This package was added in
commit 8ea5962f286272ac2533892c07f9b7e2a77d8819
Author: Philippe Mathieu-Daudé
Date: Sat May 4 07:54:40 2019 +0200
tests/docker: Test more components on the Fedora default image
but this is never used by QEMU. The multipath support in QEMU
requires the devi
There is no sign of 'bc' being used by any tests in the tree.
Signed-off-by: Daniel P. Berrangé
---
scripts/coverity-scan/coverity-scan.docker | 1 -
tests/docker/dockerfiles/debian10.docker | 1 -
tests/docker/dockerfiles/fedora-win32-cross.docker | 1 -
tests/docker/dockerfil
The NSS package was previously pre-requisite for building CCID related
features, however, this became obsolete when the libcacard library was
spun off to a separate project:
commit 7b02f5447c64d1854468f758398c9f6fe9e5721f
Author: Marc-André Lureau
Date: Sun Aug 30 11:48:40 2015 +020
This is v3.
Paolo Bonzini writes:
> OptsVisitor, StringInputVisitor and the keyval visitor have
> three different ideas of how a human could write the value of
> a boolean option. Pay homage to the backwards-compatibility
> gods and make the new common helper accept all four sets (on/off,
> tru
Daniel P. Berrangé writes:
> On Wed, Nov 04, 2020 at 12:31:40PM +0100, Paolo Bonzini wrote:
>> On 04/11/20 09:29, Markus Armbruster wrote:
>> > > It only hurts in the odd case of a boolean option becoming on/off/auto
>> > > or on/off/split.
>> > Another argument for deprecating values other tha
In looking at using libvirt-ci to generate the docker files I noticed
some wierd build deps in current package lists. This cleans them up.
Daniel P. Berrangé (3):
hw/usb/ccid: remove references to NSS
tests: remove "bc" from package listing
docker: remove libblockdev-mpath-devel package
.t
On 11/4/20 2:19 PM, Daniel P. Berrangé wrote:
> There is no sign of 'bc' being used by any tests in the tree.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> scripts/coverity-scan/coverity-scan.docker | 1 -
> tests/docker/dockerfiles/debian10.docker | 1 -
> tests/docker/dockerf
Fix code style. Don't use '#' flag of printf format ('%#') in
format strings, use '0x' prefix instead
Signed-off-by: Xinhao Zhang
Signed-off-by: Kai Deng
---
hw/xen/xen_pt.c | 10 +-
hw/xen/xen_pt_config_init.c | 6 +++---
hw/xen/xen_pt_msi.c | 16
On 11/4/20 2:19 PM, Daniel P. Berrangé wrote:
> This package was added in
>
> commit 8ea5962f286272ac2533892c07f9b7e2a77d8819
> Author: Philippe Mathieu-Daudé
> Date: Sat May 4 07:54:40 2019 +0200
>
> tests/docker: Test more components on the Fedora default image
>
> but this is nev
Paolo Bonzini writes:
> On 03/11/20 17:08, Daniel P. Berrangé wrote:
>>> +Short-form boolean options (since 5.2)
>>> +''
>>> +
>>> +Boolean options such as ``share=on``/``share=off`` can be written
>>> +in short form as ``share`` and ``noshare``. This is depre
On 11/4/20 2:19 PM, Daniel P. Berrangé wrote:
> The NSS package was previously pre-requisite for building CCID related
> features, however, this became obsolete when the libcacard library was
> spun off to a separate project:
>
> commit 7b02f5447c64d1854468f758398c9f6fe9e5721f
> Author: Ma
The following changes since commit 3d6e32347a3b57dac7f469a07c5f520e69bd070a:
Update version for v5.2.0-rc0 release (2020-11-03 21:11:57 +)
are available in the Git repository at:
git://git.kraxel.org/qemu tags/ui-20201104-pull-request
for you to fetch changes up to
From: Marc-André Lureau
Thanks to the monitors' coroutine support (merge commit b7092cda1b3),
the screendump handler can trigger a graphic_hw_update(), yield and let
the main loop run until update is done. Then the handler is resumed, and
ppm_save() will write the screen image to disk in the coro
From: Marc-André Lureau
The assert() was added in commit b681a1c73e15 ("block: Repair the
throttling code."), when the qemu_co_queue_do_restart() function
required to be running in a coroutine. It was later made unnecessary in
commit a9d9235567e7 ("coroutine-lock: reschedule coroutine on the
AioC
From: Marc-André Lureau
The function is going to be called from a coroutine, and may yield.
Let's ensure our image reference doesn't change over time (due to resize
etc) by keeping a ref.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Reviewed-by: Gerd Hoffmann
Message-id: 20
https://git.kraxel.org/cgit/qemu/log/?h=sirius/usb-asserts
can you try that branch?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1901981
Title:
assert issue locates in hw/usb/dev-storage.c:248: us
Update some docs and test cases to use 'on' | 'off' as the preferred
value for bool options.
Signed-off-by: Daniel P. Berrangé
---
docs/system/vnc-security.rst | 6 +++---
include/authz/listfile.h | 2 +-
qemu-options.hx | 4 ++--
tests/qemu-iotests/233 | 4 ++--
4 files c
This post briefly goes over the main points of virtio-fs and OSv, a
unikernel running under QEMU/KVM and taking advantage of its virtio-fs
implementation.
Feel free to review, I will be more than happy to address any comments.
Signed-off-by: Fotis Xenakis
---
_posts/2020-11-04-osv-virtio-fs.md
Signed-off-by: Muhammad Moinur Rahman
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index dd16606bcd..89d6269888 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3137,6 +3137,7 @@ W: https://app.shippable.com/github/qemu/qemu
W: http://patchew.org/QE
Should be now fixed by commits 74de7145fd6..83ad4695478 (CPRMAN model
added).
** Changed in: qemu
Assignee: Philippe Mathieu-Daudé (philmd) => (unassigned)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.n
On Wed, 4 Nov 2020, Thomas Huth wrote:
> On 26/09/2020 16.02, Mark Cave-Ayland wrote:
>> Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the
>> Mac Old World and New World machine level.
>>
>> Also remove the now obsolete comment referring to the use of serial_hd() and
>> t
On 04/11/2020 15.05, Daniel P. Berrangé wrote:
> Update some docs and test cases to use 'on' | 'off' as the preferred
> value for bool options.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/system/vnc-security.rst | 6 +++---
> include/authz/listfile.h | 2 +-
> qemu-options.hx
On 11/4/20 3:05 PM, Daniel P. Berrangé wrote:
> Update some docs and test cases to use 'on' | 'off' as the preferred
> value for bool options.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/system/vnc-security.rst | 6 +++---
> include/authz/listfile.h | 2 +-
> qemu-options.hx
On Wed, 4 Nov 2020, BALATON Zoltan via wrote:
On Wed, 4 Nov 2020, Thomas Huth wrote:
On 26/09/2020 16.02, Mark Cave-Ayland wrote:
Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the
Mac Old World and New World machine level.
Also remove the now obsolete comment referri
On 04/11/2020 15.16, BALATON Zoltan wrote:
> On Wed, 4 Nov 2020, Thomas Huth wrote:
>> On 26/09/2020 16.02, Mark Cave-Ayland wrote:
>>> Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the
>>> Mac Old World and New World machine level.
>>>
>>> Also remove the now obsolete co
Hi
On Wed, Nov 4, 2020 at 5:16 AM John Snow wrote:
> On 10/26/20 5:36 PM, John Snow wrote:
> > based-on: <20201026194251.11075-1-js...@redhat.com>
> >[PATCH v2 00/11] qapi: static typing conversion, pt2
>
> Ping,
>
> This series can be reviewed independently of pt2, so I encourage yo
From: Bruce Rogers
The gio library detection code no longer works, due to a missing $ in
front of the gio_libs reference. Make the string be $gio_libs.
Fixes: 76346b6264a ("configure: Test that gio libs from pkg-config
work")
Signed-off-by: Bruce Rogers
Message-Id: <20201103145121.668865-1-bro
The following changes since commit 83851c7c60c90e9fb6a23ff48076387a77bc33cd:
Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2020-10-27-v3-tag'
into staging (2020-11-03 12:47:58 +)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-upstream
From: Philippe Mathieu-Daudé
We removed the global_locking field in commit 4174495408a,
leaving dead code around the 'unlocked' variable. Remove it
to fix the DEADCODE issue reported by Coverity (CID 1432876).
Fixes: 4174495408a ("exec: Remove MemoryRegion::global_locking field")
Signed-off-by:
From: Peter Maydell
In socket_accept() we use setsockopt() to set SO_RCVTIMEO,
but we don't check the return value for failure. Do so.
Fixes: Coverity CID 1432321
Signed-off-by: Peter Maydell
Message-Id: <20201103115112.19211-1-peter.mayd...@linaro.org>
Signed-off-by: Paolo Bonzini
---
tests/
From: Alexander Bulekov
OSS-Fuzz changed the way it scans for fuzzers in $DEST_DIR. The new code
also scans subdirectories for fuzzers. This means that OSS-Fuzz is
considering bin/qemu-fuzz-i386 as an independent fuzzer (it is not - it
requires a --fuzz-target argument). This has led to coverage-
Memory returned by get_relocated_path must be freed with
free or g_free depending on the path that the function
took; Coverity takes exception to this practice. The
fix lets caller use g_free as is standard in QEMU.
While at it, mention the requirements on the caller in
the doc comment.
Suggeste
The warning was printing an empty string if the bad sphinx-build
was not passed on the command line. Instead, always use the
path that was returned by find_program.
Reported-by: Peter Maydell
Signed-off-by: Paolo Bonzini
---
docs/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
From: Marc Hartmayer
The option `libexecdir` is relative to `prefix` (see
https://mesonbuild.com/Builtin-options.html), so we have to be aware
of this when creating 50-qemu-gpu.json and
50-qemu-virtiofsd.json. Otherwise, tools like libvirt will not be able
to find the executable.
Fixes: 16bf7a33
device-introspect-test uses HMP, so it should escape the device name
properly. Because of this, a few devices that had commas in their
names were escaping testing.
Signed-off-by: Paolo Bonzini
---
tests/qtest/device-introspect-test.c | 10 --
1 file changed, 8 insertions(+), 2 deletions
From: Philippe Mathieu-Daudé
libFuzzer triggered the following assertion:
cat << EOF | qemu-system-i386 -M pc-q35-5.0 \
-nographic -monitor none -serial none \
-qtest stdio -d guest_errors -trace pci\*
outl 0xcf8 0x8400f841
outl 0xcfc 0xebed205d
outl 0x5d02 0xedf82049
EOF
pci
Expand on the usage of sourcesets and describe the CONFIG_ALL
symbol.
Signed-off-by: Paolo Bonzini
---
docs/devel/build-system.rst | 158
docs/devel/kconfig.rst | 2 +
2 files changed, 107 insertions(+), 53 deletions(-)
diff --git a/docs/devel/build-s
From: Alexander Bulekov
We should be checking that the device is trying to read from RAM, before
filling the region with data. Otherwise, we will try to populate
nonsensical addresses in RAM for callbacks on PIO/MMIO reads. We did
this originally, however the final version I sent had the line com
Meson 0.56.0 correctly builds non-PIC static libraries with -fPIE if
b_pie=true. We do not have to pass b_staticpic=true if PIE is requested
if Meson is new-enough, which improves performance.
Signed-off-by: Paolo Bonzini
---
configure | 6 +-
meson.build | 4 ++--
2 files changed, 7 inse
From: Alexander Bulekov
This code had all sorts of issues. We used a loop similar to
address_space_write_rom, but I did not remove a "break" that only made
sense in the context of the switch statement in the original code. Then,
after the loop, we did a separate qtest_memwrite over the entire DMA
OptsVisitor, StringInputVisitor and the keyval visitor have
three different ideas of how a human could write the value of
a boolean option. Pay homage to the backwards-compatibility
gods and make the new common helper accept all four sets (on/off,
true/false, y/n and yes/no), but remove case-insen
From: Peter Maydell
In ahci_exec() we attempt to permit the caller to pass a NULL pointer
for opts_in (in which case we use a default set of options). However
although we check for NULL when setting up the opts variable at the
top of the function, we unconditionally dereference opts_in at the
en
From: Alexander Bulekov
https://bugs.launchpad.net/qemu/+bug/1878642
Suggested-by: Paolo Bonzini
Signed-off-by: Alexander Bulekov
Message-Id: <20201102163336.115444-1-alx...@bu.edu>
Signed-off-by: Paolo Bonzini
---
tests/qtest/fuzz-test.c | 15 +++
1 file changed, 15 insertions(+
From: Alexander Bulekov
The code did not add offsets to FlatRange bases, so we did not fuzz
offsets within device MemoryRegions.
Signed-off-by: Alexander Bulekov
Reviewed-by: Darren Kenny
Message-Id: <20201029172901.534442-4-alx...@bu.edu>
Signed-off-by: Paolo Bonzini
---
tests/qtest/fuzz/ge
This QemuOpts idiom will be deprecated, so get rid of it in the tests.
Signed-off-by: Paolo Bonzini
---
tests/qtest/ivshmem-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-test.c
index d5c8b9f128..dfa69424ed 100644
--- a
qemu_semihosting_console_init uses semihosting.chardev which is set
by qemu_semihosting_connect_chardevs. Thus qemu_semihosting_connect_chardevs
has to be called first.
Both have to be called after processing -serial and friends though, so
that the semihosting console can connect to a multiplexer
The following changes since commit 8507c9d5c9a62de2a0e281b640f995e26eac46af:
Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
(2020-11-03 15:59:44 +)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you
From: Elena Afanasova
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Elena Afanasova
Message-Id: <20201017210102.26036-1-eafanas...@gmail.com>
Signed-off-by: Stefan Hajnoczi
---
accel/kvm/kvm-all.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/
From: Philippe Mathieu-Daudé
The "block/nvme.h" header is shared by both the NVMe block
driver and the NVMe emulated device. Add the 'F:' entry on
both sections, so all maintainers/reviewers are notified
when it is changed.
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Stefan Hajnoczi
R
From: AlexChen
In qos_build_main_args(), the pointer 'path' is dereferenced before
checking it is valid, which may lead to NULL pointer dereference.
So move the assignment to 'cmd_line' after checking 'path' is valid.
Reported-by: Euler Robot
Signed-off-by: Alex Chen
Message-Id: <5fa16ed5.4000
From: Elena Afanasova
Eventfd can be registered with a zero length when fast_mmio is true.
Handle this case properly when dispatching through QEMU.
Signed-off-by: Elena Afanasova
Message-id: cf71a62eb04e61932ff8ffdd02e0b2aab4f495a0.ca...@gmail.com
Signed-off-by: Stefan Hajnoczi
---
softmmu/me
From: Philippe Mathieu-Daudé
Use the same format used for the hw/vfio/ trace events.
Suggested-by: Eric Auger
Reviewed-by: Eric Auger
Reviewed-by: Stefan Hajnoczi
Tested-by: Eric Auger
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20201029093306.1063879-3-phi...@redhat.com
Signed-off-by
From: Philippe Mathieu-Daudé
What we want to trace is the block driver state and the queue index.
Suggested-by: Stefan Hajnoczi
Reviewed-by: Eric Auger
Reviewed-by: Stefan Hajnoczi
Tested-by: Eric Auger
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20201029093306.1063879-7-phi...@redhat
From: Philippe Mathieu-Daudé
As we want to enable multiple queues, report the event
in each nvme_poll_queue() call, rather than once in
the callback calling nvme_poll_queues().
Reviewed-by: Eric Auger
Reviewed-by: Stefan Hajnoczi
Tested-by: Eric Auger
Signed-off-by: Philippe Mathieu-Daudé
Me
From: Philippe Mathieu-Daudé
Controllers have different capabilities and report them in the
CAP register. We are particularly interested by the page size
limits.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Auger
Tested-by: Eric Auger
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20201
From: Philippe Mathieu-Daudé
To be able to use some definitions in structure declarations,
move them earlier. No logical change.
Reviewed-by: Eric Auger
Reviewed-by: Stefan Hajnoczi
Tested-by: Eric Auger
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20201029093306.1063879-9-phi...@redhat
From: Philippe Mathieu-Daudé
Instead of displaying warning on stderr, use warn_report()
which also displays it on the monitor.
Reviewed-by: Eric Auger
Reviewed-by: Stefan Hajnoczi
Tested-by: Eric Auger
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20201029093306.1063879-4-phi...@redhat.c
From: Philippe Mathieu-Daudé
Reviewed-by: Eric Auger
Reviewed-by: Stefan Hajnoczi
Tested-by: Eric Auger
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20201029093306.1063879-8-phi...@redhat.com
Signed-off-by: Stefan Hajnoczi
Tested-by: Eric Auger
---
block/nvme.c | 3 +++
block/tr
From: Philippe Mathieu-Daudé
We can not have negative queue count/size/index, use unsigned type.
Rename 'nr_queues' as 'queue_count' to match the spec naming.
Reviewed-by: Eric Auger
Reviewed-by: Stefan Hajnoczi
Tested-by: Eric Auger
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20201029
From: Philippe Mathieu-Daudé
Just for consistency, following the example documented since
commit e3fe3988d7 ("error: Document Error API usage rules"),
return a boolean value indicating an error is set or not.
Directly pass errp as the local_err is not requested in our
case.
Tested-by: Eric Auger
From: Philippe Mathieu-Daudé
From the specification chapter 3.1.8 "AQA - Admin Queue Attributes"
the Admin Submission Queue Size field is a 0’s based value:
Admin Submission Queue Size (ASQS):
Defines the size of the Admin Submission Queue in entries.
Enabling a controller while this
From: Philippe Mathieu-Daudé
Rename Submission Queue flags with 'Sq' to differentiate
submission queue flags from command queue flags, and introduce
Completion Queue flag definitions.
Reviewed-by: Eric Auger
Tested-by: Eric Auger
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Hajno
From: Philippe Mathieu-Daudé
Replace magic values by definitions, and simplifiy since the
number of queues will never reach 64K.
Reviewed-by: Eric Auger
Reviewed-by: Stefan Hajnoczi
Tested-by: Eric Auger
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20201029093306.1063879-14-phi...@redha
From: Philippe Mathieu-Daudé
Just for consistency, following the example documented since
commit e3fe3988d7 ("error: Document Error API usage rules"),
return a boolean value indicating an error is set or not.
Directly pass errp as the local_err is not requested in our
case. This simplifies a bit
From: Philippe Mathieu-Daudé
Commit bdd6a90a9e5 ("block: Add VFIO based NVMe driver")
sets the request_alignment in nvme_refresh_limits().
For consistency, also set it during initialization.
Reported-by: Stefan Hajnoczi
Reviewed-by: Eric Auger
Reviewed-by: Stefan Hajnoczi
Tested-by: Eric Auge
From: Philippe Mathieu-Daudé
We don't need to dereference from BDRVNVMeState each time.
Use a NVMeQueuePair pointer on the admin queue.
The nvme_init() becomes easier to review, matching the style
of nvme_add_io_queue().
Reviewed-by: Eric Auger
Reviewed-by: Stefan Hajnoczi
Tested-by: Eric Auge
From: Philippe Mathieu-Daudé
While trying to simplify the code using a macro, we forgot
the 12-bit shift... Correct that.
Fixes: fad1eb68862 ("block/nvme: Use register definitions from 'block/nvme.h'")
Reported-by: Eric Auger
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Auger
Tested-by: Eri
From: Eric Auger
In preparation of 64kB host page support, let's change the size
and alignment of the queue so that the VFIO DMA MAP succeeds.
We align on the host page size.
Signed-off-by: Eric Auger
Reviewed-by: Stefan Hajnoczi
Tested-by: Eric Auger
Signed-off-by: Philippe Mathieu-Daudé
Me
From: Eric Auger
In preparation of 64kB host page support, let's change the size
and alignment of the IDENTIFY command response buffer so that
the VFIO DMA MAP succeeds. We align on the host page size.
Signed-off-by: Eric Auger
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Hajnoczi
From: Philippe Mathieu-Daudé
As all commands use the ADMIN queue, it is pointless to pass
it as argument each time. Remove the argument, and rename the
function as nvme_admin_cmd_sync() to make this new behavior
clearer.
Reviewed-by: Eric Auger
Tested-by: Eric Auger
Signed-off-by: Philippe Mat
From: Eric Auger
In preparation of 64kB host page support, let's change the size
and alignment of the prp_list_pages so that the VFIO DMA MAP succeeds
with 64kB host page size. We align on the host page size.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Eric Auger
Reviewed-by: Stefan Haj
On 201104 1600, P J P wrote:
> +-- On Thu, 22 Oct 2020, Daniel P. Berrangé wrote --+
> | On Thu, Oct 22, 2020 at 12:24:16PM -0400, Alexander Bulekov wrote:
> | > > Once [2] lands upstream, we should see a significant uptick in oss-fuzz
> | > > reports, and I hope that we can develop a process to
From: Philippe Mathieu-Daudé
The Completion Queue Command Identifier is a 16-bit value,
so nvme_submit_command() is unlikely to work on big-endian
hosts, as the relevant bits are truncated.
Fix by using the correct byte-swap function.
Fixes: bdd6a90a9e5 ("block: Add VFIO based NVMe driver")
Repo
From: Philippe Mathieu-Daudé
Change the confuse "VFIO IOMMU check failed" error message by
the explicit "VFIO IOMMU Type1 is not supported" once.
Example on POWER:
$ qemu-system-ppc64 -drive
if=none,id=nvme0,file=nvme://0001:01:00.0/1,format=raw
qemu-system-ppc64: -drive
if=none,id=nvme0,fi
From: Eric Auger
Make sure iov's va and size are properly aligned on the
host page size.
Signed-off-by: Eric Auger
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Hajnoczi
Tested-by: Eric Auger
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20201029093306.1063879-23-phi...@redhat
From: Philippe Mathieu-Daudé
For debug purpose, trace BAR regions info.
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20201103020733.2303148-4-phi...@redhat.com
Signed-off-by: Stefan Hajnoczi
Tested-by: Eric Auger
---
util/vfio-helper
From: Philippe Mathieu-Daudé
We sometime get kernel panic with some devices on Aarch64
hosts. Alex Williamson suggests it might be broken PCIe
root complex. Add trace event to record the latest I/O
access before crashing. In case, assert our accesses are
aligned.
Reviewed-by: Fam Zheng
Reviewed
Am 04.11.2020 um 15:05 hat Daniel P. Berrangé geschrieben:
> Update some docs and test cases to use 'on' | 'off' as the preferred
> value for bool options.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/system/vnc-security.rst | 6 +++---
> include/authz/listfile.h | 2 +-
> qemu-optio
From: Philippe Mathieu-Daudé
qemu_vfio_pci_map_bar() calls mmap(), and mmap(2) states:
'offset' must be a multiple of the page size as returned
by sysconf(_SC_PAGE_SIZE).
In commit f68453237b9 we started to use an offset of 4K which
broke this contract on Aarch64 arch.
Fix by mapping at o
From: Philippe Mathieu-Daudé
For debugging purpose, trace where DMA regions are mapped.
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20201103020733.2303148-6-phi...@redhat.com
Signed-off-by: Stefan Hajnoczi
Tested-by: Eric Auger
---
From: Philippe Mathieu-Daudé
For debugging purpose, trace where a BAR is mapped.
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20201103020733.2303148-5-phi...@redhat.com
Signed-off-by: Stefan Hajnoczi
Tested-by: Eric Auger
---
util/vf
From: Philippe Mathieu-Daudé
mmap(2) states:
'offset' must be a multiple of the page size as returned
by sysconf(_SC_PAGE_SIZE).
Add an assertion to be sure we don't break this contract.
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20201103020733.2303148-8-phi...@redhat.com
Signed-o
From: Philippe Mathieu-Daudé
The QEMU_VFIO_DEBUG definition is only modifiable at build-time.
Trace events can be enabled at run-time. As we prefer the latter,
convert qemu_vfio_dump_mappings() to use trace events instead
of fprintf().
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed
The following changes since commit 3d6e32347a3b57dac7f469a07c5f520e69bd070a:
Update version for v5.2.0-rc0 release (2020-11-03 21:11:57 +)
are available in the Git repository at:
git://git.kraxel.org/qemu tags/fixes-20201104-pull-request
for you to fetch changes up to
From: Prasad J Pandit
The source and destination x,y display parameters in ati_2d_blt()
may run off the vga limits if either of s->regs.[src|dst]_[xy] is
zero. Check the parameter values to avoid potential crash.
Reported-by: Gaoning Pan
Signed-off-by: Prasad J Pandit
Message-id: 2020102110381
On Wed, 4 Nov 2020 at 15:26, Alexander Bulekov wrote:
> If I understand correctly, this is analogous to what happens with
> Coverity reports. Access to Coverity is closed (not sure if there is a
> process to apply for access). It also seems that there is a push to fix
> CID issues prior to new rel
From: Bruce Rogers
Adding qboot to the .PHONY directive will allow a
make -C roms qboot invocation to work as expected
Signed-off-by: Bruce Rogers
Message-id: 20201020152512.837769-1-brog...@suse.com
Signed-off-by: Gerd Hoffmann
---
roms/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 dele
From: Ding Hui
When we connect to vnc by websocket channel, and disconnect
(maybe by some network exception) before handshake,
qemu will left CLOSE_WAIT socket and never close it
After 04d2529da2 ("ui: convert VNC server to use QIOChannelSocket")
and dd154c4d9f ("io: fix handling of EOF / error
Ping ...
On Sat, Oct 31, 2020 at 9:51 PM Ani Sinha wrote:
> On Thu, Oct 15, 2020 at 10:22 PM Eduardo Habkost
> wrote:
> >
> > On Mon, Sep 21, 2020 at 03:03:25PM +0530, Ani Sinha wrote:
> > > Object property insertion code iterates over an integer to get an
> unused
> > > index that can be used
On Wed, Nov 4, 2020 at 1:13 PM Daniel P. Berrangé
wrote:
> On Wed, Nov 04, 2020 at 01:07:41PM +0200, Yuri Benditovich wrote:
> > On Wed, Nov 4, 2020 at 5:09 AM Jason Wang wrote:
> >
> > >
> > > On 2020/11/3 上午2:51, Andrew Melnychenko wrote:
> > > > From: Andrew
> > > >
> > > > When RSS is enabl
On Sat, Oct 31, 2020 at 09:51:38PM +0530, Ani Sinha wrote:
> On Thu, Oct 15, 2020 at 10:22 PM Eduardo Habkost wrote:
> >
> > On Mon, Sep 21, 2020 at 03:03:25PM +0530, Ani Sinha wrote:
> > > Object property insertion code iterates over an integer to get an unused
> > > index that can be used as an
This series refactor the qdev property code so the static
property system can be used by any QOM type. As an example, at
the end of the series some properties in TYPE_MACHINE are
converted to static properties to demonstrate the new API.
Changes v1 -> v2
* Rename functions and s
Move everything related to Property and PropertyInfo to
qdev-properties.[ch] to make it easier to refactor that code.
Reviewed-by: Marc-André Lureau
Signed-off-by: Eduardo Habkost
---
Cc: Paolo Bonzini
Cc: "Daniel P. Berrangé"
Cc: Eduardo Habkost
Cc: qemu-devel@nongnu.org
---
include/hw/qdev
101 - 200 of 464 matches
Mail list logo
