Re: VFIO Migration

Hi, > > > The hardware interface together with the device state representation is > > > called > > > a *device model*. Device models can be assigned URIs such as > > > https://qemu.org/devices/e1000e to uniquely identify them. > > > > Is that something that needs to be put together for every d

Re: [PATCH for-5.2 3/4] qtest: escape device name in device-introspect-test

I will just drop autofree usage completely, also because valgrind showed that GRegex does not support it and apparently is leaked. Paolo Il mer 4 nov 2020, 08:44 Thomas Huth ha scritto: > On 03/11/2020 16.14, Paolo Bonzini wrote: > > device-introspect-test uses HMP, so it should escape the devi

Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config

Il mer 4 nov 2020, 03:27 Stefano Stabellini ha scritto: > FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I > get: > > ninja: unknown tool 'query' > > Even after rebuilding ninja master by hand. Any ideas? I don't know much > about ninja. > Are you sure you have ninja insta

Re: [PULL 12/12] hw/misc/sifive_u_otp: Add backend drive support

OK, let me do it. I'll send it soon. On Tue, Nov 3, 2020 at 11:53 PM Alistair Francis wrote: > > On Mon, Nov 2, 2020 at 9:49 AM Peter Maydell wrote: > > > > On Fri, 23 Oct 2020 at 16:27, Alistair Francis > > wrote: > > > > > > From: Green Wan > > > > > > Add '-drive' support to OTP device. Al

Re: [PATCH v2] qapi, qemu-options: make all parsing visitors parse boolean options the same

Paolo Bonzini writes: > On 03/11/20 17:25, Daniel P. Berrangé wrote: >>> OptsVisitor, StringInputVisitor and the keyval visitor have >>> three different ideas of how a human could write the value of >>> a boolean option. Pay homage to the backwards-compatibility >>> gods and make the new common

Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config

On 11/4/20 7:21 AM, Thomas Huth wrote: > On 03/11/2020 21.41, Philippe Mathieu-Daudé wrote: >> On 11/3/20 7:43 PM, Thomas Huth wrote: >>> On 03/11/2020 17.46, Philippe Mathieu-Daudé wrote: > [...] diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 3b15ae5c302..6ee098ec53c 100644 ---

[PATCH-for-5.2 v2 0/4] ci: Move --without-default-devices job from Travis to GitLab

We have a job covering the --without-default-devices configure option on Travis-CI, but recommend the community to use GitLab, so build failures are missed. We need help to move the jobs to GitLab (we will keep the s390x and ppc64 containerized jobs on Travis as there is no similar offer on GitLab

[PATCH-for-5.2 v2 2/4] hw/9pfs: Fix Kconfig dependency problem between 9pfs and Xen

Fixes './configure --without-default-devices --enable-xen' build: /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common': hw/xen/xen-legacy-backend.c:754: undefined reference to `xen_9pfs_ops' /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.r

[PATCH-for-5.2 v2 1/4] s390x: fix build for --without-default-devices

From: Cornelia Huck s390-pci-vfio.c calls into the vfio code, so we need it to be built conditionally on vfio (which implies CONFIG_LINUX). Reported-by: Philippe Mathieu-Daudé Fixes: cd7498d07fbb ("s390x/pci: Add routine to get the vfio dma available count") Signed-off-by: Cornelia Huck Messa

[PATCH-for-5.2 v2 3/4] gitlab-ci: Add a job to cover the --without-default-devices config

We test './configure --without-default-devices' since commit 20885b5b169 (".travis.yml: test that no-default-device builds do not regress") in Travis-CI. Since having a single CI to look at is easier, and GitLab-CI is the preferred one, add the equivalent job there. As smoke test, run the qtests

Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config

On 11/3/20 10:12 PM, Paolo Bonzini wrote: > On 03/11/20 22:07, Philippe Mathieu-Daudé wrote: >>> diff --git a/accel/Kconfig b/accel/Kconfig >>> index 2ad94a3839..d24664d736 100644 >>> --- a/accel/Kconfig >>> +++ b/accel/Kconfig >>> @@ -7,3 +7,4 @@ config KVM >>>   config XEN >>>   bool >>>

[PATCH-for-5.2 v2 4/4] travis-ci: Remove the --without-default-devices job

We replicated the --without-default-devices job on GitLab-CI in the previous commit. We can now remove it from Travis-CI. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 8 1 file changed, 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index a3d

Re: [PATCH for-5.2 1/4] ivshmem-test: do not use short-form boolean option

Paolo Bonzini writes: > This QemuOpts idiom will be deprecated, so get rid of it in the tests. > > Signed-off-by: Paolo Bonzini > --- > tests/qtest/ivshmem-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-test.c > i

Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config

On 04/11/2020 09.32, Philippe Mathieu-Daudé wrote: > On 11/4/20 7:21 AM, Thomas Huth wrote: >> On 03/11/2020 21.41, Philippe Mathieu-Daudé wrote: >>> On 11/3/20 7:43 PM, Thomas Huth wrote: On 03/11/2020 17.46, Philippe Mathieu-Daudé wrote: >> [...] > diff --git a/.gitlab-ci.yml b/.gitlab-c

Re: [PATCH-for-5.2 v2 3/4] gitlab-ci: Add a job to cover the --without-default-devices config

On 04/11/2020 09.43, Philippe Mathieu-Daudé wrote: > We test './configure --without-default-devices' since commit > 20885b5b169 (".travis.yml: test that no-default-device builds > do not regress") in Travis-CI. > > Since having a single CI to look at is easier, and GitLab-CI > is the preferred one

[PATCH] hw/misc/sifive_u_otp: handling the fails of blk_pread and blk_pwrite

Fix code coverage issues by checking return value and handling fail case of blk_pread() and blk_pwrite(). Return default value 0xff if read fails. Signed-off-by: Green Wan --- hw/misc/sifive_u_otp.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --gi

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

On Wed, Nov 04, 2020 at 10:07:52AM +0800, Jason Wang wrote: > > On 2020/11/3 下午6:32, Yuri Benditovich wrote: > > > > > > On Tue, Nov 3, 2020 at 11:02 AM Jason Wang > > wrote: > > > > > > On 2020/11/3 上午2:51, Andrew Melnychenko wrote: > > > Basic idea is to

Re: [PULL 18/30] hw/block/nvme: update nsid when registered

On 27.10.20 11:49, Klaus Jensen wrote: > From: Klaus Jensen > > If the user does not specify an nsid parameter on the nvme-ns device, > nvme_register_namespace will find the first free namespace id and assign > that. > > This fix makes sure the assigned id is saved. > > Signed-off-by: Klaus Jen

[PATCH 1/2] MAINTAINERS: Cover exec-vary.c (variable page size)

Add exec-vary.c to the 'Overall TCG CPUs' section. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index dd16606bcdc..466898d3dbd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -117,6 +117,7 @@ R: Paolo Bonzini

Re: [RFC PATCH 1/6] net: Added SetSteeringEBPF method for NetClientState.

On Wed, Nov 4, 2020 at 4:49 AM Jason Wang wrote: > > On 2020/11/3 上午2:51, Andrew Melnychenko wrote: > > From: Andrew > > > > For now, that method supported only by Linux TAP. > > Linux TAP uses TUNSETSTEERINGEBPF ioctl. > > TUNSETSTEERINGBPF was added 3 years ago. > > Qemu checks if it was defin

[PATCH 0/2] exec: Ensure variable page size is only used with TARGET_PAGE_BITS_VARY

Simple patch while trying to figure out Fuloong-2E 16KB page size. Better safe than sorry =) Philippe Mathieu-Daudé (2): MAINTAINERS: Cover exec-vary.c (variable page size) exec: Ensure variable page size is only used with TARGET_PAGE_BITS_VARY include/qemu-common.h | 4 +++- exec-vary.c

[PATCH 2/2] exec: Ensure variable page size is only used with TARGET_PAGE_BITS_VARY

If TARGET_PAGE_BITS_VARY is not supported, machines should not intent to modify the target page size. As set_preferred_target_page_bits() is supposed to return 'false' on failure (documented in "qemu-common.h"), return false to indicate failure if this ever happens. Signed-off-by: Philippe Mathieu

Re: [PATCH-for-5.2 v2 2/4] hw/9pfs: Fix Kconfig dependency problem between 9pfs and Xen

On Wed, 4 Nov 2020 09:43:25 +0100 Philippe Mathieu-Daudé wrote: > Fixes './configure --without-default-devices --enable-xen' build: > > /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function > `xen_be_register_common': > hw/xen/xen-legacy-backend.c:754: undefined reference

Re: [PULL 12/30] hw/block/nvme: add support for scatter gather lists

On 27.10.20 11:49, Klaus Jensen wrote: > From: Klaus Jensen > > For now, support the Data Block, Segment and Last Segment descriptor > types. > > See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)"). > > Signed-off-by: Klaus Jensen > Reviewed-by: Keith Busch > --- > include/block/

Re: [qemu-web PATCH] Add virtio-fs in OSv overview blog post

On 04/11/2020 01.42, Fotis Xenakis wrote: > This post briefly goes over the main points of virtio-fs and OSv, a > unikernel running under QEMU/KVM and taking advantage of its virtio-fs > implementation. > > Feel free to review, I will be more than happy to address any comments. Thanks, articles f

Re: [PATCH v2 00/11] qapi: static typing conversion, pt2

Hi On Mon, Nov 2, 2020 at 7:41 PM John Snow wrote: > On 10/26/20 3:42 PM, John Snow wrote: > > Hi, this series adds static type hints to the QAPI module. > > This is part two, and covers introspect.py. > > > > Part 2: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt2 > > Everything: h

Re: [PULL 18/30] hw/block/nvme: update nsid when registered

On Nov 4 10:32, Max Reitz wrote: > On 27.10.20 11:49, Klaus Jensen wrote: > > From: Klaus Jensen > > > > If the user does not specify an nsid parameter on the nvme-ns device, > > nvme_register_namespace will find the first free namespace id and assign > > that. > > > > This fix makes sure the a

Re: [PULL 48/48] hw/timer/armv7m_systick: Rewrite to use ptimers

On Tue, Oct 27, 2020 at 11:44:38AM +, Peter Maydell wrote: > The armv7m systick timer is a 24-bit decrementing, wrap-on-zero, > clear-on-write counter. Our current implementation has various > bugs and dubious workarounds in it (for instance see > https://bugs.launchpad.net/qemu/+bug/1872237).

Re: [PULL 15/30] hw/block/nvme: support multiple namespaces

On 27.10.20 11:49, Klaus Jensen wrote: > From: Klaus Jensen > > This adds support for multiple namespaces by introducing a new 'nvme-ns' > device model. The nvme device creates a bus named from the device name > ('id'). The nvme-ns devices then connect to this and registers > themselves with the

Re: [PULL 48/48] hw/timer/armv7m_systick: Rewrite to use ptimers

On 11/4/20 11:03 AM, Andrew Jones wrote: > On Tue, Oct 27, 2020 at 11:44:38AM +, Peter Maydell wrote: >> The armv7m systick timer is a 24-bit decrementing, wrap-on-zero, >> clear-on-write counter. Our current implementation has various >> bugs and dubious workarounds in it (for instance see >>

Re: VFIO Migration

* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Tue, Nov 03, 2020 at 06:49:51PM +, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > On Tue, Nov 03, 2020 at 12:17:09PM +, Dr. David Alan Gilbert wrote: > > > > * Stefan Hajnoczi (stefa...@redhat.com) w

Re: [PATCH] target/microblaze: Fix possible array out of bounds in mmu_write()

On 03/11/2020 08.46, AlexChen wrote: > The size of env->mmu.regs is 3, but the range of 'rn' is [0, 5]. > To avoid data access out of bounds, only if 'rn' is less than 3, we > can print env->mmu.regs[rn]. In other cases, we can print > env->mmu.regs[MMU_R_TLBX]. ... since env->mmu.regs[MMU_R_TLBX]

[PATCH 1/4] bsd-user: space required after semicolon

This patch fixes error style problems found by checkpatch.pl: ERROR: space required after that ';' Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 2 +- bsd-user/syscall.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index 9

[PATCH 4/4] bsd-user: suspect code indent for conditional statements

This patch fixes error style problems found by checkpatch.pl: ERROR: suspect code indent for conditional statements Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 10 +- bsd-user/main.c| 4 ++-- bsd-user/syscall.c | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff

[PATCH] ssi: Fix bad printf format specifiers

We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen --- hw/ssi/imx_spi.c| 2 +- hw/ssi/xilinx_spi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ssi/imx_spi.c b/hw/ssi/

[PATCH 2/4] bsd-user: do not use C99 // comments

This patch fixes error style problems found by checkpatch.pl: ERROR: do not use C99 // comments Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index 25e625d86b..30d2d6b7a1 100644 --

[PATCH for-5.2 1/3] hw/block/nvme: fix null ns in register namespace

From: Klaus Jensen Fix dereference after NULL check. Reported-by: Coverity (CID 1436128) Fixes: b20804946bce ("hw/block/nvme: update nsid when registered") Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/block/nvme.c b/hw

[PATCH 3/4] bsd-user: "foo * bar" should be "foo *bar"

This patch fixes error style problems found by checkpatch.pl: ERROR: "foo ** bar" should be "foo **bar". ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Liyang Shi --- bsd-user/bsdload.c | 6 +++--- bsd-user/elfload.c | 22 +++--- bsd-user/qemu.h| 14 +++---

[PATCH] qtest: Fix bad printf format specifiers

We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen --- tests/qtest/arm-cpu-features.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qtest/arm-cpu-features.c b/tests

[PATCH for-5.2 0/3] hw/block/nvme: coverity fixes

From: Klaus Jensen Fix three issues reported by coverity (CIDs 1436128, 1436129 and 1436131). Klaus Jensen (3): hw/block/nvme: fix null ns in register namespace hw/block/nvme: fix uint16_t use of uint32_t sgls member hw/block/nvme: fix free of array-typed value hw/block/nvme.c | 6 ++

[PATCH for-5.2 2/3] hw/block/nvme: fix uint16_t use of uint32_t sgls member

From: Klaus Jensen nvme_map_sgl_data erroneously uses the sgls member of NvmeIdNs as a uint16_t. Reported-by: Coverity (CID 1436129) Fixes: cba0a8a344fe ("hw/block/nvme: add support for scatter gather lists") Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+

Re: [PULL v2 00/38] pc,pci,vhost,virtio: fixes

On Wed, 4 Nov 2020 at 04:50, Michael S. Tsirkin wrote: > > Sending v2 since v1 was borken on 32 bit. > > The following changes since commit c7a7a877b716cf14848f1fd5c754d293e2f8d852: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20201102' into staging (2020-11-03 > 1

[PATCH] hw/arm/Kconfig: ARM_V7M depends on PTIMER

commit 32bd322a0134 ("hw/timer/armv7m_systick: Rewrite to use ptimers") changed armv7m_systick to build on ptimers. Make sure we have ptimers in the build when building armv7m_systick. Signed-off-by: Andrew Jones --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconf

Re: [PATCH] hw/arm/Kconfig: ARM_V7M depends on PTIMER

On 11/4/20 11:33 AM, Andrew Jones wrote: > commit 32bd322a0134 ("hw/timer/armv7m_systick: Rewrite to use ptimers") > changed armv7m_systick to build on ptimers. Make sure we have ptimers > in the build when building armv7m_systick. > > Signed-off-by: Andrew Jones > --- > hw/arm/Kconfig | 1 + >

[PATCH for-5.2 3/3] hw/block/nvme: fix free of array-typed value

From: Klaus Jensen Since 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces"), the namespaces member of NvmeCtrl is no longer a dynamically allocated array. Remove the free. Fixes: 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces") Reported-by: Coverity (CID 1436131) Signed-off-b

[Bug 1901981] Re: assert issue locates in hw/usb/dev-storage.c:248: usb_msd_send_status

poc doens't run on fedora: uhci: common.c:59: gva_to_gpa: Assertion `gfn != -1' failed. Can you build qemu with DEBUG_MSD enabled (see hw/usb/dev-storage.c), then attach both stderr log and stacktrace? thanks. -- You received this bug notification because you are a member of qemu- devel-ml, whi

Re: [PATCH] target/openrisc: Remove dead code attempting to check "is timer disabled"

On Wed, 4 Nov 2020 at 07:10, Stafford Horne wrote: > > On Tue, Nov 03, 2020 at 11:46:54AM +, Peter Maydell wrote: > > In the mtspr helper we attempt to check for "is the timer disabled" > > with "if (env->ttmr & TIMER_NONE)". This is wrong because TIMER_NONE > > is zero and the condition is a

[PATCH] contrib/libvhost-user: Fix bad printf format specifiers

We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen --- contrib/libvhost-user/libvhost-user.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/contrib/libv

Re: [PULL 48/48] hw/timer/armv7m_systick: Rewrite to use ptimers

On Wed, Nov 04, 2020 at 11:11:53AM +0100, Philippe Mathieu-Daudé wrote: > On 11/4/20 11:03 AM, Andrew Jones wrote: > > On Tue, Oct 27, 2020 at 11:44:38AM +, Peter Maydell wrote: > >> The armv7m systick timer is a 24-bit decrementing, wrap-on-zero, > >> clear-on-write counter. Our current implem

Re: Ramping up Continuous Fuzzing of Virtual Devices in QEMU

+-- On Thu, 22 Oct 2020, Daniel P. Berrangé wrote --+ | On Thu, Oct 22, 2020 at 12:24:16PM -0400, Alexander Bulekov wrote: | > > Once [2] lands upstream, we should see a significant uptick in oss-fuzz | > > reports, and I hope that we can develop a process to ensure these bugs | > > are properly

Re: Debugging with rr

On Wed, 4 Nov 2020 at 06:11, Sai Pavan Boddu wrote: > I tired debugging QEMU with rr version 4.1.0, on ubuntu 16.04. And I see > below errors, any suggestions on the issue would be helpful rr version 4.1.0 is pretty old -- it was released in 2016. QEMU does some complicated stuff that in the pas

Re: [PATCH] qtest: Fix bad printf format specifiers

On 04/11/2020 11.23, AlexChen wrote: > We should use printf format specifier "%u" instead of "%d" for > argument of type "unsigned int". > > Reported-by: Euler Robot > Signed-off-by: Alex Chen > --- > tests/qtest/arm-cpu-features.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [PATCH for-5.2 3/3] hw/block/nvme: fix free of array-typed value

On 11/4/20 11:22 AM, Klaus Jensen wrote: > From: Klaus Jensen > > Since 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces"), the > namespaces member of NvmeCtrl is no longer a dynamically allocated > array. Remove the free. > > Fixes: 7f0f1acedf15 ("hw/block/nvme: support multiple namesp

Re: [QEMU] Question regarding user mode support for ARM syscalls

Hi Alistair, > On Tue, Nov 3, 2020 at 8:55 AM Lukasz Majewski wrote: > > > > Hi Alistair, > > > > > On Tue, Nov 3, 2020 at 3:03 AM Lukasz Majewski > > > wrote: > > > > > > > > Dear Qemu Community, > > > > > > Hey Lukasz, > > > > > > + QEMU Dev Mailing list > > > + Laurent > > > > > > > T

Re: [PATCH] hw/9pfs: virtio-9p: Ensure config space is a multiple of 4 bytes

On Mittwoch, 4. November 2020 08:44:44 CET Bin Meng wrote: > Hi Michael, > > On Tue, Nov 3, 2020 at 8:05 PM Michael S. Tsirkin wrote: > > On Tue, Nov 03, 2020 at 02:26:10PM +0800, Bin Meng wrote: > > > Hi Michael, > > > > > > On Fri, Oct 30, 2020 at 5:29 PM Michael S. Tsirkin wrote: > > > > On

Re: [PATCH for-5.2 1/3] hw/block/nvme: fix null ns in register namespace

On 04.11.20 11:22, Klaus Jensen wrote: > From: Klaus Jensen > > Fix dereference after NULL check. > > Reported-by: Coverity (CID 1436128) > Fixes: b20804946bce ("hw/block/nvme: update nsid when registered") > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 3 +-- > 1 file changed, 1 inse

Re: [PATCH for-5.2 3/3] hw/block/nvme: fix free of array-typed value

On 04.11.20 11:22, Klaus Jensen wrote: > From: Klaus Jensen > > Since 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces"), the > namespaces member of NvmeCtrl is no longer a dynamically allocated > array. Remove the free. > > Fixes: 7f0f1acedf15 ("hw/block/nvme: support multiple namespac

Re: [PATCH for-5.2 2/3] hw/block/nvme: fix uint16_t use of uint32_t sgls member

On 04.11.20 11:22, Klaus Jensen wrote: > From: Klaus Jensen > > nvme_map_sgl_data erroneously uses the sgls member of NvmeIdNs as a > uint16_t. > > Reported-by: Coverity (CID 1436129) > Fixes: cba0a8a344fe ("hw/block/nvme: add support for scatter gather lists") > Signed-off-by: Klaus Jensen > -

Re: [PATCH for-5.2 4/4] qemu-option: warn for short-form boolean options

On Tue, 3 Nov 2020 22:41:40 +0100 Paolo Bonzini wrote: > On 03/11/20 22:22, Igor Mammedov wrote: > > shall we also deprecate short forms for -cpu model,[feat|+feat|-feat] > > and in the end allow only -device compatible form i.e. -cpu > > type,feat=[on|off] > > > > that would let us drop custom

Re: [PATCH for-5.2 3/3] hw/block/nvme: fix free of array-typed value

On Nov 4 11:59, Max Reitz wrote: > On 04.11.20 11:22, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Since 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces"), the > > namespaces member of NvmeCtrl is no longer a dynamically allocated > > array. Remove the free. > > > > Fixes: 7f0f1

[Bug 1901981] Re: assert issue locates in hw/usb/dev-storage.c:248: usb_msd_send_status

Sorry, my reproduced environment is as follows: Host: ubuntu 18.04 Guest: ubuntu 18.04 Stderr log is as follows: usb-msd: Reset usb-msd: Command on LUN 0 usb-msd: Command tag 0x0 flags len 0 data 0 [scsi.0 id=0] INQUIRY 0x00 0x00 0x00 0x01 0x00 - from-dev len=1 usb-msd: Deferring

Re: [RFC PATCH 5/6] virtio-net: Added eBPF RSS to virtio-net.

On Wed, Nov 4, 2020 at 5:09 AM Jason Wang wrote: > > On 2020/11/3 上午2:51, Andrew Melnychenko wrote: > > From: Andrew > > > > When RSS is enabled the device tries to load the eBPF program > > to select RX virtqueue in the TUN. If eBPF can be loaded > > the RSS will function also with vhost (works

Re: [PATCH 1/4] bsd-user: space required after semicolon

On 04/11/2020 11.20, shiliyang wrote: > This patch fixes error style problems found by checkpatch.pl: > ERROR: space required after that ';' > > Signed-off-by: Liyang Shi > > --- > bsd-user/elfload.c | 2 +- > bsd-user/syscall.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >

Re: VFIO Migration

> On 3 Nov 2020, at 19:49, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com ) wrote: >> On Tue, Nov 03, 2020 at 12:17:09PM +, Dr. David Alan Gilbert wrote: >>> * Stefan Hajnoczi (stefa...@redhat.com) wrote: Device Models

Re: [PATCH for-5.2 3/3] hw/block/nvme: fix free of array-typed value

On 04.11.20 12:04, Klaus Jensen wrote: > On Nov 4 11:59, Max Reitz wrote: >> On 04.11.20 11:22, Klaus Jensen wrote: >>> From: Klaus Jensen >>> >>> Since 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces"), the >>> namespaces member of NvmeCtrl is no longer a dynamically allocated >>> arra

Re: VFIO Migration

On Tue, Nov 03, 2020 at 04:23:43PM +0100, Christophe de Dinechin wrote: > On 2020-11-02 at 12:11 CET, Stefan Hajnoczi wrote... > > There is discussion about VFIO migration in the "Re: Out-of-Process > > Device Emulation session at KVM Forum 2020" thread. The current status > > is that Kirti propose

Re: [PATCH for-5.2 1/3] hw/block/nvme: fix null ns in register namespace

On 11/4/20 11:22 AM, Klaus Jensen wrote: > From: Klaus Jensen > > Fix dereference after NULL check. > > Reported-by: Coverity (CID 1436128) > Fixes: b20804946bce ("hw/block/nvme: update nsid when registered") > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 3 +-- > 1 file changed, 1 in

Re: VFIO Migration

On Tue, Nov 03, 2020 at 10:31:35AM -0700, Alex Williamson wrote: > On Tue, 3 Nov 2020 15:33:56 + > Daniel P. Berrangé wrote: > > > On Tue, Nov 03, 2020 at 04:23:43PM +0100, Christophe de Dinechin wrote: > > > > > > On 2020-11-02 at 12:11 CET, Stefan Hajnoczi wrote... > > > > There is discu

Re: [PATCH-for-5.2? 3/5] tests/acceptance: Skip incomplete virtio_version tests using '@skip'

On 02/11/2020 15.42, Philippe Mathieu-Daudé wrote: > Prefer skipping incomplete tests with the "@skip" keyword, > rather than commenting the code. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/virtio_version.py | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions

Re: [PATCH for-5.2 0/3] hw/block/nvme: coverity fixes

On 04.11.20 11:22, Klaus Jensen wrote: > From: Klaus Jensen > > Fix three issues reported by coverity (CIDs 1436128, 1436129 and > 1436131). > > Klaus Jensen (3): > hw/block/nvme: fix null ns in register namespace > hw/block/nvme: fix uint16_t use of uint32_t sgls member > hw/block/nvme: f

Re: [PATCH for-5.2 2/3] hw/block/nvme: fix uint16_t use of uint32_t sgls member

On 11/4/20 11:22 AM, Klaus Jensen wrote: > From: Klaus Jensen > > nvme_map_sgl_data erroneously uses the sgls member of NvmeIdNs as a > uint16_t. > > Reported-by: Coverity (CID 1436129) > Fixes: cba0a8a344fe ("hw/block/nvme: add support for scatter gather lists") > Signed-off-by: Klaus Jensen >

Re: [RFC PATCH 5/6] virtio-net: Added eBPF RSS to virtio-net.

On Wed, Nov 04, 2020 at 01:07:41PM +0200, Yuri Benditovich wrote: > On Wed, Nov 4, 2020 at 5:09 AM Jason Wang wrote: > > > > > On 2020/11/3 上午2:51, Andrew Melnychenko wrote: > > > From: Andrew > > > > > > When RSS is enabled the device tries to load the eBPF program > > > to select RX virtqueue

Re: [PATCH 1/4] bsd-user: space required after semicolon

On 11/4/20 12:08 PM, Thomas Huth wrote: > On 04/11/2020 11.20, shiliyang wrote: >> This patch fixes error style problems found by checkpatch.pl: >> ERROR: space required after that ';' >> >> Signed-off-by: Liyang Shi >> >> --- >> bsd-user/elfload.c | 2 +- >> bsd-user/syscall.c | 4 ++-- >> 2 fil

Re: [PULL 0/6] Mips fixes patches

On Tue, 3 Nov 2020 at 17:33, Philippe Mathieu-Daudé wrote: > > The following changes since commit 83851c7c60c90e9fb6a23ff48076387a77bc33cd: > > Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2020-10-27-v3-ta= > g' into staging (2020-11-03 12:47:58 +) > > are available in the Git

Re: [PATCH-for-5.2? 3/5] tests/acceptance: Skip incomplete virtio_version tests using '@skip'

On 11/4/20 12:13 PM, Thomas Huth wrote: > On 02/11/2020 15.42, Philippe Mathieu-Daudé wrote: >> Prefer skipping incomplete tests with the "@skip" keyword, >> rather than commenting the code. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> tests/acceptance/virtio_version.py | 11 +++

Re: [PATCH-for-5.2 v2 2/4] hw/9pfs: Fix Kconfig dependency problem between 9pfs and Xen

On 04/11/20 09:43, Philippe Mathieu-Daudé wrote: Fixes './configure --without-default-devices --enable-xen' build: /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common': hw/xen/xen-legacy-backend.c:754: undefined reference to `xen_9pfs_ops' /us

Re: [PATCH v2] qapi, qemu-options: make all parsing visitors parse boolean options the same

On 04/11/20 09:29, Markus Armbruster wrote: It only hurts in the odd case of a boolean option becoming on/off/auto or on/off/split. Another argument for deprecating values other than "on" and "off". Unfortunately I'm fairly sure that I've seen yes/no in use. I can buy insta-removal (not de

Re: [PATCH v2] qapi, qemu-options: make all parsing visitors parse boolean options the same

On 04/11/20 08:35, Markus Armbruster wrote: + "boolean (on/off, yes/no, true/false, y/n)"); Recommend to have the error message only mention the preferred form. I like the laconic "'on' or 'off'". It's really all the user needs to know. I went for "boolean (on/off) value".

Re: [PATCH v2] qapi, qemu-options: make all parsing visitors parse boolean options the same

On Wed, Nov 04, 2020 at 12:31:40PM +0100, Paolo Bonzini wrote: > On 04/11/20 09:29, Markus Armbruster wrote: > > > It only hurts in the odd case of a boolean option becoming on/off/auto > > > or on/off/split. > > Another argument for deprecating values other than "on" and "off". > > Unfortunatel

Re: [PATCH] target/openrisc: Remove dead code attempting to check "is timer disabled"

On Wed, Nov 04, 2020 at 10:37:17AM +, Peter Maydell wrote: > On Wed, 4 Nov 2020 at 07:10, Stafford Horne wrote: > > > > On Tue, Nov 03, 2020 at 11:46:54AM +, Peter Maydell wrote: > > > In the mtspr helper we attempt to check for "is the timer disabled" > > > with "if (env->ttmr & TIMER_NON

Re: [PATCH-for-5.2? 3/5] tests/acceptance: Skip incomplete virtio_version tests using '@skip'

On 04/11/2020 12.27, Philippe Mathieu-Daudé wrote: > On 11/4/20 12:13 PM, Thomas Huth wrote: >> On 02/11/2020 15.42, Philippe Mathieu-Daudé wrote: >>> Prefer skipping incomplete tests with the "@skip" keyword, >>> rather than commenting the code. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> -

Re: [PATCH-for-5.2 v2 3/4] gitlab-ci: Add a job to cover the --without-default-devices config

On 11/4/20 10:17 AM, Thomas Huth wrote: > On 04/11/2020 09.43, Philippe Mathieu-Daudé wrote: >> We test './configure --without-default-devices' since commit >> 20885b5b169 (".travis.yml: test that no-default-device builds >> do not regress") in Travis-CI. >> >> Since having a single CI to look at i

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

On Wed, Nov 4, 2020 at 4:08 AM Jason Wang wrote: > > On 2020/11/3 下午6:32, Yuri Benditovich wrote: > > > > > > On Tue, Nov 3, 2020 at 11:02 AM Jason Wang > > wrote: > > > > > > On 2020/11/3 上午2:51, Andrew Melnychenko wrote: > > > Basic idea is to use eBPF to ca

[PATCH] qapi, qemu-options: make all parsing visitors parse boolean options the same

OptsVisitor, StringInputVisitor and the keyval visitor have three different ideas of how a human could write the value of a boolean option. Pay homage to the backwards-compatibility gods and make the new common helper accept all four sets (on/off, true/false, y/n and yes/no), but remove case-insen

[PATCH-for-5.2 v3 1/4] s390x: fix build for --without-default-devices

From: Cornelia Huck s390-pci-vfio.c calls into the vfio code, so we need it to be built conditionally on vfio (which implies CONFIG_LINUX). Reported-by: Philippe Mathieu-Daudé Fixes: cd7498d07fbb ("s390x/pci: Add routine to get the vfio dma available count") Signed-off-by: Cornelia Huck Messa

[PATCH-for-5.2 v3 2/4] hw/9pfs: Fix Kconfig dependency problem between 9pfs and Xen

Commit b2c00bce54c ("meson: convert hw/9pfs, cleanup") introduced CONFIG_9PFS (probably a wrong conflict resolution). This config is not used anywhere. Backends depend on CONFIG_FSDEV_9P which itself depends on CONFIG_VIRTFS. Remove the invalid CONFIG_9PFS and use CONFIG_FSDEV_9P instead, to fix t

[PATCH-for-5.2 v3 0/4] ci: Move --without-default-devices job from Travis to GitLab

We have a job covering the --without-default-devices configure option on Travis-CI, but recommend the community to use GitLab, so build failures are missed. We need help to move the jobs to GitLab (we will keep the s390x and ppc64 containerized jobs on Travis as there is no similar offer on GitLab

[PATCH-for-5.2 v3 3/4] gitlab-ci: Add a job to cover the --without-default-devices config

We test './configure --without-default-devices' since commit 20885b5b169 (".travis.yml: test that no-default-device builds do not regress") in Travis-CI. Since having a single CI to look at is easier, and GitLab-CI is the preferred one, add the equivalent job there. As smoke test, run the qtests

[PATCH-for-5.2 v3 4/4] travis-ci: Remove the --without-default-devices job

We replicated the --without-default-devices job on GitLab-CI in the previous commit. We can now remove it from Travis-CI. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 8 1 file changed, 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index a3d

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

On Wed, Nov 04, 2020 at 01:49:05PM +0200, Yuri Benditovich wrote: > On Wed, Nov 4, 2020 at 4:08 AM Jason Wang wrote: > > > > > On 2020/11/3 下午6:32, Yuri Benditovich wrote: > > > > > > > > > On Tue, Nov 3, 2020 at 11:02 AM Jason Wang > > > wrote: > > > > > > > > >

[PULL 4/8] dev-serial: add trace-events for baud rate and data parameters

From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé Message-id: 20201027150456.24606-5-mark.cave-ayl...@ilande.co.uk Signed-off-by: Gerd Hoffmann --- hw/usb/dev-serial.c | 3 +++ hw/usb/trace-events | 2 ++ 2 files changed,

[PULL 2/8] dev-serial: use USB_SERIAL QOM macro for USBSerialState assignments

From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé Message-id: 20201027150456.24606-3-mark.cave-ayl...@ilande.co.uk Signed-off-by: Gerd Hoffmann --- hw/usb/dev-serial.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletio

[PULL 0/8] Usb 20201104 patches

The following changes since commit 3d6e32347a3b57dac7f469a07c5f520e69bd070a: Update version for v5.2.0-rc0 release (2020-11-03 21:11:57 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20201104-pull-request for you to fetch changes up to

[PULL 8/8] dev-serial: store flow control and xon/xoff characters

From: Mark Cave-Ayland Note that whilst the device does not do anything with these values, they are logged with trace events and stored to allow future implementation. The default flow control is set to none at reset as documented in the Linux ftdi_sio.h header file. Signed-off-by: Mark Cave-Ay

[PULL 3/8] dev-serial: convert from DPRINTF to trace-events

From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé Message-id: 20201027150456.24606-4-mark.cave-ayl...@ilande.co.uk Signed-off-by: Gerd Hoffmann --- hw/usb/dev-serial.c | 28 ++-- hw/usb/trace-events

[PULL 5/8] dev-serial: replace DeviceOutVendor/DeviceInVendor with equivalent macros from usb.h

From: Mark Cave-Ayland The DeviceOutVendor and DeviceInVendor macros can be replaced with their equivalent VendorDeviceOutRequest and VendorDeviceRequest macros from usb.h. Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé Message-id: 20201027150

[PULL 1/8] dev-serial: style changes to improve readability and checkpatch fixes

From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault Message-id: 20201027150456.24606-2-mark.cave-ayl...@ilande.co.uk Signed-off-by: Gerd Hoffmann --- hw/usb/dev-serial.c | 228 1 file changed, 125 insertions(+), 103

[PULL 7/8] dev-serial: add support for setting data_bits in QEMUSerialSetParams

From: Mark Cave-Ayland Also implement the behaviour reported in Linux's ftdi_sio.c whereby if an invalid data_bits value is provided then the hardware defaults to using 8. Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé Message-id: 20201027150

Re: [PATCH for-5.2 2/4] qemu-option: move help handling to get_opt_name_value

Paolo Bonzini writes: > Right now, help options are parsed normally and then checked > specially in opt_validate---but only if coming from > qemu_opts_parse or qemu_opts_parse_noisily, not if coming > from qemu_opt_set. > > Instead, move the check from opt_validate to the common workhorses > of q

[PULL 6/8] dev-serial: add always-plugged property to ensure USB device is always attached

From: Mark Cave-Ayland Some operating systems will generate a new device ID when a USB device is unplugged and then replugged into the USB. If this is done whilst switching between multiple applications over a virtual serial port, the change of device ID requires going back into the OS/applicat

  1   2   3   4   5   >