Re: [PATCH v12 14/14] block: apply COR-filter to block-stream jobs

On 27.10.2020 19:13, Vladimir Sementsov-Ogievskiy wrote: 22.10.2020 21:13, Andrey Shinkevich wrote: This patch completes the series with the COR-filter insertion for block-stream operations. Adding the filter makes it possible for copied regions to be discarded in backing files during the bloc

[PATCH v7 0/3] hw/block/nvme: dulbe and dsm support

From: Klaus Jensen This adds support for the Deallocated or Unwritten Logical Block error recovery feature as well as the Dataset Management command. v7: - Handle negative return value from bdrv_block_status. - bdrv_get_info may not be supported on all block drivers, so do not consider i

[PATCH v7 1/3] hw/block/nvme: add dulbe support

From: Klaus Jensen Add support for reporting the Deallocated or Unwritten Logical Block Error (DULBE). Rely on the block status flags reported by the block layer and consider any block with the BDRV_BLOCK_ZERO flag to be deallocated. Multiple factors affect when a Write Zeroes command result in

Re: [RESEND PATCH 6/9] hw/riscv: microchip_pfsoc: Connect the SYSREG module

On Tue, Oct 27, 2020 at 7:43 AM Bin Meng wrote: > > From: Bin Meng > > Previously SYSREG was created as an unimplemented device. Now that > we have a simple SYSREG module, connect it. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > --- > > hw/riscv/Kconfig

[PATCH v7 3/3] hw/block/nvme: add the dataset management command

From: Klaus Jensen Add support for the Dataset Management command and the Deallocate attribute. Deallocation results in discards being sent to the underlying block device. Whether of not the blocks are actually deallocated is affected by the same factors as Write Zeroes (see previous commit).

[PATCH v7 2/3] nvme: add namespace I/O optimization fields to shared header

From: Klaus Jensen This adds the NPWG, NPWA, NPDG, NPDA and NOWS family of fields to the shared nvme.h header for use by later patches. Signed-off-by: Klaus Jensen Cc: Stefan Hajnoczi Cc: Fam Zheng Reviewed-by: Stefan Hajnoczi --- include/block/nvme.h | 7 ++- 1 file changed, 6 insertio

Re: [PATCH v12 14/14] block: apply COR-filter to block-stream jobs

27.10.2020 20:48, Andrey Shinkevich wrote: On 27.10.2020 19:13, Vladimir Sementsov-Ogievskiy wrote: 22.10.2020 21:13, Andrey Shinkevich wrote: This patch completes the series with the COR-filter insertion for block-stream operations. Adding the filter makes it possible for copied regions to be

[PATCH 09/29] vl: extract various command line validation snippets to a new function

Signed-off-by: Paolo Bonzini --- hw/core/machine.c | 1 + softmmu/vl.c | 78 +++ 2 files changed, 40 insertions(+), 39 deletions(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index d84b84463c..f5e559c493 100644 --- a/hw/core/machine.c +++

[PATCH 05/29] vl: split various early command line options to a separate function

Various options affect the global state of QEMU including the rest of qemu_init, and they need to be called very early. Group them together in a function that is called at the beginning. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 202 --- 1 f

[PATCH 08/29] vl: move prelaunch part of qemu_init to new functions

The final part of qemu_init, starting with the completion of board init, is already relatively clean. Split it out of qemu_init so that qemu_init keeps only the messy parts. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 250 +++ 1 file changed,

[PATCH 11/29] vl: extract various command line desugaring snippets to a new function

Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 40 ++-- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index c2a5ee61f9..6749109b29 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -126,6 +126,7 @@ static const char

[PATCH 10/29] vl: preconfig and loadvm are mutually exclusive

Just like -incoming. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 3316c5534c..c2a5ee61f9 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -124,6 +124,7 @@ static const char *mem_path; sta

[PATCH 04/29] vl: remove bogus check

There is no reason to prevent -preconfig -daemonize. Of course if no monitor is defined there will be no way to start the VM, but that is a user error. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 7f39eb

[PATCH 06/29] vl: move various initialization routines out of qemu_init

Some very simple initialization routines can be nested in existing subsystem-level functions, do that to simplify qemu_init. Signed-off-by: Paolo Bonzini --- hw/core/machine.c | 3 +++ include/hw/qdev-core.h | 8 migration/migration.c | 4 softmmu/qdev-monitor.c | 6 -- s

[PATCH 13/29] vl: load plugins as late as possible

There is no need to load plugins in the middle of default device processing, move -plugin handling just before preconfig is entered. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git

[PATCH 03/29] vl: extract validation of -smp to machine.c

Once smp_parse is done, the validation operates on the MachineState. There is no reason for that code to be in vl.c. Signed-off-by: Paolo Bonzini --- hw/core/machine.c | 23 +++ include/hw/boards.h | 1 + softmmu/vl.c| 20 ++-- 3 files changed, 26 i

[PATCH 01/29] trace: remove argument from trace_init_file

It is not needed, all the callers are just saving what was retrieved from -trace and trace_init_file can retrieve it on its own. Signed-off-by: Paolo Bonzini --- bsd-user/main.c | 6 ++ linux-user/main.c| 6 ++ qemu-img.c

[PATCH 14/29] vl: move semihosting command line fallback to qemu_finish_machine_init

Move more sane parts of the huge qemu_init function out of it. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 53d53ef206..bc85318b23 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -

[PATCH 19/29] vl: separate qemu_create_machine

Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 111 +++ 1 file changed, 59 insertions(+), 52 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 0c390b979e..38ad3cc895 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -133,6 +133,8 @@ static

[PATCH 15/29] vl: extract default devices to separate functions

Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 216 +++ 1 file changed, 114 insertions(+), 102 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index bc85318b23..b627b3138b 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -125,7 +125,9 @@ stat

[PATCH 27/29] remove preconfig state

The preconfig state is only used if -incoming is not specified, which makes the RunState state machine more tricky than it need be. However there is already an equivalent condition which works even with -incoming, namely qdev_hotplug. Use it instead of a separate runstate. Signed-off-by: Paolo B

[PATCH 23/29] vl: move -global check earlier

The check has no effect after both builtin and user-specified devices have been created. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index a46f1b9164..ae2854d8af 100644 --- a/softmmu/vl.c +++ b/so

[PATCH 16/29] vl: move CHECKPOINT_INIT after preconfig

Move CHECKPOINT_INIT right before the machine initialization is completed. Everything before is essentially an extension of command line parsing. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

Re: [PATCH 3/4] char: Flat alternative to overly nested chardev-add arguments

On 10/26/20 5:10 AM, Markus Armbruster wrote: > chardev-add's arguments use an annoying amount of nesting. Example: > > {"execute": "chardev-add", > "arguments": { > "id":"sock0", >"backend": { >"type": "socket", >"data": { >"addr"

[PATCH 17/29] vl: separate qemu_create_early_backends

"Early" backends are created before the machine and can be used as machine options. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 123 +++ 1 file changed, 65 insertions(+), 58 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index ebe3d4688

[PATCH 07/29] vl: extract qemu_init_subsystems

Group a bunch of subsystem initializations that can be done right after command line parsing. Remove initializations that can be done simply as global variable initializers. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 94 1 file changed,

[PATCH 22/29] vl: initialize displays before preconfig loop

Displays should be available before the monitor starts, so that it is possible to use the graphical console to interact with the monitor itself. This patch is quite ugly, but all this is temporary. The double call to qemu_init_displays will go away as soon we can unify machine initialization betw

[PATCH 29/29] vl: allow -incoming defer with -preconfig

Now that there is no RUN_STATE_PRECONFIG anymore that can conflict with RUN_STATE_INMIGRATE, we can allow -incoming defer with -preconfig. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 9866

Re: [PATCH v12 14/14] block: apply COR-filter to block-stream jobs

On 27.10.2020 20:57, Vladimir Sementsov-Ogievskiy wrote: 27.10.2020 20:48, Andrey Shinkevich wrote: On 27.10.2020 19:13, Vladimir Sementsov-Ogievskiy wrote: 22.10.2020 21:13, Andrey Shinkevich wrote: This patch completes the series with the COR-filter insertion for block-stream operations.

[PATCH 02/29] semihosting: fix order of initialization functions

qemu_semihosting_console_init uses semihosting.chardev which is set by qemu_semihosting_connect_chardevs. Thus qemu_semihosting_connect_chardevs has to be called first. Both have to be called after processing -serial and friends though, so that the semihosting console can connect to a multiplexer

[PATCH 12/29] vl: create "-net nic -net user" default earlier

Create it together with other default backends, even though the processing is done later. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 6749109b29..f64f7e 100644 --- a/softm

Re: [PATCH 0/4] qemu-storage-daemon: QAPIfy --chardev the stupid way

On 26/10/20 11:10, Markus Armbruster wrote: > Kevin's "[PATCH v2 0/6] qemu-storage-daemon: QAPIfy --chardev" > involves surgery to the QAPI generator. Some (most?) of it should go > away if we deprecate the "data" wrappers due to simple unions in QMP. > > Do we really need to mess with the code g

[PATCH 24/29] migration, vl: start migration via qmp_migrate_incoming

Make qemu_start_incoming_migration local to migration/migration.c. By using the runstate instead of a separate flag, vl need not do anything to setup deferred incoming migration. qmp_migrate_incoming also does not need the deferred_incoming flag anymore, because "-incoming PROTOCOL" will clear the

[RFC PATCH v2 00/37] cleanup qemu_init and make sense of command line processing

The main improvements with respect to v1 are: - further extraction of various phases of command line processing and VM creation to separate function; - removing the preconfig main_loop: the VM is effectively always starting as if -preconfig was specified, it just executes automatically if not

[PATCH 21/29] vl: separate qemu_resolve_machine_memdev

This is a bit nasty: the machine is storing a string and later resolving it. We probably want to remove the memdev property and instead make this a memory-set command. "-M memdev" can be handled as a legacy option that is special cased by machine_set_property. Signed-off-by: Paolo Bonzini ---

[PATCH 20/29] vl: separate qemu_apply_machine_options

Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 66 +--- 1 file changed, 37 insertions(+), 29 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 38ad3cc895..9a3c92387e 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -2700,6 +2700,41 @@ sta

[PATCH 18/29] vl: separate qemu_create_late_backends

"Late" backends are created after the machine. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 109036c089..0c390b979e 100644 --- a/softmmu/vl

Re: [PATCH V4 1/6] target/riscv: Merge m/vsstatus and m/vsstatush into one uint64_t unit

On 10/26/20 4:55 AM, Yifei Jiang wrote: > -qemu_fprintf(f, " %s " TARGET_FMT_lx "\n", "mstatus ", env->mstatus); > +qemu_fprintf(f, " %s " TARGET_FMT_lx "\n", "mstatus ", > (target_ulong)env->mstatus); This is truncating mstatus to target_ulong, i.e. breaking the output for riscv32. You

[PATCH 28/29] vl: remove separate preconfig main_loop

Move post-preconfig initialization to the x-exit-preconfig. If preconfig is not requested, just exit preconfig mode immediately with the QMP command. As a result, the preconfig loop will run with accel_setup_post and os_setup_post restrictions (xen_restrict, chroot, etc.) already done. Signed-of

[PATCH 26/29] hmp: introduce cmd_available

Combine the RUN_STATE_PRECONFIG and cmd_can_preconfig checks into a single function, to avoid repeating the same expression (or its negation after applying DeMorgan's rule) over and over again. Signed-off-by: Paolo Bonzini --- monitor/hmp.c | 18 ++ 1 file changed, 10 insertions(

[PATCH 25/29] vl: start VM via qmp_cont

Complement the previous patch by starting the VM with a QMP command. Later, the user will be able to do the same, invoking two commands "finish-machine-init" and "cont" instead of "x-exit-preconfig". Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

Re: [PATCH] virtiofsd: Fix the help message of posix lock

* Jiachen Zhang (zhangjiachen.jay...@bytedance.com) wrote: > The commit 88fc107956a5812649e5918e0c092d3f78bb28ad disabled remote > posix locks by default. But the --help message still says it is enabled > by default. So fix it to output no_posix_lock. > > Signed-off-by: Jiachen Zhang Thanks! R

Re: [PATCH v6 11/11] qapi: Use QAPI_LIST_ADD() where possible

On 10/27/20 10:36 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 10/27/20 5:09 AM, Markus Armbruster wrote: >>> Eric Blake writes: >>> Anywhere we create a list of just one item or by prepending items (typically because order doesn't matter), we can use the now-public m

Re: [PATCH 4/4] qemu-storage-daemon: QAPIfy --chardev

On 10/26/20 5:10 AM, Markus Armbruster wrote: > From: Kevin Wolf > > This removes the dependency on QemuOpts from the --chardev option of > the storage daemon. > > Help on option parameters is still wrong. Marked FIXME. > > There are quite a few differences between qemu-system-FOO -chardev, >

Re: [qemu-web PATCH v2 06/16] Rework display of screenshots to use a carousel slider

On 27/10/20 14:20, Daniel P. Berrangé wrote: > We have a number of screenshots to display, with three fitted across the > width of the screen. The screenshots dominate the usage of screen real > estate on the front page, with other relevant information off the bottom > of the page. > > As a step t

Re: [RFC] Using gitlab for upstream qemu repo?

On 27/10/20 14:14, Michael Roth wrote: > My only concern would be what the lag time might be between updates to > qemu-web.git and the actual website update if the mirroring doesn't > right away. Probably not a huge deal but might be good to know what the > upper bound is if we want to verify the u

[PATCH for-6.0 v3 02/20] fuse: Allow exporting BDSs via FUSE

block-export-add type=fuse allows mounting block graph nodes via FUSE on some existing regular file. That file should then appears like a raw disk image, and accesses to it result in accesses to the exported BDS. Right now, we only implement the necessary block export functions to set it up and s

Re: [PATCH V4 1/6] target/riscv: Merge m/vsstatus and m/vsstatush into one uint64_t unit

On Tue, Oct 27, 2020 at 11:47 AM Richard Henderson wrote: > > On 10/26/20 4:55 AM, Yifei Jiang wrote: > > -qemu_fprintf(f, " %s " TARGET_FMT_lx "\n", "mstatus ", env->mstatus); > > +qemu_fprintf(f, " %s " TARGET_FMT_lx "\n", "mstatus ", > > (target_ulong)env->mstatus); > > This is truncat

[PATCH for-6.0 v3 01/20] meson: Detect libfuse

Signed-off-by: Max Reitz --- configure | 7 +++ meson.build | 6 ++ meson_options.txt | 2 ++ 3 files changed, 15 insertions(+) diff --git a/configure b/configure index 83610b0db8..fc315deebe 100755 --- a/configure +++ b/configure @@ -448,6 +448,7 @@ meson="" ninja="" ski

[PATCH for-6.0 v3 08/20] iotests: Do not pipe _make_test_img

Executing _make_test_img as part of a pipe will undo all variable changes it has done. As such, this could not work with FUSE (because we want to remember all of our exports and their qemu instances). Replace the pipe by a temporary file in 071 and 174 (the two tests that can run on FUSE). Signe

[PATCH for-6.0 v3 03/20] fuse: Implement standard FUSE operations

This makes the export actually useful instead of only producing errors whenever it is accessed. Signed-off-by: Max Reitz --- block/export/fuse.c | 242 1 file changed, 242 insertions(+) diff --git a/block/export/fuse.c b/block/export/fuse.c index 055

[PATCH for-6.0 v3 07/20] iotests: Do not needlessly filter _make_test_img

In most cases, _make_test_img does not need a _filter_imgfmt on top. It does that by itself. (The exception is when IMGFMT has been overwritten but TEST_IMG has not. In such cases, we do need a _filter_imgfmt on top to filter the test's original IMGFMT from TEST_IMG.) Signed-off-by: Max Reitz R

[PATCH for-6.0 v3 10/20] iotests/046: Avoid renaming images

This generally does not work on non-file protocols. It is better to create the image with the final name from the start, and most tests do this already. Let 046 follow suit. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- tests/qemu-iotests/046 | 5 +++-- tests/qemu-iotests/046.out |

[PATCH for-6.0 v3 00/20] block/export: Allow exporting BDSs via FUSE

v1: https://lists.nongnu.org/archive/html/qemu-block/2019-12/msg00451.html v2: https://lists.nongnu.org/archive/html/qemu-block/2020-09/msg01611.html Branch: https://github.com/XanClic/qemu.git fuse-exports-v3 Branch: https://git.xanclic.moe/XanClic/qemu.git fuse-exports-v3 Hi, Ever since I fou

[PATCH for-6.0 v3 04/20] fuse: Allow growable exports

These will behave more like normal files in that writes beyond the EOF will automatically grow the export size. As an optimization, keep the RESIZE permission for growable exports so we do not have to take it for every post-EOF write. (This permission is not released when the export is destroyed,

[PATCH for-6.0 v3 13/20] iotests: Restrict some Python tests to file

Most Python tests are restricted to the file protocol (without explicitly saying so), but these are the ones that would break ./check -fuse -qcow2. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- tests/qemu-iotests/206 | 3 ++- tests/qemu-iotests/242 | 3 ++- 2 files changed, 4 insertions(

[PATCH for-6.0 v3 05/20] fuse: (Partially) implement fallocate()

This allows allocating areas after the (old) EOF as part of a growing resize, writing zeroes, and discarding. Signed-off-by: Max Reitz --- block/export/fuse.c | 84 + 1 file changed, 84 insertions(+) diff --git a/block/export/fuse.c b/block/export/fus

[PATCH for-6.0 v3 06/20] fuse: Implement hole detection through lseek

This is a relatively new feature in libfuse (available since 3.8.0, which was released in November 2019), so we have to add a dedicated check whether it is available before making use of it. Signed-off-by: Max Reitz --- configure | 8 - meson.build | 20 block

[PATCH for-6.0 v3 15/20] iotests/287: Clean up subshell test image

287 creates an image in a subshell (thanks to the pipe) to see whether that is possible with compression_type=zstd. If _make_test_img were to modify any global state, this global state would then be lost before we could cleanup the image. When using FUSE as the test protocol, this global state is

[PATCH for-6.0 v3 11/20] iotests: Derive image names from $TEST_IMG

Avoid creating images with custom filenames in $TEST_DIR, because non-file protocols may want to keep $TEST_IMG (and all other test images) in some other directory. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- tests/qemu-iotests/200 | 3 +-- tests/qemu-iotests/200.out | 4 ++-- test

[PATCH for-6.0 v3 09/20] iotests: Use convert -n in some cases

qemu-img convert (without -n) can often be replaced by a combination of _make_test_img + qemu-img convert -n. Doing so allows converting to protocols that do not allow direct file creation, such as FUSE exports. The only problem is that for formats other than qcow2 and qed (qcow1 at least), this m

[PATCH for-6.0 v3 19/20] iotests: Enable fuse for many tests

Many tests (that do not support generic protocols) can run just fine with FUSE-exported images, so allow them to. Note that this is no attempt at being definitely complete. There are some tests that might be modified to run on FUSE, but this patch still skips them. This patch only tries to pick

[PATCH for-6.0 v3 14/20] iotests: Let _make_test_img guess $TEST_IMG_FILE

When most iotests want to create a test image that is named differently from the default $TEST_IMG, they do something like this: TEST_IMG="$TEST_IMG.base" _make_test_img $options This works fine with the "file" protocol, but not so much for anything else: _make_test_img tries to create an ima

[PATCH for-6.0 v3 12/20] iotests/091: Use _cleanup_qemu instad of "wait"

If the test environment has some other child processes running (like a storage daemon that provides a FUSE export), then "wait" will never finish. Use wait=yes _cleanup_qemu instead. (We need to discard the output so there is no change to the reference output.) Signed-off-by: Max Reitz Reviewed

[PATCH for-6.0 v3 20/20] iotests/308: Add test for FUSE exports

We have good coverage of the normal I/O paths now, but what remains is a test that tests some more special cases: Exporting an image on itself (thus turning a formatted image into a raw one), some error cases, and non-writable and non-growable exports. Signed-off-by: Max Reitz Reviewed-by: Kevin

[PATCH for-6.0 v3 16/20] storage-daemon: Call bdrv_close_all() on exit

Otherwise, exports and block devices are not properly shut down and closed, unless the users explicitly issues blockdev-del and block-export-del commands for each of them. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- storage-daemon/qemu-storage-daemon.c | 3 +++ 1 file changed, 3 insert

[PATCH for-6.0 v3 17/20] iotests: Give access to the qemu-storage-daemon

Signed-off-by: Max Reitz --- tests/qemu-iotests/check | 11 +++ tests/qemu-iotests/common.rc | 17 + 2 files changed, 28 insertions(+) diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index 678b6e4910..3c1fa4435a 100755 --- a/tests/qemu-iotests/check +

[PATCH for-6.0 v3 18/20] iotests: Allow testing FUSE exports

This pretends FUSE exports are a kind of protocol. As such, they are always tested under the format node. This is probably the best way to test them, actually, because this will generate more I/O load and more varied patterns. Signed-off-by: Max Reitz --- tests/qemu-iotests/check | 6

Re: [PULL 31/38] device-core: use RCU for list of children of a bus

On 10/12/20 3:33 PM, Paolo Bonzini wrote: > From: Maxim Levitsky > > This fixes the race between device emulation code that tries to find > a child device to dispatch the request to (e.g a scsi disk), > and hotplug of a new device to that bus. > > Note that this doesn't convert all the readers o

Re: [Libguestfs] [libnbd PATCH] info: Add support for new 'qemu-nbd -A' qemu:allocation-depth

On Tue, Oct 27, 2020 at 10:33:48AM -0500, Eric Blake wrote: > On 10/16/20 10:23 AM, Eric Blake wrote: > > A rather trivial decoding; we may enhance it further if qemu extends > > things to give an integer depth alongside its tri-state encoding. > > --- > > > > I'll wait to push this to libnbd unti

Re: [PULL 31/38] device-core: use RCU for list of children of a bus

Maxim has already posted a fix for the test, Kevin should pull it. Paolo Il mar 27 ott 2020, 20:34 Eric Blake ha scritto: > On 10/12/20 3:33 PM, Paolo Bonzini wrote: > > From: Maxim Levitsky > > > > This fixes the race between device emulation code that tries to find > > a child device to disp

Re: [PATCH] hw/sd: Zero out function selection fields before being populated

Hello Philippe, Bin, Thanks for your support on this. I've just tried this patch and unfortunately it doesn't seem to resolve the issue, at least on my machine. This is the output that I get when running the avocado test for NetBSD9.0: (5/5) tests/acceptance/boot_linux_console.py:BootLinuxConsol

QEMU and kvm on big.LITTLE aarch64

Dear Qemu friends! I have been using qemu for years for low-level development of software (bare metal for raspberrypi or operating systems such as AROS for x86, x86-64, ppc). Since I am busy with my new project - a JIT translator of M68k running on bare metal aarch64 machines, I’ve started to

Re: [PATCH v1 12/16] target/riscv: cpu_helper: Remove compile time XLEN checks

On Mon, Oct 26, 2020 at 1:56 AM Bin Meng wrote: > > On Fri, Oct 23, 2020 at 11:45 PM Alistair Francis > wrote: > > > > Signed-off-by: Alistair Francis > > --- > > target/riscv/cpu.h| 6 ++--- > > target/riscv/cpu_helper.c | 52 --- > > 2 files change

Re: [PATCH V4 0/6] Support RISC-V migration

On Mon, Oct 26, 2020 at 4:58 AM Yifei Jiang wrote: > > This patches supported RISC-V migration based on tcg accel. And we have > verified related migration features such as snapshot and live migration. > > A few weeks ago, we submitted RFC patches about supporting RISC-V migration > based on kvm a

Re: [PATCH V4 1/6] target/riscv: Merge m/vsstatus and m/vsstatush into one uint64_t unit

On Mon, Oct 26, 2020 at 4:58 AM Yifei Jiang wrote: > > mstatus/mstatush and vsstatus/vsstatush are two halved for RISCV32. > This patch expands mstatus and vsstatus to uint64_t instead of > target_ulong so that it can be saved as one unit and reduce some > ifdefs in the code. > > Signed-off-by: Yi

Re: [PATCH v2 3/6] configure: add option to enable LTO

Ok, no problem. I can definitely disable the check on GCC. Paolo, would you like me to disable checks on AR/linker for lto too? If so, should I add some of this information on a document, perhaps docs/devel/lto.rst, so it is written somewhere for future uses? -- Btw, using lto with gcc I found

Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directories

On Mon, Oct 26, 2020 at 2:34 PM Keith Packard via wrote: > > This commit renames two files which provide ARM semihosting support so > that they can be shared by other architectures: > > 1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c > 2. linux-user/arm/semihost.c -> linux-user/semi

Re: [RESEND PATCH 1/9] hw/misc: Add Microchip PolarFire SoC DDR Memory Controller support

On Tue, Oct 27, 2020 at 7:48 AM Bin Meng wrote: > > From: Bin Meng > > The PolarFire SoC DDR Memory Controller mainly includes 2 modules, > called SGMII PHY module and the CFG module, as documented in the > chipset datasheet. > > This creates a single file that groups these 2 modules, providing >

Re: [RESEND PATCH 3/9] hw/misc: Add Microchip PolarFire SoC IOSCB module support

On Tue, Oct 27, 2020 at 7:50 AM Bin Meng wrote: > > From: Bin Meng > > This creates a model for PolarFire SoC IOSCB [1] module. It actually > contains lots of sub-modules like various PLLs to control different > peripherals. Only the mininum capabilities are emulated to make the > HSS DDR memory

Re: [RESEND PATCH 5/9] hw/misc: Add Microchip PolarFire SoC SYSREG module support

On Tue, Oct 27, 2020 at 7:56 AM Bin Meng wrote: > > From: Bin Meng > > This creates a minimum model for Microchip PolarFire SoC SYSREG > module. It only implements the ENVM_CR register to tell guest > software that eNVM is running at the configured divider rate. > > Signed-off-by: Bin Meng Revi

Re: [RESEND PATCH 8/9] hw/riscv: microchip_pfsoc: Correct DDR memory map

On Tue, Oct 27, 2020 at 7:48 AM Bin Meng wrote: > > From: Bin Meng > > When system memory is larger than 1 GiB (high memory), PolarFire SoC > maps it at address 0x10__. Address 0xC000_ and above is > aliased to the same 1 GiB low memory with different cache attributes. > > At present

Re: [PATCH v2] hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry

On Sun, Oct 18, 2020 at 6:58 PM Bin Meng wrote: > > Hi Ivan, > > On Sat, Oct 17, 2020 at 1:10 AM Ivan Griffin wrote: > > > > Adding the PolarFire SoC IOSCBCTRL memory region to prevent QEMU > > reporting a STORE/AMO Access Fault. > > > > This region is used by the PolarFire SoC port of U-Boot to

Re: QEMU and kvm on big.LITTLE aarch64

On Tue, 27 Oct 2020 at 20:28, Michal Schulz wrote: > Recently I have attempted to to run qemu-system-aarch64, version 5.1.0, on an > aarch64 machine. It is Pinebook Pro with RK3399 big.LITTLE SOC, running > Manjaro linux, kernel version 5.9.1-3. When using tcg everything works just > fine, but

Re: [PATCH 01/20] loader.c: Add support Motrola S-record format.

On Thu, Aug 27, 2020 at 5:39 AM Yoshinori Sato wrote: > > Signed-off-by: Yoshinori Sato > --- > include/hw/loader.h | 14 +++ > hw/core/loader.c| 208 > 2 files changed, 222 insertions(+) > > diff --git a/include/hw/loader.h b/include/hw/loader.h

Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directories

On Mon, 26 Oct 2020 at 21:29, Keith Packard wrote: > > This commit renames two files which provide ARM semihosting support so > that they can be shared by other architectures: > > 1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c > 2. linux-user/arm/semihost.c -> linux-user/semihost.c

Re: [PATCH 1/9] qapi: replace List[str] by IfCond

On 10/15/20 12:52 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Wrap the 'if' condition in a higher-level object. Not only this is allows more type safety but also further refactoring without too much chrun. The following patches will extend the syntax of 'if' and will have som

Re: [PATCH 2/9] qapi: move gen_if/gen_endif to IfCond

On 10/15/20 12:52 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Move the generating function to the IfCond class. (avoid cluttering and potential missuse of global functions, allow access to private members etc) Signed-off-by: Marc-André Lureau --- scripts/qapi/common.py

[Bug 1898883] Re: qemu-system-riscv64 failed to load binary kernel into memory

Just an update on this. You can use -bios to load your image, which will load it to address 0x8000. In QEMU 5.1 `-bios none -kernel Image` will load the Image to 0x8002/0x8004 depending on XLEN. QEMU 5.2 will now correctly load the above mentioned Image to address 0x8000 if you d

Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directories

Peter Maydell writes: >> +specific_ss.add(when: 'CONFIG_TCG', if_true: files ('common-semi.c')) > > I think this adds this file to the compilation for all TCG targets; > you only want it for targets which have Arm-semihosting-ABI compatible > semihosting. (Various other targets either don't have

Re: [PATCH 3/9] qapi: start building an 'if' predicate tree

On 10/15/20 12:52 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The following patches are going to express conditions in some target language agostic way. For that, let's start building a predicate tree of configuration options. The tree will be less expressive than full C mac

[PULL 00/12] NBD patches for 2020-10-27 soft-freeze

The following changes since commit 725ca3313a5b9cbef89eaa1c728567684f37990a: Merge remote-tracking branch 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20201026' into staging (2020-10-27 14:29:52 +) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2

[PULL 03/12] block: Simplify QAPI_LIST_ADD

There is no need to rely on the verbosity of the gcc/clang compiler extension of g_new(typeof(X), 1) when we can instead use the standard g_malloc(sizeof(X)). In general, we like g_new over g_malloc for returning type X rather than void* to let the compiler catch more potential typing mistakes, bu

[PULL 09/12] nbd: Allow export of multiple bitmaps for one device

With this, 'qemu-nbd -B b0 -B b1 -f qcow2 img.qcow2' can let you sniff out multiple bitmaps from one server. qemu-img as client can still only read one bitmap per client connection, but other NBD clients (hello libnbd) can now read multiple bitmaps in a single pass. Signed-off-by: Eric Blake Rev

[PULL 05/12] nbd: Utilize QAPI_CLONE for type conversion

Rather than open-coding the translation from the deprecated NbdServerAddOptions type to the preferred BlockExportOptionsNbd, it's better to utilize QAPI_CLONE_MEMBERS. This solves a couple of issues: first, if we do any more refactoring of the base type (which an upcoming patch plans to do), we do

[PULL 01/12] iotests/291: Filter irrelevant parts of img-info

From: Max Reitz We need to let _img_info emit the format-specific information so we get the list of bitmaps we want, but we do not need anything but the bitmaps. So filter out everything that is irrelevant to us. (Ideally, this would be a generalized function in common.filters that takes a list

[PULL 12/12] nbd: Add 'qemu-nbd -A' to expose allocation depth

Allow the server to expose an additional metacontext to be requested by savvy clients. qemu-nbd adds a new option -A to expose the qemu:allocation-depth metacontext through NBD_CMD_BLOCK_STATUS; this can also be set via QMP when using block-export-add. qemu as client is hacked into viewing the ke

[PULL 02/12] iotests/291: Stop NBD server

From: Max Reitz nbd_server_start_unix_socket() includes an implicit nbd_server_stop(), but we still need an explicit one at the end of the test (where there follows no next nbd_server_start_unix_socket()), or qemu-nbd will linger until the test exits. This will become important when enabling thi

[PULL 06/12] nbd: Update qapi to support exporting multiple bitmaps

Since 'block-export-add' is new to 5.2, we can still tweak the interface; there, allowing 'bitmaps':['str'] is nicer than 'bitmap':'str'. This wires up the qapi and qemu-nbd changes to permit passing multiple bitmaps as distinct metadata contexts that the NBD client may request, but the actual sup

[PULL 04/12] qapi: Add QAPI_LIST_PREPEND() macro

block.c has a useful macro QAPI_LIST_ADD() for inserting at the front of any QAPI-generated list; move it from block.c to qapi/util.h so more places can use it, including one earlier place in block.c, and rename it to something more obvious (since we also have a lot of places that append, rather th

<    1   2   3   4   5   6   >