[PULL 0/3] Ide patches

2020-10-27 Thread John Snow
The following changes since commit a95e0396c805735c491a049b01de6f5a713fb91b: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2020-10-26 15:49:11 +) are available in the Git repository at: https://gitlab.com/jsnow/qemu.git tags/ide-pull-request for

[PATCH v2 6/8] dev-serial: add always-plugged property to ensure USB device is always attached

2020-10-27 Thread Mark Cave-Ayland
Some operating systems will generate a new device ID when a USB device is unplugged and then replugged into the USB. If this is done whilst switching between multiple applications over a virtual serial port, the change of device ID requires going back into the OS/application to locate the new dev

Re: [PATCH v12 09/14] block: modify the comment for BDRV_REQ_PREFETCH flag

2020-10-27 Thread Vladimir Sementsov-Ogievskiy
22.10.2020 21:13, Andrey Shinkevich wrote: Modify the comment for the flag BDRV_REQ_PREFETCH as we are going to use it alone and pass it to the COR-filter driver for further processing. Signed-off-by: Andrey Shinkevich --- include/block/block.h | 8 +--- 1 file changed, 5 insertions(+),

[PULL 3/3] ide: clear SRST after SRST finishes

2020-10-27 Thread John Snow
The SRST protocol states that after diagnostics are complete and the status is posted, we should clear the SRST bit if it should so happen to be set. The reset method itself should handle this, but just in case -- make our intention explicit here. Signed-off-by: John Snow Tested-by: Mark Cave-Ay

[PATCH v2 8/8] dev-serial: store flow control and xon/xoff characters

2020-10-27 Thread Mark Cave-Ayland
Note that whilst the device does not do anything with these values, they are logged with trace events and stored to allow future implementation. The default flow control is set to none at reset as documented in the Linux ftdi_sio.h header file. Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel

Re: [qemu-web PATCH v2 11/16] Bring contribution links out of the footer into the home page

2020-10-27 Thread Kashyap Chamarthy
On Tue, Oct 27, 2020 at 01:20:10PM +, Daniel P. Berrangé wrote: > The selection of contribution links are important information to present > to visitors to the site. They are best placed in a prominent position on > the home page rather than in the footer > > Signed-off-by: Daniel P. BerrangÃ

Re: [PATCH v12 11/14] copy-on-read: add support for read flags to COR-filter

2020-10-27 Thread Vladimir Sementsov-Ogievskiy
22.10.2020 21:13, Andrey Shinkevich wrote: Add the BDRV_REQ_COPY_ON_READ and BDRV_REQ_PREFETCH flags to the supported_read_flags of the COR-filter. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/copy-on-read.c b/block/cop

[PATCH v2 2/8] dev-serial: use USB_SERIAL QOM macro for USBSerialState assignments

2020-10-27 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé --- hw/usb/dev-serial.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c index 7a5fa3770e..77ce89d38b 100644 --- a/hw/usb/dev-seria

[PULL 1/5] qemu-img: add support for rate limit in qemu-img commit

2020-10-27 Thread Kevin Wolf
From: Zhengui add support for rate limit in qemu-img commit. Signed-off-by: Zhengui Message-Id: <1603205264-17424-2-git-send-email-lizhen...@huawei.com> Reviewed-by: Alberto Garcia Signed-off-by: Kevin Wolf --- docs/tools/qemu-img.rst | 4 +++- qemu-img.c | 11 +-- qemu

Re: [PATCH 08/25] block/nvme: Simplify device reset

2020-10-27 Thread Keith Busch
On Tue, Oct 27, 2020 at 02:55:30PM +0100, Philippe Mathieu-Daudé wrote: > Avoid multiple endianess conversion by using device endianess. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/nvme.c b/block/n

[PATCH v2 1/8] dev-serial: style changes to improve readability and checkpatch fixes

2020-10-27 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault --- hw/usb/dev-serial.c | 230 1 file changed, 126 insertions(+), 104 deletions(-) diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c index b1622b7c7f..7a5fa3770e 100644 --- a/hw/usb/de

[PULL 4/5] qcow2: Skip copy-on-write when allocating a zero cluster

2020-10-27 Thread Kevin Wolf
From: Alberto Garcia Since commit c8bb23cbdbe32f5c326365e0a82e1b0e68cdcd8a when a write request results in a new allocation QEMU first tries to see if the rest of the cluster outside the written area contains only zeroes. In that case, instead of doing a normal copy-on-write operation and writin

[PULL 3/5] qcow2: Report BDRV_BLOCK_ZERO more accurately in bdrv_co_block_status()

2020-10-27 Thread Kevin Wolf
From: Alberto Garcia If a BlockDriverState supports backing files but has none then any unallocated area reads back as zeroes. bdrv_co_block_status() is only reporting this is if want_zero is true, but this is an inexpensive test and there is no reason not to do it in all cases. Suggested-by: V

Re: [PATCH 4/5] spapr: Pass &error_abort when getting some PC DIMM properties

2020-10-27 Thread Greg Kurz
On Tue, 27 Oct 2020 12:54:24 +0100 Igor Mammedov wrote: > On Sun, 25 Oct 2020 16:24:44 +0100 > Greg Kurz wrote: > > > On Fri, 23 Oct 2020 21:15:09 +0200 > > Igor Mammedov wrote: > > > > > On Mon, 19 Oct 2020 10:48:41 +0200 > > > Greg Kurz wrote: > > > > > > > Both PC_DIMM_SLOT_PROP and PC

Re: [PATCH v12 13/14] stream: skip filters when writing backing file name to QCOW2 header

2020-10-27 Thread Vladimir Sementsov-Ogievskiy
22.10.2020 21:13, Andrey Shinkevich wrote: Avoid writing a filter JSON file name and a filter format name to QCOW2 image when the backing file is changed after the block stream job. A user is still able to assign the 'backing-file' parameter for a block-stream job keeping in mind the possible iss

[PATCH v2 7/8] dev-serial: add support for setting data_bits in QEMUSerialSetParams

2020-10-27 Thread Mark Cave-Ayland
Also implement the behaviour reported in Linux's ftdi_sio.c whereby if an invalid data_bits value is provided then the hardware defaults to using 8. Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé --- hw/usb/dev-serial.c | 17 +

[PATCH v2 3/8] dev-serial: convert from DPRINTF to trace-events

2020-10-27 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé --- hw/usb/dev-serial.c | 28 ++-- hw/usb/trace-events | 8 2 files changed, 22 insertions(+), 14 deletions(-) diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial

Re: [PATCH v2 3/6] configure: add option to enable LTO

2020-10-27 Thread Daniel P . Berrangé
On Tue, Oct 27, 2020 at 10:57:14AM -0400, Daniele Buono wrote: > In terms of ar and linker, if you don't have the right mix it will just > stop at link time with an error. > > In terms of using gcc the errors may be a bit more subtle, similar to > what Daniel mentioned. Succesfully compiling but t

[PATCH v2 5/8] dev-serial: replace DeviceOutVendor/DeviceInVendor with equivalent macros from usb.h

2020-10-27 Thread Mark Cave-Ayland
The DeviceOutVendor and DeviceInVendor macros can be replaced with their equivalent VendorDeviceOutRequest and VendorDeviceRequest macros from usb.h. Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé --- hw/usb/dev-serial.c | 25 ++

Out-of-Process Device Emulation session at KVM Forum 2020

2020-10-27 Thread Stefan Hajnoczi
There will be a birds-of-a-feather session at KVM Forum, a chance for us to get together and discuss Out-of-Process Device Emulation. Please send suggestions for the agenda! These sessions are a good opportunity to reach agreement on topics that are hard to discuss via mailing lists. Ideas: * H

Re: [PULL 01/17] build: fix macOS --enable-modules build

2020-10-27 Thread Gerd Hoffmann
On Tue, Oct 27, 2020 at 02:27:42PM +0100, Paolo Bonzini wrote: > On 27/10/20 10:27, Philippe Mathieu-Daudé wrote: > > I'm confused as this broke the catalina-xcode test: > > > > PASS 5 qtest-aarch64/device-introspect-test > > /aarch64/device/introspect/abstract-interfaces > > missing object type

Re: [PATCH 03/25] block/nvme: Report warning with warn_report()

2020-10-27 Thread Philippe Mathieu-Daudé
On 10/27/20 3:45 PM, Keith Busch wrote: > On Tue, Oct 27, 2020 at 02:55:25PM +0100, Philippe Mathieu-Daudé wrote: >> Instead of displaying warning on stderr, use warn_report() >> which also displays it on the monitor. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> block/nvme.c | 4 ++-- >>

Re: [Libguestfs] [libnbd PATCH] info: Add support for new 'qemu-nbd -A' qemu:allocation-depth

2020-10-27 Thread Eric Blake
On 10/16/20 10:23 AM, Eric Blake wrote: > A rather trivial decoding; we may enhance it further if qemu extends > things to give an integer depth alongside its tri-state encoding. > --- > > I'll wait to push this to libnbd until the counterpart qemu patches > land upstream, although it looks like I

Re: [PULL 01/17] build: fix macOS --enable-modules build

2020-10-27 Thread Gerd Hoffmann
On Tue, Oct 27, 2020 at 04:21:50PM +0100, Gerd Hoffmann wrote: > https://patchwork.ozlabs.org/project/qemu-devel/patch/20201027120603.3625-1-kra...@redhat.com/ FYI: have pending pull req with this and 3 more module patches, ci running atm, probably goes out tomorrow ... ) take care, Gerd

[PATCH v2 0/8] dev-serial: minor fixes and improvements

2020-10-27 Thread Mark Cave-Ayland
This series comes from a client project that I have been working on over the past few months which involves communicating with serial hardware and associated simulators using the QEMU USB serial device. With thanks to Craig Stevens at Renesas for giving permission for these patches to be upstreame

[PULL 2/5] qemu-img: add support for rate limit in qemu-img convert

2020-10-27 Thread Kevin Wolf
From: Zhengui add support for rate limit in qemu-img convert. Signed-off-by: Zhengui Message-Id: <1603205264-17424-3-git-send-email-lizhen...@huawei.com> Reviewed-by: Alberto Garcia Signed-off-by: Kevin Wolf --- docs/tools/qemu-img.rst | 6 +- qemu-img.c | 27 ++

Re: [PATCH v2 3/6] configure: add option to enable LTO

2020-10-27 Thread Daniele Buono
In terms of ar and linker, if you don't have the right mix it will just stop at link time with an error. In terms of using gcc the errors may be a bit more subtle, similar to what Daniel mentioned. Succesfully compiling but then showing issues at runtime or in the test suite. I'm using ubuntu 18

[PULL 0/5] Block layer patches

2020-10-27 Thread Kevin Wolf
The following changes since commit d55450df995d6223486db11c66491cbf6c131523: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20201026a' into staging (2020-10-27 10:25:42 +) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for

[PULL 5/5] block: End quiescent sections when a BDS is deleted

2020-10-27 Thread Kevin Wolf
From: Greg Kurz If a BDS gets deleted during blk_drain_all(), it might miss a call to bdrv_do_drained_end(). This means missing a call to aio_enable_external() and the AIO context remains disabled for ever. This can cause a device to become irresponsive and to disrupt the guest execution, ie. han

Re: [PATCH v2] block: End quiescent sections when a BDS is deleted

2020-10-27 Thread Greg Kurz
On Tue, 27 Oct 2020 13:54:04 + Stefan Hajnoczi wrote: > On Fri, Oct 23, 2020 at 05:01:10PM +0200, Greg Kurz wrote: > > +/** > > + * End all quiescent sections started by bdrv_drain_all_begin(). This is > > + * only needed when deleting a BDS before bdrv_drain_all_end() is called. > > + */ > >

Re: [PATCH v6 11/11] qapi: Use QAPI_LIST_ADD() where possible

2020-10-27 Thread Markus Armbruster
Eric Blake writes: > On 10/27/20 5:09 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Anywhere we create a list of just one item or by prepending items >>> (typically because order doesn't matter), we can use the now-public >>> macro. But places where we must keep the list in order b

Re: [PATCH 0/3] console: make QMP screendump use coroutine

2020-10-27 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Hi, > > Thanks to recent work by Kevin, it becomes possible to run HMP/QMP commands i= > n a > coroutine. The screendump command is a good target, as it requires to re-enter > the main-loop in ordre to flush the display, and write

Re: [PATCH v2] block: End quiescent sections when a BDS is deleted

2020-10-27 Thread Kevin Wolf
Am 27.10.2020 um 16:24 hat Greg Kurz geschrieben: > On Tue, 27 Oct 2020 13:54:04 + > Stefan Hajnoczi wrote: > > > On Fri, Oct 23, 2020 at 05:01:10PM +0200, Greg Kurz wrote: > > > +/** > > > + * End all quiescent sections started by bdrv_drain_all_begin(). This is > > > + * only needed when de

[PATCH v2] xen: rework pci_piix3_xen_ide_unplug

2020-10-27 Thread Anthony PERARD via
From: Anthony PERARD This is to allow IDE disks to be unplugged when adding to QEMU via: -drive file=/root/disk_file,if=none,id=ide-disk0,format=raw -device ide-hd,drive=ide-disk0,bus=ide.0,unit=0 as the current code only works for disk added with: -drive file=/root/disk_file,if=ide,

Re: [PULL 00/13] 9p queue 2020-10-23

2020-10-27 Thread Christian Schoenebeck
On Dienstag, 27. Oktober 2020 11:26:53 CET Dr. David Alan Gilbert wrote: > * Christian Schoenebeck (qemu_...@crudebyte.com) wrote: > > On Dienstag, 27. Oktober 2020 10:06:53 CET Dr. David Alan Gilbert wrote: > > > * Greg Kurz (gr...@kaod.org) wrote: > > > > On Mon, 26 Oct 2020 13:48:37 +0100 > > >

Re: [PATCH 2/2] acpi/crs: Support ranges > 32b for hosts

2020-10-27 Thread Ben Widawsky
On 20-10-27 15:36:12, Igor Mammedov wrote: > On Mon, 26 Oct 2020 12:39:24 -0700 > Ben Widawsky wrote: > > > According to PCIe spec 5.0 Type 1 header space Base Address Registers > > are defined by 7.5.1.2.1 Base Address Registers (same as Type 0). The > > _CRS region should allow for the same ran

Re: [PATCH 08/25] block/nvme: Simplify device reset

2020-10-27 Thread Philippe Mathieu-Daudé
On 10/27/20 3:58 PM, Keith Busch wrote: > On Tue, Oct 27, 2020 at 02:55:30PM +0100, Philippe Mathieu-Daudé wrote: >> Avoid multiple endianess conversion by using device endianess. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> block/nvme.c | 2 +- >> 1 file changed, 1 insertion(+), 1 delet

Re: [PATCH 03/25] block/nvme: Report warning with warn_report()

2020-10-27 Thread Philippe Mathieu-Daudé
On 10/27/20 4:33 PM, Philippe Mathieu-Daudé wrote: > On 10/27/20 3:45 PM, Keith Busch wrote: >> On Tue, Oct 27, 2020 at 02:55:25PM +0100, Philippe Mathieu-Daudé wrote: >>> Instead of displaying warning on stderr, use warn_report() >>> which also displays it on the monitor. >>> >>> Signed-off-by: Ph

Re: [PATCH v12 13/14] stream: skip filters when writing backing file name to QCOW2 header

2020-10-27 Thread Andrey Shinkevich
On 27.10.2020 18:09, Vladimir Sementsov-Ogievskiy wrote: 22.10.2020 21:13, Andrey Shinkevich wrote: Avoid writing a filter JSON file name and a filter format name to QCOW2 image when the backing file is changed after the block stream job. A user is still able to assign the 'backing-file' paramet

Re: [PATCH v2 3/3] console: make QMP/HMP screendump run in coroutine

2020-10-27 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Thanks to the monitors' coroutine support (merge commit b7092cda1b3), > the screendump handler can trigger a graphic_hw_update(), yield and let > the main loop run until update is done. Then the handler is resumed, and > ppm_save()

[PATCH-for-5.2] block/nvme: Fix nvme_submit_command() on big-endian host

2020-10-27 Thread Philippe Mathieu-Daudé
The Completion Queue Command Identifier is a 16-bit value, so nvme_submit_command() is unlikely to work on big-endian hosts, as the relevant bits are truncated. The "Completion Queue Entry: DW 2" describes it as: This identifier is assigned by host software when the command is submitted to th

RE: [PATCH v2] xen: rework pci_piix3_xen_ide_unplug

2020-10-27 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD > Sent: 27 October 2020 15:41 > To: qemu-devel@nongnu.org > Cc: Anthony PERARD ; Paul Durrant ; > Stefano Stabellini > ; John Snow ; qemu-bl...@nongnu.org > Subject: [PATCH v2] xen: rework pci_piix3_xen_ide_unplug > > From: Anthony PERARD > >

Re: [PATCH v7] sev: add sev-inject-launch-secret

2020-10-27 Thread Tobin Feldman-Fitzthum
On 2020-10-27 09:35, Eduardo Habkost wrote: On Thu, Oct 22, 2020 at 01:39:09AM -0400, to...@linux.ibm.com wrote: From: Tobin Feldman-Fitzthum AMD SEV allows a guest owner to inject a secret blob into the memory of a virtual machine. The secret is encrypted with the SEV Transport Encryption Key

Re: [PATCH v12 14/14] block: apply COR-filter to block-stream jobs

2020-10-27 Thread Vladimir Sementsov-Ogievskiy
22.10.2020 21:13, Andrey Shinkevich wrote: This patch completes the series with the COR-filter insertion for block-stream operations. Adding the filter makes it possible for copied regions to be discarded in backing files during the block-stream job, what will reduce the disk overuse. The COR-fil

Re: [PATCH v2 2/6] configure: avoid new clang 11+ warnings

2020-10-27 Thread Daniele Buono
So what I would do for the warning in IplParameterBlock is the following (if I got the comments right): - Remove IplBlockFcp from IplParameterBlock - Keep IPLBlockPV and, in its declaration, use struct IPLBlockPVComp components[0]; Now for the IplBlockFcp struct declaration, it does not seem to

Re: [PULL 00/48] target-arm queue

2020-10-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201027114438.17662-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201027114438.17662-1-peter.mayd...@linaro.org Subject: [PULL 00/48] target-arm que

Re: [qemu-web PATCH v2 06/16] Rework display of screenshots to use a carousel slider

2020-10-27 Thread Kashyap Chamarthy
On Tue, Oct 27, 2020 at 01:20:05PM +, Daniel P. Berrangé wrote: > We have a number of screenshots to display, with three fitted across the > width of the screen. The screenshots dominate the usage of screen real > estate on the front page, with other relevant information off the bottom > of th

Re: [PATCH v12 13/14] stream: skip filters when writing backing file name to QCOW2 header

2020-10-27 Thread Vladimir Sementsov-Ogievskiy
27.10.2020 19:01, Andrey Shinkevich wrote: On 27.10.2020 18:09, Vladimir Sementsov-Ogievskiy wrote: 22.10.2020 21:13, Andrey Shinkevich wrote: Avoid writing a filter JSON file name and a filter format name to QCOW2 image when the backing file is changed after the block stream job. A user is sti

Re: [PATCH 14/15] sparc: remove bios_name

2020-10-27 Thread Mark Cave-Ayland
On 26/10/2020 14:30, Paolo Bonzini wrote: Cc: Mark Cave-Ayland Signed-off-by: Paolo Bonzini --- hw/sparc/leon3.c | 4 +--- hw/sparc/sun4m.c | 2 +- hw/sparc64/sun4u.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index d40b7

[PULL 0/8] Trivial branch for 5.2 patches

2020-10-27 Thread Laurent Vivier
gs/trivial-branch-for-5.2-pull-request for you to fetch changes up to e83029fa605d6aa475be60b191f2af3954591093: CHANGELOG: remove disused file (2020-10-27 16:48:50 +0100) Pull request trivial branc

[PULL 3/8] cpus: Drop declaration of cpu_remove()

2020-10-27 Thread Laurent Vivier
From: Greg Kurz cpu_remove() got superseded by cpu_remove_sync() in commit dbadee4ff4a0, but its prototype wasn't removed. We could possibly keep the shorter cpu_remove() naming but it seems better to highligth that this blocks until the CPU thread is joined. Fixes: dbadee4ff4a0 ("cpus: join thr

[PULL 2/8] Makefile: Add *.[ch].inc files to cscope/ctags/TAGS

2020-10-27 Thread Laurent Vivier
From: Greg Kurz The code base has some C source and header files that don't get indexed because their name ends with .inc: $ git ls-files "*.[ch].inc" | wc -l 66 Add them to the list. Signed-off-by: Greg Kurz Message-Id: <160258069310.900922.1495166540282536628.st...@bahia.lan> Signed-off-by:

[PULL 5/8] cryptodev: Fix Lesser GPL version number

2020-10-27 Thread Laurent Vivier
From: Chetan Pant There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Signed-off-by: Chetan Pant Reviewed-by: T

[PULL 4/8] io: Fix Lesser GPL version number

2020-10-27 Thread Laurent Vivier
From: Chetan Pant There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Signed-off-by: Chetan Pant Acked-by: Dani

[PULL 8/8] CHANGELOG: remove disused file

2020-10-27 Thread Laurent Vivier
From: John Snow There's no reason to keep this here; the versions described are ancient. Everything here is still mirrored on https://wiki.qemu.org/ChangeLog/old if anyone is curious; otherwise, use the git history. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Alex Bennée Me

[PULL 6/8] scripts/qmp: delete 'qmp' script

2020-10-27 Thread Laurent Vivier
From: John Snow This script has not seen a patch that was specifically for this script since it was moved to this location in 2013, and I doubt it is used. It uses "man qmp" for its help message, which does not exist. It also presumes there is a manual page for qmp-XXX, for each defined qmp comma

[PATCH 0/3] iotests: Fix pylint/mypy warnings on F33

2020-10-27 Thread Kevin Wolf
This series makes iotest 297 (which runs pylint and mypy on iotests.py) pass again on Fedora 33. Kevin Wolf (3): iotests.py: Fix type check errors in wait_migration() iotests: Disable unsubscriptable-object in pylint iotests: Use Python 3 style super() tests/qemu-iotests/iotests.py | 12 ++

[PULL 7/8] qdev: Fix two typos

2020-10-27 Thread Laurent Vivier
From: Maxim Levitsky Signed-off-by: Maxim Levitsky Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20201019163702.471239-2-mlevi...@redhat.com> Signed-off-by: Laurent Vivier --- include/hw/qdev-core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[PULL 1/8] elf2dmp: Fix memory leak on main() error paths

2020-10-27 Thread Laurent Vivier
From: AlexChen The 'kdgb' is allocating memory in get_kdbg(), but it is not freed in both fill_header() and fill_context() failed branches, fix it. Signed-off-by: AlexChen Reviewed-by: Li Qiang Reviewed-by: Viktor Prutyanov Reviewed-by: Thomas Huth Message-Id: <5f463659.8080...@huawei.com> S

Re: [PATCH] osdep.h: Remove include

2020-10-27 Thread Eric Blake
On 10/26/20 7:38 PM, Michael Forney wrote: > Prior to 2a4b472c3c, sys/signal.h was only included on OpenBSD > (apart from two .c files). The POSIX standard location for this > header is just and in fact, OpenBSD's signal.h includes > sys/signal.h itself. > > Unconditionally including on musl cau

[PATCH 2/3] iotests: Disable unsubscriptable-object in pylint

2020-10-27 Thread Kevin Wolf
When run with Python 3.9, pylint incorrectly warns about things like Optional[foo] because it doesn't recognise Optional as unsubscriptable. This is a known pylint bug: https://github.com/PyCQA/pylint/issues/3882 Just disable this check to get rid of the warnings. Disabling this shouldn't ma

Re: [PATCH v12 13/14] stream: skip filters when writing backing file name to QCOW2 header

2020-10-27 Thread Andrey Shinkevich
On 27.10.2020 19:21, Vladimir Sementsov-Ogievskiy wrote: 27.10.2020 19:01, Andrey Shinkevich wrote: On 27.10.2020 18:09, Vladimir Sementsov-Ogievskiy wrote: 22.10.2020 21:13, Andrey Shinkevich wrote: Avoid writing a filter JSON file name and a filter format name to QCOW2 image when the backing

[PATCH 1/3] iotests.py: Fix type check errors in wait_migration()

2020-10-27 Thread Kevin Wolf
Commit 1847a4a8c20 clarified that event_wait() can return None (though only with timeout=0) and commit f12a282ff47 annotated it as returning Optional[QMPMessage]. Type checks in wait_migration() fail because of the unexpected optional return type: iotests.py:750: error: Value of type variable "Ms

Re: [PATCH v12 13/14] stream: skip filters when writing backing file name to QCOW2 header

2020-10-27 Thread Vladimir Sementsov-Ogievskiy
27.10.2020 19:42, Andrey Shinkevich wrote: On 27.10.2020 19:21, Vladimir Sementsov-Ogievskiy wrote: 27.10.2020 19:01, Andrey Shinkevich wrote: On 27.10.2020 18:09, Vladimir Sementsov-Ogievskiy wrote: 22.10.2020 21:13, Andrey Shinkevich wrote: Avoid writing a filter JSON file name and a filter

[PATCH 2/2] iotests/291: Stop NBD server

2020-10-27 Thread Max Reitz
nbd_server_start_unix_socket() includes an implicit nbd_server_stop(), but we still need an explicit one at the end of the test (where there follows no next nbd_server_start_unix_socket()), or qemu-nbd will linger until the test exits. This will become important when enabling this test to run on F

[PATCH 3/3] iotests: Use Python 3 style super()

2020-10-27 Thread Kevin Wolf
pylint complains about the use of super with the current class and instance as arguments in VM.__init__(): iotests.py:546:8: R1725: Consider using Python 3 style super() without arguments (super-with-arguments) No reason not to follow the advice and make it happy, so let's do this. Signed-off-b

[PATCH 1/2] iotests/291: Filter irrelevant parts of img-info

2020-10-27 Thread Max Reitz
We need to let _img_info emit the format-specific information so we get the list of bitmaps we want, but we do not need anything but the bitmaps. So filter out everything that is irrelevant to us. (Ideally, this would be a generalized function in common.filters that takes a list of things to keep

Re: [PATCH 2/3] iotests: Disable unsubscriptable-object in pylint

2020-10-27 Thread John Snow
On 10/27/20 12:38 PM, Kevin Wolf wrote: When run with Python 3.9, pylint incorrectly warns about things like Optional[foo] because it doesn't recognise Optional as unsubscriptable. This is a known pylint bug: https://github.com/PyCQA/pylint/issues/3882 Just disable this check to get rid of

Re: [PATCH 3/3] iotests: Use Python 3 style super()

2020-10-27 Thread John Snow
On 10/27/20 12:38 PM, Kevin Wolf wrote: pylint complains about the use of super with the current class and instance as arguments in VM.__init__(): iotests.py:546:8: R1725: Consider using Python 3 style super() without arguments (super-with-arguments) No reason not to follow the advice and make

[PATCH 0/2] iotests/291: Two fixes

2020-10-27 Thread Max Reitz
Hi, This series fixes two things about 291, one of which is actually a problem right now (patch 1), and one of which is more or less of a style question currently, but will become a problem with my FUSE export series (patch 2). (The issues were different enough that I decided to split the fixes i

[PULL 0/3] tcg patch queue

2020-10-27 Thread Richard Henderson
s/pull-tcg-20201027 for you to fetch changes up to 1d705e8a5bbfe36294081baa45ab68a9ad987f33: accel/tcg: Add CPU_LOG_EXEC tracing for cpu_io_recompile() (2020-10-27 09:48:07 -0700) Optimize across branches. Add logging for cpu_io

[PULL 3/3] accel/tcg: Add CPU_LOG_EXEC tracing for cpu_io_recompile()

2020-10-27 Thread Richard Henderson
From: Peter Maydell When using -icount, it's useful for the CPU_LOG_EXEC logging to include information about when cpu_io_recompile() was called, because it alerts the reader of the log that the tracing of a previous TB execution may not actually correspond to an actually executed instruction. Fo

[PULL 1/3] tcg: Do not kill globals at conditional branches

2020-10-27 Thread Richard Henderson
We can easily register allocate the entire extended basic block (in this case, the set of blocks connected by fallthru), simply by not discarding the register state at the branch. This does not help blocks starting with a label, as they are reached via a taken branch, and that would require saving

Re: [PATCH 08/25] block/nvme: Simplify device reset

2020-10-27 Thread Keith Busch
On Tue, Oct 27, 2020 at 04:53:31PM +0100, Philippe Mathieu-Daudé wrote: > On 10/27/20 3:58 PM, Keith Busch wrote: > > On Tue, Oct 27, 2020 at 02:55:30PM +0100, Philippe Mathieu-Daudé wrote: > >> Avoid multiple endianess conversion by using device endianess. > >> > >> Signed-off-by: Philippe Mathieu

[PULL 2/3] tcg/optimize: Flush data at labels not TCG_OPF_BB_END

2020-10-27 Thread Richard Henderson
We can easily propagate temp values through the entire extended basic block (in this case, the set of blocks connected by fallthru), simply by not discarding the register state at the branch. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/optimize.c | 35 ++---

Re: [PULL 00/16] virtiofs queue

2020-10-27 Thread Peter Maydell
On Mon, 26 Oct 2020 at 18:51, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit a95e0396c805735c491a049b01de6f5a713fb91b: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2020-10-26 15:49:11

[PATCH v8] sev: add sev-inject-launch-secret

2020-10-27 Thread tobin
From: Tobin Feldman-Fitzthum AMD SEV allows a guest owner to inject a secret blob into the memory of a virtual machine. The secret is encrypted with the SEV Transport Encryption Key and integrity is guaranteed with the Transport Integrity Key. Although QEMU facilitates the injection of the launch

Re: [PATCH v2] qcow2: Document and enforce the QCowL2Meta invariants

2020-10-27 Thread Alberto Garcia
ping On Wed 07 Oct 2020 06:13:23 PM CEST, Alberto Garcia wrote: > The QCowL2Meta structure is used to store information about a part of > a write request that touches clusters that need changes in their L2 > entries. This happens with newly-allocated clusters or subclusters. > > This structure has

Re: [PATCH 0/2] iotests/291: Two fixes

2020-10-27 Thread Eric Blake
On 10/27/20 11:44 AM, Max Reitz wrote: > Hi, > > This series fixes two things about 291, one of which is actually a > problem right now (patch 1), and one of which is more or less of a style > question currently, but will become a problem with my FUSE export series > (patch 2). > > (The issues we

Re: [RESEND PATCH 9/9] hw/riscv: microchip_pfsoc: Hook the I2C1 controller

2020-10-27 Thread Alistair Francis
On Tue, Oct 27, 2020 at 7:55 AM Bin Meng wrote: > > From: Bin Meng > > The latest SD card image [1] released by Microchip ships a Linux > kernel with built-in PolarFire SoC I2C driver support. The device > tree file includes the description for the I2C1 node hence kernel > tries to probe the I2C1

Re: [PATCH 1/3] iotests.py: Fix type check errors in wait_migration()

2020-10-27 Thread John Snow
On 10/27/20 12:38 PM, Kevin Wolf wrote: Commit 1847a4a8c20 clarified that event_wait() can return None (though only with timeout=0) and commit f12a282ff47 annotated it as returning Optional[QMPMessage]. Type checks in wait_migration() fail because of the unexpected optional return type: iotests

Re: [PATCH v2] xen: rework pci_piix3_xen_ide_unplug

2020-10-27 Thread John Snow
On 10/27/20 11:40 AM, Anthony PERARD wrote: From: Anthony PERARD This is to allow IDE disks to be unplugged when adding to QEMU via: -drive file=/root/disk_file,if=none,id=ide-disk0,format=raw -device ide-hd,drive=ide-disk0,bus=ide.0,unit=0 as the current code only works for disk add

[PATCH 03/12] block/export: make vhost-user-blk config space little-endian

2020-10-27 Thread Stefan Hajnoczi
VIRTIO 1.0 devices have little-endian configuration space. The vhost-user-blk-server.c code already uses little-endian for virtqueue processing but not for the configuration space fields. Fix this so the vhost-user-blk export works on big-endian hosts. Signed-off-by: Stefan Hajnoczi --- block/ex

[PATCH 00/12] block/export: vhost-user-blk server cleanups and tests

2020-10-27 Thread Stefan Hajnoczi
This patch series solves some issues with the new vhost-user-blk-server and adds the qtest test case. The test case was not included in the pull request that introduced the vhost-user-blk server because of reliability issues that are fixed in this patch series. Coiby Xu (1): test: new qTest case

[PATCH 05/12] contrib/vhost-user-blk: fix get_config() information leak

2020-10-27 Thread Stefan Hajnoczi
Refuse get_config() in excess of sizeof(struct virtio_blk_config). Signed-off-by: Stefan Hajnoczi --- contrib/vhost-user-blk/vhost-user-blk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/vhost-user-blk/vhost-user-blk.c b/contrib/vhost-user-blk/vhost-user-blk.c index 25eccd02b5.

[PATCH 01/12] libvhost-user: follow QEMU comment style

2020-10-27 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- contrib/libvhost-user/libvhost-user.h | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/contrib/libvhost-user/libvhost-user.h b/contrib/libvhost-user/libvhost-user.h index 3bbeae8587..a1539dbb69 100644 --- a/contrib/libvhost-u

[PATCH 07/12] tests/qtest: add multi-queue test case to vhost-user-blk-test

2020-10-27 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi Message-id: 20201001144604.559733-3-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- tests/qtest/vhost-user-blk-test.c | 81 +-- 1 file changed, 76 insertions(+), 5 deletions(-) diff --git a/tests/qtest/vhost-user-blk-test.c b/te

[PATCH 04/12] block/export: fix vhost-user-blk get_config() information leak

2020-10-27 Thread Stefan Hajnoczi
Refuse get_config() requests in excess of sizeof(struct virtio_blk_config). Signed-off-by: Stefan Hajnoczi --- block/export/vhost-user-blk-server.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user-blk-server.c index 33cc0818b8

[PATCH 02/12] configure: introduce --enable-vhost-user-blk-server

2020-10-27 Thread Stefan Hajnoczi
Make it possible to compile out the vhost-user-blk server. It is enabled by default on Linux. Note that vhost-user-server.c depends on libvhost-user, which requires CONFIG_LINUX. The CONFIG_VHOST_USER dependency was erroneous since that option controls vhost-user frontends (previously known as "ma

[PATCH 10/12] vhost-user-blk-test: close fork child file descriptors

2020-10-27 Thread Stefan Hajnoczi
Do not leave stdin, stdout, stderr open after fork. stdout is the tap-driver.pl pipe. If we keep the pipe open then tap-driver.pl will not detect that qos-test has terminated and it will hang. Signed-off-by: Stefan Hajnoczi --- tests/qtest/vhost-user-blk-test.c | 11 +++ 1 file changed,

[PATCH 09/12] vhost-user-blk-test: rename destroy_drive() to destroy_file()

2020-10-27 Thread Stefan Hajnoczi
The function is used not just for image files but also for UNIX domain sockets (QMP monitor and vhost-user-blk). Reflect that in the name. Signed-off-by: Stefan Hajnoczi --- tests/qtest/vhost-user-blk-test.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/qtest

[PATCH 11/12] vhost-user-blk-test: drop unused return value

2020-10-27 Thread Stefan Hajnoczi
The sock_path return value was unused and bogus (it doesn't make sense when there are multiple drives because only the last path is arbitrarily returned). Signed-off-by: Stefan Hajnoczi --- tests/qtest/vhost-user-blk-test.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a

[PATCH 06/12] test: new qTest case to test the vhost-user-blk-server

2020-10-27 Thread Stefan Hajnoczi
From: Coiby Xu This test case has the same tests as tests/virtio-blk-test.c except for tests have block_resize. Since vhost-user server can only server one client one time, two instances of vhost-user-blk-server are started by qemu-storage-daemon for the hotplug test. In order to not block scrip

[PATCH 08/12] libqtest: add qtest_socket_server()

2020-10-27 Thread Stefan Hajnoczi
There is a qtest_socket_client() API. Add an equivalent qtest_socket_server() API that returns a new UNIX domain socket in the listen state. The code for this was already there but only used internally in init_socket(). Signed-off-by: Stefan Hajnoczi --- tests/qtest/libqos/libqtest.h | 8 ++

Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask

2020-10-27 Thread Jean-Philippe Brucker
On Fri, Oct 23, 2020 at 12:47:02PM -0400, Peter Xu wrote: > On Fri, Oct 23, 2020 at 09:48:58AM +0200, Jean-Philippe Brucker wrote: > > Arm CPUs and SMMU support 4k, 16k and 64k page sizes. I don't think 16k is > > used anywhere but some distributions chose 64k (RHEL, I think?), others > > 4k, so we

[PATCH 12/12] vhost-user-blk-test: fix races by using fd passing

2020-10-27 Thread Stefan Hajnoczi
Pass the QMP and vhost-user-blk server sockets as file descriptors. That way the sockets are already open and in a listen state when the QEMU process is launched. This solves the race with qemu-storage-daemon startup where the UNIX domain sockets may not be ready yet when QEMU attempts to connect.

Re: [qemu-web PATCH v2 01/16] Convert files to UNIX line endings

2020-10-27 Thread Thomas Huth
On 27/10/2020 14.20, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > assets/css/style-desktop.css | 586 - > assets/css/style-mobile.css | 750 ++--- > assets/css/style.css | 1184 +- > index.html

Re: [RESEND PATCH 2/9] hw/riscv: microchip_pfsoc: Connect DDR memory controller modules

2020-10-27 Thread Alistair Francis
On Tue, Oct 27, 2020 at 7:46 AM Bin Meng wrote: > > From: Bin Meng > > Connect DDR SGMII PHY module and CFG module to the PolarFire SoC. > > Signed-off-by: Bin Meng > --- > > hw/riscv/Kconfig | 1 + > hw/riscv/microchip_pfsoc.c | 18 ++ > include/hw/ri

Re: [RESEND PATCH 4/9] hw/riscv: microchip_pfsoc: Connect the IOSCB module

2020-10-27 Thread Alistair Francis
On Tue, Oct 27, 2020 at 7:52 AM Bin Meng wrote: > > From: Bin Meng > > Previously IOSCB_CFG was created as an unimplemented device. With > the new IOSCB model, its memory range is already covered by the > IOSCB hence remove the previous unimplemented device creation in > the SoC codes. > > Signed

Re: [RESEND PATCH 7/9] hw/riscv: microchip_pfsoc: Map debug memory

2020-10-27 Thread Alistair Francis
On Tue, Oct 27, 2020 at 7:53 AM Bin Meng wrote: > > From: Bin Meng > > Somehow HSS needs to access address 0 [1] for the DDR calibration data > which is in the chipset's debug memory. Let's map the debug memory. > > [1] See the config_copy() calls in various places in ddr_setup() in > the HSS

<    1   2   3   4   5   6   >