[qemu-web PATCH v2 09/16] Put a full SFC membership blurb in footer of every page

2020-10-27 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- _includes/footer.html | 4 +++- assets/css/style.css | 6 +- index.html| 3 --- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/_includes/footer.html b/_includes/footer.html index 6e1b247..411ff55 100644 --- a/_includes/footer.

[qemu-web PATCH v2 14/16] Simplify and restructure the page footer

2020-10-27 Thread Daniel P . Berrangé
Remove links from the footer than duplicate what is already present in the header navbar or easily found from other places. The footer bar is now simply a selection of links to related external sites, along with the website license and SFC information. Signed-off-by: Daniel P. Berrangé --- _incl

Re: [PATCH v6 01/11] block: Simplify QAPI_LIST_ADD

2020-10-27 Thread Markus Armbruster
Eric Blake writes: > There is no need to rely on the verbosity of the gcc/clang compiler > extension of g_new(typeof(X), 1) when we can instead use the standard > g_malloc(sizeof(X)). In general, we like g_new over g_malloc for > returning type X rather than void* to let the compiler catch more

[qemu-web PATCH v2 16/16] Add a CONTRIBUTING.md file as guidance for contributors

2020-10-27 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- CONTRIBUTING.md | 32 _config.yml | 1 + 2 files changed, 33 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 000..b5209ac --- /dev/null +++

Re: [PATCH RFC] memory: pause all vCPUs for the duration of memory transactions

2020-10-27 Thread Vitaly Kuznetsov
David Hildenbrand writes: > On 27.10.20 13:36, Vitaly Kuznetsov wrote: >> David Hildenbrand writes: >> >>> On 26.10.20 11:43, David Hildenbrand wrote: On 26.10.20 09:49, Vitaly Kuznetsov wrote: > Currently, KVM doesn't provide an API to make atomic updates to memmap > when > t

Re: [PATCH 12/15] s390: remove bios_name

2020-10-27 Thread Paolo Bonzini
On 27/10/20 09:38, Christian Borntraeger wrote: >> >> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c >> index e52182f946..a521eba673 100644 >> --- a/hw/s390x/s390-virtio-ccw.c >> +++ b/hw/s390x/s390-virtio-ccw.c >> @@ -258,7 +258,8 @@ static void ccw_init(MachineState *machi

Re: [PATCH 07/15] m68k: remove bios_name

2020-10-27 Thread Paolo Bonzini
On 26/10/20 20:11, Laurent Vivier wrote: >> /* Load kernel. */ >> if (!kernel_filename) { >> -if (qtest_enabled() || bios_name) { >> +if (qtest_enabled() || machine->firmware) { >> return; >> } >> error_report("Kernel image must be specified

Re: [PATCH] virtio: skip guest index check on device load

2020-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2020 at 01:02:59PM +, Felipe Franciosi wrote: > > > > On Oct 27, 2020, at 12:56 PM, Michael S. Tsirkin wrote: > > > > On Tue, Oct 27, 2020 at 12:53:29PM +, Felipe Franciosi wrote: > >> > >> > >>> On Oct 27, 2020, at 12:25 PM, Michael S. Tsirkin wrote: > >>> > >>> On

Re: [PATCH RFC] memory: pause all vCPUs for the duration of memory transactions

2020-10-27 Thread David Hildenbrand
Same applies to all other kinds of operations (splitting, punching out, ...) as you also mentioned. One question from a QEMU newbie though: why do you put kvm_ioctl_inhibit_begin()/kvm_ioctl_inhibit_end() to kvm_region_resize() only and not taking it all the way up to memory_region_transaction_b

[PATCH v2 1/3] coroutine: let CoQueue wake up outside a coroutine

2020-10-27 Thread marcandre . lureau
From: Marc-André Lureau The assert() was added in commit b681a1c73e15 ("block: Repair the throttling code."), when the qemu_co_queue_do_restart() function required to be running in a coroutine. It was later made unnecessary in commit a9d9235567e7 ("coroutine-lock: reschedule coroutine on the AioC

Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-27 Thread Jason Andryuk
On Tue, Oct 27, 2020 at 9:18 AM Mark Cave-Ayland wrote: > > I spent a bit of time this morning doing some further tests on Linux using 2 > machines > and a test program to check CTS and usbmon: > > usbmon when adapter unplugged: > 95a4bf2dd300 2366831506 S Ci:4:004:0 s c0 05 0002 2

Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-27 Thread Mark Cave-Ayland
On 26/10/2020 15:04, Samuel Thibault wrote: Mark Cave-Ayland, le lun. 26 oct. 2020 13:40:05 +, a ecrit: On 26/10/2020 13:00, Jason Andryuk wrote: On Mon, Oct 26, 2020 at 7:21 AM Samuel Thibault wrote: Aurelien, you introduced the "| 1" in commit abb8a13918ecc1e8160aa78582de9d5224ea70df

Re: [PATCH 01/22] semihosting: fix order of initialization functions

2020-10-27 Thread Paolo Bonzini
On 27/10/20 12:18, Alex Bennée wrote: >> >> -/* now chardevs have been created we may have semihosting to connect */ >> -qemu_semihosting_connect_chardevs(); >> - > Move both here: > > if (foreach_device_config(DEV_DEBUGCON, debugcon_parse) < 0) > exit(1); > > /* now cha

Re: [PATCH v6 11/11] qapi: Use QAPI_LIST_ADD() where possible

2020-10-27 Thread Vladimir Sementsov-Ogievskiy
27.10.2020 08:05, Eric Blake wrote: Anywhere we create a list of just one item or by prepending items (typically because order doesn't matter), we can use the now-public macro. But places where we must keep the list in order by appending remain open-coded. Signed-off-by: Eric Blake --- [..]

[qemu-web PATCH v2 06/16] Rework display of screenshots to use a carousel slider

2020-10-27 Thread Daniel P . Berrangé
We have a number of screenshots to display, with three fitted across the width of the screen. The screenshots dominate the usage of screen real estate on the front page, with other relevant information off the bottom of the page. As a step towards increasing the information density of the home scr

Re: [PATCH v7] sev: add sev-inject-launch-secret

2020-10-27 Thread Eduardo Habkost
On Thu, Oct 22, 2020 at 01:39:09AM -0400, to...@linux.ibm.com wrote: > From: Tobin Feldman-Fitzthum > > AMD SEV allows a guest owner to inject a secret blob > into the memory of a virtual machine. The secret is > encrypted with the SEV Transport Encryption Key and > integrity is guaranteed with t

[qemu-web PATCH v2 11/16] Bring contribution links out of the footer into the home page

2020-10-27 Thread Daniel P . Berrangé
The selection of contribution links are important information to present to visitors to the site. They are best placed in a prominent position on the home page rather than in the footer Signed-off-by: Daniel P. Berrangé --- _includes/footer.html | 7 --- index.html| 8 2

[qemu-web PATCH v2 13/16] Move wiki link from footer into the header navbar

2020-10-27 Thread Daniel P . Berrangé
The wiki is important enough that it should be presented more prominently in the page header navbar, rather than the footer. Signed-off-by: Daniel P. Berrangé --- _includes/footer.html | 1 - _includes/nav.html| 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/_includes/foot

[PATCH v2 2/3] console: modify ppm_save to take a pixman image ref

2020-10-27 Thread marcandre . lureau
From: Marc-André Lureau The function is going to be called from a coroutine, and may yield. Let's ensure our image reference doesn't change over time (due to resize etc) by keeping a ref. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Reviewed-by: Gerd Hoffmann --- ui/consol

Re: [PATCH RFC] memory: pause all vCPUs for the duration of memory transactions

2020-10-27 Thread Vitaly Kuznetsov
David Hildenbrand writes: >>> Same applies to all other kinds of operations (splitting, punching out, >>> ...) as you also mentioned. >> >> One question from a QEMU newbie though: why do you put >> kvm_ioctl_inhibit_begin()/kvm_ioctl_inhibit_end() to kvm_region_resize() >> only and not taking it

Re: [PATCH 6/9] dev-serial: add always-plugged property to ensure USB device is always attached

2020-10-27 Thread Mark Cave-Ayland
On 27/10/2020 08:09, Gerd Hoffmann wrote: case CHR_EVENT_OPENED: -if (!s->dev.attached) { +if (!s->always_plugged && !s->dev.attached) { usb_device_attach(&s->dev, &error_abort); } Not needed (but doesn't hurt either). Okay I'll leave this as-is

[PATCH v2 3/3] console: make QMP/HMP screendump run in coroutine

2020-10-27 Thread marcandre . lureau
From: Marc-André Lureau Thanks to the monitors' coroutine support (merge commit b7092cda1b3), the screendump handler can trigger a graphic_hw_update(), yield and let the main loop run until update is done. Then the handler is resumed, and ppm_save() will write the screen image to disk in the coro

Re: [PULL 01/17] build: fix macOS --enable-modules build

2020-10-27 Thread Paolo Bonzini
On 27/10/20 10:27, Philippe Mathieu-Daudé wrote: > I'm confused as this broke the catalina-xcode test: > > PASS 5 qtest-aarch64/device-introspect-test > /aarch64/device/introspect/abstract-interfaces > missing object type 'virtio-gpu-device' > Broken pipe > ../tests/qtest/libqtest.c:176: kill_qemu

[PATCH v2 0/3] console: make QMP screendump use coroutine

2020-10-27 Thread marcandre . lureau
From: Marc-André Lureau Hi, Thanks to recent work by Kevin, it becomes possible to run HMP/QMP commands i= n a coroutine. The screendump command is a good target, as it requires to re-enter the main-loop in ordre to flush the display, and write to file. Ideally, IO would be done with a non-block

[PATCH 03/25] block/nvme: Report warning with warn_report()

2020-10-27 Thread Philippe Mathieu-Daudé
Instead of displaying warning on stderr, use warn_report() which also displays it on the monitor. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index 739a0a700cb..6f1d7f9b2a1 100644 --- a

[PATCH 00/25] block/nvme: Fix Aarch64 host

2020-10-27 Thread Philippe Mathieu-Daudé
Add a bit of tracing, clean around to finally fix few bugs. In particular, restore NVMe on Aarch64 host. Eric Auger (4): block/nvme: Change size and alignment of IDENTIFY response buffer block/nvme: Change size and alignment of queue block/nvme: Change size and alignment of prp_list_pages

[PATCH 07/25] block/nvme: Trace queue pair creation/deletion

2020-10-27 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 3 +++ block/trace-events | 2 ++ 2 files changed, 5 insertions(+) diff --git a/block/nvme.c b/block/nvme.c index 29d2541b911..e95d59d3126 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -181,6 +181,7 @@ static void nvme_init_queue(B

[PATCH 02/25] block/nvme: Use hex format to display offset in trace events

2020-10-27 Thread Philippe Mathieu-Daudé
Use the same format used for the hw/vfio/ trace events. Suggested-by: Eric Auger Signed-off-by: Philippe Mathieu-Daudé --- block/trace-events | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/block/trace-events b/block/trace-events index 0e351c3fa3d..0955c85c783 1

[PATCH 13/25] block/nvme: Introduce Completion Queue definitions

2020-10-27 Thread Philippe Mathieu-Daudé
Rename Submission Queue flags with 'Sq' and introduce Completion Queue flag definitions. Signed-off-by: Philippe Mathieu-Daudé --- include/block/nvme.h | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/include/block/nvme.h b/include/block/nvme.h index 65e68a8

[PATCH 09/25] block/nvme: Move definitions before structure declarations

2020-10-27 Thread Philippe Mathieu-Daudé
To be able to use some definitions in structure declarations, move them earlier. No logical change. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index be14350f959..30075

[PATCH 14/25] block/nvme: Use definitions instead of magic values in add_io_queue()

2020-10-27 Thread Philippe Mathieu-Daudé
Replace magic values by definitions, and simplifiy since the number of queues will never reach 64K. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index 9324f0bfdc4..2dfcf8c41d7 10064

[PATCH 08/25] block/nvme: Simplify device reset

2020-10-27 Thread Philippe Mathieu-Daudé
Avoid multiple endianess conversion by using device endianess. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/nvme.c b/block/nvme.c index e95d59d3126..be14350f959 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -75

[PATCH 10/25] block/nvme: Use unsigned integer for queue counter/size

2020-10-27 Thread Philippe Mathieu-Daudé
We can not have negative queue count/size/index, use unsigned type. Rename 'nr_queues' as 'queue_count' to match the spec naming. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 38 ++ block/trace-events | 10 +- 2 files changed, 23 inse

[PATCH 11/25] block/nvme: Make nvme_identify() return boolean indicating error

2020-10-27 Thread Philippe Mathieu-Daudé
Just for consistency, following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), return a boolean value indicating an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

[PATCH 16/25] block/nvme: Simplify ADMIN queue access

2020-10-27 Thread Philippe Mathieu-Daudé
We don't need to dereference from BDRVNVMeState each time. Use a NVMeQueuePair pointer to the admin queue and use it. The nvme_init() becomes easier to review, matching the style of nvme_add_io_queue(). Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 12 ++-- 1 file changed, 6 i

Re: [PATCH v2] block: End quiescent sections when a BDS is deleted

2020-10-27 Thread Stefan Hajnoczi
On Fri, Oct 23, 2020 at 05:01:10PM +0200, Greg Kurz wrote: > +/** > + * End all quiescent sections started by bdrv_drain_all_begin(). This is > + * only needed when deleting a BDS before bdrv_drain_all_end() is called. > + */ > +void bdrv_drain_all_end_quiesce(BlockDriverState *bs); This function

[PATCH 12/25] block/nvme: Make nvme_init_queue() return boolean indicating error

2020-10-27 Thread Philippe Mathieu-Daudé
Just for consistency, following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), return a boolean value indicating an error is set or not. This simplifies a bit nvme_create_queue_pair(). Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 15 ++--

[PATCH 17/25] block/nvme: Simplify nvme_cmd_sync()

2020-10-27 Thread Philippe Mathieu-Daudé
As all commands use the ADMIN queue, it is pointless to pass it as argument each time. Remove the argument. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index 2d3648694b0..68

[PATCH 01/25] MAINTAINERS: Cover 'block/nvme.h' file

2020-10-27 Thread Philippe Mathieu-Daudé
The "block/nvme.h" header is shared by both the NVMe block driver and the NVMe emulated device. Add the 'F:' entry on both sections, so all maintainers/reviewers are notified when it is changed. Reviewed-by: Klaus Jensen Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 ++ 1 file chang

Re: [RFC] Using gitlab for upstream qemu repo?

2020-10-27 Thread Stefan Hajnoczi
On Mon, Oct 26, 2020 at 11:04:06AM +, Peter Maydell wrote: > On Thu, 22 Oct 2020 at 17:48, Paolo Bonzini wrote: > > now that Gitlab is the primary CI infrastructure for QEMU, and that all > > QEMU git repositories (including mirrors) are available on Gitlab, I > > would like to propose that co

[PATCH 15/25] block/nvme: Correctly initialize Admin Queue Attributes

2020-10-27 Thread Philippe Mathieu-Daudé
>From the specification chapter 3.1.8 "AQA - Admin Queue Attributes" the Admin Submission Queue Size field is a 0’s based value: Admin Submission Queue Size (ASQS): Defines the size of the Admin Submission Queue in entries. Enabling a controller while this field is cleared to 00h pr

[PATCH 19/25] block/nvme: Set request_alignment at initialization

2020-10-27 Thread Philippe Mathieu-Daudé
Commit bdd6a90a9e5 ("block: Add VFIO based NVMe driver") sets the request_alignment in nvme_refresh_limits(). For consistency, also set it during initialization. Reported-by: Stefan Hajnoczi Reviewed-by: Eric Auger Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/n

[PATCH 20/25] block/nvme: Correct minimum device page size

2020-10-27 Thread Philippe Mathieu-Daudé
While trying to simplify the code using a macro, we forgot the 12-bit shift... Correct that. Fixes: fad1eb68862 ("block/nvme: Use register definitions from 'block/nvme.h'") Reported-by: Eric Auger Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Auger Signed-off-by: Philippe Mathieu-Daudé --- b

Re: [PATCH 3/3] console: make QMP/HMP screendump run in coroutine

2020-10-27 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Oct 27, 2020 at 12:41 PM Markus Armbruster wrote: >> >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Thanks to the monitors coroutine support, the screendump handler can >> >> monitors' >> >> Suggest to add (merge commi

[PATCH 04/25] block/nvme: Trace controller capabilities

2020-10-27 Thread Philippe Mathieu-Daudé
Controllers have different capabilities and report them in the CAP register. We are particularly interested by the page size limits. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 13 + block/trace-events | 2 ++ 2 files changed, 15 inse

[PATCH 23/25] block/nvme: Change size and alignment of prp_list_pages

2020-10-27 Thread Philippe Mathieu-Daudé
From: Eric Auger In preparation of 64kB host page support, let's change the size and alignment of the prp_list_pages so that the VFIO DMA MAP succeeds with 64kB host page size. We align on the host page size. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Eric Auger Signed-off-by: Philippe

[PATCH 22/25] block/nvme: Change size and alignment of queue

2020-10-27 Thread Philippe Mathieu-Daudé
From: Eric Auger In preparation of 64kB host page support, let's change the size and alignment of the queue so that the VFIO DMA MAP succeeds. We align on the host page size. Signed-off-by: Eric Auger Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 4 ++-- 1 file changed, 2 insertion

[PULL 00/18] ppc-for-5.2 queue 20201028

2020-10-27 Thread David Gibson
The following changes since commit d55450df995d6223486db11c66491cbf6c131523: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20201026a' into staging (2020-10-27 10:25:42 +) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-5.2-2020

[PATCH 05/25] block/nvme: Trace nvme_poll_queue() per queue

2020-10-27 Thread Philippe Mathieu-Daudé
As we want to enable multiple queues, report the event in each nvme_poll_queue() call, rather than once in the callback calling nvme_poll_queues(). Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 2 +- block/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) di

[RFC PATCH 25/25] block/nvme: Fix use of write-only doorbells page on Aarch64 arch

2020-10-27 Thread Philippe Mathieu-Daudé
qemu_vfio_pci_map_bar() calls mmap(), and mmap(2) states: 'offset' must be a multiple of the page size as returned by sysconf(_SC_PAGE_SIZE). In commit f68453237b9 we started to use an offset of 4K which broke this contract on Aarch64 arch. Fix by mapping at offset 0, and and accessing door

[PULL 06/18] spapr: Unrealize vCPUs with qdev_unrealize()

2020-10-27 Thread David Gibson
From: Greg Kurz Since we introduced CPU hot-unplug in sPAPR, we don't unrealize the vCPU objects explicitly. Instead, we let QOM handle that for us under object_property_del_all() when the CPU core object is finalized. The only thing we do is calling cpu_remove_sync() to tear the vCPU thread down

[PATCH 06/25] block/nvme: Improve nvme_free_req_queue_wait() trace information

2020-10-27 Thread Philippe Mathieu-Daudé
What we want to trace is the block driver state and the queue index. Suggested-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 2 +- block/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index 8d7

[PULL 08/18] spapr: Make spapr_cpu_core_unrealize() idempotent

2020-10-27 Thread David Gibson
From: Greg Kurz spapr_cpu_core_realize() has a rollback path which partially duplicates the code of spapr_cpu_core_unrealize(). Let's make spapr_cpu_core_unrealize() idempotent and call it instead. This requires to: - move the registration and unregistration of the reset handler around but it

[PATCH 0/9] hw/riscv: microchip_pfsoc: Support factory HSS boot out of the box

2020-10-27 Thread Bin Meng
At present the DDR memory controller is not modeled, hence the factory HSS firmware does not boot out of the box on QEMU. A modified HSS is required per the instructions on [1]. This series adds the missing DDR memory controller support to PolarFire SoC, as well as adding various misc models to su

[PATCH 18/25] block/nvme: Pass AioContext argument to nvme_add_io_queue()

2020-10-27 Thread Philippe Mathieu-Daudé
We want to get ride of the BlockDriverState pointer at some point, so pass aio_context along. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index 68f0c3f7959..a0871fc2a81 100644 ---

[PULL 07/18] spapr: Drop spapr_delete_vcpu() unused argument

2020-10-27 Thread David Gibson
From: Greg Kurz The 'sc' argument is unused. Drop it. Signed-off-by: Greg Kurz Message-Id: <160279671929.1808373.10333672533575251075.st...@bahia.lan> Signed-off-by: David Gibson --- hw/ppc/spapr_cpu_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr

[PATCH 1/9] hw/misc: Add Microchip PolarFire SoC DDR Memory Controller support

2020-10-27 Thread Bin Meng
The PolarFire SoC DDR Memory Controller mainly includes 2 modules, called SGMII PHY module and the CFG module, as documented in the chipset datasheet. This creates a single file that groups these 2 modules, providing the minimum functionalities that make the HSS DDR initialization codes happy. Si

[PATCH 2/9] hw/riscv: microchip_pfsoc: Connect DDR memory controller modules

2020-10-27 Thread Bin Meng
Connect DDR SGMII PHY module and CFG module to the PolarFire SoC. Signed-off-by: Bin Meng --- hw/riscv/Kconfig | 1 + hw/riscv/microchip_pfsoc.c | 18 ++ include/hw/riscv/microchip_pfsoc.h | 5 + 3 files changed, 24 insertions(+) diff --git a/hw/

[PATCH 21/25] block/nvme: Change size and alignment of IDENTIFY response buffer

2020-10-27 Thread Philippe Mathieu-Daudé
From: Eric Auger In preparation of 64kB host page support, let's change the size and alignment of the IDENTIFY command response buffer so that the VFIO DMA MAP succeeds. We align on the host page size. Signed-off-by: Eric Auger Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathie

[PULL 10/18] pc-dimm: Drop @errp argument of pc_dimm_plug()

2020-10-27 Thread David Gibson
From: Greg Kurz pc_dimm_plug() doesn't use it. It only aborts on error. Drop @errp and adapt the callers accordingly. [dwg: Removed unused label to fix compile] Signed-off-by: Greg Kurz Message-Id: <160309728447.2739814.12831204841251148202.st...@bahia.lan> Reviewed-by: Vladimir Sementsov-Ogie

[PULL 01/18] spapr: Clarify why DR connectors aren't user creatable

2020-10-27 Thread David Gibson
From: Greg Kurz DR connector is a device that emulates a firmware abstraction used by PAPR compliant guests to manage hotplug/dynamic-reconfiguration of PHBs, PCI devices, memory, and CPUs. It is internally created by the spapr platform and requires to be owned by either the machine (PHBs, CPUs,

[PULL 14/18] spapr: Simplify error handling in spapr_memory_plug()

2020-10-27 Thread David Gibson
From: Greg Kurz As recommended in "qapi/error.h", add a bool return value to spapr_add_lmbs() and spapr_add_nvdimm(), and use them instead of local_err in spapr_memory_plug(). This allows to get rid of the error propagation overhead. Signed-off-by: Greg Kurz Message-Id: <160309734178.2739814.3

[PULL 02/18] ppc/spapr: re-assert IRQs during event-scan if there are pending

2020-10-27 Thread David Gibson
From: Laurent Vivier If we hotplug a CPU during the first second of the kernel boot, the IRQ can be sent to the kernel while the RTAS event handler is not installed. The event is queued, but the kernel doesn't collect it and ignores the new CPU. As the code relies on edge-triggered IRQ, we can r

[PATCH 24/25] block/nvme: Align iov's va and size on host page size

2020-10-27 Thread Philippe Mathieu-Daudé
From: Eric Auger Make sure iov's va and size are properly aligned on the host page size. Signed-off-by: Eric Auger Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/blo

[PULL 03/18] hw/net: move allocation to the heap due to very large stack frame

2020-10-27 Thread David Gibson
From: Elena Afanasova [dwg] The stack frame itself probably isn't that big a deal, but avoiding alloca() is generally recommended these days. Signed-off-by: Elena Afanasova Message-Id: <8f07132478469b35fb50a4706691e2b56b10a67b.ca...@gmail.com> Signed-off-by: David Gibson --- hw/net/spapr_llan

[PULL 04/18] spapr: Move spapr_create_nvdimm_dr_connectors() to core machine code

2020-10-27 Thread David Gibson
From: Greg Kurz The spapr_create_nvdimm_dr_connectors() function doesn't need to access any internal details of the sPAPR NVDIMM implementation. Also, pretty much like for the LMBs, only spapr_machine_init() is responsible for the creation of DR connectors for NVDIMMs. Make this clear by making

[PULL 15/18] spapr: Use error_append_hint() in spapr_reallocate_hpt()

2020-10-27 Thread David Gibson
From: Greg Kurz Hints should be added with the dedicated error_append_hint() API because we don't want to print them when using QMP. This requires to insert ERRP_GUARD as explained in "qapi/error.h". Signed-off-by: Greg Kurz Message-Id: <160371604030.305923.17464161378167312662.st...@bahia.lan>

[PULL 09/18] spapr: Simplify spapr_cpu_core_realize() and spapr_cpu_core_unrealize()

2020-10-27 Thread David Gibson
From: Greg Kurz Now that the error path of spapr_cpu_core_realize() is just to call idempotent spapr_cpu_core_unrealize() for rollback, no need to create and realize the vCPUs in two separate loops. Merge them and do them same in spapr_cpu_core_unrealize() for symmetry. Signed-off-by: Greg Kurz

[PULL 17/18] spapr: Improve spapr_reallocate_hpt() error reporting

2020-10-27 Thread David Gibson
From: Greg Kurz spapr_reallocate_hpt() has three users, two of which pass &error_fatal and the third one, htab_load(), passes &local_err, uses it to detect failures and simply propagates -EINVAL up to vmstate_load(), which will cause QEMU to exit. It is thus confusing that spapr_reallocate_hpt()

[PULL 11/18] spapr: Use appropriate getter for PC_DIMM_ADDR_PROP

2020-10-27 Thread David Gibson
From: Greg Kurz The PC_DIMM_ADDR_PROP property is defined as: DEFINE_PROP_UINT64(PC_DIMM_ADDR_PROP, PCDIMMDevice, addr, 0), Use object_property_get_uint() instead of object_property_get_int(). Signed-off-by: Greg Kurz Message-Id: <160309729609.2739814.4996614957953215591.st...@bahia.lan>

[PULL 13/18] spapr: Pass &error_abort when getting some PC DIMM properties

2020-10-27 Thread David Gibson
From: Greg Kurz Both PC_DIMM_SLOT_PROP and PC_DIMM_ADDR_PROP are defined in the default property list of the PC DIMM device class: DEFINE_PROP_UINT64(PC_DIMM_ADDR_PROP, PCDIMMDevice, addr, 0), DEFINE_PROP_INT32(PC_DIMM_SLOT_PROP, PCDIMMDevice, slot, PC_DIMM_UNASSIG

[PULL 05/18] spapr: Fix leak of CPU machine specific data

2020-10-27 Thread David Gibson
From: Greg Kurz When a CPU core is being removed, the machine specific data of each CPU thread object is leaked. Fix this by calling the dedicated helper we have for that instead of simply unparenting the CPU object. Call it from a separate loop in spapr_cpu_core_unrealize() for symmetry with sp

[RESEND PATCH 6/9] hw/riscv: microchip_pfsoc: Connect the SYSREG module

2020-10-27 Thread Bin Meng
From: Bin Meng Previously SYSREG was created as an unimplemented device. Now that we have a simple SYSREG module, connect it. Signed-off-by: Bin Meng --- hw/riscv/Kconfig | 1 + hw/riscv/microchip_pfsoc.c | 9 ++--- include/hw/riscv/microchip_pfsoc.h | 2 ++ 3 fi

[PULL 18/18] ppc/: fix some comment spelling errors

2020-10-27 Thread David Gibson
From: zhaolichang I found that there are many spelling errors in the comments of qemu/target/ppc. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang Reviewed-by: David Edmondson Message-Id: <20201009064449.2336-3-zhaolich...@huawei.c

[RESEND PATCH 0/9] hw/riscv: microchip_pfsoc: Support factory HSS boot out of the box

2020-10-27 Thread Bin Meng
From: Bin Meng At present the DDR memory controller is not modeled, hence the factory HSS firmware does not boot out of the box on QEMU. A modified HSS is required per the instructions on [1]. This series adds the missing DDR memory controller support to PolarFire SoC, as well as adding various

[RESEND PATCH 2/9] hw/riscv: microchip_pfsoc: Connect DDR memory controller modules

2020-10-27 Thread Bin Meng
From: Bin Meng Connect DDR SGMII PHY module and CFG module to the PolarFire SoC. Signed-off-by: Bin Meng --- hw/riscv/Kconfig | 1 + hw/riscv/microchip_pfsoc.c | 18 ++ include/hw/riscv/microchip_pfsoc.h | 5 + 3 files changed, 24 insertions(+)

[RESEND PATCH 1/9] hw/misc: Add Microchip PolarFire SoC DDR Memory Controller support

2020-10-27 Thread Bin Meng
From: Bin Meng The PolarFire SoC DDR Memory Controller mainly includes 2 modules, called SGMII PHY module and the CFG module, as documented in the chipset datasheet. This creates a single file that groups these 2 modules, providing the minimum functionalities that make the HSS DDR initialization

[RESEND PATCH 8/9] hw/riscv: microchip_pfsoc: Correct DDR memory map

2020-10-27 Thread Bin Meng
From: Bin Meng When system memory is larger than 1 GiB (high memory), PolarFire SoC maps it at address 0x10__. Address 0xC000_ and above is aliased to the same 1 GiB low memory with different cache attributes. At present QEMU maps the system memory contiguously from 0x8000_. This

[PULL 12/18] spapr: Use appropriate getter for PC_DIMM_SLOT_PROP

2020-10-27 Thread David Gibson
From: Greg Kurz The PC_DIMM_SLOT_PROP property is defined as: DEFINE_PROP_INT32(PC_DIMM_SLOT_PROP, PCDIMMDevice, slot, PC_DIMM_UNASSIGNED_SLOT), Use object_property_get_int() instead of object_property_get_uint(). Since spapr_memory_plug() only gets called if pc_dimm_p

[RESEND PATCH 3/9] hw/misc: Add Microchip PolarFire SoC IOSCB module support

2020-10-27 Thread Bin Meng
From: Bin Meng This creates a model for PolarFire SoC IOSCB [1] module. It actually contains lots of sub-modules like various PLLs to control different peripherals. Only the mininum capabilities are emulated to make the HSS DDR memory initialization codes happy. Lots of sub-modules are created as

[PULL 16/18] target/ppc: Fix kvmppc_load_htab_chunk() error reporting

2020-10-27 Thread David Gibson
From: Greg Kurz If kvmppc_load_htab_chunk() fails, its return value is propagated up to vmstate_load(). It should thus be a negative errno, not -1 (which maps to EPERM and would lure the user into thinking that the problem is necessarily related to a lack of privilege). Return the error reported

Re: [PATCH RFC] memory: pause all vCPUs for the duration of memory transactions

2020-10-27 Thread Igor Mammedov
On Tue, 27 Oct 2020 14:47:14 +0100 Vitaly Kuznetsov wrote: > David Hildenbrand writes: > > >>> Same applies to all other kinds of operations (splitting, punching out, > >>> ...) as you also mentioned. > >> > >> One question from a QEMU newbie though: why do you put > >> kvm_ioctl_inhibit_beg

Re: [PATCH v12 08/14] iotests: add #310 to test bottom node in COR driver

2020-10-27 Thread Vladimir Sementsov-Ogievskiy
22.10.2020 21:13, Andrey Shinkevich wrote: The test case #310 is similar to #216 by Max Reitz. The difference is that the test #310 involves a bottom node to the COR filter driver. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/310 | 109 ++

[RESEND PATCH 7/9] hw/riscv: microchip_pfsoc: Map debug memory

2020-10-27 Thread Bin Meng
From: Bin Meng Somehow HSS needs to access address 0 [1] for the DDR calibration data which is in the chipset's debug memory. Let's map the debug memory. [1] See the config_copy() calls in various places in ddr_setup() in the HSS source codes. Signed-off-by: Bin Meng --- hw/riscv/microch

[RESEND PATCH 4/9] hw/riscv: microchip_pfsoc: Connect the IOSCB module

2020-10-27 Thread Bin Meng
From: Bin Meng Previously IOSCB_CFG was created as an unimplemented device. With the new IOSCB model, its memory range is already covered by the IOSCB hence remove the previous unimplemented device creation in the SoC codes. Signed-off-by: Bin Meng --- hw/riscv/Kconfig | 1

Re: [RFC] Using gitlab for upstream qemu repo?

2020-10-27 Thread Peter Maydell
On Tue, 27 Oct 2020 at 14:08, Stefan Hajnoczi wrote: > Here are the users with commit access to qemu.org repos: > The people who need push access are: > * bonzini - qemu-web > * mdroth - qemu-stable > * pmaydell - qemu > * rth - qemu > * stefanha - qemu > * thuth - qemu-web > > Does this so

[RESEND PATCH 5/9] hw/misc: Add Microchip PolarFire SoC SYSREG module support

2020-10-27 Thread Bin Meng
From: Bin Meng This creates a minimum model for Microchip PolarFire SoC SYSREG module. It only implements the ENVM_CR register to tell guest software that eNVM is running at the configured divider rate. Signed-off-by: Bin Meng --- MAINTAINERS | 2 + hw/misc/Kconfig

[RESEND PATCH 9/9] hw/riscv: microchip_pfsoc: Hook the I2C1 controller

2020-10-27 Thread Bin Meng
From: Bin Meng The latest SD card image [1] released by Microchip ships a Linux kernel with built-in PolarFire SoC I2C driver support. The device tree file includes the description for the I2C1 node hence kernel tries to probe the I2C1 device during boot. It is enough to create an unimplemented

[PULL 2/3] ide: perform SRST as early as possible

2020-10-27 Thread John Snow
We don't need to wait for the falling edge. We can set BSY as soon as possible and begin immediately resetting the drive. Devices don't appear to need to take any specific action on the falling edge. Signed-off-by: John Snow Tested-by: Mark Cave-Ayland Message-id: 20201020200242.1497705-3-js...@

Re: [PULL v2 v2 0/2] Tracing patches

2020-10-27 Thread Peter Maydell
On Mon, 26 Oct 2020 at 17:05, Stefan Hajnoczi wrote: > > The following changes since commit a46e72710566eea0f90f9c673a0f02da0064acce: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201026' into > staging (2020-10-26 14:50:03 +) > > are available in the Git repository at: > >

Re: [RFC] Using gitlab for upstream qemu repo?

2020-10-27 Thread Daniel P . Berrangé
On Tue, Oct 27, 2020 at 02:08:18PM +, Stefan Hajnoczi wrote: > On Mon, Oct 26, 2020 at 11:04:06AM +, Peter Maydell wrote: > > On Thu, 22 Oct 2020 at 17:48, Paolo Bonzini wrote: > > > now that Gitlab is the primary CI infrastructure for QEMU, and that all > > > QEMU git repositories (includ

Re: [PATCH 03/25] block/nvme: Report warning with warn_report()

2020-10-27 Thread Keith Busch
On Tue, Oct 27, 2020 at 02:55:25PM +0100, Philippe Mathieu-Daudé wrote: > Instead of displaying warning on stderr, use warn_report() > which also displays it on the monitor. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

[PULL 1/3] ide: run diagnostic after SRST

2020-10-27 Thread John Snow
Software reset (SRST) should cause the diagnostic command to be run. Make an explicit call to that routine. Reported-by: Mark Cave-Ayland Tested-by: Mark Cave-Ayland Signed-off-by: John Snow Message-id: 20201020200242.1497705-2-js...@redhat.com Fixes: 55adb3c45620c31f29978f209e2a44a08d34e2da Fi

Re: [PATCH 15/15] vl: remove bios_name

2020-10-27 Thread Thomas Huth
On 26/10/2020 15.30, Paolo Bonzini wrote: > bios_name was a legacy variable used by machine code, but it is > no more. > > Signed-off-by: Paolo Bonzini > --- > include/sysemu/sysemu.h | 1 - > softmmu/vl.c| 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/include/sysemu/syse

Re: [PATCH 08/25] block/nvme: Simplify device reset

2020-10-27 Thread Keith Busch
On Tue, Oct 27, 2020 at 02:55:30PM +0100, Philippe Mathieu-Daudé wrote: > Avoid multiple endianess conversion by using device endianess. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/nvme.c b/block/n

Re: [PATCH 08/15] mips: remove bios_name

2020-10-27 Thread Philippe Mathieu-Daudé
On 10/26/20 3:30 PM, Paolo Bonzini wrote: > Cc: Philippe Mathieu-Daudé > Signed-off-by: Paolo Bonzini > --- > hw/mips/fuloong2e.c | 6 +++--- > hw/mips/jazz.c | 6 +++--- > hw/mips/malta.c | 6 +++--- > hw/mips/mipssim.c | 6 +++--- > hw/mips/r4k.c | 4 +--- > 5 files changed, 1

Re: [PATCH v12 10/14] block: include supported_read_flags into BDS structure

2020-10-27 Thread Vladimir Sementsov-Ogievskiy
22.10.2020 21:13, Andrey Shinkevich wrote: Add the new member supported_read_flags to the BlockDriverState structure. It will control the flags set for copy-on-read operations. Make the block generic layer evaluate supported read flags before they go to a block driver. Suggested-by: Vladimir Sem

Re: [PATCH 2/2] acpi/crs: Support ranges > 32b for hosts

2020-10-27 Thread Igor Mammedov
On Mon, 26 Oct 2020 12:39:24 -0700 Ben Widawsky wrote: > According to PCIe spec 5.0 Type 1 header space Base Address Registers > are defined by 7.5.1.2.1 Base Address Registers (same as Type 0). The > _CRS region should allow for the same range (up to 64b). Prior to this > change, any host bridge

[PATCH v2 4/8] dev-serial: add trace-events for baud rate and data parameters

2020-10-27 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé --- hw/usb/dev-serial.c | 3 +++ hw/usb/trace-events | 2 ++ 2 files changed, 5 insertions(+) diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c index abc316c7bf..badf8785db 100644 --- a/hw/usb

Re: [PATCH v12 11/14] copy-on-read: add support for read flags to COR-filter

2020-10-27 Thread Vladimir Sementsov-Ogievskiy
27.10.2020 17:46, Vladimir Sementsov-Ogievskiy wrote: 22.10.2020 21:13, Andrey Shinkevich wrote: Add the BDRV_REQ_COPY_ON_READ and BDRV_REQ_PREFETCH flags to the supported_read_flags of the COR-filter. Signed-off-by: Andrey Shinkevich ---   block/copy-on-read.c | 2 ++   1 file changed, 2 inser

<    1   2   3   4   5   6   >