Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Volker Rümelin
> > Thanks Paolo, > > Then only the issue regarding the pcbios/optionrom stuff remains ;-) > > make[1]: *** No rule to make target 'multiboot.bin', needed by 'all'.  Stop. > make: *** [Makefile:171: pc-bios/optionrom/all] Error 2 > make: *** Waiting for unfinished jobs > > Best, > Howard > H

Re: [RFC 0/5] NVMe passthrough: Support 64kB page host

2020-10-15 Thread Philippe Mathieu-Daudé
On 10/15/20 6:15 PM, Auger Eric wrote: Hi Philippe, On 10/15/20 3:49 PM, Philippe Mathieu-Daudé wrote: On 10/15/20 1:52 PM, Eric Auger wrote: This series allows NVMe passthrough on aarch64 with 64kB page host. Addresses and sizes of buffers which are VFIO DMA mapped are aligned with the host p

[PATCH v11 03/19] multi-process: setup PCI host bridge for remote device

2020-10-15 Thread Jagannathan Raman
PCI host bridge is setup for the remote device process. It is implemented using remote-pcihost object. It is an extension of the PCI host bridge setup by QEMU. Remote-pcihost configures a PCI bus which could be used by the remote PCI device to latch on to. Signed-off-by: Jagannathan Raman Signed-

Re: [PATCH v2 2/5] [RISCV_PM] Support CSRs required for RISC-V PM extension except for ones in hypervisor mode

2020-10-15 Thread Alexey Baturo
> Surely you don't need MMTE_MASK here because you used it when writing. > That said, don't you also need to mask vs the current priv level? > while surely it's a security bug for lower priv code to read anything related to a higher priv Now I think I get what you've meant: The spec states that for

[PATCH v11 00/19] Initial support for multi-process Qemu

2020-10-15 Thread Jagannathan Raman
Hello, This is the v11 of the patchset. Thank you very much for the review of the v10 of the series. We are glad to hear the patchset is getting in a better shape. We made changes to the following patches in this series. [PATCH v10 06/19] multi-process: define MPQemuMsg format and transmission

[PATCH v11 08/19] multi-process: Associate fd of a PCIDevice with its object

2020-10-15 Thread Jagannathan Raman
Associate the file descriptor for a PCIDevice in remote process with DeviceState object. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- MAINTAINERS | 2 + hw/i386/meson.build | 1 + hw/i386/remote-msg.c |

[PATCH v11 10/19] multi-process: introduce proxy object

2020-10-15 Thread Jagannathan Raman
From: Elena Ufimtseva Defines a PCI Device proxy object as a child of TYPE_PCI_DEVICE. Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson --- MAINTAINERS| 2 ++ hw/pci/meson.build | 1 + hw/pci/proxy.c | 98

[PATCH v11 01/19] memory: alloc RAM from file at offset

2020-10-15 Thread Jagannathan Raman
Allow RAM MemoryRegion to be created from an offset in a file, instead of allocating at offset of 0 by default. This is needed to synchronize RAM between QEMU & remote process. Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Reviewed-by: Stefan Hajn

[PATCH v11 11/19] multi-process: add proxy communication functions

2020-10-15 Thread Jagannathan Raman
From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi --- include/io/mpqemu-link.h | 4 io/mpqemu-link.c | 38 ++ 2 files changed, 42 insertions(+) di

[PATCH v11 13/19] multi-process: PCI BAR read/write handling for proxy & remote endpoints

2020-10-15 Thread Jagannathan Raman
Proxy device object implements handler for PCI BAR writes and reads. The handler uses BAR_WRITE/BAR_READ message to communicate to the remote process with the BAR address and value to be written/read. The remote process implements handler for BAR_WRITE/BAR_READ message. Signed-off-by: Jagannathan

[PATCH v11 05/19] multi-process: add qio channel function to transmit

2020-10-15 Thread Jagannathan Raman
From: Elena Ufimtseva The entire array of the memory regions and file handlers. Will be used in the next patch. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- include/io/channel.h | 24

[PATCH v11 12/19] multi-process: Forward PCI config space acceses to the remote process

2020-10-15 Thread Jagannathan Raman
From: Elena Ufimtseva The Proxy Object sends the PCI config space accesses as messages to the remote process over the communication channel TODO: Investigate if the local PCI config writes can be dropped. Without the proxy local PCI config space writes for the device, the driver in the guest tim

[PATCH v11 04/19] multi-process: setup a machine object for remote device process

2020-10-15 Thread Jagannathan Raman
remote-machine object sets up various subsystems of the remote device process. Instantiate PCI host bridge object and initialize RAM, IO & PCI memory regions. Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Reviewed-by: Stefan Hajnoczi --- MAINTAI

[PATCH v11 15/19] multi-process: create IOHUB object to handle irq

2020-10-15 Thread Jagannathan Raman
IOHUB object is added to manage PCI IRQs. It uses KVM_IRQFD ioctl to create irqfd to injecting PCI interrupts to the guest. IOHUB object forwards the irqfd to the remote process. Remote process uses this fd to directly send interrupts to the guest, bypassing QEMU. Signed-off-by: John G Johnson Si

[PATCH v11 02/19] multi-process: Add config option for multi-process QEMU

2020-10-15 Thread Jagannathan Raman
Add a configuration option to separate multi-process code Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Reviewed-by: Stefan Hajnoczi --- configure | 10 ++ meson.build | 1 + 2 files changed, 11 insertions(+) diff --git a/configure b

[PATCH v11 09/19] multi-process: setup memory manager for remote device

2020-10-15 Thread Jagannathan Raman
SyncSysMemMsg message format is defined. It is used to send file descriptors of the RAM regions to remote device. RAM on the remote device is configured with a set of file descriptors. Old RAM regions are deleted and new regions, each with an fd, is added to the RAM. Signed-off-by: Jagannathan Ram

[PATCH v11 14/19] multi-process: Synchronize remote memory

2020-10-15 Thread Jagannathan Raman
Add memory-listener object which is used to keep the view of the RAM in sync between QEMU and remote process. A MemoryListener is registered for system-memory AddressSpace. The listener sends SYNC_SYSMEM message to the remote process when memory listener commits the changes to memory, the remote pr

[PATCH v11 07/19] multi-process: Initialize message handler in remote device

2020-10-15 Thread Jagannathan Raman
Initializes the message handler function in the remote process. It is called whenever there's an event pending on QIOChannel that registers this function. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- MAINTAINERS

[PATCH v11 16/19] multi-process: Retrieve PCI info from remote process

2020-10-15 Thread Jagannathan Raman
Retrieve PCI configuration info about the remote device and configure the Proxy PCI object based on the returned information Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- hw/pci/proxy.c | 85 +

[PATCH v11 17/19] multi-process: perform device reset in the remote process

2020-10-15 Thread Jagannathan Raman
From: Elena Ufimtseva Perform device reset in the remote process when QEMU performs device reset. This is required to reset the internal state (like registers, etc...) of emulated devices Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by

[PATCH v11 18/19] multi-process: add the concept description to docs/devel/qemu-multiprocess

2020-10-15 Thread Jagannathan Raman
From: John G Johnson Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + docs/devel/index.rst | 1 + docs/devel/multi-process.rst | 966 +

[PATCH v11 19/19] multi-process: add configure and usage information

2020-10-15 Thread Jagannathan Raman
From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi --- MAINTAINERS| 2 ++ docs/multi-process.rst | 67 ++ scripts/mpqemu-launcher.py

Re: [PATCH] hw/intc: Rename NIOS2 kconfig as ALTERA_IIC

2020-10-15 Thread Philippe Mathieu-Daudé
ping? On 10/7/20 3:00 PM, Philippe Mathieu-Daudé wrote: The 'NIOS2' Kconfig symbol is used to select an generic interrupt controller, and has not much to do with the Nios2 target. Rename the symbol as 'ALTERA_IIC'. Signed-off-by: Philippe Mathieu-Daudé --- hw/intc/Kconfig | 3 +++ hw/in

[PATCH v2 2/2] pci: Disallow improper BAR registration for type 1

2020-10-15 Thread Ben Widawsky
Prevent future developers working on root complexes, root ports, or bridges that also wish to implement a BAR for those, from shooting themselves in the foot. PCI type 1 headers only support 2 base address registers. It is incorrect and difficult to figure out what is wrong with the device when thi

Re: [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands

2020-10-15 Thread Eduardo Habkost
On Mon, Oct 12, 2020 at 02:15:31PM +0200, Philippe Mathieu-Daudé wrote: > Reduce the machine code pulled into qemu-storage-daemon. > > The series is fully Acked, but Markus wants it reviewed > by the Machine core maintainers. I've confirmed that all patches move QAPI schema code without introduci

[PATCH v11 06/19] multi-process: define MPQemuMsg format and transmission functions

2020-10-15 Thread Jagannathan Raman
From: Elena Ufimtseva Defines MPQemuMsg, which is the message that is sent to the remote process. This message is sent over QIOChannel and is used to command the remote process to perform various tasks. Define transmission functions used by proxy and by remote. There are certain restrictions on w

[PATCH 1/2] pci: Change error_report to assert(3)

2020-10-15 Thread Ben Widawsky
Asserts are used for developer bugs. As registering a bar of the wrong size is not something that should be possible for a user to achieve, this is a developer bug. While here, use the more obvious helper function. Signed-off-by: Ben Widawsky --- hw/pci/pci.c | 6 +- 1 file changed, 1 inser

Re: [PATCH v2] hw/block/nand: Decommission the NAND museum

2020-10-15 Thread Philippe Mathieu-Daudé
ping^2... On 10/1/20 7:31 PM, Philippe Mathieu-Daudé wrote: ping qemu-block or qemu-arm? On 9/15/20 7:16 PM, Philippe Mathieu-Daudé wrote: This is the QEMU equivalent of this Linux commit (but 7 years later): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f7025a4

[PATCH 1/2] intel_iommu: Support IR-only mode without DMA translation

2020-10-15 Thread David Woodhouse
From: David Woodhouse By setting none of the SAGAW bits we can indicate to a guest that DMA translation isn't supported. Tested by booting Windows 10, as well as Linux guests with the fix at https://git.kernel.org/torvalds/c/c40c10 Signed-off-by: David Woodhouse --- hw/i386/intel_iommu.c

Re: [PATCH] ssi: Display chip select polarity in monitor 'info qtree'

2020-10-15 Thread Philippe Mathieu-Daudé
Cc'ing Markus for "Monitor" tree. On 10/5/20 9:44 AM, Philippe Mathieu-Daudé wrote: Hi Peter, Can you take this patch via your qemu-arm tree please? (most of SPI boards are ARM based) On 9/27/20 11:19 AM, Philippe Mathieu-Daudé wrote: It is sometime useful to verify a device chip select polar

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Yonggang Luo
On Wed, Oct 14, 2020 at 9:58 PM Paolo Bonzini wrote: > > This pull request is the last build system change for 5.2 from > me, and it is simple: similar to how we are invoking > ROM or tests/tcg "make" from the main Makefile, we now invoke ninja > to build QEMU. Unlike those cases, however, build.

[PATCH 2/2] intel_iommu: Only allow interrupt remapping to be enabled if it's supported

2020-10-15 Thread David Woodhouse
From: David Woodhouse We should probably check if we were meant to be exposing IR, before letting the guest turn the IRE bit on. Signed-off-by: David Woodhouse --- hw/i386/intel_iommu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Mark Cave-Ayland
On 15/10/2020 18:39, Volker Rümelin wrote: Thanks Paolo, Then only the issue regarding the pcbios/optionrom stuff remains ;-) make[1]: *** No rule to make target 'multiboot.bin', needed by 'all'.  Stop. make: *** [Makefile:171: pc-bios/optionrom/all] Error 2 make: *** Waiting for unfinished jo

Re: [RFC PATCH 0/3] target/mips: Make the number of TLB entries a CPU property

2020-10-15 Thread Victor Kamensky (kamensky)
Hi Guys, I looked at issue with P5600 machine under gdb of kernel. arch_check_elf from arch/mips/kernel/elf.c rejects our sysroot binaries with -ENOEXEC code, since our binaries do not have EF_MIPS_NAN2008 ELF header flag set and this CPU model does not have cpu_has_nan_legacy, i.e mips_use_nan_le

Re: [PULL 00/10] migration queue

2020-10-15 Thread Peter Xu
On Thu, Oct 15, 2020 at 11:13:44AM +0200, Thomas Huth wrote: > On 14/10/2020 22.01, Peter Xu wrote: > > On Sun, Oct 11, 2020 at 07:29:25PM +0100, Peter Maydell wrote: > >>> Migration: > >>> Dirtyrate measurement API cleanup > >>> Postcopy recovery fixes > >>> > >>> Virtiofsd: > >>> Missing qe

[PATCH] configure: fix handling of --docdir parameter

2020-10-15 Thread Bruce Rogers
Commit ca8c0909f01 changed qemu_docdir to be docdir, then later uses the qemu_docdir name in the final assignment. Unfortunately, one instance of qemu_docdir was missed: the one which comes from the --docdir parameter. This patch restores the proper handling of the --docdir parameter. Fixes: ca8c0

Re: [PATCH] configure: fix handling of --docdir parameter

2020-10-15 Thread Bruce Rogers
On Thu, 2020-10-15 at 13:02 -0600, Bruce Rogers wrote: > Commit ca8c0909f01 changed qemu_docdir to be docdir, then later uses > the > qemu_docdir name in the final assignment. Unfortunately, one instance > of > qemu_docdir was missed: the one which comes from the --docdir > parameter. > This patch

[PATCH] configure: fix handling of --docdir parameter

2020-10-15 Thread Bruce Rogers
Commit ca8c0909f01 changed qemu_docdir to be docdir, then later uses the qemu_docdir name in the final assignment. Unfortunately, one instance of qemu_docdir was missed: the one which comes from the --docdir parameter. This patch restores the proper handling of the --docdir parameter. Fixes: ca8c0

Re: [PATCH v2 01/10] softfloat: Use mulu64 for mul64To128

2020-10-15 Thread Alex Bennée
Richard Henderson writes: > Via host-utils.h, we use a host widening multiply for > 64-bit hosts, and a common subroutine for 32-bit hosts. > > Reviewed-by: David Hildenbrand > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 02/10] softfloat: Use int128.h for some operations

2020-10-15 Thread Alex Bennée
Richard Henderson writes: > Use our Int128, which wraps the compiler's __int128_t, > instead of open-coding left shifts and arithmetic. > We'd need to extend Int128 to have unsigned operations > to replace more than these three. > > Reviewed-by: David Hildenbrand > Signed-off-by: Richard Hende

Re: [PULL 00/10] machine + QOM queue, 2020-10-14

2020-10-15 Thread Peter Maydell
On Wed, 14 Oct 2020 at 15:34, Eduardo Habkost wrote: > > The following changes since commit 96292515c07e3a99f5a29540ed2f257b1ff75111: > > Merge remote-tracking branch > 'remotes/vivier2/tags/trivial-branch-for-5.2-pull-request' into staging > (2020-10-13 14:06:22 +0100) > > are available in th

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-15 Thread Mark Cave-Ayland
On 13/10/2020 18:05, BALATON Zoltan via wrote: Hello, Not related to this patch but while you're at it could you please take those patches that are already reviewed by you from this series as well? http://patchwork.ozlabs.org/project/qemu-devel/list/?series=186439 That would help cleaning u

[PATCH v2 0/2] hw/rtc/m48t59: Simplify m48t59_init()

2020-10-15 Thread Philippe Mathieu-Daudé
Since v1: - Do not remove mem_base in patch 1 (Laurent) - Pass MemoryRegion* (new patch) - Run check-qtest Philippe Mathieu-Daudé (2): hw/rtc/m48t59: Simplify m48t59_init() removing 'io_base' argument hw/rtc/m48t59: Simplify m48t59_init() passing MemoryRegion argument include/hw/rtc/m48t59.h

[PATCH v2 1/2] hw/rtc/m48t59: Simplify m48t59_init() removing 'io_base' argument

2020-10-15 Thread Philippe Mathieu-Daudé
As the 'io_base' argument of m48t59_init() is unused (set to 0), remove it to simplify. To create a device on the ISA bus, m48t59_init_isa() is the preferred function to use. Acked-by: David Gibson Reviewed-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daudé --- include/hw/rtc/m48t59.h

[PATCH v2 2/2] hw/rtc/m48t59: Simplify m48t59_init() passing MemoryRegion argument

2020-10-15 Thread Philippe Mathieu-Daudé
Pass a MemoryRegion* to m48t59_init(), directly call memory_region_add_subregion() instead of sysbus_mmio_map(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/rtc/m48t59.h | 2 +- hw/ppc/ppc405_boards.c | 2 +- hw/rtc/m48t59.c | 10 +++--- hw/sparc/sun4m.c| 3 ++-

Re: [PATCH] configure: fix handling of --docdir parameter

2020-10-15 Thread Philippe Mathieu-Daudé
On 10/15/20 9:07 PM, Bruce Rogers wrote: Commit ca8c0909f01 changed qemu_docdir to be docdir, then later uses the qemu_docdir name in the final assignment. Unfortunately, one instance of qemu_docdir was missed: the one which comes from the --docdir parameter. This patch restores the proper handli

Re: [PATCH 1/2] pci: Change error_report to assert(3)

2020-10-15 Thread Philippe Mathieu-Daudé
On 10/15/20 8:14 PM, Ben Widawsky wrote: Asserts are used for developer bugs. As registering a bar of the wrong size is not something that should be possible for a user to achieve, this is a developer bug. While here, use the more obvious helper function. Signed-off-by: Ben Widawsky --- hw/p

Re: [RFC PATCH] contrib/gitdm: Add more individual contributors

2020-10-15 Thread Michael Rolnik
Acked-by: Michael Rolnik > On Mon, Oct 12, 2020 at 8:56 AM sundeep subbaraya wrote: > Acked-by: Subbaraya Sundeep > > Thanks, > Sundeep > > On Sun, Oct 4, 2020 at 11:55 PM Philippe Mathieu-Daudé > wrote: > > > > These individual contributors have a number of contributions, > > add them to the

Re: [PATCH 1/2] pci: Change error_report to assert(3)

2020-10-15 Thread Philippe Mathieu-Daudé
On 10/15/20 9:55 PM, Philippe Mathieu-Daudé wrote: On 10/15/20 8:14 PM, Ben Widawsky wrote: Asserts are used for developer bugs. As registering a bar of the wrong size is not something that should be possible for a user to achieve, this is a developer bug. While here, use the more obvious helpe

Re: [PATCH v5] hw/avr: Add limited support for avr gpio registers

2020-10-15 Thread Michael Rolnik
Reviewed-by: Michael Rolnik On Sat, Oct 10, 2020 at 5:34 PM Heecheol Yang wrote: > Add some of these features for AVR GPIO: > > - GPIO I/O : PORTx registers > - Data Direction : DDRx registers > - DDRx toggling : PINx registers > > Following things are not supported yet: > - MCUR regis

[PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- scripts/rst-sanitize.py | 21 + tests/qapi-schema/meson.build | 5 +++-- 4 files changed, 26 insertions(+), 4 deletions(-) create mode 100644 scripts/rst-sanit

[PATCH v2 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-15 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 9

[PATCH v2 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index f839c2a557..1ce31f97b4 100755 --- a/configure +++ b/configure @@ -971,7 +971,7 @@ for opt do ;; --with-suffix=*) qemu_suffix="$optarg" ;; - --docdi

[PATCH v2 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
v1 - v2 Also move the docs configure part from configure to meson, this also fixed the pending ninjatool removal caused issue that docs can not be build under msys2/mingw Yonggang Luo (4): docs: Fixes build docs on msys2/mingw configure: the docdir option should passed to meson as is. meson

[PATCH v2 3/4] meson: Move the detection logic for sphinx to meson

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 59 +++ docs/meson.build | 4 +-- meson.build | 59 ++- meson_options.txt | 5 ++- tests/qapi-schema/meson.build | 2 +- 5

[PATCH v3 2/2] block: enable libnfs on msys2/mingw in cirrus.yml

2020-10-15 Thread Yonggang Luo
Initially, libnfs has not been enabled, and now it's fixed, so enable it on cirrus. Signed-off-by: Yonggang Luo --- .cirrus.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.cirrus.yml b/.cirrus.yml index f42ccb956a..2c6bf45e6d 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -109,6 +109,7 @

[PATCH v3 0/2] Fixes building nfs on msys2/mingw

2020-10-15 Thread Yonggang Luo
Revise the commit message of * block: enable libnfs on msys2/mingw in cirrus.yml V1-V2 Apply suggestion from Peter Lieven Yonggang Luo (2): block: Fixes nfs compiling error on msys2/mingw block: enable libnfs on msys2/mingw in cirrus.yml .cirrus.yml | 1 + block/nfs.c | 15 +++

[PATCH v3 1/2] block: Fixes nfs compiling error on msys2/mingw

2020-10-15 Thread Yonggang Luo
These compiling errors are fixed: ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory 27 | #include | ^~~~ compilation terminated. ../block/nfs.c:63:5: error: unknown type name 'blkcnt_t' 63 | blkcnt_t st_blocks; | ^~~~ ../block/nfs.c: I

Re: ide: Linux reports drive diagnostic failures on boot

2020-10-15 Thread Mark Cave-Ayland
On 13/10/2020 19:39, John Snow wrote: On 10/13/20 6:59 AM, Mark Cave-Ayland wrote: During my latest OpenBIOS boot tests I've noticed the following IDE diagnostics failure message appearing in dmesg at Linux boot time when booting from CDROM on both SPARC64 and PPC: Sorry for the inconvenien

[PATCH] meson: Only install icons and qemu.desktop if have_system

2020-10-15 Thread Bruce Rogers
These files are not needed for a linux-user only install. Signed-off-by: Bruce Rogers --- ui/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ui/meson.build b/ui/meson.build index 78ad792ffb..fb36d305ca 100644 --- a/ui/meson.build +++ b/ui/meson.build @@ -11

Re: [PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Peter Maydell
On Thu, 15 Oct 2020 at 21:13, Yonggang Luo wrote: > > Signed-off-by: Yonggang Luo > --- > docs/conf.py | 2 +- > docs/sphinx/kerneldoc.py | 2 +- > scripts/rst-sanitize.py | 21 + > tests/qapi-schema/meson.build | 5 +++-- > 4 files changed, 26

Re: [PATCH V1 18/32] osdep: import MADV_DOEXEC

2020-10-15 Thread Alex Williamson
On Thu, 8 Oct 2020 12:32:35 -0400 Steven Sistare wrote: > On 8/24/2020 6:30 PM, Alex Williamson wrote: > > On Wed, 19 Aug 2020 17:52:26 -0400 > > Steven Sistare wrote: > >> On 8/17/2020 10:42 PM, Alex Williamson wrote: > >>> On Mon, 17 Aug 2020 15:44:03 -0600 > >>> Alex Williamson wrote:

Re: [PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 4:30 AM Peter Maydell wrote: > > On Thu, 15 Oct 2020 at 21:13, Yonggang Luo wrote: > > > > Signed-off-by: Yonggang Luo > > --- > > docs/conf.py | 2 +- > > docs/sphinx/kerneldoc.py | 2 +- > > scripts/rst-sanitize.py | 21 +++

Re: [PATCH 0/3] hw/misc/mac_via: Factor generic via_irq_request() out

2020-10-15 Thread Mark Cave-Ayland
On 13/10/2020 21:49, Philippe Mathieu-Daudé wrote: The same logic is used in 4 different places: - via1_irq_request() - via2_irq_request() - via1_VBL() - via1_one_second() Extract the common function and reuse it. Philippe Mathieu-Daudé (3): hw/misc/mac_via: Make generic via_irq_request() f

[PATCH] ppc/spapr: re-assert IRQs during event-scan if there are pending

2020-10-15 Thread Laurent Vivier
If we hotplug a CPU during the first second of the kernel boot, the IRQ can be sent to the kernel while the RTAS event handler is not installed. The event is queued, but the kernel doesn't collect it and ignores the new CPU. As the code relies on edge-triggered IRQ, we can re-assert it during the

[PULL 4/5] tests/9pfs: add virtio_9p_test_path()

2020-10-15 Thread Christian Schoenebeck
This new public function virtio_9p_test_path() allows 9pfs 'local' tests to translate a path from guest scope to host scope. For instance by passing an empty string it would return the root path on host of the exported 9pfs tree. Signed-off-by: Christian Schoenebeck Message-Id: Signed-off-by: C

[PULL 1/5] tests/9pfs: change qtest name prefix to synth

2020-10-15 Thread Christian Schoenebeck
All existing 9pfs test cases are using the 'synth' fs driver so far, which means they are not accessing real files, but a purely simulated (in RAM only) file system. Let's make this clear by changing the prefix of the individual qtest case names from 'fs/' to 'synth/'. That way they'll be easily d

[PULL 5/5] tests/9pfs: add local Tmkdir test

2020-10-15 Thread Christian Schoenebeck
This test case uses the 9pfs 'local' driver to create a directory and then checks if the expected directory was actually created (as real directory) on host side. This patch introduces a custom split() implementation, because the test code requires non empty array elements as result. For that reas

[PULL 0/5] 9p queue 2020-10-15

2020-10-15 Thread Christian Schoenebeck
gs/pull-9p-20201015 for you to fetch changes up to 97a64ec211d051439b654950ed3f7cffc47d489b: tests/9pfs: add local Tmkdir test (2020-10-15 16:11:17 +0200) 9pfs: add tests using local fs driver The currently existing 9pfs test cas

[PULL 2/5] tests/9pfs: introduce local tests

2020-10-15 Thread Christian Schoenebeck
This patch introduces 9pfs test cases using the 9pfs 'local' filesystem driver which reads/writes/creates/deletes real files and directories. In this initial version, there is only one local test which actually only checks if the 9pfs 'local' device was created successfully. Before the 9pfs 'loca

[PULL 3/5] tests/9pfs: wipe local 9pfs test directory

2020-10-15 Thread Christian Schoenebeck
Before running the first 9pfs test case, make sure the test directory for running the 9pfs 'local' tests on is entirely empty. For that reason simply delete the test directory (if any) before (re)creating it on test suite startup. Note: The preferable precise behaviour would be the test directory

Re: ide: Linux reports drive diagnostic failures on boot

2020-10-15 Thread John Snow
On 10/15/20 4:17 PM, Mark Cave-Ayland wrote: On 13/10/2020 19:39, John Snow wrote: On 10/13/20 6:59 AM, Mark Cave-Ayland wrote: During my latest OpenBIOS boot tests I've noticed the following IDE diagnostics failure message appearing in dmesg at Linux boot time when booting from CDROM on both

[PATCH v2 4/5] spapr: Make spapr_cpu_core_unrealize() idempotent

2020-10-15 Thread Greg Kurz
spapr_cpu_core_realize() has a rollback path which partially duplicates the code of spapr_cpu_core_unrealize(). Let's make spapr_cpu_core_unrealize() idempotent and call it instead. This requires to: - move the registration and unregistration of the reset handler around but it is harmless, - all

[PATCH v2 3/5] spapr: Drop spapr_delete_vcpu() unused argument

2020-10-15 Thread Greg Kurz
The 'sc' argument is unused. Drop it. Signed-off-by: Greg Kurz --- hw/ppc/spapr_cpu_core.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c index e4aeb93c0299..45eb2121876e 100644 --- a/hw/ppc/spapr_cpu_core.c +++ b/hw

Re: [PULL 0/3] microblaze patch queue

2020-10-15 Thread Peter Maydell
On Thu, 15 Oct 2020 at 05:52, Richard Henderson wrote: > > The following changes since commit 57c98ea9acdcef5021f5671efa6475a5794a51c4: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20201014-pull-request' > into staging (2020-10-14 13:56:06 +0100) > > are available in the Git reposit

[PATCH v2 2/5] spapr: Unrealize vCPUs with qdev_unrealize()

2020-10-15 Thread Greg Kurz
Since we introduced CPU hot-unplug in sPAPR, we don't unrealize the vCPU objects explicitly. Instead, we let QOM handle that for us under object_property_del_all() when the CPU core object is finalized. The only thing we do is calling cpu_remove_sync() to tear the vCPU thread down. This happens to

[PATCH v2 5/5] spapr: Simplify spapr_cpu_core_realize() and spapr_cpu_core_unrealize()

2020-10-15 Thread Greg Kurz
Now that the error path of spapr_cpu_core_realize() is just to call idempotent spapr_cpu_core_unrealize() for rollback, no need to create and realize the vCPUs in two separate loops. Merge them and do them same in spapr_cpu_core_unrealize() for symmetry. Signed-off-by: Greg Kurz --- hw/ppc/spap

[PATCH v2 0/5] spapr: Fix and cleanups for sPAPR CPU core

2020-10-15 Thread Greg Kurz
While reading the code _again_ I spotted a memory leak and I realized that the realize/unrealize paths are uselessly complex and not really symmetrical. This series fixes the leak and re-shuffles the code to make it cleaner. Tested with 'make check', travis-ci and manual hotplug/unplug of CPU cor

Re: [PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Paolo Bonzini
Il gio 15 ott 2020, 22:30 Peter Maydell ha scritto: > On Thu, 15 Oct 2020 at 21:13, Yonggang Luo wrote: > > > > Signed-off-by: Yonggang Luo > > --- > > docs/conf.py | 2 +- > > docs/sphinx/kerneldoc.py | 2 +- > > scripts/rst-sanitize.py | 21 +

[PATCH v2 1/5] spapr: Fix leak of CPU machine specific data

2020-10-15 Thread Greg Kurz
When a CPU core is being removed, the machine specific data of each CPU thread object is leaked. Fix this by calling the dedicated helper we have for that instead of simply unparenting the CPU object. Call it from a separate loop in spapr_cpu_core_unrealize() for symmetry with spapr_cpu_core_reali

Re: [PATCH v2 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Paolo Bonzini
Why? Paolo Il gio 15 ott 2020, 22:11 Yonggang Luo ha scritto: > Signed-off-by: Yonggang Luo > --- > configure | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/configure b/configure > index f839c2a557..1ce31f97b4 100755 > --- a/configure > +++ b/configure > @@ -971,7

Re: [PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
It's tests, running by make On Fri, Oct 16, 2020 at 5:23 AM Paolo Bonzini wrote: > > > > Il gio 15 ott 2020, 22:30 Peter Maydell ha scritto: >> >> On Thu, 15 Oct 2020 at 21:13, Yonggang Luo wrote: >> > >> > Signed-off-by: Yonggang Luo >> > --- >> > docs/conf.py | 2 +- >> >

Re: [PATCH v2 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Grep qemu_docdir and docdir in configure, you will know why, qemu_docdir not used at all in configure, On Fri, Oct 16, 2020 at 5:24 AM Paolo Bonzini wrote: > > Why? > > Paolo > > Il gio 15 ott 2020, 22:11 Yonggang Luo ha scritto: >> >> Signed-off-by: Yonggang Luo >> --- >> configure | 3 +--

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Paolo Bonzini
Il gio 15 ott 2020, 20:49 Mark Cave-Ayland ha scritto: > Is there any reason why > https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg06997.html still > can't be > merged? > Because it's not the right approach. There is no reason why building firmware cannot be done with cross compilers, s

Re: [PATCH v2 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Paolo Bonzini
Looks good, apart from the CR removal patch that can simply be dropped. Paolo Il gio 15 ott 2020, 22:10 Yonggang Luo ha scritto: > v1 - v2 > Also move the docs configure part from > configure to meson, this also fixed the pending > ninjatool removal caused issue that docs can > not be build un

[PATCH v3 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
meson didn't support running ../scripts/kernel-do directly Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/conf.py b/docs/conf.py index 00e1b750e2..e584f68393 100644 --- a/docs/c

[PATCH v3 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
V2-V3 No need convert perl trick to python script anymore after Paolo's removal of ninjatool. Revise Meson: Move the detection logic for sphinx to meson for pass other platform by letting SPHINX_ARGS to be empty when build_docs are false v1 - v2 Also move the docs configure part from configure to

[PATCH v3 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index f839c2a557..1ce31f97b4 100755 --- a/configure +++ b/configure @@ -971,7 +971,7 @@ for opt do ;; --with-suffix=*) qemu_suffix="$optarg" ;; - --docdi

[PATCH v3 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-15 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 9

[PATCH v3 3/4] meson: Move the detection logic for sphinx to meson

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 59 +++ docs/meson.build | 4 +-- meson.build | 59 ++- meson_options.txt | 5 ++- tests/qapi-schema/meson.build | 2 +- 5

Re: [PATCH v2 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 5:53 AM Paolo Bonzini wrote: > > Looks good, apart from the CR removal patch that can simply be dropped. Resend with fixes, the CR removal patch composite two part. > > Paolo > > Il gio 15 ott 2020, 22:10 Yonggang Luo ha scritto: >> >> v1 - v2 >> Also move the docs config

[PATCH v4 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index f839c2a557..1ce31f97b4 100755 --- a/configure +++ b/configure @@ -971,7 +971,7 @@ for opt do ;; --with-suffix=*) qemu_suffix="$optarg" ;; - --docdi

[PATCH v4 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
meson didn't support running ../scripts/kernel-do directly Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/conf.py b/docs/conf.py index 00e1b750e2..e584f68393 100644 --- a/docs/c

[PATCH v4 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
V3-V4 Quic fixes of python style if xxx: tested locally V2-V3 No need convert perl trick to python script anymore after Paolo's removal of ninjatool. Revise Meson: Move the detection logic for sphinx to meson for pass other platform by letting SPHINX_ARGS to be empty when build_docs are false v1

[PATCH v4 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-15 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 9

[PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 59 +++--- docs/meson.build | 4 +-- meson.build | 60 +++ meson_options.txt | 5 ++- tests/qapi-schema/meson.build | 2 +- 5 f

Re: [PATCH v4 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Paolo Bonzini
Il ven 16 ott 2020, 00:06 Yonggang Luo ha scritto: > meson didn't support running ../scripts/kernel-do directly > Can you explain why this matters? Meson does not look at docs/conf.py. Paolo > Signed-off-by: Yonggang Luo > --- > docs/conf.py | 2 +- > docs/sphinx/kerneldoc.py |

Re: [PATCH] ppc/spapr: re-assert IRQs during event-scan if there are pending

2020-10-15 Thread Greg Kurz
On Thu, 15 Oct 2020 23:03:18 +0200 Laurent Vivier wrote: > If we hotplug a CPU during the first second of the kernel boot, > the IRQ can be sent to the kernel while the RTAS event handler > is not installed. The event is queued, but the kernel doesn't > collect it and ignores the new CPU. > > As

[RFC PATCH v2 0/4] target/mips: Make the number of TLB entries a CPU property

2020-10-15 Thread Philippe Mathieu-Daudé
Yocto developers have expressed interest in running MIPS32 CPU with preset number of TLB: https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg03428.html Help them by allowing to set the TLB entries from a preset array of valid hardware values. Please test/review, Phil. Philippe Mathieu-Dau

[RFC PATCH v2 3/4] target/mips: Make the number of TLB entries a CPU property

2020-10-15 Thread Philippe Mathieu-Daudé
Allow selecting the number of TLB entries from a preset array. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 1 + target/mips/cpu.c | 8 +++- target/mips/translate.c | 26 -- 3 files changed, 32 insertions(+), 3 deletions(-) diff --git a

<    1   2   3   4   >