[PULL 13/23] configure: fixes indent of $meson setup

2020-10-13 Thread Thomas Huth
From: Yonggang Luo convert these line from tab to space Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé Message-Id: <20201012234348.1427-2-luoyongg...@gmail.com> Signed-off-by: Thomas Huth --- configure | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --

[PULL 17/23] scripts/ci/gitlab-pipeline-status: make branch name configurable

2020-10-13 Thread Thomas Huth
From: Cleber Rosa With the utility function `get_local_staging_branch_commit()`, the name of the branch is hard coded (including in the function name). For extensibility reasons, let's make that configurable. Signed-off-by: Cleber Rosa Message-Id: <20200904164258.240278-2-cr...@redhat.com> Rev

[PULL 08/23] softmmu/vl: Be less verbose about missing KVM when running the qtests

2020-10-13 Thread Thomas Huth
Some of the qtests use "-accel kvm -accel tcg" to run real guest code. This causes some error messages when kvm is not available. We do not really care about these messages since the fallback to tcg is expected here. So let's silence them to avoid that they spoil the output of the tests. Unfortuna

[PULL 18/23] scripts/ci/gitlab-pipeline-status: improve message regarding timeout

2020-10-13 Thread Thomas Huth
From: Cleber Rosa The script has its own timeout, which is about how long the script will wait (when called with --wait) for the pipeline to complete, and not necessarily for the pipeline to complete. Hopefully this new wording will be clearer. Signed-off-by: Cleber Rosa Message-Id: <202009041

[PULL 12/23] docs/system/deprecated: Mark the 'moxie' CPU as deprecated

2020-10-13 Thread Thomas Huth
It is currently unclear whether anybody is still using the 'moxie' CPU, and there are no images for testing available this CPU, so the code has likely bit-rotten in the course of time. When I asked the maintainer for information, I did not get a reply within four weeks yet (see https://lists.gnu.or

[PULL 21/23] scripts/ci/gitlab-pipeline-status: handle keyboard interrupts

2020-10-13 Thread Thomas Huth
From: Cleber Rosa So that exits based on user requests are handled more gracefully. Signed-off-by: Cleber Rosa Message-Id: <20200904164258.240278-6-cr...@redhat.com> Signed-off-by: Thomas Huth --- scripts/ci/gitlab-pipeline-status | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) d

[PULL 10/23] MAINTAINERS: Ignore bios-tables-test in the qtest section

2020-10-13 Thread Thomas Huth
I'm very often getting CC: on rather large patch series that modify the ACPI stuff of either ARM or x86, just because the bios-table-test is often slightly involved here. I can't say much about ACPI, and the bios-table-test is already covered by the ACPI section in MAINTAINERS, so I'd rather prefer

[PULL 14/23] gitlab: add a CI job for running checkpatch.pl

2020-10-13 Thread Thomas Huth
From: Daniel P. Berrangé This job is advisory since it is expected that certain patches will fail the style checks and checkpatch.pl provides no way to mark exceptions to the rules. Signed-off-by: Daniel P. Berrangé Message-Id: <20200918132903.1848939-2-berra...@redhat.com> [thuth: Use "stage:

[PULL 19/23] scripts/ci/gitlab-pipeline-status: give early feedback on running pipelines

2020-10-13 Thread Thomas Huth
From: Cleber Rosa When waiting for a pipeline to run and finish, it's better to give early feedback, and then sleep and wait, than the other wait around. Specially for the first iteration, it's frustrating to see nothing while the script is sleeping. Signed-off-by: Cleber Rosa Message-Id: <202

[PULL 23/23] scripts/ci/gitlab-pipeline-status: wait for pipeline creation

2020-10-13 Thread Thomas Huth
From: Cleber Rosa When called in wait mode, this script will also wait for the pipeline to be get to a "running" state. Because many more status may be seen until a pipeline gets to "running", and those need to be handle too. Reference: https://docs.gitlab.com/ee/api/pipelines.html#list-project

[PULL 15/23] gitlab: add a CI job to validate the DCO sign off

2020-10-13 Thread Thomas Huth
From: Daniel P. Berrangé While checkpatch.pl can validate DCO sign off that job must always be advisory only since it is expected that certain patches will fail some code style rules. We require the DCO sign off to be mandatory for all commits though, so it benefits from being validated in a sta

[PULL 22/23] scripts/ci/gitlab-pipeline-status: use more descriptive exceptions

2020-10-13 Thread Thomas Huth
From: Cleber Rosa For two very different error conditions. Signed-off-by: Cleber Rosa Message-Id: <20200904164258.240278-7-cr...@redhat.com> Signed-off-by: Thomas Huth --- scripts/ci/gitlab-pipeline-status | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/scrip

[PULL 20/23] scripts/ci/gitlab-pipeline-status: refactor parser creation

2020-10-13 Thread Thomas Huth
From: Cleber Rosa Out of the main function. Signed-off-by: Cleber Rosa Message-Id: <20200904164258.240278-5-cr...@redhat.com> Signed-off-by: Thomas Huth --- scripts/ci/gitlab-pipeline-status | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/scripts/ci/gitlab-pipe

ide: Linux reports drive diagnostic failures on boot

2020-10-13 Thread Mark Cave-Ayland
During my latest OpenBIOS boot tests I've noticed the following IDE diagnostics failure message appearing in dmesg at Linux boot time when booting from CDROM on both SPARC64 and PPC: [9.347342] scsi host0: pata_cmd64x [9.369055] scsi host1: pata_cmd64x [9.371622] ata1: PATA max UDMA

Re: [PATCH v2] Makefile: Add *.[ch].inc files to cscope/ctags/TAGS

2020-10-13 Thread Paolo Bonzini
On 13/10/20 11:18, Greg Kurz wrote: > The code base has some C source and header files that don't get indexed > because their name ends with .inc: > > $ git ls-files "*.[ch].inc" | wc -l > 66 > > Add them to the list. > > Signed-off-by: Greg Kurz > -- > v2: add the missing \( and \) > --- > Ma

Re: [PATCH V13 8/9] hw/mips: Add Loongson-3 machine support

2020-10-13 Thread Huacai Chen
Hi, Philippe, On Mon, Oct 12, 2020 at 4:12 PM Philippe Mathieu-Daudé wrote: > > On 10/11/20 4:53 AM, Huacai Chen wrote: > > Hi, Philippe, > > > > On Sat, Oct 10, 2020 at 5:09 PM Philippe Mathieu-Daudé > > wrote: > >> > >> Hi Huacai, > >> > >> On 10/7/20 10:39 AM, Huacai Chen wrote: > >>> Add Lo

Re: [PULL 00/15] Trivial branch for 5.2 patches

2020-10-13 Thread Peter Maydell
licate 'sparc64' entry (2020-10-12 23:11:32 +0200) > > ---- > Trivial Patches Pull request 20201013 > > Compile failure on ppc64be: ../../hw/rtc/twl92230.c: In function ‘menelaus_rx’: ../../hw/rtc/twl92230.c:

Re: [PULL 09/14] qmp: Move dispatcher to a coroutine

2020-10-13 Thread Kevin Wolf
Am 13.10.2020 um 09:56 hat Philippe Mathieu-Daudé geschrieben: > On Mon, Oct 12, 2020 at 8:57 PM Ben Widawsky wrote: > > > > On 20-10-12 16:02:34, Alex Bennée wrote: > > > > > > Kevin Wolf writes: > > > > > > > Am 12.10.2020 um 13:53 hat Philippe Mathieu-Daudé geschrieben: > > > >> On 10/12/20 1:

Re: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-13 Thread Vladimir Sementsov-Ogievskiy
13.10.2020 10:49, Chenqun (kuhn) wrote: -Original Message- From: Laurent Vivier [mailto:laur...@vivier.eu] Sent: Tuesday, October 13, 2020 3:11 PM To: Li Qiang Cc: Fam Zheng ; ganqixin ; vsement...@virtuozzo.com; Zhanghailiang ; qemu-bl...@nongnu.org; Juan Quintela ; qemu-triv...@nongnu.

Re: [PULL 00/15] Trivial branch for 5.2 patches

2020-10-13 Thread Laurent Vivier
1fd9740b33c: >> >> meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200) >> >> >> Trivial Patches Pull request 20201013 >> >> -

Re: [PULL 00/15] Trivial branch for 5.2 patches

2020-10-13 Thread Thomas Huth
0b33c: >> >> meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200) >> >> >> Trivial Patches Pull request 20201013 >> >> ---

Re: [PULL 00/15] Trivial branch for 5.2 patches

2020-10-13 Thread Laurent Vivier
equest >>> >>> for you to fetch changes up to ef3a1d9fc36140f8933fbced70ee21fd9740b33c: >>> >>> meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200) >>> >>> ---

Re: [PULL 00/15] Trivial branch for 5.2 patches

2020-10-13 Thread Thomas Huth
pository at: >>>> >>>> git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request >>>> >>>> for you to fetch changes up to ef3a1d9fc36140f8933fbced70ee21fd9740b33c: >>>>

[PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-13 Thread Mark Cave-Ayland
Currently an object link property is used to pass a reference to the Heathrow PIC into the PCI host bridge so that grackle_init_irqs() can connect the PCI IRQs to the PIC itself. This can be simplified by defining the PCI IRQs as qdev gpios and then wiring up the PCI IRQs to the PIC in the Old Wor

[PATCH v2 0/3] ppc: Mac machine updates

2020-10-13 Thread Mark Cave-Ayland
Here are a few Mac machine updates from my pending patch queue. Patch 1 is split out from the QOM series I posted a few weeks ago (the other patches are all SPARC-related). Patches 2 and 3 move the IRQ wiring of the PCI host bridge from the host bridge device to the Old World and New World machine

[PULL 01/14] qemu-img-cmds.hx: Update comment that mentions Texinfo

2020-10-13 Thread Laurent Vivier
From: Markus Armbruster Missed in 3c95fdef94 "Update comments in .hx files that mention Texinfo". Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200929075824.1517969-2-arm...@redhat.com> Signed-off-by: Laurent Vivier --- qemu-img-cmds.hx | 2 +- 1 file ch

[PULL 00/14] Trivial branch for 5.2 patches

2020-10-13 Thread Laurent Vivier
branch-for-5.2-pull-request for you to fetch changes up to 6125673eaf711247405e796604204bb7d74090f4: meson.build: drop duplicate 'sparc64' entry (2020-10-13 13:33:46 +0200) Trivial Patches P

[PATCH v2 1/3] macio: don't reference serial_hd() directly within the device

2020-10-13 Thread Mark Cave-Ayland
Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the Mac Old World and New World machine level. Also remove the now obsolete comment referring to the use of serial_hd() and the setting of user_creatable to false accordingly. Signed-off-by: Mark Cave-Ayland --- hw/misc/ma

[PULL 04/14] tests/test-char: Use a proper fallthrough comment

2020-10-13 Thread Laurent Vivier
From: Thomas Huth For being able to compile with -Werror=implicit-fallthrough we need to use comments that the compiler recognizes. Use "fallthrough" instead of "no break" here. Signed-off-by: Thomas Huth Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe M

[PATCH v2 3/3] uninorth: use qdev gpios for PCI IRQs

2020-10-13 Thread Mark Cave-Ayland
Currently an object link property is used to pass a reference to the OpenPIC into the PCI host bridge so that pci_unin_init_irqs() can connect the PCI IRQs to the PIC itself. This can be simplified by defining the PCI IRQs as qdev gpios and then wiring up the PCI IRQs to the PIC in the New World m

[PULL 13/14] mingw: fix error __USE_MINGW_ANSI_STDIO redefined

2020-10-13 Thread Laurent Vivier
From: Marc-André Lureau Always put osdep.h first, and remove redundant stdlib.h include. Signed-off-by: Marc-André Lureau Reviewed-by: Peter Maydell Reviewed-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201008165953.884599-1-marcandre.lur...@redhat.com> Signed-off-by: L

RE: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-13 Thread Chenqun (kuhn)
> Le 10/10/2020 à 13:07, Chen Qun a écrit : > > This if statement judgment is redundant and it will cause a warning: > > > > migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ may > > be used uninitialized in this function [-Wmaybe-uninitialized] > >

[PULL 03/14] hw/block/nvme: Simplify timestamp sum

2020-10-13 Thread Laurent Vivier
From: Philippe Mathieu-Daudé As the 'timestamp' variable is declared as a 48-bit bitfield, we do not need to wrap the sum result. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Klaus Jensen Message-Id: <20201002075716.1657849-1-phi...@redhat.com> Signed-off-by: Laurent Vivier --- hw/bloc

[PULL 12/14] target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry

2020-10-13 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Commit 0b09be2b2f ("Nicer debug output for exceptions") added twice the same "Tag Overflow" entry, remove the extra one. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Message-Id: <20201011200112.3222822-1-f4...@amsat.org> Signed-off-by: Lauren

[PULL 02/14] target/i386/cpu: Update comment that mentions Texinfo

2020-10-13 Thread Laurent Vivier
From: Markus Armbruster Missed in commit 41fba1618b "docs/system: convert the documentation of deprecated features to rST." Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200929075824.1517969-3-arm...@redhat.com> Signed-off-by: Laurent Vivier --- target/i

[PULL 06/14] hw/acpi/piix4: Rename piix4_pm_add_propeties() to piix4_pm_add_properties()

2020-10-13 Thread Laurent Vivier
From: Greg Kurz Signed-off-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Message-Id: <160165476743.57452.2128307974125615413.st...@bahia.lan> Signed-off-by: Laurent Vivier --- hw/acpi/piix4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw

[PULL 10/14] hw/char/serial: remove duplicate .class_init in serial_mm_info

2020-10-13 Thread Laurent Vivier
From: Laurent Vivier .class_init is already set to serial_mm_class_init. Remove the duplicate entry. Fixes: 17fd1a6490b1 ("serial-mm: add "regshift" property") Cc: marcandre.lur...@redhat.com Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by:

[PULL 07/14] softmmu/memory: Log invalid memory accesses

2020-10-13 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Log invalid memory accesses with as GUEST_ERROR. This is particularly useful since commit 5d971f9e67 which reverted ("memory: accept mismatching sizes in memory_region_access_valid"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Message-Id

[PULL 09/14] block/blkdebug: fix memory leak

2020-10-13 Thread Laurent Vivier
From: Elena Afanasova Spotted by PVS-Studio Signed-off-by: Elena Afanasova Reviewed-by: Eric Blake Message-Id: <1e903f928eb3da332cc95e2a6f87243bd9fe66e4.ca...@gmail.com> Signed-off-by: Laurent Vivier --- block/blkdebug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/blkdebug.c b/

[PULL 08/14] hw/pci: Fix typo in PCI hot-plug error message

2020-10-13 Thread Laurent Vivier
From: Julia Suvorova 'occupied' is spelled like 'ocuppied' in the message. Signed-off-by: Julia Suvorova Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201006133958.600932-1-jus...@redhat.com> Signed-off-by: Laurent Vivier --- hw/pci/pci.c | 2 +- hw/ppc/spapr_pci.c | 2 +- 2 files

[PULL 05/14] vmdk: fix maybe uninitialized warnings

2020-10-13 Thread Laurent Vivier
From: Christian Borntraeger Fedora 32 gcc 10 seems to give false positives: Compiling C object libblock.fa.p/block_vmdk.c.o ../block/vmdk.c: In function ‘vmdk_parse_extents’: ../block/vmdk.c:587:5: error: ‘extent’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 587 |

[PULL 11/14] goldfish_rtc: change MemoryRegionOps endianness to DEVICE_NATIVE_ENDIAN

2020-10-13 Thread Laurent Vivier
From: Laurent Vivier The doc [1] doesn't define the endianness, but the kernel driver uses readl() to access the registers, so we can guess it depends on the architecture endianness. As riscv architecture endianness is little it might not change anything for it. Moreover, android implementation

[PULL 14/14] meson.build: drop duplicate 'sparc64' entry

2020-10-13 Thread Laurent Vivier
From: Sergei Trofimovich CC: Laurent Vivier CC: qemu-triv...@nongnu.org Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Sergei Trofimovich Message-Id: <20201012175719.2573367-1-sly...@gentoo.org> Signed-off-by: Laurent Vivier --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 delet

RE: [RFC PATCH 00/12] hw/arm/virt: Introduce cpu and cache topology support

2020-10-13 Thread Zengtao (B)
Cc valentin > -Original Message- > From: Qemu-devel > [mailto:qemu-devel-bounces+prime.zeng=hisilicon@nongnu.org] > On Behalf Of Ying Fang > Sent: Thursday, September 17, 2020 11:20 AM > To: qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; drjo...@redhat.com; Zhanghailiang; > Chen

Re: [PATCH v2 1/2] crypto: luks: fix tiny memory leak

2020-10-13 Thread Alberto Garcia
On Sun 11 Oct 2020 12:21:35 PM CEST, Maxim Levitsky wrote: > In the case when underlying block device doesn't support the > bdrv_co_delete_file interface, an 'Error' wasn't freed. > > Signed-off-by: Maxim Levitsky > --- > block/crypto.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/blo

[PATCH] accel/tcg: Add CPU_LOG_EXEC tracing for cpu_io_recompile()

2020-10-13 Thread Peter Maydell
When using -icount, it's useful for the CPU_LOG_EXEC logging to include information about when cpu_io_recompile() was called, because it alerts the reader of the log that the tracing of a previous TB execution may not actually correspond to an actually executed instruction. For instance if you're u

Re: [PATCH v2 1/2] crypto: luks: fix tiny memory leak

2020-10-13 Thread Maxim Levitsky
On Tue, 2020-10-13 at 14:26 +0200, Alberto Garcia wrote: > On Sun 11 Oct 2020 12:21:35 PM CEST, Maxim Levitsky wrote: > > In the case when underlying block device doesn't support the > > bdrv_co_delete_file interface, an 'Error' wasn't freed. > > > > Signed-off-by: Maxim Levitsky > > --- > > blo

[PATCH v2] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-13 Thread Chen Qun
A default value is provided for the variable 'bitmap_name' to avoid compiler warning. The compiler show warning: migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ may be used uninitialized in this function [-Wmaybe-uninitialized] g_strlcpy(s->bitmap_name, bitmap_name, sizeof(s

[PATCH] monitor: Fix order in monitor_cleanup()

2020-10-13 Thread Kevin Wolf
We can only destroy Monitor objects after we're sure that they are not in use by the dispatcher coroutine any more. This fixes crashes like the following where we tried to destroy a monitor mutex while the dispatcher coroutine still holds it: (gdb) bt #0 0x7fe541cf4bc5 in raise () at /lib64

Re: [PATCH] SDL: enable OpenGL context creation

2020-10-13 Thread Gerd Hoffmann
On Sun, Oct 04, 2020 at 12:42:21PM +0200, Jan Henrik Weinstock wrote: > We need to specify SDL_WINDOW_OPENGL if we want to create an OpenGL context > on it, i.e. when using '-device virtio-gpu-pci,virgl=on' > > Signed-off-by: Jan Henrik Weinstock Added to ui patch queue. thanks, Gerd

Re: [PATCH 10/12] input: Use class properties

2020-10-13 Thread Gerd Hoffmann
On Fri, Oct 09, 2020 at 12:01:20PM -0400, Eduardo Habkost wrote: > Instance properties make introspection hard and are not shown by > "-object ...,help". Convert them to class properties. > > Signed-off-by: Eduardo Habkost Acked-by: Gerd Hoffmann

Re: [PULL 00/23] qtests, gitlab-CI and misc patches

2020-10-13 Thread Peter Maydell
On Tue, 13 Oct 2020 at 11:55, Thomas Huth wrote: > > Hi Peter, > > the following changes since commit a0bdf866873467271eff9a92f179ab0f77d735cb: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20201012a' into staging (2020-10-12 > 13:12:04 +0100) > > are available in t

Re: [PATCH 1/1] mips: add 34Kf-64tlb fictitious cpu type like 34Kf but with 64 TLBs

2020-10-13 Thread Philippe Mathieu-Daudé
On 10/12/20 10:36 PM, Victor Kamensky wrote: In Yocto Project CI runs it was observed that test run of 32 bit mips image takes almost twice longer than 64 bit mips image with the same logical load and CI execution hits timeout. See https://bugzilla.yoctoproject.org/show_bug.cgi?id=13992 Yocto p

Re: [PATCH] qom: Fix "typddef" typo

2020-10-13 Thread Eduardo Habkost
On Mon, Oct 12, 2020 at 03:45:12PM +0100, Daniel P. Berrangé wrote: > On Wed, Oct 07, 2020 at 06:02:55PM -0400, Eduardo Habkost wrote: > > Fix typo introduced in the C11 #ifdef for qemu_max_align_t. It > > never caused any problems because we always compile using > > -std=gnu99. > > > > Fixes: 4c

Re: [PATCH v2 1/8] migration: Do not use C99 // comments

2020-10-13 Thread Bihong Yu
Thank you for your review. OK, I will try to rewrite the DPRINTF to use trace_ instead. On 2020/10/13 17:39, Dr. David Alan Gilbert wrote: > * Bihong Yu (yubih...@huawei.com) wrote: >> Signed-off-by: Bihong Yu >> Reviewed-by: Chuan Zheng > > Reviewed-by: Dr. David Alan Gilbert > > another ta

Re: Using virtio-vhost-user or vhost-pci

2020-10-13 Thread Stefan Hajnoczi
On Tue, Oct 13, 2020 at 02:14:22AM +0300, Nikos Dragazis wrote: > On 12/10/20 10:22 μ.μ., Cosmin Chenaru wrote: > > I am currently running multiple VMs, connected in between by the DPDK > > vhost-switch. A VM can start, reboot, shutdown, so much of this is dynamic > > and the vhost-switch handles

[RFC PATCH 0/3] target/mips: Make the number of TLB entries a CPU property

2020-10-13 Thread Philippe Mathieu-Daudé
Yocto developers have expressed interest in running MIPS32 CPU with custom number of TLB: https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg03428.html Help them by making the number of TLB entries a CPU property, keeping our set of CPU definitions in sync with real hardware. Please test/re

[RFC PATCH 1/3] target/mips: Make cpu_mips_realize_env() propagate Error

2020-10-13 Thread Philippe Mathieu-Daudé
To be able to propagate error to our caller, make cpu_mips_realize_env() take an Error argument and return a boolean value indicating an error is set or not, following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"). Signed-off-by: Philippe Mathieu-Daudé -

[RFC PATCH 2/3] target/mips: Store number of TLB entries in CPUMIPSState

2020-10-13 Thread Philippe Mathieu-Daudé
As we want to make the number of TLB entries configurable, store it in CPUMIPSState. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.h| 1 + target/mips/translate.c | 4 +++- target/mips/translate_init.c.inc | 2 +- 3 files changed, 5 insertions(+), 2 deletions

[RFC PATCH 3/3] target/mips: Make the number of TLB entries a CPU property

2020-10-13 Thread Philippe Mathieu-Daudé
Allow changing the number of TLB entries for testing/tunning purpose. Example to force a 34Kf cpu with 64 TLB: $ qemu-system-mipsel -cpu 34Kf,tlb-entries=64 ... This is helpful for developers of the Yocto Project [*]: Yocto Project uses qemu-system-mips 34Kf cpu model, to run 32bit MIPS C

Re: [PATCH] monitor: Fix order in monitor_cleanup()

2020-10-13 Thread Ben Widawsky
On 20-10-13 14:50:27, Kevin Wolf wrote: > We can only destroy Monitor objects after we're sure that they are not > in use by the dispatcher coroutine any more. This fixes crashes like the > following where we tried to destroy a monitor mutex while the dispatcher > coroutine still holds it: > > (g

Re: [PATCH 06/10] coroutine: add libucontext as external library

2020-10-13 Thread Stefan Hajnoczi
On Mon, Oct 12, 2020 at 04:29:35PM -0700, Joelle van Dyne wrote: > From: osy > > iOS does not support ucontext natively for aarch64 and the sigaltstack is > also unsupported (even worse, it fails silently, see: > https://openradar.appspot.com/13002712 ) > > As a workaround we include a library i

Re: [PATCH 05/10] slirp: update for iOS resolv fix

2020-10-13 Thread Philippe Mathieu-Daudé
On 10/13/20 1:29 AM, Joelle van Dyne wrote: From: osy We cannot access /etc/resolv.conf on iOS so libslirp is modified to use libresolv instead. Signed-off-by: Joelle van Dyne --- .gitmodules | 2 +- meson.build | 2 ++ slirp | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-)

Re: [PATCH v2 4/8] migration: Open brace '{' following struct go on the same line

2020-10-13 Thread Dr. David Alan Gilbert
* Bihong Yu (yubih...@huawei.com) wrote: > Signed-off-by: Bihong Yu > Reviewed-by: Chuan Zheng Yes, I think that line probably predates the coding standard :-) Reviewed-by: Dr. David Alan Gilbert > --- > migration/migration.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > di

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-13 Thread Philippe Mathieu-Daudé
On 10/13/20 1:49 PM, Mark Cave-Ayland wrote: Currently an object link property is used to pass a reference to the Heathrow PIC into the PCI host bridge so that grackle_init_irqs() can connect the PCI IRQs to the PIC itself. This can be simplified by defining the PCI IRQs as qdev gpios and then w

Re: [PATCH v2 3/3] uninorth: use qdev gpios for PCI IRQs

2020-10-13 Thread BALATON Zoltan via
On Tue, 13 Oct 2020, Mark Cave-Ayland wrote: Currently an object link property is used to pass a reference to the OpenPIC into the PCI host bridge so that pci_unin_init_irqs() can connect the PCI IRQs to the PIC itself. This can be simplified by defining the PCI IRQs as qdev gpios and then wirin

Re: [PATCH v2 3/3] uninorth: use qdev gpios for PCI IRQs

2020-10-13 Thread Philippe Mathieu-Daudé
On 10/13/20 1:49 PM, Mark Cave-Ayland wrote: Currently an object link property is used to pass a reference to the OpenPIC into the PCI host bridge so that pci_unin_init_irqs() can connect the PCI IRQs to the PIC itself. This can be simplified by defining the PCI IRQs as qdev gpios and then wirin

Re: [PATCH V13 8/9] hw/mips: Add Loongson-3 machine support

2020-10-13 Thread Philippe Mathieu-Daudé
On 10/13/20 1:12 PM, Huacai Chen wrote: Hi, Philippe, On Mon, Oct 12, 2020 at 4:12 PM Philippe Mathieu-Daudé wrote: On 10/11/20 4:53 AM, Huacai Chen wrote: Hi, Philippe, On Sat, Oct 10, 2020 at 5:09 PM Philippe Mathieu-Daudé wrote: Hi Huacai, On 10/7/20 10:39 AM, Huacai Chen wrote: Add

Re: [PATCH 08/10] tcg: mirror mapping RWX pages for iOS optional

2020-10-13 Thread Paolo Bonzini
On 13/10/20 01:29, Joelle van Dyne wrote: > From: osy > > This allows jailbroken devices with entitlements to switch the option off. > > Signed-off-by: Joelle van Dyne > --- What is the advantage in doing so? Paolo

Re: [PULL 00/14] Trivial branch for 5.2 patches

2020-10-13 Thread Peter Maydell
licate 'sparc64' entry (2020-10-13 13:33:46 +0200) > > ---- > Trivial Patches Pull request 20201013 > > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 for any user-visible changes. -- PMM

Re: [PATCH 09/10] tcg: support JIT on Apple Silicon

2020-10-13 Thread Paolo Bonzini
On 13/10/20 01:29, Joelle van Dyne wrote: > From: osy > > https://developer.apple.com/documentation/apple_silicon/porting_just-in-time_compilers_to_apple_silicon > > For < iOS 14, reverse engineered functions from libsystem_pthread.dylib is > implemented to handle APRR supported SoCs. > > The f

[PATCH v2 0/3] Add Xen CpusAccel

2020-10-13 Thread Jason Andryuk
Xen was left behind when CpusAccel became mandatory and fails the assert in qemu_init_vcpu(). It relied on the same dummy cpu threads as qtest. Move the qtest cpu functions to a common location and reuse them for Xen. v2: New patch "accel: Remove _WIN32 ifdef from qtest-cpus.c" Use accel/dumm

[PATCH v2 1/3] accel: Remove _WIN32 ifdef from qtest-cpus.c

2020-10-13 Thread Jason Andryuk
dummy-cpus.c is only compiled with CONFIG_POSIX, so the _WIN32 condition will never evaluate true. Remove it. Signed-off-by: Jason Andryuk --- v2: New in v2 --- accel/qtest/qtest-cpus.c | 5 - 1 file changed, 5 deletions(-) diff --git a/accel/qtest/qtest-cpus.c b/accel/qtest/qtest-cpus.c i

[PATCH v2 2/3] accel: move qtest CpusAccel functions to a common location

2020-10-13 Thread Jason Andryuk
Move and rename accel/qtest/qtest-cpus.c files to accel/dummy-cpus.c so it can be re-used by Xen. Signed-off-by: Jason Andryuk --- v2: - Use accel/dummy-cpus.c - Put prototype in include/sysemu/cpus.h --- accel/{qtest/qtest-cpus.c => dummy-cpus.c} | 22 -- accel/meson.buil

Re: [PATCH v2 1/3] accel: Remove _WIN32 ifdef from qtest-cpus.c

2020-10-13 Thread Claudio Fontana
On 10/13/20 4:05 PM, Jason Andryuk wrote: > dummy-cpus.c is only compiled with CONFIG_POSIX, so the _WIN32 condition > will never evaluate true. Remove it. > > Signed-off-by: Jason Andryuk > --- > v2: New in v2 > --- > accel/qtest/qtest-cpus.c | 5 - > 1 file changed, 5 deletions(-) > > di

[PATCH v2 3/3] accel: Add xen CpusAccel using dummy-cpus

2020-10-13 Thread Jason Andryuk
Xen was broken by commit 1583a3898853 ("cpus: extract out qtest-specific code to accel/qtest"). Xen relied on qemu_init_vcpu() calling qemu_dummy_start_vcpu() in the default case, but that was replaced by g_assert_not_reached(). Add a minimal "CpusAccel" for Xen using the dummy-cpus implementatio

Re: [PATCH 09/10] tcg: support JIT on Apple Silicon

2020-10-13 Thread Peter Maydell
On Tue, 13 Oct 2020 at 14:58, Paolo Bonzini wrote: > > On 13/10/20 01:29, Joelle van Dyne wrote: > > From: osy > > > > https://developer.apple.com/documentation/apple_silicon/porting_just-in-time_compilers_to_apple_silicon > > > > For < iOS 14, reverse engineered functions from libsystem_pthread.

Re: [PATCH v2 2/3] accel: move qtest CpusAccel functions to a common location

2020-10-13 Thread Claudio Fontana
On 10/13/20 4:05 PM, Jason Andryuk wrote: > Move and rename accel/qtest/qtest-cpus.c files to accel/dummy-cpus.c so > it can be re-used by Xen. > > Signed-off-by: Jason Andryuk > > --- > v2: > - Use accel/dummy-cpus.c > - Put prototype in include/sysemu/cpus.h > --- > accel/{qtest/qtest-cpus.

Re: [PATCH v2 3/3] accel: Add xen CpusAccel using dummy-cpus

2020-10-13 Thread Claudio Fontana
On 10/13/20 4:05 PM, Jason Andryuk wrote: > Xen was broken by commit 1583a3898853 ("cpus: extract out qtest-specific > code to accel/qtest"). Xen relied on qemu_init_vcpu() calling > qemu_dummy_start_vcpu() in the default case, but that was replaced by > g_assert_not_reached(). > > Add a minimal

[PATCH] qmp-shell: Sort by key when pretty-printing

2020-10-13 Thread David Edmondson
If the user selects pretty-printing (-p) the contents of any dictionaries in the output are sorted by key. Signed-off-by: David Edmondson --- scripts/qmp/qmp-shell | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell index c5eef06f3f..

[PATCH] pci: Disallow improper BAR registration for type 1

2020-10-13 Thread Ben Widawsky
This patch informs future developers working on root complexes, root ports, or bridges that also wish to implement a BAR for those. PCI type 1 headers only support 2 base address registers. It is incorrect and difficult to figure out what is wrong with the device when this mistake is made. With thi

Re: [PULL 5/7] gitlab-ci: Move edk2 and opensbi YAML files to .gitlab-ci.d folder

2020-10-13 Thread Philippe Mathieu-Daudé
On 10/12/20 4:01 PM, Daniel P. Berrangé wrote: On Mon, Oct 12, 2020 at 03:44:00PM +0200, Philippe Mathieu-Daudé wrote: Hi Thomas, Alex, +Daniel On 5/28/20 12:10 PM, Thomas Huth wrote: We have a dedicated folder for the gitlab-ci - so there is no need to clutter the top directory with these .y

Re: [PATCH] qmp-shell: Sort by key when pretty-printing

2020-10-13 Thread Philippe Mathieu-Daudé
On 10/13/20 4:14 PM, David Edmondson wrote: If the user selects pretty-printing (-p) the contents of any dictionaries in the output are sorted by key. Signed-off-by: David Edmondson --- scripts/qmp/qmp-shell | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qmp/qmp-

Re: [PATCH 08/10] hw/isa: Add the ISA_IRQ_NET_DEFAULT definition

2020-10-13 Thread Stefan Berger
On 10/13/20 3:23 AM, Gerd Hoffmann wrote: On Sun, Oct 11, 2020 at 09:32:27PM +0200, Philippe Mathieu-Daudé wrote: The network devices use IRQ #9 by default. Add this default definition to the IsaIrqNumber enum. IRQ #9 seems to be sort-of standard for acpi. Not sure whenever that is actually w

Re: [PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition

2020-10-13 Thread Stefan Berger
On 10/13/20 4:26 AM, Philippe Mathieu-Daudé wrote: On 10/13/20 9:20 AM, Gerd Hoffmann wrote: On Sun, Oct 11, 2020 at 09:32:23PM +0200, Philippe Mathieu-Daudé wrote: The TPM TIS device uses IRQ #5 by default. Add this default definition to the IsaIrqNumber enum. IRQ 5 has no fixed assig

Re: [PATCH qemu 4/4] iotests: add test for bitmap mirror

2020-10-13 Thread Max Reitz
On 02.10.20 10:23, Fabian Grünbichler wrote: > On October 1, 2020 7:31 pm, Max Reitz wrote: >> On 22.09.20 11:14, Fabian Grünbichler wrote: >>> heavily based on/practically forked off iotest 257 for bitmap backups, >>> but: >>> >>> - no writes to filter node 'mirror-top' between completion and >>>

[PATCH v3 0/3] unbreak non-tcg builds

2020-10-13 Thread Claudio Fontana
This series now unbreaks current non-tcg builds (!CONFIG_TCG). tests Makefiles need to avoid relying on all non-native archs binaries to be present, bios-tables-test needs to skip tests that are tcg-only, and notably the replay framework needs to consider that it might not be functional (or its

[PATCH v3 2/3] qtest: unbreak non-TCG builds in bios-tables-test

2020-10-13 Thread Claudio Fontana
the tests assume TCG is available, thus breaking for TCG-only tests, where only the TCG accelerator option is passed to the QEMU binary. Suggested-by: Paolo Bonzini Acked-by: Paolo Bonzini Signed-off-by: Claudio Fontana --- tests/qtest/bios-tables-test.c | 10 ++ 1 file changed, 10 ins

[PATCH v3 1/3] tests/Makefile.include: unbreak non-tcg builds

2020-10-13 Thread Claudio Fontana
From: Paolo Bonzini remove dependency of check-block from non-native archs Signed-off-by: Claudio Fontana --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 5aca98e60c..4037490b69 100644 --- a/tes

[PATCH v3 3/3] replay: do not build if TCG is not available

2020-10-13 Thread Claudio Fontana
this fixes non-TCG builds broken recently by replay reverse debugging. stub the needed functions in stub/, including errors for hmp and qmp. change hooks for the case when replay code is disabled (!CONFIG_TCG), as we need to avoid sinking all the events in replay in this case. Surprisingly, only

Re: [PATCH 04/10] meson: option to build as shared library

2020-10-13 Thread BALATON Zoltan via
On Tue, 13 Oct 2020, Daniel P. Berrangé wrote: On Mon, Oct 12, 2020 at 04:29:33PM -0700, Joelle van Dyne wrote: From: osy On iOS, we cannot fork() new processes, so the best way to load QEMU into an app is through a shared library. We add a new configure option `--enable-shared-lib` that will

Re: [PATCH 05/10] slirp: update for iOS resolv fix

2020-10-13 Thread Marc-André Lureau
Hi On Tue, Oct 13, 2020 at 5:34 PM Philippe Mathieu-Daudé wrote: > On 10/13/20 1:29 AM, Joelle van Dyne wrote: > > From: osy > > > > We cannot access /etc/resolv.conf on iOS so libslirp is modified to use > > libresolv instead. > > > > Signed-off-by: Joelle van Dyne > > --- > > .gitmodules |

Re: [PATCH 04/10] meson: option to build as shared library

2020-10-13 Thread Daniel P . Berrangé
On Tue, Oct 13, 2020 at 04:41:06PM +0200, BALATON Zoltan wrote: > On Tue, 13 Oct 2020, Daniel P. Berrangé wrote: > > On Mon, Oct 12, 2020 at 04:29:33PM -0700, Joelle van Dyne wrote: > > > From: osy > > > > > > On iOS, we cannot fork() new processes, so the best way to load QEMU into > > > an > >

Re: [PATCH v2] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-13 Thread Max Reitz
On 13.10.20 14:33, Chen Qun wrote: > A default value is provided for the variable 'bitmap_name' to avoid compiler > warning. > > The compiler show warning: > migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ > may be used uninitialized in this function [-Wmaybe-uninitialized] >

Re: [PATCH 06/10] coroutine: add libucontext as external library

2020-10-13 Thread BALATON Zoltan via
On Tue, 13 Oct 2020, Stefan Hajnoczi wrote: On Mon, Oct 12, 2020 at 04:29:35PM -0700, Joelle van Dyne wrote: From: osy iOS does not support ucontext natively for aarch64 and the sigaltstack is also unsupported (even worse, it fails silently, see: https://openradar.appspot.com/13002712 ) As a

Re: [PATCH v3 0/3] unbreak non-tcg builds

2020-10-13 Thread Philippe Mathieu-Daudé
On 10/13/20 4:38 PM, Claudio Fontana wrote: This series now unbreaks current non-tcg builds (!CONFIG_TCG). tests Makefiles need to avoid relying on all non-native archs binaries to be present, bios-tables-test needs to skip tests that are tcg-only, and notably the replay framework needs to con

Re: [PATCH 07/10] tcg: implement bulletproof JIT

2020-10-13 Thread BALATON Zoltan via
On Mon, 12 Oct 2020, Joelle van Dyne wrote: From: osy On iOS, we cannot allocate RWX pages without special entitlements. As a workaround, we can a RX region and then mirror map it to a separate RX Missing a verb here: "we can a RX region" region. Then we can write to one region and execute

Re: [PATCH 05/10] slirp: update for iOS resolv fix

2020-10-13 Thread Philippe Mathieu-Daudé
On 10/13/20 4:38 PM, Marc-André Lureau wrote: Hi On Tue, Oct 13, 2020 at 5:34 PM Philippe Mathieu-Daudé mailto:phi...@redhat.com>> wrote: On 10/13/20 1:29 AM, Joelle van Dyne wrote: > From: osy mailto:os...@users.noreply.github.com>> > > We cannot access /etc/resolv.conf on

Re: [PATCH 01/14] arc: Add initial core cpu files

2020-10-13 Thread Cupertino Miranda
Hi Philippe, Thank you for your time reviewing our patches. My apologies for reacting to it so late. :-( Once we decided to make this port we noticed that Michael Rolnik had submitt a port for ARC700 to QEMU mailinglist. As we tested it, we decided to use his directory structure, and for that rea

Re: [PATCH 12/14] arc: Add Synopsys ARC emulation boards

2020-10-13 Thread Cupertino Miranda
Hi Philippe, On Wed, Oct 7, 2020 at 5:31 AM Philippe Mathieu-Daudé wrote: > > Hi Cupertino, Claudiu, > > On 9/30/20 10:46 PM, cupertinomira...@gmail.com wrote: > > From: Claudiu Zissulescu > > > > Add the Synopsys ARC boards, arc_sim for testing, sim-hs main emulation > > board using standard UA

<    1   2   3   4   >