[PULL 13/15] target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry

From: Philippe Mathieu-Daudé Commit 0b09be2b2f ("Nicer debug output for exceptions") added twice the same "Tag Overflow" entry, remove the extra one. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Message-Id: <20201011200112.3222822-1-f4...@amsat.org> Signed-off-by: Lauren

[PULL 15/15] meson.build: drop duplicate 'sparc64' entry

From: Sergei Trofimovich CC: Laurent Vivier CC: qemu-triv...@nongnu.org Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Sergei Trofimovich Message-Id: <20201012175719.2573367-1-sly...@gentoo.org> Signed-off-by: Laurent Vivier --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PULL 06/15] vmdk: fix maybe uninitialized warnings

From: Christian Borntraeger Fedora 32 gcc 10 seems to give false positives: Compiling C object libblock.fa.p/block_vmdk.c.o ../block/vmdk.c: In function ‘vmdk_parse_extents’: ../block/vmdk.c:587:5: error: ‘extent’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 587 |

[PULL 11/15] hw/char/serial: remove duplicate .class_init in serial_mm_info

From: Laurent Vivier .class_init is already set to serial_mm_class_init. Remove the duplicate entry. Fixes: 17fd1a6490b1 ("serial-mm: add "regshift" property") Cc: marcandre.lur...@redhat.com Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by:

[PULL 04/15] hw/block/nvme: Simplify timestamp sum

From: Philippe Mathieu-Daudé As the 'timestamp' variable is declared as a 48-bit bitfield, we do not need to wrap the sum result. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Klaus Jensen Message-Id: <20201002075716.1657849-1-phi...@redhat.com> Signed-off-by: Laurent Vivier --- hw/bloc

[PULL 14/15] mingw: fix error __USE_MINGW_ANSI_STDIO redefined

From: Marc-André Lureau Always put osdep.h first, and remove redundant stdlib.h include. Signed-off-by: Marc-André Lureau Reviewed-by: Peter Maydell Reviewed-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201008165953.884599-1-marcandre.lur...@redhat.com> Signed-off-by: L

Re: Why guest physical addresses are not the same as the corresponding host virtual addresses in QEMU/KVM? Thanks!

On Tue, Oct 13, 2020 at 01:33:28AM -0400, harry harry wrote: > > > Do you mean that GPAs are different from their corresponding HVAs when > > > KVM does the walks (as you said above) in software? > > > > What do you mean by "different"? GPAs and HVAs are two completely > different > > address spac

Re: [PATCH] hw/usb/hcd-dwc2: fix divide-by-zero in dwc2_handle_packet()

> > +if (mps == 0) { > > +qemu_log_mask(LOG_GUEST_ERROR, > > +"%s: Bad HCCHAR_MPS set to zero\n", __func__); > > +return; > > +} > I think it would be better to move this check earlier in the function, > just after 'mps' is read from the

Re: [PATCH 5/6] hw/arm/npcm7xx: Add EHCI and OHCI controllers

On Thu, Oct 08, 2020 at 04:21:53PM -0700, Havard Skinnemoen wrote: > The NPCM730 and NPCM750 chips have a single USB host port shared between > a USB 2.0 EHCI host controller and a USB 1.1 OHCI host controller. This > adds support for both of them. > > Testing notes: > * With -device usb-kbd, qe

Re: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

Le 13/10/2020 à 03:34, Li Qiang a écrit : > Laurent Vivier 于2020年10月12日周一 下午11:33写道： >> >> Le 10/10/2020 à 13:07, Chen Qun a écrit : >>> This if statement judgment is redundant and it will cause a warning: >>> >>> migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ may be used >>> unin

Re: [PATCH 03/10] hw/isa: Add the ISA_IRQ_SER_DEFAULT definition

On Sun, Oct 11, 2020 at 09:32:22PM +0200, Philippe Mathieu-Daudé wrote: > The first serial port uses IRQ #4 by default. Add this ^ > +ISA_IRQ_SER_DEFAULT = 4, ... so name this SER1 maybe? And add SER2 = 3? take care, Gerd

Re: [PATCH] hw/usb/hcd-dwc2: fix divide-by-zero in dwc2_handle_packet()

Hi Gerd, On Tue, Oct 13, 2020 at 12:04 AM Gerd Hoffmann wrote: > > > > +if (mps == 0) { > > > +qemu_log_mask(LOG_GUEST_ERROR, > > > +"%s: Bad HCCHAR_MPS set to zero\n", __func__); > > > +return; > > > +} > > > I think it would be better

Re: [PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition

On Sun, Oct 11, 2020 at 09:32:23PM +0200, Philippe Mathieu-Daudé wrote: > The TPM TIS device uses IRQ #5 by default. Add this > default definition to the IsaIrqNumber enum. IRQ 5 has no fixed assignment. All kinds of add-on isa cards (sound, net) used to use irq #5 by default because that one wa

Re: [PATCH 08/10] hw/isa: Add the ISA_IRQ_NET_DEFAULT definition

On Sun, Oct 11, 2020 at 09:32:27PM +0200, Philippe Mathieu-Daudé wrote: > The network devices use IRQ #9 by default. Add this > default definition to the IsaIrqNumber enum. IRQ #9 seems to be sort-of standard for acpi. Not sure whenever that is actually written down somewhere. IIRC in pre-ACPI

Re: [PATCH 10/10] hw/isa: Add the ISA_IRQ_IDE_DEFAULT definition

On Sun, Oct 11, 2020 at 09:32:29PM +0200, Philippe Mathieu-Daudé wrote: > The IDE controller uses IRQ #14 by default. Add this > default definition to the IsaIrqNumber enum. primary, while secondary uses IRQ 15. take care, Gerd

RE: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

migration/block-dirty-bitmap.c > > > b/migration/block-dirty-bitmap.c index 5bef793ac0..e09ea4f22b 100644 > > > --- a/migration/block-dirty-bitmap.c > > > +++ b/migration/block-dirty-bitmap.c > > > @@ -1084,9 +1084,7 @@ static int dirty_bitmap_load_header(QEMUFile > *f, DBMLoadState *s, > > >

Re: [PATCH v4 2/3] qga: add implementation of guest-get-disks for Linux

Hi On Mon, Oct 12, 2020 at 12:36 PM Tomáš Golembiovský wrote: > The command lists all disks (real and virtual) as well as disk > partitions. For each disk the list of dependent disks is also listed and > /dev path is used as a handle so it can be matched with "name" field of > other returned dis

Re: [PATCH] spapr: Move spapr_create_nvdimm_dr_connectors() to core machine code

On Tue, 13 Oct 2020 11:40:14 +1100 David Gibson wrote: > On Mon, Oct 12, 2020 at 12:15:21PM +0200, Greg Kurz wrote: > > The spapr_create_nvdimm_dr_connectors() function doesn't need to access > > any internal details of the sPAPR NVDIMM implementation. Also, pretty > > much like for the LMBs, onl

[PATCH 0/3] ppc: Mac machine updates

Here are a few Mac machine updates from my pending patch queue. Patch 1 is split out from the QOM series I posted a few weeks ago (the other patches are all SPARC-related). Patches 2 and 3 move the IRQ wiring of the PCI host bridge from the host bridge device to the Old World and New World machine

[PATCH 1/3] macio: don't reference serial_hd() directly within the device

Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the Mac Old World and New World machine level. Also remove the now obsolete comment referring to the use of serial_hd() and the setting of user_creatable to false accordingly. Signed-off-by: Mark Cave-Ayland --- hw/misc/ma

[PATCH 3/3] uninorth: use qdev gpios for PCI IRQs

Currently an object link property is used to pass a reference to the OpenPIC into the PCI host bridge so that pci_unin_init_irqs() can connect the PCI IRQs to the PIC itself. This can be simplified by defining the PCI IRQs as qdev gpios and then wiring up the PCI IRQs to the PIC in the New World m

[PATCH 2/3] grackle: use qdev gpios for PCI IRQs

Currently an object link property is used to pass a reference to the Heathrow PIC into the PCI host bridge so that grackle_init_irqs() can connect the PCI IRQs to the PIC itself. This can be simplified by defining the PCI IRQs as qdev gpios and then wiring up the PCI IRQs to the PIC in the Old Wor

[PATCH v2] hw/core/qdev-properties-system: Fix pci bus range in set_pci_host_devaddr()

Signed-off-by: Klaus Herman --- hw/core/qdev-properties-system.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c index 49bdd12..e3dca56 100644 --- a/hw/core/qdev-properties-system.c +++ b/hw/core/qdev-properti

RE: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

> -Original Message- > From: Laurent Vivier [mailto:laur...@vivier.eu] > Sent: Tuesday, October 13, 2020 3:11 PM > To: Li Qiang > Cc: Fam Zheng ; ganqixin ; > vsement...@virtuozzo.com; Zhanghailiang > ; qemu-bl...@nongnu.org; Juan Quintela > ; qemu-triv...@nongnu.org; Qemu Developers > ; D

Re: [PATCH 04/10] meson: option to build as shared library

On Mon, Oct 12, 2020 at 04:29:33PM -0700, Joelle van Dyne wrote: > From: osy > > On iOS, we cannot fork() new processes, so the best way to load QEMU into an > app is through a shared library. We add a new configure option > `--enable-shared-lib` that will build the bulk of QEMU into a shared lib

Re: [PULL 09/14] qmp: Move dispatcher to a coroutine

On Mon, Oct 12, 2020 at 8:57 PM Ben Widawsky wrote: > > On 20-10-12 16:02:34, Alex Bennée wrote: > > > > Kevin Wolf writes: > > > > > Am 12.10.2020 um 13:53 hat Philippe Mathieu-Daudé geschrieben: > > >> On 10/12/20 1:25 PM, Kevin Wolf wrote: > > >> > Am 12.10.2020 um 12:47 hat Alex Bennée geschr

Re: [PATCH v2 3/3] replay: do not build if TCG is not available

Hi Paolo, On 10/13/20 12:29 AM, Paolo Bonzini wrote: > On 12/10/20 23:45, Claudio Fontana wrote: >> +ctx = blk_get_aio_context(blk); >> +if (!replay_bh_schedule_oneshot_event(ctx, error_callback_bh, acb)) { >> +/* regular case without replay */ >> +aio_bh_schedule_oneshot(c

Re: [PATCH v2 3/3] replay: do not build if TCG is not available

On 13/10/20 09:56, Claudio Fontana wrote: > Hi Paolo, > > On 10/13/20 12:29 AM, Paolo Bonzini wrote: >> On 12/10/20 23:45, Claudio Fontana wrote: >>> +ctx = blk_get_aio_context(blk); >>> +if (!replay_bh_schedule_oneshot_event(ctx, error_callback_bh, acb)) { >>> +/* regular case wit

Re: [PATCH 1/3] gitlab: add a CI job for running checkpatch.pl

On 18/09/2020 15.29, Daniel P. Berrangé wrote: > This job is advisory since it is expected that certain patches will fail > the style checks and checkpatch.pl provides no way to mark exceptions to > the rules. > > Signed-off-by: Daniel P. Berrangé > --- > .gitlab-ci.d/check-patch.py | 48 +++

Re: [PATCH 1/3] gitlab: add a CI job for running checkpatch.pl

On Tue, Oct 13, 2020 at 10:08:56AM +0200, Thomas Huth wrote: > On 18/09/2020 15.29, Daniel P. Berrangé wrote: > > This job is advisory since it is expected that certain patches will fail > > the style checks and checkpatch.pl provides no way to mark exceptions to > > the rules. > > > > Signed-off-

[PATCH] hw/intc: Move sifive_plic.h to the include directory

sifive_plic.h should be put in the include directory. Fixes: 84fcf3c15111 ("hw/riscv: Move sifive_plic model to hw/intc") Signed-off-by: Bin Meng --- {hw => include/hw}/intc/sifive_plic.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename {hw => include/hw}/intc/sifive_plic.h (100%)

Re: [PATCH 07/10] tcg: implement bulletproof JIT

Hi Joelle, On 10/13/20 1:29 AM, Joelle van Dyne wrote: From: osy On iOS, we cannot allocate RWX pages without special entitlements. As a workaround, we can a RX region and then mirror map it to a separate RX region. Then we can write to one region and execute from the other one. To better kee

Re: [PATCH v2 3/3] replay: do not build if TCG is not available

On 10/13/20 10:05 AM, Paolo Bonzini wrote: > On 13/10/20 09:56, Claudio Fontana wrote: >> Hi Paolo, >> >> On 10/13/20 12:29 AM, Paolo Bonzini wrote: >>> On 12/10/20 23:45, Claudio Fontana wrote: +ctx = blk_get_aio_context(blk); +if (!replay_bh_schedule_oneshot_event(ctx, error_cal

Re: [PATCH] hw/intc: Move sifive_plic.h to the include directory

On 10/13/20 10:19 AM, Bin Meng wrote: sifive_plic.h should be put in the include directory. Maybe: "Since sifive_plic.h is used by hw/intc/sifive_plic.c, it has to be in the public include directory. Move it." Reviewed-by: Philippe Mathieu-Daudé Fixes: 84fcf3c15111 ("hw/riscv: Move sifiv

Re: [PATCH v2 0/3] unbreak non-tcg builds

On 10/12/20 11:45 PM, Claudio Fontana wrote: This series now unbreaks current non-tcg builds (!CONFIG_TCG). tests Makefiles need to avoid relying on all non-native archs binaries to be present, bios-tables-test needs to skip tests that are tcg-only, and notably the replay framework needs to co

Re: [PATCH] hw/block/nvme: update nsid when registered

On Oct 1 23:50, Klaus Jensen wrote: > From: Klaus Jensen > > If the user does not specify an nsid parameter on the nvme-ns device, > nvme_register_namespace will find the first free namespace id and assign > that. > > This fix makes sure the assigned id is saved. > > Signed-off-by: Klaus Jense

Re: [PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition

On 10/13/20 9:20 AM, Gerd Hoffmann wrote: On Sun, Oct 11, 2020 at 09:32:23PM +0200, Philippe Mathieu-Daudé wrote: The TPM TIS device uses IRQ #5 by default. Add this default definition to the IsaIrqNumber enum. IRQ 5 has no fixed assignment. All kinds of add-on isa cards (sound, net) u

Re: [PATCH 08/10] hw/isa: Add the ISA_IRQ_NET_DEFAULT definition

On 10/13/20 9:23 AM, Gerd Hoffmann wrote: On Sun, Oct 11, 2020 at 09:32:27PM +0200, Philippe Mathieu-Daudé wrote: The network devices use IRQ #9 by default. Add this default definition to the IsaIrqNumber enum. IRQ #9 seems to be sort-of standard for acpi. Not sure whenever that is act

Re: [PATCH v2 0/3] unbreak non-tcg builds

On 10/13/20 10:25 AM, Philippe Mathieu-Daudé wrote: > On 10/12/20 11:45 PM, Claudio Fontana wrote: >> This series now unbreaks current non-tcg builds >> (!CONFIG_TCG). >> >> tests Makefiles need to avoid relying on all non-native >> archs binaries to be present, >> >> bios-tables-test needs to skip

[PATCH v2] hw/intc: Move sifive_plic.h to the include directory

Since sifive_plic.h is used by hw/intc/sifive_plic.c, it has to be in the public include directory. Move it. Fixes: 84fcf3c15111 ("hw/riscv: Move sifive_plic model to hw/intc") Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé --- Changes in v2: - reword the commit message as Philipp

[RESEND PATCH v2] hw/intc: Move sifive_plic.h to the include directory

From: Bin Meng Since sifive_plic.h is used by hw/intc/sifive_plic.c, it has to be in the public include directory. Move it. Fixes: 84fcf3c15111 ("hw/riscv: Move sifive_plic model to hw/intc") Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé --- Changes in v2: - reword the commit m

Re: [PATCH] hw/core/qdev-properties: Fix pci bus range in set_pci_host_devaddr()

Hi Klaus, On 10/13/20 12:58 AM, Klaus Herman wrote: Please include: Fixes: bccb20c49df ("hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr()") You forgot to sign your patch, see: https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line

Re: [PATCH v9 1/5] configure: fixes indent of $meson setup

On 10/13/20 1:43 AM, Yonggang Luo wrote: convert these line from tab to space Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- configure | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/configure b/configure index b553288c5e..1b63488521 10075

Re: [PATCH v7 2/4] gitignore: ignore a bit more

On 10/13/20 1:37 AM, Yonggang Luo wrote: Enable the creating multiple build directory at the source root. Ignore /meson/ and /roms/ for better search experience. Signed-off-by: Yonggang Luo --- .gitignore | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gi

Re: [PATCH] hw/usb/hcd-dwc2: fix divide-by-zero in dwc2_handle_packet()

On Tue, Oct 13, 2020 at 12:19:40AM -0700, Paul Zimmerman wrote: > I sent you a patch to fix up several assert()s, including that one, about a > month ago. Did you miss it? > https://lore.kernel.org/qemu-devel/20200920021449.830-1-pauld...@gmail.com I'll check. There is a bunch of pending stuff in

Re: [PATCH v9 2/5] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

On 10/13/20 1:43 AM, Yonggang Luo wrote: msys2/mingw lacks the POSIX-required langinfo.h. gcc test.c -DNCURSES_WIDECHAR -I/mingw64/include/ncursesw -pipe -lncursesw -lgnurx -ltre -lintl -liconv test.c:4:10: fatal error: langinfo.h: No such file or directory 4 | #include |

Re: [PATCH 0/2] Add Xen CpusAccel

On 10/12/20 10:16 PM, Claudio Fontana wrote: On 10/12/20 10:07 PM, Jason Andryuk wrote: Xen was left behind when CpusAccel became mandatory and fails the assert in qemu_init_vcpu(). It relied on the same dummy cpu threads as qtest. Move the qtest cpu functions to a common location and reuse the

Re: [PATCH v9 4/5] win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE are defined on msys2/mingw

On 10/13/20 1:43 AM, Yonggang Luo wrote: We remove the CONFIG_LOCALTIME_R detection option in configure, and move the check existence of gmtime_r from configure into C header and source directly by using macro `_POSIX_THREAD_SAFE_FUNCTIONS`. Before this patch, the configure script are always as

Re: [PATCH v2 0/3] unbreak non-tcg builds

On 10/13/20 10:28 AM, Claudio Fontana wrote: On 10/13/20 10:25 AM, Philippe Mathieu-Daudé wrote: On 10/12/20 11:45 PM, Claudio Fontana wrote: This series now unbreaks current non-tcg builds (!CONFIG_TCG). tests Makefiles need to avoid relying on all non-native archs binaries to be present, bi

Re: [PATCH v7 2/4] gitignore: ignore a bit more

On Tue, Oct 13, 2020 at 4:38 PM Philippe Mathieu-Daudé wrote: > > On 10/13/20 1:37 AM, Yonggang Luo wrote: > > Enable the creating multiple build directory at the source root. > > Ignore /meson/ and /roms/ for better search experience. > > > > Signed-off-by: Yonggang Luo > > --- > > .gitignore

Re: acceptance-system-fedora failures

On 10/9/20 12:37 PM, Pavel Dovgalyuk wrote: On 08.10.2020 14:50, Kevin Wolf wrote: Am 08.10.2020 um 12:26 hat Philippe Mathieu-Daudé geschrieben: On 10/7/20 3:11 PM, Pavel Dovgalyuk wrote: On 07.10.2020 15:49, Philippe Mathieu-Daudé wrote: On 10/7/20 2:20 PM, Pavel Dovgalyuk wrote: On 07.1

Re: [PATCH v7 2/4] gitignore: ignore a bit more

On 13/10/2020 10.53, 罗勇刚(Yonggang Luo) wrote: > > > On Tue, Oct 13, 2020 at 4:38 PM Philippe Mathieu-Daudé > wrote: >> >> On 10/13/20 1:37 AM, Yonggang Luo wrote: >> > Enable the creating multiple build directory at the source root. >> > Ignore /meson/ and /roms/ for be

Re: [PATCH 0/9] nvme qemu cleanups and fixes

On Sep 30 15:04, Keith Busch wrote: > After going through the zns enabling, I notice the controller enabling > is not correct. Then I just continued maked more stuff. The series, I > think, contains some of the less controversial patches from the two > conflicting zns series, preceeded by some clea

[PATCH] Makefile: Add *.[ch].inc files to cscope/ctags/TAGS

The code base has some C source and header files that don't get indexed because their name ends with .inc: $ git ls-files "*.[ch].inc" | wc -l 66 Add them to the list. Signed-off-by: Greg Kurz --- Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefi

Re: [PATCH 1/3] python: add mypy config

On Sat, Oct 10, 2020 at 1:54 AM John Snow wrote: > > Formalize the options used for checking the python library. You can run > mypy from the directory that mypy.ini is in by typing `mypy qemu/`. > > Signed-off-by: John Snow > --- > python/mypy.ini | 4 > 1 file changed, 4 insertions(+) > c

[PATCH v2] Makefile: Add *.[ch].inc files to cscope/ctags/TAGS

The code base has some C source and header files that don't get indexed because their name ends with .inc: $ git ls-files "*.[ch].inc" | wc -l 66 Add them to the list. Signed-off-by: Greg Kurz -- v2: add the missing \( and \) --- Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH] qemu-edid: drop cast

Not needed and makes some compilers error out with: qemu-edid.c:15:1: error: initializer element is not constant Signed-off-by: Gerd Hoffmann --- qemu-edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-edid.c b/qemu-edid.c index 1db3372b982c..1cd6a9517238 100644 ---

Re: [PATCH] Makefile: Add *.[ch].inc files to cscope/ctags/TAGS

On Tue, 13 Oct 2020 11:05:53 +0200 Greg Kurz wrote: > The code base has some C source and header files that don't get indexed > because their name ends with .inc: > > $ git ls-files "*.[ch].inc" | wc -l > 66 > > Add them to the list. > > Signed-off-by: Greg Kurz > --- > Makefile |2 +- >

[PATCH v3] hw/core/qdev-properties-system: Fix pci bus range in set_pci_host_devaddr()

Fixes: bccb20c49df ("hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr()") Signed-off-by: Klaus Herman --- hw/core/qdev-properties-system.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c in

Re: [PATCH v3 RESEND] fcntl: Add 32bit filesystem mode

On Tue, Oct 13, 2020 at 12:06:20AM +0200, Linus Walleij wrote: > It was brought to my attention that this bug from 2018 was > still unresolved: 32 bit emulators like QEMU were given > 64 bit hashes when running 32 bit emulation on 64 bit systems. > > This adds a flag to the fcntl() F_GETFD and F_S

Re: [PATCH] qemu-edid: drop cast

On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote: > Not needed and makes some compilers error out with: > > qemu-edid.c:15:1: error: initializer element is not constant Which compilers do this. If we're not seeing this failure in our CI, then we have a CI gap that likely needs fillin

Re: [PATCH v7 2/4] gitignore: ignore a bit more

On Tue, Oct 13, 2020 at 5:02 PM Thomas Huth wrote: > > On 13/10/2020 10.53, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Tue, Oct 13, 2020 at 4:38 PM Philippe Mathieu-Daudé < phi...@redhat.com > > > wrote: > >> > >> On 10/13/20 1:37 AM, Yonggang Luo wrote: > >> > Enable the cr

Re: [PATCH v4] introduce vfio-user protocol specification

On Fri, Oct 02, 2020 at 10:14:23AM +, Felipe Franciosi wrote: > > > > On Sep 30, 2020, at 3:24 PM, Stefan Hajnoczi wrote: > > > > On Tue, Sep 29, 2020 at 09:21:54AM -0700, John G Johnson wrote: > >>> On Sep 29, 2020, at 3:37 AM, Stefan Hajnoczi wrote: > >>> > >>> On Mon, Sep 28, 2020 at 0

Re: [PATCH v3 RESEND] fcntl: Add 32bit filesystem mode

On Tue, Oct 13, 2020 at 6:09 AM Linus Walleij wrote: > > It was brought to my attention that this bug from 2018 was > still unresolved: 32 bit emulators like QEMU were given > 64 bit hashes when running 32 bit emulation on 64 bit systems. > > This adds a flag to the fcntl() F_GETFD and F_SETFD ope

Re: [PATCH v2 1/8] migration: Do not use C99 // comments

* Bihong Yu (yubih...@huawei.com) wrote: > Signed-off-by: Bihong Yu > Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert another task at some point would be to rewrite the DPRINTF's in migration/block.c to use trace_ instead. > --- > migration/block.c | 2 +- > migration/rdma.c |

Re: [PATCH v4] introduce vfio-user protocol specification

On Wed, Sep 30, 2020 at 03:24:08PM +0100, Stefan Hajnoczi wrote: > On Tue, Sep 29, 2020 at 09:21:54AM -0700, John G Johnson wrote: > > > On Sep 29, 2020, at 3:37 AM, Stefan Hajnoczi wrote: > > > > > > On Mon, Sep 28, 2020 at 09:58:37AM +, Thanos Makatos wrote: > > >>> It should be accompanied

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

On Mon, Sep 21, 2020 at 11:14:35AM +, Fam Zheng wrote: > On 2020-09-19 10:22, Zhenyu Ye wrote: > > On 2020/9/18 22:06, Fam Zheng wrote: > > > > > > I can see how blocking in a slow io_submit can cause trouble for main > > > thread. I think one way to fix it (until it's made truly async in new

[PATCH] hw/core/qdev-properties-system: Rewrite set_pci_host_devaddr using GLib

set_pci_host_devaddr() is hard to follow, thus bug-prone. We indeed introduced a bug in commit bccb20c49df, as the same line might be used to parse a bus (up to 0xff) or a slot (up to 0x1f). Instead of making things worst, rewrite using g_strsplit(). Fixes: bccb20c49df ("Use qemu_strtoul() in set_

Re: PING: [PATCH 2/2] coroutine: take exactly one batch from global pool at a time

On Tue, Sep 29, 2020 at 11:24:14AM +0800, 王洪浩 wrote: > Hi, I'd like to know if there are any other problems with this patch, > or if there is a better implement to improve coroutine pool. Please rebase onto qemu.git/master and resend the patch as a top-level email thread. I think v2 was overlooked

Re: [PATCH] hw/core/qdev-properties-system: Rewrite set_pci_host_devaddr using GLib

On Tue, Oct 13, 2020 at 12:03:15PM +0200, Philippe Mathieu-Daudé wrote: > set_pci_host_devaddr() is hard to follow, thus bug-prone. > We indeed introduced a bug in commit bccb20c49df, as the > same line might be used to parse a bus (up to 0xff) or a > slot (up to 0x1f). Instead of making things wor

Re: [PATCH v2 3/8] migration: Add spaces around operator

* Bihong Yu (yubih...@huawei.com) wrote: > Signed-off-by: Bihong Yu > Reviewed-by: Chuan Zheng Yes that's OK, I'm a bit sturprised we need the space afte rthe * in the VMStateDescription case, I wouldn't necessarily go and change them all. Reviewed-by: Dr. David Alan Gilbert > --- > migrat

Re: [RFC PATCH 0/4] generic loader FDT support (for direct Xen boot)

Edgar E. Iglesias writes: > On Mon, Oct 12, 2020 at 05:02:57PM +0100, Alex Bennée wrote: >> >> Alistair Francis writes: >> >> > On Fri, Oct 9, 2020 at 10:07 AM Alex Bennée wrote: >> >> >> >> Hi, >> >> >> >> This series adds the ability to append FDT data for blobs loaded by >> >> the generi

[PATCH v2 0/4] MAINTAINERS: Update MIPS sections

Volunteer to maintain MIPS TCG. As discussed on list, Huacai will likely send a similar patch. Few more adjustments (in particular around Boston board). Based-on: <1602103041-32017-1-git-send-email-aleksandar.qemu.de...@gmail.com> https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg01974.htm

[PATCH v2 2/4] MAINTAINERS: Remove duplicated Malta test entries

The Malta tests are already covered in the Malta section. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d59e5c05c10..2de5943e388 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -238,8 +238,6 @@ F: include/

Re: [PATCH] hw/core/qdev-properties-system: Rewrite set_pci_host_devaddr using GLib

On 10/13/20 12:07 PM, Daniel P. Berrangé wrote: On Tue, Oct 13, 2020 at 12:03:15PM +0200, Philippe Mathieu-Daudé wrote: set_pci_host_devaddr() is hard to follow, thus bug-prone. We indeed introduced a bug in commit bccb20c49df, as the same line might be used to parse a bus (up to 0xff) or a slot

[PATCH v2 1/4] MAINTAINERS: Put myself forward for MIPS target

To avoid the MIPS target being orphan, volunteer to keep an eye on it and put together pull requests. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 426f52c1f63..d59e5c05c10 100644 --

[PATCH v2 3/4] MAINTAINERS: Downgrade MIPS Boston to 'Odd Fixes', fix Paul Burton mail

Paul's Wavecomp email has been bouncing for months. He told us he "no longer has access to modern MIPS CPUs or Boston hardware, and wouldn't currently have time to spend on them if he did." [1] but "perhaps that might change in the future." [2]. Be fair and downgrade the status of the Boston board

[PATCH v2 4/4] MAINTAINERS: Move MIPS GIC timer files to Boston board section

The MIPS GIC timer is only used by the Boston board. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 702f73823fc..62db288bfc4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -233,11 +233,9

[PATCH v2] hw/core/qdev-properties-system: Rewrite set_pci_host_devaddr using GLib

set_pci_host_devaddr() is hard to follow, thus bug-prone. We indeed introduced a bug in commit bccb20c49df, as the same line might be used to parse a bus (up to 0xff) or a slot (up to 0x1f). Instead of making things worst, rewrite using g_strsplit(). Fixes: bccb20c49df ("Use qemu_strtoul() in set_

Re: [PATCH v3] hw/core/qdev-properties-system: Fix pci bus range in set_pci_host_devaddr()

On 10/13/20 11:20 AM, Klaus Herman wrote: Fixes: bccb20c49df ("hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr()") Signed-off-by: Klaus Herman --- hw/core/qdev-properties-system.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/qdev-properties-

[PATCH] target/arm: AArch32 VCVT fixed-point to float is always round-to-nearest

For AArch32, unlike the VCVT of integer to float, which honours the rounding mode specified by the FPSCR, VCVT of fixed-point to float is always round-to-nearest. (AArch64 fixed-point-to-float conversions always honour the FPCR rounding mode.) Implement this by providing _round_to_nearest versions

Re: [PATCH] qemu-edid: drop cast

On Tue, Oct 13, 2020 at 10:23:22AM +0100, Daniel P. Berrangé wrote: > On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote: > > Not needed and makes some compilers error out with: > > > > qemu-edid.c:15:1: error: initializer element is not constant > > Which compilers do this. If we're

Re: [PATCH] qemu-edid: drop cast

On Tue, Oct 13, 2020 at 12:34:46PM +0200, Gerd Hoffmann wrote: > On Tue, Oct 13, 2020 at 10:23:22AM +0100, Daniel P. Berrangé wrote: > > On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote: > > > Not needed and makes some compilers error out with: > > > > > > qemu-edid.c:15:1: error:

Re: [PATCH] qemu-edid: drop cast

On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote: > Not needed and makes some compilers error out with: > > qemu-edid.c:15:1: error: initializer element is not constant > > Signed-off-by: Gerd Hoffmann > --- > qemu-edid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PULL v2 00/38] SCSI, qdev, qtest, meson patches for 2020-10-10

On Mon, 12 Oct 2020 at 21:36, Paolo Bonzini wrote: > > The following changes since commit a0bdf866873467271eff9a92f179ab0f77d735cb: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20201012a' into staging (2020-10-12 > 13:12:04 +0100) > > are available in the Git reposi

Re: [PATCH 0/3] console: make QMP screendump use coroutine

Hi, > Despite the flush, the dump may still have glitches. The graphic > device may perform some operations during the write on the same > framebuffer. That problem exists anyway, even without coroutines. The guest can write to vga memory in parallel to iothread writing out the screen dump. >

Re: [PATCH 1/2] gcrypt: test_tls_psk_init should write binary file instead text file.

On 10/13/20 3:03 AM, Yonggang Luo wrote: On windows, if open file with "w", it's will automatically convert "\n" to "\r\n" when writing to file. Signed-off-by: Yonggang Luo --- tests/crypto-tls-psk-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/crypto-tls

Re: [RFC PATCH v6 0/2] Add file-backed and write-once features to OTP

Hi Green, On Mon, Sep 28, 2020 at 6:11 PM Green Wan wrote: > > Changelogs: > v5 to v6: > - Rebase to latest. (sifive_u_otp.* are moved to hw/misc) > - Put the example command to commit message. > - Refine errp handle when check backend drive. > - Remove unnecessary debug message. > I will tr

Re: [PATCH] vnc-stubs: Allow -vnc none

On Thu, Oct 08, 2020 at 09:40:32PM -0400, Jason Andryuk wrote: > Currently `-vnc none` is fatal when built with `--disable-vnc`. Make > vnc_parse accept "none", so QEMU still run without using vnc. > > Signed-off-by: Jason Andryuk Makes sense. Added to UI queue. thanks, Gerd

[PULL 02/23] gitlab-ci.yml: Only run one test-case per fuzzer

From: Alexander Bulekov With 1000 runs, there is a non-negligible chance that the fuzzer can trigger a crash. With this CI job, we care about catching build/runtime issues in the core fuzzing code. Actual device fuzzing takes place on oss-fuzz. For these purposes, only running one input should be

[PULL 00/23] qtests, gitlab-CI and misc patches

Hi Peter, the following changes since commit a0bdf866873467271eff9a92f179ab0f77d735cb: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20201012a' into staging (2020-10-12 13:12:04 +0100) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pull

[PULL 05/23] Acceptance tests: show test report on GitLab CI

From: Cleber Rosa Avocado will, by default, produce JUnit files. Let's ask GitLab to present those in the web UI. Signed-off-by: Cleber Rosa Message-Id: <20201009205513.751968-4-cr...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth

[PULL 06/23] qtest: add fuzz test case

From: Li Qiang Currently the device fuzzer finds more and more issues. For every fuzz case, we need not only the fixes but also the corresponding test case. We can analysis the reproducer for every case and find what happened in where and write a beautiful test case. However the raw data of repro

[PULL 01/23] tests/qtest: Replace magic value by NANOSECONDS_PER_SECOND definition

From: Philippe Mathieu-Daudé Use self-explicit NANOSECONDS_PER_SECOND definition instead of a magic value. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201011194918.3219195-5-f4...@amsat.org> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/qtest/rtc-test.c | 2 +- 1 fil

[PULL 04/23] Acceptance tests: do not show canceled test logs on GitLab CI

From: Cleber Rosa Tests resulting in "CANCEL" in Avocado are usually canceled on purpose, and are almost identical to "SKIP". The logs for canceled tests are adding a lot of noise to the logs being shown on GitLab CI, and causing distraction from real failures. As a side note, this "after scrip

[PULL 07/23] tests/migration: Allow longer timeouts

From: "Dr. David Alan Gilbert" In travis, with gcov and gprof we're seeing timeouts; hopefully fix this by increasing the test timeouts a bit, but for xbzrle ensure it really does get a couple of cycles through to test the cache. I think the problem in travis is we have about 2 host CPU threads,

[PULL 09/23] Add a comment in bios-tables-test.c to clarify the reason behind approach

From: Ani Sinha A comment is added in bios-tables-test.c that explains the reasoning behind the process of updating the ACPI table blobs when new tests are added or old tests are modified or code is committed that affect tests. The explanation would help future contributors follow the correct pro

[PULL 03/23] Acceptance tests: bump pycdlib version for easier installation

From: Cleber Rosa On with certain versions of "pip", package installations will attempt to create wheels. And, on environments without a "complete" Python installation (as described in the acceptance tests requirements docs), that will fail. pycdlib, starting with version 1.11.0, is now being m

[PULL 11/23] Remove superfluous .gitignore files

Since we are now always doing out-of-tree builds, these gitignore files should not be necessary anymore. Message-Id: <20200919133637.72744-1-th...@redhat.com> Signed-off-by: Thomas Huth --- pc-bios/keymaps/.gitignore | 1 - plugins/.gitignore | 2 -- tests/.gitignore

[PULL 16/23] gitlab: assign python helper files to GitLab maintainers section

From: Daniel P. Berrangé Signed-off-by: Daniel P. Berrangé Message-Id: <20200918132903.1848939-4-berra...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index def5ad8ea9..

  1   2   3   4   >