Re: [PATCH 4/4] tests/qtest: Replace magic value by NANOSECONDS_PER_SECOND definition

2020-10-12 Thread Thomas Huth
On 11/10/2020 21.49, Philippe Mathieu-Daudé wrote: > Use self-explicit NANOSECONDS_PER_SECOND definition instead > of a magic value. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/qtest/rtc-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/rtc-

Re: [PATCH v3 05/16] fuzz: Declare DMA Read callback function

2020-10-12 Thread Paolo Bonzini
On 11/10/20 17:45, Alexander Bulekov wrote: > On 201008 0939, Paolo Bonzini wrote: >> On 21/09/20 04:24, Alexander Bulekov wrote: >>> This patch declares the fuzz_dma_read_cb function and uses the >>> preprocessor and linker(weak symbols) to handle these cases: >>> >>> When we build softmmu/all wit

Re: [PATCH v3 02/16] fuzz: Add general virtual-device fuzzer

2020-10-12 Thread Paolo Bonzini
On 11/10/20 17:35, Alexander Bulekov wrote: >> Instead of always looking for a separator, can you: >> >> 1) skip over it if you find it naturally at the end of a command (that >> is, "FUZZ" is like a comment command) >> >> 2) actively search for it only if you stumble upon an unrecognized command?

[PATCH 2/4] hw/pci-host/prep: Remove legacy PReP machine temporary workaround

2020-10-12 Thread Philippe Mathieu-Daudé
The legacy PReP machine has been removed in commit b2ce76a0730 ("hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS"). This temporary workaround is no more required, remove it. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/prep.c | 32 +++-

[PATCH 3/4] hw/pci-host/prep: Fix PCI swizzling in map_irq()

2020-10-12 Thread Philippe Mathieu-Daudé
In commit a01d8cadadf we changed the number of IRQs to 4 but forgot to update the map_irq() function. Do it now. Fixes: a01d8cadadf ("Fix memory corruption ... in PreP emulation") Signed-off-by: Philippe Mathieu-Daudé --- Cc: Jocelyn Mayer Cc: Julian Seward Signed-off-by: Philippe Mathieu-Daudé

[PATCH 0/4] hw/pci-host/prep: Fix PCI swizzling in map_irq()

2020-10-12 Thread Philippe Mathieu-Daudé
Fix a bug in the Raven PCI host, plus few cleanups while here. Philippe Mathieu-Daudé (4): hw/pci-host/prep: Update coding style to make checkpatch.pl happy hw/pci-host/prep: Remove legacy PReP machine temporary workaround hw/pci-host/prep: Fix PCI swizzling in map_irq() docs/system/target

[PATCH 4/4] docs/system/target-ppc.rst: Update PReP historical information

2020-10-12 Thread Philippe Mathieu-Daudé
Link Jocelyn Mayer's web page from the Wayback Machine, and correct the PReP acronym. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Jocelyn Mayer --- docs/system/target-ppc.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/system/target-ppc.rst b/docs/system/t

[PATCH 1/4] hw/pci-host/prep: Update coding style to make checkpatch.pl happy

2020-10-12 Thread Philippe Mathieu-Daudé
To make the next commit easier to review, clean this code first. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/prep.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index d0323fefb10..80dfb67da43 100644 --- a/hw/pci-host/

Re: Which qemu change corresponds to RedHat bug 1655408

2020-10-12 Thread Max Reitz
On 10.10.20 00:54, Jakob Bohm wrote: [...] > Theoretically, locking on a raw file needs to be protocol-compatible > with loop-mounting the same raw file, so if the loop driver doesn't > probe those magic byte offsets to prevent out-of-order block writes, > then there is little point for the qemu

Re: [PATCH 2/4] hw/pci-host/prep: Remove legacy PReP machine temporary workaround

2020-10-12 Thread Thomas Huth
On 12/10/2020 09.19, Philippe Mathieu-Daudé wrote: > The legacy PReP machine has been removed in commit b2ce76a0730 > ("hw/ppc/prep: Remove the deprecated "prep" machine and the > OpenHackware BIOS"). This temporary workaround is no more > required, remove it. > > Signed-off-by: Philippe Mathieu-D

Re: [PATCH 4/4] docs/system/target-ppc.rst: Update PReP historical information

2020-10-12 Thread Thomas Huth
On 12/10/2020 09.19, Philippe Mathieu-Daudé wrote: > Link Jocelyn Mayer's web page from the Wayback Machine, > and correct the PReP acronym. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Jocelyn Mayer > --- > docs/system/target-ppc.rst | 8 > 1 file changed, 4 insertions(+), 4

Re: [PATCH v3 05/20] target/mips: Move cpu_mips_get_random() with CP0 helpers

2020-10-12 Thread Luc Michel
On 22:43 Sat 10 Oct , Philippe Mathieu-Daudé wrote: > The get_random() helper uses the CP0_Wired register, which is > unrelated to the CP0_Count register use as timer. typo: used > Commit e16fe40c872 ("Move the MIPS CPU timer in a separate file") > incorrectly moved this get_random() helper wit

Re: [PATCH v4 3/4] hw/timer/bcm2835: Support the timer COMPARE registers

2020-10-12 Thread Luc Michel
On 22:37 Sat 10 Oct , Philippe Mathieu-Daudé wrote: > This peripheral has 1 free-running timer and 4 compare registers. > > Only the free-running timer is implemented. Add support the > COMPARE registers (each register is wired to an IRQ). > > Reference: "BCM2835 ARM Peripherals" datasheet [*

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-12 Thread David Gibson
On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe Mathieu-Daudé wrote: > On 10/12/20 12:34 AM, David Gibson wrote: > > On Sun, Oct 11, 2020 at 09:03:32PM +0200, Philippe Mathieu-Daudé wrote: > > > The Grackle PCI host model expects the interrupt controller > > > being set, but does not verify it i

Re: [PATCH 3/5] MAINTAINERS: Downgrade status of MIPS Boston to "Odd Fixes"

2020-10-12 Thread Thomas Huth
On 09/10/2020 18.52, Philippe Mathieu-Daudé wrote: > Paul's Wavecomp email has been bouncing for months. He told us > he "no longer has access to modern MIPS CPUs or Boston hardware, > and wouldn't currently have time to spend on them if he did." [1] > but "perhaps that might change in the future."

Re: Re%3A [PATCH v4 1%2F2] hw%2Fwatchdog%3A Implement SBSA watchdog device&In-Reply-To=

2020-10-12 Thread Maxim Uvarov
> +static uint64_t sbsa_gwdt_rread(void *opaque, hwaddr addr, unsigned int size) > +{ > +uint32_t ret; > + > +if (addr == SBSA_GWDT_WRR) { > +/* watch refresh read has no effect and returns 0 */ > +ret = 0; > +} else { > +qemu_log_mask(LOG_GUEST_ERROR, "bad addre

Re: [PULL 00/10] migration queue

2020-10-12 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Thu, 8 Oct 2020 at 20:13, Dr. David Alan Gilbert (git) > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > The following changes since commit e64cf4d569f6461d6b9072e00d6e78d0ab8bd4a7: > > > > Merge remote-tracking branch 'remotes/rth/ta

Re: [PATCH V13 8/9] hw/mips: Add Loongson-3 machine support

2020-10-12 Thread Philippe Mathieu-Daudé
On 10/11/20 4:53 AM, Huacai Chen wrote: Hi, Philippe, On Sat, Oct 10, 2020 at 5:09 PM Philippe Mathieu-Daudé wrote: Hi Huacai, On 10/7/20 10:39 AM, Huacai Chen wrote: Add Loongson-3 based machine support, it use liointc as the interrupt controler and use GPEX as the pci controller. Currentl

Re: [PATCH 2/4] hw/pci-host/prep: Remove legacy PReP machine temporary workaround

2020-10-12 Thread Philippe Mathieu-Daudé
On 10/12/20 9:28 AM, Thomas Huth wrote: On 12/10/2020 09.19, Philippe Mathieu-Daudé wrote: The legacy PReP machine has been removed in commit b2ce76a0730 ("hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS"). This temporary workaround is no more required, remove it. Si

Re: [PATCH v3 12/20] hw/mips/r4k: Explicit CPU frequency is 200 MHz

2020-10-12 Thread Philippe Mathieu-Daudé
Hi Huacai, On 10/11/20 5:52 AM, chen huacai wrote: Hi, Philippe, On Sun, Oct 11, 2020 at 4:43 AM Philippe Mathieu-Daudé wrote: Since its introduction in commit 6af0bf9c7c3, the 'r4k' machine runs at 200 MHz. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/r4k.c | 8 +++- 1 file ch

[PATCH v4 2/3] qga: add implementation of guest-get-disks for Linux

2020-10-12 Thread Tomáš Golembiovský
The command lists all disks (real and virtual) as well as disk partitions. For each disk the list of dependent disks is also listed and /dev path is used as a handle so it can be matched with "name" field of other returned disk entries. For disk partitions the "dependents" list is populated with th

[PATCH v4 3/3] qga: add implementation of guest-get-disks for Windows

2020-10-12 Thread Tomáš Golembiovský
The command lists all the physical disk drives. Unlike for Linux partitions and virtual volumes are not listed. Example output: { "return": [ { "name": ".\\PhysicalDrive0", "partition": false, "address": { "serial": "QM1", "bus-type": "sata",

[PATCH v4 0/3] qga: add command guest-get-disks

2020-10-12 Thread Tomáš Golembiovský
Adds command to list disks of the VM. The patch does compile on master but to work properly it requires changes to qemu-ga by Thomas Huth in series: Allow guest-get-fsinfo also for non-PCI devices. v4: - 2/3: don't leak syspath in build_guest_fsinfo_for_device() - 3/3: - added ERRP_GUARD - do

[PATCH v4 1/3] qga: add command guest-get-disks

2020-10-12 Thread Tomáš Golembiovský
Add API and stubs for new guest-get-disks command. The command guest-get-fsinfo can be used to list information about disks and partitions but it is limited only to mounted disks with filesystem. This new command should allow listing information about disks of the VM regardles whether they are mou

[Bug 1637511] Re: Armitage crashes KVM guest with Kali2016.2 for QXL video

2020-10-12 Thread Thomas Huth
Ok, thanks for your answer, so I'm closing this ticket now. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1637511 Title: Armitage cras

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-12 Thread Mark Cave-Ayland
On 11/10/2020 20:03, Philippe Mathieu-Daudé wrote: > The Grackle PCI host model expects the interrupt controller > being set, but does not verify it is present. Add a check to > help developers using this model. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/grackle.c | 4 >

Re: [PATCH] target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry

2020-10-12 Thread Mark Cave-Ayland
On 11/10/2020 21:01, Philippe Mathieu-Daudé wrote: > Commit 0b09be2b2f ("Nicer debug output for exceptions") added > twice the same "Tag Overflow" entry, remove the extra one. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/sparc/int32_helper.c | 1 - > 1 file changed, 1 deletion(-) >

Re: [PATCH 2/4] hw/pci-host/prep: Remove legacy PReP machine temporary workaround

2020-10-12 Thread Mark Cave-Ayland
On 12/10/2020 08:19, Philippe Mathieu-Daudé wrote: > The legacy PReP machine has been removed in commit b2ce76a0730 > ("hw/ppc/prep: Remove the deprecated "prep" machine and the > OpenHackware BIOS"). This temporary workaround is no more > required, remove it. > > Signed-off-by: Philippe Mathieu-

Re: [PATCH 3/4] hw/pci-host/prep: Fix PCI swizzling in map_irq()

2020-10-12 Thread Mark Cave-Ayland
On 12/10/2020 08:19, Philippe Mathieu-Daudé wrote: > In commit a01d8cadadf we changed the number of IRQs to 4 but > forgot to update the map_irq() function. Do it now. > > Fixes: a01d8cadadf ("Fix memory corruption ... in PreP emulation") > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Jocel

Re: [PATCH 1/4] hw/pci-host/prep: Update coding style to make checkpatch.pl happy

2020-10-12 Thread Mark Cave-Ayland
On 12/10/2020 08:19, Philippe Mathieu-Daudé wrote: > To make the next commit easier to review, clean this code first. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/prep.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/hw/pci-host/prep.c b/hw/pci-

Re: [PATCH v2 2/4] Makefile: Require GNU make 3.82+

2020-10-12 Thread Thomas Huth
On 25/08/2020 22.27, Roman Bolshakov wrote: > QEMU build fails with cryptic messages if make is too old: > > Makefile.ninja:2655: *** multiple target patterns. Stop. > > To avoid the confusion it's worth to fail the build right away and print > a friendly error message. > > Reviewed-by: Danie

Re: [PATCH v2 4/4] configure: Test if $make actually exists

2020-10-12 Thread Thomas Huth
On 25/08/2020 22.27, Roman Bolshakov wrote: > configure doesn't detect if $make is installed on the build host. > This is also helpful for hosts where an alias for make is used, i.e. > configure would fail if gmake is not present on macOS. > > Reviewed-by: Daniel P. Berrangé > Signed-off-by: Roma

[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol

2020-10-12 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:4.2-3ubuntu6.7 --- qemu (1:4.2-3ubuntu6.7) focal; urgency=medium * d/p/ubuntu/lp-1882774-*: add newer EPYC processor types (LP: #1887490) * d/p/u/lp-1896751-exec-rom_reset-Free-rom-data-during-inmigrate-skip.patch: fix reboot after mi

[Bug 1849644] Update Released

2020-10-12 Thread Łukasz Zemczak
The verification of the Stable Release Update for qemu has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a reg

Re: [PATCH 3/5] MAINTAINERS: Downgrade status of MIPS Boston to "Odd Fixes"

2020-10-12 Thread Philippe Mathieu-Daudé
On 10/12/20 9:40 AM, Thomas Huth wrote: On 09/10/2020 18.52, Philippe Mathieu-Daudé wrote: Paul's Wavecomp email has been bouncing for months. He told us he "no longer has access to modern MIPS CPUs or Boston hardware, and wouldn't currently have time to spend on them if he did." [1] but "perhap

[PATCH v4 02/21] qdev-monitor: Display frequencies scaled to SI unit

2020-10-12 Thread Philippe Mathieu-Daudé
Since commit 9f2ff99c7f2 ("qdev-monitor: print the device's clock with info qtree") we can display the clock frequencies in the monitor. Use the recently introduced freq_to_str() to display the frequencies using the closest SI unit (human friendlier). Before: (qemu) info qtree [...] dev: xi

[PATCH v4 00/21] hw/mips: Set CPU frequency

2020-10-12 Thread Philippe Mathieu-Daudé
Since v3: - Introduced mips_cpu_create_with_clock() helper (Huacai) - Added R-b tags Since v2: - Renamed "clk" -> "clk-in" - Renamed "cpuclk-out -> "cpu-refclk" Missing review: patches 7, 10-13, 15-21 ~~~ All the MIPS cores emulated by QEMU provides the Coproc#0 'Count' register which can be us

[PATCH v4 03/21] hw/qdev-clock: Display error hint when clock is missing from device

2020-10-12 Thread Philippe Mathieu-Daudé
Instead of directly aborting, display a hint to help the developer figure out the problem (likely trying to connect a clock to a device pre-dating the Clock API, thus not expecting clocks). Reviewed-by: Luc Michel Reviewed-by: Damien Hedde Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe

[PATCH v4 01/21] util/cutils: Introduce freq_to_str() to display Hertz units

2020-10-12 Thread Philippe Mathieu-Daudé
Introduce freq_to_str() to convert frequency values in human friendly units using the SI units for Hertz. Suggested-by: Luc Michel Reviewed-by: Alistair Francis Reviewed-by: Luc Michel Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/cutils.h | 12 util/cutils.c | 1

[PATCH v4 07/21] target/mips/cp0_timer: Document TIMER_PERIOD origin

2020-10-12 Thread Philippe Mathieu-Daudé
TIMER_PERIOD value of '10 ns' can be explained looking at commit 6af0bf9c7c3doc, where the CPU frequency is 200 MHz and CP0 default count rate is half the frequency of the CPU. Document that. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cp0_timer.c | 12 +++- 1 file changed, 11

[PATCH v4 04/21] hw/core/clock: add the clock_new helper function

2020-10-12 Thread Philippe Mathieu-Daudé
From: Luc Michel This function creates a clock and parents it to another object with a given name. It calls clock_setup_canonical_path before returning the new clock. This function is useful to create clocks in devices when one doesn't want to expose it at the qdev level (as an input or an outpu

[PATCH v4 05/21] target/mips: Move cpu_mips_get_random() with CP0 helpers

2020-10-12 Thread Philippe Mathieu-Daudé
The get_random() helper uses the CP0_Wired register, which is unrelated to the CP0_Count register used as timer. Commit e16fe40c872 ("Move the MIPS CPU timer in a separate file") incorrectly moved this get_random() helper with timer specific code. Move it back to generic CP0 helpers. Reviewed-by:

[PATCH v4 06/21] target/mips/cp0_timer: Explicit unit in variable name

2020-10-12 Thread Philippe Mathieu-Daudé
Name variables holding nanoseconds with the '_ns' suffix. Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cp0_timer.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/target/mips/cp0_timer.c b/target/mips/cp0_timer.c

[PATCH v4 09/21] target/mips/cpu: Calculate the CP0 timer period using the CPU frequency

2020-10-12 Thread Philippe Mathieu-Daudé
The CP0 timer period is a function of the CPU frequency. Start using the default values, which will be replaced by properties in the next commits. Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v4 11/21] target/mips/cpu: Allow the CPU to use dynamic frequencies

2020-10-12 Thread Philippe Mathieu-Daudé
Use the Clock API and let the CPU object have an input clock. If no clock is connected, keep using the default frequency of 200 MHz used since the introduction of the 'r4k' machine in commit 6af0bf9c7c3. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.h | 4 target/mips/cpu.c |

[PATCH v4 10/21] target/mips/cpu: Make cp0_count_rate a property

2020-10-12 Thread Philippe Mathieu-Daudé
Since not all CPU implementations use a cores use a CP0 timer at half the frequency of the CPU, make this variable a property. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.h | 9 + target/mips/cpu.c | 19 +++ 2 files changed, 20 insertions(+), 8 deletions(-)

[PATCH v4 08/21] target/mips: Move cp0_count_ns to CPUMIPSState

2020-10-12 Thread Philippe Mathieu-Daudé
Currently the CP0 timer period is fixed at 10 ns, corresponding to a fixed CPU frequency of 200 MHz (using half the speed of the CPU). In few commits we will be able to use a different CPU frequency. In preparation, move the cp0_count_ns variable to CPUMIPSState so we can modify it. Reviewed-by:

Re: [PATCH 1/3] block: push error reporting into bdrv_all_*_snapshot functions

2020-10-12 Thread Max Reitz
On 08.10.20 19:48, Philippe Mathieu-Daudé wrote: > From: Daniel P. Berrangé > > The bdrv_all_*_snapshot functions return a BlockDriverState pointer > for the invalid backend, which the callers then use to report an > error message. In some cases multiple callers are reporting the > same error mes

[PATCH v4 13/21] hw/mips/r4k: Explicit CPU frequency is 200 MHz

2020-10-12 Thread Philippe Mathieu-Daudé
Since its introduction in commit 6af0bf9c7c3, the 'r4k' machine runs at 200 MHz. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/r4k.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/mips/r4k.c b/hw/mips/r4k.c index 3487013a4a1..39bc626e7c5 100644 --- a/hw/mips/r4k

[PATCH v4 18/21] hw/mips/boston: Set CPU frequency to 1 GHz

2020-10-12 Thread Philippe Mathieu-Daudé
The I6400 can run at 1 GHz or more. Create a 'cpuclk' output clock and connect it to the CPU input clock. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/boston.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/mips/boston.c b/hw/mips/boston.c index 1b3f69e949c..cf2296f44

[PATCH v4 12/21] target/mips/cpu: Introduce mips_cpu_create_with_clock() helper

2020-10-12 Thread Philippe Mathieu-Daudé
Introduce an helper to create a MIPS CPU and connect it to a reference clock. This helper is not MIPS specific, but so far only MIPS CPUs need it. Suggested-by: Huacai Chen Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.h | 12 target/mips/cpu.c | 12 2 file

[PATCH v4 20/21] hw/mips/cps: Do not allow use without input clock

2020-10-12 Thread Philippe Mathieu-Daudé
Now than all QOM users provides the input clock, do not allow using a CPS without input clock connected. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/cps.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/mips/cps.c b/hw/mips/cps.c index af7b58c4bdd..c624821315a 100644 --- a/hw/m

[PATCH v4 15/21] hw/mips/mipssim: Correct CPU frequency

2020-10-12 Thread Philippe Mathieu-Daudé
The MIPSsim machine CPU frequency is too fast running at 200 MHz, while it should be 12 MHz for the 24K and 6 MHz for the 5K core. Ref: Linux commit c78cbf49c4ed ("Support for MIPSsim, the cycle accurate MIPS simulator.") Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mipssim.c | 11

[PATCH v4 14/21] hw/mips/fuloong2e: Set CPU frequency to 533 MHz

2020-10-12 Thread Philippe Mathieu-Daudé
The CPU frequency is normally provided by the firmware in the "cpuclock" environment variable. The 2E board can handles up to 660MHz, but be conservative and take the same value used by the Linux kernel: 533 MHz. Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/fuloong

[PATCH v4 19/21] hw/mips/malta: Set CPU frequency to 320 MHz

2020-10-12 Thread Philippe Mathieu-Daudé
The CoreLV card with ID 0x420's CPU clocked at 320 MHz. Create a 'cpuclk' output clock and connect it to the CPU input clock. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/malta.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/hw/mips/malta.c b/hw/mi

[PATCH v4 21/21] target/mips/cpu: Display warning when CPU is used without input clock

2020-10-12 Thread Philippe Mathieu-Daudé
All our QOM users provides an input clock. In order to avoid avoid future machines added without clock, display a warning. User-mode emulation use the CP0 timer with the RDHWR instruction (see commit cdfcad788394) so keep using the fixed 200 MHz clock without diplaying any warning. Only display it

[PATCH v4 16/21] hw/mips/jazz: Correct CPU frequencies

2020-10-12 Thread Philippe Mathieu-Daudé
The Magnum 4000PC CPU runs at 100 MHz, and the Acer PICA-61 CPU at ~134 MHz. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/jazz.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/hw/mips/jazz.c b/hw/mips/jazz.c index 47723093b63..8f1ad55ba34 100644 --- a/hw

Re: [PATCH] gitlab-ci.yml: Only run one test-case per fuzzer

2020-10-12 Thread Thomas Huth
On 02/10/2020 16.35, Alexander Bulekov wrote: > With 1000 runs, there is a non-negligible chance that the fuzzer can > trigger a crash. With this CI job, we care about catching build/runtime > issues in the core fuzzing code. Actual device fuzzing takes place on > oss-fuzz. For these purposes, only

[PATCH v4 17/21] hw/mips/cps: Expose input clock and connect it to CPU cores

2020-10-12 Thread Philippe Mathieu-Daudé
Expose a qdev input clock named 'clk-in', and connect it to each core to forward-propagate the clock. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/mips/cps.h | 2 ++ hw/mips/cps.c | 4 2 files changed, 6 insertions(+) diff --git a/include/hw/mips/cps.h b/include/hw/mips/cps

Re: [PATCH 1/3] hw/ssi/aspeed_smc: Rename max_slaves as max_devices

2020-10-12 Thread Kevin Wolf
Am 11.10.2020 um 23:05 hat Philippe Mathieu-Daudé geschrieben: > From: Philippe Mathieu-Daudé > > In order to use inclusive terminology, rename max_slaves > as max_peripherals. This is inconsistent with the subject line which talks about "max_devices". Kevin

Re: [RFC v1 3/4] qtest: do not build ide-test if TCG is not available

2020-10-12 Thread Claudio Fontana
On 10/10/20 12:50 PM, Claudio Fontana wrote: > On 10/9/20 6:01 PM, Paolo Bonzini wrote: >> On 09/10/20 17:21, Claudio Fontana wrote: >>> it seems that ide-test depends on TCG currently. >>> >>> Signed-off-by: Claudio Fontana >>> --- >>> tests/qtest/meson.build | 2 +- >>> 1 file changed, 1 insert

Re: [PATCH 1/3] block: push error reporting into bdrv_all_*_snapshot functions

2020-10-12 Thread Philippe Mathieu-Daudé
On 10/12/20 12:07 PM, Max Reitz wrote: On 08.10.20 19:48, Philippe Mathieu-Daudé wrote: From: Daniel P. Berrangé The bdrv_all_*_snapshot functions return a BlockDriverState pointer for the invalid backend, which the callers then use to report an error message. In some cases multiple callers ar

[PATCH] spapr: Move spapr_create_nvdimm_dr_connectors() to core machine code

2020-10-12 Thread Greg Kurz
The spapr_create_nvdimm_dr_connectors() function doesn't need to access any internal details of the sPAPR NVDIMM implementation. Also, pretty much like for the LMBs, only spapr_machine_init() is responsible for the creation of DR connectors for NVDIMMs. Make this clear by making this function stat

Re: [PATCH 1/3] hw/ssi/aspeed_smc: Rename max_slaves as max_devices

2020-10-12 Thread Philippe Mathieu-Daudé
On 10/12/20 12:04 PM, Kevin Wolf wrote: Am 11.10.2020 um 23:05 hat Philippe Mathieu-Daudé geschrieben: From: Philippe Mathieu-Daudé In order to use inclusive terminology, rename max_slaves as max_peripherals. This is inconsistent with the subject line which talks about "max_devices". Ah

Re: [PATCH] spapr: Move spapr_create_nvdimm_dr_connectors() to core machine code

2020-10-12 Thread Philippe Mathieu-Daudé
On 10/12/20 12:15 PM, Greg Kurz wrote: The spapr_create_nvdimm_dr_connectors() function doesn't need to access any internal details of the sPAPR NVDIMM implementation. Also, pretty much like for the LMBs, only spapr_machine_init() is responsible for the creation of DR connectors for NVDIMMs. Mak

Re: Ping2: [PATCH v2] Emulate dip switch language layout settings on SUN keyboard

2020-10-12 Thread Mark Cave-Ayland
On 10/10/2020 15:44, Artyom Tarasenko wrote: > Hi Mark, > > could you please pick it up? > > Regards, > Artyom Sure, I'll add it to my list. I'm currently starting to work through my backlog... ATB, Mark.

Re: [PATCH v2] qtest: add fuzz test case

2020-10-12 Thread Thomas Huth
On 21/09/2020 18.06, Li Qiang wrote: > Currently the device fuzzer find a more and more issues. > For every fuzz case, we need not only the fixes but also > the corresponding test case. We can analysis the reproducer > for every case and find what happened in where and write > a beautiful test case

Re: [PULL 00/39] SCSI, qdev, qtest, meson patches for 2020-10-10

2020-10-12 Thread Peter Maydell
On Sat, 10 Oct 2020 at 08:59, Paolo Bonzini wrote: > > The following changes since commit 4a7c0bd9dcb08798c6f82e55b5a3423f7ee669f1: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.2-20201009' > into staging (2020-10-09 15:48:04 +0100) > > are available in the Git repository at:

Re: Purpose of QOM properties registered at realize time?

2020-10-12 Thread Mark Cave-Ayland
On 06/10/2020 23:06, Eduardo Habkost wrote: > Hi, > > While trying to understand how QOM properties are used in QEMU, I > stumbled upon multiple cases where alias properties are added at > realize time. > > Now, I don't understand why those properties exist. As the > properties are added at rea

Re: [PATCH 0/3] Acceptance Tests: improve usage on GitLab CI

2020-10-12 Thread Thomas Huth
On 09/10/2020 22.55, Cleber Rosa wrote: > This attempts to improve a bit the execution of acceptance tests > in both GitLab CI, and in restricted Python environments. > > For the GitLab's rendering of test results, a sample can be seen here: > > https://gitlab.com/cleber.gnu/qemu/-/pipelines/20

Re: [RFC v1 3/4] qtest: do not build ide-test if TCG is not available

2020-10-12 Thread Claudio Fontana
On 10/12/20 12:14 PM, Claudio Fontana wrote: > On 10/10/20 12:50 PM, Claudio Fontana wrote: >> On 10/9/20 6:01 PM, Paolo Bonzini wrote: >>> On 09/10/20 17:21, Claudio Fontana wrote: it seems that ide-test depends on TCG currently. Signed-off-by: Claudio Fontana --- tests/

Re: [PATCH V13 6/9] target/mips: Add loongson-ext lsdc2 group of instructions

2020-10-12 Thread Huacai Chen
Hi, Philippe, On Sun, Oct 11, 2020 at 7:13 PM Philippe Mathieu-Daudé wrote: > > On 10/11/20 5:02 AM, Huacai Chen wrote: > > Hi, Philippe, > > > > On Sat, Oct 10, 2020 at 9:07 PM Philippe Mathieu-Daudé > > wrote: > >> > >> On 10/7/20 10:39 AM, Huacai Chen wrote: > >>> From: Jiaxun Yang > >>> >

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-12 Thread Thomas Huth
On 12/10/2020 07.30, David Gibson wrote: > On Sat, Oct 10, 2020 at 08:53:00AM -0700, Elena Afanasova wrote: >> On Sat, 2020-10-10 at 17:07 +1100, David Gibson wrote: >>> On Fri, Oct 09, 2020 at 07:02:56AM -0700, Elena Afanasova wrote: > From 09905773a00e417d3a37c12350d9e55466fdce8a Mon Sep 17 0

Re: [PULL 09/14] qmp: Move dispatcher to a coroutine

2020-10-12 Thread Alex Bennée
Markus Armbruster writes: > From: Kevin Wolf > > This moves the QMP dispatcher to a coroutine and runs all QMP command > handlers that declare 'coroutine': true in coroutine context so they > can avoid blocking the main loop while doing I/O or waiting for other > events. This subtly changes t

Re: [PATCH 3/4] hw/pci-host/prep: Fix PCI swizzling in map_irq()

2020-10-12 Thread Philippe Mathieu-Daudé
On 10/12/20 11:37 AM, Mark Cave-Ayland wrote: On 12/10/2020 08:19, Philippe Mathieu-Daudé wrote: In commit a01d8cadadf we changed the number of IRQs to 4 but forgot to update the map_irq() function. Do it now. Fixes: a01d8cadadf ("Fix memory corruption ... in PreP emulation") Signed-off-by: Ph

Re: [PATCH V13 6/9] target/mips: Add loongson-ext lsdc2 group of instructions

2020-10-12 Thread Philippe Mathieu-Daudé
On 10/12/20 12:33 PM, Huacai Chen wrote: Hi, Philippe, On Sun, Oct 11, 2020 at 7:13 PM Philippe Mathieu-Daudé wrote: On 10/11/20 5:02 AM, Huacai Chen wrote: Hi, Philippe, On Sat, Oct 10, 2020 at 9:07 PM Philippe Mathieu-Daudé wrote: On 10/7/20 10:39 AM, Huacai Chen wrote: From: Jiaxun Y

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-12 Thread Philippe Mathieu-Daudé
On 10/10/20 8:07 AM, David Gibson wrote: On Fri, Oct 09, 2020 at 07:02:56AM -0700, Elena Afanasova wrote: >From 09905773a00e417d3a37c12350d9e55466fdce8a Mon Sep 17 00:00:00 2001 From: Elena Afanasova Date: Fri, 9 Oct 2020 06:41:36 -0700 Subject: [PATCH] hw/net: move allocation to the heap due t

Re: [PATCH 1/3] block: push error reporting into bdrv_all_*_snapshot functions

2020-10-12 Thread Max Reitz
On 12.10.20 12:16, Philippe Mathieu-Daudé wrote: > On 10/12/20 12:07 PM, Max Reitz wrote: >> On 08.10.20 19:48, Philippe Mathieu-Daudé wrote: >>> From: Daniel P. Berrangé >>> >>> The bdrv_all_*_snapshot functions return a BlockDriverState pointer >>> for the invalid backend, which the callers then

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-12 Thread chenjiajun
On 2020/10/2 10:05, Raphael Norwitz wrote: > On Mon, Sep 28, 2020 at 9:17 AM Jiajun Chen wrote: >> >> Used_memslots is equal to dev->mem->nregions now, it is true for >> vhost kernel, but not for vhost user, which uses the memory regions >> that have file descriptor. In fact, not all of the mem

Re: [PATCH v7 01/13] qtest: rename qtest_qmp_receive to qtest_qmp_receive_dict

2020-10-12 Thread Thomas Huth
On 06/10/2020 14.38, Maxim Levitsky wrote: > In the next patch a new version of qtest_qmp_receive will be > reintroduced that will buffer received qmp events for later > consumption in qtest_qmp_eventwait_ref > > No functional change intended. > > Suggested-by: Paolo Bonzini > Signed-off-by: Max

Re: [PATCH v7 02/13] qtest: Reintroduce qtest_qmp_receive

2020-10-12 Thread Thomas Huth
On 06/10/2020 14.38, Maxim Levitsky wrote: > The new qtest_qmp_receive buffers all the received qmp events, allowing > qtest_qmp_eventwait_ref to return them. > > This is intended to solve the race in regard to ordering of qmp events > vs qmp responses, as soon as the callers start using the new i

Re: [PATCH v4 0/4] migration/postcopy: Sync faulted addresses after network recovered

2020-10-12 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > Queued Hi Peter, I've had to unqueue this again unfortunately. There's something going on with big endian hosts; on a PPC BE host, it reliably hangs in the recovery test with this set. (Although I can't see anything relevant to eye). Dave

Re: [PULL 09/14] qmp: Move dispatcher to a coroutine

2020-10-12 Thread Kevin Wolf
Am 12.10.2020 um 12:47 hat Alex Bennée geschrieben: > > Markus Armbruster writes: > > > From: Kevin Wolf > > > > This moves the QMP dispatcher to a coroutine and runs all QMP command > > handlers that declare 'coroutine': true in coroutine context so they > > can avoid blocking the main loop wh

[PATCH] spapr: Clarify why DR connectors aren't user creatable

2020-10-12 Thread Greg Kurz
DR connector is a device that emulates a firmware abstraction used by PAPR compliant guests to manage hotplug/dynamic-reconfiguration of PHBs, PCI devices, memory, and CPUs. It is internally created by the spapr platform and requires to be owned by either the machine (PHBs, CPUs, memory) or by a P

Re: [PULL 00/34] QAPI patches patches for 2020-10-10

2020-10-12 Thread Peter Maydell
On Sat, 10 Oct 2020 at 10:55, Markus Armbruster wrote: > > The following changes since commit 4a7c0bd9dcb08798c6f82e55b5a3423f7ee669f1: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.2-20201009' > into staging (2020-10-09 15:48:04 +0100) > > are available in the Git repository

Re: [PATCH qemu v9] spapr: Implement Open Firmware client interface

2020-10-12 Thread BALATON Zoltan via
On Mon, 12 Oct 2020, Alexey Kardashevskiy wrote: On 29/09/2020 20:35, Alexey Kardashevskiy wrote: On 16/07/2020 23:22, David Gibson wrote: On Thu, Jul 16, 2020 at 07:04:56PM +1000, Alexey Kardashevskiy wrote: Ping? I kinda realize it is not going to replace SLOF any time soon but still... Y

Re: [PATCH v4 1/7] keyval: Fix and clarify grammar

2020-10-12 Thread Eric Blake
On 10/11/20 2:34 AM, Markus Armbruster wrote: The grammar has a few issues: * key-fragment = / [^=,.]* / Prose restricts key fragments: they "must be valid QAPI names or consist only of decimal digits". Technically, '' consists only of decimal digits. The code rejects that. Fix the

[PULL 1/6] virtiofsd: Silence gcc warning

2020-10-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Gcc worries fd might be used unset, in reality it's always set if fi is set, and only used if fi is set so it's safe. Initialise it to -1 just to keep gcc happy for now. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20200827153657.111098-2-dgilb...@redhat.co

Re: [PATCH v4 2/7] test-keyval: Demonstrate misparse of ',' with implied key

2020-10-12 Thread Eric Blake
On 10/11/20 2:35 AM, Markus Armbruster wrote: Add a test for "val,,ue" with implied key. Documentation says this should parse as implied key with value "val", then fail. The code parses it as implied key with value "val,ue", then succeeds. The next commit will fix it. Signed-off-by: Markus Ar

[PULL 0/6] migration queue

2020-10-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' into staging (2020-10-12 11:29:42 +0100) are available in the Git repository at: git://github.com/dagrh/qemu.

[PULL 6/6] migration/dirtyrate: present dirty rate only when querying the rate has completed

2020-10-12 Thread Dr. David Alan Gilbert (git)
From: Chuan Zheng Make dirty_rate field optional, present dirty rate only when querying the rate has completed. The qmp results is shown as follow: @unstarted: {"return":{"status":"unstarted","start-time":0,"calc-time":0},"id":"libvirt-12"} @measuring: {"return":{"status":"measuring","start-time"

[PULL 3/6] virtiofsd: Call qemu_init_exec_dir

2020-10-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Since fcb4f59c879 qemu_get_local_state_pathname relies on the init_exec_dir, and virtiofsd asserts because we never set it. Set it. Reported-by: Alex Bennée Signed-off-by: Dr. David Alan Gilbert Message-Id: <20201002124015.44820-1-dgilb...@redhat.com> Tested-by:

[PULL 5/6] migration/dirtyrate: record start_time and calc_time while at the measuring state

2020-10-12 Thread Dr. David Alan Gilbert (git)
From: Chuan Zheng Querying could include both the start-time and the calc-time while at the measuring state, allowing a caller to determine when they should expect to come back looking for a result. Signed-off-by: Chuan Zheng Message-Id: <1601350938-128320-2-git-send-email-zhengch...@huawei.c

Re: Which qemu change corresponds to RedHat bug 1655408

2020-10-12 Thread Max Reitz
On 09.10.20 14:55, Jakob Bohm wrote: > On 2020-10-09 10:48, Max Reitz wrote: >> On 08.10.20 18:49, Jakob Bohm wrote: >>> (Top posting because previous reply did so): >>> >>> If the bug was closed as "can't reproduce", why was a very similar bug >>> listed as fixed in RHSA-2019:2553-01 ? >> >> Hi, >

[PATCH] tests/qtest/libqtest: Fix detection of architecture for binaries without path

2020-10-12 Thread Thomas Huth
The qtests can be run directly by specifying the QEMU binary with the QTEST_QEMU_BINARY environment variable, for example: $ QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/qtest/test-hmp However, if you specify a binary without a path, for example with QTEST_QEMU_BINARY=qemu-system-x8

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-12 Thread BALATON Zoltan via
On Mon, 12 Oct 2020, David Gibson wrote: On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe Mathieu-Daudé wrote: On 10/12/20 12:34 AM, David Gibson wrote: On Sun, Oct 11, 2020 at 09:03:32PM +0200, Philippe Mathieu-Daudé wrote: The Grackle PCI host model expects the interrupt controller being s

Re: [PULL 09/14] qmp: Move dispatcher to a coroutine

2020-10-12 Thread Philippe Mathieu-Daudé
On 10/12/20 1:25 PM, Kevin Wolf wrote: Am 12.10.2020 um 12:47 hat Alex Bennée geschrieben: Markus Armbruster writes: From: Kevin Wolf This moves the QMP dispatcher to a coroutine and runs all QMP command handlers that declare 'coroutine': true in coroutine context so they can avoid blockin

Re: [PATCH v4 4/7] keyval: Parse help options

2020-10-12 Thread Eric Blake
On 10/11/20 2:35 AM, Markus Armbruster wrote: From: Kevin Wolf This adds a special meaning for 'help' and '?' as options to the keyval parser. Instead of being an error (because of a missing value) or a value for an implied key, they now request help, which is a new boolean output of the parser

[PULL 2/6] tools/virtiofsd: add support for --socket-group

2020-10-12 Thread Dr. David Alan Gilbert (git)
From: Alex Bennée If you like running QEMU as a normal user (very common for TCG runs) but you have to run virtiofsd as a root user you run into connection problems. Adding support for an optional --socket-group allows the users to keep using the command line. Signed-off-by: Alex Bennée Reviewe

Re: [PATCH qemu v9] spapr: Implement Open Firmware client interface

2020-10-12 Thread Greg Kurz
On Mon, 12 Oct 2020 13:40:33 +0200 BALATON Zoltan via wrote: > On Mon, 12 Oct 2020, Alexey Kardashevskiy wrote: > > On 29/09/2020 20:35, Alexey Kardashevskiy wrote: > >> > >> On 16/07/2020 23:22, David Gibson wrote: > >>> On Thu, Jul 16, 2020 at 07:04:56PM +1000, Alexey Kardashevskiy wrote: > >>

  1   2   3   4   5   >