Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 8
1 file changed, 8 insertions(+)
diff --git a/meson.build b/meson.build
index a02c743794..eaff16d482 100644
--- a/meson.build
+++ b/meson.build
@@ -1323,6 +1323,10 @@ qemu_syms = custom_target('qemu.syms', output:
'qemu.syms',
I'm not sure how that works, but keep the use of Meson
sourcesets consistent, only add source files.
Signed-off-by: Philippe Mathieu-Daudé
---
migration/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/meson.build b/migration/meson.build
index b5b71c8060.
Be consistent creating all the libraries in the main meson.build file.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 10 ++
authz/meson.build | 10 --
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/meson.build b/meson
Be consistent creating all the libraries in the main meson.build file.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 6 ++
migration/meson.build | 6 --
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/meson.build b/meson.bui
Be consistent creating all the libraries in the main meson.build file.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build| 10 ++
crypto/meson.build | 10 --
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/meson.build b/mes
Be consistent creating all the libraries in the main meson.build file.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 7 +++
hw/core/meson.build | 6 --
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/meson.build b/meson.build
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/meson.build b/meson.build
index eaff16d482..fc7792b769 100644
--- a/meson.build
+++ b/meson.build
@@ -1059,19 +1059,19 @@ sphinx_extn_depends = [ meson.
Be consistent creating all the libraries in the main meson.build file.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 7 +++
chardev/meson.build | 6 --
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/meson.build b/meson.build
While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed
by a device only available using system-mode (fw_cfg), it is
implemented by a crypto component (tls-cipher-suites) which
is always available when crypto is used.
Commit 69699f3055 introduced the following error in the
qemu-storage-daemon b
Be consistent creating all the libraries in the main meson.build file.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 8
qom/meson.build | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/meson.build b/meson.build
index
The sh script are harder to maintain for compatible different
xsh environment so convert it to python script
Also incorporate the fixes in
https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/
Testing args length and if not enough, setting pkgversion and version to ''
Sign
On Tue, Oct 6, 2020 at 1:12 PM Philippe Mathieu-Daudé wrote:
>
> I'm not sure how that works, but keep the use of Meson
> sourcesets consistent, only add source files.
>
Eventually:
Fixes: 5516623020 ("meson: convert migration directory to Meson")
> Signed-off-by: Philippe Mathieu-Daudé
> ---
>
John Snow writes:
> A precise style guide and a package-wide overhaul is forthcoming pending
> further discussion and consensus. At present, we are avoiding obvious
> errors that cause sphinx documentation build problems.
>
> A preliminary style guide is loosely based on PEP 257 and Sphinx
> Auto
Attempt to fix the issue reported by Kevin.
Since RFC:
- Keep it local to hw/nvram (danpb)
- Based on Meson cleanup
Based-on: <20201006111219.2300921-1-phi...@redhat.com>
Supersedes: <20201005105442.2093105-1-phi...@redhat.com>
Philippe Mathieu-Daudé (1):
hw/nvram: Always register FW_CFG_DATA_
The sh script are harder to maintain for compatible different
xsh environment so convert it to python script
Also incorporate the fixes in
https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/
Testing args length and if not enough, setting pkgversion and version to ''
Sign
On 06/10/20 13:12, Philippe Mathieu-Daudé wrote:
> Be consistent creating all the libraries in the main meson.build file.
>
> Suggested-by: Paolo Bonzini
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> meson.build | 6 ++
> migration/meson.build | 6 --
> 2 files changed, 6 in
On 9/10/20 4:44 PM, Stefan Hajnoczi wrote:
> The MAINTAINERS file was not updated when the storage daemon was merged.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> MAINTAINERS | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7d0a5e91e4..eb80b6c548
On 06/10/20 13:12, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> meson.build | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/meson.build b/meson.build
> index a02c743794..eaff16d482 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1323,6 +1323
Yonggang Luo writes:
> We removed the need of .symbols file, so is the
> configure script, if we one expose a function to qemu-plugin
> just need prefix the function with QEMU_PLUGIN_EXPORT
>
> Signed-off-by: Yonggang Luo
> ---
> Makefile | 1 -
> configure
On 06/10/20 13:12, Philippe Mathieu-Daudé wrote:
> I'm not sure how that works, but keep the use of Meson
> sourcesets consistent, only add source files.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> migration/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --gi
On 10/6/20 1:25 PM, Paolo Bonzini wrote:
> On 06/10/20 13:12, Philippe Mathieu-Daudé wrote:
>> Be consistent creating all the libraries in the main meson.build file.
>>
>> Suggested-by: Paolo Bonzini
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> meson.build | 6 ++
>> migratio
On 06/10/20 13:12, Philippe Mathieu-Daudé wrote:
> Make Meson machinery more consistent, as requested by Paolo.
>
> Philippe Mathieu-Daudé (10):
> migration: Only add migration files to the Meson sourceset
> meson.build: Add comments to clarify code organization
> meson.build: Sort sourceset
On 10/5/20 9:51 PM, John Snow wrote:
> All of the QAPI include statements are changed to be package-aware, as
> explicit relative imports.
>
> A quirk of Python packages is that the name of the package exists only
> *outside* of the package. This means that to a module inside of the qapi
> folder,
On 06/10/20 13:21, Yonggang Luo wrote:
> The sh script are harder to maintain for compatible different
> xsh environment so convert it to python script
> Also incorporate the fixes in
> https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/
>
> Testing args length and if not
On 06/10/20 13:21, Yonggang Luo wrote:
> The sh script are harder to maintain for compatible different
> xsh environment so convert it to python script
> Also incorporate the fixes in
> https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/
>
> Testing args length and if not
Yonggang Luo writes:
> V2-V3
> Split following patches out
>
> V1-V2
> 1. Fixes review comments
> 2. Increase QEMU_PLUGIN_VERSION to 1 for compat QEMU_PLUGIN_VERSION 0
> 3. Revise the loader to support for version 0 and 1
> 4. By export function qemu_plugin_initialize in plugin, and call it in
On 06/10/20 13:19, Philippe Mathieu-Daudé wrote:
> While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed
> by a device only available using system-mode (fw_cfg), it is
> implemented by a crypto component (tls-cipher-suites) which
> is always available when crypto is used.
>
> Commit 69699f305
On 10/5/20 9:51 PM, John Snow wrote:
> The edge case is that if the name is '', this expression returns a
> string instead of a bool, which violates our declared type.
>
> Signed-off-by: John Snow
> Reviewed-by: Cleber Rosa
> Reviewed-by: Eduardo Habkost
> ---
> scripts/qapi/gen.py | 2 +-
> 1
On 10/5/20 9:51 PM, John Snow wrote:
> Wildcard includes become hard to manage when refactoring and dealing
> with circular dependencies with strictly typed mypy.
>
> flake8 also flags each one as a warning, as it is not smart enough to
> know which names exist in the imported file.
>
> Remove th
On 10/5/20 9:51 PM, John Snow wrote:
> Signed-off-by: John Snow
> Reviewed-by: Cleber Rosa
> Reviewed-by: Eduardo Habkost
> ---
> scripts/qapi/common.py | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py
> index a417
On 10/5/20 9:51 PM, John Snow wrote:
> And this fixes the pylint report for this file, so make sure we check
> this in the future, too.
>
> Signed-off-by: John Snow
> Reviewed-by: Eduardo Habkost
> Reviewed-by: Cleber Rosa
> Tested-by: Cleber Rosa
> ---
> scripts/qapi/pylintrc | 1 -
> script
John Snow writes:
> This is a minor re-work of the entrypoint script. It isolates a
> generate() method from the actual command-line mechanism.
>
> Signed-off-by: John Snow
> Reviewed-by: Eduardo Habkost
> Reviewed-by: Cleber Rosa
> Tested-by: Cleber Rosa
> ---
> scripts/qapi-gen.py | 85 +++
罗勇刚(Yonggang Luo) writes:
> On Tue, Oct 6, 2020 at 6:33 PM Peter Maydell
> wrote:
>>
>> On Mon, 5 Oct 2020 at 20:51, Yonggang Luo wrote:
>> >
>> > The sh script are harder to maintain for compatible different
>> > xsh environment so convert it to python script
>> > Also incorporate the fixes in
On Tue, Oct 6, 2020 at 7:34 PM Paolo Bonzini wrote:
>
> On 06/10/20 13:21, Yonggang Luo wrote:
> > The sh script are harder to maintain for compatible different
> > xsh environment so convert it to python script
> > Also incorporate the fixes in
> >
https://patchew.org/QEMU/20200929143654.518157-1
On Tue, Oct 6, 2020 at 16:28 Prerna Saxena
wrote:
>
>
> On 04/10/20, 11:35 PM, "Philippe Mathieu-Daudé" wrote:
>
> There is a number of contributors from this domain,
> add its own entry to the gitdm domain map.
>
> Cc: Ani Sinha
> Cc: David Vrabel
> Cc: Felipe Franciosi
On Tue, Oct 6, 2020 at 7:29 PM Alex Bennée wrote:
>
>
> Yonggang Luo writes:
>
> > We removed the need of .symbols file, so is the
> > configure script, if we one expose a function to qemu-plugin
> > just need prefix the function with QEMU_PLUGIN_EXPORT
> >
> > Signed-off-by: Yonggang Luo
> > --
V3-V4
Split plugin: Fixes typo in qemu-plugin.h out
Trying to explain the design of
plugin: Getting qemu-plugin works under win32.
V1-V2
1. Fixes review comments
2. Increase QEMU_PLUGIN_VERSION to 1 for compat QEMU_PLUGIN_VERSION 0
3. Revise the loader to support for version 0 and 1
4. By export
Signed-off-by: Yonggang Luo
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
---
contrib/plugins/hotblocks.c | 2 +-
tests/plugin/bb.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c
index 3
Signed-off-by: Yonggang Luo
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
---
plugins/loader.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/plugins/loader.c b/plugins/loader.c
index 685d334e1a..8ac5dbc20f 100644
--- a/plugins/loader.c
+++ b/plugins/loader.c
@@ -235,6 +235,
This is used for counting how much function are export to qemu plugin.
Signed-off-by: Yonggang Luo
Reviewed-by: Alex Bennée
---
plugins/api.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/plugins/api.c b/plugins/api.c
index bbdc5a4eb4..13177d3578 100644
--- a/plugi
Signed-off-by: Yonggang Luo
---
.cirrus.yml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/.cirrus.yml b/.cirrus.yml
index 86ea33926a..5363142373 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -104,7 +104,8 @@ windows_msys2_task:
- C:\tools\msys64\usr\bin\bash.exe -lc "
If we only have a single .c file in a plugin, then define
QEMU_PLUGIN_EXTERN to empty is OK, but if we have multiple .c files
in a plugin, then we need distinguish the implementation and the
deceleration. only the main .c file should define the macro
QEMU_PLUGIN_IMPLEMENTATION
other sources are us
Getting the comment consistence with the function name
Signed-off-by: Yonggang Luo
---
include/qemu/qemu-plugin.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index bab8b0d4b3..daac8291b8 100644
--- a/include/qemu
Define QEMU_PLUGIN_API_IMPLEMENTATION in api.c and core.c
We removed the need of .symbols file, so is the
configure script, if we one expose a function to qemu-plugin
just need prefix the function with QEMU_PLUGIN_EXPORT
We use QEMU_PLUGIN_EXPORT export the functions in api.c and core.c
and loadin
Am 06.10.2020 um 13:19 hat Philippe Mathieu-Daudé geschrieben:
> While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed
> by a device only available using system-mode (fw_cfg), it is
> implemented by a crypto component (tls-cipher-suites) which
> is always available when crypto is used.
>
> C
On Mon, 5 Oct 2020 at 16:43, Stefan Hajnoczi wrote:
>
> The following changes since commit 469e72ab7dbbd7ff4ee601e5ea7c29545d46593b:
>
> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
> (2020-10-02 16:19:42 +0100)
>
> are available in the Git repository at:
>
> ht
On 06/10/20 14:15, Kevin Wolf wrote:
> Am 06.10.2020 um 13:19 hat Philippe Mathieu-Daudé geschrieben:
>> While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed
>> by a device only available using system-mode (fw_cfg), it is
>> implemented by a crypto component (tls-cipher-suites) which
>> is a
Am 06.10.2020 um 14:20 hat Paolo Bonzini geschrieben:
> On 06/10/20 14:15, Kevin Wolf wrote:
> > Am 06.10.2020 um 13:19 hat Philippe Mathieu-Daudé geschrieben:
> >> While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed
> >> by a device only available using system-mode (fw_cfg), it is
> >> i
The only remaining users of qtest_qmp_receive_dict are tests
that fuzz the QMP protocol.
Tested with 'make check-qtest'.
Signed-off-by: Maxim Levitsky
---
tests/qtest/ahci-test.c | 4 +-
tests/qtest/device-plug-test.c | 2 +-
tests/qtest/drive_del-test.c| 9 ++---
tests/qtest/li
In the next patch a new version of qtest_qmp_receive will be
reintroduced that will buffer received qmp events for later
consumption in qtest_qmp_eventwait_ref
No functional change intended.
Suggested-by: Paolo Bonzini
Signed-off-by: Maxim Levitsky
---
tests/qtest/ahci-test.c| 4 ++--
Currently scsi_target_emulate_report_luns iterates over the child device list
twice, and there is no guarantee that this list is the same in both iterations.
The reason for iterating twice is that the first iteration calculates
how much memory to allocate. However if we use a dynamic array we can
From: Paolo Bonzini
Check if an address is free on the bus before plugging in the
device. This makes it possible to do the check without any
side effects, and to detect the problem early without having
to do it in the realize callback.
Signed-off-by: Paolo Bonzini
---
hw/core/qdev.c |
This is the next version of the patches.
In this version I implemented Paulo's suggestion of fixing the qtests
to cope with out of order events.
This resulted in small but nice refactoring.
Besides that, the only other change from V6 is that I dropped Paulo's
fix to qtest_qmp_device_del since it
On 10/6/20 11:44 AM, Alex Bennée wrote:
>
> Jan Kiszka writes:
>
>> On 05.10.20 22:52, Joseph Myers wrote:
>>> On Mon, 5 Oct 2020, Alex Bennée wrote:
>>>
Joseph Myers writes:
> On Sun, 4 Oct 2020, Philippe Mathieu-Daudé wrote:
>
>> There is a number of contributors from th
The new qtest_qmp_receive buffers all the received qmp events, allowing
qtest_qmp_eventwait_ref to return them.
This is intended to solve the race in regard to ordering of qmp events
vs qmp responses, as soon as the callers start using the new interface.
In addition to that, define qtest_qmp_even
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
---
hw/scsi/scsi-bus.c | 122 -
1 file changed, 75 insertions(+), 47 deletions(-)
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
index 3284a5d1fb..94921c04b1 100644
--- a/hw/scsi/scsi-bus.c
+++ b
Soon, a device removal might only happen on RCU callback execution.
This is okay for device-del which provides a DEVICE_DELETED event,
but not for the failure case of device-add. To avoid changing
monitor semantics, just drain all pending RCU callbacks on error.
Signed-off-by: Maxim Levitsky
Sug
This change will allow us to convert the bus children list to RCU,
while not changing the logic of this function
Signed-off-by: Maxim Levitsky
Reviewed-by: Stefan Hajnoczi
Message-Id: <20200913160259.32145-2-mlevi...@redhat.com>
Signed-off-by: Paolo Bonzini
---
hw/scsi/scsi-bus.c | 12
Some code might race with placement of new devices on a bus.
We currently first place a (unrealized) device on the bus
and then realize it.
As a workaround, users that scan the child device list, can
check the realized property to see if it is safe to access such a device.
Use an atomic write here
This fixes the race between device emulation code that tries to find
a child device to dispatch the request to (e.g a scsi disk),
and hotplug of a new device to that bus.
Note that this doesn't convert all the readers of the list
but only these that might go over that list without BQL held.
This
From: Paolo Bonzini
The device core first places a device on the bus and then realizes it.
Make scsi_device_find avoid returing such devices to avoid
races in drivers that use an iothread (currently virtio-scsi)
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1812399
Suggested-by: Paolo B
On 06/10/20 14:38, Kevin Wolf wrote:
> Am 06.10.2020 um 14:20 hat Paolo Bonzini geschrieben:
>> It's
>>
>> Based-on: <20201006111219.2300921-1-phi...@redhat.com>
>>
>> (which won't be applied in exactly that shape, but more or less it will
>> be the same).
>
> Oh, I see. Then I guess it's not su
On 05/10/20 22:52, Eduardo Habkost wrote:
> This moves the QTest section of testing.rst to a separate
> document, and include the QTest Protocol specification and
> libqtest API reference in the document.
>
> Eduardo Habkost (3):
> docs: Move QTest documentation to its own document
> docs/deve
Add scsi_device_get which finds the scsi device
and takes a reference to it.
Suggested-by: Stefan Hajnoczi
Signed-off-by: Maxim Levitsky
Message-Id: <20200913160259.32145-8-mlevi...@redhat.com>
Signed-off-by: Paolo Bonzini
---
hw/scsi/scsi-bus.c | 11 +++
include/hw/scsi/scsi.h |
On 10/6/20 1:29 PM, Paolo Bonzini wrote:
> On 06/10/20 13:12, Philippe Mathieu-Daudé wrote:
>> Make Meson machinery more consistent, as requested by Paolo.
>>
>> Philippe Mathieu-Daudé (10):
>> migration: Only add migration files to the Meson sourceset
>> meson.build: Add comments to clarify co
This will help us to avoid the scsi device disappearing
after we took a reference to it.
It doesn't by itself forbid case when we try to access
an unrealized device
Suggested-by: Stefan Hajnoczi
Signed-off-by: Maxim Levitsky
Reviewed-by: Stefan Hajnoczi
Message-Id: <20200913160259.32145-9-mlev
On 10/06/20 13:19, Philippe Mathieu-Daudé wrote:
> While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed
> by a device only available using system-mode (fw_cfg), it is
> implemented by a crypto component (tls-cipher-suites) which
> is always available when crypto is used.
>
> Commit 69699f305
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 8
1 file changed, 8 insertions(+)
diff --git a/meson.build b/meson.build
index a02c743794..4101620777 100644
--- a/meson.build
+++ b/meson.build
@@ -1323,6 +1323,10 @@ qemu_syms = custom_target('qemu.syms', output:
'qemu.syms',
Be consistent creating all the libraries in the main meson.build file.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build| 10 ++
io/meson.build | 10 --
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/meson.build b/meson.build
Make Meson machinery more consistent, as requested by Paolo.
Since v1: addressed Paolo's review comments
- Drop migration RFC patch
- Move comment block
Series coded while listening to Brass Against songs:
https://www.youtube.com/channel/UClJMqrWQJ8OYWJ4ZdfqZdeQ
and available in the Git repos
On 06/10/20 14:38, Maxim Levitsky wrote:
> The only remaining users of qtest_qmp_receive_dict are tests
> that fuzz the QMP protocol.
>
> Tested with 'make check-qtest'.
Probably the qtest_qmp_receive_success conversion should have been in a
separate patch. But it's a nice side effect that I had
Be consistent creating all the libraries in the main meson.build file.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 10 ++
authz/meson.build | 10 --
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/meson.build b/meson
Be consistent creating all the libraries in the main meson.build file.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 7 +++
chardev/meson.build | 6 --
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/meson.build b/meson.build
Be consistent creating all the libraries in the main meson.build file.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build| 10 ++
crypto/meson.build | 10 --
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/meson.build b/mes
Be consistent creating all the libraries in the main meson.build file.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 8
qom/meson.build | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/meson.build b/meson.build
index
Be consistent creating all the libraries in the main meson.build file.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 7 +++
migration/meson.build | 8 +---
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/meson.build b/meson.
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/meson.build b/meson.build
index 4101620777..60497f5615 100644
--- a/meson.build
+++ b/meson.build
@@ -1059,19 +1059,19 @@ sphinx_extn_depends = [ meson.
Patchew URL:
https://patchew.org/QEMU/20201006123904.610658-1-mlevi...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
N/A. Internal error while reading log file
The full log is available at
http://patchew.org/logs/20201006123904
If devfn is assigned automatically, 'else' clauses will never be
executed. And if it does not matter for the reserved and available
devfn, because we have already checked it, the check for function0
needs to be done again.
Steps to reproduce:
1. Run QEMU with:
-M q35 \
-device pcie
Patchew URL:
https://patchew.org/QEMU/20201006125602.2311423-1-phi...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
N/A. Internal error while reading log file
The full log is available at
http://patchew.org/logs/20201006125602.
Be consistent creating all the libraries in the main meson.build file.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
meson.build | 6 ++
hw/core/meson.build | 6 --
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/meson.build b/meson.build
i
On 10/6/20 2:55 PM, Laszlo Ersek wrote:
> On 10/06/20 13:19, Philippe Mathieu-Daudé wrote:
>> While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed
>> by a device only available using system-mode (fw_cfg), it is
>> implemented by a crypto component (tls-cipher-suites) which
>> is always availa
On 10/6/20 3:00 PM, no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20201006125602.2311423-1-phi...@redhat.com/
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> N/A. Internal error while reading log file
¯\_(ツ)
On Tue, 2020-10-06 at 14:56 +0200, Paolo Bonzini wrote:
> On 06/10/20 14:38, Maxim Levitsky wrote:
> > The only remaining users of qtest_qmp_receive_dict are tests
> > that fuzz the QMP protocol.
> >
> > Tested with 'make check-qtest'.
>
> Probably the qtest_qmp_receive_success conversion should
On 06/10/20 14:55, Philippe Mathieu-Daudé wrote:
> Make Meson machinery more consistent, as requested by Paolo.
>
> Since v1: addressed Paolo's review comments
> - Drop migration RFC patch
> - Move comment block
>
> Series coded while listening to Brass Against songs:
>
> https://www.youtube.c
On Sat, Oct 03, 2020 at 08:14:06PM +0300, Pavel Dovgalyuk wrote:
> From: Pavel Dovgalyuk
>
> This is a test for GDB reverse debugging commands: reverse step and reverse
> continue.
> Every test in this suite consists of two phases: record and replay.
> Recording saves the execution of some instr
'occupied' is spelled like 'ocuppied' in the message.
Signed-off-by: Julia Suvorova
---
hw/pci/pci.c | 2 +-
hw/ppc/spapr_pci.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 3c8f10b461..100c9381c2 100644
--- a/hw/pci/pci.c
+++ b/hw
On Tue, Oct 06, 2020 at 10:58:26AM +0100, Stefan Hajnoczi wrote:
In order to prevent /proc/self/fd escapes a temporary directory is
created where /proc/self/fd is bind-mounted. This doesn't work on
read-only file systems.
Avoid the temporary directory by bind-mounting /proc/self/fd over /proc.
T
On 10/6/20 2:29 AM, Paolo Bonzini wrote:
> From: Pavel Dovgalyuk
>
> Saving icount as a parameters of the snapshot allows navigation between
> them in the execution replay scenario.
> This information can be used for finding a specific snapshot for proceeding
> the recorded execution to the speci
On Tue, Oct 06, 2020 at 09:36:32AM +0100, Daniel P. Berrangé wrote:
> On Mon, Sep 07, 2020 at 11:14:40AM +0200, Tomáš Golembiovský wrote:
> > Add API and stubs for new guest-get-disks command.
> >
> > The command guest-get-fsinfo can be used to list information about disks
> > and partitions but i
On 10/6/20 3:39 PM, Julia Suvorova wrote:
> 'occupied' is spelled like 'ocuppied' in the message.
>
> Signed-off-by: Julia Suvorova
> ---
> hw/pci/pci.c | 2 +-
> hw/ppc/spapr_pci.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On Tue, Oct 06, 2020 at 03:53:08PM +0200, Tomáš Golembiovský wrote:
> On Tue, Oct 06, 2020 at 09:36:32AM +0100, Daniel P. Berrangé wrote:
> > On Mon, Sep 07, 2020 at 11:14:40AM +0200, Tomáš Golembiovský wrote:
> > > Add API and stubs for new guest-get-disks command.
> > >
> > > The command guest-g
On Mon, 5 Oct 2020 at 22:10, Eduardo Habkost wrote:
>
> The following changes since commit 36d9c2883e55c863b622b99f0ebb5143f0001401:
>
> readthedocs: build with Python 3.6 (2020-10-05 16:30:45 +0100)
>
> are available in the Git repository at:
>
> git://github.com/ehabkost/qemu.git tags/machin
Add some of these features for AVR GPIO:
- GPIO I/O : PORTx registers
- Data Direction : DDRx registers
- DDRx toggling : PINx registers
Following things are not supported yet:
- MCUR registers
Signed-off-by: Heecheol Yang
---
hw/avr/Kconfig | 1 +
hw/avr/atmega.c
On 06.10.20 14:41, Philippe Mathieu-Daudé wrote:
> On 10/6/20 11:44 AM, Alex Bennée wrote:
>>
>> Jan Kiszka writes:
>>
>>> On 05.10.20 22:52, Joseph Myers wrote:
On Mon, 5 Oct 2020, Alex Bennée wrote:
> Joseph Myers writes:
>
>> On Sun, 4 Oct 2020, Philippe Mathieu-Daudé wro
On Tue, Oct 06, 2020 at 03:03:57PM +0100, Peter Maydell wrote:
> On Mon, 5 Oct 2020 at 22:10, Eduardo Habkost wrote:
> >
> > The following changes since commit 36d9c2883e55c863b622b99f0ebb5143f0001401:
> >
> > readthedocs: build with Python 3.6 (2020-10-05 16:30:45 +0100)
> >
> > are available i
On Tue, 6 Oct 2020 at 15:36, Eduardo Habkost wrote:
>
> On Tue, Oct 06, 2020 at 03:03:57PM +0100, Peter Maydell wrote:
> > Compile failure on OSX:
> >
> > ../../hw/core/numa.c:429:20: error: format specifies type 'unsigned
> > char' but the argument has type 'int' [-Werror,-Wformat]
> >
On 06/10/20 16:36, Eduardo Habkost wrote:
> On Tue, Oct 06, 2020 at 03:03:57PM +0100, Peter Maydell wrote:
>> On Mon, 5 Oct 2020 at 22:10, Eduardo Habkost wrote:
>>>
>>> The following changes since commit 36d9c2883e55c863b622b99f0ebb5143f0001401:
>>>
>>> readthedocs: build with Python 3.6 (2020-
On Tue, Oct 06, 2020 at 03:38:56PM +0100, Peter Maydell wrote:
> On Tue, 6 Oct 2020 at 15:36, Eduardo Habkost wrote:
> >
> > On Tue, Oct 06, 2020 at 03:03:57PM +0100, Peter Maydell wrote:
> > > Compile failure on OSX:
> > >
> > > ../../hw/core/numa.c:429:20: error: format specifies type 'unsigned
Spec[1] defines 0 - 3 level memory side cache, however QEMU
CLI allows to specify an intermediate cache level without
specifying previous level. Such option(s) silently ignored
when building HMAT table, which leads to incomplete cache
information.
Make sure that previous level exists and error out
101 - 200 of 404 matches
Mail list logo
