[PULL 00/37] Build system + accel + record/replay patches for 2020-10-06

2020-10-06 Thread Paolo Bonzini
The following changes since commit 0ac0b47c44b4be6cbce26777a1a5968cc8f025a5: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2020-10-05 13:12:55 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for yo

[PULL 03/37] cpus: prepare new CpusAccel cpu accelerator interface

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana The new interface starts unused, will start being used by the next patches. It provides methods for each accelerator to start a vcpu, kick a vcpu, synchronize state, get cpu virtual clock and elapsed ticks. In qemu_wait_io_event, make it clear that APC is used only for HAX

[PULL 08/37] cpus: extract out whpx-specific code to target/i386/

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana register a "CpusAccel" interface for WHPX as well. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- MAINTAINERS | 1 + softmmu/cpus.c | 79 - target/i386/meson.build | 5

[PULL 05/37] cpus: extract out qtest-specific code to accel/qtest

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana register a "CpusAccel" interface for qtest as well. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- MAINTAINERS | 2 +- accel/meson.build | 2 +- accel/qtest/meson.build | 7 +++ accel/qtest/qtest

[PULL 02/37] icount: rename functions to be consistent with the module name

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini --- accel/tcg/cpu-exec.c| 6 +++--- docs/replay.txt | 6 +++--- include/sysemu/cpu-timers.h | 16 +++--- include/sysemu/repl

[PULL 09/37] cpus: extract out hvf-specific code to target/i386/hvf/

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana register a "CpusAccel" interface for HVF as well. Signed-off-by: Claudio Fontana Reviewed-by: Roman Bolshakov [added const] Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- softmmu/cpus.c | 66 ---

[PULL 04/37] cpus: extract out TCG-specific code to accel/tcg

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana TCG is the first accelerator to register a "CpusAccel" interface on initialization, providing functions for starting a vcpu, kicking a vcpu, sychronizing state and getting virtual clock and ticks. Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé Tested-b

[PULL 23/37] configure: don't enable ASLR for --enable-debug Windows builds

2020-10-06 Thread Paolo Bonzini
From: Mark Cave-Ayland Unlike other OSs it is not possible for gdb to temporarily disable ASLR when debugging executables on Windows which causes gdb to fail with memory access errors when trying to debug QEMU. Keep ASLR enabled by default on Windows via the --dynamicbase compiler flag except fo

[PULL 07/37] cpus: extract out hax-specific code to target/i386/

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana register a "CpusAccel" interface for HAX as well. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- softmmu/cpus.c| 80 +--- target/i386/hax-all.c | 6 ++- target/i386/hax-cpus

[PULL 15/37] hax: remove hax specific functions from global includes

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- accel/stubs/hax-stub.c| 10 -- include/sysemu/hax.h | 17 - target/i386/hax-all.c | 1 - target/i386/hax-cpus.c| 1 - target/i386/hax

[PULL 01/37] cpu-timers, icount: new modules

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana refactoring of cpus.c continues with cpu timer state extraction. cpu-timers: responsible for the softmmu cpu timers state, including cpu clocks and ticks. icount: counts the TCG instructions executed. As such it is specific to the TCG accelerator. Therefore, it

[PULL 18/37] accel/tcg: use current_machine as it is always set for softmmu

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana current_machine is always set before accelerators are initialized, so use that instead of MACHINE(qdev_get_machine()). Signed-off-by: Claudio Fontana Signed-off-by: Paolo Bonzini --- accel/tcg/tcg-cpus.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-)

[PULL 32/37] replay: flush rr queue before loading the vmstate

2020-10-06 Thread Paolo Bonzini
From: Pavel Dovgalyuk Non-empty record/replay queue prevents saving and loading the VM state, because it includes pending bottom halves and block coroutines. But when the new VM state is loaded, we don't have to preserve the consistency of the current state anymore. Therefore this patch just flus

[PULL 11/37] cpus: remove checks for non-NULL cpus_accel

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana now that all accelerators support the CpusAccel interface, we can remove most checks for non-NULL cpus_accel, we just add a sanity check/assert at vcpu creation. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- softmmu/cpus.

[PULL 06/37] cpus: extract out kvm-specific code to accel/kvm

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana register a "CpusAccel" interface for KVM as well. Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé [added const] Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- accel/k

[PULL 10/37] cpus: cleanup now unneeded includes

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini --- softmmu/cpus.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/softmmu/cpus.c b/softmmu/cpus.c index adc20eb3de..1180103ede 100644 --- a/sof

[PULL 25/37] replay: provide an accessor for rr filename

2020-10-06 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch adds an accessor function for the name of the record/replay log file. Adding an accessor instead of making variable global, prevents accidental modification of this variable by other modules. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Alex Bennée Reviewed-by:

[PULL 20/37] dtc: Convert Makefile bits to meson bits

2020-10-06 Thread Paolo Bonzini
Build the library via the main meson.build just like for capstone. This improves the current state of affairs in that we will re-link the qemu executables against a changed libfdt.a, which we wouldn't do before-hand, and lets us remove the whole recursive make machinery. Tested-by: Richard Henders

[PULL 34/37] gdbstub: add reverse continue support in replay mode

2020-10-06 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the b

[PULL 27/37] migration: introduce icount field for snapshots

2020-10-06 Thread Paolo Bonzini
From: Pavel Dovgalyuk Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for proceeding the recorded execution to the specific moment of the time. E.g., 'reverse step' action (

[PULL 30/37] replay: introduce breakpoint at the specified step

2020-10-06 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch introduces replay_break, replay_delete_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. replay_break command has one argument - numb

[PULL 12/37] cpus: add handle_interrupt to the CpusAccel interface

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana kvm: uses the generic handler qtest: uses the generic handler whpx: changed to use the generic handler (identical implementation) hax: changed to use the generic handler (identical implementation) hvf: changed to use the generic handler (identical implementation) tcg: adapt

[PULL 36/37] replay: create temporary snapshot at debugger connection

2020-10-06 Thread Paolo Bonzini
From: Pavel Dovgalyuk When record/replay does not uses overlays for storing the snapshots, user is not capable of issuing reverse debugging commands. This patch adds creation of the VM snapshot on the temporary overlay image, when the debugger connects to QEMU. Therefore the execution can be rewi

[PULL 35/37] replay: describe reverse debugging in docs/replay.txt

2020-10-06 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch updates the documentation and describes usage of the reverse debugging in QEMU+GDB. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Alex Bennée -- v4 changes: - added an example of the command line for reverse debugging of the diskless machine Message-Id: <16

[PULL 13/37] hvf: remove hvf specific functions from global includes

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Reviewed-by: Roman Bolshakov Signed-off-by: Paolo Bonzini --- accel/stubs/hvf-stub.c | 30 -- accel/stubs/meson.build| 1 - include/sysemu/hvf.h | 8 targe

[PULL 31/37] replay: implement replay-seek command

2020-10-06 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch adds hmp/qmp commands replay_seek/replay-seek that proceed the execution to the specified instruction count. The command automatically loads nearest snapshot and replays the execution to find the desired instruction count. Signed-off-by: Pavel Dovgalyuk Acked-by

[PULL 14/37] whpx: remove whpx specific functions from global includes

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- accel/stubs/meson.build | 1 - accel/stubs/whpx-stub.c | 47 - include/sysemu/whpx.h | 19 - target/i386/whpx-cpus.h

[PULL 37/37] tests/acceptance: add reverse debugging test

2020-10-06 Thread Paolo Bonzini
From: Pavel Dovgalyuk This is a test for GDB reverse debugging commands: reverse step and reverse continue. Every test in this suite consists of two phases: record and replay. Recording saves the execution of some instructions and makes an initial VM snapshot to allow reverse execution. Replay s

Re: [PATCH v3] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-06 Thread Paolo Bonzini
On 05/10/20 21:51, Yonggang Luo wrote: > The sh script are harder to maintain for compatible different > xsh environment so convert it to python script > Also incorporate the fixes in > https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/ > > Testing args length and if not

Re: Emulate Rpi with QEMU fails

2020-10-06 Thread Paul Zimmerman
On Mon, Oct 5, 2020 at 11:58 PM Thomas Schneider <74cmo...@gmail.com> wrote: > > Hello Paul, > > many thanks for sharing this info. > > Can you confirm that the emulated RPi with your command will use > "internal QEMU" network, means the client cannot be accessed from any > other device in LAN? > I

[Bug 1772165] Re: arm raspi2/raspi3 emulation has no USB support

2020-10-06 Thread Dims
Command lines I use are like following $QEMU_EXE \ -kernel qemu-rpi-kernel/kernel-qemu-4.4.34-jessie \ -cpu arm1176 \ -m 256 \ -M versatilepb \ -append "dwc_otg.lpm_enable=0 root=/dev/sda2 panic=1" \ -hda 2017-07-05-raspbian-jessie.img \ -usb \ -nic user \ -seri

[Bug 1772165] Re: arm raspi2/raspi3 emulation has no USB support

2020-10-06 Thread Dims
I did this, but still can't access USB device, connected to host, from guest. Also I have $ lsusb unable to initalize libusb: -99 on guest. Playing with usb options gave nothing. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. htt

[PULL 21/37] configure: do not clobber environment CFLAGS/CXXFLAGS/LDFLAGS

2020-10-06 Thread Paolo Bonzini
If the CFLAGS, CXXFLAGS or LDFLAGS variables are present in the environment, any modification made within the configure script is passed down to Meson. This is particularly undesirable for the "-pie" option, since it overrides "-shared" and thus messes up the linker flags for shared modules. Using

[PULL 22/37] configure: consistently pass CFLAGS/CXXFLAGS/LDFLAGS to meson

2020-10-06 Thread Paolo Bonzini
Environment variables like CFLAGS are easy to accidentally change. Meson warns if that happens, but in a project with a lot of configuration that is easy to lose. It is also surprising behavior since meson caches -D options and remembers those on reconfiguration (which we rely on, since configure

[PULL 24/37] replay: don't record interrupt poll

2020-10-06 Thread Paolo Bonzini
From: Pavel Dovgalyuk Interrupt poll is not a real interrupt event. It is needed only for thread safety. This interrupt is used for i386 and converted to hardware interrupt by cpu_handle_interrupt function. Therefore it is not needed to be recorded, because hardware interrupt will be recorded aft

[PULL 16/37] kvm: remove kvm specific functions from global includes

2020-10-06 Thread Paolo Bonzini
From: Claudio Fontana Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-cpus.h | 7 +++ accel/stubs/kvm-stub.c | 22 -- include/sysemu/kvm.h | 7 --- 3 files changed, 7 insertions(+), 29 deletions(-)

[PULL 17/37] kvm: kvm_init_vcpu take Error pointer

2020-10-06 Thread Paolo Bonzini
From: "Dr. David Alan Gilbert" Clean up the error handling in kvm_init_vcpu so we can see what went wrong more easily. Make it take an Error ** and fill it out with what failed, including the cpu id, so you can tell if it only fails at a given ID. Replace the remaining DPRINTF by a trace. This

[PATCH] target/i386: avoid theoretical leak on MCE injection

2020-10-06 Thread Paolo Bonzini
g_strdup_printf is used twice to write to the same variable, which can theoretically cause a leak. In practice, it is extremely unlikely that a guest is seeing a recursive MCE and has disabled CR4.MCE between the first and the second error, but we can fix it and we can also make a slight improveme

[PULL 19/37] slirp: Convert Makefile bits to meson bits

2020-10-06 Thread Paolo Bonzini
SLIRP uses Meson so it could become a subproject in the future, but our choice of configure options is not yet supported in Meson (https://github.com/mesonbuild/meson/pull/7740). For now, build the library via the main meson.build just like for capstone. This improves the current state of affairs

[PULL 26/37] qcow2: introduce icount field for snapshots

2020-10-06 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf -- v7 changes: - also fix the test which checks qcow2 snapshot extra da

[PULL 28/37] qapi: introduce replay.json for record/replay-related stuff

2020-10-06 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch adds replay.json file. It will be used for adding record/replay-related data structures and commands. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Markus Armbruster Reviewed-by: Alex Bennée Message-Id: <160174519444.12451.3472949430004845434.stgit@pasha-ThinkPa

[PULL 29/37] replay: introduce info hmp/qmp command

2020-10-06 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch introduces 'info replay' monitor command and corresponding qmp request. These commands request the current record/replay mode, replay log file name, and the instruction count (number of recorded/replayed instructions). The instruction count can be used with the r

[PULL 33/37] gdbstub: add reverse step support in replay mode

2020-10-06 Thread Paolo Bonzini
From: Pavel Dovgalyuk GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution. Bu

Re: [PATCH v2] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-06 Thread Paolo Bonzini
On 05/10/20 21:22, Peter Maydell wrote: >> +def main(args): >> +if len(args) <= 3: >> +sys.exit(0) >> + >> +dir = args[1] >> +pkgversion = args[2] >> +version = args[3] In addition to what Peter pointed out, all these lines can be changed to def main(dir, pkgversion, v

Re: [RFC PATCH 1/3] qom: Always register FW_CFG_DATA_GENERATOR_INTERFACE

2020-10-06 Thread Laszlo Ersek
On 10/05/20 12:54, Philippe Mathieu-Daudé wrote: > While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed > by a device only available using system-mode (fw_cfg), it is > implemented by a crypto component (tls-cipher-suites) which > is always available when crypto is used. > > Commit 69699f305

Re: [PATCH v2 2/3] qga: add implementation of guest-get-disks for Linux

2020-10-06 Thread Tomáš Golembiovský
On Tue, Sep 29, 2020 at 07:22:00PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Sep 7, 2020 at 1:17 PM Tomáš Golembiovský > wrote: > > > The command lists all disks (real and virtual) as well as disk > > partitions. For each disk the list of slave disks is also listed and > > /dev path is us

[Bug 1772165] Re: arm raspi2/raspi3 emulation has no USB support

2020-10-06 Thread Paul Zimmerman
You need to use -M raspi2 (or -M raspi3 for 64-bit kernels) to enable the Raspberry Pi emulation. And you need version 5.1 or newer of Qemu to get the dwc2 USB emulation. I don't think any Linux distributions provide that new of a Qemu, so you might have to build it yourself. Here is the command l

Re: [PATCH v2 1/3] qga: add command guest-get-disks

2020-10-06 Thread Daniel P . Berrangé
On Mon, Sep 07, 2020 at 11:14:40AM +0200, Tomáš Golembiovský wrote: > Add API and stubs for new guest-get-disks command. > > The command guest-get-fsinfo can be used to list information about disks > and partitions but it is limited only to mounted disks with filesystem. > This new command should

Re: [PULL 5/5] crypto/tls-cipher-suites: Produce fw_cfg consumable blob

2020-10-06 Thread Laszlo Ersek
On 10/05/20 11:16, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 10/1/20 9:18 AM, Laszlo Ersek wrote: >> On 09/29/20 17:46, Kevin Wolf wrote: >>> Am 04.07.2020 um 18:39 hat Philippe Mathieu-Daudé geschrieben: Since our format is consumable by the fw_cfg device, we can implement the F

Re: [PATCH v2 2/3] qga: add implementation of guest-get-disks for Linux

2020-10-06 Thread Marc-André Lureau
Hi On Tue, Oct 6, 2020 at 12:31 PM Tomáš Golembiovský wrote: > On Tue, Sep 29, 2020 at 07:22:00PM +0400, Marc-André Lureau wrote: > > > > +if (getline(&line, &n, fp) == -1) { > > > +g_debug(" failed to read disk size"); > > > > > > > line: getline(3) "This buffer should be f

Re: [PATCH v2 10/15] hw/misc/bcm2835_cprman: add a clock mux skeleton implementation

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/5/20 9:56 PM, Luc Michel wrote: > The clock multiplexers are the last clock stage in the CPRMAN. Each mux > outputs one clock signal that goes out of the CPRMAN to the SoC > peripherals. > > Each mux has at most 10 sources. The sources 0 to 3 are common to all > muxes. They are: >0. grou

[Bug 1772165] Re: arm raspi2/raspi3 emulation has no USB support

2020-10-06 Thread Paul Zimmerman
Here is that command line again, hopefully readable this time: qemu-system-arm -M raspi2 \ -drive file=2019-09-26-raspbian-buster.img,format=raw,if=sd \ -dtb bcm2709-rpi-2-b.dtb \ -kernel kernel7.img \ -append 'rw earlycon=pl011,0x3f201000 console=ttyAMA0 \ loglevel=8 root=

Re: [PATCH v2 11/15] hw/misc/bcm2835_cprman: implement clock mux behaviour

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/5/20 9:56 PM, Luc Michel wrote: > A clock mux can be configured to select one of its 10 sources through > the CM_CTL register. It also embeds yet another clock divider, composed > of an integer part and a fractional part. The number of bits of each > part is mux dependent. > > Tested-by: Phi

Re: [PATCH v2 2/3] qga: add implementation of guest-get-disks for Linux

2020-10-06 Thread Daniel P . Berrangé
On Mon, Sep 07, 2020 at 11:14:41AM +0200, Tomáš Golembiovský wrote: > The command lists all disks (real and virtual) as well as disk > partitions. For each disk the list of slave disks is also listed and > /dev path is used as a handle so it can be matched with "name" filed of > other returned disk

Re: [PATCH v2 15/15] hw/arm/bcm2835_peripherals: connect the UART clock

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/5/20 9:56 PM, Luc Michel wrote: > Connect the 'uart-out' clock from the CPRMAN to the PL011 instance. > > Signed-off-by: Luc Michel > --- > hw/arm/bcm2835_peripherals.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 09/15] hw/misc/bcm2835_cprman: implement PLL channels behaviour

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/5/20 9:56 PM, Luc Michel wrote: > A PLL channel is able to further divide the generated PLL frequency. > The divider is given in the CTRL_A2W register. Some channels have an > additional fixed divider which is always applied to the signal. > > Tested-by: Philippe Mathieu-Daudé > Signed-off-

Re: [PATCH v2 03/15] hw/core/clock: add the clock_new helper function

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/5/20 9:56 PM, Luc Michel wrote: > This function creates a clock a parent it to another object with a given > name. It calls clock_setup_canonical_path before returning the new > clock. > > This function is useful to create clocks in devices when one doesn't > want to expose it at the qdev le

Re: [RFC PATCH 08/21] contrib/gitdm: Add Mentor Graphics to the domain map

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/6/20 6:01 AM, Jan Kiszka wrote: > On 05.10.20 22:52, Joseph Myers wrote: >> On Mon, 5 Oct 2020, Alex Bennée wrote: >> >>> Joseph Myers writes: >>> On Sun, 4 Oct 2020, Philippe Mathieu-Daudé wrote: > There is a number of contributors from this domain, > add its own entry to

[PATCH 0/2] Move more code to softmmu/

2020-10-06 Thread Paolo Bonzini
This small series moves more files to the softmmu/ directory. Patch 1 covers files that can be moved completely, while patch 2 splits exec.c into common and softmmu parts. Based-on: <20201006072947.487729-1-pbonz...@redhat.com> Paolo Bonzini (2): softmmu: move more files to softmmu/ exec: spl

[PATCH 1/2] softmmu: move more files to softmmu/

2020-10-06 Thread Paolo Bonzini
Keep most softmmu_ss files into the system-emulation-specific directory. Signed-off-by: Paolo Bonzini --- meson.build | 10 -- bootdevice.c => softmmu/bootdevice.c | 0 device_tree.c => softmmu/device_tree.c | 0 dma-helpers.c => softmmu/dma-helpers.c

[PATCH 2/2] exec: split out non-softmmu-specific parts

2020-10-06 Thread Paolo Bonzini
Over the years, most parts of exec.c that were not specific to softmmu have been moved to accel/tcg; what's left is mostly the low-level part of the memory API, which includes RAMBlock and AddressSpaceDispatch. However exec.c also hosts 4-500 lines of code for the target specific parts of the CPU Q

Re: [PULL 5/5] crypto/tls-cipher-suites: Produce fw_cfg consumable blob

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/6/20 10:41 AM, Laszlo Ersek wrote: > On 10/05/20 11:16, Philippe Mathieu-Daudé wrote: >> Hi Laszlo, >> >> On 10/1/20 9:18 AM, Laszlo Ersek wrote: >>> On 09/29/20 17:46, Kevin Wolf wrote: Am 04.07.2020 um 18:39 hat Philippe Mathieu-Daudé geschrieben: > Since our format is consumable b

Re: QEMU API cleanup initiative - Let's chat during the KVM call

2020-10-06 Thread Paolo Bonzini
On 05/10/20 16:52, John Snow wrote: > - Markus considers the platonic ideal of a CLI one in which each flag is > a configuration directive, and each directive that references another > directive must appear after the directive in which it references. > > - I tend to consider the ideal configuratio

Re: [PATCH 1/2] softmmu: move more files to softmmu/

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/6/20 11:19 AM, Paolo Bonzini wrote: > Keep most softmmu_ss files into the system-emulation-specific > directory. > > Signed-off-by: Paolo Bonzini > --- > meson.build | 10 -- > bootdevice.c => softmmu/bootdevice.c | 0 > device_tree.c => softmmu/de

Re: [PATCH 1/2] softmmu: move more files to softmmu/

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/6/20 11:34 AM, Philippe Mathieu-Daudé wrote: > On 10/6/20 11:19 AM, Paolo Bonzini wrote: >> Keep most softmmu_ss files into the system-emulation-specific >> directory. Oops, you forgot to update MAINTAINERS. >> >> Signed-off-by: Paolo Bonzini >> --- >> meson.build

Re: QEMU API cleanup initiative - Let's chat during the KVM call

2020-10-06 Thread Daniel P . Berrangé
On Tue, Oct 06, 2020 at 11:30:20AM +0200, Paolo Bonzini wrote: > On 05/10/20 16:52, John Snow wrote: > > - Markus considers the platonic ideal of a CLI one in which each flag is > > a configuration directive, and each directive that references another > > directive must appear after the directive i

[PATCH v4 2/4] pc-bios: s390x: Save PSW rework

2020-10-06 Thread Janosch Frank
We don't need to save the ipl_continue variable in lowcore and have it limited to 32 bits because of the lowcore layout. Let's move it to a new 64 bit variable and get rid of the reset info struct. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/jump2ipl.c | 33 ++

[PATCH v4 4/4] pc-bios: s390x: Go into disabled wait when encountering a PGM exception

2020-10-06 Thread Janosch Frank
Let's setup a PGM PSW, so we won't load 0s when a program exception happens. Instead we'll load a disabled wait PSW. Signed-off-by: Janosch Frank Reviewed-by: Christian Borntraeger Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/start.S | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[PATCH v4 3/4] pc-bios: s390x: Use reset PSW if avaliable

2020-10-06 Thread Janosch Frank
If a blob provides a reset PSW then we should use it instead of branching to the PSW address and using our own mask. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/bootmap.c | 6 -- pc-bios/s390-ccw/jump2ipl.c | 26 +++--- pc-bios/s390-ccw/s

[PATCH v4 1/4] pc-bios: s390x: Fix bootmap.c zipl component entry data handling

2020-10-06 Thread Janosch Frank
The two main types of zipl component entries are execute and load/data. The last member of the component entry struct therefore denotes either a PSW or an address. Let's make this a bit more clear by introducing a union and cleaning up the code that uses that struct member. The execute type compon

[PATCH v4 0/4] pc-bios: s390x: Cleanup part 2

2020-10-06 Thread Janosch Frank
So, here are a few more cleanup patches mostly cleaning up ipl code and some of the assembly. The patches are available here: https://github.com/frankjaa/qemu/pull/new/cleanup_bios2 CI: https://gitlab.com/frankja/qemu/-/pipelines/198568601 v4: * Dropped ext/io new PSW patch to speed up r

Re: [RFC PATCH 08/21] contrib/gitdm: Add Mentor Graphics to the domain map

2020-10-06 Thread Alex Bennée
Jan Kiszka writes: > On 05.10.20 22:52, Joseph Myers wrote: >> On Mon, 5 Oct 2020, Alex Bennée wrote: >> >>> Joseph Myers writes: >>> On Sun, 4 Oct 2020, Philippe Mathieu-Daudé wrote: > There is a number of contributors from this domain, > add its own entry to the gitdm doma

Re: [PATCH 2/2] exec: split out non-softmmu-specific parts

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/6/20 11:19 AM, Paolo Bonzini wrote: > Over the years, most parts of exec.c that were not specific to softmmu > have been moved to accel/tcg; what's left is mostly the low-level part > of the memory API, which includes RAMBlock and AddressSpaceDispatch. > However exec.c also hosts 4-500 lines

Re: [PATCH 1/2] softmmu: move more files to softmmu/

2020-10-06 Thread BALATON Zoltan via
On Tue, 6 Oct 2020, Paolo Bonzini wrote: Keep most softmmu_ss files into the system-emulation-specific directory. The name of this dir may be misleading. I think it originally stood for the actual MMU emulation but now it seems everything related to system emulation is dumped here. Is it bett

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-10-06 Thread Igor Mammedov
On Mon, 28 Sep 2020 21:17:31 +0800 Jiajun Chen wrote: > Used_memslots is equal to dev->mem->nregions now, it is true for > vhost kernel, but not for vhost user, which uses the memory regions > that have file descriptor. In fact, not all of the memory regions > have file descriptor. > It is useful

Re: [RFC PATCH 1/3] qom: Always register FW_CFG_DATA_GENERATOR_INTERFACE

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/5/20 3:22 PM, Daniel P. Berrangé wrote: > On Mon, Oct 05, 2020 at 12:54:40PM +0200, Philippe Mathieu-Daudé wrote: >> While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed >> by a device only available using system-mode (fw_cfg), it is >> implemented by a crypto component (tls-cipher-suit

Re: QEMU API cleanup initiative - Let's chat during the KVM call

2020-10-06 Thread Daniel P . Berrangé
On Mon, Oct 05, 2020 at 10:52:41AM -0400, John Snow wrote: > - Markus considers the platonic ideal of a CLI one in which each flag is a > configuration directive, and each directive that references another > directive must appear after the directive in which it references. In this view you would b

Re: QEMU API cleanup initiative - Let's chat during the KVM call

2020-10-06 Thread Paolo Bonzini
On 06/10/20 11:40, Daniel P. Berrangé wrote: >> Currently we have: >> >> switch (...) { >> case QEMU_OPT_...: >> /* something has side effects, something is just parsing */ >> } >> >> init1(); >> qemu_opts_foreach(something_opts, configure_something); >> init

Re: [PATCH 1/2] softmmu: move more files to softmmu/

2020-10-06 Thread Paolo Bonzini
On 06/10/20 11:43, BALATON Zoltan wrote: > > The name of this dir may be misleading. I think it originally stood > for the actual MMU emulation but now it seems everything related to > system emulation is dumped here. Is it better to keep MMU emulation > separate and put other files in a "sysemu"

Re: Emulate Rpi with QEMU fails

2020-10-06 Thread Alex Bennée
Thomas Schneider <74cmo...@gmail.com> writes: > Hello Paul, > > many thanks for sharing this info. > > Can you confirm that the emulated RPi with your command will use > "internal QEMU" network, means the client cannot be accessed from any > other device in LAN? The support for user-mode and

[PATCH] virtiofsd: avoid /proc/self/fd tempdir

2020-10-06 Thread Stefan Hajnoczi
In order to prevent /proc/self/fd escapes a temporary directory is created where /proc/self/fd is bind-mounted. This doesn't work on read-only file systems. Avoid the temporary directory by bind-mounting /proc/self/fd over /proc. This does not affect other processes since we remounted / with MS_RE

Re: [PATCH] vhost: Ignore vrings in dirty log when using a vIOMMU

2020-10-06 Thread Greg Kurz
On Mon, 5 Oct 2020 10:18:03 -0400 "Michael S. Tsirkin" wrote: > On Mon, Sep 28, 2020 at 09:37:18AM +0200, Greg Kurz wrote: > > On Mon, 28 Sep 2020 16:23:43 +1000 > > David Gibson wrote: > > > > > On Fri, Sep 25, 2020 at 07:29:43PM +0200, Greg Kurz wrote: > > > > When a vIOMMU is present, any ad

Re: [PATCH 1/2] softmmu: move more files to softmmu/

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/6/20 11:54 AM, Paolo Bonzini wrote: > On 06/10/20 11:43, BALATON Zoltan wrote: >> >> The name of this dir may be misleading. I think it originally stood >> for the actual MMU emulation but now it seems everything related to >> system emulation is dumped here. Is it better to keep MMU emulatio

Re: [RFC 1/1] tools/virtiofsd: create temporary directory in /tmp

2020-10-06 Thread Stefan Hajnoczi
On Thu, Oct 01, 2020 at 08:15:19AM +0200, Jens Freimann wrote: > mkdtemp() will try to create a current directory in the working > directory of the process. In this case it's trying to create it in /. > This is a problem when the process doesn't have write access there. > > This patch changes the

Re: [PATCH v2 4/9] microvm: add usb support

2020-10-06 Thread Igor Mammedov
On Thu, 1 Oct 2020 10:28:29 +0200 Gerd Hoffmann wrote: > Wire up "usb=on" machine option, when enabled add > a sysbus xhci controller with 8 ports. first pci, and now usb - not so micro anymore. why not just reuse pci to add usb controller? what/how much do we win avoiding PCI? > > Signed-of

Re: [PATCH v2] hw/arm: Restrict APEI tables generation to the 'virt' machine

2020-10-06 Thread Igor Mammedov
On Thu, 1 Oct 2020 18:22:07 +0200 Philippe Mathieu-Daudé wrote: > While APEI is a generic ACPI feature (usable by X86 and ARM64), only > the 'virt' machine uses it, by enabling the RAS Virtualization. See > commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option"). > > Restrict the APEI

[Bug 1880066] Re: Microphone input dies in guest when switching evdev input

2020-10-06 Thread Chris
** Also affects: qemu (Fedora) Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1880066 Title: Microphone input dies in guest when switching evdev input St

Re: [PATCH v2 2/3] docs: add qemu-storage-daemon(1) man page

2020-10-06 Thread Kevin Wolf
Am 10.09.2020 um 16:43 hat Stefan Hajnoczi geschrieben: > Document the qemu-storage-daemon tool. Most of the command-line options > are identical to their QEMU counterparts. Perhaps Sphinx hxtool > integration could be extended to extract documentation for individual > command-line options so they

[PATCH] version.texi.in: remove

2020-10-06 Thread Paolo Bonzini
This is not needed anymore, since there aren't any more Texinfo sources. Signed-off-by: Paolo Bonzini --- version.texi.in | 2 -- 1 file changed, 2 deletions(-) delete mode 100644 version.texi.in diff --git a/version.texi.in b/version.texi.in deleted file mode 100644 index 0a723b8be6..

Re: [PATCH v4 0/4] pc-bios: s390x: Cleanup part 2

2020-10-06 Thread Thomas Huth
On 06/10/2020 11.42, Janosch Frank wrote: So, here are a few more cleanup patches mostly cleaning up ipl code and some of the assembly. The patches are available here: https://github.com/frankjaa/qemu/pull/new/cleanup_bios2 CI: https://gitlab.com/frankja/qemu/-/pipelines/198568601 v4:

Re: [PATCH v2 1/3] docs: generate qemu-storage-daemon-qmp-ref(7) man page

2020-10-06 Thread Kevin Wolf
Am 10.09.2020 um 16:43 hat Stefan Hajnoczi geschrieben: > Although qemu-storage-daemon QMP commands are identical to QEMU QMP > commands they are a subset. Generate a manual page of just the commands > supported by qemu-storage-daemon so that users know exactly what is > available in qemu-storage-d

Re: [PATCH v2 3/3] MAINTAINERS: add Kevin Wolf as storage daemon maintainer

2020-10-06 Thread Kevin Wolf
Am 10.09.2020 um 16:44 hat Stefan Hajnoczi geschrieben: > The MAINTAINERS file was not updated when the storage daemon was merged. > > Signed-off-by: Stefan Hajnoczi Acked-by: Kevin Wolf

Re: [PATCH v3] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-06 Thread Peter Maydell
On Mon, 5 Oct 2020 at 20:51, Yonggang Luo wrote: > > The sh script are harder to maintain for compatible different > xsh environment so convert it to python script > Also incorporate the fixes in > https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/ > > Testing args lengt

Re: [Bug 1772165] Re: arm raspi2/raspi3 emulation has no USB support

2020-10-06 Thread Peter Maydell
On Mon, 5 Oct 2020 at 21:38, mcandre <1772...@bugs.launchpad.net> wrote: > Which Beagle boards, Jetson Nano, other devices have rich support from > qemu? ARM is critical going forward. If you just want to be able to run a Linux kernel and Arm userspace code and you don't have a strong preference f

Re: [PATCH] vhost: Ignore vrings in dirty log when using a vIOMMU

2020-10-06 Thread Michael S. Tsirkin
On Tue, Oct 06, 2020 at 11:58:50AM +0200, Greg Kurz wrote: > On Mon, 5 Oct 2020 10:18:03 -0400 > "Michael S. Tsirkin" wrote: > > > On Mon, Sep 28, 2020 at 09:37:18AM +0200, Greg Kurz wrote: > > > On Mon, 28 Sep 2020 16:23:43 +1000 > > > David Gibson wrote: > > > > > > > On Fri, Sep 25, 2020 at

Re: [RFC PATCH 09/21] contrib/gitdm: Add Nutanix to the domain map

2020-10-06 Thread Prerna Saxena
On 04/10/20, 11:35 PM, "Philippe Mathieu-Daudé" wrote: There is a number of contributors from this domain, add its own entry to the gitdm domain map. Cc: Ani Sinha Cc: David Vrabel Cc: Felipe Franciosi Cc: Jonathan Davies Cc: Malcolm Crossley Cc: Mike Cui

Re: [PATCH] virtiofsd: avoid /proc/self/fd tempdir

2020-10-06 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > In order to prevent /proc/self/fd escapes a temporary directory is > created where /proc/self/fd is bind-mounted. This doesn't work on > read-only file systems. > > Avoid the temporary directory by bind-mounting /proc/self/fd over /proc. > This does

Re: [PATCH v3] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-06 Thread Yonggang Luo
On Tue, Oct 6, 2020 at 6:33 PM Peter Maydell wrote: > > On Mon, 5 Oct 2020 at 20:51, Yonggang Luo wrote: > > > > The sh script are harder to maintain for compatible different > > xsh environment so convert it to python script > > Also incorporate the fixes in > > https://patchew.org/QEMU/20200929

[PATCH 00/10] meson: Move the creation of the library to the main meson.build

2020-10-06 Thread Philippe Mathieu-Daudé
Make Meson machinery more consistent, as requested by Paolo. Philippe Mathieu-Daudé (10): migration: Only add migration files to the Meson sourceset meson.build: Add comments to clarify code organization meson.build: Sort sourcesets alphabetically hw/core: Move the creation of the library

[PATCH 07/10] io: Move the creation of the library to the main meson.build

2020-10-06 Thread Philippe Mathieu-Daudé
Be consistent creating all the libraries in the main meson.build file. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- meson.build| 10 ++ io/meson.build | 10 -- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/meson.build b/meson.build

  1   2   3   4   5   >