Re: [RFC v5 06/68] target/riscv: rvv-1.0: add translation-time vector context status

2020-10-05 Thread Frank Chang
On Sat, Oct 3, 2020 at 12:19 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 9/29/20 2:03 PM, frank.ch...@sifive.com wrote: > > +++ b/target/riscv/insn_trans/trans_rvv.c.inc > > @@ -41,6 +41,7 @@ static bool trans_vsetvl(DisasContext *ctx, arg_vsetvl > *a) > > gen_get_gpr(s2,

Re: [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands

2020-10-05 Thread Markus Armbruster
Eric Blake writes: > On 10/2/20 11:27 AM, Daniel P. Berrangé wrote: >> savevm, loadvm and delvm are some of the few HMP commands that have never >> been converted to use QMP. The reasons for the lack of conversion are >> that they blocked execution of the event thread, and the semantics >> around

Re: [PATCH 15/16] target/mips/cpu: Do not allow system-mode use without input clock

2020-10-05 Thread Philippe Mathieu-Daudé
+Thomas for qtest On 9/29/20 4:40 PM, Philippe Mathieu-Daudé wrote: > On 9/29/20 3:01 PM, Igor Mammedov wrote: >> On Mon, 28 Sep 2020 19:15:38 +0200 >> Philippe Mathieu-Daudé wrote: >> >>> Now than all QOM users provides the input clock, do not allow >>> using a CPU core without its input clock c

Re: [Phishing Risk] [External] [RFC PATCH 04/21] contrib/gitdm: Add ByteDance to the domain map

2020-10-05 Thread Jiachen Zhang
On Mon, Oct 5, 2020 at 2:04 AM Philippe Mathieu-Daudé wrote: > There is a number of contributors from this domain, > add its own entry to the gitdm domain map. > > Cc: Guoqing Zhang > Cc: Jiachen Zhang > Cc: Xie Yongji > Cc: Zhenwei Pi > Signed-off-by: Philippe Mathieu-Daudé > --- > One Revi

Re: [PATCH 0/2] hw/mips: Code simplifications

2020-10-05 Thread Philippe Mathieu-Daudé
ping? On 9/27/20 6:39 PM, Philippe Mathieu-Daudé wrote: > Doing housekeeping on old branches older than 1 year. > Some patches are still valuable, so post them. > > These patches should not introduce logical change, > they simply rewrite old style code using more recent > API/macros. > > Philipp

Re: [PATCH] qom: Improve error message displayed with missing object properties

2020-10-05 Thread Philippe Mathieu-Daudé
Eduardo, can you take this patch, or can it goes via qemu-trivial? On 9/20/20 5:53 PM, Philippe Mathieu-Daudé wrote: > Instead of only displaying the property missing, also display > the object name. This help developer to quickly figure out the > mistake without opening a debugger. > > Signed-of

Re: [PATCH] hw/ssi/npcm7xx_fiu: Fix handling of unsigned integer

2020-10-05 Thread Philippe Mathieu-Daudé
Hi Peter, Can you take this patch via your qemu-arm tree? On 9/19/20 3:24 PM, Philippe Mathieu-Daudé wrote: > Fix integer handling issues handling issue reported by Coverity: > > hw/ssi/npcm7xx_fiu.c: 162 in npcm7xx_fiu_flash_read() > >>> CID 1432730: Integer handling issues (NEGATIVE_

Re: [PATCH] ssi: Display chip select polarity in monitor 'info qtree'

2020-10-05 Thread Philippe Mathieu-Daudé
Hi Peter, Can you take this patch via your qemu-arm tree please? (most of SPI boards are ARM based) On 9/27/20 11:19 AM, Philippe Mathieu-Daudé wrote: > It is sometime useful to verify a device chip select polarity > on a SPI bus. Since we have this information available, display > it in the 'inf

Re: [PULL v2 00/92] Misc patches for 2020-09-24

2020-10-05 Thread Philippe Mathieu-Daudé
Hi Paolo, On 9/25/20 1:44 PM, Peter Maydell wrote: > On Fri, 25 Sep 2020 at 11:45, Peter Maydell wrote: >> >> On Fri, 25 Sep 2020 at 11:33, Paolo Bonzini wrote: >> >> Date: Fri Sep 25 11:41:22 2020 +0100 >> Signed-off-by: Philippe Mathieu-Daudé >> ERROR: pull request includes tag with UTF

Re: [PATCH 0/2] .mailmap: Fixes since v5.1

2020-10-05 Thread Erik Smit
On Sun, 4 Oct 2020 at 19:26, Philippe Mathieu-Daudé wrote: > > Fix incorrect entries committed during 5.1-5.2. > > To the developers Cc'ed: > > If you agree with your entry, please reply with a Reviewed-by / > Acked-by tag. If you disagree or doesn't care, please either > reply with Nack-by or ign

Re: [PATCH v2] elfload: use g_new/g_malloc and g_autofree

2020-10-05 Thread Markus Armbruster
Please don't post respins as replies, because our tooling will miss them there, and even humans may. Start a new thread instead. Next time :) Elena Afanasova writes: > Subject: [PATCH v2] elfload: use g_new/g_malloc and g_autofree > > Signed-off-by: Elena Afanasova > --- > bsd-user/elfload.c

Re: [PATCH 0/5] qapi: Restrict machine (and migration) specific commands

2020-10-05 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Reduce the machine code pulled into qemu-storage-daemon. I'm leaving review to Eduardo and Marcel for PATCH 1-4, and to David and Juan for PATCH 5. David already ACKed. Can do the pull request.

Re: [PATCH v2] sd: Exhibit support for CMD23

2020-10-05 Thread Philippe Mathieu-Daudé
Hi Sai, On 9/16/20 7:51 PM, Sai Pavan Boddu wrote: > Update 'SCR.CMD_SUPPORT' register with support of CMD23. > > Signed-off-by: Sai Pavan Boddu > Reported-by: Rahul Thati > --- > Changes for V2: > Fix commit message > > hw/sd/sd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [RFC PATCH 13/21] contrib/gitdm: Add more entries to the Red Hat domain

2020-10-05 Thread Frediano Ziglio
Hi, can I disagree? If the contribution is personal I use my personal address, if the contribution is from the job in the company I'm using the company address. Regards, Frediano Il giorno dom 4 ott 2020 alle ore 19:05 Philippe Mathieu-Daudé < f4...@amsat.org> ha scritto: > Cc: Frediano Zi

Re: [PATCH v2] tests/boot_linux_console: Boot Trusted Firmware-A on the Raspberry Pi 3

2020-10-05 Thread Philippe Mathieu-Daudé
On 2/17/20 11:34 AM, Philippe Mathieu-Daudé wrote: > This test runs Trusted Firmware-A on the Raspberry Pi 3. > We deliberately stop the boot process when the EDK2 UEFI version > is displayed. > > The binary is build on AppVeyor CI using Pete Batard repository [1]. > ATF v2.1 binary are used (see

Re: [PATCH] tests/acceptance: Add a 'virt_kvm' test using the GICv3

2020-10-05 Thread Philippe Mathieu-Daudé
On 9/30/20 12:48 AM, Philippe Mathieu-Daudé wrote: > The current 'virt_kvm' test is restricted to GICv2, but can also > work with a GICv3. Duplicate it but add a GICv3 test which can be > tested on some hardware. > > Noticed while running: > > $ avocado --show=app run -t machine:virt tests/accep

Re: scripts/gdb: issues when loading modules after lx-symbols

2020-10-05 Thread Stefano Garzarella
On Sun, Oct 04, 2020 at 08:52:37PM +0200, Jan Kiszka wrote: > On 01.10.20 16:31, Stefano Garzarella wrote: > > Hi, > > I had some issues with gdb scripts and kernel modules in Linux 5.9-rc7. > > > > If the modules are already loaded, and I do 'lx-symbols', all work fine. > > But, if I load a kerne

Re: [PATCH v7 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-05 Thread Daniel P . Berrangé
On Sat, Oct 03, 2020 at 02:08:38AM +0800, Yonggang Luo wrote: > msys2/mingw lacks the POSIX-required langinfo.h. > > gcc test.c -DNCURSES_WIDECHAR -I/mingw64/include/ncursesw -pipe -lncursesw > -lgnurx -ltre -lintl -liconv > test.c:4:10: fatal error: langinfo.h: No such file or directory > 4

Re: [PATCH v7 0/4] Fixes curses on msys2/mingw

2020-10-05 Thread Daniel P . Berrangé
Only one of the 4 patches in this series appears to have been sent. On Sat, Oct 03, 2020 at 02:08:37AM +0800, Yonggang Luo wrote: > V6-V7 > Update the configure script for > * curses: Fixes compiler error that complain don't have langinfo.h on msys2/m= > ingw > > V5-V6 > Dropping configure: Fixes

[PULL 00/19] Build system + MCE patches for 2020-10-05

2020-10-05 Thread Paolo Bonzini
The following changes since commit 469e72ab7dbbd7ff4ee601e5ea7c29545d46593b: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2020-10-02 16:19:42 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetc

[PULL 02/19] default-configs: move files to default-configs/devices/

2020-10-05 Thread Paolo Bonzini
Make room for target files in default-configs/targets/ Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- configure | 6 +++--- default-configs/{ => devices}/aarch64-linux-user.mak | 0 default-configs/{ => devices}/aarch64-softm

[PULL 08/19] configure: remove useless config-target.mak symbols

2020-10-05 Thread Paolo Bonzini
Omit symbols that are not needed by softmmu or bsd-user targets, in preparation for moving the generated config-target.mak files into the source tree. Signed-off-by: Paolo Bonzini --- configure | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/config

[PULL 13/19] default-configs: remove redundant keys

2020-10-05 Thread Paolo Bonzini
TARGET_BASE_ARCH and TARGET_ABI_DIR are 99% of the time the same as TARGET_ARCH, remove them if so. Signed-off-by: Paolo Bonzini --- default-configs/targets/aarch64-linux-user.mak | 1 - default-configs/targets/aarch64_be-linux-user.mak | 1 - default-configs/targets/alpha-linux-user.mak

[PULL 10/19] default-configs: remove default-configs/devices for user-mode targets

2020-10-05 Thread Paolo Bonzini
We no longer need dummy files to detect targets, since default-configs/targets/ exists. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- configure | 6 +++--- default-configs/devices/aarch64-linux-user.mak

[PULL 07/19] configure: compute derivatives of target name in meson

2020-10-05 Thread Paolo Bonzini
Several CONFIG_* symbols in config-target.mak are easily computed from just the target name. We do not need them in config-target.mak, and can instead place them in the config_target dictionary only. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini ---

[PULL 01/19] travis: remove TCI test

2020-10-05 Thread Paolo Bonzini
TCI is already covered on gitlab CI, so we can remove it. Cc: Thomas Huth Cc: Alex Bennée Signed-off-by: Paolo Bonzini --- .travis.yml | 8 1 file changed, 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index 519e62432d..1054ec5d29 100644 --- a/.travis.yml +++ b/.travis.yml @@

[PULL 16/19] qapi/run-state.json: introduce memory failure event

2020-10-05 Thread Paolo Bonzini
From: zhenwei pi Introduce memory failure events for hypervisor and guest. This lets mft: Need exactly one file argument. Try `mft --help' for more information. Suggested by Peter Maydell, rename events name&description to make them architecture-neutral; and suggested by Paolo, add more info to

[PULL 04/19] configure: rewrite accelerator defaults as tests

2020-10-05 Thread Paolo Bonzini
Prepare to process "auto" in meson rather than configure: standardize the shape of the code that changes "auto" to enabled/disabled, to ease the review when it will be moved to meson. Signed-off-by: Paolo Bonzini --- configure | 58 --- 1 file

[PULL 11/19] configure: move OpenBSD W^X test to meson

2020-10-05 Thread Paolo Bonzini
The TCG option is now passed through to Meson. Signed-off-by: Paolo Bonzini --- configure | 15 --- meson.build | 8 +++- 2 files changed, 7 insertions(+), 16 deletions(-) diff --git a/configure b/configure index a32c43a905..b31bf24d60 100755 --- a/configure +++ b/configure @

[PULL 03/19] configure: convert accelerator variables to meson options

2020-10-05 Thread Paolo Bonzini
Prepare for moving the tests to meson. For now they only have enabled/disabled as the possible values when meson is invoked, but "auto" will be a possibility later, when configure will only parse the command line options. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- configur

[PULL 17/19] target-i386: post memory failure event to QMP

2020-10-05 Thread Paolo Bonzini
From: zhenwei pi Post memory failure event through QMP to handle hardware memory corrupted event. Rather than simply printing to the log, QEMU could report more effective message to the client. For example, if a guest receives an MCE, evacuating the host could be a good idea. Signed-off-by: zhen

[PULL 06/19] configure: remove dead variable

2020-10-05 Thread Paolo Bonzini
Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- configure | 11 --- 1 file changed, 11 deletions(-) diff --git a/configure b/configure index 9224ac47e6..2133239593 100755 --- a/configure +++ b/configure @@ -811,9 +811,6 @@ fi # OS specific -# host *BSD for user mode

[PULL 05/19] configure: move accelerator logic to meson

2020-10-05 Thread Paolo Bonzini
Move to meson the code to detect the presence of accelerators, and to define accelerator-specific config-target.h symbols. The logic for now is duplicated in configure because it is still in use to build the list of targets (which is in turn used to create the config-target.mak files). The next p

[PULL 19/19] dockerfiles: add diffutils to Fedora

2020-10-05 Thread Paolo Bonzini
For some reason diffutils is not included in the Fedora containers anymore, causing the build to fail. Signed-off-by: Paolo Bonzini Reviewed-by: Neal Gompa Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201003085054.332992-2-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/dock

[PULL 12/19] default-configs: use TARGET_ARCH key

2020-10-05 Thread Paolo Bonzini
Replace the individual TARGET_*=y lines with TARGET_ARCH, similar to how TARGET_BASE_ARCH is handled already. Signed-off-by: Paolo Bonzini --- default-configs/targets/aarch64-linux-user.mak | 2 +- default-configs/targets/aarch64-softmmu.mak | 2 +- default-configs/targets/aarch64_b

Re: [RFC PATCH 13/21] contrib/gitdm: Add more entries to the Red Hat domain

2020-10-05 Thread Philippe Mathieu-Daudé
On Mon, Oct 5, 2020 at 10:05 AM Frediano Ziglio wrote: > > Hi, > can I disagree? If the contribution is personal I use my personal address, > if the contribution is from the job in the company I'm using the company > address. Certainly! Can I add your personal address to the "individual contr

[PULL 09/19] configure: remove target configuration

2020-10-05 Thread Paolo Bonzini
The config-target.mak files are small constant, we can therefore just write them down explicitly. This removes a pretty large part of the configure script, including the whole logic to detect which accelerators are supported by each target. Signed-off-by: Paolo Bonzini --- configure

Re: [RFC PATCH 13/21] contrib/gitdm: Add more entries to the Red Hat domain

2020-10-05 Thread Frediano Ziglio
Il giorno lun 5 ott 2020 alle ore 09:39 Philippe Mathieu-Daudé < f4...@amsat.org> ha scritto: > On Mon, Oct 5, 2020 at 10:05 AM Frediano Ziglio > wrote: > > > > Hi, > > can I disagree? If the contribution is personal I use my personal > address, if the contribution is from the job in the compan

[PULL 14/19] meson: move sparse detection to Meson and rewrite check_sparse.py

2020-10-05 Thread Paolo Bonzini
Pass the path to the program to scripts/check_sparse.py, which previously was not included in config-host.mak. Change scripts/check_sparse.py to work with cgcc, which seems to work better with sparse 0.6.x. Signed-off-by: Paolo Bonzini --- configure | 24 +++--- meson.

Re: [PULL v2 00/92] Misc patches for 2020-09-24

2020-10-05 Thread Paolo Bonzini
On 05/10/20 09:51, Philippe Mathieu-Daudé wrote: > Is that why your "configure: fix performance regression due to PIC > objects" patch has been dropped from your pull request? Partly. Regarding this particular failure, since Richard's capstone patches are being merged, I think it's easier to do

[PULL 15/19] target-i386: seperate MCIP & MCE_MASK error reason

2020-10-05 Thread Paolo Bonzini
From: zhenwei pi Previously we would only get a simple string "Triple fault" in qemu log. Add detailed message for the two reasons to describe why qemu has to reset the guest. Signed-off-by: zhenwei pi Message-Id: <20200930100440.1060708-2-pizhen...@bytedance.com> Signed-off-by: Paolo Bonzini

Re: [PATCH] qom: Improve error message displayed with missing object properties

2020-10-05 Thread Paolo Bonzini
On 20/09/20 17:53, Philippe Mathieu-Daudé wrote: > Instead of only displaying the property missing, also display > the object name. This help developer to quickly figure out the > mistake without opening a debugger. > > Signed-off-by: Philippe Mathieu-Daudé > --- > qom/object.c | 3 ++- > 1 file

Re: [PATCH 0/5] qapi: Restrict machine (and migration) specific commands

2020-10-05 Thread Paolo Bonzini
On 05/10/20 10:01, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Reduce the machine code pulled into qemu-storage-daemon. > I'm leaving review to Eduardo and Marcel for PATCH 1-4, and to David and > Juan for PATCH 5. David already ACKed. > > Can do the pull request. > If it c

[PULL 18/19] tests: tcg: do not use implicit rules

2020-10-05 Thread Paolo Bonzini
Use pattern rules to clarify which targets are going to match the rule and to provide clearer error messages. Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 40

[PATCH v2 0/2] hw/virtio-pci: AER capability

2020-10-05 Thread andrew
From: Andrew Melnychenko Now, AER capability for virtio-pci is disabled by default. AER capability is only for PCI with PCIe interface on PCIe bus. During migration - device "realize" should initialize AER if requested by device properties. Andrew (2): hw/virtio-pci Added counter for pcie capa

[PATCH v2 1/2] hw/virtio-pci Added counter for pcie capabilities offsets.

2020-10-05 Thread andrew
From: Andrew Removed hardcoded offset for ats. Added cap offset counter for future capabilities like AER. Signed-off-by: Andrew Melnychenko --- hw/virtio/virtio-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 5b

[PATCH v2 2/2] hw/virtio-pci Added AER capability.

2020-10-05 Thread andrew
From: Andrew Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1857668 Added AER capability for virtio-pci devices. Also added property for devices, by default AER is enabled. Signed-off-by: Andrew Melnychenko --- hw/virtio/virtio-pci.c | 16 hw/virtio/virtio-pci.h | 4 +++

Re: scripts/gdb: issues when loading modules after lx-symbols

2020-10-05 Thread Jan Kiszka
On 05.10.20 10:14, Stefano Garzarella wrote: > On Sun, Oct 04, 2020 at 08:52:37PM +0200, Jan Kiszka wrote: >> On 01.10.20 16:31, Stefano Garzarella wrote: >>> Hi, >>> I had some issues with gdb scripts and kernel modules in Linux 5.9-rc7. >>> >>> If the modules are already loaded, and I do 'lx-symb

Re: [RFC PATCH 09/21] contrib/gitdm: Add Nutanix to the domain map

2020-10-05 Thread Philippe Mathieu-Daudé
On 10/5/20 7:22 AM, Ani Sinha wrote: > > > On Sun, Oct 4, 2020 at 23:34 Philippe Mathieu-Daudé > wrote: > > There is a number of contributors from this domain, > add its own entry to the gitdm domain map. > > Cc: Ani Sinha mailto:ani.si...@nutanix.com>> >

Re: [PULL 5/5] crypto/tls-cipher-suites: Produce fw_cfg consumable blob

2020-10-05 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 10/1/20 9:18 AM, Laszlo Ersek wrote: > On 09/29/20 17:46, Kevin Wolf wrote: >> Am 04.07.2020 um 18:39 hat Philippe Mathieu-Daudé geschrieben: >>> Since our format is consumable by the fw_cfg device, >>> we can implement the FW_CFG_DATA_GENERATOR interface. >>> >>> Example of use to d

Re: [RFC PATCH 20/21] contrib/gitdm: Add Yandex to the domain map

2020-10-05 Thread Roman Kagan
On Sun, Oct 04, 2020 at 08:04:42PM +0200, Philippe Mathieu-Daudé wrote: > There is a number of contributors from this domain, > add its own entry to the gitdm domain map. > > Cc: Alexey Kirillov > Cc: Alexey Krasikov > Cc: Anton Kuchin > Cc: Dima Stepanov > Cc: Evgeny Yakovlev > Cc: Roman Kag

Re: [PATCH v3 17/19] hw/arm: Automatically select the 'virt' machine on KVM

2020-10-05 Thread Philippe Mathieu-Daudé
On 10/1/20 5:05 PM, Philippe Mathieu-Daudé wrote: > On 10/1/20 9:38 AM, Paolo Bonzini wrote: >> On 29/09/20 22:36, Philippe Mathieu-Daudé wrote: >>> Yes, the problem if I don't restrict to KVM, when >>> using the Xen accelerator odd things occur >>> (using configure --enable-xen --disable-tcg --dis

Re: scripts/gdb: issues when loading modules after lx-symbols

2020-10-05 Thread Stefano Garzarella
On Mon, Oct 05, 2020 at 10:33:30AM +0200, Jan Kiszka wrote: > On 05.10.20 10:14, Stefano Garzarella wrote: > > On Sun, Oct 04, 2020 at 08:52:37PM +0200, Jan Kiszka wrote: > >> On 01.10.20 16:31, Stefano Garzarella wrote: > >>> Hi, > >>> I had some issues with gdb scripts and kernel modules in Linux

Re: [RFC PATCH 10/21] contrib/gitdm: Add Nuvia to the domain map

2020-10-05 Thread Graeme Gregory
On Sun, Oct 04, 2020 at 08:04:32PM +0200, Philippe Mathieu-Daudé wrote: > There is a number of contributions from this domain, > add its own entry to the gitdm domain map. > > Cc: Graeme Gregory > Cc: Leif Lindholm > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Graeme Gregory > --- > O

Re: Emulate Rpi with QEMU fails

2020-10-05 Thread Alex Bennée
Peter Maydell writes: > On Sun, 4 Oct 2020 at 18:44, Alex Bennée wrote: >> Thomas <74cmo...@gmail.com> writes: >> > I'm trying to emulate Rpi with QEMU. >> > I found >> > [url=1]this[/url] >> > arcticle in Raspberry Pi Geek documenting the steps including persistent >> > storage on host. >> >

Re: scripts/gdb: issues when loading modules after lx-symbols

2020-10-05 Thread Jan Kiszka
On 05.10.20 11:29, Stefano Garzarella wrote: > On Mon, Oct 05, 2020 at 10:33:30AM +0200, Jan Kiszka wrote: >> On 05.10.20 10:14, Stefano Garzarella wrote: >>> On Sun, Oct 04, 2020 at 08:52:37PM +0200, Jan Kiszka wrote: On 01.10.20 16:31, Stefano Garzarella wrote: > Hi, > I had some iss

Re: [PATCH v2] elfload: use g_new/g_malloc and g_autofree

2020-10-05 Thread Peter Maydell
On Sun, 4 Oct 2020 at 13:22, Elena Afanasova wrote: > > Subject: [PATCH v2] elfload: use g_new/g_malloc and g_autofree > > Signed-off-by: Elena Afanasova > --- > bsd-user/elfload.c | 79 -- > 1 file changed, 14 insertions(+), 65 deletions(-) Random qu

Re: [PATCH v3 1/6] plugins: Fixes a issue when dlsym failed, the handle not closed

2020-10-05 Thread Alex Bennée
Yonggang Luo writes: > Signed-off-by: Yonggang Luo > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v3 2/6] plugin: Fixes compiling errors on msys2/mingw

2020-10-05 Thread Alex Bennée
Yonggang Luo writes: > Signed-off-by: Yonggang Luo > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 2/2] hw/virtio-pci Added AER capability.

2020-10-05 Thread Michael S. Tsirkin
On Mon, Oct 05, 2020 at 12:01:40PM +0300, and...@daynix.com wrote: > From: Andrew > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1857668 > Added AER capability for virtio-pci devices. > Also added property for devices, by default AER is enabled. Looking at code it's disabled by defaul

Re: [PATCH v2 0/2] hw/virtio-pci: AER capability

2020-10-05 Thread Michael S. Tsirkin
On Mon, Oct 05, 2020 at 12:01:38PM +0300, and...@daynix.com wrote: > From: Andrew Melnychenko > > Now, AER capability for virtio-pci is disabled by default. > AER capability is only for PCI with PCIe interface on PCIe bus. > During migration - device "realize" should initialize AER > if requested

Re: [PATCH v3 3/6] cirrus: Enable plugin in cirrus for windows

2020-10-05 Thread Alex Bennée
Yonggang Luo writes: > Signed-off-by: Yonggang Luo If the build doesn't work until your later fixes then this should be the last patch in the series. > --- > .cirrus.yml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/.cirrus.yml b/.cirrus.yml > index 86ea33926a.

Re: [PATCH v3 4/6] plugin: define QEMU_PLUGIN_API_IMPLEMENTATION first

2020-10-05 Thread Alex Bennée
Yonggang Luo writes: > This is used to distinguish from the qemu and plugin in > header qemu-plugin.h > > Signed-off-by: Yonggang Luo > --- > plugins/api.c | 1 + > plugins/core.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/plugins/api.c b/plugins/api.c > index bbdc5a4eb4..f16

Re: [PATCH v3 5/6] plugin: getting qemu_plugin_get_hwaddr only expose one function prototype

2020-10-05 Thread Alex Bennée
Yonggang Luo writes: > This is used for counting how much function are export to qemu plugin. > > Signed-off-by: Yonggang Luo > --- > plugins/api.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/plugins/api.c b/plugins/api.c > index f16922ca8b..d325084385 100

Re: Emulate Rpi with QEMU fails

2020-10-05 Thread Thomas Schneider
Hello, thanks for your replies. I must admit that I don't fully understand your analysis. However you made some conclusions that are correct. In fact I have found a Github repo where a specific kernel and versatile-pb are provided + instruction

Re: [PATCH v3 17/19] hw/arm: Automatically select the 'virt' machine on KVM

2020-10-05 Thread Paolo Bonzini
On 05/10/20 11:22, Philippe Mathieu-Daudé wrote: > List of arch-indep Kconfig using arch-defined selectors: > > hw/acpi/Kconfig:42:depends on PC > hw/intc/Kconfig:31:depends on ARM_GIC && KVM > hw/intc/Kconfig:36:depends on OPENPIC && KVM > hw/intc/Kconfig:40:depends on POWERNV ||

[RFC PATCH 2/3] tests: Only build socket_scm_helper when a softmmu target is available

2020-10-05 Thread Philippe Mathieu-Daudé
Do not try to build socket_scm_helper if not softmmu target is available. This fixes: $ make check-block Generating qemu-version.h with a meson_exe.py custom command make: *** No rule to make target 'tests/qemu-iotests/socket_scm_helper', needed by 'check-block'. Stop. Signed-off-by: Phil

[RFC PATCH 0/3] qom: Fix missing interface in qemu-storage-daemon

2020-10-05 Thread Philippe Mathieu-Daudé
Attempt to fix the issue reported by Kevin. Introduce a trivial test, but there is currently no framework in place to test qemu-storage-daemon. There might be better fix to this QOM issue, I went for the easiest one I could figure out. Philippe Mathieu-Daudé (3): qom: Always register FW_CFG_DA

[RFC PATCH 1/3] qom: Always register FW_CFG_DATA_GENERATOR_INTERFACE

2020-10-05 Thread Philippe Mathieu-Daudé
While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed by a device only available using system-mode (fw_cfg), it is implemented by a crypto component (tls-cipher-suites) which is always available when crypto is used. Commit 69699f3055 introduced the following error in the qemu-storage-daemon b

Re: [PATCH 0/5] qapi: Restrict machine (and migration) specific commands

2020-10-05 Thread Markus Armbruster
Paolo Bonzini writes: > On 05/10/20 10:01, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Reduce the machine code pulled into qemu-storage-daemon. >> I'm leaving review to Eduardo and Marcel for PATCH 1-4, and to David and >> Juan for PATCH 5. David already ACKed. >> >> Can

[RFC PATCH 3/3] tests: Add a trivial qemu-storage-daemon test

2020-10-05 Thread Philippe Mathieu-Daudé
This test fails on top of commit 69699f3055 ("crypto/tls-cipher-suites: Produce fw_cfg consumable blob") because the TYPE_FW_CFG_DATA_GENERATOR_INTERFACE registered in hw/nvram/fw_cfg.c is not linked into qemu-storage-daemon: $ make check-block Generating qemu-version.h with a meson_exe.py cus

Re: [RFC PATCH 0/3] qom: Fix missing interface in qemu-storage-daemon

2020-10-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201005105442.2093105-1-phi...@redhat.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit th

Re: [PATCH v2 2/2] hw/virtio-pci Added AER capability.

2020-10-05 Thread Andrew Melnichenko
yes > DEFINE_PROP_BIT("aer", VirtIOPCIProxy, flags, > VIRTIO_PCI_FLAG_AER_BIT, *false*), > On Mon, Oct 5, 2020 at 1:08 PM Michael S. Tsirkin wrote: > On Mon, Oct 05, 2020 at 12:01:40PM +0300, and...@daynix.com wrote: > > From: Andrew > > > > Buglink: https://bugzilla.re

Re: scripts/gdb: issues when loading modules after lx-symbols

2020-10-05 Thread Stefano Garzarella
On Mon, Oct 05, 2020 at 11:45:41AM +0200, Jan Kiszka wrote: > On 05.10.20 11:29, Stefano Garzarella wrote: > > On Mon, Oct 05, 2020 at 10:33:30AM +0200, Jan Kiszka wrote: > >> On 05.10.20 10:14, Stefano Garzarella wrote: > >>> On Sun, Oct 04, 2020 at 08:52:37PM +0200, Jan Kiszka wrote: > On 01

[PATCH v3 0/2] hw/virtio-pci: AER capability

2020-10-05 Thread andrew
From: Andrew Melnychenko Now, AER capability for virtio-pci is disabled by default. AER capability is only for PCI with PCIe interface on PCIe bus. During migration - device "realize" should initialize AER if requested by device properties. Also fixed commit message and added proper link to bugzi

[PATCH v3 1/2] hw/virtio-pci Added counter for pcie capabilities offsets.

2020-10-05 Thread andrew
From: Andrew Removed hardcoded offset for ats. Added cap offset counter for future capabilities like AER. Signed-off-by: Andrew Melnychenko --- hw/virtio/virtio-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 5b

Re: [PATCH v5 06/14] hw/block/nvme: Add support for active/inactive namespaces

2020-10-05 Thread Niklas Cassel
On Sun, Oct 04, 2020 at 11:54:13PM +, Dmitry Fomichev wrote: > On Wed, 2020-09-30 at 13:50 +, Niklas Cassel wrote: > > On Mon, Sep 28, 2020 at 11:35:20AM +0900, Dmitry Fomichev wrote: > > > From: Niklas Cassel > > > > > > In NVMe, a namespace is active if it exists and is attached to the

[PATCH v3 2/2] hw/virtio-pci Added AER capability.

2020-10-05 Thread andrew
From: Andrew Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1878465 Added AER capability for virtio-pci devices. Also added property for devices, by default AER is disabled. Signed-off-by: Andrew Melnychenko --- hw/virtio/virtio-pci.c | 16 hw/virtio/virtio-pci.h | 4 ++

Re: [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands

2020-10-05 Thread Daniel P . Berrangé
On Mon, Oct 05, 2020 at 09:26:54AM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > On 10/2/20 11:27 AM, Daniel P. Berrangé wrote: > > > > Do we have a query- command handy to easily learn which snapshot names > > are even available to attempt deletion on? If not, that's worth a > > se

Re: [PATCH v5 10/10] migration: introduce snapshot-{save,load,delete} QMP commands

2020-10-05 Thread Daniel P . Berrangé
On Fri, Oct 02, 2020 at 02:46:07PM -0500, Eric Blake wrote: > On 10/2/20 11:27 AM, Daniel P. Berrangé wrote: > > savevm, loadvm and delvm are some of the few HMP commands that have never > > been converted to use QMP. The reasons for the lack of conversion are > > that they blocked execution of the

Re: [PATCH v5 09/14] hw/block/nvme: Support Zoned Namespace Command Set

2020-10-05 Thread Niklas Cassel
On Sun, Oct 04, 2020 at 11:57:07PM +, Dmitry Fomichev wrote: > On Wed, 2020-09-30 at 14:50 +, Niklas Cassel wrote: > > On Mon, Sep 28, 2020 at 11:35:23AM +0900, Dmitry Fomichev wrote: > > > The emulation code has been changed to advertise NVM Command Set when > > > "zoned" device property i

Re: scripts/gdb: issues when loading modules after lx-symbols

2020-10-05 Thread Jan Kiszka
On 05.10.20 13:05, Stefano Garzarella wrote: > On Mon, Oct 05, 2020 at 11:45:41AM +0200, Jan Kiszka wrote: >> On 05.10.20 11:29, Stefano Garzarella wrote: >>> On Mon, Oct 05, 2020 at 10:33:30AM +0200, Jan Kiszka wrote: On 05.10.20 10:14, Stefano Garzarella wrote: > On Sun, Oct 04, 2020 at

Re: [PULL v3 00/11] capstone + disassembler patch queue

2020-10-05 Thread Peter Maydell
On Sat, 3 Oct 2020 at 10:38, Richard Henderson wrote: > > Version 3 adds the method: to the dependency(), which avoids the > cmake warning, and also matches the bulk of the other dependency() > invocations throughout meson.build. > > I also added the suggested current_source_dir() out of an abunda

Re: [PATCH v2 1/4] keyval: Parse help options

2020-10-05 Thread Markus Armbruster
Markus Armbruster writes: [...] > Making help support opt-in complicates things. Is there a genuine use > for not supporting help? Or is just to keep the users that don't > support help yet (but should) working without change? Mind, I'm not > asking you to make them work, I'm only asking wheth

Re: [RFC PATCH 19/21] contrib/gitdm: Add Yadro to the domain map

2020-10-05 Thread Roman Bolshakov
On Sun, Oct 04, 2020 at 08:04:41PM +0200, Philippe Mathieu-Daudé wrote: > There is a number of contributions from this domain, > add its own entry to the gitdm domain map. > > Cc: Igor Kononenko > Cc: Roman Bolshakov > Signed-off-by: Philippe Mathieu-Daudé > --- > One Reviewed-by/Ack-by from so

Re: [PATCH v7 00/14] Reverse debugging

2020-10-05 Thread Paolo Bonzini
On 03/10/20 19:12, Pavel Dovgalyuk wrote: > GDB remote protocol supports reverse debugging of the targets. > It includes 'reverse step' and 'reverse continue' operations. > The first one finds the previous step of the execution, > and the second one is intended to stop at the last breakpoint that >

Re: [PATCH v5 10/10] migration: introduce snapshot-{save, load, delete} QMP commands

2020-10-05 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Oct 05, 2020 at 09:26:54AM +0200, Markus Armbruster wrote: >> Eric Blake writes: >> >> > On 10/2/20 11:27 AM, Daniel P. Berrangé wrote: >> > >> > Do we have a query- command handy to easily learn which snapshot names >> > are even available to attempt deleti

[PATCH] migration: block-dirty-bitmap: rewrite dirty_bitmap_load_header

2020-10-05 Thread Paolo Bonzini
Alex reported an uninitialized variable warning in dirty_bitmap_load_header, where the compiler cannot understand that the !s->cancelled check must be true for the following one to pass. Even though the issue happened only because of -Og, the function is very convoluted. Just rewrite it to first

[PATCH] ide: clean up ahci_populate_sglist

2020-10-05 Thread Paolo Bonzini
Alex reported an uninitialized variable warning in ahci_populate_sglist. Even though the warning is bogus and happens only because of -Og, the code in the function leaves something to be desired; the condition that triggers the warning is easily shown to be entirely redundant. In particular, the l

Re: scripts/gdb: issues when loading modules after lx-symbols

2020-10-05 Thread Stefano Garzarella
On Mon, Oct 05, 2020 at 01:48:35PM +0200, Jan Kiszka wrote: > On 05.10.20 13:05, Stefano Garzarella wrote: > > On Mon, Oct 05, 2020 at 11:45:41AM +0200, Jan Kiszka wrote: > >> On 05.10.20 11:29, Stefano Garzarella wrote: > >>> On Mon, Oct 05, 2020 at 10:33:30AM +0200, Jan Kiszka wrote: > On 05

Re: [RFC PATCH 3/3] tests: Add a trivial qemu-storage-daemon test

2020-10-05 Thread Paolo Bonzini
On 05/10/20 12:54, Philippe Mathieu-Daudé wrote: > This test fails on top of commit 69699f3055 > ("crypto/tls-cipher-suites: Produce fw_cfg consumable blob") > because the TYPE_FW_CFG_DATA_GENERATOR_INTERFACE registered > in hw/nvram/fw_cfg.c is not linked into qemu-storage-daemon: > > $ make ch

Re: [RFC PATCH 1/3] qom: Always register FW_CFG_DATA_GENERATOR_INTERFACE

2020-10-05 Thread Daniel P . Berrangé
On Mon, Oct 05, 2020 at 12:54:40PM +0200, Philippe Mathieu-Daudé wrote: > While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed > by a device only available using system-mode (fw_cfg), it is > implemented by a crypto component (tls-cipher-suites) which > is always available when crypto is used

Re: [PULL 00/17] Block patches

2020-10-05 Thread Stefan Hajnoczi
On Thu, Oct 01, 2020 at 04:12:12PM +0100, Peter Maydell wrote: > On Thu, 1 Oct 2020 at 16:03, Stefan Hajnoczi wrote: > > > > On Thu, Oct 01, 2020 at 12:23:00PM +0100, Peter Maydell wrote: > > > This produces this error message on ppc64be Linux: > > > > > > make: Entering directory `/home/pm215/qem

Re: [PATCH v10 2/9] copy-on-read: add filter append/drop functions

2020-10-05 Thread Vladimir Sementsov-Ogievskiy
29.09.2020 15:38, Andrey Shinkevich wrote: Provide API for the COR-filter insertion/removal. Also, drop the filter child permissions for an inactive state when the filter node is being removed. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 84

[PATCH] configure: don't enable ASLR for --enable-debug Windows builds

2020-10-05 Thread Mark Cave-Ayland
Unlike other OSs it is not possible for gdb to temporarily disable ASLR when debugging executables on Windows which causes gdb to fail with memory access errors when trying to debug QEMU. Keep ASLR enabled by default on Windows via the --dynamicbase compiler flag except for --enable-debug builds w

Re: [PATCH 2/2] hw/mips: Simplify code using ROUND_UP(INITRD_PAGE_SIZE)

2020-10-05 Thread Richard Henderson
On 9/27/20 11:39 AM, Philippe Mathieu-Daudé wrote: > Instead of using a INITRD_PAGE_MASK definition, use the > simpler INITRD_PAGE_SIZE one which allows us to simplify > the code by using directly the self-explicit ROUND_UP() > macro. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/

Re: [PATCH 1/2] hw/mips: Simplify loading 64-bit ELF kernels

2020-10-05 Thread Richard Henderson
On 9/27/20 11:39 AM, Philippe Mathieu-Daudé wrote: > Since 82790064116 ("Cast ELF datatypes properly to host 64bit types") > we don't need to sign-extend the entry_point address. Remove this > unnecessary code. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/mips/mipssim.c | 6 +- > hw/

Re: [RFC PATCH 08/21] contrib/gitdm: Add Mentor Graphics to the domain map

2020-10-05 Thread Joseph Myers
On Sun, 4 Oct 2020, Philippe Mathieu-Daudé wrote: > There is a number of contributors from this domain, > add its own entry to the gitdm domain map. At some point the main branding will be Siemens; not sure how you want to handle that. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] configure: don't enable ASLR for --enable-debug Windows builds

2020-10-05 Thread Richard Henderson
On 10/5/20 8:34 AM, Mark Cave-Ayland wrote: > Unlike other OSs it is not possible for gdb to temporarily disable ASLR when > debugging executables on Windows which causes gdb to fail with memory access > errors when trying to debug QEMU. > > Keep ASLR enabled by default on Windows via the --dynami

Re: [PATCH v7 00/14] Reverse debugging

2020-10-05 Thread Pavel Dovgalyuk
On 05.10.2020 15:27, Paolo Bonzini wrote: On 03/10/20 19:12, Pavel Dovgalyuk wrote: GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended

  1   2   3   4   >