[PATCH v2 00/11] 9pfs: add tests using local fs driver

2020-10-02 Thread Christian Schoenebeck
The currently existing 9pfs test cases are all solely using the 9pfs 'synth' fileystem driver, which is a very simple and purely simulated (in RAM only) filesystem. There are issues though where the 'synth' fs driver is not sufficient. For example the following two bugs need test cases running the

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-02 Thread Paolo Bonzini
On 02/10/20 14:36, Peter Maydell wrote: > On Fri, 2 Oct 2020 at 13:35, Peter Maydell wrote: >> >> On Fri, 2 Oct 2020 at 13:02, Paolo Bonzini wrote: >>> - the workaround: just leave things as they are and add >>> --disable-libudev to your script. >> >> There is no --disable-udev ! > > ...and ther

[PATCH v2 11/11] tests/9pfs: add local Tmkdir test

2020-10-02 Thread Christian Schoenebeck
This test case uses the 9pfs 'local' driver to create a directory and then checks if the expected directory was actually created (as real directory) on host side. Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 139 +++ 1 file changed, 139

[PATCH v2 08/11] tests/9pfs: introduce local tests

2020-10-02 Thread Christian Schoenebeck
This patch introduces 9pfs test cases using the 9pfs 'local' filesystem driver which reads/writes/creates/deletes real files and directories. In this initial version, there is only one local test which actually only checks if the 9pfs 'local' device was created successfully. Before the 9pfs 'loca

[PATCH v2 07/11] tests/9pfs: change qtest name prefix to synth

2020-10-02 Thread Christian Schoenebeck
All existing 9pfs test cases are using the 'synth' fs driver so far, which means they are not accessing real files, but a purely simulated (in RAM only) file system. Let's make this clear by changing the prefix of the individual qtest case names from 'fs/' to 'synth/'. That way they'll be easily d

Re: [PATCH v6 0/4] Fixes curses on msys2/mingw

2020-10-02 Thread Gerd Hoffmann
On Thu, Oct 01, 2020 at 07:39:33PM +0200, Paolo Bonzini wrote: > On 01/10/20 19:32, Yonggang Luo wrote: > > And also convert related configure script to meson. > > V5-V6 > > Dropping configure: Fixes ncursesw detection under msys2/mingw by convert > > the= > > m to meson first. > > That need the m

[PATCH v2 04/11] tests/qtest/qos-test: dump qos graph if verbose

2020-10-02 Thread Christian Schoenebeck
If qtests were run in verbose mode (i.e. if --verbose CL argument was provided) then dump the generated qos graph (all nodes and edges, along with their current individual availability status) to stdout. See API doc comment on function qos_dump_graph() for details. Signed-off-by: Christian Schoen

[PATCH v2 06/11] tests/qtest/qos-test: dump QEMU command if verbose

2020-10-02 Thread Christian Schoenebeck
If qtests are run in verbose mode (i.e. if --verbose CL argument was provided) then print the assembled qemu command line for each test. Instead of using g_test_message() rather use printf() in combination with g_test_verbose(), to avoid g_test_message() cluttering the output. Signed-off-by: Chri

[PATCH v2 02/11] libqos/qgraph: add qos_node_create_driver_named()

2020-10-02 Thread Christian Schoenebeck
So far the qos subsystem of the qtest framework had the limitation that only one instance of the same official QEMU (QMP) driver name could be created for qtests. That's because a) the created qos node names must always be unique, b) the node name must match the official QEMU driver name being inst

[PATCH v2 03/11] libqos/qgraph: add qos_dump_graph()

2020-10-02 Thread Christian Schoenebeck
This new function is purely for debugging purposes. It prints the current qos graph to stdout and allows to identify problems in the created qos graph e.g. when writing new qos tests. Coloured output is used to mark available nodes in green colour, whereas unavailable nodes are marked in red colou

[PATCH v2 09/11] tests/9pfs: wipe local 9pfs test directory

2020-10-02 Thread Christian Schoenebeck
Before running the first 9pfs test case, make sure the test directory for running the 9pfs 'local' tests on is entirely empty. For that reason simply delete the test directory (if any) before (re)creating it on test suite startup. Signed-off-by: Christian Schoenebeck --- tests/qtest/libqos/virti

[PATCH v2 01/11] libqos/qgraph: add qemu_name to QOSGraphNode

2020-10-02 Thread Christian Schoenebeck
Add new member variable 'qemu_name' to struct QOSGraphNode. This new member may be optionally set in case a different name for the node (which must always be a unique name) vs. its actually associated QEMU (QMP) device name is required. Signed-off-by: Christian Schoenebeck --- tests/qtest/libqo

Re: [PATCH v2 11/11] tests/9pfs: add local Tmkdir test

2020-10-02 Thread Daniel P . Berrangé
On Fri, Oct 02, 2020 at 01:51:54PM +0200, Christian Schoenebeck wrote: > This test case uses the 9pfs 'local' driver to create a directory > and then checks if the expected directory was actually created > (as real directory) on host side. > > Signed-off-by: Christian Schoenebeck > --- > tests/q

[PATCH v2 05/11] tests/qtest/qos-test: dump environment variables if verbose

2020-10-02 Thread Christian Schoenebeck
If qtests are run in verbose mode (i.e. if --verbose CL argument was provided) then print all environment variables to stdout before running the individual tests. Instead of using g_test_message() rather use printf() in combination with g_test_verbose(), to avoid g_test_message() cluttering the ou

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-02 Thread Peter Maydell
On Fri, 2 Oct 2020 at 13:44, Paolo Bonzini wrote: > > On 02/10/20 14:36, Peter Maydell wrote: > > On Fri, 2 Oct 2020 at 13:35, Peter Maydell wrote: > >> > >> On Fri, 2 Oct 2020 at 13:02, Paolo Bonzini wrote: > >>> - the workaround: just leave things as they are and add > >>> --disable-libudev to

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-02 Thread Paolo Bonzini
On 02/10/20 14:35, Peter Maydell wrote: > > It would be better to do the "see if a static library is present" > test. This isn't too hard to do in configure (compare that > six line fix to the detection of libgio). Hopefully it is > not too hard to do in meson ? Yes, something like: if enable_st

Re: [PATCH v3 4/5] spapr_numa: consider user input when defining associativity

2020-10-02 Thread Daniel Henrique Barboza
On 10/1/20 11:24 PM, David Gibson wrote: On Tue, Sep 29, 2020 at 10:38:16AM -0300, Daniel Henrique Barboza wrote: This patch puts all the pieces together to finally allow user input when defining the NUMA topology of the spapr guest. For each NUMA node A, starting at node id 0, the new spapr

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-02 Thread Peter Maydell
On Fri, 2 Oct 2020 at 14:05, Paolo Bonzini wrote: > > On 02/10/20 14:35, Peter Maydell wrote: > > > > It would be better to do the "see if a static library is present" > > test. This isn't too hard to do in configure (compare that > > six line fix to the detection of libgio). Hopefully it is > > n

Re: [PATCH] virtiofsd: Call qemu_init_exec_dir

2020-10-02 Thread Alex Bennée
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Since fcb4f59c879 qemu_get_local_state_pathname relies on the > init_exec_dir, and virtiofsd asserts because we never set it. > Set it. > > Reported-by: Alex Bennée > Signed-off-by: Dr. David Alan Gilbert Tested-by: A

Re: [PATCH] configure: actually disable 'git_update' mode with --disable-git-update

2020-10-02 Thread Daniel P . Berrangé
On Wed, Sep 30, 2020 at 09:28:54PM -0400, Dan Streetman wrote: > On Tue, Sep 22, 2020 at 12:34 PM Daniel P. Berrangé > wrote: > > > > On Wed, Jul 29, 2020 at 03:58:29PM -0400, Dan Streetman wrote: > > > The --disable-git-update configure param sets git_update=no, but > > > some later checks only

[PATCH v2 10/11] tests/9pfs: add virtio_9p_test_path()

2020-10-02 Thread Christian Schoenebeck
This new public function virtio_9p_test_path() allows 9pfs 'local' tests to translate a path from guest scope to host scope. For instance by passing an empty string it would return the root path on host of the exported 9pfs tree. Signed-off-by: Christian Schoenebeck --- tests/qtest/libqos/virtio

Call for KVM Forum panel discussion topics

2020-10-02 Thread Stefan Hajnoczi
Hi, You can post questions for the KVM Forum panel discussion until October 13th: https://etherpad.opendev.org/p/KVMForum_2020_Panel The panel is a yearly session at KVM Forum for discussing technical and non-technical topics related to KVM, QEMU, and open source virtualization in general. The pan

Re: [PULL 00/14] testing updates (python, plugins)

2020-10-02 Thread Peter Maydell
On Fri, 2 Oct 2020 at 12:36, Alex Bennée wrote: > > The following changes since commit b5ce42f5d138d7546f9faa2decbd6ee8702243a3: > > Merge remote-tracking branch 'remotes/jsnow-gitlab/tags/ide-pull-request' > into staging (2020-10-01 19:55:10 +0100) > > are available in the Git repository at: >

Re: [PATCH v4 1/2] Introduce (x86) CPU model deprecation API

2020-10-02 Thread Robert Hoo
On Wed, 2020-09-30 at 17:56 -0400, Eduardo Habkost wrote: > On Tue, Sep 22, 2020 at 03:14:14PM +0800, Robert Hoo wrote: > > Complement versioned CPU model framework with the ability of > > marking some > > versions deprecated. When that CPU model is chosen, get some > > warning. The > > warning mes

[PATCH 0/5] qapi: Restrict machine (and migration) specific commands

2020-10-02 Thread Philippe Mathieu-Daudé
Reduce the machine code pulled into qemu-storage-daemon. Philippe Mathieu-Daudé (5): qapi: Restrict 'inject-nmi' command to machine code qapi: Restrict 'system wakeup/reset/powerdown' commands to machine.json qapi: Restrict '(p)memsave' command to machine code qapi: Restrict 'query-kvm

[PATCH 2/5] qapi: Restrict 'system wakeup/reset/powerdown' commands to machine.json

2020-10-02 Thread Philippe Mathieu-Daudé
Restricting system_wakeup/system_reset/system_powerdown to machine.json pulls slightly less QAPI-generated code into user-mode and tools. Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine.json | 57 +++ qapi/misc.json| 57 -

[PATCH 1/5] qapi: Restrict 'inject-nmi' command to machine code

2020-10-02 Thread Philippe Mathieu-Daudé
Restricting 'inject-nmi' to machine.json pulls slightly less QAPI-generated code into user-mode and tools. Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine.json | 20 qapi/misc.json| 20 softmmu/cpus.c| 1 + 3 files changed, 21 insertions(

[PATCH 4/5] qapi: Restrict 'query-kvm' command to machine code

2020-10-02 Thread Philippe Mathieu-Daudé
Restricting query-kvm to machine.json pulls slightly less QAPI-generated code into user-mode and tools. Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine.json | 30 ++ qapi/misc.json| 30 -- 2 files changed, 30 insertions(+), 30 de

[PATCH 3/5] qapi: Restrict '(p)memsave' command to machine code

2020-10-02 Thread Philippe Mathieu-Daudé
Restricting memsave/pmemsave to machine.json pulls slightly less QAPI-generated code into user-mode and tools. Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine.json | 61 +++ qapi/misc.json| 61 ---

Re: [PATCH v2 11/11] tests/9pfs: add local Tmkdir test

2020-10-02 Thread Christian Schoenebeck
On Freitag, 2. Oktober 2020 14:56:14 CEST Daniel P. Berrangé wrote: > On Fri, Oct 02, 2020 at 01:51:54PM +0200, Christian Schoenebeck wrote: > > This test case uses the 9pfs 'local' driver to create a directory > > and then checks if the expected directory was actually created > > (as real director

[PATCH 5/5] qapi: Restrict Xen migration commands to migration.json

2020-10-02 Thread Philippe Mathieu-Daudé
Restricting xen-set-global-dirty-log and xen-load-devices-state commands migration.json pulls slightly less QAPI-generated code into user-mode and tools. Signed-off-by: Philippe Mathieu-Daudé --- qapi/migration.json| 41 + qapi/misc.json | 41 -

Re: [PATCH v2 11/11] tests/9pfs: add local Tmkdir test

2020-10-02 Thread Daniel P . Berrangé
On Fri, Oct 02, 2020 at 03:41:07PM +0200, Christian Schoenebeck wrote: > On Freitag, 2. Oktober 2020 14:56:14 CEST Daniel P. Berrangé wrote: > > On Fri, Oct 02, 2020 at 01:51:54PM +0200, Christian Schoenebeck wrote: > > > This test case uses the 9pfs 'local' driver to create a directory > > > and t

Re: [PATCH 1/2] block/export: add vhost-user-blk multi-queue support

2020-10-02 Thread Stefan Hajnoczi
On Fri, Oct 02, 2020 at 07:32:39AM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > Allow the number of queues to be configured using --export > > vhost-user-blk,num-queues=N. This setting should match the QEMU --device > > vhost-user-blk-pci,num-queues=N setting but QEMU vhost-use

Re: [PATCH v10 3/4] tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller

2020-10-02 Thread Philippe Mathieu-Daudé
Hi Vikram, On 9/15/20 12:08 AM, Vikram Garhwal wrote: > The QTests perform five tests on the Xilinx ZynqMP CAN controller: > Tests the CAN controller in loopback, sleep and snoop mode. > Tests filtering of incoming CAN messages. > > Reviewed-by: Francisco Iglesias > Signed-off-by: Vikram

Re: [PATCH] hw: wdt: implement sbsa watchdog

2020-10-02 Thread Maxim Uvarov
On Thu, 1 Oct 2020 at 23:36, Peter Maydell wrote: > > On Thu, 1 Oct 2020 at 20:37, Maxim Uvarov wrote: > > > > Initial virtual driver matching linux kernel sbsa_gwdt > > driver. Driver implements basic functionality and makes > > watchdog works on virtual machine and allows to reboot > > secure O

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-02 Thread Paolo Bonzini
On 02/10/20 15:09, Peter Maydell wrote: > This duplicates the information that the thing that depends > on libudev is mpath. Can we put this in a wrapper around > dependency() so that we could just say something like > libudev = compile_checked_dependency('libudev', >requi

Re: [PATCH v2 11/11] tests/9pfs: add local Tmkdir test

2020-10-02 Thread Christian Schoenebeck
On Freitag, 2. Oktober 2020 15:44:40 CEST Daniel P. Berrangé wrote: > On Fri, Oct 02, 2020 at 03:41:07PM +0200, Christian Schoenebeck wrote: > > On Freitag, 2. Oktober 2020 14:56:14 CEST Daniel P. Berrangé wrote: > > > On Fri, Oct 02, 2020 at 01:51:54PM +0200, Christian Schoenebeck wrote: > > > > T

Re: [PATCH] hw: wdt: implement sbsa watchdog

2020-10-02 Thread Peter Maydell
On Fri, 2 Oct 2020 at 15:06, Maxim Uvarov wrote: > > On Thu, 1 Oct 2020 at 23:36, Peter Maydell wrote: > > Hi; what's the relationship between this SBSA watchdog > > device model and the one that Shashi posted recently? > > https://patchew.org/QEMU/20200929180410.33058-1-shashi.mall...@linaro.org

Re: [PATCH v10 1/4] hw/net/can: Introduce Xilinx ZynqMP CAN controller

2020-10-02 Thread Philippe Mathieu-Daudé
Hi Vikram, Sorry for reviewing that late (v10). On 9/15/20 12:08 AM, Vikram Garhwal wrote: > The Xilinx ZynqMP CAN controller is developed based on SocketCAN, QEMU CAN bus > implementation. Bus connection and socketCAN connection for each CAN module > can be set through command lines. > > Exampl

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-02 Thread Peter Maydell
On Fri, 2 Oct 2020 at 15:08, Paolo Bonzini wrote: > > On 02/10/20 15:09, Peter Maydell wrote: > > This duplicates the information that the thing that depends > > on libudev is mpath. Can we put this in a wrapper around > > dependency() so that we could just say something like > > libudev = compi

Re: [PATCH v3 1/2] arm64: kvm: Save/restore MTE registers

2020-10-02 Thread Andrew Jones
On Fri, Sep 25, 2020 at 10:36:06AM +0100, Steven Price wrote: > Define the new system registers that MTE introduces and context switch > them. The MTE feature is still hidden from the ID register as it isn't > supported in a VM yet. > > Signed-off-by: Steven Price > --- > arch/arm64/include/asm/

Re: [PATCH v2 11/11] tests/9pfs: add local Tmkdir test

2020-10-02 Thread Daniel P . Berrangé
On Fri, Oct 02, 2020 at 04:09:53PM +0200, Christian Schoenebeck wrote: > On Freitag, 2. Oktober 2020 15:44:40 CEST Daniel P. Berrangé wrote: > > On Fri, Oct 02, 2020 at 03:41:07PM +0200, Christian Schoenebeck wrote: > > > On Freitag, 2. Oktober 2020 14:56:14 CEST Daniel P. Berrangé wrote: > > > > O

Re: [PATCH] configure: actually disable 'git_update' mode with --disable-git-update

2020-10-02 Thread Peter Maydell
On Fri, 2 Oct 2020 at 14:13, Daniel P. Berrangé wrote: > Assuming you're just using git for conveniently applying local > downstream patches, you don't need the git repo to exist once > getting to the build stage. IOW just delete the .git dir after > applying patches before running a build. ...th

Re: [PATCH v2 08/11] tests/9pfs: introduce local tests

2020-10-02 Thread Christian Schoenebeck
On Freitag, 2. Oktober 2020 13:51:54 CEST Christian Schoenebeck wrote: > This patch introduces 9pfs test cases using the 9pfs 'local' > filesystem driver which reads/writes/creates/deletes real files > and directories. > > In this initial version, there is only one local test which actually > only

Re: [PATCH v2 11/11] tests/9pfs: add local Tmkdir test

2020-10-02 Thread Christian Schoenebeck
On Freitag, 2. Oktober 2020 16:23:31 CEST Daniel P. Berrangé wrote: > No need to realloate a new array - just shuffle down the elements in > the array you get back from g_strsplit to discard the empty ones. Sure > the array will end up with a series of NULLs at the end but that is > harmless. > >

Re: [PATCH v2] ppc/pnv: Increase max firmware size

2020-10-02 Thread David Gibson
On Fri, Oct 02, 2020 at 11:14:40AM +0200, Cédric Le Goater wrote: > Builds enabling GCOV can be bigger than 4MB and the limit on FSP > systems is 16MB. > > Signed-off-by: Cédric Le Goater Applied to ppc-for-5.2, thanks. > --- > hw/ppc/pnv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH v3 2/2] arm64: kvm: Introduce MTE VCPU feature

2020-10-02 Thread Andrew Jones
On Fri, Sep 25, 2020 at 10:36:07AM +0100, Steven Price wrote: > Add a new VM feature 'KVM_ARM_CAP_MTE' which enables memory tagging > for a VM. This exposes the feature to the guest and automatically tags > memory pages touched by the VM as PG_mte_tagged (and clears the tags > storage) to ensure th

Re: [PATCH v3 0/2] MTE support for KVM guest

2020-10-02 Thread Andrew Jones
On Fri, Sep 25, 2020 at 10:36:05AM +0100, Steven Price wrote: > Version 3 of adding MTE support for KVM guests. See the previous (v2) > posting for background: > > https://lore.kernel.org/r/20200904160018.29481-1-steven.price%40arm.com > > These patches add support to KVM to enable MTE within a

Re: [PATCH v2 11/11] tests/9pfs: add local Tmkdir test

2020-10-02 Thread Greg Kurz
On Fri, 2 Oct 2020 13:56:14 +0100 Daniel P. Berrangé wrote: > On Fri, Oct 02, 2020 at 01:51:54PM +0200, Christian Schoenebeck wrote: > > This test case uses the 9pfs 'local' driver to create a directory > > and then checks if the expected directory was actually created > > (as real directory) on

[PATCH] gitlab-ci.yml: Only run one test-case per fuzzer

2020-10-02 Thread Alexander Bulekov
With 1000 runs, there is a non-negligible chance that the fuzzer can trigger a crash. With this CI job, we care about catching build/runtime issues in the core fuzzing code. Actual device fuzzing takes place on oss-fuzz. For these purposes, only running one input should be sufficient. Signed-off-b

Re: [PATCH 04/14] hw/arm/raspi: add a skeleton implementation of the cprman

2020-10-02 Thread Philippe Mathieu-Daudé
On 9/28/20 10:45 AM, Luc Michel wrote: > On 23:05 Sat 26 Sep , Philippe Mathieu-Daudé wrote: >> On 9/25/20 12:17 PM, Luc Michel wrote: >>> The BCM2835 cprman is the clock manager of the SoC. It is composed of a >> >> Can we use CPRMAN in caps? >> >>> main oscillator, and several sub-components

Re: [PATCH v2 08/11] tests/9pfs: introduce local tests

2020-10-02 Thread Daniel P . Berrangé
On Fri, Oct 02, 2020 at 04:26:48PM +0200, Christian Schoenebeck wrote: > On Freitag, 2. Oktober 2020 13:51:54 CEST Christian Schoenebeck wrote: > > This patch introduces 9pfs test cases using the 9pfs 'local' > > filesystem driver which reads/writes/creates/deletes real files > > and directories. >

Re: [PATCH 09/14] hw/misc/bcm2835_cprman: add a clock mux skeleton implementation

2020-10-02 Thread Philippe Mathieu-Daudé
On 9/25/20 12:17 PM, Luc Michel wrote: > The clock multiplexers are the last clock stage in the cprman. Each mux > outputs one clock signal that goes out of the cprman to the SoC > peripherals. > > Each mux has at most 10 sources. The sources 0 to 3 are common to all > muxes. They are: >0. gro

[PULL 08/37] block/export: Add BlockExport infrastructure and block-export-add

2020-10-02 Thread Kevin Wolf
We want to have a common set of commands for all types of block exports. Currently, this is only NBD, but we're going to add more types. This patch adds the basic BlockExport and BlockExportDriver structs and a QMP command block-export-add that creates a new export based on the given BlockExportOp

Re: [PATCH] gitlab-ci.yml: Only run one test-case per fuzzer

2020-10-02 Thread Philippe Mathieu-Daudé
On 10/2/20 4:35 PM, Alexander Bulekov wrote: > With 1000 runs, there is a non-negligible chance that the fuzzer can > trigger a crash. With this CI job, we care about catching build/runtime > issues in the core fuzzing code. Actual device fuzzing takes place on > oss-fuzz. For these purposes, only

[PULL 03/37] docs: Document the throttle block filter

2020-10-02 Thread Kevin Wolf
From: Alberto Garcia This filter was added back in 2017 for QEMU 2.11 but it was never properly documented, so let's explain how it works and add a couple of examples. Signed-off-by: Alberto Garcia Message-Id: <20200921173016.27935-1-be...@igalia.com> Signed-off-by: Kevin Wolf --- docs/thrott

[PULL 04/37] qemu-io-cmds: Simplify help_oneline

2020-10-02 Thread Kevin Wolf
From: "Dr. David Alan Gilbert" help_oneline is declared and starts as: static void help_oneline(const char *cmd, const cmdinfo_t *ct) { if (cmd) { printf("%s ", cmd); } else { printf("%s ", ct->name); if (ct->altname) { printf("(or %s)

[PULL 01/37] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition

2020-10-02 Thread Kevin Wolf
From: Philippe Mathieu-Daudé Use self-explicit NANOSECONDS_PER_SECOND definition instead of magic value. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200921110145.520944-1-phi...@redhat.com> Reviewed-by: Alberto Garcia Signed-off-by: Kevin Wolf --- block/sheepdog.c | 2 +- 1 file cha

[PULL 11/37] block/export: Remove magic from block-export-add

2020-10-02 Thread Kevin Wolf
nbd-server-add tries to be convenient and adds two questionable features that we don't want to share in block-export-add, even for NBD exports: 1. When requesting a writable export of a read-only device, the export is silently downgraded to read-only. This should be an error in the context o

[PULL 02/37] tests/check-block: Do not run the iotests with old versions of bash

2020-10-02 Thread Kevin Wolf
From: Thomas Huth macOS is shipped with a very old version of the bash (3.2), which is currently not suitable for running the iotests anymore (e.g. it is missing support for "readarray" which is used in the file tests/qemu-iotests/common.filter). Add a check to skip the iotests in this case - if

[PULL 06/37] qapi: Create block-export module

2020-10-02 Thread Kevin Wolf
Move all block export related types and commands from block-core to the new QAPI module block-export. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Eric Blake Message-Id: <20200924152717.287415-3-kw...@redhat.com> Acked-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qapi/b

[PULL 00/37] Block layer patches

2020-10-02 Thread Kevin Wolf
The following changes since commit 0d2a4545bf7e763984d3ee3e802617544cb7fc7a: Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-and-python-021020-1' into staging (2020-10-02 13:39:20 +0100) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstre

[PULL 09/37] qemu-storage-daemon: Use qmp_block_export_add()

2020-10-02 Thread Kevin Wolf
No reason to duplicate the functionality locally, we can now just reuse the QMP command block-export-add for --export. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Eric Blake Message-Id: <20200924152717.287415-6-kw...@redhat.com> Acked-by: Stefan Hajnoczi Signed-off-by: Kevin

[PULL 10/37] qemu-nbd: Use raw block driver for --offset

2020-10-02 Thread Kevin Wolf
Instead of implementing qemu-nbd --offset in the NBD code, just put a raw block node with the requested offset on top of the user image and rely on that doing the job. This does not only simplify the nbd_export_new() interface and bring it closer to the set of options that the nbd-server-add QMP c

[PULL 27/37] block/export: Create BlockBackend in blk_exp_add()

2020-10-02 Thread Kevin Wolf
Every export type will need a BlockBackend, so creating it centrally in blk_exp_add() instead of the .create driver callback avoids duplication. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Message-Id: <20200924152717.287415-24-kw...@redhat.com> Acked-by: Stefan Hajnoczi Signed-off-by: Kevi

[PULL 07/37] qapi: Rename BlockExport to BlockExportOptions

2020-10-02 Thread Kevin Wolf
The name BlockExport will be used for the struct containing the runtime state of block exports, so change the name of export creation options. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Eric Blake Message-Id: <20200924152717.287415-4-kw...@redhat.com> Acked-by: Stefan Hajnocz

[PULL 05/37] nbd: Remove unused nbd_export_get_blockdev()

2020-10-02 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Eric Blake Message-Id: <20200924152717.287415-2-kw...@redhat.com> Acked-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- include/block/nbd.h | 2 -- nbd/server.c| 5 - 2 files changed, 7 deletions(-) diff --git a/incl

[PULL 31/37] nbd: Deprecate nbd-server-add/remove

2020-10-02 Thread Kevin Wolf
These QMP commands are replaced by block-export-add/del. Signed-off-by: Kevin Wolf Message-Id: <20200924152717.287415-28-kw...@redhat.com> Acked-by: Stefan Hajnoczi Reviewed-by: Max Reitz Signed-off-by: Kevin Wolf --- qapi/block-export.json | 11 +-- docs/system/deprecated.rst |

[PULL 12/37] nbd: Add max-connections to nbd-server-start

2020-10-02 Thread Kevin Wolf
This is a QMP equivalent of qemu-nbd's --shared option, limiting the maximum number of clients that can attach at the same time. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Eric Blake Message-Id: <20200924152717.287415-9-kw...@redhat.com> Acked-by: Stefan Hajnoczi Signed-off-

[PULL 19/37] block/export: Add node-name to BlockExportOptions

2020-10-02 Thread Kevin Wolf
Every block export needs a block node to export, so add a 'node-name' option to BlockExportOptions and remove the replaced option 'device' from BlockExportOptionsNbd. To maintain compatibility in nbd-server-add, BlockExportOptionsNbd needs to be wrapped by a new type NbdServerAddOptions that adds

[PULL 32/37] iotests: Factor out qemu_tool_pipe_and_status()

2020-10-02 Thread Kevin Wolf
We have three almost identical functions that call an external process and return its output and return code. Refactor them into small wrappers around a common function. Signed-off-by: Kevin Wolf Message-Id: <20200924152717.287415-29-kw...@redhat.com> Acked-by: Stefan Hajnoczi Reviewed-by: Max R

[PULL 13/37] nbd: Add writethrough to block-export-add

2020-10-02 Thread Kevin Wolf
qemu-nbd allows use of writethrough cache modes, which mean that write requests made through NBD will cause a flush before they complete. Expose the same functionality in block-export-add. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Message-Id: <20200924152717.287415-10-kw...@redhat.com> Ac

[PULL 16/37] nbd/server: Simplify export shutdown

2020-10-02 Thread Kevin Wolf
Closing export is somewhat convoluted because nbd_export_close() and nbd_export_put() call each other and the ways they actually end up being nested is not necessarily obvious. However, it is not really necessary to call nbd_export_close() from nbd_export_put() when putting the last reference beca

[PULL 17/37] block/export: Move refcount from NBDExport to BlockExport

2020-10-02 Thread Kevin Wolf
Having a refcount makes sense for all types of block exports. It is also a prerequisite for keeping a list of all exports at the BlockExport level. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Message-Id: <20200924152717.287415-14-kw...@redhat.com> Acked-by: Stefan Hajnoczi Signed-off-by: K

[PULL 18/37] block/export: Move AioContext from NBDExport to BlockExport

2020-10-02 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Message-Id: <20200924152717.287415-15-kw...@redhat.com> Acked-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- include/block/export.h | 3 +++ block/export/export.c | 2 ++ nbd/server.c | 26 +- 3 files chan

[Bug 1898215] [NEW] [git][archlinux]Build process is busted in spice-display.c

2020-10-02 Thread Frederic Bezies
Public bug reported: Linux distribution: Archlinux. Crash log added is based on a build from scratch. Gcc version: 10.2.0 Configure options used: configure \ --prefix=/usr \ --sysconfdir=/etc \ --localstatedir=/var \ --libexecdir=/usr/lib/qemu \ --extra-ldflags="$LDFLAGS" \

[PULL 15/37] qemu-nbd: Use blk_exp_add() to create the export

2020-10-02 Thread Kevin Wolf
With this change, NBD exports are now only created through the BlockExport interface. This allows us finally to move things from the NBD layer to the BlockExport layer if they make sense for other export types, too. blk_exp_add() returns only a weak reference, so the explicit nbd_export_put() goes

[PULL 20/37] block/export: Allocate BlockExport in blk_exp_add()

2020-10-02 Thread Kevin Wolf
Instead of letting the driver allocate and return the BlockExport object, allocate it already in blk_exp_add() and pass it. This allows us to initialise the generic part before calling into the driver so that the driver can just use these values instead of having to parse the options a second time.

[PULL 14/37] nbd: Remove NBDExport.close callback

2020-10-02 Thread Kevin Wolf
The export close callback is unused by the built-in NBD server. qemu-nbd uses it only during shutdown to wait for the unrefed export to actually go away. It can just use nbd_export_close_all() instead and do without the callback. This removes the close callback from nbd_export_new() and makes both

Re: [PATCH 10/14] hw/misc/bcm2835_cprman: implement clock mux behaviour

2020-10-02 Thread Philippe Mathieu-Daudé
On 9/26/20 11:40 PM, Philippe Mathieu-Daudé wrote: > On 9/25/20 12:17 PM, Luc Michel wrote: >> A clock mux can be configured to select one of its 10 sources through >> the cm_ctl register. It also embeds yet another clock divider, composed >> of an integer part and a fractionnal part. The number of

[PULL 24/37] block/export: Add block-export-del

2020-10-02 Thread Kevin Wolf
Implement a new QMP command block-export-del and make nbd-server-remove a wrapper around it. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Message-Id: <20200924152717.287415-21-kw...@redhat.com> Acked-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qapi/block-export.json | 32 +++

[PULL 21/37] block/export: Add blk_exp_close_all(_type)

2020-10-02 Thread Kevin Wolf
This adds a function to shut down all block exports, and another one to shut down the block exports of a single type. The latter is used for now when stopping the NBD server. As soon as we implement support for multiple NBD servers, we'll need a per-server list of exports and it will be replaced by

[PULL 25/37] block/export: Add BLOCK_EXPORT_DELETED event

2020-10-02 Thread Kevin Wolf
Clients may want to know when an export has finally disappeard (block-export-del returns earlier than that in the general case), so add a QAPI event for it. Signed-off-by: Kevin Wolf Message-Id: <20200924152717.287415-22-kw...@redhat.com> Acked-by: Stefan Hajnoczi Reviewed-by: Max Reitz Signed-

[PATCH V2 3/3] amd-iommu: Fix amdvi_mmio_trace() to differentiate MMIO R/W

2020-10-02 Thread Wei Huang
amd-iommu MMIO trace function does not differentiate MMIO writes from reads. Let us extend it to support both types. Co-developed-by: Wei Huang Signed-off-by: Suravee Suthikulpanit --- hw/i386/amd_iommu.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a

[PULL 22/37] block/export: Add 'id' option to block-export-add

2020-10-02 Thread Kevin Wolf
We'll need an id to identify block exports in monitor commands. This adds one. Note that this is different from the 'name' option in the NBD server, which is the externally visible export name. While block export ids need to be unique in the whole process, export names must be unique only for the

[PULL 23/37] block/export: Move strong user reference to block_exports

2020-10-02 Thread Kevin Wolf
The reference owned by the user/monitor that is created when adding the export and dropped when removing it was tied to the 'exports' list in nbd/server.c. Every block export will have a user reference, so move it to the block export level and tie it to the 'block_exports' list in block/export/expo

[PULL 36/37] qemu-storage-daemon: Fix help line for --export

2020-10-02 Thread Kevin Wolf
Commit 5f479a8d renamed the 'device' option of --export into 'node-name', but forgot to update the help in qemu-storage-daemon. Fixes: 5f479a8dc086bfa42c9f94e9ab69962f256e207f Signed-off-by: Kevin Wolf Message-Id: <20200930133909.58820-1-kw...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: K

Re: [PATCH] configure: actually disable 'git_update' mode with --disable-git-update

2020-10-02 Thread Rafael David Tinoco
Assuming you're just using git for conveniently applying local downstream patches, you don't need the git repo to exist once getting to the build stage. IOW just delete the .git dir after applying patches before running a build. ...then what do you do if the build fails and you want to ed

[PULL 26/37] block/export: Move blk to BlockExport

2020-10-02 Thread Kevin Wolf
Every block export has a BlockBackend representing the disk that is exported. It should live in BlockExport therefore. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Message-Id: <20200924152717.287415-23-kw...@redhat.com> Acked-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- include/block

Re: [PATCH 11/14] hw/misc/bcm2835_cprman: add the DSI0HSCK multiplexer

2020-10-02 Thread Philippe Mathieu-Daudé
On 9/25/20 12:17 PM, Luc Michel wrote: > This simple mux sits between the PLL channels and the DSI0E and DSI0P > clock muxes. This mux selects between PLLA-DSI0 and PLLD-DSI0 channel > and outputs the selected signal to source number 4 of DSI0E/P clock > muxes. It is controlled by the cm_dsi0hsck r

[PULL 28/37] block/export: Add query-block-exports

2020-10-02 Thread Kevin Wolf
This adds a simple QMP command to query the list of block exports. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Message-Id: <20200924152717.287415-25-kw...@redhat.com> Acked-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qapi/block-export.json | 32 blo

[PULL 30/37] nbd: Merge nbd_export_new() and nbd_export_create()

2020-10-02 Thread Kevin Wolf
There is no real reason any more why nbd_export_new() and nbd_export_create() should be separate functions. The latter only performs a few checks before it calls the former. What makes the current state stand out is that it's the only function in BlockExportDriver that is not a static function ins

[PATCH V2 0/3] Passthru device support under emulated amd-iommu

2020-10-02 Thread Wei Huang
This patchset adds support for passthru devices to run inside VMs under the management of an emulated amd-iommu device (vIOMMU). This feature has a variety of benefits, including enhanced I/O security and user-mode driver support, for guest VMs. This patchset has been tested with various 1G and 10

[Bug 1898215] Re: [git][archlinux]Build process is busted in spice-display.c

2020-10-02 Thread Frederic Bezies
Full build log with make V=1. ** Attachment added: "qemu-v=1.log" https://bugs.launchpad.net/qemu/+bug/1898215/+attachment/5416684/+files/qemu-v%3D1.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/b

Re: [PATCH v2 11/11] tests/9pfs: add local Tmkdir test

2020-10-02 Thread Christian Schoenebeck
On Freitag, 2. Oktober 2020 16:32:55 CEST Greg Kurz wrote: > On Fri, 2 Oct 2020 13:56:14 +0100 > > Daniel P. Berrangé wrote: > > On Fri, Oct 02, 2020 at 01:51:54PM +0200, Christian Schoenebeck wrote: > > > This test case uses the 9pfs 'local' driver to create a directory > > > and then checks if

[PULL 37/37] qcow2: Use L1E_SIZE in qcow2_write_l1_entry()

2020-10-02 Thread Kevin Wolf
From: Alberto Garcia We overlooked these in 02b1ecfa100e7ecc2306560cd27a4a2622bfeb04 Signed-off-by: Alberto Garcia Message-Id: <20200928162333.14998-1-be...@igalia.com> Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[PULL 29/37] block/export: Move writable to BlockExportOptions

2020-10-02 Thread Kevin Wolf
The 'writable' option is a basic option that will probably be applicable to most if not all export types that we will implement. Move it from NBD to the generic BlockExport layer. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Message-Id: <20200924152717.287415-26-kw...@redhat.com> Acked-by: S

[PULL 35/37] iotests: Test block-export-* QMP interface

2020-10-02 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Message-Id: <20200924152717.287415-32-kw...@redhat.com> Acked-by: Stefan Hajnoczi Reviewed-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qemu-iotests/307 | 132 + tests/qemu-iotests/307.out | 124

[Bug 1898215] Re: [git][archlinux]Build process is busted in spice-display.c

2020-10-02 Thread elmarco
This is a bug in the spice-server meson build system: https://gitlab.freedesktop.org/spice/spice/-/commit/37fd91a51f52cdc1b55d3ce41e6ce6db348b986c Most likely they will end up bumping the version to 0.15, so we may want to update the condition in qemu. -- You received this bug notification becau

[PULL 33/37] iotests: Introduce qemu_nbd_list_log()

2020-10-02 Thread Kevin Wolf
Add a function to list the NBD exports offered by an NBD server. Signed-off-by: Kevin Wolf Message-Id: <20200924152717.287415-30-kw...@redhat.com> Acked-by: Stefan Hajnoczi Reviewed-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 13 - 1 file changed, 1

<    1   2   3   4   >