Re: [PATCH qemu 1/4] drive-mirror: add support for sync=bitmap mode=never

2020-10-02 Thread Markus Armbruster
Fabian Grünbichler writes: > From: John Snow > > This patch adds support for the "BITMAP" sync mode to drive-mirror and > blockdev-mirror. It adds support only for the BitmapSyncMode "never," > because it's the simplest mode. > > This mode simply uses a user-provided bitmap as an initial copy >

Re: [PATCH v2 1/3] util/cutils: Introduce freq_to_str() to display Hertz units

2020-10-02 Thread Luc Michel
On 18:43 Thu 01 Oct , Philippe Mathieu-Daudé wrote: > Introduce freq_to_str() to convert frequency values in human > friendly units using the SI units for Hertz. > > Suggested-by: Luc Michel > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > include/qemu/cutils.h | 1

Re: [PATCH] ppc/pnv: Increase max firware size

2020-10-02 Thread Greg Kurz
On Fri, 2 Oct 2020 08:15:46 +0200 Cédric Le Goater wrote: > That was sent a bit fast. Can you please add in the commit log : > > Builds enabling GCOV can be bigger than 4MB and the limit on FSP > systems is 16MB. > > Thanks > And also s/firware/firmware in the title. Cheers, -- Greg

Re: io_uring possibly the culprit for qemu hang (linux-5.4.y)

2020-10-02 Thread Stefano Garzarella
Hi Ju, On Thu, Oct 01, 2020 at 11:30:14PM +0900, Ju Hyung Park wrote: > Hi Stefano, > > On Thu, Oct 1, 2020 at 5:59 PM Stefano Garzarella wrote: > > Please, can you share the qemu command line that you are using? > > This can be useful for the analysis. > > Sure. Thanks for sharing. The issue

[PATCH v4 1/1] qapi: Restrict code generated for user-mode

2020-10-02 Thread Philippe Mathieu-Daudé
A lot of QAPI generated code is never used by user-mode. Split out qapi_system_modules and qapi_system_or_tools_modules from the qapi_all_modules array. We now have 4 groups: - always used - only used by system-mode - not used by user-mode - not used by tools Signed-off-by: Philippe Mathieu-Daudé

[PATCH v4 0/1] user-mode: Prune build dependencies (part 3)

2020-10-02 Thread Philippe Mathieu-Daudé
This is the third part of a series reducing user-mode dependencies. By stripping out unused code, the build and testing time is reduced (as is space used by objects). Part 3: - Reduce user-mode QAPI generated files Since v3: - Keep qdev.json in user-mode (no need for qdev-system stub for qapi_e

Re: [PATCH v2] hw/arm: Restrict APEI tables generation to the 'virt' machine

2020-10-02 Thread Laszlo Ersek
On 10/01/20 18:22, Philippe Mathieu-Daudé wrote: > While APEI is a generic ACPI feature (usable by X86 and ARM64), only > the 'virt' machine uses it, by enabling the RAS Virtualization. See > commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option"). > > Restrict the APEI tables generation

Re: [PATCH v7 03/13] monitor: Use getter/setter functions for cur_mon

2020-10-02 Thread Markus Armbruster
Additional nitpick detail on Kevin's request. Kevin Wolf writes: > cur_mon really needs to be coroutine-local as soon as we move monitor > command handlers to coroutines and let them yield. As a first step, just > remove all direct accesses to cur_mon so that we can implement this in > the gette

Re: [PATCH] qcow2: Use L1E_SIZE in qcow2_write_l1_entry()

2020-10-02 Thread Kevin Wolf
Am 28.09.2020 um 18:23 hat Alberto Garcia geschrieben: > We overlooked these in 02b1ecfa100e7ecc2306560cd27a4a2622bfeb04 > > Signed-off-by: Alberto Garcia Thanks, applied to the block branch. Kevin

Re: [PATCH v7 07/13] monitor: Make current monitor a per-coroutine property

2020-10-02 Thread Markus Armbruster
Additional nitpick detail on Kevin's request. Kevin Wolf writes: > This way, a monitor command handler will still be able to access the > current monitor, but when it yields, all other code code will correctly > get NULL from monitor_cur(). > > This uses a hash table to map the coroutine pointer

Re: [PATCH v7 08/13] qapi: Add a 'coroutine' flag for commands

2020-10-02 Thread Markus Armbruster
Additional nitpick detail on Kevin's request. Kevin Wolf writes: > This patch adds a new 'coroutine' flag to QMP command definitions that > tells the QMP dispatcher that the command handler is safe to be run in a > coroutine. > > The documentation of the new flag pretends that this flag is alrea

[PATCH] hw/block/nvme: Simplify timestamp sum

2020-10-02 Thread Philippe Mathieu-Daudé
As the 'timestamp' variable is declared as a 48-bit bitfield, we do not need to wrap the sum result. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/nvme.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 63078f6009..44fa5b9076

Re: [PATCH v7 08/13] qapi: Add a 'coroutine' flag for commands

2020-10-02 Thread Markus Armbruster
Hit send too fast. Kevin Wolf writes: > This patch adds a new 'coroutine' flag to QMP command definitions that > tells the QMP dispatcher that the command handler is safe to be run in a > coroutine. > > The documentation of the new flag pretends that this flag is already > used as intended, whic

Re: [PATCH v7 09/13] qmp: Move dispatcher to a coroutine

2020-10-02 Thread Markus Armbruster
Additional nitpick detail on Kevin's request. Kevin Wolf writes: > This moves the QMP dispatcher to a coroutine and runs all QMP command > handlers that declare 'coroutine': true in coroutine context so they > can avoid blocking the main loop while doing I/O or waiting for other > events. > > Fo

Re: [PATCH v7 10/13] hmp: Add support for coroutine command handlers

2020-10-02 Thread Markus Armbruster
Additional nitpick detail on Kevin's request. Kevin Wolf writes: > Often, QMP command handlers are not only called to handle QMP commands, > but also from a corresponding HMP command handler. In order to give them > a consistent environment, optionally run HMP command handlers in a > coroutine,

Re: [PATCH] hw/block/nvme: Simplify timestamp sum

2020-10-02 Thread Klaus Jensen
On Oct 2 09:57, Philippe Mathieu-Daudé wrote: > As the 'timestamp' variable is declared as a 48-bit bitfield, > we do not need to wrap the sum result. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Klaus Jensen > --- > hw/block/nvme.c | 7 +-- > 1 file changed, 1 insertion(+), 6

Re: [PATCH v7 11/13] util/async: Add aio_co_reschedule_self()

2020-10-02 Thread Markus Armbruster
Additional nitpick detail on Kevin's request. Kevin Wolf writes: > Add a function that can be used to move the currently running coroutine > to a different AioContext (and therefore potentially a different > thread). > > Signed-off-by: Kevin Wolf > --- > include/block/aio.h | 10 ++ >

Re: [PATCH v7 06/13] qmp: Call monitor_set_cur() only in qmp_dispatch()

2020-10-02 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: [...] >> I'll just change this one in the next version. Changing a single >> well-known instance not a big problem. It's just unfortunate that there >> are "A few more in PATCH 08-11" and I don't know how to identify them. > > When I do that, and yo

[PATCH] hw/arm/fsl-imx25: Fix a typo

2020-10-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/fsl-imx25.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/arm/fsl-imx25.h b/include/hw/arm/fsl-imx25.h index 971f35dd16..c1603b2ac2 100644 --- a/include/hw/arm/fsl-imx25.h +++ b/include/hw/arm/fsl-imx25.h @@

[PATCH v5 1/1] accel/tcg: Fix computing of is_write for MIPS

2020-10-02 Thread Kele Huang
Detect all MIPS store instructions in cpu_signal_handler for all available MIPS versions, and set is_write if encountering such store instructions. This fixed the error while dealing with self-modified code for MIPS. Reviewed-by: Richard Henderson Signed-off-by: Kele Huang Signed-off-by: Xu Zou

Re: [PATCH v2 1/2] doc: Remove texi referenced in qemu-img-cmds.hx and target/i386/cpu.c

2020-10-02 Thread Yonggang Luo
OK, then skip this On Fri, Oct 2, 2020 at 1:15 PM Markus Armbruster wrote: > > Yonggang Luo writes: > > > There is no texi document anymore > > > > Signed-off-by: Yonggang Luo > > --- > > qemu-img-cmds.hx | 2 +- > > target/i386/cpu.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(

Re: [PATCH v3 1/1] accel/tcg: Fix computing of is_write for MIPS

2020-10-02 Thread Kele Huang
> +case 015: /* SDXC1 */ I just found a comment mistake about SUXC1, and I have rectified it and resent a new patch. On Tue, 29 Sep 2020 at 09:59, Kele Huang wrote: > Thank you so much! > > > On Mon, 28 Sep 2020 at 16:14, Aleksandar Markovic < > aleksandar.qemu.de...@gmail.com> wrote:

Re: [PATCH qemu 4/4] iotests: add test for bitmap mirror

2020-10-02 Thread Fabian Grünbichler
On October 1, 2020 7:31 pm, Max Reitz wrote: > On 22.09.20 11:14, Fabian Grünbichler wrote: >> heavily based on/practically forked off iotest 257 for bitmap backups, >> but: >> >> - no writes to filter node 'mirror-top' between completion and >> finalization, as those seem to deadlock? >> - no inc

Re: [PATCH qemu 2/4] drive-mirror: add support for conditional and always bitmap sync modes

2020-10-02 Thread Fabian Grünbichler
On October 1, 2020 7:01 pm, Max Reitz wrote: > On 22.09.20 11:14, Fabian Grünbichler wrote: >> From: John Snow >> >> Teach mirror two new tricks for using bitmaps: >> >> Always: no matter what, we synchronize the copy_bitmap back to the >> sync_bitmap. In effect, this allows us resume a failed m

Re: [PATCH qemu 1/4] drive-mirror: add support for sync=bitmap mode=never

2020-10-02 Thread Fabian Grünbichler
On October 2, 2020 9:06 am, Markus Armbruster wrote: > Fabian Grünbichler writes: > >> From: John Snow >> >> This patch adds support for the "BITMAP" sync mode to drive-mirror and >> blockdev-mirror. It adds support only for the BitmapSyncMode "never," >> because it's the simplest mode. >> >> Th

Re: [PATCH 3/9] hw/block/nvme: support per-namespace smart log

2020-10-02 Thread Klaus Jensen
On Sep 30 15:04, Keith Busch wrote: > Let the user specify a specific namespace if they want to get access > stats for a specific namespace. > > Signed-off-by: Keith Busch > --- > hw/block/nvme.c | 66 +++- > include/block/nvme.h | 1 + > 2 files cha

Re: [PATCH v4 1/1] qapi: Restrict code generated for user-mode

2020-10-02 Thread Paolo Bonzini
On 02/10/20 09:36, Philippe Mathieu-Daudé wrote: > A lot of QAPI generated code is never used by user-mode. > > Split out qapi_system_modules and qapi_system_or_tools_modules > from the qapi_all_modules array. We now have 4 groups: > - always used > - only used by system-mode > - not used by user-

Re: [PATCH] elfload: use g_new instead of malloc

2020-10-02 Thread Markus Armbruster
Thomas Huth writes: > On 02/10/2020 07.05, Markus Armbruster wrote: >> Elena Afanasova writes: >> >>> Signed-off-by: Elena Afanasova >>> --- >>> bsd-user/elfload.c | 92 +++--- >>> 1 file changed, 30 insertions(+), 62 deletions(-) >>> >>> diff --git a/b

[Bug 1894804] Re: Second DEVICE_DELETED event missing during virtio-blk disk device detach

2020-10-02 Thread Christian Ehrhardt 
Thanks Lee, builds are most reliably done in Lauchpad IMHO and the Ubuntu Delta is a quilt stack which isn't as easily bisectable. If we end up searching not between Ubuntu Delta I can help to get you qemu built from git for that. But for some initially probing which range of changes we want to a

KVM call for agenda for 2020-10-06

2020-10-02 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. For this call, we have agenda!! John Snow wants to talk about his new (and excting) developments with x-configure. Stay tun

[PATCH v2] ppc/pnv: Increase max firmware size

2020-10-02 Thread Cédric Le Goater
Builds enabling GCOV can be bigger than 4MB and the limit on FSP systems is 16MB. Signed-off-by: Cédric Le Goater --- hw/ppc/pnv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 6670967e26a9..d9e52873ea70 100644 --- a/hw/ppc/pnv.c +++ b/hw/p

Re: [PATCH] ppc/pnv: Increase max firware size

2020-10-02 Thread Cédric Le Goater
On 10/2/20 9:26 AM, Greg Kurz wrote: > On Fri, 2 Oct 2020 08:15:46 +0200 > Cédric Le Goater wrote: > >> That was sent a bit fast. Can you please add in the commit log : >> >> Builds enabling GCOV can be bigger than 4MB and the limit on FSP >> systems is 16MB. >> >> Thanks >> > > And also

[PATCH] gitlab: split deprecated job into build/check stages

2020-10-02 Thread Alex Bennée
While the job is pretty fast for only a few targets we still want to catch breakage of the build. By splitting the test step we can allow_failures for that while still ensuring we don't miss the build breaking. Signed-off-by: Alex Bennée --- .gitlab-ci.yml | 17 - 1 file changed,

Re: [PATCH v4 1/1] qapi: Restrict code generated for user-mode

2020-10-02 Thread Philippe Mathieu-Daudé
On 10/2/20 9:36 AM, Philippe Mathieu-Daudé wrote: > A lot of QAPI generated code is never used by user-mode. > > Split out qapi_system_modules and qapi_system_or_tools_modules > from the qapi_all_modules array. We now have 4 groups: > - always used > - only used by system-mode > - not used by user

Re: [PATCH v4 04/46] qapi: modify docstrings to be sphinx-compatible

2020-10-02 Thread Markus Armbruster
John Snow writes: > On 10/1/20 4:52 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 9/30/20 4:47 AM, Markus Armbruster wrote: John Snow writes: > I did not say "sphinx beautiful", just "sphinx compatible". They will > not throw errors when parsed and interpreted a

[Bug 1894804] Re: Second DEVICE_DELETED event missing during virtio-blk disk device detach

2020-10-02 Thread Lee Yarwood
Thanks Christian, I'll confirm that we see error from [2] with that PPA shortly. In the meantime I've removed the device detach retry logic from OpenStack Nova and now always see two DEVICE_DELETED events raised by QEMU after a single device_del request from libvirt: http://paste.openstack.org/s

Re: [PATCH] gitlab: split deprecated job into build/check stages

2020-10-02 Thread Thomas Huth
On 02/10/2020 11.15, Alex Bennée wrote: > While the job is pretty fast for only a few targets we still want to > catch breakage of the build. By splitting the test step we can > allow_failures for that while still ensuring we don't miss the build > breaking. Is there already something broken? Oth

Re: [PATCH v4] introduce vfio-user protocol specification

2020-10-02 Thread Felipe Franciosi
> On Sep 30, 2020, at 3:24 PM, Stefan Hajnoczi wrote: > > On Tue, Sep 29, 2020 at 09:21:54AM -0700, John G Johnson wrote: >>> On Sep 29, 2020, at 3:37 AM, Stefan Hajnoczi wrote: >>> >>> On Mon, Sep 28, 2020 at 09:58:37AM +, Thanos Makatos wrote: > It should be accompanied by a test i

Re: ARM semihosting issue

2020-10-02 Thread Peter Maydell
On Thu, 1 Oct 2020 at 22:21, Bruno Prado wrote: > Thanks for the reply... I am attaching some code and output: > > #include > int main() { >char name[50] = "Nobody"; >FILE* file = fopen("name", "r"); >printf("What is your name?\n"); >fprintf(stdout, "Reading from f

[PATCH v2] gitlab: move linux-user plugins test across to gitlab

2020-10-02 Thread Alex Bennée
Even with the recent split moving beefier plugins into contrib and dropping them from the check-tcg tests we are still hitting time limits. This possibly points to a slow down of --debug-tcg but seeing as we are migrating stuff to gitlab we might as well move there and bump the timeout. Signed-off

Re: [PATCH v2] gitlab: move linux-user plugins test across to gitlab

2020-10-02 Thread Thomas Huth
On 02/10/2020 12.32, Alex Bennée wrote: > Even with the recent split moving beefier plugins into contrib and > dropping them from the check-tcg tests we are still hitting time > limits. This possibly points to a slow down of --debug-tcg but seeing > as we are migrating stuff to gitlab we might as w

Re: [PULL 00/17] Block patches

2020-10-02 Thread Peter Maydell
On Thu, 1 Oct 2020 at 16:03, Stefan Hajnoczi wrote: > Please rerun with make -j1 V=1 so the full command is printed. I'm not > sure what is emitting these errors. Vladimir's guess was correct: /usr/bin/python3 /home/pm215/qemu/block/../scripts/block-coroutine-wrapper.py block/block-gen.c ../../b

Re: Use of "?" for help has been deprecated for 8 years, can we drop it?

2020-10-02 Thread Gerd Hoffmann
Hi, > > Did we ever issue a warning when it was used? It's easier to argue that > > it can be dropped if users had notice of some form or another. That > > said, I'm not heartbroken if we yank it immediately instead of letting > > it live for 2 more releases. > > How about keeping it as a con

[PATCH] meson.build: Don't look for libudev for static builds

2020-10-02 Thread Peter Maydell
commit f01496a314d916 moved the logic for detecting libudev from configure to meson.build, but in the process it dropped the condition that meant we only ask pkg-config about libudev for a non-static build. This breaks static builds of the system emulators on at least Ubuntu 18.04.4, because on th

Re: ARM semihosting issue

2020-10-02 Thread Bruno Prado
I am including some syscall functions: int _fstat(int file, struct stat* st) { register int value asm("r0"); uint32_t p[] = { file }; R0(0x0C); R1(p); BKPT(); return value; } int _read(int file, char* ptr, int len) { register int value asm("r0");

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-02 Thread Yonggang Luo
So the better way is pkg-config handling sttaic properly? On Fri, Oct 2, 2020 at 6:53 PM Peter Maydell wrote: > > commit f01496a314d916 moved the logic for detecting libudev from > configure to meson.build, but in the process it dropped the condition > that meant we only ask pkg-config about libud

Re: [PATCH v2] gitlab: move linux-user plugins test across to gitlab

2020-10-02 Thread Fam Zheng
On Fri, 2020-10-02 at 11:32 +0100, Alex Bennée wrote: > Even with the recent split moving beefier plugins into contrib and > dropping them from the check-tcg tests we are still hitting time > limits. This possibly points to a slow down of --debug-tcg but seeing > as we are migrating stuff to gitlab

Re: [PATCH] gitlab: split deprecated job into build/check stages

2020-10-02 Thread Alex Bennée
Thomas Huth writes: > On 02/10/2020 11.15, Alex Bennée wrote: >> While the job is pretty fast for only a few targets we still want to >> catch breakage of the build. By splitting the test step we can >> allow_failures for that while still ensuring we don't miss the build >> breaking. > > Is the

[PATCH v3 1/2] block: drop moderated sheepdog mailing list from MAINTAINERS file

2020-10-02 Thread Daniel P . Berrangé
The sheepdog mailing list is setup to stop and queue messages from non-subscribers, pending moderator approval. Unfortunately it seems that the moderation queue is not actively dealt with. Even when messages are approved, the sender is never added to the whitelist, so every future mail from the sam

[PATCH v3 0/2] block: deprecate the sheepdog driver

2020-10-02 Thread Daniel P . Berrangé
2 years back I proposed dropping the sheepdog mailing list from the MAINTAINERS file, but somehow the patch never got picked up: https://lists.gnu.org/archive/html/qemu-block/2018-03/msg01048.html So here I am with the same patch again. This time I go further and deprecate the sheepdog driver

[PATCH v3 2/2] block: deprecate the sheepdog block driver

2020-10-02 Thread Daniel P . Berrangé
This thread from a little over a year ago: http://lists.wpkg.org/pipermail/sheepdog/2019-March/thread.html states that sheepdog is no longer actively developed. The only mentioned users are some companies who are said to have it for legacy reasons with plans to replace it by Ceph. There is talk

[PULL 06/14] tests/docker: Use Fedora containers for MinGW cross-builds in the gitlab-CI

2020-10-02 Thread Alex Bennée
From: Thomas Huth According to our support policy, we do not support Debian 9 in QEMU anymore, and we only support building the Windows binaries with a very recent version of the MinGW toolchain. So we should not test the MinGW cross-compilation with Debian 9 anymore, but switch to something newe

[PULL 01/14] migration: Silence compiler warning in global_state_store_running()

2020-10-02 Thread Alex Bennée
From: Thomas Huth GCC 9.3.0 on Ubuntu complains: In file included from /usr/include/string.h:495, from /home/travis/build/huth/qemu/include/qemu/osdep.h:87, from ../migration/global_state.c:13: In function ‘strncpy’, inlined from ‘global_state_store_running’

[PULL 04/14] travis.yml: Drop the superfluous Python 3.6 build

2020-10-02 Thread Alex Bennée
From: Thomas Huth Python 3.6 is already the default Python in the jobs that are based on Ubuntu Bionic, so it does not make much sense to test this again separately. Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20200918103430.297167-7-th...@redhat.com> Message-Id: <202009

[PULL 00/14] testing updates (python, plugins)

2020-10-02 Thread Alex Bennée
The following changes since commit b5ce42f5d138d7546f9faa2decbd6ee8702243a3: Merge remote-tracking branch 'remotes/jsnow-gitlab/tags/ide-pull-request' into staging (2020-10-01 19:55:10 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-and-p

[PULL 02/14] travis.yml: Drop the default softmmu builds

2020-10-02 Thread Alex Bennée
From: Thomas Huth The total runtime of all Travis jobs is very long and we are testing all softmmu targets in the gitlab-CI already - so we can speed up the Travis testing a little bit by not testing the softmmu targets here anymore. Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée Review

[PULL 08/14] tests/docker: Update the tricore container to debian 10

2020-10-02 Thread Alex Bennée
From: Thomas Huth We do not support Debian 9 anymore, thus update the Tricore container to Debian 10 now. Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200921174320.46062-4-th...@redhat.com> Message-Id

[PULL 03/14] travis.yml: Update Travis to use Bionic and Focal instead of Xenial

2020-10-02 Thread Alex Bennée
From: Thomas Huth According to our support policy, we do not support Xenial anymore. Time to switch the bigger parts of the builds to Focal instead. Some few jobs have to be updated to Bionic instead, since they are currently still failing on Focal otherwise. Also "--disable-pie" is causing linke

[PULL 13/14] gitlab: move linux-user plugins test across to gitlab

2020-10-02 Thread Alex Bennée
Even with the recent split moving beefier plugins into contrib and dropping them from the check-tcg tests we are still hitting time limits. This possibly points to a slow down of --debug-tcg but seeing as we are migrating stuff to gitlab we might as well move there and bump the timeout. Signed-off

[PULL 09/14] shippable.yml: Remove the Debian9-based MinGW cross-compiler tests

2020-10-02 Thread Alex Bennée
From: Thomas Huth We're not supporting Debian 9 anymore, and we are now testing MinGW cross-compiler builds in the gitlab-CI, too, so we do not really need these jobs in the shippable.yml anymore. Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20200921174320.46062-5-th...@r

[PULL 11/14] gitlab-ci: Increase the timeout for the cross-compiler builds

2020-10-02 Thread Alex Bennée
From: Thomas Huth Some of the cross-compiler builds (the mips build and the win64 build for example) are quite slow and sometimes hit the 1h time limit. Increase the limit a little bit to make sure that we do not get failures in the CI runs just because of some few minutes. Signed-off-by: Thomas

[PULL 14/14] gitlab: split deprecated job into build/check stages

2020-10-02 Thread Alex Bennée
While the job is pretty fast for only a few targets we still want to catch breakage of the build. By splitting the test step we can allow_failures for that while still ensuring we don't miss the build breaking. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20201002091538.3017-

[PULL 07/14] gitlab-ci: Remove the Debian9-based containers and containers-layer3

2020-10-02 Thread Alex Bennée
From: Thomas Huth According to our support policy, Debian 9 is not supported by the QEMU project anymore. Since we now switched the MinGW cross-compiler builds to Fedora, we do not need these Debian9-based containers in the gitlab-CI anymore, and can now also get rid of the "layer3" container bui

[PULL 12/14] configure: Bump the minimum required Python version to 3.6

2020-10-02 Thread Alex Bennée
From: Thomas Huth All our supported build platforms have Python 3.6 or newer nowadays, and there are some useful features in Python 3.6 which are not available in 3.5 yet (e.g. the type hint annotations which will allow us to statically type the QAPI parser), so let's bump the minimum Python vers

[PULL 05/14] travis.yml: Drop the Python 3.5 build

2020-10-02 Thread Alex Bennée
From: Thomas Huth We are soon going to remove the support for Python 3.5. So remove the CI job now. Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20200922070441.48844-1-th...@redhat.com> Message-Id: <20200925154027.12672-9-alex.ben...@linaro.org> diff --git a/.travis.yml

[PULL 10/14] tests/docker: Remove old Debian 9 containers

2020-10-02 Thread Alex Bennée
From: Thomas Huth We do not support Debian 9 in QEMU anymore, and the Debian 9 containers are now no longer used in the gitlab-CI. Time to remove them. Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200

Re: [PATCH v1 1/1] sheepdog driver patch: fixs the problem of qemu process become crashed when the sheepdog gateway break the IO and then recover

2020-10-02 Thread Kevin Wolf
Am 01.10.2020 um 04:21 hat mingwei geschrieben: > this patch fixs the problem of qemu process become crashed when the sheepdog > gateway break the IO for a few seconds and then recover. > > problem reproduce: > 1.start a fio process in qemu to produce IOs to sheepdog gateway, whatever IO > type

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-02 Thread Paolo Bonzini
On 02/10/20 12:52, Peter Maydell wrote: > commit f01496a314d916 moved the logic for detecting libudev from > configure to meson.build, but in the process it dropped the condition > that meant we only ask pkg-config about libudev for a non-static > build. > > This breaks static builds of the system

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-02 Thread Paolo Bonzini
On 02/10/20 13:15, 罗勇刚(Yonggang Luo) wrote: > So the better way is pkg-config handling sttaic properly? The problem is that you cannot handle it properly. Consider for example libmultipath, which requires the program to define a couple functions for static linking to work. A compile-time check t

Re: [PATCH qemu 1/4] drive-mirror: add support for sync=bitmap mode=never

2020-10-02 Thread Markus Armbruster
Fabian Grünbichler writes: > On October 2, 2020 9:06 am, Markus Armbruster wrote: >> Fabian Grünbichler writes: >> >>> From: John Snow >>> >>> This patch adds support for the "BITMAP" sync mode to drive-mirror and >>> blockdev-mirror. It adds support only for the BitmapSyncMode "never," >>> be

[PULL 01/19] hw/s390x/css: Remove double initialization

2020-10-02 Thread Cornelia Huck
From: Philippe Mathieu-Daudé Fix eventual copy/paste mistake introduced in commit bc994b74ea ("s390x/css: Use static initialization for channel_subsys fields"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20200907024020.854465-1-phi...@redhat.com> Signed-off-by:

[PULL 00/19] s390x changes

2020-10-02 Thread Cornelia Huck
The following changes since commit b5ce42f5d138d7546f9faa2decbd6ee8702243a3: Merge remote-tracking branch 'remotes/jsnow-gitlab/tags/ide-pull-request' into staging (2020-10-01 19:55:10 +0100) are available in the Git repository at: https://github.com/cohuck/qemu tags/s390x-202

[PULL 03/19] s390/sclp: rework sclp boundary checks

2020-10-02 Thread Cornelia Huck
From: Collin Walling Rework the SCLP boundary check to account for different SCLP commands (eventually) allowing different boundary sizes. Signed-off-by: Collin Walling Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth Acked-by: Janosch Frank Reviewed-by: Claudio Imbrenda Message-Id: <202

[PULL 08/19] s390: guest support for diagnose 0x318

2020-10-02 Thread Cornelia Huck
From: Collin Walling DIAGNOSE 0x318 (diag318) is an s390 instruction that allows the storage of diagnostic information that is collected by the firmware in the case of hardware/firmware service events. QEMU handles the instruction by storing the info in the CPU state. A subsequent register sync

[PULL 02/19] s390/sclp: get machine once during read scp/cpu info

2020-10-02 Thread Cornelia Huck
From: Collin Walling Functions within read scp/cpu info will need access to the machine state. Let's make a call to retrieve the machine state once and pass the appropriate data to the respective functions. Signed-off-by: Collin Walling Reviewed-by: David Hildenbrand Reviewed-by: Thomas Huth

[PULL 12/19] s390x/tcg: Implement ADD HALFWORD (AGH)

2020-10-02 Thread Cornelia Huck
From: David Hildenbrand Easy, just like ADD HALFWORD IMMEDIATE (AGHI). Signed-off-by: David Hildenbrand Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Message-Id: <20200928122717.30586-3-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 1 + target/s39

[PULL 05/19] s390/sclp: check sccb len before filling in data

2020-10-02 Thread Cornelia Huck
From: Collin Walling The SCCB must be checked for a sufficient length before it is filled with any data. If the length is insufficient, then the SCLP command is suppressed and the proper response code is set in the SCCB header. While we're at it, let's cleanup the length check by placing the cal

[PULL 04/19] s390/sclp: read sccb from mem based on provided length

2020-10-02 Thread Cornelia Huck
From: Collin Walling The header contained within the SCCB passed to the SCLP service call contains the actual length of the SCCB. Instead of allocating a static 4K size for the work sccb, let's allow for a variable size determined by the value in the header. The proper checks are already in place

[PULL 07/19] s390/sclp: add extended-length sccb support for kvm guest

2020-10-02 Thread Cornelia Huck
From: Collin Walling As more features and facilities are added to the Read SCP Info (RSCPI) response, more space is required to store them. The space used to store these new features intrudes on the space originally used to store CPU entries. This means as more features and facilities are added t

[PULL 11/19] s390x/cpumodel: S390_FEAT_MISC_INSTRUCTION_EXT -> S390_FEAT_MISC_INSTRUCTION_EXT2

2020-10-02 Thread Cornelia Huck
From: David Hildenbrand Let's avoid confusion with the "Miscellaneous-Instruction-Extensions Facility 1" Suggested-by: Thomas Huth Signed-off-by: David Hildenbrand Cc: Christian Borntraeger Message-Id: <20200928122717.30586-2-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/c

[PULL 06/19] s390/sclp: use cpu offset to locate cpu entries

2020-10-02 Thread Cornelia Huck
From: Collin Walling The start of the CPU entry region in the Read SCP Info response data is denoted by the offset_cpu field. As such, QEMU needs to begin creating entries at this address. This is in preparation for when Read SCP Info inevitably introduces new bytes that push the start of the CP

[PULL 13/19] s390x/tcg: Implement SUBTRACT HALFWORD (SGH)

2020-10-02 Thread Cornelia Huck
From: David Hildenbrand Easy to wire up. Signed-off-by: David Hildenbrand Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Message-Id: <20200928122717.30586-4-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 1 + 1 file changed, 1 insertion(+) diff --g

[PULL 14/19] s390x/tcg: Implement MULTIPLY (MG, MGRK)

2020-10-02 Thread Cornelia Huck
From: David Hildenbrand Multiply two signed 64bit values and store the 128bit result in r1 (0-63) and r1 + 1 (64-127). Signed-off-by: David Hildenbrand Reviewed-by: Richard Henderson Message-Id: <20200928122717.30586-5-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data

[PULL 09/19] s390x/tcg: Implement MONITOR CALL

2020-10-02 Thread Cornelia Huck
From: David Hildenbrand Recent upstream Linux uses the MONITOR CALL instruction for things like BUG_ON() and WARN_ON(). We currently inject an operation exception when we hit a MONITOR CALL instruction - which is wrong, as the instruction is not glued to specific CPU features. Doing a simple WAR

[PULL 10/19] vfio-ccw: plug memory leak while getting region info

2020-10-02 Thread Cornelia Huck
vfio_get_dev_region_info() unconditionally allocates memory for a passed-in vfio_region_info structure (and does not re-use an already allocated structure). Therefore, we have to free the structure we pass to that function in vfio_ccw_get_region() for every region we successfully obtained informati

[PULL 15/19] s390x/tcg: Implement MULTIPLY HALFWORD (MGH)

2020-10-02 Thread Cornelia Huck
From: David Hildenbrand Just like MULTIPLY HALFWORD IMMEDIATE (MGHI), only the second operand (signed 16 bit) comes from memory. Signed-off-by: David Hildenbrand Reviewed-by: Richard Henderson Message-Id: <20200928122717.30586-6-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x

[PULL 16/19] s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)

2020-10-02 Thread Cornelia Huck
From: David Hildenbrand Just like BRANCH ON CONDITION - however the address is read from memory (always 8 bytes are read), we have to wrap the address manually. The address is read using current CPU DAT/address-space controls, just like ordinary data. Signed-off-by: David Hildenbrand Reviewed-b

[PULL 18/19] s390x/tcg: We support Miscellaneous-Instruction-Extensions Facility 2

2020-10-02 Thread Cornelia Huck
From: David Hildenbrand We implement all relevant instructions. Signed-off-by: David Hildenbrand Reviewed-by: Richard Henderson Message-Id: <20200928122717.30586-9-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/gen-features.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PULL 17/19] s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)

2020-10-02 Thread Cornelia Huck
From: David Hildenbrand We need new CC handling, determining the CC based on the intermediate result (64bit for MSC and MSRKC, 128bit for MSGC and MSGRKC). We want to store out2 ("low") after muls128 to r1, so add "wout_out2_r1". Signed-off-by: David Hildenbrand Reviewed-by: Richard Henderson

[PULL 19/19] s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA)

2020-10-02 Thread Cornelia Huck
From: David Hildenbrand As with the other crypto functions, we only implement subcode 0 (query) and no actual encryption/decryption. We now implement S390_FEAT_MSA_EXT_8. Signed-off-by: David Hildenbrand Reviewed-by: Richard Henderson Message-Id: <20200928122717.30586-10-da...@redhat.com> Sign

Re: [PATCH v2 2/4] qom: Factor out helpers from user_creatable_print_help()

2020-10-02 Thread Markus Armbruster
Kevin Wolf writes: > This creates separate helper functions for printing a list of user > creatable object types and for printing a list of properties of a given > type. This allows using these parts without having a QemuOpts. Does the last sentence allude to a future patch? If yes, I suggest t

Re: [PATCH v2 3/4] qom: Add user_creatable_print_help_from_qdict()

2020-10-02 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> This adds a function that, given a QDict of non-help options, prints >> help for user creatable objects. >> >> Signed-off-by: Kevin Wolf >> --- >> include/qom/object_interfaces.h | 9 + >> qom/object_interfaces.c | 9 +

Re: [PATCH v2 4/4] qemu-storage-daemon: Remove QemuOpts from --object parser

2020-10-02 Thread Markus Armbruster
Kevin Wolf writes: > The command line parser for --object parses the input twice: Once into > QemuOpts just for detecting help options, and then again into a QDict > using the keyval parser for actually creating the object. > > Now that the keyval parser can also detect help options, we can simpl

[RFC][POC PATCH] Supporting >255 guest CPUs without interrupt remapping

2020-10-02 Thread David Woodhouse
AFAICT there's not actually any good reason why guests can't use x2apic and have more than 255 CPUs today, even without exposing interrupt remapping to the guest. The only issue is that guests can't direct external IOAPIC and MSI interrupts at the higher APIC IDs. So what? A guest might have a wor

Re: [PATCH v2 3/4] qom: Add user_creatable_print_help_from_qdict()

2020-10-02 Thread Markus Armbruster
Kevin Wolf writes: > This adds a function that, given a QDict of non-help options, prints > help for user creatable objects. > > Signed-off-by: Kevin Wolf > --- > include/qom/object_interfaces.h | 9 + > qom/object_interfaces.c | 9 + > 2 files changed, 18 insertions(+)

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-02 Thread Peter Maydell
On Fri, 2 Oct 2020 at 13:02, Paolo Bonzini wrote: > > On 02/10/20 12:52, Peter Maydell wrote: > > commit f01496a314d916 moved the logic for detecting libudev from > > configure to meson.build, but in the process it dropped the condition > > that meant we only ask pkg-config about libudev for a non

[PATCH] virtiofsd: Call qemu_init_exec_dir

2020-10-02 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Since fcb4f59c879 qemu_get_local_state_pathname relies on the init_exec_dir, and virtiofsd asserts because we never set it. Set it. Reported-by: Alex Bennée Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 2 ++ 1 file changed, 2 inse

Re: [PATCH v9 0/4] Introduce Xilinx ZynqMP CAN controller

2020-10-02 Thread Peter Maydell
On Thu, 1 Oct 2020 at 18:57, Vikram Garhwal wrote: > > Hi Peter, > I sent rebased V10 series three weeks back as there were some issues with > meson build on v9. Would it possible for you to apply the patch series? Oops, sorry -- I didn't notice the resent series. I've put it on my list to handl

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-02 Thread Peter Maydell
On Fri, 2 Oct 2020 at 13:35, Peter Maydell wrote: > > On Fri, 2 Oct 2020 at 13:02, Paolo Bonzini wrote: > > - the workaround: just leave things as they are and add > > --disable-libudev to your script. > > There is no --disable-udev ! ...and there's no --disable-libudev either :-) -- PMM

Re: [PATCH v2] gitlab: move linux-user plugins test across to gitlab

2020-10-02 Thread Thomas Huth
On 02/10/2020 13.16, Fam Zheng wrote: > On Fri, 2020-10-02 at 11:32 +0100, Alex Bennée wrote: >> Even with the recent split moving beefier plugins into contrib and >> dropping them from the check-tcg tests we are still hitting time >> limits. This possibly points to a slow down of --debug-tcg but s

  1   2   3   4   >