On Fri, 2020-09-25 at 13:25 -0400, Paolo Bonzini wrote:
> Check if an address is free on the bus before plugging in the
> device. This makes it possible to do the check without any
> side effects, and to detect the problem early without having
> to do it in the realize callback.
>
> Signed-off-by
On Fri, 2020-09-25 at 13:25 -0400, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> hw/scsi/scsi-bus.c | 122 -
> 1 file changed, 75 insertions(+), 47 deletions(-)
>
> diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
> index 3284a5d1fb..
On Fri, 2020-09-25 at 13:25 -0400, Paolo Bonzini wrote:
> From: Maxim Levitsky
>
> This fixes the race between device emulation code that tries to find
> a child device to dispatch the request to (e.g a scsi disk),
> and hotplug of a new device to that bus.
>
> Note that this doesn't convert all
On Fri, 2020-09-25 at 13:26 -0400, Paolo Bonzini wrote:
> From: Maxim Levitsky
>
> Some code might race with placement of new devices on a bus.
> We currently first place a (unrealized) device on the bus
> and then realize it.
>
> As a workaround, users that scan the child device list, can
> che
Stefan Hajnoczi writes:
> On Wed, Sep 30, 2020 at 07:28:58AM +0200, Markus Armbruster wrote:
>> Stefan Hajnoczi writes:
>>
>> > Use the new QAPI block exports API instead of defining our own QOM
>> > objects.
>> >
>> > This is a large change because the lifecycle of VuBlockDev needs to
>> > fol
On Fri, 2020-09-25 at 13:26 -0400, Paolo Bonzini wrote:
> From: Maxim Levitsky
>
> The device core first places a device on the bus and then realizes it.
> Make scsi_device_find avoid returing such devices to avoid
> races in drivers that use an iothread (currently virtio-scsi)
>
> Bugzilla: htt
On Fri, 2020-09-25 at 13:26 -0400, Paolo Bonzini wrote:
> From: Maxim Levitsky
>
> Currently scsi_target_emulate_report_luns iterates over the child device list
> twice, and there is no guarantee that this list is the same in both
> iterations.
>
> The reason for iterating twice is that the fir
On Fri, 2020-09-25 at 13:26 -0400, Paolo Bonzini wrote:
> From: Maxim Levitsky
>
> Add scsi_device_get which finds the scsi device
> and takes a reference to it.
>
> Suggested-by: Stefan Hajnoczi
> Signed-off-by: Maxim Levitsky
> Message-Id: <20200913160259.32145-8-mlevi...@redhat.com>
> Signe
On Wed, Sep 30, 2020 at 03:40:20PM +0200, Vitaly Kuznetsov wrote:
> Hyper-V feature leaves are weird. We have some of them in
> feature_word_info[] array but we don't use feature_word_info
> magic to enable them. Neither do we use feature_dependencies[]
> mechanism to validate the configuration as
Patchew URL:
https://patchew.org/QEMU/1601425716-204629-1-git-send-email-koml...@xilinx.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
N/A. Internal error while reading log file
The full log is available at
http://patchew.org/logs/1601
On Mon, Sep 28, 2020 at 11:35:23AM +0900, Dmitry Fomichev wrote:
> The emulation code has been changed to advertise NVM Command Set when
> "zoned" device property is not set (default) and Zoned Namespace
> Command Set otherwise.
>
> Handlers for three new NVMe commands introduced in Zoned Namespac
This series adds support for the "Vector enhancements facility" and bumps
the qemu CPU model tp to a stripped-down z14.
I yet have to find a way to get more test coverage - looks like some of
the functions aren't used anywhere yet (e.g., VECTOR FP MAXIMUM), writing
unit tests to cover all function
In case of 128bit, we always have a single element.
Add some helpers that allow to generically read/write 32/64/128 bit
floats. Convert the existing implementation of vop64_3 into a macro that
deals with float* instead of uint* instead - the other users keep
working as
typedef uint32_t float32
Fortunately, we only need the Doubleword implementation.
Signed-off-by: David Hildenbrand
---
target/s390x/insn-data.def | 2 ++
target/s390x/translate_vx.c.inc | 52 +
2 files changed, 54 insertions(+)
diff --git a/target/s390x/insn-data.def b/target/s390x
Convert vop64_2 into a macro, similar to already done with vop64_3.
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 3 ++
target/s390x/translate_vx.c.inc | 51 ++-
target/s390x/vec_fpu_helper.c | 90 ++---
3 files changed, 91
Just like VECTOR FP ADD.
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 3 +++
target/s390x/translate_vx.c.inc | 18 +-
target/s390x/vec_fpu_helper.c | 28 +++-
3 files changed, 35 insertions(+), 14 deletions(-)
diff --git a/tar
128 bit -> 64 bit, there is only a single element to process.
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 1 +
target/s390x/translate_vx.c.inc | 11 ++-
target/s390x/vec_fpu_helper.c | 19 +++
3 files changed, 30 insertions(+), 1 deletion(-)
Implementation inspired by minmax_floats(). Unfortuantely, we don't have
any tests we can simply adjust/unlock.
Cc: Aurelien Jarno
Cc: Peter Maydell
Cc: "Alex Bennée"
Signed-off-by: David Hildenbrand
---
fpu/softfloat.c | 100
include/fpu/softf
Signed-off-by: David Hildenbrand
---
target/s390x/translate_vx.c.inc | 100 +---
1 file changed, 67 insertions(+), 33 deletions(-)
diff --git a/target/s390x/translate_vx.c.inc b/target/s390x/translate_vx.c.inc
index 0b21e8789f..ee79d97e19 100644
--- a/target/s390x/tra
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 2 ++
target/s390x/translate_vx.c.inc | 8
target/s390x/vec_helper.c | 22 ++
4 files changed, 33 insertions(+)
diff --git a/target/s390x/helper.h b
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 3 ++
target/s390x/translate_vx.c.inc | 26 ---
target/s390x/vec_fpu_helper.c | 76 +++--
3 files changed, 69 insertions(+), 36 deletions(-)
diff --git a/target/s390x/helper.h b/target/s
64 bit -> 128 bit, there is only a single final element.
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 1 +
target/s390x/translate_vx.c.inc | 21 -
target/s390x/vec_fpu_helper.c | 13 +
3 files changed, 30 insertions(+), 5 deletions(-)
Signed-off-by: David Hildenbrand
---
target/s390x/gen-features.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
index 21c1e912fd..a7bad36f35 100644
--- a/target/s390x/gen-features.c
+++ b/target/s390x/gen-features.c
@@ -718,6 +718,7 @
Just like VECTOR FP ADD.
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 3 +++
target/s390x/translate_vx.c.inc | 18 +-
target/s390x/vec_fpu_helper.c | 28 +++-
3 files changed, 35 insertions(+), 14 deletions(-)
diff --git a/tar
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 6 ++
target/s390x/translate_vx.c.inc | 48 +---
target/s390x/vec_fpu_helper.c | 98 -
3 files changed, 107 insertions(+), 45 deletions(-)
diff --git a/target/s390x/helper.h b/ta
Eduardo Habkost writes:
> On Wed, Sep 30, 2020 at 03:40:20PM +0200, Vitaly Kuznetsov wrote:
>> Hyper-V feature leaves are weird. We have some of them in
>> feature_word_info[] array but we don't use feature_word_info
>> magic to enable them. Neither do we use feature_dependencies[]
>> mechanism t
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 10
target/s390x/insn-data.def | 4 +++
target/s390x/translate_vx.c.inc | 26 +++
target/s390x/vec_fpu_helper.c | 45 +
4 files changed, 85 insertions(+)
diff -
Just like VECTOR FP ADD.
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 3 +++
target/s390x/translate_vx.c.inc | 18 +-
target/s390x/vec_fpu_helper.c | 28 +++-
3 files changed, 35 insertions(+), 14 deletions(-)
diff --git a/tar
On Wed, Sep 30, 2020 at 04:07:59AM -0400, Michael S. Tsirkin wrote:
> On Tue, Sep 29, 2020 at 07:38:24PM +0100, Stefan Hajnoczi wrote:
> > On Tue, Sep 29, 2020 at 06:04:34AM -0400, Michael S. Tsirkin wrote:
> > > On Tue, Sep 29, 2020 at 09:57:51AM +0100, Stefan Hajnoczi wrote:
> > > > On Tue, Sep 2
Am 30.09.2020 um 15:42 hat Eric Blake geschrieben:
> On 9/30/20 8:04 AM, Kevin Wolf wrote:
> > Am 29.09.2020 um 19:46 hat Eric Blake geschrieben:
> >> On 9/29/20 12:26 PM, Kevin Wolf wrote:
> >>> This adds a new parameter 'help' to keyval_parse() that enables parsing
> >>> of help options. If NULL
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 4 +++
target/s390x/translate_vx.c.inc | 38 +++-
target/s390x/vec_fpu_helper.c | 64 +++--
3 files changed, 72 insertions(+), 34 deletions(-)
diff --git a/target/s390x/helper.h
In addition to 32/128bit variants, we also have to support the
"Signal-on-QNaN (SQ)" bit ... let's pass it as a simple flag, I don't
feel like duplicating all helpers and coming up with names like
"...s_cc_sq".
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 18 +++
targe
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 3 +++
target/s390x/translate_vx.c.inc | 26 +-
target/s390x/vec_fpu_helper.c | 28 +++-
3 files changed, 39 insertions(+), 18 deletions(-)
diff --git a/target/s390x/helper.h
For IEEE functions, we can reuse the softfloat implementations. For the
other functions, implement it generically for 32bit/64bit/128bit -
carefully taking care of all weird special cases according to the tables
defined in the PoP.
While we could add plenty of helpers to do the function selection
Am 30.09.2020 um 15:35 hat Eric Blake geschrieben:
> On 9/30/20 7:45 AM, Kevin Wolf wrote:
> > This adds a new parameter 'help' to keyval_parse() that enables parsing
> > of help options. If NULL is passed, the function behaves the same as
> > before. But if a bool pointer is given, it contains the
On Mon, Sep 28, 2020 at 11:35:23AM +0900, Dmitry Fomichev wrote:
> The emulation code has been changed to advertise NVM Command Set when
> "zoned" device property is not set (default) and Zoned Namespace
> Command Set otherwise.
>
> Handlers for three new NVMe commands introduced in Zoned Namespac
accept4() returned wrong errno, that did not match current linux
Signed-off-by: Matus Kysel
---
linux-user/syscall.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 897d20c076..5b8c20cf21 100644
--- a/linux-user/syscall.
TCG implements everything we need to run basic z14 OS+software.
Cc: Christian Borntraeger
Signed-off-by: David Hildenbrand
---
hw/s390x/s390-virtio-ccw.c | 2 ++
target/s390x/cpu_models.c | 4 ++--
target/s390x/gen-features.c | 15 +--
3 files changed, 13 insertions(+), 8 delet
Am 30.09.2020 um 15:48 hat Eric Blake geschrieben:
> On 9/30/20 8:39 AM, Kevin Wolf wrote:
> > Commit 5f479a8d renamed the 'device' option of --export into
> > 'node-name', but forgot to update the help in qemu-storage-daemon.
> >
> > Fixes: 5f479a8dc086bfa42c9f94e9ab69962f256e207f
> > Signed-off-
On Wed, 30 Sep 2020 at 09:36, Michael S. Tsirkin wrote:
>
> The following changes since commit f142e4ede72853aaa7d306bc79b099caed45769b:
>
> tests/acpi: drop unnecessary files (2020-09-29 07:10:37 -0400)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/virt/kvm/mst/
On Wed, Sep 23, 2020 at 05:10:31PM +0100, Stefan Hajnoczi wrote:
> clang's C11 atomic_fetch_*() functions only take a C11 atomic type
> pointer argument. QEMU uses direct types (int, etc) and this causes a
> compiler error when a QEMU code calls these functions in a source file
> that also included
There are definitely resource allocation issues on the host in the
crashing case. The quirks currently enumerate the device BARs without
testing them, we identify a device and know what the resources should
be, which is why I think QEMU crashes. Are you able to test if the
patch below is sufficie
non-mangled patch
** Patch added: "patch for test"
https://bugs.launchpad.net/qemu/+bug/1897481/+attachment/5415693/+files/test-bar-size.diff
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1897481
On Wed, Sep 30, 2020 at 03:00:56PM +0530, Ani Sinha wrote:
>
> > >Â Â Â > Please let's not wait another week or so.
>
> > >
>
> > >
>
> > >
>
> > >
>
> > >
>
> > >Â Â Â OK it's not too much work but ... could you please add
> justification
>
> > >
>
On Wed, Sep 30, 2020 at 03:57:52PM +0100, Stefan Hajnoczi wrote:
> > Architecturally, I think we can have 3 processes:
> >
> >
> > VMM -- guest device emulation -- host backend
> >
> >
> > to me this looks like increasing our defence in depth strength,
> > as opposed to just shifting things aro
On Mon, Sep 28, 2020 at 11:35:17AM +0900, Dmitry Fomichev wrote:
> From: Niklas Cassel
>
> Define the structures and constants required to implement
> Namespace Types support.
>
> Signed-off-by: Niklas Cassel
> Signed-off-by: Dmitry Fomichev
> ---
> hw/block/nvme-ns.h | 2 ++
> hw/block/nv
Patchew URL: https://patchew.org/QEMU/20200930145523.71087-1-da...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200930145523.71087-1-da...@redhat.com
Subject: [PATCH v1 00/20] s390x/tcg: Implement Vector
On Wed, Sep 30, 2020 at 03:57:52PM +0100, Stefan Hajnoczi wrote:
> IMO "Inflight I/O tracking" is best placed into libvhost-user instead of
> the vhost-user protocol.
Oh I agree qemu does nothing with it. The reason we have it defined in
the spec is to facilitate compatibility across backends.
I h
Hi Thomas,
On 5/5/19 3:56 PM, Thomas Huth wrote:
> Add Kconfig dependencies for the highbank machine (and the midway
> machine).
> This patch is slightly based on earlier work by Ákos Kovács (i.e.
> his "hw/arm/Kconfig: Add ARM Kconfig" patch).
>
> Reviewed-by: Philippe Mathieu-Daudé
> Tested-by
On Wed, Sep 30, 2020 at 8:59 PM Michael S. Tsirkin wrote:
>
> On Wed, Sep 30, 2020 at 03:00:56PM +0530, Ani Sinha wrote:
> >
> > > > > Please let's not wait another week or so.
> >
> > > >
> >
> > > >
> >
> > > >
> >
> > > >
> >
> > > >
> >
> > > > OK it's not t
Hi Prasad,
Just my 2c as someone working on a downstream distro with Qemu...
On Friday, 2020-09-18 at 12:32:23 +0530, P J P wrote:
> Hello all,
>
> +-- On Wed, 16 Sep 2020, Stefan Hajnoczi wrote --+
> | I'm surprised the lack of encryption doesn't bother you. The security bug
> | reporting pro
On 30/09/20 17:28, Andrew Jones wrote:
> pvrdma_ring.h is an update-linux-headers.sh file. When running the
> script again we lose the atomic_ to qatomic_ renaming. I've hacked
> the script by adding
>
> -e 's/\batomic_read/qatomic_read/g;s/\batomic_set/qatomic_set/g'
>
> to the cp_portable() se
On Wed, Sep 30, 2020 at 2:56 AM zhaolichang wrote:
>
> I found that there are many spelling errors in the comments of
> qemu/target/riscv.
> I used spellcheck to check the spelling errors and found some errors in the
> folder.
>
> Signed-off-by: zhaolichang
Reviewed-by: Alistair Francis
Alis
With gcc 10 on Fedora32 I do get:
Compiling C object libblock.fa.p/qemu-io-cmds.c.o
In file included from /usr/include/stdio.h:867,
from /home/cborntra/REPOS/qemu/include/qemu/osdep.h:85,
from ../qemu-io-cmds.c:11:
In function ‘printf’,
inlined from ‘help_onel
make: *** [Makefile:121: config-host.mak] Error 1
[cborntra@m83lp52 qemu]$ make -C build/
make: Entering directory '/home/cborntra/REPOS/qemu/build'
Generating qemu-version.h with a meson_exe.py custom command
Compiling C object tools/virtiofsd/virtiofsd.p/passthrough_ll.c.o
../tools/virtiofsd/pass
gcc 10 from Fedora 32 gives me:
Compiling C object libblock.fa.p/nbd_server.c.o
../nbd/server.c: In function ‘nbd_co_client_start’:
../nbd/server.c:625:14: error: ‘namelen’ may be used uninitialized in this
function [-Werror=maybe-uninitialized]
625 | rc = nbd_negotiate_send_info(client
Fedora 32 gcc 10 seems to give false positives:
Compiling C object libblock.fa.p/block_vmdk.c.o
../block/vmdk.c: In function ‘vmdk_parse_extents’:
../block/vmdk.c:587:5: error: ‘extent’ may be used uninitialized in this
function [-Werror=maybe-uninitialized]
587 | g_free(extent->l1_table);
I might be wrong and some of these warnings could be correct, so some
review from the subject matter experts would be good.
Christian Borntraeger (4):
vmdk: fix maybe uninitialized warnings
nbd: silence maybe-uninitialized warnings
qemu-io-cmds: avoid gcc 10 warning
virtiofsd: avoid false
On 9/30/20 11:53 AM, zhaolichang wrote:
> I found that there are many spelling errors in the comments of
> qemu/target/arm.
> I used spellcheck to check the spelling errors and found some errors in the
> folder.
>
> Signed-off-by: zhaolichang
> ---
> target/arm/cpu.h | 2 +-
> target
On 30/09/2020 17.38, Philippe Mathieu-Daudé wrote:
> Hi Thomas,
>
> On 5/5/19 3:56 PM, Thomas Huth wrote:
>> Add Kconfig dependencies for the highbank machine (and the midway
>> machine).
>> This patch is slightly based on earlier work by Ákos Kovács (i.e.
>> his "hw/arm/Kconfig: Add ARM Kconfig"
On 9/30/20 11:53 AM, zhaolichang wrote:
> I found that there are many spelling errors in the comments of
> qemu/target/alpha.
> I used spellcheck to check the spelling errors and found some errors in the
> folder.
>
> Signed-off-by: zhaolichang
> ---
> target/alpha/cpu.h | 4 ++--
> targ
On 9/30/20 12:26 PM, Laurent Vivier wrote:
> Le 30/09/2020 à 11:53, zhaolichang a écrit :
>> I found that there are many spelling errors in the comments of
>> qemu/target/m68k.
>> I used spellcheck to check the spelling errors and found some errors in the
>> folder.
>>
>> Signed-off-by: zhaolicha
David Hildenbrand writes:
> Implementation inspired by minmax_floats(). Unfortuantely, we don't have
> any tests we can simply adjust/unlock.
>
> Cc: Aurelien Jarno
> Cc: Peter Maydell
> Cc: "Alex Bennée"
> Signed-off-by: David Hildenbrand
> ---
> fpu/softfloat.c | 100
On 9/30/20 6:10 PM, Thomas Huth wrote:
> On 30/09/2020 17.38, Philippe Mathieu-Daudé wrote:
>> Hi Thomas,
>>
>> On 5/5/19 3:56 PM, Thomas Huth wrote:
>>> Add Kconfig dependencies for the highbank machine (and the midway
>>> machine).
>>> This patch is slightly based on earlier work by Ákos Kovács (
Le 30/09/2020 à 18:03, Philippe Mathieu-Daudé a écrit :
> On 9/30/20 12:26 PM, Laurent Vivier wrote:
>> Le 30/09/2020 à 11:53, zhaolichang a écrit :
>>> I found that there are many spelling errors in the comments of
>>> qemu/target/m68k.
>>> I used spellcheck to check the spelling errors and found
HOST : Centos 7.7.1908
QEMU version : 2.10.1
GUEST : Concurrent DOS version 3.01
GEMS version : ?
Hi all,
I have an issue on a GEM environnement when I switch from GEM window to DOS
window, by pressing ctrl2, then ctrl1 to switch back to the GEM window (cf:
attached files).
The issue is not pre
On 9/30/20 5:58 PM, Christian Borntraeger wrote:
> With gcc 10 on Fedora32 I do get:
>
> Compiling C object libblock.fa.p/qemu-io-cmds.c.o
> In file included from /usr/include/stdio.h:867,
> from /home/cborntra/REPOS/qemu/include/qemu/osdep.h:85,
> from ../qemu-io
* Christian Borntraeger (borntrae...@de.ibm.com) wrote:
> With gcc 10 on Fedora32 I do get:
>
> Compiling C object libblock.fa.p/qemu-io-cmds.c.o
> In file included from /usr/include/stdio.h:867,
> from /home/cborntra/REPOS/qemu/include/qemu/osdep.h:85,
> from ../
* Christian Borntraeger (borntrae...@de.ibm.com) wrote:
> make: *** [Makefile:121: config-host.mak] Error 1
> [cborntra@m83lp52 qemu]$ make -C build/
> make: Entering directory '/home/cborntra/REPOS/qemu/build'
> Generating qemu-version.h with a meson_exe.py custom command
> Compiling C object tool
On Wed, 2020-09-30 at 17:58 +0200, Christian Borntraeger wrote:
> Fedora 32 gcc 10 seems to give false positives:
>
> Compiling C object libblock.fa.p/block_vmdk.c.o
> ../block/vmdk.c: In function ‘vmdk_parse_extents’:
> ../block/vmdk.c:587:5: error: ‘extent’ may be used uninitialized in
> this fu
In commit f68c01470b we restricted the query-uuid command to
machine code, but it is incorrect, as it is also used by the
tools. Therefore move this command again, but to block.json,
which is shared by machine code and tools.
Fixes: f68c01470b ("qapi: Restrict query-uuid command to machine code")
This is the third part of a series reducing user-mode
dependencies. By stripping out unused code, the build
and testing time is reduced (as is space used by objects).
Part 3:
- Extract code not related to user-mode from hw/core/qdev-properties.c
- Reduce user-mode QAPI generated files
Since v2:
-
Move properties specific to machines into a separate file.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
v3: Also move Reserved Region introduced in commit f78069253c
("qdev: Introduce DEFINE_PROP_RESERVED_REGION").
---
hw/core/qdev-properties-system.c | 687 +
Replace strtoul() by qemu_strtoul() so checkpatch.pl won't complain
if we move this code later.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
hw/core/qdev-properties.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/hw/c
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/qdev-properties.h | 1 +
hw/core/qdev-properties.c| 7 +++
2 files changed, 8 insertions(+)
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 528310bb22..4437450065 100644
--
A lot of QAPI generated code is never used by user-mode.
Split out qapi_system_modules and qapi_system_or_tools_modules
from the qapi_all_modules array. We now have 3 groups:
- always used
- use by system-mode or tools (usually by the block layer)
- only used by system-mode
Signed-off-by: Philipp
Only qemu-system-FOO and qemu-storage-daemon provide QMP
monitors, therefore such declarations and definitions are
irrelevant for user-mode emulation.
Restricting the x86-specific commands to machine-target.json
pulls less QAPI-generated code into user-mode.
Add a stub to satisfy linking in user-
While user-mode does not use peripherals (devices), it uses a
CPU which is a device.
In the next commit we will reduce the QAPI generated code for
user-mode. Since qdev.c calls qapi_event_send_device_deleted()
in device_finalize, let's add a stub for it.
Suggested-by: Paolo Bonzini
Reviewed-by: R
We will soon move this code, fix its style to avoid checkpatch.pl
to complain.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
hw/core/qdev-properties.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/core/qdev-properties.c b/hw/core/qd
The MACAddr structure contains an array of uint8_t. Previously
if a value was out of the [0..255] range, it was silently casted
and no input validation was done.
Replace strtol() by qemu_strtol() -- so checkpatch.pl won't
complain if we move this code later -- and return EINVAL if the
input is inva
We are going to split this file and reuse these static functions.
Add the local "qdev-prop-internal.h" header declaring them.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
hw/core/qdev-prop-internal.h | 19
hw/core/qdev-properties.c| 58 ++
We are going to split this file and reuse these static functions.
Declare them in the local "qdev-prop-internal.h" header.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
v3:
Also export qdev_propinfo_get_size32 introduced in commits
914e74cda9 ("qdev-properties: add siz
On Sun, Sep 27, 2020 at 9:22 AM Philippe Mathieu-Daudé wrote:
>
> On 9/27/20 3:47 PM, Alistair Francis wrote:
> > Currently we log interrupts and exceptions using the trace backed in
>
> s/backed/backend/
>
> > riscv_cpu_do_interrupt(). We also log execptions using the interrupt log
>
> Typo "exce
On Wed, Sep 30, 2020 at 06:49:38PM +0200, Philippe Mathieu-Daudé wrote:
> This is the third part of a series reducing user-mode
> dependencies. By stripping out unused code, the build
> and testing time is reduced (as is space used by objects).
I'm queueing patches 2-9 on machine-next. Thanks!
M
On Wed, Sep 30, 2020 at 06:49:48PM +0200, Philippe Mathieu-Daudé wrote:
> Only qemu-system-FOO and qemu-storage-daemon provide QMP
> monitors, therefore such declarations and definitions are
> irrelevant for user-mode emulation.
>
> Restricting the x86-specific commands to machine-target.json
> pu
Le 30/09/2020 à 17:16, Matus Kysel a écrit :
> accept4() returned wrong errno, that did not match current linux
>
> Signed-off-by: Matus Kysel
> ---
> linux-user/syscall.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
* Kevin Wolf (kw...@redhat.com) wrote:
> Am 30.09.2020 um 15:14 hat Markus Armbruster geschrieben:
> > Kevin Wolf writes:
> >
> > > Am 30.09.2020 um 11:26 hat Markus Armbruster geschrieben:
> > >> Kevin Wolf writes:
> > >>
> > >> > Am 28.09.2020 um 13:42 hat Markus Armbruster geschrieben:
> > >
On 9/30/20 10:58 AM, Christian Borntraeger wrote:
> gcc 10 from Fedora 32 gives me:
>
> Compiling C object libblock.fa.p/nbd_server.c.o
> ../nbd/server.c: In function ‘nbd_co_client_start’:
> ../nbd/server.c:625:14: error: ‘namelen’ may be used uninitialized in this
> function [-Werror=maybe-unin
On 9/30/20 4:47 AM, Markus Armbruster wrote:
John Snow writes:
I did not say "sphinx beautiful", just "sphinx compatible". They will
not throw errors when parsed and interpreted as ReST.
"Bang on the keyboard until Sphinx doesn't throw errors anymore" might
be good enough for a certain kind
On Wed, Sep 30, 2020 at 12:31:42AM -0400, John Snow wrote:
> _make_tree might receive a dict or some other type. Adding features
> information should arguably be performed by the caller at such a time
> when we know the type of the object and don't have to re-interrogate it.
>
> Signed-off-by: Joh
On 30/09/20 19:15, Eduardo Habkost wrote:
> On Wed, Sep 30, 2020 at 06:49:38PM +0200, Philippe Mathieu-Daudé wrote:
>> This is the third part of a series reducing user-mode
>> dependencies. By stripping out unused code, the build
>> and testing time is reduced (as is space used by objects).
> I'm q
On Wed, Sep 30, 2020 at 07:24:24PM +0200, Paolo Bonzini wrote:
> On 30/09/20 19:15, Eduardo Habkost wrote:
> > On Wed, Sep 30, 2020 at 06:49:38PM +0200, Philippe Mathieu-Daudé wrote:
> >> This is the third part of a series reducing user-mode
> >> dependencies. By stripping out unused code, the buil
On 9/30/20 4:47 AM, Markus Armbruster wrote:
Sadly, the fact that start_if() and end_if() are functions isn't
immediately obvious anymore.
I've seen :func:`start_if` elsewhere. Is this something we should or
want to use?
Looks like `start_if()` works just fine too. If you are hard-set in
wan
On 30/09/20 16:31, Maxim Levitsky wrote:
>> +
>> +qatomic_set(&dev->realized, value);
>> +/*
>> + * Ensure that concurrent users see this update prior to
>> + * any other changes done by unrealize.
>> + */
>> +smp_wmb();
>
> I''l probably never fully
On 30/09/20 16:32, Maxim Levitsky wrote:
>> Compared to Maxim's patch, I am avoiding the extra argument
>> to do_scsi_device_find by moving the RCU_READ_LOCK_GUARD()
>> out of do_scsi_device_find itself.
> Which is a good idea, although my mindset was like, I got a device,
> lets jus
On 28/09/20 11:30, Stefan Hajnoczi wrote:
>> +bool (*check_address)(BusState *bus, DeviceState *dev, Error **errp);
> Please document this function.
I will add this:
/*
* Return whether the device can be added to @bus,
* based on the address that was set (via device
Fill gpex config struct from memory map, then call the new
acpi_dsdt_add_gpex helper function. No functional change.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Michael S. Tsirkin
Message-id: 20200928104256.9241-4-kra...@redhat.com
---
hw/arm/virt-acpi-build.c | 175 ++---
Signed-off-by: Gerd Hoffmann
Reviewed-by: Michael S. Tsirkin
Message-id: 20200928104256.9241-8-kra...@redhat.com
---
tests/qtest/bios-tables-test-allowed-diff.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-al
... into new test_acpi_microvm_prepare helper
Signed-off-by: Gerd Hoffmann
Reviewed-by: Michael S. Tsirkin
Message-id: 20200928104256.9241-10-kra...@redhat.com
---
tests/qtest/bios-tables-test.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/tests/qtest/bio
Signed-off-by: Gerd Hoffmann
Reviewed-by: Michael S. Tsirkin
Message-id: 20200928104256.9241-13-kra...@redhat.com
---
tests/qtest/bios-tables-test-allowed-diff.h | 5 -
tests/data/acpi/microvm/DSDT.pcie | Bin 0 -> 3023 bytes
tests/data/acpi/virt/DSDT | Bin 5200
201 - 300 of 387 matches
Mail list logo
