Re: [PATCH RFC 06/14] mips/: fix some comment spelling errors

On 9/30/20 11:53 AM, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/mips. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang > --- > target/mips/internal.h | 2 +- >

Re: [PATCH RFC 08/14] m68k/: fix some comment spelling errors

Le 30/09/2020 à 11:53, zhaolichang a écrit : > I found that there are many spelling errors in the comments of > qemu/target/m68k. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang > --- > target/m68k/translate.c | 16

Re: [PATCH] hw/arm: Restrict APEI tables generation to the 'virt' machine

On 9/30/20 7:08 AM, Dongjiu Geng wrote: > On 2020/9/29 20:56, Philippe Mathieu-Daudé wrote: >> As only the Virt machine uses the RAS Virtualization feature (see >> commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option"), >> restrict the APEI tables generation code to the virt machine. >

Re: use of 'apt' in scripting in our dockerfiles provokes warnings

On 9/30/20 12:33 PM, Peter Maydell wrote: > While processing a recent pullreq which updated the dockerfile > dependencies and thus provoked a rebuild, I noticed that we > use the 'apt' command in ways that provoke a warning: > > #7 0.789 WARNING: apt does not have a stable CLI interface. Use with

Re: use of 'apt' in scripting in our dockerfiles provokes warnings

On Wed, Sep 30, 2020 at 11:33:21AM +0100, Peter Maydell wrote: > While processing a recent pullreq which updated the dockerfile > dependencies and thus provoked a rebuild, I noticed that we > use the 'apt' command in ways that provoke a warning: > > #7 0.789 WARNING: apt does not have a stable CLI

Re: [PATCH] hw/arm: Restrict APEI tables generation to the 'virt' machine

On Tue, Sep 29, 2020 at 02:56:09PM +0200, Philippe Mathieu-Daudé wrote: > As only the Virt machine uses the RAS Virtualization feature (see > commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option"), > restrict the APEI tables generation code to the virt machine. > > Fixes: aa16508f1d ("

Re: [PATCH v1 03/15] meson: move libmpathpersist test

Paolo Bonzini writes: > On 25/09/20 17:40, Alex Bennée wrote: >> From: Paolo Bonzini >> >> This is the first compiler/linker test that has been moved to Meson. >> Add more section headings to keep things clearer. >> >> [thuth: Add check for mpathpersist.found() before showing >> mpathpersis

Re: [PATCH RFC 02/14] ppc/: fix some comment spelling errors

On Wednesday, 2020-09-30 at 17:53:09 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/ppc. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson

Re: [PATCH RFC 03/14] riscv/: fix some comment spelling errors

On Wednesday, 2020-09-30 at 17:53:10 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/riscv. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson

Re: [PATCH RFC 06/14] mips/: fix some comment spelling errors

On Wednesday, 2020-09-30 at 17:53:13 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/mips. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson

Re: [PATCH RFC 01/14] cris/: fix some comment spelling errors

On Wednesday, 2020-09-30 at 17:53:08 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/cris. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang With the correction below...

Re: [PATCH RFC 05/14] tricore/: fix some comment spelling errors

On Wednesday, 2020-09-30 at 17:53:12 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/tricore. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmonds

Re: [PATCH RFC 09/14] sh4/: fix some comment spelling errors

On Wednesday, 2020-09-30 at 17:53:16 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/sh4. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson

Re: [PATCH RFC 08/14] m68k/: fix some comment spelling errors

On Wednesday, 2020-09-30 at 17:53:15 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/m68k. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson

Re: [PATCH RFC 07/14] s390x/: fix some comment spelling errors

On Wednesday, 2020-09-30 at 17:53:14 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/s390x. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson

Re: [PATCH RFC 04/14] rx/: fix some comment spelling errors

On Wednesday, 2020-09-30 at 17:53:11 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of qemu/target/rx. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson > -

Re: [PATCH RFC 10/14] i386/: fix some comment spelling errors

On Wednesday, 2020-09-30 at 17:53:17 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/i386. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson

Re: [PATCH v1 03/15] meson: move libmpathpersist test

On 30/09/2020 12.51, Alex Bennée wrote: > > Paolo Bonzini writes: > >> On 25/09/20 17:40, Alex Bennée wrote: >>> From: Paolo Bonzini >>> >>> This is the first compiler/linker test that has been moved to Meson. >>> Add more section headings to keep things clearer. >>> >>> [thuth: Add check for m

Re: [PATCH RFC 13/14] alpha/: fix some comment spelling errors

On Wednesday, 2020-09-30 at 17:53:20 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/alpha. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson

Re: [PATCH RFC 11/14] avr/: fix some comment spelling errors

On Wednesday, 2020-09-30 at 17:53:18 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/avr. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson

Re: [PATCH RFC 14/14] target/: fix some comment spelling errors

On Wednesday, 2020-09-30 at 17:53:21 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of qemu/target. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson > ---

Re: [PATCH RFC 12/14] arm/: fix some comment spelling errors

On Wednesday, 2020-09-30 at 17:53:19 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/arm. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson

Re: [PATCH v4 36/46] qapi/introspect.py: assert obj is a dict when features are given

On Wed, Sep 30, 2020 at 12:31:40AM -0400, John Snow wrote: > This is necessary to keep mypy passing in the next patch when we add > preliminary type hints. It will be removed shortly. > > Signed-off-by: John Snow Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH v4 30/46] qapi/gen.py: Fix edge-case of _is_user_module

On Wed, Sep 30, 2020 at 12:31:34AM -0400, John Snow wrote: > The edge case is that if the name is '', this expression returns a > string instead of a bool, which violates our declared type. > > Signed-off-by: John Snow > Reviewed-by: Cleber Rosa Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH] hw/arm: Restrict APEI tables generation to the 'virt' machine

On 2020/9/30 18:35, Philippe Mathieu-Daudé wrote: > On 9/30/20 7:08 AM, Dongjiu Geng wrote: >> On 2020/9/29 20:56, Philippe Mathieu-Daudé wrote: >>> As only the Virt machine uses the RAS Virtualization feature (see >>> commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option"), >>> restric

[Bug 1881231] Re: colo: Can not recover colo after svm failover twice

I think Lukas's fix: block/quorum.c: stable children names was merged a few days ago as 5eb9a3c7b0571562c0289747690e25e6855bc96f Can someone confirm that helped? ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- de

Re: [PATCH v1 03/15] meson: move libmpathpersist test

Thomas Huth writes: > On 30/09/2020 12.51, Alex Bennée wrote: >> >> Paolo Bonzini writes: >> >>> On 25/09/20 17:40, Alex Bennée wrote: From: Paolo Bonzini This is the first compiler/linker test that has been moved to Meson. Add more section headings to keep things cleare

[Bug 1880066] Re: Microphone input dies in guest when switching evdev input

I have this exact issue with any VM using Spice audio redirection. My setup has Linux (Fedora 32) as host and guest. The Guest microphone freezes mid way through most video conferences, which is quite a pain. I see the exact same error messages: A bug was just triggered in audio_get_avail Context

Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

Le 14/09/2020 à 12:24, Philippe Mathieu-Daudé a écrit : > As the 'io_base' argument of m48t59_init() is unused (set to 0), > remove it to simplify. > To create a device on the ISA bus, m48t59_init_isa() is the > preferred function to use. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include

Re: [PATCH 1/2] qemu-img-cmds.hx: Update comment that mentions Texinfo

Le 29/09/2020 à 09:58, Markus Armbruster a écrit : > Missed in 3c95fdef94 "Update comments in .hx files that mention > Texinfo". > > Signed-off-by: Markus Armbruster > --- > qemu-img-cmds.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-img-cmds.hx b/qemu-img-cmd

Re: [PATCH v3 0/5] hw/arm/virt: Introduce kvm-steal-time

On Tue, Sep 29, 2020 at 04:47:33PM +0200, Andrew Jones wrote: > > Hi Peter, Eric, and other interested parties, > > Here's a gentle ping for reviewers. Thanks for the review Eric! I'll send a Linux header update patch and a rebase of this series with R-b's. drew > > Thanks, > drew > > On Wed

[PATCH v4 4/6] meson: add spice_headers dependency.

Used for files which (with CONFIG_SPICE=y) depend on spice header files to pick up some enum, but which do not depend on on the actual spice shared library. Signed-off-by: Gerd Hoffmann --- audio/meson.build | 2 +- meson.build | 2 ++ monitor/meson.build | 2 +- 3 files changed, 4 ins

[PATCH v4 1/6] ui/spice-app: don't use qemu_chr_open_spice_port directly

Save the parent object's open function pointer in the (new) VCChardevClass struct instead before overwriting it, so we can look it up when needed. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé --- ui/spice-app.c | 17 + 1 file changed, 13 insertions(+), 4 dele

[PATCH v4 2/6] chardev/spice: make qemu_chr_open_spice_port static

Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé --- include/chardev/spice.h | 3 --- chardev/spice.c | 8 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/include/chardev/spice.h b/include/chardev/spice.h index 99f26aedde54..1115502cdfbd 100644 ---

[PATCH v4 5/6] meson: add spice dependency to core spice source files.

Right now it happens to work by pure luck because the spice chardevs add the spice dependency to the softmmu source set. That'll change though once we start building spice chardevs as module, so lets fix it properly. Signed-off-by: Gerd Hoffmann --- ui/meson.build | 2 +- 1 file changed, 1 inse

[PATCH v4 6/6] chardev/spice: build spice chardevs as module

Signed-off-by: Gerd Hoffmann --- util/module.c | 2 ++ chardev/meson.build | 7 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/util/module.c b/util/module.c index 34772e7d87eb..86781c207f7d 100644 --- a/util/module.c +++ b/util/module.c @@ -268,6 +268,8 @@ static stru

Re: [PATCH 2/2] target/i386/cpu: Update comment that mentions Texinfo

Le 29/09/2020 à 09:58, Markus Armbruster a écrit : > Missed in commit 41fba1618b "docs/system: convert the documentation of > deprecated features to rST." > > Signed-off-by: Markus Armbruster > --- > target/i386/cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ta

Re: [PATCH] hw/arm: Restrict APEI tables generation to the 'virt' machine

On 9/30/20 1:05 PM, Dongjiu Geng wrote: > > On 2020/9/30 18:35, Philippe Mathieu-Daudé wrote: >> On 9/30/20 7:08 AM, Dongjiu Geng wrote: >>> On 2020/9/29 20:56, Philippe Mathieu-Daudé wrote: As only the Virt machine uses the RAS Virtualization feature (see commit 2afa8c8519: "hw/arm/virt

[PATCH v4 3/6] chardev/spice: simplify chardev setup

Initialize spice before chardevs. That allows to register the spice chardevs directly in the init function and removes the need to maintain a linked list of chardevs just for registration. Signed-off-by: Gerd Hoffmann --- include/chardev/spice.h | 1 - include/ui/qemu-spice.h | 1 - chardev/s

[PATCH v4 0/6] build spice chardevs as module

v3: - fix spice-app - init objects before spice - meson cleanup v4: - rebase to latestg master, adapt to qom changes. - add patches to fix modular builds. - pick up review tags. Gerd Hoffmann (6): ui/spice-app: don't use qemu_chr_open_spice_port directly chardev/spice: make qemu_chr_open

Re: [PATCH v7 06/13] qmp: Call monitor_set_cur() only in qmp_dispatch()

Am 30.09.2020 um 11:26 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 28.09.2020 um 13:42 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > Am 14.09.2020 um 17:10 hat Markus Armbruster geschrieben: > >> >> Kevin Wolf writes: > >> >> > >> >> > The correct

Re: [PATCH] xen-bus: reduce scope of backend watch

On Wed, Sep 23, 2020 at 04:57:31PM +0100, Paul Durrant wrote: > From: Paul Durrant > > Currently a single watch on /local/domain/X/backend is registered by each > QEMU process running in service domain X (where X is usually 0). The purpose > of this watch is to ensure that QEMU is notified when t

Re: About 'qemu-security' mailing list

+-- On Fri, 18 Sep 2020, P J P wrote --+ | +-- On Wed, 16 Sep 2020, Stefan Hajnoczi wrote --+ | | Do downstream maintainers want to know about potential security bug reports | | that have not been triaged yet? | | | | Maybe there should there be a pre-announce list for bugs that have been | | tr

[Bug 1897481] Re: qemu crashes with VGA pass-through, e-GPU, nvidia 1060

dmesg: [0.00] microcode: microcode updated early to revision 0x21, date = 2019-02-13 [0.00] Linux version 5.8.6-1-MANJARO (builder@db927223e331) (gcc (GCC) 10.2.0, GNU ld (GNU Binutils) 2.35) #1 SMP PREEMPT Thu Sep 3 14:19:36 UTC 2020 [0.00] Command line: BOOT_IMAGE=/boot

[PATCH v2 3/5] nbd: Simplify meta-context parsing

We had a premature optimization of trying to read as little from the wire as possible while handling NBD_OPT_SET_META_CONTEXT in phases. But in reality, we HAVE to read the entire string from the client before we can get to the next command, and it is easier to just read it all at once than it is t

[PATCH v2 0/5] Exposing backing-chain allocation over NBD

v1 was here: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg09623.htm l Based-on: <20200924152717.287415-1-kw...@redhat.com> (block/export: Add infrastructure and QAPI for block exports) Also available at: https://repo.or.cz/qemu/ericb.git/shortlog/refs/tags/nbd-alloc-depth-v2 Since th

[PATCH v2 2/5] nbd/server: Reject embedded NUL in NBD strings

The NBD spec is clear that any string sent from the client must not contain embedded NUL characters. If the client passes "a\0", we should reject that option request rather than act on "a". Testing this is not possible with a compliant client, but I was able to use gdb to coerce libnbd into tempo

[PATCH v2 1/5] qemu-nbd: Honor SIGINT and SIGHUP

Honoring just SIGTERM on Linux is too weak; we also want to handle other common signals, and do so even on BSD. Why? Because at least 'qemu-nbd -B bitmap' needs a chance to clean up the in-use bit on bitmaps when the server is shut down via a signal. See also: http://bugzilla.redhat.com/1883608

[PATCH v2 4/5] nbd: Add new qemu:allocation-depth metacontext

'qemu-img map' provides a way to determine which extents of an image come from the top layer vs. inherited from a backing chain. This is useful information worth exposing over NBD. There is a proposal to add a QMP command block-dirty-bitmap-populate which can create a dirty bitmap that reflects a

Re: [PATCH] job: delete job_{lock,unlock} functions and replace them with lock guard

On Tue, 2020-09-29 at 14:04 -0400, John Snow wrote: > On 9/29/20 9:42 AM, Elena Afanasova wrote: > > Signed-off-by: Elena Afanasova > > Hi, can I have a commit message here, please? > > > --- > > job.c | 46 +- > > 1 file changed, 17 insertions(+),

[PATCH v2 5/5] nbd: Add 'qemu-nbd -A' to expose allocation depth

Allow the server to expose an additional metacontext to be requested by savvy clients. qemu-nbd adds a new option -A to expose the qemu:allocation-depth metacontext through NBD_CMD_BLOCK_STATUS; this can also be set via QMP when using block-export-add. qemu as client can be hacked into viewing th

[Bug 1897481] Re: qemu crashes with VGA pass-through, e-GPU, nvidia 1060

Thank you Alex for answering me. It seems, I've got it working, if I boot the host with the connected GPU from the very beginning. Previously, I tried hotplug and it crashes. So previously I had: 1. enable the host 2. enable GPU 3. connect the cable And this time I tried: 1. enable GP

[Bug 1897481] Re: qemu crashes with VGA pass-through, e-GPU, nvidia 1060

What's more interesting, it doesn't crash if I hotplug GPU after it was boot with it. So if I do 1. enable GPU 2. connect the cord 3. enable the host 4. run qemu (I'm not sure, if it's mandatory) 5. disable cord 6. disable GPU 7. enable GPU 8. enable cord 9. run qemu again qe

[PATCH v2 3/4] qom: Add user_creatable_print_help_from_qdict()

This adds a function that, given a QDict of non-help options, prints help for user creatable objects. Signed-off-by: Kevin Wolf --- include/qom/object_interfaces.h | 9 + qom/object_interfaces.c | 9 + 2 files changed, 18 insertions(+) diff --git a/include/qom/object_int

[PATCH v2 2/4] qom: Factor out helpers from user_creatable_print_help()

This creates separate helper functions for printing a list of user creatable object types and for printing a list of properties of a given type. This allows using these parts without having a QemuOpts. Signed-off-by: Kevin Wolf --- qom/object_interfaces.c | 90 ---

[PATCH v2 0/4] qemu-storage-daemon: Remove QemuOpts from --object parser

This replaces the QemuOpts-based help code for --object in the storage daemon with code based on the keyval parser. v2: - Fixed double comma by reusing the existing key and value parsers [Eric] - More tests to cover the additional cases Kevin Wolf (4): keyval: Parse help options qom: Factor o

[PATCH v2 1/4] keyval: Parse help options

This adds a new parameter 'help' to keyval_parse() that enables parsing of help options. If NULL is passed, the function behaves the same as before. But if a bool pointer is given, it contains the information whether an option "help" without value was given (which would otherwise either result in a

Re: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

On Mon, Sep 28, 2020 at 11:35:19AM +0900, Dmitry Fomichev wrote: > From: Niklas Cassel > > Namespace Types introduce a new command set, "I/O Command Sets", > that allows the host to retrieve the command sets associated with > a namespace. Introduce support for the command set and enable > detecti

[PATCH v2 4/4] qemu-storage-daemon: Remove QemuOpts from --object parser

The command line parser for --object parses the input twice: Once into QemuOpts just for detecting help options, and then again into a QDict using the keyval parser for actually creating the object. Now that the keyval parser can also detect help options, we can simplify this and remove the QemuOp

Re: [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig

On 9/30/20 12:43 AM, Philippe Mathieu-Daudé wrote: > Extend the generic Meson script to pass optional target Kconfig > file to the minikconf script. > > Signed-off-by: Philippe Mathieu-Daudé > --- > We could use fs.exists() but is_file() is more specific > (can not be a directory). > > Cc: Paolo

Re: use of 'apt' in scripting in our dockerfiles provokes warnings

On Wed, 30 Sep 2020 at 11:43, Philippe Mathieu-Daudé wrote: > On 9/30/20 12:33 PM, Peter Maydell wrote: > > Also, any idea what this error is about? > > > > #4 importing cache manifest from > > registry.gitlab.com/qemu-project/qemu/qemu... > > #4 digest: > > sha256:815fb44b573ac7520d148d9b2

Re: [PATCH 1/4] keyval: Parse help options

Am 29.09.2020 um 19:46 hat Eric Blake geschrieben: > On 9/29/20 12:26 PM, Kevin Wolf wrote: > > This adds a new parameter 'help' to keyval_parse() that enables parsing > > of help options. If NULL is passed, the function behaves the same as > > before. But if a bool pointer is given, it contains th

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

On 30/09/20 09:51, Marc-André Lureau wrote: > Hi > > On Wed, Sep 30, 2020 at 11:34 AM Markus Armbruster > wrote: > > Marc-André Lureau > writes: > > > Hi > > > > On Tue, Sep 29, 2020 at 3:01 PM Paolo Bonzini

Re: [PATCH v7 06/13] qmp: Call monitor_set_cur() only in qmp_dispatch()

Kevin Wolf writes: > Am 30.09.2020 um 11:26 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 28.09.2020 um 13:42 hat Markus Armbruster geschrieben: >> >> Kevin Wolf writes: >> >> >> >> > Am 14.09.2020 um 17:10 hat Markus Armbruster geschrieben: >> >> >> Kevin Wolf writes:

Re: [PATCH v1 03/15] meson: move libmpathpersist test

On 30/09/20 12:54, Thomas Huth wrote: > On 30/09/2020 12.51, Alex Bennée wrote: >> >> Paolo Bonzini writes: >> >>> On 25/09/20 17:40, Alex Bennée wrote: From: Paolo Bonzini This is the first compiler/linker test that has been moved to Meson. Add more section headings to keep t

Re: [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig

On 30/09/20 14:50, Claudio Fontana wrote: > On 9/30/20 12:43 AM, Philippe Mathieu-Daudé wrote: >> Extend the generic Meson script to pass optional target Kconfig >> file to the minikconf script. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> We could use fs.exists() but is_file() is more sp

Re: [PATCH] job: delete job_{lock, unlock} functions and replace them with lock guard

On 30/09/20 14:15, Elena Afanasova wrote: >>> +WITH_QEMU_LOCK_GUARD(&job_mutex) { >>> +if (ns != -1) { >>> +timer_mod(&job->sleep_timer, ns); >>> +} >>> +job->busy = false; >>> +job_event_idle(job); >> Is this new macro safe to use in a coroutine cont

Re: [PATCH] tests/acceptance: Add a 'virt_kvm' test using the GICv3

On Tue, Sep 29, 2020 at 7:49 PM Philippe Mathieu-Daudé wrote: > > The current 'virt_kvm' test is restricted to GICv2, but can also > work with a GICv3. Duplicate it but add a GICv3 test which can be > tested on some hardware. Fair enough! :) > > Noticed while running: > > $ avocado --show=app r

[PATCH] block/nvme: Add driver statistics for access alignment and hw errors

Keep statistics of some hardware errors, and number of aligned/unaligned I/O accesses. QMP example booting a full RHEL 8.3 aarch64 guest: { "execute": "query-blockstats" } { "return": [ { "device": "", "node-name": "drive0", "stats": {

Re: [PATCH v2 1/4] keyval: Parse help options

On 9/30/20 7:45 AM, Kevin Wolf wrote: > This adds a new parameter 'help' to keyval_parse() that enables parsing > of help options. If NULL is passed, the function behaves the same as > before. But if a bool pointer is given, it contains the information > whether an option "help" without value was g

[PATCH RFC v2 00/19] i386: KVM: expand Hyper-V features early

Changes since RFCv1: - Took a slightly differenet approach, instead of adding all missing Hyper-V feature leaves to feature_word_info[] remove the existing ones from there. The logic for handling them is very different and some of these leaves are not actually 'feature leaves'. See "i386: drop

[PATCH] qemu-storage-daemon: Fix help line for --export

Commit 5f479a8d renamed the 'device' option of --export into 'node-name', but forgot to update the help in qemu-storage-daemon. Fixes: 5f479a8dc086bfa42c9f94e9ab69962f256e207f Signed-off-by: Kevin Wolf --- storage-daemon/qemu-storage-daemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH RFC v2 01/19] WIP: update linux/headers

KVM_CAP_SYS_HYPERV_CPUID definition is needed for this series. Signed-off-by: Vitaly Kuznetsov --- linux-headers/asm-x86/kvm.h | 20 linux-headers/linux/kvm.h | 27 --- 2 files changed, 44 insertions(+), 3 deletions(-) diff --git a/linux-headers/as

[PATCH RFC v2 02/19] i386: fill in FEAT_HYPERV_EDX from edx instead of eax

There was a typo which went unnoticed. Fixes: e48ddcc6ce13 ("i386/kvm: implement 'hv-passthrough' mode") Signed-off-by: Vitaly Kuznetsov --- - Similar fix had been submitted at:

[PATCH RFC v2 03/19] i386: drop x86_cpu_get_supported_feature_word() forward declaration

We only use x86_cpu_get_supported_feature_word() after its implementation, no forward declaration needed. Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 3ffd877dd51f..ca713bef5eaf 100644 ---

[PATCH RFC v2 08/19] i386: keep hyperv_vendor string up-to-date

When cpu->hyperv_vendor is not set manually we default to "Microsoft Hv" and in 'hv_passthrough' mode we get the information from the host. This information is stored in cpu->hyperv_vendor_id[] array but we don't update cpu->hyperv_vendor string so e.g. QMP's query-cpu-model-expansion output is inc

[PATCH RFC v2 05/19] i386: move hyperv_interface_id initialization to x86_cpu_realizefn()

As a preparation to expanding Hyper-V CPU features early, move hyperv_interface_id initialization to x86_cpu_realizefn(). Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 6 ++ target/i386/cpu.h | 1 + target/i386/kvm.c | 18 -- 3 files changed, 19 insertions(+), 6 d

[PATCH RFC v2 04/19] i386: move hyperv_vendor_id initialization to x86_cpu_realizefn()

As a preparation to expanding Hyper-V CPU features early, move hyperv_vendor_id initialization to x86_cpu_realizefn(). Introduce x86_cpu_hyperv_realize() to not not pollute x86_cpu_realizefn() itself. Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 23 ++- target/i386

[PATCH RFC v2 11/19] i386: introduce hv_cpuid_cache

Just like with cpuid_cache, it makes no sense to call KVM_GET_SUPPORTED_HV_CPUID more than once and instead of (ab)using env->features[] and/or trying to keep all the code in one place, it is better to introduce persistent hv_cpuid_cache and hv_cpuid_get_host() accessor to it. Note, hv_cpuid_get_f

[PATCH RFC v2 10/19] i386: always fill Hyper-V CPUID feature leaves from X86CPU data

We have all the required data in X86CPU already and as we are about to split hyperv_handle_properties() into hyperv_expand_features()/ hyperv_fill_cpuids() we can remove the blind copy. The functional change is that QEMU won't pass CPUID leaves it doesn't currently know about to the guest but argua

[PATCH RFC v2 12/19] i386: drop FEAT_HYPERV feature leaves

Hyper-V feature leaves are weird. We have some of them in feature_word_info[] array but we don't use feature_word_info magic to enable them. Neither do we use feature_dependencies[] mechanism to validate the configuration as it doesn't allign well with Hyper-V's many-to-many dependency chains. Some

[PATCH RFC v2 06/19] i386: move hyperv_version_id initialization to x86_cpu_realizefn()

As a preparation to expanding Hyper-V CPU features early, move hyperv_version_id initialization to x86_cpu_realizefn(). Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 4 target/i386/cpu.h | 1 + target/i386/kvm.c | 14 -- 3 files changed, 17 insertions(+), 2 deletions

[PATCH RFC v2 14/19] i386: move eVMCS enablement to hyperv_init_vcpu()

hyperv_expand_features() will be called before we create vCPU so evmcs enablement should go away. hyperv_init_vcpu() looks like the right place. Signed-off-by: Vitaly Kuznetsov --- target/i386/kvm.c | 60 +-- 1 file changed, 37 insertions(+), 23 deleti

[PATCH RFC v2 09/19] i386: invert hyperv_spinlock_attempts setting logic with hv_passthrough

There is no need to have this special case: like all other Hyper-V enlightenments we can just use kernel's supplied value in hv_passthrough mode. Signed-off-by: Vitaly Kuznetsov --- target/i386/kvm.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target/i386/kvm.c b/tar

[PATCH RFC v2 16/19] i386: adjust the expected KVM_GET_SUPPORTED_HV_CPUID array size

SYNDBG leaves were recently (Linux-5.8) added to KVM but we haven't updated the expected size of KVM_GET_SUPPORTED_HV_CPUID output in KVM so we now make serveral tries before succeeding. Update the default. Signed-off-by: Vitaly Kuznetsov --- target/i386/kvm.c | 3 ++- 1 file changed, 2 insertio

[PATCH RFC v2 07/19] i386: move hyperv_limits initialization to x86_cpu_realizefn()

As a preparation to expanding Hyper-V CPU features early, move hyperv_limits initialization to x86_cpu_realizefn(). Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 5 + target/i386/cpu.h | 1 + target/i386/kvm.c | 13 - 3 files changed, 18 insertions(+), 1 deletion(-)

[PATCH RFC v2 19/19] i386: expand Hyper-V features during CPU feature expansion time

To make Hyper-V features appear in e.g. QMP query-cpu-model-expansion we need to expand and set the corresponding CPUID leaves early. Modify x86_cpu_get_supported_feature_word() to call newly intoduced Hyper-V specific kvm_hv_get_supported_cpuid() instead of kvm_arch_get_supported_cpuid(). We can't

[PATCH RFC v2 15/19] i386: switch hyperv_expand_features() to using error_setg()

Use standard error_setg() mechanism in hyperv_expand_features(). Signed-off-by: Vitaly Kuznetsov --- target/i386/kvm.c | 101 -- 1 file changed, 61 insertions(+), 40 deletions(-) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 181e034da701..3

[PATCH RFC v2 13/19] i386: split hyperv_handle_properties() into hyperv_expand_features()/hyperv_fill_cpuids()

The intention is to call hyperv_expand_features() early, before vCPUs are created and use the acquired data later when we set guest visible CPUID data. Signed-off-by: Vitaly Kuznetsov --- target/i386/kvm.c | 34 -- 1 file changed, 24 insertions(+), 10 deletions(-)

[PATCH RFC v2 17/19] i386: prefer system KVM_GET_SUPPORTED_HV_CPUID ioctl over vCPU's one

KVM_GET_SUPPORTED_HV_CPUID was made a system wide ioctl which can be called prior to creating vCPUs and we are going to use that to expand Hyper-V cpu features early. Use it when it is supported by KVM. Signed-off-by: Vitaly Kuznetsov --- target/i386/kvm.c | 17 + 1 file changed,

Re: [PATCH v2 2/4] qom: Factor out helpers from user_creatable_print_help()

On 9/30/20 7:45 AM, Kevin Wolf wrote: > This creates separate helper functions for printing a list of user > creatable object types and for printing a list of properties of a given > type. This allows using these parts without having a QemuOpts. > > Signed-off-by: Kevin Wolf > --- > qom/object_i

[PATCH RFC v2 18/19] i386: use global kvm_state in hyperv_enabled() check

There is no need to use vCPU-specific kvm state in hyperv_enabled() check and we need to do that when feature expansion happens early, before vCPU specific KVM state is created. Signed-off-by: Vitaly Kuznetsov --- target/i386/kvm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --

Re: [PATCH v2 3/4] qom: Add user_creatable_print_help_from_qdict()

On 9/30/20 7:45 AM, Kevin Wolf wrote: > This adds a function that, given a QDict of non-help options, prints > help for user creatable objects. > > Signed-off-by: Kevin Wolf > --- > include/qom/object_interfaces.h | 9 + > qom/object_interfaces.c | 9 + > 2 files changed,

Re: [PATCH 1/4] keyval: Parse help options

On 9/30/20 8:04 AM, Kevin Wolf wrote: > Am 29.09.2020 um 19:46 hat Eric Blake geschrieben: >> On 9/29/20 12:26 PM, Kevin Wolf wrote: >>> This adds a new parameter 'help' to keyval_parse() that enables parsing >>> of help options. If NULL is passed, the function behaves the same as >>> before. But i

Re: [PATCH v7 06/13] qmp: Call monitor_set_cur() only in qmp_dispatch()

Am 30.09.2020 um 15:14 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 30.09.2020 um 11:26 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > Am 28.09.2020 um 13:42 hat Markus Armbruster geschrieben: > >> >> Kevin Wolf writes: > >> >> > >> >> > Am 14.09.20

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

On 30/09/20 11:15, Marc-André Lureau wrote: > Why BorrowedMutPointer provides both *const P and *mut P ? The *const P > conversion seems overlapping with BorrowedPointer. "&mut T" implements Borrow so it seemed obvious to have as_ptr in BorrowedMutPointer too. Though I certainly should implement

Re: [PATCH] qemu-storage-daemon: Fix help line for --export

On 9/30/20 8:39 AM, Kevin Wolf wrote: > Commit 5f479a8d renamed the 'device' option of --export into > 'node-name', but forgot to update the help in qemu-storage-daemon. > > Fixes: 5f479a8dc086bfa42c9f94e9ab69962f256e207f > Signed-off-by: Kevin Wolf > --- > storage-daemon/qemu-storage-daemon.c |

Re: [PATCH v2 4/4] qemu-storage-daemon: Remove QemuOpts from --object parser

On 9/30/20 7:45 AM, Kevin Wolf wrote: > The command line parser for --object parses the input twice: Once into > QemuOpts just for detecting help options, and then again into a QDict > using the keyval parser for actually creating the object. > > Now that the keyval parser can also detect help opt

Re: [PATCH v5 06/14] hw/block/nvme: Add support for active/inactive namespaces

On Mon, Sep 28, 2020 at 11:35:20AM +0900, Dmitry Fomichev wrote: > From: Niklas Cassel > > In NVMe, a namespace is active if it exists and is attached to the > controller. > > CAP.CSS (together with the I/O Command Set data structure) defines what > command sets are supported by the controller.

Re: [PATCH v4] introduce vfio-user protocol specification

On Tue, Sep 29, 2020 at 09:21:54AM -0700, John G Johnson wrote: > > On Sep 29, 2020, at 3:37 AM, Stefan Hajnoczi wrote: > > > > On Mon, Sep 28, 2020 at 09:58:37AM +, Thanos Makatos wrote: > >>> It should be accompanied by a test in tests/. PCI-level testing APIS for > >>> BARs, configuration

<    1   2   3   4   >