RE: [PATCH v10 7/7] Versal: Connect DWC3 controller with virt-versal

2020-09-29 Thread Sai Pavan Boddu
Hi Gerd, > -Original Message- > From: Gerd Hoffmann > Sent: Monday, September 28, 2020 6:45 PM > To: Edgar Iglesias > Cc: Sai Pavan Boddu ; Peter Maydell > ; Markus Armbruster ; > 'Marc-André Lureau' ; Paolo Bonzini > ; Edgar Iglesias ; Francisco > Eduardo Iglesias ; qemu-devel@nongnu.or

[Bug 1897680] [NEW] memory address over 0x2000_7ffc is not accessible in mps2-an505

2020-09-29 Thread Changho Choi
Public bug reported: I currently run qemu with the following options `qemu-system-aarch64 -machine mps2-an505 -cpu cortex-m33 -m 16` For some reason, memory address over 0x2000_7ffc is not accessible. It can be tested in gdb as follow. (gdb) x/x 0x20007ffc 0x20007ffc: 0x (gdb) x/x 0x

Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-29 Thread Michael S. Tsirkin
On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > This change adds a new DSDT golden master table blob to test disabling > hotplug on both pci root bus and pci bridges. Also reverts the change > in file bios-tables-test-allowed-diff.h to make sure its now empty so that > future modificat

Re: [PATCH v5 0/7] vhost-user-blk: fix the migration issue and enhance qtests

2020-09-29 Thread Michael S. Tsirkin
On Sun, Sep 27, 2020 at 09:48:28AM +0300, Dima Stepanov wrote: > On Thu, Sep 24, 2020 at 07:26:14AM -0400, Michael S. Tsirkin wrote: > > On Fri, Sep 11, 2020 at 11:39:42AM +0300, Dima Stepanov wrote: > > > v4 -> v5: > > > - vhost: check queue state in the vhost_dev_set_log routine > > > tests

[PULL v4 00/48] virtio,pc,acpi: fixes, tests

2020-09-29 Thread Michael S. Tsirkin
Changes from v3: - dropped reconnect tests - added more fixes, an smbios feature The following changes since commit 74504514b154ebebdff577d88e4bf5c13074e9ed: Merge remote-tracking branch 'remotes/alistair/tags/pull-register-20200927' into staging (2020-09-28 16:49:10 +0100) are available in t

[PULL v4 07/48] vhost: check queue state in the vhost_dev_set_log routine

2020-09-29 Thread Michael S. Tsirkin
From: Dima Stepanov If the vhost-user-blk daemon provides only one virtqueue, but device was added with several queues, then QEMU will send more VHOST-USER command than expected by daemon side. The vhost_virtqueue_start() routine handles such case by checking the return value from the virtio_queu

[PULL v4 03/48] vhost-vdpa: batch updating IOTLB mappings

2020-09-29 Thread Michael S. Tsirkin
From: Jason Wang To speed up the memory mapping updating between vhost-vDPA and vDPA device driver, this patch passes the IOTLB batching flags via IOTLB API. Two new flags was introduced, VHOST_IOTLB_BATCH_BEGIN is a hint that a bathced IOTLB updating may be initiated from the userspace. VHOST_IO

[PULL v4 06/48] vhost: recheck dev state in the vhost_migration_log routine

2020-09-29 Thread Michael S. Tsirkin
From: Dima Stepanov vhost-user devices can get a disconnect in the middle of the VHOST-USER handshake on the migration start. If disconnect event happened right before sending next VHOST-USER command, then the vhost_dev_set_log() call in the vhost_migration_log() function will return error. This

[PULL v4 04/48] virtio-mem: detach the element from the virtqueue when error occurs

2020-09-29 Thread Michael S. Tsirkin
From: Li Qiang If error occurs while processing the virtio request we should call 'virtqueue_detach_element' to detach the element from the virtqueue before free the elem. Signed-off-by: Li Qiang Message-Id: <20200816142245.17556-1-liq...@163.com> Fixes: 910b25766b ("virtio-mem: Paravirtualized

[PULL v4 05/48] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine

2020-09-29 Thread Michael S. Tsirkin
From: David Hildenbrand Unfortunately, a typo sneeked in: we want to set auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp. Cc: qemu-sta...@nongnu.org # v5.1 Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible) Reported-by: Dr. David Alan Gilber

[PULL v4 13/48] util/hexdump: introduce qemu_hexdump_line()

2020-09-29 Thread Michael S. Tsirkin
From: Laurent Vivier Dumping one line of hexadecimal/ASCII from a buffer is often needed. Move this part from qemu_hexdump() and use it Acked-by: Stefan Hajnoczi Signed-off-by: Laurent Vivier Message-Id: <20200925091055.186023-2-lviv...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-b

[PULL v4 09/48] cphp: remove deprecated cpu-add command(s)

2020-09-29 Thread Michael S. Tsirkin
From: Igor Mammedov These were deprecated since 4.0, remove both HMP and QMP variants. Users should use device_add command instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov Reviewed-by: Thoma

[PULL v4 08/48] tests/qtest/vhost-user-test: prepare the tests for adding new dev class

2020-09-29 Thread Michael S. Tsirkin
From: Dima Stepanov For now only vhost-user-net device is supported by the test. Other vhost-user devices are not tested. As a first step make source code refactoring so new devices can reuse the same test routines. To make this provide a new vhost_user_ops structure with the methods to initializ

[PULL v4 14/48] vhost-vdpa: add trace-events

2020-09-29 Thread Michael S. Tsirkin
From: Laurent Vivier Add trace functions in vhost-vdpa.c. All traces from this file can be enabled with '-trace vhost_vdpa*'. Acked-by: Stefan Hajnoczi Signed-off-by: Laurent Vivier Message-Id: <20200925091055.186023-3-lviv...@redhat.com> Acked-by: Jason Wang Reviewed-by: Michael S. Tsirkin

[PULL v4 19/48] vhost-vsock-ccw: force virtio version 1

2020-09-29 Thread Michael S. Tsirkin
From: Stefano Garzarella virtio-vsock was introduced after the release of VIRTIO 1.0 specifications, so it should be 'modern-only'. This patch forces virtio version 1 as done for vhost-vsock-pci. To avoid migration issues, we force virtio version 1 only when legacy check is enabled in the new m

[PULL v4 15/48] configure: Fix build dependencies with vhost-vdpa.

2020-09-29 Thread Michael S. Tsirkin
From: Laurent Vivier Following the same logic as for vhost-net-user and vhost-kernel, enable vhost-net if vhost-net-vdpa is enabled and vhost-net is not explicitly disabled. See 299e6f19b3e2 ("vhost-net: revamp configure logic") Autoselect VHOST if VHOST_VDPA is set See 21c6b0c87e85 ("configure:

[PULL v4 10/48] virtio-iommu: Check gtrees are non null before destroying them

2020-09-29 Thread Michael S. Tsirkin
From: Eric Auger If realize fails, domains and endpoints trees may be NULL. On unrealize(), this produces assertions: "GLib: g_tree_destroy: assertion 'tree != NULL' failed" Check that the trees are non NULL before destroying them. Cc: qemu-sta...@nongnu.org Signed-off-by: Eric Auger Reviewed

[PULL v4 17/48] vhost-vsock-pci: force virtio version 1

2020-09-29 Thread Michael S. Tsirkin
From: Stefano Garzarella Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on vhost-vsock-pci device: $ ./qemu-system-x86_64 ... -device vhost-vsock-pci,guest-cid=5 qemu-system-x86_64: -device

[PULL v4 25/48] tests: acpi: mark to be changed tables in bios-tables-test-allowed-diff

2020-09-29 Thread Michael S. Tsirkin
From: Igor Mammedov ... to let tests pass until binary blobs are updated with new AML Signed-off-by: Igor Mammedov Message-Id: <20200923094650.1301166-6-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 19

[PULL v4 26/48] x86: ich9: expose "smi_negotiated_features" as a QOM property

2020-09-29 Thread Michael S. Tsirkin
From: Igor Mammedov Expose the "smi_negotiated_features" field of ICH9LPCState as a QOM property. Signed-off-by: Igor Mammedov Reviewed-by: Laszlo Ersek Tested-by: Laszlo Ersek Message-Id: <20200923094650.1301166-7-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S

[PULL v4 11/48] virtio-iommu-pci: force virtio version 1

2020-09-29 Thread Michael S. Tsirkin
From: Eric Auger Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on virtio-iommu-pci: qemu-system-aarch64: -device virtio-iommu-pci: device is modern-only, use disable-legacy=on virtio-iommu was introd

[PULL v4 28/48] x86: acpi: introduce the PCI0.SMI0 ACPI device

2020-09-29 Thread Michael S. Tsirkin
From: Igor Mammedov When CPU hotplug with SMI has been negotiated, describe the SMI register block in the DSDT. Pass the ACPI name of the SMI control register to build_cpus_aml(), so that CPU_SCAN_METHOD can access the register in the next patch. Signed-off-by: Igor Mammedov Reviewed-by: Laszlo

[PULL v4 18/48] vhost-user-vsock-pci: force virtio version 1

2020-09-29 Thread Michael S. Tsirkin
From: Stefano Garzarella Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on vhost-user-vsock-pci device: $ ./qemu-system-x86_64 ... \ -chardev socket,id=char0,reconnect=0,path=/tmp/vhost4.socket

[PULL v4 33/48] qemu-options: document SMBIOS type 11 settings

2020-09-29 Thread Michael S. Tsirkin
From: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé Message-Id: <20200923133804.2089190-4-berra...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- qemu-options.hx | 41 + 1 fi

[PULL v4 21/48] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-09-29 Thread Michael S. Tsirkin
From: Igor Mammedov It will allow firmware to notify QEMU that firmware requires SMI being triggered on CPU hot[un]plug, so that it would be able to account for hotplugged CPU and relocate it to new SMM base and/or safely remove CPU on unplug. Using negotiated features, follow up patches will in

[PULL v4 31/48] hw/smbios: support loading OEM strings values from a file

2020-09-29 Thread Michael S. Tsirkin
From: Daniel P. Berrangé Some applications want to pass quite large values for the OEM strings entries. Rather than having huge strings on the command line, it would be better to load them from a file, as supported with -fw_cfg. This introduces the "path" parameter allowing for: $ echo -n "th

[PULL v4 42/48] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag

2020-09-29 Thread Michael S. Tsirkin
From: Ani Sinha This patch adds a binary blob corresponding to the DSDT acpi table. It is used to unit test the flag 'acpi-pci-hotplug-with-bridge-support' used with pci bridges. This change also clears the file tests/qtest/bios-tables-test-allowed-diff.h so that future changes which affect the

[PULL v4 16/48] virtio: skip legacy support check on machine types less than 5.1

2020-09-29 Thread Michael S. Tsirkin
From: Stefano Garzarella Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a check that returns an error if legacy support is on, but the device does not support legacy. Unfortunately some devices were wrongly declared legacy capable even if they were not (e.g

[PULL v4 24/48] acpi: add aml_land() and aml_break() primitives

2020-09-29 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laszlo Ersek Tested-by: Laszlo Ersek Message-Id: <20200923094650.1301166-5-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/aml-build.

[PULL v4 22/48] x86: cpuhp: prevent guest crash on CPU hotplug when broadcast SMI is in use

2020-09-29 Thread Michael S. Tsirkin
From: Igor Mammedov There were reports of guest crash on CPU hotplug, when using q35 machine type and OVMF with SMM, due to hotplugged CPU trying to process SMI at default SMI handler location without it being relocated by firmware first. Fix it by refusing hotplug if firmware hasn't negotiated

[PULL v4 32/48] hw/smbios: report error if table size is too large

2020-09-29 Thread Michael S. Tsirkin
From: Daniel P. Berrangé The SMBIOS 2.1 entry point uses a uint16 data type for reporting the total length of the tables. If the user passes -smbios configuration to QEMU that causes the table size to exceed this limit then various bad behaviours result, including - firmware hangs in an infinit

[PULL v4 44/48] piix4: don't reserve hw resources when hotplug is off globally

2020-09-29 Thread Michael S. Tsirkin
From: Ani Sinha When acpi hotplug is turned off for both root pci bus as well as for pci bridges, we should not generate the related ACPI code for DSDT table or initialize related hw ports or reserve hw resources. This change makes sure all those operations are turned off in the case ACPI pci hot

[PULL v4 27/48] x86: acpi: introduce AcpiPmInfo::smi_on_cpuhp

2020-09-29 Thread Michael S. Tsirkin
From: Igor Mammedov Translate the "CPU hotplug with SMI" feature bit, from the property added in the last patch, to a dedicated boolean in AcpiPmInfo. Signed-off-by: Igor Mammedov Reviewed-by: Laszlo Ersek Tested-by: Laszlo Ersek Message-Id: <20200923094650.1301166-8-imamm...@redhat.com> Revi

[PULL v4 29/48] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM

2020-09-29 Thread Michael S. Tsirkin
From: Igor Mammedov In case firmware has negotiated CPU hotplug SMI feature, generate AML to describe SMI IO port region and send SMI to firmware on each CPU hotplug SCI in case new CPUs were hotplugged. Since new CPUs can be hotplugged while CPU_SCAN_METHOD is running we can't send SMI before n

[PULL v4 34/48] vhost-user: save features of multiqueues if chardev is closed

2020-09-29 Thread Michael S. Tsirkin
From: haibinzhang(张海斌) Fore-commit(c6beefd674) only saves features of queue0, this makes wrong features of other queues in multiqueues situation. For examples: qemu-system-aarch64 ... \ -chardev socket,id=charnet0,path=/var/run/vhost_sock \ -netdev vhost-user,chardev=charnet0,queues=2,id=ho

[PULL v4 35/48] tests/acpi: mark addition of table DSDT.roothp for unit testing root pci hotplug

2020-09-29 Thread Michael S. Tsirkin
From: Ani Sinha A new binary acpi table tests/data/acpi/pc/DSDT.roothp is added in order to unit test the feature flag that can disable/enable root pci bus hotplug on i440fx. This feature was added with the commit: 3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the roo

[PULL v4 01/48] linux headers: sync to 5.9-rc4

2020-09-29 Thread Michael S. Tsirkin
From: Jason Wang Update against Linux 5.9-rc4. Cc: Cornelia Huck Cc: Paolo Bonzini Signed-off-by: Jason Wang Message-Id: <20200907104903.31551-2-jasow...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/standard-headers/drm/drm_fourcc.h | 140 ++

[PULL v4 40/48] tests/acpi: list added acpi table binary file for pci bridge hotplug test

2020-09-29 Thread Michael S. Tsirkin
From: Ani Sinha The file 'tests/data/acpi/pc/DSDT.hpbridge' is a newly added acpi table file for testing the pci bridge option 'acpi-pci-hotplug-with-bridge-support' under i440fx. This change documents this fact. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov Message-Id: <20200918084111.1

[PULL v4 36/48] tests/acpi: add new unit test to test hotplug off/on feature on the root pci bus

2020-09-29 Thread Michael S. Tsirkin
From: Ani Sinha Ability to turn hotplug off on the pci root bus for i440fx was added in commit: 3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") This change adds a unit test in order to test this feature. Signed-off-by: Ani Sinha Reviewed-by: Igor Mamme

[PULL v4 20/48] virtio: update MemoryRegionCaches when guest set bad features

2020-09-29 Thread Michael S. Tsirkin
From: Li Qiang Current the 'virtio_set_features' only update the 'MemorRegionCaches' when the 'virtio_set_features_nocheck' return '0' which means it is not bad features. However the guest can still trigger the access of the used vring after set bad features. In this situation it will cause asser

[PULL v4 39/48] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-29 Thread Michael S. Tsirkin
From: Ani Sinha Cold plugged bridges are not hot unpluggable, even when their hotplug property (acpi-pci-hotplug-with-bridge-support) is turned off. Please see the function acpi_pcihp_pc_no_hotplug(). However, with the current implementaton, Windows would try to hot-unplug a pci bridge when it's

[PULL v4 38/48] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus

2020-09-29 Thread Michael S. Tsirkin
From: Ani Sinha When ACPI hotplug for the root bus is disabled, the bsel property for that bus is not set. Please see the following commit: 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus"). As a result, when acpi_pcihp_find_hotplug_bus() is called with bs

Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-29 Thread Michael S. Tsirkin
On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin wrote: > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > > > This change adds a new DSDT golden master table blob to test disabling > > > hotplug on both pci root bus

[PULL v4 37/48] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off

2020-09-29 Thread Michael S. Tsirkin
From: Ani Sinha A new binary ACPI table tests/data/acpi/pc/DSDT.roothp is added in order to unit test hotplug on/off capability on the root pci bus for i440fx. The diff between the table DSDT.bridge and DSDT.roothp is listed below: @@ -1,30 +1,30 @@ /* * Intel ACPI Component Architecture *

[PULL v4 41/48] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag

2020-09-29 Thread Michael S. Tsirkin
From: Ani Sinha This change adds a new unit test for the global flag 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci bridges in i440fx. The flag can be used to turn off ACPI based hotplug support on all pci bridges. Signed-off-by: Ani Sinha Reviewed-by: Igor Mamme

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-29 Thread Marc-André Lureau
Hi On Tue, Sep 22, 2020 at 9:08 PM Paolo Bonzini wrote: > On 22/09/20 18:35, Marc-André Lureau wrote: > > The D-Bus specification doesn't detail versioning much. What is > > recommended is to have the version number as part of the interface name > > (kinda like soname): > > http://0pointer.de/bl

[PULL v4 43/48] Add ACPI DSDT tables for q35 that are being updated by the next patch

2020-09-29 Thread Michael S. Tsirkin
From: Ani Sinha The following patch ("piix4: don't reserve hw resources when hotplug is off globally") modifies certain ACPI tables for q35 machines. This patch adds those table names to tests/qtest/bios-tables-test-allowed-diff.h so that unit tests continue to pass and bisection is not broken.

[PULL v4 02/48] vhost: switch to use IOTLB v2 format

2020-09-29 Thread Michael S. Tsirkin
From: Jason Wang This patch tries to switch to use new kernel IOTLB format V2. Previous version may have inconsistent ABI between 32bit and 64bit machines because of the hole after type field. Refer kernel commit ("429711aec282 vhost: switch to use new message format") for more information. To e

Re: [PATCH] trace/simple: Enable tracing on startup only if the user specifies a trace option

2020-09-29 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Sun, Aug 16, 2020 at 12:46:10PM -0500, dubo...@gmail.com wrote: >> From: Josh DuBois >> >> Tracing can be enabled at the command line or via the >> monitor. Command-line trace options are recorded during >> trace_opt_parse(), but tracing is not enabled until the var

[PULL v4 47/48] libvhost-user: return early on virtqueue errors

2020-09-29 Thread Michael S. Tsirkin
From: Stefan Hajnoczi vu_panic() is not guaranteed to exit the program. Return early when errors are encountered. Note that libvhost-user does not have an "unmap" operation for mapped descriptors. Therefore it is correct to return without explicit cleanup. Signed-off-by: Stefan Hajnoczi Messag

[PULL v4 46/48] hw: virtio-pmem: detach the element fromt the virtqueue when error occurs

2020-09-29 Thread Michael S. Tsirkin
From: Li Qiang If error occurs while processing the virtio request we should call 'virtqueue_detach_element' to detach the element from the virtqueue before free the elem. Signed-off-by: Li Qiang Message-Id: <20200813165125.59928-1-liq...@163.com> Reviewed-by: Michael S. Tsirkin Signed-off-by:

Re: [PATCH] virtio-gpu-3d: fix abnormal display after a warm reboot

2020-09-29 Thread Gerd Hoffmann
On Sun, Sep 27, 2020 at 08:17:10PM +0800, Guoqing Zhang wrote: > hello Gerd and Michael Michael S. Tsirkin > > ping Queued up now (not much activity for vga/ui these days ...). > > http://patchwork.ozlabs.org/project/qemu-devel/list/?series=202680 > > On Fri, Sep 18, 2020 at 7:16 PM Guoqing

[PULL v4 48/48] libvhost-user: return on error in vu_log_queue_fill()

2020-09-29 Thread Michael S. Tsirkin
From: Stefan Hajnoczi vu_panic() is not guaranteed to exit the program. Return early when errors are encountered. Signed-off-by: Stefan Hajnoczi Message-Id: <20200921113420.154378-3-stefa...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael

Re: [PATCH v3 0/6] Add physical display dimensions to spice/virtio-gpu

2020-09-29 Thread Gerd Hoffmann
On Sun, Sep 27, 2020 at 06:57:45PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > This series improves the support for HiDPI displays with Spice. > The related spice series have already been merged. > > v3: > - simplify the handling of Spice monitor configurat

Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-29 Thread Ani Sinha
On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin wrote: > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > > This change adds a new DSDT golden master table blob to test disabling > > hotplug on both pci root bus and pci bridges. Also reverts the change > > in file bios-tables-tes

[Bug 1894804] Re: Second DEVICE_DELETED event missing during virtio-blk disk device detach

2020-09-29 Thread Christian Ehrhardt 
Thanks James, but now I'm unsure where to go from here as it isn't reproducible with many tries at different scales that James and I did. @Sean/Lee Since you wondered if it might be due to Ubuntu Delta on top of 4.2 - there are two things we could compare Ubuntu's qemu to then: 1. qemu 4.2 as re

[PULL v4 12/48] virtio-pmem-pci: force virtio version 1

2020-09-29 Thread Michael S. Tsirkin
From: Pankaj Gupta Qemu fails with below error when trying to run with virtio pmem: (qemu) qemu-system-x86_64: -device virtio-pmem-pci,memdev=mem1,id=nv1: device is modern-only, use disable-legacy=on This patch fixes this by forcing virtio 1 with virtio-pmem. fixes: adf0748a49 ("virtio-pc

[PULL v4 23/48] x86: cpuhp: refuse cpu hot-unplug request earlier if not supported

2020-09-29 Thread Michael S. Tsirkin
From: Igor Mammedov CPU hot-unplug with SMM requires firmware participation to prevent guest crash (i.e. CPU can be removed only after OS _and_ firmware were prepared for the action). Previous patches introduced ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT feature bit, which is advertised by firmware when i

[PATCH 2/2] target/i386/cpu: Update comment that mentions Texinfo

2020-09-29 Thread Markus Armbruster
Missed in commit 41fba1618b "docs/system: convert the documentation of deprecated features to rST." Signed-off-by: Markus Armbruster --- target/i386/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 3ffd877dd5..aa0c38c793 1006

[PULL v4 30/48] tests: acpi: update acpi blobs with new AML

2020-09-29 Thread Michael S. Tsirkin
From: Igor Mammedov here is diff against tests/data/acpi/q35/DSDT for currently shipped ovmf binary. (once firmware blob is updated, it will negotiate CPU hotplug feature which will ad extra hunk sending SMI and Q35 tests will need to be updated), but otherwise diff shows new CPU hotplug AML that

[PATCH 1/2] qemu-img-cmds.hx: Update comment that mentions Texinfo

2020-09-29 Thread Markus Armbruster
Missed in 3c95fdef94 "Update comments in .hx files that mention Texinfo". Signed-off-by: Markus Armbruster --- qemu-img-cmds.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index b89c019b76..cab8234235 100644 --- a/qemu-img-cmds.hx +++ b

[PATCH 0/2] Update leftover comments that mention Texinfo

2020-09-29 Thread Markus Armbruster
Markus Armbruster (2): qemu-img-cmds.hx: Update comment that mentions Texinfo target/i386/cpu: Update comment that mentions Texinfo target/i386/cpu.c | 3 ++- qemu-img-cmds.hx | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) -- 2.26.2

Re: [PATCH v6 08/21] docs/interop: Convert qemu-ga-ref to rST

2020-09-29 Thread Markus Armbruster
Peter Maydell writes: > Convert qemu-ga-ref to rST format. This includes dropping > the plain-text, pdf and info format outputs for this document; > as with all our other Sphinx-based documentation, we provide > HTML and manpage only. > > The qemu-ga-ref.rst is somewhat more stripped down than >

Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-29 Thread Ani Sinha
On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin wrote: > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > > > > This change adds a new DSDT golde

Re: [PATCH Kernel v24 0/8] Add UAPIs to support migration for VFIO devices

2020-09-29 Thread Stefan Hajnoczi
On Fri, May 29, 2020 at 02:00:46AM +0530, Kirti Wankhede wrote: > * IOCTL VFIO_IOMMU_DIRTY_PAGES to get dirty pages bitmap with > respect to IOMMU container rather than per device. All pages pinned by > vendor driver through vfio_pin_pages external API has to be marked as > dirty during migr

Re: [PATCH v6 09/21] docs/interop: Convert qemu-qmp-ref to rST

2020-09-29 Thread Markus Armbruster
Peter Maydell writes: > Convert qemu-qmp-ref to rST format. This includes dropping > the plain-text, pdf and info format outputs for this document; > as with all our other Sphinx-based documentation, we provide > HTML and manpage only. > > The qemu-qmp-ref.rst is somewhat more stripped down than

Re: [PATCH v6 11/21] qga/qapi-schema.json: Add some headings

2020-09-29 Thread Markus Armbruster
Peter Maydell writes: > Add some section headings to the QGA json; this is purely so that we > have some H1 headings, as otherwise each command ends up being > visible in the interop/ manual's table of contents. In an ideal > world there might be a proper 'Introduction' section the way there is

Re: [PATCH v6 12/21] tests/qapi-schema: Convert doc-good.json to rST-style strong/emphasis

2020-09-29 Thread Markus Armbruster
Peter Maydell writes: > doc-good.json currently uses the old *strong* and _emphasis_ markup. > As part of the conversion to rST this needs to switch to **strong** > and *emphasis*, because rST uses underscores as part of its markup > of hyperlinks and will otherwise warn about the syntax error. >

Re: [PATCH v6 09/21] docs/interop: Convert qemu-qmp-ref to rST

2020-09-29 Thread Markus Armbruster
Appears to break documented make target html: $ make -C bld-x86 html make: Entering directory '/work/armbru/qemu/bld-x86' make: *** No rule to make target 'html'. Stop. make: Leaving directory '/work/armbru/qemu/bld-x86'

Re: [PATCH v6 13/21] meson.build: Move SPHINX_ARGS to top level meson.build file

2020-09-29 Thread Markus Armbruster
Peter Maydell writes: > We're going to want to use SPHINX_ARGS in both docs/meson.build > and tests/qapi-schema/meson.build. Move the definition up to the > top level file so it is available to both subdirectories. > > Signed-off-by: Peter Maydell > --- > docs/meson.build | 8 > meson.

Re: [PULL v4 00/48] virtio,pc,acpi: fixes, tests

2020-09-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200929071948.281157-1-...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-29 Thread Ani Sinha
On Tue, Sep 29, 2020 at 1:53 PM Ani Sinha wrote: > > On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin wrote: > > > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Fri, Sep 18, 2020 at 02:11

Re: [PATCH v6 14/21] meson.build: Make manuals depend on source to Sphinx extensions

2020-09-29 Thread Markus Armbruster
Peter Maydell writes: > The automatic dependency handling for Sphinx manuals only makes the output > depend on the input documentation files. This means that if you edit > the Python source of an extension then the documentation won't be > rebuilt. > > Create a list of all the source files for th

Re: [PATCH v6 05/21] scripts/qapi/parser.py: improve doc comment indent handling

2020-09-29 Thread Peter Maydell
On Mon, 28 Sep 2020 at 20:16, Markus Armbruster wrote: > > Peter Maydell writes: > > +Descriptions of arguments can span multiple lines. The description > > +text can start on the line following the '@argname:', in which case > > +it must not be indented at all. It can also start on the same line

[PATCH v2 0/2] NVMe passthrough: Take into account host IOVA reserved regions

2020-09-29 Thread Eric Auger
The current IOVA allocator allocates within the [0x1, 1ULL << 39] window, without paying attention to the host IOVA reserved regions. This prevents NVMe passthtrough from working on ARM as the fixed IOVAs rapidly grow up to the MSI reserved region [0x800, 0x810] causing some VFIO MAP DM

[PATCH v2 1/2] util/vfio-helpers: Collect IOVA reserved regions

2020-09-29 Thread Eric Auger
The IOVA allocator currently ignores host reserved regions. As a result some chosen IOVAs may collide with some of them, resulting in VFIO MAP_DMA errors later on. This happens on ARM where the MSI reserved window quickly is encountered: [0x800, 0x810]. since 5.4 kernel, VFIO returns the us

Re: [PATCH v2 7/8] qemu/bswap: Use compiler __builtin_bswap() on NetBSD

2020-09-29 Thread Peter Maydell
On Mon, 28 Sep 2020 at 23:02, Kamil Rytarowski wrote: > > Personally, I prefer using the system headers. but if you want to use > the GCC builtins, please go for it. I'd agree if the system header approach was cross-platform or if this was a BSD-only program or if we were aiming for complete comp

[PATCH v2 2/2] util/vfio-helpers: Rework the IOVA allocator to avoid IOVA reserved regions

2020-09-29 Thread Eric Auger
Introduce the qemu_vfio_find_fixed/temp_iova helpers which respectively allocate IOVAs from the bottom/top parts of the usable IOVA range, without picking within host IOVA reserved windows. The allocation remains basic: if the size is too big for the remaining of the current usable IOVA range, we j

Re: Outline for VHOST_USER_PROTOCOL_F_VDPA

2020-09-29 Thread Stefan Hajnoczi
On Tue, Sep 29, 2020 at 02:09:55AM -0400, Michael S. Tsirkin wrote: > On Mon, Sep 28, 2020 at 10:25:37AM +0100, Stefan Hajnoczi wrote: > > Why extend vhost-user with vDPA? > > > > Reusing VIRTIO emulation code for vhost-user backends > >

Re: [PATCH 00/16] hw/mips: Set CPU frequency

2020-09-29 Thread Philippe Mathieu-Daudé
On 9/29/20 4:46 AM, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20200928171539.788309-1-f4...@amsat.org/ > time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 > --- > qemu-system-aarch64: falling back to tcg > socket_accept failed: Resource temporarily unavailable

Re: [PATCH v6 07/21] docs/sphinx: Add new qapi-doc Sphinx extension

2020-09-29 Thread Peter Maydell
On Tue, 29 Sep 2020 at 07:54, Markus Armbruster wrote: > > Peter Maydell writes: > > > Some of our documentation is auto-generated from documentation > > comments in the JSON schema. > > > > For Sphinx, rather than creating a file to include, the most natural > > way to handle this is to have a s

Re: [PATCH 16/16] tests/acceptance: Test the MIPSsim machine

2020-09-29 Thread Philippe Mathieu-Daudé
+Alex/Daniel On 9/28/20 10:33 PM, Willian Rampazzo wrote: > On Mon, Sep 28, 2020 at 2:31 PM Philippe Mathieu-Daudé > wrote: >> >> Add a test for the mipssim machine, based on the recommended >> test setup from Thomas Huth: >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg606846.html >> >

Re: [PATCH 0/2] Update leftover comments that mention Texinfo

2020-09-29 Thread Philippe Mathieu-Daudé
On 9/29/20 9:58 AM, Markus Armbruster wrote: > Markus Armbruster (2): > qemu-img-cmds.hx: Update comment that mentions Texinfo > target/i386/cpu: Update comment that mentions Texinfo > > target/i386/cpu.c | 3 ++- > qemu-img-cmds.hx | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-)

[Bug 1897680] Re: memory address over 0x2000_7ffc is not accessible in mps2-an505

2020-09-29 Thread Peter Maydell
This is expected behaviour. The memory at 0x2000_ in this board is the "FPGA block RAM", and there is only 32K of it, so it finishes at 0x2000_7fff, and attempts to access beyond that will fail because there is no device or memory at the address immediately after it in the memory map. -- You

[Bug 1897680] Re: memory address over 0x2000_7ffc is not accessible in mps2-an505

2020-09-29 Thread Peter Maydell
PS: you don't need to pass "-cpu cortex-m33" as it is the default for the mps2-an505 board, and you don't need to pass a -m argument either, as 16MB is the fixed value for this board. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. ht

[Bug 1897680] Re: memory address over 0x2000_7ffc is not accessible in mps2-an505

2020-09-29 Thread Peter Maydell
(If you were just interested in having a large area of contiguous RAM, the "PSRAM" is the largest lump on this board: it's 16MB starting at 0x8000_.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

Re: [PATCH v6 08/21] docs/interop: Convert qemu-ga-ref to rST

2020-09-29 Thread Peter Maydell
On Tue, 29 Sep 2020 at 09:20, Markus Armbruster wrote: > > Peter Maydell writes: > > > Convert qemu-ga-ref to rST format. This includes dropping > > the plain-text, pdf and info format outputs for this document; > > as with all our other Sphinx-based documentation, we provide > > HTML and manpage

Re: [PULL 0/5] Usb 20200928 patches

2020-09-29 Thread Peter Maydell
On Mon, 28 Sep 2020 at 14:23, Gerd Hoffmann wrote: > > The following changes since commit 8d16e72f2d4df2c9e631393adf1669a1da7efe8a: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20200925a' into staging (2020-09-25 > 14:46:18 +0100) > > are available in the Git reposi

Re: [PATCH 16/16] tests/acceptance: Test the MIPSsim machine

2020-09-29 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > +Alex/Daniel > > On 9/28/20 10:33 PM, Willian Rampazzo wrote: >> On Mon, Sep 28, 2020 at 2:31 PM Philippe Mathieu-Daudé >> wrote: >>> >>> Add a test for the mipssim machine, based on the recommended >>> test setup from Thomas Huth: >>> https://www.mail-archive

Re: [PATCH v6 09/21] docs/interop: Convert qemu-qmp-ref to rST

2020-09-29 Thread Peter Maydell
On Tue, 29 Sep 2020 at 09:28, Markus Armbruster wrote: > > Peter Maydell writes: > > diff --git a/qapi/meson.build b/qapi/meson.build > > index 2b2872a41d8..a287ca5d9d7 100644 > > --- a/qapi/meson.build > > +++ b/qapi/meson.build > > @@ -97,7 +97,7 @@ foreach module : qapi_all_modules > > endfor

Re: [Bug 1897680] [NEW] memory address over 0x2000_7ffc is not accessible in mps2-an505

2020-09-29 Thread Philippe Mathieu-Daudé
On 9/29/20 8:57 AM, Changho Choi wrote: > Public bug reported: > > I currently run qemu with the following options > `qemu-system-aarch64 -machine mps2-an505 -cpu cortex-m33 -m 16` > > For some reason, memory address over 0x2000_7ffc is not accessible. > It can be tested in gdb as follow. > > (g

Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-29 Thread Michael S. Tsirkin
On Tue, Sep 29, 2020 at 02:21:06PM +0530, Ani Sinha wrote: > On Tue, Sep 29, 2020 at 1:53 PM Ani Sinha wrote: > > > > On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > > > > On Tue, Sep 29, 2020 at 12:42 PM Michael

[PATCH 2/2] hw/arm/sbsa-ref : allocate IRQs for SMMUv3

2020-09-29 Thread Graeme Gregory
Original commit did not allocate IRQs for the SMMUv3 in the irqmap effectively using irq 0->3 (shared with other devices). Assuming original intent was to allocate unique IRQs then add an allocation to the irqmap. Fixes: e9fdf453240 ("hw/arm: Add arm SBSA reference machine, devices part") Signed-o

[PATCH 0/2] hw/arm/sbsa-ref : small fixes to smmuv3 initialisation

2020-09-29 Thread Graeme Gregory
Fix two issues with the smmuv3 initialisation, first where a previous patch had transposed an i to a 1. The second an assumption that the IRQs allocated were meant to be unique and not 0 based. Graeme Gregory (2): hw/arm/sbsa-ref : Fix SMMUv3 Initialisation hw/arm/sbsa-ref : allocate IRQs for

[PATCH 1/2] hw/arm/sbsa-ref : Fix SMMUv3 Initialisation

2020-09-29 Thread Graeme Gregory
SMMUv3 has an error in previous patch where a i was transposed to a 1 meaning interrupts would not have been correctly assigned to the SMMUv3 instance. Fixes: 48ba18e6d3f3 ("hw/arm/sbsa-ref: Simplify by moving the gic in the machine state") Signed-off-by: Graeme Gregory --- hw/arm/sbsa-ref.c |

Re: [PATCH v6 09/21] docs/interop: Convert qemu-qmp-ref to rST

2020-09-29 Thread Peter Maydell
On Tue, 29 Sep 2020 at 09:42, Markus Armbruster wrote: > > Appears to break documented make target html: > > $ make -C bld-x86 html > make: Entering directory '/work/armbru/qemu/bld-x86' > make: *** No rule to make target 'html'. Stop. > make: Leaving directory '/work/armbru/qemu/bld-x86' Whoops

Re: [RFC PATCH 0/7] block-backend: Introduce I/O hang

2020-09-29 Thread cenjiahui
On 2020/9/28 18:57, Kevin Wolf wrote: > Am 27.09.2020 um 15:04 hat Ying Fang geschrieben: >> A VM in the cloud environment may use a virutal disk as the backend storage, >> and there are usually filesystems on the virtual block device. When backend >> storage is temporarily down, any I/O issued t

Re: [PATCH v5 0/7] vhost-user-blk: fix the migration issue and enhance qtests

2020-09-29 Thread Dima Stepanov
On Tue, Sep 29, 2020 at 03:13:09AM -0400, Michael S. Tsirkin wrote: > On Sun, Sep 27, 2020 at 09:48:28AM +0300, Dima Stepanov wrote: > > On Thu, Sep 24, 2020 at 07:26:14AM -0400, Michael S. Tsirkin wrote: > > > On Fri, Sep 11, 2020 at 11:39:42AM +0300, Dima Stepanov wrote: > > > > v4 -> v5: > > > >

Re: [PATCH 16/16] tests/acceptance: Test the MIPSsim machine

2020-09-29 Thread Philippe Mathieu-Daudé
On 9/29/20 11:38 AM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> +Alex/Daniel >> >> On 9/28/20 10:33 PM, Willian Rampazzo wrote: >>> On Mon, Sep 28, 2020 at 2:31 PM Philippe Mathieu-Daudé >>> wrote: Add a test for the mipssim machine, based on the recommended test

Re: [PATCH 2/2] hw/arm/sbsa-ref : allocate IRQs for SMMUv3

2020-09-29 Thread Philippe Mathieu-Daudé
On 9/29/20 11:42 AM, Graeme Gregory wrote: > Original commit did not allocate IRQs for the SMMUv3 in the irqmap > effectively using irq 0->3 (shared with other devices). Assuming > original intent was to allocate unique IRQs then add an allocation > to the irqmap. > > Fixes: e9fdf453240 ("hw/arm:

  1   2   3   4   5   6   >