Re: [PATCH v5] hw/i386/pc: add max combined fw size as machine configuration option

2020-09-25 Thread Laszlo Ersek
Hi Erich, when processing review feedback, please pay attention to *where* the review comments are inserted, in response to your patch email. I'm pointing this out not because I want to annoy you with my obsessions, but because I consider this discussion a kind of "git + mailing lists" training f

Re: [PATCH v6 10/15] iotests: qemu_io_silent: support --image-opts

2020-09-25 Thread Max Reitz
On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/iotests.py | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/3] virtio-net: Set mac address to hardware if the peer is vdpa

2020-09-25 Thread Cindy Lu
On Thu, Sep 24, 2020 at 3:18 PM Jason Wang wrote: > > > On 2020/9/22 上午11:01, Cindy Lu wrote: > > On Tue, Sep 22, 2020 at 9:55 AM Jason Wang wrote: > >> > >> On 2020/9/17 下午11:58, Cindy Lu wrote: > >>> If the peer's type is vdpa,set the mac address to NIC in > >>> virtio_net_device_realize, > >>

Re: [PATCH 14/37] qapi/common.py: Move comments into docstrings

2020-09-25 Thread Markus Armbruster
John Snow writes: > On 9/24/20 11:06 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 9/17/20 3:14 PM, Eduardo Habkost wrote: On Thu, Sep 17, 2020 at 02:44:53PM -0400, John Snow wrote: [...] > Having said this, I have not found any tool to date that actually *checks* >>

Re: [PATCH] configure: Fix build dependencies with vhost-vdpa.

2020-09-25 Thread Philippe Mathieu-Daudé
On 9/24/20 11:00 PM, Laurent Vivier wrote: > Following the same logic as for vhost-net-user and vhost-kernel, > enable vhost-net if vhost-net-vdpa is enabled and vhost-net is not > explicitly disabled. > See 299e6f19b3e2 ("vhost-net: revamp configure logic") > > Autoselect VHOST if VHOST_VDPA is s

Re: [PATCH 00/16] hw/block/nvme: zoned namespace command set

2020-09-25 Thread Klaus Jensen
On Sep 24 15:43, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200924204516.1881843-1-...@irrelevant.dk/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20200924204516.18818

Re: [PATCH 1/1] tcg: Adjust simd_desc size encoding

2020-09-25 Thread Frank Chang
On Tue, Sep 1, 2020 at 6:29 AM Richard Henderson < richard.hender...@linaro.org> wrote: > With larger vector sizes, it turns out oprsz == maxsz, and we only > need to represent mismatch for oprsz <= 32. We do, however, need > to represent larger oprsz and do so without reducing SIMD_DATA_BITS. >

Re: [PATCH] configure: Fix build dependencies with vhost-vdpa.

2020-09-25 Thread Paolo Bonzini
On 24/09/20 23:00, Laurent Vivier wrote: > Following the same logic as for vhost-net-user and vhost-kernel, > enable vhost-net if vhost-net-vdpa is enabled and vhost-net is not > explicitly disabled. > See 299e6f19b3e2 ("vhost-net: revamp configure logic") > > Autoselect VHOST if VHOST_VDPA is set

Re: [PATCH v9 4/7] scripts: add block-coroutine-wrapper.py

2020-09-25 Thread Vladimir Sementsov-Ogievskiy
24.09.2020 21:54, Vladimir Sementsov-Ogievskiy wrote: We have a very frequent pattern of creating a coroutine from a function with several arguments: - create a structure to pack parameters - create _entry function to call original function taking parameters from struct - do differ

Re: [PATCH v9 0/7] coroutines: generate wrapper code

2020-09-25 Thread Vladimir Sementsov-Ogievskiy
24.09.2020 23:32, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200924185414.28642-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can pro

Re: virtiofs vs 9p performance

2020-09-25 Thread Christian Schoenebeck
On Freitag, 25. September 2020 00:10:23 CEST Vivek Goyal wrote: > In my testing, with cache=none, virtiofs performed better than 9p in > all the fio jobs I was running. For the case of cache=auto for virtiofs > (with xattr enabled), 9p performed better in certain write workloads. I > have identifi

RE: [PATCH v1 0/3] Remove the limitation of Intel PT CPUID info

2020-09-25 Thread Kang, Luwei
> > > > > > Hi Eduardo, > > > > > > This patch set will remove some limitations of Intel PT > > > > > > CPUID > > > information. > > > > > > 1. The "IP payloads" feature will disable the Intel PT in > > > > > > guests and it will be > > > > > coming soon. > > > > > > 2. To make the live

Re: [RFC PATCH v3 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

2020-09-25 Thread Gerd Hoffmann
On Thu, Sep 24, 2020 at 01:04:19PM +0200, Igor Mammedov wrote: > On Thu, 24 Sep 2020 09:00:08 +0200 > Julia Suvorova wrote: > > > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > > Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. > > Gerd, > > does picked IO range loo

Re: [RFC v4 53/70] target/riscv: rvv-1.0: floating-point slide instructions

2020-09-25 Thread Frank Chang
On Sun, Aug 30, 2020 at 4:33 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/17/20 1:49 AM, frank.ch...@sifive.com wrote: > > +DEF_HELPER_6(vfslide1up_vf_h, void, ptr, ptr, i64, ptr, env, i32) > > +DEF_HELPER_6(vfslide1up_vf_w, void, ptr, ptr, i64, ptr, env, i32) > > +DEF_HELPER

Re: [PATCH v4] hw/i386/pc: add max combined fw size as machine configuration option

2020-09-25 Thread Gerd Hoffmann
Hi, > > +pcms->max_fw_size = 8 * MiB; /* use default */ [ ... ] > All I'm saying is that the "/* use default */" comment should not be > copied from "max_ram_below_4g" to "max_fw_size", because the (assumed) > meaning of the original comment does not apply to the new field. Fully agree.

Re: [PATCH v6 11/15] iotests: add 298 to test new preallocate filter driver

2020-09-25 Thread Max Reitz
On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/298 | 186 + > tests/qemu-iotests/298.out | 5 + > tests/qemu-iotests/group | 1 + > 3 files changed, 192 insertions(+) >

[PATCH 0.5/7] include/block/block.h: drop non-ascii quotation mark

2020-09-25 Thread Vladimir Sementsov-Ogievskiy
This is the only non-ascii character in the file and it doesn't really needed here. Let's use normal "'" symbol for consistency with the rest 11 occurrences of "'" in the file. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH v2 0/3] qga: add command guest-get-disk

2020-09-25 Thread Tomáš Golembiovský
gentle reminder On Mon, Sep 07, 2020 at 11:14:39AM +0200, Tomáš Golembiovský wrote: > Adds command to list disks of the VM. > > The patch does compile on master but to work properly it requires changes to > qemu-ga by Thomas Huth in series: Allow guest-get-fsinfo also for non-PCI > devices. > >

[PATCH v3 1/1] accel/tcg: Fix computing of is_write for MIPS

2020-09-25 Thread Kele Huang
Detect all MIPS store instructions in cpu_signal_handler for all available MIPS versions, and set is_write if encountering such store instructions. This fixed the error while dealing with self-modified code for MIPS. Signed-off-by: Kele Huang Signed-off-by: Xu Zou --- accel/tcg/user-exec.c | 3

Re: [PATCH v2 1/1] accel/tcg: Fix computing of is_write for mips

2020-09-25 Thread Kele Huang
Got it. Thank you again! I have resend a brand new v3 patch. On Thu, 24 Sep 2020 at 22:05, Richard Henderson < richard.hender...@linaro.org> wrote: > On 9/23/20 2:38 AM, Kele Huang wrote: > > Detect mips store instructions in cpu_signal_handler for all MIPS > > versions, and set is_write if encou

Re: [PATCH] docs: add 'io_uring' option to 'aio' param in qemu-options.hx

2020-09-25 Thread Stefan Hajnoczi
On Thu, Sep 24, 2020 at 05:15:11PM +0200, Stefano Garzarella wrote: > When we added io_uring AIO engine, we forgot to update qemu-options.hx, > so qemu(1) man page and qemu help were outdated. > > Signed-off-by: Stefano Garzarella > --- > qemu-options.hx | 10 ++ > 1 file changed, 6 inse

Re: SEV guest debugging support for Qemu

2020-09-25 Thread Dr. David Alan Gilbert
* Ashish Kalra (ashish.ka...@amd.com) wrote: > On Thu, Sep 24, 2020 at 02:37:33PM -0500, Brijesh Singh wrote: > > > > On 9/24/20 2:06 PM, Ashish Kalra wrote: > > > Hello Dave, > > > > > > Thanks for your response, please see my replies inline : > > > > > > On Thu, Sep 24, 2020 at 02:53:42PM +0100,

Re: [PATCH v7 0/5] fix & merge block_status_above and is_allocated_above

2020-09-25 Thread Vladimir Sementsov-Ogievskiy
It's all because underlying "[PATCH v9 0/7] coroutines: generate wrapper code" series, I've answered in "[PATCH v9 0/7] coroutines: generate wrapper code" thread. 25.09.2020 00:45, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200924194003.22080-1-vsement...@virtuozzo.com

Re: [PULL 00/13] Block patches

2020-09-25 Thread Stefan Hajnoczi
On Wed, Sep 23, 2020 at 01:28:47PM -0700, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200923161031.69474-1-stefa...@redhat.com/ checkpatch is warning about pre-existing issues. Stefan signature.asc Description: PGP signature

Re: [PATCH v2 00/31] block/export: Add infrastructure and QAPI for block exports

2020-09-25 Thread Stefan Hajnoczi
On Thu, Sep 24, 2020 at 10:21:56AM -0700, no-re...@patchew.org wrote: > ERROR: "(foo*)" should be "(foo *)" > #156: FILE: blockdev-nbd.c:224: > +return (BlockExport*) exp; [...] > ERROR: "(foo*)" should be "(foo *)" > #49: FILE: blockdev-nbd.c:239: > +blk_exp_unref((BlockExport*) exp); The

Re: [PATCH v6 11/15] iotests: add 298 to test new preallocate filter driver

2020-09-25 Thread Vladimir Sementsov-Ogievskiy
25.09.2020 11:26, Max Reitz wrote: On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/298 | 186 + tests/qemu-iotests/298.out | 5 + tests/qemu-iotests/group | 1 + 3 files

Re: [PATCH] tests/vm: Add Haiku test based on their vagrant images

2020-09-25 Thread Philippe Mathieu-Daudé
Hi Alexander, On 9/6/20 4:41 PM, Alexander von Gluck IV wrote: > September 6, 2020 9:35 AM, "Alexander von Gluck IV" > wrote: >> Signed-off-by: Alexander von Gluck IV >> --- >> tests/keys/vagrant | 27 + >> tests/keys/vagrant.pub | 1 + >> tests/vm/basevm.py | 5 +- >> tests/vm/haiku.x86_6

Re: SEV guest debugging support for Qemu

2020-09-25 Thread Paolo Bonzini
On 22/09/20 22:11, Ashish Kalra wrote: > This internally invokes the address_space_rw() accessor functions > which we had "fixed" internally (as part of the earlier patch) to > invoke memory region specific debug ops. In our earlier approach we > were adding debug ops/callbacks to memory regions a

Re: [PATCH v2 00/31] block/export: Add infrastructure and QAPI for block exports

2020-09-25 Thread Stefan Hajnoczi
On Thu, Sep 24, 2020 at 05:26:46PM +0200, Kevin Wolf wrote: > We are planning to add more block export types than just NBD in the near > future (e.g. vhost-user-blk and FUSE). This series lays the ground for > this with some generic block export infrastructure and QAPI interfaces > that will allow

Re: [RFC v4 17/70] target/riscv: rvv-1.0: configure instructions

2020-09-25 Thread Frank Chang
On Mon, Aug 17, 2020 at 4:50 PM wrote: > From: Frank Chang > > Signed-off-by: Frank Chang > Reviewed-by: Richard Henderson > --- > target/riscv/insn_trans/trans_rvv.inc.c | 12 > target/riscv/vector_helper.c| 14 +- > 2 files changed, 21 insertions(+), 5 d

Re: [PATCH v6 12/15] scripts/simplebench: support iops

2020-09-25 Thread Max Reitz
On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote: > Support benchmarks returning not seconds but iops. We'll use it for > further new test. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > scripts/simplebench/simplebench.py | 35 +++--- > 1 file changed, 27 in

Re: [PATCH v3 05/47] qapi/doc.py: Change code templates from function to string

2020-09-25 Thread Markus Armbruster
John Snow writes: > For whatever reason, when these are stored as functions instead of > strings, it confuses sphinx-autodoc into believing them to be > docstrings, and it chokes on the syntax. > > Keeping them as dumb strings instead avoids the problem. > > Signed-off-by: John Snow Quoting my

Re: [PATCH] tests/vm: Add Haiku test based on their vagrant images

2020-09-25 Thread Philippe Mathieu-Daudé
On 9/25/20 10:49 AM, Philippe Mathieu-Daudé wrote: > Hi Alexander, > > On 9/6/20 4:41 PM, Alexander von Gluck IV wrote: >> September 6, 2020 9:35 AM, "Alexander von Gluck IV" >> wrote: >>> Signed-off-by: Alexander von Gluck IV >>> --- >>> tests/keys/vagrant | 27 + >>> tests/keys/vagrant

Re: [PATCH V1 11/32] cpu: disable ticks when suspended

2020-09-25 Thread Dr. David Alan Gilbert
* Steven Sistare (steven.sist...@oracle.com) wrote: > On 9/11/2020 1:53 PM, Dr. David Alan Gilbert wrote: > > * Steve Sistare (steven.sist...@oracle.com) wrote: > >> After cprload, the guest console misbehaves. You must type 8 characters > >> before any are echoed to the terminal. Qemu was not se

Re: [PATCH v3 1/1] accel/tcg: Fix computing of is_write for MIPS

2020-09-25 Thread Philippe Mathieu-Daudé
Cc'ing TCG MIPS maintainers *again*. On 9/25/20 10:33 AM, Kele Huang wrote: > Detect all MIPS store instructions in cpu_signal_handler for all available > MIPS versions, and set is_write if encountering such store instructions. > > This fixed the error while dealing with self-modified code for MI

Re: [PATCH V1 01/32] savevm: add vmstate handler iterators

2020-09-25 Thread Dr. David Alan Gilbert
* Steven Sistare (steven.sist...@oracle.com) wrote: > On 9/11/2020 12:24 PM, Dr. David Alan Gilbert wrote: > > Apologies for taking a while to get around to this, > > > > * Steve Sistare (steven.sist...@oracle.com) wrote: > >> Provide the SAVEVM_FOREACH and SAVEVM_FORALL macros to loop over all s

[PATCH v3 2/2] vhost-vdpa: add trace-events

2020-09-25 Thread Laurent Vivier
Add trace functions in vhost-vdpa.c. All traces from this file can be enabled with '-trace vhost_vdpa*'. Acked-by: Stefan Hajnoczi Signed-off-by: Laurent Vivier --- hw/virtio/trace-events | 31 ++ hw/virtio/vhost-vdpa.c | 92 +++--- 2 files chang

Re: [PATCH v6 11/15] iotests: add 298 to test new preallocate filter driver

2020-09-25 Thread Max Reitz
On 25.09.20 10:49, Vladimir Sementsov-Ogievskiy wrote: > 25.09.2020 11:26, Max Reitz wrote: >> On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote: >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>>   tests/qemu-iotests/298 | 186 + >>>   tests/qem

[PATCH v3 0/2] vhost-vdpa: add trace functions in vhost-vdpa.c

2020-09-25 Thread Laurent Vivier
Add trace events functions in vdpa functions. Modify qemu_hexdump() to be able to dump the vdpa config in trace logs in hexadecimal form. v3: fix typo in commit message trace vhost_vdpa_dma_map() and vhost_vdpa_dma_unmap() v2: fix problems reported by checkpatch (TAB, missing 0x and 80+ line

[PATCH v3 1/2] util/hexdump: introduce qemu_hexdump_line()

2020-09-25 Thread Laurent Vivier
Dumping one line of hexadecimal/ASCII from a buffer is often needed. Move this part from qemu_hexdump() and use it Acked-by: Stefan Hajnoczi Signed-off-by: Laurent Vivier --- include/qemu-common.h | 8 +++ util/hexdump.c| 54 +++ 2 files chan

Re: [PATCH 6/8] softfloat: Implement float128_muladd

2020-09-25 Thread David Hildenbrand
On 24.09.20 15:30, Richard Henderson wrote: > On 9/24/20 12:56 AM, David Hildenbrand wrote: >> I do wonder if a type for Int256 would make sense - instead of > manually >> passing these arrays. > > I could do that. It does name better, I suppose, in passing. So long as > you're happy having the

Re: [PATCH 3/7] s390x/pci: create a header dedicated to PCI CLP

2020-09-25 Thread Cornelia Huck
On Sat, 19 Sep 2020 11:34:28 -0400 Matthew Rosato wrote: > From: Pierre Morel > > To have a clean separation between s390-pci-bus.h and s390-pci-inst.h > headers we export the PCI CLP instructions in a dedicated header. > > Signed-off-by: Pierre Morel > Signed-off-by: Matthew Rosato > --- >

Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort

2020-09-25 Thread Markus Armbruster
John Snow writes: > While we're mucking around with imports, we might as well formalize the > style we use. Let's use isort to do it for us. > > force_sort_within_sections: Intermingles "from x" and "import x" style > statements, such that sorting is always performed strictly on the module > name

Re: [PATCH 4/4] qemu/bswap: Remove dependency

2020-09-25 Thread Philippe Mathieu-Daudé
On 9/24/20 9:33 PM, Peter Maydell wrote: > On Thu, 24 Sep 2020 at 20:30, Richard Henderson > wrote: >> >> On 9/23/20 3:30 AM, Philippe Mathieu-Daudé wrote: >>> On 9/23/20 12:16 PM, Peter Maydell wrote: I suppose if we wanted to just use the __builtin_bswap* implementation on all hosts (i

Re: [PATCH V1 04/32] savevm: HMP Command for cprsave

2020-09-25 Thread Dr. David Alan Gilbert
* Steven Sistare (steven.sist...@oracle.com) wrote: > On 9/11/2020 12:57 PM, Dr. David Alan Gilbert wrote: > > * Steve Sistare (steven.sist...@oracle.com) wrote: > >> Enable HMP access to the cprsave QMP command. > >> > >> Usage: cprsave > >> > >> Signed-off-by: Maran Wilson > >> Signed-off-by:

Re: [PATCH v6 13/15] scripts/simplebench: improve view of ascii table

2020-09-25 Thread Max Reitz
On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote: > Introduce dynamic float precision and use percentage to show delta. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > scripts/simplebench/simplebench.py | 26 +- > 1 file changed, 25 insertions(+), 1 deletion(

[PATCH v3 2/2] arm64: kvm: Introduce MTE VCPU feature

2020-09-25 Thread Steven Price
Add a new VM feature 'KVM_ARM_CAP_MTE' which enables memory tagging for a VM. This exposes the feature to the guest and automatically tags memory pages touched by the VM as PG_mte_tagged (and clears the tags storage) to ensure that the guest cannot see stale tags, and so that the tags are correctly

[PATCH v3 1/2] arm64: kvm: Save/restore MTE registers

2020-09-25 Thread Steven Price
Define the new system registers that MTE introduces and context switch them. The MTE feature is still hidden from the ID register as it isn't supported in a VM yet. Signed-off-by: Steven Price --- arch/arm64/include/asm/kvm_host.h | 4 arch/arm64/include/asm/sysreg.h|

[PATCH v3 0/2] MTE support for KVM guest

2020-09-25 Thread Steven Price
Version 3 of adding MTE support for KVM guests. See the previous (v2) posting for background: https://lore.kernel.org/r/20200904160018.29481-1-steven.price%40arm.com These patches add support to KVM to enable MTE within a guest. They are based on Catalin's v9 MTE user-space support series[1] (cu

Re: [PATCH 4/7] s390x/pci: use a PCI Group structure

2020-09-25 Thread Cornelia Huck
On Sat, 19 Sep 2020 11:34:29 -0400 Matthew Rosato wrote: > From: Pierre Morel > > We use a S390PCIGroup structure to hold the information related to a > zPCI Function group. > > This allows us to be ready to support multiple groups and to retrieve > the group information from the host. > > Si

Re: [PATCH] build: Build and install the info manual.

2020-09-25 Thread Peter Maydell
On Fri, 25 Sep 2020 at 07:27, Maxim Cournoyer wrote: > > Take advantage of the Sphinx texinfo backend to generate a QEMU info > manual. The texinfo format allows for more structure and info readers > provide more advanced navigation capabilities compared to manpages > readers. Not providing an i

Re: [PULL 00/13] Block patches

2020-09-25 Thread Peter Maydell
On Wed, 23 Sep 2020 at 17:10, Stefan Hajnoczi wrote: > > The following changes since commit 0fc0142828b5bc965790a1c5c6e241897d3387cb: > > Merge remote-tracking branch > 'remotes/kraxel/tags/input-20200921-pull-request' into staging (2020-09-22 > 21:11:10 +0100) > > are available in the Git rep

Re: [PULL 00/11] capstone + disassembler patch queue

2020-09-25 Thread Peter Maydell
On Tue, 22 Sep 2020 at 18:47, Richard Henderson wrote: > > The following changes since commit 834b9273d5cdab68180dc8c84d641aaa4344b057: > > Merge remote-tracking branch > 'remotes/vivier2/tags/trivial-branch-for-5.2-pull-request' into staging > (2020-09-22 15:42:23 +0100) > > are available in

Re: [PULL 00/92] Misc patches for 2020-09-24

2020-09-25 Thread Peter Maydell
On Thu, 24 Sep 2020 at 10:27, Paolo Bonzini wrote: > > The following changes since commit 0fc0142828b5bc965790a1c5c6e241897d3387cb: > > Merge remote-tracking branch > 'remotes/kraxel/tags/input-20200921-pull-request' into staging (2020-09-22 > 21:11:10 +0100) > > are available in the Git repos

Re: [PATCH v1 0/5] virtio-mem: block size and address-assignment optimizations

2020-09-25 Thread David Hildenbrand
On 23.09.20 13:38, David Hildenbrand wrote: > Let's try to detect the actual THP size and use it as default block size > (unless the page size of the backend is bigger). Handle large block sizes > better, avoiding a virtio-spec violation and optimizing address > auto-detection. > > David Hildenbra

[PATCH 07/14] hw/misc/bcm2835_cprman: add a PLL channel skeleton implementation

2020-09-25 Thread Luc Michel
PLLs are composed of multiple channels. Each channel outputs one clock signal. They are modeled as one device taking the PLL generated clock as input, and outputting a new clock. A channel shares the cm register with its parent PLL, and has its own a2w_ctrl register. A write to the cm register wil

[PATCH 01/14] hw/core/clock: provide the VMSTATE_ARRAY_CLOCK macro

2020-09-25 Thread Luc Michel
Signed-off-by: Luc Michel --- include/hw/clock.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/hw/clock.h b/include/hw/clock.h index d357594df9..c93e6113cd 100644 --- a/include/hw/clock.h +++ b/include/hw/clock.h @@ -79,10 +79,15 @@ struct Clock { extern const VMStateDescripti

[PATCH 00/14] raspi: add the bcm2835 cprman clock manager

2020-09-25 Thread Luc Michel
Hi, This series add the BCM2835 cprman clock manager peripheral to the Raspberry Pi machine. Patches 1-3 are preliminary changes, patches 4-12 are the actual implementation. The two last patches add a clock input to the PL011 and connect it to the cprman and are RFC. This series has been tested

[PATCH 06/14] hw/misc/bcm2835_cprman: implement PLLs behaviour

2020-09-25 Thread Luc Michel
The cprman PLLs generate a clock based on a prescaler, a multiplier and a divider. The prescaler doubles the parent (xosc) frequency, then the multiplier/divider are applied. The multiplier has an integer and a fractionnal part. This commit also implements the cprman CM_LOCK register. This registe

[PATCH 02/14] hw/core/clock: trace clock values in Hz instead of ns

2020-09-25 Thread Luc Michel
The nanosecond unit greatly limits the dynamic range we can display in clock value traces, for values in the order of 1GHz and more. The internal representation can go way beyond this value and it is quite common for today's clocks to be within those ranges. For example, a frequency between 500MHz

[PATCH 04/14] hw/arm/raspi: add a skeleton implementation of the cprman

2020-09-25 Thread Luc Michel
The BCM2835 cprman is the clock manager of the SoC. It is composed of a main oscillator, and several sub-components (PLLs, multiplexers, ...) to generate the BCM2835 clock tree. This commit adds a skeleton of the cprman, with a dummy register read/write implementation. It embeds the main oscillato

[PATCH 10/14] hw/misc/bcm2835_cprman: implement clock mux behaviour

2020-09-25 Thread Luc Michel
A clock mux can be configured to select one of its 10 sources through the cm_ctl register. It also embeds yet another clock divider, composed of an integer part and a fractionnal part. The number of bits of each part is mux dependant. Signed-off-by: Luc Michel --- hw/misc/bcm2835_cprman.c | 43 +

[PATCH 11/14] hw/misc/bcm2835_cprman: add the DSI0HSCK multiplexer

2020-09-25 Thread Luc Michel
This simple mux sits between the PLL channels and the DSI0E and DSI0P clock muxes. This mux selects between PLLA-DSI0 and PLLD-DSI0 channel and outputs the selected signal to source number 4 of DSI0E/P clock muxes. It is controlled by the cm_dsi0hsck register. Signed-off-by: Luc Michel --- inclu

[PATCH 03/14] hw/arm/raspi: fix cprman base address

2020-09-25 Thread Luc Michel
The cprman (clock controller) was mapped at the watchdog/power manager address. It was also split into two unimplemented peripherals (cm and a2w) but this is really the same one, as shown by this extract of the Raspberry Pi 3 Linux device tree: watchdog@7e10 { compatible = "brc

[RFC PATCH 13/14] hw/char/pl011: add a clock input

2020-09-25 Thread Luc Michel
Add a clock input to the PL011 UART so we can compute the current baud rate and trace it. This is intended for developers who wish to use QEMU to e.g. debug their firmware or to figure out the baud rate configured by an unknown/closed source binary. Signed-off-by: Luc Michel --- include/hw/char/

[PATCH 08/14] hw/misc/bcm2835_cprman: implement PLL channels behaviour

2020-09-25 Thread Luc Michel
A PLL channel is able to further divide the generated PLL frequency. The divider is given in the ctrl_a2w register. Some channels have a additional fixed divider which is always applied to the signal. Signed-off-by: Luc Michel --- hw/misc/bcm2835_cprman.c | 33 -

Re: [PATCH] virtio-pmem-pci: force virtio version 1

2020-09-25 Thread David Hildenbrand
On 25.09.20 12:22, Pankaj Gupta wrote: > Qemu fails with below error when trying to run with virtio pmem: > > (qemu) qemu-system-x86_64: -device virtio-pmem-pci,memdev=mem1,id=nv1: > device is modern-only, use disable-legacy=on > > This patch fixes this by forcing virtio 1 with virtio-pmem.

[PATCH 05/14] hw/misc/bcm2835_cprman: add a PLL skeleton implementation

2020-09-25 Thread Luc Michel
There is 5 PLLs in the cprman, namely PLL A, C, D, H and B. All of them take the xosc clock as input and produce a new clock. This commit adds a skeleton implementation for the PLLs as sub-devices of the cprman. The PLLs are instantiated and connected internally to the main oscillator. Each PLL h

[RFC PATCH 14/14] hw/arm/bcm2835_peripherals: connect the UART clock

2020-09-25 Thread Luc Michel
Connect the 'uart-out' clock from the cprman to the PL011 instance. Signed-off-by: Luc Michel --- hw/arm/bcm2835_peripherals.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c index 958aadeeb9..9e4e85c3ad 100644 --- a/hw/arm/bcm283

[PATCH 09/14] hw/misc/bcm2835_cprman: add a clock mux skeleton implementation

2020-09-25 Thread Luc Michel
The clock multiplexers are the last clock stage in the cprman. Each mux outputs one clock signal that goes out of the cprman to the SoC peripherals. Each mux has at most 10 sources. The sources 0 to 3 are common to all muxes. They are: 0. ground (no clock signal) 1. the main oscillator (xosc

[PATCH 12/14] hw/misc/bcm2835_cprman: add sane reset values to the registers

2020-09-25 Thread Luc Michel
Those reset values have been extracted from a Raspberry Pi 3 model B v1.2, using the 2020-08-20 version of raspios. The dump was done using the debugfs interface of the cprman driver in Linux (under '/sys/kernel/debug/clk'). Each exposed clock tree stage (PLLs, channels and muxes) can be observed b

[PULL v2 00/92] Misc patches for 2020-09-24

2020-09-25 Thread Paolo Bonzini
The following changes since commit 8c1c07929feae876202ba26f07a540c5115c18cd: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-09-24 18:48:45 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for yo

[PATCH] virtio-pmem-pci: force virtio version 1

2020-09-25 Thread Pankaj Gupta
Qemu fails with below error when trying to run with virtio pmem: (qemu) qemu-system-x86_64: -device virtio-pmem-pci,memdev=mem1,id=nv1: device is modern-only, use disable-legacy=on This patch fixes this by forcing virtio 1 with virtio-pmem. fixes: adf0748a49 ("virtio-pci: Proxy for virtio-

Re: [PATCH v6 14/15] scripts/simplebench: improve ascii table: add difference line

2020-09-25 Thread Max Reitz
On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote: > Performance improvements / degradations are usually discussed in > percentage. Let's make the script calculate it for us. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > scripts/simplebench/simplebench.py | 46 +

Re: [RFC PATCH 13/14] hw/char/pl011: add a clock input

2020-09-25 Thread Philippe Mathieu-Daudé
On 9/25/20 12:17 PM, Luc Michel wrote: > Add a clock input to the PL011 UART so we can compute the current baud > rate and trace it. This is intended for developers who wish to use QEMU > to e.g. debug their firmware or to figure out the baud rate configured > by an unknown/closed source binary. >

Re: [PATCH] virtio-pmem-pci: force virtio version 1

2020-09-25 Thread Cornelia Huck
On Fri, 25 Sep 2020 12:22:51 +0200 Pankaj Gupta wrote: > Qemu fails with below error when trying to run with virtio pmem: > > (qemu) qemu-system-x86_64: -device virtio-pmem-pci,memdev=mem1,id=nv1: > device is modern-only, use disable-legacy=on Oh, another one :( > > This patch fixes thi

Re: [PULL v2 00/92] Misc patches for 2020-09-24

2020-09-25 Thread Peter Maydell
On Fri, 25 Sep 2020 at 11:33, Paolo Bonzini wrote: > > The following changes since commit 8c1c07929feae876202ba26f07a540c5115c18cd: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2020-09-24 18:48:45 +0100) > > are available in the Git repository at:

Re: [PATCH v6 15/15] scripts/simplebench: add bench_prealloc.py

2020-09-25 Thread Max Reitz
On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote: > Benchmark for new preallocate filter. > > Example usage: > ./bench_prealloc.py ../../build/qemu-img \ > ssd-ext4:/path/to/mount/point \ > ssd-xfs:/path2 hdd-ext4:/path3 hdd-xfs:/path4 > > The benchmark shows performance

[PULL v3 00/92] Misc patches for 2020-09-24

2020-09-25 Thread Paolo Bonzini
The following changes since commit 8c1c07929feae876202ba26f07a540c5115c18cd: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-09-24 18:48:45 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for yo

Re: [PULL v2 00/92] Misc patches for 2020-09-24

2020-09-25 Thread Paolo Bonzini
On 25/09/20 12:45, Peter Maydell wrote: > On Fri, 25 Sep 2020 at 11:33, Paolo Bonzini wrote: >> >> The following changes since commit 8c1c07929feae876202ba26f07a540c5115c18cd: >> >> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' >> into staging (2020-09-24 18:48:45 +010

Re: [PATCH v2 02/38] qapi-gen: Separate arg-parsing from generation

2020-09-25 Thread Markus Armbruster
Cleber Rosa writes: > On Tue, Sep 22, 2020 at 05:00:25PM -0400, John Snow wrote: >> This is a minor re-work of the entrypoint script. It isolates a >> generate() method from the actual command-line mechanism. >> >> Signed-off-by: John Snow >> --- >> scripts/qapi-gen.py | 87 +++

Re: [Virtio-fs] tools/virtiofs: Multi threading seems to hurt performance

2020-09-25 Thread Dr. David Alan Gilbert
* Chirantan Ekbote (chiran...@chromium.org) wrote: > On Sat, Sep 19, 2020 at 6:36 AM Vivek Goyal wrote: > > > > Hi All, > > > > virtiofsd default thread pool size is 64. To me it feels that in most of > > the cases thread pool size 1 performs better than thread pool size 64. > > > > I ran virtiofs

Re: [PULL v2 00/92] Misc patches for 2020-09-24

2020-09-25 Thread Peter Maydell
On Fri, 25 Sep 2020 at 11:45, Peter Maydell wrote: > > On Fri, 25 Sep 2020 at 11:33, Paolo Bonzini wrote: > > Date: Fri Sep 25 11:41:22 2020 +0100 > Signed-off-by: Philippe Mathieu-Daudé > ERROR: pull request includes tag with UTF-8 error in person name > > (that's "configure: Do not inten

Re: [PATCH] virtio-pmem-pci: force virtio version 1

2020-09-25 Thread Pankaj Gupta
> > > Qemu fails with below error when trying to run with virtio pmem: > > > > (qemu) qemu-system-x86_64: -device virtio-pmem-pci,memdev=mem1,id=nv1: > > device is modern-only, use disable-legacy=on > > Oh, another one :( :) > > > > > This patch fixes this by forcing virtio 1 with virtio-pmem.

Re: [PATCH v2 0/6] migration/postcopy: Sync faulted addresses after network recovered

2020-09-25 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Peter Xu (pet...@redhat.com) wrote: > > v2: > > Queued Hi Peter, I've had to unqueue most of this; it doesn't like building on 32bit. I fixed up the trace_ stuff easily (_del can take a void*, add just needs to use PRIX64) but there are

Re: [PATCH v2 09/38] qapi/common.py: Add indent manager

2020-09-25 Thread Markus Armbruster
John Snow writes: > On 9/22/20 6:22 PM, Eduardo Habkost wrote: >> On Tue, Sep 22, 2020 at 05:00:32PM -0400, John Snow wrote: >>> Code style tools really dislike the use of global keywords, because it >>> generally involves re-binding the name at runtime which can have strange >>> effects dependin

Re: [PATCH v26 07/17] vfio: Register SaveVMHandlers for VFIO device

2020-09-25 Thread Cornelia Huck
On Wed, 23 Sep 2020 04:54:09 +0530 Kirti Wankhede wrote: > Define flags to be used as delimeter in migration file stream. > Added .save_setup and .save_cleanup functions. Mapped & unmapped migration > region from these functions at source during saving or pre-copy phase. > Set VFIO device state d

Re: [PATCH v2 09/38] qapi/common.py: Add indent manager

2020-09-25 Thread Markus Armbruster
John Snow writes: > On 9/23/20 10:55 AM, Cleber Rosa wrote: >> Do you have a use case for returning the level? If not, I'd go >> without it, and add a "level" property instead, as it'd serve more >> cases. > > __int__ is doing that lifting. I can remove the return. I like my functions to return

Re: [PATCH 00/14] raspi: add the bcm2835 cprman clock manager

2020-09-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200925101731.2159827-1-...@lmichel.fr/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

[PULL v4 00/92] Misc patches for 2020-09-24

2020-09-25 Thread Paolo Bonzini
The following changes since commit 8c1c07929feae876202ba26f07a540c5115c18cd: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-09-24 18:48:45 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for yo

[PULL 01/26] migration: Properly destroy variables on incoming side

2020-09-25 Thread Dr. David Alan Gilbert (git)
From: Peter Xu In migration_incoming_state_destroy(), we've got a few variables that aren't destroyed properly, namely: main_thread_load_event postcopy_pause_sem_dst postcopy_pause_sem_fault rp_mutex Destroy them properly. Signed-off-by: Peter Xu Message-Id: <20200908203022.34

[PULL 04/26] migration/dirtyrate: add DirtyRateStatus to denote calculation status

2020-09-25 Thread Dr. David Alan Gilbert (git)
From: Chuan Zheng add DirtyRateStatus to denote calculating status. Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Li Qiang Message-Id: <1600237327-33618-3-git-send-email-zhengch...@huawei.com> Signed-off-by: Dr. David Alan Gilbert atomic name fixup --- migrat

[PULL 00/26] migration and friends queue

2020-09-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit 8c1c07929feae876202ba26f07a540c5115c18cd: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-09-24 18:48:45 +0100) are available in the Git repository at: git://github.com/dagrh/qemu.

[PULL 09/26] migration/dirtyrate: Compare page hash results for recorded sampled page

2020-09-25 Thread Dr. David Alan Gilbert (git)
From: Chuan Zheng Compare page hash results for recorded sampled page. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Li Qiang Message-Id: <1600237327-33618-8-git-send-email-zhengch...@huawei.com> Signed-off-by: Dr. David Alan Gilber

[PULL 02/26] migration: Rework migrate_send_rp_req_pages() function

2020-09-25 Thread Dr. David Alan Gilbert (git)
From: Peter Xu We duplicated the logic of maintaining the last_rb variable at both callers of this function. Pass *rb pointer into the function so that we can avoid duplicating the logic. Also, when we have the rb pointer, it's also easier to remove the original 2nd & 4th parameters, because bo

[PULL 06/26] migration/dirtyrate: Add dirtyrate statistics series functions

2020-09-25 Thread Dr. David Alan Gilbert (git)
From: Chuan Zheng Add dirtyrate statistics functions to record/update dirtyrate info. Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Li Qiang Message-Id: <1600237327-33618-5-git-send-email-zhengch...@huawei.com> Signed-off-by: Dr. David Alan Gilbert --- migratio

[PULL 11/26] migration/dirtyrate: Implement set_sample_page_period() and is_sample_period_valid()

2020-09-25 Thread Dr. David Alan Gilbert (git)
From: Chuan Zheng Implement is_sample_period_valid() to check if the sample period is vaild and do set_sample_page_period() to sleep specific time between sample actions. Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert Reviewed-by: David Edmondson Reviewed-by: Li Qiang Message

[PULL 03/26] migration/dirtyrate: setup up query-dirtyrate framwork

2020-09-25 Thread Dr. David Alan Gilbert (git)
From: Chuan Zheng Add get_dirtyrate_thread() functions to setup query-dirtyrate framework. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang Reviewed-by: Dr. David Alan Gilbert Reviewed-by: David Edmondson Reviewed-by: Li Qiang Message-Id: <1600237327-33618-2-git-send-email-zhengch..

[PULL 05/26] migration/dirtyrate: Add RamblockDirtyInfo to store sampled page info

2020-09-25 Thread Dr. David Alan Gilbert (git)
From: Chuan Zheng Add RamblockDirtyInfo to store sampled page info of each ramblock. Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert Reviewed-by: David Edmondson Reviewed-by: Li Qiang Message-Id: <1600237327-33618-4-git-send-email-zhengch...@huawei.com> Signed-off-by: Dr. Davi

[PULL 08/26] migration/dirtyrate: Record hash results for each sampled page

2020-09-25 Thread Dr. David Alan Gilbert (git)
From: Chuan Zheng Record hash results for each sampled page, crc32 is taken to calculate hash results for each sampled length in TARGET_PAGE_SIZE. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang Reviewed-by: David Edmondson Reviewed-by: Li Qiang Message-Id: <1600237327-33618-7-git-s

  1   2   3   4   5   >