Re: [PATCH QEMU v25 00/17] Add migration support for VFIO devices

2020-09-23 Thread Zenghui Yu
On 2020/9/23 7:24, Kirti Wankhede wrote: Patch 4-9: - Generic migration functionality for VFIO device. * This patch set adds functionality for PCI devices, but can be extended to other VFIO devices. * Added all the basic functions required for pre-copy, stop-and-copy and resume phase

Looking for a project in i440fx

2020-09-23 Thread Ani Sinha
Hi, Does anyone have any ideas for a project around pci space or PCIE space, preferably in i440fx but for PCIE it can be q35 as well.  I’m basically looking to learn some qemu specific stuff as a hobby project. Thanks in advance, Ani

Re: [PATCH v2 00/20] block/export: Allow exporting BDSs via FUSE

2020-09-23 Thread Max Reitz
On 22.09.20 17:58, Daniel P. Berrangé wrote: > On Tue, Sep 22, 2020 at 12:49:12PM +0200, Max Reitz wrote: >> Based-on: <20200907182011.521007-1-kw...@redhat.com> >> (“block/export: Add infrastructure and QAPI for block exports”) >> >> (Though its patch 16 needs a s/= \&blk_exp_nbd/= drv/

Re: [PATCH v2 1/1] MAINTAINERS: Add Python library stanza

2020-09-23 Thread Philippe Mathieu-Daudé
On 9/23/20 1:05 AM, John Snow wrote: > I'm proposing that I split the actual Python library off from the other > miscellaneous python scripts we have and declare it maintained. Add > myself as a maintainer of this folder, along with Cleber. > > v2: change python/* to python/, thanks Alex. ^ Can y

Re: [PATCH v1 1/8] s390x/tcg: Implement ADD HALFWORD (AGH)

2020-09-23 Thread David Hildenbrand
On 23.09.20 06:53, Thomas Huth wrote: > On 22/09/2020 12.31, David Hildenbrand wrote: >> Easy, just like ADD HALFWORD IMMEDIATE (AGHI). >> >> Signed-off-by: David Hildenbrand >> --- >> target/s390x/insn-data.def | 1 + >> target/s390x/translate.c | 1 + >> 2 files changed, 2 insertions(+) >> >>

[PATCH] hw/i386/acpi-build: Explain bits in OSC method

2020-09-23 Thread Julia Suvorova
Provide a better explanation for the enabled bits in the _OSC control field. Base it on the latest specification due to new bits 5 and 6. Signed-off-by: Julia Suvorova --- hw/i386/acpi-build.h | 11 +++ hw/i386/acpi-build.c | 7 ++- 2 files changed, 17 insertions(+), 1 deletion(-)

Re: [PATCH] Deprecate lm32 port

2020-09-23 Thread Thomas Huth
On 27/08/2020 13.32, Peter Maydell wrote: > Deprecate our lm32 target support. Michael Walle (former lm32 maintainer) > suggested that we do this in 2019: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg605024.html > because the only public user of the architecture is the many-years-dead >

[PATCH] docs/system/deprecated: Move lm32 and unicore32 to the right section

2020-09-23 Thread Thomas Huth
lm32 and unicore32 are softmmut targets, and not linux-user targets. Signed-off-by: Thomas Huth --- docs/system/deprecated.rst | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 0cb8

Re: [PATCH v2 0/2] block: deprecate the sheepdog driver

2020-09-23 Thread Peter Krempa
On Tue, Sep 22, 2020 at 18:42:52 +0100, Daniel Berrange wrote: > On Tue, Sep 22, 2020 at 01:09:06PM -0400, Neal Gompa wrote: > > On Tue, Sep 22, 2020 at 12:16 PM Daniel P. Berrangé > > wrote: > > > > > > 2 years back I proposed dropping the sheepdog mailing list from the > > > MAINTAINERS file,

Re: [PATCH] add maximum combined fw size as machine configuration option

2020-09-23 Thread Laszlo Ersek
On 09/23/20 05:24, Erich Mcmillan wrote: > From: Erich McMillan > > Signed-off-by: Erich McMillan > --- > hw/i386/pc.c | 50 > hw/i386/pc_sysfw.c | 13 ++-- > include/hw/i386/pc.h | 2 ++ > 3 files changed, 54 insertions(+), 11 del

Re: [PATCH] docs/system/deprecated: Move lm32 and unicore32 to the right section

2020-09-23 Thread Philippe Mathieu-Daudé
On 9/23/20 10:00 AM, Thomas Huth wrote: > lm32 and unicore32 are softmmut targets, and not linux-user targets. Typo "softmmu" (else it sounds like soft mammoth targets). Reviewed-by: Philippe Mathieu-Daudé > > Signed-off-by: Thomas Huth > --- > docs/system/deprecated.rst | 32 +++

Re: [PATCH 13/24] i386: Register most CPU properties as class properties

2020-09-23 Thread Igor Mammedov
On Mon, 21 Sep 2020 18:10:34 -0400 Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc

Re: [PATCH 0/9] Audio fixes and improvements

2020-09-23 Thread Gerd Hoffmann
On Sun, Sep 20, 2020 at 07:14:12PM +0200, Volker Rümelin wrote: > A few fixes and improvements from my audio patch queue. cherry-picked 1-7 into the audio queue. thanks, Gerd

Re: [PATCH v2 00/20] block/export: Allow exporting BDSs via FUSE

2020-09-23 Thread Stefan Hajnoczi
On Tue, Sep 22, 2020 at 04:58:38PM +0100, Daniel P. Berrangé wrote: > On Tue, Sep 22, 2020 at 12:49:12PM +0200, Max Reitz wrote: > > Based-on: <20200907182011.521007-1-kw...@redhat.com> > > (“block/export: Add infrastructure and QAPI for block exports”) > > > > (Though its patch 16 needs

[PULL 7/9] audio: run downstream playback queue unconditionally

2020-09-23 Thread Gerd Hoffmann
From: Volker Rümelin Run the downstream playback queue even if there are no samples in the mixing engine buffer. The downstream queue may still have queued samples. Signed-off-by: Volker Rümelin Message-id: 20200920171729.15861-7-vr_q...@t-online.de Signed-off-by: Gerd Hoffmann --- audio/audi

[PULL 0/9] Audio 20200923 patches

2020-09-23 Thread Gerd Hoffmann
The following changes since commit 0fc0142828b5bc965790a1c5c6e241897d3387cb: Merge remote-tracking branch 'remotes/kraxel/tags/input-20200921-pull-reque= st' into staging (2020-09-22 21:11:10 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/audio-202

[PULL 1/9] audio: handle buf == NULL in put_buffer_out()

2020-09-23 Thread Gerd Hoffmann
From: Volker Rümelin With the next patch all audio backends put_buffer_out() functions have to handle the buf == NULL case, provided the get_buffer_out() function may return buf = NULL and size > 0. It turns out that all audio backends get_buffer_out() functions either can't return buf = NULL or

[PULL 3/9] audio/spiceaudio: always rate limit playback stream

2020-09-23 Thread Gerd Hoffmann
From: Volker Rümelin The playback rate with the spiceaudio backend is currently too fast if there's no spice client connected or the spice client can't play audio. Rate limit the audio playback stream in all cases. To calculate the rate correctly the limiter has to know the maximum buffer size.

[PULL 4/9] audio: align audio_generic_read with audio_pcm_hw_run_in

2020-09-23 Thread Gerd Hoffmann
From: Volker Rümelin The function audio_generic_read should work exactly like audio_pcm_hw_run_in. It's a very similar function working on a different buffer. Signed-off-by: Volker Rümelin Message-id: 20200920171729.15861-4-vr_q...@t-online.de Signed-off-by: Gerd Hoffmann --- audio/audio.c |

[PULL 2/9] audio/audio: fix video playback slowdown with spiceaudio

2020-09-23 Thread Gerd Hoffmann
From: Volker Rümelin This patch allows the audio backends get_buffer_out() functions to drop audio data and mitigates a bug reported on the qemu-devel mailing list. https://lists.nongnu.org/archive/html/qemu-devel/2020-09/msg03832.html The new rules for the variables buf and size returned by ge

[PULL 6/9] audio: align audio_generic_write with audio_pcm_hw_run_out

2020-09-23 Thread Gerd Hoffmann
From: Volker Rümelin The function audio_generic_write should work exactly like audio_pcm_hw_run_out. It's a very similar function working on a different buffer. This patch significantly reduces the number of drop-outs with the DirectSound backend. To hear the difference start qemu with -audiodev

[PULL 9/9] audio: build spiceaudio as module

2020-09-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20200916084117.21828-3-kra...@redhat.com --- audio/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/audio/meson.build b/audio/meson.build index 15c06ba0453b..18a831129ed0 100644 --- a/audio/meson.build +++ b/audio/meson.b

[PULL 8/9] audio: remove qemu_spice_audio_init()

2020-09-23 Thread Gerd Hoffmann
Handle the spice special case in audio_init instead. With the qemu_spice_audio_init() symbol dependency being gone we can build spiceaudio as module. Signed-off-by: Gerd Hoffmann Message-id: 20200916084117.21828-2-kra...@redhat.com --- include/ui/qemu-spice.h | 1 - audio/audio.c | 1

[PATCH 03/12] configure: rewrite accelerator defaults as tests

2020-09-23 Thread Paolo Bonzini
Prepare to process "auto" in meson rather than configure: standardize the shape of the code that changes "auto" to enabled/disabled, to ease the review when it will be moved to meson. Signed-off-by: Paolo Bonzini --- configure | 58 --- 1 file

[PATCH 08/12] configure: remove target configuration

2020-09-23 Thread Paolo Bonzini
The config-target.mak files are small constant, we can therefore just write them down explicitly. This removes a pretty large part of the configure script, including the whole logic to detect which accelerators are supported by each target. Signed-off-by: Paolo Bonzini --- configure

[PATCH 02/12] configure: convert accelerator variables to meson options

2020-09-23 Thread Paolo Bonzini
Prepare for moving the tests to meson. For now they only have enabled/disabled as the possible values when meson is invoked, but "auto" will be a possibility later, when configure will only parse the command line options. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- configur

[PATCH 00/12] Move target configuration to Meson

2020-09-23 Thread Paolo Bonzini
With configure+make, the creation of the config-target.h files was detached from the build and had to be shared with config-host.h. With meson, using separate configure_files to format config-host.h and config-target.h comes for free; therefore we can craft the configure_file input independent of w

[PATCH 05/12] configure: remove dead variable

2020-09-23 Thread Paolo Bonzini
Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- configure | 11 --- 1 file changed, 11 deletions(-) diff --git a/configure b/configure index 5df58c4b89..903bbcbc46 100755 --- a/configure +++ b/configure @@ -815,9 +815,6 @@ fi # OS specific -# host *BSD for user mode

[PULL 5/9] audio: remove unnecessary calls to put_buffer_in

2020-09-23 Thread Gerd Hoffmann
From: Volker Rümelin This patch removes unnecessary calls to the pcm_ops function put_buffer_in(). No audio backend needs this call if the returned length of pcm_ops function get_buffer_in() is zero. For the DirectSound backend this prevents a call to dsound_unlock_in() without a preceding call

[PATCH 04/12] configure: move accelerator logic to meson

2020-09-23 Thread Paolo Bonzini
Move to meson the code to detect the presence of accelerators, and to define accelerator-specific config-target.h symbols. The logic for now is duplicated in configure because it is still in use to build the list of targets (which is in turn used to create the config-target.mak files). The next p

[PATCH 01/12] default-configs: move files to default-configs/devices/

2020-09-23 Thread Paolo Bonzini
Make room for target files in default-configs/targets/ Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- configure | 6 +++--- default-configs/{ => devices}/aarch64-linux-user.mak | 0 default-configs/{ => devices}/aarch64-softm

[PATCH 11/12] default-configs: use TARGET_ARCH key

2020-09-23 Thread Paolo Bonzini
Replace the individual TARGET_*=y lines with TARGET_ARCH, similar to how TARGET_BASE_ARCH is handled already. Signed-off-by: Paolo Bonzini --- default-configs/targets/aarch64-linux-user.mak | 2 +- default-configs/targets/aarch64-softmmu.mak | 2 +- default-configs/targets/aarch64_b

[PATCH 10/12] configure: move OpenBSD W^X test to meson

2020-09-23 Thread Paolo Bonzini
The TCG option is now passed through to Meson. Signed-off-by: Paolo Bonzini --- configure | 15 --- meson.build | 8 +++- 2 files changed, 7 insertions(+), 16 deletions(-) diff --git a/configure b/configure index 6e60de3e07..fb450858ff 100755 --- a/configure +++ b/configure @

[PATCH 12/12] default-configs: remove redundant keys

2020-09-23 Thread Paolo Bonzini
TARGET_BASE_ARCH and TARGET_ABI_DIR are 99% of the time the same as TARGET_ARCH, remove them if so. Signed-off-by: Paolo Bonzini --- default-configs/targets/aarch64-linux-user.mak | 1 - default-configs/targets/aarch64_be-linux-user.mak | 1 - default-configs/targets/alpha-linux-user.mak

[PATCH] kvm: remove now unnecessary stubs

2020-09-23 Thread Paolo Bonzini
These two stubs are now used only in accel/kvm/kvm-all.c and accel/kvm/kvm-cpus.c. Signed-off-by: Paolo Bonzini --- accel/stubs/kvm-stub.c | 9 - 1 file changed, 9 deletions(-) diff --git a/accel/stubs/kvm-stub.c b/accel/stubs/kvm-stub.c index 680e099463..d3874526f5 100644 --- a/accel/s

[PATCH 06/12] configure: compute derivatives of target name in meson

2020-09-23 Thread Paolo Bonzini
Several CONFIG_* symbols in config-target.mak are easily computed from just the target name. We do not need them in config-target.mak, and can instead place them in the config_target dictionary only. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson --- configure | 11 +--

[PATCH 09/12] default-configs: remove default-configs/devices for user-mode targets

2020-09-23 Thread Paolo Bonzini
We no longer need dummy files to detect targets, since default-configs/targets/ exists. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson --- configure | 6 +++--- default-configs/devices/aarch64-linux-user.mak | 1 - default-configs/devi

[PATCH 07/12] configure: remove useless config-target.mak symbols

2020-09-23 Thread Paolo Bonzini
Omit symbols that are not needed by softmmu or bsd-user targets, in preparation for moving the generated config-target.mak files into the source tree. Signed-off-by: Paolo Bonzini --- configure | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/config

[PATCH] modules: update qom object module comment

2020-09-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- util/module.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util/module.c b/util/module.c index 520986bd70ff..6df873593f95 100644 --- a/util/module.c +++ b/util/module.c @@ -255,8 +255,10 @@ bool module_load_one(const char *prefix, const c

[PATCH v2 4/4] configure: consistently pass CFLAGS/CXXFLAGS/LDFLAGS to meson

2020-09-23 Thread Paolo Bonzini
Environment variables like CFLAGS are easy to accidentally change. Meson warns if that happens, but in a project with a lot of configuration that is easy to lose. It is also surprising behavior since meson caches -D options and remembers those on reconfiguration (which we rely on, since configure

[PATCH v2] module: silence errors for module_load_qom_all().

2020-09-23 Thread Gerd Hoffmann
Add mayfail bool parameter to module loading functions. Set it to true for module_load_qom_all() because device modules might not load into all system emulation variants. qemu-system-s390x for example will not load qxl because it lacks vga support. Makes "make check" less chatty. Drop module_lo

[PATCH v2 0/4] configure: bugfixes and cleanups for CFLAGS

2020-09-23 Thread Paolo Bonzini
Meson is placing -pie after -shared rather than before, and this causes linking to fail while building the ArchLinux package for QEMU. But why is -pie ending up in the flags? Because LDFLAGS is an environment variable, and changes to environment variables propagate when configure does LDFLAGS=

Re: [PATCH] qemu/atomic.h: prefix qemu_ to solve collisions

2020-09-23 Thread Stefan Hajnoczi
On Tue, Sep 22, 2020 at 09:18:49AM +0100, Daniel P. Berrangé wrote: > On Tue, Sep 22, 2020 at 08:56:06AM +0200, Paolo Bonzini wrote: > > On 22/09/20 08:45, David Hildenbrand wrote: > > >> It's certainly a good idea but it's quite verbose. > > >> > > >> What about using atomic__* as the prefix? It

Re: [PATCH v2] qemu/atomic.h: prefix qemu_ to solve collisions

2020-09-23 Thread Stefan Hajnoczi
On Tue, Sep 22, 2020 at 01:35:37PM +0200, Paolo Bonzini wrote: > On 22/09/20 10:58, Stefan Hajnoczi wrote: > I think the reviews crossed, are you going to respin using a qatomic_ > prefix? Yes, let's do qatomic_. I'll send a v3. Stefan signature.asc Description: PGP signature

[PATCH v2 2/4] configure: cleanup CFLAGS and LDFLAGS for submodules

2020-09-23 Thread Paolo Bonzini
The -g and -O2 flags that configure adds to CFLAGS are only used by submodules, so do not put anymore the confusing CFLAGS variable in config-host.mak and replace it with more explicit SUBMODULE_CFLAGS variable. There was also no equivalent SUBMODULE_LDFLAGS variable, add it. This would theoretic

[PATCH v2 1/4] configure: cleanup invocation of submodule Make

2020-09-23 Thread Paolo Bonzini
Move common command line options to SUBDIR_MAKEFLAGS, thus simplifying the rules themselves. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- Makefile | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/Makefile b/Makefile index 897246d77

[PATCH v2 1/1] accel/tcg: Fix computing of is_write for mips

2020-09-23 Thread Kele Huang
Detect mips store instructions in cpu_signal_handler for all MIPS versions, and set is_write if encountering such store instructions. This fixed the error while dealing with self-modifed code for MIPS. Signed-off-by: Kele Huang Signed-off-by: Xu Zou --- accel/tcg/user-exec.c | 51 +

[PATCH v2 3/4] configure: do not clobber environment CFLAGS/CXXFLAGS/LDFLAGS

2020-09-23 Thread Paolo Bonzini
If the CFLAGS, CXXFLAGS or LDFLAGS variables are present in the environment, any modification made within the configure script is passed down to Meson. This is particularly undesirable for the "-pie" option, since it overrides "-shared" and thus messes up the linker flags for shared modules. Using

[PATCH] hw/pci/pci: Fix slot check for plugged devices

2020-09-23 Thread Julia Suvorova
If devfn is assigned automatically, 'else' clauses will never be executed. And if it does not matter for the reserved and available devfn, because we have already checked it, the check for function0 needs to be done again. Signed-off-by: Julia Suvorova --- hw/pci/pci.c | 5 +++-- 1 file changed,

Re: [PATCH v2] module: silence errors for module_load_qom_all().

2020-09-23 Thread Paolo Bonzini
On 23/09/20 11:12, Gerd Hoffmann wrote: > Add mayfail bool parameter to module loading functions. Set it to true > for module_load_qom_all() because device modules might not load into all > system emulation variants. qemu-system-s390x for example will not load > qxl because it lacks vga support.

Re: [PATCH] vhost-user: save features of multiqueues if chardev is closed

2020-09-23 Thread Adrian Moreno
Thanks Haibin, On 9/22/20 5:27 AM, haibinzhang(张海斌) wrote: > Fore-commit(c6beefd674) only saves features of queue0, > this makes wrong features of other queues in multiqueues > situation. > For examples: > qemu-system-aarch64 ... \ > -chardev socket,id=charnet0,path=/var/run/vhost_sock \ >

[PATCH v6 00/11] x86: fix cpu hotplug with secure boot

2020-09-23 Thread Igor Mammedov
v6: - [9/10] Add comment explaining why while_ctx2 restarts from the last processed CPU. - rebase on top of current master, due to non trivial conflict caused by microvm series, which moved/renamed pc_cpu_pre_plug() v5: - fix hotplug on Windows when there is more than 256 possible CPUs

[PATCH v6 02/11] x86: cpuhp: prevent guest crash on CPU hotplug when broadcast SMI is in use

2020-09-23 Thread Igor Mammedov
There were reports of guest crash on CPU hotplug, when using q35 machine type and OVMF with SMM, due to hotplugged CPU trying to process SMI at default SMI handler location without it being relocated by firmware first. Fix it by refusing hotplug if firmware hasn't negotiated CPU hotplug with SMI s

[PATCH v6 10/11] tests: acpi: update acpi blobs with new AML

2020-09-23 Thread Igor Mammedov
here is diff against tests/data/acpi/q35/DSDT for currently shipped ovmf binary. (once firmware blob is updated, it will negotiate CPU hotplug feature which will ad extra hunk sending SMI and Q35 tests will need to be updated), but otherwise diff shows new CPU hotplug AML that is shared between q35

Re: [PATCH] Deprecate lm32 port

2020-09-23 Thread Peter Maydell
On Wed, 23 Sep 2020 at 08:55, Thomas Huth wrote: > > On 27/08/2020 13.32, Peter Maydell wrote: > > @@ -416,6 +416,14 @@ The above, converted to the current supported format:: > > linux-user mode CPUs > > > > > > +``lm32`` CPUs (since 5.2.0) > > +''' >

[PATCH v6 01/11] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-09-23 Thread Igor Mammedov
It will allow firmware to notify QEMU that firmware requires SMI being triggered on CPU hot[un]plug, so that it would be able to account for hotplugged CPU and relocate it to new SMM base and/or safely remove CPU on unplug. Using negotiated features, follow up patches will insert SMI upcall into A

[PATCH v6 06/11] x86: ich9: expose "smi_negotiated_features" as a QOM property

2020-09-23 Thread Igor Mammedov
Expose the "smi_negotiated_features" field of ICH9LPCState as a QOM property. Signed-off-by: Igor Mammedov Reviewed-by: Laszlo Ersek Tested-by: Laszlo Ersek --- include/hw/i386/ich9.h | 2 ++ hw/isa/lpc_ich9.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/include/hw/i386/ich9.h

[PATCH v6 04/11] acpi: add aml_land() and aml_break() primitives

2020-09-23 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laszlo Ersek Tested-by: Laszlo Ersek --- v5: - fix comment to match spec (Laszlo Ersek ) - reorder aml_lor() and aml_land() in header (Laszlo Ersek ) --- include/hw/acpi/aml-build.h | 2 ++ hw/acpi/aml-build.c

[PATCH v6 11/11] smp: drop support for deprecated (invalid topologies)

2020-09-23 Thread Igor Mammedov
it's was deprecated since 3.1 Support for invalid topologies is removed, the user must ensure that topologies described with -smp include all possible cpus, i.e. (sockets * cores * threads) == maxcpus or QEMU will exit with error. Signed-off-by: Igor Mammedov --- docs/system/deprecated.rst | 26

Re: [PATCH v5 00/10] x86: fix cpu hotplug with secure boot

2020-09-23 Thread Igor Mammedov
On Mon, 21 Sep 2020 08:34:31 -0400 "Michael S. Tsirkin" wrote: > On Mon, Sep 21, 2020 at 01:46:01PM +0200, Igor Mammedov wrote: > > On Mon, 7 Sep 2020 07:23:38 -0400 > > Igor Mammedov wrote: > > > > > v5: > > > - fix hotplug on Windows when there is more than 256 possible CPUs > > > (W

[PATCH v6 08/11] x86: acpi: introduce the PCI0.SMI0 ACPI device

2020-09-23 Thread Igor Mammedov
When CPU hotplug with SMI has been negotiated, describe the SMI register block in the DSDT. Pass the ACPI name of the SMI control register to build_cpus_aml(), so that CPU_SCAN_METHOD can access the register in the next patch. Signed-off-by: Igor Mammedov Reviewed-by: Laszlo Ersek Tested-by: Las

[PATCH v6 03/11] x86: cpuhp: refuse cpu hot-unplug request earlier if not supported

2020-09-23 Thread Igor Mammedov
CPU hot-unplug with SMM requires firmware participation to prevent guest crash (i.e. CPU can be removed only after OS _and_ firmware were prepared for the action). Previous patches introduced ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT feature bit, which is advertised by firmware when it has support for CPU

[PATCH v6 05/11] tests: acpi: mark to be changed tables in bios-tables-test-allowed-diff

2020-09-23 Thread Igor Mammedov
... to let tests pass until binary blobs are updated with new AML Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allo

Re: Re: questions regarding vsock

2020-09-23 Thread Stefano Garzarella
Hi Robin, On Tue, Sep 22, 2020 at 10:46 PM Robin Meinzer wrote: > I added Stefano Garzarella and qemu-devel as you asked. I wonder if > you don't support SOCK_DGRAM but only SOCK_STREAM, why having code for > it then? There are functions like vsock_dgram_connect and a proto_ops > struct specifica

[PATCH v6 07/11] x86: acpi: introduce AcpiPmInfo::smi_on_cpuhp

2020-09-23 Thread Igor Mammedov
Translate the "CPU hotplug with SMI" feature bit, from the property added in the last patch, to a dedicated boolean in AcpiPmInfo. Signed-off-by: Igor Mammedov Reviewed-by: Laszlo Ersek Tested-by: Laszlo Ersek --- hw/i386/acpi-build.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/h

[PATCH v6 09/11] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM

2020-09-23 Thread Igor Mammedov
In case firmware has negotiated CPU hotplug SMI feature, generate AML to describe SMI IO port region and send SMI to firmware on each CPU hotplug SCI in case new CPUs were hotplugged. Since new CPUs can be hotplugged while CPU_SCAN_METHOD is running we can't send SMI before new CPUs are fetched fr

Re: [PATCH v6 11/11] smp: drop support for deprecated (invalid topologies)

2020-09-23 Thread Igor Mammedov
On Wed, 23 Sep 2020 05:46:50 -0400 Igor Mammedov wrote: > it's was deprecated since 3.1 > > Support for invalid topologies is removed, the user must ensure > that topologies described with -smp include all possible cpus, > i.e. (sockets * cores * threads) == maxcpus or QEMU will > exit with erro

Re: [PATCH 03/24] rng-egd: Register "chardev" as class property

2020-09-23 Thread Daniel P . Berrangé
On Mon, Sep 21, 2020 at 06:10:24PM -0400, Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: Laurent Vivier > Cc: Amit Shah > Cc: qemu-devel@nongnu.org > --- >

Re: [PATCH 07/24] rng: Register "opened" as class property

2020-09-23 Thread Daniel P . Berrangé
On Mon, Sep 21, 2020 at 06:10:28PM -0400, Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: Laurent Vivier > Cc: Amit Shah > Cc: qemu-devel@nongnu.org > --- >

Re: [PATCH 04/24] rng-random: register "filename" as class property

2020-09-23 Thread Daniel P . Berrangé
On Mon, Sep 21, 2020 at 06:10:25PM -0400, Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: Laurent Vivier > Cc: Amit Shah > Cc: qemu-devel@nongnu.org > --- >

Re: [PATCH v3 51/81] target/arm: Pass separate addend to {U, S}DOT helpers

2020-09-23 Thread LIU Zhiwei
On 2020/9/19 2:37, Richard Henderson wrote: For SVE, we potentially have a 4th argument coming from the movprfx instruction. Currently we do not optimize movprfx, so the problem is not visible. Hi Richard, I am a little confused.  If it is not immediately preceded by a MOVPRFX instruction,

Re: [PATCH v2] target/i386: always create kvmclock device

2020-09-23 Thread Antoine Damhet
Hi, The patch doesn't apply cleanly to master but it works (patched -> patched working, patched -> unpatched: old behavior, unpatched -> patched: old behavior) Thanks to everyone for the swift responses :) On Tue, Sep 22, 2020 at 05:19:34PM +0200, Vitaly Kuznetsov wrote: > QEMU's kvmclock device

[PATCH 0/4] qemu/bswap: Use compiler __builtin_bswap()

2020-09-23 Thread Philippe Mathieu-Daudé
Implement Richard's suggestion to use __builtin_bswap(). const_XX() not updated. We could use le_bswap() definitions but they are undefined, not sure yet what is the best way. Meanwhile I figure this out, these patches are ready for review. Philippe Mathieu-Daudé (4): qemu/bswap: Remove unused

[PATCH 1/4] qemu/bswap: Remove unused qemu_bswap_len()

2020-09-23 Thread Philippe Mathieu-Daudé
Last use of qemu_bswap_len() has been removed in commit e5fd1eb05ec ("apb: add busA qdev property to PBM PCI bridge"). Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/bswap.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h index 1d3e4c2

Re: [PATCH 09/24] input-linux: Register properties as class properties

2020-09-23 Thread Daniel P . Berrangé
On Mon, Sep 21, 2020 at 06:10:30PM -0400, Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: Gerd Hoffmann > Cc: qemu-devel@nongnu.org > --- > ui/input-linux.c

Re: [PATCH 10/24] input-barrier: Register properties as class properties

2020-09-23 Thread Daniel P . Berrangé
On Mon, Sep 21, 2020 at 06:10:31PM -0400, Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: Gerd Hoffmann > Cc: qemu-devel@nongnu.org > --- > ui/input-barrier.

[PATCH 4/4] qemu/bswap: Remove dependency

2020-09-23 Thread Philippe Mathieu-Daudé
All our supported compilers provide the __builtin_bswap() functions. Drop the dependency. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- configure| 13 - include/qemu/bswap.h | 17 - 2 files changed, 30 deletions(-) diff --git

[PATCH 2/4] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap()

2020-09-23 Thread Philippe Mathieu-Daudé
Use the compiler built-in function to byte swap values, as the compiler is clever and will fold constants. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/bswap.h | 30 -- 1 file changed, 4 insertions(+), 26 deletions(-) diff -

[PATCH 3/4] qemu/bswap: Replace bswapXXs() by compiler __builtin_bswap()

2020-09-23 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/bswap.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h index d1a2f700f2a..6875e48d617 100644 --- a/include/qemu/bswap.h +++ b/include/qemu/bswap.h @@ -35,29 +35

Re: [PATCH v8 3/7] usb/hcd-xhci: Split pci wrapper for xhci base model

2020-09-23 Thread Gerd Hoffmann
Hi, > This patch sets the base to use xhci as sysbus model, for which pci > specific hooks are moved to hcd-xhci-pci.c. As a part of this requirment > msi/msix interrupts handling is moved under XHCIPCIState. Made required > changes for qemu-xhci-nec. Progress. vmstate loads fine ;) Does not

Re: [PATCH] modules: update qom object module comment

2020-09-23 Thread Philippe Mathieu-Daudé
On 9/23/20 11:18 AM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > util/module.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/util/module.c b/util/module.c > index 520986bd70ff..6df873593f95 100644 > --- a/util/module.c > +++ b/util/module.c > @@ -255

Re: [PATCH 4/4] qemu/bswap: Remove dependency

2020-09-23 Thread Peter Maydell
On Wed, 23 Sep 2020 at 11:09, Philippe Mathieu-Daudé wrote: > > All our supported compilers provide the __builtin_bswap() > functions. Drop the dependency. > > Suggested-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé > diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h > in

Re: [PATCH] kvm: remove now unnecessary stubs

2020-09-23 Thread Philippe Mathieu-Daudé
On 9/23/20 11:17 AM, Paolo Bonzini wrote: > These two stubs are now used only in accel/kvm/kvm-all.c > and accel/kvm/kvm-cpus.c. > > Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé > --- > accel/stubs/kvm-stub.c | 9 - > 1 file changed, 9 deletions(-) > > diff --git

Re: [PATCH v2 2/2] block: deprecate the sheepdog block driver

2020-09-23 Thread Philippe Mathieu-Daudé
On 9/22/20 6:16 PM, Daniel P. Berrangé wrote: > This thread from a little over a year ago: > > http://lists.wpkg.org/pipermail/sheepdog/2019-March/thread.html > > states that sheepdog is no longer actively developed. The only mentioned > users are some companies who are said to have it for lega

Re: [PATCH 4/4] qemu/bswap: Remove dependency

2020-09-23 Thread Philippe Mathieu-Daudé
On 9/23/20 12:16 PM, Peter Maydell wrote: > On Wed, 23 Sep 2020 at 11:09, Philippe Mathieu-Daudé > wrote: >> >> All our supported compilers provide the __builtin_bswap() >> functions. Drop the dependency. >> >> Suggested-by: Richard Henderson >> Signed-off-by: Philippe Mathieu-Daudé >> diff --

[PATCH] Add execute bit back to scripts/tracetool.py

2020-09-23 Thread Anthony PERARD via
Commit a81df1b68b65 ("libqemuutil, qapi, trace: convert to meson") removed it without explanation and it is useful to be able to run a script without having to figure out which interpreter to use. Signed-off-by: Anthony PERARD --- scripts/tracetool.py | 0 1 file changed, 0 insertions(+), 0 dele

[PATCH v2] modules: update qom object module comment

2020-09-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- util/module.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util/module.c b/util/module.c index 520986bd70ff..6eb1e917860e 100644 --- a/util/module.c +++ b/util/module.c @@ -255,8 +255,10 @@ bool module_load_one(const char *prefix, const c

[PATCH v2 0/3] Add support for loading SMBIOS OEM strings from a file

2020-09-23 Thread Daniel P . Berrangé
I previously added support for SMBIOS OEM strings tables but only allowed for data to be passed inline. Potential users indicated they wanted to pass some quite large data blobs which is inconvenient todo inline. Thus I'm adding support for passing the data from a file. In testing this I discovere

[PATCH v2 1/3] hw/smbios: support loading OEM strings values from a file

2020-09-23 Thread Daniel P . Berrangé
Some applications want to pass quite large values for the OEM strings entries. Rather than having huge strings on the command line, it would be better to load them from a file, as supported with -fw_cfg. This introduces the "path" parameter allowing for: $ echo -n "thisthing" > mydata.txt $ q

[PATCH v2 2/3] hw/smbios: report error if table size is too large

2020-09-23 Thread Daniel P . Berrangé
The SMBIOS 2.1 entry point uses a uint16 data type for reporting the total length of the tables. If the user passes -smbios configuration to QEMU that causes the table size to exceed this limit then various bad behaviours result, including - firmware hangs in an infinite loop - firmware triggers

[PATCH v2 3/3] qemu-options: document SMBIOS type 11 settings

2020-09-23 Thread Daniel P . Berrangé
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- qemu-options.hx | 41 + 1 file changed, 41 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 47f64be0c0..2cb034bce3 100644 --- a/qemu-options.hx +++ b/qemu-options.

Re: [PATCH v2] modules: update qom object module comment

2020-09-23 Thread Philippe Mathieu-Daudé
On 9/23/20 12:37 PM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > util/module.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/util/module.c b/util/module.c > index 520986bd70ff..6eb1e917860e 100644 > --- a/util/module.c > +++ b/util/module.c > @@ -255

Re: [PATCH] Add execute bit back to scripts/tracetool.py

2020-09-23 Thread Philippe Mathieu-Daudé
On 9/23/20 12:36 PM, Anthony PERARD via wrote: > Commit a81df1b68b65 ("libqemuutil, qapi, trace: convert to meson") > removed it without explanation and it is useful to be able to run a > script without having to figure out which interpreter to use. > > Signed-off-by: Anthony PERARD > --- > scri

Re: [PATCH v2 1/1] accel/tcg: Fix computing of is_write for mips

2020-09-23 Thread Philippe Mathieu-Daudé
Cc'ing the TCG MIPS maintainers, and also Cc'ing Richard who made a comment in v1. On 9/23/20 11:38 AM, Kele Huang wrote: > Detect mips store instructions in cpu_signal_handler for all MIPS > versions, and set is_write if encountering such store instructions. > > This fixed the error while dealin

Re: [PATCH] Add execute bit back to scripts/tracetool.py

2020-09-23 Thread Paolo Bonzini
On 23/09/20 12:36, Anthony PERARD wrote: > Commit a81df1b68b65 ("libqemuutil, qapi, trace: convert to meson") > removed it without explanation and it is useful to be able to run a > script without having to figure out which interpreter to use. > > Signed-off-by: Anthony PERARD > --- > scripts/tr

Re: [PATCH] Add execute bit back to scripts/tracetool.py

2020-09-23 Thread Daniel P . Berrangé
On Wed, Sep 23, 2020 at 01:14:57PM +0200, Paolo Bonzini wrote: > On 23/09/20 12:36, Anthony PERARD wrote: > > Commit a81df1b68b65 ("libqemuutil, qapi, trace: convert to meson") > > removed it without explanation and it is useful to be able to run a > > script without having to figure out which inte

[PATCH v1 3/5] memory-device: Support big alignment requirements

2020-09-23 Thread David Hildenbrand
Let's warn instead of bailing out - the worst thing that can happen is that we'll fail hot/coldplug later. The user got warned, and this should be rare. This will be necessary for memory devices with rather big (user-defined) alignment requirements - say a virtio-mem device with a 2G block size -

[PATCH v1 0/5] virtio-mem: block size and address-assignment optimizations

2020-09-23 Thread David Hildenbrand
Let's try to detect the actual THP size and use it as default block size (unless the page size of the backend is bigger). Handle large block sizes better, avoiding a virtio-spec violation and optimizing address auto-detection. David Hildenbrand (5): virtio-mem: Probe THP size to determine defaul

[PATCH v1 4/5] memory-device: Add get_min_alignment() callback

2020-09-23 Thread David Hildenbrand
Will be used by virtio-mem to express special alignment requirements due to manually configured, big block sizes. This avoids failing later when realizing, because auto-detection wasn't able to assign a properly aligned address. Cc: "Michael S. Tsirkin" Cc: Wei Yang Cc: Dr. David Alan Gilbert C

[Bug 1896754] [NEW] Performance degradation for WinXP boot time after b55f54bc

2020-09-23 Thread Maskim Bakulin
Public bug reported: Qemu 5.1 loads Windows XP in TCG mode 5-6 times slower (~2 minutes) than 4.2 (25 seconds), I git bisected it, and it appears that commit b55f54bc965607c45b5010a107a792ba333ba654 causes this issue. Probably similar to an older fixed bug https://bugs.launchpad.net/qemu/+bug/1672

  1   2   3   4   5   >