RE: [PATCH 2/2] qdev: Let BusRealize() return a boolean value to indicate error

2020-09-21 Thread Paul Durrant
> -Original Message- > From: Philippe Mathieu-Daudé On Behalf Of > Philippe Mathieu-Daudé > Sent: 20 September 2020 12:44 > To: Markus Armbruster ; qemu-devel@nongnu.org > Cc: Laurent Vivier ; Paolo Bonzini ; > Anthony Perard > ; Stefano Stabellini ; > Daniel P. Berrangé > ; Eduardo Hab

Re: [PATCH v4 00/15] Reverse debugging

2020-09-21 Thread Philippe Mathieu-Daudé
On 9/21/20 8:48 AM, Pavel Dovgalyuk wrote: > On 20.09.2020 10:58, Paolo Bonzini wrote: >> On 14/09/20 08:06, Pavel Dovgalyuk wrote: >>> GDB remote protocol supports reverse debugging of the targets. >>> It includes 'reverse step' and 'reverse continue' operations. >>> The first one finds the previo

Re: [PATCH 06/37] qapi: delint using flake8

2020-09-21 Thread Markus Armbruster
John Snow writes: > On 9/18/20 6:33 AM, Markus Armbruster wrote: >> John Snow writes: [...] >>> Embedded templates are always gonna look kinda nasty, I think, because >>> you're trying to fight style guidelines in two languages >>> simultaneously and it's never gonna quite work out exactly how y

Re: [PATCH v3 2/2] Mark Icelake-Client CPU models deprecated

2020-09-21 Thread Robert Hoo
On Fri, 2020-09-18 at 00:20 -0400, Eduardo Habkost wrote: > On Fri, Sep 18, 2020 at 10:18:56AM +0800, Robert Hoo wrote: > > On Thu, 2020-09-17 at 14:01 -0400, Eduardo Habkost wrote: > > > On Wed, Sep 16, 2020 at 04:37:14PM +0800, Robert Hoo wrote: > > > > Going to obsolete Icelake-Client CPU models

Re: [PATCH 09/37] qapi/common.py: Add indent manager

2020-09-21 Thread Markus Armbruster
John Snow writes: > On 9/18/20 6:55 AM, Markus Armbruster wrote: >> John Snow writes: > >>> We'll get to them in due time. For now, please admire the lipstick. >> If I take off my glasses and step six feet back, I just might be >> able to >> overlook it. >> > > I consider writing a nice __repr_

RE: [PATCH v1 0/3] Remove the limitation of Intel PT CPUID info

2020-09-21 Thread Kang, Luwei
Hi Eduardo, This patch set will remove some limitations of Intel PT CPUID information. 1. The "IP payloads" feature will disable the Intel PT in guests and it will be coming soon. 2. To make the live migration safe, we set the Intel PT CPUID as a constant value(Icelake server CPUID).

Re: [PATCH 8/9] default-configs/targets: remove useless lines

2020-09-21 Thread Paolo Bonzini
Il lun 21 set 2020, 02:29 Richard Henderson ha scritto: > On 9/20/20 6:07 AM, Paolo Bonzini wrote: > > Some lines are only meaningful for user-mode targets, remove them. > > > > Signed-off-by: Paolo Bonzini > > --- > > This seems like it could be folded with the previous. > The previous patch w

Re: [PATCH v2 0/2] hw: usb: hcd-ohci: fix oob access and loop issues

2020-09-21 Thread Gerd Hoffmann
On Tue, Sep 15, 2020 at 11:52:57PM +0530, P J P wrote: > From: Prasad J Pandit > > Hello, > > * While servicing transfer descriptors(TD) in ohci_service[_iso]_td > routines, it may lead to out-of-bounds access and/or infinite loop > issues, as the OHCI controller driver may supply malicious

RE: [PATCH] xen: rework pci_piix3_xen_ide_unplug

2020-09-21 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD > Sent: 18 September 2020 15:53 > To: qemu-devel@nongnu.org > Cc: Paul Durrant ; Stefano Stabellini ; > Anthony PERARD > ; John Snow ; > qemu-bl...@nongnu.org > Subject: [PATCH] xen: rework pci_piix3_xen_ide_unplug > > This is to allow IDE dis

[PATCH v3 0/8] hw/arm/raspi: QOM housekeeping to be able to add more machines

2020-09-21 Thread Philippe Mathieu-Daudé
Machine-specific patches extracted from v2 [*] and rebased. Housekeeping the QOM model to easily add more machines. Patches missing review: 1-3,7. [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg680135.html Based-on: <20200921035257.434532-1-f4...@amsat.org> Philippe Mathieu-Daudé (8

[PATCH v3 2/8] hw/arm/raspi: Load the firmware on the first core

2020-09-21 Thread Philippe Mathieu-Daudé
The 'first_cpu' is more a QEMU accelerator-related concept than a variable the machine requires to use. Since the machine is aware of its CPUs, directly use the first one to load the firmware. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

[PATCH v3 1/8] hw/arm/raspi: Display the board revision in the machine description

2020-09-21 Thread Philippe Mathieu-Daudé
Display the board revision in the machine description. Before: $ qemu-system-aarch64 -M help | fgrep raspi raspi2 Raspberry Pi 2B raspi3 Raspberry Pi 3B After: raspi2 Raspberry Pi 2B (revision 1.1) raspi3 Raspberry Pi 3B (revisio

[PATCH v3 6/8] hw/arm/raspi: Introduce RaspiProcessorId enum

2020-09-21 Thread Philippe Mathieu-Daudé
As we only support a reduced set of the REV_CODE_PROCESSOR id encoded in the board revision, define the PROCESSOR_ID values as an enum. We can simplify the board_soc_type and cores_count methods. Reviewed-by: Luc Michel Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 45 +

[PATCH v3 3/8] hw/arm/raspi: Move arm_boot_info structure to RaspiMachineState

2020-09-21 Thread Philippe Mathieu-Daudé
The arm_boot_info structure belong to the machine, move it to RaspiMachineState. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index 8716a80a75e..16e6c8

[PATCH v3 5/8] hw/arm/raspi: Use more specific machine names

2020-09-21 Thread Philippe Mathieu-Daudé
Now that we can instantiate different machines based on their board_rev register value, we can have various raspi2 and raspi3. In commit fc78a990ec103 we corrected the machine description. Correct the machine names too. For backward compatibility, add an alias to the previous generic name. Review

[PATCH v3 8/8] hw/arm/raspi: Remove use of the 'version' value in the board code

2020-09-21 Thread Philippe Mathieu-Daudé
We expected the 'version' ID to match the board processor ID, but this is not always true (for example boards with revision id 0xa02042/0xa22042 are Raspberry Pi 2 with a BCM2837 SoC). This was not important because we were not modelling them, but since the recent refactor now allow to model these

[PATCH v3 4/8] hw/arm/raspi: Avoid using TypeInfo::class_data pointer

2020-09-21 Thread Philippe Mathieu-Daudé
Using class_data pointer to create a MachineClass is not the recommended way anymore. The correct way is to open-code the MachineClass::fields in the class_init() method. We can not use TYPE_RASPI_MACHINE::class_base_init() because it is called *before* each machine class_init(), therefore the boa

Re: [PATCH] spice: remove obsolete callback

2020-09-21 Thread Gerd Hoffmann
Hi, > Fix compiler deprecation warnings with Spice > 0.14.3 (not released > yet). We may want to wait until newer version is actually released to > apply the patch. Probably makes sense, just in case. It's not like this is an urgent fix. > +#if SPICE_SERVER_VERSION < 0x000e04 /* release 0.14.

Re: [PATCH 16/37] qapi: establish mypy type-checking baseline

2020-09-21 Thread Markus Armbruster
John Snow writes: > On 9/18/20 7:55 AM, Markus Armbruster wrote: >> Ignorant question: why does this come after PATCH 13 "qapi/common.py: >> add notational type hints", but before all the other patches adding type >> hints? >> John Snow writes: >> >>> Fix two very minor issues, and then establi

[PATCH v3 7/8] hw/arm/raspi: Use RaspiProcessorId to set the firmware load address

2020-09-21 Thread Philippe Mathieu-Daudé
The firmware load address depends of the SoC ("processor id") used, not of the version of the board. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index 0d8e5a34c78..ae98a2fbfca 10064

Re: [PATCH 16/37] qapi: establish mypy type-checking baseline

2020-09-21 Thread Markus Armbruster
John Snow writes: > On 9/18/20 7:55 AM, Markus Armbruster wrote: >> Ignorant question: why does this come after PATCH 13 "qapi/common.py: >> add notational type hints", but before all the other patches adding type >> hints? >> John Snow writes: >> >>> Fix two very minor issues, and then establi

Re: [PATCH 4/5] spice: get monitors physical dimension

2020-09-21 Thread Gerd Hoffmann
On Thu, Sep 17, 2020 at 10:22:41AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Note that for consistency, we use the same logic as MonitorsConfig to > figure out the associated monitor. However, I can't find traces of the > discussion/patches about the "new spice-serv

Re: [PATCH 2/2] qdev: Let BusRealize() return a boolean value to indicate error

2020-09-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Commit 9940b2cfbc0 introduced qdev_realize() and qbus_realize() > with the ability to return a boolean value if an error occured, > thus the caller does not need to check if the Error* pointer is > set. > Provide the same ability to the BusRealize type. > > Signed

Re: [PATCH] qom: code hardening - have bound checking while looping with integer value

2020-09-21 Thread Daniel P . Berrangé
On Sat, Sep 19, 2020 at 09:11:39PM +0530, Ani Sinha wrote: > Object property insertion code iterates over an integer to get an unused > index that can be used as an unique name for an object property. This loop > increments the integer value indefinitely. Although very unlikely, this can > still ca

Re: Limiting per vCPU Usage

2020-09-21 Thread Daniel P . Berrangé
On Sun, Sep 20, 2020 at 10:24:41PM +0200, Peter Lieven wrote: > Hi Qemu folks, > > > is there a BCP to limit just the maximum usage of a virtual (KVM) cpu? > > I know that there are many approaches, but as far as I know they all limit > the complete qemu process which is far more > > than just

[PATCH v4 0/4] vhost-vsock: force virtio version 1

2020-09-21 Thread Stefano Garzarella
v4: - Patch 1: fixed commit message and warning message [Cornelia] - Patch 3: added comment in the code [Cornelia] - Added Cornelia's R-b tags v3: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg06549.html v2: https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg04437.html v1

[PATCH v4 2/4] vhost-vsock-pci: force virtio version 1

2020-09-21 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on vhost-vsock-pci device: $ ./qemu-system-x86_64 ... -device vhost-vsock-pci,guest-cid=5 qemu-system-x86_64: -device vhost-vsock-pci,guest-cid=

[PATCH v4 3/4] vhost-user-vsock-pci: force virtio version 1

2020-09-21 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on vhost-user-vsock-pci device: $ ./qemu-system-x86_64 ... \ -chardev socket,id=char0,reconnect=0,path=/tmp/vhost4.socket \ -device vhost-user-v

Re: [RFC PATCH 3/6] hw/sd/sdcard: Do not use legal address '0' for INVALID_ADDRESS

2020-09-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > As it is legal to WRITE/ERASE the address/block 0, > change the value of this definition to an illegal > address: UINT32_MAX. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Dr. David Alan Gilbert > Cc: Markus Armbruster > > Same problem I had with the pf

[PATCH v4 1/4] virtio: skip legacy support check on machine types less than 5.1

2020-09-21 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a check that returns an error if legacy support is on, but the device does not support legacy. Unfortunately some devices were wrongly declared legacy capable even if they were not (e.g vhost-vsock). To avoid mi

[PATCH v4 4/4] vhost-vsock-ccw: force virtio version 1

2020-09-21 Thread Stefano Garzarella
virtio-vsock was introduced after the release of VIRTIO 1.0 specifications, so it should be 'modern-only'. This patch forces virtio version 1 as done for vhost-vsock-pci. To avoid migration issues, we force virtio version 1 only when legacy check is enabled in the new machine types (>= 5.1). Cc:

Re: tools/virtiofs: Multi threading seems to hurt performance

2020-09-21 Thread Stefan Hajnoczi
On Fri, Sep 18, 2020 at 05:34:36PM -0400, Vivek Goyal wrote: > And here are the comparision results. To me it seems that by default > we should switch to 1 thread (Till we can figure out how to make > multi thread performance better even when single process is doing > I/O in client). Let's underst

Re: QEMU 5.0 virtio-blk performance regression with high queue depths

2020-09-21 Thread Stefan Hajnoczi
On Fri, Sep 18, 2020 at 10:59 AM Denis V. Lunev wrote: > On 9/17/20 3:41 PM, Stefan Hajnoczi wrote: > > On Wed, Sep 16, 2020 at 5:43 PM Denis V. Lunev wrote: > >> On 9/16/20 5:07 PM, Denis V. Lunev wrote: > >>> I will make a check today. > >>> > >>> Talking about our performance measurements, we

Re: [PATCH 0/2] vhost-vdpa: add trace functions in vhost-vdpa.c

2020-09-21 Thread Stefan Hajnoczi
On Sun, Sep 20, 2020 at 06:24:32PM +0200, Laurent Vivier wrote: > Add trace events functions in vdpa functions. > > Modify qemu_hexdump() to be able to dump the vdpa config > in trace logs in hexadecimal form. > > Laurent Vivier (2): > util/hexdump: introduce qemu_hexdump_line() > vhost-vdpa:

Re: tools/virtiofs: Multi threading seems to hurt performance

2020-09-21 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > Hi All, > > virtiofsd default thread pool size is 64. To me it feels that in most of > the cases thread pool size 1 performs better than thread pool size 64. > > I ran virtiofs-tests. > > https://github.com/rhvgoyal/virtiofs-tests > > And here are the

Re: [PATCH] tests/docker: add liburing-devel to the Fedora image

2020-09-21 Thread Stefan Hajnoczi
On Fri, Aug 21, 2020 at 9:38 PM Stefano Garzarella wrote: > On Fri, Aug 21, 2020 at 07:55:02PM +0200, Philippe Mathieu-Daudé wrote: > > On 8/21/20 6:54 PM, Stefano Garzarella wrote: > > > Install liburing-devel dependencies to get better coverage on > > > io-uring stuff (block/io_uring.c and util/

Re: [PATCH v2 04/20] block/block-copy: More explicit call_state

2020-09-21 Thread Max Reitz
On 18.09.20 22:11, Vladimir Sementsov-Ogievskiy wrote: > 17.07.2020 16:45, Max Reitz wrote: >> On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote: >>> Refactor common path to use BlockCopyCallState pointer as parameter, to >>> prepare it for use in asynchronous block-copy (at least, we'll need t

[PULL 0/3] Usb 20200921 patches

2020-09-21 Thread Gerd Hoffmann
The following changes since commit 053a4177817db307ec854356e95b5b350800a216: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20200918' into staging (2020-09-18 16:34:26 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20200921-pu

[PULL 1/3] usb: fix u2f build

2020-09-21 Thread Gerd Hoffmann
Just use qemu_open_old() for a quick fix, switch to better error handling left for another day. Fixes: 448058aa99aa ("util: rename qemu_open() to qemu_open_old()") Cc: César Belley Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Message-id: 20200918110122.9121-1-kra...@redhat.com -

Re: [PATCH 0/3] Hyper-V Dynamic Memory Protocol driver (hv-balloon)

2020-09-21 Thread Igor Mammedov
On Sun, 20 Sep 2020 15:25:19 +0200 "Maciej S. Szmigiero" wrote: > From: "Maciej S. Szmigiero" >From description it sounds like an alternative of virtio-mem, CCing David. > This series adds a Hyper-V Dynamic Memory Protocol driver (hv-balloon) > and its protocol definitions. > Also included is

[PULL 3/3] hw: usb: hcd-ohci: check for processed TD before retire

2020-09-21 Thread Gerd Hoffmann
From: Prasad J Pandit While servicing OHCI transfer descriptors(TD), ohci_service_iso_td retires a TD if it has passed its time frame. It does not check if the TD was already processed once and holds an error code in TD_CC. It may happen if the TD list has a loop. Add check to avoid an infinite l

[PULL 2/3] hw: usb: hcd-ohci: check len and frame_number variables

2020-09-21 Thread Gerd Hoffmann
From: Prasad J Pandit While servicing the OHCI transfer descriptors(TD), OHCI host controller derives variables 'start_addr', 'end_addr', 'len' etc. from values supplied by the host controller driver. Host controller driver may supply values such that using above variables leads to out-of-bounds

[PATCH v2] qom: code hardening - have bound checking while looping with integer value

2020-09-21 Thread Ani Sinha
Object property insertion code iterates over an integer to get an unused index that can be used as an unique name for an object property. This loop increments the integer value indefinitely. Although very unlikely, this can still cause an integer overflow. In this change, we fix the above code by c

Re: [PATCH] virtiofsd: document cache=auto default

2020-09-21 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > From: "Harry G. Coin" > > The virtiofsd --help output documents the cache=auto default value but > the man page does not. Fix this. > > Signed-off-by: Harry G. Coin > Signed-off-by: Stefan Hajnoczi Reviewed-by: Dr. David Alan Gilbert Thanks,

Re: [PATCH 0/3] Hyper-V Dynamic Memory Protocol driver (hv-balloon)

2020-09-21 Thread David Hildenbrand
On 20.09.20 15:25, Maciej S. Szmigiero wrote: > From: "Maciej S. Szmigiero" > > This series adds a Hyper-V Dynamic Memory Protocol driver (hv-balloon) > and its protocol definitions. > Also included is a driver providing backing devices for memory hot-add > protocols ("haprots"). > > A haprot de

Re: [PATCH v2] qom: code hardening - have bound checking while looping with integer value

2020-09-21 Thread Daniel P . Berrangé
On Mon, Sep 21, 2020 at 02:37:04PM +0530, Ani Sinha wrote: > Object property insertion code iterates over an integer to get an unused > index that can be used as an unique name for an object property. This loop > increments the integer value indefinitely. Although very unlikely, this can > still ca

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-21 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Hi, > > Among the QEMU developers, there is a desire to use Rust. (see previous > thread from Stefan "Why QEMU should move from C to Rust", the rust-vmm > related projects and other experiments). > > Thanks to our QAPI type system

Re: [PATCH 4/6] sparc32-ledma: don't reference nd_table directly within the device

2020-09-21 Thread Markus Armbruster
Mark Cave-Ayland writes: > Instead use qdev_set_nic_properties() to configure the on-board NIC at the > sun4m machine level. > > Signed-off-by: Mark Cave-Ayland > --- > hw/dma/sparc32_dma.c | 5 - > hw/sparc/sun4m.c | 21 + > 2 files changed, 13 insertions(+), 13 de

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-21 Thread Paolo Bonzini
On 21/09/20 11:16, Markus Armbruster wrote: > QMP is an *external* interface. > > It supports compatible evolution: we can make certain kinds of changes > without affecting clients. These include: > > * Adding optional arguments > > * Adding results > > * Adding values to an enumeration type,

Re: [PATCH 0/3] Hyper-V Dynamic Memory Protocol driver (hv-balloon)

2020-09-21 Thread David Hildenbrand
On 21.09.20 11:00, Igor Mammedov wrote: > On Sun, 20 Sep 2020 15:25:19 +0200 > "Maciej S. Szmigiero" wrote: > >> From: "Maciej S. Szmigiero" > > From description it sounds like an alternative of virtio-mem, > CCing David. Hah! Was already replying when your cc came in (thanks anyway!). Not qu

[PATCH v3] qom: code hardening - have bound checking while looping with integer value

2020-09-21 Thread Ani Sinha
Object property insertion code iterates over an integer to get an unused index that can be used as an unique name for an object property. This loop increments the integer value indefinitely. Although very unlikely, this can still cause an integer overflow. In this change, we fix the above code by c

Re: [PATCH 2/2] qdev: Let BusRealize() return a boolean value to indicate error

2020-09-21 Thread Philippe Mathieu-Daudé
On 9/21/20 10:19 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Commit 9940b2cfbc0 introduced qdev_realize() and qbus_realize() >> with the ability to return a boolean value if an error occured, >> thus the caller does not need to check if the Error* pointer is >> set. >> Prov

Re: [PATCH v4 1/4] virtio: skip legacy support check on machine types less than 5.1

2020-09-21 Thread Cornelia Huck
On Mon, 21 Sep 2020 10:38:04 +0200 Stefano Garzarella wrote: > Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally > on") added a check that returns an error if legacy support is on, but the > device does not support legacy. > > Unfortunately some devices were wrongly decl

Re: [PATCH v4 1/4] virtio: skip legacy support check on machine types less than 5.1

2020-09-21 Thread Stefano Garzarella
On Mon, Sep 21, 2020 at 11:40:54AM +0200, Cornelia Huck wrote: > On Mon, 21 Sep 2020 10:38:04 +0200 > Stefano Garzarella wrote: > > > Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally > > on") added a check that returns an error if legacy support is on, but the > > device

Re: [PATCH v4 2/4] vhost-vsock-pci: force virtio version 1

2020-09-21 Thread Cornelia Huck
On Mon, 21 Sep 2020 10:38:05 +0200 Stefano Garzarella wrote: > Commit 9b3a35ec82 ("virtio: verify that legacy support is not > accidentally on") added a safety check that requires to set > 'disable-legacy=on' on vhost-vsock-pci device: > > $ ./qemu-system-x86_64 ... -device vhost-vsock-pci,g

[PATCH] migration: Truncate state file in xen-save-devices-state

2020-09-21 Thread Dov Murik
When running the xen-save-devices-state QMP command, if the filename already exists it will be truncated before dumping the devices' state into it. Signed-off-by: Dov Murik --- Note that I found the above issue while trying to debug xen-load-devices-state which simply fails (prints "Configuratio

Re: [PATCH 4/6] sparc32-ledma: don't reference nd_table directly within the device

2020-09-21 Thread Philippe Mathieu-Daudé
Hi Mark, On 9/20/20 10:20 AM, Mark Cave-Ayland wrote: > Instead use qdev_set_nic_properties() to configure the on-board NIC at the > sun4m machine level. > > Signed-off-by: Mark Cave-Ayland > --- > hw/dma/sparc32_dma.c | 5 - > hw/sparc/sun4m.c | 21 + > 2 files cha

Re: [PATCH v4 2/4] vhost-vsock-pci: force virtio version 1

2020-09-21 Thread Stefano Garzarella
On Mon, Sep 21, 2020 at 11:46:02AM +0200, Cornelia Huck wrote: > On Mon, 21 Sep 2020 10:38:05 +0200 > Stefano Garzarella wrote: > > > Commit 9b3a35ec82 ("virtio: verify that legacy support is not > > accidentally on") added a safety check that requires to set > > 'disable-legacy=on' on vhost-vsoc

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-21 Thread Marc-André Lureau
Hi On Mon, Sep 21, 2020 at 1:16 PM Markus Armbruster wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Hi, > > > > Among the QEMU developers, there is a desire to use Rust. (see previous > > thread from Stefan "Why QEMU should move from C to Rust", the rust-vmm

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-21 Thread Marc-André Lureau
Hi On Mon, Sep 21, 2020 at 1:16 PM Markus Armbruster wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Hi, > > > > Among the QEMU developers, there is a desire to use Rust. (see previous > > thread from Stefan "Why QEMU should move from C to Rust", the rust-vmm

RE: eMMC support

2020-09-21 Thread Sai Pavan Boddu
Hi Cedric, > -Original Message- > From: Cédric Le Goater > Sent: Thursday, September 17, 2020 11:55 AM > To: Joel Stanley ; Sai Pavan Boddu > Cc: Philippe Mathieu-Daudé ; Edgar Iglesias > ; qemu-devel@nongnu.org > Subject: Re: eMMC support > > On 9/17/20 2:55 AM, Joel Stanley wrote: > >

RE: eMMC support

2020-09-21 Thread Sai Pavan Boddu
Hi Joel, > -Original Message- > From: Joel Stanley > Sent: Thursday, September 17, 2020 6:25 AM > To: Sai Pavan Boddu ; Cédric Le Goater > > Cc: Philippe Mathieu-Daudé ; Edgar Iglesias > ; qemu-devel@nongnu.org > Subject: Re: eMMC support > > On Wed, 16 Sep 2020 at 18:35, Sai Pavan Bodd

Re: [RFC PATCH 3/6] hw/sd/sdcard: Do not use legal address '0' for INVALID_ADDRESS

2020-09-21 Thread Philippe Mathieu-Daudé
+Paolo & Kevin. On 9/21/20 10:40 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> As it is legal to WRITE/ERASE the address/block 0, >> change the value of this definition to an illegal >> address: UINT32_MAX. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> Cc: Dr. David

RE: [PATCH v7 3/7] usb/hcd-xhci: Split pci wrapper for xhci base model

2020-09-21 Thread Sai Pavan Boddu
Hi Gerd, Thanks, I will update this in V8. Regards, Sai Pavan > -Original Message- > From: Gerd Hoffmann > Sent: Thursday, September 17, 2020 5:14 PM > To: Sai Pavan Boddu > Cc: Peter Maydell ; Markus Armbruster > ; 'Marc-André Lureau' > ; Paolo Bonzini ; > Edgar Iglesias ; Francisco Ed

[RFC] Move to C11 Atomics

2020-09-21 Thread Stefan Hajnoczi
This patch is incomplete but I am looking for feedback on the approach before fully implementing it (which will involve lots of changes). QEMU's atomic.h provides atomic operations and is intended to work with or without . Some of the atomic.h APIs are from C11 Atomics while others are Linux-inspi

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-21 Thread Alex Bennée
Richard Henderson writes: > There are better ways to do this, e.g. meson cmake subproject, > but that requires cmake 3.7 and some of our CI environments > only provide cmake 3.5. > > Nor can we add a meson.build file to capstone/, because the git > submodule would then always report "untracked

[PATCH] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition

2020-09-21 Thread Philippe Mathieu-Daudé
Use self-explicit NANOSECONDS_PER_SECOND definition instead of magic value. Signed-off-by: Philippe Mathieu-Daudé --- block/sheepdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index cbbebc1aaf2..cbc655a1a05 100644 --- a/block/sheepdo

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-21 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> There are better ways to do this, e.g. meson cmake subproject, >> but that requires cmake 3.7 and some of our CI environments >> only provide cmake 3.5. >> >> Nor can we add a meson.build file to capstone/, because the git >> submodule would

Re: [PATCH] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition

2020-09-21 Thread Alberto Garcia
On Mon 21 Sep 2020 01:01:45 PM CEST, Philippe Mathieu-Daudé wrote: > Use self-explicit NANOSECONDS_PER_SECOND definition instead > of magic value. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alberto Garcia Berto

[PULL 0/1] Input 20200921 patches

2020-09-21 Thread Gerd Hoffmann
The following changes since commit 053a4177817db307ec854356e95b5b350800a216: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20200918' i= nto staging (2020-09-18 16:34:26 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/input-202

[PULL 1/1] hw/input/tsc2xxx: Reduce MouseTransformInfo structure exposure

2020-09-21 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé Commit a5d7eb6534a ("Add TSC2301 touchscreen & keypad controller") added the MouseTransformInfo declaration in "ui/console.h", however it is only used in "hw/input/tsc2xxx.h". Reduce the structure exposure by moving it to the single include where it is used. This sho

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

2020-09-21 Thread Fam Zheng
On 2020-09-19 10:22, Zhenyu Ye wrote: > On 2020/9/18 22:06, Fam Zheng wrote: > > > > I can see how blocking in a slow io_submit can cause trouble for main > > thread. I think one way to fix it (until it's made truly async in new > > kernels) is moving the io_submit call to thread pool, and wrapped

Re: [RFC] Move to C11 Atomics

2020-09-21 Thread Paolo Bonzini
On 21/09/20 12:41, Stefan Hajnoczi wrote: > The upshot is that all atomic variables in QEMU need to use C11 Atomic > atomic_* types. This is a big change! The main issue with this is that C11 atomic types do too much magic, including defaulting to seq-cst operations for loads and stores. As docume

Re: [PATCH] migration: Truncate state file in xen-save-devices-state

2020-09-21 Thread Dr. David Alan Gilbert
* Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: > When running the xen-save-devices-state QMP command, if the filename > already exists it will be truncated before dumping the devices' state > into it. > > Signed-off-by: Dov Murik > --- OK, that looks fine to me, so: Reviewed-by: Dr. David Ala

[PULL v3 00/15] virtio,pc,acpi: fixes, tests

2020-09-21 Thread Michael S. Tsirkin
The following changes since commit 053a4177817db307ec854356e95b5b350800a216: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20200918' into staging (2020-09-18 16:34:26 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for

[PULL v3 01/15] linux headers: sync to 5.9-rc4

2020-09-21 Thread Michael S. Tsirkin
From: Jason Wang Update against Linux 5.9-rc4. Cc: Cornelia Huck Cc: Paolo Bonzini Signed-off-by: Jason Wang Message-Id: <20200907104903.31551-2-jasow...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/standard-headers/drm/drm_fourcc.h | 140 ++

[PULL v3 14/15] virtio-iommu: Check gtrees are non null before destroying them

2020-09-21 Thread Michael S. Tsirkin
From: Eric Auger If realize fails, domains and endpoints trees may be NULL. On unrealize(), this produces assertions: "GLib: g_tree_destroy: assertion 'tree != NULL' failed" Check that the trees are non NULL before destroying them. Cc: qemu-sta...@nongnu.org Signed-off-by: Eric Auger Reviewed

[PULL v3 03/15] vhost-vdpa: batch updating IOTLB mappings

2020-09-21 Thread Michael S. Tsirkin
From: Jason Wang To speed up the memory mapping updating between vhost-vDPA and vDPA device driver, this patch passes the IOTLB batching flags via IOTLB API. Two new flags was introduced, VHOST_IOTLB_BATCH_BEGIN is a hint that a bathced IOTLB updating may be initiated from the userspace. VHOST_IO

[PULL v3 05/15] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine

2020-09-21 Thread Michael S. Tsirkin
From: David Hildenbrand Unfortunately, a typo sneeked in: we want to set auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp. Cc: qemu-sta...@nongnu.org # v5.1 Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible) Reported-by: Dr. David Alan Gilber

[PULL v3 02/15] vhost: switch to use IOTLB v2 format

2020-09-21 Thread Michael S. Tsirkin
From: Jason Wang This patch tries to switch to use new kernel IOTLB format V2. Previous version may have inconsistent ABI between 32bit and 64bit machines because of the hole after type field. Refer kernel commit ("429711aec282 vhost: switch to use new message format") for more information. To e

[PULL v3 15/15] virtio-iommu-pci: force virtio version 1

2020-09-21 Thread Michael S. Tsirkin
From: Eric Auger Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on virtio-iommu-pci: qemu-system-aarch64: -device virtio-iommu-pci: device is modern-only, use disable-legacy=on virtio-iommu was introd

[PULL v3 06/15] vhost: recheck dev state in the vhost_migration_log routine

2020-09-21 Thread Michael S. Tsirkin
From: Dima Stepanov vhost-user devices can get a disconnect in the middle of the VHOST-USER handshake on the migration start. If disconnect event happened right before sending next VHOST-USER command, then the vhost_dev_set_log() call in the vhost_migration_log() function will return error. This

[PULL v3 11/15] tests/qtest/vhost-user-test: add migrate_reconnect test

2020-09-21 Thread Michael S. Tsirkin
From: Dima Stepanov Add new migrate_reconnect test for the vhost-user-blk device. Perform a disconnect after sending response for the VHOST_USER_SET_LOG_BASE command. Signed-off-by: Dima Stepanov Reviewed-by: Raphael Norwitz Message-Id: <6f38139d24a1be703a6f1c7d983faccdf21d2a9a.1599813294.git

[PULL v3 07/15] vhost: check queue state in the vhost_dev_set_log routine

2020-09-21 Thread Michael S. Tsirkin
From: Dima Stepanov If the vhost-user-blk daemon provides only one virtqueue, but device was added with several queues, then QEMU will send more VHOST-USER command than expected by daemon side. The vhost_virtqueue_start() routine handles such case by checking the return value from the virtio_queu

[PULL v3 04/15] virtio-mem: detach the element from the virtqueue when error occurs

2020-09-21 Thread Michael S. Tsirkin
From: Li Qiang If error occurs while processing the virtio request we should call 'virtqueue_detach_element' to detach the element from the virtqueue before free the elem. Signed-off-by: Li Qiang Message-Id: <20200816142245.17556-1-liq...@163.com> Fixes: 910b25766b ("virtio-mem: Paravirtualized

[PULL v3 08/15] tests/qtest/vhost-user-test: prepare the tests for adding new dev class

2020-09-21 Thread Michael S. Tsirkin
From: Dima Stepanov For now only vhost-user-net device is supported by the test. Other vhost-user devices are not tested. As a first step make source code refactoring so new devices can reuse the same test routines. To make this provide a new vhost_user_ops structure with the methods to initializ

[PULL v3 10/15] tests/qtest/vhost-user-test: add support for the vhost-user-blk device

2020-09-21 Thread Michael S. Tsirkin
From: Dima Stepanov Add vhost_user_ops structure for the vhost-user-blk device class. Add the test_reconnect and test_migrate tests for this device. Signed-off-by: Dima Stepanov Reviewed-by: Raphael Norwitz Message-Id: Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[PATCH 2/2] libvhost-user: return on error in vu_log_queue_fill()

2020-09-21 Thread Stefan Hajnoczi
vu_panic() is not guaranteed to exit the program. Return early when errors are encountered. Signed-off-by: Stefan Hajnoczi --- contrib/libvhost-user/libvhost-user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c

[PULL v3 09/15] tests/qtest/libqos/virtio-blk: add support for vhost-user-blk

2020-09-21 Thread Michael S. Tsirkin
From: Dima Stepanov Add support for the vhost-user-blk-pci device. This node can be used by the vhost-user-blk tests. Tests for the vhost-user-blk device are added in the following patches. Signed-off-by: Dima Stepanov Message-Id: <4d3e683a87557bcef520826c54aa3e5ab7c64111.1599813294.git.dimas.

Re: [Bug 1896263] [NEW] The bios-tables-test test causes QEMU to crash (Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed) on AMD processors

2020-09-21 Thread Stefan Hajnoczi
On Fri, Sep 18, 2020 at 6:18 PM Apteryx <1896...@bugs.launchpad.net> wrote: > Host CPU: AMD Ryzen 3900X I also hit this test failure. Host CPU: Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz Host kernel: Linux 5.8.6-201.fc32.x86_64 qemu-system-x86_64: error: failed to set MSR 0x4b564d02 to 0x0 qemu-sy

[PULL v3 12/15] tests/qtest/vhost-user-test: enable the reconnect tests

2020-09-21 Thread Michael S. Tsirkin
From: Dima Stepanov For now a QTEST_VHOST_USER_FIXME environment variable is used to separate reconnect tests for the vhost-user-net device. Looks like the reconnect functionality is pretty stable, so this separation is deprecated. Remove it and enable these tests for the default run. Signed-off

Re: [PATCH v5 00/10] x86: fix cpu hotplug with secure boot

2020-09-21 Thread Igor Mammedov
On Mon, 7 Sep 2020 07:23:38 -0400 Igor Mammedov wrote: > v5: > - fix hotplug on Windows when there is more than 256 possible CPUs > (Windows isn't able to handle VarPackage over 255 elements > so process CPUs in batches) > - fix off-by-one in package length (Laszlo) > - fix not se

Re: [PATCH 2/2] microvm: add pcie support

2020-09-21 Thread Gerd Hoffmann
On Fri, Sep 18, 2020 at 08:36:14AM -0400, Michael S. Tsirkin wrote: > On Fri, Sep 18, 2020 at 02:19:11PM +0200, Gerd Hoffmann wrote: > > Uses the existing gpex device which is also used as pcie host bridge on > > arm/aarch64. For now only a 32bit mmio window and no ioport support. > > > > It is d

Re: [PULL v3 00/15] virtio,pc,acpi: fixes, tests

2020-09-21 Thread Li Qiang
Michael S. Tsirkin 于2020年9月21日周一 下午7:30写道: > > The following changes since commit 053a4177817db307ec854356e95b5b350800a216: > > Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20200918' > into staging (2020-09-18 16:34:26 +0100) > > are available in the Git repository at: > >

[PULL v3 13/15] cphp: remove deprecated cpu-add command(s)

2020-09-21 Thread Michael S. Tsirkin
From: Igor Mammedov These were deprecated since 4.0, remove both HMP and QMP variants. Users should use device_add command instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov Reviewed-by: Thoma

Re: [PATCH v3 0/5] Qemu SEV-ES guest support

2020-09-21 Thread Dr. David Alan Gilbert
* Tom Lendacky (thomas.lenda...@amd.com) wrote: > On 9/18/20 5:00 AM, Dr. David Alan Gilbert wrote: > > * Tom Lendacky (thomas.lenda...@amd.com) wrote: > > > On 9/17/20 12:28 PM, Dr. David Alan Gilbert wrote: > > > > * Tom Lendacky (thomas.lenda...@amd.com) wrote: > > > > > From: Tom Lendacky > >

[PATCH 0/2] microvm: add usb support

2020-09-21 Thread Gerd Hoffmann
This depends on the xhci sysfs patch series by Sai Pavan Boddu Gerd Hoffmann (2): microvm: add irq table microvm: add usb support include/hw/i386/microvm.h | 25 + hw/i386/acpi-microvm.c| 20 hw/i386/microvm.c | 12 3 fil

[PATCH 0/2] libvhost-user: return after vu_panic()

2020-09-21 Thread Stefan Hajnoczi
vu_panic() is not guaranteed to exit the program. Return errors instead. Most of the code already does this but I spotted some cases that weren't handled yet. Stefan Hajnoczi (2): libvhost-user: return early on virtqueue errors libvhost-user: return on error in vu_log_queue_fill() contrib/l

[PATCH 1/2] libvhost-user: return early on virtqueue errors

2020-09-21 Thread Stefan Hajnoczi
vu_panic() is not guaranteed to exit the program. Return early when errors are encountered. Note that libvhost-user does not have an "unmap" operation for mapped descriptors. Therefore it is correct to return without explicit cleanup. Signed-off-by: Stefan Hajnoczi --- contrib/libvhost-user/lib

[Bug 1894804] Re: Second DEVICE_DELETED event missing during virtio-blk disk device detach

2020-09-21 Thread Christian Ehrhardt 
Hi, interesting bug report - thanks lee, Kashyap and Sean - as well as Danil for taking a look already. If this would always fail no unplugs would work ever which I knew can't be right as I test that. So we need to find what is different... @Openstack people - is that reliably triggering at th

  1   2   3   4   >