Re: [PATCH v2 09/13] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

On Thu 17 Sep 2020 09:55:15 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > It's recommended for bool functions with errp to return true on success > and false on failure. Non-standard interfaces don't help to understand > the code. The change is also needed to reduce error propagation. > > Signed-o

[PATCH] xen: rework pci_piix3_xen_ide_unplug

This is to allow IDE disks to be unplugged when adding to QEMU via: -drive file=/root/disk_file,if=none,id=ide-disk0,format=raw -device ide-hd,drive=ide-disk0,bus=ide.0,unit=0 as the current code only works for disk added with: -drive file=/root/disk_file,if=ide,index=0,media=disk,form

Re: [PATCH v2 09/13] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

18.09.2020 17:54, Alberto Garcia wrote: On Thu 17 Sep 2020 09:55:15 PM CEST, Vladimir Sementsov-Ogievskiy wrote: It's recommended for bool functions with errp to return true on success and false on failure. Non-standard interfaces don't help to understand the code. The change is also needed to r

Re: [PATCH 0/3] gitlab: add jobs for checking paches

Patchew URL: https://patchew.org/QEMU/20200918132903.1848939-1-berra...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. The full log is a

[Bug 1892604] Re: qemu-system-arm: ../hw/usb/hcd-dwc2.c:666: dwc2_glbreg_read: Assertion `addr <= GINTSTS2' failed.

For my use case the newer image is fine too. I'm mildly curious what the dwc_otg driver is doing in the older image though. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1892604 Title: qemu-system-

Re: [PATCH] xen: rework pci_piix3_xen_ide_unplug

Patchew URL: https://patchew.org/QEMU/20200918145256.1886250-1-anthony.per...@citrix.com/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at http://patchew.org/logs/2020091

Re: [PATCH v2 08/13] block/qcow2: qcow2_get_specific_info(): drop error propagation

On Thu 17 Sep 2020 09:55:14 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > Don't use error propagation in qcow2_get_specific_info(). For this > refactor qcow2_get_bitmap_info_list, its current interface is rather > weird. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Greg Kurz >

[PULL 00/15] virtio,pc,acpi: fixes, tests

The following changes since commit 8ee612722dc08830761516e761dde934c3753a14: Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20200915' into staging (2020-09-16 14:47:50 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for

[PULL 03/15] vhost-vdpa: batch updating IOTLB mappings

From: Jason Wang To speed up the memory mapping updating between vhost-vDPA and vDPA device driver, this patch passes the IOTLB batching flags via IOTLB API. Two new flags was introduced, VHOST_IOTLB_BATCH_BEGIN is a hint that a bathced IOTLB updating may be initiated from the userspace. VHOST_IO

[PULL 09/15] tests/qtest/libqos/virtio-blk: add support for vhost-user-blk

From: Dima Stepanov Add support for the vhost-user-blk-pci device. This node can be used by the vhost-user-blk tests. Tests for the vhost-user-blk device are added in the following patches. Signed-off-by: Dima Stepanov Message-Id: <50d827a7b383de531ac1452e1e0ce3ad961d00af.1598865610.git.dimas.

[PULL 04/15] virtio-mem: detach the element from the virtqueue when error occurs

From: Li Qiang If error occurs while processing the virtio request we should call 'virtqueue_detach_element' to detach the element from the virtqueue before free the elem. Signed-off-by: Li Qiang Message-Id: <20200816142245.17556-1-liq...@163.com> Fixes: 910b25766b ("virtio-mem: Paravirtualized

[PULL 01/15] linux headers: sync to 5.9-rc4

From: Jason Wang Update against Linux 5.9-rc4. Cc: Cornelia Huck Cc: Paolo Bonzini Signed-off-by: Jason Wang Message-Id: <20200907104903.31551-2-jasow...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/standard-headers/drm/drm_fourcc.h | 140 ++

[PULL 07/15] vhost: check queue state in the vhost_dev_set_log routine

From: Dima Stepanov If the vhost-user-blk daemon provides only one virtqueue, but device was added with several queues, then QEMU will send more VHOST-USER command than expected by daemon side. The vhost_virtqueue_start() routine handles such case by checking the return value from the virtio_queu

[PULL 05/15] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine

From: David Hildenbrand Unfortunately, a typo sneeked in: we want to set auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp. Cc: qemu-sta...@nongnu.org # v5.1 Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible) Reported-by: Dr. David Alan Gilber

[PULL 06/15] vhost: recheck dev state in the vhost_migration_log routine

From: Dima Stepanov vhost-user devices can get a disconnect in the middle of the VHOST-USER handshake on the migration start. If disconnect event happened right before sending next VHOST-USER command, then the vhost_dev_set_log() call in the vhost_migration_log() function will return error. This

[PULL 08/15] tests/qtest/vhost-user-test: prepare the tests for adding new dev class

From: Dima Stepanov For now only vhost-user-net device is supported by the test. Other vhost-user devices are not tested. As a first step make source code refactoring so new devices can reuse the same test routines. To make this provide a new vhost_user_ops structure with the methods to initializ

Re: Heterogeneous/AMP example in mainline?

On Fri, 18 Sep 2020 at 14:15, karthik poduval wrote: > Was sifting through the heterogeneous QEMU effort in archives here > https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg06256.html > > Did this effort make it to the mainline ? Are there any examples of > AMP SoC's in the mainline ? In

[PULL 13/15] cphp: remove deprecated cpu-add command(s)

From: Igor Mammedov These were deprecated since 4.0, remove both HMP and QMP variants. Users should use device_add command instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov Reviewed-by: Thoma

[PULL 10/15] tests/qtest/vhost-user-test: add support for the vhost-user-blk device

From: Dima Stepanov Add vhost_user_ops structure for the vhost-user-blk device class. Add the test_reconnect and test_migrate tests for this device. Signed-off-by: Dima Stepanov Message-Id: <960720d82815926a648a3688bf6a38887eb0bf8e.1598865610.git.dimas...@yandex-team.ru> Reviewed-by: Michael S

[PULL 11/15] tests/qtest/vhost-user-test: add migrate_reconnect test

From: Dima Stepanov Add new migrate_reconnect test for the vhost-user-blk device. Perform a disconnect after sending response for the VHOST_USER_SET_LOG_BASE command. Signed-off-by: Dima Stepanov Message-Id: Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/

Re: [PULL 00/15] virtio,pc,acpi: fixes, tests

On Fri, 18 Sep 2020 at 16:05, Michael S. Tsirkin wrote: > > The following changes since commit 8ee612722dc08830761516e761dde934c3753a14: > > Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20200915' > into staging (2020-09-16 14:47:50 +0100) > > are available in the Git reposito

[PULL 12/15] tests/qtest/vhost-user-test: enable the reconnect tests

From: Dima Stepanov For now a QTEST_VHOST_USER_FIXME environment variable is used to separate reconnect tests for the vhost-user-net device. Looks like the reconnect functionality is pretty stable, so this separation is deprecated. Remove it and enable these tests for the default run. Signed-off

[PULL 14/15] virtio-iommu: Check gtrees are non null before destroying them

From: Eric Auger If realize fails, domains and endpoints trees may be NULL. On unrealize(), this produces assertions: "GLib: g_tree_destroy: assertion 'tree != NULL' failed" Check that the trees are non NULL before destroying them. Cc: qemu-sta...@nongnu.org Signed-off-by: Eric Auger Reviewed

[PULL 15/15] virtio-iommu-pci: force virtio version 1

From: Eric Auger Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on virtio-iommu-pci: qemu-system-aarch64: -device virtio-iommu-pci: device is modern-only, use disable-legacy=on virtio-iommu was introd

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

cc -o block-curl.so -Wl,--as-needed -Wl,--allow-shlib-undefined -shared -fPIC -Wl,--start-group -Wl,-soname,block-curl.so -Wl,--whole- archive libblock-curl.a -Wl,--no-whole-archive -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -m64 -Wl,-O1,--sort-common,--as- needed,-z,relro,-z,now -fstack-protector

Re: [PATCH] target/i386: always create kvmclock device

On Thu, Sep 17, 2020 at 06:44:10PM +0100, Dr. David Alan Gilbert wrote: [...] > > >> > > > >> > Shouldn't the old check used when machine type <= 5.1 in order to avoid > > >> > migration incompatibility ? > > >> > > >> Hm, when the check fails we just don't create the device and no error is > >

Re: [PATCH v2] tests/acceptance: Skip slow quanta-gsj U-boot+Linux test

On Fri, Sep 18, 2020 at 11:35 AM Philippe Mathieu-Daudé wrote: > > The 'arm_quanta_gsj_initrd' test is timeouting on GitLab CI: > https://gitlab.com/philmd/qemu/-/jobs/745483978#L846 > and also sometimes on my workstation, so proceed as with > the other slow tests: do not run it by default. > The

Re: [PATCH v2 10/13] block/qcow2-bitmap: return status from qcow2_store_persistent_dirty_bitmaps

On Thu 17 Sep 2020 09:55:16 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > It's better to return status together with setting errp. It makes > possible to avoid error propagation. > > While being here, put ERRP_GUARD() to fix error_prepend(errp, ...) > usage inside qcow2_store_persistent_dirty_bitm

[PULL 0/1] fw-cfg patches for 2020-09-18

The following changes since commit e883b492c221241d28aaa322c61536436090538a: Merge remote-tracking branch 'remotes/legoater/tags/pull-aspeed-20200918' into staging (2020-09-18 13:36:42 +0100) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/fw_cf

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

When I looked at /etc/makepkg.conf on my Archlinux, I found; LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now" -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896096 Title: Git version: Bu

Re: [PATCH v2 09/13] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

On Thu, 17 Sep 2020 22:55:15 +0300 Vladimir Sementsov-Ogievskiy wrote: > It's recommended for bool functions with errp to return true on success > and false on failure. Non-standard interfaces don't help to understand > the code. The change is also needed to reduce error propagation. > > Signed-

[PULL 1/1] hw/nvram/fw_cfg: fix FWCfgDataGeneratorClass::get_data() consumption

From: Laszlo Ersek The documentation on g_byte_array_free() says: > Returns > > the element data if free_segment is FALSE, otherwise NULL. The element > data should be freed using g_free(). Because we currently ca

Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

On Thu 17 Sep 2020 09:55:18 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > qcow2_do_open correctly sets errp on each failure path. So, we can > simplify code in qcow2_co_invalidate_cache() and drop explicit error > propagation. We should use ERRP_GUARD() (accordingly to comment in > include/qapi/er

Re: [PATCH 13/37] qapi/common.py: add notational type hints

On 9/18/20 7:14 AM, Markus Armbruster wrote: John Snow writes: On 9/17/20 10:32 AM, Markus Armbruster wrote: Question on the subject line: what makes a type hint notational? My cover letter explains that every time I use this phrase, I mean to state that "This patch adds exclusively type n

Re: [PATCH] target/i386: always create kvmclock device

* Antoine Damhet (antoine.dam...@blade-group.com) wrote: > On Thu, Sep 17, 2020 at 06:44:10PM +0100, Dr. David Alan Gilbert wrote: > > [...] > > > > >> > > > > >> > Shouldn't the old check used when machine type <= 5.1 in order to > > > >> > avoid > > > >> > migration incompatibility ? > > > >>

Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

On Thu, 17 Sep 2020 22:55:18 +0300 Vladimir Sementsov-Ogievskiy wrote: > qcow2_do_open correctly sets errp on each failure path. So, we can > simplify code in qcow2_co_invalidate_cache() and drop explicit error > propagation. We should use ERRP_GUARD() (accordingly to comment in > include/qapi/er

Re: [PATCH] tests/acceptance: Reduce quanta-gsj U-boot+Linux test time

On Fri, Sep 18, 2020 at 7:27 AM Philippe Mathieu-Daudé wrote: > > On 9/18/20 4:23 PM, Philippe Mathieu-Daudé wrote: > > The 'arm_quanta_gsj_initrd' test is timeouting on GitLab CI: > > https://gitlab.com/philmd/qemu/-/jobs/745483978#L846 > > > > Use the same trick from the 'arm_quanta_gsj' test to

Re: [PULL 0/1] fw-cfg patches for 2020-09-18

Patchew URL: https://patchew.org/QEMU/20200918152207.157589-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at http://patchew.org/logs/20200918152207.15

[PATCH v2] tests/check-block: Do not run the iotests with old versions of bash

macOS is shipped with a very old version of the bash (3.2), which is currently not suitable for running the iotests anymore (e.g. it is missing support for "readarray" which is used in the file tests/qemu-iotests/common.filter). Add a check to skip the iotests in this case - if someone still wants

[PATCH] iotests/046: Filter request length

For its concurrent requests, 046 has always filtered the offset, probably because concurrent requests may settle in any order. However, it did not filter the request length, and so if requests with different lengths settle in an unexpected order (notably the longer request before the shorter reque

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

Please attach config-host.mak and config.log. Hopefully that is enough to blame one of you, :) configure, meson.build or Meson itself. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896096 Title:

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

The problem is caused by the extra flags you're forcing on the compiler: Using 'CFLAGS' from environment with value: '-O2 -g -fPIE -DPIE -std=gnu99 -Wall' Using 'LDFLAGS' from environment with value: '-g -pie -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Using 'CPPFLAGS' from environment wi

Re: [PULL 07/15] vhost: check queue state in the vhost_dev_set_log routine

Hi MST - I think you picked an earlier version of the change with a bug. See my comment bellow: On Fri, Sep 18, 2020 at 11:11 AM Michael S. Tsirkin wrote: > > From: Dima Stepanov > > If the vhost-user-blk daemon provides only one virtqueue, but device was > added with several queues, then QEMU w

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

** Attachment added: "config-host.mak asked for" https://bugs.launchpad.net/qemu/+bug/1896096/+attachment/5412211/+files/config-host.mak -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896096 Titl

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

** Attachment added: "config.log asked for" https://bugs.launchpad.net/qemu/+bug/1896096/+attachment/5412210/+files/config.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896096 Title: Git v

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

I used these settings until Qemu 5.1.0 was released and it worked. These flags are used by archlinux for stable qemu release packaging. See https://github.com/archlinux/svntogit- packages/blob/packages/qemu/trunk/PKGBUILD Since qemu moved to meson, it breaks. I don't know why it used to work befo

Re: [PATCH v2] tests/check-block: Do not run the iotests with old versions of bash

Patchew URL: https://patchew.org/QEMU/20200918153514.330705-1-th...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at http://patchew.org/logs/20200918153514.330

Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

On Fri 18 Sep 2020 05:30:06 PM CEST, Greg Kurz wrote: >> qcow2_do_open correctly sets errp on each failure path. So, we can >> simplify code in qcow2_co_invalidate_cache() and drop explicit error >> propagation. We should use ERRP_GUARD() (accordingly to comment in >> include/qapi/error.h) together

[Bug 1895703] Re: performance degradation in tcg since Meson switch

I get $ qemu-m68k ./matmult_double-m68k Error while loading /home/pbonzini/matmult_double-m68k: Permission denied -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895703 Title: performance degradati

Re: [PATCH v2] tests/check-block: Do not run the iotests with old versions of bash

On Fri, Sep 18, 2020 at 05:35:14PM +0200, Thomas Huth wrote: > macOS is shipped with a very old version of the bash (3.2), which > is currently not suitable for running the iotests anymore (e.g. > it is missing support for "readarray" which is used in the file > tests/qemu-iotests/common.filter). A

Re: [PATCH v3 0/5] Qemu SEV-ES guest support

On 9/17/20 10:40 PM, Sean Christopherson wrote: On Thu, Sep 17, 2020 at 01:56:21PM -0500, Tom Lendacky wrote: On 9/17/20 12:28 PM, Dr. David Alan Gilbert wrote: * Tom Lendacky (thomas.lenda...@amd.com) wrote: From: Tom Lendacky This patch series provides support for launching an SEV-ES guest

Re: [PATCH v2] s390x/tcg: Implement MONITOR CALL

On 9/18/20 1:51 AM, David Hildenbrand wrote: > Recent upstream Linux uses the MONITOR CALL instruction for things like > BUG_ON() and WARN_ON(). We currently inject an operation exception when > we hit a MONITOR CALL instruction - which is wrong, as the instruction > is not glued to specific CPU fe

[PATCH v5 0/4] Fixes curses on msys2/mingw

And also convert related configure script to meson. Yonggang Luo (4): curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw curses: Fixes curses compiling errors. win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE are defined on msys2/ming

[PATCH v5 2/4] curses: Fixes curses compiling errors.

This is the compiling error: ../ui/curses.c: In function 'curses_refresh': ../ui/curses.c:256:5: error: 'next_maybe_keycode' may be used uninitialized in this function [-Werror=maybe-uninitialized] 256 | curses2foo(_curses2keycode, _curseskey2keycode, chr, maybe_keycode) | ^~~~

Re: [PATCH v2] tests/acceptance: Skip slow quanta-gsj U-boot+Linux test

On Fri, Sep 18, 2020 at 7:33 AM Philippe Mathieu-Daudé wrote: > > The 'arm_quanta_gsj_initrd' test is timeouting on GitLab CI: > https://gitlab.com/philmd/qemu/-/jobs/745483978#L846 > and also sometimes on my workstation, so proceed as with > the other slow tests: do not run it by default. > The t

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

FYI, QEMU automatically enables PIC/PIE as needed, so there's no need to set it via these flags. In fact everything in your $CFLAGS is already set by QEMU out of the box too. For LDFLAGS you can cull the -g and -pie -- You received this bug notification because you are a member of qemu- devel-m

Re: [PATCH 09/37] qapi/common.py: Add indent manager

On 9/18/20 6:55 AM, Markus Armbruster wrote: John Snow writes: We'll get to them in due time. For now, please admire the lipstick. If I take off my glasses and step six feet back, I just might be able to overlook it. I consider writing a nice __repr__ good habit, I'd prefer not to delete

Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

18.09.2020 18:51, Alberto Garcia wrote: On Fri 18 Sep 2020 05:30:06 PM CEST, Greg Kurz wrote: qcow2_do_open correctly sets errp on each failure path. So, we can simplify code in qcow2_co_invalidate_cache() and drop explicit error propagation. We should use ERRP_GUARD() (accordingly to comment in

[PATCH v5 1/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

msys2/mingw lacks the POSIX-required langinfo.h. gcc test.c -DNCURSES_WIDECHAR -I/mingw64/include/ncursesw -pipe -lncursesw -lgnurx -ltre -lintl -liconv test.c:4:10: fatal error: langinfo.h: No such file or directory 4 | #include | ^~~~ compilation terminated. So we u

Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

On Fri, 18 Sep 2020 19:01:34 +0300 Vladimir Sementsov-Ogievskiy wrote: > 18.09.2020 18:51, Alberto Garcia wrote: > > On Fri 18 Sep 2020 05:30:06 PM CEST, Greg Kurz wrote: > >>> qcow2_do_open correctly sets errp on each failure path. So, we can > >>> simplify code in qcow2_co_invalidate_cache() an

[Bug 1895703] Re: performance degradation in tcg since Meson switch

Paolo: what are the permissions on matmult_double-m68k on your local fs? (needs to be readable/executable by you) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895703 Title: performance degradatio

[PATCH v5 3/4] win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE are defined on msys2/mingw

We remove the CONFIG_LOCALTIME_R detection option in configure, and move the check existence of gmtime_r from configure into C header and source directly by using macro `_POSIX_THREAD_SAFE_FUNCTIONS`. Before this patch, the configure script are always assume the compiler doesn't define _POSIX_C_

[PATCH v5 4/4] configure: Fixes ncursesw detection under msys2/mingw by convert them to meson

The mingw pkg-config are showing following absolute path and contains : as the separator, -D_XOPEN_SOURCE=600 -D_POSIX_C_SOURCE=199506L -IC:/CI-Tools/msys64/mingw64/include/ncursesw:-I/usr/include/ncursesw: -DNCURSES_WIDECHAR -D_XOPEN_SOURCE=600 -D_POSIX_C_SOURCE=199506L -IC -pipe -lncursesw -l

[PULL v2 01/15] linux headers: sync to 5.9-rc4

From: Jason Wang Update against Linux 5.9-rc4. Cc: Cornelia Huck Cc: Paolo Bonzini Signed-off-by: Jason Wang Message-Id: <20200907104903.31551-2-jasow...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/standard-headers/drm/drm_fourcc.h | 140 ++

[PULL v2 00/15] virtio,pc,acpi: fixes, tests

changes from v1: rebased on master pick a fixed patch version - noticed by Raphael The following changes since commit e883b492c221241d28aaa322c61536436090538a: Merge remote-tracking branch 'remotes/legoater/tags/pull-aspeed-20200918' into staging (2020-09-18 13:36:42 +

Re: [PATCH v2 13/13] block/qed: bdrv_qed_do_open: deal with errp

On Thu, 17 Sep 2020 22:55:19 +0300 Vladimir Sementsov-Ogievskiy wrote: > Set errp always on failure. Generic bdrv_open_driver supports driver > functions which can return negative value and forget to set errp. > That's a strange thing.. Let's improve bdrv_qed_do_open to not behave > this way. Thi

[PULL v2 09/15] tests/qtest/libqos/virtio-blk: add support for vhost-user-blk

From: Dima Stepanov Add support for the vhost-user-blk-pci device. This node can be used by the vhost-user-blk tests. Tests for the vhost-user-blk device are added in the following patches. Signed-off-by: Dima Stepanov Message-Id: <4d3e683a87557bcef520826c54aa3e5ab7c64111.1599813294.git.dimas.

[PULL v2 04/15] virtio-mem: detach the element from the virtqueue when error occurs

From: Li Qiang If error occurs while processing the virtio request we should call 'virtqueue_detach_element' to detach the element from the virtqueue before free the elem. Signed-off-by: Li Qiang Message-Id: <20200816142245.17556-1-liq...@163.com> Fixes: 910b25766b ("virtio-mem: Paravirtualized

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

Before the meson port, the "-pie" arg was on the CLI *before* the "-shared" arg so the "-shared" wins and results in a shared library. After the meson port, "-shared" appears first, and so "-pie" wins and tries to create an executable. IOW, this passing of -pie was always wrong, and it was only

Re: [PATCH] configure: fixes indent of $meson setup

Hi Bonzini, please queue this On Fri, Sep 18, 2020 at 10:45 PM Yonggang Luo wrote: > > convert these line from tab to space > > Signed-off-by: Yonggang Luo > --- > configure | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/configure b/configure > index 3757e48b17

[PULL v2 02/15] vhost: switch to use IOTLB v2 format

From: Jason Wang This patch tries to switch to use new kernel IOTLB format V2. Previous version may have inconsistent ABI between 32bit and 64bit machines because of the hole after type field. Refer kernel commit ("429711aec282 vhost: switch to use new message format") for more information. To e

[PULL v2 07/15] vhost: check queue state in the vhost_dev_set_log routine

From: Dima Stepanov If the vhost-user-blk daemon provides only one virtqueue, but device was added with several queues, then QEMU will send more VHOST-USER command than expected by daemon side. The vhost_virtqueue_start() routine handles such case by checking the return value from the virtio_queu

Re: [PATCH v5 0/4] Fixes curses on msys2/mingw

Hi Bonzini, help to look at this, I convert curses and it's depends iconv to meson On Sat, Sep 19, 2020 at 12:03 AM Yonggang Luo wrote: > > And also convert related configure script to meson. > > Yonggang Luo (4): > curses: Fixes compiler error that complain don't have langinfo.h on > msys2

[PULL v2 06/15] vhost: recheck dev state in the vhost_migration_log routine

From: Dima Stepanov vhost-user devices can get a disconnect in the middle of the VHOST-USER handshake on the migration start. If disconnect event happened right before sending next VHOST-USER command, then the vhost_dev_set_log() call in the vhost_migration_log() function will return error. This

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

So, I'll try to tweak LDFLAGS and if it doesn't work, well... That's life. Thanks for the infos. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896096 Title: Git version: Build process is broken in

[PULL v2 03/15] vhost-vdpa: batch updating IOTLB mappings

From: Jason Wang To speed up the memory mapping updating between vhost-vDPA and vDPA device driver, this patch passes the IOTLB batching flags via IOTLB API. Two new flags was introduced, VHOST_IOTLB_BATCH_BEGIN is a hint that a bathced IOTLB updating may be initiated from the userspace. VHOST_IO

[PULL v2 11/15] tests/qtest/vhost-user-test: add migrate_reconnect test

From: Dima Stepanov Add new migrate_reconnect test for the vhost-user-blk device. Perform a disconnect after sending response for the VHOST_USER_SET_LOG_BASE command. Signed-off-by: Dima Stepanov Reviewed-by: Raphael Norwitz Message-Id: <6f38139d24a1be703a6f1c7d983faccdf21d2a9a.1599813294.git

[PULL v2 12/15] tests/qtest/vhost-user-test: enable the reconnect tests

From: Dima Stepanov For now a QTEST_VHOST_USER_FIXME environment variable is used to separate reconnect tests for the vhost-user-net device. Looks like the reconnect functionality is pretty stable, so this separation is deprecated. Remove it and enable these tests for the default run. Signed-off

Re: [PATCH v3 1/2] Introduce (x86) CPU model deprecation API

On Fri, Sep 18, 2020 at 01:48:18PM +0800, Robert Hoo wrote: > On Thu, 2020-09-17 at 14:18 -0400, Eduardo Habkost wrote: > > I think the patch looks better now, thanks! > > > > Just a few minor questions and suggestions: > > > > On Wed, Sep 16, 2020 at 04:37:13PM +0800, Robert Hoo wrote: > > > Com

[PULL v2 05/15] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine

From: David Hildenbrand Unfortunately, a typo sneeked in: we want to set auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp. Cc: qemu-sta...@nongnu.org # v5.1 Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible) Reported-by: Dr. David Alan Gilber

[PULL v2 13/15] cphp: remove deprecated cpu-add command(s)

From: Igor Mammedov These were deprecated since 4.0, remove both HMP and QMP variants. Users should use device_add command instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov Reviewed-by: Thoma

[PULL v2 08/15] tests/qtest/vhost-user-test: prepare the tests for adding new dev class

From: Dima Stepanov For now only vhost-user-net device is supported by the test. Other vhost-user devices are not tested. As a first step make source code refactoring so new devices can reuse the same test routines. To make this provide a new vhost_user_ops structure with the methods to initializ

Re: [PULL 0/1] fw-cfg patches for 2020-09-18

On Fri, 18 Sep 2020 at 16:31, Philippe Mathieu-Daudé wrote: > > The following changes since commit e883b492c221241d28aaa322c61536436090538a: > > Merge remote-tracking branch 'remotes/legoater/tags/pull-aspeed-20200918' > into staging (2020-09-18 13:36:42 +0100) >

[PULL v2 10/15] tests/qtest/vhost-user-test: add support for the vhost-user-blk device

From: Dima Stepanov Add vhost_user_ops structure for the vhost-user-blk device class. Add the test_reconnect and test_migrate tests for this device. Signed-off-by: Dima Stepanov Reviewed-by: Raphael Norwitz Message-Id: Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

Re: [PULL 32/36] tests/acceptance: console boot tests for quanta-gsj

On Fri, Sep 18, 2020 at 6:57 AM Philippe Mathieu-Daudé wrote: > > On Fri, Sep 18, 2020 at 3:52 PM Philippe Mathieu-Daudé > wrote: > > > > Hi Havard, > > > > On Mon, Sep 14, 2020 at 5:47 PM Peter Maydell > > wrote: > > > > > > From: Havard Skinnemoen > > > > > > This adds two acceptance tests f

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

Even with LDFLAGS tweaking, it breaks. Anyway, thanks for your help here. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896096 Title: Git version: Build process is broken in block_curl.c.o Status

Re: [PULL v2 00/15] virtio,pc,acpi: fixes, tests

On Fri, 18 Sep 2020 at 17:36, Michael S. Tsirkin wrote: > > found a problem on some build systems. sorry. > will post v3. aarch64, osx, x86-64 clang all run into this one: ../../tests/qtest/vhost-user-test.c: In function ‘vu_blk_get_config’: ../../tests/qtest/vhost-user-test.c:1076:14: error: ta

[PULL v2 15/15] virtio-iommu-pci: force virtio version 1

From: Eric Auger Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on virtio-iommu-pci: qemu-system-aarch64: -device virtio-iommu-pci: device is modern-only, use disable-legacy=on virtio-iommu was introd

[PULL v2 14/15] virtio-iommu: Check gtrees are non null before destroying them

From: Eric Auger If realize fails, domains and endpoints trees may be NULL. On unrealize(), this produces assertions: "GLib: g_tree_destroy: assertion 'tree != NULL' failed" Check that the trees are non NULL before destroying them. Cc: qemu-sta...@nongnu.org Signed-off-by: Eric Auger Reviewed

Re: [PULL v2 00/15] virtio,pc,acpi: fixes, tests

es since commit e883b492c221241d28aaa322c61536436090538a: > > Merge remote-tracking branch 'remotes/legoater/tags/pull-aspeed-20200918' > into staging (2020-09-18 13:36:42 +0100) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/fo

RE: [RFC PATCH 04/12] device_tree: add qemu_fdt_add_path

> From: Andrew Jones [mailto:drjo...@redhat.com] > Sent: Friday, September 18, 2020 7:07 AM > > On Fri, Sep 18, 2020 at 12:25:19AM +, Salil Mehta wrote: > > > > > From: Qemu-arm > [mailto:qemu-arm-bounces+salil.mehta=huawei@nongnu.org] > > > On Behalf Of Andrew Jones > > > Sent: Thursday,

Re: [PULL v2 00/15] virtio,pc,acpi: fixes, tests

Patchew URL: https://patchew.org/QEMU/20200918161836.318893-1-...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. The full log is available

Re: [Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

What's your new configure command line? Attach the config.log and make V=1 log again please. That said, I noticed that the flags were included twice in the linker command line so maybe you've only removed them in one place. Il ven 18 set 2020, 18:20 Frederic Bezies <1896...@bugs.launchpad.net> ha

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

FWIW, I reproduced the original failure using your LDFLAGS, and tested that removing '-pie' made it work -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896096 Title: Git version: Build process is b

Re: Heterogeneous/AMP example in mainline?

Thanks Peter, I will go through the Xilinx example. -- Regards, Karthik Poduval On Fri, Sep 18, 2020 at 8:08 AM Peter Maydell wrote: > On Fri, 18 Sep 2020 at 14:15, karthik poduval > wrote: > > Was sifting through the heterogeneous QEMU effort in archives here > > https://lists.gnu.org/archiv

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

And qemu log build using make -V=1. Hope it helps. ** Attachment added: "qemuv1-2.log" https://bugs.launchpad.net/qemu/+bug/1896096/+attachment/5412260/+files/qemuv1-2.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

Configure line: configure \ --prefix=/usr \ --sysconfdir=/etc \ --localstatedir=/var \ --libexecdir=/usr/lib/qemu \ --smbd=/usr/bin/smbd \ --extra-ldflags="-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now" \ --enable-modules \ --enable-sdl \ --disable-werror \

[Bug 1895703] Re: performance degradation in tcg since Meson switch

Uff, of course... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895703 Title: performance degradation in tcg since Meson switch Status in QEMU: New Bug description: The buildsys conversion t

[Bug 1896263] [NEW] The bios-tables-test test causes QEMU to crash (Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed) on AMD processors

Public bug reported: QEMU release version: Any recent version (5.0.0, 5.1.0, git master) Host CPU: AMD Ryzen 3900X The following backtrace is from commit e883b492c221241d28aaa322c61536436090538a. QTEST_QEMU_BINARY=./build/qemu-system-x86_64 gdb ./build/tests/qtest/bios-tables-test GNU gdb (GDB)

Re: [PULL 05/24] Simplify the .gitignore file

On Wed, 16 Sep 2020 at 12:47, Thomas Huth wrote: > > Now that we always do out-of-tree builds (and the in-tree builds are > faked via a "build" directory), we can simplify out .gitignore file > quite a bit. > > Message-Id: <20200909080305.258961-1-th...@redhat.com> > Reviewed-by: Philippe Mathieu-

<    1   2   3   4   5   6   >