[PATCH] Add a comment in bios-tables-test.c to clarify the reason behind approach

2020-09-18 Thread Ani Sinha
A comment blob is added in bios-tables-test.c that explains the process of updating the ACPI table blobs when new tests are added or old tests are modified or code is committed that affect tests. The explanation would help future contributors follow the correct process when making code changes that

[PATCH] spice: remove obsolete callback

2020-09-18 Thread marcandre . lureau
From: Marc-André Lureau The "attach_worker" callbacks aren't doing anything in QEMU, but they were mandatory until Spice server commit 6aa1a17c69dc3cc02f338a78b3266e4c00ea1c1a ("spice-qxl: Remove QXLWorker definition"). Furthermore, the old spelling is deprecated since commit 974692bda1e77af92b7

Re: [PATCH] spice: remove obsolete callback

2020-09-18 Thread Philippe Mathieu-Daudé
On 9/18/20 12:07 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The "attach_worker" callbacks aren't doing anything in QEMU, but they > were mandatory until Spice server commit > 6aa1a17c69dc3cc02f338a78b3266e4c00ea1c1a ("spice-qxl: Remove QXLWorker > definition"). > > Furt

Re: [PATCH v2 2/2] virtio-iommu-pci: force virtio version 1

2020-09-18 Thread Auger Eric
Hi Connie, On 9/18/20 11:29 AM, Cornelia Huck wrote: > On Tue, 8 Sep 2020 21:33:09 +0200 > Eric Auger wrote: > >> Commit 9b3a35ec82 ("virtio: verify that legacy support is not >> accidentally on") added a safety check that requires to set >> 'disable-legacy=on' on virtio-iommu-pci: >> >> qemu-s

Re: [PATCH v2] hw/ide: check null block before _cancel_dma_sync

2020-09-18 Thread P J P
+-- On Fri, 18 Sep 2020, Li Qiang wrote --+ | Update v2: use an assert() call | ->https://lists.nongnu.org/archive/html/qemu-devel/2020-08/msg08336.html ... | I think it is better to defer this check to 'ide_cancel_dma_sync'. | 'ide_cancel_dma_sync' is also called by 'cmd_device_reset' and all o

Re: [PATCH v10 2/7] libvhost-user: remove watch for kick_fd when de-initialize vu-dev

2020-09-18 Thread Stefan Hajnoczi
On Fri, Sep 18, 2020 at 04:09:07PM +0800, Coiby Xu wrote: > When the client is running in gdb and quit command is run in gdb, > QEMU will still dispatch the event which will cause segment fault in > the callback function. > > Signed-off-by: Coiby Xu > --- > contrib/libvhost-user/libvhost-user.c

Re: [PATCH V3 08/10] disas/: fix some comment spelling errors

2020-09-18 Thread Alex Bennée
Laurent Vivier writes: > Le 17/09/2020 à 10:44, Alex Bennée a écrit : >> >> zhaolichang writes: >> >>> I found that there are many spelling errors in the comments of qemu, >>> so I used the spellcheck tool to check the spelling errors >>> and finally found some spelling errors in the disas f

Re: [PATCH 06/37] qapi: delint using flake8

2020-09-18 Thread Markus Armbruster
John Snow writes: > On 9/17/20 3:54 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 9/16/20 8:12 AM, Markus Armbruster wrote: John Snow writes: > Petty style guide fixes and line length enforcement. Not a big win, not > a big loss, but flake8 passes 100% on the q

[PATCH 1/6] meson: move libudev test

2020-09-18 Thread Thomas Huth
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Message-Id: <20200916162621.100141-2-pbonz...@redhat.com> Signed-off-by: Thomas Huth --- configure | 14 -- meson.build | 7 --- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/configure b/configure index 75644

[PATCH 5/6] travis.yml: Update Travis to use Bionic and Focal instead of Xenial

2020-09-18 Thread Thomas Huth
According to our support policy, we do not support Xenial anymore. Time to switch the bigger parts of the builds to Focal instead. Some few jobs have to be updated to Bionic instead, since they are currently still failing on Focal otherwise. Also "--disable-pie" is causing linker problems with newe

[PATCH 0/6] Update Travis from Xenial to Bionic and Focal

2020-09-18 Thread Thomas Huth
According to our support policy, we do not support Xenial anymore. Time to switch the Travis jobs to Focal or Bionic instead now. Paolo Bonzini (2): meson: move libudev test meson: move libmpathpersist test Thomas Huth (4): migration: Silence compiler warning in global_state_store_running()

[PATCH 3/6] migration: Silence compiler warning in global_state_store_running()

2020-09-18 Thread Thomas Huth
GCC 9.3.0 on Ubuntu complains: In file included from /usr/include/string.h:495, from /home/travis/build/huth/qemu/include/qemu/osdep.h:87, from ../migration/global_state.c:13: In function ‘strncpy’, inlined from ‘global_state_store_running’ at ../migration/gl

[PATCH 2/6] meson: move libmpathpersist test

2020-09-18 Thread Thomas Huth
From: Paolo Bonzini This is the first compiler/linker test that has been moved to Meson. Add more section headings to keep things clearer. Signed-off-by: Paolo Bonzini [thuth: Add check for mpathpersist.found() before showing mpathpersist_new_api] Signed-off-by: Thomas Huth --- configure

[PATCH 4/6] travis.yml: Drop the default softmmu builds

2020-09-18 Thread Thomas Huth
The total runtime of all Travis jobs is very long and we are testing all softmmu targets in the gitlab-CI already - so we can speed up the Travis testing a little bit by not testing the softmmu targets here anymore. Reviewed-by: Daniel P. Berrangé Acked-by: Alex Bennée Acked-by: Philippe Mathieu

[PATCH 6/6] travis.yml: Drop the superfluous Python 3.6 build

2020-09-18 Thread Thomas Huth
Python 3.6 is already the default Python in the jobs that are based on Ubuntu Bionic, so it does not make much sense to test this again separately. Signed-off-by: Thomas Huth --- .travis.yml | 8 1 file changed, 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index 80da4ebc8e..02

Re: [PATCH] fdc: check null block pointer before blk_pwrite

2020-09-18 Thread Li Qiang
P J P 于2020年8月27日周四 下午7:41写道: > > From: Prasad J Pandit > > While transferring data via fdctrl_write_data(), check that > current drive does not have a null block pointer. Avoid > null pointer dereference. > > -> https://ruhr-uni-bochum.sciebo.de/s/NNWP2GfwzYKeKwE?path=%2Ffdc_nullptr1 > ==16

Re: [PATCH 09/37] qapi/common.py: Add indent manager

2020-09-18 Thread Markus Armbruster
John Snow writes: > On 9/17/20 4:07 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 9/16/20 11:13 AM, Markus Armbruster wrote: John Snow writes: > > Let's replace "the indent" by "the indentation" globally. >>> >>> They're both cromulent as nouns and one is shor

[PATCH] usb: fix u2f build

2020-09-18 Thread Gerd Hoffmann
Just use qemu_open_old() for a quick fix, switch to better error handling left for another day. Fixes: 448058aa99aa ("util: rename qemu_open() to qemu_open_old()") Cc: César Belley Signed-off-by: Gerd Hoffmann --- hw/usb/u2f-emulated.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH] usb: fix u2f build

2020-09-18 Thread Daniel P . Berrangé
On Fri, Sep 18, 2020 at 01:01:22PM +0200, Gerd Hoffmann wrote: > Just use qemu_open_old() for a quick fix, switch > to better error handling left for another day. > > Fixes: 448058aa99aa ("util: rename qemu_open() to qemu_open_old()") > Cc: César Belley > Signed-off-by: Gerd Hoffmann > --- > hw

Re: [PATCH 10/37] qapi/common.py: delint with pylint

2020-09-18 Thread Markus Armbruster
John Snow writes: > On 9/17/20 10:15 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Signed-off-by: John Snow >>> --- >>> scripts/qapi/common.py | 16 +++- >>> scripts/qapi/schema.py | 14 +++--- >>> 2 files changed, 14 insertions(+), 16 deletions(-) >>> >>> di

Re: [PATCH 13/37] qapi/common.py: add notational type hints

2020-09-18 Thread Markus Armbruster
John Snow writes: > On 9/17/20 10:32 AM, Markus Armbruster wrote: >> Question on the subject line: what makes a type hint notational? >> > > My cover letter explains that every time I use this phrase, I mean to > state that "This patch adds exclusively type notations and makes no > functional c

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

2020-09-18 Thread Frederic Bezies
Full build log from start to crash. ** Attachment added: "qemu.log" https://bugs.launchpad.net/qemu/+bug/1896096/+attachment/5412152/+files/qemu.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

2020-09-18 Thread Zhenyu Ye
Hi Stefan, Fam, On 2020/9/18 0:01, Fam Zheng wrote: > On 2020-09-17 16:44, Stefan Hajnoczi wrote: >> On Thu, Sep 17, 2020 at 03:36:57PM +0800, Zhenyu Ye wrote: >>> When the hang occurs, the QEMU is blocked at: >>> >>> #0 0x95762b64 in ?? () from target:/usr/lib64/libpthread.so.0 >>>

Re: [PATCH] spice: remove obsolete callback

2020-09-18 Thread Frediano Ziglio
> > From: Marc-André Lureau > > The "attach_worker" callbacks aren't doing anything in QEMU, but they > were mandatory until Spice server commit > 6aa1a17c69dc3cc02f338a78b3266e4c00ea1c1a ("spice-qxl: Remove QXLWorker > definition"). > > Furthermore, the old spelling is deprecated since commit

Re: [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements

2020-09-18 Thread Thomas Huth
On 17/09/2020 17.30, Peter Maydell wrote: > On Thu, 17 Sep 2020 at 16:29, Thomas Huth wrote: >> Ok, sounds like I should respin my patch here: >> >> https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg04476.html >> >> ... and could you install a newer version of bash via homebrew on your >> s

Re: [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com

2020-09-18 Thread Philippe Mathieu-Daudé
On 9/17/20 6:39 PM, Philippe Mathieu-Daudé wrote: > Armbian servers are not very reliable and confused the GitLab CI > users a few times this month (path updated, archives moved, and > now the SSL: CERTIFICATE_VERIFY_FAILED "certificate has expired" > error). Time to disable these tests. > Users ca

Re: [PATCH] configure: move cocoa option to Meson

2020-09-18 Thread Roman Bolshakov
On Wed, Sep 16, 2020 at 04:11:30AM -0400, Paolo Bonzini wrote: > While detection of the framework was already there, moving > the option allows for better error reporting. > > Reported-by: Christophe de Dinechin > Signed-off-by: Paolo Bonzini > --- > configure | 17 +++-- >

Re: [PATCH 16/37] qapi: establish mypy type-checking baseline

2020-09-18 Thread Markus Armbruster
Ignorant question: why does this come after PATCH 13 "qapi/common.py: add notational type hints", but before all the other patches adding type hints? John Snow writes: > Fix two very minor issues, and then establish a mypy type-checking > baseline. > > Like pylint, this should be run from the fo

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

2020-09-18 Thread Daniel Berrange
Nothing looks especially unusual there, but clear it is failing to link the block-curl.so as a library and is instead linking it as an executable and thus failing to find "main". I can't explain why that would be the case. -- You received this bug notification because you are a member of qemu- de

[PATCH] vhost-vdpa: don't check g_malloc() return value

2020-09-18 Thread Laurent Vivier
On failure, g_malloc() aborts the program, we don't need to check the return value Signed-off-by: Laurent Vivier --- hw/virtio/vhost-vdpa.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 4580f3efd8a2..23a4a957ef77 100644 --- a/hw/vi

Re: [PATCH] vhost-vdpa: don't check g_malloc() return value

2020-09-18 Thread Thomas Huth
On 18/09/2020 14.03, Laurent Vivier wrote: > On failure, g_malloc() aborts the program, we don't need to check the > return value > > Signed-off-by: Laurent Vivier > --- > hw/virtio/vhost-vdpa.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vho

[PATCH 2/2] microvm: add pcie support

2020-09-18 Thread Gerd Hoffmann
Uses the existing gpex device which is also used as pcie host bridge on arm/aarch64. For now only a 32bit mmio window and no ioport support. It is disabled by default, use "-machine microvm,pcie=on" to enable. ACPI support must be enabled too because the bus is declared in the DSDT table. Signed

[PATCH 0/2] microvm: add pcie support

2020-09-18 Thread Gerd Hoffmann
Gerd Hoffmann (2): microvm: add irq table microvm: add pcie support include/hw/i386/microvm.h | 30 +++ hw/i386/acpi-microvm.c| 163 ++ hw/i386/microvm.c | 71 + hw/i386/Kconfig | 1 + 4 files changed, 265 ins

[PATCH 1/2] microvm: add irq table

2020-09-18 Thread Gerd Hoffmann
Add a comment with a table listing the IRQs, both legacy pc and microvm side-by-side. Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h index be2d95af4d74..2

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

2020-09-18 Thread Laurent Vivier
>From log: > The Meson build system > Version: 0.55.3 Perhaps a(nother) problem with meson? Try "meson=git" -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896096 Title: Git version: Build process

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

2020-09-18 Thread Daniel Berrange
Added Paolo for his Meson expertize in case he can spot the flaw -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896096 Title: Git version: Build process is broken in block_curl.c.o Status in QEMU:

Re: [PATCH v2 00/13] block: deal with errp: part I

2020-09-18 Thread Vladimir Sementsov-Ogievskiy
17.09.2020 23:15, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200917195519.19589-1-vsement...@virtuozzo.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. The full log is available at http://patchew.org/logs/20200917195519.195

Re: [PATCH 2/2] microvm: add pcie support

2020-09-18 Thread Michael S. Tsirkin
On Fri, Sep 18, 2020 at 02:19:11PM +0200, Gerd Hoffmann wrote: > Uses the existing gpex device which is also used as pcie host bridge on > arm/aarch64. For now only a 32bit mmio window and no ioport support. > > It is disabled by default, use "-machine microvm,pcie=on" to enable. > ACPI support m

Re: [PATCH] docker.py: always use --rm

2020-09-18 Thread Peter Maydell
On Thu, 17 Sep 2020 at 11:45, Paolo Bonzini wrote: > > Avoid that containers pile up. > > Signed-off-by: Paolo Bonzini > --- > tests/docker/Makefile.include | 1 - > tests/docker/docker.py| 4 ++-- > 2 files changed, 2 insertions(+), 3 deletions(-) Applied to master, thanks. -- PMM

Re: [PATCH] vhost-vdpa: don't check g_malloc() return value

2020-09-18 Thread Li Qiang
Laurent Vivier 于2020年9月18日周五 下午8:04写道: > > On failure, g_malloc() aborts the program, we don't need to check the > return value > In fact, I have sent this one month agon. -->https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg0.html If you use this you can add my R-b tag: Reviewed-by:

Re: [PATCH] usb: fix u2f build

2020-09-18 Thread Daniel P . Berrangé
On Fri, Sep 18, 2020 at 12:03:12PM +0100, Daniel P. Berrangé wrote: > On Fri, Sep 18, 2020 at 01:01:22PM +0200, Gerd Hoffmann wrote: > > Just use qemu_open_old() for a quick fix, switch > > to better error handling left for another day. > > > > Fixes: 448058aa99aa ("util: rename qemu_open() to qem

Re: [PATCH 0/6] Update Travis from Xenial to Bionic and Focal

2020-09-18 Thread Paolo Bonzini
On 18/09/20 12:34, Thomas Huth wrote: > According to our support policy, we do not support Xenial anymore. > Time to switch the Travis jobs to Focal or Bionic instead now. > > Paolo Bonzini (2): > meson: move libudev test > meson: move libmpathpersist test Can you skip these since I'm going t

Re: [PATCH] virtio: vdpa: omit check return of g_malloc

2020-09-18 Thread Laurent Vivier
On 19/08/2020 16:43, Li Qiang wrote: > If g_malloc fails, the application will be terminated. > No need to check the return value of g_malloc. > > Signed-off-by: Li Qiang > --- > hw/virtio/vhost-vdpa.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/hw/virtio/vhos

Re: [PATCH 0/6] Update Travis from Xenial to Bionic and Focal

2020-09-18 Thread Thomas Huth
On 18/09/2020 14.51, Paolo Bonzini wrote: > On 18/09/20 12:34, Thomas Huth wrote: >> According to our support policy, we do not support Xenial anymore. >> Time to switch the Travis jobs to Focal or Bionic instead now. >> >> Paolo Bonzini (2): >> meson: move libudev test >> meson: move libmpathp

Re: [PATCH] configure: move malloc_trim/tcmalloc/jemalloc to meson

2020-09-18 Thread Yonggang Luo
On Wed, Sep 16, 2020 at 4:07 PM Paolo Bonzini wrote: > > Because LIBS is not used anymore, tcmalloc/jemalloc does > not work with binaries whose description is in Meson. > The fix is simply to move them to Meson too. > > For consistency with other configure options, specifying > --enable-malloc-tr

Re: How to convert fowlloing code from configure to meson.build

2020-09-18 Thread Paolo Bonzini
On 18/09/20 10:47, 罗勇刚(Yonggang Luo) wrote: > > seems that need compile a program, but I didn't found a demo You need "cc.compiles()" or "cc.links()". Paolo

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-18 Thread Paolo Bonzini
On 18/09/20 10:42, 罗勇刚(Yonggang Luo) wrote: > I also have a question that how about convert >   --disable-capstone) capstone="no" >   ;; >   --enable-capstone) capstone="yes" >   ;; > to  >     --disable-capstone) capstone="disabled" >   ;; >   --enable-capstone) capstone="enabled" >   ;; > > for

Re: [PATCH v2 2/2] virtio-iommu-pci: force virtio version 1

2020-09-18 Thread Cornelia Huck
On Fri, 18 Sep 2020 12:24:02 +0200 Auger Eric wrote: > Hi Connie, > > On 9/18/20 11:29 AM, Cornelia Huck wrote: > > On Tue, 8 Sep 2020 21:33:09 +0200 > > Eric Auger wrote: > > > >> Commit 9b3a35ec82 ("virtio: verify that legacy support is not > >> accidentally on") added a safety check that

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-18 Thread Yonggang Luo
On Fri, Sep 18, 2020 at 8:58 PM Paolo Bonzini wrote: > > On 18/09/20 10:42, 罗勇刚(Yonggang Luo) wrote: > > I also have a question that how about convert > > --disable-capstone) capstone="no" > > ;; > > --enable-capstone) capstone="yes" > > ;; > > to > > --disable-capstone) capstone="disa

[PATCH] meson: fix installation of keymaps

2020-09-18 Thread Anthony PERARD via
Signed-off-by: Anthony PERARD --- I don't know much about meson, but without "install:true" to the custom_target(), the keymaps files doen't get install when running `make install`. Only the files "sl" and "sv" are installed. So "install:true" seems necessary here. I've tried both with and witho

Re: [PATCH 00/37] qapi: static typing conversion, pt1

2020-09-18 Thread Philippe Mathieu-Daudé
Cc'ing Ben who offered to help with having the QEMU python scripts packaged (and this series is a step toward that). On 9/16/20 12:39 AM, John Snow wrote: > Hi, this series starts adding static type hints to the QAPI module. As > you can see, the series started getting quite a bit long, so this is

[PATCH] hw/arm/virt: use pflash image real size when mapping

2020-09-18 Thread 张海斌
Default size of arm-virt pflash image is 64MB which will cost extra 128MB(64MBx2) memory per qemu process and 12.5GB for 100 qemu processes. Host memory is precious and it is valuable to reduce pflash image size. For compatibility arm-virt uses real size when mapping. Signed-off-by: Haibin Zhang

[PATCH] hw/arm/virt: use pflash image real size when mapping

2020-09-18 Thread 张海斌
Default size of arm-virt pflash image is 64MB which will cost extra 128MB(64MBx2) memory per qemu process and 12.5GB for 100 qemu processes. Host memory is precious and it is valuable to reduce pflash image size. For compatibility arm-virt uses real size when mapping. Signed-off-by: Haibin Zhang

[PATCH] virtio-gpu-3d: fix abnormal display after a warm reboot

2020-09-18 Thread Guoqing Zhang
When resetting virtio-gpu, virgl_renderer_reset() should be called to ensure that the virglrenderer status is correct. Signed-off-by: Guoqing Zhang Reviewed-by: Qi Liu --- hw/display/virtio-gpu-3d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu-3d.c b/

Re: [PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes.

2020-09-18 Thread Ani Sinha
On Fri, Sep 18, 2020 at 3:26 PM Philippe Mathieu-Daudé wrote: > > On 9/18/20 10:40 AM, Ani Sinha wrote: > > Final patch series with all the patches reviewed or ack'd and marked as > > such. > > Thanks Julia and Igor for the reviews. Hope this series gets pulled in soon. > > FYI there is no need t

Heterogeneous/AMP example in mainline?

2020-09-18 Thread karthik poduval
Hi All, Was sifting through the heterogeneous QEMU effort in archives here https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg06256.html Did this effort make it to the mainline ? Are there any examples of AMP SoC's in the mainline ? -- Regards, Karthik Poduval

Re: [PATCH] virtio: vdpa: omit check return of g_malloc

2020-09-18 Thread Alex Bennée
Li Qiang writes: > Philippe Mathieu-Daudé 于2020年8月19日周三 下午11:07写道: >> >> On 8/19/20 4:43 PM, Li Qiang wrote: >> > If g_malloc fails, the application will be terminated. >> >> Which we don't want... better to use g_try_malloc() instead? > > I don't think so. If g_malloc return NULL it means a c

Re: [PATCH v2] hw/ide: check null block before _cancel_dma_sync

2020-09-18 Thread Li Qiang
P J P 于2020年9月18日周五 下午6:26写道: > > +-- On Fri, 18 Sep 2020, Li Qiang wrote --+ > | Update v2: use an assert() call > | ->https://lists.nongnu.org/archive/html/qemu-devel/2020-08/msg08336.html > ... > | I think it is better to defer this check to 'ide_cancel_dma_sync'. > | 'ide_cancel_dma_sync' is

Re: [PATCH] virtio: vdpa: omit check return of g_malloc

2020-09-18 Thread Alex Bennée
Li Qiang writes: > If g_malloc fails, the application will be terminated. > No need to check the return value of g_malloc. > > Signed-off-by: Li Qiang I think this is fine because a failure to config the dev would just cause an error_report later and it's extremely unlikely you don't have eno

Re: [PATCH] meson: fix installation of keymaps

2020-09-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200918130354.1879275-1-anthony.per...@citrix.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. The full lo

Re: [PATCH] virtio-gpu-3d: fix abnormal display after a warm reboot

2020-09-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200918111632.37354-1-zhangguoqing.ker...@bytedance.com/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at http://patchew.org/logs/2

Re: [EXTERNAL] [PATCH] hw/watchdog: Implement generic watchdog device model as per ARM BSAv0.9 hw/arm/sbsa-ref : Include SBSA watchdog device in sbsa-ref platform

2020-09-18 Thread Graeme Gregory
On Thu, Sep 17, 2020 at 05:51:33PM -0400, Shashi Mallela wrote: > Hi Graeme, > > In the generated patch file ,there is subject description (as below)before the > "Signed-off-by: " line.Not sure why it doesn't show up in the mail. > > Subject: [PATCH] hw/watchdog: Implement generic watchdog device

Re: [PATCH] configure: move malloc_trim/tcmalloc/jemalloc to meson

2020-09-18 Thread Paolo Bonzini
On 18/09/20 14:55, 罗勇刚(Yonggang Luo) wrote: > >>  if test "$tcmalloc" = "yes" && test "$jemalloc" = "yes" ; then >>      echo "ERROR: tcmalloc && jemalloc can't be used at the same time" >>      exit 1 >> -fi > This patch looks good for me, but I still have a small advice than move > thse judgemen

Deprecating --enable-gprof?

2020-09-18 Thread Marc-André Lureau
Hi configure has --enable-gprof since its creation, but is it actually being used, or is it sporadic enough that we could deprecate it? I have some reason to believe that it's not used much: - --enable-gprof only enables -p, which is prof (not gprof!) - nowadays there are better profiling tools,

[PATCH 1/3] gitlab: add a CI job for running checkpatch.pl

2020-09-18 Thread Daniel P . Berrangé
This job is advisory since it is expected that certain patches will fail the style checks and checkpatch.pl provides no way to mark exceptions to the rules. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/check-patch.py | 48 + .gitlab-ci.yml |

[PATCH 0/3] gitlab: add jobs for checking paches

2020-09-18 Thread Daniel P . Berrangé
This introduces two new jobs to GitLab. The first runs "checkpatch.pl" across all patches, while the second is a dedicated DCO signoff check. While checkpatch.pl does validate DCO signoff, it is sub-optimal as we need to allow the checkpatch.pl job to fail as there are always patches which intenti

[PATCH 2/3] gitlab: add a CI job to validate the DCO sign off

2020-09-18 Thread Daniel P . Berrangé
While checkpatch.pl can validate DCO sign off that job must always be advisory only since it is expected that certain patches will fail some code style rules. We require the DCO sign off to be mandatory for all commits though, so it benefits from being validated in a standalone job. Signed-off-by

[PATCH 3/3] gitlab: assign python helper files to GitLab maintainers section

2020-09-18 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3d17cad19a..b60981fb62 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3097,6 +3097,7 @@ R: Wainer dos Santos Moschetta S: Maintained F: .gitlab-ci.yml F: .gitl

configure with datadir outside of --prefix fails with meson

2020-09-18 Thread Anthony PERARD via
Hi, When we build QEMU while building Xen we do: ./configure --prefix=/usr/lib/xen \ --datadir=/usr/share/qemu-xen \ ... But meson give an error: ERROR: The value of the 'datadir' option is '/usr/share/qemu-xen' which must be a subdir of the prefix '/usr/lib

Re: Deprecating --enable-gprof?

2020-09-18 Thread Daniel P . Berrangé
On Fri, Sep 18, 2020 at 05:25:45PM +0400, Marc-André Lureau wrote: > Hi > > configure has --enable-gprof since its creation, but is it actually being > used, or is it sporadic enough that we could deprecate it? > > I have some reason to believe that it's not used much: > - --enable-gprof only ena

Re: [PATCH 0/3] gitlab: add jobs for checking paches

2020-09-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200918132903.1848939-1-berra...@redhat.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. The full log is available at http://patchew.org/logs/20200918132903.1848939-1-berra...@redhat.com/testing.FreeBSD/?type=me

Re: configure with datadir outside of --prefix fails with meson

2020-09-18 Thread Daniel P . Berrangé
On Fri, Sep 18, 2020 at 02:30:12PM +0100, Anthony PERARD via wrote: > Hi, > > When we build QEMU while building Xen we do: > ./configure --prefix=/usr/lib/xen \ > --datadir=/usr/share/qemu-xen \ > ... > > But meson give an error: > ERROR: The value of the 'da

Re: [PATCH] hw/arm/virt: use pflash image real size when mapping

2020-09-18 Thread Philippe Mathieu-Daudé
Cc'ing firmware experts. On 9/18/20 2:26 PM, haibinzhang(寮犳捣鏂�) wrote: > Default size of arm-virt pflash image is 64MB which > will cost extra 128MB(64MBx2) memory per qemu process > and 12.5GB for 100 qemu processes. Host memory is > precious and it is valuable to reduce pflash image size. > For

Re: [PATCH 1/3] gitlab: add a CI job for running checkpatch.pl

2020-09-18 Thread Philippe Mathieu-Daudé
On 9/18/20 3:29 PM, Daniel P. Berrangé wrote: > This job is advisory since it is expected that certain patches will fail > the style checks and checkpatch.pl provides no way to mark exceptions to > the rules. > > Signed-off-by: Daniel P. Berrangé > --- > .gitlab-ci.d/check-patch.py | 48

Re: [PATCH 3/3] gitlab: assign python helper files to GitLab maintainers section

2020-09-18 Thread Philippe Mathieu-Daudé
On 9/18/20 3:29 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 3d17cad19a..b60981fb62 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3097,6 +3097,7 @@ R: Wainer

Re: [PULL 32/36] tests/acceptance: console boot tests for quanta-gsj

2020-09-18 Thread Philippe Mathieu-Daudé
Hi Havard, On Mon, Sep 14, 2020 at 5:47 PM Peter Maydell wrote: > > From: Havard Skinnemoen > > This adds two acceptance tests for the quanta-gsj machine. > > One test downloads a lightly patched openbmc flash image from github and > verifies that it boots all the way to the login prompt. > > Th

Re: [PATCH 0/3] gitlab: add jobs for checking paches

2020-09-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200918132903.1848939-1-berra...@redhat.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. The full log is available at http://patchew.org/logs/20200918132903.1848939-1-berra...@redhat.com/testing.FreeBSD/?type=me

Re: [PULL 32/36] tests/acceptance: console boot tests for quanta-gsj

2020-09-18 Thread Philippe Mathieu-Daudé
On Fri, Sep 18, 2020 at 3:52 PM Philippe Mathieu-Daudé wrote: > > Hi Havard, > > On Mon, Sep 14, 2020 at 5:47 PM Peter Maydell > wrote: > > > > From: Havard Skinnemoen > > > > This adds two acceptance tests for the quanta-gsj machine. > > > > One test downloads a lightly patched openbmc flash i

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

2020-09-18 Thread Frederic Bezies
Tried meson-git, and it is still breaking on the same file. No luck here. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896096 Title: Git version: Build process is broken in block_curl.c.o Status

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

2020-09-18 Thread Fam Zheng
On 2020-09-18 19:23, Zhenyu Ye wrote: > Thread 5 (LWP 4802): > #0 0x83086b54 in syscall () at /lib64/libc.so.6 > #1 0x834598b8 in io_submit () at /lib64/libaio.so.1 > #2 0xe851e89c in ioq_submit (s=0xfffd3c001bb0) at > ../block/linux-aio.c:299 >

Re: [PULL 0/3] aspeed queue

2020-09-18 Thread Peter Maydell
> > are available in the Git repository at: > > https://github.com/legoater/qemu/ tags/pull-aspeed-20200918 > > for you to fetch changes up to 204dab83fe00a3e0781d93ad7899192a9409e987: > > misc: aspeed_scu: Update AST26

Re: [PATCH 0/3] gitlab: add jobs for checking paches

2020-09-18 Thread Thomas Huth
On 18/09/2020 15.29, Daniel P. Berrangé wrote: > This introduces two new jobs to GitLab. The first runs "checkpatch.pl" > across all patches, while the second is a dedicated DCO signoff check. This feels quite redundant since we're checking the patches with Patchew already ... or are there plans t

Re: [PATCH 0/3] gitlab: add jobs for checking paches

2020-09-18 Thread Philippe Mathieu-Daudé
On 9/18/20 4:07 PM, Thomas Huth wrote: > On 18/09/2020 15.29, Daniel P. Berrangé wrote: >> This introduces two new jobs to GitLab. The first runs "checkpatch.pl" >> across all patches, while the second is a dedicated DCO signoff check. > > This feels quite redundant since we're checking the patche

Re: [PATCH 0/3] gitlab: add jobs for checking paches

2020-09-18 Thread Daniel P . Berrangé
On Fri, Sep 18, 2020 at 04:07:22PM +0200, Thomas Huth wrote: > On 18/09/2020 15.29, Daniel P. Berrangé wrote: > > This introduces two new jobs to GitLab. The first runs "checkpatch.pl" > > across all patches, while the second is a dedicated DCO signoff check. > > This feels quite redundant since w

Re: [PATCH 0/3] gitlab: add jobs for checking paches

2020-09-18 Thread Yonggang Luo
On Fri, Sep 18, 2020 at 10:16 PM Daniel P. Berrangé wrote: > > On Fri, Sep 18, 2020 at 04:07:22PM +0200, Thomas Huth wrote: > > On 18/09/2020 15.29, Daniel P. Berrangé wrote: > > > This introduces two new jobs to GitLab. The first runs "checkpatch.pl" > > > across all patches, while the second is

Re: Deprecating --enable-gprof?

2020-09-18 Thread Peter Maydell
On Fri, 18 Sep 2020 at 14:27, Marc-André Lureau wrote: > > Hi > > configure has --enable-gprof since its creation, but is it actually being > used, or is it sporadic enough that we could deprecate it? This reminds me (because I can never keep gprof and gcov straight in my head :-)) that now the

Re: [PATCH] virtio-gpu-3d: fix abnormal display after a warm reboot

2020-09-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200918111632.37354-1-zhangguoqing.ker...@bytedance.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. The f

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

2020-09-18 Thread Daniel Berrange
Can you do the build using "make V=1" so that we actually see the compiler command lines used in the log file. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896096 Title: Git version: Build proce

[PATCH] tests/acceptance: Reduce quanta-gsj U-boot+Linux test time

2020-09-18 Thread Philippe Mathieu-Daudé
The 'arm_quanta_gsj_initrd' test is timeouting on GitLab CI: https://gitlab.com/philmd/qemu/-/jobs/745483978#L846 Use the same trick from the 'arm_quanta_gsj' test to reduce the systemd services started and get quicker to the shell prompt. Signed-off-by: Philippe Mathieu-Daudé --- tests/accepta

Re: Deprecating --enable-gprof?

2020-09-18 Thread Daniel P . Berrangé
On Fri, Sep 18, 2020 at 03:19:00PM +0100, Peter Maydell wrote: > On Fri, 18 Sep 2020 at 14:27, Marc-André Lureau > wrote: > > > > Hi > > > > configure has --enable-gprof since its creation, but is it actually being > > used, or is it sporadic enough that we could deprecate it? > > This reminds m

Re: [PATCH] tests/acceptance: Reduce quanta-gsj U-boot+Linux test time

2020-09-18 Thread Philippe Mathieu-Daudé
On 9/18/20 4:23 PM, Philippe Mathieu-Daudé wrote: > The 'arm_quanta_gsj_initrd' test is timeouting on GitLab CI: > https://gitlab.com/philmd/qemu/-/jobs/745483978#L846 > > Use the same trick from the 'arm_quanta_gsj' test to reduce the > systemd services started and get quicker to the shell prompt

Re: [PATCH 16/37] qapi: establish mypy type-checking baseline

2020-09-18 Thread John Snow
On 9/18/20 7:55 AM, Markus Armbruster wrote: Ignorant question: why does this come after PATCH 13 "qapi/common.py: add notational type hints", but before all the other patches adding type hints? John Snow writes: Fix two very minor issues, and then establish a mypy type-checking baseline. Li

Re: [PATCH] tests/acceptance: Reduce quanta-gsj U-boot+Linux test time

2020-09-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200918142344.150749-1-f4...@amsat.org/ Hi, This series failed build test on FreeBSD host. Please find the details below. The full log is available at http://patchew.org/logs/20200918142344.150749-1-f4...@amsat.org/testing.FreeBSD/?type=message. ---

Re: [PATCH 00/37] qapi: static typing conversion, pt1

2020-09-18 Thread John Snow
On 9/18/20 9:07 AM, Philippe Mathieu-Daudé wrote: Cc'ing Ben who offered to help with having the QEMU python scripts packaged (and this series is a step toward that). FWIW, I want to move ./python/qemu/ into ./python/qemu/core, and then move ./scripts/qapi to ./python/qemu/qapi. I will leav

[PATCH v2] tests/acceptance: Skip slow quanta-gsj U-boot+Linux test

2020-09-18 Thread Philippe Mathieu-Daudé
The 'arm_quanta_gsj_initrd' test is timeouting on GitLab CI: https://gitlab.com/philmd/qemu/-/jobs/745483978#L846 and also sometimes on my workstation, so proceed as with the other slow tests: do not run it by default. The test can still be run setting the AVOCADO_TIMEOUT_EXPECTED environment varia

Re: [PATCH v2] tests/acceptance: Skip slow quanta-gsj U-boot+Linux test

2020-09-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200918143355.153522-1-f4...@amsat.org/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at http://patchew.org/logs/20200918143355.1535

[PATCH] configure: fixes indent of $meson setup

2020-09-18 Thread Yonggang Luo
convert these line from tab to space Signed-off-by: Yonggang Luo --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 3757e48b17..6acd13a436 100755 --- a/configure +++ b/configure @@ -7850,10 +7850,10 @@ NINJA=${ninja:-$PWD/ninjato

[PATCH] configure: fixes indent of $meson setup

2020-09-18 Thread Yonggang Luo
convert these line from tab to space Signed-off-by: Yonggang Luo --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 3757e48b17..422b1ef2a3 100755 --- a/configure +++ b/configure @@ -7850,10 +7850,10 @@ NINJA=${ninja:-$PWD/ninjato

Re: [PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes.

2020-09-18 Thread Michael S. Tsirkin
On Fri, Sep 18, 2020 at 11:55:54AM +0200, Philippe Mathieu-Daudé wrote: > On 9/18/20 10:40 AM, Ani Sinha wrote: > > Final patch series with all the patches reviewed or ack'd and marked as > > such. > > Thanks Julia and Igor for the reviews. Hope this series gets pulled in soon. > > FYI there is

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

2020-09-18 Thread Frederic Bezies
Log with make V=1 as requested. ** Attachment added: "qemuv1.log" https://bugs.launchpad.net/qemu/+bug/1896096/+attachment/5412193/+files/qemuv1.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

<    1   2   3   4   5   6   >