[PULL 01/21] microvm: name qboot binary qboot.rom

qboot isn't a bios and shouldnt be named that way. Signed-off-by: Gerd Hoffmann Reviewed-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Message-id: 20200915120909.20838-2-kra...@redhat.com --- hw/i386/microvm.c | 4 ++-- pc-bios/meson.build |

[PULL 04/21] acpi: ged: add control regs

Add control regs (sleep, reset) for hw-reduced acpi. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Message-id: 20200915120909.20838-5-kra...@redhat.com --- include/hw/acpi/generic_event_device.h | 12 +++ hw/acpi/generic_event_device.c | 44 ++ 2 fi

[PULL 02/21] seabios: add microvm config, update build rules

Signed-off-by: Gerd Hoffmann Reviewed-by: Sergio Lopez Message-id: 20200915120909.20838-3-kra...@redhat.com --- roms/Makefile | 5 - roms/config.seabios-microvm | 26 ++ 2 files changed, 30 insertions(+), 1 deletion(-) create mode 100644 roms/config.se

[PULL 00/21] Microvm 20200917 patches

The following changes since commit 8ee612722dc08830761516e761dde934c3753a14: Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20200915' into staging (2020-09-16 14:47:50 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/microvm-202

[PULL 17/21] tests/acpi: allow microvm test data updates.

Also add empty test data files. Signed-off-by: Gerd Hoffmann Message-id: 20200915120909.20838-18-kra...@redhat.com --- tests/qtest/bios-tables-test-allowed-diff.h | 3 +++ tests/data/acpi/microvm/APIC| 0 tests/data/acpi/microvm/DSDT| 0 tests/data/acpi/microvm/FA

[PULL 07/21] microvm: make virtio irq base runtime configurable

Signed-off-by: Gerd Hoffmann Reviewed-by: Sergio Lopez Reviewed-by: Igor Mammedov Message-id: 20200915120909.20838-8-kra...@redhat.com --- include/hw/i386/microvm.h | 2 +- hw/i386/microvm.c | 11 +++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/include/hw/i38

[PULL 05/21] acpi: ged: add x86 device variant.

Set AcpiDeviceIfClass->madt_cpu, otherwise identical to TYPE_ACPI_GED. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Message-id: 20200915120909.20838-6-kra...@redhat.com --- include/hw/acpi/generic_event_device.h | 4 +++ hw/i386/generic_event_device_x86.c | 36 ++

[PULL 10/21] microvm/acpi: use GSI 16-23 for virtio

With ACPI enabled and IO-APIC being properly declared in the ACPI tables we can use interrupt lines 16-23 for virtio and avoid shared interrupts. With acpi disabled we continue to use lines 5-12. Signed-off-by: Gerd Hoffmann Reviewed-by: Sergio Lopez Reviewed-by: Igor Mammedov Message-id: 2020

[PULL 20/21] tests/acpi: update expected data files for microvm

Also clear tests/qtest/bios-tables-test-allowed-diff.h Signed-off-by: Gerd Hoffmann Message-id: 20200915120909.20838-21-kra...@redhat.com --- tests/qtest/bios-tables-test-allowed-diff.h | 3 --- tests/data/acpi/microvm/APIC| Bin 0 -> 70 bytes tests/data/acpi/microvm/DSDT

[PULL 03/21] seabios: add bios-microvm.bin binary

Signed-off-by: Gerd Hoffmann Reviewed-by: Sergio Lopez Message-id: 20200915120909.20838-4-kra...@redhat.com --- pc-bios/bios-microvm.bin | Bin 0 -> 131072 bytes pc-bios/meson.build | 1 + 2 files changed, 1 insertion(+) create mode 100644 pc-bios/bios-microvm.bin diff --git a/pc-bios/b

[PULL 12/21] microvm/acpi: disable virtio-mmio cmdline hack

... in case we are using ACPI. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Reviewed-by: Sergio Lopez Message-id: 20200915120909.20838-13-kra...@redhat.com --- hw/i386/microvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/i386/microvm.c b/hw/i386/microvm

[PULL 13/21] x86: constify x86_machine_is_*_enabled

Signed-off-by: Gerd Hoffmann Reviewed-by: Sergio Lopez Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-id: 20200915120909.20838-14-kra...@redhat.com --- include/hw/i386/x86.h | 4 ++-- hw/i386/x86.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[PULL 06/21] acpi: move acpi_dsdt_add_power_button() to ged

Allow reuse for microvm. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Message-id: 20200915120909.20838-7-kra...@redhat.com --- include/hw/acpi/generic_event_device.h | 1 + hw/acpi/generic_event_device.c | 8 hw/arm/virt-acpi-buil

[PULL 19/21] tests/acpi: add microvm test

Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Message-id: 20200915120909.20838-20-kra...@redhat.com --- tests/qtest/bios-tables-test.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 1779af1cc889

[PULL 14/21] x86: move acpi_dev from pc/microvm

Both pc and microvm machine types have a acpi_dev field. Move it to the common base type. Signed-off-by: Gerd Hoffmann Reviewed-by: Sergio Lopez Reviewed-by: Igor Mammedov Message-id: 20200915120909.20838-15-kra...@redhat.com --- include/hw/i386/microvm.h | 1 - include/hw/i386/pc.h | 1

[PULL 21/21] microvm: enable ramfb

Signed-off-by: Gerd Hoffmann Message-id: 20200915120909.20838-22-kra...@redhat.com --- hw/i386/microvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index 8de8ca864963..60d32722301f 100644 --- a/hw/i386/microvm.c +++ b/hw/i386/microvm.c @@ -39,6 +3

[PULL 16/21] microvm: wire up hotplug

The cpu hotplug code handles the initialization of coldplugged cpus too, so it is needed even in case cpu hotplug is not supported. Wire cpu hotplug up for microvm. Without this we get a broken MADT table. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Reviewed-by: Sergio Lopez Messag

[PULL 15/21] x86: move cpu hotplug from pc to x86

The cpu hotplug code handles the initialization of coldplugged cpus too, so it is needed even in case cpu hotplug is not supported. Move the code from pc to x86, so microvm can use it. Move both plug and unplug to keep everything in one place, even though microvm needs plug only. Signed-off-by:

Re: [RFC PATCH 04/12] device_tree: add qemu_fdt_add_path

On 9/17/2020 4:12 PM, Andrew Jones wrote: On Thu, Sep 17, 2020 at 11:20:25AM +0800, Ying Fang wrote: From: Andrew Jones qemu_fdt_add_path works like qemu_fdt_add_subnode, except it also recursively adds any missing parent nodes. Cc: Peter Crosthwaite Cc: Alexander Graf Signed-off-by: And

[PULL 18/21] tests/acpi: allow override blkdev

microvm needs virtio-blk instead of ide. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Reviewed-by: Sergio Lopez Message-id: 20200915120909.20838-19-kra...@redhat.com --- tests/qtest/bios-tables-test.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/qt

[PULL 11/21] microvm/acpi: use seabios with acpi=on

With acpi=off continue to use qboot. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Reviewed-by: Sergio Lopez Message-id: 20200915120909.20838-12-kra...@redhat.com --- hw/i386/microvm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/i386/microvm.c b/hw/i386

Re: [PATCH 2/3] block: add logging facility for long standing IO requests

On 10.08.20 12:14, Denis V. Lunev wrote: > There are severe delays with IO requests processing if QEMU is running in > virtual machine or over software defined storage. Such delays potentially > results in unpredictable guest behavior. For example, guests over IDE or > SATA drive could remount file

Re: [RFC PATCH 06/12] hw/arm/virt-acpi-build: distinguish possible and present cpus

On 9/17/2020 4:20 PM, Andrew Jones wrote: On Thu, Sep 17, 2020 at 11:20:27AM +0800, Ying Fang wrote: When building ACPI tables regarding CPUs we should always build them for the number of possible CPUs, not the number of present CPUs. We then ensure only the present CPUs are enabled. Signed-

Re: Use patchew to push successfully applied series to GitLab

On Thu, Sep 17, 2020 at 5:36 PM Daniel P. Berrangé wrote: > > On Thu, Sep 17, 2020 at 10:53:14AM +0200, Paolo Bonzini wrote: > > On 17/09/20 10:16, Philippe Mathieu-Daudé wrote: > > > patchew is currently pushing successfully applied series > > > (using the cover Message-ID as tag) to GitHub. > >

[PULL 09/21] microvm/acpi: add acpi_dsdt_add_virtio() for x86

Makes x86 linux kernel find virtio-mmio devices automatically. Signed-off-by: Gerd Hoffmann Reviewed-by: Sergio Lopez Reviewed-by: Igor Mammedov Message-id: 20200915120909.20838-10-kra...@redhat.com --- hw/i386/acpi-microvm.c | 52 ++ 1 file changed, 52

Re: [PATCH 04/14] blockdev: fix drive_backup_prepare() missed error

On Wed 09 Sep 2020 08:59:20 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > We leak local_err and don't report failure to the caller. It's > definitely wrong, let's fix. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

Re: [PATCH 02/14] block: use return status of bdrv_append()

On Wed 09 Sep 2020 08:59:18 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > Now bdrv_append returns status and we can drop all the local_err things > around it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

[PULL 08/21] microvm/acpi: add minimal acpi support

$subject says all. Can be controlled using -M microvm,acpi=on/off. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Message-id: 20200915120909.20838-9-kra...@redhat.com --- hw/i386/acpi-microvm.h| 8 ++ include/hw/i386/microvm.h | 9 ++ hw/i386/acpi-microvm.c| 187 ++

Re: [PATCH v7 11/12] tests/acpi: unit test exercising global pci hotplug off for i440fx

On Thu, 17 Sep 2020 15:39:46 +0530 Ani Sinha wrote: > This change adds a unit test to exercise the case when hotplug is disabled > both for pci root bus and the pci bridges by passing the following two > switches to qemu: > > -global PIIX4_PM.acpi-root-pci-hotplug=off > -global PIIX4_PM.acpi

Re: [PATCH 05/14] block: drop extra error propagation for bdrv_set_backing_hd

On Wed 09 Sep 2020 08:59:21 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > bdrv_set_backing_hd now returns status, let's use it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

Re: [RFC PATCH 09/12] target/arm/cpu: Add CPU cache description for arm

On 9/17/2020 4:39 PM, Andrew Jones wrote: On Thu, Sep 17, 2020 at 11:20:30AM +0800, Ying Fang wrote: Add the CPUCacheInfo structure to hold CPU cache information for ARM cpus. A classic three level cache topology is used here. The default cache capacity is given and userspace can overwrite th

Re: [PATCH 1/3] block/block-backend: add converter from BlockAcctStats to BlockBackend

On 10.08.20 12:14, Denis V. Lunev wrote: > Right now BlockAcctStats is always reside on BlockBackend. This structure > is not used in any other place. Thus we are able to create a converter > from one pointer to another. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Vladimir Sementsov-Ogievski

Re: [PATCH 08/14] blockjob: return status from block_job_set_speed()

On Wed 09 Sep 2020 08:59:24 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > Better to return status together with setting errp. It allows to avoid > error propagation in the caller. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

Re: [RFC PATCH 07/12] hw/acpi/aml-build: add processor hierarchy node structure

On 9/17/2020 4:27 PM, Andrew Jones wrote: On Thu, Sep 17, 2020 at 11:20:28AM +0800, Ying Fang wrote: Add the processor hierarchy node structures to build ACPI information for CPU topology. Three helpers are introduced: (1) build_socket_hierarchy for socket description structure (2) build_pro

Re: [PATCH 3/3] block: enable long IO requests report by default

On 10.08.20 12:14, Denis V. Lunev wrote: > Latency threshold is set to 10 seconds following guest request timeout > on legacy storage controller. > > Signed-off-by: Denis V. Lunev > CC: Vladimir Sementsov-Ogievskiy > CC: Stefan Hajnoczi > CC: Kevin Wolf > CC: Max Reitz > --- > blockdev.c | 7

Re: [RFC PATCH 02/12] target/arm/kvm64: make MPIDR consistent with CPU Topology

On Thu, Sep 17, 2020 at 09:19:34PM +0800, Ying Fang wrote: > > > On 9/17/2020 6:59 PM, Andrew Jones wrote: > > On Thu, Sep 17, 2020 at 09:53:35AM +0200, Andrew Jones wrote: > > > On Thu, Sep 17, 2020 at 11:20:23AM +0800, Ying Fang wrote: > > > > MPIDR helps to provide an additional PE identificat

Re: [PATCH 11/37] qapi/common.py: Replace one-letter 'c' variable

John Snow writes: > Signed-off-by: John Snow > --- > scripts/qapi/common.py | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py > index c665e67495..4c079755d3 100644 > --- a/scripts/qapi/common.py > +++ b/scripts/qapi/

[PATCH v4 3/5] vfio: Find DMA available capability

The underlying host may be limiting the number of outstanding DMA requests for type 1 IOMMU. Add helper functions to check for the DMA available capability and retrieve the current number of DMA mappings allowed. Signed-off-by: Matthew Rosato Reviewed-by: Cornelia Huck --- hw/vfio/common.c

Re: QEMU policy for real file tests

On Donnerstag, 17. September 2020 14:40:42 CEST Peter Maydell wrote: > (Ideally we'd put in some more consistent framework for temp files > used by tests to put them all in a single subdir or something, for > convenience in cleaning up afterwards.) Yes, a unified interface for creating and auto wi

[PATCH] meson: fix static flag summary

'static build:' must display value of CONFIG_STATIC rather than value of CONFIG_TOOLS. Signed-off-by: Laurent Vivier --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5421eca66a02..c174f0ab0948 100644 --- a/meson.build +++ b/meson

[PATCH v4 2/5] vfio: Create shared routine for scanning info capabilities

Rather than duplicating the same loop in multiple locations, create a static function to do the work. Signed-off-by: Matthew Rosato Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cornelia Huck --- hw/vfio/common.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-)

Re: [PATCH v7 09/12] piix4: don't reserve hw resources when hotplug is off globally

On Thu, 17 Sep 2020 15:39:44 +0530 Ani Sinha wrote: > When acpi hotplug is turned off for both root pci bus as well as for pci > bridges, we should not generate the related ACPI code for DSDT table or > initialize related hw ports or reserve hw resources. This change makes > sure all those operat

Re: [PATCH 01/14] block: return status from bdrv_append and friends

On Wed 09 Sep 2020 08:59:17 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > The recommended use of qemu error api assumes returning status together > with setting errp and avoid void functions with errp parameter. Let's > improve bdrv_append and some friends to reduce error-propagation > overhead in

Re: Python 3.5 EOL; when can require 3.6?

On 16/09/2020 16.00, Thomas Huth wrote: > On 16/09/2020 14.30, Peter Maydell wrote: >> On Wed, 16 Sep 2020 at 08:43, Markus Armbruster wrote: >>> We require Python 3.5. It will reach its "end of life" at the end of >>> September 2020[*]. Any reason not to require 3.6 for 5.2? qemu-iotests >>> a

Re: riscv32 wait() problem, qemu or glibc?

On Thu, Sep 17, 2020 at 3:16 AM Andreas K. Hüttel wrote: > > Am Donnerstag, 17. September 2020, 00:05:10 EEST schrieb Alistair Francis: > > On Wed, Sep 16, 2020 at 2:09 PM Andreas K. Hüttel > wrote: > > > > My guess is that somewhere in QEMU the types don't match what RV32 is > > > > using. It's

Re: [PATCH 13/37] qapi/common.py: add notational type hints

Question on the subject line: what makes a type hint notational? John Snow writes: > Signed-off-by: John Snow > --- > scripts/qapi/common.py | 27 --- > 1 file changed, 16 insertions(+), 11 deletions(-) > > diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py >

Re: [PATCH 10/37] qapi/common.py: delint with pylint

John Snow writes: > Signed-off-by: John Snow > --- > scripts/qapi/common.py | 16 +++- > scripts/qapi/schema.py | 14 +++--- > 2 files changed, 14 insertions(+), 16 deletions(-) > > diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py > index 87d87b95e5..c665e67495 1

[PATCH v4 4/5] s390x/pci: Add routine to get the vfio dma available count

Create new files for separating out vfio-specific work for s390 pci. Add the first such routine, which issues VFIO_IOMMU_GET_INFO ioctl to collect the current dma available count. Signed-off-by: Matthew Rosato --- hw/s390x/meson.build | 1 + hw/s390x/s390-pci-vfio.c | 54 +++

[PATCH v4 0/5] s390x/pci: Accomodate vfio DMA limiting

Kernel commit 492855939bdb added a limit to the number of outstanding DMA requests for a type1 vfio container. However, lazy unmapping in s390 can in fact cause quite a large number of outstanding DMA requests to build up prior to being purged, potentially the entire guest DMA space. This result

[PATCH v4 5/5] s390x/pci: Honor DMA limits set by vfio

When an s390 guest is using lazy unmapping, it can result in a very large number of oustanding DMA requests, far beyond the default limit configured for vfio. Let's track DMA usage similar to vfio in the host, and trigger the guest to flush their DMA mappings before vfio runs out. Signed-off-by:

Re: [PATCH] meson: fix static flag summary

Oops. :) Paolo Il gio 17 set 2020, 16:07 Laurent Vivier ha scritto: > 'static build:' must display value of CONFIG_STATIC rather than value of > CONFIG_TOOLS. > > Signed-off-by: Laurent Vivier > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.b

[PATCH v4 1/5] linux-headers: update against 5.9-rc5

PLACEHOLDER as the kernel patch driving the need for this ("vfio iommu: Add dma available capability") is not merged yet. Signed-off-by: Matthew Rosato --- include/standard-headers/drm/drm_fourcc.h | 140 + include/standard-headers/linux/ethtool.h | 87 +++

Re: [PATCH] target/i386: always create kvmclock device

* Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: > Antoine Damhet writes: > > > On Thu, Sep 17, 2020 at 01:13:06PM +0200, Vitaly Kuznetsov wrote: > >> QEMU's kvmclock device is only created when KVM PV feature bits for > >> kvmclock (KVM_FEATURE_CLOCKSOURCE/KVM_FEATURE_CLOCKSOURCE2) are > >> expos

Re: [PATCH 15/37] qapi/common.py: split build_params into new file

John Snow writes: > Including it in common.py creates a circular import dependency, because > schema relies on common.py. To type build_params properly, it needs to > be moved outside of the chain. > > Signed-off-by: John Snow > --- > scripts/qapi/commands.py | 2 +- > scripts/qapi/common.py

Re: [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements

On Thu, Sep 17, 2020 at 9:46 PM Peter Maydell wrote: > > On Wed, 16 Sep 2020 at 12:47, Thomas Huth wrote: > > > > Hi Peter, > > > > the following changes since commit de39a045bd8d2b49e4f3d07976622c29d58e0bac: > > > > Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200915-pull-request'

Re: [PATCH v4 0/5] s390x/pci: Accomodate vfio DMA limiting

Patchew URL: https://patchew.org/QEMU/1600352445-21110-1-git-send-email-mjros...@linux.ibm.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. The f

Re: [PATCH 14/37] qapi/common.py: Move comments into docstrings

John Snow writes: > As docstrings, they'll show up in documentation and IDE help. > > Signed-off-by: John Snow > --- > scripts/qapi/common.py | 50 ++ > 1 file changed, 36 insertions(+), 14 deletions(-) > > diff --git a/scripts/qapi/common.py b/scripts/qa

Re: [PATCH] meson: fix static flag summary

On 9/17/20 4:07 PM, Laurent Vivier wrote: > 'static build:' must display value of CONFIG_STATIC rather than value of > CONFIG_TOOLS. > > Signed-off-by: Laurent Vivier > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 5

Re: [PATCH v2 9/9] aspeed/smc: Add support for RDSFDP command

Hi Cedric, On [2020 Sep 02] Wed 11:31:07, Cédric Le Goater wrote: > Modify the snooping routine to handle RDSFDP, 1 dummy and 3 bytes > address space. > > Signed-off-by: Cédric Le Goater > --- > include/hw/ssi/aspeed_smc.h | 1 + > hw/ssi/aspeed_smc.c | 21 ++--- > 2 fi

Re: [PATCH v2 07/10] disas: Configure capstone for aarch64 host without libvixl

On 15/09/2020 01.02, Richard Henderson wrote: > The ifdef tangle failed to set cap_arch if libvixl itself > was not configured (e.g. due to lack of c++ compiler). > > Signed-off-by: Richard Henderson > --- > disas.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/

Re: [PATCH 03/14] block: check return value of bdrv_open_child and drop error propagation

On Wed 09 Sep 2020 08:59:19 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > This patch is generated by cocci script: > > @@ > symbol bdrv_open_child, errp, local_err; > expression file; > @@ > > file = bdrv_open_child(..., > -&local_err > +errp >

Re: [PATCH 06/14] block/mirror: drop extra error propagation in commit_active_start()

On Wed 09 Sep 2020 08:59:22 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > Let's check return value of mirror_start_job to check for failure > instead of local_err. > > Rename ret to job, as ret is usually integer variable. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garc

Re: [PATCH v2 04/10] disas: Clean up CPUDebug initialization

On 15/09/2020 01.02, Richard Henderson wrote: > Rename several functions, dropping "generic" and making "host" > vs "target" clearer. Make a bunch of functions static that are > not used outside this file. Replace INIT_DISASSEMBLE_INFO with > a trio of functions. > > Signed-off-by: Richard Hender

Re: [PATCH v2 8/9] arm/aspeed: Replace mx25l25635e chip model

On [2020 Sep 02] Wed 11:31:06, Cédric Le Goater wrote: > A mx25l25635f chip model is generally found on these machines. It's > newer and uses 4B opcodes which is better to exercise the support in > the Linux kernel. > > Signed-off-by: Cédric Le Goater Reviewed-by: Francisco Iglesias > --- > h

Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

On Wed 09 Sep 2020 08:59:27 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > It's better to return status together with setting errp. It makes > possible to avoid error propagation. > > Signed-off-by: Vladimir Sementsov-Ogievskiy [...] > -void qcow2_store_persistent_dirty_bitmaps(BlockDriverState

Re: Python 3.5 EOL; when can require 3.6?

On Wed, Sep 16, 2020 at 02:57:37PM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 16, 2020 at 02:53:55PM +0100, Alex Bennée wrote: > > > > Thomas Huth writes: > > > > > On 16/09/2020 09.53, Philippe Mathieu-Daudé wrote: > > >> On 9/16/20 9:43 AM, Markus Armbruster wrote: > > >>> We require Pytho

Re: [PATCH 12/14] block/qcow2: read_cache_sizes: return status value

On Wed 09 Sep 2020 08:59:28 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > It's better to return status together with setting errp. It allows to > reduce error propagation. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

[PATCH v8 01/12] tests/acpi: mark addition of table DSDT.roothp for unit testing root pci hotplug

A new binary acpi table tests/data/acpi/pc/DSDT.roothp is added in order to unit test the feature flag that can disable/enable root pci bus hotplug on i440fx. This feature was added with the commit: 3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") This chan

Re: [PATCH v2 04/10] disas: Clean up CPUDebug initialization

On 15/09/2020 01.02, Richard Henderson wrote: > Rename several functions, dropping "generic" and making "host" > vs "target" clearer. Make a bunch of functions static that are > not used outside this file. Replace INIT_DISASSEMBLE_INFO with > a trio of functions. > > Signed-off-by: Richard Hender

Re: [PATCH] target/i386: always create kvmclock device

"Dr. David Alan Gilbert" writes: > * Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: >> Antoine Damhet writes: >> >> > On Thu, Sep 17, 2020 at 01:13:06PM +0200, Vitaly Kuznetsov wrote: >> >> QEMU's kvmclock device is only created when KVM PV feature bits for >> >> kvmclock (KVM_FEATURE_CLOCKSOURC

Re: Python 3.5 EOL; when can require 3.6?

On Thu, Sep 17, 2020 at 04:10:55PM +0200, Thomas Huth wrote: > On 16/09/2020 16.00, Thomas Huth wrote: > > On 16/09/2020 14.30, Peter Maydell wrote: > >> On Wed, 16 Sep 2020 at 08:43, Markus Armbruster wrote: > >>> We require Python 3.5. It will reach its "end of life" at the end of > >>> Septemb

[PATCH v8 02/12] tests/acpi: add new unit test to test hotplug off/on feature on the root pci bus

Ability to turn hotplug off on the pci root bus for i440fx was added in commit: 3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") This change adds a unit test in order to test this feature. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov --- tests/qt

[PATCH v8 03/12] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off

A new binary ACPI table tests/data/acpi/pc/DSDT.roothp is added in order to unit test hotplug on/off capability on the root pci bus for i440fx. The diff between the table DSDT.bridge and DSDT.roothp is listed below: @@ -1,30 +1,30 @@ /* * Intel ACPI Component Architecture * AML/ASL+ Disassemb

Re: [PATCH v2 2/3] virtio-blk: undo destructive iov_discard_*() operations

Stefan Hajnoczi 于2020年9月17日周四 下午5:47写道： > > Fuzzing discovered that virtqueue_unmap_sg() is being called on modified > req->in/out_sg iovecs. This means dma_memory_map() and > dma_memory_unmap() calls do not have matching memory addresses. > > Fuzzing discovered that non-RAM addresses trigger a bu

[PATCH v8 04/12] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus

When ACPI hotplug for the root bus is disabled, the bsel property for that bus is not set. Please see the following commit: 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus"). As a result, when acpi_pcihp_find_hotplug_bus() is called with bsel set to 0, it ma

Re: [PATCH] target/i386: always create kvmclock device

On Thu, Sep 17, 2020 at 03:42:37PM +0100, Dr. David Alan Gilbert wrote: [...] > > > > > > Shouldn't the old check used when machine type <= 5.1 in order to avoid > > > migration incompatibility ? > > > > Hm, when the check fails we just don't create the device and no error is > > reported, so ev

[PATCH v8 08/12] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag

This patch adds a binary blob corresponding to the DSDT acpi table. It is used to unit test the flag 'acpi-pci-hotplug-with-bridge-support' used with pci bridges. This change also clears the file tests/qtest/bios-tables-test-allowed-diff.h so that future changes which affect the table can be caugh

[PATCH v8 07/12] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag

This change adds a new unit test for the global flag 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci bridges in i440fx. The flag can be used to turn off ACPI based hotplug support on all pci bridges. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov --- tests/qt

[PATCH v8 05/12] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

Cold plugged bridges are not hot unpluggable, even when their hotplug property (acpi-pci-hotplug-with-bridge-support) is turned off. Please see the function acpi_pcihp_pc_no_hotplug(). However, with the current implementaton, Windows would try to hot-unplug a pci bridge when it's hotplug switch is

[PATCH v8 00/12] i440fx/acpi: addition of feature and bug fixes.

In v8, I have updated the commit log for patch #9 mentioning the tables that are being updated with patch #10. Ani Sinha (12): tests/acpi: mark addition of table DSDT.roothp for unit testing root pci hotplug tests/acpi: add new unit test to test hotplug off/on feature on the root pci

[PATCH v8 11/12] tests/acpi: unit test exercising global pci hotplug off for i440fx

This change adds a unit test to exercise the case when hotplug is disabled both for pci root bus and the pci bridges by passing the following two switches to qemu: -global PIIX4_PM.acpi-root-pci-hotplug=off -global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off bios-tables-test-allowed-dif

Re: [PATCH v4 0/5] s390x/pci: Accomodate vfio DMA limiting

On 9/17/20 10:46 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/1600352445-21110-1-git-send-email-mjros...@linux.ibm.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed,

[PATCH v8 06/12] tests/acpi: list added acpi table binary file for pci bridge hotplug test

The file 'tests/data/acpi/pc/DSDT.hpbridge' is a newly added acpi table file for testing the pci bridge option 'acpi-pci-hotplug-with-bridge-support' under i440fx. This change documents this fact. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.

[PATCH v8 09/12] piix4: don't reserve hw resources when hotplug is off globally

When acpi hotplug is turned off for both root pci bus as well as for pci bridges, we should not generate the related ACPI code for DSDT table or initialize related hw ports or reserve hw resources. This change makes sure all those operations are turned off in the case ACPI pci hotplug is off global

Re: [PATCH 3/3] block/nvme: Align NVMeRegs structure to 4KiB and mark it packed

On Wed, Sep 16, 2020 at 10:40:04PM +0200, Philippe Mathieu-Daudé wrote: > In commit e5ff22ba9fc we changed the doorbells register > declaration but forgot to mark the structure packed (as > MMIO registers), allowing the compiler to optimize it. Does this patch actually change anything? NvmeBar is

Re: [PATCH 2/3] block/nvme: Use atomic operations instead of 'volatile' keyword

On Wed, Sep 16, 2020 at 10:40:03PM +0200, Philippe Mathieu-Daudé wrote: I think the current use of volatile is fine. It's widely used in device drivers (see Linux and DPDK) so I'm not sure eliminating it is worthwhile. > Follow docs/devel/atomics.rst guidelines and use atomic operations. > > Cc:

[PATCH v8 10/12] tests/acpi: update golden master DSDT binary table blobs for q35

In the change d7f82561fe ("piix4: don't reserve hw resources when hotplug is off globally"), we make changes to the ACPI DSDT tables such that some ACPI code are not generated when bsel is absent. Since as of this point in time, in q35 machines, we do not use bsel for pci buses, we need to update t

Re: [PATCH v2 2/9] m25p80: Add the n25q256a SFDP table

Hi Cedric, On [2020 Sep 02] Wed 11:31:00, Cédric Le Goater wrote: > The same values were collected on 4 differents OpenPower systems, > palmettos, romulus and tacoma. > > The SFDP table size is defined as being 0x100 bytes but it could be > bigger. Only the mandatory table for basic features is a

Re: [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements

On Wed, 16 Sep 2020 at 12:47, Thomas Huth wrote: > > * Fix "readlink -f" problem in iotests on macOS (to fix the Cirrus-CI tests) > * Some minor qtest improvements > * Fix the unit tests to work on MSYS2, too > * Enable building and

Re: Python 3.5 EOL; when can require 3.6?

On 17/09/2020 16.55, Daniel P. Berrangé wrote: > On Thu, Sep 17, 2020 at 04:10:55PM +0200, Thomas Huth wrote: >> On 16/09/2020 16.00, Thomas Huth wrote: >>> On 16/09/2020 14.30, Peter Maydell wrote: On Wed, 16 Sep 2020 at 08:43, Markus Armbruster wrote: > We require Python 3.5. It will r

[PATCH v8 12/12] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

This change adds a new DSDT golden master table blob to test disabling hotplug on both pci root bus and pci bridges. Also reverts the change in file bios-tables-test-allowed-diff.h to make sure its now empty so that future modifications to acpi tables can be caught. The following is the disassembl

Re: [PATCH 2/3] block: add logging facility for long standing IO requests

On 9/17/20 4:56 PM, Max Reitz wrote: > On 10.08.20 12:14, Denis V. Lunev wrote: >> There are severe delays with IO requests processing if QEMU is running in >> virtual machine or over software defined storage. Such delays potentially >> results in unpredictable guest behavior. For example, guests o

Re: [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements

On 17/09/2020 16.40, 罗勇刚(Yonggang Luo) wrote: > > > On Thu, Sep 17, 2020 at 9:46 PM Peter Maydell > wrote: >> >> On Wed, 16 Sep 2020 at 12:47, Thomas Huth > wrote: >> > >> >  Hi Peter, >> > >> > the following changes since commit > de39a

Re: [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements

On Thu, 17 Sep 2020 at 16:29, Thomas Huth wrote: > Ok, sounds like I should respin my patch here: > > https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg04476.html > > ... and could you install a newer version of bash via homebrew on your > system? I could in theory, but I don't really want

Re: Python 3.5 EOL; when can require 3.6?

Thomas Huth writes: > On 16/09/2020 16.00, Thomas Huth wrote: >> On 16/09/2020 14.30, Peter Maydell wrote: >>> On Wed, 16 Sep 2020 at 08:43, Markus Armbruster wrote: We require Python 3.5. It will reach its "end of life" at the end of September 2020[*]. Any reason not to require 3.6

Re: [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements

On 17/09/2020 17.14, Peter Maydell wrote: > On Wed, 16 Sep 2020 at 12:47, Thomas Huth wrote: >> >> * Fix "readlink -f" problem in iotests on macOS (to fix the Cirrus-CI tests) >> * Some minor qtest improvements >> * Fix the unit test

Re: [PATCH v1] s390x/tcg: Implement MONITOR CALL

On 9/17/20 4:54 AM, David Hildenbrand wrote: > Recent upstream Linux uses the MONITOR CALL instruction for things like > BUG_ON() and WARN_ON(). We currently inject an operation exception when > we hit a MONITOR CALL instruction - which is wrong, as the instruction > is not glued to specific CPU fe

Re: [PATCH v3 5/5] sev/i386: Enable an SEV-ES guest based on SEV policy

* Tom Lendacky (thomas.lenda...@amd.com) wrote: > From: Tom Lendacky > > Update the sev_es_enabled() function return value to be based on the SEV > policy that has been specified. SEV-ES is enabled if SEV is enabled and > the SEV-ES policy bit is set in the policy object. > > Signed-off-by: Tom

Re: [PATCH v8 00/12] i440fx/acpi: addition of feature and bug fixes.

Patchew URL: https://patchew.org/QEMU/20200917150044.23159-1-...@anisinha.ca/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. The full log is available

Re: Python 3.5 EOL; when can require 3.6?

On Thu, Sep 17, 2020 at 05:24:15PM +0200, Thomas Huth wrote: > On 17/09/2020 16.55, Daniel P. Berrangé wrote: > > On Thu, Sep 17, 2020 at 04:10:55PM +0200, Thomas Huth wrote: > >> On 16/09/2020 16.00, Thomas Huth wrote: > >>> On 16/09/2020 14.30, Peter Maydell wrote: > On Wed, 16 Sep 2020 at 0

<    1   2   3   4   5   >