Re: [PATCH 0/3] qom: Replace INTERFACE_CHECK with OBJECT_CHECK

Eduardo Habkost writes: > This series replaces INTERFACE_CHECK with OBJECT_CHECK because > both macros are exactly the same. See also issue#2 in Subject: Issues around TYPE_INTERFACE Date: Tue, 12 Mar 2019 11:50:54 +0100 Message-ID: <87h8c82woh@dusky.pond.sub.org> https://li

Re: [PATCH v5 09/11] piix4: don't reserve hw resources when hotplug is off globally

On Thu, 17 Sep 2020 12:09:46 +0530 Ani Sinha wrote: > On Thu, Sep 17, 2020 at 11:46 AM Igor Mammedov wrote: > > > > On Wed, 16 Sep 2020 13:49:08 +0530 > > Ani Sinha wrote: > > > > > When acpi hotplug is turned off for both root pci bus as well as for pci > > > bridges, we should not generate

Re: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros

On Wed, 16 Sep 2020 14:25:17 -0400 Eduardo Habkost wrote: > One of the goals of having less boilerplate on QOM declarations > is to avoid human error. Requiring an extra argument that is > never used is an opportunity for mistakes. > > Remove the unused argument from OBJECT_DECLARE_TYPE and > O

Re: [PATCH 07/14] block/blklogwrites: drop error propagation

Ari Sundholm writes: > Hi, > > On 9/11/20 11:03 AM, Markus Armbruster wrote: >> Ari Sundholm writes: >> >>> Hi Vladimir! >>> >>> Thank you for working on this. My comments below. >>> >>> On 9/9/20 9:59 PM, Vladimir Sementsov-Ogievskiy wrote: It's simple to avoid error propagation in blk_lo

Re: [PATCH] migration: Silence compiler warning in global_state_store_running()

On 17/09/20 08:30, Thomas Huth wrote: > On 16/09/2020 19.19, Thomas Huth wrote: >> GCC 9.3.0 on Ubuntu complains: >> >> In file included from /usr/include/string.h:495, >> from /home/travis/build/huth/qemu/include/qemu/osdep.h:87, >> from ../migration/global_state.

Re: [PATCH 0/3] qom: Replace INTERFACE_CHECK with OBJECT_CHECK

On 9/16/20 11:31 PM, Marc-André Lureau wrote: > Hi > > On Wed, Sep 16, 2020 at 11:35 PM Eduardo Habkost > wrote: > > This series replaces INTERFACE_CHECK with OBJECT_CHECK because > both macros are exactly the same. > > The last patch is a new run of the

Re: Should we apply for GitLab's open source program?

On 17/09/20 01:39, Bradley M. Kuhn wrote: > One thing to note is that my understanding is that most of what you're > getting access to through this program is proprietary software features that > GitLab offers as add-ons. Basically all we need is the increased access to the CI environment (not jus

Re: [PATCH v2] linux-user: Add most IFTUN ioctls

Ping. On Wed, Aug 5, 2020 at 4:22 PM Shu-Chun Weng wrote: > Ping: https://patchew.org/QEMU/20200723231020.769893-1-...@google.com/ > > On Thu, Jul 23, 2020 at 4:10 PM Shu-Chun Weng wrote: > >> The three options handling `struct sock_fprog` (TUNATTACHFILTER, >> TUNDETACHFILTER, and TUNGETFILTER)

Re: [PATCH 0/3] qom: Replace INTERFACE_CHECK with OBJECT_CHECK

Hi On Thu, Sep 17, 2020 at 11:19 AM Philippe Mathieu-Daudé wrote: > On 9/16/20 11:31 PM, Marc-André Lureau wrote: > > Hi > > > > On Wed, Sep 16, 2020 at 11:35 PM Eduardo Habkost > > wrote: > > > > This series replaces INTERFACE_CHECK with OBJECT_CHECK because > >

Re: [PATCH 0/2] Instruction set detection for clang.

Ping. On Wed, Aug 5, 2020 at 4:23 PM Shu-Chun Weng wrote: > Ping: https://patchew.org/QEMU/cover.1595463707.git@google.com/ > > On Wed, Jul 22, 2020 at 5:27 PM Shu-Chun Weng wrote: > >> Currently when configuring QEMU with clang, AVX2, AVX512F, ATOMIC64, and >> ATOMIC128 are all disabled be

Re: [PATCH v2 4/8] linux-user: Add IPv6 options to do_print_sockopt()

Ping -- this one was broken off into its own patch from v1 due to the amount of addition. Hence I did not add Review-by. On Tue, Aug 11, 2020 at 12:10 AM Shu-Chun Weng wrote: > Signed-off-by: Shu-Chun Weng > --- > v1 -> v2: > New: Add all IPV6 options to do_print_sockopt(), including the newl

Re: [PATCH] migration: Silence compiler warning in global_state_store_running()

On 17/09/2020 09.18, Paolo Bonzini wrote: > On 17/09/20 08:30, Thomas Huth wrote: >> On 16/09/2020 19.19, Thomas Huth wrote: >>> GCC 9.3.0 on Ubuntu complains: >>> >>> In file included from /usr/include/string.h:495, >>> from /home/travis/build/huth/qemu/include/qemu/osdep.h:87, >>

Re: [PATCH v2 5/8] linux-user: Update SO_TIMESTAMP to SO_TIMESTAMP_OLD/NEW

Ping -- any comments on the four patches start with this? https://patchew.org/QEMU/cover.1597129029.git@google.com/ On Tue, Aug 11, 2020 at 12:10 AM Shu-Chun Weng wrote: > Both guest options map to host SO_TIMESTAMP while keeping a global bit to > remember if the guest expects the old or the

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

Hi Stefan, On 2020/9/14 21:27, Stefan Hajnoczi wrote: >> >> Theoretically, everything running in an iothread is asynchronous. However, >> some 'asynchronous' actions are not non-blocking entirely, such as >> io_submit(). This will block while the iodepth is too big and I/O pressure >> is too high

Re: [PATCH v2 2/2] qom: Use DECLARE_INTERFACE_CHECKER macro

On 9/17/20 4:49 AM, Eduardo Habkost wrote: > Mechanical search/replace to use the new > DECLARE_INTERFACE_CHECKER macro instead of manually defining > macros using INTERFACE_CHECK. > > Acked-by: David Gibson > Signed-off-by: Eduardo Habkost > --- > This is an alternative to the patches submitted

Re: [SPAM] Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug()

David Gibson writes: > On Tue, Sep 15, 2020 at 01:43:40PM +0200, Greg Kurz wrote: >> On Tue, 15 Sep 2020 13:58:53 +0300 >> Vladimir Sementsov-Ogievskiy wrote: >> >> > 14.09.2020 15:35, Greg Kurz wrote: >> > > As recommended in "qapi/error.h", add a bool return value to >> > > spapr_add_lmbs() a

Re: Why QEMU translates one instruction to a TB？

On 9/17/20 8:25 AM, casmac wrote: > Hi all, > ?0?2?0?2 ?0?2 We try to add DSP architecure to QEMU 4.2. To load the COFF > format > object file, we have added loader code to load content from > ?0?2 the object file. The rom_add_blob() function is used. We firstly > analyze the COFF file to figure o

[PATCH v2] migration: Silence compiler warning in global_state_store_running()

GCC 9.3.0 on Ubuntu complains: In file included from /usr/include/string.h:495, from /home/travis/build/huth/qemu/include/qemu/osdep.h:87, from ../migration/global_state.c:13: In function ‘strncpy’, inlined from ‘global_state_store_running’ at ../migration/gl

Re: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros

On 9/16/20 8:25 PM, Eduardo Habkost wrote: > One of the goals of having less boilerplate on QOM declarations > is to avoid human error. Requiring an extra argument that is > never used is an opportunity for mistakes. > > Remove the unused argument from OBJECT_DECLARE_TYPE and > OBJECT_DECLARE_SIM

Re: [PATCH 04/37] qapi: move generator entrypoint into module

John Snow writes: > On 9/16/20 7:54 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> As part of delinting and adding type hints to the QAPI generator, it's >>> helpful for the entrypoint to be part of the module, only leaving a very >>> tiny entrypoint shim outside of the module. >>> >>

Re: Why QEMU translates one instruction to a TB？

On 9/17/20 8:25 AM, casmac wrote: > Hi all, > ?0?2?0?2 ?0?2 We try to add DSP architecure to QEMU 4.2. To load the COFF > format > object file, we have added loader code to load content from > ?0?2 the object file. [...] > ?0?2 ?0?2 The COFF loader works functionally, but we then found that some

Re: [PATCH v2] migration: Silence compiler warning in global_state_store_running()

On 9/17/20 9:43 AM, Thomas Huth wrote: > GCC 9.3.0 on Ubuntu complains: > > In file included from /usr/include/string.h:495, > from /home/travis/build/huth/qemu/include/qemu/osdep.h:87, > from ../migration/global_state.c:13: > In function ‘strncpy’, > inlined

[PATCH v6 01/12] tests/acpi: mark addition of table DSDT.roothp for unit testing root pci hotplug

A new binary acpi table tests/data/acpi/pc/DSDT.roothp is added in order to unit test the feature flag that can disable/enable root pci bus hotplug on i440fx. This feature was added with the commit: 3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") This chan

[PATCH v6 02/12] tests/acpi: add new unit test to test hotplug off/on feature on the root pci bus

Ability to turn hotplug off on the pci root bus for i440fx was added in commit: 3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") This change adds a unit test in order to test this feature. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov --- tests/qt

Re: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros

On Wed, 16 Sep 2020 14:25:17 -0400 Eduardo Habkost wrote: > One of the goals of having less boilerplate on QOM declarations > is to avoid human error. Requiring an extra argument that is > never used is an opportunity for mistakes. > > Remove the unused argument from OBJECT_DECLARE_TYPE and > O

[PATCH v6 03/12] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off

A new binary ACPI table tests/data/acpi/pc/DSDT.roothp is added in order to unit test hotplug on/off capability on the root pci bus for i440fx. The diff between the table DSDT.bridge and DSDT.roothp is listed below: @@ -1,30 +1,30 @@ /* * Intel ACPI Component Architecture * AML/ASL+ Disassemb

Re: [PATCH 2/5] qom: Remove ParentClassType argument from OBJECT_DECLARE_SIMPLE_TYPE

On 9/16/20 8:25 PM, Eduardo Habkost wrote: > The requirement to specify the parent class type makes the macro > harder to use and easy to misuse (silent bugs can be introduced > if the wrong struct type is specified). > > Simplify the macro by just not declaring any class struct, > allowing us to

[PATCH v6 04/12] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus

When ACPI hotplug for the root bus is disabled, the bsel property for that bus is not set. Please see the following commit: 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus"). As a result, when acpi_pcihp_find_hotplug_bus() is called with bsel set to 0, it ma

[PATCH v6 00/12] i440fx/acpi: addition of feature and bug fixes.

In v6: - added Acked-by and Reviewed-by for additional patches - checked 80 col/line limit for commit logs. - s/amls/acpi code in commit log - split acpi binary gold master table blobs for q35 into a separate patch (hence 12 patch series as opposed to 11). Ani Sinha (12): tests/acpi: mark ad

[PATCH v6 08/12] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag

This patch adds a binary blob corresponding to the DSDT acpi table. It is used to unit test the flag 'acpi-pci-hotplug-with-bridge-support' used with pci bridges. This change also clears the file tests/qtest/bios-tables-test-allowed-diff.h so that future changes which affect the table can be caugh

[PATCH v6 05/12] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

Cold plugged bridges are not hot unpluggable, even when their hotplug property (acpi-pci-hotplug-with-bridge-support) is turned off. Please see the function acpi_pcihp_pc_no_hotplug(). However, with the current implementaton, Windows would try to hot-unplug a pci bridge when it's hotplug switch is

Re: [PATCH 4/5] [automated] Use OBJECT_DECLARE_TYPE when possible

On 9/16/20 8:25 PM, Eduardo Habkost wrote: > This converts existing DECLARE_OBJ_CHECKERS usage to > OBJECT_DECLARE_TYPE when possible. > > $ ./scripts/codeconverter/converter.py -i \ >--pattern=AddObjectDeclareType $(git grep -l '' -- '*.[ch]') > > Signed-off-by: Eduardo Habkost For the as

[PATCH v6 07/12] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag

This change adds a new unit test for the global flag 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci bridges in i440fx. The flag can be used to turn off acpi based hotplug support on all pci bridges. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov --- tests/qt

[PATCH v6 06/12] tests/acpi: list added acpi table binary file for pci bridge hotplug test

The file 'tests/data/acpi/pc/DSDT.hpbridge' is a newly added acpi table file for testing the pci bridge option 'acpi-pci-hotplug-with-bridge-support' under i440fx. This change documents this fact. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.

[PATCH V3 01/10] qemu/: fix some comment spelling errors

I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennee --- Changelog | 2 +- accel/tcg/user-exec.c

[PATCH v6 11/12] tests/acpi: unit test exercising global pci hotplug off for i440fx

This change adds a unit test to exercise the case when hotplug is disabled both for pci root bus and the pci bridges by passing the following two switches to qemu: -global PIIX4_PM.acpi-root-pci-hotplug=off -global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off bios-tables-test-allowed-dif

[PATCH v6 09/12] piix4: don't reserve hw resources when hotplug is off globally

When acpi hotplug is turned off for both root pci bus as well as for pci bridges, we should not generate the related ACPI code for DSDT table or initialize related hw ports or reserve hw resources. This change makes sure all those operations are turned off in the case ACPI pci hotplug is off global

[PATCH V3 07/10] block/: fix some comment spelling errors

I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the block folder. Signed-off-by: zhaolichang --- block/block-copy.c | 2 +- block/linux-aio.c | 2 +- block/mirror.c | 2

[PATCH V3 02/10] migration/: fix some comment spelling errors

I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the migration folder. Signed-off-by: zhaolichang Reviewed-by: Peter Maydell --- migration/colo-failover.c | 2 +- migration/

[PATCH v6 12/12] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

This change adds a new DSDT golden master table blob to test disabling hotplug on both pci root bus and pci bridges. Also reverts the change in file bios-tables-test-allowed-diff.h to make sure its now empty so that future modifications to acpi tables can be caught. The following is the disassembl

[PATCH v6 10/12] tests/acpi: update golden master DSDT binary table blobs for q35

In the change d7f82561fe ("piix4: don't reserve hw resources when hotplug is off globally"), we make changes to the ACPI DSDT tables such that some ACPI code are not generated when bsel is absent. Since as of this point in time, in q35 machines, we do not use bsel for pci buses, we need to update t

[PATCH V3 00/10] fix some comment spelling errors

I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors, this series fixed this spelling errors. v2 -> v3: fix coding style problems in v2 version v1 -> v2: address Peter Maydell's comments address Alex Bennee's commen

[PATCH V3 03/10] docs/: fix some comment spelling errors

I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the docs folder. Signed-off-by: zhaolichang Reviewed-by: Peter Maydell --- docs/COLO-FT.txt | 6 +++--- docs/

Re: [RFC PATCH 02/12] target/arm/kvm64: make MPIDR consistent with CPU Topology

On Thu, Sep 17, 2020 at 11:20:23AM +0800, Ying Fang wrote: > MPIDR helps to provide an additional PE identification in a multiprocessor > system. This patch adds support for setting MPIDR from userspace, so that > MPIDR is consistent with CPU topology configured. > > Signed-off-by: Ying Fang > --

Re: [PATCH v2] migration: Silence compiler warning in global_state_store_running()

On 17/09/2020 09.47, Philippe Mathieu-Daudé wrote: > On 9/17/20 9:43 AM, Thomas Huth wrote: >> GCC 9.3.0 on Ubuntu complains: >> >> In file included from /usr/include/string.h:495, >> from /home/travis/build/huth/qemu/include/qemu/osdep.h:87, >> from ../migration/g

Re: [PATCH V9 0/6] mips: Add Loongson-3 machine support

Hi Huacai, On 9/16/20 4:12 AM, Huacai Chen wrote: > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B > R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while > Loongson-3A R4 is the newest and its ISA is almost the superset of all > others. To reduce complexity

[PATCH V3 05/10] util/: fix some comment spelling errors

I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the util folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennee --- util/osdep.c | 2 +- util/qemu-progress.

[PATCH V3 04/10] scripts/: fix some comment spelling errors

I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the scripts folder. Signed-off-by: zhaolichang Reviewed-by: Peter Maydell --- scripts/checkpatch.pl | 2 +- scripts/

RE: [PATCH 5/5] [automated] Use OBJECT_DECLARE_SIMPLE_TYPE when possible

> -Original Message- > From: Eduardo Habkost > Sent: 16 September 2020 19:25 > To: qemu-devel@nongnu.org > Cc: Paolo Bonzini ; Daniel P. Berrange > ; Gonglei (Arei) > ; Igor Mammedov ; Laurent > Vivier ; > Amit Shah ; Stefan Berger ; Michael > S. Tsirkin > ; Greg Kurz ; Christian Schoen

[PATCH V3 06/10] linux-user/: fix some comment spelling errors

I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the linux-user folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennee --- linux-user/aarch64/signal.c | 2 +

Re: [PATCH 07/37] qapi: add pylintrc

John Snow writes: > On 9/16/20 8:30 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Add a skeleton pylintrc file. Right now, it ignores quite a few things. >>> Files will be removed from the known-bad list throughout this and >>> following series as they are repaired. >>> >>> Note: Nor

[PATCH V3 08/10] disas/: fix some comment spelling errors

I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the disas folder. Signed-off-by: zhaolichang --- disas/hppa.c | 2 +- disas/m68k.c | 8 disas/ppc.c | 2 +- 3 files

Re: [PATCH v2] migration: Silence compiler warning in global_state_store_running()

On 17/09/2020 10.02, Thomas Huth wrote: > On 17/09/2020 09.47, Philippe Mathieu-Daudé wrote: >> On 9/17/20 9:43 AM, Thomas Huth wrote: >>> GCC 9.3.0 on Ubuntu complains: >>> >>> In file included from /usr/include/string.h:495, >>> from /home/travis/build/huth/qemu/include/qemu/osde

[PATCH V3 09/10] qapi/: fix some comment spelling errors

I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the qapi folder. Signed-off-by: zhaolichang Reviewed-by: Markus Armbruster --- qapi/block-core.json | 4 ++-- qapi/crypto.jso

[PATCH V3 10/10] contrib/: fix some comment spelling errors

I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the contrib folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennee --- contrib/gitdm/filetypes.txt | 6 +++--

Re: [PATCH v6 00/12] i440fx/acpi: addition of feature and bug fixes.

Patchew URL: https://patchew.org/QEMU/20200917074733.13612-1-...@anisinha.ca/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at http://patchew.org/logs/20200917074733.13612

Re: [PATCH V9 6/6] hw/mips: Add Loongson-3 machine support

On 9/16/20 12:47 PM, Philippe Mathieu-Daudé wrote: > On 9/16/20 11:49 AM, Huacai Chen wrote: >> On Wed, Sep 16, 2020 at 3:56 PM Philippe Mathieu-Daudé >> wrote: >>> On 9/16/20 4:12 AM, Huacai Chen wrote: > [...] +static void mips_loongson3_virt_init(MachineState *machine) +{ +i

Re: [PATCH V9 6/6] hw/mips: Add Loongson-3 machine support

On 9/16/20 11:49 AM, Huacai Chen wrote: >>> We now already have a full functional Linux kernel (based on Linux-5.4.x >>> LTS, the kvm host side and guest side have both been upstream for Linux- >>> 5.9, but Linux-5.9 has not been released yet) here: >>> >>> https://github.com/chenhuacai/linux >>> >

Re: [PATCH 06/37] qapi: delint using flake8

John Snow writes: > On 9/16/20 8:12 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Petty style guide fixes and line length enforcement. Not a big win, not >>> a big loss, but flake8 passes 100% on the qapi module, which gives us an >>> easy baseline to enforce hereafter. >>> >>> Sign

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

Hi Daniel, On 2020/9/14 22:42, Daniel P. Berrangé wrote: > On Tue, Aug 11, 2020 at 09:54:08PM +0800, Zhenyu Ye wrote: >> Hi Kevin, >> >> On 2020/8/10 23:38, Kevin Wolf wrote: >>> Am 10.08.2020 um 16:52 hat Zhenyu Ye geschrieben: Before doing qmp actions, we need to lock the qemu_global_mutex,

RE: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros

> -Original Message- > From: Eduardo Habkost > Sent: 16 September 2020 19:25 > To: qemu-devel@nongnu.org > Cc: Paolo Bonzini ; Daniel P. Berrange > ; Marc-André Lureau > ; Gerd Hoffmann ; Michael S. > Tsirkin ; > Peter Maydell ; Corey Minyard > ; Cédric Le Goater > ; David Gibson ; Corn

Re: [RFC PATCH 05/12] hw/arm/virt: DT: add cpu-map

On Thu, Sep 17, 2020 at 11:20:26AM +0800, Ying Fang wrote: > From: Andrew Jones > > Support devicetree CPU topology descriptions. > > Signed-off-by: Andrew Jones There's a new version of this patch on the refresh branch. https://github.com/rhdrjones/qemu/commits/virt-cpu-topology-refresh drew

RE: [PATCH 4/5] [automated] Use OBJECT_DECLARE_TYPE when possible

> -Original Message- > From: Eduardo Habkost > Sent: 16 September 2020 19:25 > To: qemu-devel@nongnu.org > Cc: Paolo Bonzini ; Daniel P. Berrange > ; Peter Maydell > ; Andrzej Zaborowski ; Alistair > Francis > ; Kevin Wolf ; Max Reitz > ; Mark Cave- > Ayland ; David Gibson > ; Richard

Re: [REPORT] Nightly Performance Tests - Wednesday, September 16, 2020

On Thu, Sep 17, 2020 at 12:07 AM Ahmed Karaman wrote: > > Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz > Host Memory : 15.49 GB > > Start Time (UTC) : 2020-09-16 21:35:02 > End Time (UTC) : 2020-09-16 22:07:32 > Execution Time : 0:32:29.941492 > > Status : SUCCESS

Use patchew to push successfully applied series to GitLab

Hi, patchew is currently pushing successfully applied series (using the cover Message-ID as tag) to GitHub. This is very handy (no need to apply patches manually): https://github.com/patchew-project/qemu/tags Can we push the same that to an equivalent GitLab account? We could then have a script r

Re: [RFC PATCH 03/12] target/arm/kvm32: make MPIDR consistent with CPU Topology

On Thu, Sep 17, 2020 at 11:20:24AM +0800, Ying Fang wrote: > MPIDR helps to provide an additional PE identification in a multiprocessor > system. This patch adds support for setting MPIDR from userspace, so that > MPIDR is consistent with CPU topology configured. > > Signed-off-by: Ying Fang > --

Re: [PATCH V3 00/10] fix some comment spelling errors

Patchew URL: https://patchew.org/QEMU/20200917075029.313-1-zhaolich...@huawei.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. The full log is available at http://patchew.org/logs/20200917075029.313-1-zhaolich...@huawei.com/testing.FreeBSD/?type=mess

Re: [RFC PATCH 06/12] hw/arm/virt-acpi-build: distinguish possible and present cpus

On Thu, Sep 17, 2020 at 11:20:27AM +0800, Ying Fang wrote: > When building ACPI tables regarding CPUs we should always build > them for the number of possible CPUs, not the number of present > CPUs. We then ensure only the present CPUs are enabled. > > Signed-off-by: Andrew Jones > Signed-off-by:

Re: [PATCH V9 0/6] mips: Add Loongson-3 machine support

On Wednesday, September 16, 2020, Huacai Chen wrote: > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B > R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while > Loongson-3A R4 is the newest and its ISA is almost the superset of all > others. To reduce comple

Re: [PATCH 09/37] qapi/common.py: Add indent manager

John Snow writes: > On 9/16/20 11:13 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Code style tools really dislike the use of global keywords, because it >>> generally involves re-binding the name at runtime which can have strange >>> effects depending on when and how that global nam

Re: [RFC PATCH 04/12] device_tree: add qemu_fdt_add_path

On Thu, Sep 17, 2020 at 11:20:25AM +0800, Ying Fang wrote: > From: Andrew Jones > > qemu_fdt_add_path works like qemu_fdt_add_subnode, except it > also recursively adds any missing parent nodes. > > Cc: Peter Crosthwaite > Cc: Alexander Graf > Signed-off-by: Andrew Jones > --- > device_tree.

Re: [RFC PATCH 07/12] hw/acpi/aml-build: add processor hierarchy node structure

On Thu, Sep 17, 2020 at 11:20:28AM +0800, Ying Fang wrote: > Add the processor hierarchy node structures to build ACPI information > for CPU topology. Three helpers are introduced: > > (1) build_socket_hierarchy for socket description structure > (2) build_processor_hierarchy for processor descrip

Re: [RFC PATCH 08/12] hw/arm/virt-acpi-build: add PPTT table

On Thu, Sep 17, 2020 at 11:20:29AM +0800, Ying Fang wrote: > Add the Processor Properties Topology Table (PPTT) to present CPU topology > information to the guest. > > Signed-off-by: Andrew Jones > Signed-off-by: Ying Fang > --- > hw/arm/virt-acpi-build.c | 42 ++

Re: [PATCH V3 00/10] fix some comment spelling errors

Patchew URL: https://patchew.org/QEMU/20200917075029.313-1-zhaolich...@huawei.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. The full log is available at http://patchew.org/logs/20200917075029.313-1-zhaolich...@huawei.com/testing.FreeBSD/?type=mess

Re: Should we apply for GitLab's open source program?

Paolo Bonzini writes: > On 17/09/20 01:39, Bradley M. Kuhn wrote: >> One thing to note is that my understanding is that most of what you're >> getting access to through this program is proprietary software features that >> GitLab offers as add-ons. > > Basically all we need is the increased acc

Re: [RFC PATCH 09/12] target/arm/cpu: Add CPU cache description for arm

On Thu, Sep 17, 2020 at 11:20:30AM +0800, Ying Fang wrote: > Add the CPUCacheInfo structure to hold CPU cache information for ARM cpus. > A classic three level cache topology is used here. The default cache > capacity is given and userspace can overwrite these values. Doesn't TCG already have some

Re: Why QEMU translates one instruction to a TB？

casmac writes: > Hi all, >      We try to add DSP architecure to QEMU 4.2. To load the > COFF format object file, we have added loader code to load content from >   the object file. The rom_add_blob() function is used. We firstly > analyze the COFF file to figure out which sections are c

Re: [PATCH V3 08/10] disas/: fix some comment spelling errors

zhaolichang writes: > I found that there are many spelling errors in the comments of qemu, > so I used the spellcheck tool to check the spelling errors > and finally found some spelling errors in the disas folder. > > Signed-off-by: zhaolichang Reviewed-by: Alex Bennée I suggest on your nex

Re: [PATCH v2] virtio: skip legacy support check on machine types less than 5.1

On Wed, Sep 16, 2020 at 11:08:48AM +0200, Cornelia Huck wrote: > On Tue, 15 Sep 2020 15:05:14 +0200 > Stefano Garzarella wrote: > > > Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally > > on") added a check that returns an error if legacy support is on, but the > > device

Re: [PATCH V3 00/10] fix some comment spelling errors

Patchew URL: https://patchew.org/QEMU/20200917075029.313-1-zhaolich...@huawei.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. The full log is available at http://patchew.org/logs/20200917075029.313-1-zhaolich...@huawei.com/testing.FreeBSD/?type=mess

QEMU policy for real file tests

Hi, is there a QEMU policy for test cases that create/write/read/delete real files and directories? E.g. should they be situated at a certain location and is any measure of sandboxing required? Best regards, Christian Schoenebeck

Re: Use patchew to push successfully applied series to GitLab

On 17/09/20 10:16, Philippe Mathieu-Daudé wrote: > patchew is currently pushing successfully applied series > (using the cover Message-ID as tag) to GitHub. > This is very handy (no need to apply patches manually): > https://github.com/patchew-project/qemu/tags > > Can we push the same that to an

Re: [PATCH v2] migration: Silence compiler warning in global_state_store_running()

Patchew URL: https://patchew.org/QEMU/20200917074344.168785-1-th...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. The full log is availa

Re: [PATCH v5 00/10] preallocate filter

01.09.2020 18:07, Max Reitz wrote: On 27.08.20 23:08, Vladimir Sementsov-Ogievskiy wrote: 21.08.2020 17:11, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here is a filter, which does preallocation on write. In Virtuozzo we have to deal with some custom distributed storage solution, where alloca

Re: [PATCH v10 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

* Chuan Zheng (zhengch...@huawei.com) wrote: > Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be > called > > Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert > --- > migration/dirtyrate.c | 62 > +++ >

Re: [PATCH v10 00/12] *** A Method for evaluating dirty page rate ***

* Chuan Zheng (zhengch...@huawei.com) wrote: > v9 -> v10: > rename find_page_matched as find_block_matched > fix wrong termination condition in find_block_matched > add review-by for patches > > v8 -> v9: > fix wrong index return of record_ramblock_hash_info > optimize variable

[Bug 1892604] Re: qemu-system-arm: ../hw/usb/hcd-dwc2.c:666: dwc2_glbreg_read: Assertion `addr <= GINTSTS2' failed.

Something very strange is going on with the dwc_otg driver in 2016-05-27-raspbian-jessie.img. Something is reading and writing incrementally throughout the register space of the hcd-dwc2 host. And adding the "dwc_otg.fiq_fsm_enable=0" kernel option does not fix it. Brendan, Petunia, is there a r

Re: Should we apply for GitLab's open source program?

On Thu, Sep 17, 2020 at 09:32:57AM +0100, Alex Bennée wrote: > > Paolo Bonzini writes: > > > On 17/09/20 01:39, Bradley M. Kuhn wrote: > >> One thing to note is that my understanding is that most of what you're > >> getting access to through this program is proprietary software features > >> th

Re: [PATCH v10 00/12] *** A Method for evaluating dirty page rate ***

On 2020/9/17 17:15, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengch...@huawei.com) wrote: >> v9 -> v10: >> rename find_page_matched as find_block_matched >> fix wrong termination condition in find_block_matched >> add review-by for patches >> >> v8 -> v9: >> fix wrong inde

Re: [PATCH v2] virtio: skip legacy support check on machine types less than 5.1

On Thu, 17 Sep 2020 10:48:28 +0200 Stefano Garzarella wrote: > On Wed, Sep 16, 2020 at 11:08:48AM +0200, Cornelia Huck wrote: > > On Tue, 15 Sep 2020 15:05:14 +0200 > > Stefano Garzarella wrote: > > > > > Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally > > > on") ad

Re: [PATCH v5 15/20] docs/devel/qapi-code-gen.txt: Update to new rST backend conventions

Peter Maydell writes: > Update the documentation of QAPI document comment syntax to match > the new rST backend requirements. The principal changes are: > * whitespace is now significant, Well, differently significant :) > and multiline definitions >must h

Re: QEMU policy for real file tests

Christian Schoenebeck writes: > Hi, > > is there a QEMU policy for test cases that create/write/read/delete real > files > and directories? E.g. should they be situated at a certain location and is > any > measure of sandboxing required? I don't think we have a hard and fast policy. It als

[Bug 1892604] Re: qemu-system-arm: ../hw/usb/hcd-dwc2.c:666: dwc2_glbreg_read: Assertion `addr <= GINTSTS2' failed.

The URL to the image I used is http://downloads.raspberrypi.org/raspbian/images/raspbian-2019-09-30/2019-09-26 -raspbian-buster.zip -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1892604 Title: qemu

Re: [PATCH 2/3] virtio-blk: undo destructive iov_discard_*() operations

On Wed, Sep 16, 2020 at 11:38:36PM +0800, Li Qiang wrote: > Stefan Hajnoczi 于2020年8月12日周三 下午6:51写道： > > @@ -644,7 +648,8 @@ static int virtio_blk_handle_request(VirtIOBlockReq > > *req, MultiReqBuffer *mrb) > > req->in = (void *)in_iov[in_num - 1].iov_base > >+ in_iov[in_num

Re: Use patchew to push successfully applied series to GitLab

On Thu, Sep 17, 2020 at 10:53:14AM +0200, Paolo Bonzini wrote: > On 17/09/20 10:16, Philippe Mathieu-Daudé wrote: > > patchew is currently pushing successfully applied series > > (using the cover Message-ID as tag) to GitHub. > > This is very handy (no need to apply patches manually): > > https://g

Re: QEMU policy for real file tests

On Thu, Sep 17, 2020 at 10:26:36AM +0100, Alex Bennée wrote: > > Christian Schoenebeck writes: > > > Hi, > > > > is there a QEMU policy for test cases that create/write/read/delete real > > files > > and directories? E.g. should they be situated at a certain location and is > > any > > measu

Re: [PATCH v10 00/12] *** A Method for evaluating dirty page rate ***

* Zheng Chuan (zhengch...@huawei.com) wrote: > > > On 2020/9/17 17:15, Dr. David Alan Gilbert wrote: > > * Chuan Zheng (zhengch...@huawei.com) wrote: > >> v9 -> v10: > >> rename find_page_matched as find_block_matched > >> fix wrong termination condition in find_block_matched > >> add

[PATCH v2 2/3] virtio-blk: undo destructive iov_discard_*() operations

Fuzzing discovered that virtqueue_unmap_sg() is being called on modified req->in/out_sg iovecs. This means dma_memory_map() and dma_memory_unmap() calls do not have matching memory addresses. Fuzzing discovered that non-RAM addresses trigger a bug: void address_space_unmap(AddressSpace *as, voi

[PATCH v2 0/3] virtio: restore elem->in/out_sg after iov_discard_front/back()

v2: * Add missing undo in virtio-blk write zeroes error path [Li Qiang] Both virtio-blk and virtio-crypto use destructive iov_discard_front/back() operations on elem->in/out_sg. virtqueue_push() calls dma_memory_unmap() on the modified iovec arrays. The memory addresses may not match those origin

[PATCH v2 1/3] util/iov: add iov_discard_undo()

The iov_discard_front/back() operations are useful for parsing iovecs but they modify the array elements. If the original array is needed after parsing finishes there is currently no way to restore it. Although g_memdup() can be used before performing destructive iov_discard_front/back() operation

  1   2   3   4   5   >