Re: [PATCH v4 07/11] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag

2020-09-16 Thread Igor Mammedov
On Wed, 16 Sep 2020 11:43:31 +0530 Ani Sinha wrote: > This change adds a new unit test for the global flag > 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci > bridges in i440fx. The flag can be used to turn off acpi based hotplug support > for all pci bridges. > >

Re: [PATCH v4 08/11] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag

2020-09-16 Thread Igor Mammedov
On Wed, 16 Sep 2020 11:43:32 +0530 Ani Sinha wrote: > This patch adds a binary blob corresponding to the DSDT acpi table. It is used > to unit test the flag 'acpi-pci-hotplug-with-bridge-support' used with pci > bridges. > > This change also clears the file tests/qtest/bios-tables-test-allowed-d

Re: [PATCH v6 2/8] s390/sclp: rework sclp boundary checks

2020-09-16 Thread Thomas Huth
On 15/09/2020 21.44, Collin Walling wrote: > Rework the SCLP boundary check to account for different SCLP commands > (eventually) allowing different boundary sizes. > > Signed-off-by: Collin Walling > Acked-by: Janosch Frank > Reviewed-by: Cornelia Huck > --- > hw/s390x/sclp.c | 19 +++

Re: [PATCH v4 10/11] tests/acpi: unit test exercizing hotplug off for pci root bus & bridge in i440fx

2020-09-16 Thread Igor Mammedov
On Wed, 16 Sep 2020 11:43:34 +0530 Ani Sinha wrote: > This change adds a unit test to exercize the case when hotplug is disabled > both for > pci root bus and the pci bridges by passing the following two switches to > qemu: > > -global PIIX4_PM.acpi-root-pci-hotplug=off > -global PIIX4_PM.

Re: [PATCH v3 2/5] vfio: Create shared routine for scanning info capabilities

2020-09-16 Thread Philippe Mathieu-Daudé
On 9/15/20 9:14 PM, Matthew Rosato wrote: > Rather than duplicating the same loop in multiple locations, > create a static function to do the work. > > Signed-off-by: Matthew Rosato Reviewed-by: Philippe Mathieu-Daudé > --- > hw/vfio/common.c | 21 + > 1 file changed, 13 i

Re: [PATCH v4 00/11] i440fx/acpi: addition of feature and bug fixes.

2020-09-16 Thread Igor Mammedov
On Wed, 16 Sep 2020 11:43:24 +0530 Ani Sinha wrote: > In v4 I have made the following changes: > > - a cosmetic change for patch #4. Commit log was updated as per Igor's > suggestion. > - patches #10 and #11 were added to unit test patch #9. > > The DSDT table after disabling hotplug on the ro

Re: [PATCH v4 00/11] i440fx/acpi: addition of feature and bug fixes.

2020-09-16 Thread Ani Sinha
Got it. On Wed, Sep 16, 2020 at 12:46 PM Igor Mammedov wrote: > > On Wed, 16 Sep 2020 11:43:24 +0530 > Ani Sinha wrote: > > > In v4 I have made the following changes: > > > > - a cosmetic change for patch #4. Commit log was updated as per Igor's > > suggestion. > > - patches #10 and #11 were ad

Re: [PATCH v3 4/5] s390x/pci: Add routine to get the vfio dma available count

2020-09-16 Thread Philippe Mathieu-Daudé
On 9/15/20 9:14 PM, Matthew Rosato wrote: > Create new files for separating out vfio-specific work for s390 > pci. Add the first such routine, which issues VFIO_IOMMU_GET_INFO > ioctl to collect the current dma available count. > > Signed-off-by: Matthew Rosato > --- > hw/s390x/meson.build |

Re: [PATCH v2] virtio: skip legacy support check on machine types less than 5.1

2020-09-16 Thread Stefano Garzarella
+Cc qemu-sta...@nongnu.org It was not my day... I forgot to cc stable. Thanks, Stefano On Tue, Sep 15, 2020 at 03:05:14PM +0200, Stefano Garzarella wrote: > Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally > on") added a check that returns an error if legacy support is

Re: [PATCH v4 10/11] tests/acpi: unit test exercizing hotplug off for pci root bus & bridge in i440fx

2020-09-16 Thread Igor Mammedov
On Wed, 16 Sep 2020 11:43:34 +0530 Ani Sinha wrote: > This change adds a unit test to exercize the case when hotplug is disabled > both for > pci root bus and the pci bridges by passing the following two switches to > qemu: > > -global PIIX4_PM.acpi-root-pci-hotplug=off > -global PIIX4_PM.

Re: [PATCH v4 10/11] tests/acpi: unit test exercizing hotplug off for pci root bus & bridge in i440fx

2020-09-16 Thread Thomas Huth
Hi! On 16/09/2020 08.13, Ani Sinha wrote: > This change adds a unit test to exercize the case when hotplug is disabled > both for exercize ==> exercise (also in the subject, please) [...]> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > index 7632cfe1be..4c834474

Python 3.5 EOL; when can require 3.6?

2020-09-16 Thread Markus Armbruster
We require Python 3.5. It will reach its "end of life" at the end of September 2020[*]. Any reason not to require 3.6 for 5.2? qemu-iotests already does for its Python parts. [*] https://www.python.org/downloads/release/python-3510/

Re: [PATCH V9 3/6] target/mips: Add loongson-ext lswc2 group of instructions (Part 1)

2020-09-16 Thread Philippe Mathieu-Daudé
On 9/16/20 4:12 AM, Huacai Chen wrote: > From: Jiaxun Yang > > LWC2 & SWC2 have been rewritten by Loongson EXT vendor ASE > as "load/store quad word" and "shifted load/store" groups of > instructions. > > This patch add implementation of these instructions: > gslq: load 16 bytes to GPR > gssq: s

Re: [PATCH v4 5/9] migration: control whether snapshots are ovewritten

2020-09-16 Thread Markus Armbruster
Daniel P. Berrangé writes: > The traditional HMP "savevm" command will overwrite an existing snapshot > if it already exists with the requested name. This new flag allows this > to be controlled allowing for safer behaviour with a future QMP command. > > Signed-off-by: Daniel P. Berrangé > --- >

Re: Python 3.5 EOL; when can require 3.6?

2020-09-16 Thread Philippe Mathieu-Daudé
On 9/16/20 9:43 AM, Markus Armbruster wrote: > We require Python 3.5. It will reach its "end of life" at the end of > September 2020[*]. Any reason not to require 3.6 for 5.2? qemu-iotests > already does for its Python parts. > > > [*] https://www.python.org/downloads/release/python-3510/ Not

Re: Python 3.5 EOL; when can require 3.6?

2020-09-16 Thread Thomas Huth
On 16/09/2020 09.43, Markus Armbruster wrote: > We require Python 3.5. It will reach its "end of life" at the end of > September 2020[*]. Any reason not to require 3.6 for 5.2? qemu-iotests > already does for its Python parts. I think the only reason for requiring Python 3.5 is that we still us

Question on --enable-profile

2020-09-16 Thread Zhang, Qiang
I have some questions for you, when add "--enable-profile" options to compile qemu there are some error: include/qemu/compiler.h:93:36: error: static assertion failed: "not expecting: sizeof(*&s->prof.del_op_count) > ATOMIC_REG_SIZE" 93 | #define QEMU_BUILD_BUG_MSG(x, msg) _Static_assert(!(

Re: [PATCH V9 6/6] hw/mips: Add Loongson-3 machine support

2020-09-16 Thread Philippe Mathieu-Daudé
Hi Huacai, On 9/16/20 4:12 AM, Huacai Chen wrote: > Add Loongson-3 based machine support, it use liointc as the interrupt > controler and use GPEX as the pci controller. Currently it can work with > both TCG and KVM. > > As the machine model is not based on any exiting physical hardware, the > na

Re: [PATCH V9 3/6] target/mips: Add loongson-ext lswc2 group of instructions (Part 1)

2020-09-16 Thread Huacai Chen
Hi, Philippe, On Wed, Sep 16, 2020 at 3:46 AM Philippe Mathieu-Daudé wrote: > > On 9/16/20 4:12 AM, Huacai Chen wrote: > > From: Jiaxun Yang > > > > LWC2 & SWC2 have been rewritten by Loongson EXT vendor ASE > > as "load/store quad word" and "shifted load/store" groups of > > instructions. > > >

Re: [PATCH v6 3/8] s390/sclp: read sccb from mem based on provided length

2020-09-16 Thread Thomas Huth
On 15/09/2020 21.44, Collin Walling wrote: > The header contained within the SCCB passed to the SCLP service call > contains the actual length of the SCCB. Instead of allocating a static > 4K size for the work sccb, let's allow for a variable size determined > by the value in the header. The proper

Re: Python 3.5 EOL; when can require 3.6?

2020-09-16 Thread Thomas Huth
On 16/09/2020 09.53, Philippe Mathieu-Daudé wrote: > On 9/16/20 9:43 AM, Markus Armbruster wrote: >> We require Python 3.5. It will reach its "end of life" at the end of >> September 2020[*]. Any reason not to require 3.6 for 5.2? qemu-iotests >> already does for its Python parts. >> >> >> [*] h

[PATCH] configure: move malloc_trim/tcmalloc/jemalloc to meson

2020-09-16 Thread Paolo Bonzini
Because LIBS is not used anymore, tcmalloc/jemalloc does not work with binaries whose description is in Meson. The fix is simply to move them to Meson too. For consistency with other configure options, specifying --enable-malloc-trim together with --enable-{tc,je}malloc becomes a fatal error. Rep

[PATCH] configure: fix --meson=/path/to/meson

2020-09-16 Thread Paolo Bonzini
Due to a cut-and-paste error, the path to a user-specified meson was ignored and replaced by whatever was in the path. Signed-off-by: Paolo Bonzini --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 13f53ba231..d6fbadad27 100755 --- a/co

Re: [PATCH V9 6/6] hw/mips: Add Loongson-3 machine support

2020-09-16 Thread Philippe Mathieu-Daudé
On 9/16/20 9:56 AM, Philippe Mathieu-Daudé wrote: > On 9/16/20 4:12 AM, Huacai Chen wrote: [...] >> diff --git a/default-configs/mips64el-softmmu.mak >> b/default-configs/mips64el-softmmu.mak >> index 9f8a3ef..26c660a 100644 >> --- a/default-configs/mips64el-softmmu.mak >> +++ b/default-configs/mi

[PATCH] configure: move cocoa option to Meson

2020-09-16 Thread Paolo Bonzini
While detection of the framework was already there, moving the option allows for better error reporting. Reported-by: Christophe de Dinechin Signed-off-by: Paolo Bonzini --- configure | 17 +++-- meson.build | 10 -- meson_options.txt | 2 ++ ui/meson.build

[PATCH] configure: do not limit Hypervisor.framework test to Darwin

2020-09-16 Thread Paolo Bonzini
Because the target/i386/hvf/meson.build rule culls hvf support on non-Darwin systems, a --enable-hvf build is succeeding. To fix this, just try the compilation test every time someone passes --enable-hvf. Reported-by: Christophe de Dinechin Signed-off-by: Paolo Bonzini --- configure | 8 +--

Re: [PATCH v6 8/8] s390: guest support for diagnose 0x318

2020-09-16 Thread Thomas Huth
On 15/09/2020 21.44, Collin Walling wrote: > DIAGNOSE 0x318 (diag318) is an s390 instruction that allows the storage > of diagnostic information that is collected by the firmware in the case > of hardware/firmware service events. > > QEMU handles the instruction by storing the info in the CPU stat

Re: Python 3.5 EOL; when can require 3.6?

2020-09-16 Thread Philippe Mathieu-Daudé
On 9/16/20 10:02 AM, Thomas Huth wrote: > On 16/09/2020 09.53, Philippe Mathieu-Daudé wrote: >> On 9/16/20 9:43 AM, Markus Armbruster wrote: >>> We require Python 3.5. It will reach its "end of life" at the end of >>> September 2020[*]. Any reason not to require 3.6 for 5.2? qemu-iotests >>> alr

Re: [PATCH v4 9/9] migration: introduce snapshot-{save, load, delete} QMP commands

2020-09-16 Thread Markus Armbruster
Daniel P. Berrangé writes: > savevm, loadvm and delvm are some of the few HMP commands that have never > been converted to use QMP. The reasons for the lack of conversion are > that they blocked execution of the event thread, and the semantics > around choice of disks were ill-defined. > > Despit

[PATCH v5 00/11] i440fx/acpi: addition of feature and bug fixes.

2020-09-16 Thread Ani Sinha
In v5, I have tried to address all the latest review comments in commit logs and in patches. Also added "Reviewed-by" and "Acked-by" tags when a particular patch was already reviewed. Unit tests pass when the patch series is applied on top of the latest qemu master branch. Disassembly of DSDT ta

[PATCH v5 02/11] tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus

2020-09-16 Thread Ani Sinha
Ability to turn hotplug off on the pci root bus for i440fx was added in commit: 3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") This change adds a unit test in order to test this feature. This change has been tested against upstream qemu master branch ti

[PATCH v5 04/11] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus

2020-09-16 Thread Ani Sinha
When ACPI hotplug for the root bus is disabled, the bsel property for that bus is not set. Please see the following commit: 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus"). As a result, when acpi_pcihp_find_hotplug_bus() is called with bsel set to 0, it m

[PATCH v5 07/11] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag

2020-09-16 Thread Ani Sinha
This change adds a new unit test for the global flag 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci bridges in i440fx. The flag can be used to turn off acpi based hotplug support on all pci bridges. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov --- tests/qt

[PATCH v5 01/11] tests/acpi: document addition of table DSDT.roothp for unit testing root pci hotplug on/off

2020-09-16 Thread Ani Sinha
A new binary acpi table tests/data/acpi/pc/DSDT.roothp is added in order to unit test the feature flag that can disable/enable root pci bus hotplug on i440fx. This feature was added with the commit: 3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") This c

[PATCH v5 03/11] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off

2020-09-16 Thread Ani Sinha
A new binary ACPI table tests/data/acpi/pc/DSDT.roothp is added in order to unit test hotplug on/off capability on the root pci bus for i440fx. The diff between the table DSDT.bridge and DSDT.roothp is listed below: @@ -1,30 +1,30 @@ /* * Intel ACPI Component Architecture * AML/ASL+ Disassemb

[PATCH v5 08/11] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag

2020-09-16 Thread Ani Sinha
This patch adds a binary blob corresponding to the DSDT acpi table. It is used to unit test the flag 'acpi-pci-hotplug-with-bridge-support' used with pci bridges. This change also clears the file tests/qtest/bios-tables-test-allowed-diff.h so that future changes which affect the table can be caugh

[PATCH v5 05/11] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-16 Thread Ani Sinha
Cold plugged bridges are not hot unpluggable, even when their hotplug property (acpi-pci-hotplug-with-bridge-support) is turned off. Please see the function acpi_pcihp_pc_no_hotplug(). However, with the current implementaton, Windows would try to hot-unplug a pci bridge when it's hotplug switch is

[PATCH v5 09/11] piix4: don't reserve hw resources when hotplug is off globally

2020-09-16 Thread Ani Sinha
When acpi hotplug is turned off for both root pci bus as well as for pci bridges, we should not generate the related acpi code for DSDT table or initialize related hw ports or reserve hw resources. This change makes sure all those operations are turned off in the case acpi pci hotplug is off global

[PATCH v5 06/11] tests/acpi: list added acpi table binary file for pci bridge hotplug test

2020-09-16 Thread Ani Sinha
The file 'tests/data/acpi/pc/DSDT.hpbridge' is a newly added acpi table file for testing the pci bridge option 'acpi-pci-hotplug-with-bridge-support' under i440fx. This change documents this fact. Signed-off-by: Ani Sinha --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1

[PATCH] misc: aspeed_scu: Update AST2600 silicon id register

2020-09-16 Thread Joel Stanley
Aspeed have released an updated datasheet (v7) containing the silicon id for the AST2600 A2. It looks like this: SCU004 SCU014 AST2600-A0 0x05000303 0x05000303 AST2600-A1 0x05010303 0x05010303 AST2600-A2 0x05010303 0x05020303 AST2620-A1 0x05010203 0x05010203 AS

[PATCH v5 10/11] tests/acpi: unit test exercising hotplug off for pci root bus & bridge in i440fx

2020-09-16 Thread Ani Sinha
This change adds a unit test to exercise the case when hotplug is disabled both for pci root bus and the pci bridges by passing the following two switches to qemu: -global PIIX4_PM.acpi-root-pci-hotplug=off -global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off bios-tables-test-allowed-di

[PATCH v5 11/11] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-16 Thread Ani Sinha
This change adds a new DSDT golden master table blob to test disabling hotplug on both pci root bus and pci bridges. Also reverts the change in file bios-tables-test-allowed-diff.h to make sure its now empty so that future modifications to acpi tables can be caught. The following is the disassembl

Re: [PATCH v6 8/8] s390: guest support for diagnose 0x318

2020-09-16 Thread David Hildenbrand
On 16.09.20 10:11, Thomas Huth wrote: > On 15/09/2020 21.44, Collin Walling wrote: >> DIAGNOSE 0x318 (diag318) is an s390 instruction that allows the storage >> of diagnostic information that is collected by the firmware in the case >> of hardware/firmware service events. >> >> QEMU handles the ins

Re: Python 3.5 EOL; when can require 3.6?

2020-09-16 Thread Andrea Bolognani
On Wed, 2020-09-16 at 09:53 +0200, Philippe Mathieu-Daudé wrote: > On 9/16/20 9:43 AM, Markus Armbruster wrote: > > We require Python 3.5. It will reach its "end of life" at the end of > > September 2020[*]. Any reason not to require 3.6 for 5.2? qemu-iotests > > already does for its Python part

Re: [PATCH v4 9/9] migration: introduce snapshot-{save, load, delete} QMP commands

2020-09-16 Thread Daniel P . Berrangé
On Wed, Sep 16, 2020 at 10:17:52AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > savevm, loadvm and delvm are some of the few HMP commands that have never > > been converted to use QMP. The reasons for the lack of conversion are > > that they blocked execution of the event th

Re: [PATCH v2 4/6] target/ppc: Set instance_align on PowerPCCPU TypeInfo

2020-09-16 Thread David Gibson
On Tue, Sep 15, 2020 at 05:46:36PM -0700, Richard Henderson wrote: > Fix alignment of CPUPPCState.vsr. > > Signed-off-by: Richard Henderson LGTM Acked-by: David Gibson > --- > Cc: David Gibson > Cc: qemu-...@nongnu.org > --- > target/ppc/translate_init.c.inc | 1 + > 1 file changed, 1 inser

Re: [PATCH 00/15] spapr: Error handling fixes and cleanups (round 2)

2020-09-16 Thread David Gibson
On Mon, Sep 14, 2020 at 02:34:50PM +0200, Greg Kurz wrote: > Yet another round of sanitizing the error handling in spapr. I've > identified locations that needed fixing with the errp-guard.cocci > coccinelle script. It turns out that a better result is achieved > by fixing manually, especially by c

Re: [PATCH 7/9] tests/performance: Add nightly tests

2020-09-16 Thread Alex Bennée
Aleksandar Markovic writes: > On Wednesday, September 2, 2020, Alex Bennée wrote: > >> >> Ahmed Karaman writes: >> >> > A nightly performance testing system to monitor any change in QEMU >> > performance across seventeen different targets. >> > >> > The system includes eight different benchma

Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-09-16 Thread David Gibson
On Mon, Sep 14, 2020 at 12:24:25PM +0200, Philippe Mathieu-Daudé wrote: > As the 'io_base' argument of m48t59_init() is unused (set to 0), > remove it to simplify. > To create a device on the ISA bus, m48t59_init_isa() is the > preferred function to use. > > Signed-off-by: Philippe Mathieu-Daudé

Re: Python 3.5 EOL; when can require 3.6?

2020-09-16 Thread Daniel P . Berrangé
On Wed, Sep 16, 2020 at 09:54:32AM +0200, Thomas Huth wrote: > On 16/09/2020 09.43, Markus Armbruster wrote: > > We require Python 3.5. It will reach its "end of life" at the end of > > September 2020[*]. Any reason not to require 3.6 for 5.2? qemu-iotests > > already does for its Python parts.

Re: [PATCH v4 5/9] migration: control whether snapshots are ovewritten

2020-09-16 Thread Daniel P . Berrangé
On Wed, Sep 16, 2020 at 09:47:32AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > The traditional HMP "savevm" command will overwrite an existing snapshot > > if it already exists with the requested name. This new flag allows this > > to be controlled allowing for safer behavi

Re: Python 3.5 EOL; when can require 3.6?

2020-09-16 Thread Daniel P . Berrangé
On Wed, Sep 16, 2020 at 09:43:10AM +0200, Markus Armbruster wrote: > We require Python 3.5. It will reach its "end of life" at the end of > September 2020[*]. Any reason not to require 3.6 for 5.2? qemu-iotests > already does for its Python parts. Note that upstream EOL dates aren't directly re

[PATCH v3 1/2] Introduce (x86) CPU model deprecation API

2020-09-16 Thread Robert Hoo
Complement versioned CPU model framework with the ability of marking some versions deprecated. When that CPU model is chosen, get some warning. The warning message is customized, e.g. telling in which future QEMU version will it be obsoleted. The deprecation message will also appear by x86_cpu_list

[PATCH v2 0/2] build spice chardevs as module

2020-09-16 Thread Gerd Hoffmann
Gerd Hoffmann (2): spice: simplify chardev setup chardev: build spice chardevs as module include/chardev/spice.h | 1 - include/ui/qemu-spice.h | 1 - chardev/spice.c | 29 ++--- softmmu/vl.c| 9 + ui/spice-app.c | 17 +

[PATCH v2 2/2] chardev: build spice chardevs as module

2020-09-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- util/module.c | 2 ++ chardev/meson.build | 7 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/util/module.c b/util/module.c index 34772e7d87eb..86781c207f7d 100644 --- a/util/module.c +++ b/util/module.c @@ -268,6 +268,8 @@ static stru

[PATCH v3 2/2] Mark Icelake-Client CPU models deprecated

2020-09-16 Thread Robert Hoo
Going to obsolete Icelake-Client CPU models in the future. Signed-off-by: Robert Hoo --- Change log v3: Obsolete in v5.2 --> v5.3. target/i386/cpu.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 9cb82b7..15c1c00 100644

[PATCH v2 1/2] spice: simplify chardev setup

2020-09-16 Thread Gerd Hoffmann
Initialize spice before chardevs. That allows to register the spice chardevs directly in the init function and removes the need to maintain a linked list of chardevs just for registration. Signed-off-by: Gerd Hoffmann --- include/chardev/spice.h | 1 - include/ui/qemu-spice.h | 1 - chardev/s

[PATCH 1/2] audio: remove qemu_spice_audio_init()

2020-09-16 Thread Gerd Hoffmann
Handle the spice special case in audio_init instead. With the qemu_spice_audio_init() symbol dependency being gone we can build spiceaudio as module. Signed-off-by: Gerd Hoffmann --- include/ui/qemu-spice.h | 1 - audio/audio.c | 16 audio/spiceaudio.c | 5

[PATCH 2/2] audio: build spiceaudio as module

2020-09-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- audio/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/audio/meson.build b/audio/meson.build index 15c06ba0453b..18a831129ed0 100644 --- a/audio/meson.build +++ b/audio/meson.build @@ -7,7 +7,6 @@ softmmu_ss.add(files( 'wavcap

Re: [PATCH 01/37] python: Require 3.6+

2020-09-16 Thread Markus Armbruster
John Snow writes: > Python 3.5 is now EOL. Python 3.6 brings with it several nice things: > > - Literal string interpolation (PEP 498) > - Syntax for variable annotations (PEP 526) > - Preserving keyword argument order (PEP 468) * > > PEP 526 in particular will allow us to convert the QAPI module

[PATCH 0/2] build spice audio as module

2020-09-16 Thread Gerd Hoffmann
Gerd Hoffmann (2): audio: remove qemu_spice_audio_init() audio: build spiceaudio as module include/ui/qemu-spice.h | 1 - audio/audio.c | 16 audio/spiceaudio.c | 5 - ui/spice-core.c | 1 - audio/meson.build | 4 ++-- 5 files changed, 1

Re: [PATCH v2 1/2] hw/gpio/max7310: Remove impossible check

2020-09-16 Thread Laurent Vivier
Le 10/09/2020 à 09:23, Philippe Mathieu-Daudé a écrit : > The max7310_gpio_set() handler is static and only used by > qdev_init_gpio_in, initialized with 8 IRQs. The 'line' > argument can not be out of the [0-8[ range. > Replace the dead code by an assertion. > > Suggested-by: Peter Maydell > Sig

Re: [PATCH v2 2/2] hw/ppc/ppc4xx_pci: Replace magic value by the PCI_NUM_PINS definition

2020-09-16 Thread Laurent Vivier
Le 10/09/2020 à 09:23, Philippe Mathieu-Daudé a écrit : > Replace the magic '4' value by the PCI_NUM_PINS definition. > > Suggested-by: Cédric Le Goater > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/ppc/ppc4xx_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [PATCH] ui/spice-input: Remove superfluous forward declaration

2020-09-16 Thread Laurent Vivier
Le 09/09/2020 à 19:11, Philippe Mathieu-Daudé a écrit : > We only need to forward-declare kbd_push_key() and kbd_get_leds() > which are used in kbd_interface, not kbd_leds(). Remove this > superfluous forward declaration. > > Signed-off-by: Philippe Mathieu-Daudé > --- > ui/spice-input.c | 1 - >

Re: [PATCH 01/37] python: Require 3.6+

2020-09-16 Thread Daniel P . Berrangé
On Tue, Sep 15, 2020 at 06:39:51PM -0400, John Snow wrote: > Python 3.5 is now EOL. Python 3.6 brings with it several nice things: NB Upstream EOL is not relevant. We need to base min version changes on the OS platform support matrix. So it would be better for the commit message to provide details

Re: [PATCH RESEND] manual: escape backslashes in "parsed-literal" blocks

2020-09-16 Thread Laurent Vivier
Le 15/09/2020 à 09:57, Laszlo Ersek a écrit : > On 09/10/20 12:23, Philippe Mathieu-Daudé wrote: >> Cc'ing qemu-trivial@ > > Thanks! > > The patch was posted a week ago (and reviewed as well, by you, thanks!) > -- is there something I need to do for getting this merged? Applied to my trivial-pat

Re: [PATCH] configure: move malloc_trim/tcmalloc/jemalloc to meson

2020-09-16 Thread Stefan Hajnoczi
On Wed, Sep 16, 2020 at 04:06:08AM -0400, Paolo Bonzini wrote: > Because LIBS is not used anymore, tcmalloc/jemalloc does > not work with binaries whose description is in Meson. > The fix is simply to move them to Meson too. > > For consistency with other configure options, specifying > --enable-m

[PATCH] mtest2make: add support for introspected test dependencies

2020-09-16 Thread Paolo Bonzini
Right now all "make check" targets depend blindly on "all". If Meson is 0.56.0 or newer, we can use the correct dependencies using the new "depends" entry in "meson introspect --tests". Signed-off-by: Paolo Bonzini --- Makefile | 2 +- scripts/mtest2make.py | 19 +++---

[BUG] Migration hv_time rollback

2020-09-16 Thread Antoine Damhet
Hi, We are experiencing timestamp rollbacks during live-migration of Windows 10 guests with the following qemu configuration (linux 5.4.46 and qemu master): ``` $ qemu-system-x86_64 -enable-kvm -cpu host,kvm=off,hv_time [...] ``` I have tracked the bug to the fact that `kvmclock` is not exposed a

Re: [PATCH v2 1/2] spice: simplify chardev setup

2020-09-16 Thread Daniel P . Berrangé
On Wed, Sep 16, 2020 at 10:39:12AM +0200, Gerd Hoffmann wrote: > Initialize spice before chardevs. That allows to register the spice > chardevs directly in the init function and removes the need to maintain > a linked list of chardevs just for registration. > > Signed-off-by: Gerd Hoffmann > ---

[PATCH] meson: qtest: set "depends" correctly

2020-09-16 Thread Paolo Bonzini
This does not have any effect on Meson's behavior itself, since "meson test" always rebuilds everything (that is one reason why we are not using it...). However, mtest2make can use this information to do a selective rebuild for the requested suite. Cc: Thomas Huth Signed-off-by: Paolo Bonzini --

Re: [PATCH v2] virtio: skip legacy support check on machine types less than 5.1

2020-09-16 Thread Cornelia Huck
On Tue, 15 Sep 2020 15:05:14 +0200 Stefano Garzarella wrote: > Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally > on") added a check that returns an error if legacy support is on, but the > device is not legacy. > > Unfortunately some devices were wrongly declared legac

Re: [PATCH v10 13/26] meson: remove empty else and duplicated gio deps

2020-09-16 Thread Laurent Vivier
Le 15/09/2020 à 19:12, Yonggang Luo a écrit : > Signed-off-by: Yonggang Luo > Reviewed-by: Daniel P. Berrangé > --- > meson.build | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/meson.build b/meson.build > index 690723b470..23cb1b8742 100644 > --- a/meson.build > +++ b/meson.build

Re: [PATCH 0/2] hw/timer/hpet: Fix compiler errors with -DHPET_DEBUG

2020-09-16 Thread Laurent Vivier
Le 13/09/2020 à 13:42, Philippe Mathieu-Daudé a écrit : > Cc'ing qemu-trivial@ > > On 9/10/20 2:53 PM, Dov Murik wrote: >> On 09/09/2020 20:24, Philippe Mathieu-Daudé wrote: >>> On 9/9/20 10:36 AM, Dov Murik wrote: Fix several compiler errors when compiling withe -DHPET_DEBUG. Steps

Re: [PATCH v2] scripts/git.orderfile: Display meson files along with buildsys ones

2020-09-16 Thread Laurent Vivier
Le 07/09/2020 à 18:12, Philippe Mathieu-Daudé a écrit : > Since commit a56650518f5 ("configure: integrate Meson in the build > system") we replaced many Makefile by Meson files. Adapt the > git.orderfile script to display the new file at the same position. > > Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH v2 2/2] chardev: build spice chardevs as module

2020-09-16 Thread Paolo Bonzini
On 16/09/20 10:39, Gerd Hoffmann wrote: > +if config_host.has_key('CONFIG_SPICE') > + module_ss = ss.source_set() > + module_ss.add(when: [spice], if_true: [files('spice.c'), spice]) You don't need to have "spice" listed in both sides. It is not needed in "when" because you are effectively insi

Re: [PATCH v3 3/5] sev/i386: Allow AP booting under SEV-ES

2020-09-16 Thread Laszlo Ersek
Hi Tom, sorry for the random feedback -- I haven't followed (and don't really intend to follow) the QEMU side of the feature. Just one style idea: On 09/15/20 23:29, Tom Lendacky wrote: > From: Tom Lendacky > > When SEV-ES is enabled, it is not possible modify the guests register > state after

Re: [PATCH v2 1/2] spice: simplify chardev setup

2020-09-16 Thread Paolo Bonzini
On 16/09/20 11:06, Daniel P. Berrangé wrote: >> +/* spice must initialize before chardevs (for spicevmc and spiceport) */ >> +qemu_spice_init(); >> + > I don't think we should be putting this before the '-object' processing too. > We really want -object to be the first thing processed in ge

[PATCH v3 0/5] hw/arm/virt: Introduce kvm-steal-time

2020-09-16 Thread Andrew Jones
Previous posting: https://www.mail-archive.com/qemu-devel@nongnu.org/msg727588.html v3: - Rebased: 5.2 machine type and kvm32 drop now included - Switched to using new KVM cap that has been merged upstream - Picked up some r-b's and some of Eric's comments from v2 KVM supports the ability t

[PATCH v3 2/5] hw/arm/virt: Move post cpu realize check into its own function

2020-09-16 Thread Andrew Jones
We'll add more to this new function in coming patches so we also state the gic must be created and call it below create_gic(). No functional change intended. Reviewed-by: Eric Auger Reviewed-by: Peter Maydell Signed-off-by: Andrew Jones --- hw/arm/virt.c | 43 +++--

[PATCH v3 1/5] target/arm/kvm: Make uncalled stubs explicitly unreachable

2020-09-16 Thread Andrew Jones
When we compile without KVM support !defined(CONFIG_KVM) we generate stubs for functions that the linker will still encounter. Sometimes these stubs can be executed safely and are placed in paths where they get executed with or without KVM. Other functions should never be called without KVM. Those

[PATCH v3 3/5] hw/arm/virt: Move kvm pmu setup to virt_cpu_post_init

2020-09-16 Thread Andrew Jones
Move the KVM PMU setup part of fdt_add_pmu_nodes() to virt_cpu_post_init(), which is a more appropriate location. Now fdt_add_pmu_nodes() is also named more appropriately, because it no longer does anything but fdt node creation. No functional change intended. Reviewed-by: Peter Maydell Signed-o

[PATCH v3 4/5] DO NOT MERGE: HACK: Add steal time KVM cap to kvm.h

2020-09-16 Thread Andrew Jones
--- linux-headers/linux/kvm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index a28c3667370b..924672cca1f1 100644 --- a/linux-headers/linux/kvm.h +++ b/linux-headers/linux/kvm.h @@ -1031,6 +1031,7 @@ struct kvm_ppc_resize_hpt { #define

[PATCH v3 5/5] hw/arm/virt: Implement kvm-steal-time

2020-09-16 Thread Andrew Jones
We add the kvm-steal-time CPU property and implement it for machvirt. A tiny bit of refactoring was also done to allow pmu and pvtime to use the same vcpu device helper functions. Signed-off-by: Andrew Jones --- docs/system/arm/cpu-features.rst | 11 ++ hw/arm/virt.c| 43

Re: [PATCH V2 00/10] fix some comment spelling errors

2020-09-16 Thread Laurent Vivier
Le 14/09/2020 à 05:56, zhaolichang a écrit : > ping > I tried to apply some of your patches, but they don't apply because they are not formated correctly. You should send them using "git send-email" or "git publish". Thanks, Laurent

Re: [PATCH 2/3] hostmem-file: add readonly=on|off option

2020-09-16 Thread Stefan Hajnoczi
On Fri, Aug 21, 2020 at 02:50:42PM +0200, Philippe Mathieu-Daudé wrote: > On 8/4/20 12:12 PM, Stefan Hajnoczi wrote: > > Let -object memory-backend-file work on read-only files when the > > readonly=on option is given. This can be used to share the contents of a > > file between multiple guests whi

Re: [PATCH] misc: aspeed_scu: Update AST2600 silicon id register

2020-09-16 Thread Cédric Le Goater
On 9/16/20 10:20 AM, Joel Stanley wrote: > Aspeed have released an updated datasheet (v7) containing the silicon id > for the AST2600 A2. It looks like this: > > SCU004 SCU014 > AST2600-A0 0x05000303 0x05000303 > AST2600-A1 0x05010303 0x05010303 > AST2600-A2 0x0501030

Re: [PATCH v3 1/4] qapi: net: Add query-netdevs command

2020-09-16 Thread Alexey Kirillov
08.09.2020, 17:32, "Markus Armbruster" : > Eric Blake writes: > >>  On 9/7/20 7:39 AM, Markus Armbruster wrote: >> >  This is union Netdev plus a common member @peer-id, less the variant >  members for NetClientDriver values 'nic' and 'hubport'. > >  Can 'type: 'nic' and 'type': 'h

Re: [PATCH 3/3] nvdimm: honor -object memory-backend-file, readonly=on option

2020-09-16 Thread Stefan Hajnoczi
On Fri, Aug 21, 2020 at 03:03:50PM +0200, Philippe Mathieu-Daudé wrote: > On 8/4/20 12:12 PM, Stefan Hajnoczi wrote: > > Make it possible to present read-only files to the guest as "unarmed" > > NVDIMMs. The Linux NVDIMM device (/dev/pmemX) is read-only. > > > > Signed-off-by: Stefan Hajnoczi > >

[PULL 1/8] monitor: simplify functions for getting a dup'd fdset entry

2020-09-16 Thread Daniel P . Berrangé
Currently code has to call monitor_fdset_get_fd, then dup the return fd, and then add the duplicate FD back into the fdset. This dance is overly verbose for the caller and introduces extra failure modes which can be avoided by folding all the logic into monitor_fdset_dup_fd_add and removing monitor

[PULL 4/8] util: refactor qemu_open_old to split off variadic args handling

2020-09-16 Thread Daniel P . Berrangé
This simple refactoring prepares for future patches. The variadic args handling is split from the main bulk of the open logic. Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff

Re: [PATCH v7 10/13] hmp: Add support for coroutine command handlers

2020-09-16 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Often, QMP command handlers are not only called to handle QMP commands, > but also from a corresponding HMP command handler. In order to give them > a consistent environment, optionally run HMP command handlers in a > coroutine, too. > > The implementation

[PULL 5/8] util: add Error object for qemu_open_internal error reporting

2020-09-16 Thread Daniel P . Berrangé
Instead of relying on the limited information from errno, we can now also provide detailed error messages to callers that ask for it. Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --

Re: [PATCH V9 6/6] hw/mips: Add Loongson-3 machine support

2020-09-16 Thread Huacai Chen
Hi, Philippe, On Wed, Sep 16, 2020 at 3:56 PM Philippe Mathieu-Daudé wrote: > > Hi Huacai, > > On 9/16/20 4:12 AM, Huacai Chen wrote: > > Add Loongson-3 based machine support, it use liointc as the interrupt > > controler and use GPEX as the pci controller. Currently it can work with > > both TCG

[PULL 0/8] Block odirect patches

2020-09-16 Thread Daniel P . Berrangé
The following changes since commit de39a045bd8d2b49e4f3d07976622c29d58e0bac: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200915-pull-request= ' into staging (2020-09-15 14:25:05 +0100) are available in the Git repository at: https://github.com/berrange/qemu tags/block-odirect-pul

[PULL 2/8] util: split off a helper for dealing with O_CLOEXEC flag

2020-09-16 Thread Daniel P . Berrangé
We're going to have multiple callers to open() from qemu_open() soon. Readability would thus benefit from having a helper for dealing with O_CLOEXEC. Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 23 +++ 1 file changed, 15 insertions(+),

[PULL 3/8] util: rename qemu_open() to qemu_open_old()

2020-09-16 Thread Daniel P . Berrangé
We want to introduce a new version of qemu_open() that uses an Error object for reporting problems and make this it the preferred interface. Rename the existing method to release the namespace for the new impl. Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbr

[PULL 0/2] 9p queue

2020-09-16 Thread Christian Schoenebeck
The following changes since commit 2d2c73d0e3d504a61f868e46e6abd5643f38091b: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200914-1' into staging (2020-09-14 16:03:08 +0100) are available in the Git repository at: https://github.com/cschoenebeck/qemu.git tags/pull-9

[PULL 6/8] util: introduce qemu_open and qemu_create with error reporting

2020-09-16 Thread Daniel P . Berrangé
qemu_open_old() works like open(): set errno and return -1 on failure. It has even more failure modes, though. Reporting the error clearly to users is basically impossible for many of them. Our standard cure for "errno is too coarse" is the Error object. Introduce two new helper methods: int q

Re: [Bug 1895053] Re: Cannot nspawn raspbian 10 [FAILED] Failed to start Journal Service.

2020-09-16 Thread Laurent Vivier
Le 15/09/2020 à 00:03, Petunia a écrit : > for file in /proc/sys/fs/binfmt_misc/* ; do echo "$file"; LANG=C cat $file; > done ... > /proc/sys/fs/binfmt_misc/arm > enabled > interpreter /usr/bin/qemu-arm-static > flags: OCF > offset 0 > magic 7f454c460101010002002800 > mask

  1   2   3   4   5   >