Re: [PATCH 9/9] piix4: don't reserve hw resources when hotplug is off globally

On Mon, Sep 14, 2020 at 9:11 PM Ani Sinha wrote: > > On Mon, Sep 14, 2020 at 8:51 PM Ani Sinha wrote: > > > > On Mon, Sep 14, 2020 at 8:20 PM Ani Sinha wrote: > > > > > > On Mon, Sep 14, 2020 at 7:39 PM Igor Mammedov wrote: > > > > > > > > On Mon, 14 Sep 2020 18:58:19 +0530 > > > > Ani Sinha w

Re: [PATCH v3 07/12] hw/arm/virt: Move post cpu realize check into its own function

On Tue, 15 Sep 2020 at 14:22, Andrew Jones wrote: > > On Tue, Sep 15, 2020 at 03:11:43AM +, Haibo Xu wrote: > > From: Andrew Jones > > > > We'll add more to this new function in coming patches so we also > > state the gic must be created and call it below create_gic(). > > > > No functional c

Re: [PATCH v5 0/8] user-mode: Prune build dependencies (part 2)

On 9/15/20 8:29 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> This is the second part of a series reducing user-mode >> dependencies. By stripping out unused code, the build >> and testing time is reduced (as is space used by objects). >> >> Series is fully Acked. > > One mo

Re: [PATCH 2/2] qcow2: Convert qcow2_alloc_cluster_offset() into qcow2_alloc_host_offset()

On 14.09.20 18:42, Alberto Garcia wrote: > On Mon 14 Sep 2020 02:14:36 PM CEST, Max Reitz wrote: > >> However, I wonder what you think about “cluster_offset” in >> qcow2_alloc_host_offset. It isn’t a cluster offset anymore. >> Can/should we rename it? > > That variable was not a cluster offset b

Re: [PATCH 0/2] Make preallocate_co() resize the image to the correct size

On 11.09.20 16:09, Alberto Garcia wrote: > preallocate_co() does not resize the image correctly if the original > size was not cluster-aligned. > > This series should be applied on top of Max's block branch (I tested > it with commit 8e66c829eda997dad661d49d73668b1fd3e6043d). > >https://git.x

Re: [PATCH v3 07/12] hw/arm/virt: Move post cpu realize check into its own function

On Tue, Sep 15, 2020 at 03:03:49PM +0800, Haibo Xu wrote: > On Tue, 15 Sep 2020 at 14:22, Andrew Jones wrote: > > > > On Tue, Sep 15, 2020 at 03:11:43AM +, Haibo Xu wrote: > > > From: Andrew Jones > > > > > > We'll add more to this new function in coming patches so we also > > > state the gic

Re: [PATCH v3 03/12] target/arm/cpu: spe: Add an option to turn on/off vSPE support

On Tue, 15 Sep 2020 at 14:11, Andrew Jones wrote: > > On Tue, Sep 15, 2020 at 03:11:39AM +, Haibo Xu wrote: > > Adds a spe=[on/off] option to enable/disable vSPE support in > > guest vCPU. > > > > Reviewed-by: Andrew Jones > > Signed-off-by: Haibo Xu > > --- > > target/arm/cpu.c | 6

Re: [PATCH v3 07/12] hw/arm/virt: Move post cpu realize check into its own function

On Tue, 15 Sep 2020 at 15:31, Andrew Jones wrote: > > On Tue, Sep 15, 2020 at 03:03:49PM +0800, Haibo Xu wrote: > > On Tue, 15 Sep 2020 at 14:22, Andrew Jones wrote: > > > > > > On Tue, Sep 15, 2020 at 03:11:43AM +, Haibo Xu wrote: > > > > From: Andrew Jones > > > > > > > > We'll add more to

Re: [PATCH v3 02/15] hw/block/nvme: Report actual LBA data shift in LBAF

On Sep 14 07:14, Dmitry Fomichev wrote: > Calculate the data shift value to report based on the set value of > logical_block_size device property. > > In the process, use a local variable to calculate the LBA format > index instead of the hardcoded value 0. This makes the code more > readable and

Re: [PATCH v3 01/15] hw/block/nvme: Define 64 bit cqe.result

On Sep 14 07:14, Dmitry Fomichev wrote: > From: Ajay Joshi > > A new write command, Zone Append, is added as a part of Zoned > Namespace Command Set. Upon successful completion of this command, > the controller returns the start LBA of the performed write operation > in cqe.result field. Therefor

Re: [PATCH v2 00/15] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

On Sep 13 07:54, Dmitry Fomichev wrote: > v1 -> v2: > > - Incorporated feedback from Klaus and Alistair. Since it's been a while since I reviewed this, it would have been nice if you had listed what feedback you incorporated ;) signature.asc Description: PGP signature

RE: device compatibility interface for live migration with assigned devices

On Monday, September 14, 2020 10:45 PM Alex Williamson wrote: > To: Zeng, Xin > Cc: Zhao, Yan Y ; Sean Mooney > ; Cornelia Huck ; Daniel > P.Berrangé ; k...@vger.kernel.org; libvir- > l...@redhat.com; Jason Wang ; qemu- > de...@nongnu.org; kwankh...@nvidia.com; eau...@redhat.com; Wang, > Xin-ra

Re: [PATCH v2] qom: simplify object_find_property / object_class_find_property

Daniel P. Berrangé writes: > When debugging QEMU it is often useful to put a breakpoint on the > error_setg_internal method impl. > > Unfortunately the object_property_add / object_class_property_add > methods call object_property_find / object_class_property_find methods > to check if a property

Re: [PATCH RESEND] manual: escape backslashes in "parsed-literal" blocks

On 09/10/20 12:23, Philippe Mathieu-Daudé wrote: > Cc'ing qemu-trivial@ Thanks! The patch was posted a week ago (and reviewed as well, by you, thanks!) -- is there something I need to do for getting this merged? Thank you Laszlo > On 9/8/20 7:21 PM, Laszlo Ersek wrote: >> According to >>

Re: [PATCH v4 1/6] migration/tls: save hostname into MigrationState

On Tue, Sep 15, 2020 at 11:03:57AM +0800, Chuan Zheng wrote: > hostname is need in multifd-tls, save hostname into MigrationState. > > Signed-off-by: Chuan Zheng > Signed-off-by: Yan Jin > --- > migration/channel.c | 1 + > migration/migration.c | 1 + > migration/migration.h | 5 + > mig

Re: [PATCH v4 3/6] migration/tls: add tls_hostname into MultiFDSendParams

On Tue, Sep 15, 2020 at 11:03:59AM +0800, Chuan Zheng wrote: > Since multifd creation is async with migration_channel_connect, we should > pass the hostname from MigrationState to MultiFDSendParams. > > Signed-off-by: Chuan Zheng > Signed-off-by: Yan Jin > --- > migration/multifd.c | 5 + >

Re: [PATCH v2] hw/arm/aspeed: Add machine properties to define the flash models

Tested-by: Lei YU Tested on ast2500-evb with 64MiB flash on fmc and it works as expected. On Tue, Sep 15, 2020 at 1:49 PM Cédric Le Goater wrote: > > Some machines don't have much differences a part from the flash model > being used. Introduce new machine properties to change them from the > co

Re: [PATCH v5 0/8] user-mode: Prune build dependencies (part 2)

Philippe Mathieu-Daudé writes: > This is the second part of a series reducing user-mode > dependencies. By stripping out unused code, the build > and testing time is reduced (as is space used by objects). > > Series is fully Acked. Queued, thanks!

Re: [PATCH 2/2] block: file-posix: Replace posix_fallocate with fallocate

On Mon, Sep 14, 2020 at 8:32 PM Daniel P. Berrangé wrote: > > On Mon, Aug 31, 2020 at 05:01:27PM +0300, Nir Soffer wrote: > > If fallocate() is not supported, posix_fallocate() falls back to > > inefficient allocation, writing one byte for every 4k bytes[1]. This is > > very slow compared with wri

Re: [PATCH v2] qemu-img: Support bitmap --merge into backing image

On 14.09.20 21:10, Eric Blake wrote: > If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a > bitmap from top into base, qemu-img was failing with: > > qemu-img: Could not open 'top.qcow2': Could not open backing file: Failed to > get shared "write" lock > Is another process using

Re: [PATCH] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[]

On 14.09.20 21:05, Stefano Garzarella wrote: > Commit 19ae9ae014 ("block/rbd: Add support for ceph namespaces") > introduced namespace support for RBD, but we forgot to add the > new 'namespace' options to qemu_rbd_strong_runtime_opts[]. > > The 'namespace' is used to identify the image, so it is

Re: [PATCH 01/15] spapr: Fix error leak in spapr_realize_vcpu()

14.09.2020 15:34, Greg Kurz wrote: If spapr_irq_cpu_intc_create() fails, local_err isn't propagated and thus leaked. Fixes: 992861fb1e4c ("error: Eliminate error_propagate() manually") Cc: arm...@redhat.com Signed-off-by: Greg Kurz Reviewed-by: Vladimir Sementsov-Ogievskiy --- hw/ppc/spa

Re: Potential regression in 'qemu-img convert' to LVM

On Mon, Sep 14, 2020 at 3:25 PM Stefan Reiter wrote: > > Hi list, > > following command fails since 5.1 (tested on kernel 5.4.60): > > # qemu-img convert -p -f raw -O raw /dev/zvol/pool/disk-1 /dev/vg/disk-1 > qemu-img: error while writing at byte 2157968896: Device or resource busy > > (source is

Re: [PATCH 02/15] ppc: Add a return value to ppc_set_compat() and ppc_set_compat_all()

14.09.2020 15:34, Greg Kurz wrote: As recommended in "qapi/error.h", indicate success / failure with a return value. Since ppc_set_compat() is called from a VMState handler, What handler do you mean? You don't update any handlers here.. let's make it an int so that it propagates any negative

Re: [PATCH v1 3/6] configure: also skip deprecated targets with target-list-exclude

Peter Maydell writes: > On Mon, 14 Sep 2020 at 16:27, Alex Bennée wrote: >> >> Now the user has to make an even more deliberate decision to >> enable a deprecated target rather than getting it as a side effect of >> using --target-exclude-list. >> >> Signed-off-by: Alex Bennée >> --- >> conf

Re: [PATCH 1/2] qcow2: Make preallocate_co() resize the image to the correct size

On 11.09.20 16:09, Alberto Garcia wrote: > This function preallocates metadata structures and then extends the > image to its new size, but that new size calculation is wrong because > it doesn't take into account that the host_offset variable is always > cluster-aligned. > > This problem can be r

Re: [PATCH 02/15] ppc: Add a return value to ppc_set_compat() and ppc_set_compat_all()

On Tue, 15 Sep 2020 12:18:35 +0300 Vladimir Sementsov-Ogievskiy wrote: > 14.09.2020 15:34, Greg Kurz wrote: > > As recommended in "qapi/error.h", indicate success / failure with a > > return value. Since ppc_set_compat() is called from a VMState handler, > > What handler do you mean? You don't u

Re: [PATCH v2] tests/qtest/qmp-cmd-test: Use inclusive language

On Mon, Sep 14, 2020 at 06:37:55PM +0200, Thomas Huth wrote: > We simply want to ignore certain queries here, so let's rather > use the term 'ignore' to express this intention. > > Signed-off-by: Thomas Huth > --- > v2: Changed naming according to suggestions > > tests/qtest/qmp-cmd-test.c | 1

Re: [PATCH 1/2] qcow2: Make preallocate_co() resize the image to the correct size

On Tue 15 Sep 2020 11:29:22 AM CEST, Max Reitz wrote: > On 11.09.20 16:09, Alberto Garcia wrote: >> This function preallocates metadata structures and then extends the >> image to its new size, but that new size calculation is wrong because >> it doesn't take into account that the host_offset varia

Re: [PATCH 03/15] ppc: Fix return value in cpu_post_load() error path

14.09.2020 15:34, Greg Kurz wrote: VMState handlers are supposed to return negative errno values on failure. Even vmstate_load_state() itself hase both "return -EINVAL" and "return -1".. So, all it's a mess) Signed-off-by: Greg Kurz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best rega

Re: [PATCH 04/15] spapr: Simplify error handling in callers of ppc_set_compat()

14.09.2020 15:34, Greg Kurz wrote: Now that ppc_set_compat() indicates success/failure with a return value, use it and reduce error propagation overhead. Signed-off-by: Greg Kurz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 05/15] spapr: Get rid of cas_check_pvr() error reporting

14.09.2020 15:34, Greg Kurz wrote: The cas_check_pvr() function has two purposes: - finding the "best" logical PVR, ie. the most recent one supported by the guest for this CPU type - checking if the guest supports the real PVR of this CPU type, which is just an optional extra information to

Re: [PATCH 06/15] spapr: Simplify error handling in do_client_architecture_support()

14.09.2020 15:34, Greg Kurz wrote: Use the return value of ppc_set_compat_all() to check failures, which is preferred over hijacking local_err. Signed-off-by: Greg Kurz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PULL 4/4] qga: add command guest-get-devices for reporting VirtIO devices

On 14/09/2020 03.59, Michael Roth wrote: > From: Tomáš Golembiovský > > Add command for reporting devices on Windows guest. The intent is not so > much to report the devices but more importantly the driver (and its > version) that is assigned to the device. This gives caller the > information whe

Re: [PATCH v2 1/3] vfio: Find DMA available capability

On Tue, 15 Sep 2020 08:14:24 +0200 Philippe Mathieu-Daudé wrote: > Hi Matthew, > > On 9/15/20 12:29 AM, Matthew Rosato wrote: > > The underlying host may be limiting the number of outstanding DMA > > requests for type 1 IOMMU. Add helper functions to check for the > > DMA available capability a

Re: [PATCH 07/15] spapr: Simplify error handling in spapr_vio_busdev_realize()

14.09.2020 15:34, Greg Kurz wrote: Use the return value of spapr_irq_findone() and spapr_irq_claim() to detect failures. This allows to reduce the error propagation overhead. Signed-off-by: Greg Kurz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 08/15] spapr: Add a return value to spapr_drc_attach()

14.09.2020 15:34, Greg Kurz wrote: As recommended in "qapi/error.h", return true on success and false on failure. This allows to reduce error propagation overhead in the callers. Signed-off-by: Greg Kurz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 09/15] spapr: Simplify error handling in prop_get_fdt()

14.09.2020 15:34, Greg Kurz wrote: Use the return value of visit_check_struct() and visit_check_list() for error checking instead of local_err. This allows to get rid of the error propagation overhead. Signed-off-by: Greg Kurz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladi

[Bug 1717414] Re: Sending certain keysyms results in wrong symbol input

Thanks for testing! So I'm closing the ticket now. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1717414 Title: Sending certain keysym

Re: [PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id()

14.09.2020 15:35, Greg Kurz wrote: As recommended in "qapi/error.h", return true on success and false on failure. This allows to reduce error propagation overhead in the callers. Signed-off-by: Greg Kurz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 1/3] vfio: Find DMA available capability

On Mon, 14 Sep 2020 18:29:28 -0400 Matthew Rosato wrote: > The underlying host may be limiting the number of outstanding DMA > requests for type 1 IOMMU. Add helper functions to check for the > DMA available capability and retrieve the current number of DMA > mappings allowed. > > Signed-off-by

Re: [PATCH 11/15] spapr: Simplify error handling in spapr_cpu_core_realize()

14.09.2020 15:35, Greg Kurz wrote: As recommended in "qapi/error.h", add a bool return value to spapr_realize_vcpu() and use it in spapr_cpu_core_realize() in order to get rid of the error propagation overhead. Signed-off-by: Greg Kurz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regar

[Bug 1882851] Re: QEMU video freezes with "Guest disabled display" (virtio driver)

** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1882851 Title: QEMU video freezes with "Guest disabled display" (virtio driver) Status in QEMU:

[PULL 01/22] qemu-iotests: Fix FilePaths cleanup

From: Nir Soffer If os.remove() fails to remove one of the paths, for example if the file was removed by the test, the cleanup loop would exit silently, without removing the rest of the files. Fixes: de263986b5dc Signed-off-by: Nir Soffer Reviewed-by: Max Reitz Message-Id: <20200828232152.2058

[PULL 00/22] Block patches

The following changes since commit 2d2c73d0e3d504a61f868e46e6abd5643f38091b: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200914-1' into staging (2020-09-14 16:03:08 +0100) are available in the Git repository at: https://github.com/XanClic/qemu.git tags/pull-block-

[PULL 02/22] qemu-iotests: Fix FilePaths docstring

From: Nir Soffer When this class was extracted from FilePath, the docstring was not updated for generating multiple files, and the example usage was referencing unrelated file. While fixing the docstring, add example for creating sockets, which should use iotests.sock_dir instead of the default

[PULL 16/22] qcow2: Make qcow2_free_any_clusters() free only one cluster

From: Alberto Garcia This function takes an L2 entry and a number of clusters to free. Although in principle it can free any type of cluster (using the L2 entry to determine its type) in practice the API is broken because compressed clusters have a variable size and there is no way to free more t

[PULL 07/22] qemu-img: avoid unaligned read requests during convert

From: Peter Lieven in case of large continous areas that share the same allocation status it happens that the value of s->sector_next_status is unaligned to the cluster size or even request alignment of the source. Avoid this by stripping down the s->sector_next_status position to cluster boundar

[PULL 04/22] qemu-iotests: Merge FilePaths and FilePath

From: Nir Soffer FilePath creates now one temporary file: with FilePath("a") as a: Or more: with FilePath("a", "b", "c") as (a, b, c): This is also the behavior of the file_path() helper, used by some of the tests. Now we have only 2 helpers for creating temporary files instead of 3.

[PULL 03/22] qemu-iotests: Support varargs syntax in FilePaths

From: Nir Soffer Accept variable number of names instead of a sequence: with FilePaths("a", "b", "c") as (a, b, c): The disadvantage is that base_dir must be used as kwarg: with FilePaths("a", "b", base_dir=soc_dir) as (sock1, sock2): But this is more clear and calling optional argume

[PULL 17/22] qcow2: Return the original error code in qcow2_co_pwrite_zeroes()

From: Alberto Garcia This function checks the current status of a (sub)cluster in order to see if an unaligned 'write zeroes' request can be done efficiently by simply updating the L2 metadata and without having to write actual zeroes to disk. If the situation does not allow using the fast path

[PULL 09/22] qcow2: Fix removal of list members from BDRVQcow2State.cluster_allocs

From: Alberto Garcia When a write request needs to allocate new clusters (or change the L2 bitmap of existing ones) a QCowL2Meta structure is created so the L2 metadata can be later updated and any copy-on-write can be performed if necessary. A write request can span a region consisting of an ar

[PULL 14/22] block/vhdx: Support vhdx image only with 512 bytes logical sector size

From: Swapnil Ingle block/vhdx uses qemu block layer where sector size is always 512 bytes. This may have issues with 4K logical sector sized vhdx image. For e.g qemu-img convert on such images fails with following assert: $qemu-img convert -f vhdx -O raw 4KTest1.vhdx test.raw qemu-img: util/i

[PULL 05/22] qemu-iotests: Simplify FilePath __init__

From: Nir Soffer Use list comprehension instead of append loop. Signed-off-by: Nir Soffer Reviewed-by: Max Reitz Message-Id: <20200828232152.205833-6-nsof...@redhat.com> Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) dif

[PULL 19/22] block/qcow: remove runtime opts

From: John Snow Introduced by d85f4222b468, These were seemingly never used at all. Signed-off-by: John Snow Message-Id: <20200806211345.2925343-3-js...@redhat.com> Signed-off-by: Max Reitz --- block/qcow.c | 9 - 1 file changed, 9 deletions(-) diff --git a/block/qcow.c b/block/qcow.

Re: [PATCH 12/15] spapr: Add a return value to spapr_nvdimm_validate()

14.09.2020 15:35, Greg Kurz wrote: As recommended in "qapi/error.h", return true on success and false on failure. This allows to reduce error propagation overhead in the callers. Signed-off-by: Greg Kurz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[PULL 11/22] qcow2: Rewrite the documentation of qcow2_alloc_cluster_offset()

From: Alberto Garcia The current text corresponds to an earlier, simpler version of this function and it does not explain how it works now. Signed-off-by: Alberto Garcia Message-Id: Signed-off-by: Max Reitz --- block/qcow2-cluster.c | 24 ++-- 1 file changed, 14 insertio

[PULL 06/22] block/quorum.c: stable children names

From: Lukas Straub If we remove the child with the highest index from the quorum, decrement s->next_child_index. This way we get stable children names as long as we only remove the last child. Signed-off-by: Lukas Straub Fixes: https://bugs.launchpad.net/bugs/1881231 Reviewed-by: Zhang Chen Re

Re: [qemu-web PATCH] Add virtio-blk and virtio-scsi configuration post

On Tue, Sep 15, 2020 at 11:34:06AM +0100, Stefan Hajnoczi wrote: > The second post in the storage series covers virtio-blk and virtio-scsi. > It compares the two and offers recommendations that users and tools > using QEMU can use as a starting point. Graphs are included comparing > the performance

[PULL 13/22] iotests: Skip test_stream_parallel in test 030 when doing "make check"

From: Thomas Huth The test_stream_parallel test still occasionally fails in the CI. Thus let's disable it during "make check" for now so that it does not cause trouble during merge tests. We can enable it again once the problem has been resolved. Signed-off-by: Thomas Huth Message-Id: <20200907

[PULL 08/22] qcow2: Use macros for the L1, refcount and bitmap table entry sizes

From: Alberto Garcia This patch replaces instances of sizeof(uint64_t) in the qcow2 driver with macros that indicate what those sizes are actually referring to. Signed-off-by: Alberto Garcia Message-Id: <20200828110828.13833-1-be...@igalia.com> Signed-off-by: Max Reitz --- block/qcow2.h

[PULL 18/22] block/rbd: remove runtime_opts

From: John Snow This saw its last use in 4bfb274165ba. Signed-off-by: John Snow Message-Id: <20200806211345.2925343-2-js...@redhat.com> Signed-off-by: Max Reitz --- block/rbd.c | 42 -- 1 file changed, 42 deletions(-) diff --git a/block/rbd.c b/block/r

[PULL 10/22] qcow2: Don't check nb_clusters when removing l2meta from the list

From: Alberto Garcia In the past, when a new cluster was allocated the l2meta structure was a variable in the stack so it was necessary to have a way to tell whether it had been initialized and contained valid data or not. The nb_clusters field was used for this purpose. Since commit f50f88b9fe t

[PULL 12/22] qemu-img: Explicit number replaced by a constant

From: Yi Li Signed-off-by: Yi Li Message-Id: <20200819013607.32280-1-y...@winhong.com> Reviewed-by: Alberto Garcia Reviewed-by: Stefano Garzarella Signed-off-by: Max Reitz --- qemu-img.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c in

[PULL 21/22] qcow2: Convert qcow2_alloc_cluster_offset() into qcow2_alloc_host_offset()

From: Alberto Garcia qcow2_alloc_cluster_offset() takes an (unaligned) guest offset and returns the (aligned) offset of the corresponding cluster in the qcow2 image. In practice none of the callers need to know where the cluster starts so this patch makes the function calculate and return the fi

[PULL 15/22] qcow2: Handle QCowL2Meta on error in preallocate_co()

From: Alberto Garcia If qcow2_alloc_cluster_offset() or qcow2_alloc_cluster_link_l2() fail then this function simply returns the error code, potentially leaking the QCowL2Meta structure and leaving stale items in s->cluster_allocs. A second problem is that this function calls qcow2_free_any_clus

Re: About 'qemu-security' mailing list

Hello, +-- On Fri, 11 Sep 2020, Peter Maydell wrote --+ | Way way back, the idea of a qemu-security list was proposed, and it was | decided against because there wasn't a clear way that people could send | encrypted mail to the security team if it was just a mailing list. So that's | why we h

Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug()

14.09.2020 15:35, Greg Kurz wrote: As recommended in "qapi/error.h", add a bool return value to spapr_add_lmbs() and spapr_add_nvdimm(), and use them instead of local_err in spapr_memory_plug(). Since object_property_get_uint() only returns 0 on failure, use that as well. Why are you sure? Can

[PULL 20/22] qcow2: Make preallocate_co() resize the image to the correct size

From: Alberto Garcia This function preallocates metadata structures and then extends the image to its new size, but that new size calculation is wrong because it doesn't take into account that the host_offset variable is always cluster-aligned. This problem can be reproduced with preallocation=m

[PULL 22/22] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[]

From: Stefano Garzarella Commit 19ae9ae014 ("block/rbd: Add support for ceph namespaces") introduced namespace support for RBD, but we forgot to add the new 'namespace' options to qemu_rbd_strong_runtime_opts[]. The 'namespace' is used to identify the image, so it is a strong option since it can

Re: [SPAM] Re: [PATCH 05/15] spapr: Get rid of cas_check_pvr() error reporting

On Tue, 15 Sep 2020 13:03:13 +0300 Vladimir Sementsov-Ogievskiy wrote: > 14.09.2020 15:34, Greg Kurz wrote: > > The cas_check_pvr() function has two purposes: > > - finding the "best" logical PVR, ie. the most recent one supported by > >the guest for this CPU type > > - checking if the guest

Re: [PATCH 13/15] spapr: Add a return value to spapr_check_pagesize()

14.09.2020 15:35, Greg Kurz wrote: As recommended in "qapi/error.h", return true on success and false on failure. This allows to reduce error propagation overhead in the callers. Signed-off-by: Greg Kurz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 0/3] configure: add missing CONFIG_FOO variables

On Mon, Sep 14, 2020 at 12:50:23PM +0200, Paolo Bonzini wrote: > On 14/09/20 11:52, Stefan Hajnoczi wrote: > > The meson.build feature summary checks the presence of CONFIG_FOO variables. > > Several of these variables are never emitted by ./configure so the feature > > summary always shows these f

Re: [PATCH v2 2/3] s390x/pci: Honor DMA limits set by vfio

On Mon, 14 Sep 2020 18:29:29 -0400 Matthew Rosato wrote: > When an s390 guest is using lazy unmapping, it can result in a very > large number of oustanding DMA requests, far beyond the default > limit configured for vfio. Let's track DMA usage similar to vfio > in the host, and trigger the guest

[PATCH v4 0/9] migration: bring improved savevm/loadvm/delvm to QMP

v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html v2: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07523.html v3: https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg07076.html This series aims to provide a better designed replacement for the savevm/loadvm

[PATCH v4 2/9] migration: stop returning errno from load_snapshot()

None of the callers care about the errno value since there is a full Error object populated. This gives consistency with save_snapshot() which already just returns -1. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 17 - 1 file cha

[PATCH v4 4/9] block: allow specifying name of block device for vmstate storage

Currently the vmstate will be stored in the first block device that supports snapshots. Historically this would have usually been the root device, but with UEFI it might be the variable store. There needs to be a way to override the choice of block device to store the state in. Signed-off-by: Dani

[PATCH v4 1/9] block: push error reporting into bdrv_all_*_snapshot functions

The bdrv_all_*_snapshot functions return a BlockDriverState pointer for the invalid backend, which the callers then use to report an error message. In some cases multiple callers are reporting the same error message, but with slightly different text. In the future there will be more error scenarios

[PATCH v4 3/9] block: add ability to specify list of blockdevs during snapshot

When running snapshot operations, there are various rules for which blockdevs are included/excluded. While this provides reasonable default behaviour, there are scenarios that are not well handled by the default logic. Some of the conditions do not have a single correct answer. Thus there needs to

[PATCH v4 8/9] iotests: add support for capturing and matching QMP events

When using the _launch_qemu and _send_qemu_cmd functions from common.qemu, any QMP events get mixed in with the output from the commands and responses. This makes it difficult to write a test case as the ordering of events in the output is not stable. This introduces a variable 'capture_events' w

[PATCH v4 6/9] migration: wire up support for snapshot device selection

Modify load_snapshot/save_snapshot to accept the device list and vmstate node name parameters previously added to the block layer. Signed-off-by: Daniel P. Berrangé --- include/migration/snapshot.h | 12 ++-- migration/savevm.c | 24 ++-- monitor/hmp-cmds.c

[PATCH v4 5/9] migration: control whether snapshots are ovewritten

The traditional HMP "savevm" command will overwrite an existing snapshot if it already exists with the requested name. This new flag allows this to be controlled allowing for safer behaviour with a future QMP command. Signed-off-by: Daniel P. Berrangé --- include/migration/snapshot.h | 2 +- mig

[PATCH v4 7/9] migration: introduce a delete_snapshot wrapper

Make snapshot deletion consistent with the snapshot save and load commands by using a wrapper around the blockdev layer. The main difference is that we get upfront validation of the passed in device list (if any). Signed-off-by: Daniel P. Berrangé --- include/migration/snapshot.h | 4 +++- migr

Re: [SPAM] Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug()

On Tue, 15 Sep 2020 13:58:53 +0300 Vladimir Sementsov-Ogievskiy wrote: > 14.09.2020 15:35, Greg Kurz wrote: > > As recommended in "qapi/error.h", add a bool return value to > > spapr_add_lmbs() and spapr_add_nvdimm(), and use them instead > > of local_err in spapr_memory_plug(). > > > > Since ob

[PATCH v4 9/9] migration: introduce snapshot-{save, load, delete} QMP commands

savevm, loadvm and delvm are some of the few HMP commands that have never been converted to use QMP. The reasons for the lack of conversion are that they blocked execution of the event thread, and the semantics around choice of disks were ill-defined. Despite this downside, however, libvirt and ap

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

On 13/09/2020 16.08, Paolo Bonzini wrote: > On 13/09/20 00:44, Yonggang Luo wrote: >> This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41. >> >> The --ninja option doesn't need anymore because of upgrade meson to 0.55.2 >> At that version we can use ninjatool > > We might actually get rid

[PATCH] qga/commands-win32: Fix problem with redundant protype declaration

When compiling QEMU with MSYS2 on Windows, there is currently the following error: ../qga/commands-win32.c:62:24: error: redundant redeclaration of 'CM_Get_DevNode_PropertyW' [-Werror=redundant-decls] 62 | CMAPI CONFIGRET WINAPI CM_Get_DevNode_PropertyW( |^~~~

Re: [PATCH 9/9] piix4: don't reserve hw resources when hotplug is off globally

On Mon, 14 Sep 2020 20:20:21 +0530 Ani Sinha wrote: > On Mon, Sep 14, 2020 at 7:39 PM Igor Mammedov wrote: > > > > On Mon, 14 Sep 2020 18:58:19 +0530 > > Ani Sinha wrote: > > > > > On Mon, Sep 14, 2020 at 6:40 PM Ani Sinha wrote: > > > > > > > > On Mon, Sep 14, 2020 at 6:36 PM Igor Mammedo

Re: Potential regression in 'qemu-img convert' to LVM

On 9/15/20 11:08 AM, Nir Soffer wrote: On Mon, Sep 14, 2020 at 3:25 PM Stefan Reiter wrote: Hi list, following command fails since 5.1 (tested on kernel 5.4.60): # qemu-img convert -p -f raw -O raw /dev/zvol/pool/disk-1 /dev/vg/disk-1 qemu-img: error while writing at byte 2157968896: Device

Re: [SPAM] Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug()

15.09.2020 14:43, Greg Kurz wrote: On Tue, 15 Sep 2020 13:58:53 +0300 Vladimir Sementsov-Ogievskiy wrote: 14.09.2020 15:35, Greg Kurz wrote: As recommended in "qapi/error.h", add a bool return value to spapr_add_lmbs() and spapr_add_nvdimm(), and use them instead of local_err in spapr_memory_

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

On Tue, Sep 15, 2020 at 7:44 PM Thomas Huth wrote: > On 13/09/2020 16.08, Paolo Bonzini wrote: > > On 13/09/20 00:44, Yonggang Luo wrote: > >> This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41. > >> > >> The --ninja option doesn't need anymore because of upgrade meson to > 0.55.2 > >>

[PATCH v2 0/2] fdmon-poll: reset npfd when upgrading to fdmon-epoll

v2: * Rebased onto qemu.git/master for meson Fix an assertion failure when aio_poll() is called in a aio_disable_external() region. The failure happens when fdmon-poll is first upgraded to fdmon-epoll and then downgraded again due to aio_disable_external(). Stefan Hajnoczi (2): fdmon-poll: res

[PATCH v2 2/2] tests: add test-fdmon-epoll

Test aio_disable_external(), which switches from fdmon-epoll back to fdmon-poll. This resulted in an assertion failure that was fixed in the previous patch. Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 1 + tests/test-fdmon-epoll.c | 73

[PATCH v2 1/2] fdmon-poll: reset npfd when upgrading to fdmon-epoll

npfd keeps track of how many pollfds are currently being monitored. It must be reset to 0 when fdmon_poll_wait() returns. When npfd reaches a treshold we switch to fdmon-epoll because it scales better. This patch resets npfd in the case where we switch to fdmon-epoll. Forgetting to do so results

Re: [PULL 00/22] Block patches

On Tue, 15 Sep 2020 at 11:46, Max Reitz wrote: > > The following changes since commit 2d2c73d0e3d504a61f868e46e6abd5643f38091b: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200914-1' into staging (2020-09-14 > 16:03:08 +0100) > > are available in the Git reposito

[PATCH v3] cphp: remove deprecated cpu-add command(s)

These were deprecated since 4.0, remove both HMP and QMP variants. Users should use device_add command instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov Reviewed-by: Thomas Huth Acked-by: Dr.

Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug()

I've dropped the SPAM mentions from the subject this time :) On Tue, 15 Sep 2020 14:53:53 +0300 Vladimir Sementsov-Ogievskiy wrote: > 15.09.2020 14:43, Greg Kurz wrote: > > On Tue, 15 Sep 2020 13:58:53 +0300 > > Vladimir Sementsov-Ogievskiy wrote: > > > >> 14.09.2020 15:35, Greg Kurz wrote: >

[PATCH v8 12/21] microvm/acpi: disable virtio-mmio cmdline hack

... in case we are using ACPI. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Reviewed-by: Sergio Lopez --- hw/i386/microvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index 54510a03f754..04209eb38fbe 100644 --- a/hw/i3

[PATCH v8 21/21] microvm: enable ramfb

Signed-off-by: Gerd Hoffmann --- hw/i386/microvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index 8de8ca864963..60d32722301f 100644 --- a/hw/i386/microvm.c +++ b/hw/i386/microvm.c @@ -39,6 +39,7 @@ #include "hw/timer/i8254.h" #include "hw/rtc/

[PATCH v8 01/21] microvm: name qboot binary qboot.rom

qboot isn't a bios and shouldnt be named that way. Signed-off-by: Gerd Hoffmann Reviewed-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/microvm.c | 4 ++-- pc-bios/meson.build | 2 +- pc-bios/{bios-microvm.bin => qboot.rom} | Bin

  1   2   3   4   5   >