Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

2020-09-14 Thread Yonggang Luo
On Sun, Sep 13, 2020 at 7:07 AM wrote: > > Patchew URL: https://patchew.org/QEMU/20200912224431.1428-1-luoyongg...@gmail.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > N/A. Internal error while reading log file > > > > The fu

Re: [PATCH v8 03/27] ci: fixes msys2 build by upgrading capstone to 4.0.2

2020-09-14 Thread Thomas Huth
On 13/09/2020 00.44, Yonggang Luo wrote: > The currently random version capstone have the following compiling issue: > CC /c/work/xemu/qemu/build/slirp/src/arp_table.o > make[1]: *** No rule to make target > “/c/work/xemu/qemu/build/capstone/capstone.lib”。 Stop. > > Subproject commit 1d230

Re: [PATCH v8 03/27] ci: fixes msys2 build by upgrading capstone to 4.0.2

2020-09-14 Thread Yonggang Luo
On Mon, Sep 14, 2020 at 3:10 PM Thomas Huth wrote: > > On 13/09/2020 00.44, Yonggang Luo wrote: > > The currently random version capstone have the following compiling issue: > > CC /c/work/xemu/qemu/build/slirp/src/arp_table.o > > make[1]: *** No rule to make target “/c/work/xemu/qemu/build

[PULL 04/10] tests: acpi: tolerate "virt/SSDT.memhp" mismatch temporarily

2020-09-14 Thread Philippe Mathieu-Daudé
From: Laszlo Ersek Tolerate "virt/SSDT.memhp" mismatch temporarily to let "check-qtest-aarch64" pass until we refresh the AML after advancing the edk2 submodule to tag edk2-stable202008. Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Philippe Mathieu-Daudé Ref: https://bugs.launchpad.net/qemu

[PULL 01/10] Makefile: remove obsolete edk2 exception from "clean" rule

2020-09-14 Thread Philippe Mathieu-Daudé
From: Laszlo Ersek The file "BaseTools/Source/Python/UPT/Dll/sqlite3.dll" was removed in edk2 commit 26e2b295ec7a ("BaseTools:Remove unused BaseTools\Source\Python\UPT\Dll", 2019-05-08), part of edk2-stable201905, so skipping it in the outermost in-tree "clean" rule is unnecessary. Remove the ob

[PULL 00/10] EDK2 firmware: Adopt the edk2-stable202008 release

2020-09-14 Thread Philippe Mathieu-Daudé
/edk2-next-20200914 for you to fetch changes up to 8fa3b7029f3c9f901cd6bb01004114c003432d9b: tests: acpi: update "virt/SSDT.memhp" for edk2-stable202008 (2020-09-13 23:03:15 +0200) EDK2 firmware: Adopt the edk2-stable

[PULL 02/10] roms/efirom, tests/uefi-test-tools: update edk2's own submodules first

2020-09-14 Thread Philippe Mathieu-Daudé
From: Laszlo Ersek In edk2 commit 06033f5abad3 ("BaseTools: Make brotli a submodule", 2020-04-16), part of edk2-stable202005, the Brotli compressor / decompressor source code that edk2 had flattened into BaseTools was replaced with a git submodule. This means we have to initialize edk2's own sub

[PULL 03/10] roms/Makefile.edk2: prepare for replacing TPM2*_ENABLE macros

2020-09-14 Thread Philippe Mathieu-Daudé
From: Laszlo Ersek Ekd2 commit 07952a962a40 ("OvmfPkg: rename TPM2 config prefix to TPM", 2020-03-04), part of edk2-stable202005, renamed OVMF's TPM2*_ENABLE build flags to TPM*_ENABLE. Going forward, the TPM*_ENABLE flags would activate both TPM1.2 and TPM2.0 support. In order to build OVMF at

[PULL 06/10] roms/Makefile.edk2: complete replacing TPM2*_ENABLE macros

2020-09-14 Thread Philippe Mathieu-Daudé
From: Laszlo Ersek At tag "edk2-stable202008", the TPM2_ENABLE and TPM2_CONFIG_ENABLE macros are useless (for IA32 and X64). Their roles have been absorbed by TPM_ENABLE and TPM_CONFIG_ENABLE, respectively. Remove the old build flags. Cc: Philippe Mathieu-Daudé Ref: https://bugs.launchpad.net/q

[PULL 10/10] tests: acpi: update "virt/SSDT.memhp" for edk2-stable202008

2020-09-14 Thread Philippe Mathieu-Daudé
From: Laszlo Ersek The NVDIMM_ACPI_MEM_ADDR dword in "virt/SSDT.memhp" needs an update due to the firmware now allocating NVDIMM_DSM_MEM_FILE at a lower address. > } > } > > -Name (MEMA, 0x43DD) > +Name (MEMA, 0x43D1) > } > Cc: "Michael S. Tsirkin" Cc: Igor Mamme

Re: [PATCH v6 2/7] hw/misc/led: Allow connecting from GPIO output

2020-09-14 Thread Luc Michel
On 9/12/20 3:40 PM, Philippe Mathieu-Daudé wrote: Some devices expose GPIO lines. Add a GPIO qdev input to our LED device, so we can connect a GPIO output using qdev_connect_gpio_out(). When used with GPIOs, the intensity can only be either minium or maximum. This depends of the polarity of the

[PULL 05/10] roms/edk2: update submodule from edk2-stable201905 to edk2-stable202008

2020-09-14 Thread Philippe Mathieu-Daudé
From: Laszlo Ersek Update the edk2 submodule from release edk2-stable201905 to edk2-stable202008. The release notes can be read at https://github.com/tianocore/edk2/releases/tag/edk2-stable201908 https://github.com/tianocore/edk2/releases/tag/edk2-stable201911 https://github.com/tianocore/

Re: [PATCH v6 6/7] hw/misc/mps2-scc: Use the LED device

2020-09-14 Thread Luc Michel
On 9/12/20 3:40 PM, Philippe Mathieu-Daudé wrote: Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical Reference Manual' (100112_0200_07_en): 2.1 Overview of the MPS2 and MPS2+ hardware The MPS2 and MPS2+ FPGA Prototyping Boards contain the following components and

Re: [PATCH] tests/qtest/qmp-cmd-test: Use inclusive language

2020-09-14 Thread Markus Armbruster
Paolo Bonzini writes: > On 12/09/20 09:49, Thomas Huth wrote: >> We simply want to ignore certain queries here, so let's rather >> use the term 'ignore' to express this intention. >> >> Signed-off-by: Thomas Huth >> --- >> tests/qtest/qmp-cmd-test.c | 10 +- >> 1 file changed, 5 insert

[PULL 07/10] roms/Makefile.edk2: enable new ARM/AARCH64 flags up to edk2-stable202008

2020-09-14 Thread Philippe Mathieu-Daudé
From: Laszlo Ersek Edk2 commit ffe048a0807b ("ArmVirtPkg: handle NETWORK_TLS_ENABLE in ArmVirtQemu*", 2019-06-28), part of edk2-stable201908, allows us to include the UEFI HTTPS Boot feature in the ArmVirtQemu fw platform (ARM and AARCH64). Edk2 commit range 4c0f6e349d32..0980779a9ddc, part of e

Re: [PATCH v6 5/7] hw/misc/mps2-fpgaio: Use the LED device

2020-09-14 Thread Luc Michel
On 9/12/20 3:40 PM, Philippe Mathieu-Daudé wrote: Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical Reference Manual' (100112_0200_07_en): 2.1 Overview of the MPS2 and MPS2+ hardware The MPS2 and MPS2+ FPGA Prototyping Boards contain the following components and

Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw

2020-09-14 Thread Thomas Huth
On 13/09/2020 00.44, Yonggang Luo wrote: > Fixes following tests on msys2/mingw > 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', > 'pkix_asn1_tab.c', >tasn1, crypto], > 'test-crypto-tlssession': ['crypto-tls-x509-helpers.c', > 'pkix_asn1_

Re: [PATCH v5 2/7] hw/misc/led: Allow connecting from GPIO output

2020-09-14 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Eduardo is already in Cc, adding Markus. > > On 9/12/20 12:44 AM, Richard Henderson wrote: >> On 9/10/20 1:54 PM, Philippe Mathieu-Daudé wrote: >>> Some devices expose GPIO lines. >>> >>> Add a GPIO qdev input to our LED device, so we can >>> connect a GPIO output

Re: [PATCH v8 16/27] cirrus: Building freebsd in a single short

2020-09-14 Thread Thomas Huth
On 13/09/2020 00.44, Yonggang Luo wrote: > This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba > ("cirrus.yml: Split FreeBSD job into two parts"). > > freebsd 1 hour limit not hit anymore > > I think we going to a wrong direction, I think there is some tests a stall > the test runner, >

[PULL 09/10] pc-bios: update the README file with edk2-stable202008 information

2020-09-14 Thread Philippe Mathieu-Daudé
From: Laszlo Ersek Refresh the "pc-bios/README" file with edk2 and OpenSSL release info, matching the edk2-stable202008 firmware images added in the previous patch. Cc: Philippe Mathieu-Daudé Ref: https://bugs.launchpad.net/qemu/+bug/1852196 Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Ma

Re: [PATCH] smp: drop support for deprecated (invalid topologies)

2020-09-14 Thread Igor Mammedov
On Fri, 11 Sep 2020 11:04:47 -0400 "Michael S. Tsirkin" wrote: > On Fri, Sep 11, 2020 at 09:32:02AM -0400, Igor Mammedov wrote: > > it's was deprecated since 3.1 > > > > Support for invalid topologies is removed, the user must ensure > > that topologies described with -smp include all possible c

Re: About 'qemu-security' mailing list

2020-09-14 Thread Philippe Mathieu-Daudé
On 9/11/20 5:51 PM, Peter Maydell wrote: > On Fri, 11 Sep 2020 at 15:22, P J P wrote: >> Proposal: (to address above limitations) >> = >> >> * We set up a new 'qemu-security' mailing list. >> >> * QEMU security issues are reported to this new list only. >> >> * Representatives from various

Re: [PATCH v8 24/27] ci: Enable msys2 ci in cirrus

2020-09-14 Thread Thomas Huth
On 13/09/2020 00.44, Yonggang Luo wrote: > Install msys2 in a proper way refer to > https://github.com/cirruslabs/cirrus-ci-docs/issues/699 > The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be > updated. I don't think that a request to update the wiki should be part of the c

Re: Does. there exists race condition in virtio-gpu device

2020-09-14 Thread Gerd Hoffmann
On Wed, Sep 09, 2020 at 08:49:25PM +0800, Li Qiang wrote: > Hello Gerd and Paolo, > > I think there is a race condition in virtio-gpu device. > In 'virtio_gpu_reset' and 'virtio_gpu_process_cmdq' they both operate > on 'g->cmdq'. > > However the 'virtio_gpu_reset' is in vcpu thread and the > 'vir

RE: [PATCH v1 2/2] colo-compare: Record packet creation time by QEMU_CLOCK_REALTIME

2020-09-14 Thread Zhang, Chen
From: Derek Su Sent: Monday, September 14, 2020 9:00 AM To: Zhang, Chen Cc: jasow...@redhat.com; lizhij...@cn.fujitsu.com; qemu-devel@nongnu.org Subject: Re: [PATCH v1 2/2] colo-compare: Record packet creation time by QEMU_CLOCK_REALTIME Zhang, Chen mailto:chen.zh...@intel.com>>於 2020年9月14日

[PATCH v2] cphp: remove deprecated cpu-add command(s)

2020-09-14 Thread Igor Mammedov
theses were deprecated since 4.0, remove both HMP and QMP variants. Users should use device_add command instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov Reviewed-by: Thomas Huth Acked-by: Dr.

Re: [PATCH v5 2/7] hw/misc/led: Allow connecting from GPIO output

2020-09-14 Thread Philippe Mathieu-Daudé
On 9/14/20 9:27 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Eduardo is already in Cc, adding Markus. >> >> On 9/12/20 12:44 AM, Richard Henderson wrote: >>> On 9/10/20 1:54 PM, Philippe Mathieu-Daudé wrote: Some devices expose GPIO lines. Add a GPIO qdev inpu

Re: [PATCH 2/5] hw/smbios: report error if table size is too large

2020-09-14 Thread Igor Mammedov
On Tue, 8 Sep 2020 17:54:35 +0100 Daniel P. Berrangé wrote: > The SMBIOS 2.1 entry point uses a uint16 data type for reporting the > total length of the tables. If the user passes -smbios configuration to > QEMU that causes the table size to exceed this limit then various bad > behaviours result

Re: [PATCH v2] cphp: remove deprecated cpu-add command(s)

2020-09-14 Thread Michal Privoznik
On 9/14/20 9:46 AM, Igor Mammedov wrote: theses were deprecated since 4.0, remove both HMP and QMP variants. Users should use device_add command instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammed

[PATCH v3 1/7] net/can: Initial host SocketCan support for CAN FD.

2020-09-14 Thread Pavel Pisa
From: Jan Charvat Signed-off-by: Jan Charvat Signed-off-by: Pavel Pisa Reviewed-by: Vikram Garhwal --- hw/net/can/can_sja1000.c | 2 ++ include/net/can_emu.h| 8 ++- net/can/can_socketcan.c | 47 +--- 3 files changed, 53 insertions(+), 4 deletion

[PATCH v3 0/7] CTU CAN FD core support

2020-09-14 Thread Pavel Pisa
CTU CAN FD is an open source soft core written in VHDL. It originated in 2015 as Ondrej Ille's project at the Department of Measurement of FEE at CTU. Integration for Xilinx Zynq and Intel based SoCs is available as well as support for PCIe integration of the core. The core sources https://git

[PATCH v3 3/7] net/can: Add can_dlc2len and can_len2dlc for CAN FD.

2020-09-14 Thread Pavel Pisa
From: Jan Charvat Signed-off-by: Jan Charvat Signed-off-by: Pavel Pisa Reviewed-by: Vikram Garhwal --- include/net/can_emu.h | 4 net/can/can_core.c| 36 2 files changed, 40 insertions(+) diff --git a/include/net/can_emu.h b/include/net/can_emu.

riscv32 wait() problem, qemu or glibc?

2020-09-14 Thread Andreas K . Hüttel
Hi, first of all, sorry for crossposting, but I'm dealing with many moving and experimental parts here... Situation: riscv32 (ilp32) qemu-user [1] chroot, Linux [2], glibc [3], gcc [4] The following small program outputs "child exited with status 40", which is rather unexpected (it should be

[PATCH v3 2/7] hw/net/can: sja1000 ignore CAN FD frames

2020-09-14 Thread Pavel Pisa
From: Jan Charvat Signed-off-by: Jan Charvat Signed-off-by: Pavel Pisa Reviewed-by: Vikram Garhwal --- hw/net/can/can_sja1000.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/hw/net/can/can_sja1000.c b/hw/net/can/can_sja1000.c index ec66d423

[PATCH v3 4/7] hw/net/can/ctucafd: Add CTU CAN FD core register definitions.

2020-09-14 Thread Pavel Pisa
From: Jan Charvat Definitions of registers and CAN FD frame message box of CTU CAN FD IP core are generated the specification in CACTUS/IP-XACT format. CTU CAN FD IP core repository https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core The location of the CTU CAN IP core specification within IP

[PATCH v3 7/7] hw/net/can: Correct Kconfig dependencies after switch to meson build.

2020-09-14 Thread Pavel Pisa
The original CAN_PCI config option enables multiple SJA1000 PCI boards emulation build. These boards bridge SJA1000 into I/O or memory address space of the host CPU and depend on SJA1000 emulation. Signed-off-by: Pavel Pisa --- hw/net/Kconfig | 7 +++ 1 file changed, 3 insertions(+), 4 delet

[PATCH v3 6/7] hw/net/can: Documentation for CTU CAN FD IP open hardware core emulation.

2020-09-14 Thread Pavel Pisa
Updated MAINTAINERS for CAN bus related emulation as well. Signed-off-by: Pavel Pisa --- MAINTAINERS | 9 docs/can.txt | 113 ++- 2 files changed, 111 insertions(+), 11 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index cf96fa8379..

Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw

2020-09-14 Thread Yonggang Luo
On Mon, Sep 14, 2020 at 3:23 PM Thomas Huth wrote: > > On 13/09/2020 00.44, Yonggang Luo wrote: > > Fixes following tests on msys2/mingw > > 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', 'pkix_asn1_tab.c', > >tasn1, crypto], > > 'test-cry

[PATCH v3 5/7] hw/net/can: CTU CAN FD IP open hardware core emulation.

2020-09-14 Thread Pavel Pisa
From: Jan Charvat The implementation of the model of complete open-source/design/hardware CAN FD controller. The IP core project has been started and is maintained by Ondrej Ille at Czech Technical University in Prague. CTU CAN FD project pages: https://gitlab.fel.cvut.cz/canbus/ctucanfd

Re: [PATCH v8 24/27] ci: Enable msys2 ci in cirrus

2020-09-14 Thread Stefan Weil
Am 14.09.20 um 09:38 schrieb Thomas Huth: > On 13/09/2020 00.44, Yonggang Luo wrote: >> Install msys2 in a proper way refer to >> https://github.com/cirruslabs/cirrus-ci-docs/issues/699 >> The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be >> updated. > I don't think that a

[PATCH v5 4/8] qapi: Implement deprecated-output=hide for QMP event data

2020-09-14 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP event data: suppress deprecated members. No QMP event data is deprecated right now. Signed-off-by: Markus Armbruster --- tests/test-qmp-event.c | 21 ++

[PATCH v5 3/8] qapi: Implement deprecated-output=hide for QMP events

2020-09-14 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP events: suppress deprecated ones. No QMP event is deprecated right now. Signed-off-by: Markus Armbruster --- tests/test-qmp-event.c | 20 scripts/qapi/events.py |

[PATCH v5 5/8] qapi: Implement deprecated-output=hide for QMP introspection

2020-09-14 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP command query-qmp-schema: suppress information on deprecated commands, events and object type members, i.e. anything that has the special feature flag "deprecated". Signed-off-by: Markus

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

2020-09-14 Thread Paolo Bonzini
On 13/09/20 18:14, 罗勇刚(Yonggang Luo) wrote: > I am hurry to revert --ninja option because when the meson are changed, the > make -j10 can not automatically re configure, that would raise ninja can > not found error  My understanding is that with 0.55.2 you don't need --ninja at all (the default se

[PATCH v5 8/8] qapi: New -compat deprecated-input=crash

2020-09-14 Thread Markus Armbruster
Policy "crash" calls abort() when deprecated input is received. Bugs in integration tests may mask the error from policy "reject". Provide a larger hammer: crash outright. Masking that seems unlikely. Signed-off-by: Markus Armbruster --- qapi/compat.json | 3 ++- qapi/qmp-dispatch.

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

2020-09-14 Thread Yonggang Luo
On Mon, Sep 14, 2020 at 4:45 PM Paolo Bonzini wrote: > > On 13/09/20 18:14, 罗勇刚(Yonggang Luo) wrote: > > I am hurry to revert --ninja option because when the meson are changed, the > > make -j10 can not automatically re configure, that would raise ninja can > > not found error > > My understanding

[PATCH v5 1/8] qemu-options: New -compat to set policy for deprecated interfaces

2020-09-14 Thread Markus Armbruster
Policy is separate for input and output. Input policy can be "accept" (accept silently), or "reject" (reject the request with an error). Output policy can be "accept" (pass on unchanged), or "hide" (filter out the deprecated parts). Default is "accept". Policies other than "accept" are implemen

[PATCH v5 6/8] qapi: Implement deprecated-input=reject for QMP commands

2020-09-14 Thread Markus Armbruster
This policy rejects deprecated input, and thus permits "testing the future". Implement it for QMP commands: make deprecated ones fail. Example: when QEMU is run with -compat deprecated-input=reject, then {"execute": "query-cpus"} fails like this {"error": {"class": "CommandNotFound", "d

[PATCH v5 2/8] qapi: Implement deprecated-output=hide for QMP command results

2020-09-14 Thread Markus Armbruster
This policy suppresses deprecated bits in output, and thus permits "testing the future". Implement it for QMP command results. Example: when QEMU is run with -compat deprecated-output=hide, then {"execute": "query-cpus-fast"} yields {"return": [{"thread-id": 9805, "props": {"core-id":

Re: [PATCH v8 16/27] cirrus: Building freebsd in a single short

2020-09-14 Thread Philippe Mathieu-Daudé
On 9/14/20 9:27 AM, Thomas Huth wrote: > On 13/09/2020 00.44, Yonggang Luo wrote: >> This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba >> ("cirrus.yml: Split FreeBSD job into two parts"). >> >> freebsd 1 hour limit not hit anymore >> >> I think we going to a wrong direction, I think ther

[PATCH v5 7/8] qapi: Implement deprecated-input=reject for QMP command arguments

2020-09-14 Thread Markus Armbruster
This policy rejects deprecated input, and thus permits "testing the future". Implement it for QMP command arguments: reject commands with deprecated ones. Example: when QEMU is run with -compat deprecated-input=reject, then {"execute": "eject", "arguments": {"device": "cd"}} fails like this

[PATCH v8 01/12] migration/dirtyrate: setup up query-dirtyrate framwork

2020-09-14 Thread Chuan Zheng
Add get_dirtyrate_thread() functions to setup query-dirtyrate framework. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang Reviewed-by: Dr. David Alan Gilbert Reviewed-by: David Edmondson --- migration/dirtyrate.c | 38 ++ migration/dirtyrate.h | 29

[PATCH v8 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function

2020-09-14 Thread Chuan Zheng
Implement calculate_dirtyrate() function. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang Reviewed-by: Dr. David Alan Gilbert --- migration/dirtyrate.c | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/migration/dirtyrat

[PATCH v8 03/12] migration/dirtyrate: Add RamblockDirtyInfo to store sampled page info

2020-09-14 Thread Chuan Zheng
Add RamblockDirtyInfo to store sampled page info of each ramblock. Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert Reviewed-by: David Edmondson --- migration/dirtyrate.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/migration/dirtyrate.h b/migration/dir

[PATCH v8 05/12] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h

2020-09-14 Thread Chuan Zheng
RAMBLOCK_FOREACH_MIGRATABLE is need in dirtyrate measure, move the existing definition up into migration/ram.h Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert Reviewed-by: David Edmondson --- migration/dirtyrate.c | 1 + migration/ram.c | 11 +-- migration/ram.h

[PATCH v5 0/8] Configurable policy for handling deprecated interfaces

2020-09-14 Thread Markus Armbruster
New option -compat lets you configure what to do when deprecated interfaces get used. This is intended for testing users of the management interfaces. It is experimental. -compat deprecated-input= configures what to do when deprecated input is received. Available policies: * accept: Accept dep

[PATCH v8 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status

2020-09-14 Thread Chuan Zheng
add DirtyRateStatus to denote calculating status. Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/dirtyrate.c | 26 ++ qapi/migration.json | 17 + 2 files changed, 43 insertions(+) diff --git a/migration/dirtyrate.c b/migra

[PATCH v8 07/12] migration/dirtyrate: Compare page hash results for recorded sampled page

2020-09-14 Thread Chuan Zheng
Compare page hash results for recorded sampled page. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang Reviewed-by: Dr. David Alan Gilbert --- migration/dirtyrate.c | 63 +++ 1 file changed, 63 insertions(+) diff --git a/migration/dirtyra

[PATCH v8 09/12] migration/dirtyrate: Implement set_sample_page_period() and is_sample_period_valid()

2020-09-14 Thread Chuan Zheng
Implement is_sample_period_valid() to check if the sample period is vaild and do set_sample_page_period() to sleep specific time between sample actions. Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert Reviewed-by: David Edmondson --- migration/dirtyrate.c | 24 ++

[PATCH v8 04/12] migration/dirtyrate: Add dirtyrate statistics series functions

2020-09-14 Thread Chuan Zheng
Add dirtyrate statistics functions to record/update dirtyrate info. Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/dirtyrate.c | 32 migration/dirtyrate.h | 12 2 files changed, 44 insertions(+) diff --git a/migration/

[PATCH v8 00/12] *** A Method for evaluating dirty page rate ***

2020-09-14 Thread Chuan Zheng
v7 -> v8: add atomic_read for dirtyrate status add error_report if set dirtyrate state failed change returns of save_ramblock_hash and record_ramblock_hash_info to bool alloc ramblock dirtyinfo array at one time add review-by for patches v6 -> v7: fix minior comments and co

[PATCH v8 06/12] migration/dirtyrate: Record hash results for each sampled page

2020-09-14 Thread Chuan Zheng
Record hash results for each sampled page, crc32 is taken to calculate hash results for each sampled length in TARGET_PAGE_SIZE. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang Reviewed-by: David Edmondson --- migration/dirtyrate.c | 111 +++

[PATCH v8 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE

2020-09-14 Thread Chuan Zheng
In order to sample real RAM, skip ramblock with size below MIN_RAMBLOCK_SIZE which is set as 128M. Signed-off-by: Chuan Zheng Reviewed-by: David Edmondson Reviewed-by: Dr. David Alan Gilbert --- migration/dirtyrate.c | 21 + migration/dirtyrate.h | 5 + 2 files changed

[PATCH v8 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

2020-09-14 Thread Chuan Zheng
Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be called Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 62 +++ qapi/migration.json | 50 + 2 files changed, 112 insertions

[PATCH v8 12/12] migration/dirtyrate: Add trace_calls to make it easier to debug

2020-09-14 Thread Chuan Zheng
Add trace_calls to make it easier to debug Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert Reviewed-by: David Edmondson --- migration/dirtyrate.c | 9 + migration/trace-events | 8 2 files changed, 17 insertions(+) diff --git a/migration/dirtyrate.c b/migratio

Re: [PATCH v3 6/6] migration/tls: add trace points for multifd-tls

2020-09-14 Thread Daniel P . Berrangé
On Sun, Sep 13, 2020 at 10:47:36AM +0800, Chuan Zheng wrote: > add trace points for multifd-tls for debug. > > Signed-off-by: Chuan Zheng > Signed-off-by: Yan Jin > --- > migration/multifd.c| 10 +- > migration/trace-events | 4 > 2 files changed, 13 insertions(+), 1 deletion(

Re: About 'qemu-security' mailing list

2020-09-14 Thread Daniel P . Berrangé
On Fri, Sep 11, 2020 at 04:51:49PM +0100, Peter Maydell wrote: > On Fri, 11 Sep 2020 at 15:22, P J P wrote: > > Proposal: (to address above limitations) > > = > > > > * We set up a new 'qemu-security' mailing list. > > > > * QEMU security issues are reported to this new list only. > > > >

Re: [PATCH v3 1/6] migration/tls: save hostname into MigrationState

2020-09-14 Thread Daniel P . Berrangé
On Sun, Sep 13, 2020 at 10:47:31AM +0800, Chuan Zheng wrote: > hostname is need in multifd-tls, save hostname into MigrationState. > > Signed-off-by: Chuan Zheng > Signed-off-by: Yan Jin > --- > migration/channel.c | 6 ++ > migration/migration.c | 1 + > migration/migration.h | 5 + >

Re: [PATCH v3 3/6] migration/tls: add MigrationState and tls_hostname into MultiFDSendParams

2020-09-14 Thread Daniel P . Berrangé
On Sun, Sep 13, 2020 at 10:47:33AM +0800, Chuan Zheng wrote: > MigrationState is need for tls session build and tls hostname is need > for tls handshake, add both MigrationState and tls_hostname > into MultiFDSendParams. > > Signed-off-by: Chuan Zheng > Signed-off-by: Yan Jin > --- > migration/

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-14 Thread Daniel P . Berrangé
On Sun, Sep 13, 2020 at 12:05:31PM +0200, Paolo Bonzini wrote: > Right now meson_options.txt lists less than a dozen options, but about > 40 more could come as configure tests are converted and moved to > meson.build. Each option needs code in configure to parse it and pass > the option down to Me

Re: [PATCH] hw/scsi/vmw_pvscsi.c: Fix wrong usage of gboolean types in PVSCSIState

2020-09-14 Thread Amey Narkhede
On 20/09/14 08:32AM, Philippe Mathieu-Daudé wrote: > Hi Amey, > > On 9/14/20 1:44 AM, Amey Narkhede wrote: > > rings_info_valid, msg_ring_info_valid and use_msg fields of struct > > PVSCSIState are using gboolean TRUE/FALSE values with the type uint8_t. > > Change their type to bool along with the

Re: [PATCH v5 1/8] qapi: Restrict LostTickPolicy enum to machine code

2020-09-14 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Acked-by: Markus Armbruster > Acked-by: Paolo Bonzini > Signed-off-by: Philippe Mathieu-Daudé Unlike the other patches that move code out of misc.json, this one doesn't say "allows pulling less declarations/definitions to user-mode." Intentional?

Re: [PATCH v5 3/8] qapi: Restrict balloon-related commands to machine code

2020-09-14 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Only qemu-system-FOO and qemu-storage-daemon provide QMP > monitors, therefore such declarations and definitions are > irrelevant for user-mode emulation. > > Restricting the balloon-related commands to machine.json > allows pulling less declarations/definitions t

Re: [PATCH] tests/check-block: Do not run the iotests with old versions of bash

2020-09-14 Thread Max Reitz
On 12.09.20 14:14, Thomas Huth wrote: > macOS is shipped with a very old version of the bash (3.2), which > is currently not suitable for running the iotests anymore. Add > a check to skip the iotests in this case - if someone still wants > to run the iotests on macOS, they can install a newer vers

Re: [PATCH v3 3/6] migration/tls: add MigrationState and tls_hostname into MultiFDSendParams

2020-09-14 Thread Zheng Chuan
On 2020/9/14 17:02, Daniel P. Berrangé wrote: > On Sun, Sep 13, 2020 at 10:47:33AM +0800, Chuan Zheng wrote: >> MigrationState is need for tls session build and tls hostname is need >> for tls handshake, add both MigrationState and tls_hostname >> into MultiFDSendParams. >> >> Signed-off-by: Chu

Re: [PATCH v3 3/6] migration/tls: add MigrationState and tls_hostname into MultiFDSendParams

2020-09-14 Thread Daniel P . Berrangé
On Mon, Sep 14, 2020 at 05:20:14PM +0800, Zheng Chuan wrote: > > > On 2020/9/14 17:02, Daniel P. Berrangé wrote: > > On Sun, Sep 13, 2020 at 10:47:33AM +0800, Chuan Zheng wrote: > >> MigrationState is need for tls session build and tls hostname is need > >> for tls handshake, add both MigrationSt

Re: About 'qemu-security' mailing list

2020-09-14 Thread Peter Maydell
On Mon, 14 Sep 2020 at 09:55, Daniel P. Berrangé wrote: > Do we think the current QEMU security process is working well for the > community as a whole in terms of our downstream consumers learning about > security flaws in an appropriate timeframe and manner ? That sounds like a question we shoul

Re: [PATCH] qemu-img: Support bitmap --merge into backing image

2020-09-14 Thread Max Reitz
On 11.09.20 17:17, Eric Blake wrote: > On 9/11/20 3:31 AM, Max Reitz wrote: >> On 09.09.20 14:33, Eric Blake wrote: >>> If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a >>> bitmap from top into base, qemu-img was failing with: >>> >>> qemu-img: Could not open 'top.qcow2': Could n

Re: [PATCH v3 3/6] migration/tls: add MigrationState and tls_hostname into MultiFDSendParams

2020-09-14 Thread Zheng Chuan
On 2020/9/14 17:26, Daniel P. Berrangé wrote: > On Mon, Sep 14, 2020 at 05:20:14PM +0800, Zheng Chuan wrote: >> >> >> On 2020/9/14 17:02, Daniel P. Berrangé wrote: >>> On Sun, Sep 13, 2020 at 10:47:33AM +0800, Chuan Zheng wrote: MigrationState is need for tls session build and tls hostname

Re: [PATCH] tests/check-block: Do not run the iotests with old versions of bash

2020-09-14 Thread Yonggang Luo
On Sat, Sep 12, 2020 at 8:16 PM Thomas Huth wrote: > > macOS is shipped with a very old version of the bash (3.2), which > is currently not suitable for running the iotests anymore. Add > a check to skip the iotests in this case - if someone still wants > to run the iotests on macOS, they can inst

Re: [PATCH v5 1/8] qapi: Restrict LostTickPolicy enum to machine code

2020-09-14 Thread Philippe Mathieu-Daudé
+Laurent + qemu-block@ On 9/14/20 11:14 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Acked-by: Markus Armbruster >> Acked-by: Paolo Bonzini >> Signed-off-by: Philippe Mathieu-Daudé > > Unlike the other patches that move code out of misc.json, this one > doesn't say "all

Re: [PATCH v5 3/8] qapi: Restrict balloon-related commands to machine code

2020-09-14 Thread Philippe Mathieu-Daudé
+Laurent and David On 9/14/20 11:16 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Only qemu-system-FOO and qemu-storage-daemon provide QMP >> monitors, therefore such declarations and definitions are >> irrelevant for user-mode emulation. >> >> Restricting the balloon-relate

Re: [Bug 1895471] [NEW] compilation error with clang in util/async.c

2020-09-14 Thread Stefan Hajnoczi
On Sun, Sep 13, 2020 at 06:56:12PM -, Amey Narkhede wrote: > configured with ` CC=clang CXX=clang++ ../configure --target- > list=x86_64-softmmu --enable-kvm --enable-curl --enable-debug --enable- > jemalloc --enable-fuzzing --enable-sdl` and after make I get the > following error related to c1

Re: [PATCH v5 3/8] qapi: Restrict balloon-related commands to machine code

2020-09-14 Thread David Hildenbrand
> Am 14.09.2020 um 11:42 schrieb Philippe Mathieu-Daudé : > > +Laurent and David > >> On 9/14/20 11:16 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Only qemu-system-FOO and qemu-storage-daemon provide QMP >>> monitors, therefore such declarations and definitions are

[PATCH 0/3] configure: add missing CONFIG_FOO variables

2020-09-14 Thread Stefan Hajnoczi
The meson.build feature summary checks the presence of CONFIG_FOO variables. Several of these variables are never emitted by ./configure so the feature summary always shows these features as disabled. Stefan Hajnoczi (3): configure: add missing CONFIG_TCMALLOC configure: add missing CONFIG_JEM

[PATCH 1/3] configure: add missing CONFIG_TCMALLOC

2020-09-14 Thread Stefan Hajnoczi
The feature summary in meson.build checks for CONFIG_TCMALLOC: summary_info += {'tcmalloc support': config_host.has_key('CONFIG_TCMALLOC')} Nothing emits CONFIG_TCMALLOC in ./configure so this feature appears disabled even if it has been enabled. Signed-off-by: Stefan Hajnoczi --- configure

[PATCH 3/3] configure: rename QEMU_GA_MSI_ENABLED to CONFIG_QGA_MSI

2020-09-14 Thread Stefan Hajnoczi
The QEMU_GA_MSI_ENABLED config-host.mak variable is emitted by ./configure. meson.build actually checks for CONFIG_QGA_MSI_ENABLED: summary_info += {'QGA MSI support': config_host.has_key('CONFIG_QGA_MSI_ENABLED')} Rename QEMU_GA_MSI_ENABLED to CONFIG_QGA_MSI for consistency with CONFIG_QGA_

[PATCH 2/3] configure: add missing CONFIG_JEMALLOC

2020-09-14 Thread Stefan Hajnoczi
The feature summary in meson.build checks for CONFIG_JEMALLOC: summary_info += {'jemalloc support': config_host.has_key('CONFIG_JEMALLOC')} Nothing emits CONFIG_JEMALLOC in ./configure so this feature appears disabled even if it has been enabled. Signed-off-by: Stefan Hajnoczi --- configure

Re: [PATCH 08/10] pc-bios: refresh edk2 build artifacts for edk2-stable202008

2020-09-14 Thread Gerd Hoffmann
Hi, > The CI idea is to have reproducible builds if possible. > When the submodule is updated (or the QEMU scripts containing the > -D defines), it triggers the 'build-edk2' job which produce these > same binaries. > My original idea was to push the tag on GitLab that triggers the > job, then do

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-14 Thread Stefan Hajnoczi
On Sun, Sep 13, 2020 at 12:05:31PM +0200, Paolo Bonzini wrote: > - because we parse command-line options before meson is available, > the introspection output is stored in the source tree. The output > is slightly modified using the "jq" tool in order to ensure that it's > stable and that modifica

Re: [PATCH] meson: clean up build_by_default

2020-09-14 Thread Max Reitz
On 11.09.20 15:42, Paolo Bonzini wrote: > Build all executables by default except for the known-broken ones. > > This also allows running qemu-iotests without manually building > socket_scm_helper. > > Reported-by: Max Reitz > Signed-off-by: Paolo Bonzini > --- > docs/devel/build-system.rst

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-14 Thread Yonggang Luo
On Mon, Sep 14, 2020 at 5:58 PM Stefan Hajnoczi wrote: > > On Sun, Sep 13, 2020 at 12:05:31PM +0200, Paolo Bonzini wrote: > > - because we parse command-line options before meson is available, > > the introspection output is stored in the source tree. The output > > is slightly modified using the

[PATCH] ui: Fix default window_id value

2020-09-14 Thread Samuel Thibault
./chardev/baum.c expects the default window_id value to be -1, and not 0 which could be confused with a proper window id (when numbered from 0 by the ui backend). This fixes getting Braille output with the curses and gtk frontends. Signed-off-by: Samuel Thibault --- It would be useful to backpo

Re: [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto'

2020-09-14 Thread Stefan Hajnoczi
On Sat, Sep 12, 2020 at 04:53:54PM -, Harry Coin wrote: > Public bug reported: > > The usage command line for virtiofsd has: > > void fuse_cmdline_help(void) > { > printf("-h --helpprint help\n" > ... >"-o cache=cache mode. could be one of

Re: [PATCH v2] cphp: remove deprecated cpu-add command(s)

2020-09-14 Thread Igor Mammedov
On Mon, 14 Sep 2020 10:07:36 +0200 Michal Privoznik wrote: > On 9/14/20 9:46 AM, Igor Mammedov wrote: > > theses were deprecated since 4.0, remove both HMP and QMP variants. > > > > Users should use device_add command instead. To get list of > > possible CPUs and options, use 'info hotpluggable-

Re: About 'qemu-security' mailing list

2020-09-14 Thread Stefan Hajnoczi
On Fri, Sep 11, 2020 at 04:51:49PM +0100, Peter Maydell wrote: > It sounds like you > want it to be a larger grouping than that and maybe also > want to use it as a mechanism for informing downstream distros > etc about QEMU security issues, which is to say you're > proposing an overhaul and change

Re: About 'qemu-security' mailing list

2020-09-14 Thread Stefan Hajnoczi
On Mon, Sep 14, 2020 at 09:38:07AM +0200, Philippe Mathieu-Daudé wrote: > I don't think so, as I took care to encrypt a bug report and > received the reply unencrypted =) Not sure this is the default > although, as this was my unique experience following the security > process. Hopefully a one-tim

Re: [PATCH] seccomp: fix killing of whole process instead of thread

2020-09-14 Thread Stefan Hajnoczi
On Fri, Sep 11, 2020 at 03:18:32PM +0100, Daniel P. Berrangé wrote: > Back in 2018 we introduced support for killing the whole QEMU process > instead of just one thread, when a seccomp rule is violated: > > commit bda08a5764d470f101fa38635d30b41179a313e1 > Author: Marc-André Lureau > Date:

[PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-09-14 Thread Philippe Mathieu-Daudé
As the 'io_base' argument of m48t59_init() is unused (set to 0), remove it to simplify. To create a device on the ISA bus, m48t59_init_isa() is the preferred function to use. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/rtc/m48t59.h | 2 +- hw/ppc/ppc405_boards.c | 2 +- hw/rtc/m48t59

[Bug 1895053] Re: Cannot nspawn raspbian 10 [FAILED] Failed to start Journal Service.

2020-09-14 Thread Laurent Vivier
What is the result of the following command? for file in /proc/sys/fs/binfmt_misc/* ; do echo "$file"; cat $file; done -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895053 Title: Cannot nspawn ra

  1   2   3   4   5   >