[PATCH 0/6] misc: Some inclusive terminology changes

We don't have (yet?) inclusive terminology guidelines, but the PCI hole memory is not "black", the DMA sources don't stream to "slaves", and there isn't really a TSX "black" list, we only check for broken fields. As this terms can be considered offensive, and changing them is a no-brain operation,

[PATCH 1/6] hw/ssi/aspeed_smc: Rename max_slaves as max_devices

In order to use inclusive terminology, rename max_slaves as max_devices. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ssi/aspeed_smc.h | 2 +- hw/ssi/aspeed_smc.c | 40 ++--- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/include

[PATCH 5/6] hw/pci-host/q35: Rename PCI 'black hole as '(memory) hole'

In order to use inclusive terminology, rename "blackhole" as "(memory)hole". Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci-host/q35.h | 4 ++-- hw/pci-host/q35.c | 38 +++--- tests/qtest/q35-test.c| 2 +- 3 files changed, 22 insertions(+),

[PATCH 2/6] hw/core/stream: Rename StreamSlave as StreamSink

In order to use inclusive terminology, rename 'slave stream' as 'sink stream'. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ssi/xilinx_spips.h | 2 +- include/hw/stream.h | 46 +-- hw/core/stream.c | 20 +++ hw/dma/xilin

Re: [PATCH 1/6] hw/ssi/aspeed_smc: Rename max_slaves as max_devices

On 10/09/2020 09.01, Philippe Mathieu-Daudé wrote: > In order to use inclusive terminology, rename max_slaves > as max_devices. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/ssi/aspeed_smc.h | 2 +- > hw/ssi/aspeed_smc.c | 40 ++--- > 2 fil

[PATCH 3/6] hw/dma/xilinx_axidma: Rename StreamSlave as StreamSink

In order to use inclusive terminology, rename 'slave stream' as 'sink stream'. Signed-off-by: Philippe Mathieu-Daudé --- hw/dma/xilinx_axidma.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c index c

Re: [PATCH v2 01/21] block: Fixes nfs compiling error on msys2/mingw

> Am 09.09.2020 um 11:45 schrieb Yonggang Luo : > > These compiling errors are fixed: > ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory > 27 | #include > | ^~~~ > compilation terminated. > > ../block/nfs.c:63:5: error: unknown type name 'blkcnt_t' >

Re: [PATCH 2/6] hw/core/stream: Rename StreamSlave as StreamSink

On 9/10/20 9:01 AM, Philippe Mathieu-Daudé wrote: > In order to use inclusive terminology, rename 'slave stream' > as 'sink stream'. > > Signed-off-by: Philippe Mathieu-Daudé > --- [...] > diff --git a/include/hw/stream.h b/include/hw/stream.h > index ed09e83683d..8ca161991ca 100644 > --- a/inclu

[PATCH 4/6] hw/net/xilinx_axienet: Rename StreamSlave as StreamSink

In order to use inclusive terminology, rename 'slave stream' as 'sink stream'. Signed-off-by: Philippe Mathieu-Daudé --- hw/net/xilinx_axienet.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/net/xilinx_axienet.c b/hw/net/xilinx_axienet.c index

Re: [PATCH 6/6] target/i386/kvm: Rename host_tsx_blacklisted() as host_tsx_broken()

On 10/09/2020 09.01, Philippe Mathieu-Daudé wrote: > In order to use inclusive terminology, rename host_tsx_blacklisted() > as host_tsx_broken(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/i386/kvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/targ

[PATCH 6/6] target/i386/kvm: Rename host_tsx_blacklisted() as host_tsx_broken()

In order to use inclusive terminology, rename host_tsx_blacklisted() as host_tsx_broken(). Signed-off-by: Philippe Mathieu-Daudé --- target/i386/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 205b68bc0ce..3d640a8decf 1006

Re: [PATCH v2 01/21] block: Fixes nfs compiling error on msys2/mingw

On Thu, Sep 10, 2020 at 3:01 PM Peter Lieven wrote: > > > > Am 09.09.2020 um 11:45 schrieb Yonggang Luo : > > > > These compiling errors are fixed: > > ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory > > 27 | #include > > | ^~~~ > > compilation terminated

Re: [PATCH 5/6] hw/pci-host/q35: Rename PCI 'black hole as '(memory) hole'

On 10/09/2020 09.01, Philippe Mathieu-Daudé wrote: > In order to use inclusive terminology, rename "blackhole" > as "(memory)hole". A black hole is a well-known astronomical term, which is simply named that way since it absorbes all light. I doubt that anybody could get upset by this term? > Sign

Re: [PATCH 0/4] hw/sd/sdhci: Strengthen multiple DMA transfers

On 9/3/20 7:28 PM, Philippe Mathieu-Daudé wrote: > Still trying to fix the bugs reported by Aleksander... > > - Do not send 0 block count > - Reduce DMA to MMIO re-entrancy by yielding when pending IRQ > > Based-on: <20200901140411.112150-1-f4...@amsat.org> > > Philippe Mathieu-Daudé (4): > hw

[PATCH v2 1/2] hw/gpio/max7310: Remove impossible check

The max7310_gpio_set() handler is static and only used by qdev_init_gpio_in, initialized with 8 IRQs. The 'line' argument can not be out of the [0-8[ range. Replace the dead code by an assertion. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/gpio/max7310.c | 5 +

[PATCH v2 2/2] hw/ppc/ppc4xx_pci: Replace magic value by the PCI_NUM_PINS definition

Replace the magic '4' value by the PCI_NUM_PINS definition. Suggested-by: Cédric Le Goater Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/ppc4xx_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/ppc4xx_pci.c b/hw/ppc/ppc4xx_pci.c index 503ef46b39a..930be78361d 1

[PATCH v2 0/2] hw: Replace some impossible checks by assertions

Trivial patches removing unreachable code. Since v1: - dropped patches queued - replace dead code by assert (Peter) - use PCI_NUM_PINS definition (Cédric) Philippe Mathieu-Daudé (2): hw/gpio/max7310: Remove impossible check hw/ppc/ppc4xx_pci: Replace magic value by the PCI_NUM_PINS definition

Re: [PATCH v2 01/21] block: Fixes nfs compiling error on msys2/mingw

> Am 10.09.2020 um 09:14 schrieb 罗勇刚(Yonggang Luo) : > > > > On Thu, Sep 10, 2020 at 3:01 PM Peter Lieven wrote: > > > > Am 09.09.2020 um 11:45 schrieb Yonggang Luo : > > > > These compiling errors are fixed: > > ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory > > 2

Re: [PATCH 5/6] hw/pci-host/q35: Rename PCI 'black hole as '(memory) hole'

On 9/10/20 9:15 AM, Thomas Huth wrote: > On 10/09/2020 09.01, Philippe Mathieu-Daudé wrote: >> In order to use inclusive terminology, rename "blackhole" >> as "(memory)hole". > > A black hole is a well-known astronomical term, which is simply named > that way since it absorbes all light. I doubt t

Re: [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

On 9/4/20 6:57 PM, Philippe Mathieu-Daudé wrote: > Hi, > > On 12/17/19 7:43 PM, Aleksandar Markovic wrote: >> From: Thomas Huth >> Sent: Tuesday, December 17, 2019 7:10 PM >> To: Philippe Mathieu-Daudé; qemu-devel@nongnu.org >> Cc: libvir-l...@redhat.com; Hervé Poussineau; Aleksandar Markovic; >

Re: [RFC] QEMU as Xcode project on macOS

On Wed, Sep 09, 2020 at 08:56:48PM +0200, Christian Schoenebeck wrote: > On Mittwoch, 9. September 2020 20:13:55 CEST Daniel P. Berrangé wrote: > > > On Mittwoch, 9. September 2020 15:40:05 CEST Daniel P. Berrangé wrote: > > > > Ideally any xcode setup would just invoke whatever our standard > > >

Re: [PATCH 0/6] misc: Some inclusive terminology changes

Le 10/09/2020 à 09:01, Philippe Mathieu-Daudé a écrit : > We don't have (yet?) inclusive terminology guidelines, > but the PCI hole memory is not "black", the DMA sources > don't stream to "slaves", and there isn't really a TSX > "black" list, we only check for broken fields. > > As this terms can

Re: [PATCH v6 25/25] meson: guard the minimal meson version to 0.55.1

On Thu, Sep 10, 2020 at 02:42:37AM +0800, Yonggang Luo wrote: > So we can removal usage of unstable-keyval > > Signed-off-by: Yonggang Luo > --- > meson.build | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) This prevents the use on Fedora which has 0.55.0 only. This is not desi

Re: [PATCH v2 2/2] hw/ppc/ppc4xx_pci: Replace magic value by the PCI_NUM_PINS definition

On Thu, Sep 10, 2020 at 09:23:25AM +0200, Philippe Mathieu-Daudé wrote: > Replace the magic '4' value by the PCI_NUM_PINS definition. > > Suggested-by: Cédric Le Goater > Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson > --- > hw/ppc/ppc4xx_pci.c | 2 +- > 1 file changed, 1 inse

[PULL v2 5/8] scripts/cleanup-trace-events: Fix for vcpu property

From: Markus Armbruster Commit a44cf524f8 "scripts/cleanup-trace-events: Update for current practice" limited search to the input file's directory. That's wrong for events with the vcpu property, because these can only be defined in root directory. Signed-off-by: Markus Armbruster Message-id:

[PULL v2 0/8] Tracing patches

The following changes since commit 9435a8b3dd35f1f926f1b9127e8a906217a5518a: Merge remote-tracking branch 'remotes/kraxel/tags/sirius/ipxe-20200908-pull-request' into staging (2020-09-08 21:21:13 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/traci

[PULL v2 1/8] softmmu: Add missing trace-events file

From: Philippe Mathieu-Daudé Commit c7f419f584 moved softmmu-only files out of the root directory, but forgot to move the trace events, which should no longer be generated to "trace-root.h". Fix that by adding softmmu/trace-events. Signed-off-by: Philippe Mathieu-Daudé Tested-by: Claudio Fontan

[PULL v2 2/8] scripts/tracetool: Fix dtrace generation for macOS

From: Roman Bolshakov dtrace USDT is fully supported since OS X 10.6. There are a few peculiarities compared to other dtrace flavors. 1. It doesn't accept empty files. 2. It doesn't recognize bool type but accepts C99 _Bool. 3. It converts int8_t * in probe points to char * in header files an

[PULL v2 3/8] scripts/tracetool: Use void pointer for vcpu

From: Roman Bolshakov dtrace on macOS complains that CPUState * is used for a few probes: dtrace: failed to compile script trace-dtrace-root.dtrace: line 130: syntax error near "CPUState" A comment in scripts/tracetool/__init__.py mentions that: We only want to allow standard C types or f

[PULL v2 4/8] net/colo: Match is-enabled probe to tracepoint

From: Roman Bolshakov Build of QEMU with dtrace fails on macOS: LINKx86_64-softmmu/qemu-system-x86_64 error: probe colo_compare_miscompare doesn't exist error: Could not register probes ld: error creating dtrace DOF section for architecture x86_64 The reason of the error is explained by A

[PULL v2 6/8] scripts/cleanup-trace-events: Emit files in alphabetical order

From: Markus Armbruster Signed-off-by: Markus Armbruster Message-id: 20200806141334.3646302-3-arm...@redhat.com Signed-off-by: Stefan Hajnoczi --- scripts/cleanup-trace-events.pl | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/scripts/cleanup-trace-events.pl b

[PULL v2 7/8] trace-events: Delete unused trace points

From: Markus Armbruster Tracked down with the help of scripts/cleanup-trace-events.pl. Signed-off-by: Markus Armbruster Message-id: 20200806141334.3646302-4-arm...@redhat.com Signed-off-by: Stefan Hajnoczi --- audio/trace-events | 3 --- block/trace-events | 3 --- hw/misc/trace-eve

[PULL v2 8/8] trace-events: Fix attribution of trace points to source

From: Markus Armbruster Some trace points are attributed to the wrong source file. Happens when we neglect to update trace-events for code motion, or add events in the wrong place, or misspell the file name. Clean up with help of scripts/cleanup-trace-events.pl. Funnies requiring manual post-p

Re: [PULL 3/5] softmmu/cpus: Only set parallel_cpus for SMP

Hi Philippe, On 9/8/20 9:56 AM, Philippe Mathieu-Daudé wrote: > +Laurent > > On 9/8/20 9:09 AM, Claudio Fontana wrote: >> On 9/7/20 6:49 PM, Philippe Mathieu-Daudé wrote: >>> On 9/7/20 6:30 PM, Claudio Fontana wrote: On 9/7/20 12:20 PM, Philippe Mathieu-Daudé wrote: > On 9/7/20 12:05 PM,

Re: [PATCH] hw: virtio-pmem: detach the element fromt the virtqueue when error occurs

Hi Michael, Please add while applying the patch. fixes: 5f503cd9f3 ("virtio-pmem: add virtio device") On Mon, 7 Sep 2020 at 03:38, Li Qiang wrote: > > ping! > > Li Qiang 于2020年8月28日周五 上午9:21写道： > > > > Kindly ping. > > > > Li Qiang 于2020年8月14日周五 上午12:52写道： > > > > > > If error occurs while pr

Re: VHOST_USER_PROTOCOL_F_VDPA

Hi Stefan, On 8/21/20 1:08 PM, Stefan Hajnoczi wrote: > The first vDPA ioctls have been added to the vhost-user protocol and I > wonder if it's time to fully change the vhost-user protocol's focus to > providing a full VIRTIO device model like vDPA does. > > Initially vhost-user was just used for

Re: [PATCH v2 01/21] block: Fixes nfs compiling error on msys2/mingw

On Thu, Sep 10, 2020 at 3:29 PM Peter Lieven wrote: > > > > Am 10.09.2020 um 09:14 schrieb 罗勇刚(Yonggang Luo) >: > > > > > > > > On Thu, Sep 10, 2020 at 3:01 PM Peter Lieven wrote: > > > > > > > Am 09.09.2020 um 11:45 schrieb Yonggang Luo : > > > > > > These compiling errors are fixed: > > > ../

Re: [PATCH 6/6] target/i386/kvm: Rename host_tsx_blacklisted() as host_tsx_broken()

On 10/09/20 09:08, Thomas Huth wrote: > On 10/09/2020 09.01, Philippe Mathieu-Daudé wrote: >> In order to use inclusive terminology, rename host_tsx_blacklisted() >> as host_tsx_broken(). >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> target/i386/kvm.c | 4 ++-- >> 1 file changed, 2 insert

Re: [PATCH 1/6] hw/ssi/aspeed_smc: Rename max_slaves as max_devices

On 10/09/20 09:01, Philippe Mathieu-Daudé wrote: > In order to use inclusive terminology, rename max_slaves > as max_devices. > > Signed-off-by: Philippe Mathieu-Daudé I think we should consider a wholesale replacement of SSISlave with SSIPeripheral according to the proposal at https://www.oshwa

Re: [PATCH 5/6] hw/pci-host/q35: Rename PCI 'black hole as '(memory) hole'

On 10/09/20 09:15, Thomas Huth wrote: > On 10/09/2020 09.01, Philippe Mathieu-Daudé wrote: >> In order to use inclusive terminology, rename "blackhole" >> as "(memory)hole". > A black hole is a well-known astronomical term, which is simply named > that way since it absorbes all light. I doubt that

Re: [PULL v2] Block layer patches

Am 10.09.2020 um 00:09 hat Eric Blake geschrieben: > On 9/9/20 4:55 PM, Peter Maydell wrote: > > > > > This fails 'make check' on NetBSD and OpenBSD: > > > > ./check: line 47: realpath: command not found > > ./check: line 60: /common.env: No such file or directory > > check: failed to source com

Re: [PATCH 5/6] hw/pci-host/q35: Rename PCI 'black hole as '(memory) hole'

On Thu, Sep 10, 2020 at 09:15:02AM +0200, Thomas Huth wrote: > On 10/09/2020 09.01, Philippe Mathieu-Daudé wrote: > > In order to use inclusive terminology, rename "blackhole" > > as "(memory)hole". > > A black hole is a well-known astronomical term, which is simply named > that way since it absor

[PULL v3] Block layer patches

The following changes since commit 7c37270b3fbe3d034ba80e488761461676e21eb4: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20200904-pull-request' into staging (2020-09-06 16:23:55 +0100) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for yo

Re: [PATCH 1/4] docs: lift block-core.json rST header into parents

Am 10.09.2020 um 07:18 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 09.09.2020 um 17:28 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > Am 09.09.2020 um 14:10 hat Markus Armbruster geschrieben: > >> >> Kevin Wolf writes: > [...] > >> >> > There are or

Re: [RFC] QEMU as Xcode project on macOS

On 09/09/20 22:13, Liviu Ionescu wrote: >> ... You still need a Python 3.5 or better for the other scripts >> QEMU has as part of its build process, so you will still need a >> python other than the Apple /usr/bin/python to build even if you >> have a standalone meson with its own python. > > Ah,

Re: [PATCH v2 0/2] MTE support for KVM guest

On 10/09/2020 07:29, Andrew Jones wrote: On Wed, Sep 09, 2020 at 05:04:15PM +0100, Steven Price wrote: On 09/09/2020 16:25, Andrew Jones wrote: On Fri, Sep 04, 2020 at 05:00:16PM +0100, Steven Price wrote: 2. Automatically promotes (normal host) memory given to the guest to be tag ena

Re: [PATCH v2 2/2] arm64: kvm: Introduce MTE VCPU feature

On 09/09/2020 16:48, Andrew Jones wrote: On Fri, Sep 04, 2020 at 05:00:18PM +0100, Steven Price wrote: Add a new VCPU features 'KVM_ARM_VCPU_MTE' which enables memory tagging on a VCPU. When enabled on any VCPU in the virtual machine this causes all pages that are faulted into the VM to have the

Re: [RFC] QEMU as Xcode project on macOS

On Donnerstag, 10. September 2020 09:37:10 CEST Daniel P. Berrangé wrote: > I don't think we want to be adding more 3rd party deps as submodules, quite > the opposite, we want to remove more submodules we currently have. > > Bundling every important dep we use as a submodule and providing build >

[PATCH v5 2/8] s390/sclp: rework sclp boundary checks

Rework the SCLP boundary check to account for different SCLP commands (eventually) allowing different boundary sizes. Signed-off-by: Collin Walling Acked-by: Janosch Frank Reviewed-by: Cornelia Huck --- hw/s390x/sclp.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-)

[PATCH v5 5/8] s390/sclp: use cpu offset to locate cpu entries

The start of the CPU entry region in the Read SCP Info response data is denoted by the offset_cpu field. As such, QEMU needs to begin creating entries at this address. This is in preparation for when Read SCP Info inevitably introduces new bytes that push the start of the CPUEntry field further aw

[PATCH v5 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

Janosch, Thomas, Conny: I've removed your r-b's from patch #3 since I added some g_mallocs in place and I'd like to make sure things are done properly there (explained in changelog, but let me know if further explanation is necessary). Janosch, please let me know if the changes to #3 are safe unde

[PATCH v5 1/8] s390/sclp: get machine once during read scp/cpu info

Functions within read scp/cpu info will need access to the machine state. Let's make a call to retrieve the machine state once and pass the appropriate data to the respective functions. Signed-off-by: Collin Walling Reviewed-by: David Hildenbrand Reviewed-by: Thomas Huth Reviewed-by: Janosch Fr

[PATCH v5 7/8] s390/kvm: header sync for diag318

Signed-off-by: Collin Walling --- linux-headers/asm-s390/kvm.h | 7 +-- linux-headers/linux/kvm.h| 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 0138ccb0d8..f053b8304a 100644 --- a/linux-headers/asm-s3

[PATCH v5 3/8] s390/sclp: read sccb from mem based on provided length

The header contained within the SCCB passed to the SCLP service call contains the actual length of the SCCB. Instead of allocating a static 4K size for the work sccb, let's allow for a variable size determined by the value in the header. The proper checks are already in place to ensure the SCCB len

[PATCH v5 4/8] s390/sclp: check sccb len before filling in data

The SCCB must be checked for a sufficient length before it is filled with any data. If the length is insufficient, then the SCLP command is suppressed and the proper response code is set in the SCCB header. While we're at it, let's cleanup the length check by placing the calculation inside a macro

[PATCH v5 6/8] s390/sclp: add extended-length sccb support for kvm guest

As more features and facilities are added to the Read SCP Info (RSCPI) response, more space is required to store them. The space used to store these new features intrudes on the space originally used to store CPU entries. This means as more features and facilities are added to the RSCPI response, l

Re: [RFC] QEMU as Xcode project on macOS

On Thu, Sep 10, 2020 at 11:32:35AM +0200, Christian Schoenebeck wrote: > On Donnerstag, 10. September 2020 09:37:10 CEST Daniel P. Berrangé wrote: > > I don't think we want to be adding more 3rd party deps as submodules, quite > > the opposite, we want to remove more submodules we currently have. >

[PATCH v5 8/8] s390: guest support for diagnose 0x318

DIAGNOSE 0x318 (diag318) is an s390 instruction that allows the storage of diagnostic information that is collected by the firmware in the case of hardware/firmware service events. QEMU handles the instruction by storing the info in the CPU state. A subsequent register sync will communicate the da

Re: [PATCH v2 5/6] migration: Maintain postcopy faulted addresses

* Peter Xu (pet...@redhat.com) wrote: > Maintain a list of faulted addresses on the destination host for which we're > waiting on. This is implemented using a GTree rather than a real list to make > sure even there're plenty of vCPUs/threads that are faulting, the lookup will > still be fast with

Re: [PATCH v2 2/2] arm64: kvm: Introduce MTE VCPU feature

On Thu, Sep 10, 2020 at 08:38:54AM +0200, Andrew Jones wrote: > On Wed, Sep 09, 2020 at 04:53:02PM +0100, Peter Maydell wrote: > > On Wed, 9 Sep 2020 at 16:48, Andrew Jones wrote: > > > We either need a KVM cap or a new CPU feature probing interface to avoid > > > making userspace try features one

[PULL 01/17] tests: fix output message formatting for crypto benchmarks

The output was changed from g_print to g_test_message in commit 24441f912e67233d9c52ce6b459ed75de2484525 Author: Marc-André Lureau Date: Fri Aug 28 15:07:30 2020 +0400 tests: do not print benchmark output to stdout As this makes the TAP output invalid. Use g_test_message(). The

[PULL 02/17] crypto: Assume blocksize is a power of 2

From: Richard Henderson The check in the encode/decode path using full division has a noticeable amount of overhead. By asserting the blocksize is a power of 2, we can reduce this check to a mask. Signed-off-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- crypto/cipher-builtin.c

[PULL 06/17] crypto: Move QCryptoCipherDriver typedef to crypto/cipher.h

From: Richard Henderson Allow the use in QCryptoCipher to be properly typed with the opaque struct pointer. Signed-off-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- crypto/cipherpriv.h | 2 -- include/crypto/cipher.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) di

[PULL 00/17] Crypto next patches

The following changes since commit 9435a8b3dd35f1f926f1b9127e8a906217a5518a: Merge remote-tracking branch 'remotes/kraxel/tags/sirius/ipxe-20200908-pull= -request' into staging (2020-09-08 21:21:13 +0100) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/crypt-per

[PULL 03/17] crypto: Rename cipher include files to .c.inc

From: Richard Henderson QEMU standard procedure for included c files is to use *.c.inc. E.g. there are a different set of checks that are applied. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- crypto/{cipher-builtin.c => cipher-bui

[PULL 05/17] crypto/nettle: Fix xts_encrypt arguments

From: Richard Henderson The fourth argument to xts_encrypt should be the decrypt callback; we were accidentally passing encrypt twice. Signed-off-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- crypto/cipher-nettle.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PULL 08/17] crypto: Allocate QCryptoCipher with the subclass

From: Richard Henderson Merge the allocation of "opaque" into the allocation of "cipher". This is step one in reducing the indirection in these classes. Signed-off-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- crypto/afalgpriv.h | 3 ++ crypto/cipher-afalg.c | 20

[PULL 04/17] crypto: Remove redundant includes

From: Richard Henderson Both qemu/osdep.h and cipherpriv.h have already been included by the parent cipher.c. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- crypto/cipher-builtin.c.inc | 2 -- crypto/cipher-gcrypt.c.inc | 2 -- cry

[PULL 10/17] crypto: Constify cipher data tables

From: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- crypto/cipher.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/cipher.c b/crypto/cipher.c index 3711b552fa..068b2fb867 100644 --

[PULL 09/17] crypto: Move cipher->driver init to qcrypto_*_cipher_ctx_new

From: Richard Henderson The class vtable should be set by the class initializer. This will also allow additional subclassing, reducing the amount of indirection in the hierarchy. Signed-off-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- crypto/cipher-afalg.c | 5 - cryp

[PULL 07/17] crypto: Use the correct const type for driver

From: Richard Henderson This allows the in memory structures to be read-only. Signed-off-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- crypto/cipher-afalg.c | 2 +- crypto/cipher-builtin.c.inc | 2 +- crypto/cipher-gcrypt.c.inc | 2 +- crypto/cipher-nettle.c.inc | 2

[PULL 17/17] crypto/gcrypt: Split QCryptoCipherGcrypt into subclasses

From: Richard Henderson With gcrypt, most of the dispatch happens in the library, so there aren't many classes to create. However, we can still create separate dispatch for CTR mode, and for CONFIG_QEMU_PRIVATE_XTS, which avoids needing to check for these modes at runtime. Signed-off-by: Richar

[PULL 12/17] crypto/builtin: Merge qcrypto_cipher_aes_{ecb, xts}_{en, de}crypt

From: Richard Henderson There's no real reason we need two separate helper functions here. Standardize on the function signature required for xts_encrypt. Rename to do_aes_{en,de}crypt_ecb, since the helper does not itself do anything with respect to xts. Reviewed-by: Philippe Mathieu-Daudé Sig

[PULL 11/17] crypto/builtin: Remove odd-sized AES block handling

From: Richard Henderson We verified that the data block is properly sized modulo AES_BLOCK_SIZE within qcrypto_builtin_cipher_{en,de}crypt. Therefore we will never have to handle odd sized blocks. Signed-off-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- crypto/cipher-builtin.c.i

[PULL 13/17] crypto/builtin: Move AES_cbc_encrypt into cipher-builtin.inc.c

From: Richard Henderson By making the function private, we will be able to make further simplifications. Re-indent the migrated code and fix the missing braces for CODING_STYLE. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- crypto

Re: [RFC] QEMU as Xcode project on macOS

On Donnerstag, 10. September 2020 11:39:10 CEST Daniel P. Berrangé wrote: > > Well, that's actually the whole point of this thread: saving developers' > > time. And I think the submodule solution is the most sane one. > > > > Frankly if you compile FOSS software on Mac that asks you to "just" > >

Re: Meson can't recover from deletion of generated QAPI file(s)

Paolo Bonzini writes: > On 09/09/20 14:37, Markus Armbruster wrote: >> Watch this: >> >> $ rm qapi/qapi-types-error.h >> $ make >> Generating qemu-version.h with a meson_exe.py custom command >> Compiling C object qom/libqom.fa.p/object_interfaces.c.o >> In file included fro

[PULL 14/17] crypto/builtin: Split and simplify AES_encrypt_cbc

From: Richard Henderson Split into encrypt/decrypt functions, dropping the "enc" argument. Now that the function is private to this file, we know that "len" is a multiple of AES_BLOCK_SIZE. So drop the odd block size code. Name the functions do_aes_*crypt_cbc to match the *_ecb functions. Reord

Re: [PATCH 6/6] target/i386/kvm: Rename host_tsx_blacklisted() as host_tsx_broken()

Le 10/09/2020 à 09:01, Philippe Mathieu-Daudé a écrit : > In order to use inclusive terminology, rename host_tsx_blacklisted() > as host_tsx_broken(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/i386/kvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a

Re: [PATCH 04/29] block/export: Add BlockExport infrastructure and block-export-add

On 07.09.20 20:19, Kevin Wolf wrote: > We want to have a common set of commands for all types of block exports. > Currently, this is only NBD, but we're going to add more types. > > This patch adds the basic BlockExport and BlockExportDriver structs and > a QMP command block-export-add that create

[PULL 15/17] crypto/builtin: Split QCryptoCipherBuiltin into subclasses

From: Richard Henderson We had a second set of function pointers in QCryptoCipherBuiltin, which are redundant with QCryptoCipherDriver. Split the AES and DES implementations to avoid one level of indirection. Signed-off-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- crypto/ciphe

[PULL 16/17] crypto/nettle: Split QCryptoCipherNettle into subclasses

From: Richard Henderson Use separate classes for each cipher entry point: des_rfb, des3, aes128, aes192, aes256, cast128, serpent, and twofish. Generate wrappers for XTS only for CONFIG_QEMU_PRIVATE_XTS. This eliminates unreachable wrappers for DES_RFB, DES3 and CAST128, which have blocksizes th

Re: [RFC] QEMU as Xcode project on macOS

> On 10 Sep 2020, at 12:20, Paolo Bonzini wrote: > > --python=/path/to/python3 --meson=internal > > and the build will automatically use that same Python executable to run > the scripts. Ok, good to know. My standalone meson is intended for integration into Eclipse and Visual Studio Code,

Re: [PATCH RESEND] manual: escape backslashes in "parsed-literal" blocks

Cc'ing qemu-trivial@ On 9/8/20 7:21 PM, Laszlo Ersek wrote: > According to > , > "inline markup is recognized and there is no protection from parsing. > Backslash-escapes may be necessary to prevent unintended parsing". >

Re: [RFC] QEMU as Xcode project on macOS

> On 10 Sep 2020, at 13:14, Christian Schoenebeck > wrote: > > The way to go for devs on Mac is: 3rd party libs should not be installed into > global space, rather be built & linked either as dynamic frameworks > (including > assets) or as static libs. Then apps always run with the precise

Re: [PATCH v2 0/2] MTE support for KVM guest

On 10/09/2020 01:33, Richard Henderson wrote: On 9/4/20 9:00 AM, Steven Price wrote: 3. Doesn't provide any new methods for the VMM to access the tags on memory. ... (3) may be problematic and I'd welcome input from those familiar with VMMs. User space cannot access tags unless the memo

[PATCH v7 00/25] W32, W64 msys2/mingw patches

It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and disable partial test-char tests. And then fixes all unit tests failure on msys2/mingw This fixes the reviews suggested in the mailling list Kevin Wolf (1): file-win32: Fix "locking" option Maxim Levitsky (1): rcu: Implem

[PATCH v7 03/25] block: Fixes nfs compiling error on msys2/mingw

These compiling errors are fixed: ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory 27 | #include | ^~~~ compilation terminated. ../block/nfs.c:63:5: error: unknown type name 'blkcnt_t' 63 | blkcnt_t st_blocks; | ^~~~ ../block/nfs.c: I

[PATCH v7 05/25] configure: Fixes ncursesw detection under msys2/mingw and enable curses

The mingw pkg-config are showing following absolute path and contains : as the separator, so we must not use : as path separator. and we know the command line parameter are not likely contains newline, we could use newline as path command line parameter separator -D_XOPEN_SOURCE=600 -D_POSIX_C_S

[PATCH v7 06/25] win32: Simplify gmtime_r detection direct base on _POSIX_THREAD_SAFE_FUNCTIONS.

First, this reduce the size of configure, configure are tending to removal in future, and this didn't introduce any new feature or remove any exist feature. Second, the current localtime_r detection are conflict with ncursesw detection in mingw, when ncursesw detected, it will provide the followi

[PATCH v7 01/25] file-win32: Fix "locking" option

From: Kevin Wolf The intended behaviour was that locking=off/auto work and have no effect (to remain compatible with file-posix), whereas locking=on would return an error. Unfortunately, the code forgot to remove "locking" from the options QDict, so any attempt to use the option would fail. Repl

[PATCH v7 02/25] rcu: Implement drain_call_rcu

From: Maxim Levitsky This will allow is to preserve the semantics of hmp_device_del, that the device is deleted immediatly which was changed by previos patch that delayed this to RCU callback Signed-off-by: Maxim Levitsky Suggested-by: Stefan Hajnoczi Reviewed-by: Stefan Hajnoczi --- include

[PATCH v7 07/25] curses: Fixes curses compiling errors.

This is the compiling error: ../ui/curses.c: In function 'curses_refresh': ../ui/curses.c:256:5: error: 'next_maybe_keycode' may be used uninitialized in this function [-Werror=maybe-uninitialized] 256 | curses2foo(_curses2keycode, _curseskey2keycode, chr, maybe_keycode) | ^~~~

[PATCH v7 04/25] ci: fixes msys2 build by upgrading capstone to 4.0.2

The currently random version capstone have the following compiling issue: CC /c/work/xemu/qemu/build/slirp/src/arp_table.o make[1]: *** No rule to make target “/c/work/xemu/qemu/build/capstone/capstone.lib”。 Stop. Subproject commit 1d230532840a37ac032c6ab80128238fc930c6c1 are the tagged v

[PATCH v7 08/25] tests: disable /char/stdio/* tests in test-char.c on win32

These tests are blocking test-char to be finished. Disable them by using variable is_win32, so we doesn't need macro to open it. and easy recover those function latter. Signed-off-by: Yonggang Luo --- tests/test-char.c | 26 -- 1 file changed, 16 insertions(+), 10 deletio

Re: [PULL 3/5] softmmu/cpus: Only set parallel_cpus for SMP

On 9/10/20 10:28 AM, Claudio Fontana wrote: > Hi Philippe, > > On 9/8/20 9:56 AM, Philippe Mathieu-Daudé wrote: >> +Laurent >> >> On 9/8/20 9:09 AM, Claudio Fontana wrote: >>> On 9/7/20 6:49 PM, Philippe Mathieu-Daudé wrote: On 9/7/20 6:30 PM, Claudio Fontana wrote: > On 9/7/20 12:20 PM,

[PATCH v7 13/25] gcrypt: test_tls_psk_init should write binary file instead text file.

On windows, if open file with "w", it's will automatically convert "\n" to "\r\n" when writing to file. Convert unlink to use g_remove. Signed-off-by: Yonggang Luo --- tests/crypto-tls-psk-helpers.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/crypto-tls-psk-h

[PATCH v7 09/25] tests: Fixes test-replication.c on msys2/mingw.

On Windows there is no path like /tmp/s_local_disk.XX Use g_get_tmp_dir instead of /tmp. Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- tests/test-replication.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tests/test-replication.c

[PATCH v7 10/25] tests: test-replication disable /replication/secondary/* on msys2/mingw.

They caused failure on msys2/mingw, that's because file-win32.c not implement .bdrv_reopen_prepare/commit/abort yet. This is the error message: > $ ./tests/test-replication.exe > # random seed: R02S3f4d1c01af2b0a046990e0235c481faf > 1..13 > # Start of replication tests > # Start of primary tests >

[PATCH v7 16/25] vmstate: Fixes test-vmstate.c on msys2/mingw

The vmstate are valid on win32, just need generate tmp path properly Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrangé --- tests/test-vmstate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/te

  1   2   3   4   5   >