Re: [PATCH 5/6] tests: handling signal on win32 properly

2020-09-03 Thread Paolo Bonzini
Yes, I guess that's true. I will queue it instead. Paolo Il gio 3 set 2020, 07:58 Thomas Huth ha scritto: > On 02/09/2020 19.04, Paolo Bonzini wrote: > > On 02/09/20 19:00, Yonggang Luo wrote: > >> SIGABRT should use signal(SIGABRT, sigabrt_handler) to handle on win32 > >> > >> The error: > >>

Re: [PATCH v2 3/3] nbd: disable signals and forking on Windows builds

2020-09-03 Thread Yonggang Luo
On Thu, Sep 3, 2020 at 7:29 AM Eric Blake wrote: > On 9/2/20 5:07 PM, 罗勇刚(Yonggang Luo) wrote: > > On Tue, Aug 25, 2020 at 6:40 PM Daniel P. Berrangé > > wrote: > > > >> Disabling these parts are sufficient to get the qemu-nbd program > >> compiling in a Windows build. > >> > >> Signed-off-by: D

Re: [PATCH] stubs: Move qemu_fd_register stub to util/main-loop.c

2020-09-03 Thread Yonggang Luo
I am also facing some problem alike: LINKtests/test-qdev-global-props.exe LINKtests/test-timed-average.exe C:/CI-Tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: libqemuutil.a(util_main-loop.c.obj): in function `qemu_notify_event'

[PATCH v1] sd: sdhci: assert data_count is within fifo_buffer

2020-09-03 Thread P J P
From: Prasad J Pandit While doing multi block SDMA, transfer block size may exceed the 's->fifo_buffer[s->buf_maxsz]' size. It may leave the current element pointer 's->data_count' pointing out of bounds. Leading the subsequent DMA r/w operation to OOB access issue. Assert that 's->data_count' is

[PATCH v2 08/12] target/microblaze: Replace cpustate_changed with DISAS_EXIT_NEXT

2020-09-03 Thread Richard Henderson
Rather than look for the combination of DISAS_NEXT with a separate variable, go ahead and set is_jmp to the desired state. Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/microblaze/translate.c | 34 ++ 1 f

[PATCH v2 02/12] target/microblaze: Renumber D_FLAG

2020-09-03 Thread Richard Henderson
ESS[DS] is bit 19 in the manual, but the manual uses big-endian bit numbering. This corresponds to bit 12 in little-endian numbering. Let the comment about matching the ESR be true by renumbering it. Signed-off-by: Richard Henderson --- target/microblaze/cpu.h | 2 +- 1 file changed, 1 insertio

[PATCH v2 01/12] target/microblaze: Collected fixes for env->iflags

2020-09-03 Thread Richard Henderson
There are several problems here that can result in soft lockup, depending on exactly where an interrupt or exception is delivered: Include BIMM_FLAG in IFLAGS_TB_MASK, since it needs to follow D_FLAG. Ensure that iflags is 0 when entering an interrupt/exception handler. Add mb_cpu_synchronize_from

[PATCH v2 00/12] target/microblaze improvements

2020-09-03 Thread Richard Henderson
Version 2 includes fixes for iflags that could cause lockups. It seems it was easier to do so with icount=7, which is what we do during the replay acceptance tests. This causes TBs to contain no more than 7 insns, and often less to make up for an incomplete count elsewhere. Which stressed the ifl

[PATCH v2 10/12] target/microblaze: Force rtid, rted, rtbd to exit

2020-09-03 Thread Richard Henderson
These return-from-exception type instructions have modified MSR to re-enable various forms of interrupt. Force a return to the main loop. Consolidate the cleanup of tb_flags into mb_tr_translate_insn. Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Signed-off-by: Richard Henderson

[PATCH v2 04/12] target/microblaze: Rename mmu structs

2020-09-03 Thread Richard Henderson
Introduce typedefs and follow CODING_STYLE for naming. Rename struct microblaze_mmu to MicroBlazeMMU. Rename struct microblaze_mmu_lookup to MicroBlazeMMULookup. Signed-off-by: Richard Henderson --- target/microblaze/cpu.h| 2 +- target/microblaze/mmu.h| 15 ++- target/micro

[PATCH v2 03/12] target/microblaze: Cleanup mb_cpu_do_interrupt

2020-09-03 Thread Richard Henderson
Reindent; remove dead/commented code. Use D_FLAG to set ESS[DS]. Sink MSR adjustment for kernel entry, iflags and res_addr clear. Improve CPU_LOG_INT formatting; report pc and msr before and after. Signed-off-by: Richard Henderson --- target/microblaze/helper.c | 209

[PATCH v2 09/12] target/microblaze: Handle DISAS_EXIT_NEXT in delay slot

2020-09-03 Thread Richard Henderson
It is legal to put an mts instruction into a delay slot. We should continue to return to the main loop in that case so that we recognize any pending interrupts. Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/microblaze/translate.c | 34 +

[PATCH v2 05/12] target/microblaze: Fill in VMStateDescription for cpu

2020-09-03 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/microblaze/cpu.h | 4 ++ target/microblaze/cpu.c | 8 +-- target/microblaze/machine.c | 112 ++ target/microblaze/meson.build | 5 +- 4 files changed, 121 insertions(+), 8 deletions(-) create mode 100

[PATCH v2 07/12] target/microblaze: Introduce DISAS_EXIT_NEXT, DISAS_EXIT_JUMP

2020-09-03 Thread Richard Henderson
Like DISAS_EXIT, except we need to update cpu_pc, either to pc_next or to btarget respectively. Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/microblaze/translate.c | 29 + 1 file changed, 21 insertions(+), 8

[PATCH v2 11/12] target/microblaze: Use tcg_gen_lookup_and_goto_ptr

2020-09-03 Thread Richard Henderson
Normal indirect jumps, or page-crossing direct jumps, can use tcg_gen_lookup_and_goto_ptr to avoid returning to the main loop simply to find an existing TB for the next pc. Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/microblaze/transl

[PATCH v2 06/12] target/microblaze: Rename DISAS_UPDATE to DISAS_EXIT

2020-09-03 Thread Richard Henderson
The name "update" suggests that something needs updating, but this is not the case. Use "exit" to emphasize that nothing needs doing except to exit. Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/microblaze/translate.c | 10 +-

[PATCH v2 12/12] target/microblaze: Diagnose invalid insns in delay slots

2020-09-03 Thread Richard Henderson
These cases result in undefined and undocumented behaviour but the behaviour is deterministic, i.e cores will not lock-up or expose security issues. However, RTL will not raise exceptions either. Therefore, log a GUEST_ERROR and treat these cases as nops, to avoid corner cases which could put qem

[PATCH v3 01/12] configure: fixes dtc not cloned when running msys2 CI

2020-09-03 Thread Yonggang Luo
Symlink dtc after git submodule update, because on win32 symlink to non-exist folder are forbidden. Signed-off-by: Yonggang Luo --- configure | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/configure b/configure index 8a3acef89d..30f8c4db29 100755 --- a/con

[PATCH v3 05/12] configure: Fix include and linkage issue on msys2

2020-09-03 Thread Yonggang Luo
On msys2, the -I/e/path/to/qemu -L/e/path/to/qemu are not recognized by the compiler Cause $PWD are result posix style path such as /e/path/to/qemu that can not be recognized by mingw gcc, and `pwd -W` are result Windows style path such as E:/path/to/qemu that can be recognized by the mingw gcc.

[PATCH v3 02/12] meson: Convert undefsym.sh to undefsym.py

2020-09-03 Thread Yonggang Luo
undefsym.sh are not msys2 compatible, convert it to python script Signed-off-by: Yonggang Luo --- meson.build | 2994 +-- scripts/undefsym.py | 57 + scripts/undefsym.sh | 20 - 3 files changed, 1554 insertions(+), 1517 deletions(-) create mod

[PATCH v3 00/12] Green the msys2 CI make

2020-09-03 Thread Yonggang Luo
Also it's fixes issues about make check Yonggang Luo (12): configure: fixes dtc not cloned when running msys2 CI meson: Convert undefsym.sh to undefsym.py tcg: Fixes dup_const link error tests: handling signal on win32 properly configure: Fix include and linkage issue on msys2 block: F

[PATCH v3 06/12] block: Fixes nfs on msys2/mingw

2020-09-03 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- block/nfs.c | 1812 ++- 1 file changed, 910 insertions(+), 902 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 61a249a9fc..34b2cd5708 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -1,902 +1,910 @@ -/* - * Q

[PATCH v3 04/12] tests: handling signal on win32 properly

2020-09-03 Thread Yonggang Luo
SIGABRT should use signal(SIGABRT, sigabrt_handler) to handle on win32 The error: E:/CI-Cor-Ready/xemu/qemu.org/tests/test-replication.c:559:33: error: invalid use of undefined type 'struct sigaction' 559 | sigact = (struct sigaction) { | ^ Signed-off-

[PATCH v3 07/12] osdep: These function are only available on Non-Win32 system.

2020-09-03 Thread Yonggang Luo
int qemu_lock_fd(int fd, int64_t start, int64_t len, bool exclusive); int qemu_unlock_fd(int fd, int64_t start, int64_t len); int qemu_lock_fd_test(int fd, int64_t start, int64_t len, bool exclusive); bool qemu_has_ofd_lock(void); Signed-off-by: Yonggang Luo --- include/qemu/osdep.h | 1372 +

[PATCH v3 10/12] meson: Fixes qapi tests.

2020-09-03 Thread Yonggang Luo
The error are: +@end table + +@end deftypefn + make: *** [Makefile.mtest:63: check-qapi-schema] Error 1 Signed-off-by: Yonggang Luo --- tests/qapi-schema/meson.build | 451 +- 1 file changed, 226 insertions(+), 225 deletions(-) diff --git a/tests/qapi-schema/meso

[PATCH v3 09/12] stubs: qemu_notify_event have no need to stub

2020-09-03 Thread Yonggang Luo
LINKtests/test-qdev-global-props.exe LINKtests/test-timed-average.exe C:/CI-Tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: libqemuutil.a(util_main-loop.c.obj): in function `qemu_notify_event': C:\work\xemu\qemu-build/../qemu/uti

[PATCH v3 12/12] ci: Enable msys2 ci in cirrus

2020-09-03 Thread Yonggang Luo
Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be updated. There is no need of --cross-prefix, open mingw64.exe instead of msys2.exe then we don't need the --cross-prefix, besides

[PATCH v3 11/12] tests: Disable test-image-locking that not works under Win32

2020-09-03 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- tests/Makefile.include | 1086 1 file changed, 544 insertions(+), 542 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 9ac8f5b86a..497f1f21ff 100644 --- a/tests/Makefile.include +++ b/tests/Ma

Re: [PATCH v3 00/12] Green the msys2 CI make

2020-09-03 Thread Paolo Bonzini
Please send patches more slowly. You already have several queued, and resending them only adds confusion. Paolo Il gio 3 set 2020, 09:43 Yonggang Luo ha scritto: > Also it's fixes issues about make check > > Yonggang Luo (12): > configure: fixes dtc not cloned when running msys2 CI > meson:

Re: [PATCH v3 00/12] Green the msys2 CI make

2020-09-03 Thread Yonggang Luo
On Thu, Sep 3, 2020 at 3:58 PM Paolo Bonzini wrote: > Please send patches more slowly. You already have several queued, and > resending them only adds confusion. > > OK, sorry for that. > Paolo > > Il gio 3 set 2020, 09:43 Yonggang Luo ha scritto: > >> Also it's fixes issues about make check >>

Re: [PATCH v3 10/12] meson: Fixes qapi tests.

2020-09-03 Thread Paolo Bonzini
Your patch is rewriting the whole file, I think there's a git option to fix the line endings on commit. Also the commit message should describe why it's failing. I can see you added --strip-trailing-cr, but still it should be mentioned. Paolo Il gio 3 set 2020, 09:44 Yonggang Luo ha scritto: >

Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-03 Thread Christian Schoenebeck
On Mittwoch, 2. September 2020 18:54:22 CEST Greg Kurz wrote: > > Well, I can do that of course. But somehow I fear users get lost by just > > pointing them to "man 1 qemu" in the log message. It already starts that > > e.g. on Debian there is no "man qemu", it is "man qemu-system" there > > instea

[PULL 1/8] qapi: enable use of g_autoptr with QAPI types

2020-09-03 Thread Markus Armbruster
From: Daniel P. Berrangé Currently QAPI generates a type and function for free'ing it: typedef struct QCryptoBlockCreateOptions QCryptoBlockCreateOptions; void qapi_free_QCryptoBlockCreateOptions(QCryptoBlockCreateOptions *obj); This is used in the traditional manner: QCryptoBlockCreateO

[PULL 7/8] qapi: Document event VSERPORT_CHANGE is rate-limited

2020-09-03 Thread Markus Armbruster
Commit e2ae6159de "virtio-serial: report frontend connection state via monitor" neglected to document the new event is rate-limited. Fix that. Cc: Marc-André Lureau Cc: Eric Blake Signed-off-by: Markus Armbruster Message-Id: <20200806081147.3123652-3-arm...@redhat.com> Reviewed-by: Marc-André

[PULL 4/8] scripts/qmp/qom-fuse: Port to current Python module fuse

2020-09-03 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20200723142738.1868568-3-arm...@redhat.com> Reviewed-by: John Snow --- scripts/qmp/qom-fuse | 93 ++-- 1 file changed, 47 insertions(+), 46 deletions(-) diff --git a/scripts/qmp/qom-fuse b/scripts/qmp/qom-fuse

[PULL 0/8] QAPI patches patches for 2020-09-03

2020-09-03 Thread Markus Armbruster
The following changes since commit ed215cec0fcaeaece064b0fdf37fe3bceb06d76c: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2020-09-02 15:26:38 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2020-

[PULL 8/8] docs/qdev-device-use: Don't suggest -drive and -net can do USB

2020-09-03 Thread Markus Armbruster
Commit 480324ec8d "docs/qdev-device-use: Clean up the sentences related to -usbdevice" deleted the information on syntax that no longer works. Unfortunately, the resulting text suggests you can configure USB block devices with -drive, and USB network devices with -net, which is misleading. Instea

[PULL 2/8] qapi/block-core.json: Remove stale description of 'blockdev-add'

2020-09-03 Thread Markus Armbruster
From: Kashyap Chamarthy On a 'qemu-discuss' thread[1], Kevin identifies that the current doc blurb for @blockdev-add is stale: This is actually a documentation bug. @id doesn't exist, blockdev-add never creates a BlockBackend. This was different in the very first versions of the patc

[PULL 5/8] scripts/qmp/qom-fuse: Fix getattr(), read() for files in /

2020-09-03 Thread Markus Armbruster
path, prop = "type".rsplit('/', 1) sets path to "", which doesn't work. Correct to "/". Signed-off-by: Markus Armbruster Message-Id: <20200723142738.1868568-4-arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: John Snow --- scripts/qmp/qom-fuse | 10 -- 1 file changed

Re: [PATCH] stubs: Move qemu_fd_register stub to util/main-loop.c

2020-09-03 Thread Daniel P . Berrangé
On Thu, Sep 03, 2020 at 07:45:03AM +0200, Thomas Huth wrote: > The linker of MinGW sometimes runs into the following problem: > > libqemuutil.a(util_main-loop.c.obj): In function `qemu_fd_register': > /builds/huth/qemu/build/../util/main-loop.c:331: multiple definition of > `qemu_fd_register' > l

[PULL 3/8] scripts/qmp/qom-fuse: Unbreak import of QEMUMonitorProtocol

2020-09-03 Thread Markus Armbruster
Commit c7b942d7f8 "scripts/qmp: Fix shebang and imports" messed with it for reasons I don't quite understand. I do understand how it fails now: it neglects to import sys. Fix that. It now fails because it expects an old version of module fuse. That's next. Fixes: c7b942d7f84ef54f266921bf7668d4

[PULL 6/8] docs/interop/qmp-spec: Point to the QEMU QMP reference manual

2020-09-03 Thread Markus Armbruster
Commit 4d8bb958fa0..231aaf3a821 integrated the contents of docs/qmp-events.txt into QAPI schema doc comments. It left dangling references to qmp-events.txt behind. Fix to point to the QEMU QMP reference manual generated from the QAPI schema. Add a similar reference for commands. Cc: Marc-André

Re: [PATCH v3 06/12] block: Fixes nfs on msys2/mingw

2020-09-03 Thread Daniel P . Berrangé
On Thu, Sep 03, 2020 at 03:43:07PM +0800, Yonggang Luo wrote: > Signed-off-by: Yonggang Luo > --- > block/nfs.c | 1812 ++- > 1 file changed, 910 insertions(+), 902 deletions(-) The diff for this file is totally messed up, adding/removing every sin

Re: [PATCH v3 07/12] osdep: These function are only available on Non-Win32 system.

2020-09-03 Thread Daniel P . Berrangé
On Thu, Sep 03, 2020 at 03:43:08PM +0800, Yonggang Luo wrote: > int qemu_lock_fd(int fd, int64_t start, int64_t len, bool exclusive); > int qemu_unlock_fd(int fd, int64_t start, int64_t len); > int qemu_lock_fd_test(int fd, int64_t start, int64_t len, bool exclusive); > bool qemu_has_ofd_lock(void)

[Bug 1731347] Re: VFIO Passthrough of SAS2008-based HBA card fails on E3-1225v3 due to failed DMA mapping (-14)

2020-09-03 Thread Tony.LI
Hello! Has your problem been solved? I also encountered a similar problem. My ioctl() also returned an error -14(Bad address). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1731347 Title: VFIO

[PATCH v4 00/12] Green the msys2 CI make

2020-09-03 Thread Yonggang Luo
Also it's fixes issues about make check Yonggang Luo (12): configure: fixes dtc not cloned when running msys2 CI meson: Convert undefsym.sh to undefsym.py tcg: Fixes dup_const link error tests: handling signal on win32 properly configure: Fix include and linkage issue on msys2 block: F

[PATCH v4 01/12] configure: fixes dtc not cloned when running msys2 CI

2020-09-03 Thread Yonggang Luo
Symlink dtc after git submodule update, because on win32 symlink to non-exist folder are forbidden. Signed-off-by: Yonggang Luo --- configure | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/configure b/configure index 8a3acef89d..30f8c4db29 100755 --- a/con

[PATCH v4 02/12] meson: Convert undefsym.sh to undefsym.py

2020-09-03 Thread Yonggang Luo
undefsym.sh are not msys2 compatible, convert it to python script Signed-off-by: Yonggang Luo --- meson.build | 2 +- scripts/undefsym.py | 57 + scripts/undefsym.sh | 20 3 files changed, 58 insertions(+), 21 deletions(-) cr

[PATCH v4 09/12] stubs: qemu_notify_event have no need to stub

2020-09-03 Thread Yonggang Luo
LINKtests/test-qdev-global-props.exe LINKtests/test-timed-average.exe C:/CI-Tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: libqemuutil.a(util_main-loop.c.obj): in function `qemu_notify_event': C:\work\xemu\qemu-build/../qemu/uti

Re: [PATCH v3 00/12] Green the msys2 CI make

2020-09-03 Thread Daniel P . Berrangé
On Thu, Sep 03, 2020 at 03:43:01PM +0800, Yonggang Luo wrote: > Also it's fixes issues about make check > > Yonggang Luo (12): > configure: fixes dtc not cloned when running msys2 CI > meson: Convert undefsym.sh to undefsym.py > tcg: Fixes dup_const link error > tests: handling signal on w

[PATCH v4 04/12] tests: handling signal on win32 properly

2020-09-03 Thread Yonggang Luo
SIGABRT should use signal(SIGABRT, sigabrt_handler) to handle on win32 The error: E:/CI-Cor-Ready/xemu/qemu.org/tests/test-replication.c:559:33: error: invalid use of undefined type 'struct sigaction' 559 | sigact = (struct sigaction) { | ^ Signed-off-

[PATCH v4 03/12] tcg: Fixes dup_const link error

2020-09-03 Thread Yonggang Luo
Rename function dup_const to dup_const_eval for avoid confliction with macro dup_const The link error on msys2 Linking target qemu-system-alpha.exe C:/CI-Tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: libqemu-alpha-softmmu.fa.p/tcg_optim

[PATCH v4 07/12] osdep: These function are only available on Non-Win32 system.

2020-09-03 Thread Yonggang Luo
int qemu_lock_fd(int fd, int64_t start, int64_t len, bool exclusive); int qemu_unlock_fd(int fd, int64_t start, int64_t len); int qemu_lock_fd_test(int fd, int64_t start, int64_t len, bool exclusive); bool qemu_has_ofd_lock(void); Signed-off-by: Yonggang Luo --- include/qemu/osdep.h | 2 +- 1 fi

[PATCH v4 05/12] configure: Fix include and linkage issue on msys2

2020-09-03 Thread Yonggang Luo
On msys2, the -I/e/path/to/qemu -L/e/path/to/qemu are not recognized by the compiler Cause $PWD are result posix style path such as /e/path/to/qemu that can not be recognized by mingw gcc, and `pwd -W` are result Windows style path such as E:/path/to/qemu that can be recognized by the mingw gcc.

[PATCH v4 06/12] block: Fixes nfs on msys2/mingw

2020-09-03 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- block/nfs.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 61a249a9fc..34b2cd5708 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -24,7 +24,9 @@ #include "qemu/osdep.h" +#if !define

[PATCH v4 11/12] tests: Disable test-image-locking that not works under Win32

2020-09-03 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- tests/Makefile.include | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/Makefile.include b/tests/Makefile.include index 9ac8f5b86a..497f1f21ff 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -87,7 +87,9 @@ check-unit-$(CONFIG_BLOCK) +

[PATCH v4 10/12] meson: Fixes qapi tests.

2020-09-03 Thread Yonggang Luo
The error are: +@end table + +@end deftypefn + make: *** [Makefile.mtest:63: check-qapi-schema] Error 1 Signed-off-by: Yonggang Luo --- tests/qapi-schema/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qapi-schema/meson.build b/tests/qapi-schema/meson.buil

[PATCH v4 08/12] ci: fixes msys2 build by upgrading capstone to 4.0.2

2020-09-03 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- capstone | 2 +- configure | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/capstone b/capstone index 22ead3e0bf..1d23053284 16 --- a/capstone +++ b/capstone @@ -1 +1 @@ -Subproject commit 22ead3e0bfdb87516656453336160e0a37b066bf +Subpr

[PATCH v4 12/12] ci: Enable msys2 ci in cirrus

2020-09-03 Thread Yonggang Luo
Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be updated. There is no need of --cross-prefix, open mingw64.exe instead of msys2.exe then we don't need the --cross-prefix, besides

Re: [PATCH v2 04/15] fuzz: Add DMA support to the generic-fuzzer

2020-09-03 Thread Darren Kenny
On Wednesday, 2020-08-19 at 02:10:59 -04, Alexander Bulekov wrote: > When a virtual-device tries to access some buffer in memory over DMA, we > add call-backs into the fuzzer(next commit). The fuzzer checks verifies > that the DMA request maps to a physical RAM address and fills the memory > with f

Re: [PATCH 55/63] vfio: Rename PCI_VFIO to VFIO_PCI

2020-09-03 Thread Auger Eric
Eduardo, On 9/3/20 12:43 AM, Eduardo Habkost wrote: > Make the type checking macro name consistent with the TYPE_* > constant. > > Signed-off-by: Eduardo Habkost Reviewed-by: Eric Auger Thanks Eric > --- > Cc: Alex Williamson > Cc: qemu-devel@nongnu.org > --- > hw/vfio/pci.h | 2 +- > hw/v

Re: [PATCH v2 05/15] fuzz: Declare DMA Read callback function

2020-09-03 Thread Darren Kenny
On Wednesday, 2020-08-19 at 02:11:00 -04, Alexander Bulekov wrote: > This patch declares the fuzz_dma_read_cb function and uses the > preprocessor and linker(weak symbols) to handle these cases: > > When we build softmmu/all with --enable-fuzzing, there should be no > strong symbol defined for fuzz

Re: [PATCH v2 06/15] fuzz: Add fuzzer callbacks to DMA-read functions

2020-09-03 Thread Darren Kenny
On Wednesday, 2020-08-19 at 02:11:01 -04, Alexander Bulekov wrote: > We should be careful to not call any functions besides fuzz_dma_read_cb. > Without --enable-fuzzing, fuzz_dma_read_cb is an empty inlined function. > > Signed-off-by: Alexander Bulekov Reviewed-by: Darren Kenny > --- > exec.c

Re: [PATCH v2 08/15] fuzz: add a DISABLE_PCI op to general-fuzzer

2020-09-03 Thread Darren Kenny
On Wednesday, 2020-08-19 at 02:11:03 -04, Alexander Bulekov wrote: > This new operation is used in the next commit, which concatenates two > fuzzer-generated inputs. With this operation, we can prevent the second > input from clobbering the PCI configuration performed by the first. > > Signed-off-b

Re: [PATCH v2 07/15] fuzz: Add support for custom crossover functions

2020-09-03 Thread Darren Kenny
On Wednesday, 2020-08-19 at 02:11:02 -04, Alexander Bulekov wrote: > libfuzzer supports a "custom crossover function". Libfuzzer often tries > to blend two inputs to create a new interesting input. Sometimes, we > have a better idea about how to blend inputs together. This change > allows fuzzers t

Re: [PATCH v5 1/8] monitor: simplify functions for getting a dup'd fdset entry

2020-09-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > Currently code has to call monitor_fdset_get_fd, then dup > the return fd, and then add the duplicate FD back into the > fdset. This dance is overly verbose for the caller and > introduces extra failure modes which can be avoided by > folding all the logic into monito

Re: [PATCH v5 2/8] util: split off a helper for dealing with O_CLOEXEC flag

2020-09-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > We're going to have multiple callers to open() from qemu_open() > soon. Readability would thus benefit from having a helper for > dealing with O_CLOEXEC. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Markus Armbruster

Re: [PATCH v5 3/8] util: rename qemu_open() to qemu_open_old()

2020-09-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > We want to introduce a new version of qemu_open() that uses an Error > object for reporting problems and make this it the preferred interface. > Rename the existing method to release the namespace for the new impl. > > Reviewed-by: Eric Blake > Reviewed-by: Philippe

Re: [PATCH v5 4/8] util: refactor qemu_open_old to split off variadic args handling

2020-09-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > This simple refactoring prepares for future patches. The variadic args > handling is split from the main bulk of the open logic. The duplicated > calls to open() are removed in favour of updating the "flags" variable > to have O_CLOEXEC. Drop the second sentence, it

Re: [PATCH v5 5/8] util: add Error object for qemu_open_internal error reporting

2020-09-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > Instead of relying on the limited information from errno, we can now > also provide detailed error messages to callers that ask for it. > > Signed-off-by: Daniel P. Berrangé > --- > util/osdep.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-)

Re: [PATCH v2 09/15] fuzz: add a crossover function to generic-fuzzer

2020-09-03 Thread Darren Kenny
On Wednesday, 2020-08-19 at 02:11:04 -04, Alexander Bulekov wrote: > Signed-off-by: Alexander Bulekov > --- > tests/qtest/fuzz/general_fuzz.c | 81 - > 1 file changed, 80 insertions(+), 1 deletion(-) > > diff --git a/tests/qtest/fuzz/general_fuzz.c b/tests/qtest/fu

Re: [PATCH v2 10/15] scripts/oss-fuzz: Add wrapper program for generic fuzzer

2020-09-03 Thread Darren Kenny
On Wednesday, 2020-08-19 at 02:11:05 -04, Alexander Bulekov wrote: > On oss-fuzz we need some sort of wrapper to specify command-line > arguments or environment variables. When we had a similar problem with > other targets that I fixed with > 05509c8e6d ("fuzz: select fuzz target using executable n

Re: [PATCH v2 10/15] scripts/oss-fuzz: Add wrapper program for generic fuzzer

2020-09-03 Thread Darren Kenny
Just thinking after reading later code, that maybe this should be renamed to something like target.c.tmpl, target_template.c, or similar so that it is clearer that this is not used directly, but as a template for generation of other targets. Thanks, Darren. On Wednesday, 2020-08-19 at 02:11:05

Re: [PATCH v2 11/15] scripts/oss-fuzz: Add general-fuzzer build script

2020-09-03 Thread Darren Kenny
On Wednesday, 2020-08-19 at 02:11:06 -04, Alexander Bulekov wrote: > This parses a yaml file containing general-fuzzer configs and builds a > separate oss-fuzz wrapper binary for each one, changing some > preprocessor macros for each configuration. To avoid dealing with > escaping and stringifying,

Re: [PATCH v2 13/15] scripts/oss-fuzz: build the general-fuzzer configs

2020-09-03 Thread Darren Kenny
On Wednesday, 2020-08-19 at 02:11:08 -04, Alexander Bulekov wrote: > Build general-fuzzer wrappers for each configuration defined in > general_fuzzer_configs.yml and move the actual general-fuzzer to a > subdirectory, so oss-fuzz doesn't treat it as a standalone fuzzer. You didn't mention the remo

Re: [PATCH v2 12/15] scripts/oss-fuzz: Add general-fuzzer configs for oss-fuzz

2020-09-03 Thread Darren Kenny
On Wednesday, 2020-08-19 at 02:11:07 -04, Alexander Bulekov wrote: > Each of these entries is built into a wrapper binary that sets the > needed environment variables and executes the general virtual-device > fuzzer. In the future, we will need additional fields, such as arch=arm, > timeout_per_tes

make -i check resut for msys2

2020-09-03 Thread Yonggang Luo
$ make -i check Regenerating build files. Directory does not contain a valid build tree: C:/work/xemu/qemu/build make: [Makefile.ninja:5217:build.ninja] 错误 1 (已忽略) make[1]: 进入目录“/c/work/xemu/qemu/slirp” make[1]: 对“all”无需做任何事。 make[1]: 离开目录“/c/work/xemu/qemu/slirp” Generating qemu-version.h with a m

Re: [PATCH v2 14/15] scripts/oss-fuzz: Add script to reorder a general-fuzzer trace

2020-09-03 Thread Darren Kenny
On Wednesday, 2020-08-19 at 02:11:09 -04, Alexander Bulekov wrote: > The general-fuzzer uses hooks to fulfill DMA requests just-in-time. > This means that if we try to use QTEST_LOG=1 to build a reproducer, the > DMA writes will be logged _after_ the in/out/read/write that triggered > the DMA read.

Re: [PATCH v2 15/15] scripts/oss-fuzz: Add crash trace minimization script

2020-09-03 Thread Darren Kenny
On Wednesday, 2020-08-19 at 02:11:10 -04, Alexander Bulekov wrote: > Once we find a crash, we can convert it into a QTest trace. Usually this > trace will contain many operations that are unneeded to reproduce the > crash. This script tries to minimize the crashing trace, by removing > operations a

Re: [PATCH] 9pfs: log warning if msize <= 8192

2020-09-03 Thread Greg Kurz
On Thu, 03 Sep 2020 10:20:40 +0200 Christian Schoenebeck wrote: > On Mittwoch, 2. September 2020 18:54:22 CEST Greg Kurz wrote: > > > Well, I can do that of course. But somehow I fear users get lost by just > > > pointing them to "man 1 qemu" in the log message. It already starts that > > > e.g.

Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands

2020-09-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Sep 02, 2020 at 11:27:17AM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Tue, Sep 01, 2020 at 04:20:47PM +0200, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > savevm, loadvm and delvm are some of the few

[Bug 1894071] [NEW] qemu-i386-static ioctl return -14 (Bad Address)

2020-09-03 Thread Tony.LI
Public bug reported: I use qemu-i386-static on 64 bit ARM.But I don't know how to solve some problems. First I added some ioctl operations. Then I tried to do some DRM operations like test.c. This is successful when I use qemu-x86_64-static,but it failed when I use qemu-i386-static. I can get so

[Bug 1894071] Re: qemu-i386-static ioctl return -14 (Bad Address)

2020-09-03 Thread Tony.LI
** Attachment added: "syscall_types.h" https://bugs.launchpad.net/qemu/+bug/1894071/+attachment/5407370/+files/syscall_types.h -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1894071 Title: qemu-

[Bug 1894071] Re: qemu-i386-static ioctl return -14 (Bad Address)

2020-09-03 Thread Tony.LI
** Attachment added: "syscall_defs.h" https://bugs.launchpad.net/qemu/+bug/1894071/+attachment/5407369/+files/syscall_defs.h -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1894071 Title: qemu-i3

[Bug 1894071] Re: qemu-i386-static ioctl return -14 (Bad Address)

2020-09-03 Thread Tony.LI
This problem has bothered me for a long time, but I'm not sure whether it's the IOCTL () I added or the QEMU with 32 bits. I hope we can discuss it and help our friends who have other problems. Thank you,my friends! -- You received this bug notification because you are a member of qemu- devel-ml

[Bug 1894071] Re: qemu-i386-static ioctl return -14 (Bad Address)

2020-09-03 Thread Tony.LI
** Attachment added: "ioctls.h" https://bugs.launchpad.net/qemu/+bug/1894071/+attachment/5407368/+files/ioctls.h -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1894071 Title: qemu-i386-static io

[Bug 1894071] Re: qemu-i386-static ioctl return -14 (Bad Address)

2020-09-03 Thread Tony.LI
** Attachment added: "modeset.c" https://bugs.launchpad.net/qemu/+bug/1894071/+attachment/5407367/+files/modeset.c -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1894071 Title: qemu-i386-static

[Bug 1894071] Re: qemu-i386-static ioctl return -14 (Bad Address)

2020-09-03 Thread Tony.LI
My environment is that: schroot + debian(bullseye-i386) qemu: 5.1.0-rc3 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1894071 Title: qemu-i386-static ioctl return -14 (Bad Address) Status in QEMU:

Re: [PATCH] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus

2020-09-03 Thread Michael S. Tsirkin
On Sat, Aug 29, 2020 at 01:42:33PM +0530, Ani Sinha wrote: > When ACPI hotplug for the root bus is disabled, the bsel property for that > bus is not set. Please see the following commit: > > 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the > root bus"). > > As a resu

Re: [PATCH] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus

2020-09-03 Thread Ani Sinha
On Sep 3, 2020, 15:35 +0530, Michael S. Tsirkin , wrote: On Sat, Aug 29, 2020 at 01:42:33PM +0530, Ani Sinha wrote: When ACPI hotplug for the root bus is disabled, the bsel property for that bus is not set. Please see the following commit: 3d7e78aaf ("Introduce a new flag for i440fx to di

[Bug 1894071] Re: qemu-i386-static ioctl return -14 (Bad Address)

2020-09-03 Thread Laurent Vivier
Please, send your patches to the QEMU devel mailing list, so we can review them and comment. https://wiki.qemu.org/Contribute/SubmitAPatch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1894071 Title

Re: [PATCH] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus

2020-09-03 Thread Ani Sinha
On Thu, Sep 3, 2020 at 3:41 PM Ani Sinha wrote: > > On Sep 3, 2020, 15:35 +0530, Michael S. Tsirkin , wrote: > > On Sat, Aug 29, 2020 at 01:42:33PM +0530, Ani Sinha wrote: > > When ACPI hotplug for the root bus is disabled, the bsel property for that > > bus is not set. Please see the following co

Re: [RFC v8 3/5] memory: Add IOMMU_DEVIOTLB_UNMAP IOMMUTLBNotificationType

2020-09-03 Thread Eugenio Perez Martin
Hi Eric, On Wed, Sep 2, 2020 at 12:32 PM Auger Eric wrote: > > Hi Eugenio, > > On 9/1/20 4:26 PM, Eugenio Pérez wrote: > > Adapt intel and vhost to use this new notification type > I think you should explain in the commit message what is the benefice to > introduce this new event type. Will do,

Re: [PATCH] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus

2020-09-03 Thread Michael S. Tsirkin
On Thu, Sep 03, 2020 at 03:41:13PM +0530, Ani Sinha wrote: > On Sep 3, 2020, 15:35 +0530, Michael S. Tsirkin , wrote: > > On Sat, Aug 29, 2020 at 01:42:33PM +0530, Ani Sinha wrote: > > When ACPI hotplug for the root bus is disabled, the bsel property for > that > > bu

Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands

2020-09-03 Thread Kevin Wolf
Am 03.09.2020 um 11:48 hat Markus Armbruster geschrieben: > Daniel P. Berrangé writes: > > > On Wed, Sep 02, 2020 at 11:27:17AM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Tue, Sep 01, 2020 at 04:20:47PM +0200, Markus Armbruster wrote: > >> >> Daniel P. Berr

Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands

2020-09-03 Thread Daniel P . Berrangé
On Thu, Sep 03, 2020 at 12:17:29PM +0200, Kevin Wolf wrote: > Am 03.09.2020 um 11:48 hat Markus Armbruster geschrieben: > > If having to map from drive ID to node-name really is too much of a > > burden, we can look for ways to make it easier, or we can make savem > > optionally accept drive IDs in

Re: [RFC qemu 0/6] mirror: implement incremental and bitmap modes

2020-09-03 Thread Fabian Grünbichler
On August 21, 2020 3:03 pm, Max Reitz wrote: > On 18.02.20 11:07, Fabian Grünbichler wrote: > > [Sorry :/] same, I've been meaning to ping/pick this back up but other stuff got in the way. so thanks for the reminder to get this upstream ;) > >> picking up on John's in-progress patch series fro

Re: [PATCH] stubs: Move qemu_fd_register stub to util/main-loop.c

2020-09-03 Thread Thomas Huth
On 03/09/2020 10.24, Daniel P. Berrangé wrote: > On Thu, Sep 03, 2020 at 07:45:03AM +0200, Thomas Huth wrote: >> The linker of MinGW sometimes runs into the following problem: >> >> libqemuutil.a(util_main-loop.c.obj): In function `qemu_fd_register': >> /builds/huth/qemu/build/../util/main-loop.c:3

[PATCH v2] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus

2020-09-03 Thread Ani Sinha
When ACPI hotplug for the root bus is disabled, the bsel property for that bus is not set. Please see the following commit: 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus"). As a result, when acpi_pcihp_find_hotplug_bus() is called with bsel set to 0, it m

Re: [PATCH] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus

2020-09-03 Thread Ani Sinha
On Thu, Sep 3, 2020 at 3:46 PM Michael S. Tsirkin wrote: > > On Thu, Sep 03, 2020 at 03:41:13PM +0530, Ani Sinha wrote: > > On Sep 3, 2020, 15:35 +0530, Michael S. Tsirkin , wrote: > > > > On Sat, Aug 29, 2020 at 01:42:33PM +0530, Ani Sinha wrote: > > > > When ACPI hotplug for the root

  1   2   3   4   5   6   7   >